{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/mentat/pulls/comments/165510460","pull_request_review_id":93464196,"id":165510460,"diff_hunk":"@@ -62,52 +75,61 @@ pub struct TxClient {}\n \n impl TxReader for TxClient {\n     fn all(sqlite: &rusqlite::Connection) -> Result<Vec<Tx>> {\n-        // Make sure a=txInstant rows are first, so that we process\n-        // all transactions before we process any transaction parts.\n         let mut stmt = sqlite.prepare(\n             \"SELECT\n                 e, a, v, tx, added, value_type_tag,\n                 CASE a WHEN :txInstant THEN 1 ELSE 0 END is_transaction","path":"tolstoy/src/tx_client.rs","position":null,"original_position":85,"commit_id":"1e7772b77534fadcb6807b70a888506c0ef84fef","original_commit_id":"1e7772b77534fadcb6807b70a888506c0ef84fef","user":{"login":"rnewman","id":91722,"avatar_url":"https://avatars2.githubusercontent.com/u/91722?v=4","gravatar_id":"","url":"https://api.github.com/users/rnewman","html_url":"https://github.com/rnewman","followers_url":"https://api.github.com/users/rnewman/followers","following_url":"https://api.github.com/users/rnewman/following{/other_user}","gists_url":"https://api.github.com/users/rnewman/gists{/gist_id}","starred_url":"https://api.github.com/users/rnewman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnewman/subscriptions","organizations_url":"https://api.github.com/users/rnewman/orgs","repos_url":"https://api.github.com/users/rnewman/repos","events_url":"https://api.github.com/users/rnewman/events{/privacy}","received_events_url":"https://api.github.com/users/rnewman/received_events","type":"User","site_admin":false},"body":"Strictly speaking this is incorrect: you would need to check:\r\n\r\n* `a` is `:db/txInstant`\r\n* `tx == e`\r\n\r\nBut, as noted below, I think it's better to do this in code.","created_at":"2018-02-01T22:41:20Z","updated_at":"2018-02-01T22:44:11Z","html_url":"https://github.com/mozilla/mentat/pull/542#discussion_r165510460","pull_request_url":"https://api.github.com/repos/mozilla/mentat/pulls/542","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/mentat/pulls/comments/165510460"},"html":{"href":"https://github.com/mozilla/mentat/pull/542#discussion_r165510460"},"pull_request":{"href":"https://api.github.com/repos/mozilla/mentat/pulls/542"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/mentat/pulls/542","id":166631102,"html_url":"https://github.com/mozilla/mentat/pull/542","diff_url":"https://github.com/mozilla/mentat/pull/542.diff","patch_url":"https://github.com/mozilla/mentat/pull/542.patch","issue_url":"https://api.github.com/repos/mozilla/mentat/issues/542","number":542,"state":"open","locked":false,"title":"Local transaction reader","user":{"login":"grigoryk","id":465422,"avatar_url":"https://avatars3.githubusercontent.com/u/465422?v=4","gravatar_id":"","url":"https://api.github.com/users/grigoryk","html_url":"https://github.com/grigoryk","followers_url":"https://api.github.com/users/grigoryk/followers","following_url":"https://api.github.com/users/grigoryk/following{/other_user}","gists_url":"https://api.github.com/users/grigoryk/gists{/gist_id}","starred_url":"https://api.github.com/users/grigoryk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grigoryk/subscriptions","organizations_url":"https://api.github.com/users/grigoryk/orgs","repos_url":"https://api.github.com/users/grigoryk/repos","events_url":"https://api.github.com/users/grigoryk/events{/privacy}","received_events_url":"https://api.github.com/users/grigoryk/received_events","type":"User","site_admin":false},"body":"Fixes #508.\r\n\r\nLocal transaction representation is TBD, but the current approach seems sane to me, matches some mentat internals and maps to our current test server interface.","created_at":"2018-02-01T19:34:49Z","updated_at":"2018-02-01T22:44:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1f8dfdeba79101d5b766da26d3f54ac72e7542e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/mentat/pulls/542/commits","review_comments_url":"https://api.github.com/repos/mozilla/mentat/pulls/542/comments","review_comment_url":"https://api.github.com/repos/mozilla/mentat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/mentat/issues/542/comments","statuses_url":"https://api.github.com/repos/mozilla/mentat/statuses/1e7772b77534fadcb6807b70a888506c0ef84fef","head":{"label":"mozilla:grisha/tolstoy-reader","ref":"grisha/tolstoy-reader","sha":"1e7772b77534fadcb6807b70a888506c0ef84fef","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":62660036,"name":"mentat","full_name":"mozilla/mentat","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/mentat","description":"A persistent, relational store inspired by Datomic and DataScript.","fork":false,"url":"https://api.github.com/repos/mozilla/mentat","forks_url":"https://api.github.com/repos/mozilla/mentat/forks","keys_url":"https://api.github.com/repos/mozilla/mentat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/mentat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/mentat/teams","hooks_url":"https://api.github.com/repos/mozilla/mentat/hooks","issue_events_url":"https://api.github.com/repos/mozilla/mentat/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/mentat/events","assignees_url":"https://api.github.com/repos/mozilla/mentat/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/mentat/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/mentat/tags","blobs_url":"https://api.github.com/repos/mozilla/mentat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/mentat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/mentat/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/mentat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/mentat/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/mentat/languages","stargazers_url":"https://api.github.com/repos/mozilla/mentat/stargazers","contributors_url":"https://api.github.com/repos/mozilla/mentat/contributors","subscribers_url":"https://api.github.com/repos/mozilla/mentat/subscribers","subscription_url":"https://api.github.com/repos/mozilla/mentat/subscription","commits_url":"https://api.github.com/repos/mozilla/mentat/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/mentat/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/mentat/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/mentat/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/mentat/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/mentat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/mentat/merges","archive_url":"https://api.github.com/repos/mozilla/mentat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/mentat/downloads","issues_url":"https://api.github.com/repos/mozilla/mentat/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/mentat/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/mentat/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/mentat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/mentat/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/mentat/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/mentat/deployments","created_at":"2016-07-05T18:29:34Z","updated_at":"2018-01-31T02:31:44Z","pushed_at":"2018-02-01T22:33:21Z","git_url":"git://github.com/mozilla/mentat.git","ssh_url":"git@github.com:mozilla/mentat.git","clone_url":"https://github.com/mozilla/mentat.git","svn_url":"https://github.com/mozilla/mentat","homepage":null,"size":2048,"stargazers_count":889,"watchers_count":889,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":154,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":40,"open_issues":154,"watchers":889,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"66e6fef75ea65abd5e4c178f07022334324cebbe","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":62660036,"name":"mentat","full_name":"mozilla/mentat","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/mentat","description":"A persistent, relational store inspired by Datomic and DataScript.","fork":false,"url":"https://api.github.com/repos/mozilla/mentat","forks_url":"https://api.github.com/repos/mozilla/mentat/forks","keys_url":"https://api.github.com/repos/mozilla/mentat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/mentat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/mentat/teams","hooks_url":"https://api.github.com/repos/mozilla/mentat/hooks","issue_events_url":"https://api.github.com/repos/mozilla/mentat/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/mentat/events","assignees_url":"https://api.github.com/repos/mozilla/mentat/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/mentat/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/mentat/tags","blobs_url":"https://api.github.com/repos/mozilla/mentat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/mentat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/mentat/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/mentat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/mentat/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/mentat/languages","stargazers_url":"https://api.github.com/repos/mozilla/mentat/stargazers","contributors_url":"https://api.github.com/repos/mozilla/mentat/contributors","subscribers_url":"https://api.github.com/repos/mozilla/mentat/subscribers","subscription_url":"https://api.github.com/repos/mozilla/mentat/subscription","commits_url":"https://api.github.com/repos/mozilla/mentat/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/mentat/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/mentat/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/mentat/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/mentat/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/mentat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/mentat/merges","archive_url":"https://api.github.com/repos/mozilla/mentat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/mentat/downloads","issues_url":"https://api.github.com/repos/mozilla/mentat/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/mentat/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/mentat/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/mentat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/mentat/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/mentat/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/mentat/deployments","created_at":"2016-07-05T18:29:34Z","updated_at":"2018-01-31T02:31:44Z","pushed_at":"2018-02-01T22:33:21Z","git_url":"git://github.com/mozilla/mentat.git","ssh_url":"git@github.com:mozilla/mentat.git","clone_url":"https://github.com/mozilla/mentat.git","svn_url":"https://github.com/mozilla/mentat","homepage":null,"size":2048,"stargazers_count":889,"watchers_count":889,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":154,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":40,"open_issues":154,"watchers":889,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/mentat/pulls/542"},"html":{"href":"https://github.com/mozilla/mentat/pull/542"},"issue":{"href":"https://api.github.com/repos/mozilla/mentat/issues/542"},"comments":{"href":"https://api.github.com/repos/mozilla/mentat/issues/542/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/mentat/pulls/542/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/mentat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/mentat/pulls/542/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/mentat/statuses/1e7772b77534fadcb6807b70a888506c0ef84fef"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rnewman"}}