{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/22528","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22528/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22528/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22528/events","html_url":"https://github.com/cms-sw/cmssw/pull/22528","id":303446691,"number":22528,"title":"[10.1.X] Migrate SiStripQualityStatistics configuration to be a DQMEDAnalyzer","user":{"login":"mmusich","id":5082376,"avatar_url":"https://avatars1.githubusercontent.com/u/5082376?v=4","gravatar_id":"","url":"https://api.github.com/users/mmusich","html_url":"https://github.com/mmusich","followers_url":"https://api.github.com/users/mmusich/followers","following_url":"https://api.github.com/users/mmusich/following{/other_user}","gists_url":"https://api.github.com/users/mmusich/gists{/gist_id}","starred_url":"https://api.github.com/users/mmusich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmusich/subscriptions","organizations_url":"https://api.github.com/users/mmusich/orgs","repos_url":"https://api.github.com/users/mmusich/repos","events_url":"https://api.github.com/users/mmusich/events{/privacy}","received_events_url":"https://api.github.com/users/mmusich/received_events","type":"User","site_admin":false},"labels":[{"id":52881463,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/alca-pending","name":"alca-pending","color":"fbca04","default":false},{"id":290514703,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/bug-fix","name":"bug-fix","color":"b8860b","default":false},{"id":673935047,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"009800","default":false},{"id":88645479,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800","default":false},{"id":52882241,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-approved","name":"dqm-approved","color":"009800","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":56131195,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/73","html_url":"https://github.com/cms-sw/cmssw/milestone/73","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/73/labels","id":3060828,"number":73,"title":"CMSSW_10_1_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":83,"closed_issues":449,"state":"open","created_at":"2018-01-24T11:24:59Z","updated_at":"2018-03-13T14:21:03Z","due_on":null,"closed_at":null},"comments":19,"created_at":"2018-03-08T11:25:27Z","updated_at":"2018-03-13T14:38:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/22528","html_url":"https://github.com/cms-sw/cmssw/pull/22528","diff_url":"https://github.com/cms-sw/cmssw/pull/22528.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/22528.patch"},"body":"As foreseen in https://github.com/cms-sw/cmssw/pull/22134#issuecomment-366654833, since in #22134 `SiStripQualityStatistics` has been migrated to be a `DQMEDAnalyzer` in lieu of a `edm::EDAnalyzer ` the current configuration declaration all over CMSSW won't work anymore (after #22319),  due to a Framework type mismatch: \r\n```\r\n----- Begin Fatal Exception 08-Mar-2018 12:12:51 CET-----------------------\r\nAn exception of category 'Configuration' occurred while\r\n   [0] Constructing the EventProcessor\r\n   [1] Validating configuration of module: class=SiStripQualityStatistics label='stat'\r\nException Message:\r\nThe base type in the python configuration is EDAnalyzer, but the base type\r\nfor the module's C++ class is EDProducer. Please fix the configuration.\r\nIt must use the same base type as the C++ class.\r\n----- End Fatal Exception -------------------------------------------------\r\n\r\n```\r\nI profit of this PR to add a unit test for the `SiStripQualityStatistics`  that shall help us to catch misbehaviors in time."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/372687930","html_url":"https://github.com/cms-sw/cmssw/pull/22528#issuecomment-372687930","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/22528","id":372687930,"user":{"login":"arunhep","id":4729040,"avatar_url":"https://avatars3.githubusercontent.com/u/4729040?v=4","gravatar_id":"","url":"https://api.github.com/users/arunhep","html_url":"https://github.com/arunhep","followers_url":"https://api.github.com/users/arunhep/followers","following_url":"https://api.github.com/users/arunhep/following{/other_user}","gists_url":"https://api.github.com/users/arunhep/gists{/gist_id}","starred_url":"https://api.github.com/users/arunhep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arunhep/subscriptions","organizations_url":"https://api.github.com/users/arunhep/orgs","repos_url":"https://api.github.com/users/arunhep/repos","events_url":"https://api.github.com/users/arunhep/events{/privacy}","received_events_url":"https://api.github.com/users/arunhep/received_events","type":"User","site_admin":false},"created_at":"2018-03-13T14:38:32Z","updated_at":"2018-03-13T14:38:32Z","author_association":"CONTRIBUTOR","body":"+1"}}
{"actor":{"display_login":"arunhep"}}