{"action":"created","comment":{"url":"https://api.github.com/repos/criticalstack/libevhtp/pulls/comments/181595887","pull_request_review_id":106904959,"id":181595887,"diff_hunk":"@@ -189,14 +199,6 @@ target_include_directories(evhtp PUBLIC\n     $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>\n )\n \n-if(BUILD_SHARED_LIBS)\n-    set_target_properties(evhtp PROPERTIES\n-        VERSION \"${PROJECT_VERSION}\"\n-        SOVERSION 0\n-        OUTPUT_NAME \"evhtp\"\n-        C_VISIBILITY_PRESET hidden)\n-endif()","path":"CMakeLists.txt","position":31,"original_position":31,"commit_id":"79c8c2b84e7db9b541aa67435df4747d91ad2402","original_commit_id":"79c8c2b84e7db9b541aa67435df4747d91ad2402","user":{"login":"NathanFrench","id":28454863,"avatar_url":"https://avatars3.githubusercontent.com/u/28454863?v=4","gravatar_id":"","url":"https://api.github.com/users/NathanFrench","html_url":"https://github.com/NathanFrench","followers_url":"https://api.github.com/users/NathanFrench/followers","following_url":"https://api.github.com/users/NathanFrench/following{/other_user}","gists_url":"https://api.github.com/users/NathanFrench/gists{/gist_id}","starred_url":"https://api.github.com/users/NathanFrench/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NathanFrench/subscriptions","organizations_url":"https://api.github.com/users/NathanFrench/orgs","repos_url":"https://api.github.com/users/NathanFrench/repos","events_url":"https://api.github.com/users/NathanFrench/events{/privacy}","received_events_url":"https://api.github.com/users/NathanFrench/received_events","type":"User","site_admin":false},"body":"This is just about the same thing as the Hunter devs did; I don't see a really good reason why to remove this version.","created_at":"2018-04-15T20:28:58Z","updated_at":"2018-04-15T20:58:50Z","html_url":"https://github.com/criticalstack/libevhtp/pull/83#discussion_r181595887","pull_request_url":"https://api.github.com/repos/criticalstack/libevhtp/pulls/83","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/criticalstack/libevhtp/pulls/comments/181595887"},"html":{"href":"https://github.com/criticalstack/libevhtp/pull/83#discussion_r181595887"},"pull_request":{"href":"https://api.github.com/repos/criticalstack/libevhtp/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/criticalstack/libevhtp/pulls/83","id":177258410,"html_url":"https://github.com/criticalstack/libevhtp/pull/83","diff_url":"https://github.com/criticalstack/libevhtp/pull/83.diff","patch_url":"https://github.com/criticalstack/libevhtp/pull/83.patch","issue_url":"https://api.github.com/repos/criticalstack/libevhtp/issues/83","number":83,"state":"open","locked":false,"title":"add evhtp_set_max_headers_size & fix can't build shard library","user":{"login":"mlkt","id":10374085,"avatar_url":"https://avatars2.githubusercontent.com/u/10374085?v=4","gravatar_id":"","url":"https://api.github.com/users/mlkt","html_url":"https://github.com/mlkt","followers_url":"https://api.github.com/users/mlkt/followers","following_url":"https://api.github.com/users/mlkt/following{/other_user}","gists_url":"https://api.github.com/users/mlkt/gists{/gist_id}","starred_url":"https://api.github.com/users/mlkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlkt/subscriptions","organizations_url":"https://api.github.com/users/mlkt/orgs","repos_url":"https://api.github.com/users/mlkt/repos","events_url":"https://api.github.com/users/mlkt/events{/privacy}","received_events_url":"https://api.github.com/users/mlkt/received_events","type":"User","site_admin":false},"body":"1.add evhtp_set_max_headers_size() etc.\r\n2.fix can't build shard library.","created_at":"2018-03-24T20:55:21Z","updated_at":"2018-04-15T20:58:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f7f91f20da400b2723ae681d98e0cf29906044f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/criticalstack/libevhtp/pulls/83/commits","review_comments_url":"https://api.github.com/repos/criticalstack/libevhtp/pulls/83/comments","review_comment_url":"https://api.github.com/repos/criticalstack/libevhtp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/criticalstack/libevhtp/issues/83/comments","statuses_url":"https://api.github.com/repos/criticalstack/libevhtp/statuses/79c8c2b84e7db9b541aa67435df4747d91ad2402","head":{"label":"mlkt:develop","ref":"develop","sha":"79c8c2b84e7db9b541aa67435df4747d91ad2402","user":{"login":"mlkt","id":10374085,"avatar_url":"https://avatars2.githubusercontent.com/u/10374085?v=4","gravatar_id":"","url":"https://api.github.com/users/mlkt","html_url":"https://github.com/mlkt","followers_url":"https://api.github.com/users/mlkt/followers","following_url":"https://api.github.com/users/mlkt/following{/other_user}","gists_url":"https://api.github.com/users/mlkt/gists{/gist_id}","starred_url":"https://api.github.com/users/mlkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlkt/subscriptions","organizations_url":"https://api.github.com/users/mlkt/orgs","repos_url":"https://api.github.com/users/mlkt/repos","events_url":"https://api.github.com/users/mlkt/events{/privacy}","received_events_url":"https://api.github.com/users/mlkt/received_events","type":"User","site_admin":false},"repo":{"id":126619719,"name":"libevhtp","full_name":"mlkt/libevhtp","owner":{"login":"mlkt","id":10374085,"avatar_url":"https://avatars2.githubusercontent.com/u/10374085?v=4","gravatar_id":"","url":"https://api.github.com/users/mlkt","html_url":"https://github.com/mlkt","followers_url":"https://api.github.com/users/mlkt/followers","following_url":"https://api.github.com/users/mlkt/following{/other_user}","gists_url":"https://api.github.com/users/mlkt/gists{/gist_id}","starred_url":"https://api.github.com/users/mlkt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlkt/subscriptions","organizations_url":"https://api.github.com/users/mlkt/orgs","repos_url":"https://api.github.com/users/mlkt/repos","events_url":"https://api.github.com/users/mlkt/events{/privacy}","received_events_url":"https://api.github.com/users/mlkt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlkt/libevhtp","description":"Create extremely-fast and secure embedded HTTP servers with ease.","fork":true,"url":"https://api.github.com/repos/mlkt/libevhtp","forks_url":"https://api.github.com/repos/mlkt/libevhtp/forks","keys_url":"https://api.github.com/repos/mlkt/libevhtp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlkt/libevhtp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlkt/libevhtp/teams","hooks_url":"https://api.github.com/repos/mlkt/libevhtp/hooks","issue_events_url":"https://api.github.com/repos/mlkt/libevhtp/issues/events{/number}","events_url":"https://api.github.com/repos/mlkt/libevhtp/events","assignees_url":"https://api.github.com/repos/mlkt/libevhtp/assignees{/user}","branches_url":"https://api.github.com/repos/mlkt/libevhtp/branches{/branch}","tags_url":"https://api.github.com/repos/mlkt/libevhtp/tags","blobs_url":"https://api.github.com/repos/mlkt/libevhtp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlkt/libevhtp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlkt/libevhtp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlkt/libevhtp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlkt/libevhtp/statuses/{sha}","languages_url":"https://api.github.com/repos/mlkt/libevhtp/languages","stargazers_url":"https://api.github.com/repos/mlkt/libevhtp/stargazers","contributors_url":"https://api.github.com/repos/mlkt/libevhtp/contributors","subscribers_url":"https://api.github.com/repos/mlkt/libevhtp/subscribers","subscription_url":"https://api.github.com/repos/mlkt/libevhtp/subscription","commits_url":"https://api.github.com/repos/mlkt/libevhtp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlkt/libevhtp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlkt/libevhtp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlkt/libevhtp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlkt/libevhtp/contents/{+path}","compare_url":"https://api.github.com/repos/mlkt/libevhtp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlkt/libevhtp/merges","archive_url":"https://api.github.com/repos/mlkt/libevhtp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlkt/libevhtp/downloads","issues_url":"https://api.github.com/repos/mlkt/libevhtp/issues{/number}","pulls_url":"https://api.github.com/repos/mlkt/libevhtp/pulls{/number}","milestones_url":"https://api.github.com/repos/mlkt/libevhtp/milestones{/number}","notifications_url":"https://api.github.com/repos/mlkt/libevhtp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlkt/libevhtp/labels{/name}","releases_url":"https://api.github.com/repos/mlkt/libevhtp/releases{/id}","deployments_url":"https://api.github.com/repos/mlkt/libevhtp/deployments","created_at":"2018-03-24T16:44:59Z","updated_at":"2018-03-24T20:48:24Z","pushed_at":"2018-03-24T20:48:22Z","git_url":"git://github.com/mlkt/libevhtp.git","ssh_url":"git@github.com:mlkt/libevhtp.git","clone_url":"https://github.com/mlkt/libevhtp.git","svn_url":"https://github.com/mlkt/libevhtp","homepage":"https://criticalstack.com/","size":2648,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"criticalstack:develop","ref":"develop","sha":"f18f946e7165931eee26111163cc3489b46e260e","user":{"login":"criticalstack","id":8117815,"avatar_url":"https://avatars0.githubusercontent.com/u/8117815?v=4","gravatar_id":"","url":"https://api.github.com/users/criticalstack","html_url":"https://github.com/criticalstack","followers_url":"https://api.github.com/users/criticalstack/followers","following_url":"https://api.github.com/users/criticalstack/following{/other_user}","gists_url":"https://api.github.com/users/criticalstack/gists{/gist_id}","starred_url":"https://api.github.com/users/criticalstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/criticalstack/subscriptions","organizations_url":"https://api.github.com/users/criticalstack/orgs","repos_url":"https://api.github.com/users/criticalstack/repos","events_url":"https://api.github.com/users/criticalstack/events{/privacy}","received_events_url":"https://api.github.com/users/criticalstack/received_events","type":"Organization","site_admin":false},"repo":{"id":89948865,"name":"libevhtp","full_name":"criticalstack/libevhtp","owner":{"login":"criticalstack","id":8117815,"avatar_url":"https://avatars0.githubusercontent.com/u/8117815?v=4","gravatar_id":"","url":"https://api.github.com/users/criticalstack","html_url":"https://github.com/criticalstack","followers_url":"https://api.github.com/users/criticalstack/followers","following_url":"https://api.github.com/users/criticalstack/following{/other_user}","gists_url":"https://api.github.com/users/criticalstack/gists{/gist_id}","starred_url":"https://api.github.com/users/criticalstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/criticalstack/subscriptions","organizations_url":"https://api.github.com/users/criticalstack/orgs","repos_url":"https://api.github.com/users/criticalstack/repos","events_url":"https://api.github.com/users/criticalstack/events{/privacy}","received_events_url":"https://api.github.com/users/criticalstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/criticalstack/libevhtp","description":"Create extremely-fast and secure embedded HTTP servers with ease.","fork":false,"url":"https://api.github.com/repos/criticalstack/libevhtp","forks_url":"https://api.github.com/repos/criticalstack/libevhtp/forks","keys_url":"https://api.github.com/repos/criticalstack/libevhtp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/criticalstack/libevhtp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/criticalstack/libevhtp/teams","hooks_url":"https://api.github.com/repos/criticalstack/libevhtp/hooks","issue_events_url":"https://api.github.com/repos/criticalstack/libevhtp/issues/events{/number}","events_url":"https://api.github.com/repos/criticalstack/libevhtp/events","assignees_url":"https://api.github.com/repos/criticalstack/libevhtp/assignees{/user}","branches_url":"https://api.github.com/repos/criticalstack/libevhtp/branches{/branch}","tags_url":"https://api.github.com/repos/criticalstack/libevhtp/tags","blobs_url":"https://api.github.com/repos/criticalstack/libevhtp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/criticalstack/libevhtp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/criticalstack/libevhtp/git/refs{/sha}","trees_url":"https://api.github.com/repos/criticalstack/libevhtp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/criticalstack/libevhtp/statuses/{sha}","languages_url":"https://api.github.com/repos/criticalstack/libevhtp/languages","stargazers_url":"https://api.github.com/repos/criticalstack/libevhtp/stargazers","contributors_url":"https://api.github.com/repos/criticalstack/libevhtp/contributors","subscribers_url":"https://api.github.com/repos/criticalstack/libevhtp/subscribers","subscription_url":"https://api.github.com/repos/criticalstack/libevhtp/subscription","commits_url":"https://api.github.com/repos/criticalstack/libevhtp/commits{/sha}","git_commits_url":"https://api.github.com/repos/criticalstack/libevhtp/git/commits{/sha}","comments_url":"https://api.github.com/repos/criticalstack/libevhtp/comments{/number}","issue_comment_url":"https://api.github.com/repos/criticalstack/libevhtp/issues/comments{/number}","contents_url":"https://api.github.com/repos/criticalstack/libevhtp/contents/{+path}","compare_url":"https://api.github.com/repos/criticalstack/libevhtp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/criticalstack/libevhtp/merges","archive_url":"https://api.github.com/repos/criticalstack/libevhtp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/criticalstack/libevhtp/downloads","issues_url":"https://api.github.com/repos/criticalstack/libevhtp/issues{/number}","pulls_url":"https://api.github.com/repos/criticalstack/libevhtp/pulls{/number}","milestones_url":"https://api.github.com/repos/criticalstack/libevhtp/milestones{/number}","notifications_url":"https://api.github.com/repos/criticalstack/libevhtp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/criticalstack/libevhtp/labels{/name}","releases_url":"https://api.github.com/repos/criticalstack/libevhtp/releases{/id}","deployments_url":"https://api.github.com/repos/criticalstack/libevhtp/deployments","created_at":"2017-05-01T18:05:49Z","updated_at":"2018-04-07T02:02:59Z","pushed_at":"2018-04-15T08:25:17Z","git_url":"git://github.com/criticalstack/libevhtp.git","ssh_url":"git@github.com:criticalstack/libevhtp.git","clone_url":"https://github.com/criticalstack/libevhtp.git","svn_url":"https://github.com/criticalstack/libevhtp","homepage":"https://criticalstack.com/","size":2752,"stargazers_count":93,"watchers_count":93,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":54,"open_issues":6,"watchers":93,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/criticalstack/libevhtp/pulls/83"},"html":{"href":"https://github.com/criticalstack/libevhtp/pull/83"},"issue":{"href":"https://api.github.com/repos/criticalstack/libevhtp/issues/83"},"comments":{"href":"https://api.github.com/repos/criticalstack/libevhtp/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/criticalstack/libevhtp/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/criticalstack/libevhtp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/criticalstack/libevhtp/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/criticalstack/libevhtp/statuses/79c8c2b84e7db9b541aa67435df4747d91ad2402"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"NathanFrench"}}