{"action":"created","comment":{"url":"https://api.github.com/repos/earthlab/earthpy/pulls/comments/238432615","pull_request_review_id":180973276,"id":238432615,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODQzMjYxNQ==","diff_hunk":"@@ -63,6 +63,14 @@\n \n \"\"\" Run clip shape tests \"\"\"\n \n+def test_not_gdf():\n+    \"\"\"Test that an error is raised when provided with a non geodataframe","path":"earthpy/tests/test_clip.py","position":5,"original_position":5,"commit_id":"d989ad4e00764f30f2a72f61e162031f20a81faa","original_commit_id":"d989ad4e00764f30f2a72f61e162031f20a81faa","user":{"login":"mbjoseph","id":2664564,"node_id":"MDQ6VXNlcjI2NjQ1NjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2664564?v=4","gravatar_id":"","url":"https://api.github.com/users/mbjoseph","html_url":"https://github.com/mbjoseph","followers_url":"https://api.github.com/users/mbjoseph/followers","following_url":"https://api.github.com/users/mbjoseph/following{/other_user}","gists_url":"https://api.github.com/users/mbjoseph/gists{/gist_id}","starred_url":"https://api.github.com/users/mbjoseph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbjoseph/subscriptions","organizations_url":"https://api.github.com/users/mbjoseph/orgs","repos_url":"https://api.github.com/users/mbjoseph/repos","events_url":"https://api.github.com/users/mbjoseph/events{/privacy}","received_events_url":"https://api.github.com/users/mbjoseph/received_events","type":"User","site_admin":false},"body":"Minor grammar/spelling check for this docstring -- spelling for GeoDataFrame, indefinite article with plural noun (\"a non geodataframe objects\")\r\n\r\n```suggestion\r\n    \"\"\"Non-GeoDataFrame inputs raise attribute errors.\"\"\"\r\n```","created_at":"2018-12-03T20:53:23Z","updated_at":"2018-12-03T20:56:55Z","html_url":"https://github.com/earthlab/earthpy/pull/135#discussion_r238432615","pull_request_url":"https://api.github.com/repos/earthlab/earthpy/pulls/135","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/earthlab/earthpy/pulls/comments/238432615"},"html":{"href":"https://github.com/earthlab/earthpy/pull/135#discussion_r238432615"},"pull_request":{"href":"https://api.github.com/repos/earthlab/earthpy/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/earthlab/earthpy/pulls/135","id":234854039,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0ODU0MDM5","html_url":"https://github.com/earthlab/earthpy/pull/135","diff_url":"https://github.com/earthlab/earthpy/pull/135.diff","patch_url":"https://github.com/earthlab/earthpy/pull/135.patch","issue_url":"https://api.github.com/repos/earthlab/earthpy/issues/135","number":135,"state":"open","locked":false,"title":"[tests] add non gdf tests to clip test file 100% coverage","user":{"login":"lwasser","id":7649194,"node_id":"MDQ6VXNlcjc2NDkxOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7649194?v=4","gravatar_id":"","url":"https://api.github.com/users/lwasser","html_url":"https://github.com/lwasser","followers_url":"https://api.github.com/users/lwasser/followers","following_url":"https://api.github.com/users/lwasser/following{/other_user}","gists_url":"https://api.github.com/users/lwasser/gists{/gist_id}","starred_url":"https://api.github.com/users/lwasser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwasser/subscriptions","organizations_url":"https://api.github.com/users/lwasser/orgs","repos_url":"https://api.github.com/users/lwasser/repos","events_url":"https://api.github.com/users/lwasser/events{/privacy}","received_events_url":"https://api.github.com/users/lwasser/received_events","type":"User","site_admin":false},"body":"This should magically fill the test cov to 100% coverage. added 2 non gdf tests","created_at":"2018-11-30T02:43:29Z","updated_at":"2018-12-03T20:56:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc8448cf6cf3d21e14e0014a42d656c26d5ef360","assignee":null,"assignees":[],"requested_reviewers":[{"login":"joemcglinchy","id":4762214,"node_id":"MDQ6VXNlcjQ3NjIyMTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4762214?v=4","gravatar_id":"","url":"https://api.github.com/users/joemcglinchy","html_url":"https://github.com/joemcglinchy","followers_url":"https://api.github.com/users/joemcglinchy/followers","following_url":"https://api.github.com/users/joemcglinchy/following{/other_user}","gists_url":"https://api.github.com/users/joemcglinchy/gists{/gist_id}","starred_url":"https://api.github.com/users/joemcglinchy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joemcglinchy/subscriptions","organizations_url":"https://api.github.com/users/joemcglinchy/orgs","repos_url":"https://api.github.com/users/joemcglinchy/repos","events_url":"https://api.github.com/users/joemcglinchy/events{/privacy}","received_events_url":"https://api.github.com/users/joemcglinchy/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1100178051,"node_id":"MDU6TGFiZWwxMTAwMTc4MDUx","url":"https://api.github.com/repos/earthlab/earthpy/labels/package%20structure%20&%20testing","name":"package structure & testing","color":"5c15b2","default":false},{"id":1145828724,"node_id":"MDU6TGFiZWwxMTQ1ODI4NzI0","url":"https://api.github.com/repos/earthlab/earthpy/labels/review%20requested","name":"review requested","color":"ed90e6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/earthlab/earthpy/pulls/135/commits","review_comments_url":"https://api.github.com/repos/earthlab/earthpy/pulls/135/comments","review_comment_url":"https://api.github.com/repos/earthlab/earthpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/earthlab/earthpy/issues/135/comments","statuses_url":"https://api.github.com/repos/earthlab/earthpy/statuses/d989ad4e00764f30f2a72f61e162031f20a81faa","head":{"label":"earthlab:test/clip","ref":"test/clip","sha":"d989ad4e00764f30f2a72f61e162031f20a81faa","user":{"login":"earthlab","id":19476722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc2NzIy","avatar_url":"https://avatars3.githubusercontent.com/u/19476722?v=4","gravatar_id":"","url":"https://api.github.com/users/earthlab","html_url":"https://github.com/earthlab","followers_url":"https://api.github.com/users/earthlab/followers","following_url":"https://api.github.com/users/earthlab/following{/other_user}","gists_url":"https://api.github.com/users/earthlab/gists{/gist_id}","starred_url":"https://api.github.com/users/earthlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/earthlab/subscriptions","organizations_url":"https://api.github.com/users/earthlab/orgs","repos_url":"https://api.github.com/users/earthlab/repos","events_url":"https://api.github.com/users/earthlab/events{/privacy}","received_events_url":"https://api.github.com/users/earthlab/received_events","type":"Organization","site_admin":false},"repo":{"id":122149160,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIxNDkxNjA=","name":"earthpy","full_name":"earthlab/earthpy","private":false,"owner":{"login":"earthlab","id":19476722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc2NzIy","avatar_url":"https://avatars3.githubusercontent.com/u/19476722?v=4","gravatar_id":"","url":"https://api.github.com/users/earthlab","html_url":"https://github.com/earthlab","followers_url":"https://api.github.com/users/earthlab/followers","following_url":"https://api.github.com/users/earthlab/following{/other_user}","gists_url":"https://api.github.com/users/earthlab/gists{/gist_id}","starred_url":"https://api.github.com/users/earthlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/earthlab/subscriptions","organizations_url":"https://api.github.com/users/earthlab/orgs","repos_url":"https://api.github.com/users/earthlab/repos","events_url":"https://api.github.com/users/earthlab/events{/privacy}","received_events_url":"https://api.github.com/users/earthlab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/earthlab/earthpy","description":"A package built to support python teaching","fork":false,"url":"https://api.github.com/repos/earthlab/earthpy","forks_url":"https://api.github.com/repos/earthlab/earthpy/forks","keys_url":"https://api.github.com/repos/earthlab/earthpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/earthlab/earthpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/earthlab/earthpy/teams","hooks_url":"https://api.github.com/repos/earthlab/earthpy/hooks","issue_events_url":"https://api.github.com/repos/earthlab/earthpy/issues/events{/number}","events_url":"https://api.github.com/repos/earthlab/earthpy/events","assignees_url":"https://api.github.com/repos/earthlab/earthpy/assignees{/user}","branches_url":"https://api.github.com/repos/earthlab/earthpy/branches{/branch}","tags_url":"https://api.github.com/repos/earthlab/earthpy/tags","blobs_url":"https://api.github.com/repos/earthlab/earthpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/earthlab/earthpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/earthlab/earthpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/earthlab/earthpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/earthlab/earthpy/statuses/{sha}","languages_url":"https://api.github.com/repos/earthlab/earthpy/languages","stargazers_url":"https://api.github.com/repos/earthlab/earthpy/stargazers","contributors_url":"https://api.github.com/repos/earthlab/earthpy/contributors","subscribers_url":"https://api.github.com/repos/earthlab/earthpy/subscribers","subscription_url":"https://api.github.com/repos/earthlab/earthpy/subscription","commits_url":"https://api.github.com/repos/earthlab/earthpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/earthlab/earthpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/earthlab/earthpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/earthlab/earthpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/earthlab/earthpy/contents/{+path}","compare_url":"https://api.github.com/repos/earthlab/earthpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/earthlab/earthpy/merges","archive_url":"https://api.github.com/repos/earthlab/earthpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/earthlab/earthpy/downloads","issues_url":"https://api.github.com/repos/earthlab/earthpy/issues{/number}","pulls_url":"https://api.github.com/repos/earthlab/earthpy/pulls{/number}","milestones_url":"https://api.github.com/repos/earthlab/earthpy/milestones{/number}","notifications_url":"https://api.github.com/repos/earthlab/earthpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/earthlab/earthpy/labels{/name}","releases_url":"https://api.github.com/repos/earthlab/earthpy/releases{/id}","deployments_url":"https://api.github.com/repos/earthlab/earthpy/deployments","created_at":"2018-02-20T03:02:42Z","updated_at":"2018-12-01T20:26:05Z","pushed_at":"2018-12-03T20:37:58Z","git_url":"git://github.com/earthlab/earthpy.git","ssh_url":"git@github.com:earthlab/earthpy.git","clone_url":"https://github.com/earthlab/earthpy.git","svn_url":"https://github.com/earthlab/earthpy","homepage":"https://earthpy.readthedocs.io","size":314,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":20,"license":null,"forks":26,"open_issues":20,"watchers":7,"default_branch":"master"}},"base":{"label":"earthlab:master","ref":"master","sha":"9982864384d81e665f7f0e48ed3d918242598516","user":{"login":"earthlab","id":19476722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc2NzIy","avatar_url":"https://avatars3.githubusercontent.com/u/19476722?v=4","gravatar_id":"","url":"https://api.github.com/users/earthlab","html_url":"https://github.com/earthlab","followers_url":"https://api.github.com/users/earthlab/followers","following_url":"https://api.github.com/users/earthlab/following{/other_user}","gists_url":"https://api.github.com/users/earthlab/gists{/gist_id}","starred_url":"https://api.github.com/users/earthlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/earthlab/subscriptions","organizations_url":"https://api.github.com/users/earthlab/orgs","repos_url":"https://api.github.com/users/earthlab/repos","events_url":"https://api.github.com/users/earthlab/events{/privacy}","received_events_url":"https://api.github.com/users/earthlab/received_events","type":"Organization","site_admin":false},"repo":{"id":122149160,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIxNDkxNjA=","name":"earthpy","full_name":"earthlab/earthpy","private":false,"owner":{"login":"earthlab","id":19476722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc2NzIy","avatar_url":"https://avatars3.githubusercontent.com/u/19476722?v=4","gravatar_id":"","url":"https://api.github.com/users/earthlab","html_url":"https://github.com/earthlab","followers_url":"https://api.github.com/users/earthlab/followers","following_url":"https://api.github.com/users/earthlab/following{/other_user}","gists_url":"https://api.github.com/users/earthlab/gists{/gist_id}","starred_url":"https://api.github.com/users/earthlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/earthlab/subscriptions","organizations_url":"https://api.github.com/users/earthlab/orgs","repos_url":"https://api.github.com/users/earthlab/repos","events_url":"https://api.github.com/users/earthlab/events{/privacy}","received_events_url":"https://api.github.com/users/earthlab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/earthlab/earthpy","description":"A package built to support python teaching","fork":false,"url":"https://api.github.com/repos/earthlab/earthpy","forks_url":"https://api.github.com/repos/earthlab/earthpy/forks","keys_url":"https://api.github.com/repos/earthlab/earthpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/earthlab/earthpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/earthlab/earthpy/teams","hooks_url":"https://api.github.com/repos/earthlab/earthpy/hooks","issue_events_url":"https://api.github.com/repos/earthlab/earthpy/issues/events{/number}","events_url":"https://api.github.com/repos/earthlab/earthpy/events","assignees_url":"https://api.github.com/repos/earthlab/earthpy/assignees{/user}","branches_url":"https://api.github.com/repos/earthlab/earthpy/branches{/branch}","tags_url":"https://api.github.com/repos/earthlab/earthpy/tags","blobs_url":"https://api.github.com/repos/earthlab/earthpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/earthlab/earthpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/earthlab/earthpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/earthlab/earthpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/earthlab/earthpy/statuses/{sha}","languages_url":"https://api.github.com/repos/earthlab/earthpy/languages","stargazers_url":"https://api.github.com/repos/earthlab/earthpy/stargazers","contributors_url":"https://api.github.com/repos/earthlab/earthpy/contributors","subscribers_url":"https://api.github.com/repos/earthlab/earthpy/subscribers","subscription_url":"https://api.github.com/repos/earthlab/earthpy/subscription","commits_url":"https://api.github.com/repos/earthlab/earthpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/earthlab/earthpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/earthlab/earthpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/earthlab/earthpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/earthlab/earthpy/contents/{+path}","compare_url":"https://api.github.com/repos/earthlab/earthpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/earthlab/earthpy/merges","archive_url":"https://api.github.com/repos/earthlab/earthpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/earthlab/earthpy/downloads","issues_url":"https://api.github.com/repos/earthlab/earthpy/issues{/number}","pulls_url":"https://api.github.com/repos/earthlab/earthpy/pulls{/number}","milestones_url":"https://api.github.com/repos/earthlab/earthpy/milestones{/number}","notifications_url":"https://api.github.com/repos/earthlab/earthpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/earthlab/earthpy/labels{/name}","releases_url":"https://api.github.com/repos/earthlab/earthpy/releases{/id}","deployments_url":"https://api.github.com/repos/earthlab/earthpy/deployments","created_at":"2018-02-20T03:02:42Z","updated_at":"2018-12-01T20:26:05Z","pushed_at":"2018-12-03T20:37:58Z","git_url":"git://github.com/earthlab/earthpy.git","ssh_url":"git@github.com:earthlab/earthpy.git","clone_url":"https://github.com/earthlab/earthpy.git","svn_url":"https://github.com/earthlab/earthpy","homepage":"https://earthpy.readthedocs.io","size":314,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":20,"license":null,"forks":26,"open_issues":20,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/earthlab/earthpy/pulls/135"},"html":{"href":"https://github.com/earthlab/earthpy/pull/135"},"issue":{"href":"https://api.github.com/repos/earthlab/earthpy/issues/135"},"comments":{"href":"https://api.github.com/repos/earthlab/earthpy/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/earthlab/earthpy/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/earthlab/earthpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/earthlab/earthpy/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/earthlab/earthpy/statuses/d989ad4e00764f30f2a72f61e162031f20a81faa"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mbjoseph"}}