{"action":"created","comment":{"url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/comments/174944184","pull_request_review_id":104394076,"id":174944184,"diff_hunk":"@@ -4,9 +4,12 @@\n :OUTPUT DROP [0:0]\n :LOGNDROP - [0:0]\n \n+-A INPUT         -m state --state ESTABLISHED -j ACCEPT   -m comment --comment \"Allow traffic back\"\n+\n # Prod ssh connections happen through an authenticated tor hidden service\n # The ssh connection is proxied on the server by the tor client to\n # the ssh dameon listening on the local loopback.\n+-A INPUT -i lo -p tcp --dport 22 -m state --state NEW -j ACCEPT -m comment --comment \"Allow tor connection from local loopback to connect to ssh\"","path":"install_files/ansible-base/roles/restrict-direct-access/templates/rules_v4","position":9,"original_position":9,"commit_id":"f575cd32103ff3b13cb72189e6af69b8481746af","original_commit_id":"d08af69674a3c0aa8d807d6f8ecdc945425b573b","user":{"login":"emkll","id":15223328,"avatar_url":"https://avatars2.githubusercontent.com/u/15223328?v=4","gravatar_id":"","url":"https://api.github.com/users/emkll","html_url":"https://github.com/emkll","followers_url":"https://api.github.com/users/emkll/followers","following_url":"https://api.github.com/users/emkll/following{/other_user}","gists_url":"https://api.github.com/users/emkll/gists{/gist_id}","starred_url":"https://api.github.com/users/emkll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emkll/subscriptions","organizations_url":"https://api.github.com/users/emkll/orgs","repos_url":"https://api.github.com/users/emkll/repos","events_url":"https://api.github.com/users/emkll/events{/privacy}","received_events_url":"https://api.github.com/users/emkll/received_events","type":"User","site_admin":false},"body":"Makes sense as the rule on L115 was removed :)","created_at":"2018-03-15T21:52:32Z","updated_at":"2018-03-15T22:01:32Z","html_url":"https://github.com/freedomofpress/securedrop/pull/3072#discussion_r174944184","pull_request_url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3072","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/comments/174944184"},"html":{"href":"https://github.com/freedomofpress/securedrop/pull/3072#discussion_r174944184"},"pull_request":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3072"}},"in_reply_to_id":172626838},"pull_request":{"url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3072","id":171639851,"html_url":"https://github.com/freedomofpress/securedrop/pull/3072","diff_url":"https://github.com/freedomofpress/securedrop/pull/3072.diff","patch_url":"https://github.com/freedomofpress/securedrop/pull/3072.patch","issue_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3072","number":3072,"state":"open","locked":false,"title":"group and simplify iptables INPUT rules","user":{"login":"singuliere","id":35190819,"avatar_url":"https://avatars0.githubusercontent.com/u/35190819?v=4","gravatar_id":"","url":"https://api.github.com/users/singuliere","html_url":"https://github.com/singuliere","followers_url":"https://api.github.com/users/singuliere/followers","following_url":"https://api.github.com/users/singuliere/following{/other_user}","gists_url":"https://api.github.com/users/singuliere/gists{/gist_id}","starred_url":"https://api.github.com/users/singuliere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singuliere/subscriptions","organizations_url":"https://api.github.com/users/singuliere/orgs","repos_url":"https://api.github.com/users/singuliere/repos","events_url":"https://api.github.com/users/singuliere/events{/privacy}","received_events_url":"https://api.github.com/users/singuliere/received_events","type":"User","site_admin":false},"body":"## Status\r\n\r\nReady for review\r\n\r\n## Description of Changes\r\n\r\nFixes #1236\r\n\r\n## Testing\r\n\r\n\r\n\r\n## Deployment\r\n\r\nAny special considerations for deployment? Consider both:\r\n\r\n1. Upgrading existing production instances.\r\n2. New installs.\r\n\r\n## Checklist\r\n\r\n### If you made changes to the app code:\r\n\r\n- [ ] Unit and functional tests pass on the development VM\r\n\r\n### If you made changes to the system configuration:\r\n\r\n- [ ] [Configuration tests](https://docs.securedrop.org/en/latest/development/testing_configuration_tests.html) pass\r\n\r\n### If you made changes to documentation:\r\n\r\n- [ ] Doc linting passed locally\r\n","created_at":"2018-02-27T11:50:52Z","updated_at":"2018-03-15T22:01:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"51c7a19cd179c7295980faadd320812e873b8676","assignee":null,"assignees":[],"requested_reviewers":[{"login":"conorsch","id":657862,"avatar_url":"https://avatars0.githubusercontent.com/u/657862?v=4","gravatar_id":"","url":"https://api.github.com/users/conorsch","html_url":"https://github.com/conorsch","followers_url":"https://api.github.com/users/conorsch/followers","following_url":"https://api.github.com/users/conorsch/following{/other_user}","gists_url":"https://api.github.com/users/conorsch/gists{/gist_id}","starred_url":"https://api.github.com/users/conorsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conorsch/subscriptions","organizations_url":"https://api.github.com/users/conorsch/orgs","repos_url":"https://api.github.com/users/conorsch/repos","events_url":"https://api.github.com/users/conorsch/events{/privacy}","received_events_url":"https://api.github.com/users/conorsch/received_events","type":"User","site_admin":false},{"login":"msheiny","id":1727935,"avatar_url":"https://avatars0.githubusercontent.com/u/1727935?v=4","gravatar_id":"","url":"https://api.github.com/users/msheiny","html_url":"https://github.com/msheiny","followers_url":"https://api.github.com/users/msheiny/followers","following_url":"https://api.github.com/users/msheiny/following{/other_user}","gists_url":"https://api.github.com/users/msheiny/gists{/gist_id}","starred_url":"https://api.github.com/users/msheiny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msheiny/subscriptions","organizations_url":"https://api.github.com/users/msheiny/orgs","repos_url":"https://api.github.com/users/msheiny/repos","events_url":"https://api.github.com/users/msheiny/events{/privacy}","received_events_url":"https://api.github.com/users/msheiny/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":192539287,"url":"https://api.github.com/repos/freedomofpress/securedrop/labels/ops/deployment","name":"ops/deployment","color":"c7def8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3072/commits","review_comments_url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3072/comments","review_comment_url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3072/comments","statuses_url":"https://api.github.com/repos/freedomofpress/securedrop/statuses/f575cd32103ff3b13cb72189e6af69b8481746af","head":{"label":"singuliere:issue-1236-iptables","ref":"issue-1236-iptables","sha":"f575cd32103ff3b13cb72189e6af69b8481746af","user":{"login":"singuliere","id":35190819,"avatar_url":"https://avatars0.githubusercontent.com/u/35190819?v=4","gravatar_id":"","url":"https://api.github.com/users/singuliere","html_url":"https://github.com/singuliere","followers_url":"https://api.github.com/users/singuliere/followers","following_url":"https://api.github.com/users/singuliere/following{/other_user}","gists_url":"https://api.github.com/users/singuliere/gists{/gist_id}","starred_url":"https://api.github.com/users/singuliere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singuliere/subscriptions","organizations_url":"https://api.github.com/users/singuliere/orgs","repos_url":"https://api.github.com/users/singuliere/repos","events_url":"https://api.github.com/users/singuliere/events{/privacy}","received_events_url":"https://api.github.com/users/singuliere/received_events","type":"User","site_admin":false},"repo":{"id":116559655,"name":"securedrop","full_name":"singuliere/securedrop","owner":{"login":"singuliere","id":35190819,"avatar_url":"https://avatars0.githubusercontent.com/u/35190819?v=4","gravatar_id":"","url":"https://api.github.com/users/singuliere","html_url":"https://github.com/singuliere","followers_url":"https://api.github.com/users/singuliere/followers","following_url":"https://api.github.com/users/singuliere/following{/other_user}","gists_url":"https://api.github.com/users/singuliere/gists{/gist_id}","starred_url":"https://api.github.com/users/singuliere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singuliere/subscriptions","organizations_url":"https://api.github.com/users/singuliere/orgs","repos_url":"https://api.github.com/users/singuliere/repos","events_url":"https://api.github.com/users/singuliere/events{/privacy}","received_events_url":"https://api.github.com/users/singuliere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/singuliere/securedrop","description":"GitHub repository for the SecureDrop whistleblower platform. Do not submit tips here!","fork":true,"url":"https://api.github.com/repos/singuliere/securedrop","forks_url":"https://api.github.com/repos/singuliere/securedrop/forks","keys_url":"https://api.github.com/repos/singuliere/securedrop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/singuliere/securedrop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/singuliere/securedrop/teams","hooks_url":"https://api.github.com/repos/singuliere/securedrop/hooks","issue_events_url":"https://api.github.com/repos/singuliere/securedrop/issues/events{/number}","events_url":"https://api.github.com/repos/singuliere/securedrop/events","assignees_url":"https://api.github.com/repos/singuliere/securedrop/assignees{/user}","branches_url":"https://api.github.com/repos/singuliere/securedrop/branches{/branch}","tags_url":"https://api.github.com/repos/singuliere/securedrop/tags","blobs_url":"https://api.github.com/repos/singuliere/securedrop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/singuliere/securedrop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/singuliere/securedrop/git/refs{/sha}","trees_url":"https://api.github.com/repos/singuliere/securedrop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/singuliere/securedrop/statuses/{sha}","languages_url":"https://api.github.com/repos/singuliere/securedrop/languages","stargazers_url":"https://api.github.com/repos/singuliere/securedrop/stargazers","contributors_url":"https://api.github.com/repos/singuliere/securedrop/contributors","subscribers_url":"https://api.github.com/repos/singuliere/securedrop/subscribers","subscription_url":"https://api.github.com/repos/singuliere/securedrop/subscription","commits_url":"https://api.github.com/repos/singuliere/securedrop/commits{/sha}","git_commits_url":"https://api.github.com/repos/singuliere/securedrop/git/commits{/sha}","comments_url":"https://api.github.com/repos/singuliere/securedrop/comments{/number}","issue_comment_url":"https://api.github.com/repos/singuliere/securedrop/issues/comments{/number}","contents_url":"https://api.github.com/repos/singuliere/securedrop/contents/{+path}","compare_url":"https://api.github.com/repos/singuliere/securedrop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/singuliere/securedrop/merges","archive_url":"https://api.github.com/repos/singuliere/securedrop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/singuliere/securedrop/downloads","issues_url":"https://api.github.com/repos/singuliere/securedrop/issues{/number}","pulls_url":"https://api.github.com/repos/singuliere/securedrop/pulls{/number}","milestones_url":"https://api.github.com/repos/singuliere/securedrop/milestones{/number}","notifications_url":"https://api.github.com/repos/singuliere/securedrop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/singuliere/securedrop/labels{/name}","releases_url":"https://api.github.com/repos/singuliere/securedrop/releases{/id}","deployments_url":"https://api.github.com/repos/singuliere/securedrop/deployments","created_at":"2018-01-07T11:25:33Z","updated_at":"2018-01-07T11:25:36Z","pushed_at":"2018-03-15T20:10:32Z","git_url":"git://github.com/singuliere/securedrop.git","ssh_url":"git@github.com:singuliere/securedrop.git","clone_url":"https://github.com/singuliere/securedrop.git","svn_url":"https://github.com/singuliere/securedrop","homepage":"https://securedrop.org/","size":66953,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"freedomofpress:develop","ref":"develop","sha":"2e43c9cfe181e8c0d459a161586b30c3bfa8fce6","user":{"login":"freedomofpress","id":5388147,"avatar_url":"https://avatars1.githubusercontent.com/u/5388147?v=4","gravatar_id":"","url":"https://api.github.com/users/freedomofpress","html_url":"https://github.com/freedomofpress","followers_url":"https://api.github.com/users/freedomofpress/followers","following_url":"https://api.github.com/users/freedomofpress/following{/other_user}","gists_url":"https://api.github.com/users/freedomofpress/gists{/gist_id}","starred_url":"https://api.github.com/users/freedomofpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freedomofpress/subscriptions","organizations_url":"https://api.github.com/users/freedomofpress/orgs","repos_url":"https://api.github.com/users/freedomofpress/repos","events_url":"https://api.github.com/users/freedomofpress/events{/privacy}","received_events_url":"https://api.github.com/users/freedomofpress/received_events","type":"Organization","site_admin":false},"repo":{"id":3156820,"name":"securedrop","full_name":"freedomofpress/securedrop","owner":{"login":"freedomofpress","id":5388147,"avatar_url":"https://avatars1.githubusercontent.com/u/5388147?v=4","gravatar_id":"","url":"https://api.github.com/users/freedomofpress","html_url":"https://github.com/freedomofpress","followers_url":"https://api.github.com/users/freedomofpress/followers","following_url":"https://api.github.com/users/freedomofpress/following{/other_user}","gists_url":"https://api.github.com/users/freedomofpress/gists{/gist_id}","starred_url":"https://api.github.com/users/freedomofpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freedomofpress/subscriptions","organizations_url":"https://api.github.com/users/freedomofpress/orgs","repos_url":"https://api.github.com/users/freedomofpress/repos","events_url":"https://api.github.com/users/freedomofpress/events{/privacy}","received_events_url":"https://api.github.com/users/freedomofpress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freedomofpress/securedrop","description":"GitHub repository for the SecureDrop whistleblower platform. Do not submit tips here!","fork":false,"url":"https://api.github.com/repos/freedomofpress/securedrop","forks_url":"https://api.github.com/repos/freedomofpress/securedrop/forks","keys_url":"https://api.github.com/repos/freedomofpress/securedrop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freedomofpress/securedrop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freedomofpress/securedrop/teams","hooks_url":"https://api.github.com/repos/freedomofpress/securedrop/hooks","issue_events_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/events{/number}","events_url":"https://api.github.com/repos/freedomofpress/securedrop/events","assignees_url":"https://api.github.com/repos/freedomofpress/securedrop/assignees{/user}","branches_url":"https://api.github.com/repos/freedomofpress/securedrop/branches{/branch}","tags_url":"https://api.github.com/repos/freedomofpress/securedrop/tags","blobs_url":"https://api.github.com/repos/freedomofpress/securedrop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freedomofpress/securedrop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freedomofpress/securedrop/git/refs{/sha}","trees_url":"https://api.github.com/repos/freedomofpress/securedrop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freedomofpress/securedrop/statuses/{sha}","languages_url":"https://api.github.com/repos/freedomofpress/securedrop/languages","stargazers_url":"https://api.github.com/repos/freedomofpress/securedrop/stargazers","contributors_url":"https://api.github.com/repos/freedomofpress/securedrop/contributors","subscribers_url":"https://api.github.com/repos/freedomofpress/securedrop/subscribers","subscription_url":"https://api.github.com/repos/freedomofpress/securedrop/subscription","commits_url":"https://api.github.com/repos/freedomofpress/securedrop/commits{/sha}","git_commits_url":"https://api.github.com/repos/freedomofpress/securedrop/git/commits{/sha}","comments_url":"https://api.github.com/repos/freedomofpress/securedrop/comments{/number}","issue_comment_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/comments{/number}","contents_url":"https://api.github.com/repos/freedomofpress/securedrop/contents/{+path}","compare_url":"https://api.github.com/repos/freedomofpress/securedrop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freedomofpress/securedrop/merges","archive_url":"https://api.github.com/repos/freedomofpress/securedrop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freedomofpress/securedrop/downloads","issues_url":"https://api.github.com/repos/freedomofpress/securedrop/issues{/number}","pulls_url":"https://api.github.com/repos/freedomofpress/securedrop/pulls{/number}","milestones_url":"https://api.github.com/repos/freedomofpress/securedrop/milestones{/number}","notifications_url":"https://api.github.com/repos/freedomofpress/securedrop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freedomofpress/securedrop/labels{/name}","releases_url":"https://api.github.com/repos/freedomofpress/securedrop/releases{/id}","deployments_url":"https://api.github.com/repos/freedomofpress/securedrop/deployments","created_at":"2012-01-11T19:57:55Z","updated_at":"2018-03-15T21:20:30Z","pushed_at":"2018-03-15T21:51:12Z","git_url":"git://github.com/freedomofpress/securedrop.git","ssh_url":"git@github.com:freedomofpress/securedrop.git","clone_url":"https://github.com/freedomofpress/securedrop.git","svn_url":"https://github.com/freedomofpress/securedrop","homepage":"https://securedrop.org/","size":67129,"stargazers_count":2358,"watchers_count":2358,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":458,"mirror_url":null,"archived":false,"open_issues_count":341,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":458,"open_issues":341,"watchers":2358,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3072"},"html":{"href":"https://github.com/freedomofpress/securedrop/pull/3072"},"issue":{"href":"https://api.github.com/repos/freedomofpress/securedrop/issues/3072"},"comments":{"href":"https://api.github.com/repos/freedomofpress/securedrop/issues/3072/comments"},"review_comments":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3072/comments"},"review_comment":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3072/commits"},"statuses":{"href":"https://api.github.com/repos/freedomofpress/securedrop/statuses/f575cd32103ff3b13cb72189e6af69b8481746af"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"emkll"}}