{"action":"created","issue":{"url":"https://api.github.com/repos/OpenMS/OpenMS/issues/3274","repository_url":"https://api.github.com/repos/OpenMS/OpenMS","labels_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/3274/labels{/name}","comments_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/3274/comments","events_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/3274/events","html_url":"https://github.com/OpenMS/OpenMS/pull/3274","id":301356836,"number":3274,"title":"[FEATURE] TOPPView: peaks colored by label content","user":{"login":"enetz","id":15832022,"avatar_url":"https://avatars2.githubusercontent.com/u/15832022?v=4","gravatar_id":"","url":"https://api.github.com/users/enetz","html_url":"https://github.com/enetz","followers_url":"https://api.github.com/users/enetz/followers","following_url":"https://api.github.com/users/enetz/following{/other_user}","gists_url":"https://api.github.com/users/enetz/gists{/gist_id}","starred_url":"https://api.github.com/users/enetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enetz/subscriptions","organizations_url":"https://api.github.com/users/enetz/orgs","repos_url":"https://api.github.com/users/enetz/repos","events_url":"https://api.github.com/users/enetz/events{/privacy}","received_events_url":"https://api.github.com/users/enetz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-03-01T10:43:16Z","updated_at":"2018-03-01T16:57:00Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OpenMS/OpenMS/pulls/3274","html_url":"https://github.com/OpenMS/OpenMS/pull/3274","diff_url":"https://github.com/OpenMS/OpenMS/pull/3274.diff","patch_url":"https://github.com/OpenMS/OpenMS/pull/3274.patch"},"body":"Extension of #3007 by @hendrikweisser .\r\n\r\nA new vector for peak colors has been added to LayerData.\r\nPeaks are colored by the colors stored in there, if its length equals the length of the spectrum.\r\nCurrently it is filled by label content, in the same way the colors for the labels were determined.\r\nIn the future we can also use information in DataArrays or other sources to set colors for different kinds of data.\r\n\r\nScreenshot (for Cross-Linking MS data):\r\n![peak_colors](https://user-images.githubusercontent.com/15832022/36840221-83982622-1d44-11e8-85d0-c67eba9f0121.png)\r\n"},"comment":{"url":"https://api.github.com/repos/OpenMS/OpenMS/issues/comments/369657701","html_url":"https://github.com/OpenMS/OpenMS/pull/3274#issuecomment-369657701","issue_url":"https://api.github.com/repos/OpenMS/OpenMS/issues/3274","id":369657701,"user":{"login":"hendrikweisser","id":2251068,"avatar_url":"https://avatars2.githubusercontent.com/u/2251068?v=4","gravatar_id":"","url":"https://api.github.com/users/hendrikweisser","html_url":"https://github.com/hendrikweisser","followers_url":"https://api.github.com/users/hendrikweisser/followers","following_url":"https://api.github.com/users/hendrikweisser/following{/other_user}","gists_url":"https://api.github.com/users/hendrikweisser/gists{/gist_id}","starred_url":"https://api.github.com/users/hendrikweisser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hendrikweisser/subscriptions","organizations_url":"https://api.github.com/users/hendrikweisser/orgs","repos_url":"https://api.github.com/users/hendrikweisser/repos","events_url":"https://api.github.com/users/hendrikweisser/events{/privacy}","received_events_url":"https://api.github.com/users/hendrikweisser/received_events","type":"User","site_admin":false},"created_at":"2018-03-01T16:57:00Z","updated_at":"2018-03-01T16:57:00Z","author_association":"CONTRIBUTOR","body":"@enetz: I don't know if you're already aware, but I wanted to point out that your usage of the arrows in the coverage annotation is a bit non-standard (and may be confusing for people who are used to the standard notation). See this example for what I mean by \"standard notation\": https://www.researchgate.net/profile/Ulrich_Goepfert/publication/229083272/figure/fig3/AS:300749193007108@1448715603476/Fragment-ion-spectra-of-the-HC-T13-peptide-originating-from-the-spiking-antibody-B.png\r\nSo in this notation you have \"angles\" on top and below the sequence corresponding to the b/y ions. Your arrows resemble these angles, but they're read in the opposite direction. For example, for the top-left red arrow in your screenshot (over the second \"L\" of \"LEL\"), the \"standard\" interpretation would be that it denotes a b ion with sequence \"LEL\". I think you could just reverse the direction of your single arrows to move to the \"standard\" notation."}}
{"actor":{"display_login":"hendrikweisser"}}