{"action":"created","issue":{"url":"https://api.github.com/repos/scalableminds/webknossos/issues/3019","repository_url":"https://api.github.com/repos/scalableminds/webknossos","labels_url":"https://api.github.com/repos/scalableminds/webknossos/issues/3019/labels{/name}","comments_url":"https://api.github.com/repos/scalableminds/webknossos/issues/3019/comments","events_url":"https://api.github.com/repos/scalableminds/webknossos/issues/3019/events","html_url":"https://github.com/scalableminds/webknossos/pull/3019","id":348779559,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MDQ5NTY5","number":3019,"title":"Better DOM snapshot diffs","user":{"login":"daniel-wer","id":1702075,"node_id":"MDQ6VXNlcjE3MDIwNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1702075?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-wer","html_url":"https://github.com/daniel-wer","followers_url":"https://api.github.com/users/daniel-wer/followers","following_url":"https://api.github.com/users/daniel-wer/following{/other_user}","gists_url":"https://api.github.com/users/daniel-wer/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-wer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-wer/subscriptions","organizations_url":"https://api.github.com/users/daniel-wer/orgs","repos_url":"https://api.github.com/users/daniel-wer/repos","events_url":"https://api.github.com/users/daniel-wer/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-wer/received_events","type":"User","site_admin":false},"labels":[{"id":318524318,"node_id":"MDU6TGFiZWwzMTg1MjQzMTg=","url":"https://api.github.com/repos/scalableminds/webknossos/labels/testing","name":"testing","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":{"login":"daniel-wer","id":1702075,"node_id":"MDQ6VXNlcjE3MDIwNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1702075?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-wer","html_url":"https://github.com/daniel-wer","followers_url":"https://api.github.com/users/daniel-wer/followers","following_url":"https://api.github.com/users/daniel-wer/following{/other_user}","gists_url":"https://api.github.com/users/daniel-wer/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-wer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-wer/subscriptions","organizations_url":"https://api.github.com/users/daniel-wer/orgs","repos_url":"https://api.github.com/users/daniel-wer/repos","events_url":"https://api.github.com/users/daniel-wer/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-wer/received_events","type":"User","site_admin":false},"assignees":[{"login":"daniel-wer","id":1702075,"node_id":"MDQ6VXNlcjE3MDIwNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1702075?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-wer","html_url":"https://github.com/daniel-wer","followers_url":"https://api.github.com/users/daniel-wer/followers","following_url":"https://api.github.com/users/daniel-wer/following{/other_user}","gists_url":"https://api.github.com/users/daniel-wer/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-wer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-wer/subscriptions","organizations_url":"https://api.github.com/users/daniel-wer/orgs","repos_url":"https://api.github.com/users/daniel-wer/repos","events_url":"https://api.github.com/users/daniel-wer/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-wer/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-08-08T15:33:54Z","updated_at":"2018-08-08T15:59:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/scalableminds/webknossos/pulls/3019","html_url":"https://github.com/scalableminds/webknossos/pull/3019","diff_url":"https://github.com/scalableminds/webknossos/pull/3019.diff","patch_url":"https://github.com/scalableminds/webknossos/pull/3019.patch"},"body":"This PR should make it a lot easier to understand differences in the DOM snapshots generated in our snapshot end-to-end tests. Previously, removing a Spinner caused all elements that were wrapped by that spinner to display as changed, due to the changed indentation level (and changed JSON structure of the snapshot).\r\nNow, the snapshots are saved as multiline HTML strings (which reduces their size from ~58000 lines to ~7000 lines) and, additionally, leading whitespace is removed. The result is that all lines have the same indentation level, but removing said Spinner only causes two line changes (as the indentation level of the wrapped elements is disregarded). It is harder to see the DOM structure in the diff now, but the advantage of having much simpler diffs is worth this imo. One is still able to look at the debug html files (in the `debug-htmls` folder), that contain the indented original DOM structure and which are written to disk during testing as well.\r\n\r\n### Steps to test:\r\n- Successful CI run\r\n- Check out the branch locally, remove a spinner and have a look at the diff result. Unfortunately a lot of unchanged lines are printed by ava as well, but I couldn't find an option to disable that.\r\n\r\n------\r\n- [ ] ~Updated [changelog](../blob/master/CHANGELOG.md#unreleased)~\r\n- [ ] ~Updated [migration guide](../blob/master/MIGRATIONS.md#unreleased) if applicable~\r\n- [x] Ready for review\r\n"},"comment":{"url":"https://api.github.com/repos/scalableminds/webknossos/issues/comments/411458668","html_url":"https://github.com/scalableminds/webknossos/pull/3019#issuecomment-411458668","issue_url":"https://api.github.com/repos/scalableminds/webknossos/issues/3019","id":411458668,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTQ1ODY2OA==","user":{"login":"daniel-wer","id":1702075,"node_id":"MDQ6VXNlcjE3MDIwNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1702075?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-wer","html_url":"https://github.com/daniel-wer","followers_url":"https://api.github.com/users/daniel-wer/followers","following_url":"https://api.github.com/users/daniel-wer/following{/other_user}","gists_url":"https://api.github.com/users/daniel-wer/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-wer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-wer/subscriptions","organizations_url":"https://api.github.com/users/daniel-wer/orgs","repos_url":"https://api.github.com/users/daniel-wer/repos","events_url":"https://api.github.com/users/daniel-wer/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-wer/received_events","type":"User","site_admin":false},"created_at":"2018-08-08T15:59:41Z","updated_at":"2018-08-08T15:59:41Z","author_association":"CONTRIBUTOR","body":"@fm3 Do you have an idea why when executing the e2e-tests through sbt (`val result = \"yarn test-e2e\".run().exitValue()`), the ava output is not colored at all? When executing the yarn command directly, the output is colored as expected. Having the colors would make it easier to spot changed lines when ava outputs a lot (which unfortunately sometimes happens)."}}
{"actor":{"display_login":"daniel-wer"}}