{"action":"created","issue":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/2490","repository_url":"https://api.github.com/repos/BloomBooks/BloomDesktop","labels_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/2490/labels{/name}","comments_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/2490/comments","events_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/2490/events","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/2490","id":331769225,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NDE5NjA2","number":2490,"title":"BL-6055 Save Epub UI settings to meta.json","user":{"login":"gmartin7","id":2300551,"node_id":"MDQ6VXNlcjIzMDA1NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2300551?v=4","gravatar_id":"","url":"https://api.github.com/users/gmartin7","html_url":"https://github.com/gmartin7","followers_url":"https://api.github.com/users/gmartin7/followers","following_url":"https://api.github.com/users/gmartin7/following{/other_user}","gists_url":"https://api.github.com/users/gmartin7/gists{/gist_id}","starred_url":"https://api.github.com/users/gmartin7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmartin7/subscriptions","organizations_url":"https://api.github.com/users/gmartin7/orgs","repos_url":"https://api.github.com/users/gmartin7/repos","events_url":"https://api.github.com/users/gmartin7/events{/privacy}","received_events_url":"https://api.github.com/users/gmartin7/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-06-12T21:59:16Z","updated_at":"2018-06-19T17:18:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/pulls/2490","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/2490","diff_url":"https://github.com/BloomBooks/BloomDesktop/pull/2490.diff","patch_url":"https://github.com/BloomBooks/BloomDesktop/pull/2490.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/bloombooks/bloomdesktop/2490)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/comments/398477424","html_url":"https://github.com/BloomBooks/BloomDesktop/pull/2490#issuecomment-398477424","issue_url":"https://api.github.com/repos/BloomBooks/BloomDesktop/issues/2490","id":398477424,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODQ3NzQyNA==","user":{"login":"andrew-polk","id":5847219,"node_id":"MDQ6VXNlcjU4NDcyMTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5847219?v=4","gravatar_id":"","url":"https://api.github.com/users/andrew-polk","html_url":"https://github.com/andrew-polk","followers_url":"https://api.github.com/users/andrew-polk/followers","following_url":"https://api.github.com/users/andrew-polk/following{/other_user}","gists_url":"https://api.github.com/users/andrew-polk/gists{/gist_id}","starred_url":"https://api.github.com/users/andrew-polk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrew-polk/subscriptions","organizations_url":"https://api.github.com/users/andrew-polk/orgs","repos_url":"https://api.github.com/users/andrew-polk/repos","events_url":"https://api.github.com/users/andrew-polk/events{/privacy}","received_events_url":"https://api.github.com/users/andrew-polk/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T17:18:37Z","updated_at":"2018-06-19T17:18:37Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReviewed 2 of 4 files at r1, 7 of 15 files at r2, 7 of 11 files at r3, 8 of 9 files at r4.\nReview status: all files reviewed, 3 unresolved discussions (waiting on @hatton and @gmartin7)\n\n---\n\n*[src/BloomExe/Book/Book.cs, line 62 at r4](https://reviewable.io/reviews/bloombooks/bloomdesktop/2490#-LFO01Kn6g5Ugnx3iS5Y:-LFO01Ko1mi4k_DA6sui:bj81d62) ([raw file](https://github.com/bloombooks/bloomdesktop/blob/98d5da8b20f02ba4a41f84cbb673e19cab281c89/src/BloomExe/Book/Book.cs#L62)):*\n> ```Smalltalk\n> \t\tpublic Book(BookInfo info = null)\n> \t\t{\n> \t\t\tBookInfo = info; // only for testing!\n> ```\n\nWorth adding a check (at least a debug assert?) to ensure we are running unit tests when calling this constructor?\nPretty sure we have a way to check if we are running unit tests.\n\n---\n\n*[src/BloomExe/web/EnhancedImageServer.cs, line 102 at r4](https://reviewable.io/reviews/bloombooks/bloomdesktop/2490#-LFO1ujHEbCVRZKYX5DL:-LFO1ujI6p4rCTkSmreE:b-7vz74f) ([raw file](https://github.com/bloombooks/bloomdesktop/blob/98d5da8b20f02ba4a41f84cbb673e19cab281c89/src/BloomExe/web/EnhancedImageServer.cs#L102)):*\n> ```Smalltalk\n> \t\t/// Handle enum reads/writes\n> \t\t/// </summary>\n> \t\tpublic void RegisterEnumEndpointHandler<T>(string pattern, Func<ApiRequest, T> readAction, Action<ApiRequest, T> writeAction,\n> ```\n\nDoes this belong in EnhancedImageServer?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/bloombooks/bloomdesktop/2490)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"andrew-polk"}}