{"action":"created","issue":{"url":"https://api.github.com/repos/dedis/cothority/issues/1257","repository_url":"https://api.github.com/repos/dedis/cothority","labels_url":"https://api.github.com/repos/dedis/cothority/issues/1257/labels{/name}","comments_url":"https://api.github.com/repos/dedis/cothority/issues/1257/comments","events_url":"https://api.github.com/repos/dedis/cothority/issues/1257/events","html_url":"https://github.com/dedis/cothority/issues/1257","id":325168810,"number":1257,"title":"Finish adapting java/kyber to go/kyber","user":{"login":"ineiti","id":1545067,"avatar_url":"https://avatars2.githubusercontent.com/u/1545067?v=4","gravatar_id":"","url":"https://api.github.com/users/ineiti","html_url":"https://github.com/ineiti","followers_url":"https://api.github.com/users/ineiti/followers","following_url":"https://api.github.com/users/ineiti/following{/other_user}","gists_url":"https://api.github.com/users/ineiti/gists{/gist_id}","starred_url":"https://api.github.com/users/ineiti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ineiti/subscriptions","organizations_url":"https://api.github.com/users/ineiti/orgs","repos_url":"https://api.github.com/users/ineiti/repos","events_url":"https://api.github.com/users/ineiti/events{/privacy}","received_events_url":"https://api.github.com/users/ineiti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-22T07:19:49Z","updated_at":"2018-05-22T12:44:33Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"There are still some differences in naming and using of the java/kyber library and go/kyber library. Please edit this description to point out differences, so we can do them:\n- no `XOF` in java\n- use same arguments as in go: `point.Mul(scalar, point)` and others\n- add `Point.Zero`, `Scalar.One`, `Point.Base`"},"comment":{"url":"https://api.github.com/repos/dedis/cothority/issues/comments/390976183","html_url":"https://github.com/dedis/cothority/issues/1257#issuecomment-390976183","issue_url":"https://api.github.com/repos/dedis/cothority/issues/1257","id":390976183,"user":{"login":"kc1212","id":1093806,"avatar_url":"https://avatars0.githubusercontent.com/u/1093806?v=4","gravatar_id":"","url":"https://api.github.com/users/kc1212","html_url":"https://github.com/kc1212","followers_url":"https://api.github.com/users/kc1212/followers","following_url":"https://api.github.com/users/kc1212/following{/other_user}","gists_url":"https://api.github.com/users/kc1212/gists{/gist_id}","starred_url":"https://api.github.com/users/kc1212/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kc1212/subscriptions","organizations_url":"https://api.github.com/users/kc1212/orgs","repos_url":"https://api.github.com/users/kc1212/repos","events_url":"https://api.github.com/users/kc1212/events{/privacy}","received_events_url":"https://api.github.com/users/kc1212/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T12:44:33Z","updated_at":"2018-05-22T12:44:33Z","author_association":"CONTRIBUTOR","body":"I was thinking how we can nicely implement the java interface while doing that java lib PR. There is one thing that I think defeats the purpose of using an interface in the current implementation. That is---we use the `Ed25519Point` constructor everywhere. It gives us back an ed25519 point so we're not directly using the point interface anymore, but the actual class methods. As a result, if we change all our `Ed25519Point` to `Point`, a lot of the code will break because there are static methods in `Ed25519Point` like `embed` that are not a part of the interface.\r\n\r\nI propose the following, never use the constructor such as `Ed25519Point` directly. Instead, write something like `public static Point Ed25519Point.New()` for everything that implements the `Point` interface. I further propose we add a very simple `Suite` in there like kyber, it can be a simple one at first. So that we can switch groups easily in the future."}}
{"actor":{"display_login":"kc1212"}}