{"action":"created","comment":{"url":"https://api.github.com/repos/char0n/ramda-adjunct/pulls/comments/168586817","pull_request_review_id":96975415,"id":168586817,"diff_hunk":"@@ -3,19 +3,18 @@ import MAX_SAFE_INTEGER from '../src/internal/polyfills/Number.MAX_SAFE_INTEGER'\n import MIN_SAFE_INTEGER from '../src/internal/polyfills/Number.MIN_SAFE_INTEGER';\n import eq from './shared/eq';\n \n-\n-describe('isNotFloat', function () {\n-  it('tests a value for complement of a `float`', function () {\n+describe('isNotFloat', function() {\n+  it('tests a value for complement of a `float`', function() {\n     eq(RA.isNotFloat(0), true);\n     eq(RA.isNotFloat(1), true);\n     eq(RA.isNotFloat(-100000), true);\n     eq(RA.isNotFloat(MAX_SAFE_INTEGER), true);\n     eq(RA.isNotFloat(MIN_SAFE_INTEGER), true);\n-    eq(RA.isNotFloat(5e+0), true);\n+    eq(RA.isNotFloat(5), true);\n \n     eq(RA.isNotFloat(0.1), false);\n     eq(RA.isNotFloat(Math.PI), false);\n-    eq(RA.isNotFloat(5.56789e+0), false);\n+    eq(RA.isNotFloat(5.56789), false);","path":"test/isNotFloat.js","position":20,"original_position":20,"commit_id":"c6b7e7977f68fd171403c8273a8d250475ff49c0","original_commit_id":"c6b7e7977f68fd171403c8273a8d250475ff49c0","user":{"login":"char0n","id":193286,"avatar_url":"https://avatars1.githubusercontent.com/u/193286?v=4","gravatar_id":"","url":"https://api.github.com/users/char0n","html_url":"https://github.com/char0n","followers_url":"https://api.github.com/users/char0n/followers","following_url":"https://api.github.com/users/char0n/following{/other_user}","gists_url":"https://api.github.com/users/char0n/gists{/gist_id}","starred_url":"https://api.github.com/users/char0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/char0n/subscriptions","organizations_url":"https://api.github.com/users/char0n/orgs","repos_url":"https://api.github.com/users/char0n/repos","events_url":"https://api.github.com/users/char0n/events{/privacy}","received_events_url":"https://api.github.com/users/char0n/received_events","type":"User","site_admin":false},"body":"the scientific notation has been dropped here, but was here by design, can we ignore here ?","created_at":"2018-02-15T19:42:52Z","updated_at":"2018-02-15T19:49:17Z","html_url":"https://github.com/char0n/ramda-adjunct/pull/360#discussion_r168586817","pull_request_url":"https://api.github.com/repos/char0n/ramda-adjunct/pulls/360","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/char0n/ramda-adjunct/pulls/comments/168586817"},"html":{"href":"https://github.com/char0n/ramda-adjunct/pull/360#discussion_r168586817"},"pull_request":{"href":"https://api.github.com/repos/char0n/ramda-adjunct/pulls/360"}}},"pull_request":{"url":"https://api.github.com/repos/char0n/ramda-adjunct/pulls/360","id":168462464,"html_url":"https://github.com/char0n/ramda-adjunct/pull/360","diff_url":"https://github.com/char0n/ramda-adjunct/pull/360.diff","patch_url":"https://github.com/char0n/ramda-adjunct/pull/360.patch","issue_url":"https://api.github.com/repos/char0n/ramda-adjunct/issues/360","number":360,"state":"open","locked":false,"title":"prettier integration POC","user":{"login":"Undistraction","id":161489,"avatar_url":"https://avatars2.githubusercontent.com/u/161489?v=4","gravatar_id":"","url":"https://api.github.com/users/Undistraction","html_url":"https://github.com/Undistraction","followers_url":"https://api.github.com/users/Undistraction/followers","following_url":"https://api.github.com/users/Undistraction/following{/other_user}","gists_url":"https://api.github.com/users/Undistraction/gists{/gist_id}","starred_url":"https://api.github.com/users/Undistraction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Undistraction/subscriptions","organizations_url":"https://api.github.com/users/Undistraction/orgs","repos_url":"https://api.github.com/users/Undistraction/repos","events_url":"https://api.github.com/users/Undistraction/events{/privacy}","received_events_url":"https://api.github.com/users/Undistraction/received_events","type":"User","site_admin":false},"body":"This PR adds prettier and integrates it with eslint. It's for discussion so please take a look. \r\n\r\nI have run it on all files in the `src/` and `test/` dirs. \r\n\r\nPrettier's minimal options are [here](https://prettier.io/docs/en/options.html). I would recommend:\r\n\r\n1. Drop the  'Print Width' to 80.\r\n2. Lose the semi-colons.\r\n3. Use backticks instead of single quotes.\r\n\r\nI have it configured (with VSCode) so it formats on save which I find to be very very useful. It really becomes part of your workflow - you don't need to think about formatting at all. \r\n\r\nI've added it to the `lint` script. It could go into the `lint:fix` script instead, but I think it should happen transparently when linting.\r\n\r\nIt'll take some tweaking to get eslint happy with what prettier does, but I'll hold off doing that for the moment until we decide it's something we want. \r\n\r\ncloses #336 \r\n","created_at":"2018-02-11T16:57:19Z","updated_at":"2018-02-15T19:49:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fa91d67f62c7e368cc3a7935e8a7f9465519f07","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/char0n/ramda-adjunct/pulls/360/commits","review_comments_url":"https://api.github.com/repos/char0n/ramda-adjunct/pulls/360/comments","review_comment_url":"https://api.github.com/repos/char0n/ramda-adjunct/pulls/comments{/number}","comments_url":"https://api.github.com/repos/char0n/ramda-adjunct/issues/360/comments","statuses_url":"https://api.github.com/repos/char0n/ramda-adjunct/statuses/c6b7e7977f68fd171403c8273a8d250475ff49c0","head":{"label":"Undistraction:undistraction/prettier","ref":"undistraction/prettier","sha":"c6b7e7977f68fd171403c8273a8d250475ff49c0","user":{"login":"Undistraction","id":161489,"avatar_url":"https://avatars2.githubusercontent.com/u/161489?v=4","gravatar_id":"","url":"https://api.github.com/users/Undistraction","html_url":"https://github.com/Undistraction","followers_url":"https://api.github.com/users/Undistraction/followers","following_url":"https://api.github.com/users/Undistraction/following{/other_user}","gists_url":"https://api.github.com/users/Undistraction/gists{/gist_id}","starred_url":"https://api.github.com/users/Undistraction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Undistraction/subscriptions","organizations_url":"https://api.github.com/users/Undistraction/orgs","repos_url":"https://api.github.com/users/Undistraction/repos","events_url":"https://api.github.com/users/Undistraction/events{/privacy}","received_events_url":"https://api.github.com/users/Undistraction/received_events","type":"User","site_admin":false},"repo":{"id":114905977,"name":"ramda-adjunct","full_name":"Undistraction/ramda-adjunct","owner":{"login":"Undistraction","id":161489,"avatar_url":"https://avatars2.githubusercontent.com/u/161489?v=4","gravatar_id":"","url":"https://api.github.com/users/Undistraction","html_url":"https://github.com/Undistraction","followers_url":"https://api.github.com/users/Undistraction/followers","following_url":"https://api.github.com/users/Undistraction/following{/other_user}","gists_url":"https://api.github.com/users/Undistraction/gists{/gist_id}","starred_url":"https://api.github.com/users/Undistraction/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Undistraction/subscriptions","organizations_url":"https://api.github.com/users/Undistraction/orgs","repos_url":"https://api.github.com/users/Undistraction/repos","events_url":"https://api.github.com/users/Undistraction/events{/privacy}","received_events_url":"https://api.github.com/users/Undistraction/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Undistraction/ramda-adjunct","description":"Adjunct is a thing added to something else as a supplementary rather than an essential part. And that something is being ramda.","fork":true,"url":"https://api.github.com/repos/Undistraction/ramda-adjunct","forks_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/forks","keys_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/teams","hooks_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/hooks","issue_events_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/issues/events{/number}","events_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/events","assignees_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/assignees{/user}","branches_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/branches{/branch}","tags_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/tags","blobs_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/git/refs{/sha}","trees_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/statuses/{sha}","languages_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/languages","stargazers_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/stargazers","contributors_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/contributors","subscribers_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/subscribers","subscription_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/subscription","commits_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/commits{/sha}","git_commits_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/git/commits{/sha}","comments_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/comments{/number}","issue_comment_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/issues/comments{/number}","contents_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/contents/{+path}","compare_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/merges","archive_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/downloads","issues_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/issues{/number}","pulls_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/pulls{/number}","milestones_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/milestones{/number}","notifications_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/labels{/name}","releases_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/releases{/id}","deployments_url":"https://api.github.com/repos/Undistraction/ramda-adjunct/deployments","created_at":"2017-12-20T16:03:03Z","updated_at":"2017-12-20T16:03:05Z","pushed_at":"2018-02-12T15:56:24Z","git_url":"git://github.com/Undistraction/ramda-adjunct.git","ssh_url":"git@github.com:Undistraction/ramda-adjunct.git","clone_url":"https://github.com/Undistraction/ramda-adjunct.git","svn_url":"https://github.com/Undistraction/ramda-adjunct","homepage":"https://char0n.github.io/ramda-adjunct/","size":4943,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"char0n:master","ref":"master","sha":"c9a4c67122ae629d3dc3fa1712e10d8c298a7c4f","user":{"login":"char0n","id":193286,"avatar_url":"https://avatars1.githubusercontent.com/u/193286?v=4","gravatar_id":"","url":"https://api.github.com/users/char0n","html_url":"https://github.com/char0n","followers_url":"https://api.github.com/users/char0n/followers","following_url":"https://api.github.com/users/char0n/following{/other_user}","gists_url":"https://api.github.com/users/char0n/gists{/gist_id}","starred_url":"https://api.github.com/users/char0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/char0n/subscriptions","organizations_url":"https://api.github.com/users/char0n/orgs","repos_url":"https://api.github.com/users/char0n/repos","events_url":"https://api.github.com/users/char0n/events{/privacy}","received_events_url":"https://api.github.com/users/char0n/received_events","type":"User","site_admin":false},"repo":{"id":81263716,"name":"ramda-adjunct","full_name":"char0n/ramda-adjunct","owner":{"login":"char0n","id":193286,"avatar_url":"https://avatars1.githubusercontent.com/u/193286?v=4","gravatar_id":"","url":"https://api.github.com/users/char0n","html_url":"https://github.com/char0n","followers_url":"https://api.github.com/users/char0n/followers","following_url":"https://api.github.com/users/char0n/following{/other_user}","gists_url":"https://api.github.com/users/char0n/gists{/gist_id}","starred_url":"https://api.github.com/users/char0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/char0n/subscriptions","organizations_url":"https://api.github.com/users/char0n/orgs","repos_url":"https://api.github.com/users/char0n/repos","events_url":"https://api.github.com/users/char0n/events{/privacy}","received_events_url":"https://api.github.com/users/char0n/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/char0n/ramda-adjunct","description":"Adjunct is a thing added to something else as a supplementary rather than an essential part. And that something is being ramda.","fork":false,"url":"https://api.github.com/repos/char0n/ramda-adjunct","forks_url":"https://api.github.com/repos/char0n/ramda-adjunct/forks","keys_url":"https://api.github.com/repos/char0n/ramda-adjunct/keys{/key_id}","collaborators_url":"https://api.github.com/repos/char0n/ramda-adjunct/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/char0n/ramda-adjunct/teams","hooks_url":"https://api.github.com/repos/char0n/ramda-adjunct/hooks","issue_events_url":"https://api.github.com/repos/char0n/ramda-adjunct/issues/events{/number}","events_url":"https://api.github.com/repos/char0n/ramda-adjunct/events","assignees_url":"https://api.github.com/repos/char0n/ramda-adjunct/assignees{/user}","branches_url":"https://api.github.com/repos/char0n/ramda-adjunct/branches{/branch}","tags_url":"https://api.github.com/repos/char0n/ramda-adjunct/tags","blobs_url":"https://api.github.com/repos/char0n/ramda-adjunct/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/char0n/ramda-adjunct/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/char0n/ramda-adjunct/git/refs{/sha}","trees_url":"https://api.github.com/repos/char0n/ramda-adjunct/git/trees{/sha}","statuses_url":"https://api.github.com/repos/char0n/ramda-adjunct/statuses/{sha}","languages_url":"https://api.github.com/repos/char0n/ramda-adjunct/languages","stargazers_url":"https://api.github.com/repos/char0n/ramda-adjunct/stargazers","contributors_url":"https://api.github.com/repos/char0n/ramda-adjunct/contributors","subscribers_url":"https://api.github.com/repos/char0n/ramda-adjunct/subscribers","subscription_url":"https://api.github.com/repos/char0n/ramda-adjunct/subscription","commits_url":"https://api.github.com/repos/char0n/ramda-adjunct/commits{/sha}","git_commits_url":"https://api.github.com/repos/char0n/ramda-adjunct/git/commits{/sha}","comments_url":"https://api.github.com/repos/char0n/ramda-adjunct/comments{/number}","issue_comment_url":"https://api.github.com/repos/char0n/ramda-adjunct/issues/comments{/number}","contents_url":"https://api.github.com/repos/char0n/ramda-adjunct/contents/{+path}","compare_url":"https://api.github.com/repos/char0n/ramda-adjunct/compare/{base}...{head}","merges_url":"https://api.github.com/repos/char0n/ramda-adjunct/merges","archive_url":"https://api.github.com/repos/char0n/ramda-adjunct/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/char0n/ramda-adjunct/downloads","issues_url":"https://api.github.com/repos/char0n/ramda-adjunct/issues{/number}","pulls_url":"https://api.github.com/repos/char0n/ramda-adjunct/pulls{/number}","milestones_url":"https://api.github.com/repos/char0n/ramda-adjunct/milestones{/number}","notifications_url":"https://api.github.com/repos/char0n/ramda-adjunct/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/char0n/ramda-adjunct/labels{/name}","releases_url":"https://api.github.com/repos/char0n/ramda-adjunct/releases{/id}","deployments_url":"https://api.github.com/repos/char0n/ramda-adjunct/deployments","created_at":"2017-02-07T23:01:37Z","updated_at":"2018-02-14T13:33:43Z","pushed_at":"2018-02-14T21:12:39Z","git_url":"git://github.com/char0n/ramda-adjunct.git","ssh_url":"git@github.com:char0n/ramda-adjunct.git","clone_url":"https://github.com/char0n/ramda-adjunct.git","svn_url":"https://github.com/char0n/ramda-adjunct","homepage":"https://char0n.github.io/ramda-adjunct/","size":6448,"stargazers_count":122,"watchers_count":122,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":14,"open_issues":65,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/char0n/ramda-adjunct/pulls/360"},"html":{"href":"https://github.com/char0n/ramda-adjunct/pull/360"},"issue":{"href":"https://api.github.com/repos/char0n/ramda-adjunct/issues/360"},"comments":{"href":"https://api.github.com/repos/char0n/ramda-adjunct/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/char0n/ramda-adjunct/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/char0n/ramda-adjunct/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/char0n/ramda-adjunct/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/char0n/ramda-adjunct/statuses/c6b7e7977f68fd171403c8273a8d250475ff49c0"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"char0n"}}