{"action":"created","issue":{"url":"https://api.github.com/repos/AnssiR66/AlanStdLib/issues/42","repository_url":"https://api.github.com/repos/AnssiR66/AlanStdLib","labels_url":"https://api.github.com/repos/AnssiR66/AlanStdLib/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/AnssiR66/AlanStdLib/issues/42/comments","events_url":"https://api.github.com/repos/AnssiR66/AlanStdLib/issues/42/events","html_url":"https://github.com/AnssiR66/AlanStdLib/issues/42","id":377107019,"node_id":"MDU6SXNzdWUzNzcxMDcwMTk=","number":42,"title":"Floor and Ground problems","user":{"login":"tajmone","id":11064292,"node_id":"MDQ6VXNlcjExMDY0Mjky","avatar_url":"https://avatars2.githubusercontent.com/u/11064292?v=4","gravatar_id":"","url":"https://api.github.com/users/tajmone","html_url":"https://github.com/tajmone","followers_url":"https://api.github.com/users/tajmone/followers","following_url":"https://api.github.com/users/tajmone/following{/other_user}","gists_url":"https://api.github.com/users/tajmone/gists{/gist_id}","starred_url":"https://api.github.com/users/tajmone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tajmone/subscriptions","organizations_url":"https://api.github.com/users/tajmone/orgs","repos_url":"https://api.github.com/users/tajmone/repos","events_url":"https://api.github.com/users/tajmone/events{/privacy}","received_events_url":"https://api.github.com/users/tajmone/received_events","type":"User","site_admin":false},"labels":[{"id":946355219,"node_id":"MDU6TGFiZWw5NDYzNTUyMTk=","url":"https://api.github.com/repos/AnssiR66/AlanStdLib/labels/:skull:%20bug","name":":skull: bug","color":"d73a4a","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-04T00:23:30Z","updated_at":"2018-11-04T09:50:53Z","closed_at":null,"author_association":"COLLABORATOR","body":"- [ ] Add tests to identify and isolate all cases of similar problems.\r\n- [ ] Find solutions.\r\n\r\nVerbs like `put_in`, and other, have their own `DOES ONLY` ovverides in room objects or in `floor` and `ground`, but some of these will never be executed due to some `CHECK`s defined in the main verbs in `lib_verbs.i`.\r\n\r\nExample for `put_in`:\r\n\r\n```alan\r\nADD TO EVERY OBJECT\r\n  VERB put_in\r\n    WHEN obj\r\n      CHECK ...\r\n      ...\r\n      AND obj IN allowed OF cont\r\n        ELSE\r\n          IF obj IS NOT plural\r\n            THEN SAY check_obj_allowed_in_sg OF my_game.\r\n            ELSE SAY check_obj_allowed_in_pl OF my_game.\r\n```\r\n\r\nand then in `lib_locations.i`, on the `floor` instance:\r\n\r\n```alan\r\n  VERB put_in\r\n     WHEN cont\r\n    DOES ONLY \"That's not something you can $v things into.\"\r\n```\r\n\r\nBut the latter will never get executed, due to `CHECK`s inheritance preventing it (unless the `obj` is included in the `allowed` of floor, which is unlikely and unwanted).\r\n\r\nI've tested this in the Italian library and I can confirm I get the message from the `AND obj IN allowed OF cont` CHECK (\"The XXX doesn't belong...\") instead of the expected (\"That's not something you can put things into.\").\r\n\r\nSimilar CHECKs in other verbs are preventing `DOES ONLY` executions in other cases too, especially with the verbs of the 'put,' 'pour' and 'empty' groups, when involving room/site objects, liquids and other specialized library classes.\r\n\r\nI'll try to add some tests to pin down all the problematic verbs and see which solution can be adopted. For now, this Issue serves as a reminder."},"comment":{"url":"https://api.github.com/repos/AnssiR66/AlanStdLib/issues/comments/435652366","html_url":"https://github.com/AnssiR66/AlanStdLib/issues/42#issuecomment-435652366","issue_url":"https://api.github.com/repos/AnssiR66/AlanStdLib/issues/42","id":435652366,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTY1MjM2Ng==","user":{"login":"AnssiR66","id":6137118,"node_id":"MDQ6VXNlcjYxMzcxMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/6137118?v=4","gravatar_id":"","url":"https://api.github.com/users/AnssiR66","html_url":"https://github.com/AnssiR66","followers_url":"https://api.github.com/users/AnssiR66/followers","following_url":"https://api.github.com/users/AnssiR66/following{/other_user}","gists_url":"https://api.github.com/users/AnssiR66/gists{/gist_id}","starred_url":"https://api.github.com/users/AnssiR66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnssiR66/subscriptions","organizations_url":"https://api.github.com/users/AnssiR66/orgs","repos_url":"https://api.github.com/users/AnssiR66/repos","events_url":"https://api.github.com/users/AnssiR66/events{/privacy}","received_events_url":"https://api.github.com/users/AnssiR66/received_events","type":"User","site_admin":false},"created_at":"2018-11-04T09:50:53Z","updated_at":"2018-11-04T09:50:53Z","author_association":"OWNER","body":"OK, thanks! Let's address this issue later when we know the scope of it."}}
{"actor":{"display_login":"AnssiR66"}}