{"action":"closed","number":460,"pull_request":{"url":"https://api.github.com/repos/facebookresearch/visdom/pulls/460","id":211893709,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExODkzNzA5","html_url":"https://github.com/facebookresearch/visdom/pull/460","diff_url":"https://github.com/facebookresearch/visdom/pull/460.diff","patch_url":"https://github.com/facebookresearch/visdom/pull/460.patch","issue_url":"https://api.github.com/repos/facebookresearch/visdom/issues/460","number":460,"state":"closed","locked":false,"title":"Adding timout to check connection to allow waiting for a connection","user":{"login":"JackUrb","id":1276867,"node_id":"MDQ6VXNlcjEyNzY4Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/1276867?v=4","gravatar_id":"","url":"https://api.github.com/users/JackUrb","html_url":"https://github.com/JackUrb","followers_url":"https://api.github.com/users/JackUrb/followers","following_url":"https://api.github.com/users/JackUrb/following{/other_user}","gists_url":"https://api.github.com/users/JackUrb/gists{/gist_id}","starred_url":"https://api.github.com/users/JackUrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JackUrb/subscriptions","organizations_url":"https://api.github.com/users/JackUrb/orgs","repos_url":"https://api.github.com/users/JackUrb/repos","events_url":"https://api.github.com/users/JackUrb/events{/privacy}","received_events_url":"https://api.github.com/users/JackUrb/received_events","type":"User","site_admin":false},"body":"## Description\r\nAs it's somewhat canonical to wait a little bit for a visdom connection to be formed, this is now built into the `check_connection` method.\r\n\r\n## Motivation and Context\r\nBrought up in #452 as a possible improvement.\r\n\r\n## How Has This Been Tested?\r\nRunning the demo with the new change is successful.\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [x] I have updated the documentation accordingly.\r\n- [ ] For JavaScript changes, I have re-generated the minified JavaScript code.\r\n","created_at":"2018-08-29T21:32:20Z","updated_at":"2018-08-30T21:33:46Z","closed_at":"2018-08-30T21:33:46Z","merged_at":null,"merge_commit_sha":"d468e6aaf9fb8e04acc4d8a047bd3e22f0b9d32d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lvdmaaten","id":1168046,"node_id":"MDQ6VXNlcjExNjgwNDY=","avatar_url":"https://avatars0.githubusercontent.com/u/1168046?v=4","gravatar_id":"","url":"https://api.github.com/users/lvdmaaten","html_url":"https://github.com/lvdmaaten","followers_url":"https://api.github.com/users/lvdmaaten/followers","following_url":"https://api.github.com/users/lvdmaaten/following{/other_user}","gists_url":"https://api.github.com/users/lvdmaaten/gists{/gist_id}","starred_url":"https://api.github.com/users/lvdmaaten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvdmaaten/subscriptions","organizations_url":"https://api.github.com/users/lvdmaaten/orgs","repos_url":"https://api.github.com/users/lvdmaaten/repos","events_url":"https://api.github.com/users/lvdmaaten/events{/privacy}","received_events_url":"https://api.github.com/users/lvdmaaten/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":525891146,"node_id":"MDU6TGFiZWw1MjU4OTExNDY=","url":"https://api.github.com/repos/facebookresearch/visdom/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebookresearch/visdom/pulls/460/commits","review_comments_url":"https://api.github.com/repos/facebookresearch/visdom/pulls/460/comments","review_comment_url":"https://api.github.com/repos/facebookresearch/visdom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebookresearch/visdom/issues/460/comments","statuses_url":"https://api.github.com/repos/facebookresearch/visdom/statuses/4371a8e9d3964b6fb113e870d007a87beae9d1a5","head":{"label":"facebookresearch:check-connection-timeout","ref":"check-connection-timeout","sha":"4371a8e9d3964b6fb113e870d007a87beae9d1a5","user":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":80041090,"node_id":"MDEwOlJlcG9zaXRvcnk4MDA0MTA5MA==","name":"visdom","full_name":"facebookresearch/visdom","owner":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebookresearch/visdom","description":"A flexible tool for creating, organizing, and sharing visualizations of live, rich data. Supports Torch and Numpy.","fork":false,"url":"https://api.github.com/repos/facebookresearch/visdom","forks_url":"https://api.github.com/repos/facebookresearch/visdom/forks","keys_url":"https://api.github.com/repos/facebookresearch/visdom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookresearch/visdom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookresearch/visdom/teams","hooks_url":"https://api.github.com/repos/facebookresearch/visdom/hooks","issue_events_url":"https://api.github.com/repos/facebookresearch/visdom/issues/events{/number}","events_url":"https://api.github.com/repos/facebookresearch/visdom/events","assignees_url":"https://api.github.com/repos/facebookresearch/visdom/assignees{/user}","branches_url":"https://api.github.com/repos/facebookresearch/visdom/branches{/branch}","tags_url":"https://api.github.com/repos/facebookresearch/visdom/tags","blobs_url":"https://api.github.com/repos/facebookresearch/visdom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookresearch/visdom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookresearch/visdom/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookresearch/visdom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookresearch/visdom/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookresearch/visdom/languages","stargazers_url":"https://api.github.com/repos/facebookresearch/visdom/stargazers","contributors_url":"https://api.github.com/repos/facebookresearch/visdom/contributors","subscribers_url":"https://api.github.com/repos/facebookresearch/visdom/subscribers","subscription_url":"https://api.github.com/repos/facebookresearch/visdom/subscription","commits_url":"https://api.github.com/repos/facebookresearch/visdom/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookresearch/visdom/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookresearch/visdom/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookresearch/visdom/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookresearch/visdom/contents/{+path}","compare_url":"https://api.github.com/repos/facebookresearch/visdom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookresearch/visdom/merges","archive_url":"https://api.github.com/repos/facebookresearch/visdom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookresearch/visdom/downloads","issues_url":"https://api.github.com/repos/facebookresearch/visdom/issues{/number}","pulls_url":"https://api.github.com/repos/facebookresearch/visdom/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookresearch/visdom/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookresearch/visdom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookresearch/visdom/labels{/name}","releases_url":"https://api.github.com/repos/facebookresearch/visdom/releases{/id}","deployments_url":"https://api.github.com/repos/facebookresearch/visdom/deployments","created_at":"2017-01-25T17:59:45Z","updated_at":"2018-08-30T18:59:14Z","pushed_at":"2018-08-30T21:33:44Z","git_url":"git://github.com/facebookresearch/visdom.git","ssh_url":"git@github.com:facebookresearch/visdom.git","clone_url":"https://github.com/facebookresearch/visdom.git","svn_url":"https://github.com/facebookresearch/visdom","homepage":"","size":966,"stargazers_count":4630,"watchers_count":4630,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":564,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":564,"open_issues":40,"watchers":4630,"default_branch":"master"}},"base":{"label":"facebookresearch:master","ref":"master","sha":"451fc8ff39e028ab76eecfecd2054eb39f0669ca","user":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":80041090,"node_id":"MDEwOlJlcG9zaXRvcnk4MDA0MTA5MA==","name":"visdom","full_name":"facebookresearch/visdom","owner":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebookresearch/visdom","description":"A flexible tool for creating, organizing, and sharing visualizations of live, rich data. Supports Torch and Numpy.","fork":false,"url":"https://api.github.com/repos/facebookresearch/visdom","forks_url":"https://api.github.com/repos/facebookresearch/visdom/forks","keys_url":"https://api.github.com/repos/facebookresearch/visdom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookresearch/visdom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookresearch/visdom/teams","hooks_url":"https://api.github.com/repos/facebookresearch/visdom/hooks","issue_events_url":"https://api.github.com/repos/facebookresearch/visdom/issues/events{/number}","events_url":"https://api.github.com/repos/facebookresearch/visdom/events","assignees_url":"https://api.github.com/repos/facebookresearch/visdom/assignees{/user}","branches_url":"https://api.github.com/repos/facebookresearch/visdom/branches{/branch}","tags_url":"https://api.github.com/repos/facebookresearch/visdom/tags","blobs_url":"https://api.github.com/repos/facebookresearch/visdom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookresearch/visdom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookresearch/visdom/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookresearch/visdom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookresearch/visdom/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookresearch/visdom/languages","stargazers_url":"https://api.github.com/repos/facebookresearch/visdom/stargazers","contributors_url":"https://api.github.com/repos/facebookresearch/visdom/contributors","subscribers_url":"https://api.github.com/repos/facebookresearch/visdom/subscribers","subscription_url":"https://api.github.com/repos/facebookresearch/visdom/subscription","commits_url":"https://api.github.com/repos/facebookresearch/visdom/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookresearch/visdom/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookresearch/visdom/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookresearch/visdom/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookresearch/visdom/contents/{+path}","compare_url":"https://api.github.com/repos/facebookresearch/visdom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookresearch/visdom/merges","archive_url":"https://api.github.com/repos/facebookresearch/visdom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookresearch/visdom/downloads","issues_url":"https://api.github.com/repos/facebookresearch/visdom/issues{/number}","pulls_url":"https://api.github.com/repos/facebookresearch/visdom/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookresearch/visdom/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookresearch/visdom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookresearch/visdom/labels{/name}","releases_url":"https://api.github.com/repos/facebookresearch/visdom/releases{/id}","deployments_url":"https://api.github.com/repos/facebookresearch/visdom/deployments","created_at":"2017-01-25T17:59:45Z","updated_at":"2018-08-30T18:59:14Z","pushed_at":"2018-08-30T21:33:44Z","git_url":"git://github.com/facebookresearch/visdom.git","ssh_url":"git@github.com:facebookresearch/visdom.git","clone_url":"https://github.com/facebookresearch/visdom.git","svn_url":"https://github.com/facebookresearch/visdom","homepage":"","size":966,"stargazers_count":4630,"watchers_count":4630,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":564,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":564,"open_issues":40,"watchers":4630,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/visdom/pulls/460"},"html":{"href":"https://github.com/facebookresearch/visdom/pull/460"},"issue":{"href":"https://api.github.com/repos/facebookresearch/visdom/issues/460"},"comments":{"href":"https://api.github.com/repos/facebookresearch/visdom/issues/460/comments"},"review_comments":{"href":"https://api.github.com/repos/facebookresearch/visdom/pulls/460/comments"},"review_comment":{"href":"https://api.github.com/repos/facebookresearch/visdom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebookresearch/visdom/pulls/460/commits"},"statuses":{"href":"https://api.github.com/repos/facebookresearch/visdom/statuses/4371a8e9d3964b6fb113e870d007a87beae9d1a5"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":22,"deletions":15,"changed_files":4}}
{"actor":{"display_login":"facebook-github-bot"}}