{"action":"created","comment":{"url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/pulls/comments/177340685","pull_request_review_id":107190126,"id":177340685,"diff_hunk":"@@ -19,7 +21,37 @@ public CandlesController(ICandlesHistoryServiceProvider candlesServiceProvider)\n         }\n \n         /// <summary>\n-        /// Get candles for specified period and asset pair\n+        /// Get list of supported asset pairs for the given market type.\n+        /// </summary>\n+        /// <param name=\"market\">The market type. Acceptable values: Spot, Mt.</param>\n+        [HttpGet(\"history/{market}/available\")]\n+        [ProducesResponseType(typeof(string[]), 200)]\n+        [ProducesResponseType(typeof(ApiError), 400)]\n+        public async Task<IActionResult> GetAvailableAssets(MarketType market)\n+        {\n+            if (!ModelState.IsValid)\n+            {\n+                return BadRequest(ModelState.ToApiError());\n+            }\n+\n+            var candlesService = _candlesServiceProvider.TryGet(market.ToDomain());\n+\n+            if (candlesService == null)\n+            {\n+                return BadRequest(new ApiError\n+                {\n+                    Code = ErrorCodes.InvalidInput,\n+                    Msg = \"Invalid market\"\n+                });\n+            }\n+\n+            var response = await candlesService.GetAvailableAssetPairsAsync();","path":"src/LykkePublicAPI/Controllers/CandlesController.cs","position":37,"original_position":37,"commit_id":"ababec8feceff66a7022e235f6c76bbffa2dccc5","original_commit_id":"ababec8feceff66a7022e235f6c76bbffa2dccc5","user":{"login":"starkmsu","id":2949551,"avatar_url":"https://avatars3.githubusercontent.com/u/2949551?v=4","gravatar_id":"","url":"https://api.github.com/users/starkmsu","html_url":"https://github.com/starkmsu","followers_url":"https://api.github.com/users/starkmsu/followers","following_url":"https://api.github.com/users/starkmsu/following{/other_user}","gists_url":"https://api.github.com/users/starkmsu/gists{/gist_id}","starred_url":"https://api.github.com/users/starkmsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starkmsu/subscriptions","organizations_url":"https://api.github.com/users/starkmsu/orgs","repos_url":"https://api.github.com/users/starkmsu/repos","events_url":"https://api.github.com/users/starkmsu/events{/privacy}","received_events_url":"https://api.github.com/users/starkmsu/received_events","type":"User","site_admin":false},"body":"Can we get here any failed results? Is result check required?","created_at":"2018-03-27T08:12:55Z","updated_at":"2018-03-27T08:12:55Z","html_url":"https://github.com/LykkeCity/LykkePublicAPI/pull/40#discussion_r177340685","pull_request_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/pulls/40","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/pulls/comments/177340685"},"html":{"href":"https://github.com/LykkeCity/LykkePublicAPI/pull/40#discussion_r177340685"},"pull_request":{"href":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/pulls/40","id":177657460,"html_url":"https://github.com/LykkeCity/LykkePublicAPI/pull/40","diff_url":"https://github.com/LykkeCity/LykkePublicAPI/pull/40.diff","patch_url":"https://github.com/LykkeCity/LykkePublicAPI/pull/40.patch","issue_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/issues/40","number":40,"state":"open","locked":false,"title":"Feature lwdev 5939 new endpoint for candles history","user":{"login":"dmitrysmall","id":35897594,"avatar_url":"https://avatars3.githubusercontent.com/u/35897594?v=4","gravatar_id":"","url":"https://api.github.com/users/dmitrysmall","html_url":"https://github.com/dmitrysmall","followers_url":"https://api.github.com/users/dmitrysmall/followers","following_url":"https://api.github.com/users/dmitrysmall/following{/other_user}","gists_url":"https://api.github.com/users/dmitrysmall/gists{/gist_id}","starred_url":"https://api.github.com/users/dmitrysmall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmitrysmall/subscriptions","organizations_url":"https://api.github.com/users/dmitrysmall/orgs","repos_url":"https://api.github.com/users/dmitrysmall/repos","events_url":"https://api.github.com/users/dmitrysmall/events{/privacy}","received_events_url":"https://api.github.com/users/dmitrysmall/received_events","type":"User","site_admin":false},"body":"Please, see: https://lykkex.atlassian.net/browse/LWDEV-5939","created_at":"2018-03-27T07:52:37Z","updated_at":"2018-03-27T08:12:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aaab65e4febc40bb0f816621ab36dd939469e3e3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"KonstantinRyazantsev","id":10830510,"avatar_url":"https://avatars0.githubusercontent.com/u/10830510?v=4","gravatar_id":"","url":"https://api.github.com/users/KonstantinRyazantsev","html_url":"https://github.com/KonstantinRyazantsev","followers_url":"https://api.github.com/users/KonstantinRyazantsev/followers","following_url":"https://api.github.com/users/KonstantinRyazantsev/following{/other_user}","gists_url":"https://api.github.com/users/KonstantinRyazantsev/gists{/gist_id}","starred_url":"https://api.github.com/users/KonstantinRyazantsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KonstantinRyazantsev/subscriptions","organizations_url":"https://api.github.com/users/KonstantinRyazantsev/orgs","repos_url":"https://api.github.com/users/KonstantinRyazantsev/repos","events_url":"https://api.github.com/users/KonstantinRyazantsev/events{/privacy}","received_events_url":"https://api.github.com/users/KonstantinRyazantsev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/pulls/40/commits","review_comments_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/pulls/40/comments","review_comment_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/issues/40/comments","statuses_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/statuses/ababec8feceff66a7022e235f6c76bbffa2dccc5","head":{"label":"LykkeCity:feature_LWDEV-5939-New-endpoint-for-candles-history","ref":"feature_LWDEV-5939-New-endpoint-for-candles-history","sha":"ababec8feceff66a7022e235f6c76bbffa2dccc5","user":{"login":"LykkeCity","id":14153330,"avatar_url":"https://avatars0.githubusercontent.com/u/14153330?v=4","gravatar_id":"","url":"https://api.github.com/users/LykkeCity","html_url":"https://github.com/LykkeCity","followers_url":"https://api.github.com/users/LykkeCity/followers","following_url":"https://api.github.com/users/LykkeCity/following{/other_user}","gists_url":"https://api.github.com/users/LykkeCity/gists{/gist_id}","starred_url":"https://api.github.com/users/LykkeCity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LykkeCity/subscriptions","organizations_url":"https://api.github.com/users/LykkeCity/orgs","repos_url":"https://api.github.com/users/LykkeCity/repos","events_url":"https://api.github.com/users/LykkeCity/events{/privacy}","received_events_url":"https://api.github.com/users/LykkeCity/received_events","type":"Organization","site_admin":false},"repo":{"id":72775417,"name":"LykkePublicAPI","full_name":"LykkeCity/LykkePublicAPI","owner":{"login":"LykkeCity","id":14153330,"avatar_url":"https://avatars0.githubusercontent.com/u/14153330?v=4","gravatar_id":"","url":"https://api.github.com/users/LykkeCity","html_url":"https://github.com/LykkeCity","followers_url":"https://api.github.com/users/LykkeCity/followers","following_url":"https://api.github.com/users/LykkeCity/following{/other_user}","gists_url":"https://api.github.com/users/LykkeCity/gists{/gist_id}","starred_url":"https://api.github.com/users/LykkeCity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LykkeCity/subscriptions","organizations_url":"https://api.github.com/users/LykkeCity/orgs","repos_url":"https://api.github.com/users/LykkeCity/repos","events_url":"https://api.github.com/users/LykkeCity/events{/privacy}","received_events_url":"https://api.github.com/users/LykkeCity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LykkeCity/LykkePublicAPI","description":"Public API exposed for third party usage.","fork":false,"url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI","forks_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/forks","keys_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/teams","hooks_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/hooks","issue_events_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/issues/events{/number}","events_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/events","assignees_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/assignees{/user}","branches_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/branches{/branch}","tags_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/tags","blobs_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/languages","stargazers_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/stargazers","contributors_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/contributors","subscribers_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/subscribers","subscription_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/subscription","commits_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/contents/{+path}","compare_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/merges","archive_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/downloads","issues_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/issues{/number}","pulls_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/labels{/name}","releases_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/releases{/id}","deployments_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/deployments","created_at":"2016-11-03T18:36:10Z","updated_at":"2018-03-15T12:37:04Z","pushed_at":"2018-03-27T07:52:37Z","git_url":"git://github.com/LykkeCity/LykkePublicAPI.git","ssh_url":"git@github.com:LykkeCity/LykkePublicAPI.git","clone_url":"https://github.com/LykkeCity/LykkePublicAPI.git","svn_url":"https://github.com/LykkeCity/LykkePublicAPI","homepage":null,"size":697,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"LykkeCity:master","ref":"master","sha":"f2511fc4c5afcd22e352c45847c485d3feeada0c","user":{"login":"LykkeCity","id":14153330,"avatar_url":"https://avatars0.githubusercontent.com/u/14153330?v=4","gravatar_id":"","url":"https://api.github.com/users/LykkeCity","html_url":"https://github.com/LykkeCity","followers_url":"https://api.github.com/users/LykkeCity/followers","following_url":"https://api.github.com/users/LykkeCity/following{/other_user}","gists_url":"https://api.github.com/users/LykkeCity/gists{/gist_id}","starred_url":"https://api.github.com/users/LykkeCity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LykkeCity/subscriptions","organizations_url":"https://api.github.com/users/LykkeCity/orgs","repos_url":"https://api.github.com/users/LykkeCity/repos","events_url":"https://api.github.com/users/LykkeCity/events{/privacy}","received_events_url":"https://api.github.com/users/LykkeCity/received_events","type":"Organization","site_admin":false},"repo":{"id":72775417,"name":"LykkePublicAPI","full_name":"LykkeCity/LykkePublicAPI","owner":{"login":"LykkeCity","id":14153330,"avatar_url":"https://avatars0.githubusercontent.com/u/14153330?v=4","gravatar_id":"","url":"https://api.github.com/users/LykkeCity","html_url":"https://github.com/LykkeCity","followers_url":"https://api.github.com/users/LykkeCity/followers","following_url":"https://api.github.com/users/LykkeCity/following{/other_user}","gists_url":"https://api.github.com/users/LykkeCity/gists{/gist_id}","starred_url":"https://api.github.com/users/LykkeCity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LykkeCity/subscriptions","organizations_url":"https://api.github.com/users/LykkeCity/orgs","repos_url":"https://api.github.com/users/LykkeCity/repos","events_url":"https://api.github.com/users/LykkeCity/events{/privacy}","received_events_url":"https://api.github.com/users/LykkeCity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LykkeCity/LykkePublicAPI","description":"Public API exposed for third party usage.","fork":false,"url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI","forks_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/forks","keys_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/teams","hooks_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/hooks","issue_events_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/issues/events{/number}","events_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/events","assignees_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/assignees{/user}","branches_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/branches{/branch}","tags_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/tags","blobs_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/git/refs{/sha}","trees_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/statuses/{sha}","languages_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/languages","stargazers_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/stargazers","contributors_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/contributors","subscribers_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/subscribers","subscription_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/subscription","commits_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/commits{/sha}","git_commits_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/git/commits{/sha}","comments_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/comments{/number}","issue_comment_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/issues/comments{/number}","contents_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/contents/{+path}","compare_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/merges","archive_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/downloads","issues_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/issues{/number}","pulls_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/pulls{/number}","milestones_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/milestones{/number}","notifications_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/labels{/name}","releases_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/releases{/id}","deployments_url":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/deployments","created_at":"2016-11-03T18:36:10Z","updated_at":"2018-03-15T12:37:04Z","pushed_at":"2018-03-27T07:52:37Z","git_url":"git://github.com/LykkeCity/LykkePublicAPI.git","ssh_url":"git@github.com:LykkeCity/LykkePublicAPI.git","clone_url":"https://github.com/LykkeCity/LykkePublicAPI.git","svn_url":"https://github.com/LykkeCity/LykkePublicAPI","homepage":null,"size":697,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/pulls/40"},"html":{"href":"https://github.com/LykkeCity/LykkePublicAPI/pull/40"},"issue":{"href":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/issues/40"},"comments":{"href":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/LykkeCity/LykkePublicAPI/statuses/ababec8feceff66a7022e235f6c76bbffa2dccc5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"starkmsu"}}