{"action":"opened","number":16,"pull_request":{"url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/pulls/16","id":174011193,"html_url":"https://github.com/htmlacademy-php/20008-yeticave/pull/16","diff_url":"https://github.com/htmlacademy-php/20008-yeticave/pull/16.diff","patch_url":"https://github.com/htmlacademy-php/20008-yeticave/pull/16.patch","issue_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/issues/16","number":16,"state":"open","locked":false,"title":"Обновление проекта","user":{"login":"Acknowhow","id":10113434,"avatar_url":"https://avatars0.githubusercontent.com/u/10113434?v=4","gravatar_id":"","url":"https://api.github.com/users/Acknowhow","html_url":"https://github.com/Acknowhow","followers_url":"https://api.github.com/users/Acknowhow/followers","following_url":"https://api.github.com/users/Acknowhow/following{/other_user}","gists_url":"https://api.github.com/users/Acknowhow/gists{/gist_id}","starred_url":"https://api.github.com/users/Acknowhow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Acknowhow/subscriptions","organizations_url":"https://api.github.com/users/Acknowhow/orgs","repos_url":"https://api.github.com/users/Acknowhow/repos","events_url":"https://api.github.com/users/Acknowhow/events{/privacy}","received_events_url":"https://api.github.com/users/Acknowhow/received_events","type":"User","site_admin":false},"body":"<img width=\"539\" alt=\"b1\" src=\"https://user-images.githubusercontent.com/10113434/37209066-ccea2fde-23b4-11e8-9c93-98bb3a2111ee.png\">\r\n\r\n\r\n- Добавил изображение\r\n- Ставки в человечевском формате на странице лота\r\n- Не показывается добавление ставки в соответствии с ТЗ\r\n- var_dump убрал, на будущее конечно буду проверять перед сдачей\r\n- ссылки вставил привычным образом\r\nХотел уточнить по поводу пароля – его по количеству символов вообще никак не ограничивать? А если пользователь вставить текстовый файл на 10 мб?\r\n- Пользовательские данные уберу\r\n\r\n<img width=\"525\" alt=\"b6\" src=\"https://user-images.githubusercontent.com/10113434/37209205-74605590-23b5-11e8-8c2f-678387ce0401.png\">\r\n\r\n- Посторонние файлы уберу\r\n\r\n<img width=\"539\" alt=\"b7\" src=\"https://user-images.githubusercontent.com/10113434/37209226-90b1280a-23b5-11e8-8127-53816e012d2f.png\">\r\n\r\n- Сама не путаюсь. Как думаешь насколько это релевантно? \r\n\r\n<img width=\"525\" alt=\"b10\" src=\"https://user-images.githubusercontent.com/10113434/37210293-3d1eb4a6-23b9-11e8-9ae8-704447cdec85.png\">\r\n\r\nhttps://yadi.sk/i/clP_Q48W3T25yk\r\nКакая проверка здесь имеется в виду? \r\nПо остальным коментам вроде все исправил\r\n\r\n<img width=\"523\" alt=\"b11\" src=\"https://user-images.githubusercontent.com/10113434/37210329-65df85c8-23b9-11e8-8bda-28ce96bf224c.png\">\r\n\r\nisEmptyArray() убрал. А что не так с остальными функциями и проверками? Все проверки в сценарии, на выходе минимум лишнего кода \r\n\r\n<img width=\"533\" alt=\"check_2\" src=\"https://user-images.githubusercontent.com/10113434/37210394-a49268f8-23b9-11e8-9461-7a4be33c931f.png\">\r\n\r\n<img width=\"531\" alt=\"b17\" src=\"https://user-images.githubusercontent.com/10113434/37210441-c5b0cdfe-23b9-11e8-929a-fa037c7fe23b.png\">\r\n\r\nЯ правильно понимаю, везде, где выводятся данные пользовательского ввода, нужно добавить htmlspecialchars()? Или что то еще имеется в виду?\r\n\r\n<img width=\"523\" alt=\"b19\" src=\"https://user-images.githubusercontent.com/10113434/37210572-480ed674-23ba-11e8-985b-294fcb5d62f5.png\">\r\n\r\nНе совсем понял, что не так с таблицами? Я немного исправил, явно задал CURRENT_TIMESTAMP, а конечный срок размещения лота я сохраняю в формате даты, потом все равно его через fetch забираю в формате UNIX_TIMESTAMP. Уберу в итоге bet_is_win, потому что победитель определяется через запрос к БД\r\n\r\n<img width=\"519\" alt=\"d1\" src=\"https://user-images.githubusercontent.com/10113434/37210711-c06dce54-23ba-11e8-95cd-d35a8f68e755.png\">\r\n\r\nЯвное приведение типов добавлю, где отсутствует. Т.е. все таки не все мои проверки были такие дичайшие?\r\n<img width=\"529\" alt=\"d5-d6\" src=\"https://user-images.githubusercontent.com/10113434/37210782-f7682580-23ba-11e8-9604-b8ebd9069047.png\">\r\n\r\nЭто в процессе\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2018-03-09T13:57:58Z","updated_at":"2018-03-09T13:57:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/pulls/16/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/pulls/16/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/issues/16/comments","statuses_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/statuses/b3b007dbdb779e014717b30fc2f588b8de99639b","head":{"label":"Acknowhow:master","ref":"master","sha":"b3b007dbdb779e014717b30fc2f588b8de99639b","user":{"login":"Acknowhow","id":10113434,"avatar_url":"https://avatars0.githubusercontent.com/u/10113434?v=4","gravatar_id":"","url":"https://api.github.com/users/Acknowhow","html_url":"https://github.com/Acknowhow","followers_url":"https://api.github.com/users/Acknowhow/followers","following_url":"https://api.github.com/users/Acknowhow/following{/other_user}","gists_url":"https://api.github.com/users/Acknowhow/gists{/gist_id}","starred_url":"https://api.github.com/users/Acknowhow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Acknowhow/subscriptions","organizations_url":"https://api.github.com/users/Acknowhow/orgs","repos_url":"https://api.github.com/users/Acknowhow/repos","events_url":"https://api.github.com/users/Acknowhow/events{/privacy}","received_events_url":"https://api.github.com/users/Acknowhow/received_events","type":"User","site_admin":false},"repo":{"id":119583724,"name":"20008-yeticave-1","full_name":"Acknowhow/20008-yeticave-1","owner":{"login":"Acknowhow","id":10113434,"avatar_url":"https://avatars0.githubusercontent.com/u/10113434?v=4","gravatar_id":"","url":"https://api.github.com/users/Acknowhow","html_url":"https://github.com/Acknowhow","followers_url":"https://api.github.com/users/Acknowhow/followers","following_url":"https://api.github.com/users/Acknowhow/following{/other_user}","gists_url":"https://api.github.com/users/Acknowhow/gists{/gist_id}","starred_url":"https://api.github.com/users/Acknowhow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Acknowhow/subscriptions","organizations_url":"https://api.github.com/users/Acknowhow/orgs","repos_url":"https://api.github.com/users/Acknowhow/repos","events_url":"https://api.github.com/users/Acknowhow/events{/privacy}","received_events_url":"https://api.github.com/users/Acknowhow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Acknowhow/20008-yeticave-1","description":"Вадим Корабельник","fork":true,"url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1","forks_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/forks","keys_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/teams","hooks_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/hooks","issue_events_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/issues/events{/number}","events_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/events","assignees_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/assignees{/user}","branches_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/branches{/branch}","tags_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/tags","blobs_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/statuses/{sha}","languages_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/languages","stargazers_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/stargazers","contributors_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/contributors","subscribers_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/subscribers","subscription_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/subscription","commits_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/contents/{+path}","compare_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/merges","archive_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/downloads","issues_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/issues{/number}","pulls_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/pulls{/number}","milestones_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/milestones{/number}","notifications_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/labels{/name}","releases_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/releases{/id}","deployments_url":"https://api.github.com/repos/Acknowhow/20008-yeticave-1/deployments","created_at":"2018-01-30T19:27:57Z","updated_at":"2018-01-30T19:27:59Z","pushed_at":"2018-03-09T13:07:37Z","git_url":"git://github.com/Acknowhow/20008-yeticave-1.git","ssh_url":"git@github.com:Acknowhow/20008-yeticave-1.git","clone_url":"https://github.com/Acknowhow/20008-yeticave-1.git","svn_url":"https://github.com/Acknowhow/20008-yeticave-1","homepage":null,"size":964,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-php:master","ref":"master","sha":"cfb69f0d5eaed42e3c9b86a540d3920d52196b21","user":{"login":"htmlacademy-php","id":27206120,"avatar_url":"https://avatars1.githubusercontent.com/u/27206120?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-php","html_url":"https://github.com/htmlacademy-php","followers_url":"https://api.github.com/users/htmlacademy-php/followers","following_url":"https://api.github.com/users/htmlacademy-php/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-php/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-php/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-php/orgs","repos_url":"https://api.github.com/users/htmlacademy-php/repos","events_url":"https://api.github.com/users/htmlacademy-php/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-php/received_events","type":"Organization","site_admin":false},"repo":{"id":119583551,"name":"20008-yeticave","full_name":"htmlacademy-php/20008-yeticave","owner":{"login":"htmlacademy-php","id":27206120,"avatar_url":"https://avatars1.githubusercontent.com/u/27206120?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-php","html_url":"https://github.com/htmlacademy-php","followers_url":"https://api.github.com/users/htmlacademy-php/followers","following_url":"https://api.github.com/users/htmlacademy-php/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-php/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-php/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-php/orgs","repos_url":"https://api.github.com/users/htmlacademy-php/repos","events_url":"https://api.github.com/users/htmlacademy-php/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-php/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-php/20008-yeticave","description":"Вадим Корабельник","fork":false,"url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave","forks_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/forks","keys_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/teams","hooks_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/events","assignees_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/tags","blobs_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/subscription","commits_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/merges","archive_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/downloads","issues_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/deployments","created_at":"2018-01-30T19:26:16Z","updated_at":"2018-01-30T19:40:55Z","pushed_at":"2018-03-04T20:52:05Z","git_url":"git://github.com/htmlacademy-php/20008-yeticave.git","ssh_url":"git@github.com:htmlacademy-php/20008-yeticave.git","clone_url":"https://github.com/htmlacademy-php/20008-yeticave.git","svn_url":"https://github.com/htmlacademy-php/20008-yeticave","homepage":"https://github.com/Acknowhow/20008-yeticave-1","size":964,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/pulls/16"},"html":{"href":"https://github.com/htmlacademy-php/20008-yeticave/pull/16"},"issue":{"href":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/issues/16"},"comments":{"href":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-php/20008-yeticave/statuses/b3b007dbdb779e014717b30fc2f588b8de99639b"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":42,"additions":608,"deletions":348,"changed_files":42}}
{"actor":{"display_login":"Acknowhow"}}