{"action":"created","comment":{"url":"https://api.github.com/repos/joyent/containerpilot/pulls/comments/180777295","pull_request_review_id":111258115,"id":180777295,"diff_hunk":"@@ -24,6 +24,7 @@ type Config struct {\n \n \t// service discovery\n \tPort              int           `mapstructure:\"port\"`\n+\tInitialStatus     string        `mapstructure:\"initialStatus\"`","path":"jobs/config.go","position":null,"original_position":4,"commit_id":"5358e3053efb26834314dc6f71adf63a0cba14fc","original_commit_id":"1125ab530d2631c5331dcd77b765f56b241cd435","user":{"login":"cheapRoc","id":140,"avatar_url":"https://avatars2.githubusercontent.com/u/140?v=4","gravatar_id":"","url":"https://api.github.com/users/cheapRoc","html_url":"https://github.com/cheapRoc","followers_url":"https://api.github.com/users/cheapRoc/followers","following_url":"https://api.github.com/users/cheapRoc/following{/other_user}","gists_url":"https://api.github.com/users/cheapRoc/gists{/gist_id}","starred_url":"https://api.github.com/users/cheapRoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cheapRoc/subscriptions","organizations_url":"https://api.github.com/users/cheapRoc/orgs","repos_url":"https://api.github.com/users/cheapRoc/repos","events_url":"https://api.github.com/users/cheapRoc/events{/privacy}","received_events_url":"https://api.github.com/users/cheapRoc/received_events","type":"User","site_admin":false},"body":"Ah yes, you're right.","created_at":"2018-04-11T14:36:30Z","updated_at":"2018-04-11T14:36:30Z","html_url":"https://github.com/joyent/containerpilot/pull/553#discussion_r180777295","pull_request_url":"https://api.github.com/repos/joyent/containerpilot/pulls/553","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/joyent/containerpilot/pulls/comments/180777295"},"html":{"href":"https://github.com/joyent/containerpilot/pull/553#discussion_r180777295"},"pull_request":{"href":"https://api.github.com/repos/joyent/containerpilot/pulls/553"}},"in_reply_to_id":180604590},"pull_request":{"url":"https://api.github.com/repos/joyent/containerpilot/pulls/553","id":178831371,"html_url":"https://github.com/joyent/containerpilot/pull/553","diff_url":"https://github.com/joyent/containerpilot/pull/553.diff","patch_url":"https://github.com/joyent/containerpilot/pull/553.patch","issue_url":"https://api.github.com/repos/joyent/containerpilot/issues/553","number":553,"state":"open","locked":false,"title":"Register critical services in consul.","user":{"login":"eliasbrange","id":8293016,"avatar_url":"https://avatars2.githubusercontent.com/u/8293016?v=4","gravatar_id":"","url":"https://api.github.com/users/eliasbrange","html_url":"https://github.com/eliasbrange","followers_url":"https://api.github.com/users/eliasbrange/followers","following_url":"https://api.github.com/users/eliasbrange/following{/other_user}","gists_url":"https://api.github.com/users/eliasbrange/gists{/gist_id}","starred_url":"https://api.github.com/users/eliasbrange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliasbrange/subscriptions","organizations_url":"https://api.github.com/users/eliasbrange/orgs","repos_url":"https://api.github.com/users/eliasbrange/repos","events_url":"https://api.github.com/users/eliasbrange/events{/privacy}","received_events_url":"https://api.github.com/users/eliasbrange/received_events","type":"User","site_admin":false},"body":"Fixes #552 \r\n\r\nThis PR adds the functionality to register services in consul that never gets healthy to be able to filter on failed services in consul and see that they are misbehaving. \r\n\r\nI've added a method for registering a service with the status set to critical. This is called in `onHealthChechFailed`, but only if the service hasn't already been registered. I've also made some minor refactoring in `services/services.go`, i.e. having `MarkForMaintenance` call `Deregister` instead of the other way around.\r\n","created_at":"2018-04-02T12:35:20Z","updated_at":"2018-04-11T14:36:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b869f4835f9e8c04973a5fe58eef8b9c1592ed56","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/joyent/containerpilot/pulls/553/commits","review_comments_url":"https://api.github.com/repos/joyent/containerpilot/pulls/553/comments","review_comment_url":"https://api.github.com/repos/joyent/containerpilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joyent/containerpilot/issues/553/comments","statuses_url":"https://api.github.com/repos/joyent/containerpilot/statuses/5358e3053efb26834314dc6f71adf63a0cba14fc","head":{"label":"eliasbrange:register-service-even-if-it-never-gets-healthy","ref":"register-service-even-if-it-never-gets-healthy","sha":"5358e3053efb26834314dc6f71adf63a0cba14fc","user":{"login":"eliasbrange","id":8293016,"avatar_url":"https://avatars2.githubusercontent.com/u/8293016?v=4","gravatar_id":"","url":"https://api.github.com/users/eliasbrange","html_url":"https://github.com/eliasbrange","followers_url":"https://api.github.com/users/eliasbrange/followers","following_url":"https://api.github.com/users/eliasbrange/following{/other_user}","gists_url":"https://api.github.com/users/eliasbrange/gists{/gist_id}","starred_url":"https://api.github.com/users/eliasbrange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliasbrange/subscriptions","organizations_url":"https://api.github.com/users/eliasbrange/orgs","repos_url":"https://api.github.com/users/eliasbrange/repos","events_url":"https://api.github.com/users/eliasbrange/events{/privacy}","received_events_url":"https://api.github.com/users/eliasbrange/received_events","type":"User","site_admin":false},"repo":{"id":122372271,"name":"containerpilot","full_name":"eliasbrange/containerpilot","owner":{"login":"eliasbrange","id":8293016,"avatar_url":"https://avatars2.githubusercontent.com/u/8293016?v=4","gravatar_id":"","url":"https://api.github.com/users/eliasbrange","html_url":"https://github.com/eliasbrange","followers_url":"https://api.github.com/users/eliasbrange/followers","following_url":"https://api.github.com/users/eliasbrange/following{/other_user}","gists_url":"https://api.github.com/users/eliasbrange/gists{/gist_id}","starred_url":"https://api.github.com/users/eliasbrange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliasbrange/subscriptions","organizations_url":"https://api.github.com/users/eliasbrange/orgs","repos_url":"https://api.github.com/users/eliasbrange/repos","events_url":"https://api.github.com/users/eliasbrange/events{/privacy}","received_events_url":"https://api.github.com/users/eliasbrange/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eliasbrange/containerpilot","description":"A service for autodiscovery and configuration of applications running in containers","fork":true,"url":"https://api.github.com/repos/eliasbrange/containerpilot","forks_url":"https://api.github.com/repos/eliasbrange/containerpilot/forks","keys_url":"https://api.github.com/repos/eliasbrange/containerpilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eliasbrange/containerpilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eliasbrange/containerpilot/teams","hooks_url":"https://api.github.com/repos/eliasbrange/containerpilot/hooks","issue_events_url":"https://api.github.com/repos/eliasbrange/containerpilot/issues/events{/number}","events_url":"https://api.github.com/repos/eliasbrange/containerpilot/events","assignees_url":"https://api.github.com/repos/eliasbrange/containerpilot/assignees{/user}","branches_url":"https://api.github.com/repos/eliasbrange/containerpilot/branches{/branch}","tags_url":"https://api.github.com/repos/eliasbrange/containerpilot/tags","blobs_url":"https://api.github.com/repos/eliasbrange/containerpilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eliasbrange/containerpilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eliasbrange/containerpilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/eliasbrange/containerpilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eliasbrange/containerpilot/statuses/{sha}","languages_url":"https://api.github.com/repos/eliasbrange/containerpilot/languages","stargazers_url":"https://api.github.com/repos/eliasbrange/containerpilot/stargazers","contributors_url":"https://api.github.com/repos/eliasbrange/containerpilot/contributors","subscribers_url":"https://api.github.com/repos/eliasbrange/containerpilot/subscribers","subscription_url":"https://api.github.com/repos/eliasbrange/containerpilot/subscription","commits_url":"https://api.github.com/repos/eliasbrange/containerpilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/eliasbrange/containerpilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/eliasbrange/containerpilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/eliasbrange/containerpilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/eliasbrange/containerpilot/contents/{+path}","compare_url":"https://api.github.com/repos/eliasbrange/containerpilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eliasbrange/containerpilot/merges","archive_url":"https://api.github.com/repos/eliasbrange/containerpilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eliasbrange/containerpilot/downloads","issues_url":"https://api.github.com/repos/eliasbrange/containerpilot/issues{/number}","pulls_url":"https://api.github.com/repos/eliasbrange/containerpilot/pulls{/number}","milestones_url":"https://api.github.com/repos/eliasbrange/containerpilot/milestones{/number}","notifications_url":"https://api.github.com/repos/eliasbrange/containerpilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eliasbrange/containerpilot/labels{/name}","releases_url":"https://api.github.com/repos/eliasbrange/containerpilot/releases{/id}","deployments_url":"https://api.github.com/repos/eliasbrange/containerpilot/deployments","created_at":"2018-02-21T17:55:33Z","updated_at":"2018-02-21T17:55:35Z","pushed_at":"2018-04-11T07:24:14Z","git_url":"git://github.com/eliasbrange/containerpilot.git","ssh_url":"git@github.com:eliasbrange/containerpilot.git","clone_url":"https://github.com/eliasbrange/containerpilot.git","svn_url":"https://github.com/eliasbrange/containerpilot","homepage":null,"size":1237,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joyent:master","ref":"master","sha":"92f9b8f891ed758d6d56278a9c2418006f9117e9","user":{"login":"joyent","id":10161,"avatar_url":"https://avatars0.githubusercontent.com/u/10161?v=4","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"repo":{"id":44767194,"name":"containerpilot","full_name":"joyent/containerpilot","owner":{"login":"joyent","id":10161,"avatar_url":"https://avatars0.githubusercontent.com/u/10161?v=4","gravatar_id":"","url":"https://api.github.com/users/joyent","html_url":"https://github.com/joyent","followers_url":"https://api.github.com/users/joyent/followers","following_url":"https://api.github.com/users/joyent/following{/other_user}","gists_url":"https://api.github.com/users/joyent/gists{/gist_id}","starred_url":"https://api.github.com/users/joyent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joyent/subscriptions","organizations_url":"https://api.github.com/users/joyent/orgs","repos_url":"https://api.github.com/users/joyent/repos","events_url":"https://api.github.com/users/joyent/events{/privacy}","received_events_url":"https://api.github.com/users/joyent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joyent/containerpilot","description":"A service for autodiscovery and configuration of applications running in containers","fork":false,"url":"https://api.github.com/repos/joyent/containerpilot","forks_url":"https://api.github.com/repos/joyent/containerpilot/forks","keys_url":"https://api.github.com/repos/joyent/containerpilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joyent/containerpilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joyent/containerpilot/teams","hooks_url":"https://api.github.com/repos/joyent/containerpilot/hooks","issue_events_url":"https://api.github.com/repos/joyent/containerpilot/issues/events{/number}","events_url":"https://api.github.com/repos/joyent/containerpilot/events","assignees_url":"https://api.github.com/repos/joyent/containerpilot/assignees{/user}","branches_url":"https://api.github.com/repos/joyent/containerpilot/branches{/branch}","tags_url":"https://api.github.com/repos/joyent/containerpilot/tags","blobs_url":"https://api.github.com/repos/joyent/containerpilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joyent/containerpilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joyent/containerpilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/joyent/containerpilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joyent/containerpilot/statuses/{sha}","languages_url":"https://api.github.com/repos/joyent/containerpilot/languages","stargazers_url":"https://api.github.com/repos/joyent/containerpilot/stargazers","contributors_url":"https://api.github.com/repos/joyent/containerpilot/contributors","subscribers_url":"https://api.github.com/repos/joyent/containerpilot/subscribers","subscription_url":"https://api.github.com/repos/joyent/containerpilot/subscription","commits_url":"https://api.github.com/repos/joyent/containerpilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/joyent/containerpilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/joyent/containerpilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/joyent/containerpilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/joyent/containerpilot/contents/{+path}","compare_url":"https://api.github.com/repos/joyent/containerpilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joyent/containerpilot/merges","archive_url":"https://api.github.com/repos/joyent/containerpilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joyent/containerpilot/downloads","issues_url":"https://api.github.com/repos/joyent/containerpilot/issues{/number}","pulls_url":"https://api.github.com/repos/joyent/containerpilot/pulls{/number}","milestones_url":"https://api.github.com/repos/joyent/containerpilot/milestones{/number}","notifications_url":"https://api.github.com/repos/joyent/containerpilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joyent/containerpilot/labels{/name}","releases_url":"https://api.github.com/repos/joyent/containerpilot/releases{/id}","deployments_url":"https://api.github.com/repos/joyent/containerpilot/deployments","created_at":"2015-10-22T19:06:39Z","updated_at":"2018-04-09T03:24:51Z","pushed_at":"2018-04-11T07:24:15Z","git_url":"git://github.com/joyent/containerpilot.git","ssh_url":"git@github.com:joyent/containerpilot.git","clone_url":"https://github.com/joyent/containerpilot.git","svn_url":"https://github.com/joyent/containerpilot","homepage":null,"size":1216,"stargazers_count":889,"watchers_count":889,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":105,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":105,"open_issues":26,"watchers":889,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joyent/containerpilot/pulls/553"},"html":{"href":"https://github.com/joyent/containerpilot/pull/553"},"issue":{"href":"https://api.github.com/repos/joyent/containerpilot/issues/553"},"comments":{"href":"https://api.github.com/repos/joyent/containerpilot/issues/553/comments"},"review_comments":{"href":"https://api.github.com/repos/joyent/containerpilot/pulls/553/comments"},"review_comment":{"href":"https://api.github.com/repos/joyent/containerpilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joyent/containerpilot/pulls/553/commits"},"statuses":{"href":"https://api.github.com/repos/joyent/containerpilot/statuses/5358e3053efb26834314dc6f71adf63a0cba14fc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cheapRoc"}}