{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/166857279","pull_request_review_id":94984800,"id":166857279,"diff_hunk":"@@ -92,12 +92,14 @@ case class WriteToDataSourceV2Exec(writer: DataSourceWriter, query: SparkPlan) e\n         logInfo(s\"Data source writer $writer committed.\")\n       }\n     } catch {\n-      case _: InterruptedException if writer.isInstanceOf[StreamWriter] =>\n-        // Interruption is how continuous queries are ended, so accept and ignore the exception.\n+      case _: SparkException if writer.isInstanceOf[StreamWriter] =>","path":"sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala","position":6,"original_position":6,"commit_id":"f1106f33c583f9cba0fd31a5783e12ab211d7e81","original_commit_id":"f1106f33c583f9cba0fd31a5783e12ab211d7e81","user":{"login":"jerryshao","id":850797,"avatar_url":"https://avatars2.githubusercontent.com/u/850797?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryshao","html_url":"https://github.com/jerryshao","followers_url":"https://api.github.com/users/jerryshao/followers","following_url":"https://api.github.com/users/jerryshao/following{/other_user}","gists_url":"https://api.github.com/users/jerryshao/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryshao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryshao/subscriptions","organizations_url":"https://api.github.com/users/jerryshao/orgs","repos_url":"https://api.github.com/users/jerryshao/repos","events_url":"https://api.github.com/users/jerryshao/events{/privacy}","received_events_url":"https://api.github.com/users/jerryshao/received_events","type":"User","site_admin":false},"body":"I agree with @srowen that `SparkException` swallows to much. Also you both fixed here and the below lines, not sure which your intentional fix.","created_at":"2018-02-08T08:17:39Z","updated_at":"2018-02-08T08:17:39Z","html_url":"https://github.com/apache/spark/pull/20529#discussion_r166857279","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/20529","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/166857279"},"html":{"href":"https://github.com/apache/spark/pull/20529#discussion_r166857279"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/20529"}},"in_reply_to_id":166768784},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/20529","id":167664715,"html_url":"https://github.com/apache/spark/pull/20529","diff_url":"https://github.com/apache/spark/pull/20529.diff","patch_url":"https://github.com/apache/spark/pull/20529.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/20529","number":20529,"state":"open","locked":false,"title":"[SPARK-23350][SS]Bug fix for exception handling when stopping continu…","user":{"login":"yanlin-Lynn","id":32827886,"avatar_url":"https://avatars0.githubusercontent.com/u/32827886?v=4","gravatar_id":"","url":"https://api.github.com/users/yanlin-Lynn","html_url":"https://github.com/yanlin-Lynn","followers_url":"https://api.github.com/users/yanlin-Lynn/followers","following_url":"https://api.github.com/users/yanlin-Lynn/following{/other_user}","gists_url":"https://api.github.com/users/yanlin-Lynn/gists{/gist_id}","starred_url":"https://api.github.com/users/yanlin-Lynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanlin-Lynn/subscriptions","organizations_url":"https://api.github.com/users/yanlin-Lynn/orgs","repos_url":"https://api.github.com/users/yanlin-Lynn/repos","events_url":"https://api.github.com/users/yanlin-Lynn/events{/privacy}","received_events_url":"https://api.github.com/users/yanlin-Lynn/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nSparkException happends when stopping continuous processing application, using Ctrl-C in stand-alone mode. Stopping continuous processing application will throw SparkException, not InterruptedException as the code in [WriteToDataSourceV2](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2.scala#L95)\r\n\r\n## How was this patch tested?\r\n\r\nmanual tests\r\n","created_at":"2018-02-07T11:18:31Z","updated_at":"2018-02-08T08:17:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10e5a78fc242ae5518034071b47e36a8cba3abef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/20529/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/20529/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/20529/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/f1106f33c583f9cba0fd31a5783e12ab211d7e81","head":{"label":"yanlin-Lynn:SPARK-23350","ref":"SPARK-23350","sha":"f1106f33c583f9cba0fd31a5783e12ab211d7e81","user":{"login":"yanlin-Lynn","id":32827886,"avatar_url":"https://avatars0.githubusercontent.com/u/32827886?v=4","gravatar_id":"","url":"https://api.github.com/users/yanlin-Lynn","html_url":"https://github.com/yanlin-Lynn","followers_url":"https://api.github.com/users/yanlin-Lynn/followers","following_url":"https://api.github.com/users/yanlin-Lynn/following{/other_user}","gists_url":"https://api.github.com/users/yanlin-Lynn/gists{/gist_id}","starred_url":"https://api.github.com/users/yanlin-Lynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanlin-Lynn/subscriptions","organizations_url":"https://api.github.com/users/yanlin-Lynn/orgs","repos_url":"https://api.github.com/users/yanlin-Lynn/repos","events_url":"https://api.github.com/users/yanlin-Lynn/events{/privacy}","received_events_url":"https://api.github.com/users/yanlin-Lynn/received_events","type":"User","site_admin":false},"repo":{"id":115577076,"name":"spark","full_name":"yanlin-Lynn/spark","owner":{"login":"yanlin-Lynn","id":32827886,"avatar_url":"https://avatars0.githubusercontent.com/u/32827886?v=4","gravatar_id":"","url":"https://api.github.com/users/yanlin-Lynn","html_url":"https://github.com/yanlin-Lynn","followers_url":"https://api.github.com/users/yanlin-Lynn/followers","following_url":"https://api.github.com/users/yanlin-Lynn/following{/other_user}","gists_url":"https://api.github.com/users/yanlin-Lynn/gists{/gist_id}","starred_url":"https://api.github.com/users/yanlin-Lynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yanlin-Lynn/subscriptions","organizations_url":"https://api.github.com/users/yanlin-Lynn/orgs","repos_url":"https://api.github.com/users/yanlin-Lynn/repos","events_url":"https://api.github.com/users/yanlin-Lynn/events{/privacy}","received_events_url":"https://api.github.com/users/yanlin-Lynn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yanlin-Lynn/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/yanlin-Lynn/spark","forks_url":"https://api.github.com/repos/yanlin-Lynn/spark/forks","keys_url":"https://api.github.com/repos/yanlin-Lynn/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yanlin-Lynn/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yanlin-Lynn/spark/teams","hooks_url":"https://api.github.com/repos/yanlin-Lynn/spark/hooks","issue_events_url":"https://api.github.com/repos/yanlin-Lynn/spark/issues/events{/number}","events_url":"https://api.github.com/repos/yanlin-Lynn/spark/events","assignees_url":"https://api.github.com/repos/yanlin-Lynn/spark/assignees{/user}","branches_url":"https://api.github.com/repos/yanlin-Lynn/spark/branches{/branch}","tags_url":"https://api.github.com/repos/yanlin-Lynn/spark/tags","blobs_url":"https://api.github.com/repos/yanlin-Lynn/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yanlin-Lynn/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yanlin-Lynn/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/yanlin-Lynn/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yanlin-Lynn/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/yanlin-Lynn/spark/languages","stargazers_url":"https://api.github.com/repos/yanlin-Lynn/spark/stargazers","contributors_url":"https://api.github.com/repos/yanlin-Lynn/spark/contributors","subscribers_url":"https://api.github.com/repos/yanlin-Lynn/spark/subscribers","subscription_url":"https://api.github.com/repos/yanlin-Lynn/spark/subscription","commits_url":"https://api.github.com/repos/yanlin-Lynn/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/yanlin-Lynn/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/yanlin-Lynn/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/yanlin-Lynn/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/yanlin-Lynn/spark/contents/{+path}","compare_url":"https://api.github.com/repos/yanlin-Lynn/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yanlin-Lynn/spark/merges","archive_url":"https://api.github.com/repos/yanlin-Lynn/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yanlin-Lynn/spark/downloads","issues_url":"https://api.github.com/repos/yanlin-Lynn/spark/issues{/number}","pulls_url":"https://api.github.com/repos/yanlin-Lynn/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/yanlin-Lynn/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/yanlin-Lynn/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yanlin-Lynn/spark/labels{/name}","releases_url":"https://api.github.com/repos/yanlin-Lynn/spark/releases{/id}","deployments_url":"https://api.github.com/repos/yanlin-Lynn/spark/deployments","created_at":"2017-12-28T02:38:42Z","updated_at":"2017-12-28T02:39:08Z","pushed_at":"2018-02-07T11:15:12Z","git_url":"git://github.com/yanlin-Lynn/spark.git","ssh_url":"git@github.com:yanlin-Lynn/spark.git","clone_url":"https://github.com/yanlin-Lynn/spark.git","svn_url":"https://github.com/yanlin-Lynn/spark","homepage":null,"size":267152,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c36fecc3b416c38002779c3cf40b6a665ac4bf13","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-02-08T05:55:56Z","pushed_at":"2018-02-08T08:09:27Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":267589,"stargazers_count":16101,"watchers_count":16101,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14902,"mirror_url":null,"archived":false,"open_issues_count":421,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":14902,"open_issues":421,"watchers":16101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/20529"},"html":{"href":"https://github.com/apache/spark/pull/20529"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/20529"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/20529/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/20529/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/20529/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/f1106f33c583f9cba0fd31a5783e12ab211d7e81"}},"author_association":"NONE"}}
{"actor":{"display_login":"jerryshao"}}