{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/3728","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/3728/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3728/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/3728/events","html_url":"https://github.com/codice/ddf/pull/3728","id":359594930,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDUwODI3","number":3728,"title":"[2.13.x] DDF-4135 Don't overwite internal ports with external ports","user":{"login":"kcover","id":22778496,"node_id":"MDQ6VXNlcjIyNzc4NDk2","avatar_url":"https://avatars0.githubusercontent.com/u/22778496?v=4","gravatar_id":"","url":"https://api.github.com/users/kcover","html_url":"https://github.com/kcover","followers_url":"https://api.github.com/users/kcover/followers","following_url":"https://api.github.com/users/kcover/following{/other_user}","gists_url":"https://api.github.com/users/kcover/gists{/gist_id}","starred_url":"https://api.github.com/users/kcover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcover/subscriptions","organizations_url":"https://api.github.com/users/kcover/orgs","repos_url":"https://api.github.com/users/kcover/repos","events_url":"https://api.github.com/users/kcover/events{/privacy}","received_events_url":"https://api.github.com/users/kcover/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"clockard","id":5248090,"node_id":"MDQ6VXNlcjUyNDgwOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5248090?v=4","gravatar_id":"","url":"https://api.github.com/users/clockard","html_url":"https://github.com/clockard","followers_url":"https://api.github.com/users/clockard/followers","following_url":"https://api.github.com/users/clockard/following{/other_user}","gists_url":"https://api.github.com/users/clockard/gists{/gist_id}","starred_url":"https://api.github.com/users/clockard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clockard/subscriptions","organizations_url":"https://api.github.com/users/clockard/orgs","repos_url":"https://api.github.com/users/clockard/repos","events_url":"https://api.github.com/users/clockard/events{/privacy}","received_events_url":"https://api.github.com/users/clockard/received_events","type":"User","site_admin":false},"assignees":[{"login":"clockard","id":5248090,"node_id":"MDQ6VXNlcjUyNDgwOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5248090?v=4","gravatar_id":"","url":"https://api.github.com/users/clockard","html_url":"https://github.com/clockard","followers_url":"https://api.github.com/users/clockard/followers","following_url":"https://api.github.com/users/clockard/following{/other_user}","gists_url":"https://api.github.com/users/clockard/gists{/gist_id}","starred_url":"https://api.github.com/users/clockard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clockard/subscriptions","organizations_url":"https://api.github.com/users/clockard/orgs","repos_url":"https://api.github.com/users/clockard/repos","events_url":"https://api.github.com/users/clockard/events{/privacy}","received_events_url":"https://api.github.com/users/clockard/received_events","type":"User","site_admin":false},{"login":"vinamartin","id":9013407,"node_id":"MDQ6VXNlcjkwMTM0MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/9013407?v=4","gravatar_id":"","url":"https://api.github.com/users/vinamartin","html_url":"https://github.com/vinamartin","followers_url":"https://api.github.com/users/vinamartin/followers","following_url":"https://api.github.com/users/vinamartin/following{/other_user}","gists_url":"https://api.github.com/users/vinamartin/gists{/gist_id}","starred_url":"https://api.github.com/users/vinamartin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinamartin/subscriptions","organizations_url":"https://api.github.com/users/vinamartin/orgs","repos_url":"https://api.github.com/users/vinamartin/repos","events_url":"https://api.github.com/users/vinamartin/events{/privacy}","received_events_url":"https://api.github.com/users/vinamartin/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/codice/ddf/milestones/23","html_url":"https://github.com/codice/ddf/milestone/23","labels_url":"https://api.github.com/repos/codice/ddf/milestones/23/labels","id":3566137,"node_id":"MDk6TWlsZXN0b25lMzU2NjEzNw==","number":23,"title":"2.13.2","description":"","creator":{"login":"clockard","id":5248090,"node_id":"MDQ6VXNlcjUyNDgwOTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5248090?v=4","gravatar_id":"","url":"https://api.github.com/users/clockard","html_url":"https://github.com/clockard","followers_url":"https://api.github.com/users/clockard/followers","following_url":"https://api.github.com/users/clockard/following{/other_user}","gists_url":"https://api.github.com/users/clockard/gists{/gist_id}","starred_url":"https://api.github.com/users/clockard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clockard/subscriptions","organizations_url":"https://api.github.com/users/clockard/orgs","repos_url":"https://api.github.com/users/clockard/repos","events_url":"https://api.github.com/users/clockard/events{/privacy}","received_events_url":"https://api.github.com/users/clockard/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":21,"state":"open","created_at":"2018-08-13T15:58:34Z","updated_at":"2018-09-13T21:43:49Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2018-09-12T18:13:46Z","updated_at":"2018-09-14T00:12:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3728","html_url":"https://github.com/codice/ddf/pull/3728","diff_url":"https://github.com/codice/ddf/pull/3728.diff","patch_url":"https://github.com/codice/ddf/pull/3728.patch"},"body":"#### What does this PR do?\r\n\r\nThis commit changes the SystemPropertiesAdmin to no longer overwrite the\r\nsystem ports whenever the external ports are changed. Now if the user\r\nchanges their external ports before install, the installer won't\r\noverwrite the system ports. Changing the ports in the installer will\r\nalso only change the external ports, as it says it will.\r\n\r\n#### Who is reviewing it? \r\n\r\n@peterhuffer @emmberk \r\n\r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n\r\n@clockard \r\n@vinamartin\r\n\r\n#### How should this be tested?\r\n\r\nUnzip ddf and in the system.properties file find the external host, protocol, http port, and https port and change them. Go through the installer and when you get to the page that displays the ports/hostname make sure they have values you gave them. After installing, go back into the system.properties file and make sure the system host, protocol, and ports haven't been overwritten with the values you gave the external ones.\r\n\r\n#### What are the relevant tickets?\r\n\r\n[DDF-4135](https://codice.atlassian.net/browse/DDF-4135)\r\n\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [x] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/421190681","html_url":"https://github.com/codice/ddf/pull/3728#issuecomment-421190681","issue_url":"https://api.github.com/repos/codice/ddf/issues/3728","id":421190681,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTE5MDY4MQ==","user":{"login":"cxbot","id":21088360,"node_id":"MDQ6VXNlcjIxMDg4MzYw","avatar_url":"https://avatars2.githubusercontent.com/u/21088360?v=4","gravatar_id":"","url":"https://api.github.com/users/cxbot","html_url":"https://github.com/cxbot","followers_url":"https://api.github.com/users/cxbot/followers","following_url":"https://api.github.com/users/cxbot/following{/other_user}","gists_url":"https://api.github.com/users/cxbot/gists{/gist_id}","starred_url":"https://api.github.com/users/cxbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cxbot/subscriptions","organizations_url":"https://api.github.com/users/cxbot/orgs","repos_url":"https://api.github.com/users/cxbot/repos","events_url":"https://api.github.com/users/cxbot/events{/privacy}","received_events_url":"https://api.github.com/users/cxbot/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T00:12:19Z","updated_at":"2018-09-14T00:12:19Z","author_association":"COLLABORATOR","body":"Internal build has been scheduled, your results will be available at build completion."}}
{"actor":{"display_login":"cxbot"}}