{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/376","repository_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack","labels_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/376/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/376/comments","events_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/376/events","html_url":"https://github.com/kubernetes/cloud-provider-openstack/pull/376","id":383584366,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDE4MTIx","number":376,"title":"Move loadbalancer annotations to the service","user":{"login":"ainmosni","id":1147920,"node_id":"MDQ6VXNlcjExNDc5MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1147920?v=4","gravatar_id":"","url":"https://api.github.com/users/ainmosni","html_url":"https://github.com/ainmosni","followers_url":"https://api.github.com/users/ainmosni/followers","following_url":"https://api.github.com/users/ainmosni/following{/other_user}","gists_url":"https://api.github.com/users/ainmosni/gists{/gist_id}","starred_url":"https://api.github.com/users/ainmosni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ainmosni/subscriptions","organizations_url":"https://api.github.com/users/ainmosni/orgs","repos_url":"https://api.github.com/users/ainmosni/repos","events_url":"https://api.github.com/users/ainmosni/events{/privacy}","received_events_url":"https://api.github.com/users/ainmosni/received_events","type":"User","site_admin":false},"labels":[{"id":875191555,"node_id":"MDU6TGFiZWw4NzUxOTE1NTU=","url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":875378880,"node_id":"MDU6TGFiZWw4NzUzNzg4ODA=","url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":875377870,"node_id":"MDU6TGFiZWw4NzUzNzc4NzA=","url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-22T15:37:14Z","updated_at":"2018-11-22T15:37:22Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/pulls/376","html_url":"https://github.com/kubernetes/cloud-provider-openstack/pull/376","diff_url":"https://github.com/kubernetes/cloud-provider-openstack/pull/376.diff","patch_url":"https://github.com/kubernetes/cloud-provider-openstack/pull/376.patch"},"body":"For the loadbalancer annotations to have any effect, they need to be in\r\nthe service definition not in the deployment.\r\n\r\n**What this PR does / why we need it**:\r\n\r\nIt moves the loadbalancer annotations in the loadbalancers examples to the right resource.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #375 "},"comment":{"url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/comments/441065252","html_url":"https://github.com/kubernetes/cloud-provider-openstack/pull/376#issuecomment-441065252","issue_url":"https://api.github.com/repos/kubernetes/cloud-provider-openstack/issues/376","id":441065252,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTA2NTI1Mg==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-11-22T15:37:22Z","updated_at":"2018-11-22T15:37:22Z","author_association":"CONTRIBUTOR","body":"Hi @ainmosni. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nOnce the patch is verified, the new status will be reflected by the `ok-to-test` label.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n"}}
{"actor":{"display_login":"k8s-ci-robot"}}