{"action":"created","comment":{"url":"https://api.github.com/repos/allenai/allennlp/pulls/comments/237612566","pull_request_review_id":179955425,"id":237612566,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzYxMjU2Ng==","diff_hunk":"@@ -104,26 +108,7 @@ def test_forward_runs_with_non_bijective_mapping(self):\n                 }\n         token_embedder(inputs)\n \n-    def test_old_from_params_new_from_params(self):","path":"allennlp/tests/modules/text_field_embedders/basic_text_field_embedder_test.py","position":null,"original_position":77,"commit_id":"87c464808f92814a05846db7f5f652de5fc38d49","original_commit_id":"98188e2803dc56979e5695461561176dc7e8795a","user":{"login":"schmmd","id":954798,"node_id":"MDQ6VXNlcjk1NDc5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/954798?v=4","gravatar_id":"","url":"https://api.github.com/users/schmmd","html_url":"https://github.com/schmmd","followers_url":"https://api.github.com/users/schmmd/followers","following_url":"https://api.github.com/users/schmmd/following{/other_user}","gists_url":"https://api.github.com/users/schmmd/gists{/gist_id}","starred_url":"https://api.github.com/users/schmmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmmd/subscriptions","organizations_url":"https://api.github.com/users/schmmd/orgs","repos_url":"https://api.github.com/users/schmmd/repos","events_url":"https://api.github.com/users/schmmd/events{/privacy}","received_events_url":"https://api.github.com/users/schmmd/received_events","type":"User","site_admin":false},"body":"I also added a test to make sure the keys match regardless of how they are passed in.  The old test just made sure the old way didn't throw an exception and instead logged a warning.","created_at":"2018-11-29T18:47:45Z","updated_at":"2018-11-29T18:47:46Z","html_url":"https://github.com/allenai/allennlp/pull/2114#discussion_r237612566","pull_request_url":"https://api.github.com/repos/allenai/allennlp/pulls/2114","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/comments/237612566"},"html":{"href":"https://github.com/allenai/allennlp/pull/2114#discussion_r237612566"},"pull_request":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/2114"}},"in_reply_to_id":237608738},"pull_request":{"url":"https://api.github.com/repos/allenai/allennlp/pulls/2114","id":234726153,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NzI2MTUz","html_url":"https://github.com/allenai/allennlp/pull/2114","diff_url":"https://github.com/allenai/allennlp/pull/2114.diff","patch_url":"https://github.com/allenai/allennlp/pull/2114.patch","issue_url":"https://api.github.com/repos/allenai/allennlp/issues/2114","number":2114,"state":"open","locked":false,"title":"Remove the BasicTextFieldEmbedder warning","user":{"login":"schmmd","id":954798,"node_id":"MDQ6VXNlcjk1NDc5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/954798?v=4","gravatar_id":"","url":"https://api.github.com/users/schmmd","html_url":"https://github.com/schmmd","followers_url":"https://api.github.com/users/schmmd/followers","following_url":"https://api.github.com/users/schmmd/following{/other_user}","gists_url":"https://api.github.com/users/schmmd/gists{/gist_id}","starred_url":"https://api.github.com/users/schmmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmmd/subscriptions","organizations_url":"https://api.github.com/users/schmmd/orgs","repos_url":"https://api.github.com/users/schmmd/repos","events_url":"https://api.github.com/users/schmmd/events{/privacy}","received_events_url":"https://api.github.com/users/schmmd/received_events","type":"User","site_admin":false},"body":"While we would like to discourage the original behavior, we would like to remove the deprecation warning because we still follow it throughout our test fixtures and full models.  We can formally deprecate this behavior when AllenNLP gets off it.","created_at":"2018-11-29T17:36:36Z","updated_at":"2018-11-29T18:47:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8af2e3d880f5e82d94bb3e8a606440c2553e09c","assignee":{"login":"joelgrus","id":1308313,"node_id":"MDQ6VXNlcjEzMDgzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1308313?v=4","gravatar_id":"","url":"https://api.github.com/users/joelgrus","html_url":"https://github.com/joelgrus","followers_url":"https://api.github.com/users/joelgrus/followers","following_url":"https://api.github.com/users/joelgrus/following{/other_user}","gists_url":"https://api.github.com/users/joelgrus/gists{/gist_id}","starred_url":"https://api.github.com/users/joelgrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelgrus/subscriptions","organizations_url":"https://api.github.com/users/joelgrus/orgs","repos_url":"https://api.github.com/users/joelgrus/repos","events_url":"https://api.github.com/users/joelgrus/events{/privacy}","received_events_url":"https://api.github.com/users/joelgrus/received_events","type":"User","site_admin":false},"assignees":[{"login":"joelgrus","id":1308313,"node_id":"MDQ6VXNlcjEzMDgzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1308313?v=4","gravatar_id":"","url":"https://api.github.com/users/joelgrus","html_url":"https://github.com/joelgrus","followers_url":"https://api.github.com/users/joelgrus/followers","following_url":"https://api.github.com/users/joelgrus/following{/other_user}","gists_url":"https://api.github.com/users/joelgrus/gists{/gist_id}","starred_url":"https://api.github.com/users/joelgrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelgrus/subscriptions","organizations_url":"https://api.github.com/users/joelgrus/orgs","repos_url":"https://api.github.com/users/joelgrus/repos","events_url":"https://api.github.com/users/joelgrus/events{/privacy}","received_events_url":"https://api.github.com/users/joelgrus/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/allenai/allennlp/pulls/2114/commits","review_comments_url":"https://api.github.com/repos/allenai/allennlp/pulls/2114/comments","review_comment_url":"https://api.github.com/repos/allenai/allennlp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/allenai/allennlp/issues/2114/comments","statuses_url":"https://api.github.com/repos/allenai/allennlp/statuses/87c464808f92814a05846db7f5f652de5fc38d49","head":{"label":"schmmd:basic-warning","ref":"basic-warning","sha":"87c464808f92814a05846db7f5f652de5fc38d49","user":{"login":"schmmd","id":954798,"node_id":"MDQ6VXNlcjk1NDc5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/954798?v=4","gravatar_id":"","url":"https://api.github.com/users/schmmd","html_url":"https://github.com/schmmd","followers_url":"https://api.github.com/users/schmmd/followers","following_url":"https://api.github.com/users/schmmd/following{/other_user}","gists_url":"https://api.github.com/users/schmmd/gists{/gist_id}","starred_url":"https://api.github.com/users/schmmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmmd/subscriptions","organizations_url":"https://api.github.com/users/schmmd/orgs","repos_url":"https://api.github.com/users/schmmd/repos","events_url":"https://api.github.com/users/schmmd/events{/privacy}","received_events_url":"https://api.github.com/users/schmmd/received_events","type":"User","site_admin":false},"repo":{"id":95493347,"node_id":"MDEwOlJlcG9zaXRvcnk5NTQ5MzM0Nw==","name":"allennlp","full_name":"schmmd/allennlp","private":false,"owner":{"login":"schmmd","id":954798,"node_id":"MDQ6VXNlcjk1NDc5OA==","avatar_url":"https://avatars3.githubusercontent.com/u/954798?v=4","gravatar_id":"","url":"https://api.github.com/users/schmmd","html_url":"https://github.com/schmmd","followers_url":"https://api.github.com/users/schmmd/followers","following_url":"https://api.github.com/users/schmmd/following{/other_user}","gists_url":"https://api.github.com/users/schmmd/gists{/gist_id}","starred_url":"https://api.github.com/users/schmmd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmmd/subscriptions","organizations_url":"https://api.github.com/users/schmmd/orgs","repos_url":"https://api.github.com/users/schmmd/repos","events_url":"https://api.github.com/users/schmmd/events{/privacy}","received_events_url":"https://api.github.com/users/schmmd/received_events","type":"User","site_admin":false},"html_url":"https://github.com/schmmd/allennlp","description":"A natural language processing toolkit using state-of-the-art deep learning models.","fork":true,"url":"https://api.github.com/repos/schmmd/allennlp","forks_url":"https://api.github.com/repos/schmmd/allennlp/forks","keys_url":"https://api.github.com/repos/schmmd/allennlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schmmd/allennlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schmmd/allennlp/teams","hooks_url":"https://api.github.com/repos/schmmd/allennlp/hooks","issue_events_url":"https://api.github.com/repos/schmmd/allennlp/issues/events{/number}","events_url":"https://api.github.com/repos/schmmd/allennlp/events","assignees_url":"https://api.github.com/repos/schmmd/allennlp/assignees{/user}","branches_url":"https://api.github.com/repos/schmmd/allennlp/branches{/branch}","tags_url":"https://api.github.com/repos/schmmd/allennlp/tags","blobs_url":"https://api.github.com/repos/schmmd/allennlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schmmd/allennlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schmmd/allennlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/schmmd/allennlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schmmd/allennlp/statuses/{sha}","languages_url":"https://api.github.com/repos/schmmd/allennlp/languages","stargazers_url":"https://api.github.com/repos/schmmd/allennlp/stargazers","contributors_url":"https://api.github.com/repos/schmmd/allennlp/contributors","subscribers_url":"https://api.github.com/repos/schmmd/allennlp/subscribers","subscription_url":"https://api.github.com/repos/schmmd/allennlp/subscription","commits_url":"https://api.github.com/repos/schmmd/allennlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/schmmd/allennlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/schmmd/allennlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/schmmd/allennlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/schmmd/allennlp/contents/{+path}","compare_url":"https://api.github.com/repos/schmmd/allennlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schmmd/allennlp/merges","archive_url":"https://api.github.com/repos/schmmd/allennlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schmmd/allennlp/downloads","issues_url":"https://api.github.com/repos/schmmd/allennlp/issues{/number}","pulls_url":"https://api.github.com/repos/schmmd/allennlp/pulls{/number}","milestones_url":"https://api.github.com/repos/schmmd/allennlp/milestones{/number}","notifications_url":"https://api.github.com/repos/schmmd/allennlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schmmd/allennlp/labels{/name}","releases_url":"https://api.github.com/repos/schmmd/allennlp/releases{/id}","deployments_url":"https://api.github.com/repos/schmmd/allennlp/deployments","created_at":"2017-06-26T22:04:12Z","updated_at":"2018-10-25T21:24:19Z","pushed_at":"2018-11-29T18:47:12Z","git_url":"git://github.com/schmmd/allennlp.git","ssh_url":"git@github.com:schmmd/allennlp.git","clone_url":"https://github.com/schmmd/allennlp.git","svn_url":"https://github.com/schmmd/allennlp","homepage":null,"size":54143,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"allenai:master","ref":"master","sha":"92c71a172e3db498b22fdd052f56e23d9506a49b","user":{"login":"allenai","id":5667695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2Njc2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"repo":{"id":91356408,"node_id":"MDEwOlJlcG9zaXRvcnk5MTM1NjQwOA==","name":"allennlp","full_name":"allenai/allennlp","private":false,"owner":{"login":"allenai","id":5667695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2Njc2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/allenai/allennlp","description":"An open-source NLP research library, built on PyTorch.","fork":false,"url":"https://api.github.com/repos/allenai/allennlp","forks_url":"https://api.github.com/repos/allenai/allennlp/forks","keys_url":"https://api.github.com/repos/allenai/allennlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allenai/allennlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allenai/allennlp/teams","hooks_url":"https://api.github.com/repos/allenai/allennlp/hooks","issue_events_url":"https://api.github.com/repos/allenai/allennlp/issues/events{/number}","events_url":"https://api.github.com/repos/allenai/allennlp/events","assignees_url":"https://api.github.com/repos/allenai/allennlp/assignees{/user}","branches_url":"https://api.github.com/repos/allenai/allennlp/branches{/branch}","tags_url":"https://api.github.com/repos/allenai/allennlp/tags","blobs_url":"https://api.github.com/repos/allenai/allennlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allenai/allennlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allenai/allennlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/allenai/allennlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allenai/allennlp/statuses/{sha}","languages_url":"https://api.github.com/repos/allenai/allennlp/languages","stargazers_url":"https://api.github.com/repos/allenai/allennlp/stargazers","contributors_url":"https://api.github.com/repos/allenai/allennlp/contributors","subscribers_url":"https://api.github.com/repos/allenai/allennlp/subscribers","subscription_url":"https://api.github.com/repos/allenai/allennlp/subscription","commits_url":"https://api.github.com/repos/allenai/allennlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/allenai/allennlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/allenai/allennlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/allenai/allennlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/allenai/allennlp/contents/{+path}","compare_url":"https://api.github.com/repos/allenai/allennlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allenai/allennlp/merges","archive_url":"https://api.github.com/repos/allenai/allennlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allenai/allennlp/downloads","issues_url":"https://api.github.com/repos/allenai/allennlp/issues{/number}","pulls_url":"https://api.github.com/repos/allenai/allennlp/pulls{/number}","milestones_url":"https://api.github.com/repos/allenai/allennlp/milestones{/number}","notifications_url":"https://api.github.com/repos/allenai/allennlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allenai/allennlp/labels{/name}","releases_url":"https://api.github.com/repos/allenai/allennlp/releases{/id}","deployments_url":"https://api.github.com/repos/allenai/allennlp/deployments","created_at":"2017-05-15T15:52:41Z","updated_at":"2018-11-29T17:47:06Z","pushed_at":"2018-11-29T18:47:14Z","git_url":"git://github.com/allenai/allennlp.git","ssh_url":"git@github.com:allenai/allennlp.git","clone_url":"https://github.com/allenai/allennlp.git","svn_url":"https://github.com/allenai/allennlp","homepage":"http://www.allennlp.org/","size":53869,"stargazers_count":4366,"watchers_count":4366,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":803,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":803,"open_issues":99,"watchers":4366,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/2114"},"html":{"href":"https://github.com/allenai/allennlp/pull/2114"},"issue":{"href":"https://api.github.com/repos/allenai/allennlp/issues/2114"},"comments":{"href":"https://api.github.com/repos/allenai/allennlp/issues/2114/comments"},"review_comments":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/2114/comments"},"review_comment":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/2114/commits"},"statuses":{"href":"https://api.github.com/repos/allenai/allennlp/statuses/87c464808f92814a05846db7f5f652de5fc38d49"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"schmmd"}}