{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/cluster-registry/issues/204","repository_url":"https://api.github.com/repos/kubernetes/cluster-registry","labels_url":"https://api.github.com/repos/kubernetes/cluster-registry/issues/204/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/cluster-registry/issues/204/comments","events_url":"https://api.github.com/repos/kubernetes/cluster-registry/issues/204/events","html_url":"https://github.com/kubernetes/cluster-registry/pull/204","id":299198718,"number":204,"title":"Fix clusterregistry.k8s.io:apiserver ClusterRole","user":{"login":"mlowery","id":976779,"avatar_url":"https://avatars0.githubusercontent.com/u/976779?v=4","gravatar_id":"","url":"https://api.github.com/users/mlowery","html_url":"https://github.com/mlowery","followers_url":"https://api.github.com/users/mlowery/followers","following_url":"https://api.github.com/users/mlowery/following{/other_user}","gists_url":"https://api.github.com/users/mlowery/gists{/gist_id}","starred_url":"https://api.github.com/users/mlowery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlowery/subscriptions","organizations_url":"https://api.github.com/users/mlowery/orgs","repos_url":"https://api.github.com/users/mlowery/repos","events_url":"https://api.github.com/users/mlowery/events{/privacy}","received_events_url":"https://api.github.com/users/mlowery/received_events","type":"User","site_admin":false},"labels":[{"id":718256675,"url":"https://api.github.com/repos/kubernetes/cluster-registry/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":718260643,"url":"https://api.github.com/repos/kubernetes/cluster-registry/labels/sig/multicluster","name":"sig/multicluster","color":"d2b48c","default":false},{"id":698318529,"url":"https://api.github.com/repos/kubernetes/cluster-registry/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-22T02:14:31Z","updated_at":"2018-02-22T02:14:38Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/cluster-registry/pulls/204","html_url":"https://github.com/kubernetes/cluster-registry/pull/204","diff_url":"https://github.com/kubernetes/cluster-registry/pull/204.diff","patch_url":"https://github.com/kubernetes/cluster-registry/pull/204.patch"},"body":"I discovered this when I attempted to create a new `ClusterRoleBinding` referencing this `ClusterRole`. Until I changed from `cluster` to `clusters`, it didn't work.\r\n\r\nBefore:\r\n\r\n```yaml\r\napiVersion: rbac.authorization.k8s.io/v1\r\nkind: ClusterRole\r\nmetadata:\r\n  labels:\r\n    app: clusterregistry\r\n  name: clusterregistry.k8s.io:apiserver\r\nrules:\r\n- apiGroups:\r\n  - clusterregistry.k8s.io\r\n  resources:\r\n  - cluster\r\n  verbs:\r\n  - get\r\n  - list\r\n  - watch\r\n  - create\r\n  - update\r\n  - patch\r\n  - delete\r\n```\r\n\r\nAfter (only change is `clusters` under `resources`):\r\n\r\n```yaml\r\napiVersion: rbac.authorization.k8s.io/v1\r\nkind: ClusterRole\r\nmetadata:\r\n  labels:\r\n    app: clusterregistry\r\n  name: clusterregistry.k8s.io:apiserver\r\nrules:\r\n- apiGroups:\r\n  - clusterregistry.k8s.io\r\n  resources:\r\n  - clusters\r\n  verbs:\r\n  - get\r\n  - list\r\n  - watch\r\n  - create\r\n  - update\r\n  - patch\r\n  - delete\r\n```\r\n\r\nThis brings up another question. What is the purpose of this `ClusterRole`? It's bound to the `ServiceAccount` in the `ClusterRoleBinding` of the same name but I'm not familiar with when that would be used. Any instruction here would be appreciated.\r\n\r\n<!-- Labels this issue with the sig/multicluster label. Please do not remove. -->\r\n\r\n/sig multicluster\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/cluster-registry/issues/comments/367544442","html_url":"https://github.com/kubernetes/cluster-registry/pull/204#issuecomment-367544442","issue_url":"https://api.github.com/repos/kubernetes/cluster-registry/issues/204","id":367544442,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-02-22T02:14:38Z","updated_at":"2018-02-22T02:14:38Z","author_association":"CONTRIBUTOR","body":"Hi @mlowery. Thanks for your PR.\n\nI'm waiting for a [kubernetes](https://github.com/orgs/kubernetes/people) member to verify that this patch is reasonable to test. If it is, they should reply with `/ok-to-test` on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should [join the org](https://git.k8s.io/community/community-membership.md#member) to skip this step.\n\nI understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.\n</details>\n"}}
{"actor":{"display_login":"k8s-ci-robot"}}