{"action":"created","comment":{"url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/comments/186729594","pull_request_review_id":118364749,"id":186729594,"diff_hunk":"@@ -53,7 +53,11 @@ export class SearchNumberRangeComponent implements SearchWidget, OnInit {\n         this.form = new FormGroup({\n             from: this.from,\n             to: this.to\n-        });\n+        }, this.formValidator);\n+    }\n+\n+    formValidator(g: FormGroup) {","path":"lib/content-services/search/components/search-number-range/search-number-range.component.ts","position":8,"original_position":8,"commit_id":"c0fa025162c3f2afc85fcd34ce4ebaa902e4c969","original_commit_id":"c0fa025162c3f2afc85fcd34ce4ebaa902e4c969","user":{"login":"eromano","id":1030050,"avatar_url":"https://avatars1.githubusercontent.com/u/1030050?v=4","gravatar_id":"","url":"https://api.github.com/users/eromano","html_url":"https://github.com/eromano","followers_url":"https://api.github.com/users/eromano/followers","following_url":"https://api.github.com/users/eromano/following{/other_user}","gists_url":"https://api.github.com/users/eromano/gists{/gist_id}","starred_url":"https://api.github.com/users/eromano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eromano/subscriptions","organizations_url":"https://api.github.com/users/eromano/orgs","repos_url":"https://api.github.com/users/eromano/repos","events_url":"https://api.github.com/users/eromano/events{/privacy}","received_events_url":"https://api.github.com/users/eromano/received_events","type":"User","site_admin":false},"body":"please do not use one character variable name are really bad for readability","created_at":"2018-05-08T13:38:55Z","updated_at":"2018-05-08T13:39:01Z","html_url":"https://github.com/Alfresco/alfresco-ng2-components/pull/3279#discussion_r186729594","pull_request_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/3279","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/comments/186729594"},"html":{"href":"https://github.com/Alfresco/alfresco-ng2-components/pull/3279#discussion_r186729594"},"pull_request":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/3279"}}},"pull_request":{"url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/3279","id":186618465,"html_url":"https://github.com/Alfresco/alfresco-ng2-components/pull/3279","diff_url":"https://github.com/Alfresco/alfresco-ng2-components/pull/3279.diff","patch_url":"https://github.com/Alfresco/alfresco-ng2-components/pull/3279.patch","issue_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/3279","number":3279,"state":"open","locked":false,"title":"[ADF-2916] number range form validator added","user":{"login":"bbcodrin","id":28699600,"avatar_url":"https://avatars3.githubusercontent.com/u/28699600?v=4","gravatar_id":"","url":"https://api.github.com/users/bbcodrin","html_url":"https://github.com/bbcodrin","followers_url":"https://api.github.com/users/bbcodrin/followers","following_url":"https://api.github.com/users/bbcodrin/following{/other_user}","gists_url":"https://api.github.com/users/bbcodrin/gists{/gist_id}","starred_url":"https://api.github.com/users/bbcodrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbcodrin/subscriptions","organizations_url":"https://api.github.com/users/bbcodrin/orgs","repos_url":"https://api.github.com/users/bbcodrin/repos","events_url":"https://api.github.com/users/bbcodrin/events{/privacy}","received_events_url":"https://api.github.com/users/bbcodrin/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n\r\n> - [X] The commit message follows our [guidelines](https://github.com/Alfresco/alfresco-ng2-components/wiki/Commit-format)\r\n> - [ ] Tests for the changes have been added (for bug fixes / features)\r\n> - [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n<!--\r\n Before submitting your PR, please check that your code follows our contribution guidelines:\r\n https://github.com/Alfresco/alfresco-ng2-components/wiki/Code-contribution-acceptance-criteria\r\n -->\r\n\r\n**What kind of change does this PR introduce?** (check one with \"x\")\r\n\r\n> - [X] Bugfix\r\n> - [ ] Feature\r\n> - [ ] Code style update (formatting, local variables)\r\n> - [ ] Refactoring (no functional changes, no api changes)\r\n> - [ ] Build related changes\r\n> - [ ] Documentation\r\n> - [ ] Other... Please describe:\r\n\r\n\r\n**What is the current behaviour?** (You can also link to an open issue here)\r\nIf FROM value is bigger than TO value, we still make an backend call, even if we know that list will be empty.\r\nhttps://issues.alfresco.com/jira/browse/ADF-2916\r\n\r\n\r\n**What is the new behaviour?**\r\nThat behaviour is deactivated now. If FROM value is bigger than TO value, APPLY button will be disabled.\r\n\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n\r\n> - [ ] Yes\r\n> - [X] No\r\n\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n**Other information**:\r\n","created_at":"2018-05-08T12:28:44Z","updated_at":"2018-05-08T13:39:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"660cad9db73a075474f34d9f9340df1719c65841","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mauriziovitale","id":14923305,"avatar_url":"https://avatars3.githubusercontent.com/u/14923305?v=4","gravatar_id":"","url":"https://api.github.com/users/mauriziovitale","html_url":"https://github.com/mauriziovitale","followers_url":"https://api.github.com/users/mauriziovitale/followers","following_url":"https://api.github.com/users/mauriziovitale/following{/other_user}","gists_url":"https://api.github.com/users/mauriziovitale/gists{/gist_id}","starred_url":"https://api.github.com/users/mauriziovitale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mauriziovitale/subscriptions","organizations_url":"https://api.github.com/users/mauriziovitale/orgs","repos_url":"https://api.github.com/users/mauriziovitale/repos","events_url":"https://api.github.com/users/mauriziovitale/events{/privacy}","received_events_url":"https://api.github.com/users/mauriziovitale/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/3279/commits","review_comments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/3279/comments","review_comment_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/3279/comments","statuses_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/statuses/c0fa025162c3f2afc85fcd34ce4ebaa902e4c969","head":{"label":"Alfresco:dev-cbobu-ADF-2916","ref":"dev-cbobu-ADF-2916","sha":"c0fa025162c3f2afc85fcd34ce4ebaa902e4c969","user":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":55400726,"name":"alfresco-ng2-components","full_name":"Alfresco/alfresco-ng2-components","owner":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alfresco/alfresco-ng2-components","description":"Alfresco Angular Components","fork":false,"url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components","forks_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/forks","keys_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/teams","hooks_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/events","assignees_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/tags","blobs_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/languages","stargazers_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/subscription","commits_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/merges","archive_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/downloads","issues_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/releases{/id}","deployments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/deployments","created_at":"2016-04-04T09:54:25Z","updated_at":"2018-05-06T08:21:24Z","pushed_at":"2018-05-08T13:27:09Z","git_url":"git://github.com/Alfresco/alfresco-ng2-components.git","ssh_url":"git@github.com:Alfresco/alfresco-ng2-components.git","clone_url":"https://github.com/Alfresco/alfresco-ng2-components.git","svn_url":"https://github.com/Alfresco/alfresco-ng2-components","homepage":"https://alfresco.github.io/adf-component-catalog/","size":96489,"stargazers_count":160,"watchers_count":160,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":80,"open_issues":47,"watchers":160,"default_branch":"master"}},"base":{"label":"Alfresco:development","ref":"development","sha":"87a464907c44fd306461491292aed556b04dd849","user":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":55400726,"name":"alfresco-ng2-components","full_name":"Alfresco/alfresco-ng2-components","owner":{"login":"Alfresco","id":391127,"avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alfresco/alfresco-ng2-components","description":"Alfresco Angular Components","fork":false,"url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components","forks_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/forks","keys_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/teams","hooks_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/events","assignees_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/tags","blobs_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/languages","stargazers_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/subscription","commits_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/merges","archive_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/downloads","issues_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/releases{/id}","deployments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/deployments","created_at":"2016-04-04T09:54:25Z","updated_at":"2018-05-06T08:21:24Z","pushed_at":"2018-05-08T13:27:09Z","git_url":"git://github.com/Alfresco/alfresco-ng2-components.git","ssh_url":"git@github.com:Alfresco/alfresco-ng2-components.git","clone_url":"https://github.com/Alfresco/alfresco-ng2-components.git","svn_url":"https://github.com/Alfresco/alfresco-ng2-components","homepage":"https://alfresco.github.io/adf-component-catalog/","size":96489,"stargazers_count":160,"watchers_count":160,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":80,"open_issues":47,"watchers":160,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/3279"},"html":{"href":"https://github.com/Alfresco/alfresco-ng2-components/pull/3279"},"issue":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/3279"},"comments":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/3279/comments"},"review_comments":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/3279/comments"},"review_comment":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/3279/commits"},"statuses":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/statuses/c0fa025162c3f2afc85fcd34ce4ebaa902e4c969"}},"author_association":"NONE"}}
{"actor":{"display_login":"eromano"}}