{"action":"created","issue":{"url":"https://api.github.com/repos/Netflix/conductor/issues/838","repository_url":"https://api.github.com/repos/Netflix/conductor","labels_url":"https://api.github.com/repos/Netflix/conductor/issues/838/labels{/name}","comments_url":"https://api.github.com/repos/Netflix/conductor/issues/838/comments","events_url":"https://api.github.com/repos/Netflix/conductor/issues/838/events","html_url":"https://github.com/Netflix/conductor/pull/838","id":374061131,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODQ5MDEy","number":838,"title":"Converts index templates to ES5 syntax and upgrade to ES5 in Docker","user":{"login":"davidwadden","id":9936700,"node_id":"MDQ6VXNlcjk5MzY3MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/9936700?v=4","gravatar_id":"","url":"https://api.github.com/users/davidwadden","html_url":"https://github.com/davidwadden","followers_url":"https://api.github.com/users/davidwadden/followers","following_url":"https://api.github.com/users/davidwadden/following{/other_user}","gists_url":"https://api.github.com/users/davidwadden/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwadden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwadden/subscriptions","organizations_url":"https://api.github.com/users/davidwadden/orgs","repos_url":"https://api.github.com/users/davidwadden/repos","events_url":"https://api.github.com/users/davidwadden/events{/privacy}","received_events_url":"https://api.github.com/users/davidwadden/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-25T17:52:45Z","updated_at":"2018-10-27T04:39:42Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Netflix/conductor/pulls/838","html_url":"https://github.com/Netflix/conductor/pull/838","diff_url":"https://github.com/Netflix/conductor/pull/838.diff","patch_url":"https://github.com/Netflix/conductor/pull/838.patch"},"body":"With the [v2 release](https://github.com/Netflix/conductor/releases/tag/v2.0.0), some of the configurations are not in sync with the upgrade to Elasticsearch 5.\r\n\r\n> This PR is based against `dev` branch which is not up-to-date with `master`.  I didn't want to submit the fast-forward as part of this merge.  Will rebase this PR once `dev` is up-to-date with `master`.\r\n\r\nThis PR does the following:\r\n\r\n- Syncs up the default `docker-compose.yml` to start ES 5.6.8 (identical to [`docker-compose.dependencies.yaml`](https://github.com/Netflix/conductor/blob/master/docker/grpc/docker-compose.dependencies.yaml#L21-L33)\r\n- Removes references the deprecated ES 2 components and templates (as well as the templates themselves)\r\n- Converts the templates to replace the deprecated `string` type per https://www.elastic.co/blog/strings-are-dead-long-live-strings\r\n  - Removes `include_in_app` directive in favor of default (based on boolean value of `index`)\r\n    - https://www.elastic.co/guide/en/elasticsearch/reference/6.2/breaking_60_mappings_changes.html#_the_literal_include_in_all_literal_mapping_parameter_is_now_disallowed\r\n    - https://www.elastic.co/guide/en/elasticsearch/reference/5.4/include-in-all.html#include-in-all\r\n- Provide default values for Hikari JDBC pool configs for the `mysql` provider when run inside of Docker\r\n  - `conductor.mysql.connection.pool.size.max=10`\r\n  - `conductor.mysql.connection.pool.idle.min=2`\r\n\r\nDidn't see much in terms of integration tests to cover these changes.  I did exercise the system against ES and reviewed `DEBUG` level logging on ES to verify the deprecated warnings were no longer there and the system generally still worked.\r\n\r\nHappy to incorporate any recommendations or feedback for this PR\r\n"},"comment":{"url":"https://api.github.com/repos/Netflix/conductor/issues/comments/433590255","html_url":"https://github.com/Netflix/conductor/pull/838#issuecomment-433590255","issue_url":"https://api.github.com/repos/Netflix/conductor/issues/838","id":433590255,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzU5MDI1NQ==","user":{"login":"davidwadden","id":9936700,"node_id":"MDQ6VXNlcjk5MzY3MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/9936700?v=4","gravatar_id":"","url":"https://api.github.com/users/davidwadden","html_url":"https://github.com/davidwadden","followers_url":"https://api.github.com/users/davidwadden/followers","following_url":"https://api.github.com/users/davidwadden/following{/other_user}","gists_url":"https://api.github.com/users/davidwadden/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwadden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwadden/subscriptions","organizations_url":"https://api.github.com/users/davidwadden/orgs","repos_url":"https://api.github.com/users/davidwadden/repos","events_url":"https://api.github.com/users/davidwadden/events{/privacy}","received_events_url":"https://api.github.com/users/davidwadden/received_events","type":"User","site_admin":false},"created_at":"2018-10-27T04:39:42Z","updated_at":"2018-10-27T04:39:42Z","author_association":"NONE","body":"I utilized the [`healthcheck`](https://docs.docker.com/compose/compose-file/compose-file-v2/#healthcheck) directive with the [`depends_on#service_healthy`](https://docs.docker.com/compose/compose-file/compose-file-v2/#depends_on) to ensure the port was open on `elasticsearch`, `mysql` and `dynomite` prior to starting `conductor-server`.\r\n\r\n- Consolidated `docker-compose.dependencies.yaml` and `docker-compose.apps.yaml` under `grpc` Docker definition by leveraging the same feature.\r\n- Generally made the two `docker-compose` definitions more similar."}}
{"actor":{"display_login":"davidwadden"}}