{"action":"created","issue":{"url":"https://api.github.com/repos/kylebarron/stata_kernel/issues/70","repository_url":"https://api.github.com/repos/kylebarron/stata_kernel","labels_url":"https://api.github.com/repos/kylebarron/stata_kernel/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/kylebarron/stata_kernel/issues/70/comments","events_url":"https://api.github.com/repos/kylebarron/stata_kernel/issues/70/events","html_url":"https://github.com/kylebarron/stata_kernel/pull/70","id":349871719,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODU4NzA4","number":70,"title":"Various fixes. Supercedes #67","user":{"login":"kylebarron","id":15164633,"node_id":"MDQ6VXNlcjE1MTY0NjMz","avatar_url":"https://avatars3.githubusercontent.com/u/15164633?v=4","gravatar_id":"","url":"https://api.github.com/users/kylebarron","html_url":"https://github.com/kylebarron","followers_url":"https://api.github.com/users/kylebarron/followers","following_url":"https://api.github.com/users/kylebarron/following{/other_user}","gists_url":"https://api.github.com/users/kylebarron/gists{/gist_id}","starred_url":"https://api.github.com/users/kylebarron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylebarron/subscriptions","organizations_url":"https://api.github.com/users/kylebarron/orgs","repos_url":"https://api.github.com/users/kylebarron/repos","events_url":"https://api.github.com/users/kylebarron/events{/privacy}","received_events_url":"https://api.github.com/users/kylebarron/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-08-13T02:49:19Z","updated_at":"2018-08-13T04:37:42Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/kylebarron/stata_kernel/pulls/70","html_url":"https://github.com/kylebarron/stata_kernel/pull/70","diff_url":"https://github.com/kylebarron/stata_kernel/pull/70.diff","patch_url":"https://github.com/kylebarron/stata_kernel/pull/70.patch"},"body":"- [ ] closes #xxxx\r\n- [x] tests added / passed\r\n\r\nNew features:\r\n\r\n- This now uses two separate lexers. It updates the code_manager accordingly.\r\n- It seems to solve the first two issues, while the last issues are log-file parsing related\r\n- It also removes the code that prevented both images and text from being sent (I can't reproduce my issues in Hydrogen).\r\n- It adds `stripall=False` and `stripnl=False` to the instantiations of the lexer classes. I believe this should give more accurate `is_complete` messages if you type `///` and then two newlines.\r\n- Previous tests were updated and many more tests were added, especially with regards to `is_complete`. These should be easy to test. There's currently one failing test."},"comment":{"url":"https://api.github.com/repos/kylebarron/stata_kernel/issues/comments/412406448","html_url":"https://github.com/kylebarron/stata_kernel/pull/70#issuecomment-412406448","issue_url":"https://api.github.com/repos/kylebarron/stata_kernel/issues/70","id":412406448,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjQwNjQ0OA==","user":{"login":"kylebarron","id":15164633,"node_id":"MDQ6VXNlcjE1MTY0NjMz","avatar_url":"https://avatars3.githubusercontent.com/u/15164633?v=4","gravatar_id":"","url":"https://api.github.com/users/kylebarron","html_url":"https://github.com/kylebarron","followers_url":"https://api.github.com/users/kylebarron/followers","following_url":"https://api.github.com/users/kylebarron/following{/other_user}","gists_url":"https://api.github.com/users/kylebarron/gists{/gist_id}","starred_url":"https://api.github.com/users/kylebarron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylebarron/subscriptions","organizations_url":"https://api.github.com/users/kylebarron/orgs","repos_url":"https://api.github.com/users/kylebarron/repos","events_url":"https://api.github.com/users/kylebarron/events{/privacy}","received_events_url":"https://api.github.com/users/kylebarron/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T04:37:42Z","updated_at":"2018-08-13T04:37:42Z","author_association":"OWNER","body":"@mcaceresb \r\nDo you understand why this doesn't work?\r\n```\r\ndisp \"Line start\"\r\n// This is ignored, and does not give error\r\n\"; Line end\" ;\r\n```\r\nBut this does?\r\n```\r\ndisp \"Line start\"\r\n // This is ignored, and does not give error\r\n\"; Line end\" ;\r\n```\r\n\r\nI don't understand why the first wouldn't work. It just needs a space at the beginning of the line?"}}
{"actor":{"display_login":"kylebarron"}}