{"action":"created","issue":{"url":"https://api.github.com/repos/Fourdee/DietPi/issues/2095","repository_url":"https://api.github.com/repos/Fourdee/DietPi","labels_url":"https://api.github.com/repos/Fourdee/DietPi/issues/2095/labels{/name}","comments_url":"https://api.github.com/repos/Fourdee/DietPi/issues/2095/comments","events_url":"https://api.github.com/repos/Fourdee/DietPi/issues/2095/events","html_url":"https://github.com/Fourdee/DietPi/pull/2095","id":363754471,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MTA5OTk2","number":2095,"title":"All CodeFactor Issues fixed.","user":{"login":"mrmajik45","id":35823544,"node_id":"MDQ6VXNlcjM1ODIzNTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/35823544?v=4","gravatar_id":"","url":"https://api.github.com/users/mrmajik45","html_url":"https://github.com/mrmajik45","followers_url":"https://api.github.com/users/mrmajik45/followers","following_url":"https://api.github.com/users/mrmajik45/following{/other_user}","gists_url":"https://api.github.com/users/mrmajik45/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmajik45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmajik45/subscriptions","organizations_url":"https://api.github.com/users/mrmajik45/orgs","repos_url":"https://api.github.com/users/mrmajik45/repos","events_url":"https://api.github.com/users/mrmajik45/events{/privacy}","received_events_url":"https://api.github.com/users/mrmajik45/received_events","type":"User","site_admin":false},"labels":[{"id":187191723,"node_id":"MDU6TGFiZWwxODcxOTE3MjM=","url":"https://api.github.com/repos/Fourdee/DietPi/labels/enhancement%20:dash:","name":"enhancement :dash:","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":{"login":"mrmajik45","id":35823544,"node_id":"MDQ6VXNlcjM1ODIzNTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/35823544?v=4","gravatar_id":"","url":"https://api.github.com/users/mrmajik45","html_url":"https://github.com/mrmajik45","followers_url":"https://api.github.com/users/mrmajik45/followers","following_url":"https://api.github.com/users/mrmajik45/following{/other_user}","gists_url":"https://api.github.com/users/mrmajik45/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmajik45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmajik45/subscriptions","organizations_url":"https://api.github.com/users/mrmajik45/orgs","repos_url":"https://api.github.com/users/mrmajik45/repos","events_url":"https://api.github.com/users/mrmajik45/events{/privacy}","received_events_url":"https://api.github.com/users/mrmajik45/received_events","type":"User","site_admin":false},"assignees":[{"login":"mrmajik45","id":35823544,"node_id":"MDQ6VXNlcjM1ODIzNTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/35823544?v=4","gravatar_id":"","url":"https://api.github.com/users/mrmajik45","html_url":"https://github.com/mrmajik45","followers_url":"https://api.github.com/users/mrmajik45/followers","following_url":"https://api.github.com/users/mrmajik45/following{/other_user}","gists_url":"https://api.github.com/users/mrmajik45/gists{/gist_id}","starred_url":"https://api.github.com/users/mrmajik45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrmajik45/subscriptions","organizations_url":"https://api.github.com/users/mrmajik45/orgs","repos_url":"https://api.github.com/users/mrmajik45/repos","events_url":"https://api.github.com/users/mrmajik45/events{/privacy}","received_events_url":"https://api.github.com/users/mrmajik45/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Fourdee/DietPi/milestones/82","html_url":"https://github.com/Fourdee/DietPi/milestone/82","labels_url":"https://api.github.com/repos/Fourdee/DietPi/milestones/82/labels","id":3671183,"node_id":"MDk6TWlsZXN0b25lMzY3MTE4Mw==","number":82,"title":"v6.17","description":null,"creator":{"login":"Fourdee","id":7077026,"node_id":"MDQ6VXNlcjcwNzcwMjY=","avatar_url":"https://avatars3.githubusercontent.com/u/7077026?v=4","gravatar_id":"","url":"https://api.github.com/users/Fourdee","html_url":"https://github.com/Fourdee","followers_url":"https://api.github.com/users/Fourdee/followers","following_url":"https://api.github.com/users/Fourdee/following{/other_user}","gists_url":"https://api.github.com/users/Fourdee/gists{/gist_id}","starred_url":"https://api.github.com/users/Fourdee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fourdee/subscriptions","organizations_url":"https://api.github.com/users/Fourdee/orgs","repos_url":"https://api.github.com/users/Fourdee/repos","events_url":"https://api.github.com/users/Fourdee/events{/privacy}","received_events_url":"https://api.github.com/users/Fourdee/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":6,"state":"open","created_at":"2018-09-19T12:24:18Z","updated_at":"2018-09-26T17:17:09Z","due_on":null,"closed_at":null},"comments":12,"created_at":"2018-09-25T20:32:30Z","updated_at":"2018-09-26T18:31:08Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Fourdee/DietPi/pulls/2095","html_url":"https://github.com/Fourdee/DietPi/pull/2095","diff_url":"https://github.com/Fourdee/DietPi/pull/2095.diff","patch_url":"https://github.com/Fourdee/DietPi/pull/2095.patch"},"body":"**Status**: Not tested \r\n\r\n**Reference**: https://github.com/mrmajik45/DietPi/\r\n\r\n**Commit list/description**:\r\n\r\n- Use a ( subshell ) to avoid having to cd back. / Check exit code directly with e.g. 'if mycmd;', not indirectly with $?\r\n- Don't use $ on the left side of assignments. / Don't put spaces around the = in assignments.\r\n- Check exit code directly with e.g. 'if mycmd;', not indirectly with $?\r\n"},"comment":{"url":"https://api.github.com/repos/Fourdee/DietPi/issues/comments/424822819","html_url":"https://github.com/Fourdee/DietPi/pull/2095#issuecomment-424822819","issue_url":"https://api.github.com/repos/Fourdee/DietPi/issues/2095","id":424822819,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDgyMjgxOQ==","user":{"login":"MichaIng","id":28480705,"node_id":"MDQ6VXNlcjI4NDgwNzA1","avatar_url":"https://avatars2.githubusercontent.com/u/28480705?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaIng","html_url":"https://github.com/MichaIng","followers_url":"https://api.github.com/users/MichaIng/followers","following_url":"https://api.github.com/users/MichaIng/following{/other_user}","gists_url":"https://api.github.com/users/MichaIng/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaIng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaIng/subscriptions","organizations_url":"https://api.github.com/users/MichaIng/orgs","repos_url":"https://api.github.com/users/MichaIng/repos","events_url":"https://api.github.com/users/MichaIng/events{/privacy}","received_events_url":"https://api.github.com/users/MichaIng/received_events","type":"User","site_admin":false},"created_at":"2018-09-26T18:31:08Z","updated_at":"2018-09-26T18:31:08Z","author_association":"COLLABORATOR","body":"@Fourdee \r\n> ( cd rtl8812au_sparky; G_RUN_CMD ./install.sh )\r\n\r\nNice about it is, that the `cd` is error handled as well indirectly. If it fails, G_RUN_CMD will fail as well and should throw meaningful message about missing file."}}
{"actor":{"display_login":"MichaIng"}}