{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/20596","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/20596/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/20596/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/20596/events","html_url":"https://github.com/openshift/origin/pull/20596","id":349342666,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDgzMTk5","number":20596,"title":"UPSTREAM: 66617: Do not set cgroup parent when --cgroups-per-qos is disabled","user":{"login":"pravisankar","id":1258630,"node_id":"MDQ6VXNlcjEyNTg2MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1258630?v=4","gravatar_id":"","url":"https://api.github.com/users/pravisankar","html_url":"https://github.com/pravisankar","followers_url":"https://api.github.com/users/pravisankar/followers","following_url":"https://api.github.com/users/pravisankar/following{/other_user}","gists_url":"https://api.github.com/users/pravisankar/gists{/gist_id}","starred_url":"https://api.github.com/users/pravisankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravisankar/subscriptions","organizations_url":"https://api.github.com/users/pravisankar/orgs","repos_url":"https://api.github.com/users/pravisankar/repos","events_url":"https://api.github.com/users/pravisankar/events{/privacy}","received_events_url":"https://api.github.com/users/pravisankar/received_events","type":"User","site_admin":false},"labels":[{"id":223051294,"node_id":"MDU6TGFiZWwyMjMwNTEyOTQ=","url":"https://api.github.com/repos/openshift/origin/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":223479084,"node_id":"MDU6TGFiZWwyMjM0NzkwODQ=","url":"https://api.github.com/repos/openshift/origin/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":640547849,"node_id":"MDU6TGFiZWw2NDA1NDc4NDk=","url":"https://api.github.com/repos/openshift/origin/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":{"login":"derekwaynecarr","id":6233452,"node_id":"MDQ6VXNlcjYyMzM0NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6233452?v=4","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"assignees":[{"login":"derekwaynecarr","id":6233452,"node_id":"MDQ6VXNlcjYyMzM0NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6233452?v=4","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},{"login":"dcbw","id":10926354,"node_id":"MDQ6VXNlcjEwOTI2MzU0","avatar_url":"https://avatars2.githubusercontent.com/u/10926354?v=4","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false}],"milestone":null,"comments":126,"created_at":"2018-08-10T01:13:07Z","updated_at":"2018-09-15T05:13:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/20596","html_url":"https://github.com/openshift/origin/pull/20596","diff_url":"https://github.com/openshift/origin/pull/20596.diff","patch_url":"https://github.com/openshift/origin/pull/20596.patch"},"body":"This will fix launching pods on dind cluster.\r\n\r\nWhen --cgroups-per-qos=false (default is true), kubelet sets pod\r\ncontainer management to podContainerManagerNoop implementation and\r\nGetPodContainerName() returns '/' as cgroup parent (default cgroup root).\r\n\r\n(1) In case of 'systemd' cgroup driver, '/' is invalid parent as\r\ndocker daemon expects '.slice' suffix and throws this error:\r\n'cgroup-parent for systemd cgroup should be a valid slice named as \\\"xxx.slice\\\"'\r\n(https://github.com/moby/moby/blob/5fc12449d830ae9005138fb3d3782728fa8d137a/daemon/daemon_unix.go#L618)\r\n'/' corresponds to '-.slice' (root slice) in systemd but I don't think\r\nwe want to assign root slice instead of runtime specific default value.\r\nIn case of docker runtime, this will be 'system.slice'\r\n(https://github.com/moby/moby/blob/e2593239d949eee454935daea7a5fe025477322f/daemon/oci_linux.go#L698)\r\n\r\n(2) In case of 'cgroupfs' cgroup driver, '/' is valid parent but I don't\r\nthink we want to assign root instead of runtime specific default value.\r\nIn case of docker runtime, this will be '/docker'\r\n(https://github.com/moby/moby/blob/e2593239d949eee454935daea7a5fe025477322f/daemon/oci_linux.go#L695)\r\n\r\nCurrent fix will not set the cgroup parent when --cgroups-per-qos is disabled."},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/421531913","html_url":"https://github.com/openshift/origin/pull/20596#issuecomment-421531913","issue_url":"https://api.github.com/repos/openshift/origin/issues/20596","id":421531913,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTUzMTkxMw==","user":{"login":"openshift-bot","id":1779249,"node_id":"MDQ6VXNlcjE3NzkyNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1779249?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"created_at":"2018-09-15T05:13:20Z","updated_at":"2018-09-15T05:13:20Z","author_association":"MEMBER","body":"/retest\n\nPlease review the [full test history](https://openshift-gce-devel.appspot.com/pr/20596) for this PR and help us cut down flakes."}}
{"actor":{"display_login":"openshift-bot"}}