{"action":"created","comment":{"url":"https://api.github.com/repos/sourcebots/sb-vision/pulls/comments/167099665","pull_request_review_id":95245964,"id":167099665,"diff_hunk":"@@ -0,0 +1,46 @@\n+\"\"\"Tests for marker sizing.\"\"\"\n+\n+import numpy as np\n+\n+from sb_vision import Token\n+\n+# Homography matrix of a real image.\n+homography_from_camera = np.array([\n+    [7.08277177e-01, -6.30171882e-03, 9.36194251e-01],\n+    [1.08272961e-02, 7.11294182e-01, 2.64415168e+00],\n+    [2.14327973e-05, 7.37441645e-06, 7.25640594e-03],\n+])\n+distance_model = 'c270'\n+image_resolution = (1280, 720)\n+\n+\n+def test_marker_size():","path":"tests/test_marker_sizes.py","position":17,"original_position":17,"commit_id":"42239034530cb89e8f70cf8607fdcc382fcb2888","original_commit_id":"42239034530cb89e8f70cf8607fdcc382fcb2888","user":{"login":"PeterJCLaw","id":336212,"avatar_url":"https://avatars2.githubusercontent.com/u/336212?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterJCLaw","html_url":"https://github.com/PeterJCLaw","followers_url":"https://api.github.com/users/PeterJCLaw/followers","following_url":"https://api.github.com/users/PeterJCLaw/following{/other_user}","gists_url":"https://api.github.com/users/PeterJCLaw/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterJCLaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterJCLaw/subscriptions","organizations_url":"https://api.github.com/users/PeterJCLaw/orgs","repos_url":"https://api.github.com/users/PeterJCLaw/repos","events_url":"https://api.github.com/users/PeterJCLaw/events{/privacy}","received_events_url":"https://api.github.com/users/PeterJCLaw/received_events","type":"User","site_admin":false},"body":"Thanks for adding this, though this test is rather complex to read and doesn't really validate the underlying approach being taken -- it's more just duplicating the logic somewhere else!\r\n\r\nI've added some more holistic tests which also validate the underlying approach in 1274f6a8be8210bcf1e5b1f2ae5db4e2a4a8cf96.","created_at":"2018-02-08T23:26:48Z","updated_at":"2018-02-08T23:28:17Z","html_url":"https://github.com/sourcebots/sb-vision/pull/25#discussion_r167099665","pull_request_url":"https://api.github.com/repos/sourcebots/sb-vision/pulls/25","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sourcebots/sb-vision/pulls/comments/167099665"},"html":{"href":"https://github.com/sourcebots/sb-vision/pull/25#discussion_r167099665"},"pull_request":{"href":"https://api.github.com/repos/sourcebots/sb-vision/pulls/25"}}},"pull_request":{"url":"https://api.github.com/repos/sourcebots/sb-vision/pulls/25","id":166960737,"html_url":"https://github.com/sourcebots/sb-vision/pull/25","diff_url":"https://github.com/sourcebots/sb-vision/pull/25.diff","patch_url":"https://github.com/sourcebots/sb-vision/pull/25.patch","issue_url":"https://api.github.com/repos/sourcebots/sb-vision/issues/25","number":25,"state":"open","locked":false,"title":"Marker sizes","user":{"login":"Adimote","id":2551763,"avatar_url":"https://avatars0.githubusercontent.com/u/2551763?v=4","gravatar_id":"","url":"https://api.github.com/users/Adimote","html_url":"https://github.com/Adimote","followers_url":"https://api.github.com/users/Adimote/followers","following_url":"https://api.github.com/users/Adimote/following{/other_user}","gists_url":"https://api.github.com/users/Adimote/gists{/gist_id}","starred_url":"https://api.github.com/users/Adimote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adimote/subscriptions","organizations_url":"https://api.github.com/users/Adimote/orgs","repos_url":"https://api.github.com/users/Adimote/repos","events_url":"https://api.github.com/users/Adimote/events{/privacy}","received_events_url":"https://api.github.com/users/Adimote/received_events","type":"User","site_admin":false},"body":"make sb-vision marker size aware.\r\n\r\nThis involves re-adding game_specific.py, but that's okay because we can remove it from robotd now.","created_at":"2018-02-03T12:42:11Z","updated_at":"2018-02-08T23:28:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fa0a60868c81b1c362c21254a547349a5660f1f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"prophile","id":35525,"avatar_url":"https://avatars3.githubusercontent.com/u/35525?v=4","gravatar_id":"","url":"https://api.github.com/users/prophile","html_url":"https://github.com/prophile","followers_url":"https://api.github.com/users/prophile/followers","following_url":"https://api.github.com/users/prophile/following{/other_user}","gists_url":"https://api.github.com/users/prophile/gists{/gist_id}","starred_url":"https://api.github.com/users/prophile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prophile/subscriptions","organizations_url":"https://api.github.com/users/prophile/orgs","repos_url":"https://api.github.com/users/prophile/repos","events_url":"https://api.github.com/users/prophile/events{/privacy}","received_events_url":"https://api.github.com/users/prophile/received_events","type":"User","site_admin":false},{"login":"RealOrangeOne","id":6527489,"avatar_url":"https://avatars0.githubusercontent.com/u/6527489?v=4","gravatar_id":"","url":"https://api.github.com/users/RealOrangeOne","html_url":"https://github.com/RealOrangeOne","followers_url":"https://api.github.com/users/RealOrangeOne/followers","following_url":"https://api.github.com/users/RealOrangeOne/following{/other_user}","gists_url":"https://api.github.com/users/RealOrangeOne/gists{/gist_id}","starred_url":"https://api.github.com/users/RealOrangeOne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RealOrangeOne/subscriptions","organizations_url":"https://api.github.com/users/RealOrangeOne/orgs","repos_url":"https://api.github.com/users/RealOrangeOne/repos","events_url":"https://api.github.com/users/RealOrangeOne/events{/privacy}","received_events_url":"https://api.github.com/users/RealOrangeOne/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/sourcebots/sb-vision/pulls/25/commits","review_comments_url":"https://api.github.com/repos/sourcebots/sb-vision/pulls/25/comments","review_comment_url":"https://api.github.com/repos/sourcebots/sb-vision/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sourcebots/sb-vision/issues/25/comments","statuses_url":"https://api.github.com/repos/sourcebots/sb-vision/statuses/42239034530cb89e8f70cf8607fdcc382fcb2888","head":{"label":"sourcebots:marker-sizes","ref":"marker-sizes","sha":"42239034530cb89e8f70cf8607fdcc382fcb2888","user":{"login":"sourcebots","id":23337052,"avatar_url":"https://avatars2.githubusercontent.com/u/23337052?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcebots","html_url":"https://github.com/sourcebots","followers_url":"https://api.github.com/users/sourcebots/followers","following_url":"https://api.github.com/users/sourcebots/following{/other_user}","gists_url":"https://api.github.com/users/sourcebots/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcebots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcebots/subscriptions","organizations_url":"https://api.github.com/users/sourcebots/orgs","repos_url":"https://api.github.com/users/sourcebots/repos","events_url":"https://api.github.com/users/sourcebots/events{/privacy}","received_events_url":"https://api.github.com/users/sourcebots/received_events","type":"Organization","site_admin":false},"repo":{"id":98543594,"name":"sb-vision","full_name":"sourcebots/sb-vision","owner":{"login":"sourcebots","id":23337052,"avatar_url":"https://avatars2.githubusercontent.com/u/23337052?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcebots","html_url":"https://github.com/sourcebots","followers_url":"https://api.github.com/users/sourcebots/followers","following_url":"https://api.github.com/users/sourcebots/following{/other_user}","gists_url":"https://api.github.com/users/sourcebots/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcebots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcebots/subscriptions","organizations_url":"https://api.github.com/users/sourcebots/orgs","repos_url":"https://api.github.com/users/sourcebots/repos","events_url":"https://api.github.com/users/sourcebots/events{/privacy}","received_events_url":"https://api.github.com/users/sourcebots/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sourcebots/sb-vision","description":"SourceBots' vision system","fork":false,"url":"https://api.github.com/repos/sourcebots/sb-vision","forks_url":"https://api.github.com/repos/sourcebots/sb-vision/forks","keys_url":"https://api.github.com/repos/sourcebots/sb-vision/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcebots/sb-vision/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcebots/sb-vision/teams","hooks_url":"https://api.github.com/repos/sourcebots/sb-vision/hooks","issue_events_url":"https://api.github.com/repos/sourcebots/sb-vision/issues/events{/number}","events_url":"https://api.github.com/repos/sourcebots/sb-vision/events","assignees_url":"https://api.github.com/repos/sourcebots/sb-vision/assignees{/user}","branches_url":"https://api.github.com/repos/sourcebots/sb-vision/branches{/branch}","tags_url":"https://api.github.com/repos/sourcebots/sb-vision/tags","blobs_url":"https://api.github.com/repos/sourcebots/sb-vision/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcebots/sb-vision/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcebots/sb-vision/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcebots/sb-vision/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcebots/sb-vision/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcebots/sb-vision/languages","stargazers_url":"https://api.github.com/repos/sourcebots/sb-vision/stargazers","contributors_url":"https://api.github.com/repos/sourcebots/sb-vision/contributors","subscribers_url":"https://api.github.com/repos/sourcebots/sb-vision/subscribers","subscription_url":"https://api.github.com/repos/sourcebots/sb-vision/subscription","commits_url":"https://api.github.com/repos/sourcebots/sb-vision/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcebots/sb-vision/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcebots/sb-vision/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcebots/sb-vision/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcebots/sb-vision/contents/{+path}","compare_url":"https://api.github.com/repos/sourcebots/sb-vision/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcebots/sb-vision/merges","archive_url":"https://api.github.com/repos/sourcebots/sb-vision/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcebots/sb-vision/downloads","issues_url":"https://api.github.com/repos/sourcebots/sb-vision/issues{/number}","pulls_url":"https://api.github.com/repos/sourcebots/sb-vision/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcebots/sb-vision/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcebots/sb-vision/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcebots/sb-vision/labels{/name}","releases_url":"https://api.github.com/repos/sourcebots/sb-vision/releases{/id}","deployments_url":"https://api.github.com/repos/sourcebots/sb-vision/deployments","created_at":"2017-07-27T14:10:32Z","updated_at":"2018-02-03T15:16:21Z","pushed_at":"2018-02-08T23:27:31Z","git_url":"git://github.com/sourcebots/sb-vision.git","ssh_url":"git@github.com:sourcebots/sb-vision.git","clone_url":"https://github.com/sourcebots/sb-vision.git","svn_url":"https://github.com/sourcebots/sb-vision","homepage":"","size":105994,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":10,"watchers":1,"default_branch":"master"}},"base":{"label":"sourcebots:master","ref":"master","sha":"642eb89c8d14d39b44f4ea25defadf035a13f747","user":{"login":"sourcebots","id":23337052,"avatar_url":"https://avatars2.githubusercontent.com/u/23337052?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcebots","html_url":"https://github.com/sourcebots","followers_url":"https://api.github.com/users/sourcebots/followers","following_url":"https://api.github.com/users/sourcebots/following{/other_user}","gists_url":"https://api.github.com/users/sourcebots/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcebots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcebots/subscriptions","organizations_url":"https://api.github.com/users/sourcebots/orgs","repos_url":"https://api.github.com/users/sourcebots/repos","events_url":"https://api.github.com/users/sourcebots/events{/privacy}","received_events_url":"https://api.github.com/users/sourcebots/received_events","type":"Organization","site_admin":false},"repo":{"id":98543594,"name":"sb-vision","full_name":"sourcebots/sb-vision","owner":{"login":"sourcebots","id":23337052,"avatar_url":"https://avatars2.githubusercontent.com/u/23337052?v=4","gravatar_id":"","url":"https://api.github.com/users/sourcebots","html_url":"https://github.com/sourcebots","followers_url":"https://api.github.com/users/sourcebots/followers","following_url":"https://api.github.com/users/sourcebots/following{/other_user}","gists_url":"https://api.github.com/users/sourcebots/gists{/gist_id}","starred_url":"https://api.github.com/users/sourcebots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sourcebots/subscriptions","organizations_url":"https://api.github.com/users/sourcebots/orgs","repos_url":"https://api.github.com/users/sourcebots/repos","events_url":"https://api.github.com/users/sourcebots/events{/privacy}","received_events_url":"https://api.github.com/users/sourcebots/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sourcebots/sb-vision","description":"SourceBots' vision system","fork":false,"url":"https://api.github.com/repos/sourcebots/sb-vision","forks_url":"https://api.github.com/repos/sourcebots/sb-vision/forks","keys_url":"https://api.github.com/repos/sourcebots/sb-vision/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sourcebots/sb-vision/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sourcebots/sb-vision/teams","hooks_url":"https://api.github.com/repos/sourcebots/sb-vision/hooks","issue_events_url":"https://api.github.com/repos/sourcebots/sb-vision/issues/events{/number}","events_url":"https://api.github.com/repos/sourcebots/sb-vision/events","assignees_url":"https://api.github.com/repos/sourcebots/sb-vision/assignees{/user}","branches_url":"https://api.github.com/repos/sourcebots/sb-vision/branches{/branch}","tags_url":"https://api.github.com/repos/sourcebots/sb-vision/tags","blobs_url":"https://api.github.com/repos/sourcebots/sb-vision/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sourcebots/sb-vision/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sourcebots/sb-vision/git/refs{/sha}","trees_url":"https://api.github.com/repos/sourcebots/sb-vision/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sourcebots/sb-vision/statuses/{sha}","languages_url":"https://api.github.com/repos/sourcebots/sb-vision/languages","stargazers_url":"https://api.github.com/repos/sourcebots/sb-vision/stargazers","contributors_url":"https://api.github.com/repos/sourcebots/sb-vision/contributors","subscribers_url":"https://api.github.com/repos/sourcebots/sb-vision/subscribers","subscription_url":"https://api.github.com/repos/sourcebots/sb-vision/subscription","commits_url":"https://api.github.com/repos/sourcebots/sb-vision/commits{/sha}","git_commits_url":"https://api.github.com/repos/sourcebots/sb-vision/git/commits{/sha}","comments_url":"https://api.github.com/repos/sourcebots/sb-vision/comments{/number}","issue_comment_url":"https://api.github.com/repos/sourcebots/sb-vision/issues/comments{/number}","contents_url":"https://api.github.com/repos/sourcebots/sb-vision/contents/{+path}","compare_url":"https://api.github.com/repos/sourcebots/sb-vision/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sourcebots/sb-vision/merges","archive_url":"https://api.github.com/repos/sourcebots/sb-vision/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sourcebots/sb-vision/downloads","issues_url":"https://api.github.com/repos/sourcebots/sb-vision/issues{/number}","pulls_url":"https://api.github.com/repos/sourcebots/sb-vision/pulls{/number}","milestones_url":"https://api.github.com/repos/sourcebots/sb-vision/milestones{/number}","notifications_url":"https://api.github.com/repos/sourcebots/sb-vision/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sourcebots/sb-vision/labels{/name}","releases_url":"https://api.github.com/repos/sourcebots/sb-vision/releases{/id}","deployments_url":"https://api.github.com/repos/sourcebots/sb-vision/deployments","created_at":"2017-07-27T14:10:32Z","updated_at":"2018-02-03T15:16:21Z","pushed_at":"2018-02-08T23:27:31Z","git_url":"git://github.com/sourcebots/sb-vision.git","ssh_url":"git@github.com:sourcebots/sb-vision.git","clone_url":"https://github.com/sourcebots/sb-vision.git","svn_url":"https://github.com/sourcebots/sb-vision","homepage":"","size":105994,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":10,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sourcebots/sb-vision/pulls/25"},"html":{"href":"https://github.com/sourcebots/sb-vision/pull/25"},"issue":{"href":"https://api.github.com/repos/sourcebots/sb-vision/issues/25"},"comments":{"href":"https://api.github.com/repos/sourcebots/sb-vision/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/sourcebots/sb-vision/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/sourcebots/sb-vision/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sourcebots/sb-vision/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/sourcebots/sb-vision/statuses/42239034530cb89e8f70cf8607fdcc382fcb2888"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"PeterJCLaw"}}