{"action":"created","comment":{"url":"https://api.github.com/repos/creditkarma/thrift-server/pulls/comments/214126092","pull_request_review_id":151113980,"id":214126092,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDEyNjA5Mg==","diff_hunk":"@@ -40,51 +43,35 @@ export function ThriftServerHapi<TProcessor extends IThriftProcessor<Hapi.Reques\n                         options.protocol,\n                     )\n \n-                    const buffer: Buffer = request.payload\n+                    const buffer: Buffer = (request.payload as Buffer)\n \n-                    try {","path":"packages/thrift-server-hapi/src/main/ThriftServerHapi.ts","position":26,"original_position":26,"commit_id":"27458f8735c29582007a4522e112609c53dc681f","original_commit_id":"27458f8735c29582007a4522e112609c53dc681f","user":{"login":"kevin-greene-ck","id":30637378,"node_id":"MDQ6VXNlcjMwNjM3Mzc4","avatar_url":"https://avatars3.githubusercontent.com/u/30637378?v=4","gravatar_id":"","url":"https://api.github.com/users/kevin-greene-ck","html_url":"https://github.com/kevin-greene-ck","followers_url":"https://api.github.com/users/kevin-greene-ck/followers","following_url":"https://api.github.com/users/kevin-greene-ck/following{/other_user}","gists_url":"https://api.github.com/users/kevin-greene-ck/gists{/gist_id}","starred_url":"https://api.github.com/users/kevin-greene-ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevin-greene-ck/subscriptions","organizations_url":"https://api.github.com/users/kevin-greene-ck/orgs","repos_url":"https://api.github.com/users/kevin-greene-ck/repos","events_url":"https://api.github.com/users/kevin-greene-ck/events{/privacy}","received_events_url":"https://api.github.com/users/kevin-greene-ck/received_events","type":"User","site_admin":false},"body":"Hapi should catch these errors and return them. This try/catch was redundant since we aren't doing anything to format the returned error.","created_at":"2018-08-30T18:00:12Z","updated_at":"2018-08-30T18:00:12Z","html_url":"https://github.com/creditkarma/thrift-server/pull/90#discussion_r214126092","pull_request_url":"https://api.github.com/repos/creditkarma/thrift-server/pulls/90","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/creditkarma/thrift-server/pulls/comments/214126092"},"html":{"href":"https://github.com/creditkarma/thrift-server/pull/90#discussion_r214126092"},"pull_request":{"href":"https://api.github.com/repos/creditkarma/thrift-server/pulls/90"}},"in_reply_to_id":214113206},"pull_request":{"url":"https://api.github.com/repos/creditkarma/thrift-server/pulls/90","id":211243389,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjQzMzg5","html_url":"https://github.com/creditkarma/thrift-server/pull/90","diff_url":"https://github.com/creditkarma/thrift-server/pull/90.diff","patch_url":"https://github.com/creditkarma/thrift-server/pull/90.patch","issue_url":"https://api.github.com/repos/creditkarma/thrift-server/issues/90","number":90,"state":"open","locked":false,"title":"BREAKING CHANGE: Update to hapi 17","user":{"login":"kevin-greene-ck","id":30637378,"node_id":"MDQ6VXNlcjMwNjM3Mzc4","avatar_url":"https://avatars3.githubusercontent.com/u/30637378?v=4","gravatar_id":"","url":"https://api.github.com/users/kevin-greene-ck","html_url":"https://github.com/kevin-greene-ck","followers_url":"https://api.github.com/users/kevin-greene-ck/followers","following_url":"https://api.github.com/users/kevin-greene-ck/following{/other_user}","gists_url":"https://api.github.com/users/kevin-greene-ck/gists{/gist_id}","starred_url":"https://api.github.com/users/kevin-greene-ck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevin-greene-ck/subscriptions","organizations_url":"https://api.github.com/users/kevin-greene-ck/orgs","repos_url":"https://api.github.com/users/kevin-greene-ck/repos","events_url":"https://api.github.com/users/kevin-greene-ck/events{/privacy}","received_events_url":"https://api.github.com/users/kevin-greene-ck/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-27T21:57:07Z","updated_at":"2018-08-30T18:00:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a070f987c8daf7dc8df23a36a2c9285467fe5626","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/creditkarma/thrift-server/pulls/90/commits","review_comments_url":"https://api.github.com/repos/creditkarma/thrift-server/pulls/90/comments","review_comment_url":"https://api.github.com/repos/creditkarma/thrift-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/creditkarma/thrift-server/issues/90/comments","statuses_url":"https://api.github.com/repos/creditkarma/thrift-server/statuses/27458f8735c29582007a4522e112609c53dc681f","head":{"label":"creditkarma:hapi-17","ref":"hapi-17","sha":"27458f8735c29582007a4522e112609c53dc681f","user":{"login":"creditkarma","id":1206633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDY2MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1206633?v=4","gravatar_id":"","url":"https://api.github.com/users/creditkarma","html_url":"https://github.com/creditkarma","followers_url":"https://api.github.com/users/creditkarma/followers","following_url":"https://api.github.com/users/creditkarma/following{/other_user}","gists_url":"https://api.github.com/users/creditkarma/gists{/gist_id}","starred_url":"https://api.github.com/users/creditkarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creditkarma/subscriptions","organizations_url":"https://api.github.com/users/creditkarma/orgs","repos_url":"https://api.github.com/users/creditkarma/repos","events_url":"https://api.github.com/users/creditkarma/events{/privacy}","received_events_url":"https://api.github.com/users/creditkarma/received_events","type":"Organization","site_admin":false},"repo":{"id":97515605,"node_id":"MDEwOlJlcG9zaXRvcnk5NzUxNTYwNQ==","name":"thrift-server","full_name":"creditkarma/thrift-server","owner":{"login":"creditkarma","id":1206633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDY2MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1206633?v=4","gravatar_id":"","url":"https://api.github.com/users/creditkarma","html_url":"https://github.com/creditkarma","followers_url":"https://api.github.com/users/creditkarma/followers","following_url":"https://api.github.com/users/creditkarma/following{/other_user}","gists_url":"https://api.github.com/users/creditkarma/gists{/gist_id}","starred_url":"https://api.github.com/users/creditkarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creditkarma/subscriptions","organizations_url":"https://api.github.com/users/creditkarma/orgs","repos_url":"https://api.github.com/users/creditkarma/repos","events_url":"https://api.github.com/users/creditkarma/events{/privacy}","received_events_url":"https://api.github.com/users/creditkarma/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/creditkarma/thrift-server","description":"Thrift core library in TypeScript","fork":false,"url":"https://api.github.com/repos/creditkarma/thrift-server","forks_url":"https://api.github.com/repos/creditkarma/thrift-server/forks","keys_url":"https://api.github.com/repos/creditkarma/thrift-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/creditkarma/thrift-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/creditkarma/thrift-server/teams","hooks_url":"https://api.github.com/repos/creditkarma/thrift-server/hooks","issue_events_url":"https://api.github.com/repos/creditkarma/thrift-server/issues/events{/number}","events_url":"https://api.github.com/repos/creditkarma/thrift-server/events","assignees_url":"https://api.github.com/repos/creditkarma/thrift-server/assignees{/user}","branches_url":"https://api.github.com/repos/creditkarma/thrift-server/branches{/branch}","tags_url":"https://api.github.com/repos/creditkarma/thrift-server/tags","blobs_url":"https://api.github.com/repos/creditkarma/thrift-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/creditkarma/thrift-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/creditkarma/thrift-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/creditkarma/thrift-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/creditkarma/thrift-server/statuses/{sha}","languages_url":"https://api.github.com/repos/creditkarma/thrift-server/languages","stargazers_url":"https://api.github.com/repos/creditkarma/thrift-server/stargazers","contributors_url":"https://api.github.com/repos/creditkarma/thrift-server/contributors","subscribers_url":"https://api.github.com/repos/creditkarma/thrift-server/subscribers","subscription_url":"https://api.github.com/repos/creditkarma/thrift-server/subscription","commits_url":"https://api.github.com/repos/creditkarma/thrift-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/creditkarma/thrift-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/creditkarma/thrift-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/creditkarma/thrift-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/creditkarma/thrift-server/contents/{+path}","compare_url":"https://api.github.com/repos/creditkarma/thrift-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/creditkarma/thrift-server/merges","archive_url":"https://api.github.com/repos/creditkarma/thrift-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/creditkarma/thrift-server/downloads","issues_url":"https://api.github.com/repos/creditkarma/thrift-server/issues{/number}","pulls_url":"https://api.github.com/repos/creditkarma/thrift-server/pulls{/number}","milestones_url":"https://api.github.com/repos/creditkarma/thrift-server/milestones{/number}","notifications_url":"https://api.github.com/repos/creditkarma/thrift-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/creditkarma/thrift-server/labels{/name}","releases_url":"https://api.github.com/repos/creditkarma/thrift-server/releases{/id}","deployments_url":"https://api.github.com/repos/creditkarma/thrift-server/deployments","created_at":"2017-07-17T19:43:51Z","updated_at":"2018-08-30T15:23:42Z","pushed_at":"2018-08-30T15:26:19Z","git_url":"git://github.com/creditkarma/thrift-server.git","ssh_url":"git@github.com:creditkarma/thrift-server.git","clone_url":"https://github.com/creditkarma/thrift-server.git","svn_url":"https://github.com/creditkarma/thrift-server","homepage":null,"size":2426,"stargazers_count":8,"watchers_count":8,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":2,"watchers":8,"default_branch":"master"}},"base":{"label":"creditkarma:master","ref":"master","sha":"c5b6dbe24b3a0c99b20c2cff7cad547a2b1430ee","user":{"login":"creditkarma","id":1206633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDY2MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1206633?v=4","gravatar_id":"","url":"https://api.github.com/users/creditkarma","html_url":"https://github.com/creditkarma","followers_url":"https://api.github.com/users/creditkarma/followers","following_url":"https://api.github.com/users/creditkarma/following{/other_user}","gists_url":"https://api.github.com/users/creditkarma/gists{/gist_id}","starred_url":"https://api.github.com/users/creditkarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creditkarma/subscriptions","organizations_url":"https://api.github.com/users/creditkarma/orgs","repos_url":"https://api.github.com/users/creditkarma/repos","events_url":"https://api.github.com/users/creditkarma/events{/privacy}","received_events_url":"https://api.github.com/users/creditkarma/received_events","type":"Organization","site_admin":false},"repo":{"id":97515605,"node_id":"MDEwOlJlcG9zaXRvcnk5NzUxNTYwNQ==","name":"thrift-server","full_name":"creditkarma/thrift-server","owner":{"login":"creditkarma","id":1206633,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDY2MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/1206633?v=4","gravatar_id":"","url":"https://api.github.com/users/creditkarma","html_url":"https://github.com/creditkarma","followers_url":"https://api.github.com/users/creditkarma/followers","following_url":"https://api.github.com/users/creditkarma/following{/other_user}","gists_url":"https://api.github.com/users/creditkarma/gists{/gist_id}","starred_url":"https://api.github.com/users/creditkarma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creditkarma/subscriptions","organizations_url":"https://api.github.com/users/creditkarma/orgs","repos_url":"https://api.github.com/users/creditkarma/repos","events_url":"https://api.github.com/users/creditkarma/events{/privacy}","received_events_url":"https://api.github.com/users/creditkarma/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/creditkarma/thrift-server","description":"Thrift core library in TypeScript","fork":false,"url":"https://api.github.com/repos/creditkarma/thrift-server","forks_url":"https://api.github.com/repos/creditkarma/thrift-server/forks","keys_url":"https://api.github.com/repos/creditkarma/thrift-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/creditkarma/thrift-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/creditkarma/thrift-server/teams","hooks_url":"https://api.github.com/repos/creditkarma/thrift-server/hooks","issue_events_url":"https://api.github.com/repos/creditkarma/thrift-server/issues/events{/number}","events_url":"https://api.github.com/repos/creditkarma/thrift-server/events","assignees_url":"https://api.github.com/repos/creditkarma/thrift-server/assignees{/user}","branches_url":"https://api.github.com/repos/creditkarma/thrift-server/branches{/branch}","tags_url":"https://api.github.com/repos/creditkarma/thrift-server/tags","blobs_url":"https://api.github.com/repos/creditkarma/thrift-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/creditkarma/thrift-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/creditkarma/thrift-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/creditkarma/thrift-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/creditkarma/thrift-server/statuses/{sha}","languages_url":"https://api.github.com/repos/creditkarma/thrift-server/languages","stargazers_url":"https://api.github.com/repos/creditkarma/thrift-server/stargazers","contributors_url":"https://api.github.com/repos/creditkarma/thrift-server/contributors","subscribers_url":"https://api.github.com/repos/creditkarma/thrift-server/subscribers","subscription_url":"https://api.github.com/repos/creditkarma/thrift-server/subscription","commits_url":"https://api.github.com/repos/creditkarma/thrift-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/creditkarma/thrift-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/creditkarma/thrift-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/creditkarma/thrift-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/creditkarma/thrift-server/contents/{+path}","compare_url":"https://api.github.com/repos/creditkarma/thrift-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/creditkarma/thrift-server/merges","archive_url":"https://api.github.com/repos/creditkarma/thrift-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/creditkarma/thrift-server/downloads","issues_url":"https://api.github.com/repos/creditkarma/thrift-server/issues{/number}","pulls_url":"https://api.github.com/repos/creditkarma/thrift-server/pulls{/number}","milestones_url":"https://api.github.com/repos/creditkarma/thrift-server/milestones{/number}","notifications_url":"https://api.github.com/repos/creditkarma/thrift-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/creditkarma/thrift-server/labels{/name}","releases_url":"https://api.github.com/repos/creditkarma/thrift-server/releases{/id}","deployments_url":"https://api.github.com/repos/creditkarma/thrift-server/deployments","created_at":"2017-07-17T19:43:51Z","updated_at":"2018-08-30T15:23:42Z","pushed_at":"2018-08-30T15:26:19Z","git_url":"git://github.com/creditkarma/thrift-server.git","ssh_url":"git@github.com:creditkarma/thrift-server.git","clone_url":"https://github.com/creditkarma/thrift-server.git","svn_url":"https://github.com/creditkarma/thrift-server","homepage":null,"size":2426,"stargazers_count":8,"watchers_count":8,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/creditkarma/thrift-server/pulls/90"},"html":{"href":"https://github.com/creditkarma/thrift-server/pull/90"},"issue":{"href":"https://api.github.com/repos/creditkarma/thrift-server/issues/90"},"comments":{"href":"https://api.github.com/repos/creditkarma/thrift-server/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/creditkarma/thrift-server/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/creditkarma/thrift-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/creditkarma/thrift-server/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/creditkarma/thrift-server/statuses/27458f8735c29582007a4522e112609c53dc681f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kevin-greene-ck"}}