{"action":"opened","number":126,"pull_request":{"url":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/126","id":178110062,"html_url":"https://github.com/colemanw/webform_civicrm/pull/126","diff_url":"https://github.com/colemanw/webform_civicrm/pull/126.diff","patch_url":"https://github.com/colemanw/webform_civicrm/pull/126.patch","issue_url":"https://api.github.com/repos/colemanw/webform_civicrm/issues/126","number":126,"state":"open","locked":false,"title":"try getfields for address fields rather than hardcoding them and add …","user":{"login":"eyeonall","id":10200090,"avatar_url":"https://avatars2.githubusercontent.com/u/10200090?v=4","gravatar_id":"","url":"https://api.github.com/users/eyeonall","html_url":"https://github.com/eyeonall","followers_url":"https://api.github.com/users/eyeonall/followers","following_url":"https://api.github.com/users/eyeonall/following{/other_user}","gists_url":"https://api.github.com/users/eyeonall/gists{/gist_id}","starred_url":"https://api.github.com/users/eyeonall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyeonall/subscriptions","organizations_url":"https://api.github.com/users/eyeonall/orgs","repos_url":"https://api.github.com/users/eyeonall/repos","events_url":"https://api.github.com/users/eyeonall/events{/privacy}","received_events_url":"https://api.github.com/users/eyeonall/received_events","type":"User","site_admin":false},"body":"The hard coded fields in wf_crm_address_fields does not account for address custom fields. If we change that function to try and use the api getfields method first, list of all address subfields can be obtained, including the supplemental fields.  If the getfields call fails, then revert to the default hardcoded fields. Whatever the fields turn out to be, using drupal_static ensures that the api call to getfields is only called once per request.\r\n\r\nWhen updating a phone with an extension, if we clear out, or change the extension, it is not submitted for update. The module does a good job with adding the correct field parameter to the submitted values so changing the loop to add all of the submitted values allows for other location entity custom fields and the phone extension to be updated.","created_at":"2018-03-28T17:31:14Z","updated_at":"2018-03-28T17:31:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/126/commits","review_comments_url":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/126/comments","review_comment_url":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/colemanw/webform_civicrm/issues/126/comments","statuses_url":"https://api.github.com/repos/colemanw/webform_civicrm/statuses/464e9037fe224c950cb0e252457f40f0673fc2a8","head":{"label":"eyeonall:update_entity_custom_fields","ref":"update_entity_custom_fields","sha":"464e9037fe224c950cb0e252457f40f0673fc2a8","user":{"login":"eyeonall","id":10200090,"avatar_url":"https://avatars2.githubusercontent.com/u/10200090?v=4","gravatar_id":"","url":"https://api.github.com/users/eyeonall","html_url":"https://github.com/eyeonall","followers_url":"https://api.github.com/users/eyeonall/followers","following_url":"https://api.github.com/users/eyeonall/following{/other_user}","gists_url":"https://api.github.com/users/eyeonall/gists{/gist_id}","starred_url":"https://api.github.com/users/eyeonall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyeonall/subscriptions","organizations_url":"https://api.github.com/users/eyeonall/orgs","repos_url":"https://api.github.com/users/eyeonall/repos","events_url":"https://api.github.com/users/eyeonall/events{/privacy}","received_events_url":"https://api.github.com/users/eyeonall/received_events","type":"User","site_admin":false},"repo":{"id":127157136,"name":"webform_civicrm","full_name":"eyeonall/webform_civicrm","owner":{"login":"eyeonall","id":10200090,"avatar_url":"https://avatars2.githubusercontent.com/u/10200090?v=4","gravatar_id":"","url":"https://api.github.com/users/eyeonall","html_url":"https://github.com/eyeonall","followers_url":"https://api.github.com/users/eyeonall/followers","following_url":"https://api.github.com/users/eyeonall/following{/other_user}","gists_url":"https://api.github.com/users/eyeonall/gists{/gist_id}","starred_url":"https://api.github.com/users/eyeonall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eyeonall/subscriptions","organizations_url":"https://api.github.com/users/eyeonall/orgs","repos_url":"https://api.github.com/users/eyeonall/repos","events_url":"https://api.github.com/users/eyeonall/events{/privacy}","received_events_url":"https://api.github.com/users/eyeonall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eyeonall/webform_civicrm","description":"A powerful, flexible, user-friendly form builder for CiviCRM.","fork":true,"url":"https://api.github.com/repos/eyeonall/webform_civicrm","forks_url":"https://api.github.com/repos/eyeonall/webform_civicrm/forks","keys_url":"https://api.github.com/repos/eyeonall/webform_civicrm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eyeonall/webform_civicrm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eyeonall/webform_civicrm/teams","hooks_url":"https://api.github.com/repos/eyeonall/webform_civicrm/hooks","issue_events_url":"https://api.github.com/repos/eyeonall/webform_civicrm/issues/events{/number}","events_url":"https://api.github.com/repos/eyeonall/webform_civicrm/events","assignees_url":"https://api.github.com/repos/eyeonall/webform_civicrm/assignees{/user}","branches_url":"https://api.github.com/repos/eyeonall/webform_civicrm/branches{/branch}","tags_url":"https://api.github.com/repos/eyeonall/webform_civicrm/tags","blobs_url":"https://api.github.com/repos/eyeonall/webform_civicrm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eyeonall/webform_civicrm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eyeonall/webform_civicrm/git/refs{/sha}","trees_url":"https://api.github.com/repos/eyeonall/webform_civicrm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eyeonall/webform_civicrm/statuses/{sha}","languages_url":"https://api.github.com/repos/eyeonall/webform_civicrm/languages","stargazers_url":"https://api.github.com/repos/eyeonall/webform_civicrm/stargazers","contributors_url":"https://api.github.com/repos/eyeonall/webform_civicrm/contributors","subscribers_url":"https://api.github.com/repos/eyeonall/webform_civicrm/subscribers","subscription_url":"https://api.github.com/repos/eyeonall/webform_civicrm/subscription","commits_url":"https://api.github.com/repos/eyeonall/webform_civicrm/commits{/sha}","git_commits_url":"https://api.github.com/repos/eyeonall/webform_civicrm/git/commits{/sha}","comments_url":"https://api.github.com/repos/eyeonall/webform_civicrm/comments{/number}","issue_comment_url":"https://api.github.com/repos/eyeonall/webform_civicrm/issues/comments{/number}","contents_url":"https://api.github.com/repos/eyeonall/webform_civicrm/contents/{+path}","compare_url":"https://api.github.com/repos/eyeonall/webform_civicrm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eyeonall/webform_civicrm/merges","archive_url":"https://api.github.com/repos/eyeonall/webform_civicrm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eyeonall/webform_civicrm/downloads","issues_url":"https://api.github.com/repos/eyeonall/webform_civicrm/issues{/number}","pulls_url":"https://api.github.com/repos/eyeonall/webform_civicrm/pulls{/number}","milestones_url":"https://api.github.com/repos/eyeonall/webform_civicrm/milestones{/number}","notifications_url":"https://api.github.com/repos/eyeonall/webform_civicrm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eyeonall/webform_civicrm/labels{/name}","releases_url":"https://api.github.com/repos/eyeonall/webform_civicrm/releases{/id}","deployments_url":"https://api.github.com/repos/eyeonall/webform_civicrm/deployments","created_at":"2018-03-28T15:00:05Z","updated_at":"2018-03-28T15:00:07Z","pushed_at":"2018-03-28T17:25:15Z","git_url":"git://github.com/eyeonall/webform_civicrm.git","ssh_url":"git@github.com:eyeonall/webform_civicrm.git","clone_url":"https://github.com/eyeonall/webform_civicrm.git","svn_url":"https://github.com/eyeonall/webform_civicrm","homepage":"https://www.drupal.org/project/webform_civicrm","size":1662,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"7.x-4.x"}},"base":{"label":"colemanw:7.x-4.x","ref":"7.x-4.x","sha":"d6fcc1aa6bc86edcc10ef816f2ed9670934caf4a","user":{"login":"colemanw","id":2874912,"avatar_url":"https://avatars3.githubusercontent.com/u/2874912?v=4","gravatar_id":"","url":"https://api.github.com/users/colemanw","html_url":"https://github.com/colemanw","followers_url":"https://api.github.com/users/colemanw/followers","following_url":"https://api.github.com/users/colemanw/following{/other_user}","gists_url":"https://api.github.com/users/colemanw/gists{/gist_id}","starred_url":"https://api.github.com/users/colemanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colemanw/subscriptions","organizations_url":"https://api.github.com/users/colemanw/orgs","repos_url":"https://api.github.com/users/colemanw/repos","events_url":"https://api.github.com/users/colemanw/events{/privacy}","received_events_url":"https://api.github.com/users/colemanw/received_events","type":"User","site_admin":false},"repo":{"id":33629346,"name":"webform_civicrm","full_name":"colemanw/webform_civicrm","owner":{"login":"colemanw","id":2874912,"avatar_url":"https://avatars3.githubusercontent.com/u/2874912?v=4","gravatar_id":"","url":"https://api.github.com/users/colemanw","html_url":"https://github.com/colemanw","followers_url":"https://api.github.com/users/colemanw/followers","following_url":"https://api.github.com/users/colemanw/following{/other_user}","gists_url":"https://api.github.com/users/colemanw/gists{/gist_id}","starred_url":"https://api.github.com/users/colemanw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colemanw/subscriptions","organizations_url":"https://api.github.com/users/colemanw/orgs","repos_url":"https://api.github.com/users/colemanw/repos","events_url":"https://api.github.com/users/colemanw/events{/privacy}","received_events_url":"https://api.github.com/users/colemanw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colemanw/webform_civicrm","description":"A powerful, flexible, user-friendly form builder for CiviCRM.","fork":false,"url":"https://api.github.com/repos/colemanw/webform_civicrm","forks_url":"https://api.github.com/repos/colemanw/webform_civicrm/forks","keys_url":"https://api.github.com/repos/colemanw/webform_civicrm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colemanw/webform_civicrm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colemanw/webform_civicrm/teams","hooks_url":"https://api.github.com/repos/colemanw/webform_civicrm/hooks","issue_events_url":"https://api.github.com/repos/colemanw/webform_civicrm/issues/events{/number}","events_url":"https://api.github.com/repos/colemanw/webform_civicrm/events","assignees_url":"https://api.github.com/repos/colemanw/webform_civicrm/assignees{/user}","branches_url":"https://api.github.com/repos/colemanw/webform_civicrm/branches{/branch}","tags_url":"https://api.github.com/repos/colemanw/webform_civicrm/tags","blobs_url":"https://api.github.com/repos/colemanw/webform_civicrm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colemanw/webform_civicrm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colemanw/webform_civicrm/git/refs{/sha}","trees_url":"https://api.github.com/repos/colemanw/webform_civicrm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colemanw/webform_civicrm/statuses/{sha}","languages_url":"https://api.github.com/repos/colemanw/webform_civicrm/languages","stargazers_url":"https://api.github.com/repos/colemanw/webform_civicrm/stargazers","contributors_url":"https://api.github.com/repos/colemanw/webform_civicrm/contributors","subscribers_url":"https://api.github.com/repos/colemanw/webform_civicrm/subscribers","subscription_url":"https://api.github.com/repos/colemanw/webform_civicrm/subscription","commits_url":"https://api.github.com/repos/colemanw/webform_civicrm/commits{/sha}","git_commits_url":"https://api.github.com/repos/colemanw/webform_civicrm/git/commits{/sha}","comments_url":"https://api.github.com/repos/colemanw/webform_civicrm/comments{/number}","issue_comment_url":"https://api.github.com/repos/colemanw/webform_civicrm/issues/comments{/number}","contents_url":"https://api.github.com/repos/colemanw/webform_civicrm/contents/{+path}","compare_url":"https://api.github.com/repos/colemanw/webform_civicrm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colemanw/webform_civicrm/merges","archive_url":"https://api.github.com/repos/colemanw/webform_civicrm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colemanw/webform_civicrm/downloads","issues_url":"https://api.github.com/repos/colemanw/webform_civicrm/issues{/number}","pulls_url":"https://api.github.com/repos/colemanw/webform_civicrm/pulls{/number}","milestones_url":"https://api.github.com/repos/colemanw/webform_civicrm/milestones{/number}","notifications_url":"https://api.github.com/repos/colemanw/webform_civicrm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colemanw/webform_civicrm/labels{/name}","releases_url":"https://api.github.com/repos/colemanw/webform_civicrm/releases{/id}","deployments_url":"https://api.github.com/repos/colemanw/webform_civicrm/deployments","created_at":"2015-04-08T20:04:31Z","updated_at":"2018-03-22T18:45:52Z","pushed_at":"2018-03-27T10:27:09Z","git_url":"git://github.com/colemanw/webform_civicrm.git","ssh_url":"git@github.com:colemanw/webform_civicrm.git","clone_url":"https://github.com/colemanw/webform_civicrm.git","svn_url":"https://github.com/colemanw/webform_civicrm","homepage":"https://www.drupal.org/project/webform_civicrm","size":1662,"stargazers_count":11,"watchers_count":11,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":14,"license":null,"forks":49,"open_issues":14,"watchers":11,"default_branch":"7.x-4.x"}},"_links":{"self":{"href":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/126"},"html":{"href":"https://github.com/colemanw/webform_civicrm/pull/126"},"issue":{"href":"https://api.github.com/repos/colemanw/webform_civicrm/issues/126"},"comments":{"href":"https://api.github.com/repos/colemanw/webform_civicrm/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/colemanw/webform_civicrm/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/colemanw/webform_civicrm/statuses/464e9037fe224c950cb0e252457f40f0673fc2a8"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":39,"deletions":20,"changed_files":2}}
{"actor":{"display_login":"eyeonall"}}