{"action":"created","comment":{"url":"https://api.github.com/repos/folio-org/raml-module-builder/pulls/comments/242300423","pull_request_review_id":185778799,"id":242300423,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjMwMDQyMw==","diff_hunk":"@@ -1406,13 +1428,13 @@ public TotaledResults(ResultSet set, Integer total) {\n    */\n   private <T> void doStreamGet(\n     SQLConnection connection, boolean transactionMode, String table, Class<T> clazz,\n-    String fieldName, String where, boolean returnIdField, boolean setId, List<FacetField> facets,\n+    String fieldName, String where, boolean returnIdField, boolean setId, List<FacetField> facets, String distinctOn,\n     Handler<T> streamHandler, Handler<AsyncResult<?>> replyHandler","path":"domain-models-runtime/src/main/java/org/folio/rest/persist/PostgresClient.java","position":136,"original_position":136,"commit_id":"9a6a15a7497519f56a39216a7796f0b9106da8c3","original_commit_id":"9a6a15a7497519f56a39216a7796f0b9106da8c3","user":{"login":"sonarcloud[bot]","id":39514782,"node_id":"MDM6Qm90Mzk1MTQ3ODI=","avatar_url":"https://avatars2.githubusercontent.com/in/12526?v=4","gravatar_id":"","url":"https://api.github.com/users/sonarcloud%5Bbot%5D","html_url":"https://github.com/apps/sonarcloud","followers_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/followers","following_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/repos","events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/sonarcloud%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"![Code Smell](https://sonarsource.github.io/sonar-github/code_smell.png 'Code Smell') Code Smell: Method has 10 parameters, which is greater than 7 authorized. ([squid:S00107](https://sonarcloud.io/organizations/folio-org/rules#rule_key=squid%3AS00107))\n\n[See it in SonarCloud](https://sonarcloud.io/project/issues?id=org.folio%3Araml-module-builder&pullRequest=332&issues=AWdHW5rBGn-j85A90JCK&open=AWdHW5rBGn-j85A90JCK)\n\n[ISSUE_KEY]: AWdHW5rBGn-j85A90JCK","created_at":"2018-12-17T20:14:34Z","updated_at":"2018-12-17T20:14:35Z","html_url":"https://github.com/folio-org/raml-module-builder/pull/332#discussion_r242300423","pull_request_url":"https://api.github.com/repos/folio-org/raml-module-builder/pulls/332","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/folio-org/raml-module-builder/pulls/comments/242300423"},"html":{"href":"https://github.com/folio-org/raml-module-builder/pull/332#discussion_r242300423"},"pull_request":{"href":"https://api.github.com/repos/folio-org/raml-module-builder/pulls/332"}}},"pull_request":{"url":"https://api.github.com/repos/folio-org/raml-module-builder/pulls/332","id":232805331,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyODA1MzMx","html_url":"https://github.com/folio-org/raml-module-builder/pull/332","diff_url":"https://github.com/folio-org/raml-module-builder/pull/332.diff","patch_url":"https://github.com/folio-org/raml-module-builder/pull/332.patch","issue_url":"https://api.github.com/repos/folio-org/raml-module-builder/issues/332","number":332,"state":"open","locked":false,"title":"RMB-305: incorporate the use of DISTINCT (ON)","user":{"login":"craigmcnally","id":24814831,"node_id":"MDQ6VXNlcjI0ODE0ODMx","avatar_url":"https://avatars1.githubusercontent.com/u/24814831?v=4","gravatar_id":"","url":"https://api.github.com/users/craigmcnally","html_url":"https://github.com/craigmcnally","followers_url":"https://api.github.com/users/craigmcnally/followers","following_url":"https://api.github.com/users/craigmcnally/following{/other_user}","gists_url":"https://api.github.com/users/craigmcnally/gists{/gist_id}","starred_url":"https://api.github.com/users/craigmcnally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigmcnally/subscriptions","organizations_url":"https://api.github.com/users/craigmcnally/orgs","repos_url":"https://api.github.com/users/craigmcnally/repos","events_url":"https://api.github.com/users/craigmcnally/events{/privacy}","received_events_url":"https://api.github.com/users/craigmcnally/received_events","type":"User","site_admin":false},"body":"WIP - need to add unit tests before requesting review.","created_at":"2018-11-21T21:43:22Z","updated_at":"2018-12-17T20:14:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"269a79946b8c798d2a52a9f32df9907f22af718a","assignee":{"login":"craigmcnally","id":24814831,"node_id":"MDQ6VXNlcjI0ODE0ODMx","avatar_url":"https://avatars1.githubusercontent.com/u/24814831?v=4","gravatar_id":"","url":"https://api.github.com/users/craigmcnally","html_url":"https://github.com/craigmcnally","followers_url":"https://api.github.com/users/craigmcnally/followers","following_url":"https://api.github.com/users/craigmcnally/following{/other_user}","gists_url":"https://api.github.com/users/craigmcnally/gists{/gist_id}","starred_url":"https://api.github.com/users/craigmcnally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigmcnally/subscriptions","organizations_url":"https://api.github.com/users/craigmcnally/orgs","repos_url":"https://api.github.com/users/craigmcnally/repos","events_url":"https://api.github.com/users/craigmcnally/events{/privacy}","received_events_url":"https://api.github.com/users/craigmcnally/received_events","type":"User","site_admin":false},"assignees":[{"login":"craigmcnally","id":24814831,"node_id":"MDQ6VXNlcjI0ODE0ODMx","avatar_url":"https://avatars1.githubusercontent.com/u/24814831?v=4","gravatar_id":"","url":"https://api.github.com/users/craigmcnally","html_url":"https://github.com/craigmcnally","followers_url":"https://api.github.com/users/craigmcnally/followers","following_url":"https://api.github.com/users/craigmcnally/following{/other_user}","gists_url":"https://api.github.com/users/craigmcnally/gists{/gist_id}","starred_url":"https://api.github.com/users/craigmcnally/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigmcnally/subscriptions","organizations_url":"https://api.github.com/users/craigmcnally/orgs","repos_url":"https://api.github.com/users/craigmcnally/repos","events_url":"https://api.github.com/users/craigmcnally/events{/privacy}","received_events_url":"https://api.github.com/users/craigmcnally/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/folio-org/raml-module-builder/pulls/332/commits","review_comments_url":"https://api.github.com/repos/folio-org/raml-module-builder/pulls/332/comments","review_comment_url":"https://api.github.com/repos/folio-org/raml-module-builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/folio-org/raml-module-builder/issues/332/comments","statuses_url":"https://api.github.com/repos/folio-org/raml-module-builder/statuses/9a6a15a7497519f56a39216a7796f0b9106da8c3","head":{"label":"folio-org:DistinctOn","ref":"DistinctOn","sha":"9a6a15a7497519f56a39216a7796f0b9106da8c3","user":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"repo":{"id":65975333,"node_id":"MDEwOlJlcG9zaXRvcnk2NTk3NTMzMw==","name":"raml-module-builder","full_name":"folio-org/raml-module-builder","private":false,"owner":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/folio-org/raml-module-builder","description":"Framework allowing easy module creation based on RAML files","fork":false,"url":"https://api.github.com/repos/folio-org/raml-module-builder","forks_url":"https://api.github.com/repos/folio-org/raml-module-builder/forks","keys_url":"https://api.github.com/repos/folio-org/raml-module-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/folio-org/raml-module-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/folio-org/raml-module-builder/teams","hooks_url":"https://api.github.com/repos/folio-org/raml-module-builder/hooks","issue_events_url":"https://api.github.com/repos/folio-org/raml-module-builder/issues/events{/number}","events_url":"https://api.github.com/repos/folio-org/raml-module-builder/events","assignees_url":"https://api.github.com/repos/folio-org/raml-module-builder/assignees{/user}","branches_url":"https://api.github.com/repos/folio-org/raml-module-builder/branches{/branch}","tags_url":"https://api.github.com/repos/folio-org/raml-module-builder/tags","blobs_url":"https://api.github.com/repos/folio-org/raml-module-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/folio-org/raml-module-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/folio-org/raml-module-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/folio-org/raml-module-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/folio-org/raml-module-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/folio-org/raml-module-builder/languages","stargazers_url":"https://api.github.com/repos/folio-org/raml-module-builder/stargazers","contributors_url":"https://api.github.com/repos/folio-org/raml-module-builder/contributors","subscribers_url":"https://api.github.com/repos/folio-org/raml-module-builder/subscribers","subscription_url":"https://api.github.com/repos/folio-org/raml-module-builder/subscription","commits_url":"https://api.github.com/repos/folio-org/raml-module-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/folio-org/raml-module-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/folio-org/raml-module-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/folio-org/raml-module-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/folio-org/raml-module-builder/contents/{+path}","compare_url":"https://api.github.com/repos/folio-org/raml-module-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/folio-org/raml-module-builder/merges","archive_url":"https://api.github.com/repos/folio-org/raml-module-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/folio-org/raml-module-builder/downloads","issues_url":"https://api.github.com/repos/folio-org/raml-module-builder/issues{/number}","pulls_url":"https://api.github.com/repos/folio-org/raml-module-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/folio-org/raml-module-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/folio-org/raml-module-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/folio-org/raml-module-builder/labels{/name}","releases_url":"https://api.github.com/repos/folio-org/raml-module-builder/releases{/id}","deployments_url":"https://api.github.com/repos/folio-org/raml-module-builder/deployments","created_at":"2016-08-18T07:28:13Z","updated_at":"2018-12-17T16:27:19Z","pushed_at":"2018-12-17T16:27:16Z","git_url":"git://github.com/folio-org/raml-module-builder.git","ssh_url":"git@github.com:folio-org/raml-module-builder.git","clone_url":"https://github.com/folio-org/raml-module-builder.git","svn_url":"https://github.com/folio-org/raml-module-builder","homepage":"","size":5586,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":3,"watchers":10,"default_branch":"master"}},"base":{"label":"folio-org:master","ref":"master","sha":"c2c4fa12fa2abe58a7e2120ae1c191349e8698be","user":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"repo":{"id":65975333,"node_id":"MDEwOlJlcG9zaXRvcnk2NTk3NTMzMw==","name":"raml-module-builder","full_name":"folio-org/raml-module-builder","private":false,"owner":{"login":"folio-org","id":16495055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDk1MDU1","avatar_url":"https://avatars2.githubusercontent.com/u/16495055?v=4","gravatar_id":"","url":"https://api.github.com/users/folio-org","html_url":"https://github.com/folio-org","followers_url":"https://api.github.com/users/folio-org/followers","following_url":"https://api.github.com/users/folio-org/following{/other_user}","gists_url":"https://api.github.com/users/folio-org/gists{/gist_id}","starred_url":"https://api.github.com/users/folio-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/folio-org/subscriptions","organizations_url":"https://api.github.com/users/folio-org/orgs","repos_url":"https://api.github.com/users/folio-org/repos","events_url":"https://api.github.com/users/folio-org/events{/privacy}","received_events_url":"https://api.github.com/users/folio-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/folio-org/raml-module-builder","description":"Framework allowing easy module creation based on RAML files","fork":false,"url":"https://api.github.com/repos/folio-org/raml-module-builder","forks_url":"https://api.github.com/repos/folio-org/raml-module-builder/forks","keys_url":"https://api.github.com/repos/folio-org/raml-module-builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/folio-org/raml-module-builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/folio-org/raml-module-builder/teams","hooks_url":"https://api.github.com/repos/folio-org/raml-module-builder/hooks","issue_events_url":"https://api.github.com/repos/folio-org/raml-module-builder/issues/events{/number}","events_url":"https://api.github.com/repos/folio-org/raml-module-builder/events","assignees_url":"https://api.github.com/repos/folio-org/raml-module-builder/assignees{/user}","branches_url":"https://api.github.com/repos/folio-org/raml-module-builder/branches{/branch}","tags_url":"https://api.github.com/repos/folio-org/raml-module-builder/tags","blobs_url":"https://api.github.com/repos/folio-org/raml-module-builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/folio-org/raml-module-builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/folio-org/raml-module-builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/folio-org/raml-module-builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/folio-org/raml-module-builder/statuses/{sha}","languages_url":"https://api.github.com/repos/folio-org/raml-module-builder/languages","stargazers_url":"https://api.github.com/repos/folio-org/raml-module-builder/stargazers","contributors_url":"https://api.github.com/repos/folio-org/raml-module-builder/contributors","subscribers_url":"https://api.github.com/repos/folio-org/raml-module-builder/subscribers","subscription_url":"https://api.github.com/repos/folio-org/raml-module-builder/subscription","commits_url":"https://api.github.com/repos/folio-org/raml-module-builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/folio-org/raml-module-builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/folio-org/raml-module-builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/folio-org/raml-module-builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/folio-org/raml-module-builder/contents/{+path}","compare_url":"https://api.github.com/repos/folio-org/raml-module-builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/folio-org/raml-module-builder/merges","archive_url":"https://api.github.com/repos/folio-org/raml-module-builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/folio-org/raml-module-builder/downloads","issues_url":"https://api.github.com/repos/folio-org/raml-module-builder/issues{/number}","pulls_url":"https://api.github.com/repos/folio-org/raml-module-builder/pulls{/number}","milestones_url":"https://api.github.com/repos/folio-org/raml-module-builder/milestones{/number}","notifications_url":"https://api.github.com/repos/folio-org/raml-module-builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/folio-org/raml-module-builder/labels{/name}","releases_url":"https://api.github.com/repos/folio-org/raml-module-builder/releases{/id}","deployments_url":"https://api.github.com/repos/folio-org/raml-module-builder/deployments","created_at":"2016-08-18T07:28:13Z","updated_at":"2018-12-17T16:27:19Z","pushed_at":"2018-12-17T16:27:16Z","git_url":"git://github.com/folio-org/raml-module-builder.git","ssh_url":"git@github.com:folio-org/raml-module-builder.git","clone_url":"https://github.com/folio-org/raml-module-builder.git","svn_url":"https://github.com/folio-org/raml-module-builder","homepage":"","size":5586,"stargazers_count":10,"watchers_count":10,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":3,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/folio-org/raml-module-builder/pulls/332"},"html":{"href":"https://github.com/folio-org/raml-module-builder/pull/332"},"issue":{"href":"https://api.github.com/repos/folio-org/raml-module-builder/issues/332"},"comments":{"href":"https://api.github.com/repos/folio-org/raml-module-builder/issues/332/comments"},"review_comments":{"href":"https://api.github.com/repos/folio-org/raml-module-builder/pulls/332/comments"},"review_comment":{"href":"https://api.github.com/repos/folio-org/raml-module-builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/folio-org/raml-module-builder/pulls/332/commits"},"statuses":{"href":"https://api.github.com/repos/folio-org/raml-module-builder/statuses/9a6a15a7497519f56a39216a7796f0b9106da8c3"}},"author_association":"NONE"}}
{"actor":{"display_login":"sonarcloud"}}