{"action":"created","comment":{"url":"https://api.github.com/repos/corda/corda/pulls/comments/167197542","pull_request_review_id":95362990,"id":167197542,"diff_hunk":"@@ -178,6 +178,10 @@ UNRELEASED\n * Marked ``stateMachine`` on ``FlowLogic`` as ``CordaInternal`` to make clear that is it not part of the public api and is\n   only for internal use\n \n+* Created a new ``MockNetwork`` for creating mock networks for testing, and ``StartedMockNode`` and ``UnstartedMockNode``","path":"docs/source/changelog.rst","position":4,"original_position":4,"commit_id":"4b78df8054f8b178682ea04ab553c44f646873b2","original_commit_id":"4b78df8054f8b178682ea04ab553c44f646873b2","user":{"login":"shamsasari","id":3883563,"avatar_url":"https://avatars3.githubusercontent.com/u/3883563?v=4","gravatar_id":"","url":"https://api.github.com/users/shamsasari","html_url":"https://github.com/shamsasari","followers_url":"https://api.github.com/users/shamsasari/followers","following_url":"https://api.github.com/users/shamsasari/following{/other_user}","gists_url":"https://api.github.com/users/shamsasari/gists{/gist_id}","starred_url":"https://api.github.com/users/shamsasari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shamsasari/subscriptions","organizations_url":"https://api.github.com/users/shamsasari/orgs","repos_url":"https://api.github.com/users/shamsasari/repos","events_url":"https://api.github.com/users/shamsasari/events{/privacy}","received_events_url":"https://api.github.com/users/shamsasari/received_events","type":"User","site_admin":false},"body":"From the point of view of app developers what has changed, just StartedMockNode and UnstartedMockNode, right? `MockNetwork` has stayed the same, no? Describing it as \"new\" implies a complete rewrite.","created_at":"2018-02-09T10:55:29Z","updated_at":"2018-02-09T10:56:11Z","html_url":"https://github.com/corda/corda/pull/2472#discussion_r167197542","pull_request_url":"https://api.github.com/repos/corda/corda/pulls/2472","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/comments/167197542"},"html":{"href":"https://github.com/corda/corda/pull/2472#discussion_r167197542"},"pull_request":{"href":"https://api.github.com/repos/corda/corda/pulls/2472"}}},"pull_request":{"url":"https://api.github.com/repos/corda/corda/pulls/2472","id":167472903,"html_url":"https://github.com/corda/corda/pull/2472","diff_url":"https://github.com/corda/corda/pull/2472.diff","patch_url":"https://github.com/corda/corda/pull/2472.patch","issue_url":"https://api.github.com/repos/corda/corda/issues/2472","number":2472,"state":"open","locked":false,"title":"CORDA-939 - Don't expose StartedNode and AbstractNode as part of public test api","user":{"login":"anthonykr3","id":34482776,"avatar_url":"https://avatars3.githubusercontent.com/u/34482776?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonykr3","html_url":"https://github.com/anthonykr3","followers_url":"https://api.github.com/users/anthonykr3/followers","following_url":"https://api.github.com/users/anthonykr3/following{/other_user}","gists_url":"https://api.github.com/users/anthonykr3/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonykr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonykr3/subscriptions","organizations_url":"https://api.github.com/users/anthonykr3/orgs","repos_url":"https://api.github.com/users/anthonykr3/repos","events_url":"https://api.github.com/users/anthonykr3/events{/privacy}","received_events_url":"https://api.github.com/users/anthonykr3/received_events","type":"User","site_admin":false},"body":"Renamed MockNetwork as InternalMockNetwork and moved to the Internal namespace. \r\n\r\nCreated a new MockNetwork and MockNode which don't expose any internal API's\r\n\r\nThere are still some tests internally which use the InternalMockNetwork directly - that is because they inject custom AbstractNode implementations. Since AbstractNode shouldn't be implemented outside of Corda this seems like the best course of action.","created_at":"2018-02-06T17:03:17Z","updated_at":"2018-02-09T10:56:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5dd3da1241f5ec0ee2dc625211b2baaa3acf6ffa","assignee":{"login":"anthonykr3","id":34482776,"avatar_url":"https://avatars3.githubusercontent.com/u/34482776?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonykr3","html_url":"https://github.com/anthonykr3","followers_url":"https://api.github.com/users/anthonykr3/followers","following_url":"https://api.github.com/users/anthonykr3/following{/other_user}","gists_url":"https://api.github.com/users/anthonykr3/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonykr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonykr3/subscriptions","organizations_url":"https://api.github.com/users/anthonykr3/orgs","repos_url":"https://api.github.com/users/anthonykr3/repos","events_url":"https://api.github.com/users/anthonykr3/events{/privacy}","received_events_url":"https://api.github.com/users/anthonykr3/received_events","type":"User","site_admin":false},"assignees":[{"login":"anthonykr3","id":34482776,"avatar_url":"https://avatars3.githubusercontent.com/u/34482776?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonykr3","html_url":"https://github.com/anthonykr3","followers_url":"https://api.github.com/users/anthonykr3/followers","following_url":"https://api.github.com/users/anthonykr3/following{/other_user}","gists_url":"https://api.github.com/users/anthonykr3/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonykr3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonykr3/subscriptions","organizations_url":"https://api.github.com/users/anthonykr3/orgs","repos_url":"https://api.github.com/users/anthonykr3/repos","events_url":"https://api.github.com/users/anthonykr3/events{/privacy}","received_events_url":"https://api.github.com/users/anthonykr3/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/corda/corda/pulls/2472/commits","review_comments_url":"https://api.github.com/repos/corda/corda/pulls/2472/comments","review_comment_url":"https://api.github.com/repos/corda/corda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/corda/corda/issues/2472/comments","statuses_url":"https://api.github.com/repos/corda/corda/statuses/4b78df8054f8b178682ea04ab553c44f646873b2","head":{"label":"corda:anthony-dont-expose-startednode","ref":"anthony-dont-expose-startednode","sha":"4b78df8054f8b178682ea04ab553c44f646873b2","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions yet with applications in multiple industries.  It offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-02-09T10:22:28Z","pushed_at":"2018-02-09T10:36:19Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":106790,"stargazers_count":1444,"watchers_count":1444,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":391,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":391,"open_issues":128,"watchers":1444,"default_branch":"master"}},"base":{"label":"corda:master","ref":"master","sha":"2986e2f5a9559a2dc7bdcaab80e8a4274a3c6b1d","user":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"repo":{"id":70137417,"name":"corda","full_name":"corda/corda","owner":{"login":"corda","id":22600631,"avatar_url":"https://avatars1.githubusercontent.com/u/22600631?v=4","gravatar_id":"","url":"https://api.github.com/users/corda","html_url":"https://github.com/corda","followers_url":"https://api.github.com/users/corda/followers","following_url":"https://api.github.com/users/corda/following{/other_user}","gists_url":"https://api.github.com/users/corda/gists{/gist_id}","starred_url":"https://api.github.com/users/corda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corda/subscriptions","organizations_url":"https://api.github.com/users/corda/orgs","repos_url":"https://api.github.com/users/corda/repos","events_url":"https://api.github.com/users/corda/events{/privacy}","received_events_url":"https://api.github.com/users/corda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/corda/corda","description":"Corda is a distributed ledger platform designed to record, manage and automate legal agreements between business partners. Designed by (and for) the world's largest financial institutions yet with applications in multiple industries.  It offers a unique response to the privacy and scalability challenges facing decentralised applications.","fork":false,"url":"https://api.github.com/repos/corda/corda","forks_url":"https://api.github.com/repos/corda/corda/forks","keys_url":"https://api.github.com/repos/corda/corda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corda/corda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corda/corda/teams","hooks_url":"https://api.github.com/repos/corda/corda/hooks","issue_events_url":"https://api.github.com/repos/corda/corda/issues/events{/number}","events_url":"https://api.github.com/repos/corda/corda/events","assignees_url":"https://api.github.com/repos/corda/corda/assignees{/user}","branches_url":"https://api.github.com/repos/corda/corda/branches{/branch}","tags_url":"https://api.github.com/repos/corda/corda/tags","blobs_url":"https://api.github.com/repos/corda/corda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corda/corda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corda/corda/git/refs{/sha}","trees_url":"https://api.github.com/repos/corda/corda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corda/corda/statuses/{sha}","languages_url":"https://api.github.com/repos/corda/corda/languages","stargazers_url":"https://api.github.com/repos/corda/corda/stargazers","contributors_url":"https://api.github.com/repos/corda/corda/contributors","subscribers_url":"https://api.github.com/repos/corda/corda/subscribers","subscription_url":"https://api.github.com/repos/corda/corda/subscription","commits_url":"https://api.github.com/repos/corda/corda/commits{/sha}","git_commits_url":"https://api.github.com/repos/corda/corda/git/commits{/sha}","comments_url":"https://api.github.com/repos/corda/corda/comments{/number}","issue_comment_url":"https://api.github.com/repos/corda/corda/issues/comments{/number}","contents_url":"https://api.github.com/repos/corda/corda/contents/{+path}","compare_url":"https://api.github.com/repos/corda/corda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corda/corda/merges","archive_url":"https://api.github.com/repos/corda/corda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corda/corda/downloads","issues_url":"https://api.github.com/repos/corda/corda/issues{/number}","pulls_url":"https://api.github.com/repos/corda/corda/pulls{/number}","milestones_url":"https://api.github.com/repos/corda/corda/milestones{/number}","notifications_url":"https://api.github.com/repos/corda/corda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corda/corda/labels{/name}","releases_url":"https://api.github.com/repos/corda/corda/releases{/id}","deployments_url":"https://api.github.com/repos/corda/corda/deployments","created_at":"2016-10-06T08:46:29Z","updated_at":"2018-02-09T10:22:28Z","pushed_at":"2018-02-09T10:36:19Z","git_url":"git://github.com/corda/corda.git","ssh_url":"git@github.com:corda/corda.git","clone_url":"https://github.com/corda/corda.git","svn_url":"https://github.com/corda/corda","homepage":"https://www.corda.net","size":106790,"stargazers_count":1444,"watchers_count":1444,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":391,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":391,"open_issues":128,"watchers":1444,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/corda/corda/pulls/2472"},"html":{"href":"https://github.com/corda/corda/pull/2472"},"issue":{"href":"https://api.github.com/repos/corda/corda/issues/2472"},"comments":{"href":"https://api.github.com/repos/corda/corda/issues/2472/comments"},"review_comments":{"href":"https://api.github.com/repos/corda/corda/pulls/2472/comments"},"review_comment":{"href":"https://api.github.com/repos/corda/corda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/corda/corda/pulls/2472/commits"},"statuses":{"href":"https://api.github.com/repos/corda/corda/statuses/4b78df8054f8b178682ea04ab553c44f646873b2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shamsasari"}}