{"action":"closed","number":20116,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20116","id":182363326,"html_url":"https://github.com/nodejs/node/pull/20116","diff_url":"https://github.com/nodejs/node/pull/20116.diff","patch_url":"https://github.com/nodejs/node/pull/20116.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/20116","number":20116,"state":"closed","locked":false,"title":"test: check that modules backed by read-only files can load (win32)","user":{"login":"billti","id":993909,"avatar_url":"https://avatars3.githubusercontent.com/u/993909?v=4","gravatar_id":"","url":"https://api.github.com/users/billti","html_url":"https://github.com/billti","followers_url":"https://api.github.com/users/billti/followers","following_url":"https://api.github.com/users/billti/following{/other_user}","gists_url":"https://api.github.com/users/billti/gists{/gist_id}","starred_url":"https://api.github.com/users/billti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billti/subscriptions","organizations_url":"https://api.github.com/users/billti/orgs","repos_url":"https://api.github.com/users/billti/repos","events_url":"https://api.github.com/users/billti/events{/privacy}","received_events_url":"https://api.github.com/users/billti/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\nThis is the test-case for the issue at https://github.com/nodejs/node/issues/20112 . This fails with the issue present, and passes with the fix applied. \r\n\r\nNote: Even before any changes, `vcbuild test` gave a ton of failures for me, so not sure if that is my machine or something more fundamental. This test behaves as expected though.\r\n\r\nCC @vsemozhetbyt, @cjihrig, @richardlau ","created_at":"2018-04-18T04:14:28Z","updated_at":"2018-04-18T19:01:50Z","closed_at":"2018-04-18T19:01:49Z","merged_at":null,"merge_commit_sha":"84e6640b5ca9142f20efdda82e0da1db1b259fec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":362054330,"url":"https://api.github.com/repos/nodejs/node/labels/blocked","name":"blocked","color":"b60205","default":false},{"id":176240519,"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false},{"id":904071494,"url":"https://api.github.com/repos/nodejs/node/labels/v10.x","name":"v10.x","color":"4213c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/20116/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/20116/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20116/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/860578d005da89b56b37c7dac3a6649d576ed077","head":{"label":"billti:test-read-only-modules","ref":"test-read-only-modules","sha":"860578d005da89b56b37c7dac3a6649d576ed077","user":{"login":"billti","id":993909,"avatar_url":"https://avatars3.githubusercontent.com/u/993909?v=4","gravatar_id":"","url":"https://api.github.com/users/billti","html_url":"https://github.com/billti","followers_url":"https://api.github.com/users/billti/followers","following_url":"https://api.github.com/users/billti/following{/other_user}","gists_url":"https://api.github.com/users/billti/gists{/gist_id}","starred_url":"https://api.github.com/users/billti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billti/subscriptions","organizations_url":"https://api.github.com/users/billti/orgs","repos_url":"https://api.github.com/users/billti/repos","events_url":"https://api.github.com/users/billti/events{/privacy}","received_events_url":"https://api.github.com/users/billti/received_events","type":"User","site_admin":false},"repo":{"id":130001952,"name":"node","full_name":"billti/node","owner":{"login":"billti","id":993909,"avatar_url":"https://avatars3.githubusercontent.com/u/993909?v=4","gravatar_id":"","url":"https://api.github.com/users/billti","html_url":"https://github.com/billti","followers_url":"https://api.github.com/users/billti/followers","following_url":"https://api.github.com/users/billti/following{/other_user}","gists_url":"https://api.github.com/users/billti/gists{/gist_id}","starred_url":"https://api.github.com/users/billti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billti/subscriptions","organizations_url":"https://api.github.com/users/billti/orgs","repos_url":"https://api.github.com/users/billti/repos","events_url":"https://api.github.com/users/billti/events{/privacy}","received_events_url":"https://api.github.com/users/billti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/billti/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/billti/node","forks_url":"https://api.github.com/repos/billti/node/forks","keys_url":"https://api.github.com/repos/billti/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/billti/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/billti/node/teams","hooks_url":"https://api.github.com/repos/billti/node/hooks","issue_events_url":"https://api.github.com/repos/billti/node/issues/events{/number}","events_url":"https://api.github.com/repos/billti/node/events","assignees_url":"https://api.github.com/repos/billti/node/assignees{/user}","branches_url":"https://api.github.com/repos/billti/node/branches{/branch}","tags_url":"https://api.github.com/repos/billti/node/tags","blobs_url":"https://api.github.com/repos/billti/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/billti/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/billti/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/billti/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/billti/node/statuses/{sha}","languages_url":"https://api.github.com/repos/billti/node/languages","stargazers_url":"https://api.github.com/repos/billti/node/stargazers","contributors_url":"https://api.github.com/repos/billti/node/contributors","subscribers_url":"https://api.github.com/repos/billti/node/subscribers","subscription_url":"https://api.github.com/repos/billti/node/subscription","commits_url":"https://api.github.com/repos/billti/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/billti/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/billti/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/billti/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/billti/node/contents/{+path}","compare_url":"https://api.github.com/repos/billti/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/billti/node/merges","archive_url":"https://api.github.com/repos/billti/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/billti/node/downloads","issues_url":"https://api.github.com/repos/billti/node/issues{/number}","pulls_url":"https://api.github.com/repos/billti/node/pulls{/number}","milestones_url":"https://api.github.com/repos/billti/node/milestones{/number}","notifications_url":"https://api.github.com/repos/billti/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/billti/node/labels{/name}","releases_url":"https://api.github.com/repos/billti/node/releases{/id}","deployments_url":"https://api.github.com/repos/billti/node/deployments","created_at":"2018-04-18T04:04:29Z","updated_at":"2018-04-18T04:04:49Z","pushed_at":"2018-04-18T18:58:51Z","git_url":"git://github.com/billti/node.git","ssh_url":"git@github.com:billti/node.git","clone_url":"https://github.com/billti/node.git","svn_url":"https://github.com/billti/node","homepage":"https://nodejs.org","size":374000,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:v10.x","ref":"v10.x","sha":"efda6fbce6643a0c9c109a9fcb437f0e1436d15d","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-04-18T18:51:08Z","pushed_at":"2018-04-18T19:01:18Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":373916,"stargazers_count":47755,"watchers_count":47755,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10049,"mirror_url":null,"archived":false,"open_issues_count":741,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10049,"open_issues":741,"watchers":47755,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/20116"},"html":{"href":"https://github.com/nodejs/node/pull/20116"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/20116"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/20116/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/20116/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/20116/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/860578d005da89b56b37c7dac3a6649d576ed077"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":11,"review_comments":11,"maintainer_can_modify":false,"commits":3,"additions":36,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"billti"}}