{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/19413","repository_url":"https://api.github.com/repos/edx/edx-platform","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/19413/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/19413/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/19413/events","html_url":"https://github.com/edx/edx-platform/pull/19413","id":389622060,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NTcwMTcx","number":19413,"title":"Put certificate data message into it's own block for overriding","user":{"login":"kaizoku","id":270966,"node_id":"MDQ6VXNlcjI3MDk2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/270966?v=4","gravatar_id":"","url":"https://api.github.com/users/kaizoku","html_url":"https://github.com/kaizoku","followers_url":"https://api.github.com/users/kaizoku/followers","following_url":"https://api.github.com/users/kaizoku/following{/other_user}","gists_url":"https://api.github.com/users/kaizoku/gists{/gist_id}","starred_url":"https://api.github.com/users/kaizoku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaizoku/subscriptions","organizations_url":"https://api.github.com/users/kaizoku/orgs","repos_url":"https://api.github.com/users/kaizoku/repos","events_url":"https://api.github.com/users/kaizoku/events{/privacy}","received_events_url":"https://api.github.com/users/kaizoku/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-11T07:00:25Z","updated_at":"2018-12-11T07:00:33Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/19413","html_url":"https://github.com/edx/edx-platform/pull/19413","diff_url":"https://github.com/edx/edx-platform/pull/19413.diff","patch_url":"https://github.com/edx/edx-platform/pull/19413.patch"},"body":"This PR simply puts the certificate information into a block in order to facilitate overriding it without overriding the entire progress template.\r\n\r\n**Dependencies**: None\r\n\r\n**Testing instructions**:\r\n\r\n1. Create and activate a theme with content in `lms/templates/courseware/progress.html` similar to the following:\r\n```\r\n<%inherit file=\"progress.html\" />\r\n<%block name=\"certificate_block\">Test Override Block</%block>\r\n${parent.body()}\r\n```\r\n2. Check the progress page and see that the block is overrode and \"Test Override Block\" shows above the course progress display.\r\n\r\n**Reviewers**\r\n- [ ] edX reviewer[s] TBD"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/446093980","html_url":"https://github.com/edx/edx-platform/pull/19413#issuecomment-446093980","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/19413","id":446093980,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjA5Mzk4MA==","user":{"login":"edx-webhook","id":8964148,"node_id":"MDQ6VXNlcjg5NjQxNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/8964148?v=4","gravatar_id":"","url":"https://api.github.com/users/edx-webhook","html_url":"https://github.com/edx-webhook","followers_url":"https://api.github.com/users/edx-webhook/followers","following_url":"https://api.github.com/users/edx-webhook/following{/other_user}","gists_url":"https://api.github.com/users/edx-webhook/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-webhook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-webhook/subscriptions","organizations_url":"https://api.github.com/users/edx-webhook/orgs","repos_url":"https://api.github.com/users/edx-webhook/repos","events_url":"https://api.github.com/users/edx-webhook/events{/privacy}","received_events_url":"https://api.github.com/users/edx-webhook/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T07:00:33Z","updated_at":"2018-12-11T07:00:33Z","author_association":"NONE","body":"Thanks for the pull request, @kaizoku! I've created [OSPR-2895](https://openedx.atlassian.net/browse/OSPR-2895) to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams.\n\nFeel free to add as much of the following information to the ticket:\n- supporting documentation\n- edx-code email threads\n- timeline information (\"this must be merged by XX date\", and why that is)\n- partner information (\"this is a course on edx.org\")\n- any other information that can help Product understand the context for the PR\n\nAll technical communication about the code itself will still be done via the GitHub pull request interface. As a reminder, [our process documentation is here](http://edx-developer-guide.readthedocs.org/en/latest/process/overview.html).\n\n\n\n"}}
{"actor":{"display_login":"edx-webhook"}}