{"action":"closed","number":3171,"pull_request":{"url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/3171","id":240704174,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNzA0MTc0","html_url":"https://github.com/webdriverio/webdriverio/pull/3171","diff_url":"https://github.com/webdriverio/webdriverio/pull/3171.diff","patch_url":"https://github.com/webdriverio/webdriverio/pull/3171.patch","issue_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/3171","number":3171,"state":"closed","locked":false,"title":"Fix middleware regression and add smoke tests","user":{"login":"christian-bromann","id":731337,"node_id":"MDQ6VXNlcjczMTMzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/731337?v=4","gravatar_id":"","url":"https://api.github.com/users/christian-bromann","html_url":"https://github.com/christian-bromann","followers_url":"https://api.github.com/users/christian-bromann/followers","following_url":"https://api.github.com/users/christian-bromann/following{/other_user}","gists_url":"https://api.github.com/users/christian-bromann/gists{/gist_id}","starred_url":"https://api.github.com/users/christian-bromann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christian-bromann/subscriptions","organizations_url":"https://api.github.com/users/christian-bromann/orgs","repos_url":"https://api.github.com/users/christian-bromann/repos","events_url":"https://api.github.com/users/christian-bromann/events{/privacy}","received_events_url":"https://api.github.com/users/christian-bromann/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n\r\nWe introduced a regression in the middleware. This patch fixes this and adds a smoke test framework to ensure that we run test against the whole package stack.\r\n\r\ncloses #3166 \r\n\r\n## Types of changes\r\n\r\n[//]: # (What types of changes does your code introduce to WebdriverIO?)\r\n[//]: # (_Put an `x` in the boxes that apply_)\r\n\r\n- [x] Bugfix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist\r\n\r\n[//]: # (_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._)\r\n\r\n- [x] I have read the [CONTRIBUTING](https://github.com/webdriverio/webdriverio/blob/master/CONTRIBUTING.md) doc\r\n- [x] I have added tests that prove my fix is effective or that my feature works\r\n- [x] I have added necessary documentation (if appropriate)\r\n\r\n## Further comments\r\n\r\n[//]: # (If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...)\r\n\r\n### Reviewers: @webdriverio/technical-committee\r\n","created_at":"2018-12-23T22:48:44Z","updated_at":"2018-12-23T23:44:46Z","closed_at":"2018-12-23T23:44:46Z","merged_at":"2018-12-23T23:44:45Z","merge_commit_sha":"0a2ca3e53332b0b78f85a6129637259bb0ee1b16","assignee":{"login":"christian-bromann","id":731337,"node_id":"MDQ6VXNlcjczMTMzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/731337?v=4","gravatar_id":"","url":"https://api.github.com/users/christian-bromann","html_url":"https://github.com/christian-bromann","followers_url":"https://api.github.com/users/christian-bromann/followers","following_url":"https://api.github.com/users/christian-bromann/following{/other_user}","gists_url":"https://api.github.com/users/christian-bromann/gists{/gist_id}","starred_url":"https://api.github.com/users/christian-bromann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christian-bromann/subscriptions","organizations_url":"https://api.github.com/users/christian-bromann/orgs","repos_url":"https://api.github.com/users/christian-bromann/repos","events_url":"https://api.github.com/users/christian-bromann/events{/privacy}","received_events_url":"https://api.github.com/users/christian-bromann/received_events","type":"User","site_admin":false},"assignees":[{"login":"christian-bromann","id":731337,"node_id":"MDQ6VXNlcjczMTMzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/731337?v=4","gravatar_id":"","url":"https://api.github.com/users/christian-bromann","html_url":"https://github.com/christian-bromann","followers_url":"https://api.github.com/users/christian-bromann/followers","following_url":"https://api.github.com/users/christian-bromann/following{/other_user}","gists_url":"https://api.github.com/users/christian-bromann/gists{/gist_id}","starred_url":"https://api.github.com/users/christian-bromann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christian-bromann/subscriptions","organizations_url":"https://api.github.com/users/christian-bromann/orgs","repos_url":"https://api.github.com/users/christian-bromann/repos","events_url":"https://api.github.com/users/christian-bromann/events{/privacy}","received_events_url":"https://api.github.com/users/christian-bromann/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[{"name":"Project Committers","id":776821,"node_id":"MDQ6VGVhbTc3NjgyMQ==","slug":"project-committers","description":"","privacy":"closed","url":"https://api.github.com/teams/776821","members_url":"https://api.github.com/teams/776821/members{/member}","repositories_url":"https://api.github.com/teams/776821/repos","permission":"push"}],"labels":[{"id":1159685127,"node_id":"MDU6TGFiZWwxMTU5Njg1MTI3","url":"https://api.github.com/repos/webdriverio/webdriverio/labels/PR:%20Bug%20Fix%20:bug:","name":"PR: Bug Fix :bug:","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/3171/commits","review_comments_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/3171/comments","review_comment_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/3171/comments","statuses_url":"https://api.github.com/repos/webdriverio/webdriverio/statuses/fe445e871f7b9b1076d568222da61c8d0ff75dab","head":{"label":"webdriverio:cb-elem-cmd-fix","ref":"cb-elem-cmd-fix","sha":"fe445e871f7b9b1076d568222da61c8d0ff75dab","user":{"login":"webdriverio","id":6512473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MTI0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6512473?v=4","gravatar_id":"","url":"https://api.github.com/users/webdriverio","html_url":"https://github.com/webdriverio","followers_url":"https://api.github.com/users/webdriverio/followers","following_url":"https://api.github.com/users/webdriverio/following{/other_user}","gists_url":"https://api.github.com/users/webdriverio/gists{/gist_id}","starred_url":"https://api.github.com/users/webdriverio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdriverio/subscriptions","organizations_url":"https://api.github.com/users/webdriverio/orgs","repos_url":"https://api.github.com/users/webdriverio/repos","events_url":"https://api.github.com/users/webdriverio/events{/privacy}","received_events_url":"https://api.github.com/users/webdriverio/received_events","type":"Organization","site_admin":false},"repo":{"id":2296970,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk2OTcw","name":"webdriverio","full_name":"webdriverio/webdriverio","private":false,"owner":{"login":"webdriverio","id":6512473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MTI0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6512473?v=4","gravatar_id":"","url":"https://api.github.com/users/webdriverio","html_url":"https://github.com/webdriverio","followers_url":"https://api.github.com/users/webdriverio/followers","following_url":"https://api.github.com/users/webdriverio/following{/other_user}","gists_url":"https://api.github.com/users/webdriverio/gists{/gist_id}","starred_url":"https://api.github.com/users/webdriverio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdriverio/subscriptions","organizations_url":"https://api.github.com/users/webdriverio/orgs","repos_url":"https://api.github.com/users/webdriverio/repos","events_url":"https://api.github.com/users/webdriverio/events{/privacy}","received_events_url":"https://api.github.com/users/webdriverio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/webdriverio/webdriverio","description":"Next-gen WebDriver test automation framework for Node.js","fork":false,"url":"https://api.github.com/repos/webdriverio/webdriverio","forks_url":"https://api.github.com/repos/webdriverio/webdriverio/forks","keys_url":"https://api.github.com/repos/webdriverio/webdriverio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webdriverio/webdriverio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webdriverio/webdriverio/teams","hooks_url":"https://api.github.com/repos/webdriverio/webdriverio/hooks","issue_events_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/events{/number}","events_url":"https://api.github.com/repos/webdriverio/webdriverio/events","assignees_url":"https://api.github.com/repos/webdriverio/webdriverio/assignees{/user}","branches_url":"https://api.github.com/repos/webdriverio/webdriverio/branches{/branch}","tags_url":"https://api.github.com/repos/webdriverio/webdriverio/tags","blobs_url":"https://api.github.com/repos/webdriverio/webdriverio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webdriverio/webdriverio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webdriverio/webdriverio/git/refs{/sha}","trees_url":"https://api.github.com/repos/webdriverio/webdriverio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webdriverio/webdriverio/statuses/{sha}","languages_url":"https://api.github.com/repos/webdriverio/webdriverio/languages","stargazers_url":"https://api.github.com/repos/webdriverio/webdriverio/stargazers","contributors_url":"https://api.github.com/repos/webdriverio/webdriverio/contributors","subscribers_url":"https://api.github.com/repos/webdriverio/webdriverio/subscribers","subscription_url":"https://api.github.com/repos/webdriverio/webdriverio/subscription","commits_url":"https://api.github.com/repos/webdriverio/webdriverio/commits{/sha}","git_commits_url":"https://api.github.com/repos/webdriverio/webdriverio/git/commits{/sha}","comments_url":"https://api.github.com/repos/webdriverio/webdriverio/comments{/number}","issue_comment_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/comments{/number}","contents_url":"https://api.github.com/repos/webdriverio/webdriverio/contents/{+path}","compare_url":"https://api.github.com/repos/webdriverio/webdriverio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webdriverio/webdriverio/merges","archive_url":"https://api.github.com/repos/webdriverio/webdriverio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webdriverio/webdriverio/downloads","issues_url":"https://api.github.com/repos/webdriverio/webdriverio/issues{/number}","pulls_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls{/number}","milestones_url":"https://api.github.com/repos/webdriverio/webdriverio/milestones{/number}","notifications_url":"https://api.github.com/repos/webdriverio/webdriverio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webdriverio/webdriverio/labels{/name}","releases_url":"https://api.github.com/repos/webdriverio/webdriverio/releases{/id}","deployments_url":"https://api.github.com/repos/webdriverio/webdriverio/deployments","created_at":"2011-08-30T19:02:35Z","updated_at":"2018-12-23T15:42:34Z","pushed_at":"2018-12-23T23:44:45Z","git_url":"git://github.com/webdriverio/webdriverio.git","ssh_url":"git@github.com:webdriverio/webdriverio.git","clone_url":"https://github.com/webdriverio/webdriverio.git","svn_url":"https://github.com/webdriverio/webdriverio","homepage":"http://webdriver.io","size":10097,"stargazers_count":4466,"watchers_count":4466,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1210,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1210,"open_issues":59,"watchers":4466,"default_branch":"master"}},"base":{"label":"webdriverio:master","ref":"master","sha":"ae868c810584bd50fba6f73a6f9a8ac4a7fdb77b","user":{"login":"webdriverio","id":6512473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MTI0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6512473?v=4","gravatar_id":"","url":"https://api.github.com/users/webdriverio","html_url":"https://github.com/webdriverio","followers_url":"https://api.github.com/users/webdriverio/followers","following_url":"https://api.github.com/users/webdriverio/following{/other_user}","gists_url":"https://api.github.com/users/webdriverio/gists{/gist_id}","starred_url":"https://api.github.com/users/webdriverio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdriverio/subscriptions","organizations_url":"https://api.github.com/users/webdriverio/orgs","repos_url":"https://api.github.com/users/webdriverio/repos","events_url":"https://api.github.com/users/webdriverio/events{/privacy}","received_events_url":"https://api.github.com/users/webdriverio/received_events","type":"Organization","site_admin":false},"repo":{"id":2296970,"node_id":"MDEwOlJlcG9zaXRvcnkyMjk2OTcw","name":"webdriverio","full_name":"webdriverio/webdriverio","private":false,"owner":{"login":"webdriverio","id":6512473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1MTI0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/6512473?v=4","gravatar_id":"","url":"https://api.github.com/users/webdriverio","html_url":"https://github.com/webdriverio","followers_url":"https://api.github.com/users/webdriverio/followers","following_url":"https://api.github.com/users/webdriverio/following{/other_user}","gists_url":"https://api.github.com/users/webdriverio/gists{/gist_id}","starred_url":"https://api.github.com/users/webdriverio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webdriverio/subscriptions","organizations_url":"https://api.github.com/users/webdriverio/orgs","repos_url":"https://api.github.com/users/webdriverio/repos","events_url":"https://api.github.com/users/webdriverio/events{/privacy}","received_events_url":"https://api.github.com/users/webdriverio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/webdriverio/webdriverio","description":"Next-gen WebDriver test automation framework for Node.js","fork":false,"url":"https://api.github.com/repos/webdriverio/webdriverio","forks_url":"https://api.github.com/repos/webdriverio/webdriverio/forks","keys_url":"https://api.github.com/repos/webdriverio/webdriverio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webdriverio/webdriverio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webdriverio/webdriverio/teams","hooks_url":"https://api.github.com/repos/webdriverio/webdriverio/hooks","issue_events_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/events{/number}","events_url":"https://api.github.com/repos/webdriverio/webdriverio/events","assignees_url":"https://api.github.com/repos/webdriverio/webdriverio/assignees{/user}","branches_url":"https://api.github.com/repos/webdriverio/webdriverio/branches{/branch}","tags_url":"https://api.github.com/repos/webdriverio/webdriverio/tags","blobs_url":"https://api.github.com/repos/webdriverio/webdriverio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webdriverio/webdriverio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webdriverio/webdriverio/git/refs{/sha}","trees_url":"https://api.github.com/repos/webdriverio/webdriverio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webdriverio/webdriverio/statuses/{sha}","languages_url":"https://api.github.com/repos/webdriverio/webdriverio/languages","stargazers_url":"https://api.github.com/repos/webdriverio/webdriverio/stargazers","contributors_url":"https://api.github.com/repos/webdriverio/webdriverio/contributors","subscribers_url":"https://api.github.com/repos/webdriverio/webdriverio/subscribers","subscription_url":"https://api.github.com/repos/webdriverio/webdriverio/subscription","commits_url":"https://api.github.com/repos/webdriverio/webdriverio/commits{/sha}","git_commits_url":"https://api.github.com/repos/webdriverio/webdriverio/git/commits{/sha}","comments_url":"https://api.github.com/repos/webdriverio/webdriverio/comments{/number}","issue_comment_url":"https://api.github.com/repos/webdriverio/webdriverio/issues/comments{/number}","contents_url":"https://api.github.com/repos/webdriverio/webdriverio/contents/{+path}","compare_url":"https://api.github.com/repos/webdriverio/webdriverio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webdriverio/webdriverio/merges","archive_url":"https://api.github.com/repos/webdriverio/webdriverio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webdriverio/webdriverio/downloads","issues_url":"https://api.github.com/repos/webdriverio/webdriverio/issues{/number}","pulls_url":"https://api.github.com/repos/webdriverio/webdriverio/pulls{/number}","milestones_url":"https://api.github.com/repos/webdriverio/webdriverio/milestones{/number}","notifications_url":"https://api.github.com/repos/webdriverio/webdriverio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webdriverio/webdriverio/labels{/name}","releases_url":"https://api.github.com/repos/webdriverio/webdriverio/releases{/id}","deployments_url":"https://api.github.com/repos/webdriverio/webdriverio/deployments","created_at":"2011-08-30T19:02:35Z","updated_at":"2018-12-23T15:42:34Z","pushed_at":"2018-12-23T23:44:45Z","git_url":"git://github.com/webdriverio/webdriverio.git","ssh_url":"git@github.com:webdriverio/webdriverio.git","clone_url":"https://github.com/webdriverio/webdriverio.git","svn_url":"https://github.com/webdriverio/webdriverio","homepage":"http://webdriver.io","size":10097,"stargazers_count":4466,"watchers_count":4466,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1210,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1210,"open_issues":59,"watchers":4466,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/3171"},"html":{"href":"https://github.com/webdriverio/webdriverio/pull/3171"},"issue":{"href":"https://api.github.com/repos/webdriverio/webdriverio/issues/3171"},"comments":{"href":"https://api.github.com/repos/webdriverio/webdriverio/issues/3171/comments"},"review_comments":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/3171/comments"},"review_comment":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webdriverio/webdriverio/pulls/3171/commits"},"statuses":{"href":"https://api.github.com/repos/webdriverio/webdriverio/statuses/fe445e871f7b9b1076d568222da61c8d0ff75dab"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"christian-bromann","id":731337,"node_id":"MDQ6VXNlcjczMTMzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/731337?v=4","gravatar_id":"","url":"https://api.github.com/users/christian-bromann","html_url":"https://github.com/christian-bromann","followers_url":"https://api.github.com/users/christian-bromann/followers","following_url":"https://api.github.com/users/christian-bromann/following{/other_user}","gists_url":"https://api.github.com/users/christian-bromann/gists{/gist_id}","starred_url":"https://api.github.com/users/christian-bromann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christian-bromann/subscriptions","organizations_url":"https://api.github.com/users/christian-bromann/orgs","repos_url":"https://api.github.com/users/christian-bromann/repos","events_url":"https://api.github.com/users/christian-bromann/events{/privacy}","received_events_url":"https://api.github.com/users/christian-bromann/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":7,"additions":395,"deletions":67,"changed_files":26}}
{"actor":{"display_login":"christian-bromann"}}