{"action":"created","issue":{"url":"https://api.github.com/repos/uber/luma.gl/issues/831","repository_url":"https://api.github.com/repos/uber/luma.gl","labels_url":"https://api.github.com/repos/uber/luma.gl/issues/831/labels{/name}","comments_url":"https://api.github.com/repos/uber/luma.gl/issues/831/comments","events_url":"https://api.github.com/repos/uber/luma.gl/issues/831/events","html_url":"https://github.com/uber/luma.gl/issues/831","id":394759794,"node_id":"MDU6SXNzdWUzOTQ3NTk3OTQ=","number":831,"title":"texture.setImageData and setSubImageData are do not work as expected","user":{"login":"xintongxia","id":2927808,"node_id":"MDQ6VXNlcjI5Mjc4MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2927808?v=4","gravatar_id":"","url":"https://api.github.com/users/xintongxia","html_url":"https://github.com/xintongxia","followers_url":"https://api.github.com/users/xintongxia/followers","following_url":"https://api.github.com/users/xintongxia/following{/other_user}","gists_url":"https://api.github.com/users/xintongxia/gists{/gist_id}","starred_url":"https://api.github.com/users/xintongxia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xintongxia/subscriptions","organizations_url":"https://api.github.com/users/xintongxia/orgs","repos_url":"https://api.github.com/users/xintongxia/repos","events_url":"https://api.github.com/users/xintongxia/events{/privacy}","received_events_url":"https://api.github.com/users/xintongxia/received_events","type":"User","site_admin":false},"labels":[{"id":316235486,"node_id":"MDU6TGFiZWwzMTYyMzU0ODY=","url":"https://api.github.com/repos/uber/luma.gl/labels/enhancement","name":"enhancement","color":"0052cc","default":true}],"state":"open","locked":false,"assignee":{"login":"ibgreen","id":7025232,"node_id":"MDQ6VXNlcjcwMjUyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/7025232?v=4","gravatar_id":"","url":"https://api.github.com/users/ibgreen","html_url":"https://github.com/ibgreen","followers_url":"https://api.github.com/users/ibgreen/followers","following_url":"https://api.github.com/users/ibgreen/following{/other_user}","gists_url":"https://api.github.com/users/ibgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/ibgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibgreen/subscriptions","organizations_url":"https://api.github.com/users/ibgreen/orgs","repos_url":"https://api.github.com/users/ibgreen/repos","events_url":"https://api.github.com/users/ibgreen/events{/privacy}","received_events_url":"https://api.github.com/users/ibgreen/received_events","type":"User","site_admin":false},"assignees":[{"login":"ibgreen","id":7025232,"node_id":"MDQ6VXNlcjcwMjUyMzI=","avatar_url":"https://avatars1.githubusercontent.com/u/7025232?v=4","gravatar_id":"","url":"https://api.github.com/users/ibgreen","html_url":"https://github.com/ibgreen","followers_url":"https://api.github.com/users/ibgreen/followers","following_url":"https://api.github.com/users/ibgreen/following{/other_user}","gists_url":"https://api.github.com/users/ibgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/ibgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibgreen/subscriptions","organizations_url":"https://api.github.com/users/ibgreen/orgs","repos_url":"https://api.github.com/users/ibgreen/repos","events_url":"https://api.github.com/users/ibgreen/events{/privacy}","received_events_url":"https://api.github.com/users/ibgreen/received_events","type":"User","site_admin":false},{"login":"1chandu","id":9502731,"node_id":"MDQ6VXNlcjk1MDI3MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/9502731?v=4","gravatar_id":"","url":"https://api.github.com/users/1chandu","html_url":"https://github.com/1chandu","followers_url":"https://api.github.com/users/1chandu/followers","following_url":"https://api.github.com/users/1chandu/following{/other_user}","gists_url":"https://api.github.com/users/1chandu/gists{/gist_id}","starred_url":"https://api.github.com/users/1chandu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1chandu/subscriptions","organizations_url":"https://api.github.com/users/1chandu/orgs","repos_url":"https://api.github.com/users/1chandu/repos","events_url":"https://api.github.com/users/1chandu/events{/privacy}","received_events_url":"https://api.github.com/users/1chandu/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-12-29T04:22:30Z","updated_at":"2019-01-03T19:31:15Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"<!-- If it is bug -->\r\nIn order to make `texture.setImageData` and `texture.setSubImageData` functions work, `texture.generateMipmap()` has to be called after. \r\n\r\nIs it intended to be this? If so, should mention in documentation. But I think it makes more sense to do `generateMipmap()` inside `texture.setImageData` and `texture.setSubImageData`.\r\n\r\n<!-- For any issue in your example, please provide runnable code package and data -->\r\n#### Reproduce Steps\r\nI added a [debugging](https://github.com/uber/luma.gl/blob/xx/texture-debug/examples/wip/texture-display/app.js#L142) branch\r\n\r\n#### To Do List <!-- For developer only -->\r\n  - [ ] Add label and assign to milestone\r\n  - [ ] Coding\r\n  - [ ] Test\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/uber/luma.gl/issues/comments/451251563","html_url":"https://github.com/uber/luma.gl/issues/831#issuecomment-451251563","issue_url":"https://api.github.com/repos/uber/luma.gl/issues/831","id":451251563,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTI1MTU2Mw==","user":{"login":"1chandu","id":9502731,"node_id":"MDQ6VXNlcjk1MDI3MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/9502731?v=4","gravatar_id":"","url":"https://api.github.com/users/1chandu","html_url":"https://github.com/1chandu","followers_url":"https://api.github.com/users/1chandu/followers","following_url":"https://api.github.com/users/1chandu/following{/other_user}","gists_url":"https://api.github.com/users/1chandu/gists{/gist_id}","starred_url":"https://api.github.com/users/1chandu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1chandu/subscriptions","organizations_url":"https://api.github.com/users/1chandu/orgs","repos_url":"https://api.github.com/users/1chandu/repos","events_url":"https://api.github.com/users/1chandu/events{/privacy}","received_events_url":"https://api.github.com/users/1chandu/received_events","type":"User","site_admin":false},"created_at":"2019-01-03T19:31:15Z","updated_at":"2019-01-03T19:31:15Z","author_association":"CONTRIBUTOR","body":"Another related issue I found while debugging this with @xintongxia , we have two sources of truth for mipmap usage `1. filter setting`, `2. parameters.mipmap`.  Problem should also go away if you force non mipmap filtering in that debugging branch. User might set mipmaps to false, but not sure that default filter setting uses mipmaps.\r\n\r\nSo, either we should remove `parameters.mipmaps` or overwrite `filter` settings based on `parameters.mipmaps`."}}
{"actor":{"display_login":"1chandu"}}