{"action":"created","comment":{"url":"https://api.github.com/repos/andela/travel_tool_back/pulls/comments/229684454","pull_request_review_id":170238248,"id":229684454,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTY4NDQ1NA==","diff_hunk":"@@ -10,7 +10,7 @@\n     \"serve\": \"node dist/index.js\",\n     \"start\": \"NODE_ENV=production yarn run build && yarn run serve\",\n     \"start:dev\": \"NODE_ENV=development  DEBUG=log  nodemon --exec babel-node src/index.js\",\n-    \"lint\": \"eslint src/**/**.js\",\n+    \"lint\": \"node_modules/.bin/eslint ./src\",","path":"package.json","position":5,"original_position":5,"commit_id":"441d584f8bf5cd6121f6754a23beebba9ee3d8e5","original_commit_id":"441d584f8bf5cd6121f6754a23beebba9ee3d8e5","user":{"login":"ezrqnkemboi","id":32410518,"node_id":"MDQ6VXNlcjMyNDEwNTE4","avatar_url":"https://avatars3.githubusercontent.com/u/32410518?v=4","gravatar_id":"","url":"https://api.github.com/users/ezrqnkemboi","html_url":"https://github.com/ezrqnkemboi","followers_url":"https://api.github.com/users/ezrqnkemboi/followers","following_url":"https://api.github.com/users/ezrqnkemboi/following{/other_user}","gists_url":"https://api.github.com/users/ezrqnkemboi/gists{/gist_id}","starred_url":"https://api.github.com/users/ezrqnkemboi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezrqnkemboi/subscriptions","organizations_url":"https://api.github.com/users/ezrqnkemboi/orgs","repos_url":"https://api.github.com/users/ezrqnkemboi/repos","events_url":"https://api.github.com/users/ezrqnkemboi/events{/privacy}","received_events_url":"https://api.github.com/users/ezrqnkemboi/received_events","type":"User","site_admin":false},"body":"I think this implementation is good as during yarn install, the eslint will be installed, which will be used for linting process. ","created_at":"2018-10-31T13:07:45Z","updated_at":"2018-10-31T13:08:41Z","html_url":"https://github.com/andela/travel_tool_back/pull/150#discussion_r229684454","pull_request_url":"https://api.github.com/repos/andela/travel_tool_back/pulls/150","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/andela/travel_tool_back/pulls/comments/229684454"},"html":{"href":"https://github.com/andela/travel_tool_back/pull/150#discussion_r229684454"},"pull_request":{"href":"https://api.github.com/repos/andela/travel_tool_back/pulls/150"}}},"pull_request":{"url":"https://api.github.com/repos/andela/travel_tool_back/pulls/150","id":227254717,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MjU0NzE3","html_url":"https://github.com/andela/travel_tool_back/pull/150","diff_url":"https://github.com/andela/travel_tool_back/pull/150.diff","patch_url":"https://github.com/andela/travel_tool_back/pull/150.patch","issue_url":"https://api.github.com/repos/andela/travel_tool_back/issues/150","number":150,"state":"open","locked":false,"title":"reconfigure eslint and fix errors","user":{"login":"dmaish","id":19623571,"node_id":"MDQ6VXNlcjE5NjIzNTcx","avatar_url":"https://avatars3.githubusercontent.com/u/19623571?v=4","gravatar_id":"","url":"https://api.github.com/users/dmaish","html_url":"https://github.com/dmaish","followers_url":"https://api.github.com/users/dmaish/followers","following_url":"https://api.github.com/users/dmaish/following{/other_user}","gists_url":"https://api.github.com/users/dmaish/gists{/gist_id}","starred_url":"https://api.github.com/users/dmaish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmaish/subscriptions","organizations_url":"https://api.github.com/users/dmaish/orgs","repos_url":"https://api.github.com/users/dmaish/repos","events_url":"https://api.github.com/users/dmaish/events{/privacy}","received_events_url":"https://api.github.com/users/dmaish/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nIntroduces eslint rules that make the codebase uniform and readable\r\n\r\n#### Description of Task to be completed?\r\nenable the following eslint rules:\r\n\r\n- end-of-line\r\n- no-unused variables\r\n- lines not exceeding maximum of 100\r\n- no trailling spaces\r\n- spaces after opening and closing braces\r\n\r\n#### How should this be manually tested?\r\n- After pulling latest changes from develop, run ```yarn install```\r\n- When a trailling or unused variable is introduced, esling should prompt an error about that\r\n\r\n#### Any background context you want to provide?\r\nN/A\r\n\r\n#### What are the relevant pivotal tracker stories?\r\n[161323203](https://www.pivotaltracker.com/story/show/161323203)\r\n\r\n#### Screenshots (if appropriate)\r\n\r\n#### Questions:\r\n","created_at":"2018-10-31T11:46:22Z","updated_at":"2018-10-31T13:08:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b7b9088b96519a5fb246b5316e2a441b20f571a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ronaldndirangu","id":12511966,"node_id":"MDQ6VXNlcjEyNTExOTY2","avatar_url":"https://avatars1.githubusercontent.com/u/12511966?v=4","gravatar_id":"","url":"https://api.github.com/users/ronaldndirangu","html_url":"https://github.com/ronaldndirangu","followers_url":"https://api.github.com/users/ronaldndirangu/followers","following_url":"https://api.github.com/users/ronaldndirangu/following{/other_user}","gists_url":"https://api.github.com/users/ronaldndirangu/gists{/gist_id}","starred_url":"https://api.github.com/users/ronaldndirangu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ronaldndirangu/subscriptions","organizations_url":"https://api.github.com/users/ronaldndirangu/orgs","repos_url":"https://api.github.com/users/ronaldndirangu/repos","events_url":"https://api.github.com/users/ronaldndirangu/events{/privacy}","received_events_url":"https://api.github.com/users/ronaldndirangu/received_events","type":"User","site_admin":false},{"login":"DennisWanjiru","id":22371596,"node_id":"MDQ6VXNlcjIyMzcxNTk2","avatar_url":"https://avatars1.githubusercontent.com/u/22371596?v=4","gravatar_id":"","url":"https://api.github.com/users/DennisWanjiru","html_url":"https://github.com/DennisWanjiru","followers_url":"https://api.github.com/users/DennisWanjiru/followers","following_url":"https://api.github.com/users/DennisWanjiru/following{/other_user}","gists_url":"https://api.github.com/users/DennisWanjiru/gists{/gist_id}","starred_url":"https://api.github.com/users/DennisWanjiru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DennisWanjiru/subscriptions","organizations_url":"https://api.github.com/users/DennisWanjiru/orgs","repos_url":"https://api.github.com/users/DennisWanjiru/repos","events_url":"https://api.github.com/users/DennisWanjiru/events{/privacy}","received_events_url":"https://api.github.com/users/DennisWanjiru/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1039219639,"node_id":"MDU6TGFiZWwxMDM5MjE5NjM5","url":"https://api.github.com/repos/andela/travel_tool_back/labels/PEER-REVIEW","name":"PEER-REVIEW","color":"98ea15","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/andela/travel_tool_back/pulls/150/commits","review_comments_url":"https://api.github.com/repos/andela/travel_tool_back/pulls/150/comments","review_comment_url":"https://api.github.com/repos/andela/travel_tool_back/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/travel_tool_back/issues/150/comments","statuses_url":"https://api.github.com/repos/andela/travel_tool_back/statuses/441d584f8bf5cd6121f6754a23beebba9ee3d8e5","head":{"label":"andela:reconfigure-ESLint-161323203","ref":"reconfigure-ESLint-161323203","sha":"441d584f8bf5cd6121f6754a23beebba9ee3d8e5","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":141128323,"node_id":"MDEwOlJlcG9zaXRvcnkxNDExMjgzMjM=","name":"travel_tool_back","full_name":"andela/travel_tool_back","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/travel_tool_back","description":"Andela travel tool API.","fork":false,"url":"https://api.github.com/repos/andela/travel_tool_back","forks_url":"https://api.github.com/repos/andela/travel_tool_back/forks","keys_url":"https://api.github.com/repos/andela/travel_tool_back/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/travel_tool_back/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/travel_tool_back/teams","hooks_url":"https://api.github.com/repos/andela/travel_tool_back/hooks","issue_events_url":"https://api.github.com/repos/andela/travel_tool_back/issues/events{/number}","events_url":"https://api.github.com/repos/andela/travel_tool_back/events","assignees_url":"https://api.github.com/repos/andela/travel_tool_back/assignees{/user}","branches_url":"https://api.github.com/repos/andela/travel_tool_back/branches{/branch}","tags_url":"https://api.github.com/repos/andela/travel_tool_back/tags","blobs_url":"https://api.github.com/repos/andela/travel_tool_back/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/travel_tool_back/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/travel_tool_back/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/travel_tool_back/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/travel_tool_back/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/travel_tool_back/languages","stargazers_url":"https://api.github.com/repos/andela/travel_tool_back/stargazers","contributors_url":"https://api.github.com/repos/andela/travel_tool_back/contributors","subscribers_url":"https://api.github.com/repos/andela/travel_tool_back/subscribers","subscription_url":"https://api.github.com/repos/andela/travel_tool_back/subscription","commits_url":"https://api.github.com/repos/andela/travel_tool_back/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/travel_tool_back/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/travel_tool_back/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/travel_tool_back/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/travel_tool_back/contents/{+path}","compare_url":"https://api.github.com/repos/andela/travel_tool_back/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/travel_tool_back/merges","archive_url":"https://api.github.com/repos/andela/travel_tool_back/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/travel_tool_back/downloads","issues_url":"https://api.github.com/repos/andela/travel_tool_back/issues{/number}","pulls_url":"https://api.github.com/repos/andela/travel_tool_back/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/travel_tool_back/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/travel_tool_back/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/travel_tool_back/labels{/name}","releases_url":"https://api.github.com/repos/andela/travel_tool_back/releases{/id}","deployments_url":"https://api.github.com/repos/andela/travel_tool_back/deployments","created_at":"2018-07-16T11:15:30Z","updated_at":"2018-10-30T17:33:32Z","pushed_at":"2018-10-31T12:49:54Z","git_url":"git://github.com/andela/travel_tool_back.git","ssh_url":"git@github.com:andela/travel_tool_back.git","clone_url":"https://github.com/andela/travel_tool_back.git","svn_url":"https://github.com/andela/travel_tool_back","homepage":"","size":20550,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":8,"watchers":1,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"300043abdcf8e38e5c371634a67eb3390db64b1f","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":141128323,"node_id":"MDEwOlJlcG9zaXRvcnkxNDExMjgzMjM=","name":"travel_tool_back","full_name":"andela/travel_tool_back","private":false,"owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/andela/travel_tool_back","description":"Andela travel tool API.","fork":false,"url":"https://api.github.com/repos/andela/travel_tool_back","forks_url":"https://api.github.com/repos/andela/travel_tool_back/forks","keys_url":"https://api.github.com/repos/andela/travel_tool_back/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/travel_tool_back/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/travel_tool_back/teams","hooks_url":"https://api.github.com/repos/andela/travel_tool_back/hooks","issue_events_url":"https://api.github.com/repos/andela/travel_tool_back/issues/events{/number}","events_url":"https://api.github.com/repos/andela/travel_tool_back/events","assignees_url":"https://api.github.com/repos/andela/travel_tool_back/assignees{/user}","branches_url":"https://api.github.com/repos/andela/travel_tool_back/branches{/branch}","tags_url":"https://api.github.com/repos/andela/travel_tool_back/tags","blobs_url":"https://api.github.com/repos/andela/travel_tool_back/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/travel_tool_back/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/travel_tool_back/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/travel_tool_back/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/travel_tool_back/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/travel_tool_back/languages","stargazers_url":"https://api.github.com/repos/andela/travel_tool_back/stargazers","contributors_url":"https://api.github.com/repos/andela/travel_tool_back/contributors","subscribers_url":"https://api.github.com/repos/andela/travel_tool_back/subscribers","subscription_url":"https://api.github.com/repos/andela/travel_tool_back/subscription","commits_url":"https://api.github.com/repos/andela/travel_tool_back/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/travel_tool_back/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/travel_tool_back/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/travel_tool_back/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/travel_tool_back/contents/{+path}","compare_url":"https://api.github.com/repos/andela/travel_tool_back/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/travel_tool_back/merges","archive_url":"https://api.github.com/repos/andela/travel_tool_back/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/travel_tool_back/downloads","issues_url":"https://api.github.com/repos/andela/travel_tool_back/issues{/number}","pulls_url":"https://api.github.com/repos/andela/travel_tool_back/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/travel_tool_back/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/travel_tool_back/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/travel_tool_back/labels{/name}","releases_url":"https://api.github.com/repos/andela/travel_tool_back/releases{/id}","deployments_url":"https://api.github.com/repos/andela/travel_tool_back/deployments","created_at":"2018-07-16T11:15:30Z","updated_at":"2018-10-30T17:33:32Z","pushed_at":"2018-10-31T12:49:54Z","git_url":"git://github.com/andela/travel_tool_back.git","ssh_url":"git@github.com:andela/travel_tool_back.git","clone_url":"https://github.com/andela/travel_tool_back.git","svn_url":"https://github.com/andela/travel_tool_back","homepage":"","size":20550,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":8,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/travel_tool_back/pulls/150"},"html":{"href":"https://github.com/andela/travel_tool_back/pull/150"},"issue":{"href":"https://api.github.com/repos/andela/travel_tool_back/issues/150"},"comments":{"href":"https://api.github.com/repos/andela/travel_tool_back/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/travel_tool_back/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/travel_tool_back/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/travel_tool_back/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/andela/travel_tool_back/statuses/441d584f8bf5cd6121f6754a23beebba9ee3d8e5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ezrqnkemboi"}}