{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/169316525","pull_request_review_id":97820283,"id":169316525,"diff_hunk":"@@ -427,3 +430,16 @@ def async_set_chromecast(self, chromecast):\n \n         self.cast_status = self.cast.status\n         self.media_status = self.cast.media_controller.status\n+\n+    @asyncio.coroutine\n+    def async_will_remove_from_hass(self):\n+        \"\"\"Disconnect Chromecast object when removed.\"\"\"\n+        self._async_disconnect()","path":"homeassistant/components/media_player/cast.py","position":285,"original_position":145,"commit_id":"34b3581e9094817bd692116e985ca8a8e4e8c4b8","original_commit_id":"34b3581e9094817bd692116e985ca8a8e4e8c4b8","user":{"login":"tinloaf","id":442687,"avatar_url":"https://avatars3.githubusercontent.com/u/442687?v=4","gravatar_id":"","url":"https://api.github.com/users/tinloaf","html_url":"https://github.com/tinloaf","followers_url":"https://api.github.com/users/tinloaf/followers","following_url":"https://api.github.com/users/tinloaf/following{/other_user}","gists_url":"https://api.github.com/users/tinloaf/gists{/gist_id}","starred_url":"https://api.github.com/users/tinloaf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinloaf/subscriptions","organizations_url":"https://api.github.com/users/tinloaf/orgs","repos_url":"https://api.github.com/users/tinloaf/repos","events_url":"https://api.github.com/users/tinloaf/events{/privacy}","received_events_url":"https://api.github.com/users/tinloaf/received_events","type":"User","site_admin":false},"body":"You probably also should remove the entity object from `hass.data[ADDED_CAST_DEVICE_KEY]` here (or in `_async_disconnect`?)","created_at":"2018-02-20T13:27:24Z","updated_at":"2018-02-20T13:27:50Z","html_url":"https://github.com/home-assistant/home-assistant/pull/12474#discussion_r169316525","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12474","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/169316525"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/12474#discussion_r169316525"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12474"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12474","id":169783223,"html_url":"https://github.com/home-assistant/home-assistant/pull/12474","diff_url":"https://github.com/home-assistant/home-assistant/pull/12474.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/12474.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/12474","number":12474,"state":"open","locked":false,"title":"[WIP] Cast unique_id and async discovery","user":{"login":"OttoWinter","id":6833237,"avatar_url":"https://avatars1.githubusercontent.com/u/6833237?v=4","gravatar_id":"","url":"https://api.github.com/users/OttoWinter","html_url":"https://github.com/OttoWinter","followers_url":"https://api.github.com/users/OttoWinter/followers","following_url":"https://api.github.com/users/OttoWinter/following{/other_user}","gists_url":"https://api.github.com/users/OttoWinter/gists{/gist_id}","starred_url":"https://api.github.com/users/OttoWinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OttoWinter/subscriptions","organizations_url":"https://api.github.com/users/OttoWinter/orgs","repos_url":"https://api.github.com/users/OttoWinter/repos","events_url":"https://api.github.com/users/OttoWinter/events{/privacy}","received_events_url":"https://api.github.com/users/OttoWinter/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\n🏔 This PR adds a `unique_id` to the [cast platform](https://home-assistant.io/components/media_player.cast/). While doing so, it makes the platform **faster** by using async discovery and it tries to make the cast code base a bit easier to understand.\r\n\r\n⚠️ This needs to be tested ... like, a lot. From the past we know that the cast platform is very fragmented and there are many weird errors that result from 3rd party cast products. While I've tested this over the last 1 ½ days, I can't guarantee it will work for all devices, especially for audio groups.\r\n\r\nMy Chromecast Audio broke some time ago and my new one is only arriving in about a week (living in the mountains does have its downsides 😕). But then I'll also be able to try audio groups.\r\n\r\nRelated: #12395, #12405, fixes #11905\r\n\r\nAdded benefit: Home Assistant startup time is significantly reduced and those pesky \"Setup of platform media_player.cast is taking over 10 seconds.\" long entries are removed.\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\ndiscovery:\r\nmedia_player:\r\n  - platform: cast\r\n```\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n\r\nIf the code does not interact with devices:\r\n  - [ ] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [ ] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2018-02-17T13:24:58Z","updated_at":"2018-02-20T13:27:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4e12010ad409ec22ddd93385285a9105f612ec3f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":527871105,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":530497746,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20media_player.cast","name":"platform: media_player.cast","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12474/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12474/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/12474/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/34b3581e9094817bd692116e985ca8a8e4e8c4b8","head":{"label":"OttoWinter:cast-uuid","ref":"cast-uuid","sha":"34b3581e9094817bd692116e985ca8a8e4e8c4b8","user":{"login":"OttoWinter","id":6833237,"avatar_url":"https://avatars1.githubusercontent.com/u/6833237?v=4","gravatar_id":"","url":"https://api.github.com/users/OttoWinter","html_url":"https://github.com/OttoWinter","followers_url":"https://api.github.com/users/OttoWinter/followers","following_url":"https://api.github.com/users/OttoWinter/following{/other_user}","gists_url":"https://api.github.com/users/OttoWinter/gists{/gist_id}","starred_url":"https://api.github.com/users/OttoWinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OttoWinter/subscriptions","organizations_url":"https://api.github.com/users/OttoWinter/orgs","repos_url":"https://api.github.com/users/OttoWinter/repos","events_url":"https://api.github.com/users/OttoWinter/events{/privacy}","received_events_url":"https://api.github.com/users/OttoWinter/received_events","type":"User","site_admin":false},"repo":{"id":81717015,"name":"home-assistant","full_name":"OttoWinter/home-assistant","owner":{"login":"OttoWinter","id":6833237,"avatar_url":"https://avatars1.githubusercontent.com/u/6833237?v=4","gravatar_id":"","url":"https://api.github.com/users/OttoWinter","html_url":"https://github.com/OttoWinter","followers_url":"https://api.github.com/users/OttoWinter/followers","following_url":"https://api.github.com/users/OttoWinter/following{/other_user}","gists_url":"https://api.github.com/users/OttoWinter/gists{/gist_id}","starred_url":"https://api.github.com/users/OttoWinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OttoWinter/subscriptions","organizations_url":"https://api.github.com/users/OttoWinter/orgs","repos_url":"https://api.github.com/users/OttoWinter/repos","events_url":"https://api.github.com/users/OttoWinter/events{/privacy}","received_events_url":"https://api.github.com/users/OttoWinter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OttoWinter/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/OttoWinter/home-assistant","forks_url":"https://api.github.com/repos/OttoWinter/home-assistant/forks","keys_url":"https://api.github.com/repos/OttoWinter/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OttoWinter/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OttoWinter/home-assistant/teams","hooks_url":"https://api.github.com/repos/OttoWinter/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/OttoWinter/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/OttoWinter/home-assistant/events","assignees_url":"https://api.github.com/repos/OttoWinter/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/OttoWinter/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/OttoWinter/home-assistant/tags","blobs_url":"https://api.github.com/repos/OttoWinter/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OttoWinter/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OttoWinter/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/OttoWinter/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OttoWinter/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/OttoWinter/home-assistant/languages","stargazers_url":"https://api.github.com/repos/OttoWinter/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/OttoWinter/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/OttoWinter/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/OttoWinter/home-assistant/subscription","commits_url":"https://api.github.com/repos/OttoWinter/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/OttoWinter/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/OttoWinter/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/OttoWinter/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/OttoWinter/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/OttoWinter/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OttoWinter/home-assistant/merges","archive_url":"https://api.github.com/repos/OttoWinter/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OttoWinter/home-assistant/downloads","issues_url":"https://api.github.com/repos/OttoWinter/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/OttoWinter/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/OttoWinter/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/OttoWinter/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OttoWinter/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/OttoWinter/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/OttoWinter/home-assistant/deployments","created_at":"2017-02-12T10:00:20Z","updated_at":"2018-01-22T16:40:59Z","pushed_at":"2018-02-20T13:04:04Z","git_url":"git://github.com/OttoWinter/home-assistant.git","ssh_url":"git@github.com:OttoWinter/home-assistant.git","clone_url":"https://github.com/OttoWinter/home-assistant.git","svn_url":"https://github.com/OttoWinter/home-assistant","homepage":"https://home-assistant.io","size":78965,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"3fd61d8f456f14796e41dc05c77a7ab60861eb84","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-02-20T13:02:11Z","pushed_at":"2018-02-20T13:09:45Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":78724,"stargazers_count":12652,"watchers_count":12652,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3657,"mirror_url":null,"archived":false,"open_issues_count":839,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3657,"open_issues":839,"watchers":12652,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12474"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/12474"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/12474"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/12474/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12474/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12474/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/34b3581e9094817bd692116e985ca8a8e4e8c4b8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tinloaf"}}