{"action":"created","comment":{"url":"https://api.github.com/repos/jampp/sharedbuffers/pulls/comments/220663032","pull_request_review_id":159123308,"id":220663032,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDY2MzAzMg==","diff_hunk":"@@ -1174,6 +1175,7 @@ class ObjectBufferProxyProperty(GenericBufferProxyProperty):\n     mapped_decimal : DecimalBufferProxyProperty,\n \n     int : LongBufferProxyProperty,\n+    long : LongBufferProxyProperty,","path":"sharedbuffers/mapped_struct.py","position":12,"original_position":12,"commit_id":"a1351f95f02652b1fa602d4bf7ad59dcc27f017f","original_commit_id":"a1351f95f02652b1fa602d4bf7ad59dcc27f017f","user":{"login":"klaussfreire","id":1746892,"node_id":"MDQ6VXNlcjE3NDY4OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1746892?v=4","gravatar_id":"","url":"https://api.github.com/users/klaussfreire","html_url":"https://github.com/klaussfreire","followers_url":"https://api.github.com/users/klaussfreire/followers","following_url":"https://api.github.com/users/klaussfreire/following{/other_user}","gists_url":"https://api.github.com/users/klaussfreire/gists{/gist_id}","starred_url":"https://api.github.com/users/klaussfreire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaussfreire/subscriptions","organizations_url":"https://api.github.com/users/klaussfreire/orgs","repos_url":"https://api.github.com/users/klaussfreire/repos","events_url":"https://api.github.com/users/klaussfreire/events{/privacy}","received_events_url":"https://api.github.com/users/klaussfreire/received_events","type":"User","site_admin":false},"body":"It's a python long.\r\n\r\nWe should, but this isn't implementing that.\r\n\r\nIt just happens that we routinely get longs that fit into an int. So until we start handling them as true longs, we can handle most cases like this. If the value doesn't fit, it will raise an error anyway.","created_at":"2018-09-26T17:54:39Z","updated_at":"2018-09-26T17:54:39Z","html_url":"https://github.com/jampp/sharedbuffers/pull/42#discussion_r220663032","pull_request_url":"https://api.github.com/repos/jampp/sharedbuffers/pulls/42","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jampp/sharedbuffers/pulls/comments/220663032"},"html":{"href":"https://github.com/jampp/sharedbuffers/pull/42#discussion_r220663032"},"pull_request":{"href":"https://api.github.com/repos/jampp/sharedbuffers/pulls/42"}},"in_reply_to_id":220662461},"pull_request":{"url":"https://api.github.com/repos/jampp/sharedbuffers/pulls/42","id":218400816,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDAwODE2","html_url":"https://github.com/jampp/sharedbuffers/pull/42","diff_url":"https://github.com/jampp/sharedbuffers/pull/42.diff","patch_url":"https://github.com/jampp/sharedbuffers/pull/42.patch","issue_url":"https://api.github.com/repos/jampp/sharedbuffers/issues/42","number":42,"state":"open","locked":false,"title":"Treat long as int, and produce more informative errors","user":{"login":"klaussfreire","id":1746892,"node_id":"MDQ6VXNlcjE3NDY4OTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1746892?v=4","gravatar_id":"","url":"https://api.github.com/users/klaussfreire","html_url":"https://github.com/klaussfreire","followers_url":"https://api.github.com/users/klaussfreire/followers","following_url":"https://api.github.com/users/klaussfreire/following{/other_user}","gists_url":"https://api.github.com/users/klaussfreire/gists{/gist_id}","starred_url":"https://api.github.com/users/klaussfreire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klaussfreire/subscriptions","organizations_url":"https://api.github.com/users/klaussfreire/orgs","repos_url":"https://api.github.com/users/klaussfreire/repos","events_url":"https://api.github.com/users/klaussfreire/events{/privacy}","received_events_url":"https://api.github.com/users/klaussfreire/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-26T17:46:55Z","updated_at":"2018-09-26T17:54:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47d9404c1c167fd1933bcc99ddab0c224599e2ba","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gefarion","id":1751005,"node_id":"MDQ6VXNlcjE3NTEwMDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1751005?v=4","gravatar_id":"","url":"https://api.github.com/users/gefarion","html_url":"https://github.com/gefarion","followers_url":"https://api.github.com/users/gefarion/followers","following_url":"https://api.github.com/users/gefarion/following{/other_user}","gists_url":"https://api.github.com/users/gefarion/gists{/gist_id}","starred_url":"https://api.github.com/users/gefarion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gefarion/subscriptions","organizations_url":"https://api.github.com/users/gefarion/orgs","repos_url":"https://api.github.com/users/gefarion/repos","events_url":"https://api.github.com/users/gefarion/events{/privacy}","received_events_url":"https://api.github.com/users/gefarion/received_events","type":"User","site_admin":false},{"login":"tzulberti-jampp","id":18741829,"node_id":"MDQ6VXNlcjE4NzQxODI5","avatar_url":"https://avatars0.githubusercontent.com/u/18741829?v=4","gravatar_id":"","url":"https://api.github.com/users/tzulberti-jampp","html_url":"https://github.com/tzulberti-jampp","followers_url":"https://api.github.com/users/tzulberti-jampp/followers","following_url":"https://api.github.com/users/tzulberti-jampp/following{/other_user}","gists_url":"https://api.github.com/users/tzulberti-jampp/gists{/gist_id}","starred_url":"https://api.github.com/users/tzulberti-jampp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzulberti-jampp/subscriptions","organizations_url":"https://api.github.com/users/tzulberti-jampp/orgs","repos_url":"https://api.github.com/users/tzulberti-jampp/repos","events_url":"https://api.github.com/users/tzulberti-jampp/events{/privacy}","received_events_url":"https://api.github.com/users/tzulberti-jampp/received_events","type":"User","site_admin":false},{"login":"npazos","id":41085778,"node_id":"MDQ6VXNlcjQxMDg1Nzc4","avatar_url":"https://avatars0.githubusercontent.com/u/41085778?v=4","gravatar_id":"","url":"https://api.github.com/users/npazos","html_url":"https://github.com/npazos","followers_url":"https://api.github.com/users/npazos/followers","following_url":"https://api.github.com/users/npazos/following{/other_user}","gists_url":"https://api.github.com/users/npazos/gists{/gist_id}","starred_url":"https://api.github.com/users/npazos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npazos/subscriptions","organizations_url":"https://api.github.com/users/npazos/orgs","repos_url":"https://api.github.com/users/npazos/repos","events_url":"https://api.github.com/users/npazos/events{/privacy}","received_events_url":"https://api.github.com/users/npazos/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jampp/sharedbuffers/pulls/42/commits","review_comments_url":"https://api.github.com/repos/jampp/sharedbuffers/pulls/42/comments","review_comment_url":"https://api.github.com/repos/jampp/sharedbuffers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jampp/sharedbuffers/issues/42/comments","statuses_url":"https://api.github.com/repos/jampp/sharedbuffers/statuses/a1351f95f02652b1fa602d4bf7ad59dcc27f017f","head":{"label":"jampp:long_support","ref":"long_support","sha":"a1351f95f02652b1fa602d4bf7ad59dcc27f017f","user":{"login":"jampp","id":13048969,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDQ4OTY5","avatar_url":"https://avatars0.githubusercontent.com/u/13048969?v=4","gravatar_id":"","url":"https://api.github.com/users/jampp","html_url":"https://github.com/jampp","followers_url":"https://api.github.com/users/jampp/followers","following_url":"https://api.github.com/users/jampp/following{/other_user}","gists_url":"https://api.github.com/users/jampp/gists{/gist_id}","starred_url":"https://api.github.com/users/jampp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jampp/subscriptions","organizations_url":"https://api.github.com/users/jampp/orgs","repos_url":"https://api.github.com/users/jampp/repos","events_url":"https://api.github.com/users/jampp/events{/privacy}","received_events_url":"https://api.github.com/users/jampp/received_events","type":"Organization","site_admin":false},"repo":{"id":70011533,"node_id":"MDEwOlJlcG9zaXRvcnk3MDAxMTUzMw==","name":"sharedbuffers","full_name":"jampp/sharedbuffers","private":false,"owner":{"login":"jampp","id":13048969,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDQ4OTY5","avatar_url":"https://avatars0.githubusercontent.com/u/13048969?v=4","gravatar_id":"","url":"https://api.github.com/users/jampp","html_url":"https://github.com/jampp","followers_url":"https://api.github.com/users/jampp/followers","following_url":"https://api.github.com/users/jampp/following{/other_user}","gists_url":"https://api.github.com/users/jampp/gists{/gist_id}","starred_url":"https://api.github.com/users/jampp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jampp/subscriptions","organizations_url":"https://api.github.com/users/jampp/orgs","repos_url":"https://api.github.com/users/jampp/repos","events_url":"https://api.github.com/users/jampp/events{/privacy}","received_events_url":"https://api.github.com/users/jampp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jampp/sharedbuffers","description":null,"fork":false,"url":"https://api.github.com/repos/jampp/sharedbuffers","forks_url":"https://api.github.com/repos/jampp/sharedbuffers/forks","keys_url":"https://api.github.com/repos/jampp/sharedbuffers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jampp/sharedbuffers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jampp/sharedbuffers/teams","hooks_url":"https://api.github.com/repos/jampp/sharedbuffers/hooks","issue_events_url":"https://api.github.com/repos/jampp/sharedbuffers/issues/events{/number}","events_url":"https://api.github.com/repos/jampp/sharedbuffers/events","assignees_url":"https://api.github.com/repos/jampp/sharedbuffers/assignees{/user}","branches_url":"https://api.github.com/repos/jampp/sharedbuffers/branches{/branch}","tags_url":"https://api.github.com/repos/jampp/sharedbuffers/tags","blobs_url":"https://api.github.com/repos/jampp/sharedbuffers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jampp/sharedbuffers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jampp/sharedbuffers/git/refs{/sha}","trees_url":"https://api.github.com/repos/jampp/sharedbuffers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jampp/sharedbuffers/statuses/{sha}","languages_url":"https://api.github.com/repos/jampp/sharedbuffers/languages","stargazers_url":"https://api.github.com/repos/jampp/sharedbuffers/stargazers","contributors_url":"https://api.github.com/repos/jampp/sharedbuffers/contributors","subscribers_url":"https://api.github.com/repos/jampp/sharedbuffers/subscribers","subscription_url":"https://api.github.com/repos/jampp/sharedbuffers/subscription","commits_url":"https://api.github.com/repos/jampp/sharedbuffers/commits{/sha}","git_commits_url":"https://api.github.com/repos/jampp/sharedbuffers/git/commits{/sha}","comments_url":"https://api.github.com/repos/jampp/sharedbuffers/comments{/number}","issue_comment_url":"https://api.github.com/repos/jampp/sharedbuffers/issues/comments{/number}","contents_url":"https://api.github.com/repos/jampp/sharedbuffers/contents/{+path}","compare_url":"https://api.github.com/repos/jampp/sharedbuffers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jampp/sharedbuffers/merges","archive_url":"https://api.github.com/repos/jampp/sharedbuffers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jampp/sharedbuffers/downloads","issues_url":"https://api.github.com/repos/jampp/sharedbuffers/issues{/number}","pulls_url":"https://api.github.com/repos/jampp/sharedbuffers/pulls{/number}","milestones_url":"https://api.github.com/repos/jampp/sharedbuffers/milestones{/number}","notifications_url":"https://api.github.com/repos/jampp/sharedbuffers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jampp/sharedbuffers/labels{/name}","releases_url":"https://api.github.com/repos/jampp/sharedbuffers/releases{/id}","deployments_url":"https://api.github.com/repos/jampp/sharedbuffers/deployments","created_at":"2016-10-04T22:26:03Z","updated_at":"2018-09-25T13:04:59Z","pushed_at":"2018-09-26T17:48:00Z","git_url":"git://github.com/jampp/sharedbuffers.git","ssh_url":"git@github.com:jampp/sharedbuffers.git","clone_url":"https://github.com/jampp/sharedbuffers.git","svn_url":"https://github.com/jampp/sharedbuffers","homepage":null,"size":349,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":7,"watchers":9,"default_branch":"master"}},"base":{"label":"jampp:master","ref":"master","sha":"336953eb30e4921a4d5b62e27544bf1a2d5bf2b4","user":{"login":"jampp","id":13048969,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDQ4OTY5","avatar_url":"https://avatars0.githubusercontent.com/u/13048969?v=4","gravatar_id":"","url":"https://api.github.com/users/jampp","html_url":"https://github.com/jampp","followers_url":"https://api.github.com/users/jampp/followers","following_url":"https://api.github.com/users/jampp/following{/other_user}","gists_url":"https://api.github.com/users/jampp/gists{/gist_id}","starred_url":"https://api.github.com/users/jampp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jampp/subscriptions","organizations_url":"https://api.github.com/users/jampp/orgs","repos_url":"https://api.github.com/users/jampp/repos","events_url":"https://api.github.com/users/jampp/events{/privacy}","received_events_url":"https://api.github.com/users/jampp/received_events","type":"Organization","site_admin":false},"repo":{"id":70011533,"node_id":"MDEwOlJlcG9zaXRvcnk3MDAxMTUzMw==","name":"sharedbuffers","full_name":"jampp/sharedbuffers","private":false,"owner":{"login":"jampp","id":13048969,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMDQ4OTY5","avatar_url":"https://avatars0.githubusercontent.com/u/13048969?v=4","gravatar_id":"","url":"https://api.github.com/users/jampp","html_url":"https://github.com/jampp","followers_url":"https://api.github.com/users/jampp/followers","following_url":"https://api.github.com/users/jampp/following{/other_user}","gists_url":"https://api.github.com/users/jampp/gists{/gist_id}","starred_url":"https://api.github.com/users/jampp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jampp/subscriptions","organizations_url":"https://api.github.com/users/jampp/orgs","repos_url":"https://api.github.com/users/jampp/repos","events_url":"https://api.github.com/users/jampp/events{/privacy}","received_events_url":"https://api.github.com/users/jampp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jampp/sharedbuffers","description":null,"fork":false,"url":"https://api.github.com/repos/jampp/sharedbuffers","forks_url":"https://api.github.com/repos/jampp/sharedbuffers/forks","keys_url":"https://api.github.com/repos/jampp/sharedbuffers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jampp/sharedbuffers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jampp/sharedbuffers/teams","hooks_url":"https://api.github.com/repos/jampp/sharedbuffers/hooks","issue_events_url":"https://api.github.com/repos/jampp/sharedbuffers/issues/events{/number}","events_url":"https://api.github.com/repos/jampp/sharedbuffers/events","assignees_url":"https://api.github.com/repos/jampp/sharedbuffers/assignees{/user}","branches_url":"https://api.github.com/repos/jampp/sharedbuffers/branches{/branch}","tags_url":"https://api.github.com/repos/jampp/sharedbuffers/tags","blobs_url":"https://api.github.com/repos/jampp/sharedbuffers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jampp/sharedbuffers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jampp/sharedbuffers/git/refs{/sha}","trees_url":"https://api.github.com/repos/jampp/sharedbuffers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jampp/sharedbuffers/statuses/{sha}","languages_url":"https://api.github.com/repos/jampp/sharedbuffers/languages","stargazers_url":"https://api.github.com/repos/jampp/sharedbuffers/stargazers","contributors_url":"https://api.github.com/repos/jampp/sharedbuffers/contributors","subscribers_url":"https://api.github.com/repos/jampp/sharedbuffers/subscribers","subscription_url":"https://api.github.com/repos/jampp/sharedbuffers/subscription","commits_url":"https://api.github.com/repos/jampp/sharedbuffers/commits{/sha}","git_commits_url":"https://api.github.com/repos/jampp/sharedbuffers/git/commits{/sha}","comments_url":"https://api.github.com/repos/jampp/sharedbuffers/comments{/number}","issue_comment_url":"https://api.github.com/repos/jampp/sharedbuffers/issues/comments{/number}","contents_url":"https://api.github.com/repos/jampp/sharedbuffers/contents/{+path}","compare_url":"https://api.github.com/repos/jampp/sharedbuffers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jampp/sharedbuffers/merges","archive_url":"https://api.github.com/repos/jampp/sharedbuffers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jampp/sharedbuffers/downloads","issues_url":"https://api.github.com/repos/jampp/sharedbuffers/issues{/number}","pulls_url":"https://api.github.com/repos/jampp/sharedbuffers/pulls{/number}","milestones_url":"https://api.github.com/repos/jampp/sharedbuffers/milestones{/number}","notifications_url":"https://api.github.com/repos/jampp/sharedbuffers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jampp/sharedbuffers/labels{/name}","releases_url":"https://api.github.com/repos/jampp/sharedbuffers/releases{/id}","deployments_url":"https://api.github.com/repos/jampp/sharedbuffers/deployments","created_at":"2016-10-04T22:26:03Z","updated_at":"2018-09-25T13:04:59Z","pushed_at":"2018-09-26T17:48:00Z","git_url":"git://github.com/jampp/sharedbuffers.git","ssh_url":"git@github.com:jampp/sharedbuffers.git","clone_url":"https://github.com/jampp/sharedbuffers.git","svn_url":"https://github.com/jampp/sharedbuffers","homepage":null,"size":349,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":7,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jampp/sharedbuffers/pulls/42"},"html":{"href":"https://github.com/jampp/sharedbuffers/pull/42"},"issue":{"href":"https://api.github.com/repos/jampp/sharedbuffers/issues/42"},"comments":{"href":"https://api.github.com/repos/jampp/sharedbuffers/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/jampp/sharedbuffers/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/jampp/sharedbuffers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jampp/sharedbuffers/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/jampp/sharedbuffers/statuses/a1351f95f02652b1fa602d4bf7ad59dcc27f017f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"klaussfreire"}}