{"action":"created","comment":{"url":"https://api.github.com/repos/smspillaz/libwobbly/pulls/comments/200556418","pull_request_review_id":134895414,"id":200556418,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDU1NjQxOA==","diff_hunk":"@@ -64,7 +64,7 @@\n #include <type_traits>                  // for move, etc\n #include <vector>                       // for vector\n \n-#include <boost/optional/optional.hpp>\n+#include <experimental/optional>        // for optional","path":"src/wobbly.cpp","position":5,"original_position":5,"commit_id":"80170a070c4064ef1959ee83de4cde74cf31ad2e","original_commit_id":"467876ac85e0c58cd482db4177bd2b626c920d3d","user":{"login":"smspillaz","id":775309,"node_id":"MDQ6VXNlcjc3NTMwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/775309?v=4","gravatar_id":"","url":"https://api.github.com/users/smspillaz","html_url":"https://github.com/smspillaz","followers_url":"https://api.github.com/users/smspillaz/followers","following_url":"https://api.github.com/users/smspillaz/following{/other_user}","gists_url":"https://api.github.com/users/smspillaz/gists{/gist_id}","starred_url":"https://api.github.com/users/smspillaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smspillaz/subscriptions","organizations_url":"https://api.github.com/users/smspillaz/orgs","repos_url":"https://api.github.com/users/smspillaz/repos","events_url":"https://api.github.com/users/smspillaz/events{/privacy}","received_events_url":"https://api.github.com/users/smspillaz/received_events","type":"User","site_admin":false},"body":"This header can even be dropped.","created_at":"2018-07-06T06:03:41Z","updated_at":"2018-07-06T06:03:41Z","html_url":"https://github.com/smspillaz/libwobbly/pull/11#discussion_r200556418","pull_request_url":"https://api.github.com/repos/smspillaz/libwobbly/pulls/11","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/smspillaz/libwobbly/pulls/comments/200556418"},"html":{"href":"https://github.com/smspillaz/libwobbly/pull/11#discussion_r200556418"},"pull_request":{"href":"https://api.github.com/repos/smspillaz/libwobbly/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/smspillaz/libwobbly/pulls/11","id":199495570,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NDk1NTcw","html_url":"https://github.com/smspillaz/libwobbly/pull/11","diff_url":"https://github.com/smspillaz/libwobbly/pull/11.diff","patch_url":"https://github.com/smspillaz/libwobbly/pull/11.patch","issue_url":"https://api.github.com/repos/smspillaz/libwobbly/issues/11","number":11,"state":"open","locked":false,"title":"T23173: Drop boost dependency, port to Meson","user":{"login":"smspillaz","id":775309,"node_id":"MDQ6VXNlcjc3NTMwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/775309?v=4","gravatar_id":"","url":"https://api.github.com/users/smspillaz","html_url":"https://github.com/smspillaz","followers_url":"https://api.github.com/users/smspillaz/followers","following_url":"https://api.github.com/users/smspillaz/following{/other_user}","gists_url":"https://api.github.com/users/smspillaz/gists{/gist_id}","starred_url":"https://api.github.com/users/smspillaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smspillaz/subscriptions","organizations_url":"https://api.github.com/users/smspillaz/orgs","repos_url":"https://api.github.com/users/smspillaz/repos","events_url":"https://api.github.com/users/smspillaz/events{/privacy}","received_events_url":"https://api.github.com/users/smspillaz/received_events","type":"User","site_admin":false},"body":"This is part of a task to make this code more maintainable for Endless (the main user of this project).\r\n\r\nFor various reasons having a dependency on boost and cmake makes distro maintenance a bit of a nightmare, so this PR gets rid of both of those, replacing boost template code with handwritten templates and cmake with meson.\r\n\r\nThe main part of this work was to drop the dependency on `boost::geometry`. This was trickier than it looked, as we were actually using boost::geometry to support arithmetic between array-of-structures  (`PointModel`) and structure-of-arrays (`PointView`) types. So, in order to preserve the structure-of-arrays optimizations, this PR re-implements some of the `boost::geometry` type traits and operations in `wobbly/geometry_traits`. The main concept there is that both `PointView` and `PointModel` implement the `wobbly::geometry::dimension:Dimension` and `wobbly::geometry::dimension:DimensionAccess` type trait, meaning template substitution will allow generating code for those types when passed to anything in `wobbly::geometry::dimension`.\r\n\r\nFinally, we drop `cmake` and all of the polysquare-specific (now unmaintained by yours truly) code and switch to meson. This sadly means that we lose support for some tooling, but meson is rapidly [gaining support for that anyway](http://mesonbuild.com/Release-notes-for-0-42-0.html#page-description).\r\n\r\nhttps://phabricator.endlessm.com/T23173","created_at":"2018-07-05T14:49:01Z","updated_at":"2018-07-06T06:03:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea82b24b64f354fd31ed55836898c9bd8c8f5427","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/smspillaz/libwobbly/pulls/11/commits","review_comments_url":"https://api.github.com/repos/smspillaz/libwobbly/pulls/11/comments","review_comment_url":"https://api.github.com/repos/smspillaz/libwobbly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smspillaz/libwobbly/issues/11/comments","statuses_url":"https://api.github.com/repos/smspillaz/libwobbly/statuses/80170a070c4064ef1959ee83de4cde74cf31ad2e","head":{"label":"smspillaz:T23173","ref":"T23173","sha":"80170a070c4064ef1959ee83de4cde74cf31ad2e","user":{"login":"smspillaz","id":775309,"node_id":"MDQ6VXNlcjc3NTMwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/775309?v=4","gravatar_id":"","url":"https://api.github.com/users/smspillaz","html_url":"https://github.com/smspillaz","followers_url":"https://api.github.com/users/smspillaz/followers","following_url":"https://api.github.com/users/smspillaz/following{/other_user}","gists_url":"https://api.github.com/users/smspillaz/gists{/gist_id}","starred_url":"https://api.github.com/users/smspillaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smspillaz/subscriptions","organizations_url":"https://api.github.com/users/smspillaz/orgs","repos_url":"https://api.github.com/users/smspillaz/repos","events_url":"https://api.github.com/users/smspillaz/events{/privacy}","received_events_url":"https://api.github.com/users/smspillaz/received_events","type":"User","site_admin":false},"repo":{"id":16116146,"node_id":"MDEwOlJlcG9zaXRvcnkxNjExNjE0Ng==","name":"libwobbly","full_name":"smspillaz/libwobbly","owner":{"login":"smspillaz","id":775309,"node_id":"MDQ6VXNlcjc3NTMwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/775309?v=4","gravatar_id":"","url":"https://api.github.com/users/smspillaz","html_url":"https://github.com/smspillaz","followers_url":"https://api.github.com/users/smspillaz/followers","following_url":"https://api.github.com/users/smspillaz/following{/other_user}","gists_url":"https://api.github.com/users/smspillaz/gists{/gist_id}","starred_url":"https://api.github.com/users/smspillaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smspillaz/subscriptions","organizations_url":"https://api.github.com/users/smspillaz/orgs","repos_url":"https://api.github.com/users/smspillaz/repos","events_url":"https://api.github.com/users/smspillaz/events{/privacy}","received_events_url":"https://api.github.com/users/smspillaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smspillaz/libwobbly","description":"Wobbly windows logic split out from Compiz","fork":false,"url":"https://api.github.com/repos/smspillaz/libwobbly","forks_url":"https://api.github.com/repos/smspillaz/libwobbly/forks","keys_url":"https://api.github.com/repos/smspillaz/libwobbly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smspillaz/libwobbly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smspillaz/libwobbly/teams","hooks_url":"https://api.github.com/repos/smspillaz/libwobbly/hooks","issue_events_url":"https://api.github.com/repos/smspillaz/libwobbly/issues/events{/number}","events_url":"https://api.github.com/repos/smspillaz/libwobbly/events","assignees_url":"https://api.github.com/repos/smspillaz/libwobbly/assignees{/user}","branches_url":"https://api.github.com/repos/smspillaz/libwobbly/branches{/branch}","tags_url":"https://api.github.com/repos/smspillaz/libwobbly/tags","blobs_url":"https://api.github.com/repos/smspillaz/libwobbly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smspillaz/libwobbly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smspillaz/libwobbly/git/refs{/sha}","trees_url":"https://api.github.com/repos/smspillaz/libwobbly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smspillaz/libwobbly/statuses/{sha}","languages_url":"https://api.github.com/repos/smspillaz/libwobbly/languages","stargazers_url":"https://api.github.com/repos/smspillaz/libwobbly/stargazers","contributors_url":"https://api.github.com/repos/smspillaz/libwobbly/contributors","subscribers_url":"https://api.github.com/repos/smspillaz/libwobbly/subscribers","subscription_url":"https://api.github.com/repos/smspillaz/libwobbly/subscription","commits_url":"https://api.github.com/repos/smspillaz/libwobbly/commits{/sha}","git_commits_url":"https://api.github.com/repos/smspillaz/libwobbly/git/commits{/sha}","comments_url":"https://api.github.com/repos/smspillaz/libwobbly/comments{/number}","issue_comment_url":"https://api.github.com/repos/smspillaz/libwobbly/issues/comments{/number}","contents_url":"https://api.github.com/repos/smspillaz/libwobbly/contents/{+path}","compare_url":"https://api.github.com/repos/smspillaz/libwobbly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smspillaz/libwobbly/merges","archive_url":"https://api.github.com/repos/smspillaz/libwobbly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smspillaz/libwobbly/downloads","issues_url":"https://api.github.com/repos/smspillaz/libwobbly/issues{/number}","pulls_url":"https://api.github.com/repos/smspillaz/libwobbly/pulls{/number}","milestones_url":"https://api.github.com/repos/smspillaz/libwobbly/milestones{/number}","notifications_url":"https://api.github.com/repos/smspillaz/libwobbly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smspillaz/libwobbly/labels{/name}","releases_url":"https://api.github.com/repos/smspillaz/libwobbly/releases{/id}","deployments_url":"https://api.github.com/repos/smspillaz/libwobbly/deployments","created_at":"2014-01-21T19:30:13Z","updated_at":"2018-06-18T13:54:43Z","pushed_at":"2018-07-06T02:45:46Z","git_url":"git://github.com/smspillaz/libwobbly.git","ssh_url":"git@github.com:smspillaz/libwobbly.git","clone_url":"https://github.com/smspillaz/libwobbly.git","svn_url":"https://github.com/smspillaz/libwobbly","homepage":null,"size":345,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"smspillaz:master","ref":"master","sha":"bbd1d918c71c8e6eaa27607352b2df1e151f0227","user":{"login":"smspillaz","id":775309,"node_id":"MDQ6VXNlcjc3NTMwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/775309?v=4","gravatar_id":"","url":"https://api.github.com/users/smspillaz","html_url":"https://github.com/smspillaz","followers_url":"https://api.github.com/users/smspillaz/followers","following_url":"https://api.github.com/users/smspillaz/following{/other_user}","gists_url":"https://api.github.com/users/smspillaz/gists{/gist_id}","starred_url":"https://api.github.com/users/smspillaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smspillaz/subscriptions","organizations_url":"https://api.github.com/users/smspillaz/orgs","repos_url":"https://api.github.com/users/smspillaz/repos","events_url":"https://api.github.com/users/smspillaz/events{/privacy}","received_events_url":"https://api.github.com/users/smspillaz/received_events","type":"User","site_admin":false},"repo":{"id":16116146,"node_id":"MDEwOlJlcG9zaXRvcnkxNjExNjE0Ng==","name":"libwobbly","full_name":"smspillaz/libwobbly","owner":{"login":"smspillaz","id":775309,"node_id":"MDQ6VXNlcjc3NTMwOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/775309?v=4","gravatar_id":"","url":"https://api.github.com/users/smspillaz","html_url":"https://github.com/smspillaz","followers_url":"https://api.github.com/users/smspillaz/followers","following_url":"https://api.github.com/users/smspillaz/following{/other_user}","gists_url":"https://api.github.com/users/smspillaz/gists{/gist_id}","starred_url":"https://api.github.com/users/smspillaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smspillaz/subscriptions","organizations_url":"https://api.github.com/users/smspillaz/orgs","repos_url":"https://api.github.com/users/smspillaz/repos","events_url":"https://api.github.com/users/smspillaz/events{/privacy}","received_events_url":"https://api.github.com/users/smspillaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smspillaz/libwobbly","description":"Wobbly windows logic split out from Compiz","fork":false,"url":"https://api.github.com/repos/smspillaz/libwobbly","forks_url":"https://api.github.com/repos/smspillaz/libwobbly/forks","keys_url":"https://api.github.com/repos/smspillaz/libwobbly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smspillaz/libwobbly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smspillaz/libwobbly/teams","hooks_url":"https://api.github.com/repos/smspillaz/libwobbly/hooks","issue_events_url":"https://api.github.com/repos/smspillaz/libwobbly/issues/events{/number}","events_url":"https://api.github.com/repos/smspillaz/libwobbly/events","assignees_url":"https://api.github.com/repos/smspillaz/libwobbly/assignees{/user}","branches_url":"https://api.github.com/repos/smspillaz/libwobbly/branches{/branch}","tags_url":"https://api.github.com/repos/smspillaz/libwobbly/tags","blobs_url":"https://api.github.com/repos/smspillaz/libwobbly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smspillaz/libwobbly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smspillaz/libwobbly/git/refs{/sha}","trees_url":"https://api.github.com/repos/smspillaz/libwobbly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smspillaz/libwobbly/statuses/{sha}","languages_url":"https://api.github.com/repos/smspillaz/libwobbly/languages","stargazers_url":"https://api.github.com/repos/smspillaz/libwobbly/stargazers","contributors_url":"https://api.github.com/repos/smspillaz/libwobbly/contributors","subscribers_url":"https://api.github.com/repos/smspillaz/libwobbly/subscribers","subscription_url":"https://api.github.com/repos/smspillaz/libwobbly/subscription","commits_url":"https://api.github.com/repos/smspillaz/libwobbly/commits{/sha}","git_commits_url":"https://api.github.com/repos/smspillaz/libwobbly/git/commits{/sha}","comments_url":"https://api.github.com/repos/smspillaz/libwobbly/comments{/number}","issue_comment_url":"https://api.github.com/repos/smspillaz/libwobbly/issues/comments{/number}","contents_url":"https://api.github.com/repos/smspillaz/libwobbly/contents/{+path}","compare_url":"https://api.github.com/repos/smspillaz/libwobbly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smspillaz/libwobbly/merges","archive_url":"https://api.github.com/repos/smspillaz/libwobbly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smspillaz/libwobbly/downloads","issues_url":"https://api.github.com/repos/smspillaz/libwobbly/issues{/number}","pulls_url":"https://api.github.com/repos/smspillaz/libwobbly/pulls{/number}","milestones_url":"https://api.github.com/repos/smspillaz/libwobbly/milestones{/number}","notifications_url":"https://api.github.com/repos/smspillaz/libwobbly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smspillaz/libwobbly/labels{/name}","releases_url":"https://api.github.com/repos/smspillaz/libwobbly/releases{/id}","deployments_url":"https://api.github.com/repos/smspillaz/libwobbly/deployments","created_at":"2014-01-21T19:30:13Z","updated_at":"2018-06-18T13:54:43Z","pushed_at":"2018-07-06T02:45:46Z","git_url":"git://github.com/smspillaz/libwobbly.git","ssh_url":"git@github.com:smspillaz/libwobbly.git","clone_url":"https://github.com/smspillaz/libwobbly.git","svn_url":"https://github.com/smspillaz/libwobbly","homepage":null,"size":345,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smspillaz/libwobbly/pulls/11"},"html":{"href":"https://github.com/smspillaz/libwobbly/pull/11"},"issue":{"href":"https://api.github.com/repos/smspillaz/libwobbly/issues/11"},"comments":{"href":"https://api.github.com/repos/smspillaz/libwobbly/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/smspillaz/libwobbly/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/smspillaz/libwobbly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smspillaz/libwobbly/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/smspillaz/libwobbly/statuses/80170a070c4064ef1959ee83de4cde74cf31ad2e"}},"author_association":"OWNER"}}
{"actor":{"display_login":"smspillaz"}}