{"action":"created","issue":{"url":"https://api.github.com/repos/yarnpkg/yarn/issues/5424","repository_url":"https://api.github.com/repos/yarnpkg/yarn","labels_url":"https://api.github.com/repos/yarnpkg/yarn/issues/5424/labels{/name}","comments_url":"https://api.github.com/repos/yarnpkg/yarn/issues/5424/comments","events_url":"https://api.github.com/repos/yarnpkg/yarn/issues/5424/events","html_url":"https://github.com/yarnpkg/yarn/pull/5424","id":300860683,"number":5424,"title":"Make secureGitUrl() warn for insecure Urls","user":{"login":"sth","id":950517,"avatar_url":"https://avatars0.githubusercontent.com/u/950517?v=4","gravatar_id":"","url":"https://api.github.com/users/sth","html_url":"https://github.com/sth","followers_url":"https://api.github.com/users/sth/followers","following_url":"https://api.github.com/users/sth/following{/other_user}","gists_url":"https://api.github.com/users/sth/gists{/gist_id}","starred_url":"https://api.github.com/users/sth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sth/subscriptions","organizations_url":"https://api.github.com/users/sth/orgs","repos_url":"https://api.github.com/users/sth/repos","events_url":"https://api.github.com/users/sth/events{/privacy}","received_events_url":"https://api.github.com/users/sth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-28T01:49:50Z","updated_at":"2018-04-18T16:33:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/yarnpkg/yarn/pulls/5424","html_url":"https://github.com/yarnpkg/yarn/pull/5424","diff_url":"https://github.com/yarnpkg/yarn/pull/5424.diff","patch_url":"https://github.com/yarnpkg/yarn/pull/5424.patch"},"body":"This is an updated version of #4809. It is rebased to current master and has some new tests added that verify the behavior of the modified `secureGitUrl()` function.\r\n\r\n**Summary**\r\n`secureGitUrl()` tries to make sure that we use secure URLs. It currently behaves inconsistently, like allowing plain http download without any warnings or raising `SecurityError` if a repository doesn't exist. See #4307 for details.\r\n\r\nMain changes in behavior with this pull request:\r\n- Insecure `http:` and `git:` URLs are handled consistently:\r\n    - Plain `http:` URLs without a commit hash now report a warning. Previously they were silently accepted.\r\n    - Plain `git:` URLs without a commit hash now no longer raise a SecurityError. Instead they report a warning.\r\n- Non-existing or otherwise inaccessible repositories now no longer raise `SecurityError`. Previously this happend in some cases, leading to very confusing error messages.\r\n\r\nFor more context/rational see #4307 and the test cases in this pull request."},"comment":{"url":"https://api.github.com/repos/yarnpkg/yarn/issues/comments/382449254","html_url":"https://github.com/yarnpkg/yarn/pull/5424#issuecomment-382449254","issue_url":"https://api.github.com/repos/yarnpkg/yarn/issues/5424","id":382449254,"user":{"login":"arcanis","id":1037931,"avatar_url":"https://avatars2.githubusercontent.com/u/1037931?v=4","gravatar_id":"","url":"https://api.github.com/users/arcanis","html_url":"https://github.com/arcanis","followers_url":"https://api.github.com/users/arcanis/followers","following_url":"https://api.github.com/users/arcanis/following{/other_user}","gists_url":"https://api.github.com/users/arcanis/gists{/gist_id}","starred_url":"https://api.github.com/users/arcanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcanis/subscriptions","organizations_url":"https://api.github.com/users/arcanis/orgs","repos_url":"https://api.github.com/users/arcanis/repos","events_url":"https://api.github.com/users/arcanis/events{/privacy}","received_events_url":"https://api.github.com/users/arcanis/received_events","type":"User","site_admin":false},"created_at":"2018-04-18T16:33:40Z","updated_at":"2018-04-18T16:33:40Z","author_association":"OWNER","body":"A bit late, but this looks good! Thanks @sth! 🙂 "}}
{"actor":{"display_login":"arcanis"}}