{"action":"created","comment":{"url":"https://api.github.com/repos/sencha/ext-angular/pulls/comments/242650350","pull_request_review_id":186213384,"id":242650350,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjY1MDM1MA==","diff_hunk":"@@ -1,35 +1,56 @@\n-import { Component } from '@angular/core';\n+import { Component, VERSION } from '@angular/core';\n+import { Router } from '@angular/router';\n \n @Component({\n   selector: 'app-root',\n-  template: `\n-<panel #item [title]=title [layout]=\"'fit'\" [fitToParent]=\"true\">\n-  <grid #item\n-    [columns]=\"gridcolumns\" \n-    [store]=\"gridstore\"\n-    (select)=\"onGridSelect($event)\"\n-  ></grid>\n-</panel>\n-  `,\n+  templateUrl: 'app.component.html',\n   styles: []\n })\n export class AppComponent {\n-  title = 'ext-angular-modern-boilerplate'\n-  gridcolumns = [\n-\t\t{ text: 'Name', width: 250, dataIndex: 'name' },\n-\t\t{ text: 'Email Address', flex: 1, dataIndex: 'email' },\n-\t\t{ text: 'Phone Number', width: 250, dataIndex: 'phone' }\n-\t]\n-\tgridstore = {\n-\t\tfields: ['name', 'email', 'phone'],\n-\t\tdata: [\n-\t\t\t{ name: 'Lisa', email: 'lisa@simpsons.com', phone: '555-111-1224' },\n-\t\t\t{ name: 'Bart', email: 'bart@simpsons.com', phone: '555-222-1234' },\n-\t\t\t{ name: 'Homer', email: 'homer@simpsons.com', phone: '555-222-1244' },\n-\t\t\t{ name: 'Marge', email: 'marge@simpsons.com', phone: '555-222-1254' }\n-\t\t]\n-  }\n-  private onGridSelect({record}) {\n-\t\talert(record.data.name)\n+\n+\tANGULAR_VERSION: any = VERSION.full\n+\ttitle = 'ext-angular-modern-boilerplate - Angular v' + this.ANGULAR_VERSION\n+\n+\tconstructor(private router: Router) {\n+\n \t}\n+\n+\tshowAppMenu:boolean = false;\n+\t\n+\ttoggleAppMenu = () => {\n+\t\tthis.showAppMenu = !this.showAppMenu;\n+}\n+\n+onHideAppMenu = () => {\n+\t\tthis.showAppMenu = false;\n+}\n+\n+navigate = (event) => {\n+\tconsole.log(\"navigate\");\n+\n+\tvar record = event.record;\n+\tconsole.log(record.data.id);\n+\tthis.router.navigate([record.data.id]);\n+}\n+\n+navStore = {\n+\troot: {\n+\t\t\tchildren: [\n+\t\t\t\t\t{ id: '/', text: 'Home', iconCls: 'x-fa fa-home', leaf: true },\n+\t\t\t\t\t{ id: '/about', text: 'About', iconCls: 'x-fa fa-info', leaf: true },\n+\t\t\t]\n+\t}\n+};\n+\n+responsiveConfig = {","path":"packages/ext-angular-modern-boilerplate/src/app/app.component.ts","position":72,"original_position":72,"commit_id":"25e3975461f50ef226f7e251c0052c16948480f0","original_commit_id":"25e3975461f50ef226f7e251c0052c16948480f0","user":{"login":"branflake2267","id":1326504,"node_id":"MDQ6VXNlcjEzMjY1MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1326504?v=4","gravatar_id":"","url":"https://api.github.com/users/branflake2267","html_url":"https://github.com/branflake2267","followers_url":"https://api.github.com/users/branflake2267/followers","following_url":"https://api.github.com/users/branflake2267/following{/other_user}","gists_url":"https://api.github.com/users/branflake2267/gists{/gist_id}","starred_url":"https://api.github.com/users/branflake2267/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branflake2267/subscriptions","organizations_url":"https://api.github.com/users/branflake2267/orgs","repos_url":"https://api.github.com/users/branflake2267/repos","events_url":"https://api.github.com/users/branflake2267/events{/privacy}","received_events_url":"https://api.github.com/users/branflake2267/received_events","type":"User","site_admin":false},"body":"The class member indentation doesn't look right here? ","created_at":"2018-12-18T18:22:59Z","updated_at":"2018-12-18T18:22:59Z","html_url":"https://github.com/sencha/ext-angular/pull/101#discussion_r242650350","pull_request_url":"https://api.github.com/repos/sencha/ext-angular/pulls/101","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/sencha/ext-angular/pulls/comments/242650350"},"html":{"href":"https://github.com/sencha/ext-angular/pull/101#discussion_r242650350"},"pull_request":{"href":"https://api.github.com/repos/sencha/ext-angular/pulls/101"}}},"pull_request":{"url":"https://api.github.com/repos/sencha/ext-angular/pulls/101","id":239254891,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MjU0ODkx","html_url":"https://github.com/sencha/ext-angular/pull/101","diff_url":"https://github.com/sencha/ext-angular/pull/101.diff","patch_url":"https://github.com/sencha/ext-angular/pull/101.patch","issue_url":"https://api.github.com/repos/sencha/ext-angular/issues/101","number":101,"state":"open","locked":false,"title":"Ext Angular: Incremental PR","user":{"login":"aniket91","id":5745302,"node_id":"MDQ6VXNlcjU3NDUzMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/5745302?v=4","gravatar_id":"","url":"https://api.github.com/users/aniket91","html_url":"https://github.com/aniket91","followers_url":"https://api.github.com/users/aniket91/followers","following_url":"https://api.github.com/users/aniket91/following{/other_user}","gists_url":"https://api.github.com/users/aniket91/gists{/gist_id}","starred_url":"https://api.github.com/users/aniket91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aniket91/subscriptions","organizations_url":"https://api.github.com/users/aniket91/orgs","repos_url":"https://api.github.com/users/aniket91/repos","events_url":"https://api.github.com/users/aniket91/events{/privacy}","received_events_url":"https://api.github.com/users/aniket91/received_events","type":"User","site_admin":false},"body":"This PR contains -\r\n1. FIxed Heterogeneous tree example in Kichensink\r\n2. Added more Sencha tests  (todo: https://github.com/sencha/ext-angular/blob/31d8c05e7c198dde4c54dd2f056eb90f5057db6a/packages/ext-angular-tests/src/app/test/TODO)\r\n3. Updated boiler plate code for angular modern to be same as react.\r\n4. Rest of api docs for angular","created_at":"2018-12-17T19:18:06Z","updated_at":"2018-12-18T18:22:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57ed7991f11a77b517b292314f4e01c28a0299f1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sencha/ext-angular/pulls/101/commits","review_comments_url":"https://api.github.com/repos/sencha/ext-angular/pulls/101/comments","review_comment_url":"https://api.github.com/repos/sencha/ext-angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sencha/ext-angular/issues/101/comments","statuses_url":"https://api.github.com/repos/sencha/ext-angular/statuses/25e3975461f50ef226f7e251c0052c16948480f0","head":{"label":"aniket91:master","ref":"master","sha":"25e3975461f50ef226f7e251c0052c16948480f0","user":{"login":"aniket91","id":5745302,"node_id":"MDQ6VXNlcjU3NDUzMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/5745302?v=4","gravatar_id":"","url":"https://api.github.com/users/aniket91","html_url":"https://github.com/aniket91","followers_url":"https://api.github.com/users/aniket91/followers","following_url":"https://api.github.com/users/aniket91/following{/other_user}","gists_url":"https://api.github.com/users/aniket91/gists{/gist_id}","starred_url":"https://api.github.com/users/aniket91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aniket91/subscriptions","organizations_url":"https://api.github.com/users/aniket91/orgs","repos_url":"https://api.github.com/users/aniket91/repos","events_url":"https://api.github.com/users/aniket91/events{/privacy}","received_events_url":"https://api.github.com/users/aniket91/received_events","type":"User","site_admin":false},"repo":{"id":157559324,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc1NTkzMjQ=","name":"ext-angular-1","full_name":"aniket91/ext-angular-1","private":false,"owner":{"login":"aniket91","id":5745302,"node_id":"MDQ6VXNlcjU3NDUzMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/5745302?v=4","gravatar_id":"","url":"https://api.github.com/users/aniket91","html_url":"https://github.com/aniket91","followers_url":"https://api.github.com/users/aniket91/followers","following_url":"https://api.github.com/users/aniket91/following{/other_user}","gists_url":"https://api.github.com/users/aniket91/gists{/gist_id}","starred_url":"https://api.github.com/users/aniket91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aniket91/subscriptions","organizations_url":"https://api.github.com/users/aniket91/orgs","repos_url":"https://api.github.com/users/aniket91/repos","events_url":"https://api.github.com/users/aniket91/events{/privacy}","received_events_url":"https://api.github.com/users/aniket91/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aniket91/ext-angular-1","description":null,"fork":true,"url":"https://api.github.com/repos/aniket91/ext-angular-1","forks_url":"https://api.github.com/repos/aniket91/ext-angular-1/forks","keys_url":"https://api.github.com/repos/aniket91/ext-angular-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aniket91/ext-angular-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aniket91/ext-angular-1/teams","hooks_url":"https://api.github.com/repos/aniket91/ext-angular-1/hooks","issue_events_url":"https://api.github.com/repos/aniket91/ext-angular-1/issues/events{/number}","events_url":"https://api.github.com/repos/aniket91/ext-angular-1/events","assignees_url":"https://api.github.com/repos/aniket91/ext-angular-1/assignees{/user}","branches_url":"https://api.github.com/repos/aniket91/ext-angular-1/branches{/branch}","tags_url":"https://api.github.com/repos/aniket91/ext-angular-1/tags","blobs_url":"https://api.github.com/repos/aniket91/ext-angular-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aniket91/ext-angular-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aniket91/ext-angular-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/aniket91/ext-angular-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aniket91/ext-angular-1/statuses/{sha}","languages_url":"https://api.github.com/repos/aniket91/ext-angular-1/languages","stargazers_url":"https://api.github.com/repos/aniket91/ext-angular-1/stargazers","contributors_url":"https://api.github.com/repos/aniket91/ext-angular-1/contributors","subscribers_url":"https://api.github.com/repos/aniket91/ext-angular-1/subscribers","subscription_url":"https://api.github.com/repos/aniket91/ext-angular-1/subscription","commits_url":"https://api.github.com/repos/aniket91/ext-angular-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/aniket91/ext-angular-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/aniket91/ext-angular-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/aniket91/ext-angular-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/aniket91/ext-angular-1/contents/{+path}","compare_url":"https://api.github.com/repos/aniket91/ext-angular-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aniket91/ext-angular-1/merges","archive_url":"https://api.github.com/repos/aniket91/ext-angular-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aniket91/ext-angular-1/downloads","issues_url":"https://api.github.com/repos/aniket91/ext-angular-1/issues{/number}","pulls_url":"https://api.github.com/repos/aniket91/ext-angular-1/pulls{/number}","milestones_url":"https://api.github.com/repos/aniket91/ext-angular-1/milestones{/number}","notifications_url":"https://api.github.com/repos/aniket91/ext-angular-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aniket91/ext-angular-1/labels{/name}","releases_url":"https://api.github.com/repos/aniket91/ext-angular-1/releases{/id}","deployments_url":"https://api.github.com/repos/aniket91/ext-angular-1/deployments","created_at":"2018-11-14T14:17:07Z","updated_at":"2018-12-18T17:50:17Z","pushed_at":"2018-12-18T17:50:15Z","git_url":"git://github.com/aniket91/ext-angular-1.git","ssh_url":"git@github.com:aniket91/ext-angular-1.git","clone_url":"https://github.com/aniket91/ext-angular-1.git","svn_url":"https://github.com/aniket91/ext-angular-1","homepage":null,"size":88852,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sencha:master","ref":"master","sha":"370eb1487201f2eb5ea6ece59c9caac4064c25c6","user":{"login":"sencha","id":333591,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMzU5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/333591?v=4","gravatar_id":"","url":"https://api.github.com/users/sencha","html_url":"https://github.com/sencha","followers_url":"https://api.github.com/users/sencha/followers","following_url":"https://api.github.com/users/sencha/following{/other_user}","gists_url":"https://api.github.com/users/sencha/gists{/gist_id}","starred_url":"https://api.github.com/users/sencha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sencha/subscriptions","organizations_url":"https://api.github.com/users/sencha/orgs","repos_url":"https://api.github.com/users/sencha/repos","events_url":"https://api.github.com/users/sencha/events{/privacy}","received_events_url":"https://api.github.com/users/sencha/received_events","type":"Organization","site_admin":false},"repo":{"id":100643620,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA2NDM2MjA=","name":"ext-angular","full_name":"sencha/ext-angular","private":false,"owner":{"login":"sencha","id":333591,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMzU5MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/333591?v=4","gravatar_id":"","url":"https://api.github.com/users/sencha","html_url":"https://github.com/sencha","followers_url":"https://api.github.com/users/sencha/followers","following_url":"https://api.github.com/users/sencha/following{/other_user}","gists_url":"https://api.github.com/users/sencha/gists{/gist_id}","starred_url":"https://api.github.com/users/sencha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sencha/subscriptions","organizations_url":"https://api.github.com/users/sencha/orgs","repos_url":"https://api.github.com/users/sencha/repos","events_url":"https://api.github.com/users/sencha/events{/privacy}","received_events_url":"https://api.github.com/users/sencha/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sencha/ext-angular","description":"ExtAngular","fork":false,"url":"https://api.github.com/repos/sencha/ext-angular","forks_url":"https://api.github.com/repos/sencha/ext-angular/forks","keys_url":"https://api.github.com/repos/sencha/ext-angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sencha/ext-angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sencha/ext-angular/teams","hooks_url":"https://api.github.com/repos/sencha/ext-angular/hooks","issue_events_url":"https://api.github.com/repos/sencha/ext-angular/issues/events{/number}","events_url":"https://api.github.com/repos/sencha/ext-angular/events","assignees_url":"https://api.github.com/repos/sencha/ext-angular/assignees{/user}","branches_url":"https://api.github.com/repos/sencha/ext-angular/branches{/branch}","tags_url":"https://api.github.com/repos/sencha/ext-angular/tags","blobs_url":"https://api.github.com/repos/sencha/ext-angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sencha/ext-angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sencha/ext-angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/sencha/ext-angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sencha/ext-angular/statuses/{sha}","languages_url":"https://api.github.com/repos/sencha/ext-angular/languages","stargazers_url":"https://api.github.com/repos/sencha/ext-angular/stargazers","contributors_url":"https://api.github.com/repos/sencha/ext-angular/contributors","subscribers_url":"https://api.github.com/repos/sencha/ext-angular/subscribers","subscription_url":"https://api.github.com/repos/sencha/ext-angular/subscription","commits_url":"https://api.github.com/repos/sencha/ext-angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/sencha/ext-angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/sencha/ext-angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/sencha/ext-angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/sencha/ext-angular/contents/{+path}","compare_url":"https://api.github.com/repos/sencha/ext-angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sencha/ext-angular/merges","archive_url":"https://api.github.com/repos/sencha/ext-angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sencha/ext-angular/downloads","issues_url":"https://api.github.com/repos/sencha/ext-angular/issues{/number}","pulls_url":"https://api.github.com/repos/sencha/ext-angular/pulls{/number}","milestones_url":"https://api.github.com/repos/sencha/ext-angular/milestones{/number}","notifications_url":"https://api.github.com/repos/sencha/ext-angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sencha/ext-angular/labels{/name}","releases_url":"https://api.github.com/repos/sencha/ext-angular/releases{/id}","deployments_url":"https://api.github.com/repos/sencha/ext-angular/deployments","created_at":"2017-08-17T20:42:17Z","updated_at":"2018-12-17T17:40:32Z","pushed_at":"2018-12-18T17:50:16Z","git_url":"git://github.com/sencha/ext-angular.git","ssh_url":"git@github.com:sencha/ext-angular.git","clone_url":"https://github.com/sencha/ext-angular.git","svn_url":"https://github.com/sencha/ext-angular","homepage":"http://docs.sencha.com/extangular","size":88789,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sencha/ext-angular/pulls/101"},"html":{"href":"https://github.com/sencha/ext-angular/pull/101"},"issue":{"href":"https://api.github.com/repos/sencha/ext-angular/issues/101"},"comments":{"href":"https://api.github.com/repos/sencha/ext-angular/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/sencha/ext-angular/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/sencha/ext-angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sencha/ext-angular/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/sencha/ext-angular/statuses/25e3975461f50ef226f7e251c0052c16948480f0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"branflake2267"}}