{"action":"created","issue":{"url":"https://api.github.com/repos/DNNCommunity/DNN.Events/issues/49","repository_url":"https://api.github.com/repos/DNNCommunity/DNN.Events","labels_url":"https://api.github.com/repos/DNNCommunity/DNN.Events/issues/49/labels{/name}","comments_url":"https://api.github.com/repos/DNNCommunity/DNN.Events/issues/49/comments","events_url":"https://api.github.com/repos/DNNCommunity/DNN.Events/issues/49/events","html_url":"https://github.com/DNNCommunity/DNN.Events/pull/49","id":223926138,"number":49,"title":"Fix broken EventDateSort causing blank or missing events on calendar","user":{"login":"Starholme","id":1916332,"avatar_url":"https://avatars2.githubusercontent.com/u/1916332?v=4","gravatar_id":"","url":"https://api.github.com/users/Starholme","html_url":"https://github.com/Starholme","followers_url":"https://api.github.com/users/Starholme/followers","following_url":"https://api.github.com/users/Starholme/following{/other_user}","gists_url":"https://api.github.com/users/Starholme/gists{/gist_id}","starred_url":"https://api.github.com/users/Starholme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starholme/subscriptions","organizations_url":"https://api.github.com/users/Starholme/orgs","repos_url":"https://api.github.com/users/Starholme/repos","events_url":"https://api.github.com/users/Starholme/events{/privacy}","received_events_url":"https://api.github.com/users/Starholme/received_events","type":"User","site_admin":false},"labels":[{"id":174517100,"url":"https://api.github.com/repos/DNNCommunity/DNN.Events/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":{"login":"EPTamminga","id":5859855,"avatar_url":"https://avatars1.githubusercontent.com/u/5859855?v=4","gravatar_id":"","url":"https://api.github.com/users/EPTamminga","html_url":"https://github.com/EPTamminga","followers_url":"https://api.github.com/users/EPTamminga/followers","following_url":"https://api.github.com/users/EPTamminga/following{/other_user}","gists_url":"https://api.github.com/users/EPTamminga/gists{/gist_id}","starred_url":"https://api.github.com/users/EPTamminga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EPTamminga/subscriptions","organizations_url":"https://api.github.com/users/EPTamminga/orgs","repos_url":"https://api.github.com/users/EPTamminga/repos","events_url":"https://api.github.com/users/EPTamminga/events{/privacy}","received_events_url":"https://api.github.com/users/EPTamminga/received_events","type":"User","site_admin":false},"assignees":[{"login":"EPTamminga","id":5859855,"avatar_url":"https://avatars1.githubusercontent.com/u/5859855?v=4","gravatar_id":"","url":"https://api.github.com/users/EPTamminga","html_url":"https://github.com/EPTamminga","followers_url":"https://api.github.com/users/EPTamminga/followers","following_url":"https://api.github.com/users/EPTamminga/following{/other_user}","gists_url":"https://api.github.com/users/EPTamminga/gists{/gist_id}","starred_url":"https://api.github.com/users/EPTamminga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EPTamminga/subscriptions","organizations_url":"https://api.github.com/users/EPTamminga/orgs","repos_url":"https://api.github.com/users/EPTamminga/repos","events_url":"https://api.github.com/users/EPTamminga/events{/privacy}","received_events_url":"https://api.github.com/users/EPTamminga/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2017-04-24T19:28:11Z","updated_at":"2018-04-23T14:33:36Z","closed_at":"2017-05-05T06:24:58Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/DNNCommunity/DNN.Events/pulls/49","html_url":"https://github.com/DNNCommunity/DNN.Events/pull/49","diff_url":"https://github.com/DNNCommunity/DNN.Events/pull/49.diff","patch_url":"https://github.com/DNNCommunity/DNN.Events/pull/49.patch"},"body":"Hi,\r\nI believe I've found and solved the cause of some issues. On the City of Prince Albert website we are using this event module, and it stopped displaying events on a month. There didn't seem to be any rhyme or reason to which months did or did not work.\r\nI came across #48 when looking for solutions, and decided to dig into the code myself. The only way I was able to reproduce the issue was by copying my production event data into my development environment and patch up the module/user id's.\r\n\r\nLine 350 in EventController.vb was throwing an exception: Unable to sort because the IComparer.Compare() method returns inconsistent results. Either a value does not compare equal to itself, or one value repeatedly compared to another value yields different results\r\n\r\nThe cast from a boolean to a integer on line 666 could only return 0 or -1, never +1. I suspect it almost never causes problems because events don't change start dates very often(So they are sorted already when they come from the db), and any sort with very few items will use an insertion sort, which doesn't really care. Only when there is enough that it hits something like quicksort/heap/etc, AND items are out of order, does it explode.\r\n\r\nI suspect but cannot prove that this is the cause of #48, #46, #39, #19.\r\n\r\nCould also be related to #47.\r\n\r\nReally, anytime that 'some' events were missing or 'all' events were missing in a bug report, this could be the cause. It's very data dependent.\r\n\r\nIf you would like a copy of my data to test/verify with, please contact me at rdelainey@citypa.com and I'll take the time to anonymize it.\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/DNNCommunity/DNN.Events/pull/49%23issuecomment-299284914%22%2C%20%22https%3A//github.com/DNNCommunity/DNN.Events/pull/49%23issuecomment-299392037%22%2C%20%22https%3A//github.com/DNNCommunity/DNN.Events/pull/49%23issuecomment-317183570%22%2C%20%22https%3A//github.com/DNNCommunity/DNN.Events/pull/49%23issuecomment-317353358%22%2C%20%22https%3A//github.com/DNNCommunity/DNN.Events/pull/49%23issuecomment-383559673%22%2C%20%22https%3A//github.com/DNNCommunity/DNN.Events/pull/49%23issuecomment-383576980%22%2C%20%22https%3A//github.com/DNNCommunity/DNN.Events/pull/49%23issuecomment-383595606%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/DNNCommunity/DNN.Events/pull/49%23issuecomment-299284914%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%40EPTamminga%20Do%20you%20need%20anything%20else%20from%20me%20to%20get%20this%20pull%20request%20moving%3F%20I%27m%20pretty%20new%20to%20the%20open%20source%20world.%22%2C%20%22created_at%22%3A%20%222017-05-04T19%3A26%3A27Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars1.githubusercontent.com/u/1916332%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/Starholme%22%7D%7D%2C%20%7B%22body%22%3A%20%22%40Starholme%20%3A%20no%2C%20no%20need.%20Thank%20you%20for%20your%20work.%5Cr%5CnI%20just%20need%20to%20allocate%20some%20time%20myself%20to%20verify%20and%20create%20a%20new%20release%20by%20going%20over%20a%20number%20of%20issues%20and%20evaluate%20them.%20In%20the%20mean%20time%2C%20you%20are%20perfectly%20safe%20by%20having%20your%20own%20modified%20version%20and%20switch%20over%20to%20a%20new%20release%20once%20it%20comes%20around.%22%2C%20%22created_at%22%3A%20%222017-05-05T06%3A24%3A41Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars2.githubusercontent.com/u/5859855%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/EPTamminga%22%7D%7D%2C%20%7B%22body%22%3A%20%22Is%20there%20an%20estimated%20time%20for%20a%20new%20version%20including%20this%20fix%3F%5Cr%5Cn%5Cr%5CnAnd%20thanks%20%40EPTamminga%20for%20your%20continued%20support%20of%20this%20excellent%20module.%22%2C%20%22created_at%22%3A%20%222017-07-22T13%3A24%3A26Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars1.githubusercontent.com/u/312711%3Fv%3D4%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/djamell%22%7D%7D%2C%20%7B%22body%22%3A%20%22%40djamell%20I%20have%20the%20new%20release%20%28almost%29%20at%20the%20top%20of%20my%20ToDo%20list%2C%20but%20normal%20work%20%28and%20children%20%26%20grand%20children%20activities%29%20keep%20pushing%20it%20a%20bit%20downward.%20I%27ll%20work%20om%20it%20this%20week.%22%2C%20%22created_at%22%3A%20%222017-07-24T08%3A25%3A40Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars1.githubusercontent.com/u/5859855%3Fv%3D4%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/EPTamminga%22%7D%7D%2C%20%7B%22body%22%3A%20%22Hi%20Guys%5Cr%5Cn%5Cr%5CnI%20still%20have%20this%20problem.%5Cr%5Cn%5Cr%5CnUnable%20to%20sort%20because%20the%20IComparer.Compare%28%29%20method%20returns%20inconsistent%20results.%20Either%20a%20value%20does%20not%20compare%20equal%20to%20itself%2C%20or%20one%20value%20repeatedly%20compared%20to%20another%20value%20yields%20different%20results.%20IComparer%3A%20%27DotNetNuke.Modules.Events.EventInfoHelper%2BEventDateSort%27.%22%2C%20%22created_at%22%3A%20%222018-04-23T12%3A36%3A37Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars3.githubusercontent.com/u/9818491%3Fv%3D4%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/Behnam-Emamian%22%7D%7D%2C%20%7B%22body%22%3A%20%22I%20have%20one%20of%20my%20developers%20working%20on%20DNN.Events.%20We%20converted%20it%20to%20C%23%2C%20he%20is%20now%20working%20on%20removing%20some%20Telerik%20controls%20and%20getting%20the%20whole%20module%20packaging%20process%20into%20place.%20When%20the%20basics%20are%20working%20again%2C%20he%20will%20have%20a%20look%20at%20the%20issues.%22%2C%20%22created_at%22%3A%20%222018-04-23T13%3A34%3A39Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars1.githubusercontent.com/u/5859855%3Fv%3D4%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/EPTamminga%22%7D%7D%2C%20%7B%22body%22%3A%20%22Ernst%2C%5Cr%5Cn%5Cr%5CnI%20currently%20use%2020%20sub-calendars%20to%20manage%20event%20security.%20Can%20he%20also%20please%20look%20at%20including%20sub-calendar%20names%20in%20the%20iCal%20output%20like%20that%20displayed%20on%20a%20parent%20calendar%3F%20I%20know%20an%20attempt%20to%20fix%20this%20was%20previously%20attempted%20however%20I%20could%20not%20get%20the%20test%20code%20to%20run.%5Cr%5Cn%5Cr%5CnThank%20you.%5Cr%5Cn%5Cr%5Cn%5Cr%5CnFrom%3A%20Ernst%20Peter%20Tamminga%20%5Bmailto%3Anotifications%40github.com%5D%5Cr%5CnSent%3A%20Monday%2C%2023%20April%202018%2011%3A35%20PM%5Cr%5CnTo%3A%20DNNCommunity/DNN.Events%20%3CDNN.Events%40noreply.github.com%3E%5Cr%5CnCc%3A%20Subscribed%20%3Csubscribed%40noreply.github.com%3E%5Cr%5CnSubject%3A%20Re%3A%20%5BDNNCommunity/DNN.Events%5D%20Fix%20broken%20EventDateSort%20causing%20blank%20or%20missing%20events%20on%20calendar%20%28%2349%29%5Cr%5Cn%5Cr%5Cn%5Cr%5CnI%20have%20one%20of%20my%20developers%20working%20on%20DNN.Events.%20We%20converted%20it%20to%20C%23%2C%20he%20is%20now%20working%20on%20removing%20some%20Telerik%20controls%20and%20getting%20the%20whole%20module%20packaging%20process%20into%20place.%20When%20the%20basics%20are%20working%20again%2C%20he%20will%20have%20a%20look%20at%20the%20issues.%5Cr%5Cn%5Cr%5Cn%5Cu2014%5Cr%5CnYou%20are%20receiving%20this%20because%20you%20are%20subscribed%20to%20this%20thread.%5Cr%5CnReply%20to%20this%20email%20directly%2C%20view%20it%20on%20GitHub%3Chttps%3A//github.com/DNNCommunity/DNN.Events/pull/49%23issuecomment-383576980%3E%2C%20or%20mute%20the%20thread%3Chttps%3A//github.com/notifications/unsubscribe-auth/AYJWQu36pfAjwQAVAG5dB1G6d4OhXNHnks5trdhwgaJpZM4NGmtw%3E.%5Cr%5Cn%22%2C%20%22created_at%22%3A%20%222018-04-23T14%3A29%3A25Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars2.githubusercontent.com/u/25318978%3Fv%3D4%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/PeterCasper%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/DNNCommunity/DNN.Events/pull/49#issuecomment-299284914'>General Comment</a></b>\n- <a href='https://github.com/Starholme'><img border=0 src='https://avatars1.githubusercontent.com/u/1916332?v=3' height=16 width=16></a> @EPTamminga Do you need anything else from me to get this pull request moving? I'm pretty new to the open source world.\n- <a href='https://github.com/EPTamminga'><img border=0 src='https://avatars2.githubusercontent.com/u/5859855?v=3' height=16 width=16></a> @Starholme : no, no need. Thank you for your work.\nI just need to allocate some time myself to verify and create a new release by going over a number of issues and evaluate them. In the mean time, you are perfectly safe by having your own modified version and switch over to a new release once it comes around.\n- <a href='https://github.com/djamell'><img border=0 src='https://avatars1.githubusercontent.com/u/312711?v=4' height=16 width=16></a> Is there an estimated time for a new version including this fix?\nAnd thanks @EPTamminga for your continued support of this excellent module.\n- <a href='https://github.com/EPTamminga'><img border=0 src='https://avatars1.githubusercontent.com/u/5859855?v=4' height=16 width=16></a> @djamell I have the new release (almost) at the top of my ToDo list, but normal work (and children & grand children activities) keep pushing it a bit downward. I'll work om it this week.\n- <a href='https://github.com/Behnam-Emamian'><img border=0 src='https://avatars3.githubusercontent.com/u/9818491?v=4' height=16 width=16></a> Hi Guys\nI still have this problem.\nUnable to sort because the IComparer.Compare() method returns inconsistent results. Either a value does not compare equal to itself, or one value repeatedly compared to another value yields different results. IComparer: 'DotNetNuke.Modules.Events.EventInfoHelper+EventDateSort'.\n- <a href='https://github.com/EPTamminga'><img border=0 src='https://avatars1.githubusercontent.com/u/5859855?v=4' height=16 width=16></a> I have one of my developers working on DNN.Events. We converted it to C#, he is now working on removing some Telerik controls and getting the whole module packaging process into place. When the basics are working again, he will have a look at the issues.\n- <a href='https://github.com/PeterCasper'><img border=0 src='https://avatars2.githubusercontent.com/u/25318978?v=4' height=16 width=16></a> Ernst,\nI currently use 20 sub-calendars to manage event security. Can he also please look at including sub-calendar names in the iCal output like that displayed on a parent calendar? I know an attempt to fix this was previously attempted however I could not get the test code to run.\nThank you.\nFrom: Ernst Peter Tamminga [mailto:notifications@github.com]\nSent: Monday, 23 April 2018 11:35 PM\nTo: DNNCommunity/DNN.Events <DNN.Events@noreply.github.com>\nCc: Subscribed <subscribed@noreply.github.com>\nSubject: Re: [DNNCommunity/DNN.Events] Fix broken EventDateSort causing blank or missing events on calendar (#49)\nI have one of my developers working on DNN.Events. We converted it to C#, he is now working on removing some Telerik controls and getting the whole module packaging process into place. When the basics are working again, he will have a look at the issues.\n—\nYou are receiving this because you are subscribed to this thread.\nReply to this email directly, view it on GitHub<https://github.com/DNNCommunity/DNN.Events/pull/49#issuecomment-383576980>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AYJWQu36pfAjwQAVAG5dB1G6d4OhXNHnks5trdhwgaJpZM4NGmtw>.\n\n\n<a href='https://www.codereviewhub.com/DNNCommunity/DNN.Events/pull/49?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/DNNCommunity/DNN.Events/pull/49?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/DNNCommunity/DNN.Events/pull/49'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>"},"comment":{"url":"https://api.github.com/repos/DNNCommunity/DNN.Events/issues/comments/383597111","html_url":"https://github.com/DNNCommunity/DNN.Events/pull/49#issuecomment-383597111","issue_url":"https://api.github.com/repos/DNNCommunity/DNN.Events/issues/49","id":383597111,"user":{"login":"EPTamminga","id":5859855,"avatar_url":"https://avatars1.githubusercontent.com/u/5859855?v=4","gravatar_id":"","url":"https://api.github.com/users/EPTamminga","html_url":"https://github.com/EPTamminga","followers_url":"https://api.github.com/users/EPTamminga/followers","following_url":"https://api.github.com/users/EPTamminga/following{/other_user}","gists_url":"https://api.github.com/users/EPTamminga/gists{/gist_id}","starred_url":"https://api.github.com/users/EPTamminga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EPTamminga/subscriptions","organizations_url":"https://api.github.com/users/EPTamminga/orgs","repos_url":"https://api.github.com/users/EPTamminga/repos","events_url":"https://api.github.com/users/EPTamminga/events{/privacy}","received_events_url":"https://api.github.com/users/EPTamminga/received_events","type":"User","site_admin":false},"created_at":"2018-04-23T14:33:35Z","updated_at":"2018-04-23T14:33:35Z","author_association":"CONTRIBUTOR","body":"I know. This request is a bit more complex, but it is on the list and not forgotten."}}
{"actor":{"display_login":"EPTamminga"}}