{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang-nursery/rls/issues/1093","repository_url":"https://api.github.com/repos/rust-lang-nursery/rls","labels_url":"https://api.github.com/repos/rust-lang-nursery/rls/issues/1093/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rls/issues/1093/comments","events_url":"https://api.github.com/repos/rust-lang-nursery/rls/issues/1093/events","html_url":"https://github.com/rust-lang-nursery/rls/issues/1093","id":371241179,"node_id":"MDU6SXNzdWUzNzEyNDExNzk=","number":1093,"title":"RLS can't handle implicit workspaces","user":{"login":"jonathandturner","id":547158,"node_id":"MDQ6VXNlcjU0NzE1OA==","avatar_url":"https://avatars0.githubusercontent.com/u/547158?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathandturner","html_url":"https://github.com/jonathandturner","followers_url":"https://api.github.com/users/jonathandturner/followers","following_url":"https://api.github.com/users/jonathandturner/following{/other_user}","gists_url":"https://api.github.com/users/jonathandturner/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathandturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathandturner/subscriptions","organizations_url":"https://api.github.com/users/jonathandturner/orgs","repos_url":"https://api.github.com/users/jonathandturner/repos","events_url":"https://api.github.com/users/jonathandturner/events{/privacy}","received_events_url":"https://api.github.com/users/jonathandturner/received_events","type":"User","site_admin":false},"labels":[{"id":452360476,"node_id":"MDU6TGFiZWw0NTIzNjA0NzY=","url":"https://api.github.com/repos/rust-lang-nursery/rls/labels/P-high","name":"P-high","color":"b60205","default":false},{"id":433856097,"node_id":"MDU6TGFiZWw0MzM4NTYwOTc=","url":"https://api.github.com/repos/rust-lang-nursery/rls/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/rust-lang-nursery/rls/milestones/8","html_url":"https://github.com/rust-lang-nursery/rls/milestone/8","labels_url":"https://api.github.com/repos/rust-lang-nursery/rls/milestones/8/labels","id":3553850,"node_id":"MDk6TWlsZXN0b25lMzU1Mzg1MA==","number":8,"title":"Edition RC1","description":"","creator":{"login":"nrc","id":762626,"node_id":"MDQ6VXNlcjc2MjYyNg==","avatar_url":"https://avatars0.githubusercontent.com/u/762626?v=4","gravatar_id":"","url":"https://api.github.com/users/nrc","html_url":"https://github.com/nrc","followers_url":"https://api.github.com/users/nrc/followers","following_url":"https://api.github.com/users/nrc/following{/other_user}","gists_url":"https://api.github.com/users/nrc/gists{/gist_id}","starred_url":"https://api.github.com/users/nrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrc/subscriptions","organizations_url":"https://api.github.com/users/nrc/orgs","repos_url":"https://api.github.com/users/nrc/repos","events_url":"https://api.github.com/users/nrc/events{/privacy}","received_events_url":"https://api.github.com/users/nrc/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":5,"state":"open","created_at":"2018-08-07T22:08:44Z","updated_at":"2018-10-26T07:07:40Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-10-17T19:53:41Z","updated_at":"2018-10-26T16:40:01Z","closed_at":null,"author_association":"COLLABORATOR","body":"There are a couple options for workspaces in the Cargo.toml file to set up a workspace. Often, the workspace is explicit and the root Cargo.toml explicitly collects sub-crates under a workspace.\r\n\r\nYou can also have an implicit workspace, where you have dependencies to sub-crates without explicitly having a `[workspace]` section. In this case, the workspace is implied.\r\n\r\nCurrently, RLS doesn't seem to handle the latter case correctly. When it has an implicit case, it just errors on the toml file and doesn't do a full build. The same Cargo.toml with implicit workspace builds as expected from the commandline."},"comment":{"url":"https://api.github.com/repos/rust-lang-nursery/rls/issues/comments/433469841","html_url":"https://github.com/rust-lang-nursery/rls/issues/1093#issuecomment-433469841","issue_url":"https://api.github.com/repos/rust-lang-nursery/rls/issues/1093","id":433469841,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzQ2OTg0MQ==","user":{"login":"luser","id":286001,"node_id":"MDQ6VXNlcjI4NjAwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/286001?v=4","gravatar_id":"","url":"https://api.github.com/users/luser","html_url":"https://github.com/luser","followers_url":"https://api.github.com/users/luser/followers","following_url":"https://api.github.com/users/luser/following{/other_user}","gists_url":"https://api.github.com/users/luser/gists{/gist_id}","starred_url":"https://api.github.com/users/luser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luser/subscriptions","organizations_url":"https://api.github.com/users/luser/orgs","repos_url":"https://api.github.com/users/luser/repos","events_url":"https://api.github.com/users/luser/events{/privacy}","received_events_url":"https://api.github.com/users/luser/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T16:40:01Z","updated_at":"2018-10-26T16:40:01Z","author_association":"NONE","body":"> As a side note, due to our 'primary crate' logic, we won't pick up changes in `inner` since we only consider the root package + explicit workspace member packages as user-modifiable and so I imagine we could be smarter about it and treat every subdir `path` dependency as user-modifiable.\r\n\r\nFWIW cargo has logic similar to this to select when to enable incremental compilation. It'd probably be worth copying that:\r\nhttps://github.com/rust-lang/cargo/blob/2d0863f657e6f45159fc7412267eee3e659185e5/src/cargo/core/compiler/context/mod.rs#L429-L437"}}
{"actor":{"display_login":"luser"}}