{"action":"created","comment":{"url":"https://api.github.com/repos/OPM/opm-common/pulls/comments/180080672","pull_request_review_id":110437570,"id":180080672,"diff_hunk":"@@ -72,7 +72,20 @@ class VFPProdTable {\n         ALQ_UNDEF, //< Undefined\n         ALQ_INVALID\n     };\n-    inline VFPProdTable() {};","path":"opm/parser/eclipse/EclipseState/Schedule/VFPProdTable.hpp","position":null,"original_position":4,"commit_id":"f50a3ceb4f339b5d57b3e9b4670135d79d86efe5","original_commit_id":"f50a3ceb4f339b5d57b3e9b4670135d79d86efe5","user":{"login":"GitPaean","id":6847941,"avatar_url":"https://avatars0.githubusercontent.com/u/6847941?v=4","gravatar_id":"","url":"https://api.github.com/users/GitPaean","html_url":"https://github.com/GitPaean","followers_url":"https://api.github.com/users/GitPaean/followers","following_url":"https://api.github.com/users/GitPaean/following{/other_user}","gists_url":"https://api.github.com/users/GitPaean/gists{/gist_id}","starred_url":"https://api.github.com/users/GitPaean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GitPaean/subscriptions","organizations_url":"https://api.github.com/users/GitPaean/orgs","repos_url":"https://api.github.com/users/GitPaean/repos","events_url":"https://api.github.com/users/GitPaean/events{/privacy}","received_events_url":"https://api.github.com/users/GitPaean/received_events","type":"User","site_admin":false},"body":"Sorry, the default constructor is still required by the same test. ","created_at":"2018-04-09T12:42:46Z","updated_at":"2018-04-09T12:42:46Z","html_url":"https://github.com/OPM/opm-common/pull/375#discussion_r180080672","pull_request_url":"https://api.github.com/repos/OPM/opm-common/pulls/375","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-common/pulls/comments/180080672"},"html":{"href":"https://github.com/OPM/opm-common/pull/375#discussion_r180080672"},"pull_request":{"href":"https://api.github.com/repos/OPM/opm-common/pulls/375"}}},"pull_request":{"url":"https://api.github.com/repos/OPM/opm-common/pulls/375","id":179951532,"html_url":"https://github.com/OPM/opm-common/pull/375","diff_url":"https://github.com/OPM/opm-common/pull/375.diff","patch_url":"https://github.com/OPM/opm-common/pull/375.patch","issue_url":"https://api.github.com/repos/OPM/opm-common/issues/375","number":375,"state":"open","locked":false,"title":"Make VFP tables dynamic","user":{"login":"joakim-hove","id":1321665,"avatar_url":"https://avatars3.githubusercontent.com/u/1321665?v=4","gravatar_id":"","url":"https://api.github.com/users/joakim-hove","html_url":"https://github.com/joakim-hove","followers_url":"https://api.github.com/users/joakim-hove/followers","following_url":"https://api.github.com/users/joakim-hove/following{/other_user}","gists_url":"https://api.github.com/users/joakim-hove/gists{/gist_id}","starred_url":"https://api.github.com/users/joakim-hove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakim-hove/subscriptions","organizations_url":"https://api.github.com/users/joakim-hove/orgs","repos_url":"https://api.github.com/users/joakim-hove/repos","events_url":"https://api.github.com/users/joakim-hove/events{/privacy}","received_events_url":"https://api.github.com/users/joakim-hove/received_events","type":"User","site_admin":false},"body":"The VFP tables can be changed during the simulation. With this PR the VFPxxx implementation is moved from the `Table` domain to the Schedule domain - and a `DynamicState<>` is to store them, so that we can take varying VFP tables into account.\r\n\r\nDownsream PR coming.","created_at":"2018-04-06T13:39:51Z","updated_at":"2018-04-09T12:42:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8258c6913cf2194fdc0c72d9677d048c35975fc4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OPM/opm-common/pulls/375/commits","review_comments_url":"https://api.github.com/repos/OPM/opm-common/pulls/375/comments","review_comment_url":"https://api.github.com/repos/OPM/opm-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OPM/opm-common/issues/375/comments","statuses_url":"https://api.github.com/repos/OPM/opm-common/statuses/f50a3ceb4f339b5d57b3e9b4670135d79d86efe5","head":{"label":"joakim-hove:move-vfp-tables","ref":"move-vfp-tables","sha":"f50a3ceb4f339b5d57b3e9b4670135d79d86efe5","user":{"login":"joakim-hove","id":1321665,"avatar_url":"https://avatars3.githubusercontent.com/u/1321665?v=4","gravatar_id":"","url":"https://api.github.com/users/joakim-hove","html_url":"https://github.com/joakim-hove","followers_url":"https://api.github.com/users/joakim-hove/followers","following_url":"https://api.github.com/users/joakim-hove/following{/other_user}","gists_url":"https://api.github.com/users/joakim-hove/gists{/gist_id}","starred_url":"https://api.github.com/users/joakim-hove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakim-hove/subscriptions","organizations_url":"https://api.github.com/users/joakim-hove/orgs","repos_url":"https://api.github.com/users/joakim-hove/repos","events_url":"https://api.github.com/users/joakim-hove/events{/privacy}","received_events_url":"https://api.github.com/users/joakim-hove/received_events","type":"User","site_admin":false},"repo":{"id":32456806,"name":"opm-common","full_name":"joakim-hove/opm-common","owner":{"login":"joakim-hove","id":1321665,"avatar_url":"https://avatars3.githubusercontent.com/u/1321665?v=4","gravatar_id":"","url":"https://api.github.com/users/joakim-hove","html_url":"https://github.com/joakim-hove","followers_url":"https://api.github.com/users/joakim-hove/followers","following_url":"https://api.github.com/users/joakim-hove/following{/other_user}","gists_url":"https://api.github.com/users/joakim-hove/gists{/gist_id}","starred_url":"https://api.github.com/users/joakim-hove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakim-hove/subscriptions","organizations_url":"https://api.github.com/users/joakim-hove/orgs","repos_url":"https://api.github.com/users/joakim-hove/repos","events_url":"https://api.github.com/users/joakim-hove/events{/privacy}","received_events_url":"https://api.github.com/users/joakim-hove/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joakim-hove/opm-common","description":"Shared cmake files across flow simulation and upscaling repositories","fork":true,"url":"https://api.github.com/repos/joakim-hove/opm-common","forks_url":"https://api.github.com/repos/joakim-hove/opm-common/forks","keys_url":"https://api.github.com/repos/joakim-hove/opm-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joakim-hove/opm-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joakim-hove/opm-common/teams","hooks_url":"https://api.github.com/repos/joakim-hove/opm-common/hooks","issue_events_url":"https://api.github.com/repos/joakim-hove/opm-common/issues/events{/number}","events_url":"https://api.github.com/repos/joakim-hove/opm-common/events","assignees_url":"https://api.github.com/repos/joakim-hove/opm-common/assignees{/user}","branches_url":"https://api.github.com/repos/joakim-hove/opm-common/branches{/branch}","tags_url":"https://api.github.com/repos/joakim-hove/opm-common/tags","blobs_url":"https://api.github.com/repos/joakim-hove/opm-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joakim-hove/opm-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joakim-hove/opm-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/joakim-hove/opm-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joakim-hove/opm-common/statuses/{sha}","languages_url":"https://api.github.com/repos/joakim-hove/opm-common/languages","stargazers_url":"https://api.github.com/repos/joakim-hove/opm-common/stargazers","contributors_url":"https://api.github.com/repos/joakim-hove/opm-common/contributors","subscribers_url":"https://api.github.com/repos/joakim-hove/opm-common/subscribers","subscription_url":"https://api.github.com/repos/joakim-hove/opm-common/subscription","commits_url":"https://api.github.com/repos/joakim-hove/opm-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/joakim-hove/opm-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/joakim-hove/opm-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/joakim-hove/opm-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/joakim-hove/opm-common/contents/{+path}","compare_url":"https://api.github.com/repos/joakim-hove/opm-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joakim-hove/opm-common/merges","archive_url":"https://api.github.com/repos/joakim-hove/opm-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joakim-hove/opm-common/downloads","issues_url":"https://api.github.com/repos/joakim-hove/opm-common/issues{/number}","pulls_url":"https://api.github.com/repos/joakim-hove/opm-common/pulls{/number}","milestones_url":"https://api.github.com/repos/joakim-hove/opm-common/milestones{/number}","notifications_url":"https://api.github.com/repos/joakim-hove/opm-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joakim-hove/opm-common/labels{/name}","releases_url":"https://api.github.com/repos/joakim-hove/opm-common/releases{/id}","deployments_url":"https://api.github.com/repos/joakim-hove/opm-common/deployments","created_at":"2015-03-18T12:14:21Z","updated_at":"2016-11-14T06:18:15Z","pushed_at":"2018-04-09T12:21:14Z","git_url":"git://github.com/joakim-hove/opm-common.git","ssh_url":"git@github.com:joakim-hove/opm-common.git","clone_url":"https://github.com/joakim-hove/opm-common.git","svn_url":"https://github.com/joakim-hove/opm-common","homepage":null,"size":7736,"stargazers_count":0,"watchers_count":0,"language":"CMake","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OPM:master","ref":"master","sha":"936f5e5963511258edae9585977b80f8b5a254fd","user":{"login":"OPM","id":1827197,"avatar_url":"https://avatars0.githubusercontent.com/u/1827197?v=4","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"repo":{"id":32443143,"name":"opm-common","full_name":"OPM/opm-common","owner":{"login":"OPM","id":1827197,"avatar_url":"https://avatars0.githubusercontent.com/u/1827197?v=4","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OPM/opm-common","description":"Common components for OPM, in particular build system (cmake).","fork":false,"url":"https://api.github.com/repos/OPM/opm-common","forks_url":"https://api.github.com/repos/OPM/opm-common/forks","keys_url":"https://api.github.com/repos/OPM/opm-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPM/opm-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPM/opm-common/teams","hooks_url":"https://api.github.com/repos/OPM/opm-common/hooks","issue_events_url":"https://api.github.com/repos/OPM/opm-common/issues/events{/number}","events_url":"https://api.github.com/repos/OPM/opm-common/events","assignees_url":"https://api.github.com/repos/OPM/opm-common/assignees{/user}","branches_url":"https://api.github.com/repos/OPM/opm-common/branches{/branch}","tags_url":"https://api.github.com/repos/OPM/opm-common/tags","blobs_url":"https://api.github.com/repos/OPM/opm-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPM/opm-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPM/opm-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPM/opm-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPM/opm-common/statuses/{sha}","languages_url":"https://api.github.com/repos/OPM/opm-common/languages","stargazers_url":"https://api.github.com/repos/OPM/opm-common/stargazers","contributors_url":"https://api.github.com/repos/OPM/opm-common/contributors","subscribers_url":"https://api.github.com/repos/OPM/opm-common/subscribers","subscription_url":"https://api.github.com/repos/OPM/opm-common/subscription","commits_url":"https://api.github.com/repos/OPM/opm-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPM/opm-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPM/opm-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPM/opm-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPM/opm-common/contents/{+path}","compare_url":"https://api.github.com/repos/OPM/opm-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPM/opm-common/merges","archive_url":"https://api.github.com/repos/OPM/opm-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPM/opm-common/downloads","issues_url":"https://api.github.com/repos/OPM/opm-common/issues{/number}","pulls_url":"https://api.github.com/repos/OPM/opm-common/pulls{/number}","milestones_url":"https://api.github.com/repos/OPM/opm-common/milestones{/number}","notifications_url":"https://api.github.com/repos/OPM/opm-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPM/opm-common/labels{/name}","releases_url":"https://api.github.com/repos/OPM/opm-common/releases{/id}","deployments_url":"https://api.github.com/repos/OPM/opm-common/deployments","created_at":"2015-03-18T06:59:50Z","updated_at":"2018-04-09T12:30:12Z","pushed_at":"2018-04-09T12:30:09Z","git_url":"git://github.com/OPM/opm-common.git","ssh_url":"git@github.com:OPM/opm-common.git","clone_url":"https://github.com/OPM/opm-common.git","svn_url":"https://github.com/OPM/opm-common","homepage":"http://www.opm-project.org","size":7701,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":39,"open_issues":18,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-common/pulls/375"},"html":{"href":"https://github.com/OPM/opm-common/pull/375"},"issue":{"href":"https://api.github.com/repos/OPM/opm-common/issues/375"},"comments":{"href":"https://api.github.com/repos/OPM/opm-common/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/OPM/opm-common/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/OPM/opm-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OPM/opm-common/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/OPM/opm-common/statuses/f50a3ceb4f339b5d57b3e9b4670135d79d86efe5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"GitPaean"}}