{"action":"created","comment":{"url":"https://api.github.com/repos/SwissDataScienceCenter/renku/pulls/comments/191201509","pull_request_review_id":123728981,"id":191201509,"diff_hunk":"@@ -9,8 +9,7 @@ metadata:\n   annotations:\n     \"helm.sh/hook\": post-install,post-upgrade\n     \"helm.sh/hook-weight\": \"5\"\n-    \"helm.sh/hook-delete-policy\": \"hook-succeeded,hook-failed\"\n-    # FIXME with newer version of helm \"before-hook-creation\"\n+    \"helm.sh/hook-delete-policy\": \"hook-succeeded,before-hook-creation\"","path":"charts/renku/templates/post-install-job.yaml","position":6,"original_position":6,"commit_id":"5557d2d582d2f0feb7489ebf631e7edabd2d8976","original_commit_id":"5557d2d582d2f0feb7489ebf631e7edabd2d8976","user":{"login":"jirikuncar","id":189798,"avatar_url":"https://avatars1.githubusercontent.com/u/189798?v=4","gravatar_id":"","url":"https://api.github.com/users/jirikuncar","html_url":"https://github.com/jirikuncar","followers_url":"https://api.github.com/users/jirikuncar/followers","following_url":"https://api.github.com/users/jirikuncar/following{/other_user}","gists_url":"https://api.github.com/users/jirikuncar/gists{/gist_id}","starred_url":"https://api.github.com/users/jirikuncar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jirikuncar/subscriptions","organizations_url":"https://api.github.com/users/jirikuncar/orgs","repos_url":"https://api.github.com/users/jirikuncar/repos","events_url":"https://api.github.com/users/jirikuncar/events{/privacy}","received_events_url":"https://api.github.com/users/jirikuncar/received_events","type":"User","site_admin":false},"body":"I would personally keep the job there after success too and go with a single value `\"before-hook-creation\"`.\r\n\r\n---\r\nhttps://github.com/kubernetes/helm/blob/master/docs/charts_hooks.md#automatically-delete-hook-from-previous-release","created_at":"2018-05-28T13:03:38Z","updated_at":"2018-05-28T13:04:49Z","html_url":"https://github.com/SwissDataScienceCenter/renku/pull/244#discussion_r191201509","pull_request_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/pulls/244","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/SwissDataScienceCenter/renku/pulls/comments/191201509"},"html":{"href":"https://github.com/SwissDataScienceCenter/renku/pull/244#discussion_r191201509"},"pull_request":{"href":"https://api.github.com/repos/SwissDataScienceCenter/renku/pulls/244"}}},"pull_request":{"url":"https://api.github.com/repos/SwissDataScienceCenter/renku/pulls/244","id":190876923,"html_url":"https://github.com/SwissDataScienceCenter/renku/pull/244","diff_url":"https://github.com/SwissDataScienceCenter/renku/pull/244.diff","patch_url":"https://github.com/SwissDataScienceCenter/renku/pull/244.patch","issue_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/issues/244","number":244,"state":"open","locked":false,"title":"Fix post-install hook","user":{"login":"leafty","id":951086,"avatar_url":"https://avatars1.githubusercontent.com/u/951086?v=4","gravatar_id":"","url":"https://api.github.com/users/leafty","html_url":"https://github.com/leafty","followers_url":"https://api.github.com/users/leafty/followers","following_url":"https://api.github.com/users/leafty/following{/other_user}","gists_url":"https://api.github.com/users/leafty/gists{/gist_id}","starred_url":"https://api.github.com/users/leafty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leafty/subscriptions","organizations_url":"https://api.github.com/users/leafty/orgs","repos_url":"https://api.github.com/users/leafty/repos","events_url":"https://api.github.com/users/leafty/events{/privacy}","received_events_url":"https://api.github.com/users/leafty/received_events","type":"User","site_admin":false},"body":"Closes #243 ","created_at":"2018-05-28T09:10:38Z","updated_at":"2018-05-28T13:04:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcb407bcc03dd53440b2a77a68b5f18f150a201c","assignee":{"login":"leafty","id":951086,"avatar_url":"https://avatars1.githubusercontent.com/u/951086?v=4","gravatar_id":"","url":"https://api.github.com/users/leafty","html_url":"https://github.com/leafty","followers_url":"https://api.github.com/users/leafty/followers","following_url":"https://api.github.com/users/leafty/following{/other_user}","gists_url":"https://api.github.com/users/leafty/gists{/gist_id}","starred_url":"https://api.github.com/users/leafty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leafty/subscriptions","organizations_url":"https://api.github.com/users/leafty/orgs","repos_url":"https://api.github.com/users/leafty/repos","events_url":"https://api.github.com/users/leafty/events{/privacy}","received_events_url":"https://api.github.com/users/leafty/received_events","type":"User","site_admin":false},"assignees":[{"login":"leafty","id":951086,"avatar_url":"https://avatars1.githubusercontent.com/u/951086?v=4","gravatar_id":"","url":"https://api.github.com/users/leafty","html_url":"https://github.com/leafty","followers_url":"https://api.github.com/users/leafty/followers","following_url":"https://api.github.com/users/leafty/following{/other_user}","gists_url":"https://api.github.com/users/leafty/gists{/gist_id}","starred_url":"https://api.github.com/users/leafty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leafty/subscriptions","organizations_url":"https://api.github.com/users/leafty/orgs","repos_url":"https://api.github.com/users/leafty/repos","events_url":"https://api.github.com/users/leafty/events{/privacy}","received_events_url":"https://api.github.com/users/leafty/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/pulls/244/commits","review_comments_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/pulls/244/comments","review_comment_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/issues/244/comments","statuses_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/statuses/5557d2d582d2f0feb7489ebf631e7edabd2d8976","head":{"label":"SwissDataScienceCenter:leafty-patch-1","ref":"leafty-patch-1","sha":"5557d2d582d2f0feb7489ebf631e7edabd2d8976","user":{"login":"SwissDataScienceCenter","id":25008760,"avatar_url":"https://avatars3.githubusercontent.com/u/25008760?v=4","gravatar_id":"","url":"https://api.github.com/users/SwissDataScienceCenter","html_url":"https://github.com/SwissDataScienceCenter","followers_url":"https://api.github.com/users/SwissDataScienceCenter/followers","following_url":"https://api.github.com/users/SwissDataScienceCenter/following{/other_user}","gists_url":"https://api.github.com/users/SwissDataScienceCenter/gists{/gist_id}","starred_url":"https://api.github.com/users/SwissDataScienceCenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwissDataScienceCenter/subscriptions","organizations_url":"https://api.github.com/users/SwissDataScienceCenter/orgs","repos_url":"https://api.github.com/users/SwissDataScienceCenter/repos","events_url":"https://api.github.com/users/SwissDataScienceCenter/events{/privacy}","received_events_url":"https://api.github.com/users/SwissDataScienceCenter/received_events","type":"Organization","site_admin":false},"repo":{"id":100963735,"name":"renku","full_name":"SwissDataScienceCenter/renku","owner":{"login":"SwissDataScienceCenter","id":25008760,"avatar_url":"https://avatars3.githubusercontent.com/u/25008760?v=4","gravatar_id":"","url":"https://api.github.com/users/SwissDataScienceCenter","html_url":"https://github.com/SwissDataScienceCenter","followers_url":"https://api.github.com/users/SwissDataScienceCenter/followers","following_url":"https://api.github.com/users/SwissDataScienceCenter/following{/other_user}","gists_url":"https://api.github.com/users/SwissDataScienceCenter/gists{/gist_id}","starred_url":"https://api.github.com/users/SwissDataScienceCenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwissDataScienceCenter/subscriptions","organizations_url":"https://api.github.com/users/SwissDataScienceCenter/orgs","repos_url":"https://api.github.com/users/SwissDataScienceCenter/repos","events_url":"https://api.github.com/users/SwissDataScienceCenter/events{/privacy}","received_events_url":"https://api.github.com/users/SwissDataScienceCenter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SwissDataScienceCenter/renku","description":"RENKU (連句) is a highly-scalable & secure open software platform designed to foster multidisciplinary data (science) collaboration across mutually untrusted academic and industrial institutions.","fork":false,"url":"https://api.github.com/repos/SwissDataScienceCenter/renku","forks_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/forks","keys_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/teams","hooks_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/hooks","issue_events_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/issues/events{/number}","events_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/events","assignees_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/assignees{/user}","branches_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/branches{/branch}","tags_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/tags","blobs_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/git/refs{/sha}","trees_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/statuses/{sha}","languages_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/languages","stargazers_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/stargazers","contributors_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/contributors","subscribers_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/subscribers","subscription_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/subscription","commits_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/commits{/sha}","git_commits_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/git/commits{/sha}","comments_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/comments{/number}","issue_comment_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/issues/comments{/number}","contents_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/contents/{+path}","compare_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/merges","archive_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/downloads","issues_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/issues{/number}","pulls_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/pulls{/number}","milestones_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/milestones{/number}","notifications_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/labels{/name}","releases_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/releases{/id}","deployments_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/deployments","created_at":"2017-08-21T15:02:23Z","updated_at":"2018-05-28T12:23:54Z","pushed_at":"2018-05-28T12:35:04Z","git_url":"git://github.com/SwissDataScienceCenter/renku.git","ssh_url":"git@github.com:SwissDataScienceCenter/renku.git","clone_url":"https://github.com/SwissDataScienceCenter/renku.git","svn_url":"https://github.com/SwissDataScienceCenter/renku","homepage":"https://datascience.ch/renku-platform/","size":1554,"stargazers_count":24,"watchers_count":24,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":8,"open_issues":33,"watchers":24,"default_branch":"master"}},"base":{"label":"SwissDataScienceCenter:master","ref":"master","sha":"4d4d1c888e8b64b3635a35b21a447ba8fb0211ba","user":{"login":"SwissDataScienceCenter","id":25008760,"avatar_url":"https://avatars3.githubusercontent.com/u/25008760?v=4","gravatar_id":"","url":"https://api.github.com/users/SwissDataScienceCenter","html_url":"https://github.com/SwissDataScienceCenter","followers_url":"https://api.github.com/users/SwissDataScienceCenter/followers","following_url":"https://api.github.com/users/SwissDataScienceCenter/following{/other_user}","gists_url":"https://api.github.com/users/SwissDataScienceCenter/gists{/gist_id}","starred_url":"https://api.github.com/users/SwissDataScienceCenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwissDataScienceCenter/subscriptions","organizations_url":"https://api.github.com/users/SwissDataScienceCenter/orgs","repos_url":"https://api.github.com/users/SwissDataScienceCenter/repos","events_url":"https://api.github.com/users/SwissDataScienceCenter/events{/privacy}","received_events_url":"https://api.github.com/users/SwissDataScienceCenter/received_events","type":"Organization","site_admin":false},"repo":{"id":100963735,"name":"renku","full_name":"SwissDataScienceCenter/renku","owner":{"login":"SwissDataScienceCenter","id":25008760,"avatar_url":"https://avatars3.githubusercontent.com/u/25008760?v=4","gravatar_id":"","url":"https://api.github.com/users/SwissDataScienceCenter","html_url":"https://github.com/SwissDataScienceCenter","followers_url":"https://api.github.com/users/SwissDataScienceCenter/followers","following_url":"https://api.github.com/users/SwissDataScienceCenter/following{/other_user}","gists_url":"https://api.github.com/users/SwissDataScienceCenter/gists{/gist_id}","starred_url":"https://api.github.com/users/SwissDataScienceCenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwissDataScienceCenter/subscriptions","organizations_url":"https://api.github.com/users/SwissDataScienceCenter/orgs","repos_url":"https://api.github.com/users/SwissDataScienceCenter/repos","events_url":"https://api.github.com/users/SwissDataScienceCenter/events{/privacy}","received_events_url":"https://api.github.com/users/SwissDataScienceCenter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SwissDataScienceCenter/renku","description":"RENKU (連句) is a highly-scalable & secure open software platform designed to foster multidisciplinary data (science) collaboration across mutually untrusted academic and industrial institutions.","fork":false,"url":"https://api.github.com/repos/SwissDataScienceCenter/renku","forks_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/forks","keys_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/teams","hooks_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/hooks","issue_events_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/issues/events{/number}","events_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/events","assignees_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/assignees{/user}","branches_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/branches{/branch}","tags_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/tags","blobs_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/git/refs{/sha}","trees_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/statuses/{sha}","languages_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/languages","stargazers_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/stargazers","contributors_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/contributors","subscribers_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/subscribers","subscription_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/subscription","commits_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/commits{/sha}","git_commits_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/git/commits{/sha}","comments_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/comments{/number}","issue_comment_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/issues/comments{/number}","contents_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/contents/{+path}","compare_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/merges","archive_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/downloads","issues_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/issues{/number}","pulls_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/pulls{/number}","milestones_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/milestones{/number}","notifications_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/labels{/name}","releases_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/releases{/id}","deployments_url":"https://api.github.com/repos/SwissDataScienceCenter/renku/deployments","created_at":"2017-08-21T15:02:23Z","updated_at":"2018-05-28T12:23:54Z","pushed_at":"2018-05-28T12:35:04Z","git_url":"git://github.com/SwissDataScienceCenter/renku.git","ssh_url":"git@github.com:SwissDataScienceCenter/renku.git","clone_url":"https://github.com/SwissDataScienceCenter/renku.git","svn_url":"https://github.com/SwissDataScienceCenter/renku","homepage":"https://datascience.ch/renku-platform/","size":1554,"stargazers_count":24,"watchers_count":24,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":8,"open_issues":33,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SwissDataScienceCenter/renku/pulls/244"},"html":{"href":"https://github.com/SwissDataScienceCenter/renku/pull/244"},"issue":{"href":"https://api.github.com/repos/SwissDataScienceCenter/renku/issues/244"},"comments":{"href":"https://api.github.com/repos/SwissDataScienceCenter/renku/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/SwissDataScienceCenter/renku/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/SwissDataScienceCenter/renku/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SwissDataScienceCenter/renku/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/SwissDataScienceCenter/renku/statuses/5557d2d582d2f0feb7489ebf631e7edabd2d8976"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jirikuncar"}}