{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/jzwart/protoloads/pulls/1","id":186811565,"html_url":"https://github.com/jzwart/protoloads/pull/1","diff_url":"https://github.com/jzwart/protoloads/pull/1.diff","patch_url":"https://github.com/jzwart/protoloads/pull/1.patch","issue_url":"https://api.github.com/repos/jzwart/protoloads/issues/1","number":1,"state":"open","locked":false,"title":"Rough fix to scale_factor problem.","user":{"login":"dblodgett-usgs","id":1492803,"avatar_url":"https://avatars0.githubusercontent.com/u/1492803?v=4","gravatar_id":"","url":"https://api.github.com/users/dblodgett-usgs","html_url":"https://github.com/dblodgett-usgs","followers_url":"https://api.github.com/users/dblodgett-usgs/followers","following_url":"https://api.github.com/users/dblodgett-usgs/following{/other_user}","gists_url":"https://api.github.com/users/dblodgett-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/dblodgett-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblodgett-usgs/subscriptions","organizations_url":"https://api.github.com/users/dblodgett-usgs/orgs","repos_url":"https://api.github.com/users/dblodgett-usgs/repos","events_url":"https://api.github.com/users/dblodgett-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/dblodgett-usgs/received_events","type":"User","site_admin":false},"body":"Couldn't sleep... so applied what I'd been thinking about quick. \r\n\r\nAs I say in the commit message. When I reran all the nwm extractions, the nwm_retro target updates but the operational forecast data doesn't. Turns out the operational forecasts lost their scale_factor along the way some how. I'm looking into that but I don't think I'm really going to be able to fix that without rerunning the extraction script back in Tuscaloosa next week.\r\n\r\nI think this is the best I'm going to be able to do for now, but please take a look and see if this data is more coherent. Feeling more than a little dumb for flubbing the scale_factor stuff so much. I was just thinking about bigger picture stuff and lost track of the details.\r\n\r\nThere's a chance that the forecasts are just very low fidelity -- OK, but missing their scale_factor. I started looking at what the workflow to extract the data does and have a few threads I need to follow. Long story short, what is available now _should_ be whole cubic meters per second as integers. I need to double check a few things and rerun this when I get back to Tuscaloosa. It appears that R is applying the scale factor on read, writing to an integer without applying the scale factor, then a subsequent step is stripping the scale factor attribute off the variable. -- ironically this subsequent step, when I glue the files together along the time dimension (I think), is actually making the data more correct by removing the scale factor. ... I think. This is all I can do for now, hopefully it gives you something to work with.","created_at":"2018-05-09T03:56:04Z","updated_at":"2018-05-09T03:56:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jzwart/protoloads/pulls/1/commits","review_comments_url":"https://api.github.com/repos/jzwart/protoloads/pulls/1/comments","review_comment_url":"https://api.github.com/repos/jzwart/protoloads/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jzwart/protoloads/issues/1/comments","statuses_url":"https://api.github.com/repos/jzwart/protoloads/statuses/ebdc56f8e0167182f3e3320b266757c1c2393531","head":{"label":"dblodgett-usgs:master","ref":"master","sha":"ebdc56f8e0167182f3e3320b266757c1c2393531","user":{"login":"dblodgett-usgs","id":1492803,"avatar_url":"https://avatars0.githubusercontent.com/u/1492803?v=4","gravatar_id":"","url":"https://api.github.com/users/dblodgett-usgs","html_url":"https://github.com/dblodgett-usgs","followers_url":"https://api.github.com/users/dblodgett-usgs/followers","following_url":"https://api.github.com/users/dblodgett-usgs/following{/other_user}","gists_url":"https://api.github.com/users/dblodgett-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/dblodgett-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblodgett-usgs/subscriptions","organizations_url":"https://api.github.com/users/dblodgett-usgs/orgs","repos_url":"https://api.github.com/users/dblodgett-usgs/repos","events_url":"https://api.github.com/users/dblodgett-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/dblodgett-usgs/received_events","type":"User","site_admin":false},"repo":{"id":131764306,"name":"protoloads","full_name":"dblodgett-usgs/protoloads","owner":{"login":"dblodgett-usgs","id":1492803,"avatar_url":"https://avatars0.githubusercontent.com/u/1492803?v=4","gravatar_id":"","url":"https://api.github.com/users/dblodgett-usgs","html_url":"https://github.com/dblodgett-usgs","followers_url":"https://api.github.com/users/dblodgett-usgs/followers","following_url":"https://api.github.com/users/dblodgett-usgs/following{/other_user}","gists_url":"https://api.github.com/users/dblodgett-usgs/gists{/gist_id}","starred_url":"https://api.github.com/users/dblodgett-usgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblodgett-usgs/subscriptions","organizations_url":"https://api.github.com/users/dblodgett-usgs/orgs","repos_url":"https://api.github.com/users/dblodgett-usgs/repos","events_url":"https://api.github.com/users/dblodgett-usgs/events{/privacy}","received_events_url":"https://api.github.com/users/dblodgett-usgs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dblodgett-usgs/protoloads","description":"Prototyping and exploring options for broad-scale load forecasting","fork":true,"url":"https://api.github.com/repos/dblodgett-usgs/protoloads","forks_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/forks","keys_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/teams","hooks_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/hooks","issue_events_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/issues/events{/number}","events_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/events","assignees_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/assignees{/user}","branches_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/branches{/branch}","tags_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/tags","blobs_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/git/refs{/sha}","trees_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/statuses/{sha}","languages_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/languages","stargazers_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/stargazers","contributors_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/contributors","subscribers_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/subscribers","subscription_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/subscription","commits_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/commits{/sha}","git_commits_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/git/commits{/sha}","comments_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/comments{/number}","issue_comment_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/issues/comments{/number}","contents_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/contents/{+path}","compare_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/merges","archive_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/downloads","issues_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/issues{/number}","pulls_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/pulls{/number}","milestones_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/milestones{/number}","notifications_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/labels{/name}","releases_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/releases{/id}","deployments_url":"https://api.github.com/repos/dblodgett-usgs/protoloads/deployments","created_at":"2018-05-01T21:20:17Z","updated_at":"2018-05-09T03:20:05Z","pushed_at":"2018-05-09T03:20:01Z","git_url":"git://github.com/dblodgett-usgs/protoloads.git","ssh_url":"git@github.com:dblodgett-usgs/protoloads.git","clone_url":"https://github.com/dblodgett-usgs/protoloads.git","svn_url":"https://github.com/dblodgett-usgs/protoloads","homepage":null,"size":38,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jzwart:master","ref":"master","sha":"3ebb5181923c8a008667a29455d82c0a7d4af2e6","user":{"login":"jzwart","id":4825431,"avatar_url":"https://avatars2.githubusercontent.com/u/4825431?v=4","gravatar_id":"","url":"https://api.github.com/users/jzwart","html_url":"https://github.com/jzwart","followers_url":"https://api.github.com/users/jzwart/followers","following_url":"https://api.github.com/users/jzwart/following{/other_user}","gists_url":"https://api.github.com/users/jzwart/gists{/gist_id}","starred_url":"https://api.github.com/users/jzwart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzwart/subscriptions","organizations_url":"https://api.github.com/users/jzwart/orgs","repos_url":"https://api.github.com/users/jzwart/repos","events_url":"https://api.github.com/users/jzwart/events{/privacy}","received_events_url":"https://api.github.com/users/jzwart/received_events","type":"User","site_admin":false},"repo":{"id":131661982,"name":"protoloads","full_name":"jzwart/protoloads","owner":{"login":"jzwart","id":4825431,"avatar_url":"https://avatars2.githubusercontent.com/u/4825431?v=4","gravatar_id":"","url":"https://api.github.com/users/jzwart","html_url":"https://github.com/jzwart","followers_url":"https://api.github.com/users/jzwart/followers","following_url":"https://api.github.com/users/jzwart/following{/other_user}","gists_url":"https://api.github.com/users/jzwart/gists{/gist_id}","starred_url":"https://api.github.com/users/jzwart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzwart/subscriptions","organizations_url":"https://api.github.com/users/jzwart/orgs","repos_url":"https://api.github.com/users/jzwart/repos","events_url":"https://api.github.com/users/jzwart/events{/privacy}","received_events_url":"https://api.github.com/users/jzwart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jzwart/protoloads","description":"Prototyping and exploring options for broad-scale load forecasting","fork":true,"url":"https://api.github.com/repos/jzwart/protoloads","forks_url":"https://api.github.com/repos/jzwart/protoloads/forks","keys_url":"https://api.github.com/repos/jzwart/protoloads/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jzwart/protoloads/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jzwart/protoloads/teams","hooks_url":"https://api.github.com/repos/jzwart/protoloads/hooks","issue_events_url":"https://api.github.com/repos/jzwart/protoloads/issues/events{/number}","events_url":"https://api.github.com/repos/jzwart/protoloads/events","assignees_url":"https://api.github.com/repos/jzwart/protoloads/assignees{/user}","branches_url":"https://api.github.com/repos/jzwart/protoloads/branches{/branch}","tags_url":"https://api.github.com/repos/jzwart/protoloads/tags","blobs_url":"https://api.github.com/repos/jzwart/protoloads/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jzwart/protoloads/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jzwart/protoloads/git/refs{/sha}","trees_url":"https://api.github.com/repos/jzwart/protoloads/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jzwart/protoloads/statuses/{sha}","languages_url":"https://api.github.com/repos/jzwart/protoloads/languages","stargazers_url":"https://api.github.com/repos/jzwart/protoloads/stargazers","contributors_url":"https://api.github.com/repos/jzwart/protoloads/contributors","subscribers_url":"https://api.github.com/repos/jzwart/protoloads/subscribers","subscription_url":"https://api.github.com/repos/jzwart/protoloads/subscription","commits_url":"https://api.github.com/repos/jzwart/protoloads/commits{/sha}","git_commits_url":"https://api.github.com/repos/jzwart/protoloads/git/commits{/sha}","comments_url":"https://api.github.com/repos/jzwart/protoloads/comments{/number}","issue_comment_url":"https://api.github.com/repos/jzwart/protoloads/issues/comments{/number}","contents_url":"https://api.github.com/repos/jzwart/protoloads/contents/{+path}","compare_url":"https://api.github.com/repos/jzwart/protoloads/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jzwart/protoloads/merges","archive_url":"https://api.github.com/repos/jzwart/protoloads/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jzwart/protoloads/downloads","issues_url":"https://api.github.com/repos/jzwart/protoloads/issues{/number}","pulls_url":"https://api.github.com/repos/jzwart/protoloads/pulls{/number}","milestones_url":"https://api.github.com/repos/jzwart/protoloads/milestones{/number}","notifications_url":"https://api.github.com/repos/jzwart/protoloads/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jzwart/protoloads/labels{/name}","releases_url":"https://api.github.com/repos/jzwart/protoloads/releases{/id}","deployments_url":"https://api.github.com/repos/jzwart/protoloads/deployments","created_at":"2018-05-01T00:54:28Z","updated_at":"2018-05-08T21:47:09Z","pushed_at":"2018-05-08T21:47:07Z","git_url":"git://github.com/jzwart/protoloads.git","ssh_url":"git@github.com:jzwart/protoloads.git","clone_url":"https://github.com/jzwart/protoloads.git","svn_url":"https://github.com/jzwart/protoloads","homepage":null,"size":54,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jzwart/protoloads/pulls/1"},"html":{"href":"https://github.com/jzwart/protoloads/pull/1"},"issue":{"href":"https://api.github.com/repos/jzwart/protoloads/issues/1"},"comments":{"href":"https://api.github.com/repos/jzwart/protoloads/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/jzwart/protoloads/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/jzwart/protoloads/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jzwart/protoloads/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/jzwart/protoloads/statuses/ebdc56f8e0167182f3e3320b266757c1c2393531"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":179,"deletions":123,"changed_files":10}}
{"actor":{"display_login":"dblodgett-usgs"}}