{"action":"closed","number":166,"pull_request":{"url":"https://api.github.com/repos/sumup/circuit-ui/pulls/166","id":186577095,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg2NTc3MDk1","html_url":"https://github.com/sumup/circuit-ui/pull/166","diff_url":"https://github.com/sumup/circuit-ui/pull/166.diff","patch_url":"https://github.com/sumup/circuit-ui/pull/166.patch","issue_url":"https://api.github.com/repos/sumup/circuit-ui/issues/166","number":166,"state":"closed","locked":false,"title":"Add a build task for distribution","user":{"login":"felixjung","id":265947,"node_id":"MDQ6VXNlcjI2NTk0Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/265947?v=4","gravatar_id":"","url":"https://api.github.com/users/felixjung","html_url":"https://github.com/felixjung","followers_url":"https://api.github.com/users/felixjung/followers","following_url":"https://api.github.com/users/felixjung/following{/other_user}","gists_url":"https://api.github.com/users/felixjung/gists{/gist_id}","starred_url":"https://api.github.com/users/felixjung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixjung/subscriptions","organizations_url":"https://api.github.com/users/felixjung/orgs","repos_url":"https://api.github.com/users/felixjung/repos","events_url":"https://api.github.com/users/felixjung/events{/privacy}","received_events_url":"https://api.github.com/users/felixjung/received_events","type":"User","site_admin":false},"body":"##### Description\r\n\r\nAdds a proper build task that outputs a cjs and a esm bundle for distribution via npm. We use Rollup to create the build as it's the superior bundler for libraries due to better support for tree-shaking and native ES modules.\r\n\r\n##### Changes\r\n- Git-ignore `.node-version` file.\r\n- Add a rollup production build producing ESM and CJS bundles. The symlinks in the project root link to the ESM target files in dist.\r\n- Update to MIT license and change `license` entry package.json (after a survey of all the licenses our dependencies use, this seemed like the right choice).\r\n\r\n##### TODO\r\n\r\n- [x] Fix a bug that causes huge chunks when this is used in a webpack project. It's possible that there are some weird circular dependencies, despite Rollup not detecting any.\r\n- [x] Decide what the different module systems in the dist should actually be.\r\n- [x] Figure out why the snapshot test for buttons is failing and not using the correct classes.\r\n- [ ] Ensure the library is small (i.e., double check what gets bundled).\r\n- [ ] Clean up messages about external dependencies.\r\n- [ ] Check if it would be benefitial to provide individual components by having them as entry points.\r\n- [ ] Set up publishing workflow with versioning etc.","created_at":"2018-05-08T09:32:51Z","updated_at":"2018-08-11T14:43:00Z","closed_at":"2018-08-11T14:43:00Z","merged_at":null,"merge_commit_sha":"f81698d1b70603fe0ac831c1148e0026a07695e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":809259911,"node_id":"MDU6TGFiZWw4MDkyNTk5MTE=","url":"https://api.github.com/repos/sumup/circuit-ui/labels/in%20progress","name":"in progress","color":"FFC859","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sumup/circuit-ui/pulls/166/commits","review_comments_url":"https://api.github.com/repos/sumup/circuit-ui/pulls/166/comments","review_comment_url":"https://api.github.com/repos/sumup/circuit-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sumup/circuit-ui/issues/166/comments","statuses_url":"https://api.github.com/repos/sumup/circuit-ui/statuses/1b36c62c6ffce59991bb6d770fcf7d6c9fb03555","head":{"label":"sumup:tech/production-build","ref":"tech/production-build","sha":"1b36c62c6ffce59991bb6d770fcf7d6c9fb03555","user":{"login":"sumup","id":1194464,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTQ0NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1194464?v=4","gravatar_id":"","url":"https://api.github.com/users/sumup","html_url":"https://github.com/sumup","followers_url":"https://api.github.com/users/sumup/followers","following_url":"https://api.github.com/users/sumup/following{/other_user}","gists_url":"https://api.github.com/users/sumup/gists{/gist_id}","starred_url":"https://api.github.com/users/sumup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumup/subscriptions","organizations_url":"https://api.github.com/users/sumup/orgs","repos_url":"https://api.github.com/users/sumup/repos","events_url":"https://api.github.com/users/sumup/events{/privacy}","received_events_url":"https://api.github.com/users/sumup/received_events","type":"Organization","site_admin":false},"repo":{"id":95433249,"node_id":"MDEwOlJlcG9zaXRvcnk5NTQzMzI0OQ==","name":"circuit-ui","full_name":"sumup/circuit-ui","owner":{"login":"sumup","id":1194464,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTQ0NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1194464?v=4","gravatar_id":"","url":"https://api.github.com/users/sumup","html_url":"https://github.com/sumup","followers_url":"https://api.github.com/users/sumup/followers","following_url":"https://api.github.com/users/sumup/following{/other_user}","gists_url":"https://api.github.com/users/sumup/gists{/gist_id}","starred_url":"https://api.github.com/users/sumup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumup/subscriptions","organizations_url":"https://api.github.com/users/sumup/orgs","repos_url":"https://api.github.com/users/sumup/repos","events_url":"https://api.github.com/users/sumup/events{/privacy}","received_events_url":"https://api.github.com/users/sumup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sumup/circuit-ui","description":"React component library for sumup web apps","fork":false,"url":"https://api.github.com/repos/sumup/circuit-ui","forks_url":"https://api.github.com/repos/sumup/circuit-ui/forks","keys_url":"https://api.github.com/repos/sumup/circuit-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sumup/circuit-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sumup/circuit-ui/teams","hooks_url":"https://api.github.com/repos/sumup/circuit-ui/hooks","issue_events_url":"https://api.github.com/repos/sumup/circuit-ui/issues/events{/number}","events_url":"https://api.github.com/repos/sumup/circuit-ui/events","assignees_url":"https://api.github.com/repos/sumup/circuit-ui/assignees{/user}","branches_url":"https://api.github.com/repos/sumup/circuit-ui/branches{/branch}","tags_url":"https://api.github.com/repos/sumup/circuit-ui/tags","blobs_url":"https://api.github.com/repos/sumup/circuit-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sumup/circuit-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sumup/circuit-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/sumup/circuit-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sumup/circuit-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/sumup/circuit-ui/languages","stargazers_url":"https://api.github.com/repos/sumup/circuit-ui/stargazers","contributors_url":"https://api.github.com/repos/sumup/circuit-ui/contributors","subscribers_url":"https://api.github.com/repos/sumup/circuit-ui/subscribers","subscription_url":"https://api.github.com/repos/sumup/circuit-ui/subscription","commits_url":"https://api.github.com/repos/sumup/circuit-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/sumup/circuit-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/sumup/circuit-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/sumup/circuit-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/sumup/circuit-ui/contents/{+path}","compare_url":"https://api.github.com/repos/sumup/circuit-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sumup/circuit-ui/merges","archive_url":"https://api.github.com/repos/sumup/circuit-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sumup/circuit-ui/downloads","issues_url":"https://api.github.com/repos/sumup/circuit-ui/issues{/number}","pulls_url":"https://api.github.com/repos/sumup/circuit-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/sumup/circuit-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/sumup/circuit-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sumup/circuit-ui/labels{/name}","releases_url":"https://api.github.com/repos/sumup/circuit-ui/releases{/id}","deployments_url":"https://api.github.com/repos/sumup/circuit-ui/deployments","created_at":"2017-06-26T09:57:50Z","updated_at":"2018-08-11T13:13:35Z","pushed_at":"2018-08-11T14:35:24Z","git_url":"git://github.com/sumup/circuit-ui.git","ssh_url":"git@github.com:sumup/circuit-ui.git","clone_url":"https://github.com/sumup/circuit-ui.git","svn_url":"https://github.com/sumup/circuit-ui","homepage":"https://sumup.github.io/circuit-ui/storybook","size":16754,"stargazers_count":81,"watchers_count":81,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":17,"license":null,"forks":10,"open_issues":17,"watchers":81,"default_branch":"master"}},"base":{"label":"sumup:master","ref":"master","sha":"e898315249291922165d3e61499cbce02f93ce9e","user":{"login":"sumup","id":1194464,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTQ0NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1194464?v=4","gravatar_id":"","url":"https://api.github.com/users/sumup","html_url":"https://github.com/sumup","followers_url":"https://api.github.com/users/sumup/followers","following_url":"https://api.github.com/users/sumup/following{/other_user}","gists_url":"https://api.github.com/users/sumup/gists{/gist_id}","starred_url":"https://api.github.com/users/sumup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumup/subscriptions","organizations_url":"https://api.github.com/users/sumup/orgs","repos_url":"https://api.github.com/users/sumup/repos","events_url":"https://api.github.com/users/sumup/events{/privacy}","received_events_url":"https://api.github.com/users/sumup/received_events","type":"Organization","site_admin":false},"repo":{"id":95433249,"node_id":"MDEwOlJlcG9zaXRvcnk5NTQzMzI0OQ==","name":"circuit-ui","full_name":"sumup/circuit-ui","owner":{"login":"sumup","id":1194464,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExOTQ0NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1194464?v=4","gravatar_id":"","url":"https://api.github.com/users/sumup","html_url":"https://github.com/sumup","followers_url":"https://api.github.com/users/sumup/followers","following_url":"https://api.github.com/users/sumup/following{/other_user}","gists_url":"https://api.github.com/users/sumup/gists{/gist_id}","starred_url":"https://api.github.com/users/sumup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumup/subscriptions","organizations_url":"https://api.github.com/users/sumup/orgs","repos_url":"https://api.github.com/users/sumup/repos","events_url":"https://api.github.com/users/sumup/events{/privacy}","received_events_url":"https://api.github.com/users/sumup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sumup/circuit-ui","description":"React component library for sumup web apps","fork":false,"url":"https://api.github.com/repos/sumup/circuit-ui","forks_url":"https://api.github.com/repos/sumup/circuit-ui/forks","keys_url":"https://api.github.com/repos/sumup/circuit-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sumup/circuit-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sumup/circuit-ui/teams","hooks_url":"https://api.github.com/repos/sumup/circuit-ui/hooks","issue_events_url":"https://api.github.com/repos/sumup/circuit-ui/issues/events{/number}","events_url":"https://api.github.com/repos/sumup/circuit-ui/events","assignees_url":"https://api.github.com/repos/sumup/circuit-ui/assignees{/user}","branches_url":"https://api.github.com/repos/sumup/circuit-ui/branches{/branch}","tags_url":"https://api.github.com/repos/sumup/circuit-ui/tags","blobs_url":"https://api.github.com/repos/sumup/circuit-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sumup/circuit-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sumup/circuit-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/sumup/circuit-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sumup/circuit-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/sumup/circuit-ui/languages","stargazers_url":"https://api.github.com/repos/sumup/circuit-ui/stargazers","contributors_url":"https://api.github.com/repos/sumup/circuit-ui/contributors","subscribers_url":"https://api.github.com/repos/sumup/circuit-ui/subscribers","subscription_url":"https://api.github.com/repos/sumup/circuit-ui/subscription","commits_url":"https://api.github.com/repos/sumup/circuit-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/sumup/circuit-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/sumup/circuit-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/sumup/circuit-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/sumup/circuit-ui/contents/{+path}","compare_url":"https://api.github.com/repos/sumup/circuit-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sumup/circuit-ui/merges","archive_url":"https://api.github.com/repos/sumup/circuit-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sumup/circuit-ui/downloads","issues_url":"https://api.github.com/repos/sumup/circuit-ui/issues{/number}","pulls_url":"https://api.github.com/repos/sumup/circuit-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/sumup/circuit-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/sumup/circuit-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sumup/circuit-ui/labels{/name}","releases_url":"https://api.github.com/repos/sumup/circuit-ui/releases{/id}","deployments_url":"https://api.github.com/repos/sumup/circuit-ui/deployments","created_at":"2017-06-26T09:57:50Z","updated_at":"2018-08-11T13:13:35Z","pushed_at":"2018-08-11T14:35:24Z","git_url":"git://github.com/sumup/circuit-ui.git","ssh_url":"git@github.com:sumup/circuit-ui.git","clone_url":"https://github.com/sumup/circuit-ui.git","svn_url":"https://github.com/sumup/circuit-ui","homepage":"https://sumup.github.io/circuit-ui/storybook","size":16754,"stargazers_count":81,"watchers_count":81,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":17,"license":null,"forks":10,"open_issues":17,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/166"},"html":{"href":"https://github.com/sumup/circuit-ui/pull/166"},"issue":{"href":"https://api.github.com/repos/sumup/circuit-ui/issues/166"},"comments":{"href":"https://api.github.com/repos/sumup/circuit-ui/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/sumup/circuit-ui/statuses/1b36c62c6ffce59991bb6d770fcf7d6c9fb03555"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":34,"additions":630,"deletions":88,"changed_files":69}}
{"actor":{"display_login":"mlent"}}