{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71854","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71854/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71854/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71854/events","html_url":"https://github.com/kubernetes/kubernetes/pull/71854","id":388752895,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2OTQ1NDU2","number":71854,"title":"apply: fix detection of non-dry-run enabled servers","user":{"login":"apelisse","id":1929644,"node_id":"MDQ6VXNlcjE5Mjk2NDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1929644?v=4","gravatar_id":"","url":"https://api.github.com/users/apelisse","html_url":"https://github.com/apelisse","followers_url":"https://api.github.com/users/apelisse/followers","following_url":"https://api.github.com/users/apelisse/following{/other_user}","gists_url":"https://api.github.com/users/apelisse/gists{/gist_id}","starred_url":"https://api.github.com/users/apelisse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apelisse/subscriptions","organizations_url":"https://api.github.com/users/apelisse/orgs","repos_url":"https://api.github.com/users/apelisse/repos","events_url":"https://api.github.com/users/apelisse/events{/privacy}","received_events_url":"https://api.github.com/users/apelisse/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"node_id":"MDU6TGFiZWw0MTQ4ODM5ODI=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":138247961,"node_id":"MDU6TGFiZWwxMzgyNDc5NjE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubectl","name":"area/kubectl","color":"0052cc","default":false},{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":148225179,"node_id":"MDU6TGFiZWwxNDgyMjUxNzk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":114528068,"node_id":"MDU6TGFiZWwxMTQ1MjgwNjg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/critical-urgent","name":"priority/critical-urgent","color":"e11d21","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":450823910,"node_id":"MDU6TGFiZWw0NTA4MjM5MTA=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cli","name":"sig/cli","color":"d2b48c","default":false},{"id":253450895,"node_id":"MDU6TGFiZWwyNTM0NTA4OTU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"seans3","id":7387162,"node_id":"MDQ6VXNlcjczODcxNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/7387162?v=4","gravatar_id":"","url":"https://api.github.com/users/seans3","html_url":"https://github.com/seans3","followers_url":"https://api.github.com/users/seans3/followers","following_url":"https://api.github.com/users/seans3/following{/other_user}","gists_url":"https://api.github.com/users/seans3/gists{/gist_id}","starred_url":"https://api.github.com/users/seans3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seans3/subscriptions","organizations_url":"https://api.github.com/users/seans3/orgs","repos_url":"https://api.github.com/users/seans3/repos","events_url":"https://api.github.com/users/seans3/events{/privacy}","received_events_url":"https://api.github.com/users/seans3/received_events","type":"User","site_admin":false},"assignees":[{"login":"seans3","id":7387162,"node_id":"MDQ6VXNlcjczODcxNjI=","avatar_url":"https://avatars3.githubusercontent.com/u/7387162?v=4","gravatar_id":"","url":"https://api.github.com/users/seans3","html_url":"https://github.com/seans3","followers_url":"https://api.github.com/users/seans3/followers","following_url":"https://api.github.com/users/seans3/following{/other_user}","gists_url":"https://api.github.com/users/seans3/gists{/gist_id}","starred_url":"https://api.github.com/users/seans3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seans3/subscriptions","organizations_url":"https://api.github.com/users/seans3/orgs","repos_url":"https://api.github.com/users/seans3/repos","events_url":"https://api.github.com/users/seans3/events{/privacy}","received_events_url":"https://api.github.com/users/seans3/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-12-07T17:49:22Z","updated_at":"2018-12-07T18:48:07Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/71854","html_url":"https://github.com/kubernetes/kubernetes/pull/71854","diff_url":"https://github.com/kubernetes/kubernetes/pull/71854.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/71854.patch"},"body":"Apply only checks that the server supports dry-run in the create path,\r\nnot the update path, which is pretty bad.\r\n\r\n**What type of PR is this?**\r\n> Uncomment only one, leave it on its own line:\r\n/kind bug\r\n\r\n**What this PR does / why we need it**:\r\nFixes a bug where apply forgets to check if the server supports dry-run\r\n\r\n**Which issue(s) this PR fixes**:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n<!--  \r\nIf no, just write \"NONE\".\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. \r\n-->\r\n```release-note\r\napply: fix detection of non-dry-run enabled servers\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/445328074","html_url":"https://github.com/kubernetes/kubernetes/pull/71854#issuecomment-445328074","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71854","id":445328074,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTMyODA3NA==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-12-07T18:48:07Z","updated_at":"2018-12-07T18:48:07Z","author_association":"CONTRIBUTOR","body":"@apelisse: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-verify | 68ad459739bd5b7d79c732b7ed985a1d4c07d54f | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/71854/pull-kubernetes-verify/115950/) | `/test pull-kubernetes-verify`\npull-kubernetes-e2e-kops-aws | 68ad459739bd5b7d79c732b7ed985a1d4c07d54f | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/71854/pull-kubernetes-e2e-kops-aws/116115/) | `/test pull-kubernetes-e2e-kops-aws`\n\n[Full PR test history](https://gubernator.k8s.io/pr/71854). [Your PR dashboard](https://gubernator.k8s.io/pr/apelisse). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}