{"action":"created","comment":{"url":"https://api.github.com/repos/guardian/mobile-n10n/pulls/comments/230727341","pull_request_review_id":171524657,"id":230727341,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDcyNzM0MQ==","diff_hunk":"@@ -8,16 +8,18 @@ import scala.concurrent.duration.DurationLong\n \n class ReportTopicRegistrationCounter(\n   ws: WSClient,\n-  registrationCounterUrl: String\n+  reportUrl: String,\n+  apiKey: String\n )(implicit ec: ExecutionContext) extends TopicRegistrationCounter {\n \n   val lruCache: LruCache[PlatformCount] = new LruCache[PlatformCount](200, 1000, 3.days)\n \n   override def count(topics: List[Topic]): Future[PlatformCount] = {\n     lruCache(topics.toSet) {\n       val topicParameters = topics.map(topic => \"topics\" -> topic.toString)\n-      ws.url(registrationCounterUrl)\n-        .withQueryStringParameters(topicParameters: _*)\n+      val allParams = topicParameters ++ List(\"api-key\" -> apiKey)","path":"notification/app/notification/services/guardian/ReportTopicRegistrationCounter.scala","position":16,"original_position":16,"commit_id":"81a0f5e95b75812da600dbf3783b42c061766eeb","original_commit_id":"81a0f5e95b75812da600dbf3783b42c061766eeb","user":{"login":"TBonnin","id":233326,"node_id":"MDQ6VXNlcjIzMzMyNg==","avatar_url":"https://avatars2.githubusercontent.com/u/233326?v=4","gravatar_id":"","url":"https://api.github.com/users/TBonnin","html_url":"https://github.com/TBonnin","followers_url":"https://api.github.com/users/TBonnin/followers","following_url":"https://api.github.com/users/TBonnin/following{/other_user}","gists_url":"https://api.github.com/users/TBonnin/gists{/gist_id}","starred_url":"https://api.github.com/users/TBonnin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TBonnin/subscriptions","organizations_url":"https://api.github.com/users/TBonnin/orgs","repos_url":"https://api.github.com/users/TBonnin/repos","events_url":"https://api.github.com/users/TBonnin/events{/privacy}","received_events_url":"https://api.github.com/users/TBonnin/received_events","type":"User","site_admin":false},"body":"can you not append a single tuple: `val allParams = topicParameters :+ (\"api-key\" -> apiKey)`","created_at":"2018-11-05T12:08:54Z","updated_at":"2018-11-05T12:10:03Z","html_url":"https://github.com/guardian/mobile-n10n/pull/234#discussion_r230727341","pull_request_url":"https://api.github.com/repos/guardian/mobile-n10n/pulls/234","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/guardian/mobile-n10n/pulls/comments/230727341"},"html":{"href":"https://github.com/guardian/mobile-n10n/pull/234#discussion_r230727341"},"pull_request":{"href":"https://api.github.com/repos/guardian/mobile-n10n/pulls/234"}}},"pull_request":{"url":"https://api.github.com/repos/guardian/mobile-n10n/pulls/234","id":227699009,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Njk5MDA5","html_url":"https://github.com/guardian/mobile-n10n/pull/234","diff_url":"https://github.com/guardian/mobile-n10n/pull/234.diff","patch_url":"https://github.com/guardian/mobile-n10n/pull/234.patch","issue_url":"https://api.github.com/repos/guardian/mobile-n10n/issues/234","number":234,"state":"open","locked":false,"title":"Wire notification to sqs","user":{"login":"alexduf","id":3389563,"node_id":"MDQ6VXNlcjMzODk1NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/3389563?v=4","gravatar_id":"","url":"https://api.github.com/users/alexduf","html_url":"https://github.com/alexduf","followers_url":"https://api.github.com/users/alexduf/followers","following_url":"https://api.github.com/users/alexduf/following{/other_user}","gists_url":"https://api.github.com/users/alexduf/gists{/gist_id}","starred_url":"https://api.github.com/users/alexduf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexduf/subscriptions","organizations_url":"https://api.github.com/users/alexduf/orgs","repos_url":"https://api.github.com/users/alexduf/repos","events_url":"https://api.github.com/users/alexduf/events{/privacy}","received_events_url":"https://api.github.com/users/alexduf/received_events","type":"User","site_admin":false},"body":"**This should not be merged until** `create-workers-resources` **is merged**\r\n\r\nThis wires the code that writes to the SQS queues, and also implements a flip/flop filter that decides where to send the notification","created_at":"2018-11-01T17:35:45Z","updated_at":"2018-11-05T12:10:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26ac08536d382493259e01f6c70a04f9892103e4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/guardian/mobile-n10n/pulls/234/commits","review_comments_url":"https://api.github.com/repos/guardian/mobile-n10n/pulls/234/comments","review_comment_url":"https://api.github.com/repos/guardian/mobile-n10n/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/mobile-n10n/issues/234/comments","statuses_url":"https://api.github.com/repos/guardian/mobile-n10n/statuses/81a0f5e95b75812da600dbf3783b42c061766eeb","head":{"label":"guardian:wire-notification-to-sqs","ref":"wire-notification-to-sqs","sha":"81a0f5e95b75812da600dbf3783b42c061766eeb","user":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":42113608,"node_id":"MDEwOlJlcG9zaXRvcnk0MjExMzYwOA==","name":"mobile-n10n","full_name":"guardian/mobile-n10n","private":false,"owner":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/guardian/mobile-n10n","description":null,"fork":false,"url":"https://api.github.com/repos/guardian/mobile-n10n","forks_url":"https://api.github.com/repos/guardian/mobile-n10n/forks","keys_url":"https://api.github.com/repos/guardian/mobile-n10n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/mobile-n10n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/mobile-n10n/teams","hooks_url":"https://api.github.com/repos/guardian/mobile-n10n/hooks","issue_events_url":"https://api.github.com/repos/guardian/mobile-n10n/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/mobile-n10n/events","assignees_url":"https://api.github.com/repos/guardian/mobile-n10n/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/mobile-n10n/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/mobile-n10n/tags","blobs_url":"https://api.github.com/repos/guardian/mobile-n10n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/mobile-n10n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/mobile-n10n/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/mobile-n10n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/mobile-n10n/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/mobile-n10n/languages","stargazers_url":"https://api.github.com/repos/guardian/mobile-n10n/stargazers","contributors_url":"https://api.github.com/repos/guardian/mobile-n10n/contributors","subscribers_url":"https://api.github.com/repos/guardian/mobile-n10n/subscribers","subscription_url":"https://api.github.com/repos/guardian/mobile-n10n/subscription","commits_url":"https://api.github.com/repos/guardian/mobile-n10n/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/mobile-n10n/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/mobile-n10n/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/mobile-n10n/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/mobile-n10n/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/mobile-n10n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/mobile-n10n/merges","archive_url":"https://api.github.com/repos/guardian/mobile-n10n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/mobile-n10n/downloads","issues_url":"https://api.github.com/repos/guardian/mobile-n10n/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/mobile-n10n/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/mobile-n10n/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/mobile-n10n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/mobile-n10n/labels{/name}","releases_url":"https://api.github.com/repos/guardian/mobile-n10n/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/mobile-n10n/deployments","created_at":"2015-09-08T13:24:20Z","updated_at":"2018-11-05T11:16:34Z","pushed_at":"2018-11-05T11:56:38Z","git_url":"git://github.com/guardian/mobile-n10n.git","ssh_url":"git@github.com:guardian/mobile-n10n.git","clone_url":"https://github.com/guardian/mobile-n10n.git","svn_url":"https://github.com/guardian/mobile-n10n","homepage":"","size":2364,"stargazers_count":7,"watchers_count":7,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":2,"watchers":7,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"08539606bf58e1be385e8d8c812febf2e3be816c","user":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":42113608,"node_id":"MDEwOlJlcG9zaXRvcnk0MjExMzYwOA==","name":"mobile-n10n","full_name":"guardian/mobile-n10n","private":false,"owner":{"login":"guardian","id":164318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/164318?v=4","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/guardian/mobile-n10n","description":null,"fork":false,"url":"https://api.github.com/repos/guardian/mobile-n10n","forks_url":"https://api.github.com/repos/guardian/mobile-n10n/forks","keys_url":"https://api.github.com/repos/guardian/mobile-n10n/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/mobile-n10n/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/mobile-n10n/teams","hooks_url":"https://api.github.com/repos/guardian/mobile-n10n/hooks","issue_events_url":"https://api.github.com/repos/guardian/mobile-n10n/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/mobile-n10n/events","assignees_url":"https://api.github.com/repos/guardian/mobile-n10n/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/mobile-n10n/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/mobile-n10n/tags","blobs_url":"https://api.github.com/repos/guardian/mobile-n10n/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/mobile-n10n/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/mobile-n10n/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/mobile-n10n/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/mobile-n10n/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/mobile-n10n/languages","stargazers_url":"https://api.github.com/repos/guardian/mobile-n10n/stargazers","contributors_url":"https://api.github.com/repos/guardian/mobile-n10n/contributors","subscribers_url":"https://api.github.com/repos/guardian/mobile-n10n/subscribers","subscription_url":"https://api.github.com/repos/guardian/mobile-n10n/subscription","commits_url":"https://api.github.com/repos/guardian/mobile-n10n/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/mobile-n10n/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/mobile-n10n/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/mobile-n10n/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/mobile-n10n/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/mobile-n10n/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/mobile-n10n/merges","archive_url":"https://api.github.com/repos/guardian/mobile-n10n/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/mobile-n10n/downloads","issues_url":"https://api.github.com/repos/guardian/mobile-n10n/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/mobile-n10n/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/mobile-n10n/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/mobile-n10n/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/mobile-n10n/labels{/name}","releases_url":"https://api.github.com/repos/guardian/mobile-n10n/releases{/id}","deployments_url":"https://api.github.com/repos/guardian/mobile-n10n/deployments","created_at":"2015-09-08T13:24:20Z","updated_at":"2018-11-05T11:16:34Z","pushed_at":"2018-11-05T11:56:38Z","git_url":"git://github.com/guardian/mobile-n10n.git","ssh_url":"git@github.com:guardian/mobile-n10n.git","clone_url":"https://github.com/guardian/mobile-n10n.git","svn_url":"https://github.com/guardian/mobile-n10n","homepage":"","size":2364,"stargazers_count":7,"watchers_count":7,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/mobile-n10n/pulls/234"},"html":{"href":"https://github.com/guardian/mobile-n10n/pull/234"},"issue":{"href":"https://api.github.com/repos/guardian/mobile-n10n/issues/234"},"comments":{"href":"https://api.github.com/repos/guardian/mobile-n10n/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/mobile-n10n/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/mobile-n10n/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/mobile-n10n/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/mobile-n10n/statuses/81a0f5e95b75812da600dbf3783b42c061766eeb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TBonnin"}}