{"action":"created","comment":{"url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments/182489267","pull_request_review_id":113291597,"id":182489267,"diff_hunk":"@@ -2206,13 +2210,13 @@ def depart_literal_strong(self, node):\n     def visit_abbreviation(self, node):\n         # type: (nodes.Node) -> None\n         abbr = node.astext()\n-        self.body.append(r'\\sphinxstyleabbreviation{')\n-        # spell out the explanation once\n-        if node.hasattr('explanation') and abbr not in self.handled_abbrs:\n-            self.context.append('} (%s)' % self.encode(node['explanation']))\n-            self.handled_abbrs.add(abbr)\n+        if node.hasattr('explanation'):\n+            self.body.append(r'\\gls{')\n+            self.abbr.add('\\\\newacronym{' + abbr + '}{' + abbr + '}{' +\n+                    node['explanation'] + '}\\n')","path":"sphinx/writers/latex.py","position":60,"original_position":60,"commit_id":"22d85257358dcd6d6bcae2f17283cc37902f7d39","original_commit_id":"22d85257358dcd6d6bcae2f17283cc37902f7d39","user":{"login":"jfbu","id":2589111,"avatar_url":"https://avatars0.githubusercontent.com/u/2589111?v=4","gravatar_id":"","url":"https://api.github.com/users/jfbu","html_url":"https://github.com/jfbu","followers_url":"https://api.github.com/users/jfbu/followers","following_url":"https://api.github.com/users/jfbu/following{/other_user}","gists_url":"https://api.github.com/users/jfbu/gists{/gist_id}","starred_url":"https://api.github.com/users/jfbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfbu/subscriptions","organizations_url":"https://api.github.com/users/jfbu/orgs","repos_url":"https://api.github.com/users/jfbu/repos","events_url":"https://api.github.com/users/jfbu/events{/privacy}","received_events_url":"https://api.github.com/users/jfbu/received_events","type":"User","site_admin":false},"body":"in case input has duplicated possibly diverging explanations, the original code stored only the first explanation ; here it seems ``\\newacronym` will be inserted in LaTeX multiple times in such cases. This does not cause problem? ","created_at":"2018-04-18T16:26:04Z","updated_at":"2018-04-18T16:27:16Z","html_url":"https://github.com/sphinx-doc/sphinx/pull/4861#discussion_r182489267","pull_request_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/4861","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments/182489267"},"html":{"href":"https://github.com/sphinx-doc/sphinx/pull/4861#discussion_r182489267"},"pull_request":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/4861"}},"in_reply_to_id":182486307},"pull_request":{"url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/4861","id":182404278,"html_url":"https://github.com/sphinx-doc/sphinx/pull/4861","diff_url":"https://github.com/sphinx-doc/sphinx/pull/4861.diff","patch_url":"https://github.com/sphinx-doc/sphinx/pull/4861.patch","issue_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/4861","number":4861,"state":"open","locked":false,"title":"Add support for list of abbreviations to LaTeX builder","user":{"login":"sephalon","id":893474,"avatar_url":"https://avatars0.githubusercontent.com/u/893474?v=4","gravatar_id":"","url":"https://api.github.com/users/sephalon","html_url":"https://github.com/sephalon","followers_url":"https://api.github.com/users/sephalon/followers","following_url":"https://api.github.com/users/sephalon/following{/other_user}","gists_url":"https://api.github.com/users/sephalon/gists{/gist_id}","starred_url":"https://api.github.com/users/sephalon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sephalon/subscriptions","organizations_url":"https://api.github.com/users/sephalon/orgs","repos_url":"https://api.github.com/users/sephalon/repos","events_url":"https://api.github.com/users/sephalon/events{/privacy}","received_events_url":"https://api.github.com/users/sephalon/received_events","type":"User","site_admin":false},"body":"Subject: Add support for list of abbreviations to LaTeX builder\r\n\r\n### Feature or Bugfix\r\n- Feature\r\n\r\n\r\n### Purpose\r\nAdds support for generating a list of abbreviations as well as cross-references in the LaTeX builder. All the heavy-lifting is done by the LaTeX ``glossaries`` package, not internally in Sphinx.\r\n\r\nAs index creation is already been done by LaTeX packages, I think it is only logical to use existing, well-tested tooling for creating acronyms and not reinvent the wheel in Sphinx. Therefore I'd also like to propose handling glossaries in the same way.","created_at":"2018-04-18T08:34:19Z","updated_at":"2018-04-18T16:27:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14ebe6e1712fa763365a97bb3186fc6113aed87a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/4861/commits","review_comments_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/4861/comments","review_comment_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/4861/comments","statuses_url":"https://api.github.com/repos/sphinx-doc/sphinx/statuses/22d85257358dcd6d6bcae2f17283cc37902f7d39","head":{"label":"sephalon:latex_abbreviation_list","ref":"latex_abbreviation_list","sha":"22d85257358dcd6d6bcae2f17283cc37902f7d39","user":{"login":"sephalon","id":893474,"avatar_url":"https://avatars0.githubusercontent.com/u/893474?v=4","gravatar_id":"","url":"https://api.github.com/users/sephalon","html_url":"https://github.com/sephalon","followers_url":"https://api.github.com/users/sephalon/followers","following_url":"https://api.github.com/users/sephalon/following{/other_user}","gists_url":"https://api.github.com/users/sephalon/gists{/gist_id}","starred_url":"https://api.github.com/users/sephalon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sephalon/subscriptions","organizations_url":"https://api.github.com/users/sephalon/orgs","repos_url":"https://api.github.com/users/sephalon/repos","events_url":"https://api.github.com/users/sephalon/events{/privacy}","received_events_url":"https://api.github.com/users/sephalon/received_events","type":"User","site_admin":false},"repo":{"id":116137406,"name":"sphinx","full_name":"sephalon/sphinx","owner":{"login":"sephalon","id":893474,"avatar_url":"https://avatars0.githubusercontent.com/u/893474?v=4","gravatar_id":"","url":"https://api.github.com/users/sephalon","html_url":"https://github.com/sephalon","followers_url":"https://api.github.com/users/sephalon/followers","following_url":"https://api.github.com/users/sephalon/following{/other_user}","gists_url":"https://api.github.com/users/sephalon/gists{/gist_id}","starred_url":"https://api.github.com/users/sephalon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sephalon/subscriptions","organizations_url":"https://api.github.com/users/sephalon/orgs","repos_url":"https://api.github.com/users/sephalon/repos","events_url":"https://api.github.com/users/sephalon/events{/privacy}","received_events_url":"https://api.github.com/users/sephalon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sephalon/sphinx","description":"Main repository for the Sphinx documentation builder","fork":true,"url":"https://api.github.com/repos/sephalon/sphinx","forks_url":"https://api.github.com/repos/sephalon/sphinx/forks","keys_url":"https://api.github.com/repos/sephalon/sphinx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sephalon/sphinx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sephalon/sphinx/teams","hooks_url":"https://api.github.com/repos/sephalon/sphinx/hooks","issue_events_url":"https://api.github.com/repos/sephalon/sphinx/issues/events{/number}","events_url":"https://api.github.com/repos/sephalon/sphinx/events","assignees_url":"https://api.github.com/repos/sephalon/sphinx/assignees{/user}","branches_url":"https://api.github.com/repos/sephalon/sphinx/branches{/branch}","tags_url":"https://api.github.com/repos/sephalon/sphinx/tags","blobs_url":"https://api.github.com/repos/sephalon/sphinx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sephalon/sphinx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sephalon/sphinx/git/refs{/sha}","trees_url":"https://api.github.com/repos/sephalon/sphinx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sephalon/sphinx/statuses/{sha}","languages_url":"https://api.github.com/repos/sephalon/sphinx/languages","stargazers_url":"https://api.github.com/repos/sephalon/sphinx/stargazers","contributors_url":"https://api.github.com/repos/sephalon/sphinx/contributors","subscribers_url":"https://api.github.com/repos/sephalon/sphinx/subscribers","subscription_url":"https://api.github.com/repos/sephalon/sphinx/subscription","commits_url":"https://api.github.com/repos/sephalon/sphinx/commits{/sha}","git_commits_url":"https://api.github.com/repos/sephalon/sphinx/git/commits{/sha}","comments_url":"https://api.github.com/repos/sephalon/sphinx/comments{/number}","issue_comment_url":"https://api.github.com/repos/sephalon/sphinx/issues/comments{/number}","contents_url":"https://api.github.com/repos/sephalon/sphinx/contents/{+path}","compare_url":"https://api.github.com/repos/sephalon/sphinx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sephalon/sphinx/merges","archive_url":"https://api.github.com/repos/sephalon/sphinx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sephalon/sphinx/downloads","issues_url":"https://api.github.com/repos/sephalon/sphinx/issues{/number}","pulls_url":"https://api.github.com/repos/sephalon/sphinx/pulls{/number}","milestones_url":"https://api.github.com/repos/sephalon/sphinx/milestones{/number}","notifications_url":"https://api.github.com/repos/sephalon/sphinx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sephalon/sphinx/labels{/name}","releases_url":"https://api.github.com/repos/sephalon/sphinx/releases{/id}","deployments_url":"https://api.github.com/repos/sephalon/sphinx/deployments","created_at":"2018-01-03T13:02:01Z","updated_at":"2018-01-03T13:02:06Z","pushed_at":"2018-04-18T08:17:44Z","git_url":"git://github.com/sephalon/sphinx.git","ssh_url":"git@github.com:sephalon/sphinx.git","clone_url":"https://github.com/sephalon/sphinx.git","svn_url":"https://github.com/sephalon/sphinx","homepage":"http://sphinx-doc.org","size":26585,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sphinx-doc:master","ref":"master","sha":"96c5605374135652cf7ec0ad517b532b9261ef19","user":{"login":"sphinx-doc","id":9928167,"avatar_url":"https://avatars2.githubusercontent.com/u/9928167?v=4","gravatar_id":"","url":"https://api.github.com/users/sphinx-doc","html_url":"https://github.com/sphinx-doc","followers_url":"https://api.github.com/users/sphinx-doc/followers","following_url":"https://api.github.com/users/sphinx-doc/following{/other_user}","gists_url":"https://api.github.com/users/sphinx-doc/gists{/gist_id}","starred_url":"https://api.github.com/users/sphinx-doc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphinx-doc/subscriptions","organizations_url":"https://api.github.com/users/sphinx-doc/orgs","repos_url":"https://api.github.com/users/sphinx-doc/repos","events_url":"https://api.github.com/users/sphinx-doc/events{/privacy}","received_events_url":"https://api.github.com/users/sphinx-doc/received_events","type":"Organization","site_admin":false},"repo":{"id":28710753,"name":"sphinx","full_name":"sphinx-doc/sphinx","owner":{"login":"sphinx-doc","id":9928167,"avatar_url":"https://avatars2.githubusercontent.com/u/9928167?v=4","gravatar_id":"","url":"https://api.github.com/users/sphinx-doc","html_url":"https://github.com/sphinx-doc","followers_url":"https://api.github.com/users/sphinx-doc/followers","following_url":"https://api.github.com/users/sphinx-doc/following{/other_user}","gists_url":"https://api.github.com/users/sphinx-doc/gists{/gist_id}","starred_url":"https://api.github.com/users/sphinx-doc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphinx-doc/subscriptions","organizations_url":"https://api.github.com/users/sphinx-doc/orgs","repos_url":"https://api.github.com/users/sphinx-doc/repos","events_url":"https://api.github.com/users/sphinx-doc/events{/privacy}","received_events_url":"https://api.github.com/users/sphinx-doc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sphinx-doc/sphinx","description":"Main repository for the Sphinx documentation builder","fork":false,"url":"https://api.github.com/repos/sphinx-doc/sphinx","forks_url":"https://api.github.com/repos/sphinx-doc/sphinx/forks","keys_url":"https://api.github.com/repos/sphinx-doc/sphinx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sphinx-doc/sphinx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sphinx-doc/sphinx/teams","hooks_url":"https://api.github.com/repos/sphinx-doc/sphinx/hooks","issue_events_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/events{/number}","events_url":"https://api.github.com/repos/sphinx-doc/sphinx/events","assignees_url":"https://api.github.com/repos/sphinx-doc/sphinx/assignees{/user}","branches_url":"https://api.github.com/repos/sphinx-doc/sphinx/branches{/branch}","tags_url":"https://api.github.com/repos/sphinx-doc/sphinx/tags","blobs_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/refs{/sha}","trees_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sphinx-doc/sphinx/statuses/{sha}","languages_url":"https://api.github.com/repos/sphinx-doc/sphinx/languages","stargazers_url":"https://api.github.com/repos/sphinx-doc/sphinx/stargazers","contributors_url":"https://api.github.com/repos/sphinx-doc/sphinx/contributors","subscribers_url":"https://api.github.com/repos/sphinx-doc/sphinx/subscribers","subscription_url":"https://api.github.com/repos/sphinx-doc/sphinx/subscription","commits_url":"https://api.github.com/repos/sphinx-doc/sphinx/commits{/sha}","git_commits_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/commits{/sha}","comments_url":"https://api.github.com/repos/sphinx-doc/sphinx/comments{/number}","issue_comment_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/comments{/number}","contents_url":"https://api.github.com/repos/sphinx-doc/sphinx/contents/{+path}","compare_url":"https://api.github.com/repos/sphinx-doc/sphinx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sphinx-doc/sphinx/merges","archive_url":"https://api.github.com/repos/sphinx-doc/sphinx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sphinx-doc/sphinx/downloads","issues_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues{/number}","pulls_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls{/number}","milestones_url":"https://api.github.com/repos/sphinx-doc/sphinx/milestones{/number}","notifications_url":"https://api.github.com/repos/sphinx-doc/sphinx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sphinx-doc/sphinx/labels{/name}","releases_url":"https://api.github.com/repos/sphinx-doc/sphinx/releases{/id}","deployments_url":"https://api.github.com/repos/sphinx-doc/sphinx/deployments","created_at":"2015-01-02T10:53:28Z","updated_at":"2018-04-18T14:28:51Z","pushed_at":"2018-04-18T08:34:19Z","git_url":"git://github.com/sphinx-doc/sphinx.git","ssh_url":"git@github.com:sphinx-doc/sphinx.git","clone_url":"https://github.com/sphinx-doc/sphinx.git","svn_url":"https://github.com/sphinx-doc/sphinx","homepage":"http://sphinx-doc.org","size":28833,"stargazers_count":1805,"watchers_count":1805,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":761,"mirror_url":null,"archived":false,"open_issues_count":683,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":761,"open_issues":683,"watchers":1805,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/4861"},"html":{"href":"https://github.com/sphinx-doc/sphinx/pull/4861"},"issue":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/issues/4861"},"comments":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/issues/4861/comments"},"review_comments":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/4861/comments"},"review_comment":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/4861/commits"},"statuses":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/statuses/22d85257358dcd6d6bcae2f17283cc37902f7d39"}},"author_association":"NONE"}}
{"actor":{"display_login":"jfbu"}}