{"action":"created","issue":{"url":"https://api.github.com/repos/trezor/trezor-core/issues/140","repository_url":"https://api.github.com/repos/trezor/trezor-core","labels_url":"https://api.github.com/repos/trezor/trezor-core/issues/140/labels{/name}","comments_url":"https://api.github.com/repos/trezor/trezor-core/issues/140/comments","events_url":"https://api.github.com/repos/trezor/trezor-core/issues/140/events","html_url":"https://github.com/trezor/trezor-core/pull/140","id":302124221,"number":140,"title":"Wanchain support in trezor-core","user":{"login":"tyrion70","id":4341712,"avatar_url":"https://avatars3.githubusercontent.com/u/4341712?v=4","gravatar_id":"","url":"https://api.github.com/users/tyrion70","html_url":"https://github.com/tyrion70","followers_url":"https://api.github.com/users/tyrion70/followers","following_url":"https://api.github.com/users/tyrion70/following{/other_user}","gists_url":"https://api.github.com/users/tyrion70/gists{/gist_id}","starred_url":"https://api.github.com/users/tyrion70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyrion70/subscriptions","organizations_url":"https://api.github.com/users/tyrion70/orgs","repos_url":"https://api.github.com/users/tyrion70/repos","events_url":"https://api.github.com/users/tyrion70/events{/privacy}","received_events_url":"https://api.github.com/users/tyrion70/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-04T21:31:06Z","updated_at":"2018-03-05T10:46:10Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/trezor/trezor-core/pulls/140","html_url":"https://github.com/trezor/trezor-core/pull/140","diff_url":"https://github.com/trezor/trezor-core/pull/140.diff","patch_url":"https://github.com/trezor/trezor-core/pull/140.patch"},"body":"Added wanchain_sign_tx function and WanchainSignTx message. Tried to do it with as less duplication as possible. Because there is an extra field in the beginning of the message (txtype) I couldn't modify EthereumSignTx and had to create a new message and some functions."},"comment":{"url":"https://api.github.com/repos/trezor/trezor-core/issues/comments/370380591","html_url":"https://github.com/trezor/trezor-core/pull/140#issuecomment-370380591","issue_url":"https://api.github.com/repos/trezor/trezor-core/issues/140","id":370380591,"user":{"login":"jhoenicke","id":897826,"avatar_url":"https://avatars1.githubusercontent.com/u/897826?v=4","gravatar_id":"","url":"https://api.github.com/users/jhoenicke","html_url":"https://github.com/jhoenicke","followers_url":"https://api.github.com/users/jhoenicke/followers","following_url":"https://api.github.com/users/jhoenicke/following{/other_user}","gists_url":"https://api.github.com/users/jhoenicke/gists{/gist_id}","starred_url":"https://api.github.com/users/jhoenicke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhoenicke/subscriptions","organizations_url":"https://api.github.com/users/jhoenicke/orgs","repos_url":"https://api.github.com/users/jhoenicke/repos","events_url":"https://api.github.com/users/jhoenicke/events{/privacy}","received_events_url":"https://api.github.com/users/jhoenicke/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T10:46:10Z","updated_at":"2018-03-05T10:46:10Z","author_association":"COLLABORATOR","body":"Please note that the files in `trezorlib.messages` are generated from the protobuf definitions in `trezor-common/protob`.  You should change [messages.proto](https://github.com/trezor/trezor-common/blob/master/protob/messages.proto) and then regenerate the files.\r\n\r\nYou can add the new txtype to ethereum_sign_tx; just give it a new number and mark the field as optional.  The order of the fields doesn't have to match the order in which they are signed.  The function could then check if txtype is present (check for None).\r\n\r\nDoes wanchain uses a different chain_id?  We usually use the chain_id to determine the currency that is displayed on the confirmation screen."}}
{"actor":{"display_login":"jhoenicke"}}