{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/foreman/issues/5840","repository_url":"https://api.github.com/repos/theforeman/foreman","labels_url":"https://api.github.com/repos/theforeman/foreman/issues/5840/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/5840/comments","events_url":"https://api.github.com/repos/theforeman/foreman/issues/5840/events","html_url":"https://github.com/theforeman/foreman/pull/5840","id":341448060,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNTgyOTIx","number":5840,"title":"Fixes #24256 - Optimize DB indices","user":{"login":"tbrisker","id":1540531,"node_id":"MDQ6VXNlcjE1NDA1MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1540531?v=4","gravatar_id":"","url":"https://api.github.com/users/tbrisker","html_url":"https://github.com/tbrisker","followers_url":"https://api.github.com/users/tbrisker/followers","following_url":"https://api.github.com/users/tbrisker/following{/other_user}","gists_url":"https://api.github.com/users/tbrisker/gists{/gist_id}","starred_url":"https://api.github.com/users/tbrisker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbrisker/subscriptions","organizations_url":"https://api.github.com/users/tbrisker/orgs","repos_url":"https://api.github.com/users/tbrisker/repos","events_url":"https://api.github.com/users/tbrisker/events{/privacy}","received_events_url":"https://api.github.com/users/tbrisker/received_events","type":"User","site_admin":false},"labels":[{"id":79040689,"node_id":"MDU6TGFiZWw3OTA0MDY4OQ==","url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false},{"id":79040085,"node_id":"MDU6TGFiZWw3OTA0MDA4NQ==","url":"https://api.github.com/repos/theforeman/foreman/labels/Not%20yet%20reviewed","name":"Not yet reviewed","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-16T09:33:24Z","updated_at":"2018-07-29T07:34:50Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/5840","html_url":"https://github.com/theforeman/foreman/pull/5840","diff_url":"https://github.com/theforeman/foreman/pull/5840.diff","patch_url":"https://github.com/theforeman/foreman/pull/5840.patch"},"body":"This removes some indices that aren't really needed since they are\r\nalready covered by parts of another index - both PostgreSQL and MySQL\r\nknow how to use partial indices. Additionally, a few polymorphic indices\r\nwere reversed in order so that the type column is indexed before the id\r\ncolumn. A couple of duplicate indices were also deleted.\r\n\r\n\r\n\r\n<!---\r\n\r\nThank you for contributing to The Foreman, please read the\r\n[following guide](https://www.theforeman.org/contribute.html), in short:\r\n\r\n* [Create an issue](https://projects.theforeman.org/projects/foreman/issues)\r\n* Reference the issue via `Fixes #1234` or `Refs #1234` in the commit message\r\n* Prefer present-tense, imperative-style commit messages\r\n* Extract all strings for i18n, see [Translating section in the guide]\r\n(https://projects.theforeman.org/projects/foreman/wiki/Translating)\r\n* Prepend `[WIP]` for work in progress from bots triggering actions\r\n* Be patient, we will do our best to take a look as soon as we can\r\n* Explain the purpose of the PR, attach screenshots if applicable\r\n* Be nice and respectful\r\n\r\nWe are running bots that will poke you if you miss an item from the list :-)\r\n\r\n--->\r\n"},"comment":{"url":"https://api.github.com/repos/theforeman/foreman/issues/comments/408658106","html_url":"https://github.com/theforeman/foreman/pull/5840#issuecomment-408658106","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/5840","id":408658106,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODY1ODEwNg==","user":{"login":"tbrisker","id":1540531,"node_id":"MDQ6VXNlcjE1NDA1MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1540531?v=4","gravatar_id":"","url":"https://api.github.com/users/tbrisker","html_url":"https://github.com/tbrisker","followers_url":"https://api.github.com/users/tbrisker/followers","following_url":"https://api.github.com/users/tbrisker/following{/other_user}","gists_url":"https://api.github.com/users/tbrisker/gists{/gist_id}","starred_url":"https://api.github.com/users/tbrisker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbrisker/subscriptions","organizations_url":"https://api.github.com/users/tbrisker/orgs","repos_url":"https://api.github.com/users/tbrisker/repos","events_url":"https://api.github.com/users/tbrisker/events{/privacy}","received_events_url":"https://api.github.com/users/tbrisker/received_events","type":"User","site_admin":false},"created_at":"2018-07-29T07:34:50Z","updated_at":"2018-07-29T07:34:50Z","author_association":"MEMBER","body":"@lzap - correct, i was referring to using a subset of a multi-column index, sorry about the confusion. I'll look at the results from the tool to make sure I didn't miss anything. Also I'm not sure regarding adding the indices to all fk's but in any case that should be a separate pr."}}
{"actor":{"display_login":"tbrisker"}}