{"action":"closed","number":31126,"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/31126","id":236558654,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NTU4NjU0","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/31126","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/31126.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/31126.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/31126","number":31126,"state":"closed","locked":false,"title":"styled-components - fixes #31088","user":{"login":"donaldpipowitch","id":1152805,"node_id":"MDQ6VXNlcjExNTI4MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1152805?v=4","gravatar_id":"","url":"https://api.github.com/users/donaldpipowitch","html_url":"https://github.com/donaldpipowitch","followers_url":"https://api.github.com/users/donaldpipowitch/followers","following_url":"https://api.github.com/users/donaldpipowitch/following{/other_user}","gists_url":"https://api.github.com/users/donaldpipowitch/gists{/gist_id}","starred_url":"https://api.github.com/users/donaldpipowitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donaldpipowitch/subscriptions","organizations_url":"https://api.github.com/users/donaldpipowitch/orgs","repos_url":"https://api.github.com/users/donaldpipowitch/repos","events_url":"https://api.github.com/users/donaldpipowitch/events{/privacy}","received_events_url":"https://api.github.com/users/donaldpipowitch/received_events","type":"User","site_admin":false},"body":"**WORK-IN-PROGESS**\r\n\r\n[I just tried the old definition locally](https://github.com/styled-components/styled-components/blob/1fd1cc609da9eaa1aaad9e8a7963d6cc9b58fc9c/typings/styled-components.d.ts#L71) and it worked. I'm sure I missed something. Let's see what CI says.\r\n\r\n**Update 1**\r\n\r\nWow, are these typings complicated 😂\r\n- Findings `createGlobalStyle<CustomProps>` work as expected.\r\n- I think `O` in `ThemedStyledFunctionBase<C, T, O, A>` refers to my _custom props_ I'd like to pass.\r\n- I think we loose `O` in `ThemedStyledProps<StyledComponentPropsWithRef<C> & O, T>`.\r\n- Looking further I think we loose `O` in `StyledComponentPropsWithRef<C> & O`.\r\n- This seems to cast everything to `any`:\r\n\r\n```ts\r\ntype StyledComponentPropsWithRef<\r\n    C extends keyof JSX.IntrinsicElements | React.ComponentType<any>\r\n> = C extends AnyStyledComponent\r\n    ? React.ComponentPropsWithRef<StyledComponentInnerComponent<C>>\r\n    : React.ComponentPropsWithRef<C>;  // <---- this line is the culprit?\r\n```\r\n\r\n---\r\n\r\nPlease fill in this template.\r\n\r\n- [ ] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [ ] Test the change in your own code. (Compile and run.)\r\n- [ ] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [ ] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [ ] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [ ] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf adding a new definition:\r\n- [ ] The package does not already provide its own types, or cannot have its `.d.ts` files generated via `--declaration`\r\n- [ ] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.\r\n- [ ] Create it with `dts-gen --dt`, not by basing it on an existing project.\r\n- [ ] `tslint.json` should be present, and `tsconfig.json` should have `noImplicitAny`, `noImplicitThis`, `strictNullChecks`, and `strictFunctionTypes` set to `true`.\r\n\r\nIf changing an existing definition:\r\n- [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>\r\n- [ ] Increase the version number in the header if appropriate.\r\n- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n\r\nIf removing a declaration:\r\n- [ ] If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)\r\n- [ ] Delete the package's directory.\r\n- [ ] Add it to `notNeededPackages.json`.\r\n","created_at":"2018-12-06T14:57:06Z","updated_at":"2018-12-07T09:33:35Z","closed_at":"2018-12-07T09:33:35Z","merged_at":null,"merge_commit_sha":"1f8d86b870b691d57c6b61fb9201bfb91fe46fbb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Igorbek","id":1929486,"node_id":"MDQ6VXNlcjE5Mjk0ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/1929486?v=4","gravatar_id":"","url":"https://api.github.com/users/Igorbek","html_url":"https://github.com/Igorbek","followers_url":"https://api.github.com/users/Igorbek/followers","following_url":"https://api.github.com/users/Igorbek/following{/other_user}","gists_url":"https://api.github.com/users/Igorbek/gists{/gist_id}","starred_url":"https://api.github.com/users/Igorbek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igorbek/subscriptions","organizations_url":"https://api.github.com/users/Igorbek/orgs","repos_url":"https://api.github.com/users/Igorbek/repos","events_url":"https://api.github.com/users/Igorbek/events{/privacy}","received_events_url":"https://api.github.com/users/Igorbek/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":684321576,"node_id":"MDU6TGFiZWw2ODQzMjE1NzY=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Popular%20package","name":"Popular package","color":"fbca04","default":false},{"id":57534397,"node_id":"MDU6TGFiZWw1NzUzNDM5Nw==","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/The%20Travis%20CI%20build%20failed","name":"The Travis CI build failed","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/31126/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/31126/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/31126/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/dd2f47905552b88014ed568e9c3b47e93c11bc37","head":{"label":"donaldpipowitch:patch-22","ref":"patch-22","sha":"dd2f47905552b88014ed568e9c3b47e93c11bc37","user":{"login":"donaldpipowitch","id":1152805,"node_id":"MDQ6VXNlcjExNTI4MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1152805?v=4","gravatar_id":"","url":"https://api.github.com/users/donaldpipowitch","html_url":"https://github.com/donaldpipowitch","followers_url":"https://api.github.com/users/donaldpipowitch/followers","following_url":"https://api.github.com/users/donaldpipowitch/following{/other_user}","gists_url":"https://api.github.com/users/donaldpipowitch/gists{/gist_id}","starred_url":"https://api.github.com/users/donaldpipowitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donaldpipowitch/subscriptions","organizations_url":"https://api.github.com/users/donaldpipowitch/orgs","repos_url":"https://api.github.com/users/donaldpipowitch/repos","events_url":"https://api.github.com/users/donaldpipowitch/events{/privacy}","received_events_url":"https://api.github.com/users/donaldpipowitch/received_events","type":"User","site_admin":false},"repo":{"id":63938325,"node_id":"MDEwOlJlcG9zaXRvcnk2MzkzODMyNQ==","name":"DefinitelyTyped","full_name":"donaldpipowitch/DefinitelyTyped","private":false,"owner":{"login":"donaldpipowitch","id":1152805,"node_id":"MDQ6VXNlcjExNTI4MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1152805?v=4","gravatar_id":"","url":"https://api.github.com/users/donaldpipowitch","html_url":"https://github.com/donaldpipowitch","followers_url":"https://api.github.com/users/donaldpipowitch/followers","following_url":"https://api.github.com/users/donaldpipowitch/following{/other_user}","gists_url":"https://api.github.com/users/donaldpipowitch/gists{/gist_id}","starred_url":"https://api.github.com/users/donaldpipowitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donaldpipowitch/subscriptions","organizations_url":"https://api.github.com/users/donaldpipowitch/orgs","repos_url":"https://api.github.com/users/donaldpipowitch/repos","events_url":"https://api.github.com/users/donaldpipowitch/events{/privacy}","received_events_url":"https://api.github.com/users/donaldpipowitch/received_events","type":"User","site_admin":false},"html_url":"https://github.com/donaldpipowitch/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped","forks_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/donaldpipowitch/DefinitelyTyped/deployments","created_at":"2016-07-22T08:44:37Z","updated_at":"2018-12-05T11:05:26Z","pushed_at":"2018-12-06T14:56:05Z","git_url":"git://github.com/donaldpipowitch/DefinitelyTyped.git","ssh_url":"git@github.com:donaldpipowitch/DefinitelyTyped.git","clone_url":"https://github.com/donaldpipowitch/DefinitelyTyped.git","svn_url":"https://github.com/donaldpipowitch/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":379562,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"a7e0763b93abd4c22bd8ec5c2c1dc815e1e0a16a","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","private":false,"owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-12-07T08:47:07Z","pushed_at":"2018-12-07T08:54:08Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":386183,"stargazers_count":18939,"watchers_count":18939,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15651,"mirror_url":null,"archived":false,"open_issues_count":2582,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15651,"open_issues":2582,"watchers":18939,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/31126"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/31126"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/31126"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/31126/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/31126/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/31126/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/dd2f47905552b88014ed568e9c3b47e93c11bc37"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":28,"changed_files":1}}
{"actor":{"display_login":"donaldpipowitch"}}