{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/210121595","pull_request_review_id":146272137,"id":210121595,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDEyMTU5NQ==","diff_hunk":"@@ -17,6 +17,8 @@\n \n package org.apache.spark.launcher;\n \n+import org.apache.commons.lang.StringUtils;","path":"launcher/src/main/java/org/apache/spark/launcher/OutputRedirector.java","position":4,"original_position":4,"commit_id":"7e3100ed148f98078c04e5aba8a41ead8776f89b","original_commit_id":"7e3100ed148f98078c04e5aba8a41ead8776f89b","user":{"login":"vanzin","id":1694083,"node_id":"MDQ6VXNlcjE2OTQwODM=","avatar_url":"https://avatars0.githubusercontent.com/u/1694083?v=4","gravatar_id":"","url":"https://api.github.com/users/vanzin","html_url":"https://github.com/vanzin","followers_url":"https://api.github.com/users/vanzin/followers","following_url":"https://api.github.com/users/vanzin/following{/other_user}","gists_url":"https://api.github.com/users/vanzin/gists{/gist_id}","starred_url":"https://api.github.com/users/vanzin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanzin/subscriptions","organizations_url":"https://api.github.com/users/vanzin/orgs","repos_url":"https://api.github.com/users/vanzin/repos","events_url":"https://api.github.com/users/vanzin/events{/privacy}","received_events_url":"https://api.github.com/users/vanzin/received_events","type":"User","site_admin":false},"body":"This module shouldn't really depend on any 3rd-party libraries... there's an oddity in the current parent pom that causes this dependency to be available but I think we should instead fix that by adding this property to launcher/pom.xml:\r\n\r\n```\r\n    <hadoop.deps.scope>test</hadoop.deps.scope>\r\n```\r\n\r\n`containsIgnoreCase` shouldn't really be hard to replicate. Although, if you really want to simplify things, I'd just set the error in this case to a generic \"Spark exited with error code X. Please check logs.\".","created_at":"2018-08-14T22:15:36Z","updated_at":"2018-08-14T22:16:10Z","html_url":"https://github.com/apache/spark/pull/21849#discussion_r210121595","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/21849","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/210121595"},"html":{"href":"https://github.com/apache/spark/pull/21849#discussion_r210121595"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/21849"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/21849","id":203291231,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMjkxMjMx","html_url":"https://github.com/apache/spark/pull/21849","diff_url":"https://github.com/apache/spark/pull/21849.diff","patch_url":"https://github.com/apache/spark/pull/21849.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/21849","number":21849,"state":"open","locked":false,"title":"[SPARK-24243][CORE] Expose exceptions from InProcessAppHandle","user":{"login":"sahilTakiar","id":1282583,"node_id":"MDQ6VXNlcjEyODI1ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/1282583?v=4","gravatar_id":"","url":"https://api.github.com/users/sahilTakiar","html_url":"https://github.com/sahilTakiar","followers_url":"https://api.github.com/users/sahilTakiar/followers","following_url":"https://api.github.com/users/sahilTakiar/following{/other_user}","gists_url":"https://api.github.com/users/sahilTakiar/gists{/gist_id}","starred_url":"https://api.github.com/users/sahilTakiar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahilTakiar/subscriptions","organizations_url":"https://api.github.com/users/sahilTakiar/orgs","repos_url":"https://api.github.com/users/sahilTakiar/repos","events_url":"https://api.github.com/users/sahilTakiar/events{/privacy}","received_events_url":"https://api.github.com/users/sahilTakiar/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nAdds a new method to `SparkAppHandle` called `getError` which returns\r\nthe exception (if present) that caused the underlying Spark app to\r\nfail.\r\n\r\n## How was this patch tested?\r\n\r\nNew tests added to `SparkLauncherSuite` for the new method.\r\n","created_at":"2018-07-23T17:35:35Z","updated_at":"2018-08-14T22:16:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81514415f980493d69a9063a8a40624d25b3115d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/21849/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/21849/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/21849/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/7e3100ed148f98078c04e5aba8a41ead8776f89b","head":{"label":"sahilTakiar:master","ref":"master","sha":"7e3100ed148f98078c04e5aba8a41ead8776f89b","user":{"login":"sahilTakiar","id":1282583,"node_id":"MDQ6VXNlcjEyODI1ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/1282583?v=4","gravatar_id":"","url":"https://api.github.com/users/sahilTakiar","html_url":"https://github.com/sahilTakiar","followers_url":"https://api.github.com/users/sahilTakiar/followers","following_url":"https://api.github.com/users/sahilTakiar/following{/other_user}","gists_url":"https://api.github.com/users/sahilTakiar/gists{/gist_id}","starred_url":"https://api.github.com/users/sahilTakiar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahilTakiar/subscriptions","organizations_url":"https://api.github.com/users/sahilTakiar/orgs","repos_url":"https://api.github.com/users/sahilTakiar/repos","events_url":"https://api.github.com/users/sahilTakiar/events{/privacy}","received_events_url":"https://api.github.com/users/sahilTakiar/received_events","type":"User","site_admin":false},"repo":{"id":86848625,"node_id":"MDEwOlJlcG9zaXRvcnk4Njg0ODYyNQ==","name":"spark","full_name":"sahilTakiar/spark","owner":{"login":"sahilTakiar","id":1282583,"node_id":"MDQ6VXNlcjEyODI1ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/1282583?v=4","gravatar_id":"","url":"https://api.github.com/users/sahilTakiar","html_url":"https://github.com/sahilTakiar","followers_url":"https://api.github.com/users/sahilTakiar/followers","following_url":"https://api.github.com/users/sahilTakiar/following{/other_user}","gists_url":"https://api.github.com/users/sahilTakiar/gists{/gist_id}","starred_url":"https://api.github.com/users/sahilTakiar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahilTakiar/subscriptions","organizations_url":"https://api.github.com/users/sahilTakiar/orgs","repos_url":"https://api.github.com/users/sahilTakiar/repos","events_url":"https://api.github.com/users/sahilTakiar/events{/privacy}","received_events_url":"https://api.github.com/users/sahilTakiar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sahilTakiar/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/sahilTakiar/spark","forks_url":"https://api.github.com/repos/sahilTakiar/spark/forks","keys_url":"https://api.github.com/repos/sahilTakiar/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sahilTakiar/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sahilTakiar/spark/teams","hooks_url":"https://api.github.com/repos/sahilTakiar/spark/hooks","issue_events_url":"https://api.github.com/repos/sahilTakiar/spark/issues/events{/number}","events_url":"https://api.github.com/repos/sahilTakiar/spark/events","assignees_url":"https://api.github.com/repos/sahilTakiar/spark/assignees{/user}","branches_url":"https://api.github.com/repos/sahilTakiar/spark/branches{/branch}","tags_url":"https://api.github.com/repos/sahilTakiar/spark/tags","blobs_url":"https://api.github.com/repos/sahilTakiar/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sahilTakiar/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sahilTakiar/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/sahilTakiar/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sahilTakiar/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/sahilTakiar/spark/languages","stargazers_url":"https://api.github.com/repos/sahilTakiar/spark/stargazers","contributors_url":"https://api.github.com/repos/sahilTakiar/spark/contributors","subscribers_url":"https://api.github.com/repos/sahilTakiar/spark/subscribers","subscription_url":"https://api.github.com/repos/sahilTakiar/spark/subscription","commits_url":"https://api.github.com/repos/sahilTakiar/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/sahilTakiar/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/sahilTakiar/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/sahilTakiar/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/sahilTakiar/spark/contents/{+path}","compare_url":"https://api.github.com/repos/sahilTakiar/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sahilTakiar/spark/merges","archive_url":"https://api.github.com/repos/sahilTakiar/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sahilTakiar/spark/downloads","issues_url":"https://api.github.com/repos/sahilTakiar/spark/issues{/number}","pulls_url":"https://api.github.com/repos/sahilTakiar/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/sahilTakiar/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/sahilTakiar/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sahilTakiar/spark/labels{/name}","releases_url":"https://api.github.com/repos/sahilTakiar/spark/releases{/id}","deployments_url":"https://api.github.com/repos/sahilTakiar/spark/deployments","created_at":"2017-03-31T18:25:52Z","updated_at":"2018-07-23T17:35:35Z","pushed_at":"2018-07-23T17:34:27Z","git_url":"git://github.com/sahilTakiar/spark.git","ssh_url":"git@github.com:sahilTakiar/spark.git","clone_url":"https://github.com/sahilTakiar/spark.git","svn_url":"https://github.com/sahilTakiar/spark","homepage":null,"size":272396,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2edf17effd8b0aba61c95dddd5823ad7277d6c7d","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"node_id":"MDEwOlJlcG9zaXRvcnkxNzE2NTY1OA==","name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-08-14T18:49:53Z","pushed_at":"2018-08-14T21:45:09Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":279458,"stargazers_count":18391,"watchers_count":18391,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16660,"mirror_url":null,"archived":false,"open_issues_count":495,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16660,"open_issues":495,"watchers":18391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/21849"},"html":{"href":"https://github.com/apache/spark/pull/21849"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/21849"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/21849/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/21849/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/21849/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/7e3100ed148f98078c04e5aba8a41ead8776f89b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vanzin"}}