{"action":"created","comment":{"url":"https://api.github.com/repos/maticnetwork/contracts/pulls/comments/240143863","pull_request_review_id":183102847,"id":240143863,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDE0Mzg2Mw==","diff_hunk":"@@ -62,18 +66,22 @@ contract('ChildERC20', async function(accounts) {\n \n     // withdraw those tokens\n     const receipt = await childToken.withdraw(amount)\n-\n-    receipt.logs.should.have.lengthOf(2)\n-\n-    receipt.logs[0].event.should.equal('Withdraw')\n-    receipt.logs[0].args.token.should.equal(rootToken.address)\n-    receipt.logs[0].args.user.should.equal(owner)\n-    receipt.logs[0].args.amount.toString().should.equal(amount)\n-\n-    receipt.logs[1].event.should.equal('LogWithdraw')\n-    receipt.logs[1].args.input1.should.be.bignumber.equal(amount)\n-    receipt.logs[1].args.amount.should.be.bignumber.equal(amount)\n-    receipt.logs[1].args.output1.should.be.bignumber.equal(0)\n+    receipt.logs.should.have.lengthOf(3)\n+\n+    receipt.logs[0].event.should.equal('Transfer')\n+    receipt.logs[0].args.from.toLowerCase().should.equal(owner)\n+    receipt.logs[0].args.to.toLowerCase().should.equal(ZeroAddress)\n+    receipt.logs[0].args.value.should.be.bignumber.equal(amount)\n+\n+    receipt.logs[1].event.should.equal('Withdraw')","path":"test/child/ChildERC20.test.js","position":58,"original_position":58,"commit_id":"241172040fc05ec519e5684802974237bd1a842e","original_commit_id":"241172040fc05ec519e5684802974237bd1a842e","user":{"login":"jdkanani","id":1692593,"node_id":"MDQ6VXNlcjE2OTI1OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1692593?v=4","gravatar_id":"","url":"https://api.github.com/users/jdkanani","html_url":"https://github.com/jdkanani","followers_url":"https://api.github.com/users/jdkanani/followers","following_url":"https://api.github.com/users/jdkanani/following{/other_user}","gists_url":"https://api.github.com/users/jdkanani/gists{/gist_id}","starred_url":"https://api.github.com/users/jdkanani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdkanani/subscriptions","organizations_url":"https://api.github.com/users/jdkanani/orgs","repos_url":"https://api.github.com/users/jdkanani/repos","events_url":"https://api.github.com/users/jdkanani/events{/privacy}","received_events_url":"https://api.github.com/users/jdkanani/received_events","type":"User","site_admin":false},"body":"Remove `Withdraw` and use `Transfer` only.","created_at":"2018-12-10T09:52:50Z","updated_at":"2018-12-10T09:52:50Z","html_url":"https://github.com/maticnetwork/contracts/pull/40#discussion_r240143863","pull_request_url":"https://api.github.com/repos/maticnetwork/contracts/pulls/40","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/maticnetwork/contracts/pulls/comments/240143863"},"html":{"href":"https://github.com/maticnetwork/contracts/pull/40#discussion_r240143863"},"pull_request":{"href":"https://api.github.com/repos/maticnetwork/contracts/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/maticnetwork/contracts/pulls/40","id":236176869,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MTc2ODY5","html_url":"https://github.com/maticnetwork/contracts/pull/40","diff_url":"https://github.com/maticnetwork/contracts/pull/40.diff","patch_url":"https://github.com/maticnetwork/contracts/pull/40.patch","issue_url":"https://api.github.com/repos/maticnetwork/contracts/issues/40","number":40,"state":"open","locked":false,"title":"Open zapplin update","user":{"login":"0xAshish","id":14859266,"node_id":"MDQ6VXNlcjE0ODU5MjY2","avatar_url":"https://avatars1.githubusercontent.com/u/14859266?v=4","gravatar_id":"","url":"https://api.github.com/users/0xAshish","html_url":"https://github.com/0xAshish","followers_url":"https://api.github.com/users/0xAshish/followers","following_url":"https://api.github.com/users/0xAshish/following{/other_user}","gists_url":"https://api.github.com/users/0xAshish/gists{/gist_id}","starred_url":"https://api.github.com/users/0xAshish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xAshish/subscriptions","organizations_url":"https://api.github.com/users/0xAshish/orgs","repos_url":"https://api.github.com/users/0xAshish/repos","events_url":"https://api.github.com/users/0xAshish/events{/privacy}","received_events_url":"https://api.github.com/users/0xAshish/received_events","type":"User","site_admin":false},"body":"WIP: please review and keep it open.","created_at":"2018-12-05T13:37:51Z","updated_at":"2018-12-10T09:52:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fc135dcde387c394bb4489b01474b5703e7f0cd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sandeepnailwal","id":8059578,"node_id":"MDQ6VXNlcjgwNTk1Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/8059578?v=4","gravatar_id":"","url":"https://api.github.com/users/sandeepnailwal","html_url":"https://github.com/sandeepnailwal","followers_url":"https://api.github.com/users/sandeepnailwal/followers","following_url":"https://api.github.com/users/sandeepnailwal/following{/other_user}","gists_url":"https://api.github.com/users/sandeepnailwal/gists{/gist_id}","starred_url":"https://api.github.com/users/sandeepnailwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandeepnailwal/subscriptions","organizations_url":"https://api.github.com/users/sandeepnailwal/orgs","repos_url":"https://api.github.com/users/sandeepnailwal/repos","events_url":"https://api.github.com/users/sandeepnailwal/events{/privacy}","received_events_url":"https://api.github.com/users/sandeepnailwal/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/maticnetwork/contracts/pulls/40/commits","review_comments_url":"https://api.github.com/repos/maticnetwork/contracts/pulls/40/comments","review_comment_url":"https://api.github.com/repos/maticnetwork/contracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maticnetwork/contracts/issues/40/comments","statuses_url":"https://api.github.com/repos/maticnetwork/contracts/statuses/241172040fc05ec519e5684802974237bd1a842e","head":{"label":"maticnetwork:open-zapplin-update","ref":"open-zapplin-update","sha":"241172040fc05ec519e5684802974237bd1a842e","user":{"login":"maticnetwork","id":30753617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzUzNjE3","avatar_url":"https://avatars2.githubusercontent.com/u/30753617?v=4","gravatar_id":"","url":"https://api.github.com/users/maticnetwork","html_url":"https://github.com/maticnetwork","followers_url":"https://api.github.com/users/maticnetwork/followers","following_url":"https://api.github.com/users/maticnetwork/following{/other_user}","gists_url":"https://api.github.com/users/maticnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/maticnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maticnetwork/subscriptions","organizations_url":"https://api.github.com/users/maticnetwork/orgs","repos_url":"https://api.github.com/users/maticnetwork/repos","events_url":"https://api.github.com/users/maticnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/maticnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":111664047,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE2NjQwNDc=","name":"contracts","full_name":"maticnetwork/contracts","private":false,"owner":{"login":"maticnetwork","id":30753617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzUzNjE3","avatar_url":"https://avatars2.githubusercontent.com/u/30753617?v=4","gravatar_id":"","url":"https://api.github.com/users/maticnetwork","html_url":"https://github.com/maticnetwork","followers_url":"https://api.github.com/users/maticnetwork/followers","following_url":"https://api.github.com/users/maticnetwork/following{/other_user}","gists_url":"https://api.github.com/users/maticnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/maticnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maticnetwork/subscriptions","organizations_url":"https://api.github.com/users/maticnetwork/orgs","repos_url":"https://api.github.com/users/maticnetwork/repos","events_url":"https://api.github.com/users/maticnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/maticnetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/maticnetwork/contracts","description":"Smart contracts comprising the business logic of the Matic Network","fork":false,"url":"https://api.github.com/repos/maticnetwork/contracts","forks_url":"https://api.github.com/repos/maticnetwork/contracts/forks","keys_url":"https://api.github.com/repos/maticnetwork/contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maticnetwork/contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maticnetwork/contracts/teams","hooks_url":"https://api.github.com/repos/maticnetwork/contracts/hooks","issue_events_url":"https://api.github.com/repos/maticnetwork/contracts/issues/events{/number}","events_url":"https://api.github.com/repos/maticnetwork/contracts/events","assignees_url":"https://api.github.com/repos/maticnetwork/contracts/assignees{/user}","branches_url":"https://api.github.com/repos/maticnetwork/contracts/branches{/branch}","tags_url":"https://api.github.com/repos/maticnetwork/contracts/tags","blobs_url":"https://api.github.com/repos/maticnetwork/contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maticnetwork/contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maticnetwork/contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/maticnetwork/contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maticnetwork/contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/maticnetwork/contracts/languages","stargazers_url":"https://api.github.com/repos/maticnetwork/contracts/stargazers","contributors_url":"https://api.github.com/repos/maticnetwork/contracts/contributors","subscribers_url":"https://api.github.com/repos/maticnetwork/contracts/subscribers","subscription_url":"https://api.github.com/repos/maticnetwork/contracts/subscription","commits_url":"https://api.github.com/repos/maticnetwork/contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/maticnetwork/contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/maticnetwork/contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/maticnetwork/contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/maticnetwork/contracts/contents/{+path}","compare_url":"https://api.github.com/repos/maticnetwork/contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maticnetwork/contracts/merges","archive_url":"https://api.github.com/repos/maticnetwork/contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maticnetwork/contracts/downloads","issues_url":"https://api.github.com/repos/maticnetwork/contracts/issues{/number}","pulls_url":"https://api.github.com/repos/maticnetwork/contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/maticnetwork/contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/maticnetwork/contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maticnetwork/contracts/labels{/name}","releases_url":"https://api.github.com/repos/maticnetwork/contracts/releases{/id}","deployments_url":"https://api.github.com/repos/maticnetwork/contracts/deployments","created_at":"2017-11-22T09:34:25Z","updated_at":"2018-12-01T18:18:44Z","pushed_at":"2018-12-07T08:20:39Z","git_url":"git://github.com/maticnetwork/contracts.git","ssh_url":"git@github.com:maticnetwork/contracts.git","clone_url":"https://github.com/maticnetwork/contracts.git","svn_url":"https://github.com/maticnetwork/contracts","homepage":"https://matic.network","size":786,"stargazers_count":33,"watchers_count":33,"language":"Solidity","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":11,"open_issues":14,"watchers":33,"default_branch":"master"}},"base":{"label":"maticnetwork:master","ref":"master","sha":"d9fddcea5dc490a3acd356d8c4a3f7819b0245ba","user":{"login":"maticnetwork","id":30753617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzUzNjE3","avatar_url":"https://avatars2.githubusercontent.com/u/30753617?v=4","gravatar_id":"","url":"https://api.github.com/users/maticnetwork","html_url":"https://github.com/maticnetwork","followers_url":"https://api.github.com/users/maticnetwork/followers","following_url":"https://api.github.com/users/maticnetwork/following{/other_user}","gists_url":"https://api.github.com/users/maticnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/maticnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maticnetwork/subscriptions","organizations_url":"https://api.github.com/users/maticnetwork/orgs","repos_url":"https://api.github.com/users/maticnetwork/repos","events_url":"https://api.github.com/users/maticnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/maticnetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":111664047,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE2NjQwNDc=","name":"contracts","full_name":"maticnetwork/contracts","private":false,"owner":{"login":"maticnetwork","id":30753617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNzUzNjE3","avatar_url":"https://avatars2.githubusercontent.com/u/30753617?v=4","gravatar_id":"","url":"https://api.github.com/users/maticnetwork","html_url":"https://github.com/maticnetwork","followers_url":"https://api.github.com/users/maticnetwork/followers","following_url":"https://api.github.com/users/maticnetwork/following{/other_user}","gists_url":"https://api.github.com/users/maticnetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/maticnetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maticnetwork/subscriptions","organizations_url":"https://api.github.com/users/maticnetwork/orgs","repos_url":"https://api.github.com/users/maticnetwork/repos","events_url":"https://api.github.com/users/maticnetwork/events{/privacy}","received_events_url":"https://api.github.com/users/maticnetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/maticnetwork/contracts","description":"Smart contracts comprising the business logic of the Matic Network","fork":false,"url":"https://api.github.com/repos/maticnetwork/contracts","forks_url":"https://api.github.com/repos/maticnetwork/contracts/forks","keys_url":"https://api.github.com/repos/maticnetwork/contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maticnetwork/contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maticnetwork/contracts/teams","hooks_url":"https://api.github.com/repos/maticnetwork/contracts/hooks","issue_events_url":"https://api.github.com/repos/maticnetwork/contracts/issues/events{/number}","events_url":"https://api.github.com/repos/maticnetwork/contracts/events","assignees_url":"https://api.github.com/repos/maticnetwork/contracts/assignees{/user}","branches_url":"https://api.github.com/repos/maticnetwork/contracts/branches{/branch}","tags_url":"https://api.github.com/repos/maticnetwork/contracts/tags","blobs_url":"https://api.github.com/repos/maticnetwork/contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maticnetwork/contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maticnetwork/contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/maticnetwork/contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maticnetwork/contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/maticnetwork/contracts/languages","stargazers_url":"https://api.github.com/repos/maticnetwork/contracts/stargazers","contributors_url":"https://api.github.com/repos/maticnetwork/contracts/contributors","subscribers_url":"https://api.github.com/repos/maticnetwork/contracts/subscribers","subscription_url":"https://api.github.com/repos/maticnetwork/contracts/subscription","commits_url":"https://api.github.com/repos/maticnetwork/contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/maticnetwork/contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/maticnetwork/contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/maticnetwork/contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/maticnetwork/contracts/contents/{+path}","compare_url":"https://api.github.com/repos/maticnetwork/contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maticnetwork/contracts/merges","archive_url":"https://api.github.com/repos/maticnetwork/contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maticnetwork/contracts/downloads","issues_url":"https://api.github.com/repos/maticnetwork/contracts/issues{/number}","pulls_url":"https://api.github.com/repos/maticnetwork/contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/maticnetwork/contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/maticnetwork/contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maticnetwork/contracts/labels{/name}","releases_url":"https://api.github.com/repos/maticnetwork/contracts/releases{/id}","deployments_url":"https://api.github.com/repos/maticnetwork/contracts/deployments","created_at":"2017-11-22T09:34:25Z","updated_at":"2018-12-01T18:18:44Z","pushed_at":"2018-12-07T08:20:39Z","git_url":"git://github.com/maticnetwork/contracts.git","ssh_url":"git@github.com:maticnetwork/contracts.git","clone_url":"https://github.com/maticnetwork/contracts.git","svn_url":"https://github.com/maticnetwork/contracts","homepage":"https://matic.network","size":786,"stargazers_count":33,"watchers_count":33,"language":"Solidity","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":11,"open_issues":14,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maticnetwork/contracts/pulls/40"},"html":{"href":"https://github.com/maticnetwork/contracts/pull/40"},"issue":{"href":"https://api.github.com/repos/maticnetwork/contracts/issues/40"},"comments":{"href":"https://api.github.com/repos/maticnetwork/contracts/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/maticnetwork/contracts/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/maticnetwork/contracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maticnetwork/contracts/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/maticnetwork/contracts/statuses/241172040fc05ec519e5684802974237bd1a842e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jdkanani"}}