{"action":"created","comment":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/165469442","pull_request_review_id":93415391,"id":165469442,"diff_hunk":"@@ -69,28 +69,25 @@ def test_sched_fifo(self):\n \n         # Submit 3 jobs to workq2, 1 jobs to workq\n         j1 = Job(TEST_USER, attrs={\n-            ATTR_queue: \"workq2\"\n+            ATTR_queue: \"workq\"\n         })\n         j2 = Job(TEST_USER, attrs={\n             ATTR_queue: \"workq2\"\n         })\n         j3 = Job(TEST_USER, attrs={\n-            ATTR_queue: \"workq2\"\n-        })\n-        j4 = Job(TEST_USER, attrs={\n             ATTR_queue: \"workq\"\n         })\n \n         j_id1 = self.server.submit(j1)\n         j_id2 = self.server.submit(j2)\n         j_id3 = self.server.submit(j3)\n-        j_id4 = self.server.submit(j4)\n \n         # Turn scheduling on again\n-        self.server.manager(MGR_CMD_SET, SERVER, {'scheduling': 'True'})\n+        self.server.manager(MGR_CMD_SET,\n+                            SERVER,\n+                            {'scheduling': 'True'})","path":"test/tests/functional/pbs_sched_fifo.py","position":null,"original_position":26,"commit_id":"c3370b5ce769a4417992a88622e044539aa23966","original_commit_id":"c3370b5ce769a4417992a88622e044539aa23966","user":{"login":"bhroam","id":17993078,"avatar_url":"https://avatars3.githubusercontent.com/u/17993078?v=4","gravatar_id":"","url":"https://api.github.com/users/bhroam","html_url":"https://github.com/bhroam","followers_url":"https://api.github.com/users/bhroam/followers","following_url":"https://api.github.com/users/bhroam/following{/other_user}","gists_url":"https://api.github.com/users/bhroam/gists{/gist_id}","starred_url":"https://api.github.com/users/bhroam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhroam/subscriptions","organizations_url":"https://api.github.com/users/bhroam/orgs","repos_url":"https://api.github.com/users/bhroam/repos","events_url":"https://api.github.com/users/bhroam/events{/privacy}","received_events_url":"https://api.github.com/users/bhroam/received_events","type":"User","site_admin":false},"body":"This probably can fit on 2 lines instead of 3.  It'd be more tidy.","created_at":"2018-02-01T19:52:44Z","updated_at":"2018-02-01T19:52:51Z","html_url":"https://github.com/PBSPro/pbspro/pull/536#discussion_r165469442","pull_request_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/536","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/165469442"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/536#discussion_r165469442"},"pull_request":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/536"}}},"pull_request":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/536","id":165626652,"html_url":"https://github.com/PBSPro/pbspro/pull/536","diff_url":"https://github.com/PBSPro/pbspro/pull/536.diff","patch_url":"https://github.com/PBSPro/pbspro/pull/536.patch","issue_url":"https://api.github.com/repos/PBSPro/pbspro/issues/536","number":536,"state":"open","locked":false,"title":"PP-1023: FIFO not working","user":{"login":"sid2364","id":13983559,"avatar_url":"https://avatars2.githubusercontent.com/u/13983559?v=4","gravatar_id":"","url":"https://api.github.com/users/sid2364","html_url":"https://github.com/sid2364","followers_url":"https://api.github.com/users/sid2364/followers","following_url":"https://api.github.com/users/sid2364/following{/other_user}","gists_url":"https://api.github.com/users/sid2364/gists{/gist_id}","starred_url":"https://api.github.com/users/sid2364/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sid2364/subscriptions","organizations_url":"https://api.github.com/users/sid2364/orgs","repos_url":"https://api.github.com/users/sid2364/repos","events_url":"https://api.github.com/users/sid2364/events{/privacy}","received_events_url":"https://api.github.com/users/sid2364/received_events","type":"User","site_admin":false},"body":"<!--- Please review your changes in preview mode -->\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n#### Bug Description\r\n* *FIFO scheduling was not working*\r\n* *[PP-1023](https://pbspro.atlassian.net/browse/PP-1023)*\r\n\r\n#### Affected Platform(s) and PBS Version\r\n* *RHEL/CentOS 7*\r\n* *14.2.1*\r\n\r\n#### Cause / Analysis\r\n* *pbs_scheduler is not able to convert qrank (which now is an epoch in milliseconds) to a long.*\r\n\r\n#### Solution Description\r\n* *Scheduler has wrong code where after \"strtol\" it is checking for end pointer to be NOT null when ideally it should be checking it to BE null for the functionality to pass.*\r\n\r\n#### Checklist:\r\n<!--- Use the preview button to see the checkboxes/links properly. -->\r\n<!--- Go over the following points, and put an `x` (without spaces around it) in the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have joined the **[pbspro community forum](http://community.pbspro.org/)**.\r\n- [x] My pull request contains a **single, signed** commit. See **[setting up gpg signature](https://pbspro.atlassian.net/wiki/display/DG/Signing+Your+Git+Commits)**.\r\n- [x] My code follows the **[coding style](https://pbspro.atlassian.net/wiki/display/DG/Coding+Standards)** of this project.\r\n- [ ] My change requires project documentation. See **[required documentation checklist](https://pbspro.atlassian.net/wiki/display/DG/Checklist+for+Developing+Features+and+Bug+Fixes)** for details.\r\n- [ ] I have added documentation in the **[project documentation area](https://pbspro.atlassian.net/wiki/display/PD)**.\r\n- [ ] I have added new **PTL test(s) to my commit**. (See **[using PTL for testing](https://pbspro.atlassian.net/wiki/display/DG/Using+PTL+for+Testing)**) *(or)*\r\n- [x] I have added  **manual test(s) to this pull request and explained why PTL is not appropriate** for this case.\r\n- [x] All new and existing automated tests have passed. (See **[running automated PTL tests](https://pbspro.atlassian.net/wiki/display/DG/PTL+Quick+Start+Guide)**).\r\n- [x] I have attached **test logs to this pull request** as evidence of testing/verification.\r\n\r\n\r\n__***For further information please visit the [Developer Guide Home](https://pbspro.atlassian.net/wiki/display/DG/Developer+Guide+Home).***__\r\n","created_at":"2018-01-29T06:43:48Z","updated_at":"2018-02-01T19:52:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86ae37a242955d5ddb864ef6ade34c102c8dac9a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/536/commits","review_comments_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/536/comments","review_comment_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/issues/536/comments","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/c3370b5ce769a4417992a88622e044539aa23966","head":{"label":"sid2364:PP-1023","ref":"PP-1023","sha":"c3370b5ce769a4417992a88622e044539aa23966","user":{"login":"sid2364","id":13983559,"avatar_url":"https://avatars2.githubusercontent.com/u/13983559?v=4","gravatar_id":"","url":"https://api.github.com/users/sid2364","html_url":"https://github.com/sid2364","followers_url":"https://api.github.com/users/sid2364/followers","following_url":"https://api.github.com/users/sid2364/following{/other_user}","gists_url":"https://api.github.com/users/sid2364/gists{/gist_id}","starred_url":"https://api.github.com/users/sid2364/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sid2364/subscriptions","organizations_url":"https://api.github.com/users/sid2364/orgs","repos_url":"https://api.github.com/users/sid2364/repos","events_url":"https://api.github.com/users/sid2364/events{/privacy}","received_events_url":"https://api.github.com/users/sid2364/received_events","type":"User","site_admin":false},"repo":{"id":62547207,"name":"pbspro","full_name":"sid2364/pbspro","owner":{"login":"sid2364","id":13983559,"avatar_url":"https://avatars2.githubusercontent.com/u/13983559?v=4","gravatar_id":"","url":"https://api.github.com/users/sid2364","html_url":"https://github.com/sid2364","followers_url":"https://api.github.com/users/sid2364/followers","following_url":"https://api.github.com/users/sid2364/following{/other_user}","gists_url":"https://api.github.com/users/sid2364/gists{/gist_id}","starred_url":"https://api.github.com/users/sid2364/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sid2364/subscriptions","organizations_url":"https://api.github.com/users/sid2364/orgs","repos_url":"https://api.github.com/users/sid2364/repos","events_url":"https://api.github.com/users/sid2364/events{/privacy}","received_events_url":"https://api.github.com/users/sid2364/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sid2364/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":true,"url":"https://api.github.com/repos/sid2364/pbspro","forks_url":"https://api.github.com/repos/sid2364/pbspro/forks","keys_url":"https://api.github.com/repos/sid2364/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sid2364/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sid2364/pbspro/teams","hooks_url":"https://api.github.com/repos/sid2364/pbspro/hooks","issue_events_url":"https://api.github.com/repos/sid2364/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/sid2364/pbspro/events","assignees_url":"https://api.github.com/repos/sid2364/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/sid2364/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/sid2364/pbspro/tags","blobs_url":"https://api.github.com/repos/sid2364/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sid2364/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sid2364/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/sid2364/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sid2364/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/sid2364/pbspro/languages","stargazers_url":"https://api.github.com/repos/sid2364/pbspro/stargazers","contributors_url":"https://api.github.com/repos/sid2364/pbspro/contributors","subscribers_url":"https://api.github.com/repos/sid2364/pbspro/subscribers","subscription_url":"https://api.github.com/repos/sid2364/pbspro/subscription","commits_url":"https://api.github.com/repos/sid2364/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/sid2364/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/sid2364/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/sid2364/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/sid2364/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/sid2364/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sid2364/pbspro/merges","archive_url":"https://api.github.com/repos/sid2364/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sid2364/pbspro/downloads","issues_url":"https://api.github.com/repos/sid2364/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/sid2364/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/sid2364/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/sid2364/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sid2364/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/sid2364/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/sid2364/pbspro/deployments","created_at":"2016-07-04T08:58:10Z","updated_at":"2016-07-04T08:58:16Z","pushed_at":"2018-02-01T05:43:17Z","git_url":"git://github.com/sid2364/pbspro.git","ssh_url":"git@github.com:sid2364/pbspro.git","clone_url":"https://github.com/sid2364/pbspro.git","svn_url":"https://github.com/sid2364/pbspro","homepage":"www.pbspro.org","size":10061,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PBSPro:master","ref":"master","sha":"e328499485688358ef64d8a73470bdb5d48fa3cc","user":{"login":"PBSPro","id":19280436,"avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"repo":{"id":59082072,"name":"pbspro","full_name":"PBSPro/pbspro","owner":{"login":"PBSPro","id":19280436,"avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PBSPro/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":false,"url":"https://api.github.com/repos/PBSPro/pbspro","forks_url":"https://api.github.com/repos/PBSPro/pbspro/forks","keys_url":"https://api.github.com/repos/PBSPro/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PBSPro/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PBSPro/pbspro/teams","hooks_url":"https://api.github.com/repos/PBSPro/pbspro/hooks","issue_events_url":"https://api.github.com/repos/PBSPro/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/PBSPro/pbspro/events","assignees_url":"https://api.github.com/repos/PBSPro/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/PBSPro/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/PBSPro/pbspro/tags","blobs_url":"https://api.github.com/repos/PBSPro/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PBSPro/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PBSPro/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/PBSPro/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/PBSPro/pbspro/languages","stargazers_url":"https://api.github.com/repos/PBSPro/pbspro/stargazers","contributors_url":"https://api.github.com/repos/PBSPro/pbspro/contributors","subscribers_url":"https://api.github.com/repos/PBSPro/pbspro/subscribers","subscription_url":"https://api.github.com/repos/PBSPro/pbspro/subscription","commits_url":"https://api.github.com/repos/PBSPro/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/PBSPro/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/PBSPro/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/PBSPro/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/PBSPro/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PBSPro/pbspro/merges","archive_url":"https://api.github.com/repos/PBSPro/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PBSPro/pbspro/downloads","issues_url":"https://api.github.com/repos/PBSPro/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/PBSPro/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/PBSPro/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/PBSPro/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PBSPro/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/PBSPro/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/PBSPro/pbspro/deployments","created_at":"2016-05-18T04:31:29Z","updated_at":"2018-01-31T05:42:26Z","pushed_at":"2018-02-01T18:57:21Z","git_url":"git://github.com/PBSPro/pbspro.git","ssh_url":"git@github.com:PBSPro/pbspro.git","clone_url":"https://github.com/PBSPro/pbspro.git","svn_url":"https://github.com/PBSPro/pbspro","homepage":"www.pbspro.org","size":10058,"stargazers_count":141,"watchers_count":141,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":124,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":124,"open_issues":16,"watchers":141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/536"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/536"},"issue":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/536"},"comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/536/comments"},"review_comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/536/comments"},"review_comment":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/536/commits"},"statuses":{"href":"https://api.github.com/repos/PBSPro/pbspro/statuses/c3370b5ce769a4417992a88622e044539aa23966"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bhroam"}}