{"action":"created","issue":{"url":"https://api.github.com/repos/molgenis/molgenis/issues/7357","repository_url":"https://api.github.com/repos/molgenis/molgenis","labels_url":"https://api.github.com/repos/molgenis/molgenis/issues/7357/labels{/name}","comments_url":"https://api.github.com/repos/molgenis/molgenis/issues/7357/comments","events_url":"https://api.github.com/repos/molgenis/molgenis/issues/7357/events","html_url":"https://github.com/molgenis/molgenis/pull/7357","id":321535659,"number":7357,"title":"Group/Role model changes","user":{"login":"tommydeboer","id":5362890,"avatar_url":"https://avatars2.githubusercontent.com/u/5362890?v=4","gravatar_id":"","url":"https://api.github.com/users/tommydeboer","html_url":"https://github.com/tommydeboer","followers_url":"https://api.github.com/users/tommydeboer/followers","following_url":"https://api.github.com/users/tommydeboer/following{/other_user}","gists_url":"https://api.github.com/users/tommydeboer/gists{/gist_id}","starred_url":"https://api.github.com/users/tommydeboer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommydeboer/subscriptions","organizations_url":"https://api.github.com/users/tommydeboer/orgs","repos_url":"https://api.github.com/users/tommydeboer/repos","events_url":"https://api.github.com/users/tommydeboer/events{/privacy}","received_events_url":"https://api.github.com/users/tommydeboer/received_events","type":"User","site_admin":false},"labels":[{"id":927632013,"url":"https://api.github.com/repos/molgenis/molgenis/labels/feature/group-model","name":"feature/group-model","color":"f9c577","default":false},{"id":571751313,"url":"https://api.github.com/repos/molgenis/molgenis/labels/work%20in%20progress","name":"work in progress","color":"e99695","default":false}],"state":"open","locked":false,"assignee":{"login":"fdlk","id":1523838,"avatar_url":"https://avatars2.githubusercontent.com/u/1523838?v=4","gravatar_id":"","url":"https://api.github.com/users/fdlk","html_url":"https://github.com/fdlk","followers_url":"https://api.github.com/users/fdlk/followers","following_url":"https://api.github.com/users/fdlk/following{/other_user}","gists_url":"https://api.github.com/users/fdlk/gists{/gist_id}","starred_url":"https://api.github.com/users/fdlk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdlk/subscriptions","organizations_url":"https://api.github.com/users/fdlk/orgs","repos_url":"https://api.github.com/users/fdlk/repos","events_url":"https://api.github.com/users/fdlk/events{/privacy}","received_events_url":"https://api.github.com/users/fdlk/received_events","type":"User","site_admin":false},"assignees":[{"login":"fdlk","id":1523838,"avatar_url":"https://avatars2.githubusercontent.com/u/1523838?v=4","gravatar_id":"","url":"https://api.github.com/users/fdlk","html_url":"https://github.com/fdlk","followers_url":"https://api.github.com/users/fdlk/followers","following_url":"https://api.github.com/users/fdlk/following{/other_user}","gists_url":"https://api.github.com/users/fdlk/gists{/gist_id}","starred_url":"https://api.github.com/users/fdlk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdlk/subscriptions","organizations_url":"https://api.github.com/users/fdlk/orgs","repos_url":"https://api.github.com/users/fdlk/repos","events_url":"https://api.github.com/users/fdlk/events{/privacy}","received_events_url":"https://api.github.com/users/fdlk/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-05-09T11:37:59Z","updated_at":"2018-05-15T19:42:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/molgenis/molgenis/pulls/7357","html_url":"https://github.com/molgenis/molgenis/pull/7357","diff_url":"https://github.com/molgenis/molgenis/pull/7357.diff","patch_url":"https://github.com/molgenis/molgenis/pull/7357.patch"},"body":"#### Checklist\r\n- [ ] Functionality works & meets specifications\r\n- [ ] Code reviewed\r\n- [ ] Code unit/integration/system tested\r\n- [ ] User documentation updated\r\n- [ ] (If you have changed REST API interface) view-swagger.ftl updated\r\n- [ ] Test plan template updated\r\n- [ ] Clean commits\r\n- [ ] Added Feature/Fix to release notes\r\n"},"comment":{"url":"https://api.github.com/repos/molgenis/molgenis/issues/comments/389289361","html_url":"https://github.com/molgenis/molgenis/pull/7357#issuecomment-389289361","issue_url":"https://api.github.com/repos/molgenis/molgenis/issues/7357","id":389289361,"user":{"login":"molgenis-jenkins","id":15369941,"avatar_url":"https://avatars2.githubusercontent.com/u/15369941?v=4","gravatar_id":"","url":"https://api.github.com/users/molgenis-jenkins","html_url":"https://github.com/molgenis-jenkins","followers_url":"https://api.github.com/users/molgenis-jenkins/followers","following_url":"https://api.github.com/users/molgenis-jenkins/following{/other_user}","gists_url":"https://api.github.com/users/molgenis-jenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/molgenis-jenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molgenis-jenkins/subscriptions","organizations_url":"https://api.github.com/users/molgenis-jenkins/orgs","repos_url":"https://api.github.com/users/molgenis-jenkins/repos","events_url":"https://api.github.com/users/molgenis-jenkins/events{/privacy}","received_events_url":"https://api.github.com/users/molgenis-jenkins/received_events","type":"User","site_admin":false},"created_at":"2018-05-15T19:42:41Z","updated_at":"2018-05-15T19:42:41Z","author_association":"CONTRIBUTOR","body":"SonarQube analysis reported 46 issues\n* ![CRITICAL][CRITICAL] 13 critical\n* ![MAJOR][MAJOR] 6 major\n* ![MINOR][MINOR] 25 minor\n* ![INFO][INFO] 2 info\n\nWatch the comments in this conversation to review them.\n\n#### Top 10 extra issues\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![CRITICAL][CRITICAL] [PermissionManagerController.java#L299](https://github.com/molgenis/molgenis/blob/5432712e7888aca64dcb9fd5fefced765a0e8651/molgenis-core-ui/src/main/java/org/molgenis/core/ui/admin/permission/PermissionManagerController.java#L299): Define a constant instead of duplicating this literal \"radio-\" 3 times. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1192)\n1. ![CRITICAL][CRITICAL] [UserManagerController.java#L55](https://github.com/molgenis/molgenis/blob/5432712e7888aca64dcb9fd5fefced765a0e8651/molgenis-core-ui/src/main/java/org/molgenis/core/ui/admin/usermanager/UserManagerController.java#L55): Use already-defined constant 'VIEW_STATE' instead of duplicating its value here. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1192)\n1. ![CRITICAL][CRITICAL] [ValidationResultWizardPage.java#L30](https://github.com/molgenis/molgenis/blob/5432712e7888aca64dcb9fd5fefced765a0e8651/molgenis-core-ui/src/main/java/org/molgenis/core/ui/data/importer/wizard/ValidationResultWizardPage.java#L30): Make \"asyncImportJobs\" transient or serializable. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1948)\n1. ![CRITICAL][CRITICAL] [ValidationResultWizardPage.java#L33](https://github.com/molgenis/molgenis/blob/5432712e7888aca64dcb9fd5fefced765a0e8651/molgenis-core-ui/src/main/java/org/molgenis/core/ui/data/importer/wizard/ValidationResultWizardPage.java#L33): Make \"importServiceFactory\" transient or serializable. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1948)\n1. ![CRITICAL][CRITICAL] [MolgenisWebAppSecurityConfig.java#L250](https://github.com/molgenis/molgenis/blob/5432712e7888aca64dcb9fd5fefced765a0e8651/molgenis-security/src/main/java/org/molgenis/security/MolgenisWebAppSecurityConfig.java#L250): Define a constant instead of duplicating this literal \"continueWithUnsupportedBrowser\" 3 times. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1192)\n1. ![CRITICAL][CRITICAL] [GoogleAuthenticationProcessingFilter.java#L117](https://github.com/molgenis/molgenis/blob/5432712e7888aca64dcb9fd5fefced765a0e8651/molgenis-security/src/main/java/org/molgenis/security/google/GoogleAuthenticationProcessingFilter.java#L117): Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS3776)\n1. ![CRITICAL][CRITICAL] [UserAccountService.java#L8](https://github.com/molgenis/molgenis/blob/5432712e7888aca64dcb9fd5fefced765a0e8651/molgenis-security/src/main/java/org/molgenis/security/user/UserAccountService.java#L8): Move constants to a class or enum. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1214)\n1. ![MAJOR][MAJOR] [UsersGroupsPopulatorImpl.java#L51](https://github.com/molgenis/molgenis/blob/5432712e7888aca64dcb9fd5fefced765a0e8651/molgenis-bootstrap/src/main/java/org/molgenis/bootstrap/populate/UsersGroupsPopulatorImpl.java#L51): Define and throw a dedicated exception instead of using a generic one. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS00112)\n1. ![MAJOR][MAJOR] [SecurityUtils.java#L12](https://github.com/molgenis/molgenis/blob/5432712e7888aca64dcb9fd5fefced765a0e8651/molgenis-security-core/src/main/java/org/molgenis/security/core/utils/SecurityUtils.java#L12): Add a private constructor to hide the implicit public one. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS1118)\n1. ![MAJOR][MAJOR] [MolgenisWebAppSecurityConfig.java#L433](https://github.com/molgenis/molgenis/blob/5432712e7888aca64dcb9fd5fefced765a0e8651/molgenis-security/src/main/java/org/molgenis/security/MolgenisWebAppSecurityConfig.java#L433): Define and throw a dedicated exception instead of using a generic one. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS00112)\n\n[CRITICAL]: https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL'\n[INFO]: https://sonarsource.github.io/sonar-github/severity-info.png 'Severity: INFO'\n[MAJOR]: https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR'\n[MINOR]: https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"molgenis-jenkins"}}