{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/211513451","pull_request_review_id":147945882,"id":211513451,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTUxMzQ1MQ==","diff_hunk":"@@ -32,6 +32,20 @@ import (\n  ATTENTION: Rerun code generators when comments on structs or fields are modified.\n */\n \n+// Represents a disk created on the cluster level","path":"pkg/api/v1/schema.go","position":4,"original_position":4,"commit_id":"615357ffdab9651a0585830fc3260cb58cec1308","original_commit_id":"615357ffdab9651a0585830fc3260cb58cec1308","user":{"login":"mfranczy","id":27352691,"node_id":"MDQ6VXNlcjI3MzUyNjkx","avatar_url":"https://avatars3.githubusercontent.com/u/27352691?v=4","gravatar_id":"","url":"https://api.github.com/users/mfranczy","html_url":"https://github.com/mfranczy","followers_url":"https://api.github.com/users/mfranczy/followers","following_url":"https://api.github.com/users/mfranczy/following{/other_user}","gists_url":"https://api.github.com/users/mfranczy/gists{/gist_id}","starred_url":"https://api.github.com/users/mfranczy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfranczy/subscriptions","organizations_url":"https://api.github.com/users/mfranczy/orgs","repos_url":"https://api.github.com/users/mfranczy/repos","events_url":"https://api.github.com/users/mfranczy/events{/privacy}","received_events_url":"https://api.github.com/users/mfranczy/received_events","type":"User","site_admin":false},"body":"Yes, you're right, I will change that, it's on the node.","created_at":"2018-08-21T08:07:37Z","updated_at":"2018-08-21T08:07:37Z","html_url":"https://github.com/kubevirt/kubevirt/pull/1349#discussion_r211513451","pull_request_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1349","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/211513451"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/1349#discussion_r211513451"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1349"}},"in_reply_to_id":211270119},"pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1349","id":202603461,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNjAzNDYx","html_url":"https://github.com/kubevirt/kubevirt/pull/1349","diff_url":"https://github.com/kubevirt/kubevirt/pull/1349.diff","patch_url":"https://github.com/kubevirt/kubevirt/pull/1349.patch","issue_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1349","number":1349,"state":"open","locked":false,"title":"Initialize disk.img for empty persistent volume claims attached to vm","user":{"login":"mfranczy","id":27352691,"node_id":"MDQ6VXNlcjI3MzUyNjkx","avatar_url":"https://avatars3.githubusercontent.com/u/27352691?v=4","gravatar_id":"","url":"https://api.github.com/users/mfranczy","html_url":"https://github.com/mfranczy","followers_url":"https://api.github.com/users/mfranczy/followers","following_url":"https://api.github.com/users/mfranczy/following{/other_user}","gists_url":"https://api.github.com/users/mfranczy/gists{/gist_id}","starred_url":"https://api.github.com/users/mfranczy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfranczy/subscriptions","organizations_url":"https://api.github.com/users/mfranczy/orgs","repos_url":"https://api.github.com/users/mfranczy/repos","events_url":"https://api.github.com/users/mfranczy/events{/privacy}","received_events_url":"https://api.github.com/users/mfranczy/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. Follow the instructions for writing a release note from k8s: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nIt gives possibility to attach empty PVC to VM without manually created disk.img\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #991\r\n\r\n**Special notes for your reviewer**:\r\nAfter talk with @rmohr we have decided to add new volume source type\r\nwhich is host disk that is created based on defined PVC.\r\n\r\nScenario:\r\n1. user is attaching empty PVC to vm\r\n2. virt-handler is checking size of the PVC (it has to do that, I don't have this information)\r\n3. virt-handler is changing PVC to HostDisk (it initializes new HostDisk structure)\r\n4. virt-launcher is checking if vmi object has HostDisk volume defined\r\n5. virt-launcher is checking if disk.img exists, if not, then disk.img will be created and saved on the host\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\n\r\n```\r\n","created_at":"2018-07-19T15:42:58Z","updated_at":"2018-08-21T08:07:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5654c795af90d6892f948f8609b8b40675373ae0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":685000214,"node_id":"MDU6TGFiZWw2ODUwMDAyMTQ=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"e11d21","default":false},{"id":802030280,"node_id":"MDU6TGFiZWw4MDIwMzAyODA=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1349/commits","review_comments_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1349/comments","review_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1349/comments","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/615357ffdab9651a0585830fc3260cb58cec1308","head":{"label":"mfranczy:initialize-empty-fs-based-pvs","ref":"initialize-empty-fs-based-pvs","sha":"615357ffdab9651a0585830fc3260cb58cec1308","user":{"login":"mfranczy","id":27352691,"node_id":"MDQ6VXNlcjI3MzUyNjkx","avatar_url":"https://avatars3.githubusercontent.com/u/27352691?v=4","gravatar_id":"","url":"https://api.github.com/users/mfranczy","html_url":"https://github.com/mfranczy","followers_url":"https://api.github.com/users/mfranczy/followers","following_url":"https://api.github.com/users/mfranczy/following{/other_user}","gists_url":"https://api.github.com/users/mfranczy/gists{/gist_id}","starred_url":"https://api.github.com/users/mfranczy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfranczy/subscriptions","organizations_url":"https://api.github.com/users/mfranczy/orgs","repos_url":"https://api.github.com/users/mfranczy/repos","events_url":"https://api.github.com/users/mfranczy/events{/privacy}","received_events_url":"https://api.github.com/users/mfranczy/received_events","type":"User","site_admin":false},"repo":{"id":135268431,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUyNjg0MzE=","name":"kubevirt","full_name":"mfranczy/kubevirt","owner":{"login":"mfranczy","id":27352691,"node_id":"MDQ6VXNlcjI3MzUyNjkx","avatar_url":"https://avatars3.githubusercontent.com/u/27352691?v=4","gravatar_id":"","url":"https://api.github.com/users/mfranczy","html_url":"https://github.com/mfranczy","followers_url":"https://api.github.com/users/mfranczy/followers","following_url":"https://api.github.com/users/mfranczy/following{/other_user}","gists_url":"https://api.github.com/users/mfranczy/gists{/gist_id}","starred_url":"https://api.github.com/users/mfranczy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfranczy/subscriptions","organizations_url":"https://api.github.com/users/mfranczy/orgs","repos_url":"https://api.github.com/users/mfranczy/repos","events_url":"https://api.github.com/users/mfranczy/events{/privacy}","received_events_url":"https://api.github.com/users/mfranczy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfranczy/kubevirt","description":"Kubernetes Virtualization Operator with API and runtime in order to define and manage virtual machines.","fork":true,"url":"https://api.github.com/repos/mfranczy/kubevirt","forks_url":"https://api.github.com/repos/mfranczy/kubevirt/forks","keys_url":"https://api.github.com/repos/mfranczy/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfranczy/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfranczy/kubevirt/teams","hooks_url":"https://api.github.com/repos/mfranczy/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/mfranczy/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/mfranczy/kubevirt/events","assignees_url":"https://api.github.com/repos/mfranczy/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/mfranczy/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/mfranczy/kubevirt/tags","blobs_url":"https://api.github.com/repos/mfranczy/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfranczy/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfranczy/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfranczy/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfranczy/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/mfranczy/kubevirt/languages","stargazers_url":"https://api.github.com/repos/mfranczy/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/mfranczy/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/mfranczy/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/mfranczy/kubevirt/subscription","commits_url":"https://api.github.com/repos/mfranczy/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfranczy/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfranczy/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfranczy/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfranczy/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/mfranczy/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfranczy/kubevirt/merges","archive_url":"https://api.github.com/repos/mfranczy/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfranczy/kubevirt/downloads","issues_url":"https://api.github.com/repos/mfranczy/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/mfranczy/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/mfranczy/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/mfranczy/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfranczy/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/mfranczy/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/mfranczy/kubevirt/deployments","created_at":"2018-05-29T08:52:57Z","updated_at":"2018-08-15T09:25:01Z","pushed_at":"2018-08-15T09:24:58Z","git_url":"git://github.com/mfranczy/kubevirt.git","ssh_url":"git@github.com:mfranczy/kubevirt.git","clone_url":"https://github.com/mfranczy/kubevirt.git","svn_url":"https://github.com/mfranczy/kubevirt","homepage":"","size":83830,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"c228bd96c4654786332b9bcbc898d962509eb563","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":76686583,"node_id":"MDEwOlJlcG9zaXRvcnk3NjY4NjU4Mw==","name":"kubevirt","full_name":"kubevirt/kubevirt","owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubevirt/kubevirt","description":"Kubernetes Virtualization Operator with API and runtime in order to define and manage virtual machines.","fork":false,"url":"https://api.github.com/repos/kubevirt/kubevirt","forks_url":"https://api.github.com/repos/kubevirt/kubevirt/forks","keys_url":"https://api.github.com/repos/kubevirt/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/kubevirt/teams","hooks_url":"https://api.github.com/repos/kubevirt/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/kubevirt/events","assignees_url":"https://api.github.com/repos/kubevirt/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/kubevirt/tags","blobs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/kubevirt/languages","stargazers_url":"https://api.github.com/repos/kubevirt/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/kubevirt/subscription","commits_url":"https://api.github.com/repos/kubevirt/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/kubevirt/merges","archive_url":"https://api.github.com/repos/kubevirt/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/kubevirt/downloads","issues_url":"https://api.github.com/repos/kubevirt/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/kubevirt/deployments","created_at":"2016-12-16T21:24:26Z","updated_at":"2018-08-20T15:24:11Z","pushed_at":"2018-08-21T02:01:27Z","git_url":"git://github.com/kubevirt/kubevirt.git","ssh_url":"git@github.com:kubevirt/kubevirt.git","clone_url":"https://github.com/kubevirt/kubevirt.git","svn_url":"https://github.com/kubevirt/kubevirt","homepage":"","size":84001,"stargazers_count":806,"watchers_count":806,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":174,"mirror_url":null,"archived":false,"open_issues_count":161,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":174,"open_issues":161,"watchers":806,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1349"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/1349"},"issue":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/1349"},"comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/1349/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1349/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1349/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/kubevirt/statuses/615357ffdab9651a0585830fc3260cb58cec1308"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mfranczy"}}