{"action":"created","issue":{"url":"https://api.github.com/repos/Nethereum/Nethereum/issues/473","repository_url":"https://api.github.com/repos/Nethereum/Nethereum","labels_url":"https://api.github.com/repos/Nethereum/Nethereum/issues/473/labels{/name}","comments_url":"https://api.github.com/repos/Nethereum/Nethereum/issues/473/comments","events_url":"https://api.github.com/repos/Nethereum/Nethereum/issues/473/events","html_url":"https://github.com/Nethereum/Nethereum/pull/473","id":386646514,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MzE3MDg4","number":473,"title":"Wired010/subscriptions","user":{"login":"wired010","id":2018363,"node_id":"MDQ6VXNlcjIwMTgzNjM=","avatar_url":"https://avatars0.githubusercontent.com/u/2018363?v=4","gravatar_id":"","url":"https://api.github.com/users/wired010","html_url":"https://github.com/wired010","followers_url":"https://api.github.com/users/wired010/followers","following_url":"https://api.github.com/users/wired010/following{/other_user}","gists_url":"https://api.github.com/users/wired010/gists{/gist_id}","starred_url":"https://api.github.com/users/wired010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wired010/subscriptions","organizations_url":"https://api.github.com/users/wired010/orgs","repos_url":"https://api.github.com/users/wired010/repos","events_url":"https://api.github.com/users/wired010/events{/privacy}","received_events_url":"https://api.github.com/users/wired010/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-03T03:33:26Z","updated_at":"2018-12-03T09:31:13Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Nethereum/Nethereum/pulls/473","html_url":"https://github.com/Nethereum/Nethereum/pull/473","diff_url":"https://github.com/Nethereum/Nethereum/pull/473.diff","patch_url":"https://github.com/Nethereum/Nethereum/pull/473.patch"},"body":"Added support for pendingTransaction subscription and newBlockHeaders\r\nsubscription. Since subscriptions aren't polling based, and they use\r\ntheir own RPC response format, a lot of plumbing and infrastructure code\r\nhad to be added to support the feature.\r\n\r\nWhere possible, existing code and infrastructure was refactored as\r\nlittle as possible to prevent any issues with backward compatibility.\r\n\r\nAs currently implemented, streaming data is handled via events, but in\r\nthe future, C# 8 features like IAsyncEnumerable could provide an\r\ninteresting way to consume these sorts of events.\r\n\r\nThere are 2 remaining subscriptions that could be implemented: syncing\r\nand logs. Based on the Web3JS implementation of subscriptions, these two\r\ntypes will be a little unique since they have custom handlers that are\r\ninvoked."},"comment":{"url":"https://api.github.com/repos/Nethereum/Nethereum/issues/comments/443644702","html_url":"https://github.com/Nethereum/Nethereum/pull/473#issuecomment-443644702","issue_url":"https://api.github.com/repos/Nethereum/Nethereum/issues/473","id":443644702,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzY0NDcwMg==","user":{"login":"juanfranblanco","id":562371,"node_id":"MDQ6VXNlcjU2MjM3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/562371?v=4","gravatar_id":"","url":"https://api.github.com/users/juanfranblanco","html_url":"https://github.com/juanfranblanco","followers_url":"https://api.github.com/users/juanfranblanco/followers","following_url":"https://api.github.com/users/juanfranblanco/following{/other_user}","gists_url":"https://api.github.com/users/juanfranblanco/gists{/gist_id}","starred_url":"https://api.github.com/users/juanfranblanco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juanfranblanco/subscriptions","organizations_url":"https://api.github.com/users/juanfranblanco/orgs","repos_url":"https://api.github.com/users/juanfranblanco/repos","events_url":"https://api.github.com/users/juanfranblanco/events{/privacy}","received_events_url":"https://api.github.com/users/juanfranblanco/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T09:31:13Z","updated_at":"2018-12-03T09:31:13Z","author_association":"MEMBER","body":"This is awesome, I was actually working on this in the background but I do like your implementation it is more integrate (although I need to have a better look).\r\n\r\nOne thing some websockets subscriptions are specific only for Geth /Parity but that is for the future. PendingTransactions is in both"}}
{"actor":{"display_login":"juanfranblanco"}}