{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/191541037","pull_request_review_id":124133193,"id":191541037,"diff_hunk":"@@ -91,6 +91,15 @@ class base_blob\n                ((uint64_t)ptr[7]) << 56;\n     }\n \n+    uint32_t GetUint32(int pos) const\n+    {\n+        const uint8_t* ptr = data + pos * 8;","path":"src/uint256.h","position":6,"original_position":6,"commit_id":"21f67ff4f0d405e085e2ff42a1f80529959bccaa","original_commit_id":"21f67ff4f0d405e085e2ff42a1f80529959bccaa","user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars0.githubusercontent.com/u/126646?v=4","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"body":"why *8? that doesn't look in line with 32 bit values.\r\n\r\nAlso, please add `LE` to make clear that this is always little-endian.","created_at":"2018-05-29T19:13:55Z","updated_at":"2018-05-29T19:13:55Z","html_url":"https://github.com/bitcoin/bitcoin/pull/12136#discussion_r191541037","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12136","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/191541037"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/12136#discussion_r191541037"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12136"}}},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12136","id":162032620,"html_url":"https://github.com/bitcoin/bitcoin/pull/12136","diff_url":"https://github.com/bitcoin/bitcoin/pull/12136.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/12136.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12136","number":12136,"state":"open","locked":false,"title":"Implement BIP 174 Partially Signed Bitcoin Transactions","user":{"login":"achow101","id":3782274,"avatar_url":"https://avatars3.githubusercontent.com/u/3782274?v=4","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","site_admin":false},"body":"[BIP 174](https://github.com/bitcoin/bips/blob/master/bip-0174.mediawiki) specifies a binary transaction format which contains the information necessary for a signer to produce signatures for the transaction and holds the signatures for an input while the input does not have a complete set of signatures.\r\n\r\n***\r\n\r\nBIP 174 is fully implemented in this pull request. It contains a struct for the a PSBT, serialization and deserialization functions, and a PSBT specific versions of `ProduceSignature` (`SignPartialTransaction`), `SignStep`(`SignSigsOnly`) and `CombineSignatures`(FinalizePartialTransaction`).\r\n\r\nCurrently PSBT functionality is limited to 4 new RPC calls, `walletupdatepsbt`, `walletcreatepsbt`, `combinepsbt`, and `decodepsbt`.\r\n\r\n`walletupdatepsbt` updates a given PSBT with data from the wallet. For each input, it will attempt to add the proper UTXO, sign for the input, and finalize the input. It will also add any known redeem scripts, witness scripts, and public key derivation paths if they are known to the wallet.\r\n\r\n`walletcreatepsbt` takes a network serialized raw transaction as produced by the `*rawtransaction` commands and converts it to a PSBT. Inputs are filled using information known to the wallet.\r\n\r\n`combinepsbt` combines multiple PSBTs and finalizes them if possible.\r\n\r\n`decodepsbt` decodes a PSBT and into a human readable format in order to more easily examine them. It is analogous to `decoderawtransaction`.\r\n\r\n***\r\n\r\nAll of the test vectors currently in BIP 174 are also implemented.","created_at":"2018-01-10T04:08:39Z","updated_at":"2018-05-29T19:13:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"de74c48d1226634746cbbd2f7ae076309783f9d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":192202000,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Consensus","name":"Consensus","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12136/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12136/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/12136/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/21f67ff4f0d405e085e2ff42a1f80529959bccaa","head":{"label":"achow101:psbt","ref":"psbt","sha":"21f67ff4f0d405e085e2ff42a1f80529959bccaa","user":{"login":"achow101","id":3782274,"avatar_url":"https://avatars3.githubusercontent.com/u/3782274?v=4","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","site_admin":false},"repo":{"id":45006379,"name":"bitcoin","full_name":"achow101/bitcoin","owner":{"login":"achow101","id":3782274,"avatar_url":"https://avatars3.githubusercontent.com/u/3782274?v=4","gravatar_id":"","url":"https://api.github.com/users/achow101","html_url":"https://github.com/achow101","followers_url":"https://api.github.com/users/achow101/followers","following_url":"https://api.github.com/users/achow101/following{/other_user}","gists_url":"https://api.github.com/users/achow101/gists{/gist_id}","starred_url":"https://api.github.com/users/achow101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/achow101/subscriptions","organizations_url":"https://api.github.com/users/achow101/orgs","repos_url":"https://api.github.com/users/achow101/repos","events_url":"https://api.github.com/users/achow101/events{/privacy}","received_events_url":"https://api.github.com/users/achow101/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/achow101/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/achow101/bitcoin","forks_url":"https://api.github.com/repos/achow101/bitcoin/forks","keys_url":"https://api.github.com/repos/achow101/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/achow101/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/achow101/bitcoin/teams","hooks_url":"https://api.github.com/repos/achow101/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/achow101/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/achow101/bitcoin/events","assignees_url":"https://api.github.com/repos/achow101/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/achow101/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/achow101/bitcoin/tags","blobs_url":"https://api.github.com/repos/achow101/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/achow101/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/achow101/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/achow101/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/achow101/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/achow101/bitcoin/languages","stargazers_url":"https://api.github.com/repos/achow101/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/achow101/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/achow101/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/achow101/bitcoin/subscription","commits_url":"https://api.github.com/repos/achow101/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/achow101/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/achow101/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/achow101/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/achow101/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/achow101/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/achow101/bitcoin/merges","archive_url":"https://api.github.com/repos/achow101/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/achow101/bitcoin/downloads","issues_url":"https://api.github.com/repos/achow101/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/achow101/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/achow101/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/achow101/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/achow101/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/achow101/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/achow101/bitcoin/deployments","created_at":"2015-10-27T00:20:28Z","updated_at":"2018-04-30T13:49:22Z","pushed_at":"2018-05-26T05:02:17Z","git_url":"git://github.com/achow101/bitcoin.git","ssh_url":"git@github.com:achow101/bitcoin.git","clone_url":"https://github.com/achow101/bitcoin.git","svn_url":"https://github.com/achow101/bitcoin","homepage":"https://bitcoin.org/en/download","size":108177,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"610f4dd719ad690cde480b12665d2ba74284a826","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2018-05-29T18:48:21Z","pushed_at":"2018-05-29T18:14:43Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":106286,"stargazers_count":31917,"watchers_count":31917,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":19214,"mirror_url":null,"archived":false,"open_issues_count":792,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":19214,"open_issues":792,"watchers":31917,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12136"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/12136"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/12136"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/12136/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12136/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/12136/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/21f67ff4f0d405e085e2ff42a1f80529959bccaa"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"laanwj"}}