{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/209450343","pull_request_review_id":145469770,"id":209450343,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQ1MDM0Mw==","diff_hunk":"@@ -18,32 +18,42 @@ stdenv.mkDerivation rec {\n   nativeBuildInputs = [ cmake ninja llvm pkgconfig intltool perl desktop-file-utils wrapGAppsHook ];\n \n   buildInputs = [\n-    cairo curl exiv2 glib gtk3 ilmbase lcms2 lensfun libX11 libexif\n+    cairo curl exiv2 glib gtk3 ilmbase lcms2 lensfun libexif\n     libgphoto2 libjpeg libpng librsvg libtiff openexr sqlite libxslt\n     libsoup graphicsmagick json-glib openjpeg lua pugixml\n-    colord colord-gtk libwebp libsecret gnome3.adwaita-icon-theme\n-    osm-gps-map ocl-icd\n-  ];\n-    \n+    libwebp libsecret gnome3.adwaita-icon-theme osm-gps-map pcre\n+  ] ++ stdenv.lib.optionals stdenv.isLinux [\n+    colord colord-gtk libX11 ocl-icd\n+  ] ++ stdenv.lib.optional stdenv.isDarwin gtk-mac-integration;\n+\n   cmakeFlags = [\n     \"-DBUILD_USERMANUAL=False\"\n+  ] ++ stdenv.lib.optionals stdenv.isDarwin [\n+    \"-DUSE_COLORD=OFF\"\n+    \"-DUSE_KWALLET=OFF\"\n   ];\n \n+  ldLibraryPathPrefix = \"$out/lib/darktable\" + stdenv.lib.optionalString stdenv.isLinux \":${ocl-icd}/lib\";","path":"pkgs/applications/graphics/darktable/default.nix","position":33,"original_position":33,"commit_id":"785efed7fdae70ba056752c39020ff08e639265f","original_commit_id":"785efed7fdae70ba056752c39020ff08e639265f","user":{"login":"LnL7","id":689294,"node_id":"MDQ6VXNlcjY4OTI5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/689294?v=4","gravatar_id":"","url":"https://api.github.com/users/LnL7","html_url":"https://github.com/LnL7","followers_url":"https://api.github.com/users/LnL7/followers","following_url":"https://api.github.com/users/LnL7/following{/other_user}","gists_url":"https://api.github.com/users/LnL7/gists{/gist_id}","starred_url":"https://api.github.com/users/LnL7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LnL7/subscriptions","organizations_url":"https://api.github.com/users/LnL7/orgs","repos_url":"https://api.github.com/users/LnL7/repos","events_url":"https://api.github.com/users/LnL7/events{/privacy}","received_events_url":"https://api.github.com/users/LnL7/received_events","type":"User","site_admin":false},"body":"I would move this into a let statement.","created_at":"2018-08-12T10:28:20Z","updated_at":"2018-08-12T10:50:19Z","html_url":"https://github.com/NixOS/nixpkgs/pull/44922#discussion_r209450343","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44922","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/209450343"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/44922#discussion_r209450343"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44922"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44922","id":207803710,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODAzNzEw","html_url":"https://github.com/NixOS/nixpkgs/pull/44922","diff_url":"https://github.com/NixOS/nixpkgs/pull/44922.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/44922.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44922","number":44922,"state":"open","locked":false,"title":"darktable: Fix compilation on macOS","user":{"login":"Enzime","id":10492681,"node_id":"MDQ6VXNlcjEwNDkyNjgx","avatar_url":"https://avatars0.githubusercontent.com/u/10492681?v=4","gravatar_id":"","url":"https://api.github.com/users/Enzime","html_url":"https://github.com/Enzime","followers_url":"https://api.github.com/users/Enzime/followers","following_url":"https://api.github.com/users/Enzime/following{/other_user}","gists_url":"https://api.github.com/users/Enzime/gists{/gist_id}","starred_url":"https://api.github.com/users/Enzime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Enzime/subscriptions","organizations_url":"https://api.github.com/users/Enzime/orgs","repos_url":"https://api.github.com/users/Enzime/repos","events_url":"https://api.github.com/users/Enzime/events{/privacy}","received_events_url":"https://api.github.com/users/Enzime/received_events","type":"User","site_admin":false},"body":"###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested without sandbox on macOS\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-08-12T04:05:44Z","updated_at":"2018-08-12T10:50:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9383f48fc7a79ac1c7ca41b1cef2e03b32f2406c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":90308187,"node_id":"MDU6TGFiZWw5MDMwODE4Nw==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20darwin","name":"6.topic: darwin","color":"fef2c0","default":false},{"id":290122734,"node_id":"MDU6TGFiZWwyOTAxMjI3MzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44922/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44922/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44922/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/785efed7fdae70ba056752c39020ff08e639265f","head":{"label":"Enzime:fix/darktable-on-macos","ref":"fix/darktable-on-macos","sha":"785efed7fdae70ba056752c39020ff08e639265f","user":{"login":"Enzime","id":10492681,"node_id":"MDQ6VXNlcjEwNDkyNjgx","avatar_url":"https://avatars0.githubusercontent.com/u/10492681?v=4","gravatar_id":"","url":"https://api.github.com/users/Enzime","html_url":"https://github.com/Enzime","followers_url":"https://api.github.com/users/Enzime/followers","following_url":"https://api.github.com/users/Enzime/following{/other_user}","gists_url":"https://api.github.com/users/Enzime/gists{/gist_id}","starred_url":"https://api.github.com/users/Enzime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Enzime/subscriptions","organizations_url":"https://api.github.com/users/Enzime/orgs","repos_url":"https://api.github.com/users/Enzime/repos","events_url":"https://api.github.com/users/Enzime/events{/privacy}","received_events_url":"https://api.github.com/users/Enzime/received_events","type":"User","site_admin":false},"repo":{"id":99398545,"node_id":"MDEwOlJlcG9zaXRvcnk5OTM5ODU0NQ==","name":"nixpkgs","full_name":"Enzime/nixpkgs","owner":{"login":"Enzime","id":10492681,"node_id":"MDQ6VXNlcjEwNDkyNjgx","avatar_url":"https://avatars0.githubusercontent.com/u/10492681?v=4","gravatar_id":"","url":"https://api.github.com/users/Enzime","html_url":"https://github.com/Enzime","followers_url":"https://api.github.com/users/Enzime/followers","following_url":"https://api.github.com/users/Enzime/following{/other_user}","gists_url":"https://api.github.com/users/Enzime/gists{/gist_id}","starred_url":"https://api.github.com/users/Enzime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Enzime/subscriptions","organizations_url":"https://api.github.com/users/Enzime/orgs","repos_url":"https://api.github.com/users/Enzime/repos","events_url":"https://api.github.com/users/Enzime/events{/privacy}","received_events_url":"https://api.github.com/users/Enzime/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Enzime/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/Enzime/nixpkgs","forks_url":"https://api.github.com/repos/Enzime/nixpkgs/forks","keys_url":"https://api.github.com/repos/Enzime/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Enzime/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Enzime/nixpkgs/teams","hooks_url":"https://api.github.com/repos/Enzime/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/Enzime/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/Enzime/nixpkgs/events","assignees_url":"https://api.github.com/repos/Enzime/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/Enzime/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/Enzime/nixpkgs/tags","blobs_url":"https://api.github.com/repos/Enzime/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Enzime/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Enzime/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Enzime/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Enzime/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/Enzime/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/Enzime/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/Enzime/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/Enzime/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/Enzime/nixpkgs/subscription","commits_url":"https://api.github.com/repos/Enzime/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Enzime/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Enzime/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Enzime/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Enzime/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/Enzime/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Enzime/nixpkgs/merges","archive_url":"https://api.github.com/repos/Enzime/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Enzime/nixpkgs/downloads","issues_url":"https://api.github.com/repos/Enzime/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/Enzime/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/Enzime/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/Enzime/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Enzime/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/Enzime/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/Enzime/nixpkgs/deployments","created_at":"2017-08-05T04:17:38Z","updated_at":"2018-08-11T05:26:46Z","pushed_at":"2018-08-12T04:00:49Z","git_url":"git://github.com/Enzime/nixpkgs.git","ssh_url":"git@github.com:Enzime/nixpkgs.git","clone_url":"https://github.com/Enzime/nixpkgs.git","svn_url":"https://github.com/Enzime/nixpkgs","homepage":null,"size":726325,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"bb3f7d14a17e88e4341872c55d8b32127c6f8101","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-08-12T10:19:48Z","pushed_at":"2018-08-12T10:49:40Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":834755,"stargazers_count":2644,"watchers_count":2644,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2939,"mirror_url":null,"archived":false,"open_issues_count":3122,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2939,"open_issues":3122,"watchers":2644,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44922"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/44922"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/44922"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/44922/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44922/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44922/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/785efed7fdae70ba056752c39020ff08e639265f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"LnL7"}}