{"action":"created","comment":{"url":"https://api.github.com/repos/percona/percona-server/pulls/comments/182039033","pull_request_review_id":112766835,"id":182039033,"diff_hunk":"@@ -427,7 +427,11 @@ void Optimize_table_order::best_access_path(\n     idx == join->const_tables ||                                     // 1\n     !thd->optimizer_switch_flag(OPTIMIZER_SWITCH_BNL);               // 2\n \n+// See the comment at Loose_scan_opt::Loose_scan_opt for why this warning has\n+// been left in the code intentionally\n+MY_DISABLE_WARN_MAYBE_UNINITIALIZED","path":"sql/sql_planner.cc","position":6,"original_position":6,"commit_id":"0ce9b7ba6f66b313d7d7ad176008834651dbf8d5","original_commit_id":"0ce9b7ba6f66b313d7d7ad176008834651dbf8d5","user":{"login":"percona-ysorokin","id":13441497,"avatar_url":"https://avatars1.githubusercontent.com/u/13441497?v=4","gravatar_id":"","url":"https://api.github.com/users/percona-ysorokin","html_url":"https://github.com/percona-ysorokin","followers_url":"https://api.github.com/users/percona-ysorokin/followers","following_url":"https://api.github.com/users/percona-ysorokin/following{/other_user}","gists_url":"https://api.github.com/users/percona-ysorokin/gists{/gist_id}","starred_url":"https://api.github.com/users/percona-ysorokin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona-ysorokin/subscriptions","organizations_url":"https://api.github.com/users/percona-ysorokin/orgs","repos_url":"https://api.github.com/users/percona-ysorokin/repos","events_url":"https://api.github.com/users/percona-ysorokin/events{/privacy}","received_events_url":"https://api.github.com/users/percona-ysorokin/received_events","type":"User","site_admin":false},"body":"Shouldn't this be put inside Loose_scan_opt's constructor?","created_at":"2018-04-17T11:28:10Z","updated_at":"2018-04-17T11:50:46Z","html_url":"https://github.com/percona/percona-server/pull/2325#discussion_r182039033","pull_request_url":"https://api.github.com/repos/percona/percona-server/pulls/2325","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments/182039033"},"html":{"href":"https://github.com/percona/percona-server/pull/2325#discussion_r182039033"},"pull_request":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2325"}}},"pull_request":{"url":"https://api.github.com/repos/percona/percona-server/pulls/2325","id":182099191,"html_url":"https://github.com/percona/percona-server/pull/2325","diff_url":"https://github.com/percona/percona-server/pull/2325.diff","patch_url":"https://github.com/percona/percona-server/pull/2325.patch","issue_url":"https://api.github.com/repos/percona/percona-server/issues/2325","number":2325,"state":"open","locked":false,"title":"PS-3950 (5.6): gcc-8 compilation warnings","user":{"login":"inikep","id":15112322,"avatar_url":"https://avatars3.githubusercontent.com/u/15112322?v=4","gravatar_id":"","url":"https://api.github.com/users/inikep","html_url":"https://github.com/inikep","followers_url":"https://api.github.com/users/inikep/followers","following_url":"https://api.github.com/users/inikep/following{/other_user}","gists_url":"https://api.github.com/users/inikep/gists{/gist_id}","starred_url":"https://api.github.com/users/inikep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inikep/subscriptions","organizations_url":"https://api.github.com/users/inikep/orgs","repos_url":"https://api.github.com/users/inikep/repos","events_url":"https://api.github.com/users/inikep/events{/privacy}","received_events_url":"https://api.github.com/users/inikep/received_events","type":"User","site_admin":false},"body":"1. Add gcc-8 to Travis config file\r\n2. Fix the following gcc-8 warnings:\r\n- cast between incompatible function types [-Werror=cast-function-type]\r\n- clearing an object with no trivial copy-assignment [-Werror=class-memaccess]\r\n- directive output may be truncated [-Werror=format-truncation=]\r\n\r\n(the commit will be cherry-picked forward to 5.7)","created_at":"2018-04-17T09:09:57Z","updated_at":"2018-04-17T11:50:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"590b22613d6b02624dcbe2c8318262f9cde107b5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/percona/percona-server/pulls/2325/commits","review_comments_url":"https://api.github.com/repos/percona/percona-server/pulls/2325/comments","review_comment_url":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/percona/percona-server/issues/2325/comments","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/0ce9b7ba6f66b313d7d7ad176008834651dbf8d5","head":{"label":"inikep:ps5.6-PS-3950","ref":"ps5.6-PS-3950","sha":"0ce9b7ba6f66b313d7d7ad176008834651dbf8d5","user":{"login":"inikep","id":15112322,"avatar_url":"https://avatars3.githubusercontent.com/u/15112322?v=4","gravatar_id":"","url":"https://api.github.com/users/inikep","html_url":"https://github.com/inikep","followers_url":"https://api.github.com/users/inikep/followers","following_url":"https://api.github.com/users/inikep/following{/other_user}","gists_url":"https://api.github.com/users/inikep/gists{/gist_id}","starred_url":"https://api.github.com/users/inikep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inikep/subscriptions","organizations_url":"https://api.github.com/users/inikep/orgs","repos_url":"https://api.github.com/users/inikep/repos","events_url":"https://api.github.com/users/inikep/events{/privacy}","received_events_url":"https://api.github.com/users/inikep/received_events","type":"User","site_admin":false},"repo":{"id":113457168,"name":"percona-server","full_name":"inikep/percona-server","owner":{"login":"inikep","id":15112322,"avatar_url":"https://avatars3.githubusercontent.com/u/15112322?v=4","gravatar_id":"","url":"https://api.github.com/users/inikep","html_url":"https://github.com/inikep","followers_url":"https://api.github.com/users/inikep/followers","following_url":"https://api.github.com/users/inikep/following{/other_user}","gists_url":"https://api.github.com/users/inikep/gists{/gist_id}","starred_url":"https://api.github.com/users/inikep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inikep/subscriptions","organizations_url":"https://api.github.com/users/inikep/orgs","repos_url":"https://api.github.com/users/inikep/repos","events_url":"https://api.github.com/users/inikep/events{/privacy}","received_events_url":"https://api.github.com/users/inikep/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inikep/percona-server","description":"Percona Server","fork":true,"url":"https://api.github.com/repos/inikep/percona-server","forks_url":"https://api.github.com/repos/inikep/percona-server/forks","keys_url":"https://api.github.com/repos/inikep/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inikep/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inikep/percona-server/teams","hooks_url":"https://api.github.com/repos/inikep/percona-server/hooks","issue_events_url":"https://api.github.com/repos/inikep/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/inikep/percona-server/events","assignees_url":"https://api.github.com/repos/inikep/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/inikep/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/inikep/percona-server/tags","blobs_url":"https://api.github.com/repos/inikep/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inikep/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inikep/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/inikep/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inikep/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/inikep/percona-server/languages","stargazers_url":"https://api.github.com/repos/inikep/percona-server/stargazers","contributors_url":"https://api.github.com/repos/inikep/percona-server/contributors","subscribers_url":"https://api.github.com/repos/inikep/percona-server/subscribers","subscription_url":"https://api.github.com/repos/inikep/percona-server/subscription","commits_url":"https://api.github.com/repos/inikep/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/inikep/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/inikep/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/inikep/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/inikep/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/inikep/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inikep/percona-server/merges","archive_url":"https://api.github.com/repos/inikep/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inikep/percona-server/downloads","issues_url":"https://api.github.com/repos/inikep/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/inikep/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/inikep/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/inikep/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inikep/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/inikep/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/inikep/percona-server/deployments","created_at":"2017-12-07T13:57:11Z","updated_at":"2017-12-07T13:58:41Z","pushed_at":"2018-04-17T09:05:35Z","git_url":"git://github.com/inikep/percona-server.git","ssh_url":"git@github.com:inikep/percona-server.git","clone_url":"https://github.com/inikep/percona-server.git","svn_url":"https://github.com/inikep/percona-server","homepage":"https://www.percona.com/software/mysql-database/percona-server","size":585368,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.7"}},"base":{"label":"percona:5.6","ref":"5.6","sha":"beb7724800d48fccf674f253c47bb9d298401cd7","user":{"login":"percona","id":1683025,"avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"repo":{"id":30753733,"name":"percona-server","full_name":"percona/percona-server","owner":{"login":"percona","id":1683025,"avatar_url":"https://avatars0.githubusercontent.com/u/1683025?v=4","gravatar_id":"","url":"https://api.github.com/users/percona","html_url":"https://github.com/percona","followers_url":"https://api.github.com/users/percona/followers","following_url":"https://api.github.com/users/percona/following{/other_user}","gists_url":"https://api.github.com/users/percona/gists{/gist_id}","starred_url":"https://api.github.com/users/percona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/percona/subscriptions","organizations_url":"https://api.github.com/users/percona/orgs","repos_url":"https://api.github.com/users/percona/repos","events_url":"https://api.github.com/users/percona/events{/privacy}","received_events_url":"https://api.github.com/users/percona/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/percona/percona-server","description":"Percona Server","fork":false,"url":"https://api.github.com/repos/percona/percona-server","forks_url":"https://api.github.com/repos/percona/percona-server/forks","keys_url":"https://api.github.com/repos/percona/percona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/percona/percona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/percona/percona-server/teams","hooks_url":"https://api.github.com/repos/percona/percona-server/hooks","issue_events_url":"https://api.github.com/repos/percona/percona-server/issues/events{/number}","events_url":"https://api.github.com/repos/percona/percona-server/events","assignees_url":"https://api.github.com/repos/percona/percona-server/assignees{/user}","branches_url":"https://api.github.com/repos/percona/percona-server/branches{/branch}","tags_url":"https://api.github.com/repos/percona/percona-server/tags","blobs_url":"https://api.github.com/repos/percona/percona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/percona/percona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/percona/percona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/percona/percona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/percona/percona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/percona/percona-server/languages","stargazers_url":"https://api.github.com/repos/percona/percona-server/stargazers","contributors_url":"https://api.github.com/repos/percona/percona-server/contributors","subscribers_url":"https://api.github.com/repos/percona/percona-server/subscribers","subscription_url":"https://api.github.com/repos/percona/percona-server/subscription","commits_url":"https://api.github.com/repos/percona/percona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/percona/percona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/percona/percona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/percona/percona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/percona/percona-server/contents/{+path}","compare_url":"https://api.github.com/repos/percona/percona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/percona/percona-server/merges","archive_url":"https://api.github.com/repos/percona/percona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/percona/percona-server/downloads","issues_url":"https://api.github.com/repos/percona/percona-server/issues{/number}","pulls_url":"https://api.github.com/repos/percona/percona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/percona/percona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/percona/percona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/percona/percona-server/labels{/name}","releases_url":"https://api.github.com/repos/percona/percona-server/releases{/id}","deployments_url":"https://api.github.com/repos/percona/percona-server/deployments","created_at":"2015-02-13T11:32:01Z","updated_at":"2018-04-17T06:19:44Z","pushed_at":"2018-04-17T09:09:57Z","git_url":"git://github.com/percona/percona-server.git","ssh_url":"git@github.com:percona/percona-server.git","clone_url":"https://github.com/percona/percona-server.git","svn_url":"https://github.com/percona/percona-server","homepage":"https://www.percona.com/software/mysql-database/percona-server","size":585403,"stargazers_count":417,"watchers_count":417,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":176,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":176,"open_issues":49,"watchers":417,"default_branch":"5.7"}},"_links":{"self":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2325"},"html":{"href":"https://github.com/percona/percona-server/pull/2325"},"issue":{"href":"https://api.github.com/repos/percona/percona-server/issues/2325"},"comments":{"href":"https://api.github.com/repos/percona/percona-server/issues/2325/comments"},"review_comments":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2325/comments"},"review_comment":{"href":"https://api.github.com/repos/percona/percona-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/percona/percona-server/pulls/2325/commits"},"statuses":{"href":"https://api.github.com/repos/percona/percona-server/statuses/0ce9b7ba6f66b313d7d7ad176008834651dbf8d5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"percona-ysorokin"}}