{"action":"created","issue":{"url":"https://api.github.com/repos/Graylog2/graylog2-server/issues/4729","repository_url":"https://api.github.com/repos/Graylog2/graylog2-server","labels_url":"https://api.github.com/repos/Graylog2/graylog2-server/issues/4729/labels{/name}","comments_url":"https://api.github.com/repos/Graylog2/graylog2-server/issues/4729/comments","events_url":"https://api.github.com/repos/Graylog2/graylog2-server/issues/4729/events","html_url":"https://github.com/Graylog2/graylog2-server/pull/4729","id":315055508,"number":4729,"title":"Kafka 1.0.1 compatibility changes","user":{"login":"muralibasani","id":10197247,"avatar_url":"https://avatars0.githubusercontent.com/u/10197247?v=4","gravatar_id":"","url":"https://api.github.com/users/muralibasani","html_url":"https://github.com/muralibasani","followers_url":"https://api.github.com/users/muralibasani/followers","following_url":"https://api.github.com/users/muralibasani/following{/other_user}","gists_url":"https://api.github.com/users/muralibasani/gists{/gist_id}","starred_url":"https://api.github.com/users/muralibasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muralibasani/subscriptions","organizations_url":"https://api.github.com/users/muralibasani/orgs","repos_url":"https://api.github.com/users/muralibasani/repos","events_url":"https://api.github.com/users/muralibasani/events{/privacy}","received_events_url":"https://api.github.com/users/muralibasani/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-17T13:17:36Z","updated_at":"2018-04-17T13:32:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Graylog2/graylog2-server/pulls/4729","html_url":"https://github.com/Graylog2/graylog2-server/pull/4729","diff_url":"https://github.com/Graylog2/graylog2-server/pull/4729.diff","patch_url":"https://github.com/Graylog2/graylog2-server/pull/4729.patch"},"body":"Currently Graylog2 is limited to run with Kafka 0.9.0.1 or lower versions. This change overcomes it, by being comptabile with newer version of kafka (1.0.1)., but downside is it is not compatible with old versions of Kafka (0.9.0.1)  or lower.\r\n\r\n## Description\r\n\r\n- Changes do not work with Kafka older versions (0.9.0.1 or lower)\r\n- Frontend Kafka inputs have new fields to accept SSL parameters, bootstrap servers, auto.offset.reset to earliest/latest instead of largest/smallest\r\n- In Frontend : based on if SSL i set to true or false, corresponding ssl parameters will be accepted. \r\n\r\n## Motivation and Context\r\nChange is required to make Graylog2 run with new Kafka version 1.0.1, and avail new features of it like ssl and better streaming capabilities.\r\n\r\n## How Has This Been Tested?\r\nTested with Multiple nodes, multiple partitions\r\nInstalled in Ubuntu and tested all changes\r\nOnly affects Kafka classes\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x ] New feature  New feature - Kafka new version 1.0.1, and SSL, with no backwards compatibility\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x ] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ x] I have updated the documentation accordingly.\r\n- [ x] I have read the **CONTRIBUTING** document.\r\n- [ x] I have added tests to cover my changes.\r\n- [ x] All new and existing tests passed.\r\n"},"comment":{"url":"https://api.github.com/repos/Graylog2/graylog2-server/issues/comments/381993564","html_url":"https://github.com/Graylog2/graylog2-server/pull/4729#issuecomment-381993564","issue_url":"https://api.github.com/repos/Graylog2/graylog2-server/issues/4729","id":381993564,"user":{"login":"joschi","id":43951,"avatar_url":"https://avatars1.githubusercontent.com/u/43951?v=4","gravatar_id":"","url":"https://api.github.com/users/joschi","html_url":"https://github.com/joschi","followers_url":"https://api.github.com/users/joschi/followers","following_url":"https://api.github.com/users/joschi/following{/other_user}","gists_url":"https://api.github.com/users/joschi/gists{/gist_id}","starred_url":"https://api.github.com/users/joschi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joschi/subscriptions","organizations_url":"https://api.github.com/users/joschi/orgs","repos_url":"https://api.github.com/users/joschi/repos","events_url":"https://api.github.com/users/joschi/events{/privacy}","received_events_url":"https://api.github.com/users/joschi/received_events","type":"User","site_admin":false},"created_at":"2018-04-17T13:32:40Z","updated_at":"2018-04-17T13:32:40Z","author_association":"OWNER","body":"@muralibasani I'm not sure about that but would it be possible to use a current version of org.apache.kafka:kafka-streams (or org.apache.kafka:kafka-clients) while keeping org.apache.kafka:kafka_2.11:0.9.0.1 to retain compatibility with the on-disk message journal?"}}
{"actor":{"display_login":"joschi"}}