{"action":"created","comment":{"url":"https://api.github.com/repos/linkerd/linkerd/pulls/comments/222852047","pull_request_review_id":161841221,"id":222852047,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjg1MjA0Nw==","diff_hunk":"@@ -360,6 +361,31 @@ object LinkerdBuild extends Base {\n          |  done\n          |fi\n          |export MALLOC_ARENA_MAX=2\n+         |\n+         |# Configure GC logging directory\n+         |if [ -z \"$GC_LOG\" ]; then\n+         |  GC_LOG=\"/var/log/namerd\"\n+         |fi\n+         |\n+         |mkdir -p \"$GC_LOG\" && touch \"$GC_LOG/gc.log\"","path":"project/LinkerdBuild.scala","position":18,"original_position":18,"commit_id":"eef0e7b8fd5de4860e9c81fceeec0a231817b38b","original_commit_id":"eef0e7b8fd5de4860e9c81fceeec0a231817b38b","user":{"login":"dadjeibaah","id":2197104,"node_id":"MDQ6VXNlcjIxOTcxMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2197104?v=4","gravatar_id":"","url":"https://api.github.com/users/dadjeibaah","html_url":"https://github.com/dadjeibaah","followers_url":"https://api.github.com/users/dadjeibaah/followers","following_url":"https://api.github.com/users/dadjeibaah/following{/other_user}","gists_url":"https://api.github.com/users/dadjeibaah/gists{/gist_id}","starred_url":"https://api.github.com/users/dadjeibaah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadjeibaah/subscriptions","organizations_url":"https://api.github.com/users/dadjeibaah/orgs","repos_url":"https://api.github.com/users/dadjeibaah/repos","events_url":"https://api.github.com/users/dadjeibaah/events{/privacy}","received_events_url":"https://api.github.com/users/dadjeibaah/received_events","type":"User","site_admin":false},"body":"Wanted to make a note about the the line `touch \"$GC_LOG/gc.log\"`. It looks like even `mkdir -p $GC_LOG` will have an exit status of 0 if the directory already exists and has strict permissions. We actually need to do an additional check to see if our process can create a file in the directory since that is what the JVM will do when its writing logs to that directory. ","created_at":"2018-10-04T22:58:50Z","updated_at":"2018-10-04T22:58:50Z","html_url":"https://github.com/linkerd/linkerd/pull/2119#discussion_r222852047","pull_request_url":"https://api.github.com/repos/linkerd/linkerd/pulls/2119","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/comments/222852047"},"html":{"href":"https://github.com/linkerd/linkerd/pull/2119#discussion_r222852047"},"pull_request":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/2119"}}},"pull_request":{"url":"https://api.github.com/repos/linkerd/linkerd/pulls/2119","id":213165046,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMTY1MDQ2","html_url":"https://github.com/linkerd/linkerd/pull/2119","diff_url":"https://github.com/linkerd/linkerd/pull/2119.diff","patch_url":"https://github.com/linkerd/linkerd/pull/2119.patch","issue_url":"https://api.github.com/repos/linkerd/linkerd/issues/2119","number":2119,"state":"open","locked":false,"title":"Add GC logging by default","user":{"login":"dadjeibaah","id":2197104,"node_id":"MDQ6VXNlcjIxOTcxMDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2197104?v=4","gravatar_id":"","url":"https://api.github.com/users/dadjeibaah","html_url":"https://github.com/dadjeibaah","followers_url":"https://api.github.com/users/dadjeibaah/followers","following_url":"https://api.github.com/users/dadjeibaah/following{/other_user}","gists_url":"https://api.github.com/users/dadjeibaah/gists{/gist_id}","starred_url":"https://api.github.com/users/dadjeibaah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadjeibaah/subscriptions","organizations_url":"https://api.github.com/users/dadjeibaah/orgs","repos_url":"https://api.github.com/users/dadjeibaah/repos","events_url":"https://api.github.com/users/dadjeibaah/events{/privacy}","received_events_url":"https://api.github.com/users/dadjeibaah/received_events","type":"User","site_admin":false},"body":"GC logging is necessary for debugging JVM issues in Linkerd. This PR adds flags to the Linkerd exec script to enable GC logging. It also adds a line in the exec script that creates a directory `var/log/linkerd` for `gc.log` files if it doesn't exist. it also allows for the GC log directory to be configurable using the environment variable `GC_LOG`\r\n\r\nfixes #2110\r\n\r\nSigned-off-by: Dennis Adjei-Baah <dennis@buoyant.io>","created_at":"2018-09-05T04:18:41Z","updated_at":"2018-10-04T22:58:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5b63f8afe78c864bfa834783d6f50ea31463aaa","assignee":null,"assignees":[],"requested_reviewers":[{"login":"olix0r","id":240738,"node_id":"MDQ6VXNlcjI0MDczOA==","avatar_url":"https://avatars3.githubusercontent.com/u/240738?v=4","gravatar_id":"","url":"https://api.github.com/users/olix0r","html_url":"https://github.com/olix0r","followers_url":"https://api.github.com/users/olix0r/followers","following_url":"https://api.github.com/users/olix0r/following{/other_user}","gists_url":"https://api.github.com/users/olix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/olix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olix0r/subscriptions","organizations_url":"https://api.github.com/users/olix0r/orgs","repos_url":"https://api.github.com/users/olix0r/repos","events_url":"https://api.github.com/users/olix0r/events{/privacy}","received_events_url":"https://api.github.com/users/olix0r/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":796179022,"node_id":"MDU6TGFiZWw3OTYxNzkwMjI=","url":"https://api.github.com/repos/linkerd/linkerd/labels/review","name":"review","color":"ededed","default":false},{"id":311263252,"node_id":"MDU6TGFiZWwzMTEyNjMyNTI=","url":"https://api.github.com/repos/linkerd/linkerd/labels/reviewable","name":"reviewable","color":"33cc33","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/linkerd/linkerd/pulls/2119/commits","review_comments_url":"https://api.github.com/repos/linkerd/linkerd/pulls/2119/comments","review_comment_url":"https://api.github.com/repos/linkerd/linkerd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkerd/linkerd/issues/2119/comments","statuses_url":"https://api.github.com/repos/linkerd/linkerd/statuses/eef0e7b8fd5de4860e9c81fceeec0a231817b38b","head":{"label":"linkerd:dad/gc-logging","ref":"dad/gc-logging","sha":"eef0e7b8fd5de4860e9c81fceeec0a231817b38b","user":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"repo":{"id":49605596,"node_id":"MDEwOlJlcG9zaXRvcnk0OTYwNTU5Ng==","name":"linkerd","full_name":"linkerd/linkerd","private":false,"owner":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/linkerd/linkerd","description":"A service sidecar for Kubernetes and beyond. Main repo for Linkerd 1.x.","fork":false,"url":"https://api.github.com/repos/linkerd/linkerd","forks_url":"https://api.github.com/repos/linkerd/linkerd/forks","keys_url":"https://api.github.com/repos/linkerd/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkerd/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkerd/linkerd/teams","hooks_url":"https://api.github.com/repos/linkerd/linkerd/hooks","issue_events_url":"https://api.github.com/repos/linkerd/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/linkerd/linkerd/events","assignees_url":"https://api.github.com/repos/linkerd/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/linkerd/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/linkerd/linkerd/tags","blobs_url":"https://api.github.com/repos/linkerd/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkerd/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkerd/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkerd/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkerd/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/linkerd/linkerd/languages","stargazers_url":"https://api.github.com/repos/linkerd/linkerd/stargazers","contributors_url":"https://api.github.com/repos/linkerd/linkerd/contributors","subscribers_url":"https://api.github.com/repos/linkerd/linkerd/subscribers","subscription_url":"https://api.github.com/repos/linkerd/linkerd/subscription","commits_url":"https://api.github.com/repos/linkerd/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkerd/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkerd/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkerd/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkerd/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/linkerd/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkerd/linkerd/merges","archive_url":"https://api.github.com/repos/linkerd/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkerd/linkerd/downloads","issues_url":"https://api.github.com/repos/linkerd/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/linkerd/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/linkerd/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/linkerd/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkerd/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/linkerd/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/linkerd/linkerd/deployments","created_at":"2016-01-13T22:14:52Z","updated_at":"2018-10-04T14:09:21Z","pushed_at":"2018-10-04T22:40:32Z","git_url":"git://github.com/linkerd/linkerd.git","ssh_url":"git@github.com:linkerd/linkerd.git","clone_url":"https://github.com/linkerd/linkerd.git","svn_url":"https://github.com/linkerd/linkerd","homepage":"https://linkerd.io","size":18075,"stargazers_count":4702,"watchers_count":4702,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":462,"mirror_url":null,"archived":false,"open_issues_count":156,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":462,"open_issues":156,"watchers":4702,"default_branch":"master"}},"base":{"label":"linkerd:master","ref":"master","sha":"7bd1ba7b57a8d91268a1b0fe70c54b4a42ed40b7","user":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"repo":{"id":49605596,"node_id":"MDEwOlJlcG9zaXRvcnk0OTYwNTU5Ng==","name":"linkerd","full_name":"linkerd/linkerd","private":false,"owner":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/linkerd/linkerd","description":"A service sidecar for Kubernetes and beyond. Main repo for Linkerd 1.x.","fork":false,"url":"https://api.github.com/repos/linkerd/linkerd","forks_url":"https://api.github.com/repos/linkerd/linkerd/forks","keys_url":"https://api.github.com/repos/linkerd/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkerd/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkerd/linkerd/teams","hooks_url":"https://api.github.com/repos/linkerd/linkerd/hooks","issue_events_url":"https://api.github.com/repos/linkerd/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/linkerd/linkerd/events","assignees_url":"https://api.github.com/repos/linkerd/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/linkerd/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/linkerd/linkerd/tags","blobs_url":"https://api.github.com/repos/linkerd/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkerd/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkerd/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkerd/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkerd/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/linkerd/linkerd/languages","stargazers_url":"https://api.github.com/repos/linkerd/linkerd/stargazers","contributors_url":"https://api.github.com/repos/linkerd/linkerd/contributors","subscribers_url":"https://api.github.com/repos/linkerd/linkerd/subscribers","subscription_url":"https://api.github.com/repos/linkerd/linkerd/subscription","commits_url":"https://api.github.com/repos/linkerd/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkerd/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkerd/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkerd/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkerd/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/linkerd/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkerd/linkerd/merges","archive_url":"https://api.github.com/repos/linkerd/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkerd/linkerd/downloads","issues_url":"https://api.github.com/repos/linkerd/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/linkerd/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/linkerd/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/linkerd/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkerd/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/linkerd/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/linkerd/linkerd/deployments","created_at":"2016-01-13T22:14:52Z","updated_at":"2018-10-04T14:09:21Z","pushed_at":"2018-10-04T22:40:32Z","git_url":"git://github.com/linkerd/linkerd.git","ssh_url":"git@github.com:linkerd/linkerd.git","clone_url":"https://github.com/linkerd/linkerd.git","svn_url":"https://github.com/linkerd/linkerd","homepage":"https://linkerd.io","size":18075,"stargazers_count":4702,"watchers_count":4702,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":462,"mirror_url":null,"archived":false,"open_issues_count":156,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":462,"open_issues":156,"watchers":4702,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/2119"},"html":{"href":"https://github.com/linkerd/linkerd/pull/2119"},"issue":{"href":"https://api.github.com/repos/linkerd/linkerd/issues/2119"},"comments":{"href":"https://api.github.com/repos/linkerd/linkerd/issues/2119/comments"},"review_comments":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/2119/comments"},"review_comment":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/2119/commits"},"statuses":{"href":"https://api.github.com/repos/linkerd/linkerd/statuses/eef0e7b8fd5de4860e9c81fceeec0a231817b38b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dadjeibaah"}}