{"action":"created","comment":{"url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/pulls/comments/204610787","pull_request_review_id":139719977,"id":204610787,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDYxMDc4Nw==","diff_hunk":"@@ -110,28 +69,40 @@ def main(argv=None):\n         print(\"Dry run, exiting.\")\n         return\n \n-    if options.clear:\n-        if PIPE_EXISTS:\n-            pipe_out = os.open(PIPE_PATH, os.O_WRONLY)\n-            os.write(pipe_out, b\"quit\\n\")\n-            os.close(pipe_out)\n-        scripter.clear_terminal()\n-        return\n-\n-    if is_slideshow and options.id <= 0 and size > 1:\n-        if os.name == 'nt':\n-            print(\"Slideshow not supported on Windows yet.\")\n-            sys.exit(0)\n-        if PIPE_EXISTS:\n-            print(\"Slideshow already running in this instance!\")\n-            sys.exit(0)\n-        if options.slideshow <= 0:\n-            print(\"Time has to be greater then 0. You can use decimal values.\")\n+    e = create_named_event(\"Pokemon-Terminal_Wallpaper\" if options.wallpaper else \"Pokemon-Terminal_Terminal\")","path":"pokemonterminal/main.py","position":80,"original_position":80,"commit_id":"564cff6379a9ab028d199e9cac496ab2f84cf6b5","original_commit_id":"2c1c418257e6cbaf26d0fae0420df3f60eb17d02","user":{"login":"jimmyorourke","id":20860653,"node_id":"MDQ6VXNlcjIwODYwNjUz","avatar_url":"https://avatars0.githubusercontent.com/u/20860653?v=4","gravatar_id":"","url":"https://api.github.com/users/jimmyorourke","html_url":"https://github.com/jimmyorourke","followers_url":"https://api.github.com/users/jimmyorourke/followers","following_url":"https://api.github.com/users/jimmyorourke/following{/other_user}","gists_url":"https://api.github.com/users/jimmyorourke/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmyorourke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmyorourke/subscriptions","organizations_url":"https://api.github.com/users/jimmyorourke/orgs","repos_url":"https://api.github.com/users/jimmyorourke/repos","events_url":"https://api.github.com/users/jimmyorourke/events{/privacy}","received_events_url":"https://api.github.com/users/jimmyorourke/received_events","type":"User","site_admin":false},"body":"Yeah tbh with the issues that @samosaara is also seeing I'm wodering if we should go back to the named FIFO for posix, wrapped in the `NamedEvent` interface","created_at":"2018-07-24T02:59:12Z","updated_at":"2018-07-24T02:59:12Z","html_url":"https://github.com/LazoCoder/Pokemon-Terminal/pull/150#discussion_r204610787","pull_request_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/pulls/150","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/pulls/comments/204610787"},"html":{"href":"https://github.com/LazoCoder/Pokemon-Terminal/pull/150#discussion_r204610787"},"pull_request":{"href":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/pulls/150"}},"in_reply_to_id":204603115},"pull_request":{"url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/pulls/150","id":202436642,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNDM2NjQy","html_url":"https://github.com/LazoCoder/Pokemon-Terminal/pull/150","diff_url":"https://github.com/LazoCoder/Pokemon-Terminal/pull/150.diff","patch_url":"https://github.com/LazoCoder/Pokemon-Terminal/pull/150.patch","issue_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/issues/150","number":150,"state":"open","locked":false,"title":"[WIP] Windows wallpaper changing and slideshow support, general improvements","user":{"login":"sylveon","id":6440374,"node_id":"MDQ6VXNlcjY0NDAzNzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6440374?v=4","gravatar_id":"","url":"https://api.github.com/users/sylveon","html_url":"https://github.com/sylveon","followers_url":"https://api.github.com/users/sylveon/followers","following_url":"https://api.github.com/users/sylveon/following{/other_user}","gists_url":"https://api.github.com/users/sylveon/gists{/gist_id}","starred_url":"https://api.github.com/users/sylveon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylveon/subscriptions","organizations_url":"https://api.github.com/users/sylveon/orgs","repos_url":"https://api.github.com/users/sylveon/repos","events_url":"https://api.github.com/users/sylveon/events{/privacy}","received_events_url":"https://api.github.com/users/sylveon/received_events","type":"User","site_admin":false},"body":"Basic slideshow functionality works, provided you add a dummy sleeper in __exit_listener instead of the current raise. It also seems to leave processes hanging around after closing the terminal. (but I suspect this is not a Windows-specific issue)\r\n\r\nI've removed the instance detection feature (because it was highly dependent on Unix family features) and am not sure how to approach reimplementing it right now.\r\n\r\nI've made a few changes to other adapters too, would be nice to get some testing. (Only ConEmu has been personally tested as of now)\r\n\r\n~~I've also identified a bug for ConEmu. Attempting to set any background part of the extra collection fails with a cryptic \"UnknownOption\" message.~~ Fixed","created_at":"2018-07-19T03:36:07Z","updated_at":"2018-07-24T02:59:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a930bbc902b969be89a188eb6fc6a68dfb58bcb8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/pulls/150/commits","review_comments_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/pulls/150/comments","review_comment_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/issues/150/comments","statuses_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/statuses/564cff6379a9ab028d199e9cac496ab2f84cf6b5","head":{"label":"LazoCoder:windows","ref":"windows","sha":"564cff6379a9ab028d199e9cac496ab2f84cf6b5","user":{"login":"LazoCoder","id":22990491,"node_id":"MDQ6VXNlcjIyOTkwNDkx","avatar_url":"https://avatars0.githubusercontent.com/u/22990491?v=4","gravatar_id":"","url":"https://api.github.com/users/LazoCoder","html_url":"https://github.com/LazoCoder","followers_url":"https://api.github.com/users/LazoCoder/followers","following_url":"https://api.github.com/users/LazoCoder/following{/other_user}","gists_url":"https://api.github.com/users/LazoCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/LazoCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LazoCoder/subscriptions","organizations_url":"https://api.github.com/users/LazoCoder/orgs","repos_url":"https://api.github.com/users/LazoCoder/repos","events_url":"https://api.github.com/users/LazoCoder/events{/privacy}","received_events_url":"https://api.github.com/users/LazoCoder/received_events","type":"User","site_admin":false},"repo":{"id":88655352,"node_id":"MDEwOlJlcG9zaXRvcnk4ODY1NTM1Mg==","name":"Pokemon-Terminal","full_name":"LazoCoder/Pokemon-Terminal","owner":{"login":"LazoCoder","id":22990491,"node_id":"MDQ6VXNlcjIyOTkwNDkx","avatar_url":"https://avatars0.githubusercontent.com/u/22990491?v=4","gravatar_id":"","url":"https://api.github.com/users/LazoCoder","html_url":"https://github.com/LazoCoder","followers_url":"https://api.github.com/users/LazoCoder/followers","following_url":"https://api.github.com/users/LazoCoder/following{/other_user}","gists_url":"https://api.github.com/users/LazoCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/LazoCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LazoCoder/subscriptions","organizations_url":"https://api.github.com/users/LazoCoder/orgs","repos_url":"https://api.github.com/users/LazoCoder/repos","events_url":"https://api.github.com/users/LazoCoder/events{/privacy}","received_events_url":"https://api.github.com/users/LazoCoder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LazoCoder/Pokemon-Terminal","description":"Pokemon terminal themes.","fork":false,"url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal","forks_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/forks","keys_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/teams","hooks_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/hooks","issue_events_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/issues/events{/number}","events_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/events","assignees_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/assignees{/user}","branches_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/branches{/branch}","tags_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/tags","blobs_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/git/refs{/sha}","trees_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/statuses/{sha}","languages_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/languages","stargazers_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/stargazers","contributors_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/contributors","subscribers_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/subscribers","subscription_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/subscription","commits_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/commits{/sha}","git_commits_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/git/commits{/sha}","comments_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/comments{/number}","issue_comment_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/issues/comments{/number}","contents_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/contents/{+path}","compare_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/merges","archive_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/downloads","issues_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/issues{/number}","pulls_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/pulls{/number}","milestones_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/milestones{/number}","notifications_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/labels{/name}","releases_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/releases{/id}","deployments_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/deployments","created_at":"2017-04-18T18:04:54Z","updated_at":"2018-07-23T04:34:04Z","pushed_at":"2018-07-24T02:00:56Z","git_url":"git://github.com/LazoCoder/Pokemon-Terminal.git","ssh_url":"git@github.com:LazoCoder/Pokemon-Terminal.git","clone_url":"https://github.com/LazoCoder/Pokemon-Terminal.git","svn_url":"https://github.com/LazoCoder/Pokemon-Terminal","homepage":"","size":69299,"stargazers_count":2841,"watchers_count":2841,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":132,"open_issues":17,"watchers":2841,"default_branch":"master"}},"base":{"label":"LazoCoder:master","ref":"master","sha":"9b4ed7a10d5ba50d47ce7a65d082412b1847bfe1","user":{"login":"LazoCoder","id":22990491,"node_id":"MDQ6VXNlcjIyOTkwNDkx","avatar_url":"https://avatars0.githubusercontent.com/u/22990491?v=4","gravatar_id":"","url":"https://api.github.com/users/LazoCoder","html_url":"https://github.com/LazoCoder","followers_url":"https://api.github.com/users/LazoCoder/followers","following_url":"https://api.github.com/users/LazoCoder/following{/other_user}","gists_url":"https://api.github.com/users/LazoCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/LazoCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LazoCoder/subscriptions","organizations_url":"https://api.github.com/users/LazoCoder/orgs","repos_url":"https://api.github.com/users/LazoCoder/repos","events_url":"https://api.github.com/users/LazoCoder/events{/privacy}","received_events_url":"https://api.github.com/users/LazoCoder/received_events","type":"User","site_admin":false},"repo":{"id":88655352,"node_id":"MDEwOlJlcG9zaXRvcnk4ODY1NTM1Mg==","name":"Pokemon-Terminal","full_name":"LazoCoder/Pokemon-Terminal","owner":{"login":"LazoCoder","id":22990491,"node_id":"MDQ6VXNlcjIyOTkwNDkx","avatar_url":"https://avatars0.githubusercontent.com/u/22990491?v=4","gravatar_id":"","url":"https://api.github.com/users/LazoCoder","html_url":"https://github.com/LazoCoder","followers_url":"https://api.github.com/users/LazoCoder/followers","following_url":"https://api.github.com/users/LazoCoder/following{/other_user}","gists_url":"https://api.github.com/users/LazoCoder/gists{/gist_id}","starred_url":"https://api.github.com/users/LazoCoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LazoCoder/subscriptions","organizations_url":"https://api.github.com/users/LazoCoder/orgs","repos_url":"https://api.github.com/users/LazoCoder/repos","events_url":"https://api.github.com/users/LazoCoder/events{/privacy}","received_events_url":"https://api.github.com/users/LazoCoder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LazoCoder/Pokemon-Terminal","description":"Pokemon terminal themes.","fork":false,"url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal","forks_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/forks","keys_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/teams","hooks_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/hooks","issue_events_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/issues/events{/number}","events_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/events","assignees_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/assignees{/user}","branches_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/branches{/branch}","tags_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/tags","blobs_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/git/refs{/sha}","trees_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/statuses/{sha}","languages_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/languages","stargazers_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/stargazers","contributors_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/contributors","subscribers_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/subscribers","subscription_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/subscription","commits_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/commits{/sha}","git_commits_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/git/commits{/sha}","comments_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/comments{/number}","issue_comment_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/issues/comments{/number}","contents_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/contents/{+path}","compare_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/merges","archive_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/downloads","issues_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/issues{/number}","pulls_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/pulls{/number}","milestones_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/milestones{/number}","notifications_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/labels{/name}","releases_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/releases{/id}","deployments_url":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/deployments","created_at":"2017-04-18T18:04:54Z","updated_at":"2018-07-23T04:34:04Z","pushed_at":"2018-07-24T02:00:56Z","git_url":"git://github.com/LazoCoder/Pokemon-Terminal.git","ssh_url":"git@github.com:LazoCoder/Pokemon-Terminal.git","clone_url":"https://github.com/LazoCoder/Pokemon-Terminal.git","svn_url":"https://github.com/LazoCoder/Pokemon-Terminal","homepage":"","size":69299,"stargazers_count":2841,"watchers_count":2841,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":132,"open_issues":17,"watchers":2841,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/pulls/150"},"html":{"href":"https://github.com/LazoCoder/Pokemon-Terminal/pull/150"},"issue":{"href":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/issues/150"},"comments":{"href":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/LazoCoder/Pokemon-Terminal/statuses/564cff6379a9ab028d199e9cac496ab2f84cf6b5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jimmyorourke"}}