{"action":"created","comment":{"url":"https://api.github.com/repos/saltstack/salt/pulls/comments/183729852","pull_request_review_id":114782080,"id":183729852,"diff_hunk":"@@ -177,6 +177,11 @@ Specify the SSH private key file to be used for authentication.\n .UNINDENT\n .INDENT 0.0\n .TP\n+.B \\-\\-priv\\-passwd=SSH_PRIV_PASSWD\n+Specify the SSH private key file's passphrase.","path":"doc/man/salt-ssh.1","position":5,"original_position":5,"commit_id":"39cb55a66603e84d0d751256325a1e5fb64da3b6","original_commit_id":"39cb55a66603e84d0d751256325a1e5fb64da3b6","user":{"login":"gtmanfred","id":732321,"avatar_url":"https://avatars0.githubusercontent.com/u/732321?v=4","gravatar_id":"","url":"https://api.github.com/users/gtmanfred","html_url":"https://github.com/gtmanfred","followers_url":"https://api.github.com/users/gtmanfred/followers","following_url":"https://api.github.com/users/gtmanfred/following{/other_user}","gists_url":"https://api.github.com/users/gtmanfred/gists{/gist_id}","starred_url":"https://api.github.com/users/gtmanfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtmanfred/subscriptions","organizations_url":"https://api.github.com/users/gtmanfred/orgs","repos_url":"https://api.github.com/users/gtmanfred/repos","events_url":"https://api.github.com/users/gtmanfred/events{/privacy}","received_events_url":"https://api.github.com/users/gtmanfred/received_events","type":"User","site_admin":false},"body":"Can you remove this change?\r\n\r\nWe compile these when they are packaged, it does not need to be updated.","created_at":"2018-04-24T13:30:44Z","updated_at":"2018-04-24T13:31:02Z","html_url":"https://github.com/saltstack/salt/pull/47238#discussion_r183729852","pull_request_url":"https://api.github.com/repos/saltstack/salt/pulls/47238","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments/183729852"},"html":{"href":"https://github.com/saltstack/salt/pull/47238#discussion_r183729852"},"pull_request":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47238"}}},"pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/47238","id":183356182,"html_url":"https://github.com/saltstack/salt/pull/47238","diff_url":"https://github.com/saltstack/salt/pull/47238.diff","patch_url":"https://github.com/saltstack/salt/pull/47238.patch","issue_url":"https://api.github.com/repos/saltstack/salt/issues/47238","number":47238,"state":"open","locked":false,"title":"Fix issue #38366 salt-ssh support private key's passphrase","user":{"login":"pengyao","id":919816,"avatar_url":"https://avatars3.githubusercontent.com/u/919816?v=4","gravatar_id":"","url":"https://api.github.com/users/pengyao","html_url":"https://github.com/pengyao","followers_url":"https://api.github.com/users/pengyao/followers","following_url":"https://api.github.com/users/pengyao/following{/other_user}","gists_url":"https://api.github.com/users/pengyao/gists{/gist_id}","starred_url":"https://api.github.com/users/pengyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengyao/subscriptions","organizations_url":"https://api.github.com/users/pengyao/orgs","repos_url":"https://api.github.com/users/pengyao/repos","events_url":"https://api.github.com/users/pengyao/events{/privacy}","received_events_url":"https://api.github.com/users/pengyao/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nFix issue #38366\r\n\r\n### What issues does this PR fix or reference?\r\n\r\nSupport private key's passphrase for salt-ssh\r\n\r\n### Previous Behavior\r\n\r\nNot support\r\n\r\n### New Behavior\r\n\r\nPrivate key's passphrase could be configured by:\r\n* `--priv-passwd` for salt-ssh cli\r\n* `salt_priv_passwd` for salt master configure file\r\n* `priv_passwd` for salt roster file\r\n","created_at":"2018-04-23T08:13:49Z","updated_at":"2018-04-24T13:31:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0711b713d446289cf7fb3ead86796dd40894a25a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/saltstack/salt/pulls/47238/commits","review_comments_url":"https://api.github.com/repos/saltstack/salt/pulls/47238/comments","review_comment_url":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/47238/comments","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/39cb55a66603e84d0d751256325a1e5fb64da3b6","head":{"label":"pengyao:ssh_private_key_pass","ref":"ssh_private_key_pass","sha":"39cb55a66603e84d0d751256325a1e5fb64da3b6","user":{"login":"pengyao","id":919816,"avatar_url":"https://avatars3.githubusercontent.com/u/919816?v=4","gravatar_id":"","url":"https://api.github.com/users/pengyao","html_url":"https://github.com/pengyao","followers_url":"https://api.github.com/users/pengyao/followers","following_url":"https://api.github.com/users/pengyao/following{/other_user}","gists_url":"https://api.github.com/users/pengyao/gists{/gist_id}","starred_url":"https://api.github.com/users/pengyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengyao/subscriptions","organizations_url":"https://api.github.com/users/pengyao/orgs","repos_url":"https://api.github.com/users/pengyao/repos","events_url":"https://api.github.com/users/pengyao/events{/privacy}","received_events_url":"https://api.github.com/users/pengyao/received_events","type":"User","site_admin":false},"repo":{"id":13459539,"name":"salt","full_name":"pengyao/salt","owner":{"login":"pengyao","id":919816,"avatar_url":"https://avatars3.githubusercontent.com/u/919816?v=4","gravatar_id":"","url":"https://api.github.com/users/pengyao","html_url":"https://github.com/pengyao","followers_url":"https://api.github.com/users/pengyao/followers","following_url":"https://api.github.com/users/pengyao/following{/other_user}","gists_url":"https://api.github.com/users/pengyao/gists{/gist_id}","starred_url":"https://api.github.com/users/pengyao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pengyao/subscriptions","organizations_url":"https://api.github.com/users/pengyao/orgs","repos_url":"https://api.github.com/users/pengyao/repos","events_url":"https://api.github.com/users/pengyao/events{/privacy}","received_events_url":"https://api.github.com/users/pengyao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pengyao/salt","description":"Central system and configuration manager ","fork":true,"url":"https://api.github.com/repos/pengyao/salt","forks_url":"https://api.github.com/repos/pengyao/salt/forks","keys_url":"https://api.github.com/repos/pengyao/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pengyao/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pengyao/salt/teams","hooks_url":"https://api.github.com/repos/pengyao/salt/hooks","issue_events_url":"https://api.github.com/repos/pengyao/salt/issues/events{/number}","events_url":"https://api.github.com/repos/pengyao/salt/events","assignees_url":"https://api.github.com/repos/pengyao/salt/assignees{/user}","branches_url":"https://api.github.com/repos/pengyao/salt/branches{/branch}","tags_url":"https://api.github.com/repos/pengyao/salt/tags","blobs_url":"https://api.github.com/repos/pengyao/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pengyao/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pengyao/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/pengyao/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pengyao/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/pengyao/salt/languages","stargazers_url":"https://api.github.com/repos/pengyao/salt/stargazers","contributors_url":"https://api.github.com/repos/pengyao/salt/contributors","subscribers_url":"https://api.github.com/repos/pengyao/salt/subscribers","subscription_url":"https://api.github.com/repos/pengyao/salt/subscription","commits_url":"https://api.github.com/repos/pengyao/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/pengyao/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/pengyao/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/pengyao/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/pengyao/salt/contents/{+path}","compare_url":"https://api.github.com/repos/pengyao/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pengyao/salt/merges","archive_url":"https://api.github.com/repos/pengyao/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pengyao/salt/downloads","issues_url":"https://api.github.com/repos/pengyao/salt/issues{/number}","pulls_url":"https://api.github.com/repos/pengyao/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/pengyao/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/pengyao/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pengyao/salt/labels{/name}","releases_url":"https://api.github.com/repos/pengyao/salt/releases{/id}","deployments_url":"https://api.github.com/repos/pengyao/salt/deployments","created_at":"2013-10-10T01:59:37Z","updated_at":"2018-04-23T05:47:41Z","pushed_at":"2018-04-24T02:50:21Z","git_url":"git://github.com/pengyao/salt.git","ssh_url":"git@github.com:pengyao/salt.git","clone_url":"https://github.com/pengyao/salt.git","svn_url":"https://github.com/pengyao/salt","homepage":"saltstack.org","size":214484,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":0,"watchers":3,"default_branch":"develop"}},"base":{"label":"saltstack:develop","ref":"develop","sha":"6a7833db38a3a03bdd7089b37390716c5869461b","user":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"repo":{"id":1390248,"name":"salt","full_name":"saltstack/salt","owner":{"login":"saltstack","id":1147473,"avatar_url":"https://avatars3.githubusercontent.com/u/1147473?v=4","gravatar_id":"","url":"https://api.github.com/users/saltstack","html_url":"https://github.com/saltstack","followers_url":"https://api.github.com/users/saltstack/followers","following_url":"https://api.github.com/users/saltstack/following{/other_user}","gists_url":"https://api.github.com/users/saltstack/gists{/gist_id}","starred_url":"https://api.github.com/users/saltstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saltstack/subscriptions","organizations_url":"https://api.github.com/users/saltstack/orgs","repos_url":"https://api.github.com/users/saltstack/repos","events_url":"https://api.github.com/users/saltstack/events{/privacy}","received_events_url":"https://api.github.com/users/saltstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/saltstack/salt","description":"Software to automate the management and configuration of any infrastructure or application at scale. Get access to the Salt software package repository here: ","fork":false,"url":"https://api.github.com/repos/saltstack/salt","forks_url":"https://api.github.com/repos/saltstack/salt/forks","keys_url":"https://api.github.com/repos/saltstack/salt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saltstack/salt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saltstack/salt/teams","hooks_url":"https://api.github.com/repos/saltstack/salt/hooks","issue_events_url":"https://api.github.com/repos/saltstack/salt/issues/events{/number}","events_url":"https://api.github.com/repos/saltstack/salt/events","assignees_url":"https://api.github.com/repos/saltstack/salt/assignees{/user}","branches_url":"https://api.github.com/repos/saltstack/salt/branches{/branch}","tags_url":"https://api.github.com/repos/saltstack/salt/tags","blobs_url":"https://api.github.com/repos/saltstack/salt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saltstack/salt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saltstack/salt/git/refs{/sha}","trees_url":"https://api.github.com/repos/saltstack/salt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saltstack/salt/statuses/{sha}","languages_url":"https://api.github.com/repos/saltstack/salt/languages","stargazers_url":"https://api.github.com/repos/saltstack/salt/stargazers","contributors_url":"https://api.github.com/repos/saltstack/salt/contributors","subscribers_url":"https://api.github.com/repos/saltstack/salt/subscribers","subscription_url":"https://api.github.com/repos/saltstack/salt/subscription","commits_url":"https://api.github.com/repos/saltstack/salt/commits{/sha}","git_commits_url":"https://api.github.com/repos/saltstack/salt/git/commits{/sha}","comments_url":"https://api.github.com/repos/saltstack/salt/comments{/number}","issue_comment_url":"https://api.github.com/repos/saltstack/salt/issues/comments{/number}","contents_url":"https://api.github.com/repos/saltstack/salt/contents/{+path}","compare_url":"https://api.github.com/repos/saltstack/salt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saltstack/salt/merges","archive_url":"https://api.github.com/repos/saltstack/salt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saltstack/salt/downloads","issues_url":"https://api.github.com/repos/saltstack/salt/issues{/number}","pulls_url":"https://api.github.com/repos/saltstack/salt/pulls{/number}","milestones_url":"https://api.github.com/repos/saltstack/salt/milestones{/number}","notifications_url":"https://api.github.com/repos/saltstack/salt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saltstack/salt/labels{/name}","releases_url":"https://api.github.com/repos/saltstack/salt/releases{/id}","deployments_url":"https://api.github.com/repos/saltstack/salt/deployments","created_at":"2011-02-20T20:16:56Z","updated_at":"2018-04-24T13:24:40Z","pushed_at":"2018-04-24T13:29:24Z","git_url":"git://github.com/saltstack/salt.git","ssh_url":"git@github.com:saltstack/salt.git","clone_url":"https://github.com/saltstack/salt.git","svn_url":"https://github.com/saltstack/salt","homepage":"https://repo.saltstack.com/","size":218126,"stargazers_count":8772,"watchers_count":8772,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4110,"mirror_url":null,"archived":false,"open_issues_count":3495,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4110,"open_issues":3495,"watchers":8772,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47238"},"html":{"href":"https://github.com/saltstack/salt/pull/47238"},"issue":{"href":"https://api.github.com/repos/saltstack/salt/issues/47238"},"comments":{"href":"https://api.github.com/repos/saltstack/salt/issues/47238/comments"},"review_comments":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47238/comments"},"review_comment":{"href":"https://api.github.com/repos/saltstack/salt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/saltstack/salt/pulls/47238/commits"},"statuses":{"href":"https://api.github.com/repos/saltstack/salt/statuses/39cb55a66603e84d0d751256325a1e5fb64da3b6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gtmanfred"}}