{"action":"closed","number":302,"pull_request":{"url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/302","id":188844428,"html_url":"https://github.com/clearlinux/mixer-tools/pull/302","diff_url":"https://github.com/clearlinux/mixer-tools/pull/302.diff","patch_url":"https://github.com/clearlinux/mixer-tools/pull/302.patch","issue_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/302","number":302,"state":"closed","locked":false,"title":"Report TOML config name for missing config values.","user":{"login":"kevincwells","id":14334449,"avatar_url":"https://avatars1.githubusercontent.com/u/14334449?v=4","gravatar_id":"","url":"https://api.github.com/users/kevincwells","html_url":"https://github.com/kevincwells","followers_url":"https://api.github.com/users/kevincwells/followers","following_url":"https://api.github.com/users/kevincwells/following{/other_user}","gists_url":"https://api.github.com/users/kevincwells/gists{/gist_id}","starred_url":"https://api.github.com/users/kevincwells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevincwells/subscriptions","organizations_url":"https://api.github.com/users/kevincwells/orgs","repos_url":"https://api.github.com/users/kevincwells/repos","events_url":"https://api.github.com/users/kevincwells/events{/privacy}","received_events_url":"https://api.github.com/users/kevincwells/received_events","type":"User","site_admin":false},"body":"Noticed this while testing the new config value I added for containerized mixer. @rchiossi just fixed a similar bug (using variable name instead of toml name during config setting) in his #290.\r\n\r\n-------------------------\r\n\r\nPreviously, when a \"required\" config value was missing, the config\r\nobject's variable name was reported, rather than the name actually used\r\nin the `builder.conf` file itself.\r\n\r\nThis resulted in the following output, for example:\r\n`ERROR: Missing required field in config file: ServerStateDir`\r\nrather than\r\n`ERROR: Missing required field in config file: SERVER_STATE_DIR`\r\n\r\nThis patch falls back to the variable name if a config field does not\r\nhave a \"toml\" name defined.\r\n\r\nSigned-off-by: Kevin C. Wells <kevin.c.wells@intel.com>","created_at":"2018-05-17T19:56:04Z","updated_at":"2018-05-17T20:43:24Z","closed_at":"2018-05-17T20:43:24Z","merged_at":"2018-05-17T20:43:24Z","merge_commit_sha":"2cd5811ba9e0b89972a80b1dd91ad94881aaf1d7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/302/commits","review_comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/302/comments","review_comment_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/302/comments","statuses_url":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/b4bd7b1c1dcb6a8bcfaa5c82f77fb7936c579786","head":{"label":"kevincwells:missing-config","ref":"missing-config","sha":"b4bd7b1c1dcb6a8bcfaa5c82f77fb7936c579786","user":{"login":"kevincwells","id":14334449,"avatar_url":"https://avatars1.githubusercontent.com/u/14334449?v=4","gravatar_id":"","url":"https://api.github.com/users/kevincwells","html_url":"https://github.com/kevincwells","followers_url":"https://api.github.com/users/kevincwells/followers","following_url":"https://api.github.com/users/kevincwells/following{/other_user}","gists_url":"https://api.github.com/users/kevincwells/gists{/gist_id}","starred_url":"https://api.github.com/users/kevincwells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevincwells/subscriptions","organizations_url":"https://api.github.com/users/kevincwells/orgs","repos_url":"https://api.github.com/users/kevincwells/repos","events_url":"https://api.github.com/users/kevincwells/events{/privacy}","received_events_url":"https://api.github.com/users/kevincwells/received_events","type":"User","site_admin":false},"repo":{"id":111451804,"name":"mixer-tools","full_name":"kevincwells/mixer-tools","owner":{"login":"kevincwells","id":14334449,"avatar_url":"https://avatars1.githubusercontent.com/u/14334449?v=4","gravatar_id":"","url":"https://api.github.com/users/kevincwells","html_url":"https://github.com/kevincwells","followers_url":"https://api.github.com/users/kevincwells/followers","following_url":"https://api.github.com/users/kevincwells/following{/other_user}","gists_url":"https://api.github.com/users/kevincwells/gists{/gist_id}","starred_url":"https://api.github.com/users/kevincwells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevincwells/subscriptions","organizations_url":"https://api.github.com/users/kevincwells/orgs","repos_url":"https://api.github.com/users/kevincwells/repos","events_url":"https://api.github.com/users/kevincwells/events{/privacy}","received_events_url":"https://api.github.com/users/kevincwells/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kevincwells/mixer-tools","description":null,"fork":true,"url":"https://api.github.com/repos/kevincwells/mixer-tools","forks_url":"https://api.github.com/repos/kevincwells/mixer-tools/forks","keys_url":"https://api.github.com/repos/kevincwells/mixer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kevincwells/mixer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kevincwells/mixer-tools/teams","hooks_url":"https://api.github.com/repos/kevincwells/mixer-tools/hooks","issue_events_url":"https://api.github.com/repos/kevincwells/mixer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/kevincwells/mixer-tools/events","assignees_url":"https://api.github.com/repos/kevincwells/mixer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/kevincwells/mixer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/kevincwells/mixer-tools/tags","blobs_url":"https://api.github.com/repos/kevincwells/mixer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kevincwells/mixer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kevincwells/mixer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/kevincwells/mixer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kevincwells/mixer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/kevincwells/mixer-tools/languages","stargazers_url":"https://api.github.com/repos/kevincwells/mixer-tools/stargazers","contributors_url":"https://api.github.com/repos/kevincwells/mixer-tools/contributors","subscribers_url":"https://api.github.com/repos/kevincwells/mixer-tools/subscribers","subscription_url":"https://api.github.com/repos/kevincwells/mixer-tools/subscription","commits_url":"https://api.github.com/repos/kevincwells/mixer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/kevincwells/mixer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/kevincwells/mixer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/kevincwells/mixer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/kevincwells/mixer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/kevincwells/mixer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kevincwells/mixer-tools/merges","archive_url":"https://api.github.com/repos/kevincwells/mixer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kevincwells/mixer-tools/downloads","issues_url":"https://api.github.com/repos/kevincwells/mixer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/kevincwells/mixer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/kevincwells/mixer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/kevincwells/mixer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kevincwells/mixer-tools/labels{/name}","releases_url":"https://api.github.com/repos/kevincwells/mixer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/kevincwells/mixer-tools/deployments","created_at":"2017-11-20T19:10:58Z","updated_at":"2018-05-17T19:27:31Z","pushed_at":"2018-05-17T19:52:32Z","git_url":"git://github.com/kevincwells/mixer-tools.git","ssh_url":"git@github.com:kevincwells/mixer-tools.git","clone_url":"https://github.com/kevincwells/mixer-tools.git","svn_url":"https://github.com/kevincwells/mixer-tools","homepage":null,"size":1168,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clearlinux:master","ref":"master","sha":"44f45c37d92f654892ab37b89c93013a0421041a","user":{"login":"clearlinux","id":12545216,"avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":54439474,"name":"mixer-tools","full_name":"clearlinux/mixer-tools","owner":{"login":"clearlinux","id":12545216,"avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearlinux/mixer-tools","description":null,"fork":false,"url":"https://api.github.com/repos/clearlinux/mixer-tools","forks_url":"https://api.github.com/repos/clearlinux/mixer-tools/forks","keys_url":"https://api.github.com/repos/clearlinux/mixer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearlinux/mixer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearlinux/mixer-tools/teams","hooks_url":"https://api.github.com/repos/clearlinux/mixer-tools/hooks","issue_events_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/clearlinux/mixer-tools/events","assignees_url":"https://api.github.com/repos/clearlinux/mixer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/clearlinux/mixer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/tags","blobs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/clearlinux/mixer-tools/languages","stargazers_url":"https://api.github.com/repos/clearlinux/mixer-tools/stargazers","contributors_url":"https://api.github.com/repos/clearlinux/mixer-tools/contributors","subscribers_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscribers","subscription_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscription","commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearlinux/mixer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/clearlinux/mixer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearlinux/mixer-tools/merges","archive_url":"https://api.github.com/repos/clearlinux/mixer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearlinux/mixer-tools/downloads","issues_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/clearlinux/mixer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/clearlinux/mixer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearlinux/mixer-tools/labels{/name}","releases_url":"https://api.github.com/repos/clearlinux/mixer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/clearlinux/mixer-tools/deployments","created_at":"2016-03-22T02:38:26Z","updated_at":"2018-05-17T20:19:49Z","pushed_at":"2018-05-17T20:43:24Z","git_url":"git://github.com/clearlinux/mixer-tools.git","ssh_url":"git@github.com:clearlinux/mixer-tools.git","clone_url":"https://github.com/clearlinux/mixer-tools.git","svn_url":"https://github.com/clearlinux/mixer-tools","homepage":null,"size":1147,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":17,"open_issues":35,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/302"},"html":{"href":"https://github.com/clearlinux/mixer-tools/pull/302"},"issue":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/issues/302"},"comments":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/b4bd7b1c1dcb6a8bcfaa5c82f77fb7936c579786"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tmarcu","id":574028,"avatar_url":"https://avatars2.githubusercontent.com/u/574028?v=4","gravatar_id":"","url":"https://api.github.com/users/tmarcu","html_url":"https://github.com/tmarcu","followers_url":"https://api.github.com/users/tmarcu/followers","following_url":"https://api.github.com/users/tmarcu/following{/other_user}","gists_url":"https://api.github.com/users/tmarcu/gists{/gist_id}","starred_url":"https://api.github.com/users/tmarcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmarcu/subscriptions","organizations_url":"https://api.github.com/users/tmarcu/orgs","repos_url":"https://api.github.com/users/tmarcu/repos","events_url":"https://api.github.com/users/tmarcu/events{/privacy}","received_events_url":"https://api.github.com/users/tmarcu/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"tmarcu"}}