{"action":"created","comment":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments/170461497","pull_request_review_id":99150929,"id":170461497,"diff_hunk":"@@ -185,8 +187,11 @@ object ITCRequest {\n   def gsaoiParameters(r: ITCRequest): GsaoiParameters = {\n     val filter      = r.enumParameter(classOf[Gsaoi.Filter])\n     val readMode    = r.enumParameter(classOf[Gsaoi.ReadMode])\n-    val gems        = gemsParameters(r)\n-    GsaoiParameters(filter, readMode, gems)\n+    val iq          = obsConditionParameters(r).iq\n+    ConfigExtractor.createGsaoiParameters(filter, readMode, iq) match {\n+      case \\/-(p) => p\n+      case -\\/(t) => throw new IllegalArgumentException(t)\n+    }\n   }","path":"bundle/edu.gemini.itc.web/src/main/scala/edu/gemini/itc/web/ITCRequest.scala","position":20,"original_position":20,"commit_id":"82a4c72c1e835a3a5278aee6e7f5f526de7fea60","original_commit_id":"82a4c72c1e835a3a5278aee6e7f5f526de7fea60","user":{"login":"leashma","id":26463945,"avatar_url":"https://avatars2.githubusercontent.com/u/26463945?v=4","gravatar_id":"","url":"https://api.github.com/users/leashma","html_url":"https://github.com/leashma","followers_url":"https://api.github.com/users/leashma/followers","following_url":"https://api.github.com/users/leashma/following{/other_user}","gists_url":"https://api.github.com/users/leashma/gists{/gist_id}","starred_url":"https://api.github.com/users/leashma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leashma/subscriptions","organizations_url":"https://api.github.com/users/leashma/orgs","repos_url":"https://api.github.com/users/leashma/repos","events_url":"https://api.github.com/users/leashma/events{/privacy}","received_events_url":"https://api.github.com/users/leashma/received_events","type":"User","site_admin":false},"body":"It is deleted in my local repository, tried to push newest changes, but git tells me there's nothing new to commit. ","created_at":"2018-02-25T18:16:51Z","updated_at":"2018-02-25T18:16:51Z","html_url":"https://github.com/gemini-hlsw/ocs/pull/1432#discussion_r170461497","pull_request_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/1432","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments/170461497"},"html":{"href":"https://github.com/gemini-hlsw/ocs/pull/1432#discussion_r170461497"},"pull_request":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/1432"}},"in_reply_to_id":170433513},"pull_request":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/1432","id":171198297,"html_url":"https://github.com/gemini-hlsw/ocs/pull/1432","diff_url":"https://github.com/gemini-hlsw/ocs/pull/1432.diff","patch_url":"https://github.com/gemini-hlsw/ocs/pull/1432.patch","issue_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/1432","number":1432,"state":"open","locked":false,"title":"Feature/rel 3222","user":{"login":"leashma","id":26463945,"avatar_url":"https://avatars2.githubusercontent.com/u/26463945?v=4","gravatar_id":"","url":"https://api.github.com/users/leashma","html_url":"https://github.com/leashma","followers_url":"https://api.github.com/users/leashma/followers","following_url":"https://api.github.com/users/leashma/following{/other_user}","gists_url":"https://api.github.com/users/leashma/gists{/gist_id}","starred_url":"https://api.github.com/users/leashma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leashma/subscriptions","organizations_url":"https://api.github.com/users/leashma/orgs","repos_url":"https://api.github.com/users/leashma/repos","events_url":"https://api.github.com/users/leashma/events{/privacy}","received_events_url":"https://api.github.com/users/leashma/received_events","type":"User","site_admin":false},"body":"Sebastian showed me the proper changes to make in ITCrequest.scala and ConfigExtractor.scala. Then all I did was remove the selection in GSAOI ITC webform. This pull request also includes changes made related to REL-503. Had one unmerged pull request open before making changes for this one. ","created_at":"2018-02-24T21:23:38Z","updated_at":"2018-02-25T18:16:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"beda5a5ac9f1a483990aa344a5836233d4d13722","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/1432/commits","review_comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/1432/comments","review_comment_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/1432/comments","statuses_url":"https://api.github.com/repos/gemini-hlsw/ocs/statuses/82a4c72c1e835a3a5278aee6e7f5f526de7fea60","head":{"label":"leashma:feature/REL-3222","ref":"feature/REL-3222","sha":"82a4c72c1e835a3a5278aee6e7f5f526de7fea60","user":{"login":"leashma","id":26463945,"avatar_url":"https://avatars2.githubusercontent.com/u/26463945?v=4","gravatar_id":"","url":"https://api.github.com/users/leashma","html_url":"https://github.com/leashma","followers_url":"https://api.github.com/users/leashma/followers","following_url":"https://api.github.com/users/leashma/following{/other_user}","gists_url":"https://api.github.com/users/leashma/gists{/gist_id}","starred_url":"https://api.github.com/users/leashma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leashma/subscriptions","organizations_url":"https://api.github.com/users/leashma/orgs","repos_url":"https://api.github.com/users/leashma/repos","events_url":"https://api.github.com/users/leashma/events{/privacy}","received_events_url":"https://api.github.com/users/leashma/received_events","type":"User","site_admin":false},"repo":{"id":85591089,"name":"ocs","full_name":"leashma/ocs","owner":{"login":"leashma","id":26463945,"avatar_url":"https://avatars2.githubusercontent.com/u/26463945?v=4","gravatar_id":"","url":"https://api.github.com/users/leashma","html_url":"https://github.com/leashma","followers_url":"https://api.github.com/users/leashma/followers","following_url":"https://api.github.com/users/leashma/following{/other_user}","gists_url":"https://api.github.com/users/leashma/gists{/gist_id}","starred_url":"https://api.github.com/users/leashma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leashma/subscriptions","organizations_url":"https://api.github.com/users/leashma/orgs","repos_url":"https://api.github.com/users/leashma/repos","events_url":"https://api.github.com/users/leashma/events{/privacy}","received_events_url":"https://api.github.com/users/leashma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leashma/ocs","description":"Observatory Control Software","fork":true,"url":"https://api.github.com/repos/leashma/ocs","forks_url":"https://api.github.com/repos/leashma/ocs/forks","keys_url":"https://api.github.com/repos/leashma/ocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leashma/ocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leashma/ocs/teams","hooks_url":"https://api.github.com/repos/leashma/ocs/hooks","issue_events_url":"https://api.github.com/repos/leashma/ocs/issues/events{/number}","events_url":"https://api.github.com/repos/leashma/ocs/events","assignees_url":"https://api.github.com/repos/leashma/ocs/assignees{/user}","branches_url":"https://api.github.com/repos/leashma/ocs/branches{/branch}","tags_url":"https://api.github.com/repos/leashma/ocs/tags","blobs_url":"https://api.github.com/repos/leashma/ocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leashma/ocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leashma/ocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/leashma/ocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leashma/ocs/statuses/{sha}","languages_url":"https://api.github.com/repos/leashma/ocs/languages","stargazers_url":"https://api.github.com/repos/leashma/ocs/stargazers","contributors_url":"https://api.github.com/repos/leashma/ocs/contributors","subscribers_url":"https://api.github.com/repos/leashma/ocs/subscribers","subscription_url":"https://api.github.com/repos/leashma/ocs/subscription","commits_url":"https://api.github.com/repos/leashma/ocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/leashma/ocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/leashma/ocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/leashma/ocs/issues/comments{/number}","contents_url":"https://api.github.com/repos/leashma/ocs/contents/{+path}","compare_url":"https://api.github.com/repos/leashma/ocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leashma/ocs/merges","archive_url":"https://api.github.com/repos/leashma/ocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leashma/ocs/downloads","issues_url":"https://api.github.com/repos/leashma/ocs/issues{/number}","pulls_url":"https://api.github.com/repos/leashma/ocs/pulls{/number}","milestones_url":"https://api.github.com/repos/leashma/ocs/milestones{/number}","notifications_url":"https://api.github.com/repos/leashma/ocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leashma/ocs/labels{/name}","releases_url":"https://api.github.com/repos/leashma/ocs/releases{/id}","deployments_url":"https://api.github.com/repos/leashma/ocs/deployments","created_at":"2017-03-20T15:06:27Z","updated_at":"2017-03-20T15:06:50Z","pushed_at":"2018-02-24T21:20:08Z","git_url":"git://github.com/leashma/ocs.git","ssh_url":"git@github.com:leashma/ocs.git","clone_url":"https://github.com/leashma/ocs.git","svn_url":"https://github.com/leashma/ocs","homepage":"","size":369950,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"gemini-hlsw:develop","ref":"develop","sha":"2db5823a93caa82312e269001fe7c39ed1960a10","user":{"login":"gemini-hlsw","id":8593735,"avatar_url":"https://avatars2.githubusercontent.com/u/8593735?v=4","gravatar_id":"","url":"https://api.github.com/users/gemini-hlsw","html_url":"https://github.com/gemini-hlsw","followers_url":"https://api.github.com/users/gemini-hlsw/followers","following_url":"https://api.github.com/users/gemini-hlsw/following{/other_user}","gists_url":"https://api.github.com/users/gemini-hlsw/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-hlsw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-hlsw/subscriptions","organizations_url":"https://api.github.com/users/gemini-hlsw/orgs","repos_url":"https://api.github.com/users/gemini-hlsw/repos","events_url":"https://api.github.com/users/gemini-hlsw/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-hlsw/received_events","type":"Organization","site_admin":false},"repo":{"id":23963494,"name":"ocs","full_name":"gemini-hlsw/ocs","owner":{"login":"gemini-hlsw","id":8593735,"avatar_url":"https://avatars2.githubusercontent.com/u/8593735?v=4","gravatar_id":"","url":"https://api.github.com/users/gemini-hlsw","html_url":"https://github.com/gemini-hlsw","followers_url":"https://api.github.com/users/gemini-hlsw/followers","following_url":"https://api.github.com/users/gemini-hlsw/following{/other_user}","gists_url":"https://api.github.com/users/gemini-hlsw/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-hlsw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-hlsw/subscriptions","organizations_url":"https://api.github.com/users/gemini-hlsw/orgs","repos_url":"https://api.github.com/users/gemini-hlsw/repos","events_url":"https://api.github.com/users/gemini-hlsw/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-hlsw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-hlsw/ocs","description":"Observatory Control Software","fork":false,"url":"https://api.github.com/repos/gemini-hlsw/ocs","forks_url":"https://api.github.com/repos/gemini-hlsw/ocs/forks","keys_url":"https://api.github.com/repos/gemini-hlsw/ocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-hlsw/ocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-hlsw/ocs/teams","hooks_url":"https://api.github.com/repos/gemini-hlsw/ocs/hooks","issue_events_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-hlsw/ocs/events","assignees_url":"https://api.github.com/repos/gemini-hlsw/ocs/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-hlsw/ocs/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-hlsw/ocs/tags","blobs_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-hlsw/ocs/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-hlsw/ocs/languages","stargazers_url":"https://api.github.com/repos/gemini-hlsw/ocs/stargazers","contributors_url":"https://api.github.com/repos/gemini-hlsw/ocs/contributors","subscribers_url":"https://api.github.com/repos/gemini-hlsw/ocs/subscribers","subscription_url":"https://api.github.com/repos/gemini-hlsw/ocs/subscription","commits_url":"https://api.github.com/repos/gemini-hlsw/ocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-hlsw/ocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemini-hlsw/ocs/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-hlsw/ocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-hlsw/ocs/merges","archive_url":"https://api.github.com/repos/gemini-hlsw/ocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-hlsw/ocs/downloads","issues_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-hlsw/ocs/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-hlsw/ocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-hlsw/ocs/labels{/name}","releases_url":"https://api.github.com/repos/gemini-hlsw/ocs/releases{/id}","deployments_url":"https://api.github.com/repos/gemini-hlsw/ocs/deployments","created_at":"2014-09-12T14:20:23Z","updated_at":"2016-10-23T00:37:21Z","pushed_at":"2018-02-24T21:23:39Z","git_url":"git://github.com/gemini-hlsw/ocs.git","ssh_url":"git@github.com:gemini-hlsw/ocs.git","clone_url":"https://github.com/gemini-hlsw/ocs.git","svn_url":"https://github.com/gemini-hlsw/ocs","homepage":"","size":370028,"stargazers_count":8,"watchers_count":8,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":19,"open_issues":6,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/1432"},"html":{"href":"https://github.com/gemini-hlsw/ocs/pull/1432"},"issue":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/issues/1432"},"comments":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/issues/1432/comments"},"review_comments":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/1432/comments"},"review_comment":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/1432/commits"},"statuses":{"href":"https://api.github.com/repos/gemini-hlsw/ocs/statuses/82a4c72c1e835a3a5278aee6e7f5f526de7fea60"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"leashma"}}