{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/pxt-blockly/issues/126","repository_url":"https://api.github.com/repos/Microsoft/pxt-blockly","labels_url":"https://api.github.com/repos/Microsoft/pxt-blockly/issues/126/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/pxt-blockly/issues/126/comments","events_url":"https://api.github.com/repos/Microsoft/pxt-blockly/issues/126/events","html_url":"https://github.com/Microsoft/pxt-blockly/pull/126","id":368911575,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTc2OTMw","number":126,"title":"Update widget div positioning logic to not cut off content above the screen","user":{"login":"samelhusseini","id":16690124,"node_id":"MDQ6VXNlcjE2NjkwMTI0","avatar_url":"https://avatars3.githubusercontent.com/u/16690124?v=4","gravatar_id":"","url":"https://api.github.com/users/samelhusseini","html_url":"https://github.com/samelhusseini","followers_url":"https://api.github.com/users/samelhusseini/followers","following_url":"https://api.github.com/users/samelhusseini/following{/other_user}","gists_url":"https://api.github.com/users/samelhusseini/gists{/gist_id}","starred_url":"https://api.github.com/users/samelhusseini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samelhusseini/subscriptions","organizations_url":"https://api.github.com/users/samelhusseini/orgs","repos_url":"https://api.github.com/users/samelhusseini/repos","events_url":"https://api.github.com/users/samelhusseini/events{/privacy}","received_events_url":"https://api.github.com/users/samelhusseini/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-11T01:04:16Z","updated_at":"2018-10-11T02:51:38Z","closed_at":"2018-10-11T01:16:03Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Microsoft/pxt-blockly/pulls/126","html_url":"https://github.com/Microsoft/pxt-blockly/pull/126","diff_url":"https://github.com/Microsoft/pxt-blockly/pull/126.diff","patch_url":"https://github.com/Microsoft/pxt-blockly/pull/126.patch"},"body":"The current positioning of the widget div would rather show content close to the top of the field and have it cut off the top of the screen, than show it above the entire field. \r\n\r\nChanging this logic to show content above a field in that case. \r\nHere's an example: \r\n\r\n![screen shot 2018-10-10 at 6 03 36 pm](https://user-images.githubusercontent.com/16690124/46774357-d980a100-ccb6-11e8-8f34-eafe465d1231.png)\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/pxt-blockly/issues/comments/428801297","html_url":"https://github.com/Microsoft/pxt-blockly/pull/126#issuecomment-428801297","issue_url":"https://api.github.com/repos/Microsoft/pxt-blockly/issues/126","id":428801297,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODgwMTI5Nw==","user":{"login":"samelhusseini","id":16690124,"node_id":"MDQ6VXNlcjE2NjkwMTI0","avatar_url":"https://avatars3.githubusercontent.com/u/16690124?v=4","gravatar_id":"","url":"https://api.github.com/users/samelhusseini","html_url":"https://github.com/samelhusseini","followers_url":"https://api.github.com/users/samelhusseini/followers","following_url":"https://api.github.com/users/samelhusseini/following{/other_user}","gists_url":"https://api.github.com/users/samelhusseini/gists{/gist_id}","starred_url":"https://api.github.com/users/samelhusseini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samelhusseini/subscriptions","organizations_url":"https://api.github.com/users/samelhusseini/orgs","repos_url":"https://api.github.com/users/samelhusseini/repos","events_url":"https://api.github.com/users/samelhusseini/events{/privacy}","received_events_url":"https://api.github.com/users/samelhusseini/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T02:51:38Z","updated_at":"2018-10-11T02:51:38Z","author_association":"MEMBER","body":"No, this is really only useful to the gridpicker which uses the WidgetDiv to place it's content. \r\nMost new pickers use the DropdownDiv which adds an arrow that points to what field opened it. In that case showing it above the field might look weird, but we could also possibly just not show an arrow in that scenario. \r\n\r\nAnyway short answer, different code paths, this only fixes the WidgetDiv positioning."}}
{"actor":{"display_login":"samelhusseini"}}