{"action":"created","comment":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/comments/191835503","pull_request_review_id":124487661,"id":191835503,"diff_hunk":"@@ -54,7 +54,7 @@ ProcessWatcher::ProcessWatcher( RemotePlugin * _p ) :\n \n void ProcessWatcher::run()\n {\n-\twhile( !m_quit && m_plugin->isRunning() )\n+\twhile( !m_quit && (m_plugin->messagesLeft() || m_plugin->isRunning()) )","path":"src/core/RemotePlugin.cpp","position":5,"original_position":5,"commit_id":"0a8fabcdc1050a429241078d2116d8b4f887e301","original_commit_id":"0a8fabcdc1050a429241078d2116d8b4f887e301","user":{"login":"justnope","id":39016732,"avatar_url":"https://avatars1.githubusercontent.com/u/39016732?v=4","gravatar_id":"","url":"https://api.github.com/users/justnope","html_url":"https://github.com/justnope","followers_url":"https://api.github.com/users/justnope/followers","following_url":"https://api.github.com/users/justnope/following{/other_user}","gists_url":"https://api.github.com/users/justnope/gists{/gist_id}","starred_url":"https://api.github.com/users/justnope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justnope/subscriptions","organizations_url":"https://api.github.com/users/justnope/orgs","repos_url":"https://api.github.com/users/justnope/repos","events_url":"https://api.github.com/users/justnope/events{/privacy}","received_events_url":"https://api.github.com/users/justnope/received_events","type":"User","site_admin":false},"body":"heh :) good catch, thanks. (I wanted to write something about why you were wrong but then realized you were right)\r\n","created_at":"2018-05-30T16:28:55Z","updated_at":"2018-05-30T16:28:55Z","html_url":"https://github.com/LMMS/lmms/pull/4371#discussion_r191835503","pull_request_url":"https://api.github.com/repos/LMMS/lmms/pulls/4371","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/comments/191835503"},"html":{"href":"https://github.com/LMMS/lmms/pull/4371#discussion_r191835503"},"pull_request":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/4371"}},"in_reply_to_id":191290686},"pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/4371","id":189618255,"html_url":"https://github.com/LMMS/lmms/pull/4371","diff_url":"https://github.com/LMMS/lmms/pull/4371.diff","patch_url":"https://github.com/LMMS/lmms/pull/4371.patch","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/4371","number":4371,"state":"open","locked":false,"title":"RemoteVST: process all remaining messages after the process has quit","user":{"login":"justnope","id":39016732,"avatar_url":"https://avatars1.githubusercontent.com/u/39016732?v=4","gravatar_id":"","url":"https://api.github.com/users/justnope","html_url":"https://github.com/justnope","followers_url":"https://api.github.com/users/justnope/followers","following_url":"https://api.github.com/users/justnope/following{/other_user}","gists_url":"https://api.github.com/users/justnope/gists{/gist_id}","starred_url":"https://api.github.com/users/justnope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justnope/subscriptions","organizations_url":"https://api.github.com/users/justnope/orgs","repos_url":"https://api.github.com/users/justnope/repos","events_url":"https://api.github.com/users/justnope/events{/privacy}","received_events_url":"https://api.github.com/users/justnope/received_events","type":"User","site_admin":false},"body":"If the process exits, keep processing the remaining messages. Some might be debug messages or a msg that the vst loaded was 32 bits.\r\n\r\n(cherry-picked msvc/ng)","created_at":"2018-05-22T10:38:24Z","updated_at":"2018-05-30T16:28:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b58b08734446619a825088b7a97361ac80f2e372","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LMMS/lmms/pulls/4371/commits","review_comments_url":"https://api.github.com/repos/LMMS/lmms/pulls/4371/comments","review_comment_url":"https://api.github.com/repos/LMMS/lmms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/4371/comments","statuses_url":"https://api.github.com/repos/LMMS/lmms/statuses/0a8fabcdc1050a429241078d2116d8b4f887e301","head":{"label":"justnope:cp-processwatch","ref":"cp-processwatch","sha":"0a8fabcdc1050a429241078d2116d8b4f887e301","user":{"login":"justnope","id":39016732,"avatar_url":"https://avatars1.githubusercontent.com/u/39016732?v=4","gravatar_id":"","url":"https://api.github.com/users/justnope","html_url":"https://github.com/justnope","followers_url":"https://api.github.com/users/justnope/followers","following_url":"https://api.github.com/users/justnope/following{/other_user}","gists_url":"https://api.github.com/users/justnope/gists{/gist_id}","starred_url":"https://api.github.com/users/justnope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justnope/subscriptions","organizations_url":"https://api.github.com/users/justnope/orgs","repos_url":"https://api.github.com/users/justnope/repos","events_url":"https://api.github.com/users/justnope/events{/privacy}","received_events_url":"https://api.github.com/users/justnope/received_events","type":"User","site_admin":false},"repo":{"id":132508509,"name":"lmms","full_name":"justnope/lmms","owner":{"login":"justnope","id":39016732,"avatar_url":"https://avatars1.githubusercontent.com/u/39016732?v=4","gravatar_id":"","url":"https://api.github.com/users/justnope","html_url":"https://github.com/justnope","followers_url":"https://api.github.com/users/justnope/followers","following_url":"https://api.github.com/users/justnope/following{/other_user}","gists_url":"https://api.github.com/users/justnope/gists{/gist_id}","starred_url":"https://api.github.com/users/justnope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justnope/subscriptions","organizations_url":"https://api.github.com/users/justnope/orgs","repos_url":"https://api.github.com/users/justnope/repos","events_url":"https://api.github.com/users/justnope/events{/privacy}","received_events_url":"https://api.github.com/users/justnope/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justnope/lmms","description":"Cross-platform music production software","fork":true,"url":"https://api.github.com/repos/justnope/lmms","forks_url":"https://api.github.com/repos/justnope/lmms/forks","keys_url":"https://api.github.com/repos/justnope/lmms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justnope/lmms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justnope/lmms/teams","hooks_url":"https://api.github.com/repos/justnope/lmms/hooks","issue_events_url":"https://api.github.com/repos/justnope/lmms/issues/events{/number}","events_url":"https://api.github.com/repos/justnope/lmms/events","assignees_url":"https://api.github.com/repos/justnope/lmms/assignees{/user}","branches_url":"https://api.github.com/repos/justnope/lmms/branches{/branch}","tags_url":"https://api.github.com/repos/justnope/lmms/tags","blobs_url":"https://api.github.com/repos/justnope/lmms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justnope/lmms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justnope/lmms/git/refs{/sha}","trees_url":"https://api.github.com/repos/justnope/lmms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justnope/lmms/statuses/{sha}","languages_url":"https://api.github.com/repos/justnope/lmms/languages","stargazers_url":"https://api.github.com/repos/justnope/lmms/stargazers","contributors_url":"https://api.github.com/repos/justnope/lmms/contributors","subscribers_url":"https://api.github.com/repos/justnope/lmms/subscribers","subscription_url":"https://api.github.com/repos/justnope/lmms/subscription","commits_url":"https://api.github.com/repos/justnope/lmms/commits{/sha}","git_commits_url":"https://api.github.com/repos/justnope/lmms/git/commits{/sha}","comments_url":"https://api.github.com/repos/justnope/lmms/comments{/number}","issue_comment_url":"https://api.github.com/repos/justnope/lmms/issues/comments{/number}","contents_url":"https://api.github.com/repos/justnope/lmms/contents/{+path}","compare_url":"https://api.github.com/repos/justnope/lmms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justnope/lmms/merges","archive_url":"https://api.github.com/repos/justnope/lmms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justnope/lmms/downloads","issues_url":"https://api.github.com/repos/justnope/lmms/issues{/number}","pulls_url":"https://api.github.com/repos/justnope/lmms/pulls{/number}","milestones_url":"https://api.github.com/repos/justnope/lmms/milestones{/number}","notifications_url":"https://api.github.com/repos/justnope/lmms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justnope/lmms/labels{/name}","releases_url":"https://api.github.com/repos/justnope/lmms/releases{/id}","deployments_url":"https://api.github.com/repos/justnope/lmms/deployments","created_at":"2018-05-07T19:42:32Z","updated_at":"2018-05-28T22:45:39Z","pushed_at":"2018-05-28T22:45:38Z","git_url":"git://github.com/justnope/lmms.git","ssh_url":"git@github.com:justnope/lmms.git","clone_url":"https://github.com/justnope/lmms.git","svn_url":"https://github.com/justnope/lmms","homepage":"https://lmms.io/","size":79032,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"msvc/ng"}},"base":{"label":"LMMS:master","ref":"master","sha":"0fa7fbde0f86c7d68e2633008a8456497e3024b3","user":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars0.githubusercontent.com/u/6363159?v=4","gravatar_id":"","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"repo":{"id":15778896,"name":"lmms","full_name":"LMMS/lmms","owner":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars0.githubusercontent.com/u/6363159?v=4","gravatar_id":"","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LMMS/lmms","description":"Cross-platform music production software","fork":false,"url":"https://api.github.com/repos/LMMS/lmms","forks_url":"https://api.github.com/repos/LMMS/lmms/forks","keys_url":"https://api.github.com/repos/LMMS/lmms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LMMS/lmms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LMMS/lmms/teams","hooks_url":"https://api.github.com/repos/LMMS/lmms/hooks","issue_events_url":"https://api.github.com/repos/LMMS/lmms/issues/events{/number}","events_url":"https://api.github.com/repos/LMMS/lmms/events","assignees_url":"https://api.github.com/repos/LMMS/lmms/assignees{/user}","branches_url":"https://api.github.com/repos/LMMS/lmms/branches{/branch}","tags_url":"https://api.github.com/repos/LMMS/lmms/tags","blobs_url":"https://api.github.com/repos/LMMS/lmms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LMMS/lmms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LMMS/lmms/git/refs{/sha}","trees_url":"https://api.github.com/repos/LMMS/lmms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LMMS/lmms/statuses/{sha}","languages_url":"https://api.github.com/repos/LMMS/lmms/languages","stargazers_url":"https://api.github.com/repos/LMMS/lmms/stargazers","contributors_url":"https://api.github.com/repos/LMMS/lmms/contributors","subscribers_url":"https://api.github.com/repos/LMMS/lmms/subscribers","subscription_url":"https://api.github.com/repos/LMMS/lmms/subscription","commits_url":"https://api.github.com/repos/LMMS/lmms/commits{/sha}","git_commits_url":"https://api.github.com/repos/LMMS/lmms/git/commits{/sha}","comments_url":"https://api.github.com/repos/LMMS/lmms/comments{/number}","issue_comment_url":"https://api.github.com/repos/LMMS/lmms/issues/comments{/number}","contents_url":"https://api.github.com/repos/LMMS/lmms/contents/{+path}","compare_url":"https://api.github.com/repos/LMMS/lmms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LMMS/lmms/merges","archive_url":"https://api.github.com/repos/LMMS/lmms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LMMS/lmms/downloads","issues_url":"https://api.github.com/repos/LMMS/lmms/issues{/number}","pulls_url":"https://api.github.com/repos/LMMS/lmms/pulls{/number}","milestones_url":"https://api.github.com/repos/LMMS/lmms/milestones{/number}","notifications_url":"https://api.github.com/repos/LMMS/lmms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LMMS/lmms/labels{/name}","releases_url":"https://api.github.com/repos/LMMS/lmms/releases{/id}","deployments_url":"https://api.github.com/repos/LMMS/lmms/deployments","created_at":"2014-01-09T20:43:43Z","updated_at":"2018-05-30T10:16:03Z","pushed_at":"2018-05-30T10:15:58Z","git_url":"git://github.com/LMMS/lmms.git","ssh_url":"git@github.com:LMMS/lmms.git","clone_url":"https://github.com/LMMS/lmms.git","svn_url":"https://github.com/LMMS/lmms","homepage":"https://lmms.io/","size":79152,"stargazers_count":1972,"watchers_count":1972,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":397,"mirror_url":null,"archived":false,"open_issues_count":741,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":397,"open_issues":741,"watchers":1972,"default_branch":"stable-1.2"}},"_links":{"self":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/4371"},"html":{"href":"https://github.com/LMMS/lmms/pull/4371"},"issue":{"href":"https://api.github.com/repos/LMMS/lmms/issues/4371"},"comments":{"href":"https://api.github.com/repos/LMMS/lmms/issues/4371/comments"},"review_comments":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/4371/comments"},"review_comment":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/4371/commits"},"statuses":{"href":"https://api.github.com/repos/LMMS/lmms/statuses/0a8fabcdc1050a429241078d2116d8b4f887e301"}},"author_association":"NONE"}}
{"actor":{"display_login":"justnope"}}