{"action":"created","issue":{"url":"https://api.github.com/repos/afourmy/flask-gentelella/issues/8","repository_url":"https://api.github.com/repos/afourmy/flask-gentelella","labels_url":"https://api.github.com/repos/afourmy/flask-gentelella/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/afourmy/flask-gentelella/issues/8/comments","events_url":"https://api.github.com/repos/afourmy/flask-gentelella/issues/8/events","html_url":"https://github.com/afourmy/flask-gentelella/pull/8","id":376326218,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NTY3MzE4","number":8,"title":"Add basic support for themes. Theme can be configured in config file …","user":{"login":"mwallraf","id":935879,"node_id":"MDQ6VXNlcjkzNTg3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/935879?v=4","gravatar_id":"","url":"https://api.github.com/users/mwallraf","html_url":"https://github.com/mwallraf","followers_url":"https://api.github.com/users/mwallraf/followers","following_url":"https://api.github.com/users/mwallraf/following{/other_user}","gists_url":"https://api.github.com/users/mwallraf/gists{/gist_id}","starred_url":"https://api.github.com/users/mwallraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwallraf/subscriptions","organizations_url":"https://api.github.com/users/mwallraf/orgs","repos_url":"https://api.github.com/users/mwallraf/repos","events_url":"https://api.github.com/users/mwallraf/events{/privacy}","received_events_url":"https://api.github.com/users/mwallraf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-01T09:59:47Z","updated_at":"2018-11-01T10:16:09Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/afourmy/flask-gentelella/pulls/8","html_url":"https://github.com/afourmy/flask-gentelella/pull/8","diff_url":"https://github.com/afourmy/flask-gentelella/pull/8.diff","patch_url":"https://github.com/afourmy/flask-gentelella/pull/8.patch"},"body":"…or directly in url_for()\r\n\r\nHi, as discussed earlier, here's the PR to include support for themes in flask-gentelella.\r\n\r\nIf no theme is provided in the config file then nothing changes, if a theme name is configured then all static files should exist in /static/theme_name/ (in all blueprints)\r\nOr it's possible to include a theme for each individual url_for('static', filename='', theme='') request.\r\n\r\nI've included a sample 'theme_dark' theme which is exactly the same as the original but with a dark default background.\r\n"},"comment":{"url":"https://api.github.com/repos/afourmy/flask-gentelella/issues/comments/434995694","html_url":"https://github.com/afourmy/flask-gentelella/pull/8#issuecomment-434995694","issue_url":"https://api.github.com/repos/afourmy/flask-gentelella/issues/8","id":434995694,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDk5NTY5NA==","user":{"login":"afourmy","id":16152622,"node_id":"MDQ6VXNlcjE2MTUyNjIy","avatar_url":"https://avatars1.githubusercontent.com/u/16152622?v=4","gravatar_id":"","url":"https://api.github.com/users/afourmy","html_url":"https://github.com/afourmy","followers_url":"https://api.github.com/users/afourmy/followers","following_url":"https://api.github.com/users/afourmy/following{/other_user}","gists_url":"https://api.github.com/users/afourmy/gists{/gist_id}","starred_url":"https://api.github.com/users/afourmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afourmy/subscriptions","organizations_url":"https://api.github.com/users/afourmy/orgs","repos_url":"https://api.github.com/users/afourmy/repos","events_url":"https://api.github.com/users/afourmy/events{/privacy}","received_events_url":"https://api.github.com/users/afourmy/received_events","type":"User","site_admin":false},"created_at":"2018-11-01T10:16:09Z","updated_at":"2018-11-01T10:16:09Z","author_association":"OWNER","body":"The problem is that it doesn't scale: you're adding 4K duplicated files (2M lines of code - almost all the project in fact) per theme. \r\n\r\n[Travis](https://travis-ci.org/afourmy/flask-gentelella/) complains because the files in the theme folder are not ignored by [ESlint](https://github.com/afourmy/flask-gentelella/blob/master/.eslintignore) (that's what causes the build to fail).\r\n\r\nCan you update `url_for` to default to the `static` folder in case a file is not found in the theme folder, such that if you add a theme that changes the background color, you'll need to add only that one file to the theme folder ? \r\n\r\nThanks"}}
{"actor":{"display_login":"afourmy"}}