{"action":"created","comment":{"url":"https://api.github.com/repos/sbt/sbt/pulls/comments/172625037","pull_request_review_id":101674436,"id":172625037,"diff_hunk":"@@ -38,32 +40,31 @@ def buildLevelSettings: Seq[Setting[_]] =\n       scalafmtVersion := \"1.3.0\",\n     ))\n \n-def commonSettings: Seq[Setting[_]] =\n-  Seq[SettingsDefinition](\n-    headerLicense := Some(HeaderLicense.Custom(\n-      \"\"\"|sbt\n-         |Copyright 2011 - 2017, Lightbend, Inc.\n-         |Copyright 2008 - 2010, Mark Harrah\n-         |Licensed under BSD-3-Clause license (see LICENSE)\n-         |\"\"\".stripMargin\n-    )),\n-    scalaVersion := baseScalaVersion,\n-    componentID := None,\n-    resolvers += Resolver.typesafeIvyRepo(\"releases\"),\n-    resolvers += Resolver.sonatypeRepo(\"snapshots\"),\n-    resolvers += \"bintray-sbt-maven-releases\" at \"https://dl.bintray.com/sbt/maven-releases/\",\n-    addCompilerPlugin(\"org.spire-math\" % \"kind-projector\" % \"0.9.4\" cross CrossVersion.binary),\n-    concurrentRestrictions in Global += Util.testExclusiveRestriction,\n-    testOptions in Test += Tests.Argument(TestFrameworks.ScalaCheck, \"-w\", \"1\"),\n-    testOptions in Test += Tests.Argument(TestFrameworks.ScalaCheck, \"-verbosity\", \"2\"),\n-    javacOptions in compile ++= Seq(\"-Xlint\", \"-Xlint:-serial\"),\n-    crossScalaVersions := Seq(baseScalaVersion),\n-    bintrayPackage := (bintrayPackage in ThisBuild).value,\n-    bintrayRepository := (bintrayRepository in ThisBuild).value,\n-    publishArtifact in Test := false,\n-    fork in compile := true,\n-    fork in run := true\n-  ) flatMap (_.settings)\n+def commonSettings: Seq[Setting[_]] = Def settings (","path":"build.sbt","position":47,"original_position":47,"commit_id":"4b36bca5ec6e37ac86655edf643b86f12ce6fb37","original_commit_id":"4b36bca5ec6e37ac86655edf643b86f12ce6fb37","user":{"login":"eed3si9n","id":184683,"avatar_url":"https://avatars0.githubusercontent.com/u/184683?v=4","gravatar_id":"","url":"https://api.github.com/users/eed3si9n","html_url":"https://github.com/eed3si9n","followers_url":"https://api.github.com/users/eed3si9n/followers","following_url":"https://api.github.com/users/eed3si9n/following{/other_user}","gists_url":"https://api.github.com/users/eed3si9n/gists{/gist_id}","starred_url":"https://api.github.com/users/eed3si9n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eed3si9n/subscriptions","organizations_url":"https://api.github.com/users/eed3si9n/orgs","repos_url":"https://api.github.com/users/eed3si9n/repos","events_url":"https://api.github.com/users/eed3si9n/events{/privacy}","received_events_url":"https://api.github.com/users/eed3si9n/received_events","type":"User","site_admin":false},"body":"A function should be denoted with dot `Def.settings`.","created_at":"2018-03-06T19:03:38Z","updated_at":"2018-03-06T19:03:39Z","html_url":"https://github.com/sbt/sbt/pull/3988#discussion_r172625037","pull_request_url":"https://api.github.com/repos/sbt/sbt/pulls/3988","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/sbt/sbt/pulls/comments/172625037"},"html":{"href":"https://github.com/sbt/sbt/pull/3988#discussion_r172625037"},"pull_request":{"href":"https://api.github.com/repos/sbt/sbt/pulls/3988"}}},"pull_request":{"url":"https://api.github.com/repos/sbt/sbt/pulls/3988","id":173138080,"html_url":"https://github.com/sbt/sbt/pull/3988","diff_url":"https://github.com/sbt/sbt/pull/3988.diff","patch_url":"https://github.com/sbt/sbt/pull/3988.patch","issue_url":"https://api.github.com/repos/sbt/sbt/issues/3988","number":3988,"state":"open","locked":false,"title":"Cleanups from my recent work in scripted","user":{"login":"dwijnand","id":344610,"avatar_url":"https://avatars1.githubusercontent.com/u/344610?v=4","gravatar_id":"","url":"https://api.github.com/users/dwijnand","html_url":"https://github.com/dwijnand","followers_url":"https://api.github.com/users/dwijnand/followers","following_url":"https://api.github.com/users/dwijnand/following{/other_user}","gists_url":"https://api.github.com/users/dwijnand/gists{/gist_id}","starred_url":"https://api.github.com/users/dwijnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwijnand/subscriptions","organizations_url":"https://api.github.com/users/dwijnand/orgs","repos_url":"https://api.github.com/users/dwijnand/repos","events_url":"https://api.github.com/users/dwijnand/events{/privacy}","received_events_url":"https://api.github.com/users/dwijnand/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-03-06T12:03:29Z","updated_at":"2018-03-06T19:03:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82b5a26fc9e8ed13ec2bf96e0b07029f89d0c793","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":123869845,"url":"https://api.github.com/repos/sbt/sbt/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sbt/sbt/pulls/3988/commits","review_comments_url":"https://api.github.com/repos/sbt/sbt/pulls/3988/comments","review_comment_url":"https://api.github.com/repos/sbt/sbt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sbt/sbt/issues/3988/comments","statuses_url":"https://api.github.com/repos/sbt/sbt/statuses/4b36bca5ec6e37ac86655edf643b86f12ce6fb37","head":{"label":"dwijnand:scripted-cleanups","ref":"scripted-cleanups","sha":"4b36bca5ec6e37ac86655edf643b86f12ce6fb37","user":{"login":"dwijnand","id":344610,"avatar_url":"https://avatars1.githubusercontent.com/u/344610?v=4","gravatar_id":"","url":"https://api.github.com/users/dwijnand","html_url":"https://github.com/dwijnand","followers_url":"https://api.github.com/users/dwijnand/followers","following_url":"https://api.github.com/users/dwijnand/following{/other_user}","gists_url":"https://api.github.com/users/dwijnand/gists{/gist_id}","starred_url":"https://api.github.com/users/dwijnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwijnand/subscriptions","organizations_url":"https://api.github.com/users/dwijnand/orgs","repos_url":"https://api.github.com/users/dwijnand/repos","events_url":"https://api.github.com/users/dwijnand/events{/privacy}","received_events_url":"https://api.github.com/users/dwijnand/received_events","type":"User","site_admin":false},"repo":{"id":61502490,"name":"sbt","full_name":"dwijnand/sbt","owner":{"login":"dwijnand","id":344610,"avatar_url":"https://avatars1.githubusercontent.com/u/344610?v=4","gravatar_id":"","url":"https://api.github.com/users/dwijnand","html_url":"https://github.com/dwijnand","followers_url":"https://api.github.com/users/dwijnand/followers","following_url":"https://api.github.com/users/dwijnand/following{/other_user}","gists_url":"https://api.github.com/users/dwijnand/gists{/gist_id}","starred_url":"https://api.github.com/users/dwijnand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwijnand/subscriptions","organizations_url":"https://api.github.com/users/dwijnand/orgs","repos_url":"https://api.github.com/users/dwijnand/repos","events_url":"https://api.github.com/users/dwijnand/events{/privacy}","received_events_url":"https://api.github.com/users/dwijnand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dwijnand/sbt","description":"sbt, the interactive build tool","fork":true,"url":"https://api.github.com/repos/dwijnand/sbt","forks_url":"https://api.github.com/repos/dwijnand/sbt/forks","keys_url":"https://api.github.com/repos/dwijnand/sbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dwijnand/sbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dwijnand/sbt/teams","hooks_url":"https://api.github.com/repos/dwijnand/sbt/hooks","issue_events_url":"https://api.github.com/repos/dwijnand/sbt/issues/events{/number}","events_url":"https://api.github.com/repos/dwijnand/sbt/events","assignees_url":"https://api.github.com/repos/dwijnand/sbt/assignees{/user}","branches_url":"https://api.github.com/repos/dwijnand/sbt/branches{/branch}","tags_url":"https://api.github.com/repos/dwijnand/sbt/tags","blobs_url":"https://api.github.com/repos/dwijnand/sbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dwijnand/sbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dwijnand/sbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/dwijnand/sbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dwijnand/sbt/statuses/{sha}","languages_url":"https://api.github.com/repos/dwijnand/sbt/languages","stargazers_url":"https://api.github.com/repos/dwijnand/sbt/stargazers","contributors_url":"https://api.github.com/repos/dwijnand/sbt/contributors","subscribers_url":"https://api.github.com/repos/dwijnand/sbt/subscribers","subscription_url":"https://api.github.com/repos/dwijnand/sbt/subscription","commits_url":"https://api.github.com/repos/dwijnand/sbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/dwijnand/sbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/dwijnand/sbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/dwijnand/sbt/issues/comments{/number}","contents_url":"https://api.github.com/repos/dwijnand/sbt/contents/{+path}","compare_url":"https://api.github.com/repos/dwijnand/sbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dwijnand/sbt/merges","archive_url":"https://api.github.com/repos/dwijnand/sbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dwijnand/sbt/downloads","issues_url":"https://api.github.com/repos/dwijnand/sbt/issues{/number}","pulls_url":"https://api.github.com/repos/dwijnand/sbt/pulls{/number}","milestones_url":"https://api.github.com/repos/dwijnand/sbt/milestones{/number}","notifications_url":"https://api.github.com/repos/dwijnand/sbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dwijnand/sbt/labels{/name}","releases_url":"https://api.github.com/repos/dwijnand/sbt/releases{/id}","deployments_url":"https://api.github.com/repos/dwijnand/sbt/deployments","created_at":"2016-06-19T22:02:57Z","updated_at":"2016-06-19T22:04:35Z","pushed_at":"2018-03-06T18:05:44Z","git_url":"git://github.com/dwijnand/sbt.git","ssh_url":"git@github.com:dwijnand/sbt.git","clone_url":"https://github.com/dwijnand/sbt.git","svn_url":"https://github.com/dwijnand/sbt","homepage":"http://scala-sbt.org","size":15253,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"z"}},"base":{"label":"sbt:1.x","ref":"1.x","sha":"90cd60f3b90a1b640453d8f3988a904f49ce2d19","user":{"login":"sbt","id":1158012,"avatar_url":"https://avatars2.githubusercontent.com/u/1158012?v=4","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"repo":{"id":279553,"name":"sbt","full_name":"sbt/sbt","owner":{"login":"sbt","id":1158012,"avatar_url":"https://avatars2.githubusercontent.com/u/1158012?v=4","gravatar_id":"","url":"https://api.github.com/users/sbt","html_url":"https://github.com/sbt","followers_url":"https://api.github.com/users/sbt/followers","following_url":"https://api.github.com/users/sbt/following{/other_user}","gists_url":"https://api.github.com/users/sbt/gists{/gist_id}","starred_url":"https://api.github.com/users/sbt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbt/subscriptions","organizations_url":"https://api.github.com/users/sbt/orgs","repos_url":"https://api.github.com/users/sbt/repos","events_url":"https://api.github.com/users/sbt/events{/privacy}","received_events_url":"https://api.github.com/users/sbt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sbt/sbt","description":"sbt, the interactive build tool","fork":false,"url":"https://api.github.com/repos/sbt/sbt","forks_url":"https://api.github.com/repos/sbt/sbt/forks","keys_url":"https://api.github.com/repos/sbt/sbt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbt/sbt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbt/sbt/teams","hooks_url":"https://api.github.com/repos/sbt/sbt/hooks","issue_events_url":"https://api.github.com/repos/sbt/sbt/issues/events{/number}","events_url":"https://api.github.com/repos/sbt/sbt/events","assignees_url":"https://api.github.com/repos/sbt/sbt/assignees{/user}","branches_url":"https://api.github.com/repos/sbt/sbt/branches{/branch}","tags_url":"https://api.github.com/repos/sbt/sbt/tags","blobs_url":"https://api.github.com/repos/sbt/sbt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbt/sbt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbt/sbt/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbt/sbt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbt/sbt/statuses/{sha}","languages_url":"https://api.github.com/repos/sbt/sbt/languages","stargazers_url":"https://api.github.com/repos/sbt/sbt/stargazers","contributors_url":"https://api.github.com/repos/sbt/sbt/contributors","subscribers_url":"https://api.github.com/repos/sbt/sbt/subscribers","subscription_url":"https://api.github.com/repos/sbt/sbt/subscription","commits_url":"https://api.github.com/repos/sbt/sbt/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbt/sbt/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbt/sbt/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbt/sbt/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbt/sbt/contents/{+path}","compare_url":"https://api.github.com/repos/sbt/sbt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbt/sbt/merges","archive_url":"https://api.github.com/repos/sbt/sbt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbt/sbt/downloads","issues_url":"https://api.github.com/repos/sbt/sbt/issues{/number}","pulls_url":"https://api.github.com/repos/sbt/sbt/pulls{/number}","milestones_url":"https://api.github.com/repos/sbt/sbt/milestones{/number}","notifications_url":"https://api.github.com/repos/sbt/sbt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbt/sbt/labels{/name}","releases_url":"https://api.github.com/repos/sbt/sbt/releases{/id}","deployments_url":"https://api.github.com/repos/sbt/sbt/deployments","created_at":"2009-08-17T00:31:14Z","updated_at":"2018-03-06T10:37:04Z","pushed_at":"2018-03-06T18:05:49Z","git_url":"git://github.com/sbt/sbt.git","ssh_url":"git@github.com:sbt/sbt.git","clone_url":"https://github.com/sbt/sbt.git","svn_url":"https://github.com/sbt/sbt","homepage":"https://scala-sbt.org","size":16862,"stargazers_count":3449,"watchers_count":3449,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":664,"mirror_url":null,"archived":false,"open_issues_count":769,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":664,"open_issues":769,"watchers":3449,"default_branch":"1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sbt/sbt/pulls/3988"},"html":{"href":"https://github.com/sbt/sbt/pull/3988"},"issue":{"href":"https://api.github.com/repos/sbt/sbt/issues/3988"},"comments":{"href":"https://api.github.com/repos/sbt/sbt/issues/3988/comments"},"review_comments":{"href":"https://api.github.com/repos/sbt/sbt/pulls/3988/comments"},"review_comment":{"href":"https://api.github.com/repos/sbt/sbt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sbt/sbt/pulls/3988/commits"},"statuses":{"href":"https://api.github.com/repos/sbt/sbt/statuses/4b36bca5ec6e37ac86655edf643b86f12ce6fb37"}},"author_association":"OWNER"}}
{"actor":{"display_login":"eed3si9n"}}