{"action":"created","issue":{"url":"https://api.github.com/repos/drush-ops/drush/issues/3402","repository_url":"https://api.github.com/repos/drush-ops/drush","labels_url":"https://api.github.com/repos/drush-ops/drush/issues/3402/labels{/name}","comments_url":"https://api.github.com/repos/drush-ops/drush/issues/3402/comments","events_url":"https://api.github.com/repos/drush-ops/drush/issues/3402/events","html_url":"https://github.com/drush-ops/drush/pull/3402","id":298644820,"number":3402,"title":"Add the migrate runner commands","user":{"login":"claudiu-cristea","id":473868,"avatar_url":"https://avatars0.githubusercontent.com/u/473868?v=4","gravatar_id":"","url":"https://api.github.com/users/claudiu-cristea","html_url":"https://github.com/claudiu-cristea","followers_url":"https://api.github.com/users/claudiu-cristea/followers","following_url":"https://api.github.com/users/claudiu-cristea/following{/other_user}","gists_url":"https://api.github.com/users/claudiu-cristea/gists{/gist_id}","starred_url":"https://api.github.com/users/claudiu-cristea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudiu-cristea/subscriptions","organizations_url":"https://api.github.com/users/claudiu-cristea/orgs","repos_url":"https://api.github.com/users/claudiu-cristea/repos","events_url":"https://api.github.com/users/claudiu-cristea/events{/privacy}","received_events_url":"https://api.github.com/users/claudiu-cristea/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-02-20T15:49:57Z","updated_at":"2018-03-12T15:01:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/drush-ops/drush/pulls/3402","html_url":"https://github.com/drush-ops/drush/pull/3402","diff_url":"https://github.com/drush-ops/drush/pull/3402.diff","patch_url":"https://github.com/drush-ops/drush/pull/3402.patch"},"body":"Resolves #2926\r\n\r\n### Should be fixed before merging:\r\n\r\n- ~https://www.drupal.org/project/migrate_run/issues/2914429~ ✔️\r\n- ~Migrate import runs dependent migrations multiple times.~ ✔️\r\n- ~Add documentation on how to write and run migrations.~ ✔️\r\n- Add a doc section specifically telling folks how to get started with Drupal => Drupal upgrades. How to make use of the migrations that are in core.\r\n- ~Move~ Copy example modules from `migrate_plus` into https://www.drupal.org/project/examples. Examples provide in Migrate Plus are coupled to the module so, probably we cannot move them, we should create some adapted versions in https://www.drupal.org/project/examples.\r\n- This plan was drafted with Lucas Hedding (@heddn) and Moshe Weitzman (@weitzman). Prepare `migrate_tools`, `migrate_plus` to adapt the new Drush core feature. We need to coordinate new releases of Migrate Plus & Migrate Tools and also add the composer constraints in Drush:\r\n  - Module `migrate_plus` will alter the Drush core commands `migrate:status`, `migrate:import` and `migrate:rollback` in order to support migration grouping, which is a feature of Migrate Plus. The reason why this command alter is added in `migrate_plus` and not in `migrate_tools` is that the migration grouping is provided by `migrate_plus`. So, we don't provide new Drush 9 commands, we're altering existing Drush core commands. A new branch (`8.x-5.x`) will hold these changes. [Drupal.org issue #2951968](https://www.drupal.org/project/migrate_plus/issues/2951968).\r\n  - Drush 9 commands will be removed from `migrate_tools` because they are provided now in core. When used with Drush 8, the commands are still provided in the `*.drush.inc` file. A new branch (`8.x-5.x`) will hold these changes. Drupal.org issue [TBD].\r\n \r\nOther improvements can be added after merging."},"comment":{"url":"https://api.github.com/repos/drush-ops/drush/issues/comments/372340742","html_url":"https://github.com/drush-ops/drush/pull/3402#issuecomment-372340742","issue_url":"https://api.github.com/repos/drush-ops/drush/issues/3402","id":372340742,"user":{"login":"Eli-TW","id":440637,"avatar_url":"https://avatars1.githubusercontent.com/u/440637?v=4","gravatar_id":"","url":"https://api.github.com/users/Eli-TW","html_url":"https://github.com/Eli-TW","followers_url":"https://api.github.com/users/Eli-TW/followers","following_url":"https://api.github.com/users/Eli-TW/following{/other_user}","gists_url":"https://api.github.com/users/Eli-TW/gists{/gist_id}","starred_url":"https://api.github.com/users/Eli-TW/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eli-TW/subscriptions","organizations_url":"https://api.github.com/users/Eli-TW/orgs","repos_url":"https://api.github.com/users/Eli-TW/repos","events_url":"https://api.github.com/users/Eli-TW/events{/privacy}","received_events_url":"https://api.github.com/users/Eli-TW/received_events","type":"User","site_admin":false},"created_at":"2018-03-12T15:01:59Z","updated_at":"2018-03-12T15:01:59Z","author_association":"NONE","body":"Question with respect to this approach - if migrate_plus alters the core commands rather than migrate_tools, that means people wanting to use other parts of migrate_plus (eg the prepareRow event, the JSON/XML source plugins) will be forced to use its commands rather than the Drush ones, whereas before it would have been possible to use migrate run with those source plugins. Is that correct? And is that a limitation that we have decided to accept?"}}
{"actor":{"display_login":"Eli-TW"}}