{"action":"created","issue":{"url":"https://api.github.com/repos/gsrafael01/ESGST/issues/896","repository_url":"https://api.github.com/repos/gsrafael01/ESGST","labels_url":"https://api.github.com/repos/gsrafael01/ESGST/issues/896/labels{/name}","comments_url":"https://api.github.com/repos/gsrafael01/ESGST/issues/896/comments","events_url":"https://api.github.com/repos/gsrafael01/ESGST/issues/896/events","html_url":"https://github.com/gsrafael01/ESGST/issues/896","id":352043715,"node_id":"MDU6SXNzdWUzNTIwNDM3MTU=","number":896,"title":"Split code","user":{"login":"insideone","id":16841572,"node_id":"MDQ6VXNlcjE2ODQxNTcy","avatar_url":"https://avatars1.githubusercontent.com/u/16841572?v=4","gravatar_id":"","url":"https://api.github.com/users/insideone","html_url":"https://github.com/insideone","followers_url":"https://api.github.com/users/insideone/followers","following_url":"https://api.github.com/users/insideone/following{/other_user}","gists_url":"https://api.github.com/users/insideone/gists{/gist_id}","starred_url":"https://api.github.com/users/insideone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insideone/subscriptions","organizations_url":"https://api.github.com/users/insideone/orgs","repos_url":"https://api.github.com/users/insideone/repos","events_url":"https://api.github.com/users/insideone/events{/privacy}","received_events_url":"https://api.github.com/users/insideone/received_events","type":"User","site_admin":false},"labels":[{"id":884216503,"node_id":"MDU6TGFiZWw4ODQyMTY1MDM=","url":"https://api.github.com/repos/gsrafael01/ESGST/labels/Ongoing","name":"Ongoing","color":"f9a270","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":35,"created_at":"2018-08-20T09:00:11Z","updated_at":"2018-09-23T13:56:25Z","closed_at":"2018-08-26T21:58:06Z","author_association":"NONE","body":"Hi, revilheart!\r\n\r\nWould you accept PR with code spliting changes? I want to create builder based on [webpack](https://webpack.js.org/). The result file be identical, but we will get splitted project which is much easier to maintain collectively.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/gsrafael01/ESGST/issues/comments/423818394","html_url":"https://github.com/gsrafael01/ESGST/issues/896#issuecomment-423818394","issue_url":"https://api.github.com/repos/gsrafael01/ESGST/issues/896","id":423818394,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzgxODM5NA==","user":{"login":"insideone","id":16841572,"node_id":"MDQ6VXNlcjE2ODQxNTcy","avatar_url":"https://avatars1.githubusercontent.com/u/16841572?v=4","gravatar_id":"","url":"https://api.github.com/users/insideone","html_url":"https://github.com/insideone","followers_url":"https://api.github.com/users/insideone/followers","following_url":"https://api.github.com/users/insideone/following{/other_user}","gists_url":"https://api.github.com/users/insideone/gists{/gist_id}","starred_url":"https://api.github.com/users/insideone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/insideone/subscriptions","organizations_url":"https://api.github.com/users/insideone/orgs","repos_url":"https://api.github.com/users/insideone/repos","events_url":"https://api.github.com/users/insideone/events{/privacy}","received_events_url":"https://api.github.com/users/insideone/received_events","type":"User","site_admin":false},"created_at":"2018-09-23T13:56:25Z","updated_at":"2018-09-23T13:56:25Z","author_association":"NONE","body":"> And it would be nice if the .meta.js and .user.js files were built in the main directory, because users already get updates from there. If we move its location, I think users will have to update manually.\r\n\r\nGot it. I'll try it today\r\n\r\n> As for the warnings you disabled, I already fixed all of the unfiltered for .. in loops anyway (or at least I think I did), and I'd think that's the safe way to do it, isn't it? And the typo warning is actually useful, I found tons of serious typos with it.\r\n\r\nTypo inspection is helpful, but it generates a lot of false positives. Though if the dictionary will be full then it will be ok. So, let's try turn it on.\r\n\"for .. in\" - maybe I shouldn't have turned it off, but parsedown need 5 fixes (that's will be ok I think)\r\n\r\n> Can I can use <% package.version %> anywhere?\r\n\r\nSadly, no. banner.js got this feature because of this code in `webpack.config.js`:\r\n```javascript\r\nreturn calfinated.process(fs.readFileSync(bannerFile, 'utf8'), {package: packageJson});\r\n```\r\n\r\nI think that it's possible to implement custom loader but I'm not familiar with this.\r\nBut maybe it will be enough:\r\nhttps://webpack.js.org/plugins/define-plugin/\r\n"}}
{"actor":{"display_login":"insideone"}}