{"action":"created","issue":{"url":"https://api.github.com/repos/ApollosProject/apollos-prototype/issues/420","repository_url":"https://api.github.com/repos/ApollosProject/apollos-prototype","labels_url":"https://api.github.com/repos/ApollosProject/apollos-prototype/issues/420/labels{/name}","comments_url":"https://api.github.com/repos/ApollosProject/apollos-prototype/issues/420/comments","events_url":"https://api.github.com/repos/ApollosProject/apollos-prototype/issues/420/events","html_url":"https://github.com/ApollosProject/apollos-prototype/pull/420","id":380483612,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNjcxNDQx","number":420,"title":"Adds more media player polish","user":{"login":"burkeshartsis","id":2053547,"node_id":"MDQ6VXNlcjIwNTM1NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/2053547?v=4","gravatar_id":"","url":"https://api.github.com/users/burkeshartsis","html_url":"https://github.com/burkeshartsis","followers_url":"https://api.github.com/users/burkeshartsis/followers","following_url":"https://api.github.com/users/burkeshartsis/following{/other_user}","gists_url":"https://api.github.com/users/burkeshartsis/gists{/gist_id}","starred_url":"https://api.github.com/users/burkeshartsis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burkeshartsis/subscriptions","organizations_url":"https://api.github.com/users/burkeshartsis/orgs","repos_url":"https://api.github.com/users/burkeshartsis/repos","events_url":"https://api.github.com/users/burkeshartsis/events{/privacy}","received_events_url":"https://api.github.com/users/burkeshartsis/received_events","type":"User","site_admin":false},"labels":[{"id":949595072,"node_id":"MDU6TGFiZWw5NDk1OTUwNzI=","url":"https://api.github.com/repos/ApollosProject/apollos-prototype/labels/ready%20for%20review","name":"ready for review","color":"e8da63","default":false}],"state":"open","locked":false,"assignee":{"login":"conrad-vanl","id":103927,"node_id":"MDQ6VXNlcjEwMzkyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/103927?v=4","gravatar_id":"","url":"https://api.github.com/users/conrad-vanl","html_url":"https://github.com/conrad-vanl","followers_url":"https://api.github.com/users/conrad-vanl/followers","following_url":"https://api.github.com/users/conrad-vanl/following{/other_user}","gists_url":"https://api.github.com/users/conrad-vanl/gists{/gist_id}","starred_url":"https://api.github.com/users/conrad-vanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conrad-vanl/subscriptions","organizations_url":"https://api.github.com/users/conrad-vanl/orgs","repos_url":"https://api.github.com/users/conrad-vanl/repos","events_url":"https://api.github.com/users/conrad-vanl/events{/privacy}","received_events_url":"https://api.github.com/users/conrad-vanl/received_events","type":"User","site_admin":false},"assignees":[{"login":"conrad-vanl","id":103927,"node_id":"MDQ6VXNlcjEwMzkyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/103927?v=4","gravatar_id":"","url":"https://api.github.com/users/conrad-vanl","html_url":"https://github.com/conrad-vanl","followers_url":"https://api.github.com/users/conrad-vanl/followers","following_url":"https://api.github.com/users/conrad-vanl/following{/other_user}","gists_url":"https://api.github.com/users/conrad-vanl/gists{/gist_id}","starred_url":"https://api.github.com/users/conrad-vanl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conrad-vanl/subscriptions","organizations_url":"https://api.github.com/users/conrad-vanl/orgs","repos_url":"https://api.github.com/users/conrad-vanl/repos","events_url":"https://api.github.com/users/conrad-vanl/events{/privacy}","received_events_url":"https://api.github.com/users/conrad-vanl/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-11-14T00:26:56Z","updated_at":"2018-11-15T05:32:37Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ApollosProject/apollos-prototype/pulls/420","html_url":"https://github.com/ApollosProject/apollos-prototype/pull/420","diff_url":"https://github.com/ApollosProject/apollos-prototype/pull/420.diff","patch_url":"https://github.com/ApollosProject/apollos-prototype/pull/420.patch"},"body":"## DESCRIPTION\r\nThis PR implements changes made in #416 to addd support for Android's native ripple. In doing so we fix #382 and all code changes needed for #383. \r\n### What does this PR do, or why is it needed?\r\nBy using the improvements from the new `Touchable` and adding a new `ButtonIcon` component that intelligently pads icons appropriately (but flexibly) we dramatically improve UX.\r\n\r\nThis also fixes some crash bugs when skipping before the video was loaded.\r\n### What design trade-offs/decisions were made?\r\nI think `ButtonIcon` could be improved to take a style object or at least a padding object so that padding can be applied however one wishes. This is particularly noticeable on the mini player where the padding on the play button is awkward.\r\n\r\nWith regards to the crashes, our fix solves for the crash but now the play head jitters around if you try to skip back 30 sec before 30sec have elapsed. There is some improvement here that could be made. Ideally, if there is less than 30sec the video should just start over from the beginning. \r\n### How do I test this PR?\r\n`yarn test` 💥 \r\n### What automated tests did you write?\r\n🍪's\r\n## TODO:\r\n\r\n- [x] PR has a relevant title that will be understandable in a public changelog (ie...non developers)\r\n- [x] Closes #383 and fixes #382 \r\n- [x] No new warnings in tests, in storybook, and in-app\r\n- [ ] Upload GIF(s) of iOS and Android\r\n- [x] Set a relevant reviewer\r\n\r\n## REVIEW:\r\n\r\n**Manual QA**\r\n\r\n- [ ] Manual QA on iOS and ensure it looks/behaves as expected\r\n- [ ] Manual QA on Android and ensure it looks/behaves as expected\r\n\r\n**Code Review: Questions to consider**\r\n\r\n- [ ] Read through the \"Files changed\" tab _very carefully_\r\n- [ ] Edge cases: what assumptions are made about input?\r\n- [ ] What kind of tests could be written?\r\n- [ ] How might we make this easier for someone else to understand?\r\n- [ ] Could the code be simpler?\r\n- [ ] Will the code be easy to modify in the future?\r\n- [ ] What's one part of these changes that makes you excited to merge it?\r\n\r\n> The purpose of PR Review is to _improve the quality of the software._\r\n"},"comment":{"url":"https://api.github.com/repos/ApollosProject/apollos-prototype/issues/comments/438923157","html_url":"https://github.com/ApollosProject/apollos-prototype/pull/420#issuecomment-438923157","issue_url":"https://api.github.com/repos/ApollosProject/apollos-prototype/issues/420","id":438923157,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODkyMzE1Nw==","user":{"login":"burkeshartsis","id":2053547,"node_id":"MDQ6VXNlcjIwNTM1NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/2053547?v=4","gravatar_id":"","url":"https://api.github.com/users/burkeshartsis","html_url":"https://github.com/burkeshartsis","followers_url":"https://api.github.com/users/burkeshartsis/followers","following_url":"https://api.github.com/users/burkeshartsis/following{/other_user}","gists_url":"https://api.github.com/users/burkeshartsis/gists{/gist_id}","starred_url":"https://api.github.com/users/burkeshartsis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burkeshartsis/subscriptions","organizations_url":"https://api.github.com/users/burkeshartsis/orgs","repos_url":"https://api.github.com/users/burkeshartsis/repos","events_url":"https://api.github.com/users/burkeshartsis/events{/privacy}","received_events_url":"https://api.github.com/users/burkeshartsis/received_events","type":"User","site_admin":false},"created_at":"2018-11-15T05:32:37Z","updated_at":"2018-11-15T05:32:37Z","author_association":"MEMBER","body":"@conrad-vanl I think this is ready for a first pass review. I expect there will need to be some additional work."}}
{"actor":{"display_login":"burkeshartsis"}}