{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/228168930","pull_request_review_id":168376329,"id":228168930,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODE2ODkzMA==","diff_hunk":"@@ -22,9 +22,12 @@ use Carp;\n \n sub wicked_command {\n     my ($self, $action, $iface) = @_;\n-    my $cmd = q(/usr/sbin/wicked --debug all --log-target syslog ) . $action . ' --timeout infinite ' . $iface;\n+    my $cmd = '/usr/sbin/wicked --debug all --log-target syslog ' . $action . ' --timeout infinite ' . $iface;\n+    assert_script_run(q(echo -e \"\\n# \") . $cmd . ' >> /tmp/wicked_serial.log');","path":"lib/wickedbase.pm","position":6,"original_position":6,"commit_id":"1b7e9f7463c7926ebb7ce729cd833892719634d1","original_commit_id":"1d830d9826f92a5639bfd917e549eb16ae3c97d9","user":{"login":"jlausuch","id":11728254,"node_id":"MDQ6VXNlcjExNzI4MjU0","avatar_url":"https://avatars3.githubusercontent.com/u/11728254?v=4","gravatar_id":"","url":"https://api.github.com/users/jlausuch","html_url":"https://github.com/jlausuch","followers_url":"https://api.github.com/users/jlausuch/followers","following_url":"https://api.github.com/users/jlausuch/following{/other_user}","gists_url":"https://api.github.com/users/jlausuch/gists{/gist_id}","starred_url":"https://api.github.com/users/jlausuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlausuch/subscriptions","organizations_url":"https://api.github.com/users/jlausuch/orgs","repos_url":"https://api.github.com/users/jlausuch/repos","events_url":"https://api.github.com/users/jlausuch/events{/privacy}","received_events_url":"https://api.github.com/users/jlausuch/received_events","type":"User","site_admin":false},"body":"@asmorodskyi I did this to avoid searching things in serial_terminal.txt which contains all the commands of all the tests and openqa stuff. This way, we have isolated wicked commands + output in a single file fore each test. This is an example of this file for one test: https://pastebin.com/raw/yaQ433Ly","created_at":"2018-10-25T13:19:44Z","updated_at":"2018-10-25T13:19:44Z","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6035#discussion_r228168930","pull_request_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6035","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/228168930"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6035#discussion_r228168930"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6035"}},"in_reply_to_id":228144830},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6035","id":225367781,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzY3Nzgx","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6035","diff_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6035.diff","patch_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6035.patch","issue_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/6035","number":6035,"state":"open","locked":false,"title":"wicked: collect logs before and after each module","user":{"login":"jlausuch","id":11728254,"node_id":"MDQ6VXNlcjExNzI4MjU0","avatar_url":"https://avatars3.githubusercontent.com/u/11728254?v=4","gravatar_id":"","url":"https://api.github.com/users/jlausuch","html_url":"https://github.com/jlausuch","followers_url":"https://api.github.com/users/jlausuch/followers","following_url":"https://api.github.com/users/jlausuch/following{/other_user}","gists_url":"https://api.github.com/users/jlausuch/gists{/gist_id}","starred_url":"https://api.github.com/users/jlausuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlausuch/subscriptions","organizations_url":"https://api.github.com/users/jlausuch/orgs","repos_url":"https://api.github.com/users/jlausuch/repos","events_url":"https://api.github.com/users/jlausuch/events{/privacy}","received_events_url":"https://api.github.com/users/jlausuch/received_events","type":"User","site_admin":false},"body":"Collect logs before and after each module is executed.\r\nThanks to \"revert to snapshot feature\", we will not drag logs from test X in test X+1 \r\n \r\n- Related ticket: https://progress.opensuse.org/issues/42641\r\n- Verification runs: \r\n  basic: http://fromm.arch.suse.de/tests/2489#downloads\r\n  advanced: http://fromm.arch.suse.de/tests/2486#downloads\r\n  startstop: http://fromm.arch.suse.de/tests/2483#downloads\r\n\r\n","created_at":"2018-10-24T11:36:56Z","updated_at":"2018-10-25T13:19:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f75e49a203eb29a0dbb50944a2ae895608b4c671","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6035/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6035/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/6035/comments","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/1b7e9f7463c7926ebb7ce729cd833892719634d1","head":{"label":"jlausuch:wicked_get_logs","ref":"wicked_get_logs","sha":"1b7e9f7463c7926ebb7ce729cd833892719634d1","user":{"login":"jlausuch","id":11728254,"node_id":"MDQ6VXNlcjExNzI4MjU0","avatar_url":"https://avatars3.githubusercontent.com/u/11728254?v=4","gravatar_id":"","url":"https://api.github.com/users/jlausuch","html_url":"https://github.com/jlausuch","followers_url":"https://api.github.com/users/jlausuch/followers","following_url":"https://api.github.com/users/jlausuch/following{/other_user}","gists_url":"https://api.github.com/users/jlausuch/gists{/gist_id}","starred_url":"https://api.github.com/users/jlausuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlausuch/subscriptions","organizations_url":"https://api.github.com/users/jlausuch/orgs","repos_url":"https://api.github.com/users/jlausuch/repos","events_url":"https://api.github.com/users/jlausuch/events{/privacy}","received_events_url":"https://api.github.com/users/jlausuch/received_events","type":"User","site_admin":false},"repo":{"id":151088387,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEwODgzODc=","name":"os-autoinst-distri-opensuse","full_name":"jlausuch/os-autoinst-distri-opensuse","private":false,"owner":{"login":"jlausuch","id":11728254,"node_id":"MDQ6VXNlcjExNzI4MjU0","avatar_url":"https://avatars3.githubusercontent.com/u/11728254?v=4","gravatar_id":"","url":"https://api.github.com/users/jlausuch","html_url":"https://github.com/jlausuch","followers_url":"https://api.github.com/users/jlausuch/followers","following_url":"https://api.github.com/users/jlausuch/following{/other_user}","gists_url":"https://api.github.com/users/jlausuch/gists{/gist_id}","starred_url":"https://api.github.com/users/jlausuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlausuch/subscriptions","organizations_url":"https://api.github.com/users/jlausuch/orgs","repos_url":"https://api.github.com/users/jlausuch/repos","events_url":"https://api.github.com/users/jlausuch/events{/privacy}","received_events_url":"https://api.github.com/users/jlausuch/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jlausuch/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":true,"url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/jlausuch/os-autoinst-distri-opensuse/deployments","created_at":"2018-10-01T12:53:22Z","updated_at":"2018-10-25T11:11:42Z","pushed_at":"2018-10-25T13:11:08Z","git_url":"git://github.com/jlausuch/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:jlausuch/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/jlausuch/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/jlausuch/os-autoinst-distri-opensuse","homepage":"https://progress.opensuse.org/projects/openqatests/issues","size":97945,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"e8d9adfc0b9f122f7023bdb619e18919ec398ad7","user":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":17630288,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYzMDI4OA==","name":"os-autoinst-distri-opensuse","full_name":"os-autoinst/os-autoinst-distri-opensuse","private":false,"owner":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":false,"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/deployments","created_at":"2014-03-11T12:54:42Z","updated_at":"2018-10-25T12:57:29Z","pushed_at":"2018-10-25T13:11:10Z","git_url":"git://github.com/os-autoinst/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:os-autoinst/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","homepage":"https://progress.opensuse.org/projects/openqatests/issues","size":97970,"stargazers_count":33,"watchers_count":33,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":149,"mirror_url":null,"archived":false,"open_issues_count":58,"license":null,"forks":149,"open_issues":58,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6035"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6035"},"issue":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/6035"},"comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/6035/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6035/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6035/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/1b7e9f7463c7926ebb7ce729cd833892719634d1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jlausuch"}}