{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/omr/pulls/comments/187440025","pull_request_review_id":119222927,"id":187440025,"diff_hunk":"@@ -307,7 +311,9 @@ class VM_AtomicSupport\n \t\t*/\n #elif defined(ARM) /* defined(J9HAMMER) */\n \t\t__sync_synchronize();\n-#else /* defined(ARM) */\n+#elif defined(AARCH64) /* defined(ARM) */\n+\t\t__asm __volatile (\"dmb ishld\":::\"memory\")\n+#else /* defined(AARCH64) */","path":"include_core/AtomicSupport.hpp","position":36,"original_position":36,"commit_id":"9af3661a6b0ad677620e0096c7d617c0ccf3d998","original_commit_id":"9af3661a6b0ad677620e0096c7d617c0ccf3d998","user":{"login":"jeanlego","id":9909445,"avatar_url":"https://avatars2.githubusercontent.com/u/9909445?v=4","gravatar_id":"","url":"https://api.github.com/users/jeanlego","html_url":"https://github.com/jeanlego","followers_url":"https://api.github.com/users/jeanlego/followers","following_url":"https://api.github.com/users/jeanlego/following{/other_user}","gists_url":"https://api.github.com/users/jeanlego/gists{/gist_id}","starred_url":"https://api.github.com/users/jeanlego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeanlego/subscriptions","organizations_url":"https://api.github.com/users/jeanlego/orgs","repos_url":"https://api.github.com/users/jeanlego/repos","events_url":"https://api.github.com/users/jeanlego/events{/privacy}","received_events_url":"https://api.github.com/users/jeanlego/received_events","type":"User","site_admin":false},"body":"line  231, 270, and 315\r\nI have used internal memory barriers, but is this restrictive enough ?\r\n(these can also be used for ARM! )\r\nthere is three shareable domain, inner, outer or  all\r\nsee http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0802b/CIHGHHIE.html","created_at":"2018-05-10T19:52:01Z","updated_at":"2018-05-10T19:52:01Z","html_url":"https://github.com/eclipse/omr/pull/2520#discussion_r187440025","pull_request_url":"https://api.github.com/repos/eclipse/omr/pulls/2520","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments/187440025"},"html":{"href":"https://github.com/eclipse/omr/pull/2520#discussion_r187440025"},"pull_request":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2520"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/omr/pulls/2520","id":185504021,"html_url":"https://github.com/eclipse/omr/pull/2520","diff_url":"https://github.com/eclipse/omr/pull/2520.diff","patch_url":"https://github.com/eclipse/omr/pull/2520.patch","issue_url":"https://api.github.com/repos/eclipse/omr/issues/2520","number":2520,"state":"open","locked":false,"title":"AArch64: Initial Port Library Changes","user":{"login":"aarongraham9","id":1694318,"avatar_url":"https://avatars0.githubusercontent.com/u/1694318?v=4","gravatar_id":"","url":"https://api.github.com/users/aarongraham9","html_url":"https://github.com/aarongraham9","followers_url":"https://api.github.com/users/aarongraham9/followers","following_url":"https://api.github.com/users/aarongraham9/following{/other_user}","gists_url":"https://api.github.com/users/aarongraham9/gists{/gist_id}","starred_url":"https://api.github.com/users/aarongraham9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aarongraham9/subscriptions","organizations_url":"https://api.github.com/users/aarongraham9/orgs","repos_url":"https://api.github.com/users/aarongraham9/repos","events_url":"https://api.github.com/users/aarongraham9/events{/privacy}","received_events_url":"https://api.github.com/users/aarongraham9/received_events","type":"User","site_admin":false},"body":"This PR implements the initial configure/make/build systems, port library and Travis CI cross-compile build for aarch64 (ARM 64-Bit).\r\n\r\nWork by @aarongraham9 and @jeanlego.\r\n\r\nThis is a part of #2327 and #2445.\r\n\r\nSigned-off-by: Aaron Graham aaron.graham@unb.ca ","created_at":"2018-05-02T17:11:23Z","updated_at":"2018-05-10T19:52:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88fbb873be115c9ebddd65dfa44219715abe7924","assignee":{"login":"0xdaryl","id":17713611,"avatar_url":"https://avatars2.githubusercontent.com/u/17713611?v=4","gravatar_id":"","url":"https://api.github.com/users/0xdaryl","html_url":"https://github.com/0xdaryl","followers_url":"https://api.github.com/users/0xdaryl/followers","following_url":"https://api.github.com/users/0xdaryl/following{/other_user}","gists_url":"https://api.github.com/users/0xdaryl/gists{/gist_id}","starred_url":"https://api.github.com/users/0xdaryl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xdaryl/subscriptions","organizations_url":"https://api.github.com/users/0xdaryl/orgs","repos_url":"https://api.github.com/users/0xdaryl/repos","events_url":"https://api.github.com/users/0xdaryl/events{/privacy}","received_events_url":"https://api.github.com/users/0xdaryl/received_events","type":"User","site_admin":false},"assignees":[{"login":"0xdaryl","id":17713611,"avatar_url":"https://avatars2.githubusercontent.com/u/17713611?v=4","gravatar_id":"","url":"https://api.github.com/users/0xdaryl","html_url":"https://github.com/0xdaryl","followers_url":"https://api.github.com/users/0xdaryl/followers","following_url":"https://api.github.com/users/0xdaryl/following{/other_user}","gists_url":"https://api.github.com/users/0xdaryl/gists{/gist_id}","starred_url":"https://api.github.com/users/0xdaryl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xdaryl/subscriptions","organizations_url":"https://api.github.com/users/0xdaryl/orgs","repos_url":"https://api.github.com/users/0xdaryl/repos","events_url":"https://api.github.com/users/0xdaryl/events{/privacy}","received_events_url":"https://api.github.com/users/0xdaryl/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":463261830,"url":"https://api.github.com/repos/eclipse/omr/labels/compiler","name":"compiler","color":"00d73d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/omr/pulls/2520/commits","review_comments_url":"https://api.github.com/repos/eclipse/omr/pulls/2520/comments","review_comment_url":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/omr/issues/2520/comments","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/9af3661a6b0ad677620e0096c7d617c0ccf3d998","head":{"label":"CAS-Atlantic:aarch64","ref":"aarch64","sha":"9af3661a6b0ad677620e0096c7d617c0ccf3d998","user":{"login":"CAS-Atlantic","id":38439176,"avatar_url":"https://avatars1.githubusercontent.com/u/38439176?v=4","gravatar_id":"","url":"https://api.github.com/users/CAS-Atlantic","html_url":"https://github.com/CAS-Atlantic","followers_url":"https://api.github.com/users/CAS-Atlantic/followers","following_url":"https://api.github.com/users/CAS-Atlantic/following{/other_user}","gists_url":"https://api.github.com/users/CAS-Atlantic/gists{/gist_id}","starred_url":"https://api.github.com/users/CAS-Atlantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CAS-Atlantic/subscriptions","organizations_url":"https://api.github.com/users/CAS-Atlantic/orgs","repos_url":"https://api.github.com/users/CAS-Atlantic/repos","events_url":"https://api.github.com/users/CAS-Atlantic/events{/privacy}","received_events_url":"https://api.github.com/users/CAS-Atlantic/received_events","type":"Organization","site_admin":false},"repo":{"id":129790328,"name":"omr","full_name":"CAS-Atlantic/omr","owner":{"login":"CAS-Atlantic","id":38439176,"avatar_url":"https://avatars1.githubusercontent.com/u/38439176?v=4","gravatar_id":"","url":"https://api.github.com/users/CAS-Atlantic","html_url":"https://github.com/CAS-Atlantic","followers_url":"https://api.github.com/users/CAS-Atlantic/followers","following_url":"https://api.github.com/users/CAS-Atlantic/following{/other_user}","gists_url":"https://api.github.com/users/CAS-Atlantic/gists{/gist_id}","starred_url":"https://api.github.com/users/CAS-Atlantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CAS-Atlantic/subscriptions","organizations_url":"https://api.github.com/users/CAS-Atlantic/orgs","repos_url":"https://api.github.com/users/CAS-Atlantic/repos","events_url":"https://api.github.com/users/CAS-Atlantic/events{/privacy}","received_events_url":"https://api.github.com/users/CAS-Atlantic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CAS-Atlantic/omr","description":"Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes","fork":true,"url":"https://api.github.com/repos/CAS-Atlantic/omr","forks_url":"https://api.github.com/repos/CAS-Atlantic/omr/forks","keys_url":"https://api.github.com/repos/CAS-Atlantic/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CAS-Atlantic/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CAS-Atlantic/omr/teams","hooks_url":"https://api.github.com/repos/CAS-Atlantic/omr/hooks","issue_events_url":"https://api.github.com/repos/CAS-Atlantic/omr/issues/events{/number}","events_url":"https://api.github.com/repos/CAS-Atlantic/omr/events","assignees_url":"https://api.github.com/repos/CAS-Atlantic/omr/assignees{/user}","branches_url":"https://api.github.com/repos/CAS-Atlantic/omr/branches{/branch}","tags_url":"https://api.github.com/repos/CAS-Atlantic/omr/tags","blobs_url":"https://api.github.com/repos/CAS-Atlantic/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CAS-Atlantic/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CAS-Atlantic/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/CAS-Atlantic/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CAS-Atlantic/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/CAS-Atlantic/omr/languages","stargazers_url":"https://api.github.com/repos/CAS-Atlantic/omr/stargazers","contributors_url":"https://api.github.com/repos/CAS-Atlantic/omr/contributors","subscribers_url":"https://api.github.com/repos/CAS-Atlantic/omr/subscribers","subscription_url":"https://api.github.com/repos/CAS-Atlantic/omr/subscription","commits_url":"https://api.github.com/repos/CAS-Atlantic/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/CAS-Atlantic/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/CAS-Atlantic/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/CAS-Atlantic/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/CAS-Atlantic/omr/contents/{+path}","compare_url":"https://api.github.com/repos/CAS-Atlantic/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CAS-Atlantic/omr/merges","archive_url":"https://api.github.com/repos/CAS-Atlantic/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CAS-Atlantic/omr/downloads","issues_url":"https://api.github.com/repos/CAS-Atlantic/omr/issues{/number}","pulls_url":"https://api.github.com/repos/CAS-Atlantic/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/CAS-Atlantic/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/CAS-Atlantic/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CAS-Atlantic/omr/labels{/name}","releases_url":"https://api.github.com/repos/CAS-Atlantic/omr/releases{/id}","deployments_url":"https://api.github.com/repos/CAS-Atlantic/omr/deployments","created_at":"2018-04-16T18:48:01Z","updated_at":"2018-05-09T17:31:17Z","pushed_at":"2018-05-10T18:08:53Z","git_url":"git://github.com/CAS-Atlantic/omr.git","ssh_url":"git@github.com:CAS-Atlantic/omr.git","clone_url":"https://github.com/CAS-Atlantic/omr.git","svn_url":"https://github.com/CAS-Atlantic/omr","homepage":"http://www.eclipse.org/omr","size":24226,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"996c8e1ec72e7215f58216cb94806ef75ccb04c6","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":53077478,"name":"omr","full_name":"eclipse/omr","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/omr","description":"Eclipse OMR™ Cross platform components for building reliable, high performance language runtimes","fork":false,"url":"https://api.github.com/repos/eclipse/omr","forks_url":"https://api.github.com/repos/eclipse/omr/forks","keys_url":"https://api.github.com/repos/eclipse/omr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/omr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/omr/teams","hooks_url":"https://api.github.com/repos/eclipse/omr/hooks","issue_events_url":"https://api.github.com/repos/eclipse/omr/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/omr/events","assignees_url":"https://api.github.com/repos/eclipse/omr/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/omr/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/omr/tags","blobs_url":"https://api.github.com/repos/eclipse/omr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/omr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/omr/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/omr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/omr/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/omr/languages","stargazers_url":"https://api.github.com/repos/eclipse/omr/stargazers","contributors_url":"https://api.github.com/repos/eclipse/omr/contributors","subscribers_url":"https://api.github.com/repos/eclipse/omr/subscribers","subscription_url":"https://api.github.com/repos/eclipse/omr/subscription","commits_url":"https://api.github.com/repos/eclipse/omr/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/omr/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/omr/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/omr/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/omr/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/omr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/omr/merges","archive_url":"https://api.github.com/repos/eclipse/omr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/omr/downloads","issues_url":"https://api.github.com/repos/eclipse/omr/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/omr/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/omr/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/omr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/omr/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/omr/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/omr/deployments","created_at":"2016-03-03T19:34:17Z","updated_at":"2018-05-09T17:30:28Z","pushed_at":"2018-05-10T18:08:55Z","git_url":"git://github.com/eclipse/omr.git","ssh_url":"git@github.com:eclipse/omr.git","clone_url":"https://github.com/eclipse/omr.git","svn_url":"https://github.com/eclipse/omr","homepage":"http://www.eclipse.org/omr","size":24016,"stargazers_count":481,"watchers_count":481,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":214,"mirror_url":null,"archived":false,"open_issues_count":437,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":214,"open_issues":437,"watchers":481,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2520"},"html":{"href":"https://github.com/eclipse/omr/pull/2520"},"issue":{"href":"https://api.github.com/repos/eclipse/omr/issues/2520"},"comments":{"href":"https://api.github.com/repos/eclipse/omr/issues/2520/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2520/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/omr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/omr/pulls/2520/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/omr/statuses/9af3661a6b0ad677620e0096c7d617c0ccf3d998"}},"author_association":"NONE"}}
{"actor":{"display_login":"jeanlego"}}