{"action":"created","comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/pulls/comments/231408176","pull_request_review_id":172371058,"id":231408176,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTQwODE3Ng==","diff_hunk":"@@ -153,7 +153,11 @@\n % Configure the LDAP authentication plugin\n   {rabbitmq_auth_backend_ldap, [\n     {other_bind, <%= @ldap_other_bind %>},\n+<% if @ldap_server.class == Array or @ldap_server =~ /^\\[/  -%>","path":"templates/rabbitmq.config.erb","position":4,"original_position":4,"commit_id":"9d18fe8a81efe43b5599c6aec10331faff9def54","original_commit_id":"1f9fe2a7a367e24d11d532eab831e9e95b7ae331","user":{"login":"vStone","id":356719,"node_id":"MDQ6VXNlcjM1NjcxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/356719?v=4","gravatar_id":"","url":"https://api.github.com/users/vStone","html_url":"https://github.com/vStone","followers_url":"https://api.github.com/users/vStone/followers","following_url":"https://api.github.com/users/vStone/following{/other_user}","gists_url":"https://api.github.com/users/vStone/gists{/gist_id}","starred_url":"https://api.github.com/users/vStone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vStone/subscriptions","organizations_url":"https://api.github.com/users/vStone/orgs","repos_url":"https://api.github.com/users/vStone/repos","events_url":"https://api.github.com/users/vStone/events{/privacy}","received_events_url":"https://api.github.com/users/vStone/received_events","type":"User","site_admin":false},"body":"I use `[@ldap_servers].flatten` quite a lot to support both string and array[string]\r\n","created_at":"2018-11-07T07:58:19Z","updated_at":"2018-11-07T07:58:19Z","html_url":"https://github.com/voxpupuli/puppet-rabbitmq/pull/679#discussion_r231408176","pull_request_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/pulls/679","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/pulls/comments/231408176"},"html":{"href":"https://github.com/voxpupuli/puppet-rabbitmq/pull/679#discussion_r231408176"},"pull_request":{"href":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/pulls/679"}},"in_reply_to_id":166829892},"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/pulls/679","id":167748133,"node_id":"MDExOlB1bGxSZXF1ZXN0MTY3NzQ4MTMz","html_url":"https://github.com/voxpupuli/puppet-rabbitmq/pull/679","diff_url":"https://github.com/voxpupuli/puppet-rabbitmq/pull/679.diff","patch_url":"https://github.com/voxpupuli/puppet-rabbitmq/pull/679.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/issues/679","number":679,"state":"open","locked":false,"title":"Add support for multiple LDAP servers","user":{"login":"skrussell","id":22320649,"node_id":"MDQ6VXNlcjIyMzIwNjQ5","avatar_url":"https://avatars2.githubusercontent.com/u/22320649?v=4","gravatar_id":"","url":"https://api.github.com/users/skrussell","html_url":"https://github.com/skrussell","followers_url":"https://api.github.com/users/skrussell/followers","following_url":"https://api.github.com/users/skrussell/following{/other_user}","gists_url":"https://api.github.com/users/skrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/skrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skrussell/subscriptions","organizations_url":"https://api.github.com/users/skrussell/orgs","repos_url":"https://api.github.com/users/skrussell/repos","events_url":"https://api.github.com/users/skrussell/events{/privacy}","received_events_url":"https://api.github.com/users/skrussell/received_events","type":"User","site_admin":false},"body":"The RabbitMQ LDAP plug-in supports multiple servers being listed in the the \"servers\" field, but the puppet module currently only accepts a single String value.\r\n\r\nMy simple pull request allows an array of servers to be passed, which is then correctly formatted in the rabbitmq.confg template. I additionally attempt to detect an array that has already been flattened to a string, as happens if you configure the ldap_servers variable from hiera by way of sourcing an array variable that is already defined else where in puppet (rabbitmq::ldap_server: \"%{ldap::servers}\").\r\n\r\nTested and working with a string, an array, and a array flattened to a string.","created_at":"2018-02-07T16:50:06Z","updated_at":"2018-11-07T07:58:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54751aa6d8cec0eb5fc9da8863311f290ec5a467","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alexjfisher","id":146471,"node_id":"MDQ6VXNlcjE0NjQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/146471?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjfisher","html_url":"https://github.com/alexjfisher","followers_url":"https://api.github.com/users/alexjfisher/followers","following_url":"https://api.github.com/users/alexjfisher/following{/other_user}","gists_url":"https://api.github.com/users/alexjfisher/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjfisher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjfisher/subscriptions","organizations_url":"https://api.github.com/users/alexjfisher/orgs","repos_url":"https://api.github.com/users/alexjfisher/repos","events_url":"https://api.github.com/users/alexjfisher/events{/privacy}","received_events_url":"https://api.github.com/users/alexjfisher/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":50010747,"node_id":"MDU6TGFiZWw1MDAxMDc0Nw==","url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/labels/enhancement","name":"enhancement","color":"0052cc","default":true},{"id":50010757,"node_id":"MDU6TGFiZWw1MDAxMDc1Nw==","url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/labels/needs-rebase","name":"needs-rebase","color":"207de5","default":false},{"id":50010758,"node_id":"MDU6TGFiZWw1MDAxMDc1OA==","url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/labels/needs-tests","name":"needs-tests","color":"f7c6c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/pulls/679/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/pulls/679/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/issues/679/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/statuses/9d18fe8a81efe43b5599c6aec10331faff9def54","head":{"label":"skrussell:master","ref":"master","sha":"9d18fe8a81efe43b5599c6aec10331faff9def54","user":{"login":"skrussell","id":22320649,"node_id":"MDQ6VXNlcjIyMzIwNjQ5","avatar_url":"https://avatars2.githubusercontent.com/u/22320649?v=4","gravatar_id":"","url":"https://api.github.com/users/skrussell","html_url":"https://github.com/skrussell","followers_url":"https://api.github.com/users/skrussell/followers","following_url":"https://api.github.com/users/skrussell/following{/other_user}","gists_url":"https://api.github.com/users/skrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/skrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skrussell/subscriptions","organizations_url":"https://api.github.com/users/skrussell/orgs","repos_url":"https://api.github.com/users/skrussell/repos","events_url":"https://api.github.com/users/skrussell/events{/privacy}","received_events_url":"https://api.github.com/users/skrussell/received_events","type":"User","site_admin":false},"repo":{"id":120631925,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA2MzE5MjU=","name":"puppet-rabbitmq","full_name":"skrussell/puppet-rabbitmq","private":false,"owner":{"login":"skrussell","id":22320649,"node_id":"MDQ6VXNlcjIyMzIwNjQ5","avatar_url":"https://avatars2.githubusercontent.com/u/22320649?v=4","gravatar_id":"","url":"https://api.github.com/users/skrussell","html_url":"https://github.com/skrussell","followers_url":"https://api.github.com/users/skrussell/followers","following_url":"https://api.github.com/users/skrussell/following{/other_user}","gists_url":"https://api.github.com/users/skrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/skrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skrussell/subscriptions","organizations_url":"https://api.github.com/users/skrussell/orgs","repos_url":"https://api.github.com/users/skrussell/repos","events_url":"https://api.github.com/users/skrussell/events{/privacy}","received_events_url":"https://api.github.com/users/skrussell/received_events","type":"User","site_admin":false},"html_url":"https://github.com/skrussell/puppet-rabbitmq","description":"RabbitMQ Puppet Module","fork":true,"url":"https://api.github.com/repos/skrussell/puppet-rabbitmq","forks_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/forks","keys_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/teams","hooks_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/hooks","issue_events_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/issues/events{/number}","events_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/events","assignees_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/assignees{/user}","branches_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/branches{/branch}","tags_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/tags","blobs_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/statuses/{sha}","languages_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/languages","stargazers_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/stargazers","contributors_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/contributors","subscribers_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/subscribers","subscription_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/subscription","commits_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/contents/{+path}","compare_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/merges","archive_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/downloads","issues_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/issues{/number}","pulls_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/pulls{/number}","milestones_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/milestones{/number}","notifications_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/labels{/name}","releases_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/releases{/id}","deployments_url":"https://api.github.com/repos/skrussell/puppet-rabbitmq/deployments","created_at":"2018-02-07T15:20:20Z","updated_at":"2018-05-08T13:52:28Z","pushed_at":"2018-05-08T13:52:23Z","git_url":"git://github.com/skrussell/puppet-rabbitmq.git","ssh_url":"git@github.com:skrussell/puppet-rabbitmq.git","clone_url":"https://github.com/skrussell/puppet-rabbitmq.git","svn_url":"https://github.com/skrussell/puppet-rabbitmq","homepage":"http://forge.puppetlabs.com/puppetlabs/rabbitmq","size":1625,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"0ada399b330fbc84a1a1179ad0e827e0735e1912","user":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":1513777,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEzNzc3","name":"puppet-rabbitmq","full_name":"voxpupuli/puppet-rabbitmq","private":false,"owner":{"login":"voxpupuli","id":8693967,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTM5Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/voxpupuli/puppet-rabbitmq","description":"RabbitMQ Puppet Module","fork":false,"url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq","forks_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/deployments","created_at":"2011-03-22T22:47:13Z","updated_at":"2018-10-26T13:43:10Z","pushed_at":"2018-11-07T07:53:18Z","git_url":"git://github.com/voxpupuli/puppet-rabbitmq.git","ssh_url":"git@github.com:voxpupuli/puppet-rabbitmq.git","clone_url":"https://github.com/voxpupuli/puppet-rabbitmq.git","svn_url":"https://github.com/voxpupuli/puppet-rabbitmq","homepage":"http://forge.puppetlabs.com/puppetlabs/rabbitmq","size":1707,"stargazers_count":165,"watchers_count":165,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":481,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":481,"open_issues":17,"watchers":165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/pulls/679"},"html":{"href":"https://github.com/voxpupuli/puppet-rabbitmq/pull/679"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/issues/679"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/issues/679/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/pulls/679/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/pulls/679/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-rabbitmq/statuses/9d18fe8a81efe43b5599c6aec10331faff9def54"}},"author_association":"NONE"}}
{"actor":{"display_login":"vStone"}}