{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24854","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24854/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24854/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24854/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24854","id":312660662,"number":24854,"title":"[estree] make function declaration id nullable","user":{"login":"stas-vilchik","id":2317341,"avatar_url":"https://avatars0.githubusercontent.com/u/2317341?v=4","gravatar_id":"","url":"https://api.github.com/users/stas-vilchik","html_url":"https://github.com/stas-vilchik","followers_url":"https://api.github.com/users/stas-vilchik/followers","following_url":"https://api.github.com/users/stas-vilchik/following{/other_user}","gists_url":"https://api.github.com/users/stas-vilchik/gists{/gist_id}","starred_url":"https://api.github.com/users/stas-vilchik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stas-vilchik/subscriptions","organizations_url":"https://api.github.com/users/stas-vilchik/orgs","repos_url":"https://api.github.com/users/stas-vilchik/repos","events_url":"https://api.github.com/users/stas-vilchik/events{/privacy}","received_events_url":"https://api.github.com/users/stas-vilchik/received_events","type":"User","site_admin":false},"labels":[{"id":397523192,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false},{"id":644095882,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Merge:YSYL","name":"Merge:YSYL","color":"bfdadc","default":false},{"id":684321576,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Popular%20package","name":"Popular package","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-04-09T19:41:55Z","updated_at":"2018-04-17T17:01:43Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/24854","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24854","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24854.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24854.patch"},"body":"A `FunctionDeclaration` `id` can be `null` if this function declaration is a part of the `ExportDefaultDeclaration` ([ast explorer gist](https://astexplorer.net/#/gist/bcb2d30873c46351a69473ad91a9cadd/2ccd96c9b4202b442c6f7fae52acc14cd5fca756)):\r\n\r\n```javascript\r\nexport default function() {}\r\n```\r\n\r\nThis PR updates the `FunctionDeclaration` interface."},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/382067969","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/24854#issuecomment-382067969","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/24854","id":382067969,"user":{"login":"RyanCavanaugh","id":6685088,"avatar_url":"https://avatars3.githubusercontent.com/u/6685088?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanCavanaugh","html_url":"https://github.com/RyanCavanaugh","followers_url":"https://api.github.com/users/RyanCavanaugh/followers","following_url":"https://api.github.com/users/RyanCavanaugh/following{/other_user}","gists_url":"https://api.github.com/users/RyanCavanaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanCavanaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanCavanaugh/subscriptions","organizations_url":"https://api.github.com/users/RyanCavanaugh/orgs","repos_url":"https://api.github.com/users/RyanCavanaugh/repos","events_url":"https://api.github.com/users/RyanCavanaugh/events{/privacy}","received_events_url":"https://api.github.com/users/RyanCavanaugh/received_events","type":"User","site_admin":false},"created_at":"2018-04-17T17:01:43Z","updated_at":"2018-04-17T17:01:43Z","author_association":"MEMBER","body":"The TypeScript syntax tree suffers the same problem and it's a big source of bugs.\r\n\r\nI think the fix as-is is honestly the right one - attempting to split out the tree differently doesn't really work because it's really a matrix (export, default, named, async, etc) rather than a directable graph.\r\n\r\n@RReverser without a concrete better PR I think this one should be merged. Any objections?"}}
{"actor":{"display_login":"RyanCavanaugh"}}