{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/EIPs/issues/841","repository_url":"https://api.github.com/repos/ethereum/EIPs","labels_url":"https://api.github.com/repos/ethereum/EIPs/issues/841/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/EIPs/issues/841/comments","events_url":"https://api.github.com/repos/ethereum/EIPs/issues/841/events","html_url":"https://github.com/ethereum/EIPs/pull/841","id":291094467,"number":841,"title":"EIP-721 Non-Fungible Token Standard","user":{"login":"fulldecent","id":382183,"avatar_url":"https://avatars0.githubusercontent.com/u/382183?v=4","gravatar_id":"","url":"https://api.github.com/users/fulldecent","html_url":"https://github.com/fulldecent","followers_url":"https://api.github.com/users/fulldecent/followers","following_url":"https://api.github.com/users/fulldecent/following{/other_user}","gists_url":"https://api.github.com/users/fulldecent/gists{/gist_id}","starred_url":"https://api.github.com/users/fulldecent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fulldecent/subscriptions","organizations_url":"https://api.github.com/users/fulldecent/orgs","repos_url":"https://api.github.com/users/fulldecent/repos","events_url":"https://api.github.com/users/fulldecent/events{/privacy}","received_events_url":"https://api.github.com/users/fulldecent/received_events","type":"User","site_admin":false},"labels":[{"id":290507092,"url":"https://api.github.com/repos/ethereum/EIPs/labels/ERC","name":"ERC","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":184,"created_at":"2018-01-24T06:06:53Z","updated_at":"2018-03-06T20:47:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ethereum/EIPs/pulls/841","html_url":"https://github.com/ethereum/EIPs/pull/841","diff_url":"https://github.com/ethereum/EIPs/pull/841.diff","patch_url":"https://github.com/ethereum/EIPs/pull/841.patch"},"body":"# TO DO:\r\n\r\n- [x] Write rationale section\r\n- [x] Finalize `ERC721Metadata` interface\r\n- [x] Finalize `ERC165` compliance\r\n- [x] Reconsider the \"deed\" word choice -- https://github.com/fulldecent/EIPs/pull/2\r\n- [x] Demonstrate sufficient consensus for standardization\r\n- [x] Launch [bug bounty program](https://github.com/fulldecent/su-squares-bounty/blob/master/README.md) **BOUNTY ENDS 2018-03-04**\r\n- [ ] Review which event parameters are indexed (read http://solidity.readthedocs.io/en/develop/contracts.html#events)\r\n- [ ] Get implementation into OpenZeppelin\r\n- [ ] Write test cases / Truffle\r\n- [ ] **Submit to EIP reviewer for DRAFT ACCEPTED status** // target date 2018-02-28\r\n- [ ] Post on Reddit, wider forum promote adoption\r\n- [x] Requires ERC-165 (currently in DRAFT ACCEPTED status)\r\n- [ ] **Get to DRAFT APPROVED status**\r\n\r\n----\r\n\r\n# How to discuss\r\n\r\nIf you... | Then...\r\n-- | --\r\nHave general thoughts/questions on NFT/deed/DAR standardization | Visit https://github.com/ethereum/eips/issues/721 and leave a comment\r\nReviewed this pull request and have implementation feedback or can help improve the wording in the standard | Comment here, scroll down ⬇\r\n\r\nAlso see discussion at https://gitter.im/ETH-NFT/Lobby\r\n\r\n* Please introduce yourself 😃\r\n* If you express an opinion, are you speaking individually or do you represent an organization?\r\n* If you provide feedback, what level of review you have performed (creative thinking/test code/deployed contract)?\r\n\r\n---\r\n\r\n# What is this?\r\n\r\n**This pull request is the [ERC-721](https://github.com/ethereum/eips/issues/721) standardization document.** \r\n\r\nThis PR is represents the contributions of dozens of people imagining a future where smart contracts will manage ownership of important things in the real world and online. Thanks for your help and support! \r\n\r\n**Please react with party emoji 🎉  if you believe this EIP should be accepted. Acceptance is NOT final.  The significance of acceptance is detailed in [EIP-1](https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1.md#what-belongs-in-a-successful-eip):**\r\n\r\n> If the EIP collaborators approve, the EIP editor will assign the EIP a number (generally the issue or PR number related to the EIP), label it as Standards Track, Informational, or Meta, give it status “Draft”, and add it to the git repository.\r\n\r\nWhen this is accepted, then we can begin the work of writing test cases and implementations. We can still discuss and change things. Another benefit is that it gets listed on the EIP homepage, this increases the audience of this EIP and will get more people involved and scrutinizing this standard.\r\n\r\n**You are the collaborators.** "},"comment":{"url":"https://api.github.com/repos/ethereum/EIPs/issues/comments/370922589","html_url":"https://github.com/ethereum/EIPs/pull/841#issuecomment-370922589","issue_url":"https://api.github.com/repos/ethereum/EIPs/issues/841","id":370922589,"user":{"login":"spalladino","id":429604,"avatar_url":"https://avatars2.githubusercontent.com/u/429604?v=4","gravatar_id":"","url":"https://api.github.com/users/spalladino","html_url":"https://github.com/spalladino","followers_url":"https://api.github.com/users/spalladino/followers","following_url":"https://api.github.com/users/spalladino/following{/other_user}","gists_url":"https://api.github.com/users/spalladino/gists{/gist_id}","starred_url":"https://api.github.com/users/spalladino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spalladino/subscriptions","organizations_url":"https://api.github.com/users/spalladino/orgs","repos_url":"https://api.github.com/users/spalladino/repos","events_url":"https://api.github.com/users/spalladino/events{/privacy}","received_events_url":"https://api.github.com/users/spalladino/received_events","type":"User","site_admin":false},"created_at":"2018-03-06T20:47:39Z","updated_at":"2018-03-06T20:47:39Z","author_association":"NONE","body":"@fulldecent there's something we wanted to review on one of the methods, and I'm not sure if it's been already discussed. We are looking at `getApproved(uint256 _tokenId) public returns (address)`, which only makes sense because in the ERC721 context there can be only one address approved for an individual token. \r\n\r\nHow about using a similar approach to ERC20, and support querying on whether a specific address can manage a token or not? Would be similar to [Decentraland's isAuthorized](https://github.com/decentraland/erc821/blob/master/contracts/ERC721Base.sol#L87-L96), and return whether the address has been individually approved for the asset, or is the owner, or is an operator.\r\n\r\nIn other words, how about removing `getApproved(uint256 _tokenId) public returns (address)`, in favour of:\r\n```\r\nisApproved(address operator, uint256 assetId) public view returns (bool)\r\n```\r\n\r\nOn the other hand, I understand that it could be confusing whether this method returns true for an address not individually approved, but who is an operator of the owner of the token. \r\n\r\nWDYT?"}}
{"actor":{"display_login":"spalladino"}}