{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-context-menu/issues/158","repository_url":"https://api.github.com/repos/vaadin/vaadin-context-menu","labels_url":"https://api.github.com/repos/vaadin/vaadin-context-menu/issues/158/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-context-menu/issues/158/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-context-menu/issues/158/events","html_url":"https://github.com/vaadin/vaadin-context-menu/pull/158","id":323266401,"number":158,"title":"Fix overlay position","user":{"login":"manolo","id":161853,"avatar_url":"https://avatars1.githubusercontent.com/u/161853?v=4","gravatar_id":"","url":"https://api.github.com/users/manolo","html_url":"https://github.com/manolo","followers_url":"https://api.github.com/users/manolo/followers","following_url":"https://api.github.com/users/manolo/following{/other_user}","gists_url":"https://api.github.com/users/manolo/gists{/gist_id}","starred_url":"https://api.github.com/users/manolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manolo/subscriptions","organizations_url":"https://api.github.com/users/manolo/orgs","repos_url":"https://api.github.com/users/manolo/repos","events_url":"https://api.github.com/users/manolo/events{/privacy}","received_events_url":"https://api.github.com/users/manolo/received_events","type":"User","site_admin":false},"labels":[{"id":440953006,"url":"https://api.github.com/repos/vaadin/vaadin-context-menu/labels/in%20review","name":"in review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-05-15T15:21:15Z","updated_at":"2018-05-18T20:15:20Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-context-menu/pulls/158","html_url":"https://github.com/vaadin/vaadin-context-menu/pull/158","diff_url":"https://github.com/vaadin/vaadin-context-menu/pull/158.diff","patch_url":"https://github.com/vaadin/vaadin-context-menu/pull/158.patch"},"body":"Fixes #115\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-context-menu/158)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-context-menu/issues/comments/390320072","html_url":"https://github.com/vaadin/vaadin-context-menu/pull/158#issuecomment-390320072","issue_url":"https://api.github.com/repos/vaadin/vaadin-context-menu/issues/158","id":390320072,"user":{"login":"manolo","id":161853,"avatar_url":"https://avatars1.githubusercontent.com/u/161853?v=4","gravatar_id":"","url":"https://api.github.com/users/manolo","html_url":"https://github.com/manolo","followers_url":"https://api.github.com/users/manolo/followers","following_url":"https://api.github.com/users/manolo/following{/other_user}","gists_url":"https://api.github.com/users/manolo/gists{/gist_id}","starred_url":"https://api.github.com/users/manolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manolo/subscriptions","organizations_url":"https://api.github.com/users/manolo/orgs","repos_url":"https://api.github.com/users/manolo/repos","events_url":"https://api.github.com/users/manolo/events{/privacy}","received_events_url":"https://api.github.com/users/manolo/received_events","type":"User","site_admin":false},"created_at":"2018-05-18T20:15:20Z","updated_at":"2018-05-18T20:15:20Z","author_association":"MEMBER","body":"\n\n\n\nReview status: 0 of 3 files reviewed at latest revision, 4 unresolved discussions, some commit checks broke.\n\n---\n\n*[src/vaadin-context-menu.html, line 447 at r2](https://reviewable.io/reviews/vaadin/vaadin-context-menu/158#-LCiLJ3V2vu0Aa_UBCKk:-LCopZyO0lkFb5OQayfj:b-896fix) ([raw file](https://github.com/vaadin/vaadin-context-menu/blob/06dffbf4205985edb9eb269c32cdcf7b35bae34d/src/vaadin-context-menu.html#L447)):*\n<details><summary><i>Previously, tomivirkki (Tomi Virkki) wrote…</i></summary><blockquote>\n\nUntested code\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/vaadin-context-menu.html, line 448 at r2](https://reviewable.io/reviews/vaadin/vaadin-context-menu/158#-LCiLL4t-HmghvSglLjk:-LCop__L4aE43GexQOOf:b-896fix) ([raw file](https://github.com/vaadin/vaadin-context-menu/blob/06dffbf4205985edb9eb269c32cdcf7b35bae34d/src/vaadin-context-menu.html#L448)):*\n<details><summary><i>Previously, tomivirkki (Tomi Virkki) wrote…</i></summary><blockquote>\n\nUntested code\n</blockquote></details>\n\nDone.\n\n---\n\n*[src/vaadin-context-menu.html, line 475 at r2](https://reviewable.io/reviews/vaadin/vaadin-context-menu/158#-LCiIxel1W3zkDYskNFx:-LCosVVJ1P0_LFT7OwnD:b-896fix) ([raw file](https://github.com/vaadin/vaadin-context-menu/blob/06dffbf4205985edb9eb269c32cdcf7b35bae34d/src/vaadin-context-menu.html#L475)):*\n<details><summary><i>Previously, tomivirkki (Tomi Virkki) wrote…</i></summary><blockquote>\n\nUntested code\n</blockquote></details>\n\nDone.\n\n---\n\n*[test/overlay.html, line 101 at r2](https://reviewable.io/reviews/vaadin/vaadin-context-menu/158#-LCiJ-hB5RJXZuDoVbFa:-LCosb7D45hv7X7Krbna:bdz0kud) ([raw file](https://github.com/vaadin/vaadin-context-menu/blob/06dffbf4205985edb9eb269c32cdcf7b35bae34d/test/overlay.html#L101)):*\n<details><summary><i>Previously, tomivirkki (Tomi Virkki) wrote…</i></summary><blockquote>\n\nThese test are testing the implementation (presence of some internal attribute) rather that the expected behaviour. If someone would accidentally remove the new styles added for \"right-aligned\" and \"bottom-aligned\", all the tests would still pass but the element would be broken. \n</blockquote></details>\n\nadded assertions in tests  to actually measure overlay position.  Done\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/vaadin/vaadin-context-menu/158)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"manolo"}}