{"action":"created","issue":{"url":"https://api.github.com/repos/weaveworks/scope/issues/3132","repository_url":"https://api.github.com/repos/weaveworks/scope","labels_url":"https://api.github.com/repos/weaveworks/scope/issues/3132/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/scope/issues/3132/comments","events_url":"https://api.github.com/repos/weaveworks/scope/issues/3132/events","html_url":"https://github.com/weaveworks/scope/pull/3132","id":311742936,"number":3132,"title":"Add pv and pvc support in weave scope","user":{"login":"satyamz","id":5508956,"avatar_url":"https://avatars0.githubusercontent.com/u/5508956?v=4","gravatar_id":"","url":"https://api.github.com/users/satyamz","html_url":"https://github.com/satyamz","followers_url":"https://api.github.com/users/satyamz/followers","following_url":"https://api.github.com/users/satyamz/following{/other_user}","gists_url":"https://api.github.com/users/satyamz/gists{/gist_id}","starred_url":"https://api.github.com/users/satyamz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satyamz/subscriptions","organizations_url":"https://api.github.com/users/satyamz/orgs","repos_url":"https://api.github.com/users/satyamz/repos","events_url":"https://api.github.com/users/satyamz/events{/privacy}","received_events_url":"https://api.github.com/users/satyamz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-04-05T19:39:57Z","updated_at":"2018-05-21T17:06:10Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/weaveworks/scope/pulls/3132","html_url":"https://github.com/weaveworks/scope/pull/3132","diff_url":"https://github.com/weaveworks/scope/pull/3132.diff","patch_url":"https://github.com/weaveworks/scope/pull/3132.patch"},"body":"As a part of this, a new sub-topology called `Persistent Volumes` which contain the graph of `Persistent Volume` and `Persistent Volume Claim`. \r\nEdges are drawn on the basis of Volume Claim Name in PV and PVC.\r\n\r\nFixes: #3130 \r\n\r\n![pv-pvc-support](https://user-images.githubusercontent.com/5508956/38387889-1beba2ec-3937-11e8-82c7-7c60650ce4ac.png)\r\n"},"comment":{"url":"https://api.github.com/repos/weaveworks/scope/issues/comments/390718048","html_url":"https://github.com/weaveworks/scope/pull/3132#issuecomment-390718048","issue_url":"https://api.github.com/repos/weaveworks/scope/issues/3132","id":390718048,"user":{"login":"bboreham","id":8125524,"avatar_url":"https://avatars2.githubusercontent.com/u/8125524?v=4","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"created_at":"2018-05-21T17:06:10Z","updated_at":"2018-05-21T17:06:10Z","author_association":"MEMBER","body":"@satyamz apologies I have been away from this for some time.  I finally got my own version to work - see https://github.com/weaveworks/scope/compare/master...k8s-volumes\r\n\r\nIt uses lots of code from this PR, but the key thing I wanted to show is that it has virtually no changes on the rendering side.  No new methods on `joinResult` and none of the code you used to feed things into it.  I simply create the adjacency I want in the probe.  I don't include `probeID` in the storage node; can't see any need for it.\r\n\r\nI left in that branch a previous commit where the information goes via the `parent` field; this seemed plausible but in the end unnecessary.\r\n\r\nWhat I suggest is you look at my branch, then simplify this PR based on those ideas.  I left out all your tests, also the most recent changes, because all I wanted to do was understand the rendering/adjacency side."}}
{"actor":{"display_login":"bboreham"}}