{"action":"created","comment":{"url":"https://api.github.com/repos/paritytech/pwasm-ethereum/pulls/comments/231840092","pull_request_review_id":172897737,"id":231840092,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTg0MDA5Mg==","diff_hunk":"@@ -130,9 +133,14 @@ pub fn balance(address: &Address) -> U256 {\n pub fn create(endowment: U256, code: &[u8]) -> Result<Address, Error> {\n \tlet mut endowment_arr = [0u8; 32];\n \tendowment.to_big_endian(&mut endowment_arr);\n-\tlet mut result = Address::new();\n+\tlet mut result = Address::from(H160::zero());\n \tunsafe {\n-\t\tif external::create(endowment_arr.as_ptr(), code.as_ptr(), code.len() as u32, (&mut result).as_mut_ptr()) == 0 {\n+\t\tif external::create(","path":"src/ext.rs","position":44,"original_position":23,"commit_id":"e9e1314f765a0f37c839c36a01e7d0a11b446c95","original_commit_id":"7b9e9477f6cfa2f07a8447f16296250a54684852","user":{"login":"Robbepop","id":8193155,"node_id":"MDQ6VXNlcjgxOTMxNTU=","avatar_url":"https://avatars3.githubusercontent.com/u/8193155?v=4","gravatar_id":"","url":"https://api.github.com/users/Robbepop","html_url":"https://github.com/Robbepop","followers_url":"https://api.github.com/users/Robbepop/followers","following_url":"https://api.github.com/users/Robbepop/following{/other_user}","gists_url":"https://api.github.com/users/Robbepop/gists{/gist_id}","starred_url":"https://api.github.com/users/Robbepop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robbepop/subscriptions","organizations_url":"https://api.github.com/users/Robbepop/orgs","repos_url":"https://api.github.com/users/Robbepop/repos","events_url":"https://api.github.com/users/Robbepop/events{/privacy}","received_events_url":"https://api.github.com/users/Robbepop/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-11-08T10:45:44Z","updated_at":"2018-11-08T10:45:44Z","html_url":"https://github.com/paritytech/pwasm-ethereum/pull/16#discussion_r231840092","pull_request_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/pulls/16","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/paritytech/pwasm-ethereum/pulls/comments/231840092"},"html":{"href":"https://github.com/paritytech/pwasm-ethereum/pull/16#discussion_r231840092"},"pull_request":{"href":"https://api.github.com/repos/paritytech/pwasm-ethereum/pulls/16"}},"in_reply_to_id":231819110},"pull_request":{"url":"https://api.github.com/repos/paritytech/pwasm-ethereum/pulls/16","id":229103183,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MTAzMTgz","html_url":"https://github.com/paritytech/pwasm-ethereum/pull/16","diff_url":"https://github.com/paritytech/pwasm-ethereum/pull/16.diff","patch_url":"https://github.com/paritytech/pwasm-ethereum/pull/16.patch","issue_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/issues/16","number":16,"state":"open","locked":false,"title":"Update to pwasm-std 0.11","user":{"login":"Robbepop","id":8193155,"node_id":"MDQ6VXNlcjgxOTMxNTU=","avatar_url":"https://avatars3.githubusercontent.com/u/8193155?v=4","gravatar_id":"","url":"https://api.github.com/users/Robbepop","html_url":"https://github.com/Robbepop","followers_url":"https://api.github.com/users/Robbepop/followers","following_url":"https://api.github.com/users/Robbepop/following{/other_user}","gists_url":"https://api.github.com/users/Robbepop/gists{/gist_id}","starred_url":"https://api.github.com/users/Robbepop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robbepop/subscriptions","organizations_url":"https://api.github.com/users/Robbepop/orgs","repos_url":"https://api.github.com/users/Robbepop/repos","events_url":"https://api.github.com/users/Robbepop/events{/privacy}","received_events_url":"https://api.github.com/users/Robbepop/received_events","type":"User","site_admin":false},"body":"Updates the crate to `pwasm-std` version `0.11`.\r\nThis has the effect that the `uint` and `parity-hash` dependencies can be removed entirely.\r\n\r\nShould make a version `0.7` release after this.\r\nUsed by `pwasm-abi` in the tests, so this is a blocker until merged (or until I release another version of it.)","created_at":"2018-11-07T17:10:41Z","updated_at":"2018-11-08T10:45:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1670bf72f6e3b3ba7f5e2f3377237ac7e4d5dd7b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fckt","id":547167,"node_id":"MDQ6VXNlcjU0NzE2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/547167?v=4","gravatar_id":"","url":"https://api.github.com/users/fckt","html_url":"https://github.com/fckt","followers_url":"https://api.github.com/users/fckt/followers","following_url":"https://api.github.com/users/fckt/following{/other_user}","gists_url":"https://api.github.com/users/fckt/gists{/gist_id}","starred_url":"https://api.github.com/users/fckt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fckt/subscriptions","organizations_url":"https://api.github.com/users/fckt/orgs","repos_url":"https://api.github.com/users/fckt/repos","events_url":"https://api.github.com/users/fckt/events{/privacy}","received_events_url":"https://api.github.com/users/fckt/received_events","type":"User","site_admin":false},{"login":"NikVolf","id":3186518,"node_id":"MDQ6VXNlcjMxODY1MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/3186518?v=4","gravatar_id":"","url":"https://api.github.com/users/NikVolf","html_url":"https://github.com/NikVolf","followers_url":"https://api.github.com/users/NikVolf/followers","following_url":"https://api.github.com/users/NikVolf/following{/other_user}","gists_url":"https://api.github.com/users/NikVolf/gists{/gist_id}","starred_url":"https://api.github.com/users/NikVolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NikVolf/subscriptions","organizations_url":"https://api.github.com/users/NikVolf/orgs","repos_url":"https://api.github.com/users/NikVolf/repos","events_url":"https://api.github.com/users/NikVolf/events{/privacy}","received_events_url":"https://api.github.com/users/NikVolf/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/pulls/16/commits","review_comments_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/pulls/16/comments","review_comment_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/issues/16/comments","statuses_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/statuses/e9e1314f765a0f37c839c36a01e7d0a11b446c95","head":{"label":"Robbepop:update-to-pwasm-std-0_11","ref":"update-to-pwasm-std-0_11","sha":"e9e1314f765a0f37c839c36a01e7d0a11b446c95","user":{"login":"Robbepop","id":8193155,"node_id":"MDQ6VXNlcjgxOTMxNTU=","avatar_url":"https://avatars3.githubusercontent.com/u/8193155?v=4","gravatar_id":"","url":"https://api.github.com/users/Robbepop","html_url":"https://github.com/Robbepop","followers_url":"https://api.github.com/users/Robbepop/followers","following_url":"https://api.github.com/users/Robbepop/following{/other_user}","gists_url":"https://api.github.com/users/Robbepop/gists{/gist_id}","starred_url":"https://api.github.com/users/Robbepop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robbepop/subscriptions","organizations_url":"https://api.github.com/users/Robbepop/orgs","repos_url":"https://api.github.com/users/Robbepop/repos","events_url":"https://api.github.com/users/Robbepop/events{/privacy}","received_events_url":"https://api.github.com/users/Robbepop/received_events","type":"User","site_admin":false},"repo":{"id":151715961,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3MTU5NjE=","name":"pwasm-ethereum","full_name":"Robbepop/pwasm-ethereum","private":false,"owner":{"login":"Robbepop","id":8193155,"node_id":"MDQ6VXNlcjgxOTMxNTU=","avatar_url":"https://avatars3.githubusercontent.com/u/8193155?v=4","gravatar_id":"","url":"https://api.github.com/users/Robbepop","html_url":"https://github.com/Robbepop","followers_url":"https://api.github.com/users/Robbepop/followers","following_url":"https://api.github.com/users/Robbepop/following{/other_user}","gists_url":"https://api.github.com/users/Robbepop/gists{/gist_id}","starred_url":"https://api.github.com/users/Robbepop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Robbepop/subscriptions","organizations_url":"https://api.github.com/users/Robbepop/orgs","repos_url":"https://api.github.com/users/Robbepop/repos","events_url":"https://api.github.com/users/Robbepop/events{/privacy}","received_events_url":"https://api.github.com/users/Robbepop/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Robbepop/pwasm-ethereum","description":null,"fork":true,"url":"https://api.github.com/repos/Robbepop/pwasm-ethereum","forks_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/forks","keys_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/teams","hooks_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/hooks","issue_events_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/events","assignees_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/tags","blobs_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/languages","stargazers_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/stargazers","contributors_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/contributors","subscribers_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/subscribers","subscription_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/subscription","commits_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/merges","archive_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/downloads","issues_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/Robbepop/pwasm-ethereum/deployments","created_at":"2018-10-05T12:15:34Z","updated_at":"2018-10-05T12:19:22Z","pushed_at":"2018-11-08T10:45:12Z","git_url":"git://github.com/Robbepop/pwasm-ethereum.git","ssh_url":"git@github.com:Robbepop/pwasm-ethereum.git","clone_url":"https://github.com/Robbepop/pwasm-ethereum.git","svn_url":"https://github.com/Robbepop/pwasm-ethereum","homepage":null,"size":6066,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"paritytech:master","ref":"master","sha":"50fc1583cbefda569d3c517d42f20bd8a7b05da0","user":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"repo":{"id":113979341,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM5NzkzNDE=","name":"pwasm-ethereum","full_name":"paritytech/pwasm-ethereum","private":false,"owner":{"login":"paritytech","id":14176906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTc2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/14176906?v=4","gravatar_id":"","url":"https://api.github.com/users/paritytech","html_url":"https://github.com/paritytech","followers_url":"https://api.github.com/users/paritytech/followers","following_url":"https://api.github.com/users/paritytech/following{/other_user}","gists_url":"https://api.github.com/users/paritytech/gists{/gist_id}","starred_url":"https://api.github.com/users/paritytech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paritytech/subscriptions","organizations_url":"https://api.github.com/users/paritytech/orgs","repos_url":"https://api.github.com/users/paritytech/repos","events_url":"https://api.github.com/users/paritytech/events{/privacy}","received_events_url":"https://api.github.com/users/paritytech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/paritytech/pwasm-ethereum","description":null,"fork":false,"url":"https://api.github.com/repos/paritytech/pwasm-ethereum","forks_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/forks","keys_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/teams","hooks_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/hooks","issue_events_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/events","assignees_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/tags","blobs_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/languages","stargazers_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/stargazers","contributors_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/contributors","subscribers_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/subscribers","subscription_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/subscription","commits_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/merges","archive_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/downloads","issues_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/paritytech/pwasm-ethereum/deployments","created_at":"2017-12-12T10:58:15Z","updated_at":"2018-09-19T08:16:21Z","pushed_at":"2018-11-08T10:45:13Z","git_url":"git://github.com/paritytech/pwasm-ethereum.git","ssh_url":"git@github.com:paritytech/pwasm-ethereum.git","clone_url":"https://github.com/paritytech/pwasm-ethereum.git","svn_url":"https://github.com/paritytech/pwasm-ethereum","homepage":null,"size":6064,"stargazers_count":20,"watchers_count":20,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":1,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paritytech/pwasm-ethereum/pulls/16"},"html":{"href":"https://github.com/paritytech/pwasm-ethereum/pull/16"},"issue":{"href":"https://api.github.com/repos/paritytech/pwasm-ethereum/issues/16"},"comments":{"href":"https://api.github.com/repos/paritytech/pwasm-ethereum/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/paritytech/pwasm-ethereum/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/paritytech/pwasm-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paritytech/pwasm-ethereum/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/paritytech/pwasm-ethereum/statuses/e9e1314f765a0f37c839c36a01e7d0a11b446c95"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Robbepop"}}