{"action":"closed","number":1380,"pull_request":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/1380","id":209230439,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MjMwNDM5","html_url":"https://github.com/kubeflow/kubeflow/pull/1380","diff_url":"https://github.com/kubeflow/kubeflow/pull/1380.diff","patch_url":"https://github.com/kubeflow/kubeflow/pull/1380.patch","issue_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/1380","number":1380,"state":"closed","locked":false,"title":"Fix groups for various resources","user":{"login":"activatedgeek","id":3909933,"node_id":"MDQ6VXNlcjM5MDk5MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/3909933?v=4","gravatar_id":"","url":"https://api.github.com/users/activatedgeek","html_url":"https://github.com/activatedgeek","followers_url":"https://api.github.com/users/activatedgeek/followers","following_url":"https://api.github.com/users/activatedgeek/following{/other_user}","gists_url":"https://api.github.com/users/activatedgeek/gists{/gist_id}","starred_url":"https://api.github.com/users/activatedgeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activatedgeek/subscriptions","organizations_url":"https://api.github.com/users/activatedgeek/orgs","repos_url":"https://api.github.com/users/activatedgeek/repos","events_url":"https://api.github.com/users/activatedgeek/events{/privacy}","received_events_url":"https://api.github.com/users/activatedgeek/received_events","type":"User","site_admin":false},"body":"Role groups for a few resources were not correct.\r\n\r\n- `deployments` belongs to `apps` group (and also `extensions` for compatibility with older versions)\r\n- `jobs` belongs to `batch` group\r\n- Allow all resource verbs\r\n\r\n/cc @ankushagarwal\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/kubeflow/1380)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-08-17T18:55:17Z","updated_at":"2018-08-17T22:51:02Z","closed_at":"2018-08-17T22:51:02Z","merged_at":"2018-08-17T22:51:02Z","merge_commit_sha":"af0a2dc7a89f60dcfb80a8b807f02c7ea4fb71e0","assignee":{"login":"ankushagarwal","id":796949,"node_id":"MDQ6VXNlcjc5Njk0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/796949?v=4","gravatar_id":"","url":"https://api.github.com/users/ankushagarwal","html_url":"https://github.com/ankushagarwal","followers_url":"https://api.github.com/users/ankushagarwal/followers","following_url":"https://api.github.com/users/ankushagarwal/following{/other_user}","gists_url":"https://api.github.com/users/ankushagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ankushagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankushagarwal/subscriptions","organizations_url":"https://api.github.com/users/ankushagarwal/orgs","repos_url":"https://api.github.com/users/ankushagarwal/repos","events_url":"https://api.github.com/users/ankushagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ankushagarwal/received_events","type":"User","site_admin":false},"assignees":[{"login":"ankushagarwal","id":796949,"node_id":"MDQ6VXNlcjc5Njk0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/796949?v=4","gravatar_id":"","url":"https://api.github.com/users/ankushagarwal","html_url":"https://github.com/ankushagarwal","followers_url":"https://api.github.com/users/ankushagarwal/followers","following_url":"https://api.github.com/users/ankushagarwal/following{/other_user}","gists_url":"https://api.github.com/users/ankushagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ankushagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankushagarwal/subscriptions","organizations_url":"https://api.github.com/users/ankushagarwal/orgs","repos_url":"https://api.github.com/users/ankushagarwal/repos","events_url":"https://api.github.com/users/ankushagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ankushagarwal/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ankushagarwal","id":796949,"node_id":"MDQ6VXNlcjc5Njk0OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/796949?v=4","gravatar_id":"","url":"https://api.github.com/users/ankushagarwal","html_url":"https://github.com/ankushagarwal","followers_url":"https://api.github.com/users/ankushagarwal/followers","following_url":"https://api.github.com/users/ankushagarwal/following{/other_user}","gists_url":"https://api.github.com/users/ankushagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ankushagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankushagarwal/subscriptions","organizations_url":"https://api.github.com/users/ankushagarwal/orgs","repos_url":"https://api.github.com/users/ankushagarwal/repos","events_url":"https://api.github.com/users/ankushagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ankushagarwal/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":852268762,"node_id":"MDU6TGFiZWw4NTIyNjg3NjI=","url":"https://api.github.com/repos/kubeflow/kubeflow/labels/approved","name":"approved","color":"03db12","default":false},{"id":1016516455,"node_id":"MDU6TGFiZWwxMDE2NTE2NDU1","url":"https://api.github.com/repos/kubeflow/kubeflow/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false},{"id":842377274,"node_id":"MDU6TGFiZWw4NDIzNzcyNzQ=","url":"https://api.github.com/repos/kubeflow/kubeflow/labels/lgtm","name":"lgtm","color":"2efca4","default":false},{"id":796371353,"node_id":"MDU6TGFiZWw3OTYzNzEzNTM=","url":"https://api.github.com/repos/kubeflow/kubeflow/labels/size/M","name":"size/M","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/1380/commits","review_comments_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/1380/comments","review_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/1380/comments","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/e5189fecc37ebbac89fec420a09d70fed0f65854","head":{"label":"activatedgeek:fix-jupyter-role-groups","ref":"fix-jupyter-role-groups","sha":"e5189fecc37ebbac89fec420a09d70fed0f65854","user":{"login":"activatedgeek","id":3909933,"node_id":"MDQ6VXNlcjM5MDk5MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/3909933?v=4","gravatar_id":"","url":"https://api.github.com/users/activatedgeek","html_url":"https://github.com/activatedgeek","followers_url":"https://api.github.com/users/activatedgeek/followers","following_url":"https://api.github.com/users/activatedgeek/following{/other_user}","gists_url":"https://api.github.com/users/activatedgeek/gists{/gist_id}","starred_url":"https://api.github.com/users/activatedgeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activatedgeek/subscriptions","organizations_url":"https://api.github.com/users/activatedgeek/orgs","repos_url":"https://api.github.com/users/activatedgeek/repos","events_url":"https://api.github.com/users/activatedgeek/events{/privacy}","received_events_url":"https://api.github.com/users/activatedgeek/received_events","type":"User","site_admin":false},"repo":{"id":137142976,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxNDI5NzY=","name":"kubeflow","full_name":"activatedgeek/kubeflow","owner":{"login":"activatedgeek","id":3909933,"node_id":"MDQ6VXNlcjM5MDk5MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/3909933?v=4","gravatar_id":"","url":"https://api.github.com/users/activatedgeek","html_url":"https://github.com/activatedgeek","followers_url":"https://api.github.com/users/activatedgeek/followers","following_url":"https://api.github.com/users/activatedgeek/following{/other_user}","gists_url":"https://api.github.com/users/activatedgeek/gists{/gist_id}","starred_url":"https://api.github.com/users/activatedgeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/activatedgeek/subscriptions","organizations_url":"https://api.github.com/users/activatedgeek/orgs","repos_url":"https://api.github.com/users/activatedgeek/repos","events_url":"https://api.github.com/users/activatedgeek/events{/privacy}","received_events_url":"https://api.github.com/users/activatedgeek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/activatedgeek/kubeflow","description":"Machine Learning Toolkit for Kubernetes","fork":true,"url":"https://api.github.com/repos/activatedgeek/kubeflow","forks_url":"https://api.github.com/repos/activatedgeek/kubeflow/forks","keys_url":"https://api.github.com/repos/activatedgeek/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/activatedgeek/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/activatedgeek/kubeflow/teams","hooks_url":"https://api.github.com/repos/activatedgeek/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/activatedgeek/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/activatedgeek/kubeflow/events","assignees_url":"https://api.github.com/repos/activatedgeek/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/activatedgeek/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/activatedgeek/kubeflow/tags","blobs_url":"https://api.github.com/repos/activatedgeek/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/activatedgeek/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/activatedgeek/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/activatedgeek/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/activatedgeek/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/activatedgeek/kubeflow/languages","stargazers_url":"https://api.github.com/repos/activatedgeek/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/activatedgeek/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/activatedgeek/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/activatedgeek/kubeflow/subscription","commits_url":"https://api.github.com/repos/activatedgeek/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/activatedgeek/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/activatedgeek/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/activatedgeek/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/activatedgeek/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/activatedgeek/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/activatedgeek/kubeflow/merges","archive_url":"https://api.github.com/repos/activatedgeek/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/activatedgeek/kubeflow/downloads","issues_url":"https://api.github.com/repos/activatedgeek/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/activatedgeek/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/activatedgeek/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/activatedgeek/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/activatedgeek/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/activatedgeek/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/activatedgeek/kubeflow/deployments","created_at":"2018-06-13T00:42:53Z","updated_at":"2018-08-17T18:53:29Z","pushed_at":"2018-08-17T18:53:50Z","git_url":"git://github.com/activatedgeek/kubeflow.git","ssh_url":"git@github.com:activatedgeek/kubeflow.git","clone_url":"https://github.com/activatedgeek/kubeflow.git","svn_url":"https://github.com/activatedgeek/kubeflow","homepage":"","size":122352,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeflow:master","ref":"master","sha":"24c275d16a85ed3a57bae8e97f8378d32122d3ea","user":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":112647343,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI2NDczNDM=","name":"kubeflow","full_name":"kubeflow/kubeflow","owner":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubeflow/kubeflow","description":"Machine Learning Toolkit for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubeflow/kubeflow","forks_url":"https://api.github.com/repos/kubeflow/kubeflow/forks","keys_url":"https://api.github.com/repos/kubeflow/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/kubeflow/teams","hooks_url":"https://api.github.com/repos/kubeflow/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/kubeflow/events","assignees_url":"https://api.github.com/repos/kubeflow/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/kubeflow/tags","blobs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/kubeflow/languages","stargazers_url":"https://api.github.com/repos/kubeflow/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/kubeflow/subscription","commits_url":"https://api.github.com/repos/kubeflow/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/kubeflow/merges","archive_url":"https://api.github.com/repos/kubeflow/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/kubeflow/downloads","issues_url":"https://api.github.com/repos/kubeflow/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/kubeflow/deployments","created_at":"2017-11-30T18:44:19Z","updated_at":"2018-08-17T21:23:43Z","pushed_at":"2018-08-17T22:51:02Z","git_url":"git://github.com/kubeflow/kubeflow.git","ssh_url":"git@github.com:kubeflow/kubeflow.git","clone_url":"https://github.com/kubeflow/kubeflow.git","svn_url":"https://github.com/kubeflow/kubeflow","homepage":"","size":125720,"stargazers_count":4286,"watchers_count":4286,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":553,"mirror_url":null,"archived":false,"open_issues_count":272,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":553,"open_issues":272,"watchers":4286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/1380"},"html":{"href":"https://github.com/kubeflow/kubeflow/pull/1380"},"issue":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/1380"},"comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/1380/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/1380/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/1380/commits"},"statuses":{"href":"https://api.github.com/repos/kubeflow/kubeflow/statuses/e5189fecc37ebbac89fec420a09d70fed0f65854"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":26,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"k8s-ci-robot"}}