{"action":"created","issue":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/9284","repository_url":"https://api.github.com/repos/qbittorrent/qBittorrent","labels_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/9284/labels{/name}","comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/9284/comments","events_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/9284/events","html_url":"https://github.com/qbittorrent/qBittorrent/pull/9284","id":347670567,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjIyODI4","number":9284,"title":"Migrate to SVG icons","user":{"login":"Chocobo1","id":9395168,"node_id":"MDQ6VXNlcjkzOTUxNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/9395168?v=4","gravatar_id":"","url":"https://api.github.com/users/Chocobo1","html_url":"https://github.com/Chocobo1","followers_url":"https://api.github.com/users/Chocobo1/followers","following_url":"https://api.github.com/users/Chocobo1/following{/other_user}","gists_url":"https://api.github.com/users/Chocobo1/gists{/gist_id}","starred_url":"https://api.github.com/users/Chocobo1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chocobo1/subscriptions","organizations_url":"https://api.github.com/users/Chocobo1/orgs","repos_url":"https://api.github.com/users/Chocobo1/repos","events_url":"https://api.github.com/users/Chocobo1/events{/privacy}","received_events_url":"https://api.github.com/users/Chocobo1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-05T05:25:27Z","updated_at":"2018-08-05T12:09:29Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/9284","html_url":"https://github.com/qbittorrent/qBittorrent/pull/9284","diff_url":"https://github.com/qbittorrent/qBittorrent/pull/9284.diff","patch_url":"https://github.com/qbittorrent/qBittorrent/pull/9284.patch"},"body":"This PR aims to replace PNG icons with their SVG counterparts.\r\n\r\n1. WebUI will not be able to use desktop environment theme icons\r\n  IMO this side effect shouldn't have much impact, since WebUI mixes DE icons and qbt built-in icons. From another viewpoint, this PR actually unifies the icon style.\r\n\r\n2. Currently this PR creates a temporary state\r\n  The PNGs aren't removed yet, I plan to do it in the next PR, this avoid messy git operations when the comments rolls in.\r\n  The next PR will remove the PNGs and move SVGs to where PNGs relies now, also removing the temporary qrc files.\r\n\r\n3. There are one or two icons need to be tuned, see [screenshot](https://user-images.githubusercontent.com/9395168/43682849-390c9a18-98b2-11e8-9b95-1fdacbff7712.png)\r\n  The \"Completed\" & \"Errored\" width are off, hopefully someone can help fixing it (in another PR).\r\n\r\n4. Not all icons have SVG counterparts\r\n  We can replace it (in later PR) after someone provided them.\r\n"},"comment":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/comments/410515966","html_url":"https://github.com/qbittorrent/qBittorrent/pull/9284#issuecomment-410515966","issue_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/9284","id":410515966,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDUxNTk2Ng==","user":{"login":"zeule","id":394621,"node_id":"MDQ6VXNlcjM5NDYyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/394621?v=4","gravatar_id":"","url":"https://api.github.com/users/zeule","html_url":"https://github.com/zeule","followers_url":"https://api.github.com/users/zeule/followers","following_url":"https://api.github.com/users/zeule/following{/other_user}","gists_url":"https://api.github.com/users/zeule/gists{/gist_id}","starred_url":"https://api.github.com/users/zeule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeule/subscriptions","organizations_url":"https://api.github.com/users/zeule/orgs","repos_url":"https://api.github.com/users/zeule/repos","events_url":"https://api.github.com/users/zeule/events{/privacy}","received_events_url":"https://api.github.com/users/zeule/received_events","type":"User","site_admin":false},"created_at":"2018-08-05T12:09:29Z","updated_at":"2018-08-05T12:09:29Z","author_association":"CONTRIBUTOR","body":"The second item from the top description does not seem obvious to me. Why splitting an atomic operation onto two commits make it any cleaner?\r\n\r\nI can't find where do you remove `GuiIconProvider::generateDifferentSizes()`."}}
{"actor":{"display_login":"zeule"}}