{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1603","repository_url":"https://api.github.com/repos/JuliaData/DataFrames.jl","labels_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1603/labels{/name}","comments_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1603/comments","events_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1603/events","html_url":"https://github.com/JuliaData/DataFrames.jl/pull/1603","id":381996983,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODExNzgz","number":1603,"title":"Remove deprecation of getindex","user":{"login":"bkamins","id":6187170,"node_id":"MDQ6VXNlcjYxODcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/6187170?v=4","gravatar_id":"","url":"https://api.github.com/users/bkamins","html_url":"https://github.com/bkamins","followers_url":"https://api.github.com/users/bkamins/followers","following_url":"https://api.github.com/users/bkamins/following{/other_user}","gists_url":"https://api.github.com/users/bkamins/gists{/gist_id}","starred_url":"https://api.github.com/users/bkamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkamins/subscriptions","organizations_url":"https://api.github.com/users/bkamins/orgs","repos_url":"https://api.github.com/users/bkamins/repos","events_url":"https://api.github.com/users/bkamins/events{/privacy}","received_events_url":"https://api.github.com/users/bkamins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-18T20:29:23Z","updated_at":"2018-11-19T15:03:09Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/JuliaData/DataFrames.jl/pulls/1603","html_url":"https://github.com/JuliaData/DataFrames.jl/pull/1603","diff_url":"https://github.com/JuliaData/DataFrames.jl/pull/1603.diff","patch_url":"https://github.com/JuliaData/DataFrames.jl/pull/1603.patch"},"body":"This should be merged only after new release of DataFrames.jl is tagged but I wanted to push it out now to show the consequences.\r\n\r\nThis depends on first fixing https://github.com/JuliaData/CategoricalArrays.jl/issues/170. I have commented out a relevant test, but it should be re-enabled before merging. When this is fixed I will also write additional tests.\r\n\r\nWhat does this PR change many inter-related features:\r\n* finish `getindex` deprecation for `DataFrame`, `SubDataFrame`, `DataFrameRow`\r\n* improve `StackedVector` and `RepeatedVector` documentation and make them `IndexLinear` to use mechanics from Base to properly handle `getindex`;\r\n* finish deprecation of iterator for `DataFrameColumns` (now it returns `Pair`)\r\n* `DataFrame(::DataFrame)` makes a copy\r\n* `DataFrameRow` constructor performs bounds checking which can be disabled by `@inbounds`\r\n* add `size` to `DataFrameRow` and finish `iterate` deprecation\r\n* `SubDataFrame` constructor disallows integer row selector (vector is required)"},"comment":{"url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/comments/439922893","html_url":"https://github.com/JuliaData/DataFrames.jl/pull/1603#issuecomment-439922893","issue_url":"https://api.github.com/repos/JuliaData/DataFrames.jl/issues/1603","id":439922893,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTkyMjg5Mw==","user":{"login":"bkamins","id":6187170,"node_id":"MDQ6VXNlcjYxODcxNzA=","avatar_url":"https://avatars3.githubusercontent.com/u/6187170?v=4","gravatar_id":"","url":"https://api.github.com/users/bkamins","html_url":"https://github.com/bkamins","followers_url":"https://api.github.com/users/bkamins/followers","following_url":"https://api.github.com/users/bkamins/following{/other_user}","gists_url":"https://api.github.com/users/bkamins/gists{/gist_id}","starred_url":"https://api.github.com/users/bkamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkamins/subscriptions","organizations_url":"https://api.github.com/users/bkamins/orgs","repos_url":"https://api.github.com/users/bkamins/repos","events_url":"https://api.github.com/users/bkamins/events{/privacy}","received_events_url":"https://api.github.com/users/bkamins/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T15:03:09Z","updated_at":"2018-11-19T15:03:09Z","author_association":"MEMBER","body":"> Can you move the non-breaking parts about `RepeatedVector` and `StackedVector` to a separate PR?\r\n\r\nThis would be only documentation parts. I can move it out, but I thought they are pretty simple so I included them (I can exclude them if you prefer). Should I do it?\r\n\r\nThe `LinearIndex` part and changing the signature from `Integer` to `Int` is a part of this PR as it is strictly related to making all types in DataFrames.jl follow the indexing style introduced in Julia 1.0 (essentially we make sure that all the mechanics is handled by Base as in the recent PR for `eachrow`/`eachcol`/`columns`)."}}
{"actor":{"display_login":"bkamins"}}