{"action":"created","issue":{"url":"https://api.github.com/repos/shopware/shopware/issues/1906","repository_url":"https://api.github.com/repos/shopware/shopware","labels_url":"https://api.github.com/repos/shopware/shopware/issues/1906/labels{/name}","comments_url":"https://api.github.com/repos/shopware/shopware/issues/1906/comments","events_url":"https://api.github.com/repos/shopware/shopware/issues/1906/events","html_url":"https://github.com/shopware/shopware/pull/1906","id":386248048,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MDM1MzI3","number":1906,"title":"Set correct regex for xss filter to filter data-* attributes correctly","user":{"login":"zapato","id":5098534,"node_id":"MDQ6VXNlcjUwOTg1MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5098534?v=4","gravatar_id":"","url":"https://api.github.com/users/zapato","html_url":"https://github.com/zapato","followers_url":"https://api.github.com/users/zapato/followers","following_url":"https://api.github.com/users/zapato/following{/other_user}","gists_url":"https://api.github.com/users/zapato/gists{/gist_id}","starred_url":"https://api.github.com/users/zapato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zapato/subscriptions","organizations_url":"https://api.github.com/users/zapato/orgs","repos_url":"https://api.github.com/users/zapato/repos","events_url":"https://api.github.com/users/zapato/events{/privacy}","received_events_url":"https://api.github.com/users/zapato/received_events","type":"User","site_admin":false},"labels":[{"id":318046718,"node_id":"MDU6TGFiZWwzMTgwNDY3MTg=","url":"https://api.github.com/repos/shopware/shopware/labels/Scheduled","name":"Scheduled","color":"eb6420","default":false}],"state":"closed","locked":false,"assignee":{"login":"soebbing","id":174161,"node_id":"MDQ6VXNlcjE3NDE2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/174161?v=4","gravatar_id":"","url":"https://api.github.com/users/soebbing","html_url":"https://github.com/soebbing","followers_url":"https://api.github.com/users/soebbing/followers","following_url":"https://api.github.com/users/soebbing/following{/other_user}","gists_url":"https://api.github.com/users/soebbing/gists{/gist_id}","starred_url":"https://api.github.com/users/soebbing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soebbing/subscriptions","organizations_url":"https://api.github.com/users/soebbing/orgs","repos_url":"https://api.github.com/users/soebbing/repos","events_url":"https://api.github.com/users/soebbing/events{/privacy}","received_events_url":"https://api.github.com/users/soebbing/received_events","type":"User","site_admin":false},"assignees":[{"login":"soebbing","id":174161,"node_id":"MDQ6VXNlcjE3NDE2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/174161?v=4","gravatar_id":"","url":"https://api.github.com/users/soebbing","html_url":"https://github.com/soebbing","followers_url":"https://api.github.com/users/soebbing/followers","following_url":"https://api.github.com/users/soebbing/following{/other_user}","gists_url":"https://api.github.com/users/soebbing/gists{/gist_id}","starred_url":"https://api.github.com/users/soebbing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soebbing/subscriptions","organizations_url":"https://api.github.com/users/soebbing/orgs","repos_url":"https://api.github.com/users/soebbing/repos","events_url":"https://api.github.com/users/soebbing/events{/privacy}","received_events_url":"https://api.github.com/users/soebbing/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-11-30T16:02:53Z","updated_at":"2019-01-02T14:16:38Z","closed_at":"2019-01-02T14:15:39Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/shopware/shopware/pulls/1906","html_url":"https://github.com/shopware/shopware/pull/1906","diff_url":"https://github.com/shopware/shopware/pull/1906.diff","patch_url":"https://github.com/shopware/shopware/pull/1906.patch"},"body":"<!--\r\nThank you for contributing to Shopware! Please fill out this description template to help us to process your pull request.\r\n\r\nPlease make sure to fulfil our contribution guideline (https://developers.shopware.com/contributing/contribution-guideline/).\r\n-->\r\n\r\n### 1. Why is this change necessary?\r\nUsage of URL domain names which contain `data-` could not be used. For example when a domain name contains `data-` then Shopware will set the `$_SERVER[HTTP_HOST]` to `NULL`\r\n\r\nSo we are not able to use Shopware without workarounds for our Domains `*.data-room.de` and `*.data-graphis.de`\r\n\r\n### 2. What does this change do, exactly?\r\n\r\nAdds the missing `=` to the xss regex to filter a html `data-*` attribute and keeps values like the `HTTP_HOST` with `data-` values.\r\n\r\n### 3. Describe each step to reproduce the issue or behaviour.\r\n\r\nInstall Shopware to an domain which contains `data-` and call `$this->Request()->getHttpHost()` into a controller\r\n\r\n### 4. Please link to the relevant issues (if any).\r\n\r\nnone\r\n\r\n### 5. Which documentation changes (if any) need to be made because of this PR?\r\n\r\nnone\r\n\r\n### 6. Checklist\r\n\r\n- [x] I have written tests and verified that they fail without my change\r\n- [x] I have squashed any insignificant commits (only a single commit)\r\n- [ ] This change has comments for package types, values, functions, and non-obvious lines of code\r\n- [x] I have read the contribution requirements and fulfil them."},"comment":{"url":"https://api.github.com/repos/shopware/shopware/issues/comments/450873894","html_url":"https://github.com/shopware/shopware/pull/1906#issuecomment-450873894","issue_url":"https://api.github.com/repos/shopware/shopware/issues/1906","id":450873894,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDg3Mzg5NA==","user":{"login":"shopwareBot","id":4725494,"node_id":"MDQ6VXNlcjQ3MjU0OTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4725494?v=4","gravatar_id":"","url":"https://api.github.com/users/shopwareBot","html_url":"https://github.com/shopwareBot","followers_url":"https://api.github.com/users/shopwareBot/followers","following_url":"https://api.github.com/users/shopwareBot/following{/other_user}","gists_url":"https://api.github.com/users/shopwareBot/gists{/gist_id}","starred_url":"https://api.github.com/users/shopwareBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shopwareBot/subscriptions","organizations_url":"https://api.github.com/users/shopwareBot/orgs","repos_url":"https://api.github.com/users/shopwareBot/repos","events_url":"https://api.github.com/users/shopwareBot/events{/privacy}","received_events_url":"https://api.github.com/users/shopwareBot/received_events","type":"User","site_admin":false},"created_at":"2019-01-02T14:16:38Z","updated_at":"2019-01-02T14:16:38Z","author_association":"NONE","body":"Hey @zapato,\r\nhappy new year and thank you for the contribution! :blue_heart: "}}
{"actor":{"display_login":"shopwareBot"}}