{"action":"created","issue":{"url":"https://api.github.com/repos/eXist-db/exist/issues/1650","repository_url":"https://api.github.com/repos/eXist-db/exist","labels_url":"https://api.github.com/repos/eXist-db/exist/issues/1650/labels{/name}","comments_url":"https://api.github.com/repos/eXist-db/exist/issues/1650/comments","events_url":"https://api.github.com/repos/eXist-db/exist/issues/1650/events","html_url":"https://github.com/eXist-db/exist/pull/1650","id":279569451,"number":1650,"title":"Fixes to XQuery binary type use in APIs.","user":{"login":"adamretter","id":1264057,"avatar_url":"https://avatars1.githubusercontent.com/u/1264057?v=4","gravatar_id":"","url":"https://api.github.com/users/adamretter","html_url":"https://github.com/adamretter","followers_url":"https://api.github.com/users/adamretter/followers","following_url":"https://api.github.com/users/adamretter/following{/other_user}","gists_url":"https://api.github.com/users/adamretter/gists{/gist_id}","starred_url":"https://api.github.com/users/adamretter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamretter/subscriptions","organizations_url":"https://api.github.com/users/adamretter/orgs","repos_url":"https://api.github.com/users/adamretter/repos","events_url":"https://api.github.com/users/adamretter/events{/privacy}","received_events_url":"https://api.github.com/users/adamretter/received_events","type":"User","site_admin":false},"labels":[{"id":49540768,"url":"https://api.github.com/repos/eXist-db/exist/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":{"login":"wolfgangmm","id":607433,"avatar_url":"https://avatars0.githubusercontent.com/u/607433?v=4","gravatar_id":"","url":"https://api.github.com/users/wolfgangmm","html_url":"https://github.com/wolfgangmm","followers_url":"https://api.github.com/users/wolfgangmm/followers","following_url":"https://api.github.com/users/wolfgangmm/following{/other_user}","gists_url":"https://api.github.com/users/wolfgangmm/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfgangmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfgangmm/subscriptions","organizations_url":"https://api.github.com/users/wolfgangmm/orgs","repos_url":"https://api.github.com/users/wolfgangmm/repos","events_url":"https://api.github.com/users/wolfgangmm/events{/privacy}","received_events_url":"https://api.github.com/users/wolfgangmm/received_events","type":"User","site_admin":false},"assignees":[{"login":"wolfgangmm","id":607433,"avatar_url":"https://avatars0.githubusercontent.com/u/607433?v=4","gravatar_id":"","url":"https://api.github.com/users/wolfgangmm","html_url":"https://github.com/wolfgangmm","followers_url":"https://api.github.com/users/wolfgangmm/followers","following_url":"https://api.github.com/users/wolfgangmm/following{/other_user}","gists_url":"https://api.github.com/users/wolfgangmm/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfgangmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfgangmm/subscriptions","organizations_url":"https://api.github.com/users/wolfgangmm/orgs","repos_url":"https://api.github.com/users/wolfgangmm/repos","events_url":"https://api.github.com/users/wolfgangmm/events{/privacy}","received_events_url":"https://api.github.com/users/wolfgangmm/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/eXist-db/exist/milestones/5","html_url":"https://github.com/eXist-db/exist/milestone/5","labels_url":"https://api.github.com/repos/eXist-db/exist/milestones/5/labels","id":1050275,"number":5,"title":"eXist-4.0.0","description":"","creator":{"login":"adamretter","id":1264057,"avatar_url":"https://avatars1.githubusercontent.com/u/1264057?v=4","gravatar_id":"","url":"https://api.github.com/users/adamretter","html_url":"https://github.com/adamretter","followers_url":"https://api.github.com/users/adamretter/followers","following_url":"https://api.github.com/users/adamretter/following{/other_user}","gists_url":"https://api.github.com/users/adamretter/gists{/gist_id}","starred_url":"https://api.github.com/users/adamretter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamretter/subscriptions","organizations_url":"https://api.github.com/users/adamretter/orgs","repos_url":"https://api.github.com/users/adamretter/repos","events_url":"https://api.github.com/users/adamretter/events{/privacy}","received_events_url":"https://api.github.com/users/adamretter/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":13,"state":"open","created_at":"2015-04-02T12:56:33Z","updated_at":"2018-02-06T20:24:57Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2017-12-05T23:31:40Z","updated_at":"2018-02-10T09:53:17Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/eXist-db/exist/pulls/1650","html_url":"https://github.com/eXist-db/exist/pull/1650","diff_url":"https://github.com/eXist-db/exist/pull/1650.diff","patch_url":"https://github.com/eXist-db/exist/pull/1650.patch"},"body":"Closes https://github.com/eXist-db/exist/issues/790\r\nAlong with the issue #790, the tests I added pretty much show the previous problems.\r\n\r\nFixes a number of issues with `xs:base64Binary` and `xs:hexBinary` returned from XQuery execution in various API's in particular XML:DB and XML-RPC.\r\n\r\nAlso fixes a regression with access to binaries via the XML:DB API in 3.6.0 (which appeared after 3.5.0). You can see the regression by running the test suite of the [EXPath Bin Module](https://github.com/exist-db/expath-bin-module) against eXist 3.6.0.\r\n\r\nThese changes are **not** API backwards compatible with the existing XML:DB and XML-RPC APIs. \r\n\r\nThe main things are:\r\n\r\n1. When an XQuery returns a `xs:base64Binary` or `xs:hexBinary` a `BinaryResource` will now be returned instead of an `XMLResource`. This means that calls to `org.xmldb.api.base.Resource#getContent()` which used to return an encoded binary. This is much more efficient, however users **must** call either `EXistResource#close()` or `ResourceSet#clear()` to release the handles on the underlying binary streams.\r\n\r\n2. We previously could not deliver streaming binary values via the XML:DB API. We now do, however this moves ownership of the binary streams out to the API. The calling user of the XML:DB API is responsible for calling either `org.exist.xmldb.EXistResource#close()` or `org.xmldb.api.base.ResourceSet#clear()` to release the streams."},"comment":{"url":"https://api.github.com/repos/eXist-db/exist/issues/comments/364639944","html_url":"https://github.com/eXist-db/exist/pull/1650#issuecomment-364639944","issue_url":"https://api.github.com/repos/eXist-db/exist/issues/1650","id":364639944,"user":{"login":"wolfgangmm","id":607433,"avatar_url":"https://avatars0.githubusercontent.com/u/607433?v=4","gravatar_id":"","url":"https://api.github.com/users/wolfgangmm","html_url":"https://github.com/wolfgangmm","followers_url":"https://api.github.com/users/wolfgangmm/followers","following_url":"https://api.github.com/users/wolfgangmm/following{/other_user}","gists_url":"https://api.github.com/users/wolfgangmm/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfgangmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfgangmm/subscriptions","organizations_url":"https://api.github.com/users/wolfgangmm/orgs","repos_url":"https://api.github.com/users/wolfgangmm/repos","events_url":"https://api.github.com/users/wolfgangmm/events{/privacy}","received_events_url":"https://api.github.com/users/wolfgangmm/received_events","type":"User","site_admin":false},"created_at":"2018-02-10T09:53:17Z","updated_at":"2018-02-10T09:53:17Z","author_association":"OWNER","body":"No further warnings popped up, great! Merging ..."}}
{"actor":{"display_login":"wolfgangmm"}}