{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/169827073","pull_request_review_id":98417058,"id":169827073,"diff_hunk":"@@ -0,0 +1,46 @@\n+/*\n+Copyright 2014 The Kubernetes Authors.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package gce_pd\n+\n+import (\n+\t\"os\"\n+\t\"testing\"\n+\n+\tutiltesting \"k8s.io/client-go/util/testing\"\n+)\n+\n+func TestGetVolumeSpecFromGlobalMapPath(t *testing.T) {\n+\t// make our test path for fake GlobalMapPath\n+\t// /tmp symbolized our pluginDir\n+\t// /tmp/volumeDevices/pdVol1\n+\ttmpVDir, err := utiltesting.MkTmpdir(\"volumeDevices\")\n+\tif err != nil {\n+\t\tt.Fatalf(\"can't make a temp dir: %v\", err)\n+\t}\n+\t//deferred clean up\n+\tdefer os.RemoveAll(tmpVDir)\n+\n+\tpath1a := tmpVDir + \"/pdVol1\"\n+\terr1a := os.MkdirAll(path1a, 0777)\n+\tif err1a != nil {\n+\t\tt.Fatalf(\"can't make a temp dir: %v\", err1a)\n+\t}\n+\tspec, err := getVolumeSpecFromGlobalMapPath(path1a)","path":"pkg/volume/gce_pd/gce_pd_block_test.go","position":42,"original_position":42,"commit_id":"be4b24dca52f2995e89597cf4230746dd41c71f7","original_commit_id":"be4b24dca52f2995e89597cf4230746dd41c71f7","user":{"login":"screeley44","id":6773375,"avatar_url":"https://avatars2.githubusercontent.com/u/6773375?v=4","gravatar_id":"","url":"https://api.github.com/users/screeley44","html_url":"https://github.com/screeley44","followers_url":"https://api.github.com/users/screeley44/followers","following_url":"https://api.github.com/users/screeley44/following{/other_user}","gists_url":"https://api.github.com/users/screeley44/gists{/gist_id}","starred_url":"https://api.github.com/users/screeley44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screeley44/subscriptions","organizations_url":"https://api.github.com/users/screeley44/orgs","repos_url":"https://api.github.com/users/screeley44/repos","events_url":"https://api.github.com/users/screeley44/events{/privacy}","received_events_url":"https://api.github.com/users/screeley44/received_events","type":"User","site_admin":false},"body":"of course, my bad","created_at":"2018-02-22T00:55:05Z","updated_at":"2018-02-22T00:55:05Z","html_url":"https://github.com/kubernetes/kubernetes/pull/58710#discussion_r169827073","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58710","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/169827073"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/58710#discussion_r169827073"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58710"}},"in_reply_to_id":169762243},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58710","id":164672519,"html_url":"https://github.com/kubernetes/kubernetes/pull/58710","diff_url":"https://github.com/kubernetes/kubernetes/pull/58710.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/58710.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58710","number":58710,"state":"open","locked":false,"title":"update GCE plugin for block support","user":{"login":"screeley44","id":6773375,"avatar_url":"https://avatars2.githubusercontent.com/u/6773375?v=4","gravatar_id":"","url":"https://api.github.com/users/screeley44","html_url":"https://github.com/screeley44","followers_url":"https://api.github.com/users/screeley44/followers","following_url":"https://api.github.com/users/screeley44/following{/other_user}","gists_url":"https://api.github.com/users/screeley44/gists{/gist_id}","starred_url":"https://api.github.com/users/screeley44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screeley44/subscriptions","organizations_url":"https://api.github.com/users/screeley44/orgs","repos_url":"https://api.github.com/users/screeley44/repos","events_url":"https://api.github.com/users/screeley44/events{/privacy}","received_events_url":"https://api.github.com/users/screeley44/received_events","type":"User","site_admin":false},"body":"update GCE plugin for block volume support\r\n\r\ncc @gnufied @mtanino @jsafrane ","created_at":"2018-01-23T19:48:52Z","updated_at":"2018-02-22T00:55:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d98c2316ac0c45fa2ab6c3c662b772a82bec502","assignee":{"login":"msau42","id":24448061,"avatar_url":"https://avatars3.githubusercontent.com/u/24448061?v=4","gravatar_id":"","url":"https://api.github.com/users/msau42","html_url":"https://github.com/msau42","followers_url":"https://api.github.com/users/msau42/followers","following_url":"https://api.github.com/users/msau42/following{/other_user}","gists_url":"https://api.github.com/users/msau42/gists{/gist_id}","starred_url":"https://api.github.com/users/msau42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msau42/subscriptions","organizations_url":"https://api.github.com/users/msau42/orgs","repos_url":"https://api.github.com/users/msau42/repos","events_url":"https://api.github.com/users/msau42/events{/privacy}","received_events_url":"https://api.github.com/users/msau42/received_events","type":"User","site_admin":false},"assignees":[{"login":"msau42","id":24448061,"avatar_url":"https://avatars3.githubusercontent.com/u/24448061?v=4","gravatar_id":"","url":"https://api.github.com/users/msau42","html_url":"https://github.com/msau42","followers_url":"https://api.github.com/users/msau42/followers","following_url":"https://api.github.com/users/msau42/following{/other_user}","gists_url":"https://api.github.com/users/msau42/gists{/gist_id}","starred_url":"https://api.github.com/users/msau42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msau42/subscriptions","organizations_url":"https://api.github.com/users/msau42/orgs","repos_url":"https://api.github.com/users/msau42/repos","events_url":"https://api.github.com/users/msau42/events{/privacy}","received_events_url":"https://api.github.com/users/msau42/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"davidz627","id":5459214,"avatar_url":"https://avatars3.githubusercontent.com/u/5459214?v=4","gravatar_id":"","url":"https://api.github.com/users/davidz627","html_url":"https://github.com/davidz627","followers_url":"https://api.github.com/users/davidz627/followers","following_url":"https://api.github.com/users/davidz627/following{/other_user}","gists_url":"https://api.github.com/users/davidz627/gists{/gist_id}","starred_url":"https://api.github.com/users/davidz627/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidz627/subscriptions","organizations_url":"https://api.github.com/users/davidz627/orgs","repos_url":"https://api.github.com/users/davidz627/repos","events_url":"https://api.github.com/users/davidz627/events{/privacy}","received_events_url":"https://api.github.com/users/davidz627/received_events","type":"User","site_admin":false},{"login":"jingxu97","id":19172805,"avatar_url":"https://avatars3.githubusercontent.com/u/19172805?v=4","gravatar_id":"","url":"https://api.github.com/users/jingxu97","html_url":"https://github.com/jingxu97","followers_url":"https://api.github.com/users/jingxu97/followers","following_url":"https://api.github.com/users/jingxu97/following{/other_user}","gists_url":"https://api.github.com/users/jingxu97/gists{/gist_id}","starred_url":"https://api.github.com/users/jingxu97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingxu97/subscriptions","organizations_url":"https://api.github.com/users/jingxu97/orgs","repos_url":"https://api.github.com/users/jingxu97/repos","events_url":"https://api.github.com/users/jingxu97/events{/privacy}","received_events_url":"https://api.github.com/users/jingxu97/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":680152113,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"e11d21","default":false},{"id":169428334,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58710/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58710/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/58710/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/be4b24dca52f2995e89597cf4230746dd41c71f7","head":{"label":"screeley44:gce-block-update2","ref":"gce-block-update2","sha":"be4b24dca52f2995e89597cf4230746dd41c71f7","user":{"login":"screeley44","id":6773375,"avatar_url":"https://avatars2.githubusercontent.com/u/6773375?v=4","gravatar_id":"","url":"https://api.github.com/users/screeley44","html_url":"https://github.com/screeley44","followers_url":"https://api.github.com/users/screeley44/followers","following_url":"https://api.github.com/users/screeley44/following{/other_user}","gists_url":"https://api.github.com/users/screeley44/gists{/gist_id}","starred_url":"https://api.github.com/users/screeley44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screeley44/subscriptions","organizations_url":"https://api.github.com/users/screeley44/orgs","repos_url":"https://api.github.com/users/screeley44/repos","events_url":"https://api.github.com/users/screeley44/events{/privacy}","received_events_url":"https://api.github.com/users/screeley44/received_events","type":"User","site_admin":false},"repo":{"id":78146634,"name":"kubernetes","full_name":"screeley44/kubernetes","owner":{"login":"screeley44","id":6773375,"avatar_url":"https://avatars2.githubusercontent.com/u/6773375?v=4","gravatar_id":"","url":"https://api.github.com/users/screeley44","html_url":"https://github.com/screeley44","followers_url":"https://api.github.com/users/screeley44/followers","following_url":"https://api.github.com/users/screeley44/following{/other_user}","gists_url":"https://api.github.com/users/screeley44/gists{/gist_id}","starred_url":"https://api.github.com/users/screeley44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screeley44/subscriptions","organizations_url":"https://api.github.com/users/screeley44/orgs","repos_url":"https://api.github.com/users/screeley44/repos","events_url":"https://api.github.com/users/screeley44/events{/privacy}","received_events_url":"https://api.github.com/users/screeley44/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/screeley44/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/screeley44/kubernetes","forks_url":"https://api.github.com/repos/screeley44/kubernetes/forks","keys_url":"https://api.github.com/repos/screeley44/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/screeley44/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/screeley44/kubernetes/teams","hooks_url":"https://api.github.com/repos/screeley44/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/screeley44/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/screeley44/kubernetes/events","assignees_url":"https://api.github.com/repos/screeley44/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/screeley44/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/screeley44/kubernetes/tags","blobs_url":"https://api.github.com/repos/screeley44/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/screeley44/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/screeley44/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/screeley44/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/screeley44/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/screeley44/kubernetes/languages","stargazers_url":"https://api.github.com/repos/screeley44/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/screeley44/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/screeley44/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/screeley44/kubernetes/subscription","commits_url":"https://api.github.com/repos/screeley44/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/screeley44/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/screeley44/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/screeley44/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/screeley44/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/screeley44/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/screeley44/kubernetes/merges","archive_url":"https://api.github.com/repos/screeley44/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/screeley44/kubernetes/downloads","issues_url":"https://api.github.com/repos/screeley44/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/screeley44/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/screeley44/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/screeley44/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/screeley44/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/screeley44/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/screeley44/kubernetes/deployments","created_at":"2017-01-05T20:40:07Z","updated_at":"2017-01-05T20:40:44Z","pushed_at":"2018-02-21T19:26:21Z","git_url":"git://github.com/screeley44/kubernetes.git","ssh_url":"git@github.com:screeley44/kubernetes.git","clone_url":"https://github.com/screeley44/kubernetes.git","svn_url":"https://github.com/screeley44/kubernetes","homepage":"http://kubernetes.io","size":529185,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"2b530438f11d2dd8fab20423956b3df99309f757","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-02-21T23:26:14Z","pushed_at":"2018-02-22T00:51:30Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":755481,"stargazers_count":32760,"watchers_count":32760,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11549,"mirror_url":null,"archived":false,"open_issues_count":4654,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":11549,"open_issues":4654,"watchers":32760,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58710"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/58710"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/58710"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/58710/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58710/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/58710/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/be4b24dca52f2995e89597cf4230746dd41c71f7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"screeley44"}}