{"action":"created","comment":{"url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/pulls/comments/218279130","pull_request_review_id":156179422,"id":218279130,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODI3OTEzMA==","diff_hunk":"@@ -0,0 +1,77 @@\n+const http = require('http');","path":"micro-airtable-api.test.js","position":1,"original_position":1,"commit_id":"e0739e90416e5608698acdd12f6a249087816e99","original_commit_id":"e0739e90416e5608698acdd12f6a249087816e99","user":{"login":"rosszurowski","id":303731,"node_id":"MDQ6VXNlcjMwMzczMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/303731?v=4","gravatar_id":"","url":"https://api.github.com/users/rosszurowski","html_url":"https://github.com/rosszurowski","followers_url":"https://api.github.com/users/rosszurowski/followers","following_url":"https://api.github.com/users/rosszurowski/following{/other_user}","gists_url":"https://api.github.com/users/rosszurowski/gists{/gist_id}","starred_url":"https://api.github.com/users/rosszurowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosszurowski/subscriptions","organizations_url":"https://api.github.com/users/rosszurowski/orgs","repos_url":"https://api.github.com/users/rosszurowski/repos","events_url":"https://api.github.com/users/rosszurowski/events{/privacy}","received_events_url":"https://api.github.com/users/rosszurowski/received_events","type":"User","site_admin":false},"body":"Mind renaming this file back to `index.test.js`? It's a standard Jest practice to name the test files the same as the files they're testing. Since we're testing `index.js`, it should be named `index.test.js` too.","created_at":"2018-09-18T01:52:35Z","updated_at":"2018-09-18T01:55:06Z","html_url":"https://github.com/rosszurowski/micro-airtable-api/pull/19#discussion_r218279130","pull_request_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/pulls/19","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/rosszurowski/micro-airtable-api/pulls/comments/218279130"},"html":{"href":"https://github.com/rosszurowski/micro-airtable-api/pull/19#discussion_r218279130"},"pull_request":{"href":"https://api.github.com/repos/rosszurowski/micro-airtable-api/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/pulls/19","id":215724541,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NzI0NTQx","html_url":"https://github.com/rosszurowski/micro-airtable-api/pull/19","diff_url":"https://github.com/rosszurowski/micro-airtable-api/pull/19.diff","patch_url":"https://github.com/rosszurowski/micro-airtable-api/pull/19.patch","issue_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/issues/19","number":19,"state":"open","locked":false,"title":"Integration tests","user":{"login":"karllhughes","id":1103622,"node_id":"MDQ6VXNlcjExMDM2MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1103622?v=4","gravatar_id":"","url":"https://api.github.com/users/karllhughes","html_url":"https://github.com/karllhughes","followers_url":"https://api.github.com/users/karllhughes/followers","following_url":"https://api.github.com/users/karllhughes/following{/other_user}","gists_url":"https://api.github.com/users/karllhughes/gists{/gist_id}","starred_url":"https://api.github.com/users/karllhughes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karllhughes/subscriptions","organizations_url":"https://api.github.com/users/karllhughes/orgs","repos_url":"https://api.github.com/users/karllhughes/repos","events_url":"https://api.github.com/users/karllhughes/events{/privacy}","received_events_url":"https://api.github.com/users/karllhughes/received_events","type":"User","site_admin":false},"body":"This is not ready to merge, but I wanted to open conversation on a proof of concept for how we might set up integration tests (re: #17).\r\n\r\nTBH, I've never used Supertest or done much integration testing like this in JS before, but it seems to work. I'm very open to feedback on best practices or cleaning it up though!\r\n\r\nI just added you as a collaborator on [this airtable base](https://airtable.com/tblcWfadZbQsxW4ay/viwfqecWYF6nsnQmT), so you should be able to run the integration tests via the command line:\r\n\r\n```\r\nAIRTABLE_API_KEY=... AIRTABLE_BASE_ID=... npm test\r\n```\r\n\r\nIf you leave out the API keys, it should skip the integration test suite file.\r\n\r\nI'm excited about this, should make debugging easier and regressions less likely! 🎆 ","created_at":"2018-09-14T22:20:05Z","updated_at":"2018-09-18T01:55:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4cee985762841828b7ed8e3a74eac2dec2d51756","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/pulls/19/commits","review_comments_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/pulls/19/comments","review_comment_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/issues/19/comments","statuses_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/statuses/e0739e90416e5608698acdd12f6a249087816e99","head":{"label":"rosszurowski:integration-tests","ref":"integration-tests","sha":"e0739e90416e5608698acdd12f6a249087816e99","user":{"login":"rosszurowski","id":303731,"node_id":"MDQ6VXNlcjMwMzczMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/303731?v=4","gravatar_id":"","url":"https://api.github.com/users/rosszurowski","html_url":"https://github.com/rosszurowski","followers_url":"https://api.github.com/users/rosszurowski/followers","following_url":"https://api.github.com/users/rosszurowski/following{/other_user}","gists_url":"https://api.github.com/users/rosszurowski/gists{/gist_id}","starred_url":"https://api.github.com/users/rosszurowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosszurowski/subscriptions","organizations_url":"https://api.github.com/users/rosszurowski/orgs","repos_url":"https://api.github.com/users/rosszurowski/repos","events_url":"https://api.github.com/users/rosszurowski/events{/privacy}","received_events_url":"https://api.github.com/users/rosszurowski/received_events","type":"User","site_admin":false},"repo":{"id":91962703,"node_id":"MDEwOlJlcG9zaXRvcnk5MTk2MjcwMw==","name":"micro-airtable-api","full_name":"rosszurowski/micro-airtable-api","private":false,"owner":{"login":"rosszurowski","id":303731,"node_id":"MDQ6VXNlcjMwMzczMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/303731?v=4","gravatar_id":"","url":"https://api.github.com/users/rosszurowski","html_url":"https://github.com/rosszurowski","followers_url":"https://api.github.com/users/rosszurowski/followers","following_url":"https://api.github.com/users/rosszurowski/following{/other_user}","gists_url":"https://api.github.com/users/rosszurowski/gists{/gist_id}","starred_url":"https://api.github.com/users/rosszurowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosszurowski/subscriptions","organizations_url":"https://api.github.com/users/rosszurowski/orgs","repos_url":"https://api.github.com/users/rosszurowski/repos","events_url":"https://api.github.com/users/rosszurowski/events{/privacy}","received_events_url":"https://api.github.com/users/rosszurowski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rosszurowski/micro-airtable-api","description":"Quickly make an API from Airtable","fork":false,"url":"https://api.github.com/repos/rosszurowski/micro-airtable-api","forks_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/forks","keys_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/teams","hooks_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/hooks","issue_events_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/issues/events{/number}","events_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/events","assignees_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/assignees{/user}","branches_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/branches{/branch}","tags_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/tags","blobs_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/statuses/{sha}","languages_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/languages","stargazers_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/stargazers","contributors_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/contributors","subscribers_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/subscribers","subscription_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/subscription","commits_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/contents/{+path}","compare_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/merges","archive_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/downloads","issues_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/issues{/number}","pulls_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/pulls{/number}","milestones_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/milestones{/number}","notifications_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/labels{/name}","releases_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/releases{/id}","deployments_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/deployments","created_at":"2017-05-21T14:19:03Z","updated_at":"2018-09-15T18:59:32Z","pushed_at":"2018-09-17T22:21:04Z","git_url":"git://github.com/rosszurowski/micro-airtable-api.git","ssh_url":"git@github.com:rosszurowski/micro-airtable-api.git","clone_url":"https://github.com/rosszurowski/micro-airtable-api.git","svn_url":"https://github.com/rosszurowski/micro-airtable-api","homepage":"","size":77,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":7,"watchers":6,"default_branch":"master"}},"base":{"label":"rosszurowski:master","ref":"master","sha":"c1b938a79fcd656dd04757874509bd22c73066e5","user":{"login":"rosszurowski","id":303731,"node_id":"MDQ6VXNlcjMwMzczMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/303731?v=4","gravatar_id":"","url":"https://api.github.com/users/rosszurowski","html_url":"https://github.com/rosszurowski","followers_url":"https://api.github.com/users/rosszurowski/followers","following_url":"https://api.github.com/users/rosszurowski/following{/other_user}","gists_url":"https://api.github.com/users/rosszurowski/gists{/gist_id}","starred_url":"https://api.github.com/users/rosszurowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosszurowski/subscriptions","organizations_url":"https://api.github.com/users/rosszurowski/orgs","repos_url":"https://api.github.com/users/rosszurowski/repos","events_url":"https://api.github.com/users/rosszurowski/events{/privacy}","received_events_url":"https://api.github.com/users/rosszurowski/received_events","type":"User","site_admin":false},"repo":{"id":91962703,"node_id":"MDEwOlJlcG9zaXRvcnk5MTk2MjcwMw==","name":"micro-airtable-api","full_name":"rosszurowski/micro-airtable-api","private":false,"owner":{"login":"rosszurowski","id":303731,"node_id":"MDQ6VXNlcjMwMzczMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/303731?v=4","gravatar_id":"","url":"https://api.github.com/users/rosszurowski","html_url":"https://github.com/rosszurowski","followers_url":"https://api.github.com/users/rosszurowski/followers","following_url":"https://api.github.com/users/rosszurowski/following{/other_user}","gists_url":"https://api.github.com/users/rosszurowski/gists{/gist_id}","starred_url":"https://api.github.com/users/rosszurowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosszurowski/subscriptions","organizations_url":"https://api.github.com/users/rosszurowski/orgs","repos_url":"https://api.github.com/users/rosszurowski/repos","events_url":"https://api.github.com/users/rosszurowski/events{/privacy}","received_events_url":"https://api.github.com/users/rosszurowski/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rosszurowski/micro-airtable-api","description":"Quickly make an API from Airtable","fork":false,"url":"https://api.github.com/repos/rosszurowski/micro-airtable-api","forks_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/forks","keys_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/teams","hooks_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/hooks","issue_events_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/issues/events{/number}","events_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/events","assignees_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/assignees{/user}","branches_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/branches{/branch}","tags_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/tags","blobs_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/statuses/{sha}","languages_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/languages","stargazers_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/stargazers","contributors_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/contributors","subscribers_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/subscribers","subscription_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/subscription","commits_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/contents/{+path}","compare_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/merges","archive_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/downloads","issues_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/issues{/number}","pulls_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/pulls{/number}","milestones_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/milestones{/number}","notifications_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/labels{/name}","releases_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/releases{/id}","deployments_url":"https://api.github.com/repos/rosszurowski/micro-airtable-api/deployments","created_at":"2017-05-21T14:19:03Z","updated_at":"2018-09-15T18:59:32Z","pushed_at":"2018-09-17T22:21:04Z","git_url":"git://github.com/rosszurowski/micro-airtable-api.git","ssh_url":"git@github.com:rosszurowski/micro-airtable-api.git","clone_url":"https://github.com/rosszurowski/micro-airtable-api.git","svn_url":"https://github.com/rosszurowski/micro-airtable-api","homepage":"","size":77,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":7,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rosszurowski/micro-airtable-api/pulls/19"},"html":{"href":"https://github.com/rosszurowski/micro-airtable-api/pull/19"},"issue":{"href":"https://api.github.com/repos/rosszurowski/micro-airtable-api/issues/19"},"comments":{"href":"https://api.github.com/repos/rosszurowski/micro-airtable-api/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/rosszurowski/micro-airtable-api/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/rosszurowski/micro-airtable-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rosszurowski/micro-airtable-api/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/rosszurowski/micro-airtable-api/statuses/e0739e90416e5608698acdd12f6a249087816e99"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rosszurowski"}}