{"action":"created","issue":{"url":"https://api.github.com/repos/kubeflow/tf-operator/issues/558","repository_url":"https://api.github.com/repos/kubeflow/tf-operator","labels_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/558/labels{/name}","comments_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/558/comments","events_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/558/events","html_url":"https://github.com/kubeflow/tf-operator/issues/558","id":317398066,"number":558,"title":"Add a timeout flag in tf-operator to preserve resources after job completion for a given period","user":{"login":"ashahba","id":12436063,"avatar_url":"https://avatars3.githubusercontent.com/u/12436063?v=4","gravatar_id":"","url":"https://api.github.com/users/ashahba","html_url":"https://github.com/ashahba","followers_url":"https://api.github.com/users/ashahba/followers","following_url":"https://api.github.com/users/ashahba/following{/other_user}","gists_url":"https://api.github.com/users/ashahba/gists{/gist_id}","starred_url":"https://api.github.com/users/ashahba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashahba/subscriptions","organizations_url":"https://api.github.com/users/ashahba/orgs","repos_url":"https://api.github.com/users/ashahba/repos","events_url":"https://api.github.com/users/ashahba/events{/privacy}","received_events_url":"https://api.github.com/users/ashahba/received_events","type":"User","site_admin":false},"labels":[{"id":823344077,"url":"https://api.github.com/repos/kubeflow/tf-operator/labels/area/operator","name":"area/operator","color":"d2b48c","default":false},{"id":912972664,"url":"https://api.github.com/repos/kubeflow/tf-operator/labels/community/discussion","name":"community/discussion","color":"ecfc15","default":false},{"id":912972665,"url":"https://api.github.com/repos/kubeflow/tf-operator/labels/improvement/optimization","name":"improvement/optimization","color":"00daff","default":false},{"id":823359003,"url":"https://api.github.com/repos/kubeflow/tf-operator/labels/priority/p3","name":"priority/p3","color":"fef2c0","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-24T21:15:21Z","updated_at":"2018-04-26T05:02:23Z","closed_at":"2018-04-26T05:02:23Z","author_association":"NONE","body":"When users are still in template development phase they may require to get a shell into the running Pod and inspect it and many other scenarios that require Job resources to remain available even after Job has been completed.\r\n\r\nThis way we leave decision on resource cleanup to users.\r\nOn the other hand cluster admins should always be able to define `Resource Quotas` per user and per namespace.\r\nThis way we encourage people to be mindful of resources available to them and also give them option to use the resource however they choose rather than enforcing the policy on them 🙂 .\r\n\r\nNow I'm not asking to keep resources around indefinitely after the Job has been finished, so the flag really should provide a configurable `timeout` value that users can overwrite and it should also be capped at some large number like `7 days`, `30 days` or something that we can agree on later.\r\n\r\nSo I believe a timeout flag to preserve resources after Job completion for a certain period would be super helpful."},"comment":{"url":"https://api.github.com/repos/kubeflow/tf-operator/issues/comments/384513724","html_url":"https://github.com/kubeflow/tf-operator/issues/558#issuecomment-384513724","issue_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/558","id":384513724,"user":{"login":"gaocegege","id":5100735,"avatar_url":"https://avatars3.githubusercontent.com/u/5100735?v=4","gravatar_id":"","url":"https://api.github.com/users/gaocegege","html_url":"https://github.com/gaocegege","followers_url":"https://api.github.com/users/gaocegege/followers","following_url":"https://api.github.com/users/gaocegege/following{/other_user}","gists_url":"https://api.github.com/users/gaocegege/gists{/gist_id}","starred_url":"https://api.github.com/users/gaocegege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaocegege/subscriptions","organizations_url":"https://api.github.com/users/gaocegege/orgs","repos_url":"https://api.github.com/users/gaocegege/repos","events_url":"https://api.github.com/users/gaocegege/events{/privacy}","received_events_url":"https://api.github.com/users/gaocegege/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T05:02:23Z","updated_at":"2018-04-26T05:02:23Z","author_association":"MEMBER","body":"I think so, but I am not sure if we are on the same page. It seems that we all think that it is not what we want.\r\n\r\nClosing it."}}
{"actor":{"display_login":"gaocegege"}}