{"action":"created","issue":{"url":"https://api.github.com/repos/ably/ably-js/issues/229","repository_url":"https://api.github.com/repos/ably/ably-js","labels_url":"https://api.github.com/repos/ably/ably-js/issues/229/labels{/name}","comments_url":"https://api.github.com/repos/ably/ably-js/issues/229/comments","events_url":"https://api.github.com/repos/ably/ably-js/issues/229/events","html_url":"https://github.com/ably/ably-js/pull/229","id":130809419,"number":229,"title":"Ie8 10 test suite fixes","user":{"login":"mattheworiordan","id":43789,"avatar_url":"https://avatars3.githubusercontent.com/u/43789?v=4","gravatar_id":"","url":"https://api.github.com/users/mattheworiordan","html_url":"https://github.com/mattheworiordan","followers_url":"https://api.github.com/users/mattheworiordan/followers","following_url":"https://api.github.com/users/mattheworiordan/following{/other_user}","gists_url":"https://api.github.com/users/mattheworiordan/gists{/gist_id}","starred_url":"https://api.github.com/users/mattheworiordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattheworiordan/subscriptions","organizations_url":"https://api.github.com/users/mattheworiordan/orgs","repos_url":"https://api.github.com/users/mattheworiordan/repos","events_url":"https://api.github.com/users/mattheworiordan/events{/privacy}","received_events_url":"https://api.github.com/users/mattheworiordan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2016-02-02T20:35:26Z","updated_at":"2018-03-01T14:54:44Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/ably/ably-js/pulls/229","html_url":"https://github.com/ably/ably-js/pull/229","diff_url":"https://github.com/ably/ably-js/pull/229.diff","patch_url":"https://github.com/ably/ably-js/pull/229.patch"},"body":"This PR in response to discussion with @SimonWoolf on failing parts of the test suite cross-browser.\n\n>  Had a look at some runs of browsers-all. Failures can be divided into:\n> - Random http timeouts. Saucelabs internet connection seems to be occasionally flakey, and any of the VMs (inc firefox and chrome) sometimes get random timeouts with comet requests.\n\nOk, not sure we can do much about this.\n\n> - Systematic saucelabs-only internet failures. Eg:\n> - for IE9 and 9, the first attempt to set up an app (which happens to be the realtime auth tests) pretty much always times out, resulting in those tests all failing. Subsequent attempts succeed.\n\nI hope I have fixed this by adding a retry into the app setup, 7a627c4\n\n> - IE10 is almost the opposite: after 50 or so successful tests, starting usually somewhere the early channel tests the VM seems to stop being able to connect to ably in any way. All subsequent tests timeout.\n>   (I've fired up local IE 9 and 10 virtual machines and double-checked that the test suite passes in both).\n\nI've tried this in Saucelabs now with db56a1e and this appears to not be an issue now.  This also covers some of https://github.com/ably/ably-js/issues/211 although my commits are only aimed at fixing the tests.\n\n> I spent some time trying to debug the IE10 one back when I did IE10, without success.\n> Not really sure what to suggest tbh. Reliable cross-browser testing is something we're going to have to have eventually.(edited)\n> OK -- I should stop darkly hinting that this is because saucelabs sucks, because I've just tried with testingbot, and got the same results, for both IE10 and IE8/9.\n> - The IE10 problem (`network error 0x2ee4`) appears to be a bug in IE10 triggered by saucelabs/testingbot's use of a network proxy, which is why I'm not seeing it locally. Was reported to MS, closed as \"fixed in latest version\" (ie IE11) , which is unhelpful. (https://connect.microsoft.com/IE/feedback/details/852785/ie10-network-error-0x2ee4-https-proxy-ajax).\n\nOk, this may now be fixed in this PR\n\n> The IE8/9 problem seems to only happen the first time the page is loaded after the VM is created. On subsequent page refeshes (even if cache cleared, 'always refresh from server' ticked etc.) it works fine; which is why I couldn't recreate it in my local VM.\n\nAs above, may now be fixed.\n\ncc @SimonWoolf @paddybyers \n"},"comment":{"url":"https://api.github.com/repos/ably/ably-js/issues/comments/369616855","html_url":"https://github.com/ably/ably-js/pull/229#issuecomment-369616855","issue_url":"https://api.github.com/repos/ably/ably-js/issues/229","id":369616855,"user":{"login":"SimonWoolf","id":5908687,"avatar_url":"https://avatars1.githubusercontent.com/u/5908687?v=4","gravatar_id":"","url":"https://api.github.com/users/SimonWoolf","html_url":"https://github.com/SimonWoolf","followers_url":"https://api.github.com/users/SimonWoolf/followers","following_url":"https://api.github.com/users/SimonWoolf/following{/other_user}","gists_url":"https://api.github.com/users/SimonWoolf/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonWoolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonWoolf/subscriptions","organizations_url":"https://api.github.com/users/SimonWoolf/orgs","repos_url":"https://api.github.com/users/SimonWoolf/repos","events_url":"https://api.github.com/users/SimonWoolf/events{/privacy}","received_events_url":"https://api.github.com/users/SimonWoolf/received_events","type":"User","site_admin":false},"created_at":"2018-03-01T14:54:44Z","updated_at":"2018-03-01T14:54:44Z","author_association":"OWNER","body":"@funkyboy Thanks -- I look forward to your PR fixing all those bugs :slightly_smiling_face: "}}
{"actor":{"display_login":"SimonWoolf"}}