{"action":"created","comment":{"url":"https://api.github.com/repos/istio/proxy/pulls/comments/181176370","pull_request_review_id":111737422,"id":181176370,"diff_hunk":"@@ -28,6 +28,7 @@ const char AttributeName::kRequestPath[] = \"request.path\";\n const char AttributeName::kRequestReferer[] = \"request.referer\";\n const char AttributeName::kRequestScheme[] = \"request.scheme\";\n const char AttributeName::kRequestSize[] = \"request.size\";\n+const char AttributeName::kReceivedBytes[] = \"received.bytes\";","path":"src/istio/control/attribute_names.cc","position":4,"original_position":4,"commit_id":"9f71a81e696841b787562ed0e86071442da5eee1","original_commit_id":"fbaaa4b3e16d374f196900b038ef55ab17e5dc46","user":{"login":"douglas-reid","id":21148125,"avatar_url":"https://avatars3.githubusercontent.com/u/21148125?v=4","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false},"body":"@qiwzhang `request.total_size` and `response.total_size` sgtm.","created_at":"2018-04-12T18:19:09Z","updated_at":"2018-04-12T18:19:09Z","html_url":"https://github.com/istio/proxy/pull/1372#discussion_r181176370","pull_request_url":"https://api.github.com/repos/istio/proxy/pulls/1372","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/proxy/pulls/comments/181176370"},"html":{"href":"https://github.com/istio/proxy/pull/1372#discussion_r181176370"},"pull_request":{"href":"https://api.github.com/repos/istio/proxy/pulls/1372"}},"in_reply_to_id":180165639},"pull_request":{"url":"https://api.github.com/repos/istio/proxy/pulls/1372","id":180140338,"html_url":"https://github.com/istio/proxy/pull/1372","diff_url":"https://github.com/istio/proxy/pull/1372.diff","patch_url":"https://github.com/istio/proxy/pull/1372.patch","issue_url":"https://api.github.com/repos/istio/proxy/issues/1372","number":1372,"state":"open","locked":false,"title":"Support Mixer HTTP filter to report sent.bytes and received.bytes attributes","user":{"login":"JimmyCYJ","id":28548492,"avatar_url":"https://avatars0.githubusercontent.com/u/28548492?v=4","gravatar_id":"","url":"https://api.github.com/users/JimmyCYJ","html_url":"https://github.com/JimmyCYJ","followers_url":"https://api.github.com/users/JimmyCYJ/followers","following_url":"https://api.github.com/users/JimmyCYJ/following{/other_user}","gists_url":"https://api.github.com/users/JimmyCYJ/gists{/gist_id}","starred_url":"https://api.github.com/users/JimmyCYJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimmyCYJ/subscriptions","organizations_url":"https://api.github.com/users/JimmyCYJ/orgs","repos_url":"https://api.github.com/users/JimmyCYJ/repos","events_url":"https://api.github.com/users/JimmyCYJ/events{/privacy}","received_events_url":"https://api.github.com/users/JimmyCYJ/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:Support Mixer HTTP filter to send attributes \"sent.bytes\" and \"received.bytes\" in Report() calls. \"sent.bytes\" records total response sent in bytes, including response headers, body, and trailers. \"received.bytes\" records total request received in bytes, including request headers, body, and trailers.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #1370 \r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2018-04-08T05:10:31Z","updated_at":"2018-04-12T18:19:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a27e9843dcaacd6a4875d2a36a02df2dd3a048a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mandarjog","id":800375,"avatar_url":"https://avatars2.githubusercontent.com/u/800375?v=4","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":712050392,"url":"https://api.github.com/repos/istio/proxy/labels/cla:%20yes","name":"cla: yes","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/proxy/pulls/1372/commits","review_comments_url":"https://api.github.com/repos/istio/proxy/pulls/1372/comments","review_comment_url":"https://api.github.com/repos/istio/proxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/proxy/issues/1372/comments","statuses_url":"https://api.github.com/repos/istio/proxy/statuses/9f71a81e696841b787562ed0e86071442da5eee1","head":{"label":"JimmyCYJ:add-attribute-sent-bytes-received-bytes","ref":"add-attribute-sent-bytes-received-bytes","sha":"9f71a81e696841b787562ed0e86071442da5eee1","user":{"login":"JimmyCYJ","id":28548492,"avatar_url":"https://avatars0.githubusercontent.com/u/28548492?v=4","gravatar_id":"","url":"https://api.github.com/users/JimmyCYJ","html_url":"https://github.com/JimmyCYJ","followers_url":"https://api.github.com/users/JimmyCYJ/followers","following_url":"https://api.github.com/users/JimmyCYJ/following{/other_user}","gists_url":"https://api.github.com/users/JimmyCYJ/gists{/gist_id}","starred_url":"https://api.github.com/users/JimmyCYJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimmyCYJ/subscriptions","organizations_url":"https://api.github.com/users/JimmyCYJ/orgs","repos_url":"https://api.github.com/users/JimmyCYJ/repos","events_url":"https://api.github.com/users/JimmyCYJ/events{/privacy}","received_events_url":"https://api.github.com/users/JimmyCYJ/received_events","type":"User","site_admin":false},"repo":{"id":112794018,"name":"proxy","full_name":"JimmyCYJ/proxy","owner":{"login":"JimmyCYJ","id":28548492,"avatar_url":"https://avatars0.githubusercontent.com/u/28548492?v=4","gravatar_id":"","url":"https://api.github.com/users/JimmyCYJ","html_url":"https://github.com/JimmyCYJ","followers_url":"https://api.github.com/users/JimmyCYJ/followers","following_url":"https://api.github.com/users/JimmyCYJ/following{/other_user}","gists_url":"https://api.github.com/users/JimmyCYJ/gists{/gist_id}","starred_url":"https://api.github.com/users/JimmyCYJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimmyCYJ/subscriptions","organizations_url":"https://api.github.com/users/JimmyCYJ/orgs","repos_url":"https://api.github.com/users/JimmyCYJ/repos","events_url":"https://api.github.com/users/JimmyCYJ/events{/privacy}","received_events_url":"https://api.github.com/users/JimmyCYJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JimmyCYJ/proxy","description":"The Istio proxy components.","fork":true,"url":"https://api.github.com/repos/JimmyCYJ/proxy","forks_url":"https://api.github.com/repos/JimmyCYJ/proxy/forks","keys_url":"https://api.github.com/repos/JimmyCYJ/proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JimmyCYJ/proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JimmyCYJ/proxy/teams","hooks_url":"https://api.github.com/repos/JimmyCYJ/proxy/hooks","issue_events_url":"https://api.github.com/repos/JimmyCYJ/proxy/issues/events{/number}","events_url":"https://api.github.com/repos/JimmyCYJ/proxy/events","assignees_url":"https://api.github.com/repos/JimmyCYJ/proxy/assignees{/user}","branches_url":"https://api.github.com/repos/JimmyCYJ/proxy/branches{/branch}","tags_url":"https://api.github.com/repos/JimmyCYJ/proxy/tags","blobs_url":"https://api.github.com/repos/JimmyCYJ/proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JimmyCYJ/proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JimmyCYJ/proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/JimmyCYJ/proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JimmyCYJ/proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/JimmyCYJ/proxy/languages","stargazers_url":"https://api.github.com/repos/JimmyCYJ/proxy/stargazers","contributors_url":"https://api.github.com/repos/JimmyCYJ/proxy/contributors","subscribers_url":"https://api.github.com/repos/JimmyCYJ/proxy/subscribers","subscription_url":"https://api.github.com/repos/JimmyCYJ/proxy/subscription","commits_url":"https://api.github.com/repos/JimmyCYJ/proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/JimmyCYJ/proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/JimmyCYJ/proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/JimmyCYJ/proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/JimmyCYJ/proxy/contents/{+path}","compare_url":"https://api.github.com/repos/JimmyCYJ/proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JimmyCYJ/proxy/merges","archive_url":"https://api.github.com/repos/JimmyCYJ/proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JimmyCYJ/proxy/downloads","issues_url":"https://api.github.com/repos/JimmyCYJ/proxy/issues{/number}","pulls_url":"https://api.github.com/repos/JimmyCYJ/proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/JimmyCYJ/proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/JimmyCYJ/proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JimmyCYJ/proxy/labels{/name}","releases_url":"https://api.github.com/repos/JimmyCYJ/proxy/releases{/id}","deployments_url":"https://api.github.com/repos/JimmyCYJ/proxy/deployments","created_at":"2017-12-01T22:42:44Z","updated_at":"2017-12-01T22:42:46Z","pushed_at":"2018-04-10T01:23:58Z","git_url":"git://github.com/JimmyCYJ/proxy.git","ssh_url":"git@github.com:JimmyCYJ/proxy.git","clone_url":"https://github.com/JimmyCYJ/proxy.git","svn_url":"https://github.com/JimmyCYJ/proxy","homepage":"","size":2401,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"e562a1b090e6d2cd73e321323d687af1315a4056","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":75322405,"name":"proxy","full_name":"istio/proxy","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/proxy","description":"The Istio proxy components.","fork":false,"url":"https://api.github.com/repos/istio/proxy","forks_url":"https://api.github.com/repos/istio/proxy/forks","keys_url":"https://api.github.com/repos/istio/proxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/proxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/proxy/teams","hooks_url":"https://api.github.com/repos/istio/proxy/hooks","issue_events_url":"https://api.github.com/repos/istio/proxy/issues/events{/number}","events_url":"https://api.github.com/repos/istio/proxy/events","assignees_url":"https://api.github.com/repos/istio/proxy/assignees{/user}","branches_url":"https://api.github.com/repos/istio/proxy/branches{/branch}","tags_url":"https://api.github.com/repos/istio/proxy/tags","blobs_url":"https://api.github.com/repos/istio/proxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/proxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/proxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/proxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/proxy/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/proxy/languages","stargazers_url":"https://api.github.com/repos/istio/proxy/stargazers","contributors_url":"https://api.github.com/repos/istio/proxy/contributors","subscribers_url":"https://api.github.com/repos/istio/proxy/subscribers","subscription_url":"https://api.github.com/repos/istio/proxy/subscription","commits_url":"https://api.github.com/repos/istio/proxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/proxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/proxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/proxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/proxy/contents/{+path}","compare_url":"https://api.github.com/repos/istio/proxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/proxy/merges","archive_url":"https://api.github.com/repos/istio/proxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/proxy/downloads","issues_url":"https://api.github.com/repos/istio/proxy/issues{/number}","pulls_url":"https://api.github.com/repos/istio/proxy/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/proxy/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/proxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/proxy/labels{/name}","releases_url":"https://api.github.com/repos/istio/proxy/releases{/id}","deployments_url":"https://api.github.com/repos/istio/proxy/deployments","created_at":"2016-12-01T18:51:04Z","updated_at":"2018-04-11T18:23:49Z","pushed_at":"2018-04-12T17:54:52Z","git_url":"git://github.com/istio/proxy.git","ssh_url":"git@github.com:istio/proxy.git","clone_url":"https://github.com/istio/proxy.git","svn_url":"https://github.com/istio/proxy","homepage":"","size":2384,"stargazers_count":121,"watchers_count":121,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":87,"open_issues":35,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/proxy/pulls/1372"},"html":{"href":"https://github.com/istio/proxy/pull/1372"},"issue":{"href":"https://api.github.com/repos/istio/proxy/issues/1372"},"comments":{"href":"https://api.github.com/repos/istio/proxy/issues/1372/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/proxy/pulls/1372/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/proxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/proxy/pulls/1372/commits"},"statuses":{"href":"https://api.github.com/repos/istio/proxy/statuses/9f71a81e696841b787562ed0e86071442da5eee1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"douglas-reid"}}