{"action":"created","comment":{"url":"https://api.github.com/repos/phalcon/cphalcon/pulls/comments/208720275","pull_request_review_id":144589785,"id":208720275,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODcyMDI3NQ==","diff_hunk":"@@ -71,7 +71,7 @@ class Numericality extends Validator\n \n \t\tlet value = validation->getValue(field);\n \n-\t\tif !preg_match(\"/^-?\\d+\\.?\\d*$/\", value) {\n+\t\tif !preg_match(\"/^-?\\d+[\\.,]?\\d*$/\", value) || !is_numeric(value) {","path":"phalcon/validation/validator/numericality.zep","position":5,"original_position":5,"commit_id":"c1ec28ed21eb9d9e142efe0d643db04ca9681481","original_commit_id":"c1ec28ed21eb9d9e142efe0d643db04ca9681481","user":{"login":"virgofx","id":739719,"node_id":"MDQ6VXNlcjczOTcxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/739719?v=4","gravatar_id":"","url":"https://api.github.com/users/virgofx","html_url":"https://github.com/virgofx","followers_url":"https://api.github.com/users/virgofx/followers","following_url":"https://api.github.com/users/virgofx/following{/other_user}","gists_url":"https://api.github.com/users/virgofx/gists{/gist_id}","starred_url":"https://api.github.com/users/virgofx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virgofx/subscriptions","organizations_url":"https://api.github.com/users/virgofx/orgs","repos_url":"https://api.github.com/users/virgofx/repos","events_url":"https://api.github.com/users/virgofx/events{/privacy}","received_events_url":"https://api.github.com/users/virgofx/received_events","type":"User","site_admin":false},"body":"It appears that `is_numeric()` covers everything in the regular expression and more. So yeah .. we should just straight proxy ... I think that's the best solution.","created_at":"2018-08-08T20:16:10Z","updated_at":"2018-08-08T20:16:10Z","html_url":"https://github.com/phalcon/cphalcon/pull/13457#discussion_r208720275","pull_request_url":"https://api.github.com/repos/phalcon/cphalcon/pulls/13457","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/comments/208720275"},"html":{"href":"https://github.com/phalcon/cphalcon/pull/13457#discussion_r208720275"},"pull_request":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/13457"}},"in_reply_to_id":207244131},"pull_request":{"url":"https://api.github.com/repos/phalcon/cphalcon/pulls/13457","id":205720952,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NzIwOTUy","html_url":"https://github.com/phalcon/cphalcon/pull/13457","diff_url":"https://github.com/phalcon/cphalcon/pull/13457.diff","patch_url":"https://github.com/phalcon/cphalcon/pull/13457.patch","issue_url":"https://api.github.com/repos/phalcon/cphalcon/issues/13457","number":13457,"state":"open","locked":false,"title":"Fix issue with validation on locales where comma used","user":{"login":"mervick","id":2429298,"node_id":"MDQ6VXNlcjI0MjkyOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2429298?v=4","gravatar_id":"","url":"https://api.github.com/users/mervick","html_url":"https://github.com/mervick","followers_url":"https://api.github.com/users/mervick/followers","following_url":"https://api.github.com/users/mervick/following{/other_user}","gists_url":"https://api.github.com/users/mervick/gists{/gist_id}","starred_url":"https://api.github.com/users/mervick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mervick/subscriptions","organizations_url":"https://api.github.com/users/mervick/orgs","repos_url":"https://api.github.com/users/mervick/repos","events_url":"https://api.github.com/users/mervick/events{/privacy}","received_events_url":"https://api.github.com/users/mervick/received_events","type":"User","site_admin":false},"body":"fix https://github.com/phalcon/cphalcon/issues/13450\r\n\r\nHello!\r\n\r\n* Type: bug fix\r\n* Link to issue: https://github.com/phalcon/cphalcon/issues/13450\r\n\r\n**In raising this pull request, I confirm the following (please check boxes):**\r\n\r\n- [X] I have read and understood the [Contributing Guidelines](https://github.com/phalcon/cphalcon/blob/master/CONTRIBUTING.md)?\r\n- [X] I have checked that another pull request for this purpose does not exist.\r\n- [ ] I wrote some tests for this PR.\r\n\r\nThanks\r\n\r\n","created_at":"2018-08-02T12:42:00Z","updated_at":"2018-08-08T20:16:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a0bbdf93fa5137f27a6a0e5722cd24dc7cdacae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/phalcon/cphalcon/pulls/13457/commits","review_comments_url":"https://api.github.com/repos/phalcon/cphalcon/pulls/13457/comments","review_comment_url":"https://api.github.com/repos/phalcon/cphalcon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phalcon/cphalcon/issues/13457/comments","statuses_url":"https://api.github.com/repos/phalcon/cphalcon/statuses/c1ec28ed21eb9d9e142efe0d643db04ca9681481","head":{"label":"mervick:3.4.x","ref":"3.4.x","sha":"c1ec28ed21eb9d9e142efe0d643db04ca9681481","user":{"login":"mervick","id":2429298,"node_id":"MDQ6VXNlcjI0MjkyOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2429298?v=4","gravatar_id":"","url":"https://api.github.com/users/mervick","html_url":"https://github.com/mervick","followers_url":"https://api.github.com/users/mervick/followers","following_url":"https://api.github.com/users/mervick/following{/other_user}","gists_url":"https://api.github.com/users/mervick/gists{/gist_id}","starred_url":"https://api.github.com/users/mervick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mervick/subscriptions","organizations_url":"https://api.github.com/users/mervick/orgs","repos_url":"https://api.github.com/users/mervick/repos","events_url":"https://api.github.com/users/mervick/events{/privacy}","received_events_url":"https://api.github.com/users/mervick/received_events","type":"User","site_admin":false},"repo":{"id":143291900,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMyOTE5MDA=","name":"cphalcon","full_name":"mervick/cphalcon","owner":{"login":"mervick","id":2429298,"node_id":"MDQ6VXNlcjI0MjkyOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2429298?v=4","gravatar_id":"","url":"https://api.github.com/users/mervick","html_url":"https://github.com/mervick","followers_url":"https://api.github.com/users/mervick/followers","following_url":"https://api.github.com/users/mervick/following{/other_user}","gists_url":"https://api.github.com/users/mervick/gists{/gist_id}","starred_url":"https://api.github.com/users/mervick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mervick/subscriptions","organizations_url":"https://api.github.com/users/mervick/orgs","repos_url":"https://api.github.com/users/mervick/repos","events_url":"https://api.github.com/users/mervick/events{/privacy}","received_events_url":"https://api.github.com/users/mervick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mervick/cphalcon","description":"High performance, full-stack PHP framework delivered as a C extension.","fork":true,"url":"https://api.github.com/repos/mervick/cphalcon","forks_url":"https://api.github.com/repos/mervick/cphalcon/forks","keys_url":"https://api.github.com/repos/mervick/cphalcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mervick/cphalcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mervick/cphalcon/teams","hooks_url":"https://api.github.com/repos/mervick/cphalcon/hooks","issue_events_url":"https://api.github.com/repos/mervick/cphalcon/issues/events{/number}","events_url":"https://api.github.com/repos/mervick/cphalcon/events","assignees_url":"https://api.github.com/repos/mervick/cphalcon/assignees{/user}","branches_url":"https://api.github.com/repos/mervick/cphalcon/branches{/branch}","tags_url":"https://api.github.com/repos/mervick/cphalcon/tags","blobs_url":"https://api.github.com/repos/mervick/cphalcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mervick/cphalcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mervick/cphalcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/mervick/cphalcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mervick/cphalcon/statuses/{sha}","languages_url":"https://api.github.com/repos/mervick/cphalcon/languages","stargazers_url":"https://api.github.com/repos/mervick/cphalcon/stargazers","contributors_url":"https://api.github.com/repos/mervick/cphalcon/contributors","subscribers_url":"https://api.github.com/repos/mervick/cphalcon/subscribers","subscription_url":"https://api.github.com/repos/mervick/cphalcon/subscription","commits_url":"https://api.github.com/repos/mervick/cphalcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/mervick/cphalcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/mervick/cphalcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/mervick/cphalcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/mervick/cphalcon/contents/{+path}","compare_url":"https://api.github.com/repos/mervick/cphalcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mervick/cphalcon/merges","archive_url":"https://api.github.com/repos/mervick/cphalcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mervick/cphalcon/downloads","issues_url":"https://api.github.com/repos/mervick/cphalcon/issues{/number}","pulls_url":"https://api.github.com/repos/mervick/cphalcon/pulls{/number}","milestones_url":"https://api.github.com/repos/mervick/cphalcon/milestones{/number}","notifications_url":"https://api.github.com/repos/mervick/cphalcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mervick/cphalcon/labels{/name}","releases_url":"https://api.github.com/repos/mervick/cphalcon/releases{/id}","deployments_url":"https://api.github.com/repos/mervick/cphalcon/deployments","created_at":"2018-08-02T12:30:31Z","updated_at":"2018-08-02T12:30:37Z","pushed_at":"2018-08-08T06:30:20Z","git_url":"git://github.com/mervick/cphalcon.git","ssh_url":"git@github.com:mervick/cphalcon.git","clone_url":"https://github.com/mervick/cphalcon.git","svn_url":"https://github.com/mervick/cphalcon","homepage":"https://phalconphp.com","size":148341,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phalcon:3.4.x","ref":"3.4.x","sha":"3513faca14fa4d8e2e0f5f0650fa842b827f679a","user":{"login":"phalcon","id":1221505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjE1MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1221505?v=4","gravatar_id":"","url":"https://api.github.com/users/phalcon","html_url":"https://github.com/phalcon","followers_url":"https://api.github.com/users/phalcon/followers","following_url":"https://api.github.com/users/phalcon/following{/other_user}","gists_url":"https://api.github.com/users/phalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/phalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phalcon/subscriptions","organizations_url":"https://api.github.com/users/phalcon/orgs","repos_url":"https://api.github.com/users/phalcon/repos","events_url":"https://api.github.com/users/phalcon/events{/privacy}","received_events_url":"https://api.github.com/users/phalcon/received_events","type":"Organization","site_admin":false},"repo":{"id":2854337,"node_id":"MDEwOlJlcG9zaXRvcnkyODU0MzM3","name":"cphalcon","full_name":"phalcon/cphalcon","owner":{"login":"phalcon","id":1221505,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMjE1MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1221505?v=4","gravatar_id":"","url":"https://api.github.com/users/phalcon","html_url":"https://github.com/phalcon","followers_url":"https://api.github.com/users/phalcon/followers","following_url":"https://api.github.com/users/phalcon/following{/other_user}","gists_url":"https://api.github.com/users/phalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/phalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phalcon/subscriptions","organizations_url":"https://api.github.com/users/phalcon/orgs","repos_url":"https://api.github.com/users/phalcon/repos","events_url":"https://api.github.com/users/phalcon/events{/privacy}","received_events_url":"https://api.github.com/users/phalcon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phalcon/cphalcon","description":"High performance, full-stack PHP framework delivered as a C extension.","fork":false,"url":"https://api.github.com/repos/phalcon/cphalcon","forks_url":"https://api.github.com/repos/phalcon/cphalcon/forks","keys_url":"https://api.github.com/repos/phalcon/cphalcon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phalcon/cphalcon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phalcon/cphalcon/teams","hooks_url":"https://api.github.com/repos/phalcon/cphalcon/hooks","issue_events_url":"https://api.github.com/repos/phalcon/cphalcon/issues/events{/number}","events_url":"https://api.github.com/repos/phalcon/cphalcon/events","assignees_url":"https://api.github.com/repos/phalcon/cphalcon/assignees{/user}","branches_url":"https://api.github.com/repos/phalcon/cphalcon/branches{/branch}","tags_url":"https://api.github.com/repos/phalcon/cphalcon/tags","blobs_url":"https://api.github.com/repos/phalcon/cphalcon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phalcon/cphalcon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phalcon/cphalcon/git/refs{/sha}","trees_url":"https://api.github.com/repos/phalcon/cphalcon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phalcon/cphalcon/statuses/{sha}","languages_url":"https://api.github.com/repos/phalcon/cphalcon/languages","stargazers_url":"https://api.github.com/repos/phalcon/cphalcon/stargazers","contributors_url":"https://api.github.com/repos/phalcon/cphalcon/contributors","subscribers_url":"https://api.github.com/repos/phalcon/cphalcon/subscribers","subscription_url":"https://api.github.com/repos/phalcon/cphalcon/subscription","commits_url":"https://api.github.com/repos/phalcon/cphalcon/commits{/sha}","git_commits_url":"https://api.github.com/repos/phalcon/cphalcon/git/commits{/sha}","comments_url":"https://api.github.com/repos/phalcon/cphalcon/comments{/number}","issue_comment_url":"https://api.github.com/repos/phalcon/cphalcon/issues/comments{/number}","contents_url":"https://api.github.com/repos/phalcon/cphalcon/contents/{+path}","compare_url":"https://api.github.com/repos/phalcon/cphalcon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phalcon/cphalcon/merges","archive_url":"https://api.github.com/repos/phalcon/cphalcon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phalcon/cphalcon/downloads","issues_url":"https://api.github.com/repos/phalcon/cphalcon/issues{/number}","pulls_url":"https://api.github.com/repos/phalcon/cphalcon/pulls{/number}","milestones_url":"https://api.github.com/repos/phalcon/cphalcon/milestones{/number}","notifications_url":"https://api.github.com/repos/phalcon/cphalcon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phalcon/cphalcon/labels{/name}","releases_url":"https://api.github.com/repos/phalcon/cphalcon/releases{/id}","deployments_url":"https://api.github.com/repos/phalcon/cphalcon/deployments","created_at":"2011-11-26T05:52:50Z","updated_at":"2018-08-08T11:18:40Z","pushed_at":"2018-08-06T06:24:49Z","git_url":"git://github.com/phalcon/cphalcon.git","ssh_url":"git@github.com:phalcon/cphalcon.git","clone_url":"https://github.com/phalcon/cphalcon.git","svn_url":"https://github.com/phalcon/cphalcon","homepage":"https://phalconphp.com","size":148799,"stargazers_count":9095,"watchers_count":9095,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1693,"mirror_url":null,"archived":false,"open_issues_count":203,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1693,"open_issues":203,"watchers":9095,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/13457"},"html":{"href":"https://github.com/phalcon/cphalcon/pull/13457"},"issue":{"href":"https://api.github.com/repos/phalcon/cphalcon/issues/13457"},"comments":{"href":"https://api.github.com/repos/phalcon/cphalcon/issues/13457/comments"},"review_comments":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/13457/comments"},"review_comment":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phalcon/cphalcon/pulls/13457/commits"},"statuses":{"href":"https://api.github.com/repos/phalcon/cphalcon/statuses/c1ec28ed21eb9d9e142efe0d643db04ca9681481"}},"author_association":"NONE"}}
{"actor":{"display_login":"virgofx"}}