{"action":"closed","number":714,"pull_request":{"url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/714","id":224397429,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0Mzk3NDI5","html_url":"https://github.com/ROCm-Developer-Tools/HIP/pull/714","diff_url":"https://github.com/ROCm-Developer-Tools/HIP/pull/714.diff","patch_url":"https://github.com/ROCm-Developer-Tools/HIP/pull/714.patch","issue_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/issues/714","number":714,"state":"closed","locked":false,"title":"Remove libhip_device.a static library","user":{"login":"aaronenyeshi","id":17602366,"node_id":"MDQ6VXNlcjE3NjAyMzY2","avatar_url":"https://avatars2.githubusercontent.com/u/17602366?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronenyeshi","html_url":"https://github.com/aaronenyeshi","followers_url":"https://api.github.com/users/aaronenyeshi/followers","following_url":"https://api.github.com/users/aaronenyeshi/following{/other_user}","gists_url":"https://api.github.com/users/aaronenyeshi/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronenyeshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronenyeshi/subscriptions","organizations_url":"https://api.github.com/users/aaronenyeshi/orgs","repos_url":"https://api.github.com/users/aaronenyeshi/repos","events_url":"https://api.github.com/users/aaronenyeshi/events{/privacy}","received_events_url":"https://api.github.com/users/aaronenyeshi/received_events","type":"User","site_admin":false},"body":"Move remaining function definitions from device_util.cpp to hip_runtime.h header. We can now remove the static library completely as device_util.cpp was the last file part of target hip::hip_device .\r\n\r\nIn this PR, I'm removing the device_util.cpp and associated links. Removing the hip:hip_device target, and also the package creation of libhip_device.a static lib.","created_at":"2018-10-19T20:10:06Z","updated_at":"2018-10-31T08:38:30Z","closed_at":"2018-10-31T08:38:30Z","merged_at":"2018-10-31T08:38:30Z","merge_commit_sha":"0b86b421c1aa6f999daf3608dd70f9c61720de8b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mangupta","id":14296582,"node_id":"MDQ6VXNlcjE0Mjk2NTgy","avatar_url":"https://avatars2.githubusercontent.com/u/14296582?v=4","gravatar_id":"","url":"https://api.github.com/users/mangupta","html_url":"https://github.com/mangupta","followers_url":"https://api.github.com/users/mangupta/followers","following_url":"https://api.github.com/users/mangupta/following{/other_user}","gists_url":"https://api.github.com/users/mangupta/gists{/gist_id}","starred_url":"https://api.github.com/users/mangupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mangupta/subscriptions","organizations_url":"https://api.github.com/users/mangupta/orgs","repos_url":"https://api.github.com/users/mangupta/repos","events_url":"https://api.github.com/users/mangupta/events{/privacy}","received_events_url":"https://api.github.com/users/mangupta/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/714/commits","review_comments_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/714/comments","review_comment_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/issues/714/comments","statuses_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/statuses/817b27d5306da56ddf7c8fe5438289261d595a41","head":{"label":"aaronenyeshi:remove-static-hip-device","ref":"remove-static-hip-device","sha":"817b27d5306da56ddf7c8fe5438289261d595a41","user":{"login":"aaronenyeshi","id":17602366,"node_id":"MDQ6VXNlcjE3NjAyMzY2","avatar_url":"https://avatars2.githubusercontent.com/u/17602366?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronenyeshi","html_url":"https://github.com/aaronenyeshi","followers_url":"https://api.github.com/users/aaronenyeshi/followers","following_url":"https://api.github.com/users/aaronenyeshi/following{/other_user}","gists_url":"https://api.github.com/users/aaronenyeshi/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronenyeshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronenyeshi/subscriptions","organizations_url":"https://api.github.com/users/aaronenyeshi/orgs","repos_url":"https://api.github.com/users/aaronenyeshi/repos","events_url":"https://api.github.com/users/aaronenyeshi/events{/privacy}","received_events_url":"https://api.github.com/users/aaronenyeshi/received_events","type":"User","site_admin":false},"repo":{"id":102876411,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI4NzY0MTE=","name":"HIP","full_name":"aaronenyeshi/HIP","private":false,"owner":{"login":"aaronenyeshi","id":17602366,"node_id":"MDQ6VXNlcjE3NjAyMzY2","avatar_url":"https://avatars2.githubusercontent.com/u/17602366?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronenyeshi","html_url":"https://github.com/aaronenyeshi","followers_url":"https://api.github.com/users/aaronenyeshi/followers","following_url":"https://api.github.com/users/aaronenyeshi/following{/other_user}","gists_url":"https://api.github.com/users/aaronenyeshi/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronenyeshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronenyeshi/subscriptions","organizations_url":"https://api.github.com/users/aaronenyeshi/orgs","repos_url":"https://api.github.com/users/aaronenyeshi/repos","events_url":"https://api.github.com/users/aaronenyeshi/events{/privacy}","received_events_url":"https://api.github.com/users/aaronenyeshi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aaronenyeshi/HIP","description":"HIP : Convert CUDA to Portable C++ Code","fork":true,"url":"https://api.github.com/repos/aaronenyeshi/HIP","forks_url":"https://api.github.com/repos/aaronenyeshi/HIP/forks","keys_url":"https://api.github.com/repos/aaronenyeshi/HIP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaronenyeshi/HIP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaronenyeshi/HIP/teams","hooks_url":"https://api.github.com/repos/aaronenyeshi/HIP/hooks","issue_events_url":"https://api.github.com/repos/aaronenyeshi/HIP/issues/events{/number}","events_url":"https://api.github.com/repos/aaronenyeshi/HIP/events","assignees_url":"https://api.github.com/repos/aaronenyeshi/HIP/assignees{/user}","branches_url":"https://api.github.com/repos/aaronenyeshi/HIP/branches{/branch}","tags_url":"https://api.github.com/repos/aaronenyeshi/HIP/tags","blobs_url":"https://api.github.com/repos/aaronenyeshi/HIP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaronenyeshi/HIP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaronenyeshi/HIP/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaronenyeshi/HIP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaronenyeshi/HIP/statuses/{sha}","languages_url":"https://api.github.com/repos/aaronenyeshi/HIP/languages","stargazers_url":"https://api.github.com/repos/aaronenyeshi/HIP/stargazers","contributors_url":"https://api.github.com/repos/aaronenyeshi/HIP/contributors","subscribers_url":"https://api.github.com/repos/aaronenyeshi/HIP/subscribers","subscription_url":"https://api.github.com/repos/aaronenyeshi/HIP/subscription","commits_url":"https://api.github.com/repos/aaronenyeshi/HIP/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaronenyeshi/HIP/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaronenyeshi/HIP/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaronenyeshi/HIP/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaronenyeshi/HIP/contents/{+path}","compare_url":"https://api.github.com/repos/aaronenyeshi/HIP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaronenyeshi/HIP/merges","archive_url":"https://api.github.com/repos/aaronenyeshi/HIP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaronenyeshi/HIP/downloads","issues_url":"https://api.github.com/repos/aaronenyeshi/HIP/issues{/number}","pulls_url":"https://api.github.com/repos/aaronenyeshi/HIP/pulls{/number}","milestones_url":"https://api.github.com/repos/aaronenyeshi/HIP/milestones{/number}","notifications_url":"https://api.github.com/repos/aaronenyeshi/HIP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaronenyeshi/HIP/labels{/name}","releases_url":"https://api.github.com/repos/aaronenyeshi/HIP/releases{/id}","deployments_url":"https://api.github.com/repos/aaronenyeshi/HIP/deployments","created_at":"2017-09-08T15:31:17Z","updated_at":"2017-09-08T15:31:20Z","pushed_at":"2018-10-25T19:52:56Z","git_url":"git://github.com/aaronenyeshi/HIP.git","ssh_url":"git@github.com:aaronenyeshi/HIP.git","clone_url":"https://github.com/aaronenyeshi/HIP.git","svn_url":"https://github.com/aaronenyeshi/HIP","homepage":null,"size":7970,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ROCm-Developer-Tools:master","ref":"master","sha":"7c3cea210b91b67ef01654b0e1d04d86c691f8d4","user":{"login":"ROCm-Developer-Tools","id":16688128,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Njg4MTI4","avatar_url":"https://avatars0.githubusercontent.com/u/16688128?v=4","gravatar_id":"","url":"https://api.github.com/users/ROCm-Developer-Tools","html_url":"https://github.com/ROCm-Developer-Tools","followers_url":"https://api.github.com/users/ROCm-Developer-Tools/followers","following_url":"https://api.github.com/users/ROCm-Developer-Tools/following{/other_user}","gists_url":"https://api.github.com/users/ROCm-Developer-Tools/gists{/gist_id}","starred_url":"https://api.github.com/users/ROCm-Developer-Tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROCm-Developer-Tools/subscriptions","organizations_url":"https://api.github.com/users/ROCm-Developer-Tools/orgs","repos_url":"https://api.github.com/users/ROCm-Developer-Tools/repos","events_url":"https://api.github.com/users/ROCm-Developer-Tools/events{/privacy}","received_events_url":"https://api.github.com/users/ROCm-Developer-Tools/received_events","type":"Organization","site_admin":false},"repo":{"id":49220157,"node_id":"MDEwOlJlcG9zaXRvcnk0OTIyMDE1Nw==","name":"HIP","full_name":"ROCm-Developer-Tools/HIP","private":false,"owner":{"login":"ROCm-Developer-Tools","id":16688128,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Njg4MTI4","avatar_url":"https://avatars0.githubusercontent.com/u/16688128?v=4","gravatar_id":"","url":"https://api.github.com/users/ROCm-Developer-Tools","html_url":"https://github.com/ROCm-Developer-Tools","followers_url":"https://api.github.com/users/ROCm-Developer-Tools/followers","following_url":"https://api.github.com/users/ROCm-Developer-Tools/following{/other_user}","gists_url":"https://api.github.com/users/ROCm-Developer-Tools/gists{/gist_id}","starred_url":"https://api.github.com/users/ROCm-Developer-Tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ROCm-Developer-Tools/subscriptions","organizations_url":"https://api.github.com/users/ROCm-Developer-Tools/orgs","repos_url":"https://api.github.com/users/ROCm-Developer-Tools/repos","events_url":"https://api.github.com/users/ROCm-Developer-Tools/events{/privacy}","received_events_url":"https://api.github.com/users/ROCm-Developer-Tools/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ROCm-Developer-Tools/HIP","description":"HIP : Convert CUDA to Portable C++ Code","fork":false,"url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP","forks_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/forks","keys_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/teams","hooks_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/hooks","issue_events_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/issues/events{/number}","events_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/events","assignees_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/assignees{/user}","branches_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/branches{/branch}","tags_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/tags","blobs_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/git/refs{/sha}","trees_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/statuses/{sha}","languages_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/languages","stargazers_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/stargazers","contributors_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/contributors","subscribers_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/subscribers","subscription_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/subscription","commits_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/commits{/sha}","git_commits_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/git/commits{/sha}","comments_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/comments{/number}","issue_comment_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/issues/comments{/number}","contents_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/contents/{+path}","compare_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/merges","archive_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/downloads","issues_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/issues{/number}","pulls_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls{/number}","milestones_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/milestones{/number}","notifications_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/labels{/name}","releases_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/releases{/id}","deployments_url":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/deployments","created_at":"2016-01-07T17:41:56Z","updated_at":"2018-10-31T08:34:11Z","pushed_at":"2018-10-31T08:38:30Z","git_url":"git://github.com/ROCm-Developer-Tools/HIP.git","ssh_url":"git@github.com:ROCm-Developer-Tools/HIP.git","clone_url":"https://github.com/ROCm-Developer-Tools/HIP.git","svn_url":"https://github.com/ROCm-Developer-Tools/HIP","homepage":null,"size":8230,"stargazers_count":1495,"watchers_count":1495,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":199,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":199,"open_issues":81,"watchers":1495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/714"},"html":{"href":"https://github.com/ROCm-Developer-Tools/HIP/pull/714"},"issue":{"href":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/issues/714"},"comments":{"href":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/issues/714/comments"},"review_comments":{"href":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/714/comments"},"review_comment":{"href":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/pulls/714/commits"},"statuses":{"href":"https://api.github.com/repos/ROCm-Developer-Tools/HIP/statuses/817b27d5306da56ddf7c8fe5438289261d595a41"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mangupta","id":14296582,"node_id":"MDQ6VXNlcjE0Mjk2NTgy","avatar_url":"https://avatars2.githubusercontent.com/u/14296582?v=4","gravatar_id":"","url":"https://api.github.com/users/mangupta","html_url":"https://github.com/mangupta","followers_url":"https://api.github.com/users/mangupta/followers","following_url":"https://api.github.com/users/mangupta/following{/other_user}","gists_url":"https://api.github.com/users/mangupta/gists{/gist_id}","starred_url":"https://api.github.com/users/mangupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mangupta/subscriptions","organizations_url":"https://api.github.com/users/mangupta/orgs","repos_url":"https://api.github.com/users/mangupta/repos","events_url":"https://api.github.com/users/mangupta/events{/privacy}","received_events_url":"https://api.github.com/users/mangupta/received_events","type":"User","site_admin":false},"comments":6,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":23,"deletions":71,"changed_files":8}}
{"actor":{"display_login":"mangupta"}}