{"action":"created","issue":{"url":"https://api.github.com/repos/p4yl04d3r/blinds/issues/1","repository_url":"https://api.github.com/repos/p4yl04d3r/blinds","labels_url":"https://api.github.com/repos/p4yl04d3r/blinds/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/p4yl04d3r/blinds/issues/1/comments","events_url":"https://api.github.com/repos/p4yl04d3r/blinds/issues/1/events","html_url":"https://github.com/p4yl04d3r/blinds/issues/1","id":306671764,"number":1,"title":"Best Practices","user":{"login":"2delarosa","id":25567058,"avatar_url":"https://avatars0.githubusercontent.com/u/25567058?v=4","gravatar_id":"","url":"https://api.github.com/users/2delarosa","html_url":"https://github.com/2delarosa","followers_url":"https://api.github.com/users/2delarosa/followers","following_url":"https://api.github.com/users/2delarosa/following{/other_user}","gists_url":"https://api.github.com/users/2delarosa/gists{/gist_id}","starred_url":"https://api.github.com/users/2delarosa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2delarosa/subscriptions","organizations_url":"https://api.github.com/users/2delarosa/orgs","repos_url":"https://api.github.com/users/2delarosa/repos","events_url":"https://api.github.com/users/2delarosa/events{/privacy}","received_events_url":"https://api.github.com/users/2delarosa/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-19T23:12:14Z","updated_at":"2018-03-27T02:19:25Z","closed_at":null,"author_association":"NONE","body":"I like your designed and I'm about to deploy it.  I have several questions that I hope you can answer.  \r\n\r\n- Should the setting and status be different for each window?  The way you have it configured, it appears that all blinds are being controlled at the same time.  I'm sure there will be instances where one would want to control a subset of blinds (in a room or a particular blind).  Any suggestions?\r\n- The half setting appears to tilt the blind just slightly.  I can consistently open and close the blinds but not half tilt.  I know the servo doesn't read the position so I'm not quite sure if it is a software issue.\r\n-  The speed is fast but loud.  I'm wondering if you considered was slowing the speed like the following from \"Simplest-SmartThings-ESP8266-Blinds\" sketch.  \r\n`    for (pos = 0; pos <= 90; pos += 1) {   // goes from 0 degrees to 90 degrees in steps of 1 degree CHANGE 90 TO MATCH ANGLE OF TILT DESIRED\r\n      myservo.write(pos);                  // tell servo to go to position in variable 'pos'\r\n      delay(30);                           // waits 30ms between each degree to slow rotation speed\r\n    }`\r\n- For the mqtt connection, you used a token.  I searched and could not see how to use a token with my mosquitto servo.  I'm currently using u/n and p/w to get authenticated. Can you point me where I can get more information on the token?\r\n- Are you using \"Wblind-AP\" for all controllers or are you defining different names?  What do you recommend?\r\n-  Where can I insert WiFi.hostname(\"foobar\") in the code?  I would like to identify the individual blinds in my router.  I know it needs to before WiFi.begin but it must be called out from within Wifimanager\r\n\r\nThanks again for your contribution.\r\n\r\nTony"},"comment":{"url":"https://api.github.com/repos/p4yl04d3r/blinds/issues/comments/376373971","html_url":"https://github.com/p4yl04d3r/blinds/issues/1#issuecomment-376373971","issue_url":"https://api.github.com/repos/p4yl04d3r/blinds/issues/1","id":376373971,"user":{"login":"p4yl04d3r","id":19712223,"avatar_url":"https://avatars3.githubusercontent.com/u/19712223?v=4","gravatar_id":"","url":"https://api.github.com/users/p4yl04d3r","html_url":"https://github.com/p4yl04d3r","followers_url":"https://api.github.com/users/p4yl04d3r/followers","following_url":"https://api.github.com/users/p4yl04d3r/following{/other_user}","gists_url":"https://api.github.com/users/p4yl04d3r/gists{/gist_id}","starred_url":"https://api.github.com/users/p4yl04d3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4yl04d3r/subscriptions","organizations_url":"https://api.github.com/users/p4yl04d3r/orgs","repos_url":"https://api.github.com/users/p4yl04d3r/repos","events_url":"https://api.github.com/users/p4yl04d3r/events{/privacy}","received_events_url":"https://api.github.com/users/p4yl04d3r/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T02:19:24Z","updated_at":"2018-03-27T02:19:24Z","author_association":"OWNER","body":"Hi Tony,\nThanks for the suggestions in a prior email.  I will make them and continue\nwith some code cleanup.\nI was looking in git and it looks like I inadvertently pushed some\nun-tested code (which you happen to be using).\nI'm sorry for this as you are now testing some fixes. The last commit from\nJuly 2016 is what I am running with at home. In January I added \"Config\nmanager\" and the web portal to configure the blinds.  Prior to that all the\nchanges were done in the code and then you compiled.\nOK so this code snippet is were I added some new stuff and is untested.\nI added the feature to make 1 degree changes (offset) to open and half-open\npositions to fix an issue I had when multiple binds exist on a wall. Each\nopen and half-open position were not perfectly aligned. The reason for this\nis because of mechanical errors in either the position of the server and\nblind rod or servo accuracy.  I opted to address the issue in software\nrather then in hardware.\nSo what this code is suppose to do is take the offset for that blind and\napply it to the open and half-open values.\nThe offset is set to the midpoint/open position or 90 degrees.\n\nSo you missed a critical line.\n\" int b1_value=value;\" IF the offset=90 all offset tests are skipped. If\nyou did not change the offset value. the code is mute.\n\nI want to talk about functions \" void callback(...)\" I want to change this\nfunction to take commands instead of an integer value from MQTT. Before I\nget into new design work. How do the blinds work with local control? It you\nsetup the blinds with the servo on the right side, I will need to add\nsupport to mirror servo movements so all blinds operate\nthe same regardless on how the server is mounted.\n\nPost some pictures of the components.\n\nregards,\nchris\n\nOn Mon, Mar 26, 2018 at 7:25 PM, 2delarosa <notifications@github.com> wrote:\n\n> Chris,\n>\n> I hope you can help me with two annoying things my wife has with the\n> blinds. First, the open command appears to always go one position. I used a\n> MQTT tool to change the position but it doesn't for certain ranges. This\n> applies to the two of the three blinds where the orientation of the servo\n> was reversed. Second, the open position depends on whether I start closeup\n> or closedown. I believe it has to do with the offset value you created. Can\n> you clarify what the offset does?\n>\n> `    if (atoi(blind1_0_offset) != 90 && value == OPEN) {  // Set new open value.\n>        b1_value = atoi(blind1_0_offset);\n>        debug and Serial.println(\"B1 here1\");\n>     }\n>     if (atoi(blind1_0_offset) > 90 && value == HALF) {  // Calculate new half open value if offset is > 90.\n>        b1_value = value+(atoi(blind1_0_offset)-90);\n>        debug and Serial.println(\"B1 here2\");\n>     }\n>     if (atoi(blind1_0_offset) < 90 && value == HALF) {  // Calculate new half open value if offset is < 90.\n>        b1_value = value-(90-atoi(blind1_0_offset));\n>        debug and Serial.println(\"B1 here3\");\n>     }`\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/p4yl04d3r/blinds/issues/1#issuecomment-376355068>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/ASzI39C82BWg4oZaFi0GihTQzl9EHYOnks5tiYb3gaJpZM4SxDNl>\n> .\n>\n"}}
{"actor":{"display_login":"p4yl04d3r"}}