{"action":"created","comment":{"url":"https://api.github.com/repos/rcbops/rpc-upgrades/pulls/comments/173209244","pull_request_review_id":102359305,"id":173209244,"diff_hunk":"@@ -175,3 +175,49 @@\n     - name: Duplicate flavors exist\n       fail: msg=\"Duplicated flavor IDs are detected.\"\n       when: flavor_check.stdout != \"\"\n+\n+# RLM-1372 Check NFS exsiting\n+- name: Check Glance NFS backend on glance\n+  hosts: glance_all\n+  gather_facts: false\n+  user: root\n+  tasks:\n+    - name: Look for NFS mount on Glance\n+      shell: |\n+        if mount | grep -i 'nfs'; then\n+          mount | grep -i 'nfs'\n+        fi\n+      register: nfs_mount_found\n+      failed_when:\n+        - nfs_mount_found.stdout\n+\n+    - name: Look for NFS config in Glance config\n+      shell: |\n+        if grep -q 'default_store = file' {{ item }}; then\n+          echo 'true'\n+        else\n+          echo 'false'\n+        fi\n+      register: nfs_default_store\n+      with_items:\n+        - \"/etc/glance/glance-api.conf\"\n+      failed_when: nfs_default_store.stdout == 'true'\n+\n+- name: Check Glance NFS config on infa\n+  hosts: \"os-infra_hosts\"\n+  gather_facts: false\n+  user: root\n+  tasks:\n+    - name: Glance NFS config found\n+      shell: |\n+        if grep -q 'glance_default_store: nfs' {{ item }}; then","path":"playbooks/preflight-check.yml","position":39,"original_position":39,"commit_id":"e09fa1438183174ef5b55f8b5de4e76c4bbc2774","original_commit_id":"e09fa1438183174ef5b55f8b5de4e76c4bbc2774","user":{"login":"BjoernT","id":5613435,"avatar_url":"https://avatars3.githubusercontent.com/u/5613435?v=4","gravatar_id":"","url":"https://api.github.com/users/BjoernT","html_url":"https://github.com/BjoernT","followers_url":"https://api.github.com/users/BjoernT/followers","following_url":"https://api.github.com/users/BjoernT/following{/other_user}","gists_url":"https://api.github.com/users/BjoernT/gists{/gist_id}","starred_url":"https://api.github.com/users/BjoernT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BjoernT/subscriptions","organizations_url":"https://api.github.com/users/BjoernT/orgs","repos_url":"https://api.github.com/users/BjoernT/repos","events_url":"https://api.github.com/users/BjoernT/events{/privacy}","received_events_url":"https://api.github.com/users/BjoernT/received_events","type":"User","site_admin":false},"body":"Also nfs mounts in infra would likely be configured as  glance_default_store: file so that logic seems wrong as glance_default_store: nfs is actually a invalid configuration","created_at":"2018-03-08T16:19:51Z","updated_at":"2018-03-08T16:21:26Z","html_url":"https://github.com/rcbops/rpc-upgrades/pull/145#discussion_r173209244","pull_request_url":"https://api.github.com/repos/rcbops/rpc-upgrades/pulls/145","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rcbops/rpc-upgrades/pulls/comments/173209244"},"html":{"href":"https://github.com/rcbops/rpc-upgrades/pull/145#discussion_r173209244"},"pull_request":{"href":"https://api.github.com/repos/rcbops/rpc-upgrades/pulls/145"}},"in_reply_to_id":173208295},"pull_request":{"url":"https://api.github.com/repos/rcbops/rpc-upgrades/pulls/145","id":171500379,"html_url":"https://github.com/rcbops/rpc-upgrades/pull/145","diff_url":"https://github.com/rcbops/rpc-upgrades/pull/145.diff","patch_url":"https://github.com/rcbops/rpc-upgrades/pull/145.patch","issue_url":"https://api.github.com/repos/rcbops/rpc-upgrades/issues/145","number":145,"state":"open","locked":false,"title":"RLM-1372 Add NFS mount check","user":{"login":"Frank-ZhangXin","id":5384857,"avatar_url":"https://avatars0.githubusercontent.com/u/5384857?v=4","gravatar_id":"","url":"https://api.github.com/users/Frank-ZhangXin","html_url":"https://github.com/Frank-ZhangXin","followers_url":"https://api.github.com/users/Frank-ZhangXin/followers","following_url":"https://api.github.com/users/Frank-ZhangXin/following{/other_user}","gists_url":"https://api.github.com/users/Frank-ZhangXin/gists{/gist_id}","starred_url":"https://api.github.com/users/Frank-ZhangXin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frank-ZhangXin/subscriptions","organizations_url":"https://api.github.com/users/Frank-ZhangXin/orgs","repos_url":"https://api.github.com/users/Frank-ZhangXin/repos","events_url":"https://api.github.com/users/Frank-ZhangXin/events{/privacy}","received_events_url":"https://api.github.com/users/Frank-ZhangXin/received_events","type":"User","site_admin":false},"body":"Make preflight check having ability to determine if NFS mount exists. If\r\nso advanced glance config is needed to perform.","created_at":"2018-02-26T21:44:40Z","updated_at":"2018-03-08T16:21:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"796d3bedd74206d292f29346dee1df9ab9646c4b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"antonym","id":245007,"avatar_url":"https://avatars2.githubusercontent.com/u/245007?v=4","gravatar_id":"","url":"https://api.github.com/users/antonym","html_url":"https://github.com/antonym","followers_url":"https://api.github.com/users/antonym/followers","following_url":"https://api.github.com/users/antonym/following{/other_user}","gists_url":"https://api.github.com/users/antonym/gists{/gist_id}","starred_url":"https://api.github.com/users/antonym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonym/subscriptions","organizations_url":"https://api.github.com/users/antonym/orgs","repos_url":"https://api.github.com/users/antonym/repos","events_url":"https://api.github.com/users/antonym/events{/privacy}","received_events_url":"https://api.github.com/users/antonym/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rcbops/rpc-upgrades/pulls/145/commits","review_comments_url":"https://api.github.com/repos/rcbops/rpc-upgrades/pulls/145/comments","review_comment_url":"https://api.github.com/repos/rcbops/rpc-upgrades/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rcbops/rpc-upgrades/issues/145/comments","statuses_url":"https://api.github.com/repos/rcbops/rpc-upgrades/statuses/e09fa1438183174ef5b55f8b5de4e76c4bbc2774","head":{"label":"Frank-ZhangXin:nfs-mount-check","ref":"nfs-mount-check","sha":"e09fa1438183174ef5b55f8b5de4e76c4bbc2774","user":{"login":"Frank-ZhangXin","id":5384857,"avatar_url":"https://avatars0.githubusercontent.com/u/5384857?v=4","gravatar_id":"","url":"https://api.github.com/users/Frank-ZhangXin","html_url":"https://github.com/Frank-ZhangXin","followers_url":"https://api.github.com/users/Frank-ZhangXin/followers","following_url":"https://api.github.com/users/Frank-ZhangXin/following{/other_user}","gists_url":"https://api.github.com/users/Frank-ZhangXin/gists{/gist_id}","starred_url":"https://api.github.com/users/Frank-ZhangXin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frank-ZhangXin/subscriptions","organizations_url":"https://api.github.com/users/Frank-ZhangXin/orgs","repos_url":"https://api.github.com/users/Frank-ZhangXin/repos","events_url":"https://api.github.com/users/Frank-ZhangXin/events{/privacy}","received_events_url":"https://api.github.com/users/Frank-ZhangXin/received_events","type":"User","site_admin":false},"repo":{"id":110596920,"name":"rpc-upgrades","full_name":"Frank-ZhangXin/rpc-upgrades","owner":{"login":"Frank-ZhangXin","id":5384857,"avatar_url":"https://avatars0.githubusercontent.com/u/5384857?v=4","gravatar_id":"","url":"https://api.github.com/users/Frank-ZhangXin","html_url":"https://github.com/Frank-ZhangXin","followers_url":"https://api.github.com/users/Frank-ZhangXin/followers","following_url":"https://api.github.com/users/Frank-ZhangXin/following{/other_user}","gists_url":"https://api.github.com/users/Frank-ZhangXin/gists{/gist_id}","starred_url":"https://api.github.com/users/Frank-ZhangXin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frank-ZhangXin/subscriptions","organizations_url":"https://api.github.com/users/Frank-ZhangXin/orgs","repos_url":"https://api.github.com/users/Frank-ZhangXin/repos","events_url":"https://api.github.com/users/Frank-ZhangXin/events{/privacy}","received_events_url":"https://api.github.com/users/Frank-ZhangXin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Frank-ZhangXin/rpc-upgrades","description":"Moving Leapfrog/FastTrack/IntraSeries Upgrades out of RPC-OpenStack","fork":true,"url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades","forks_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/forks","keys_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/teams","hooks_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/hooks","issue_events_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/issues/events{/number}","events_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/events","assignees_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/assignees{/user}","branches_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/branches{/branch}","tags_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/tags","blobs_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/git/refs{/sha}","trees_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/statuses/{sha}","languages_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/languages","stargazers_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/stargazers","contributors_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/contributors","subscribers_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/subscribers","subscription_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/subscription","commits_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/commits{/sha}","git_commits_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/git/commits{/sha}","comments_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/comments{/number}","issue_comment_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/issues/comments{/number}","contents_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/contents/{+path}","compare_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/merges","archive_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/downloads","issues_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/issues{/number}","pulls_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/pulls{/number}","milestones_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/milestones{/number}","notifications_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/labels{/name}","releases_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/releases{/id}","deployments_url":"https://api.github.com/repos/Frank-ZhangXin/rpc-upgrades/deployments","created_at":"2017-11-13T20:14:34Z","updated_at":"2017-11-13T20:14:36Z","pushed_at":"2018-03-05T18:24:57Z","git_url":"git://github.com/Frank-ZhangXin/rpc-upgrades.git","ssh_url":"git@github.com:Frank-ZhangXin/rpc-upgrades.git","clone_url":"https://github.com/Frank-ZhangXin/rpc-upgrades.git","svn_url":"https://github.com/Frank-ZhangXin/rpc-upgrades","homepage":null,"size":505,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rcbops:master","ref":"master","sha":"634a252dc1b064002473a4dccb36aa23bcc44386","user":{"login":"rcbops","id":1153548,"avatar_url":"https://avatars1.githubusercontent.com/u/1153548?v=4","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"repo":{"id":106319474,"name":"rpc-upgrades","full_name":"rcbops/rpc-upgrades","owner":{"login":"rcbops","id":1153548,"avatar_url":"https://avatars1.githubusercontent.com/u/1153548?v=4","gravatar_id":"","url":"https://api.github.com/users/rcbops","html_url":"https://github.com/rcbops","followers_url":"https://api.github.com/users/rcbops/followers","following_url":"https://api.github.com/users/rcbops/following{/other_user}","gists_url":"https://api.github.com/users/rcbops/gists{/gist_id}","starred_url":"https://api.github.com/users/rcbops/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcbops/subscriptions","organizations_url":"https://api.github.com/users/rcbops/orgs","repos_url":"https://api.github.com/users/rcbops/repos","events_url":"https://api.github.com/users/rcbops/events{/privacy}","received_events_url":"https://api.github.com/users/rcbops/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rcbops/rpc-upgrades","description":"Leapfrog/FastTrack/IntraSeries Upgrades for RPC-OpenStack","fork":false,"url":"https://api.github.com/repos/rcbops/rpc-upgrades","forks_url":"https://api.github.com/repos/rcbops/rpc-upgrades/forks","keys_url":"https://api.github.com/repos/rcbops/rpc-upgrades/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcbops/rpc-upgrades/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcbops/rpc-upgrades/teams","hooks_url":"https://api.github.com/repos/rcbops/rpc-upgrades/hooks","issue_events_url":"https://api.github.com/repos/rcbops/rpc-upgrades/issues/events{/number}","events_url":"https://api.github.com/repos/rcbops/rpc-upgrades/events","assignees_url":"https://api.github.com/repos/rcbops/rpc-upgrades/assignees{/user}","branches_url":"https://api.github.com/repos/rcbops/rpc-upgrades/branches{/branch}","tags_url":"https://api.github.com/repos/rcbops/rpc-upgrades/tags","blobs_url":"https://api.github.com/repos/rcbops/rpc-upgrades/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcbops/rpc-upgrades/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcbops/rpc-upgrades/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcbops/rpc-upgrades/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcbops/rpc-upgrades/statuses/{sha}","languages_url":"https://api.github.com/repos/rcbops/rpc-upgrades/languages","stargazers_url":"https://api.github.com/repos/rcbops/rpc-upgrades/stargazers","contributors_url":"https://api.github.com/repos/rcbops/rpc-upgrades/contributors","subscribers_url":"https://api.github.com/repos/rcbops/rpc-upgrades/subscribers","subscription_url":"https://api.github.com/repos/rcbops/rpc-upgrades/subscription","commits_url":"https://api.github.com/repos/rcbops/rpc-upgrades/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcbops/rpc-upgrades/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcbops/rpc-upgrades/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcbops/rpc-upgrades/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcbops/rpc-upgrades/contents/{+path}","compare_url":"https://api.github.com/repos/rcbops/rpc-upgrades/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcbops/rpc-upgrades/merges","archive_url":"https://api.github.com/repos/rcbops/rpc-upgrades/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcbops/rpc-upgrades/downloads","issues_url":"https://api.github.com/repos/rcbops/rpc-upgrades/issues{/number}","pulls_url":"https://api.github.com/repos/rcbops/rpc-upgrades/pulls{/number}","milestones_url":"https://api.github.com/repos/rcbops/rpc-upgrades/milestones{/number}","notifications_url":"https://api.github.com/repos/rcbops/rpc-upgrades/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcbops/rpc-upgrades/labels{/name}","releases_url":"https://api.github.com/repos/rcbops/rpc-upgrades/releases{/id}","deployments_url":"https://api.github.com/repos/rcbops/rpc-upgrades/deployments","created_at":"2017-10-09T18:20:18Z","updated_at":"2018-02-01T15:39:29Z","pushed_at":"2018-03-07T16:59:49Z","git_url":"git://github.com/rcbops/rpc-upgrades.git","ssh_url":"git@github.com:rcbops/rpc-upgrades.git","clone_url":"https://github.com/rcbops/rpc-upgrades.git","svn_url":"https://github.com/rcbops/rpc-upgrades","homepage":"","size":498,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":10,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rcbops/rpc-upgrades/pulls/145"},"html":{"href":"https://github.com/rcbops/rpc-upgrades/pull/145"},"issue":{"href":"https://api.github.com/repos/rcbops/rpc-upgrades/issues/145"},"comments":{"href":"https://api.github.com/repos/rcbops/rpc-upgrades/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/rcbops/rpc-upgrades/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/rcbops/rpc-upgrades/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rcbops/rpc-upgrades/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/rcbops/rpc-upgrades/statuses/e09fa1438183174ef5b55f8b5de4e76c4bbc2774"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"BjoernT"}}