{"action":"created","comment":{"url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/pulls/comments/198451892","pull_request_review_id":132382629,"id":198451892,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODQ1MTg5Mg==","diff_hunk":"@@ -0,0 +1,39 @@\n+.PHONY: build clean test help default lint\n+\n+PROJECT=github.com/praekeltfoundation/vault-plugin-auth-mesos\n+\n+BIN_NAME=vault-plugin-auth-mesos\n+\n+VERSION := $(shell grep \"const Version \" version/version.go | sed -E 's/.*\"(.+)\"$$/\\1/')","path":"Makefile","position":7,"original_position":7,"commit_id":"44c250924e4388e978288cf6f30f6bdd2a62f180","original_commit_id":"7150d4a5dd5ba797c135e57711c9aa9cec29d479","user":{"login":"jerith","id":43731,"node_id":"MDQ6VXNlcjQzNzMx","avatar_url":"https://avatars1.githubusercontent.com/u/43731?v=4","gravatar_id":"","url":"https://api.github.com/users/jerith","html_url":"https://github.com/jerith","followers_url":"https://api.github.com/users/jerith/followers","following_url":"https://api.github.com/users/jerith/following{/other_user}","gists_url":"https://api.github.com/users/jerith/gists{/gist_id}","starred_url":"https://api.github.com/users/jerith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerith/subscriptions","organizations_url":"https://api.github.com/users/jerith/orgs","repos_url":"https://api.github.com/users/jerith/repos","events_url":"https://api.github.com/users/jerith/events{/privacy}","received_events_url":"https://api.github.com/users/jerith/received_events","type":"User","site_admin":false},"body":"Paraphrased from the GNU make docs:\r\nA variable set using `=` is \"recursively expanded\" -- any substitutions or whatever are evaluated when the variable is referenced.\r\nA variable set using `:=` (or `::=`) is \"simply expanded\" -- everything is evaluated when the variable is set.\r\nMore detail at https://www.gnu.org/software/make/manual/html_node/Flavors.html","created_at":"2018-06-27T10:58:55Z","updated_at":"2018-06-27T10:58:56Z","html_url":"https://github.com/praekeltfoundation/vault-plugin-auth-mesos/pull/1#discussion_r198451892","pull_request_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/pulls/comments/198451892"},"html":{"href":"https://github.com/praekeltfoundation/vault-plugin-auth-mesos/pull/1#discussion_r198451892"},"pull_request":{"href":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/pulls/1"}},"in_reply_to_id":198156429},"pull_request":{"url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/pulls/1","id":197404197,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDA0MTk3","html_url":"https://github.com/praekeltfoundation/vault-plugin-auth-mesos/pull/1","diff_url":"https://github.com/praekeltfoundation/vault-plugin-auth-mesos/pull/1.diff","patch_url":"https://github.com/praekeltfoundation/vault-plugin-auth-mesos/pull/1.patch","issue_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/issues/1","number":1,"state":"open","locked":false,"title":"Project boilerplate and the very start of an auth plugin","user":{"login":"jerith","id":43731,"node_id":"MDQ6VXNlcjQzNzMx","avatar_url":"https://avatars1.githubusercontent.com/u/43731?v=4","gravatar_id":"","url":"https://api.github.com/users/jerith","html_url":"https://github.com/jerith","followers_url":"https://api.github.com/users/jerith/followers","following_url":"https://api.github.com/users/jerith/following{/other_user}","gists_url":"https://api.github.com/users/jerith/gists{/gist_id}","starred_url":"https://api.github.com/users/jerith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerith/subscriptions","organizations_url":"https://api.github.com/users/jerith/orgs","repos_url":"https://api.github.com/users/jerith/repos","events_url":"https://api.github.com/users/jerith/events{/privacy}","received_events_url":"https://api.github.com/users/jerith/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-06-26T12:26:19Z","updated_at":"2018-06-27T10:58:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e77add25af1c1eaeabe0c50078ba1d7ba4f94717","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/pulls/1/commits","review_comments_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/pulls/1/comments","review_comment_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/issues/1/comments","statuses_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/statuses/44c250924e4388e978288cf6f30f6bdd2a62f180","head":{"label":"praekeltfoundation:in-the-beginning","ref":"in-the-beginning","sha":"44c250924e4388e978288cf6f30f6bdd2a62f180","user":{"login":"praekeltfoundation","id":15786759,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Nzg2NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15786759?v=4","gravatar_id":"","url":"https://api.github.com/users/praekeltfoundation","html_url":"https://github.com/praekeltfoundation","followers_url":"https://api.github.com/users/praekeltfoundation/followers","following_url":"https://api.github.com/users/praekeltfoundation/following{/other_user}","gists_url":"https://api.github.com/users/praekeltfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/praekeltfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekeltfoundation/subscriptions","organizations_url":"https://api.github.com/users/praekeltfoundation/orgs","repos_url":"https://api.github.com/users/praekeltfoundation/repos","events_url":"https://api.github.com/users/praekeltfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/praekeltfoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":138595931,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg1OTU5MzE=","name":"vault-plugin-auth-mesos","full_name":"praekeltfoundation/vault-plugin-auth-mesos","owner":{"login":"praekeltfoundation","id":15786759,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Nzg2NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15786759?v=4","gravatar_id":"","url":"https://api.github.com/users/praekeltfoundation","html_url":"https://github.com/praekeltfoundation","followers_url":"https://api.github.com/users/praekeltfoundation/followers","following_url":"https://api.github.com/users/praekeltfoundation/following{/other_user}","gists_url":"https://api.github.com/users/praekeltfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/praekeltfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekeltfoundation/subscriptions","organizations_url":"https://api.github.com/users/praekeltfoundation/orgs","repos_url":"https://api.github.com/users/praekeltfoundation/repos","events_url":"https://api.github.com/users/praekeltfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/praekeltfoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/praekeltfoundation/vault-plugin-auth-mesos","description":"A (currently very experimental) Vault auth plugin for mesos tasks.","fork":false,"url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos","forks_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/forks","keys_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/teams","hooks_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/hooks","issue_events_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/issues/events{/number}","events_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/events","assignees_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/assignees{/user}","branches_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/branches{/branch}","tags_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/tags","blobs_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/statuses/{sha}","languages_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/languages","stargazers_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/stargazers","contributors_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/contributors","subscribers_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/subscribers","subscription_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/subscription","commits_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/issues/comments{/number}","contents_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/contents/{+path}","compare_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/merges","archive_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/downloads","issues_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/issues{/number}","pulls_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/pulls{/number}","milestones_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/milestones{/number}","notifications_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/labels{/name}","releases_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/releases{/id}","deployments_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/deployments","created_at":"2018-06-25T13:03:36Z","updated_at":"2018-06-25T13:03:39Z","pushed_at":"2018-06-27T10:49:42Z","git_url":"git://github.com/praekeltfoundation/vault-plugin-auth-mesos.git","ssh_url":"git@github.com:praekeltfoundation/vault-plugin-auth-mesos.git","clone_url":"https://github.com/praekeltfoundation/vault-plugin-auth-mesos.git","svn_url":"https://github.com/praekeltfoundation/vault-plugin-auth-mesos","homepage":null,"size":16,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"praekeltfoundation:master","ref":"master","sha":"ec9a88e83f94ba641325cfb4d043832845f85802","user":{"login":"praekeltfoundation","id":15786759,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Nzg2NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15786759?v=4","gravatar_id":"","url":"https://api.github.com/users/praekeltfoundation","html_url":"https://github.com/praekeltfoundation","followers_url":"https://api.github.com/users/praekeltfoundation/followers","following_url":"https://api.github.com/users/praekeltfoundation/following{/other_user}","gists_url":"https://api.github.com/users/praekeltfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/praekeltfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekeltfoundation/subscriptions","organizations_url":"https://api.github.com/users/praekeltfoundation/orgs","repos_url":"https://api.github.com/users/praekeltfoundation/repos","events_url":"https://api.github.com/users/praekeltfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/praekeltfoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":138595931,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg1OTU5MzE=","name":"vault-plugin-auth-mesos","full_name":"praekeltfoundation/vault-plugin-auth-mesos","owner":{"login":"praekeltfoundation","id":15786759,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1Nzg2NzU5","avatar_url":"https://avatars3.githubusercontent.com/u/15786759?v=4","gravatar_id":"","url":"https://api.github.com/users/praekeltfoundation","html_url":"https://github.com/praekeltfoundation","followers_url":"https://api.github.com/users/praekeltfoundation/followers","following_url":"https://api.github.com/users/praekeltfoundation/following{/other_user}","gists_url":"https://api.github.com/users/praekeltfoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/praekeltfoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praekeltfoundation/subscriptions","organizations_url":"https://api.github.com/users/praekeltfoundation/orgs","repos_url":"https://api.github.com/users/praekeltfoundation/repos","events_url":"https://api.github.com/users/praekeltfoundation/events{/privacy}","received_events_url":"https://api.github.com/users/praekeltfoundation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/praekeltfoundation/vault-plugin-auth-mesos","description":"A (currently very experimental) Vault auth plugin for mesos tasks.","fork":false,"url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos","forks_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/forks","keys_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/teams","hooks_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/hooks","issue_events_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/issues/events{/number}","events_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/events","assignees_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/assignees{/user}","branches_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/branches{/branch}","tags_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/tags","blobs_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/git/refs{/sha}","trees_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/statuses/{sha}","languages_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/languages","stargazers_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/stargazers","contributors_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/contributors","subscribers_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/subscribers","subscription_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/subscription","commits_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/commits{/sha}","git_commits_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/git/commits{/sha}","comments_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/comments{/number}","issue_comment_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/issues/comments{/number}","contents_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/contents/{+path}","compare_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/merges","archive_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/downloads","issues_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/issues{/number}","pulls_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/pulls{/number}","milestones_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/milestones{/number}","notifications_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/labels{/name}","releases_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/releases{/id}","deployments_url":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/deployments","created_at":"2018-06-25T13:03:36Z","updated_at":"2018-06-25T13:03:39Z","pushed_at":"2018-06-27T10:49:42Z","git_url":"git://github.com/praekeltfoundation/vault-plugin-auth-mesos.git","ssh_url":"git@github.com:praekeltfoundation/vault-plugin-auth-mesos.git","clone_url":"https://github.com/praekeltfoundation/vault-plugin-auth-mesos.git","svn_url":"https://github.com/praekeltfoundation/vault-plugin-auth-mesos","homepage":null,"size":16,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/pulls/1"},"html":{"href":"https://github.com/praekeltfoundation/vault-plugin-auth-mesos/pull/1"},"issue":{"href":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/issues/1"},"comments":{"href":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/praekeltfoundation/vault-plugin-auth-mesos/statuses/44c250924e4388e978288cf6f30f6bdd2a62f180"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jerith"}}