{"action":"created","issue":{"url":"https://api.github.com/repos/pachyderm/pachyderm/issues/1280","repository_url":"https://api.github.com/repos/pachyderm/pachyderm","labels_url":"https://api.github.com/repos/pachyderm/pachyderm/issues/1280/labels{/name}","comments_url":"https://api.github.com/repos/pachyderm/pachyderm/issues/1280/comments","events_url":"https://api.github.com/repos/pachyderm/pachyderm/issues/1280/events","html_url":"https://github.com/pachyderm/pachyderm/issues/1280","id":202008839,"number":1280,"title":"Prevent pathological PutFile case","user":{"login":"sjezewski","id":597953,"avatar_url":"https://avatars1.githubusercontent.com/u/597953?v=4","gravatar_id":"","url":"https://api.github.com/users/sjezewski","html_url":"https://github.com/sjezewski","followers_url":"https://api.github.com/users/sjezewski/followers","following_url":"https://api.github.com/users/sjezewski/following{/other_user}","gists_url":"https://api.github.com/users/sjezewski/gists{/gist_id}","starred_url":"https://api.github.com/users/sjezewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjezewski/subscriptions","organizations_url":"https://api.github.com/users/sjezewski/orgs","repos_url":"https://api.github.com/users/sjezewski/repos","events_url":"https://api.github.com/users/sjezewski/events{/privacy}","received_events_url":"https://api.github.com/users/sjezewski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-01-19T23:44:45Z","updated_at":"2018-02-14T19:32:01Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"This came up during the GRPC PR\r\n\r\nGRPC 1.0 adds a `MaxMsgSize` to its server ... which means we can now go past that size. When that happens ... the server errs:\r\n\r\n```\r\nrpc error: code = 13 desc = grpc: received message length 25165898 exceeding the max size 25165824\r\n```\r\n\r\nBut the client only sees a `io.EOF` suggesting that the server has just hung up.\r\n\r\nOn the `pathological_putfile` branch I have a failing test for this.\r\n\r\nGoing forward ... we should make sure the client's writers never write more than the size of the `MaxMsgSize` limit. Since (right now) that value is set in `src/server/pfs/server/server.go` we'll have to move that to the client (bcz of vendoring ... client code can _never_ import server code).\r\n\r\nRight now the limit is set to 16MB so the only way you'll see this is if you:\r\n\r\n- write a text file whose line that crosses a block boundary (the 8MB mark) is itself 16MB long\r\n- write a bin file whose block is bigger than 24MB\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/pachyderm/pachyderm/issues/comments/365719263","html_url":"https://github.com/pachyderm/pachyderm/issues/1280#issuecomment-365719263","issue_url":"https://api.github.com/repos/pachyderm/pachyderm/issues/1280","id":365719263,"user":{"login":"stale[bot]","id":26384082,"avatar_url":"https://avatars2.githubusercontent.com/u/26350515?v=4","gravatar_id":"","url":"https://api.github.com/users/stale%5Bbot%5D","html_url":"https://github.com/apps/stale","followers_url":"https://api.github.com/users/stale%5Bbot%5D/followers","following_url":"https://api.github.com/users/stale%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/stale%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/stale%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stale%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/stale%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/stale%5Bbot%5D/repos","events_url":"https://api.github.com/users/stale%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/stale%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-02-14T19:32:01Z","updated_at":"2018-02-14T19:32:01Z","author_association":"NONE","body":"This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n"}}
{"actor":{"display_login":"stale"}}