{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/208655758","pull_request_review_id":144510730,"id":208655758,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODY1NTc1OA==","diff_hunk":"@@ -75,6 +75,17 @@ If(-not $forest) {\n         $iaf = Install-ADDSForest @install_forest_args\n \n         $result.reboot_required = $iaf.RebootRequired\n+\n+        # The Netlogon service is set to auto start but is not started. This is\n+        # required for Ansible to connect back to the host and reboot in a\n+        # later task. Even if this fails Ansible can still connect but only\n+        # with ansible_winrm_transport=basic so we just display a warning if\n+        # this fails.\n+        try {\n+            Start-Service -Name Netlogon","path":"lib/ansible/modules/windows/win_domain.ps1","position":11,"original_position":11,"commit_id":"c41b951d0c167133ae95da4451b01a4838a46bd5","original_commit_id":"c41b951d0c167133ae95da4451b01a4838a46bd5","user":{"login":"jhawkesworth","id":8440323,"node_id":"MDQ6VXNlcjg0NDAzMjM=","avatar_url":"https://avatars2.githubusercontent.com/u/8440323?v=4","gravatar_id":"","url":"https://api.github.com/users/jhawkesworth","html_url":"https://github.com/jhawkesworth","followers_url":"https://api.github.com/users/jhawkesworth/followers","following_url":"https://api.github.com/users/jhawkesworth/following{/other_user}","gists_url":"https://api.github.com/users/jhawkesworth/gists{/gist_id}","starred_url":"https://api.github.com/users/jhawkesworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhawkesworth/subscriptions","organizations_url":"https://api.github.com/users/jhawkesworth/orgs","repos_url":"https://api.github.com/users/jhawkesworth/repos","events_url":"https://api.github.com/users/jhawkesworth/events{/privacy}","received_events_url":"https://api.github.com/users/jhawkesworth/received_events","type":"User","site_admin":false},"body":"I wonder if its worth 'treading lightly' and only calling 'Start-Service' if Netlogon isn't currently running?  Would potentially avoid an unneeded warning if using Basic auth?","created_at":"2018-08-08T16:50:02Z","updated_at":"2018-08-08T16:50:03Z","html_url":"https://github.com/ansible/ansible/pull/43703#discussion_r208655758","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/43703","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/208655758"},"html":{"href":"https://github.com/ansible/ansible/pull/43703#discussion_r208655758"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/43703"}}},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/43703","id":206316973,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MzE2OTcz","html_url":"https://github.com/ansible/ansible/pull/43703","diff_url":"https://github.com/ansible/ansible/pull/43703.diff","patch_url":"https://github.com/ansible/ansible/pull/43703.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/43703","number":43703,"state":"open","locked":false,"title":"win_domain modules: ensure Netlogon service is still running after promotion","user":{"login":"jborean93","id":8462645,"node_id":"MDQ6VXNlcjg0NjI2NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/8462645?v=4","gravatar_id":"","url":"https://api.github.com/users/jborean93","html_url":"https://github.com/jborean93","followers_url":"https://api.github.com/users/jborean93/followers","following_url":"https://api.github.com/users/jborean93/following{/other_user}","gists_url":"https://api.github.com/users/jborean93/gists{/gist_id}","starred_url":"https://api.github.com/users/jborean93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jborean93/subscriptions","organizations_url":"https://api.github.com/users/jborean93/orgs","repos_url":"https://api.github.com/users/jborean93/repos","events_url":"https://api.github.com/users/jborean93/events{/privacy}","received_events_url":"https://api.github.com/users/jborean93/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nWhen promoting a server to a domain controller, Ansible is unable to authenticate to the server unless it is manually rebooted, the `Netlogon` service is started manually, or `basic` auth is used. This change tries to start the `Netlogon` service manually before returning back to the host so subsequent calls like `win_reboot` can reboot the host.\r\n\r\nFixes https://github.com/ansible/ansible/issues/39235\r\n\r\n##### ISSUE TYPE\r\n - Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\nwin_domain\r\nwin_domain_controller\r\n\r\n##### ANSIBLE VERSION\r\n```\r\n2.6\r\ndevel\r\n```","created_at":"2018-08-06T07:55:39Z","updated_at":"2018-08-08T16:50:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d2d84c5dc030573d0039df1d679ad54f02d59b9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":947190508,"node_id":"MDU6TGFiZWw5NDcxOTA1MDg=","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.7","name":"affects_2.7","color":"ededed","default":false},{"id":785271699,"node_id":"MDU6TGFiZWw3ODUyNzE2OTk=","url":"https://api.github.com/repos/ansible/ansible/labels/bug","name":"bug","color":"fbca04","default":true},{"id":513652538,"node_id":"MDU6TGFiZWw1MTM2NTI1Mzg=","url":"https://api.github.com/repos/ansible/ansible/labels/core_review","name":"core_review","color":"ededed","default":false},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":636352796,"node_id":"MDU6TGFiZWw2MzYzNTI3OTY=","url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false},{"id":108461331,"node_id":"MDU6TGFiZWwxMDg0NjEzMzE=","url":"https://api.github.com/repos/ansible/ansible/labels/windows","name":"windows","color":"777777","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/43703/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/43703/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/43703/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/c41b951d0c167133ae95da4451b01a4838a46bd5","head":{"label":"jborean93:win_domain-netlogon","ref":"win_domain-netlogon","sha":"c41b951d0c167133ae95da4451b01a4838a46bd5","user":{"login":"jborean93","id":8462645,"node_id":"MDQ6VXNlcjg0NjI2NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/8462645?v=4","gravatar_id":"","url":"https://api.github.com/users/jborean93","html_url":"https://github.com/jborean93","followers_url":"https://api.github.com/users/jborean93/followers","following_url":"https://api.github.com/users/jborean93/following{/other_user}","gists_url":"https://api.github.com/users/jborean93/gists{/gist_id}","starred_url":"https://api.github.com/users/jborean93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jborean93/subscriptions","organizations_url":"https://api.github.com/users/jborean93/orgs","repos_url":"https://api.github.com/users/jborean93/repos","events_url":"https://api.github.com/users/jborean93/events{/privacy}","received_events_url":"https://api.github.com/users/jborean93/received_events","type":"User","site_admin":false},"repo":{"id":72729201,"node_id":"MDEwOlJlcG9zaXRvcnk3MjcyOTIwMQ==","name":"ansible","full_name":"jborean93/ansible","owner":{"login":"jborean93","id":8462645,"node_id":"MDQ6VXNlcjg0NjI2NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/8462645?v=4","gravatar_id":"","url":"https://api.github.com/users/jborean93","html_url":"https://github.com/jborean93","followers_url":"https://api.github.com/users/jborean93/followers","following_url":"https://api.github.com/users/jborean93/following{/other_user}","gists_url":"https://api.github.com/users/jborean93/gists{/gist_id}","starred_url":"https://api.github.com/users/jborean93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jborean93/subscriptions","organizations_url":"https://api.github.com/users/jborean93/orgs","repos_url":"https://api.github.com/users/jborean93/repos","events_url":"https://api.github.com/users/jborean93/events{/privacy}","received_events_url":"https://api.github.com/users/jborean93/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jborean93/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/jborean93/ansible","forks_url":"https://api.github.com/repos/jborean93/ansible/forks","keys_url":"https://api.github.com/repos/jborean93/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jborean93/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jborean93/ansible/teams","hooks_url":"https://api.github.com/repos/jborean93/ansible/hooks","issue_events_url":"https://api.github.com/repos/jborean93/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/jborean93/ansible/events","assignees_url":"https://api.github.com/repos/jborean93/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/jborean93/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/jborean93/ansible/tags","blobs_url":"https://api.github.com/repos/jborean93/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jborean93/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jborean93/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/jborean93/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jborean93/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/jborean93/ansible/languages","stargazers_url":"https://api.github.com/repos/jborean93/ansible/stargazers","contributors_url":"https://api.github.com/repos/jborean93/ansible/contributors","subscribers_url":"https://api.github.com/repos/jborean93/ansible/subscribers","subscription_url":"https://api.github.com/repos/jborean93/ansible/subscription","commits_url":"https://api.github.com/repos/jborean93/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/jborean93/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/jborean93/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/jborean93/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/jborean93/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/jborean93/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jborean93/ansible/merges","archive_url":"https://api.github.com/repos/jborean93/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jborean93/ansible/downloads","issues_url":"https://api.github.com/repos/jborean93/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/jborean93/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/jborean93/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/jborean93/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jborean93/ansible/labels{/name}","releases_url":"https://api.github.com/repos/jborean93/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/jborean93/ansible/deployments","created_at":"2016-11-03T09:27:23Z","updated_at":"2018-08-08T05:01:41Z","pushed_at":"2018-08-08T11:20:36Z","git_url":"git://github.com/jborean93/ansible.git","ssh_url":"git@github.com:jborean93/ansible.git","clone_url":"https://github.com/jborean93/ansible.git","svn_url":"https://github.com/jborean93/ansible","homepage":"http://ansible.com/","size":120610,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"741fa025a06b1e63278ad5f3e0963e39126a94da","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4OTY0","name":"ansible","full_name":"ansible/ansible","owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-08-08T16:49:01Z","pushed_at":"2018-08-08T16:43:48Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":135591,"stargazers_count":31834,"watchers_count":31834,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12309,"mirror_url":null,"archived":false,"open_issues_count":5445,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":12309,"open_issues":5445,"watchers":31834,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/43703"},"html":{"href":"https://github.com/ansible/ansible/pull/43703"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/43703"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/43703/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/43703/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/43703/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/c41b951d0c167133ae95da4451b01a4838a46bd5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jhawkesworth"}}