{"action":"created","comment":{"url":"https://api.github.com/repos/fabiospampinato/notable/pulls/comments/244403213","pull_request_review_id":188365678,"id":244403213,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDQwMzIxMw==","diff_hunk":"@@ -25,9 +25,11 @@ class Search extends Container<SearchState, MainCTX> {\n \n   _isNoteMatch = ( note: NoteObj, query: string ): boolean => {\n \n+    const queryRe = new RegExp ( _.escapeRegExp ( query ), 'ig' );","path":"src/renderer/containers/main/search.ts","position":5,"original_position":4,"commit_id":"b0c367f2551fdc1c2b4f0a4674a17ef772a0228f","original_commit_id":"b0c367f2551fdc1c2b4f0a4674a17ef772a0228f","user":{"login":"fabiospampinato","id":1812093,"node_id":"MDQ6VXNlcjE4MTIwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1812093?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiospampinato","html_url":"https://github.com/fabiospampinato","followers_url":"https://api.github.com/users/fabiospampinato/followers","following_url":"https://api.github.com/users/fabiospampinato/following{/other_user}","gists_url":"https://api.github.com/users/fabiospampinato/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiospampinato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiospampinato/subscriptions","organizations_url":"https://api.github.com/users/fabiospampinato/orgs","repos_url":"https://api.github.com/users/fabiospampinato/repos","events_url":"https://api.github.com/users/fabiospampinato/events{/privacy}","received_events_url":"https://api.github.com/users/fabiospampinato/received_events","type":"User","site_admin":false},"body":"@tylerdiaz maybe pass it as third parameter, we need the string for fuzzy matching the title.","created_at":"2018-12-28T20:37:20Z","updated_at":"2018-12-28T20:37:20Z","html_url":"https://github.com/fabiospampinato/notable/pull/62#discussion_r244403213","pull_request_url":"https://api.github.com/repos/fabiospampinato/notable/pulls/62","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/fabiospampinato/notable/pulls/comments/244403213"},"html":{"href":"https://github.com/fabiospampinato/notable/pull/62#discussion_r244403213"},"pull_request":{"href":"https://api.github.com/repos/fabiospampinato/notable/pulls/62"}},"in_reply_to_id":244399749},"pull_request":{"url":"https://api.github.com/repos/fabiospampinato/notable/pulls/62","id":241232385,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMjMyMzg1","html_url":"https://github.com/fabiospampinato/notable/pull/62","diff_url":"https://github.com/fabiospampinato/notable/pull/62.diff","patch_url":"https://github.com/fabiospampinato/notable/pull/62.patch","issue_url":"https://api.github.com/repos/fabiospampinato/notable/issues/62","number":62,"state":"open","locked":false,"title":"Include note contents in search query","user":{"login":"tylerdiaz","id":584182,"node_id":"MDQ6VXNlcjU4NDE4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/584182?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerdiaz","html_url":"https://github.com/tylerdiaz","followers_url":"https://api.github.com/users/tylerdiaz/followers","following_url":"https://api.github.com/users/tylerdiaz/following{/other_user}","gists_url":"https://api.github.com/users/tylerdiaz/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerdiaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerdiaz/subscriptions","organizations_url":"https://api.github.com/users/tylerdiaz/orgs","repos_url":"https://api.github.com/users/tylerdiaz/repos","events_url":"https://api.github.com/users/tylerdiaz/events{/privacy}","received_events_url":"https://api.github.com/users/tylerdiaz/received_events","type":"User","site_admin":false},"body":"Solution attempt for https://github.com/fabiospampinato/notable/issues/48\r\n\r\n@fabiospampinato Curious to hear your thoughts on this. It works well enough in most cases and doesn't significantly hurt performance. The down-side of using `indexOf` is that you only get an exact, case-sensitive match.","created_at":"2018-12-27T22:19:41Z","updated_at":"2018-12-28T20:37:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22462aefb1743ddee2ecc3eb20f812b5d574d83f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabiospampinato/notable/pulls/62/commits","review_comments_url":"https://api.github.com/repos/fabiospampinato/notable/pulls/62/comments","review_comment_url":"https://api.github.com/repos/fabiospampinato/notable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabiospampinato/notable/issues/62/comments","statuses_url":"https://api.github.com/repos/fabiospampinato/notable/statuses/b0c367f2551fdc1c2b4f0a4674a17ef772a0228f","head":{"label":"tylerdiaz:td/search","ref":"td/search","sha":"b0c367f2551fdc1c2b4f0a4674a17ef772a0228f","user":{"login":"tylerdiaz","id":584182,"node_id":"MDQ6VXNlcjU4NDE4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/584182?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerdiaz","html_url":"https://github.com/tylerdiaz","followers_url":"https://api.github.com/users/tylerdiaz/followers","following_url":"https://api.github.com/users/tylerdiaz/following{/other_user}","gists_url":"https://api.github.com/users/tylerdiaz/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerdiaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerdiaz/subscriptions","organizations_url":"https://api.github.com/users/tylerdiaz/orgs","repos_url":"https://api.github.com/users/tylerdiaz/repos","events_url":"https://api.github.com/users/tylerdiaz/events{/privacy}","received_events_url":"https://api.github.com/users/tylerdiaz/received_events","type":"User","site_admin":false},"repo":{"id":163329462,"node_id":"MDEwOlJlcG9zaXRvcnkxNjMzMjk0NjI=","name":"notable","full_name":"tylerdiaz/notable","private":false,"owner":{"login":"tylerdiaz","id":584182,"node_id":"MDQ6VXNlcjU4NDE4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/584182?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerdiaz","html_url":"https://github.com/tylerdiaz","followers_url":"https://api.github.com/users/tylerdiaz/followers","following_url":"https://api.github.com/users/tylerdiaz/following{/other_user}","gists_url":"https://api.github.com/users/tylerdiaz/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerdiaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerdiaz/subscriptions","organizations_url":"https://api.github.com/users/tylerdiaz/orgs","repos_url":"https://api.github.com/users/tylerdiaz/repos","events_url":"https://api.github.com/users/tylerdiaz/events{/privacy}","received_events_url":"https://api.github.com/users/tylerdiaz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tylerdiaz/notable","description":"The markdown-based note-taking app that doesn't suck.","fork":true,"url":"https://api.github.com/repos/tylerdiaz/notable","forks_url":"https://api.github.com/repos/tylerdiaz/notable/forks","keys_url":"https://api.github.com/repos/tylerdiaz/notable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tylerdiaz/notable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tylerdiaz/notable/teams","hooks_url":"https://api.github.com/repos/tylerdiaz/notable/hooks","issue_events_url":"https://api.github.com/repos/tylerdiaz/notable/issues/events{/number}","events_url":"https://api.github.com/repos/tylerdiaz/notable/events","assignees_url":"https://api.github.com/repos/tylerdiaz/notable/assignees{/user}","branches_url":"https://api.github.com/repos/tylerdiaz/notable/branches{/branch}","tags_url":"https://api.github.com/repos/tylerdiaz/notable/tags","blobs_url":"https://api.github.com/repos/tylerdiaz/notable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tylerdiaz/notable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tylerdiaz/notable/git/refs{/sha}","trees_url":"https://api.github.com/repos/tylerdiaz/notable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tylerdiaz/notable/statuses/{sha}","languages_url":"https://api.github.com/repos/tylerdiaz/notable/languages","stargazers_url":"https://api.github.com/repos/tylerdiaz/notable/stargazers","contributors_url":"https://api.github.com/repos/tylerdiaz/notable/contributors","subscribers_url":"https://api.github.com/repos/tylerdiaz/notable/subscribers","subscription_url":"https://api.github.com/repos/tylerdiaz/notable/subscription","commits_url":"https://api.github.com/repos/tylerdiaz/notable/commits{/sha}","git_commits_url":"https://api.github.com/repos/tylerdiaz/notable/git/commits{/sha}","comments_url":"https://api.github.com/repos/tylerdiaz/notable/comments{/number}","issue_comment_url":"https://api.github.com/repos/tylerdiaz/notable/issues/comments{/number}","contents_url":"https://api.github.com/repos/tylerdiaz/notable/contents/{+path}","compare_url":"https://api.github.com/repos/tylerdiaz/notable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tylerdiaz/notable/merges","archive_url":"https://api.github.com/repos/tylerdiaz/notable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tylerdiaz/notable/downloads","issues_url":"https://api.github.com/repos/tylerdiaz/notable/issues{/number}","pulls_url":"https://api.github.com/repos/tylerdiaz/notable/pulls{/number}","milestones_url":"https://api.github.com/repos/tylerdiaz/notable/milestones{/number}","notifications_url":"https://api.github.com/repos/tylerdiaz/notable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tylerdiaz/notable/labels{/name}","releases_url":"https://api.github.com/repos/tylerdiaz/notable/releases{/id}","deployments_url":"https://api.github.com/repos/tylerdiaz/notable/deployments","created_at":"2018-12-27T19:30:18Z","updated_at":"2018-12-28T20:25:34Z","pushed_at":"2018-12-28T20:25:32Z","git_url":"git://github.com/tylerdiaz/notable.git","ssh_url":"git@github.com:tylerdiaz/notable.git","clone_url":"https://github.com/tylerdiaz/notable.git","svn_url":"https://github.com/tylerdiaz/notable","homepage":null,"size":1204,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabiospampinato:master","ref":"master","sha":"e0d27304447a57da4dc3c72926c173ee7e968369","user":{"login":"fabiospampinato","id":1812093,"node_id":"MDQ6VXNlcjE4MTIwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1812093?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiospampinato","html_url":"https://github.com/fabiospampinato","followers_url":"https://api.github.com/users/fabiospampinato/followers","following_url":"https://api.github.com/users/fabiospampinato/following{/other_user}","gists_url":"https://api.github.com/users/fabiospampinato/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiospampinato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiospampinato/subscriptions","organizations_url":"https://api.github.com/users/fabiospampinato/orgs","repos_url":"https://api.github.com/users/fabiospampinato/repos","events_url":"https://api.github.com/users/fabiospampinato/events{/privacy}","received_events_url":"https://api.github.com/users/fabiospampinato/received_events","type":"User","site_admin":false},"repo":{"id":162815665,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI4MTU2NjU=","name":"notable","full_name":"fabiospampinato/notable","private":false,"owner":{"login":"fabiospampinato","id":1812093,"node_id":"MDQ6VXNlcjE4MTIwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1812093?v=4","gravatar_id":"","url":"https://api.github.com/users/fabiospampinato","html_url":"https://github.com/fabiospampinato","followers_url":"https://api.github.com/users/fabiospampinato/followers","following_url":"https://api.github.com/users/fabiospampinato/following{/other_user}","gists_url":"https://api.github.com/users/fabiospampinato/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiospampinato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiospampinato/subscriptions","organizations_url":"https://api.github.com/users/fabiospampinato/orgs","repos_url":"https://api.github.com/users/fabiospampinato/repos","events_url":"https://api.github.com/users/fabiospampinato/events{/privacy}","received_events_url":"https://api.github.com/users/fabiospampinato/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fabiospampinato/notable","description":"The markdown-based note-taking app that doesn't suck.","fork":false,"url":"https://api.github.com/repos/fabiospampinato/notable","forks_url":"https://api.github.com/repos/fabiospampinato/notable/forks","keys_url":"https://api.github.com/repos/fabiospampinato/notable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabiospampinato/notable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabiospampinato/notable/teams","hooks_url":"https://api.github.com/repos/fabiospampinato/notable/hooks","issue_events_url":"https://api.github.com/repos/fabiospampinato/notable/issues/events{/number}","events_url":"https://api.github.com/repos/fabiospampinato/notable/events","assignees_url":"https://api.github.com/repos/fabiospampinato/notable/assignees{/user}","branches_url":"https://api.github.com/repos/fabiospampinato/notable/branches{/branch}","tags_url":"https://api.github.com/repos/fabiospampinato/notable/tags","blobs_url":"https://api.github.com/repos/fabiospampinato/notable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabiospampinato/notable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabiospampinato/notable/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabiospampinato/notable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabiospampinato/notable/statuses/{sha}","languages_url":"https://api.github.com/repos/fabiospampinato/notable/languages","stargazers_url":"https://api.github.com/repos/fabiospampinato/notable/stargazers","contributors_url":"https://api.github.com/repos/fabiospampinato/notable/contributors","subscribers_url":"https://api.github.com/repos/fabiospampinato/notable/subscribers","subscription_url":"https://api.github.com/repos/fabiospampinato/notable/subscription","commits_url":"https://api.github.com/repos/fabiospampinato/notable/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabiospampinato/notable/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabiospampinato/notable/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabiospampinato/notable/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabiospampinato/notable/contents/{+path}","compare_url":"https://api.github.com/repos/fabiospampinato/notable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabiospampinato/notable/merges","archive_url":"https://api.github.com/repos/fabiospampinato/notable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabiospampinato/notable/downloads","issues_url":"https://api.github.com/repos/fabiospampinato/notable/issues{/number}","pulls_url":"https://api.github.com/repos/fabiospampinato/notable/pulls{/number}","milestones_url":"https://api.github.com/repos/fabiospampinato/notable/milestones{/number}","notifications_url":"https://api.github.com/repos/fabiospampinato/notable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabiospampinato/notable/labels{/name}","releases_url":"https://api.github.com/repos/fabiospampinato/notable/releases{/id}","deployments_url":"https://api.github.com/repos/fabiospampinato/notable/deployments","created_at":"2018-12-22T13:57:19Z","updated_at":"2018-12-28T20:35:18Z","pushed_at":"2018-12-28T20:25:33Z","git_url":"git://github.com/fabiospampinato/notable.git","ssh_url":"git@github.com:fabiospampinato/notable.git","clone_url":"https://github.com/fabiospampinato/notable.git","svn_url":"https://github.com/fabiospampinato/notable","homepage":null,"size":1164,"stargazers_count":2197,"watchers_count":2197,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":64,"open_issues":83,"watchers":2197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabiospampinato/notable/pulls/62"},"html":{"href":"https://github.com/fabiospampinato/notable/pull/62"},"issue":{"href":"https://api.github.com/repos/fabiospampinato/notable/issues/62"},"comments":{"href":"https://api.github.com/repos/fabiospampinato/notable/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/fabiospampinato/notable/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/fabiospampinato/notable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabiospampinato/notable/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/fabiospampinato/notable/statuses/b0c367f2551fdc1c2b4f0a4674a17ef772a0228f"}},"author_association":"NONE"}}
{"actor":{"display_login":"fabiospampinato"}}