{"action":"closed","number":288,"pull_request":{"url":"https://api.github.com/repos/kubermatic/machine-controller/pulls/288","id":204389147,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0Mzg5MTQ3","html_url":"https://github.com/kubermatic/machine-controller/pull/288","diff_url":"https://github.com/kubermatic/machine-controller/pull/288.diff","patch_url":"https://github.com/kubermatic/machine-controller/pull/288.patch","issue_url":"https://api.github.com/repos/kubermatic/machine-controller/issues/288","number":288,"state":"closed","locked":false,"title":"Fix Azure Validation & Finalizer assignment","user":{"login":"alvaroaleman","id":6496100,"node_id":"MDQ6VXNlcjY0OTYxMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/6496100?v=4","gravatar_id":"","url":"https://api.github.com/users/alvaroaleman","html_url":"https://github.com/alvaroaleman","followers_url":"https://api.github.com/users/alvaroaleman/followers","following_url":"https://api.github.com/users/alvaroaleman/following{/other_user}","gists_url":"https://api.github.com/users/alvaroaleman/gists{/gist_id}","starred_url":"https://api.github.com/users/alvaroaleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvaroaleman/subscriptions","organizations_url":"https://api.github.com/users/alvaroaleman/orgs","repos_url":"https://api.github.com/users/alvaroaleman/repos","events_url":"https://api.github.com/users/alvaroaleman/events{/privacy}","received_events_url":"https://api.github.com/users/alvaroaleman/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\n* Adds Validation for Azure Network & Subnet\r\n* Moves the finalizer assignment after successful resource creation to avoid deadlocks\r\n* Increases the e2e cleanup timeout as Azure may take quite some time there\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes e2e tests\r\n\r\n**Special notes for your reviewer**:\r\n","created_at":"2018-07-27T10:15:23Z","updated_at":"2018-07-30T10:10:31Z","closed_at":"2018-07-30T10:10:31Z","merged_at":"2018-07-30T10:10:31Z","merge_commit_sha":"83721010bf05a0aa1844a1a28bcdb656bde768af","assignee":{"login":"alvaroaleman","id":6496100,"node_id":"MDQ6VXNlcjY0OTYxMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/6496100?v=4","gravatar_id":"","url":"https://api.github.com/users/alvaroaleman","html_url":"https://github.com/alvaroaleman","followers_url":"https://api.github.com/users/alvaroaleman/followers","following_url":"https://api.github.com/users/alvaroaleman/following{/other_user}","gists_url":"https://api.github.com/users/alvaroaleman/gists{/gist_id}","starred_url":"https://api.github.com/users/alvaroaleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvaroaleman/subscriptions","organizations_url":"https://api.github.com/users/alvaroaleman/orgs","repos_url":"https://api.github.com/users/alvaroaleman/repos","events_url":"https://api.github.com/users/alvaroaleman/events{/privacy}","received_events_url":"https://api.github.com/users/alvaroaleman/received_events","type":"User","site_admin":false},"assignees":[{"login":"alvaroaleman","id":6496100,"node_id":"MDQ6VXNlcjY0OTYxMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/6496100?v=4","gravatar_id":"","url":"https://api.github.com/users/alvaroaleman","html_url":"https://github.com/alvaroaleman","followers_url":"https://api.github.com/users/alvaroaleman/followers","following_url":"https://api.github.com/users/alvaroaleman/following{/other_user}","gists_url":"https://api.github.com/users/alvaroaleman/gists{/gist_id}","starred_url":"https://api.github.com/users/alvaroaleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvaroaleman/subscriptions","organizations_url":"https://api.github.com/users/alvaroaleman/orgs","repos_url":"https://api.github.com/users/alvaroaleman/repos","events_url":"https://api.github.com/users/alvaroaleman/events{/privacy}","received_events_url":"https://api.github.com/users/alvaroaleman/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":824250688,"node_id":"MDU6TGFiZWw4MjQyNTA2ODg=","url":"https://api.github.com/repos/kubermatic/machine-controller/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubermatic/machine-controller/pulls/288/commits","review_comments_url":"https://api.github.com/repos/kubermatic/machine-controller/pulls/288/comments","review_comment_url":"https://api.github.com/repos/kubermatic/machine-controller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubermatic/machine-controller/issues/288/comments","statuses_url":"https://api.github.com/repos/kubermatic/machine-controller/statuses/d58a622d29989237eaa75ca8f5927813b2672bc9","head":{"label":"kubermatic:fixup-azure-finalizers","ref":"fixup-azure-finalizers","sha":"d58a622d29989237eaa75ca8f5927813b2672bc9","user":{"login":"kubermatic","id":17001193,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDAxMTkz","avatar_url":"https://avatars2.githubusercontent.com/u/17001193?v=4","gravatar_id":"","url":"https://api.github.com/users/kubermatic","html_url":"https://github.com/kubermatic","followers_url":"https://api.github.com/users/kubermatic/followers","following_url":"https://api.github.com/users/kubermatic/following{/other_user}","gists_url":"https://api.github.com/users/kubermatic/gists{/gist_id}","starred_url":"https://api.github.com/users/kubermatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubermatic/subscriptions","organizations_url":"https://api.github.com/users/kubermatic/orgs","repos_url":"https://api.github.com/users/kubermatic/repos","events_url":"https://api.github.com/users/kubermatic/events{/privacy}","received_events_url":"https://api.github.com/users/kubermatic/received_events","type":"Organization","site_admin":false},"repo":{"id":115267126,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUyNjcxMjY=","name":"machine-controller","full_name":"kubermatic/machine-controller","owner":{"login":"kubermatic","id":17001193,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDAxMTkz","avatar_url":"https://avatars2.githubusercontent.com/u/17001193?v=4","gravatar_id":"","url":"https://api.github.com/users/kubermatic","html_url":"https://github.com/kubermatic","followers_url":"https://api.github.com/users/kubermatic/followers","following_url":"https://api.github.com/users/kubermatic/following{/other_user}","gists_url":"https://api.github.com/users/kubermatic/gists{/gist_id}","starred_url":"https://api.github.com/users/kubermatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubermatic/subscriptions","organizations_url":"https://api.github.com/users/kubermatic/orgs","repos_url":"https://api.github.com/users/kubermatic/repos","events_url":"https://api.github.com/users/kubermatic/events{/privacy}","received_events_url":"https://api.github.com/users/kubermatic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubermatic/machine-controller","description":null,"fork":false,"url":"https://api.github.com/repos/kubermatic/machine-controller","forks_url":"https://api.github.com/repos/kubermatic/machine-controller/forks","keys_url":"https://api.github.com/repos/kubermatic/machine-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubermatic/machine-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubermatic/machine-controller/teams","hooks_url":"https://api.github.com/repos/kubermatic/machine-controller/hooks","issue_events_url":"https://api.github.com/repos/kubermatic/machine-controller/issues/events{/number}","events_url":"https://api.github.com/repos/kubermatic/machine-controller/events","assignees_url":"https://api.github.com/repos/kubermatic/machine-controller/assignees{/user}","branches_url":"https://api.github.com/repos/kubermatic/machine-controller/branches{/branch}","tags_url":"https://api.github.com/repos/kubermatic/machine-controller/tags","blobs_url":"https://api.github.com/repos/kubermatic/machine-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubermatic/machine-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubermatic/machine-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubermatic/machine-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubermatic/machine-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/kubermatic/machine-controller/languages","stargazers_url":"https://api.github.com/repos/kubermatic/machine-controller/stargazers","contributors_url":"https://api.github.com/repos/kubermatic/machine-controller/contributors","subscribers_url":"https://api.github.com/repos/kubermatic/machine-controller/subscribers","subscription_url":"https://api.github.com/repos/kubermatic/machine-controller/subscription","commits_url":"https://api.github.com/repos/kubermatic/machine-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubermatic/machine-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubermatic/machine-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubermatic/machine-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubermatic/machine-controller/contents/{+path}","compare_url":"https://api.github.com/repos/kubermatic/machine-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubermatic/machine-controller/merges","archive_url":"https://api.github.com/repos/kubermatic/machine-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubermatic/machine-controller/downloads","issues_url":"https://api.github.com/repos/kubermatic/machine-controller/issues{/number}","pulls_url":"https://api.github.com/repos/kubermatic/machine-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/kubermatic/machine-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/kubermatic/machine-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubermatic/machine-controller/labels{/name}","releases_url":"https://api.github.com/repos/kubermatic/machine-controller/releases{/id}","deployments_url":"https://api.github.com/repos/kubermatic/machine-controller/deployments","created_at":"2017-12-24T14:12:56Z","updated_at":"2018-07-30T07:55:27Z","pushed_at":"2018-07-30T10:10:31Z","git_url":"git://github.com/kubermatic/machine-controller.git","ssh_url":"git@github.com:kubermatic/machine-controller.git","clone_url":"https://github.com/kubermatic/machine-controller.git","svn_url":"https://github.com/kubermatic/machine-controller","homepage":null,"size":9671,"stargazers_count":17,"watchers_count":17,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":19,"watchers":17,"default_branch":"master"}},"base":{"label":"kubermatic:master","ref":"master","sha":"45068daf69414a2b856380a6933bc98c603b8362","user":{"login":"kubermatic","id":17001193,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDAxMTkz","avatar_url":"https://avatars2.githubusercontent.com/u/17001193?v=4","gravatar_id":"","url":"https://api.github.com/users/kubermatic","html_url":"https://github.com/kubermatic","followers_url":"https://api.github.com/users/kubermatic/followers","following_url":"https://api.github.com/users/kubermatic/following{/other_user}","gists_url":"https://api.github.com/users/kubermatic/gists{/gist_id}","starred_url":"https://api.github.com/users/kubermatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubermatic/subscriptions","organizations_url":"https://api.github.com/users/kubermatic/orgs","repos_url":"https://api.github.com/users/kubermatic/repos","events_url":"https://api.github.com/users/kubermatic/events{/privacy}","received_events_url":"https://api.github.com/users/kubermatic/received_events","type":"Organization","site_admin":false},"repo":{"id":115267126,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUyNjcxMjY=","name":"machine-controller","full_name":"kubermatic/machine-controller","owner":{"login":"kubermatic","id":17001193,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDAxMTkz","avatar_url":"https://avatars2.githubusercontent.com/u/17001193?v=4","gravatar_id":"","url":"https://api.github.com/users/kubermatic","html_url":"https://github.com/kubermatic","followers_url":"https://api.github.com/users/kubermatic/followers","following_url":"https://api.github.com/users/kubermatic/following{/other_user}","gists_url":"https://api.github.com/users/kubermatic/gists{/gist_id}","starred_url":"https://api.github.com/users/kubermatic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubermatic/subscriptions","organizations_url":"https://api.github.com/users/kubermatic/orgs","repos_url":"https://api.github.com/users/kubermatic/repos","events_url":"https://api.github.com/users/kubermatic/events{/privacy}","received_events_url":"https://api.github.com/users/kubermatic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubermatic/machine-controller","description":null,"fork":false,"url":"https://api.github.com/repos/kubermatic/machine-controller","forks_url":"https://api.github.com/repos/kubermatic/machine-controller/forks","keys_url":"https://api.github.com/repos/kubermatic/machine-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubermatic/machine-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubermatic/machine-controller/teams","hooks_url":"https://api.github.com/repos/kubermatic/machine-controller/hooks","issue_events_url":"https://api.github.com/repos/kubermatic/machine-controller/issues/events{/number}","events_url":"https://api.github.com/repos/kubermatic/machine-controller/events","assignees_url":"https://api.github.com/repos/kubermatic/machine-controller/assignees{/user}","branches_url":"https://api.github.com/repos/kubermatic/machine-controller/branches{/branch}","tags_url":"https://api.github.com/repos/kubermatic/machine-controller/tags","blobs_url":"https://api.github.com/repos/kubermatic/machine-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubermatic/machine-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubermatic/machine-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubermatic/machine-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubermatic/machine-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/kubermatic/machine-controller/languages","stargazers_url":"https://api.github.com/repos/kubermatic/machine-controller/stargazers","contributors_url":"https://api.github.com/repos/kubermatic/machine-controller/contributors","subscribers_url":"https://api.github.com/repos/kubermatic/machine-controller/subscribers","subscription_url":"https://api.github.com/repos/kubermatic/machine-controller/subscription","commits_url":"https://api.github.com/repos/kubermatic/machine-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubermatic/machine-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubermatic/machine-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubermatic/machine-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubermatic/machine-controller/contents/{+path}","compare_url":"https://api.github.com/repos/kubermatic/machine-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubermatic/machine-controller/merges","archive_url":"https://api.github.com/repos/kubermatic/machine-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubermatic/machine-controller/downloads","issues_url":"https://api.github.com/repos/kubermatic/machine-controller/issues{/number}","pulls_url":"https://api.github.com/repos/kubermatic/machine-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/kubermatic/machine-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/kubermatic/machine-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubermatic/machine-controller/labels{/name}","releases_url":"https://api.github.com/repos/kubermatic/machine-controller/releases{/id}","deployments_url":"https://api.github.com/repos/kubermatic/machine-controller/deployments","created_at":"2017-12-24T14:12:56Z","updated_at":"2018-07-30T07:55:27Z","pushed_at":"2018-07-30T10:10:31Z","git_url":"git://github.com/kubermatic/machine-controller.git","ssh_url":"git@github.com:kubermatic/machine-controller.git","clone_url":"https://github.com/kubermatic/machine-controller.git","svn_url":"https://github.com/kubermatic/machine-controller","homepage":null,"size":9671,"stargazers_count":17,"watchers_count":17,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":19,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubermatic/machine-controller/pulls/288"},"html":{"href":"https://github.com/kubermatic/machine-controller/pull/288"},"issue":{"href":"https://api.github.com/repos/kubermatic/machine-controller/issues/288"},"comments":{"href":"https://api.github.com/repos/kubermatic/machine-controller/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/kubermatic/machine-controller/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/kubermatic/machine-controller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubermatic/machine-controller/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/kubermatic/machine-controller/statuses/d58a622d29989237eaa75ca8f5927813b2672bc9"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"alvaroaleman","id":6496100,"node_id":"MDQ6VXNlcjY0OTYxMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/6496100?v=4","gravatar_id":"","url":"https://api.github.com/users/alvaroaleman","html_url":"https://github.com/alvaroaleman","followers_url":"https://api.github.com/users/alvaroaleman/followers","following_url":"https://api.github.com/users/alvaroaleman/following{/other_user}","gists_url":"https://api.github.com/users/alvaroaleman/gists{/gist_id}","starred_url":"https://api.github.com/users/alvaroaleman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvaroaleman/subscriptions","organizations_url":"https://api.github.com/users/alvaroaleman/orgs","repos_url":"https://api.github.com/users/alvaroaleman/repos","events_url":"https://api.github.com/users/alvaroaleman/events{/privacy}","received_events_url":"https://api.github.com/users/alvaroaleman/received_events","type":"User","site_admin":false},"comments":3,"review_comments":12,"maintainer_can_modify":false,"commits":21,"additions":124,"deletions":71,"changed_files":14}}
{"actor":{"display_login":"alvaroaleman"}}