{"action":"created","comment":{"url":"https://api.github.com/repos/INCF/bids-validator/pulls/comments/209702747","pull_request_review_id":145764710,"id":209702747,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTcwMjc0Nw==","diff_hunk":"@@ -40,6 +41,12 @@ function checkUnits (file, sidecar) {\n             schema = require('./schemas/dataset_description.json');\n         } else if (file.name.endsWith(\"meg.json\")) {\n             schema = require('./schemas/meg.json');\n+        } else if (file.name.endsWith(\"ieeg.json\")) {\n+            schema = require('./schemas/ieeg.json');\n+        } else if (file.path.includes('/meg/') && file.name.endsWith(\"coordsystem.json\")) {\n+            schema = require('./schemas/coordsystem_meg.json');\n+        } else if (file.path.includes('/ieeg/') && file.name.endsWith(\"coordsystem.json\")) {\n+            schema = require('./schemas/coordsystem_ieeg.json');\n         } else if (file.name.endsWith(\"eeg.json\")) {","path":"validators/json.js","position":18,"original_position":18,"commit_id":"68fb39c25577119b4c25ba6aa87bec647f66f584","original_commit_id":"68fb39c25577119b4c25ba6aa87bec647f66f584","user":{"login":"sappelhoff","id":9084751,"node_id":"MDQ6VXNlcjkwODQ3NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9084751?v=4","gravatar_id":"","url":"https://api.github.com/users/sappelhoff","html_url":"https://github.com/sappelhoff","followers_url":"https://api.github.com/users/sappelhoff/followers","following_url":"https://api.github.com/users/sappelhoff/following{/other_user}","gists_url":"https://api.github.com/users/sappelhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/sappelhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sappelhoff/subscriptions","organizations_url":"https://api.github.com/users/sappelhoff/orgs","repos_url":"https://api.github.com/users/sappelhoff/repos","events_url":"https://api.github.com/users/sappelhoff/events{/privacy}","received_events_url":"https://api.github.com/users/sappelhoff/received_events","type":"User","site_admin":false},"body":"Note: there is no `coordsystem_eeg.json` yet ... we should add that ... but after merging this PR","created_at":"2018-08-13T18:00:04Z","updated_at":"2018-08-13T18:05:07Z","html_url":"https://github.com/INCF/bids-validator/pull/451#discussion_r209702747","pull_request_url":"https://api.github.com/repos/INCF/bids-validator/pulls/451","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/INCF/bids-validator/pulls/comments/209702747"},"html":{"href":"https://github.com/INCF/bids-validator/pull/451#discussion_r209702747"},"pull_request":{"href":"https://api.github.com/repos/INCF/bids-validator/pulls/451"}}},"pull_request":{"url":"https://api.github.com/repos/INCF/bids-validator/pulls/451","id":179479214,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc5NDc5MjE0","html_url":"https://github.com/INCF/bids-validator/pull/451","diff_url":"https://github.com/INCF/bids-validator/pull/451.diff","patch_url":"https://github.com/INCF/bids-validator/pull/451.patch","issue_url":"https://api.github.com/repos/INCF/bids-validator/issues/451","number":451,"state":"open","locked":false,"title":"[WIP] iEEG validator extension","user":{"login":"choldgraf","id":1839645,"node_id":"MDQ6VXNlcjE4Mzk2NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1839645?v=4","gravatar_id":"","url":"https://api.github.com/users/choldgraf","html_url":"https://github.com/choldgraf","followers_url":"https://api.github.com/users/choldgraf/followers","following_url":"https://api.github.com/users/choldgraf/following{/other_user}","gists_url":"https://api.github.com/users/choldgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/choldgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choldgraf/subscriptions","organizations_url":"https://api.github.com/users/choldgraf/orgs","repos_url":"https://api.github.com/users/choldgraf/repos","events_url":"https://api.github.com/users/choldgraf/events{/privacy}","received_events_url":"https://api.github.com/users/choldgraf/received_events","type":"User","site_admin":false},"body":"This PR adds validation for the iEEG specification. It's still WIP and is basically a riff off of @jasmainak 's MEG PR. Still a WIP but comments are definitely welcome.\r\n\r\n## To-do list for this PR to get merged\r\n\r\n- [ ] Agree on how to reference the coordinate systems in the main BIDS spec\r\n- [ ] Agree on nomenclature around \"electrodes\" vs \"contacts\" (e.g. for electrode shanks vs single electrodes)\r\n- [ ] Decide on a final list of file extensions to support.\r\n  - Current extensions suggested: EDF, VHDR\r\n  - Current extensions allowed in addition: MEF3, SET, NWB\r\n  - In particular @jasmainak and @teonbrooks showed concerns with having EDF as a primary format we recommend people use.\r\n- [ ] Decide whether we want javascript readers to be a blocker on the specification\r\n- [ ] Decide whether we want python readers to be a blocker on the specification\r\n- [ ] Figure out prefixes for units\r\n- [ ] Relatively minor spot-checks in the google doc\r\n- [ ] Final pass\r\n- [ ] Merge!\r\n\r\n<details>\r\n<summary>Old comments from before</summary>\r\n\r\nA few thoughts that came up with this first pass:\r\n\r\n* Here: do we need `_ieeg` and `_meg` for each of the electrodes/channels files (e.g., should we do `channels.tsv` -> `channels_meg.tsv`? Here are some points where this might be relevant:\r\n  * https://github.com/INCF/bids-validator/pull/301/files#diff-bca076162864b02c2dbe628ed44a653cR61\r\n  * https://github.com/INCF/bids-validator/pull/301/files#diff-bca076162864b02c2dbe628ed44a653cR108\r\n  * https://github.com/INCF/bids-validator/pull/301/files#diff-bca076162864b02c2dbe628ed44a653cR196\r\n  * https://github.com/INCF/bids-validator/pull/301/files#diff-bb569ec823383674890ed051c0aab5f5R42\r\n* Or can we just update the coordsystem schema to include ieeg?\r\n  * https://github.com/INCF/bids-validator/pull/301/files#diff-edddc921ee448ec0b00eb10faf4ac9d6R3\r\n* Does it make sense to merge some of the JSONSchemas into a \"shared\" schema and\r\n  then use the same \"inheritance\" principle so we only define the schema items\r\n  that differ for each type of data? At the least we could have a `base.json`\r\n  that holds fields to be shared between all data\r\n* Does the MEG spec have \"electrodes.tsv\" or is this just iEEG? I didn't see\r\n  anything about `electrodes.tsv` in Mainak's PR.\r\n* Where is the check for optional fields in TSV files? E.g., can we create a\r\n  JSONSchema for TSV files where keys map onto columns, and \"type\" maps on to the\r\n  type for each column?\r\n</details>\r\n\r\n\r\ncc @chrisfilo @dorahermes @tyarkoni @jasmainak who may be interested or have thoughts","created_at":"2018-04-04T18:47:24Z","updated_at":"2018-08-13T18:05:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8a690d531c3895e560f383c52a487d8f4e24b10","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/INCF/bids-validator/pulls/451/commits","review_comments_url":"https://api.github.com/repos/INCF/bids-validator/pulls/451/comments","review_comment_url":"https://api.github.com/repos/INCF/bids-validator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/INCF/bids-validator/issues/451/comments","statuses_url":"https://api.github.com/repos/INCF/bids-validator/statuses/68fb39c25577119b4c25ba6aa87bec647f66f584","head":{"label":"choldgraf:ieeg","ref":"ieeg","sha":"68fb39c25577119b4c25ba6aa87bec647f66f584","user":{"login":"choldgraf","id":1839645,"node_id":"MDQ6VXNlcjE4Mzk2NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1839645?v=4","gravatar_id":"","url":"https://api.github.com/users/choldgraf","html_url":"https://github.com/choldgraf","followers_url":"https://api.github.com/users/choldgraf/followers","following_url":"https://api.github.com/users/choldgraf/following{/other_user}","gists_url":"https://api.github.com/users/choldgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/choldgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choldgraf/subscriptions","organizations_url":"https://api.github.com/users/choldgraf/orgs","repos_url":"https://api.github.com/users/choldgraf/repos","events_url":"https://api.github.com/users/choldgraf/events{/privacy}","received_events_url":"https://api.github.com/users/choldgraf/received_events","type":"User","site_admin":false},"repo":{"id":124791770,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ3OTE3NzA=","name":"bids-validator","full_name":"choldgraf/bids-validator","owner":{"login":"choldgraf","id":1839645,"node_id":"MDQ6VXNlcjE4Mzk2NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/1839645?v=4","gravatar_id":"","url":"https://api.github.com/users/choldgraf","html_url":"https://github.com/choldgraf","followers_url":"https://api.github.com/users/choldgraf/followers","following_url":"https://api.github.com/users/choldgraf/following{/other_user}","gists_url":"https://api.github.com/users/choldgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/choldgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choldgraf/subscriptions","organizations_url":"https://api.github.com/users/choldgraf/orgs","repos_url":"https://api.github.com/users/choldgraf/repos","events_url":"https://api.github.com/users/choldgraf/events{/privacy}","received_events_url":"https://api.github.com/users/choldgraf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/choldgraf/bids-validator","description":"Validator for the Brain Imaging Data Structure","fork":true,"url":"https://api.github.com/repos/choldgraf/bids-validator","forks_url":"https://api.github.com/repos/choldgraf/bids-validator/forks","keys_url":"https://api.github.com/repos/choldgraf/bids-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/choldgraf/bids-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/choldgraf/bids-validator/teams","hooks_url":"https://api.github.com/repos/choldgraf/bids-validator/hooks","issue_events_url":"https://api.github.com/repos/choldgraf/bids-validator/issues/events{/number}","events_url":"https://api.github.com/repos/choldgraf/bids-validator/events","assignees_url":"https://api.github.com/repos/choldgraf/bids-validator/assignees{/user}","branches_url":"https://api.github.com/repos/choldgraf/bids-validator/branches{/branch}","tags_url":"https://api.github.com/repos/choldgraf/bids-validator/tags","blobs_url":"https://api.github.com/repos/choldgraf/bids-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/choldgraf/bids-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/choldgraf/bids-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/choldgraf/bids-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/choldgraf/bids-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/choldgraf/bids-validator/languages","stargazers_url":"https://api.github.com/repos/choldgraf/bids-validator/stargazers","contributors_url":"https://api.github.com/repos/choldgraf/bids-validator/contributors","subscribers_url":"https://api.github.com/repos/choldgraf/bids-validator/subscribers","subscription_url":"https://api.github.com/repos/choldgraf/bids-validator/subscription","commits_url":"https://api.github.com/repos/choldgraf/bids-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/choldgraf/bids-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/choldgraf/bids-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/choldgraf/bids-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/choldgraf/bids-validator/contents/{+path}","compare_url":"https://api.github.com/repos/choldgraf/bids-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/choldgraf/bids-validator/merges","archive_url":"https://api.github.com/repos/choldgraf/bids-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/choldgraf/bids-validator/downloads","issues_url":"https://api.github.com/repos/choldgraf/bids-validator/issues{/number}","pulls_url":"https://api.github.com/repos/choldgraf/bids-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/choldgraf/bids-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/choldgraf/bids-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/choldgraf/bids-validator/labels{/name}","releases_url":"https://api.github.com/repos/choldgraf/bids-validator/releases{/id}","deployments_url":"https://api.github.com/repos/choldgraf/bids-validator/deployments","created_at":"2018-03-11T19:38:44Z","updated_at":"2018-03-11T19:38:46Z","pushed_at":"2018-08-13T16:50:35Z","git_url":"git://github.com/choldgraf/bids-validator.git","ssh_url":"git@github.com:choldgraf/bids-validator.git","clone_url":"https://github.com/choldgraf/bids-validator.git","svn_url":"https://github.com/choldgraf/bids-validator","homepage":"http://incf.github.io/bids-validator","size":25235,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"INCF:master","ref":"master","sha":"1e02e8125cbb342a087fc073ceec5814a15143d8","user":{"login":"INCF","id":758175,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1ODE3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/758175?v=4","gravatar_id":"","url":"https://api.github.com/users/INCF","html_url":"https://github.com/INCF","followers_url":"https://api.github.com/users/INCF/followers","following_url":"https://api.github.com/users/INCF/following{/other_user}","gists_url":"https://api.github.com/users/INCF/gists{/gist_id}","starred_url":"https://api.github.com/users/INCF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INCF/subscriptions","organizations_url":"https://api.github.com/users/INCF/orgs","repos_url":"https://api.github.com/users/INCF/repos","events_url":"https://api.github.com/users/INCF/events{/privacy}","received_events_url":"https://api.github.com/users/INCF/received_events","type":"Organization","site_admin":false},"repo":{"id":37161308,"node_id":"MDEwOlJlcG9zaXRvcnkzNzE2MTMwOA==","name":"bids-validator","full_name":"INCF/bids-validator","owner":{"login":"INCF","id":758175,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1ODE3NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/758175?v=4","gravatar_id":"","url":"https://api.github.com/users/INCF","html_url":"https://github.com/INCF","followers_url":"https://api.github.com/users/INCF/followers","following_url":"https://api.github.com/users/INCF/following{/other_user}","gists_url":"https://api.github.com/users/INCF/gists{/gist_id}","starred_url":"https://api.github.com/users/INCF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/INCF/subscriptions","organizations_url":"https://api.github.com/users/INCF/orgs","repos_url":"https://api.github.com/users/INCF/repos","events_url":"https://api.github.com/users/INCF/events{/privacy}","received_events_url":"https://api.github.com/users/INCF/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/INCF/bids-validator","description":"Validator for the Brain Imaging Data Structure","fork":false,"url":"https://api.github.com/repos/INCF/bids-validator","forks_url":"https://api.github.com/repos/INCF/bids-validator/forks","keys_url":"https://api.github.com/repos/INCF/bids-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/INCF/bids-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/INCF/bids-validator/teams","hooks_url":"https://api.github.com/repos/INCF/bids-validator/hooks","issue_events_url":"https://api.github.com/repos/INCF/bids-validator/issues/events{/number}","events_url":"https://api.github.com/repos/INCF/bids-validator/events","assignees_url":"https://api.github.com/repos/INCF/bids-validator/assignees{/user}","branches_url":"https://api.github.com/repos/INCF/bids-validator/branches{/branch}","tags_url":"https://api.github.com/repos/INCF/bids-validator/tags","blobs_url":"https://api.github.com/repos/INCF/bids-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/INCF/bids-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/INCF/bids-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/INCF/bids-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/INCF/bids-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/INCF/bids-validator/languages","stargazers_url":"https://api.github.com/repos/INCF/bids-validator/stargazers","contributors_url":"https://api.github.com/repos/INCF/bids-validator/contributors","subscribers_url":"https://api.github.com/repos/INCF/bids-validator/subscribers","subscription_url":"https://api.github.com/repos/INCF/bids-validator/subscription","commits_url":"https://api.github.com/repos/INCF/bids-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/INCF/bids-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/INCF/bids-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/INCF/bids-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/INCF/bids-validator/contents/{+path}","compare_url":"https://api.github.com/repos/INCF/bids-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/INCF/bids-validator/merges","archive_url":"https://api.github.com/repos/INCF/bids-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/INCF/bids-validator/downloads","issues_url":"https://api.github.com/repos/INCF/bids-validator/issues{/number}","pulls_url":"https://api.github.com/repos/INCF/bids-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/INCF/bids-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/INCF/bids-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/INCF/bids-validator/labels{/name}","releases_url":"https://api.github.com/repos/INCF/bids-validator/releases{/id}","deployments_url":"https://api.github.com/repos/INCF/bids-validator/deployments","created_at":"2015-06-09T22:08:27Z","updated_at":"2018-08-13T16:29:33Z","pushed_at":"2018-08-13T16:50:36Z","git_url":"git://github.com/INCF/bids-validator.git","ssh_url":"git@github.com:INCF/bids-validator.git","clone_url":"https://github.com/INCF/bids-validator.git","svn_url":"https://github.com/INCF/bids-validator","homepage":"http://incf.github.io/bids-validator","size":27108,"stargazers_count":43,"watchers_count":43,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":40,"open_issues":66,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/INCF/bids-validator/pulls/451"},"html":{"href":"https://github.com/INCF/bids-validator/pull/451"},"issue":{"href":"https://api.github.com/repos/INCF/bids-validator/issues/451"},"comments":{"href":"https://api.github.com/repos/INCF/bids-validator/issues/451/comments"},"review_comments":{"href":"https://api.github.com/repos/INCF/bids-validator/pulls/451/comments"},"review_comment":{"href":"https://api.github.com/repos/INCF/bids-validator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/INCF/bids-validator/pulls/451/commits"},"statuses":{"href":"https://api.github.com/repos/INCF/bids-validator/statuses/68fb39c25577119b4c25ba6aa87bec647f66f584"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sappelhoff"}}