{"action":"created","issue":{"url":"https://api.github.com/repos/rosstuck/TuckConverterBundle/issues/18","repository_url":"https://api.github.com/repos/rosstuck/TuckConverterBundle","labels_url":"https://api.github.com/repos/rosstuck/TuckConverterBundle/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/rosstuck/TuckConverterBundle/issues/18/comments","events_url":"https://api.github.com/repos/rosstuck/TuckConverterBundle/issues/18/events","html_url":"https://github.com/rosstuck/TuckConverterBundle/issues/18","id":305562058,"number":18,"title":"Conversion error with defaults tag","user":{"login":"mweimerskirch","id":362092,"avatar_url":"https://avatars3.githubusercontent.com/u/362092?v=4","gravatar_id":"","url":"https://api.github.com/users/mweimerskirch","html_url":"https://github.com/mweimerskirch","followers_url":"https://api.github.com/users/mweimerskirch/followers","following_url":"https://api.github.com/users/mweimerskirch/following{/other_user}","gists_url":"https://api.github.com/users/mweimerskirch/gists{/gist_id}","starred_url":"https://api.github.com/users/mweimerskirch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mweimerskirch/subscriptions","organizations_url":"https://api.github.com/users/mweimerskirch/orgs","repos_url":"https://api.github.com/users/mweimerskirch/repos","events_url":"https://api.github.com/users/mweimerskirch/events{/privacy}","received_events_url":"https://api.github.com/users/mweimerskirch/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-15T13:54:51Z","updated_at":"2018-03-29T11:51:53Z","closed_at":null,"author_association":"NONE","body":"I got a \"conversion error\" with the following file:\r\nhttps://github.com/symfony/symfony/blob/3.4/src/Symfony/Bundle/TwigBundle/Resources/config/form.xml\r\n\r\nThe problem seems to be the \"defaults\" tag: \r\n\r\n     <defaults public=\"false\" />\r\n\r\nwhich should be converted to\r\n\r\n     _defaults:\r\n       public: false"},"comment":{"url":"https://api.github.com/repos/rosstuck/TuckConverterBundle/issues/comments/377211034","html_url":"https://github.com/rosstuck/TuckConverterBundle/issues/18#issuecomment-377211034","issue_url":"https://api.github.com/repos/rosstuck/TuckConverterBundle/issues/18","id":377211034,"user":{"login":"mweimerskirch","id":362092,"avatar_url":"https://avatars3.githubusercontent.com/u/362092?v=4","gravatar_id":"","url":"https://api.github.com/users/mweimerskirch","html_url":"https://github.com/mweimerskirch","followers_url":"https://api.github.com/users/mweimerskirch/followers","following_url":"https://api.github.com/users/mweimerskirch/following{/other_user}","gists_url":"https://api.github.com/users/mweimerskirch/gists{/gist_id}","starred_url":"https://api.github.com/users/mweimerskirch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mweimerskirch/subscriptions","organizations_url":"https://api.github.com/users/mweimerskirch/orgs","repos_url":"https://api.github.com/users/mweimerskirch/repos","events_url":"https://api.github.com/users/mweimerskirch/events{/privacy}","received_events_url":"https://api.github.com/users/mweimerskirch/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T11:51:52Z","updated_at":"2018-03-29T11:51:52Z","author_association":"NONE","body":"Thanks for your feedback. I just tried updating the dependencies. Instead of converting the <defaults> tag, the \"public: false\" is added to all the converted services, so instead of this:\r\n\r\n```services:\r\n    _defaults:\r\n        public: false\r\n    test.average:\r\n        class: '%test.average.class%'\r\n        tags:\r\n            - { name: test.faketag }\r\n        arguments: ['@test.loader.factory', '@test.dumper.factory']\r\n    test.empty:\r\n        class: '%test.empty.class%'\r\n```\r\nthe output is this:\r\n```services:\r\n    test.average:\r\n        class: '%test.average.class%'\r\n        tags:\r\n            - { name: test.faketag }\r\n        arguments: ['@test.loader.factory', '@test.dumper.factory']\r\n        public: false\r\n    test.empty:\r\n        class: '%test.empty.class%'\r\n        public: false\r\n```\r\n\r\nHere's what I was working on: https://github.com/mweimerskirch/TuckaConverterBundle/commits/master\r\nI'm not sure this can even be fixed, and if it does, a proper fix will probably be much more complex."}}
{"actor":{"display_login":"mweimerskirch"}}