{"action":"created","comment":{"url":"https://api.github.com/repos/connexta/saml-conformance/pulls/comments/180264890","pull_request_review_id":110656441,"id":180264890,"diff_hunk":"@@ -120,13 +120,6 @@ class TestCommon {\n          */\n         fun parseErrorResponse(response: Response): IdpResponseDecorator {\n             return if (response.header(\"Location\") != null) {\n-                /*\n-                 * TODO \"Manually change DDF IdP to respond with 302/303 status code for Redirect\"","path":"ctk/common/src/main/kotlin/org/codice/compliance/utils/TestCommon.kt","position":5,"original_position":5,"commit_id":"4858cf19fe19a85f067684302ff11a74d22923b9","original_commit_id":"4858cf19fe19a85f067684302ff11a74d22923b9","user":{"login":"blen-desta","id":29550062,"avatar_url":"https://avatars0.githubusercontent.com/u/29550062?v=4","gravatar_id":"","url":"https://api.github.com/users/blen-desta","html_url":"https://github.com/blen-desta","followers_url":"https://api.github.com/users/blen-desta/followers","following_url":"https://api.github.com/users/blen-desta/following{/other_user}","gists_url":"https://api.github.com/users/blen-desta/gists{/gist_id}","starred_url":"https://api.github.com/users/blen-desta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blen-desta/subscriptions","organizations_url":"https://api.github.com/users/blen-desta/orgs","repos_url":"https://api.github.com/users/blen-desta/repos","events_url":"https://api.github.com/users/blen-desta/events{/privacy}","received_events_url":"https://api.github.com/users/blen-desta/received_events","type":"User","site_admin":false},"body":"I removed it cause we aren't doing that anymore. We will be responding exclusively with POST. We still might want to do it for log out so I will document that in the ticket.","created_at":"2018-04-10T00:03:57Z","updated_at":"2018-04-10T00:03:57Z","html_url":"https://github.com/connexta/saml-conformance/pull/85#discussion_r180264890","pull_request_url":"https://api.github.com/repos/connexta/saml-conformance/pulls/85","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/connexta/saml-conformance/pulls/comments/180264890"},"html":{"href":"https://github.com/connexta/saml-conformance/pull/85#discussion_r180264890"},"pull_request":{"href":"https://api.github.com/repos/connexta/saml-conformance/pulls/85"}},"in_reply_to_id":180263994},"pull_request":{"url":"https://api.github.com/repos/connexta/saml-conformance/pulls/85","id":180439964,"html_url":"https://github.com/connexta/saml-conformance/pull/85","diff_url":"https://github.com/connexta/saml-conformance/pull/85.diff","patch_url":"https://github.com/connexta/saml-conformance/pull/85.patch","issue_url":"https://api.github.com/repos/connexta/saml-conformance/issues/85","number":85,"state":"open","locked":false,"title":"MAINT - Removed TODOs","user":{"login":"blen-desta","id":29550062,"avatar_url":"https://avatars0.githubusercontent.com/u/29550062?v=4","gravatar_id":"","url":"https://api.github.com/users/blen-desta","html_url":"https://github.com/blen-desta","followers_url":"https://api.github.com/users/blen-desta/followers","following_url":"https://api.github.com/users/blen-desta/following{/other_user}","gists_url":"https://api.github.com/users/blen-desta/gists{/gist_id}","starred_url":"https://api.github.com/users/blen-desta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blen-desta/subscriptions","organizations_url":"https://api.github.com/users/blen-desta/orgs","repos_url":"https://api.github.com/users/blen-desta/repos","events_url":"https://api.github.com/users/blen-desta/events{/privacy}","received_events_url":"https://api.github.com/users/blen-desta/received_events","type":"User","site_admin":false},"body":"- Removed TODOs that are not relevant\r\n- Removed TODOs in exception codes (since no one is looking at the existing one and we have tickets tracking them)\r\n- Created cards for remaining TODOs","created_at":"2018-04-09T22:04:18Z","updated_at":"2018-04-10T00:03:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3a601923dbfbc50757b2ac96228f63956108788","assignee":null,"assignees":[],"requested_reviewers":[{"login":"brjeter","id":8130140,"avatar_url":"https://avatars3.githubusercontent.com/u/8130140?v=4","gravatar_id":"","url":"https://api.github.com/users/brjeter","html_url":"https://github.com/brjeter","followers_url":"https://api.github.com/users/brjeter/followers","following_url":"https://api.github.com/users/brjeter/following{/other_user}","gists_url":"https://api.github.com/users/brjeter/gists{/gist_id}","starred_url":"https://api.github.com/users/brjeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brjeter/subscriptions","organizations_url":"https://api.github.com/users/brjeter/orgs","repos_url":"https://api.github.com/users/brjeter/repos","events_url":"https://api.github.com/users/brjeter/events{/privacy}","received_events_url":"https://api.github.com/users/brjeter/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/connexta/saml-conformance/pulls/85/commits","review_comments_url":"https://api.github.com/repos/connexta/saml-conformance/pulls/85/comments","review_comment_url":"https://api.github.com/repos/connexta/saml-conformance/pulls/comments{/number}","comments_url":"https://api.github.com/repos/connexta/saml-conformance/issues/85/comments","statuses_url":"https://api.github.com/repos/connexta/saml-conformance/statuses/4858cf19fe19a85f067684302ff11a74d22923b9","head":{"label":"blen-desta:todos","ref":"todos","sha":"4858cf19fe19a85f067684302ff11a74d22923b9","user":{"login":"blen-desta","id":29550062,"avatar_url":"https://avatars0.githubusercontent.com/u/29550062?v=4","gravatar_id":"","url":"https://api.github.com/users/blen-desta","html_url":"https://github.com/blen-desta","followers_url":"https://api.github.com/users/blen-desta/followers","following_url":"https://api.github.com/users/blen-desta/following{/other_user}","gists_url":"https://api.github.com/users/blen-desta/gists{/gist_id}","starred_url":"https://api.github.com/users/blen-desta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blen-desta/subscriptions","organizations_url":"https://api.github.com/users/blen-desta/orgs","repos_url":"https://api.github.com/users/blen-desta/repos","events_url":"https://api.github.com/users/blen-desta/events{/privacy}","received_events_url":"https://api.github.com/users/blen-desta/received_events","type":"User","site_admin":false},"repo":{"id":126052431,"name":"saml-conformance","full_name":"blen-desta/saml-conformance","owner":{"login":"blen-desta","id":29550062,"avatar_url":"https://avatars0.githubusercontent.com/u/29550062?v=4","gravatar_id":"","url":"https://api.github.com/users/blen-desta","html_url":"https://github.com/blen-desta","followers_url":"https://api.github.com/users/blen-desta/followers","following_url":"https://api.github.com/users/blen-desta/following{/other_user}","gists_url":"https://api.github.com/users/blen-desta/gists{/gist_id}","starred_url":"https://api.github.com/users/blen-desta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blen-desta/subscriptions","organizations_url":"https://api.github.com/users/blen-desta/orgs","repos_url":"https://api.github.com/users/blen-desta/repos","events_url":"https://api.github.com/users/blen-desta/events{/privacy}","received_events_url":"https://api.github.com/users/blen-desta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blen-desta/saml-conformance","description":null,"fork":true,"url":"https://api.github.com/repos/blen-desta/saml-conformance","forks_url":"https://api.github.com/repos/blen-desta/saml-conformance/forks","keys_url":"https://api.github.com/repos/blen-desta/saml-conformance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blen-desta/saml-conformance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blen-desta/saml-conformance/teams","hooks_url":"https://api.github.com/repos/blen-desta/saml-conformance/hooks","issue_events_url":"https://api.github.com/repos/blen-desta/saml-conformance/issues/events{/number}","events_url":"https://api.github.com/repos/blen-desta/saml-conformance/events","assignees_url":"https://api.github.com/repos/blen-desta/saml-conformance/assignees{/user}","branches_url":"https://api.github.com/repos/blen-desta/saml-conformance/branches{/branch}","tags_url":"https://api.github.com/repos/blen-desta/saml-conformance/tags","blobs_url":"https://api.github.com/repos/blen-desta/saml-conformance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blen-desta/saml-conformance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blen-desta/saml-conformance/git/refs{/sha}","trees_url":"https://api.github.com/repos/blen-desta/saml-conformance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blen-desta/saml-conformance/statuses/{sha}","languages_url":"https://api.github.com/repos/blen-desta/saml-conformance/languages","stargazers_url":"https://api.github.com/repos/blen-desta/saml-conformance/stargazers","contributors_url":"https://api.github.com/repos/blen-desta/saml-conformance/contributors","subscribers_url":"https://api.github.com/repos/blen-desta/saml-conformance/subscribers","subscription_url":"https://api.github.com/repos/blen-desta/saml-conformance/subscription","commits_url":"https://api.github.com/repos/blen-desta/saml-conformance/commits{/sha}","git_commits_url":"https://api.github.com/repos/blen-desta/saml-conformance/git/commits{/sha}","comments_url":"https://api.github.com/repos/blen-desta/saml-conformance/comments{/number}","issue_comment_url":"https://api.github.com/repos/blen-desta/saml-conformance/issues/comments{/number}","contents_url":"https://api.github.com/repos/blen-desta/saml-conformance/contents/{+path}","compare_url":"https://api.github.com/repos/blen-desta/saml-conformance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blen-desta/saml-conformance/merges","archive_url":"https://api.github.com/repos/blen-desta/saml-conformance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blen-desta/saml-conformance/downloads","issues_url":"https://api.github.com/repos/blen-desta/saml-conformance/issues{/number}","pulls_url":"https://api.github.com/repos/blen-desta/saml-conformance/pulls{/number}","milestones_url":"https://api.github.com/repos/blen-desta/saml-conformance/milestones{/number}","notifications_url":"https://api.github.com/repos/blen-desta/saml-conformance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blen-desta/saml-conformance/labels{/name}","releases_url":"https://api.github.com/repos/blen-desta/saml-conformance/releases{/id}","deployments_url":"https://api.github.com/repos/blen-desta/saml-conformance/deployments","created_at":"2018-03-20T16:57:12Z","updated_at":"2018-03-20T16:57:14Z","pushed_at":"2018-04-09T23:29:54Z","git_url":"git://github.com/blen-desta/saml-conformance.git","ssh_url":"git@github.com:blen-desta/saml-conformance.git","clone_url":"https://github.com/blen-desta/saml-conformance.git","svn_url":"https://github.com/blen-desta/saml-conformance","homepage":null,"size":721,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"connexta:master","ref":"master","sha":"08f79b54de82933c6f1505837f836f0e35345323","user":{"login":"connexta","id":6706726,"avatar_url":"https://avatars3.githubusercontent.com/u/6706726?v=4","gravatar_id":"","url":"https://api.github.com/users/connexta","html_url":"https://github.com/connexta","followers_url":"https://api.github.com/users/connexta/followers","following_url":"https://api.github.com/users/connexta/following{/other_user}","gists_url":"https://api.github.com/users/connexta/gists{/gist_id}","starred_url":"https://api.github.com/users/connexta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connexta/subscriptions","organizations_url":"https://api.github.com/users/connexta/orgs","repos_url":"https://api.github.com/users/connexta/repos","events_url":"https://api.github.com/users/connexta/events{/privacy}","received_events_url":"https://api.github.com/users/connexta/received_events","type":"Organization","site_admin":false},"repo":{"id":121804316,"name":"saml-conformance","full_name":"connexta/saml-conformance","owner":{"login":"connexta","id":6706726,"avatar_url":"https://avatars3.githubusercontent.com/u/6706726?v=4","gravatar_id":"","url":"https://api.github.com/users/connexta","html_url":"https://github.com/connexta","followers_url":"https://api.github.com/users/connexta/followers","following_url":"https://api.github.com/users/connexta/following{/other_user}","gists_url":"https://api.github.com/users/connexta/gists{/gist_id}","starred_url":"https://api.github.com/users/connexta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connexta/subscriptions","organizations_url":"https://api.github.com/users/connexta/orgs","repos_url":"https://api.github.com/users/connexta/repos","events_url":"https://api.github.com/users/connexta/events{/privacy}","received_events_url":"https://api.github.com/users/connexta/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/connexta/saml-conformance","description":null,"fork":false,"url":"https://api.github.com/repos/connexta/saml-conformance","forks_url":"https://api.github.com/repos/connexta/saml-conformance/forks","keys_url":"https://api.github.com/repos/connexta/saml-conformance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/connexta/saml-conformance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/connexta/saml-conformance/teams","hooks_url":"https://api.github.com/repos/connexta/saml-conformance/hooks","issue_events_url":"https://api.github.com/repos/connexta/saml-conformance/issues/events{/number}","events_url":"https://api.github.com/repos/connexta/saml-conformance/events","assignees_url":"https://api.github.com/repos/connexta/saml-conformance/assignees{/user}","branches_url":"https://api.github.com/repos/connexta/saml-conformance/branches{/branch}","tags_url":"https://api.github.com/repos/connexta/saml-conformance/tags","blobs_url":"https://api.github.com/repos/connexta/saml-conformance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/connexta/saml-conformance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/connexta/saml-conformance/git/refs{/sha}","trees_url":"https://api.github.com/repos/connexta/saml-conformance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/connexta/saml-conformance/statuses/{sha}","languages_url":"https://api.github.com/repos/connexta/saml-conformance/languages","stargazers_url":"https://api.github.com/repos/connexta/saml-conformance/stargazers","contributors_url":"https://api.github.com/repos/connexta/saml-conformance/contributors","subscribers_url":"https://api.github.com/repos/connexta/saml-conformance/subscribers","subscription_url":"https://api.github.com/repos/connexta/saml-conformance/subscription","commits_url":"https://api.github.com/repos/connexta/saml-conformance/commits{/sha}","git_commits_url":"https://api.github.com/repos/connexta/saml-conformance/git/commits{/sha}","comments_url":"https://api.github.com/repos/connexta/saml-conformance/comments{/number}","issue_comment_url":"https://api.github.com/repos/connexta/saml-conformance/issues/comments{/number}","contents_url":"https://api.github.com/repos/connexta/saml-conformance/contents/{+path}","compare_url":"https://api.github.com/repos/connexta/saml-conformance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/connexta/saml-conformance/merges","archive_url":"https://api.github.com/repos/connexta/saml-conformance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/connexta/saml-conformance/downloads","issues_url":"https://api.github.com/repos/connexta/saml-conformance/issues{/number}","pulls_url":"https://api.github.com/repos/connexta/saml-conformance/pulls{/number}","milestones_url":"https://api.github.com/repos/connexta/saml-conformance/milestones{/number}","notifications_url":"https://api.github.com/repos/connexta/saml-conformance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/connexta/saml-conformance/labels{/name}","releases_url":"https://api.github.com/repos/connexta/saml-conformance/releases{/id}","deployments_url":"https://api.github.com/repos/connexta/saml-conformance/deployments","created_at":"2018-02-16T21:48:23Z","updated_at":"2018-04-09T23:59:43Z","pushed_at":"2018-04-09T23:59:41Z","git_url":"git://github.com/connexta/saml-conformance.git","ssh_url":"git@github.com:connexta/saml-conformance.git","clone_url":"https://github.com/connexta/saml-conformance.git","svn_url":"https://github.com/connexta/saml-conformance","homepage":null,"size":711,"stargazers_count":1,"watchers_count":1,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":6,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/connexta/saml-conformance/pulls/85"},"html":{"href":"https://github.com/connexta/saml-conformance/pull/85"},"issue":{"href":"https://api.github.com/repos/connexta/saml-conformance/issues/85"},"comments":{"href":"https://api.github.com/repos/connexta/saml-conformance/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/connexta/saml-conformance/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/connexta/saml-conformance/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/connexta/saml-conformance/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/connexta/saml-conformance/statuses/4858cf19fe19a85f067684302ff11a74d22923b9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"blen-desta"}}