{"action":"created","comment":{"url":"https://api.github.com/repos/pmem/pmdk/pulls/comments/218345263","pull_request_review_id":156260140,"id":218345263,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODM0NTI2Mw==","diff_hunk":"@@ -0,0 +1,108 @@\n+---\n+layout: manual\n+Content-Style: 'text/css'\n+title: _MP(PMEMPOOL_FEATURE_QUERY, 3)\n+collection: libpmempool\n+header: PMDK\n+date: pmempool API version 1.3\n+...\n+\n+[comment]: <> (Copyright 2018, Intel Corporation)\n+\n+[comment]: <> (Redistribution and use in source and binary forms, with or without)\n+[comment]: <> (modification, are permitted provided that the following conditions)\n+[comment]: <> (are met:)\n+[comment]: <> (    * Redistributions of source code must retain the above copyright)\n+[comment]: <> (      notice, this list of conditions and the following disclaimer.)\n+[comment]: <> (    * Redistributions in binary form must reproduce the above copyright)\n+[comment]: <> (      notice, this list of conditions and the following disclaimer in)\n+[comment]: <> (      the documentation and/or other materials provided with the)\n+[comment]: <> (      distribution.)\n+[comment]: <> (    * Neither the name of the copyright holder nor the names of its)\n+[comment]: <> (      contributors may be used to endorse or promote products derived)\n+[comment]: <> (      from this software without specific prior written permission.)\n+\n+[comment]: <> (THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS)\n+[comment]: <> (\"AS IS\" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT)\n+[comment]: <> (LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR)\n+[comment]: <> (A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT)\n+[comment]: <> (OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,)\n+[comment]: <> (SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT)\n+[comment]: <> (LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,)\n+[comment]: <> (DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY)\n+[comment]: <> (THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT)\n+[comment]: <> ((INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE)\n+[comment]: <> (OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.)\n+\n+[comment]: <> (pmempool_feature_query.3 -- man page for toggle and query pool","path":"doc/libpmempool/pmempool_feature_query.3.md","position":37,"original_position":37,"commit_id":"e51704483a37d7bc7e5aef3f690369fce834b6b8","original_commit_id":"e51704483a37d7bc7e5aef3f690369fce834b6b8","user":{"login":"wlemkows","id":19204460,"node_id":"MDQ6VXNlcjE5MjA0NDYw","avatar_url":"https://avatars3.githubusercontent.com/u/19204460?v=4","gravatar_id":"","url":"https://api.github.com/users/wlemkows","html_url":"https://github.com/wlemkows","followers_url":"https://api.github.com/users/wlemkows/followers","following_url":"https://api.github.com/users/wlemkows/following{/other_user}","gists_url":"https://api.github.com/users/wlemkows/gists{/gist_id}","starred_url":"https://api.github.com/users/wlemkows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wlemkows/subscriptions","organizations_url":"https://api.github.com/users/wlemkows/orgs","repos_url":"https://api.github.com/users/wlemkows/repos","events_url":"https://api.github.com/users/wlemkows/events{/privacy}","received_events_url":"https://api.github.com/users/wlemkows/received_events","type":"User","site_admin":false},"body":"please add this and other function to `doc/Makefile`\r\nand aliases to `doc/generated`","created_at":"2018-09-18T08:43:38Z","updated_at":"2018-09-18T08:45:43Z","html_url":"https://github.com/pmem/pmdk/pull/3184#discussion_r218345263","pull_request_url":"https://api.github.com/repos/pmem/pmdk/pulls/3184","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pmem/pmdk/pulls/comments/218345263"},"html":{"href":"https://github.com/pmem/pmdk/pull/3184#discussion_r218345263"},"pull_request":{"href":"https://api.github.com/repos/pmem/pmdk/pulls/3184"}}},"pull_request":{"url":"https://api.github.com/repos/pmem/pmdk/pulls/3184","id":215993879,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1OTkzODc5","html_url":"https://github.com/pmem/pmdk/pull/3184","diff_url":"https://github.com/pmem/pmdk/pull/3184.diff","patch_url":"https://github.com/pmem/pmdk/pull/3184.patch","issue_url":"https://api.github.com/repos/pmem/pmdk/issues/3184","number":3184,"state":"open","locked":false,"title":"[RFC] pool: feature init","user":{"login":"janekmi","id":3518702,"node_id":"MDQ6VXNlcjM1MTg3MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3518702?v=4","gravatar_id":"","url":"https://api.github.com/users/janekmi","html_url":"https://github.com/janekmi","followers_url":"https://api.github.com/users/janekmi/followers","following_url":"https://api.github.com/users/janekmi/following{/other_user}","gists_url":"https://api.github.com/users/janekmi/gists{/gist_id}","starred_url":"https://api.github.com/users/janekmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janekmi/subscriptions","organizations_url":"https://api.github.com/users/janekmi/orgs","repos_url":"https://api.github.com/users/janekmi/repos","events_url":"https://api.github.com/users/janekmi/events{/privacy}","received_events_url":"https://api.github.com/users/janekmi/received_events","type":"User","site_admin":false},"body":"TODO:\r\n- [ ] **PMEMPOOL_FEAT_SINGLEHDR** enable / disable\r\n- [ ] **PMEMPOOL_FEAT_CKSUM_2K** enable / disable\r\n- [ ] **PMEMPOOL_FEAT_SHUTDOWN_STATE** enable / disable\r\n- [ ] pmempool tests\r\n- [ ] libpmempool tests\r\n\r\nThis pull request requires two more to be merged prior to this one and **contains their commits**:\r\n- [ ] pmem/pmdk#3163 - pool: fix shutdown state check\r\n- [ ] pmem/pmdk#3181 - common: introduce shutdown state incompat feature\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/pmem/pmdk/3184)\n<!-- Reviewable:end -->\n","created_at":"2018-09-17T14:05:51Z","updated_at":"2018-09-18T08:45:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f3b221208d0a17e9858b233db12d0334f44dbe4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pmem/pmdk/pulls/3184/commits","review_comments_url":"https://api.github.com/repos/pmem/pmdk/pulls/3184/comments","review_comment_url":"https://api.github.com/repos/pmem/pmdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pmem/pmdk/issues/3184/comments","statuses_url":"https://api.github.com/repos/pmem/pmdk/statuses/e51704483a37d7bc7e5aef3f690369fce834b6b8","head":{"label":"janekmi:pool-feature-init","ref":"pool-feature-init","sha":"e51704483a37d7bc7e5aef3f690369fce834b6b8","user":{"login":"janekmi","id":3518702,"node_id":"MDQ6VXNlcjM1MTg3MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3518702?v=4","gravatar_id":"","url":"https://api.github.com/users/janekmi","html_url":"https://github.com/janekmi","followers_url":"https://api.github.com/users/janekmi/followers","following_url":"https://api.github.com/users/janekmi/following{/other_user}","gists_url":"https://api.github.com/users/janekmi/gists{/gist_id}","starred_url":"https://api.github.com/users/janekmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janekmi/subscriptions","organizations_url":"https://api.github.com/users/janekmi/orgs","repos_url":"https://api.github.com/users/janekmi/repos","events_url":"https://api.github.com/users/janekmi/events{/privacy}","received_events_url":"https://api.github.com/users/janekmi/received_events","type":"User","site_admin":false},"repo":{"id":50022149,"node_id":"MDEwOlJlcG9zaXRvcnk1MDAyMjE0OQ==","name":"nvml","full_name":"janekmi/nvml","private":false,"owner":{"login":"janekmi","id":3518702,"node_id":"MDQ6VXNlcjM1MTg3MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3518702?v=4","gravatar_id":"","url":"https://api.github.com/users/janekmi","html_url":"https://github.com/janekmi","followers_url":"https://api.github.com/users/janekmi/followers","following_url":"https://api.github.com/users/janekmi/following{/other_user}","gists_url":"https://api.github.com/users/janekmi/gists{/gist_id}","starred_url":"https://api.github.com/users/janekmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janekmi/subscriptions","organizations_url":"https://api.github.com/users/janekmi/orgs","repos_url":"https://api.github.com/users/janekmi/repos","events_url":"https://api.github.com/users/janekmi/events{/privacy}","received_events_url":"https://api.github.com/users/janekmi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/janekmi/nvml","description":"Active development tree for the NVM Library","fork":true,"url":"https://api.github.com/repos/janekmi/nvml","forks_url":"https://api.github.com/repos/janekmi/nvml/forks","keys_url":"https://api.github.com/repos/janekmi/nvml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janekmi/nvml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janekmi/nvml/teams","hooks_url":"https://api.github.com/repos/janekmi/nvml/hooks","issue_events_url":"https://api.github.com/repos/janekmi/nvml/issues/events{/number}","events_url":"https://api.github.com/repos/janekmi/nvml/events","assignees_url":"https://api.github.com/repos/janekmi/nvml/assignees{/user}","branches_url":"https://api.github.com/repos/janekmi/nvml/branches{/branch}","tags_url":"https://api.github.com/repos/janekmi/nvml/tags","blobs_url":"https://api.github.com/repos/janekmi/nvml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janekmi/nvml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janekmi/nvml/git/refs{/sha}","trees_url":"https://api.github.com/repos/janekmi/nvml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janekmi/nvml/statuses/{sha}","languages_url":"https://api.github.com/repos/janekmi/nvml/languages","stargazers_url":"https://api.github.com/repos/janekmi/nvml/stargazers","contributors_url":"https://api.github.com/repos/janekmi/nvml/contributors","subscribers_url":"https://api.github.com/repos/janekmi/nvml/subscribers","subscription_url":"https://api.github.com/repos/janekmi/nvml/subscription","commits_url":"https://api.github.com/repos/janekmi/nvml/commits{/sha}","git_commits_url":"https://api.github.com/repos/janekmi/nvml/git/commits{/sha}","comments_url":"https://api.github.com/repos/janekmi/nvml/comments{/number}","issue_comment_url":"https://api.github.com/repos/janekmi/nvml/issues/comments{/number}","contents_url":"https://api.github.com/repos/janekmi/nvml/contents/{+path}","compare_url":"https://api.github.com/repos/janekmi/nvml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janekmi/nvml/merges","archive_url":"https://api.github.com/repos/janekmi/nvml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janekmi/nvml/downloads","issues_url":"https://api.github.com/repos/janekmi/nvml/issues{/number}","pulls_url":"https://api.github.com/repos/janekmi/nvml/pulls{/number}","milestones_url":"https://api.github.com/repos/janekmi/nvml/milestones{/number}","notifications_url":"https://api.github.com/repos/janekmi/nvml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janekmi/nvml/labels{/name}","releases_url":"https://api.github.com/repos/janekmi/nvml/releases{/id}","deployments_url":"https://api.github.com/repos/janekmi/nvml/deployments","created_at":"2016-01-20T10:16:53Z","updated_at":"2016-01-20T10:16:58Z","pushed_at":"2018-09-17T14:23:48Z","git_url":"git://github.com/janekmi/nvml.git","ssh_url":"git@github.com:janekmi/nvml.git","clone_url":"https://github.com/janekmi/nvml.git","svn_url":"https://github.com/janekmi/nvml","homepage":"http://pmem.io","size":27842,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pmem:master","ref":"master","sha":"ba443862cbf5957e57203b21c190a665f2041114","user":{"login":"pmem","id":4894933,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4OTQ5MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/4894933?v=4","gravatar_id":"","url":"https://api.github.com/users/pmem","html_url":"https://github.com/pmem","followers_url":"https://api.github.com/users/pmem/followers","following_url":"https://api.github.com/users/pmem/following{/other_user}","gists_url":"https://api.github.com/users/pmem/gists{/gist_id}","starred_url":"https://api.github.com/users/pmem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmem/subscriptions","organizations_url":"https://api.github.com/users/pmem/orgs","repos_url":"https://api.github.com/users/pmem/repos","events_url":"https://api.github.com/users/pmem/events{/privacy}","received_events_url":"https://api.github.com/users/pmem/received_events","type":"Organization","site_admin":false},"repo":{"id":23637153,"node_id":"MDEwOlJlcG9zaXRvcnkyMzYzNzE1Mw==","name":"pmdk","full_name":"pmem/pmdk","private":false,"owner":{"login":"pmem","id":4894933,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4OTQ5MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/4894933?v=4","gravatar_id":"","url":"https://api.github.com/users/pmem","html_url":"https://github.com/pmem","followers_url":"https://api.github.com/users/pmem/followers","following_url":"https://api.github.com/users/pmem/following{/other_user}","gists_url":"https://api.github.com/users/pmem/gists{/gist_id}","starred_url":"https://api.github.com/users/pmem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmem/subscriptions","organizations_url":"https://api.github.com/users/pmem/orgs","repos_url":"https://api.github.com/users/pmem/repos","events_url":"https://api.github.com/users/pmem/events{/privacy}","received_events_url":"https://api.github.com/users/pmem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pmem/pmdk","description":"Persistent Memory Development Kit","fork":false,"url":"https://api.github.com/repos/pmem/pmdk","forks_url":"https://api.github.com/repos/pmem/pmdk/forks","keys_url":"https://api.github.com/repos/pmem/pmdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmem/pmdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmem/pmdk/teams","hooks_url":"https://api.github.com/repos/pmem/pmdk/hooks","issue_events_url":"https://api.github.com/repos/pmem/pmdk/issues/events{/number}","events_url":"https://api.github.com/repos/pmem/pmdk/events","assignees_url":"https://api.github.com/repos/pmem/pmdk/assignees{/user}","branches_url":"https://api.github.com/repos/pmem/pmdk/branches{/branch}","tags_url":"https://api.github.com/repos/pmem/pmdk/tags","blobs_url":"https://api.github.com/repos/pmem/pmdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmem/pmdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmem/pmdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmem/pmdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmem/pmdk/statuses/{sha}","languages_url":"https://api.github.com/repos/pmem/pmdk/languages","stargazers_url":"https://api.github.com/repos/pmem/pmdk/stargazers","contributors_url":"https://api.github.com/repos/pmem/pmdk/contributors","subscribers_url":"https://api.github.com/repos/pmem/pmdk/subscribers","subscription_url":"https://api.github.com/repos/pmem/pmdk/subscription","commits_url":"https://api.github.com/repos/pmem/pmdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmem/pmdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmem/pmdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmem/pmdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmem/pmdk/contents/{+path}","compare_url":"https://api.github.com/repos/pmem/pmdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmem/pmdk/merges","archive_url":"https://api.github.com/repos/pmem/pmdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmem/pmdk/downloads","issues_url":"https://api.github.com/repos/pmem/pmdk/issues{/number}","pulls_url":"https://api.github.com/repos/pmem/pmdk/pulls{/number}","milestones_url":"https://api.github.com/repos/pmem/pmdk/milestones{/number}","notifications_url":"https://api.github.com/repos/pmem/pmdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmem/pmdk/labels{/name}","releases_url":"https://api.github.com/repos/pmem/pmdk/releases{/id}","deployments_url":"https://api.github.com/repos/pmem/pmdk/deployments","created_at":"2014-09-03T20:55:23Z","updated_at":"2018-09-18T00:48:56Z","pushed_at":"2018-09-18T07:59:39Z","git_url":"git://github.com/pmem/pmdk.git","ssh_url":"git@github.com:pmem/pmdk.git","clone_url":"https://github.com/pmem/pmdk.git","svn_url":"https://github.com/pmem/pmdk","homepage":"http://pmem.io","size":57056,"stargazers_count":487,"watchers_count":487,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":221,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":221,"open_issues":15,"watchers":487,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pmem/pmdk/pulls/3184"},"html":{"href":"https://github.com/pmem/pmdk/pull/3184"},"issue":{"href":"https://api.github.com/repos/pmem/pmdk/issues/3184"},"comments":{"href":"https://api.github.com/repos/pmem/pmdk/issues/3184/comments"},"review_comments":{"href":"https://api.github.com/repos/pmem/pmdk/pulls/3184/comments"},"review_comment":{"href":"https://api.github.com/repos/pmem/pmdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pmem/pmdk/pulls/3184/commits"},"statuses":{"href":"https://api.github.com/repos/pmem/pmdk/statuses/e51704483a37d7bc7e5aef3f690369fce834b6b8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wlemkows"}}