{"action":"created","issue":{"url":"https://api.github.com/repos/cloudcreativity/laravel-json-api/issues/207","repository_url":"https://api.github.com/repos/cloudcreativity/laravel-json-api","labels_url":"https://api.github.com/repos/cloudcreativity/laravel-json-api/issues/207/labels{/name}","comments_url":"https://api.github.com/repos/cloudcreativity/laravel-json-api/issues/207/comments","events_url":"https://api.github.com/repos/cloudcreativity/laravel-json-api/issues/207/events","html_url":"https://github.com/cloudcreativity/laravel-json-api/issues/207","id":337914453,"node_id":"MDU6SXNzdWUzMzc5MTQ0NTM=","number":207,"title":"Binding generic adapter isn't working","user":{"login":"TomBrouwer","id":3687997,"node_id":"MDQ6VXNlcjM2ODc5OTc=","avatar_url":"https://avatars3.githubusercontent.com/u/3687997?v=4","gravatar_id":"","url":"https://api.github.com/users/TomBrouwer","html_url":"https://github.com/TomBrouwer","followers_url":"https://api.github.com/users/TomBrouwer/followers","following_url":"https://api.github.com/users/TomBrouwer/following{/other_user}","gists_url":"https://api.github.com/users/TomBrouwer/gists{/gist_id}","starred_url":"https://api.github.com/users/TomBrouwer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomBrouwer/subscriptions","organizations_url":"https://api.github.com/users/TomBrouwer/orgs","repos_url":"https://api.github.com/users/TomBrouwer/repos","events_url":"https://api.github.com/users/TomBrouwer/events{/privacy}","received_events_url":"https://api.github.com/users/TomBrouwer/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-03T14:04:45Z","updated_at":"2018-07-03T16:02:32Z","closed_at":"2018-07-03T16:02:32Z","author_association":"NONE","body":"**EDIT:** I wanted to adjust it myself and make a pull request. But now I see that it is fixed in the aplha 4 release from yesterday. This issue can be closed.\r\n\r\nHi I try to bind a generic adapter, but it isn't work. It will tell me: \"...\\JsonApi\\v1\\Users\\Adapter] is not a resource adapter\". \r\n\r\nThe code I use to bind (The '...' are replacing the App name in the begin of the namespace):\r\n```\r\n$this->app->bind('...\\JsonApi\\v1\\Users\\Adapter', function () {\r\n     return new Adapter(new \\...\\Models\\User(), null);\r\n});\r\n```\r\n\r\nBut it will not pass the create function in de src/Container.php\r\n```\r\nprotected function create($className)\r\n    {\r\n        if (!class_exists($className)) {\r\n            return null;\r\n        }\r\n\r\n        return $this->container->make($className);\r\n}\r\n```\r\n\r\nIt doesn't pass the class_exists function and return NULL. If I test to make the class, it will make the class. Maybe it can be checked with:\r\n`$this->container->bound($className)`\r\ninstead of class_exists?\r\n\r\n```\r\nif (!class_exists($className) && !$this->container->bound($className)) {\r\n     return null;\r\n}\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/cloudcreativity/laravel-json-api/issues/comments/402208609","html_url":"https://github.com/cloudcreativity/laravel-json-api/issues/207#issuecomment-402208609","issue_url":"https://api.github.com/repos/cloudcreativity/laravel-json-api/issues/207","id":402208609,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjIwODYwOQ==","user":{"login":"lindyhopchris","id":4464333,"node_id":"MDQ6VXNlcjQ0NjQzMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/4464333?v=4","gravatar_id":"","url":"https://api.github.com/users/lindyhopchris","html_url":"https://github.com/lindyhopchris","followers_url":"https://api.github.com/users/lindyhopchris/followers","following_url":"https://api.github.com/users/lindyhopchris/following{/other_user}","gists_url":"https://api.github.com/users/lindyhopchris/gists{/gist_id}","starred_url":"https://api.github.com/users/lindyhopchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lindyhopchris/subscriptions","organizations_url":"https://api.github.com/users/lindyhopchris/orgs","repos_url":"https://api.github.com/users/lindyhopchris/repos","events_url":"https://api.github.com/users/lindyhopchris/events{/privacy}","received_events_url":"https://api.github.com/users/lindyhopchris/received_events","type":"User","site_admin":false},"created_at":"2018-07-03T16:02:32Z","updated_at":"2018-07-03T16:02:32Z","author_association":"MEMBER","body":"Hi @TomBrouwer - yes, this is exactly the change we released yesterday. Hope `1.0.0-alpha.4` solves your problem."}}
{"actor":{"display_login":"lindyhopchris"}}