{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/pulls/comments/245215310","pull_request_review_id":189268301,"id":245215310,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTIxNTMxMA==","diff_hunk":"@@ -399,6 +431,14 @@ func resourceAliyunSlbListenerUpdate(d *schema.ResourceData, meta interface{}) e\n \tclient := meta.(*connectivity.AliyunClient)\n \tprotocol := Protocol(d.Get(\"protocol\").(string))\n \n+\t//if redirection is enabled, set http listener attribute is not supported\n+\tif protocol == Http {\n+\t\tlistenerForward := d.Get(\"listener_forward\")\n+\t\tif listenerForward.(bool) {\n+\t\t\treturn fmt.Errorf(\"SetLoadBalancer%sListenerAttribute is not allowed when redirection is enabled.\", strings.ToUpper(string(protocol)))\n+\t\t}\n+\t}\n+","path":"alicloud/resource_alicloud_slb_listener.go","position":71,"original_position":71,"commit_id":"e6903eee525d4dbc0ed9c91b5dc0f715aa91dfc6","original_commit_id":"e6903eee525d4dbc0ed9c91b5dc0f715aa91dfc6","user":{"login":"xiaozhu36","id":21300084,"node_id":"MDQ6VXNlcjIxMzAwMDg0","avatar_url":"https://avatars1.githubusercontent.com/u/21300084?v=4","gravatar_id":"","url":"https://api.github.com/users/xiaozhu36","html_url":"https://github.com/xiaozhu36","followers_url":"https://api.github.com/users/xiaozhu36/followers","following_url":"https://api.github.com/users/xiaozhu36/following{/other_user}","gists_url":"https://api.github.com/users/xiaozhu36/gists{/gist_id}","starred_url":"https://api.github.com/users/xiaozhu36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiaozhu36/subscriptions","organizations_url":"https://api.github.com/users/xiaozhu36/orgs","repos_url":"https://api.github.com/users/xiaozhu36/repos","events_url":"https://api.github.com/users/xiaozhu36/events{/privacy}","received_events_url":"https://api.github.com/users/xiaozhu36/received_events","type":"User","site_admin":false},"body":"I think line 434-441 are needless.","created_at":"2019-01-04T06:05:24Z","updated_at":"2019-01-04T06:05:59Z","html_url":"https://github.com/terraform-providers/terraform-provider-alicloud/pull/614#discussion_r245215310","pull_request_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/pulls/614","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/pulls/comments/245215310"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-alicloud/pull/614#discussion_r245215310"},"pull_request":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/pulls/614"}}},"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/pulls/614","id":241984894,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxOTg0ODk0","html_url":"https://github.com/terraform-providers/terraform-provider-alicloud/pull/614","diff_url":"https://github.com/terraform-providers/terraform-provider-alicloud/pull/614.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-alicloud/pull/614.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/issues/614","number":614,"state":"open","locked":false,"title":"Add capability for slb http listener redirection","user":{"login":"Savasw","id":21305223,"node_id":"MDQ6VXNlcjIxMzA1MjIz","avatar_url":"https://avatars2.githubusercontent.com/u/21305223?v=4","gravatar_id":"","url":"https://api.github.com/users/Savasw","html_url":"https://github.com/Savasw","followers_url":"https://api.github.com/users/Savasw/followers","following_url":"https://api.github.com/users/Savasw/following{/other_user}","gists_url":"https://api.github.com/users/Savasw/gists{/gist_id}","starred_url":"https://api.github.com/users/Savasw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Savasw/subscriptions","organizations_url":"https://api.github.com/users/Savasw/orgs","repos_url":"https://api.github.com/users/Savasw/repos","events_url":"https://api.github.com/users/Savasw/events{/privacy}","received_events_url":"https://api.github.com/users/Savasw/received_events","type":"User","site_admin":false},"body":"","created_at":"2019-01-03T12:43:53Z","updated_at":"2019-01-04T06:05:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d261b08d3194da421015a22e0efe1f51a8371336","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":620326998,"node_id":"MDU6TGFiZWw2MjAzMjY5OTg=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/labels/documentation","name":"documentation","color":"fef2c0","default":false},{"id":737911991,"node_id":"MDU6TGFiZWw3Mzc5MTE5OTE=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/labels/size/S","name":"size/S","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/pulls/614/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/pulls/614/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/issues/614/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/statuses/e6903eee525d4dbc0ed9c91b5dc0f715aa91dfc6","head":{"label":"Savasw:redirect-listener","ref":"redirect-listener","sha":"e6903eee525d4dbc0ed9c91b5dc0f715aa91dfc6","user":{"login":"Savasw","id":21305223,"node_id":"MDQ6VXNlcjIxMzA1MjIz","avatar_url":"https://avatars2.githubusercontent.com/u/21305223?v=4","gravatar_id":"","url":"https://api.github.com/users/Savasw","html_url":"https://github.com/Savasw","followers_url":"https://api.github.com/users/Savasw/followers","following_url":"https://api.github.com/users/Savasw/following{/other_user}","gists_url":"https://api.github.com/users/Savasw/gists{/gist_id}","starred_url":"https://api.github.com/users/Savasw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Savasw/subscriptions","organizations_url":"https://api.github.com/users/Savasw/orgs","repos_url":"https://api.github.com/users/Savasw/repos","events_url":"https://api.github.com/users/Savasw/events{/privacy}","received_events_url":"https://api.github.com/users/Savasw/received_events","type":"User","site_admin":false},"repo":{"id":162386184,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIzODYxODQ=","name":"terraform-provider-alicloud","full_name":"Savasw/terraform-provider-alicloud","private":false,"owner":{"login":"Savasw","id":21305223,"node_id":"MDQ6VXNlcjIxMzA1MjIz","avatar_url":"https://avatars2.githubusercontent.com/u/21305223?v=4","gravatar_id":"","url":"https://api.github.com/users/Savasw","html_url":"https://github.com/Savasw","followers_url":"https://api.github.com/users/Savasw/followers","following_url":"https://api.github.com/users/Savasw/following{/other_user}","gists_url":"https://api.github.com/users/Savasw/gists{/gist_id}","starred_url":"https://api.github.com/users/Savasw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Savasw/subscriptions","organizations_url":"https://api.github.com/users/Savasw/orgs","repos_url":"https://api.github.com/users/Savasw/repos","events_url":"https://api.github.com/users/Savasw/events{/privacy}","received_events_url":"https://api.github.com/users/Savasw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Savasw/terraform-provider-alicloud","description":"Terraform AliCloud provider","fork":true,"url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud","forks_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/forks","keys_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/teams","hooks_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/hooks","issue_events_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/issues/events{/number}","events_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/events","assignees_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/assignees{/user}","branches_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/branches{/branch}","tags_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/tags","blobs_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/statuses/{sha}","languages_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/languages","stargazers_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/stargazers","contributors_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/contributors","subscribers_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/subscribers","subscription_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/subscription","commits_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/contents/{+path}","compare_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/merges","archive_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/downloads","issues_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/issues{/number}","pulls_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/pulls{/number}","milestones_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/milestones{/number}","notifications_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/labels{/name}","releases_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/releases{/id}","deployments_url":"https://api.github.com/repos/Savasw/terraform-provider-alicloud/deployments","created_at":"2018-12-19T05:16:14Z","updated_at":"2018-12-19T05:16:18Z","pushed_at":"2019-01-03T12:40:46Z","git_url":"git://github.com/Savasw/terraform-provider-alicloud.git","ssh_url":"git@github.com:Savasw/terraform-provider-alicloud.git","clone_url":"https://github.com/Savasw/terraform-provider-alicloud.git","svn_url":"https://github.com/Savasw/terraform-provider-alicloud","homepage":"https://www.terraform.io/docs/providers/alicloud/","size":9926,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"af7e4e5497f8b27e3d43171d294ffb0f8c0c8f84","user":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93446083,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQ0NjA4Mw==","name":"terraform-provider-alicloud","full_name":"terraform-providers/terraform-provider-alicloud","private":false,"owner":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/terraform-providers/terraform-provider-alicloud","description":"Terraform AliCloud provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/deployments","created_at":"2017-06-05T20:54:04Z","updated_at":"2019-01-04T05:13:14Z","pushed_at":"2019-01-04T04:27:43Z","git_url":"git://github.com/terraform-providers/terraform-provider-alicloud.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-alicloud.git","clone_url":"https://github.com/terraform-providers/terraform-provider-alicloud.git","svn_url":"https://github.com/terraform-providers/terraform-provider-alicloud","homepage":"https://www.terraform.io/docs/providers/alicloud/","size":9892,"stargazers_count":99,"watchers_count":99,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":62,"open_issues":23,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/pulls/614"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-alicloud/pull/614"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/issues/614"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/issues/614/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/pulls/614/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/pulls/614/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-alicloud/statuses/e6903eee525d4dbc0ed9c91b5dc0f715aa91dfc6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xiaozhu36"}}