{"action":"created","issue":{"url":"https://api.github.com/repos/amberframework/granite/issues/257","repository_url":"https://api.github.com/repos/amberframework/granite","labels_url":"https://api.github.com/repos/amberframework/granite/issues/257/labels{/name}","comments_url":"https://api.github.com/repos/amberframework/granite/issues/257/comments","events_url":"https://api.github.com/repos/amberframework/granite/issues/257/events","html_url":"https://github.com/amberframework/granite/pull/257","id":342585071,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNDQ5NjI5","number":257,"title":"Adapter Registration Support","user":{"login":"Blacksmoke16","id":12136995,"node_id":"MDQ6VXNlcjEyMTM2OTk1","avatar_url":"https://avatars1.githubusercontent.com/u/12136995?v=4","gravatar_id":"","url":"https://api.github.com/users/Blacksmoke16","html_url":"https://github.com/Blacksmoke16","followers_url":"https://api.github.com/users/Blacksmoke16/followers","following_url":"https://api.github.com/users/Blacksmoke16/following{/other_user}","gists_url":"https://api.github.com/users/Blacksmoke16/gists{/gist_id}","starred_url":"https://api.github.com/users/Blacksmoke16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blacksmoke16/subscriptions","organizations_url":"https://api.github.com/users/Blacksmoke16/orgs","repos_url":"https://api.github.com/users/Blacksmoke16/repos","events_url":"https://api.github.com/users/Blacksmoke16/events{/privacy}","received_events_url":"https://api.github.com/users/Blacksmoke16/received_events","type":"User","site_admin":false},"labels":[{"id":893254583,"node_id":"MDU6TGFiZWw4OTMyNTQ1ODM=","url":"https://api.github.com/repos/amberframework/granite/labels/kind:breaking-change","name":"kind:breaking-change","color":"b60205","default":false},{"id":251246821,"node_id":"MDU6TGFiZWwyNTEyNDY4MjE=","url":"https://api.github.com/repos/amberframework/granite/labels/kind:enhancement","name":"kind:enhancement","color":"bfd4f2","default":false},{"id":870698503,"node_id":"MDU6TGFiZWw4NzA2OTg1MDM=","url":"https://api.github.com/repos/amberframework/granite/labels/pr:needs-review","name":"pr:needs-review","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-19T05:36:38Z","updated_at":"2018-07-21T13:37:24Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/amberframework/granite/pulls/257","html_url":"https://github.com/amberframework/granite/pull/257","diff_url":"https://github.com/amberframework/granite/pull/257.diff","patch_url":"https://github.com/amberframework/granite/pull/257.patch"},"body":"First pass on #254.  Tests pass so assuming this works.  Still some things to do tho :p Feedback appreciated :)\r\n\r\nBasic removes ability of reading ENV vars directly as connection_strings.  Refactors how adapters works to support an array of adapters that can be defined by name and used on a model to model basis.  \r\n\r\nThis allows for one model to use another database schema, or even a whole other database server than another model.\r\n\r\nTODOs:\r\n- [x] Write tests\r\n- [x] Add better error handling on invalid connection params on adapter init\r\n- [x] Possibly cleanup `Granite.adapters.adapters` syntax\r\n- [x] Update docs"},"comment":{"url":"https://api.github.com/repos/amberframework/granite/issues/comments/406797258","html_url":"https://github.com/amberframework/granite/pull/257#issuecomment-406797258","issue_url":"https://api.github.com/repos/amberframework/granite/issues/257","id":406797258,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjc5NzI1OA==","user":{"login":"Blacksmoke16","id":12136995,"node_id":"MDQ6VXNlcjEyMTM2OTk1","avatar_url":"https://avatars1.githubusercontent.com/u/12136995?v=4","gravatar_id":"","url":"https://api.github.com/users/Blacksmoke16","html_url":"https://github.com/Blacksmoke16","followers_url":"https://api.github.com/users/Blacksmoke16/followers","following_url":"https://api.github.com/users/Blacksmoke16/following{/other_user}","gists_url":"https://api.github.com/users/Blacksmoke16/gists{/gist_id}","starred_url":"https://api.github.com/users/Blacksmoke16/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blacksmoke16/subscriptions","organizations_url":"https://api.github.com/users/Blacksmoke16/orgs","repos_url":"https://api.github.com/users/Blacksmoke16/repos","events_url":"https://api.github.com/users/Blacksmoke16/events{/privacy}","received_events_url":"https://api.github.com/users/Blacksmoke16/received_events","type":"User","site_admin":false},"created_at":"2018-07-21T13:37:24Z","updated_at":"2018-07-21T13:37:24Z","author_association":"MEMBER","body":"Refactored a bit:\r\n\r\n* Syntax is now `Granite::Adapters << adapter`\r\n  * The `Adapters' <<` class method now hold the duplicate name logic\r\n* Changed the settings back to how it was before\r\n  * Defaulted logger to nil"}}
{"actor":{"display_login":"Blacksmoke16"}}