{"action":"created","comment":{"url":"https://api.github.com/repos/gohugoio/hugo/pulls/comments/222379554","pull_request_review_id":161252358,"id":222379554,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjM3OTU1NA==","diff_hunk":"@@ -688,8 +689,18 @@ func getRstContent(ctx *RenderingContext) []byte {\n \n \t}\n \tjww.INFO.Println(\"Rendering\", ctx.DocumentName, \"with\", path, \"...\")\n-\targs := []string{path, \"--leave-comments\", \"--initial-header-level=2\"}\n-\tresult := externallyRenderContent(ctx, python, args)\n+\tvar result []byte\n+\t// certain *nix based OSs wrap executables in scripted launchers\n+\t// invoking binaries on these OSs via python interpreter causes SyntaxError\n+\t// invoke directly so that shebangs work as expected\n+\t// handle Windows manually because it doesn't do shebangs\n+\tif runtime.GOOS == \"windows\" {\n+\t\targs := []string{path, \"--leave-comments\", \"--initial-header-level=2\"}\n+\t\tresult = externallyRenderContent(ctx, python, args)","path":"helpers/content.go","position":21,"original_position":21,"commit_id":"406d45d85e80be2a3aa39eac22f244cbe1534dd7","original_commit_id":"406d45d85e80be2a3aa39eac22f244cbe1534dd7","user":{"login":"bep","id":394382,"node_id":"MDQ6VXNlcjM5NDM4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/394382?v=4","gravatar_id":"","url":"https://api.github.com/users/bep","html_url":"https://github.com/bep","followers_url":"https://api.github.com/users/bep/followers","following_url":"https://api.github.com/users/bep/following{/other_user}","gists_url":"https://api.github.com/users/bep/gists{/gist_id}","starred_url":"https://api.github.com/users/bep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bep/subscriptions","organizations_url":"https://api.github.com/users/bep/orgs","repos_url":"https://api.github.com/users/bep/repos","events_url":"https://api.github.com/users/bep/events{/privacy}","received_events_url":"https://api.github.com/users/bep/received_events","type":"User","site_admin":false},"body":"Agree.","created_at":"2018-10-03T16:30:51Z","updated_at":"2018-10-03T16:30:51Z","html_url":"https://github.com/gohugoio/hugo/pull/5285#discussion_r222379554","pull_request_url":"https://api.github.com/repos/gohugoio/hugo/pulls/5285","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gohugoio/hugo/pulls/comments/222379554"},"html":{"href":"https://github.com/gohugoio/hugo/pull/5285#discussion_r222379554"},"pull_request":{"href":"https://api.github.com/repos/gohugoio/hugo/pulls/5285"}},"in_reply_to_id":222376396},"pull_request":{"url":"https://api.github.com/repos/gohugoio/hugo/pulls/5285","id":220057872,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMDU3ODcy","html_url":"https://github.com/gohugoio/hugo/pull/5285","diff_url":"https://github.com/gohugoio/hugo/pull/5285.diff","patch_url":"https://github.com/gohugoio/hugo/pull/5285.patch","issue_url":"https://api.github.com/repos/gohugoio/hugo/issues/5285","number":5285,"state":"open","locked":false,"title":"helpers/content.go: call rst2html directly on *nix but via python on windows","user":{"login":"shreyanshk","id":8820721,"node_id":"MDQ6VXNlcjg4MjA3MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/8820721?v=4","gravatar_id":"","url":"https://api.github.com/users/shreyanshk","html_url":"https://github.com/shreyanshk","followers_url":"https://api.github.com/users/shreyanshk/followers","following_url":"https://api.github.com/users/shreyanshk/following{/other_user}","gists_url":"https://api.github.com/users/shreyanshk/gists{/gist_id}","starred_url":"https://api.github.com/users/shreyanshk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shreyanshk/subscriptions","organizations_url":"https://api.github.com/users/shreyanshk/orgs","repos_url":"https://api.github.com/users/shreyanshk/repos","events_url":"https://api.github.com/users/shreyanshk/events{/privacy}","received_events_url":"https://api.github.com/users/shreyanshk/received_events","type":"User","site_admin":false},"body":"Initially, rst2html was called via the python interpreter which would\r\nfail if the script was wrapped in a launcher as on NixOS.\r\nIdeally, on *nix, binaries should be invoked directly to ensure that\r\nshebangs work properly as is being done now.\r\nHandle the case of windows as it doesn't do shebangs.","created_at":"2018-10-03T14:26:31Z","updated_at":"2018-10-03T16:30:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c499543dd7da2bf8c8f92640515e454b12d39d6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gohugoio/hugo/pulls/5285/commits","review_comments_url":"https://api.github.com/repos/gohugoio/hugo/pulls/5285/comments","review_comment_url":"https://api.github.com/repos/gohugoio/hugo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gohugoio/hugo/issues/5285/comments","statuses_url":"https://api.github.com/repos/gohugoio/hugo/statuses/406d45d85e80be2a3aa39eac22f244cbe1534dd7","head":{"label":"shreyanshk:master","ref":"master","sha":"406d45d85e80be2a3aa39eac22f244cbe1534dd7","user":{"login":"shreyanshk","id":8820721,"node_id":"MDQ6VXNlcjg4MjA3MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/8820721?v=4","gravatar_id":"","url":"https://api.github.com/users/shreyanshk","html_url":"https://github.com/shreyanshk","followers_url":"https://api.github.com/users/shreyanshk/followers","following_url":"https://api.github.com/users/shreyanshk/following{/other_user}","gists_url":"https://api.github.com/users/shreyanshk/gists{/gist_id}","starred_url":"https://api.github.com/users/shreyanshk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shreyanshk/subscriptions","organizations_url":"https://api.github.com/users/shreyanshk/orgs","repos_url":"https://api.github.com/users/shreyanshk/repos","events_url":"https://api.github.com/users/shreyanshk/events{/privacy}","received_events_url":"https://api.github.com/users/shreyanshk/received_events","type":"User","site_admin":false},"repo":{"id":147529418,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1Mjk0MTg=","name":"hugo","full_name":"shreyanshk/hugo","private":false,"owner":{"login":"shreyanshk","id":8820721,"node_id":"MDQ6VXNlcjg4MjA3MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/8820721?v=4","gravatar_id":"","url":"https://api.github.com/users/shreyanshk","html_url":"https://github.com/shreyanshk","followers_url":"https://api.github.com/users/shreyanshk/followers","following_url":"https://api.github.com/users/shreyanshk/following{/other_user}","gists_url":"https://api.github.com/users/shreyanshk/gists{/gist_id}","starred_url":"https://api.github.com/users/shreyanshk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shreyanshk/subscriptions","organizations_url":"https://api.github.com/users/shreyanshk/orgs","repos_url":"https://api.github.com/users/shreyanshk/repos","events_url":"https://api.github.com/users/shreyanshk/events{/privacy}","received_events_url":"https://api.github.com/users/shreyanshk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/shreyanshk/hugo","description":"The world’s fastest framework for building websites.","fork":true,"url":"https://api.github.com/repos/shreyanshk/hugo","forks_url":"https://api.github.com/repos/shreyanshk/hugo/forks","keys_url":"https://api.github.com/repos/shreyanshk/hugo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shreyanshk/hugo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shreyanshk/hugo/teams","hooks_url":"https://api.github.com/repos/shreyanshk/hugo/hooks","issue_events_url":"https://api.github.com/repos/shreyanshk/hugo/issues/events{/number}","events_url":"https://api.github.com/repos/shreyanshk/hugo/events","assignees_url":"https://api.github.com/repos/shreyanshk/hugo/assignees{/user}","branches_url":"https://api.github.com/repos/shreyanshk/hugo/branches{/branch}","tags_url":"https://api.github.com/repos/shreyanshk/hugo/tags","blobs_url":"https://api.github.com/repos/shreyanshk/hugo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shreyanshk/hugo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shreyanshk/hugo/git/refs{/sha}","trees_url":"https://api.github.com/repos/shreyanshk/hugo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shreyanshk/hugo/statuses/{sha}","languages_url":"https://api.github.com/repos/shreyanshk/hugo/languages","stargazers_url":"https://api.github.com/repos/shreyanshk/hugo/stargazers","contributors_url":"https://api.github.com/repos/shreyanshk/hugo/contributors","subscribers_url":"https://api.github.com/repos/shreyanshk/hugo/subscribers","subscription_url":"https://api.github.com/repos/shreyanshk/hugo/subscription","commits_url":"https://api.github.com/repos/shreyanshk/hugo/commits{/sha}","git_commits_url":"https://api.github.com/repos/shreyanshk/hugo/git/commits{/sha}","comments_url":"https://api.github.com/repos/shreyanshk/hugo/comments{/number}","issue_comment_url":"https://api.github.com/repos/shreyanshk/hugo/issues/comments{/number}","contents_url":"https://api.github.com/repos/shreyanshk/hugo/contents/{+path}","compare_url":"https://api.github.com/repos/shreyanshk/hugo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shreyanshk/hugo/merges","archive_url":"https://api.github.com/repos/shreyanshk/hugo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shreyanshk/hugo/downloads","issues_url":"https://api.github.com/repos/shreyanshk/hugo/issues{/number}","pulls_url":"https://api.github.com/repos/shreyanshk/hugo/pulls{/number}","milestones_url":"https://api.github.com/repos/shreyanshk/hugo/milestones{/number}","notifications_url":"https://api.github.com/repos/shreyanshk/hugo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shreyanshk/hugo/labels{/name}","releases_url":"https://api.github.com/repos/shreyanshk/hugo/releases{/id}","deployments_url":"https://api.github.com/repos/shreyanshk/hugo/deployments","created_at":"2018-09-05T14:16:15Z","updated_at":"2018-10-03T14:23:43Z","pushed_at":"2018-10-03T14:23:50Z","git_url":"git://github.com/shreyanshk/hugo.git","ssh_url":"git@github.com:shreyanshk/hugo.git","clone_url":"https://github.com/shreyanshk/hugo.git","svn_url":"https://github.com/shreyanshk/hugo","homepage":"https://gohugo.io","size":61280,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gohugoio:master","ref":"master","sha":"e421696d02bfb8764ae57238e211ce0e85e9782e","user":{"login":"gohugoio","id":29385237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mzg1MjM3","avatar_url":"https://avatars2.githubusercontent.com/u/29385237?v=4","gravatar_id":"","url":"https://api.github.com/users/gohugoio","html_url":"https://github.com/gohugoio","followers_url":"https://api.github.com/users/gohugoio/followers","following_url":"https://api.github.com/users/gohugoio/following{/other_user}","gists_url":"https://api.github.com/users/gohugoio/gists{/gist_id}","starred_url":"https://api.github.com/users/gohugoio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gohugoio/subscriptions","organizations_url":"https://api.github.com/users/gohugoio/orgs","repos_url":"https://api.github.com/users/gohugoio/repos","events_url":"https://api.github.com/users/gohugoio/events{/privacy}","received_events_url":"https://api.github.com/users/gohugoio/received_events","type":"Organization","site_admin":false},"repo":{"id":11180687,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE4MDY4Nw==","name":"hugo","full_name":"gohugoio/hugo","private":false,"owner":{"login":"gohugoio","id":29385237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5Mzg1MjM3","avatar_url":"https://avatars2.githubusercontent.com/u/29385237?v=4","gravatar_id":"","url":"https://api.github.com/users/gohugoio","html_url":"https://github.com/gohugoio","followers_url":"https://api.github.com/users/gohugoio/followers","following_url":"https://api.github.com/users/gohugoio/following{/other_user}","gists_url":"https://api.github.com/users/gohugoio/gists{/gist_id}","starred_url":"https://api.github.com/users/gohugoio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gohugoio/subscriptions","organizations_url":"https://api.github.com/users/gohugoio/orgs","repos_url":"https://api.github.com/users/gohugoio/repos","events_url":"https://api.github.com/users/gohugoio/events{/privacy}","received_events_url":"https://api.github.com/users/gohugoio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gohugoio/hugo","description":"The world’s fastest framework for building websites.","fork":false,"url":"https://api.github.com/repos/gohugoio/hugo","forks_url":"https://api.github.com/repos/gohugoio/hugo/forks","keys_url":"https://api.github.com/repos/gohugoio/hugo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gohugoio/hugo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gohugoio/hugo/teams","hooks_url":"https://api.github.com/repos/gohugoio/hugo/hooks","issue_events_url":"https://api.github.com/repos/gohugoio/hugo/issues/events{/number}","events_url":"https://api.github.com/repos/gohugoio/hugo/events","assignees_url":"https://api.github.com/repos/gohugoio/hugo/assignees{/user}","branches_url":"https://api.github.com/repos/gohugoio/hugo/branches{/branch}","tags_url":"https://api.github.com/repos/gohugoio/hugo/tags","blobs_url":"https://api.github.com/repos/gohugoio/hugo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gohugoio/hugo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gohugoio/hugo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gohugoio/hugo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gohugoio/hugo/statuses/{sha}","languages_url":"https://api.github.com/repos/gohugoio/hugo/languages","stargazers_url":"https://api.github.com/repos/gohugoio/hugo/stargazers","contributors_url":"https://api.github.com/repos/gohugoio/hugo/contributors","subscribers_url":"https://api.github.com/repos/gohugoio/hugo/subscribers","subscription_url":"https://api.github.com/repos/gohugoio/hugo/subscription","commits_url":"https://api.github.com/repos/gohugoio/hugo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gohugoio/hugo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gohugoio/hugo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gohugoio/hugo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gohugoio/hugo/contents/{+path}","compare_url":"https://api.github.com/repos/gohugoio/hugo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gohugoio/hugo/merges","archive_url":"https://api.github.com/repos/gohugoio/hugo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gohugoio/hugo/downloads","issues_url":"https://api.github.com/repos/gohugoio/hugo/issues{/number}","pulls_url":"https://api.github.com/repos/gohugoio/hugo/pulls{/number}","milestones_url":"https://api.github.com/repos/gohugoio/hugo/milestones{/number}","notifications_url":"https://api.github.com/repos/gohugoio/hugo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gohugoio/hugo/labels{/name}","releases_url":"https://api.github.com/repos/gohugoio/hugo/releases{/id}","deployments_url":"https://api.github.com/repos/gohugoio/hugo/deployments","created_at":"2013-07-04T15:26:26Z","updated_at":"2018-10-03T15:58:49Z","pushed_at":"2018-10-03T14:26:32Z","git_url":"git://github.com/gohugoio/hugo.git","ssh_url":"git@github.com:gohugoio/hugo.git","clone_url":"https://github.com/gohugoio/hugo.git","svn_url":"https://github.com/gohugoio/hugo","homepage":"https://gohugo.io","size":61300,"stargazers_count":29231,"watchers_count":29231,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3420,"mirror_url":null,"archived":false,"open_issues_count":302,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3420,"open_issues":302,"watchers":29231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gohugoio/hugo/pulls/5285"},"html":{"href":"https://github.com/gohugoio/hugo/pull/5285"},"issue":{"href":"https://api.github.com/repos/gohugoio/hugo/issues/5285"},"comments":{"href":"https://api.github.com/repos/gohugoio/hugo/issues/5285/comments"},"review_comments":{"href":"https://api.github.com/repos/gohugoio/hugo/pulls/5285/comments"},"review_comment":{"href":"https://api.github.com/repos/gohugoio/hugo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gohugoio/hugo/pulls/5285/commits"},"statuses":{"href":"https://api.github.com/repos/gohugoio/hugo/statuses/406d45d85e80be2a3aa39eac22f244cbe1534dd7"}},"author_association":"NONE"}}
{"actor":{"display_login":"bep"}}