{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/175983757","pull_request_review_id":105605039,"id":175983757,"diff_hunk":"@@ -337,15 +337,20 @@ public interface IRenderAboveShroudWhenSelected\n \t\tbool SpatiallyPartitionable { get; }\n \t}\n \n+\t/// <summary>\n+\t/// Indicates target types as defined on <see cref=\"Traits.ITargetable\"/> are present in a <see cref=\"Primitives.BitSet{T}\"/>.\n+\t/// </summary>\n+\tpublic sealed class TargetableType { TargetableType() { } }","path":"OpenRA.Game/Traits/TraitsInterfaces.cs","position":7,"original_position":7,"commit_id":"ad471b5afa799dda0aa8d9e664380b71de162719","original_commit_id":"ad471b5afa799dda0aa8d9e664380b71de162719","user":{"login":"pchote","id":167819,"avatar_url":"https://avatars1.githubusercontent.com/u/167819?v=4","gravatar_id":"","url":"https://api.github.com/users/pchote","html_url":"https://github.com/pchote","followers_url":"https://api.github.com/users/pchote/followers","following_url":"https://api.github.com/users/pchote/following{/other_user}","gists_url":"https://api.github.com/users/pchote/gists{/gist_id}","starred_url":"https://api.github.com/users/pchote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchote/subscriptions","organizations_url":"https://api.github.com/users/pchote/orgs","repos_url":"https://api.github.com/users/pchote/repos","events_url":"https://api.github.com/users/pchote/events{/privacy}","received_events_url":"https://api.github.com/users/pchote/received_events","type":"User","site_admin":false},"body":"Can we rename this to `TargetType` to match previous conventions?","created_at":"2018-03-21T04:41:24Z","updated_at":"2018-03-21T04:43:23Z","html_url":"https://github.com/OpenRA/OpenRA/pull/14943#discussion_r175983757","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/14943","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/175983757"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/14943#discussion_r175983757"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/14943"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/14943","id":175769045,"html_url":"https://github.com/OpenRA/OpenRA/pull/14943","diff_url":"https://github.com/OpenRA/OpenRA/pull/14943.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/14943.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/14943","number":14943,"state":"open","locked":false,"title":"Use a BitSet for representing target types.","user":{"login":"RoosterDragon","id":3399086,"avatar_url":"https://avatars0.githubusercontent.com/u/3399086?v=4","gravatar_id":"","url":"https://api.github.com/users/RoosterDragon","html_url":"https://github.com/RoosterDragon","followers_url":"https://api.github.com/users/RoosterDragon/followers","following_url":"https://api.github.com/users/RoosterDragon/following{/other_user}","gists_url":"https://api.github.com/users/RoosterDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/RoosterDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoosterDragon/subscriptions","organizations_url":"https://api.github.com/users/RoosterDragon/orgs","repos_url":"https://api.github.com/users/RoosterDragon/repos","events_url":"https://api.github.com/users/RoosterDragon/events{/privacy}","received_events_url":"https://api.github.com/users/RoosterDragon/received_events","type":"User","site_admin":false},"body":"Use a `BitSet` rather than a `HashSet<string>` for representing target types. Since there are only a few distinct target types, we can easily represent these as a bitfield which is faster and more memory efficient than a `HashSet`.\r\n\r\nSuggested by @chrisforbes: https://github.com/OpenRA/OpenRA/pull/14917#discussion_r175274537, https://github.com/OpenRA/OpenRA/pull/14933#discussion_r175274613.\r\n\r\nIn the default mods, there are the following numbers of distinct target types:\r\n\r\n| Mod | Count |\r\n| ----- | -----: |\r\n| d2k  | 12 |\r\n| cnc   | 16 |\r\n| ts     | 17 |\r\n| ra     | 26 |\r\n\r\nCurrently we use a 32-bit integer to give us a limit of 32 - should this ever become insufficient it can always be upped to a 64-bit integer for a limit of 64.\r\n\r\nEdit: Switched to System.Numerics.BigInteger - which means no limit!","created_at":"2018-03-18T19:40:43Z","updated_at":"2018-03-21T04:43:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e644805057a6302439b55a3f393edf07fa4426e1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":117740707,"url":"https://api.github.com/repos/OpenRA/OpenRA/labels/PR:%20Rebase%20me!","name":"PR: Rebase me!","color":"eb6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/14943/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/14943/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/14943/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/ad471b5afa799dda0aa8d9e664380b71de162719","head":{"label":"RoosterDragon:targets-bitset","ref":"targets-bitset","sha":"ad471b5afa799dda0aa8d9e664380b71de162719","user":{"login":"RoosterDragon","id":3399086,"avatar_url":"https://avatars0.githubusercontent.com/u/3399086?v=4","gravatar_id":"","url":"https://api.github.com/users/RoosterDragon","html_url":"https://github.com/RoosterDragon","followers_url":"https://api.github.com/users/RoosterDragon/followers","following_url":"https://api.github.com/users/RoosterDragon/following{/other_user}","gists_url":"https://api.github.com/users/RoosterDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/RoosterDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoosterDragon/subscriptions","organizations_url":"https://api.github.com/users/RoosterDragon/orgs","repos_url":"https://api.github.com/users/RoosterDragon/repos","events_url":"https://api.github.com/users/RoosterDragon/events{/privacy}","received_events_url":"https://api.github.com/users/RoosterDragon/received_events","type":"User","site_admin":false},"repo":{"id":20080394,"name":"OpenRA","full_name":"RoosterDragon/OpenRA","owner":{"login":"RoosterDragon","id":3399086,"avatar_url":"https://avatars0.githubusercontent.com/u/3399086?v=4","gravatar_id":"","url":"https://api.github.com/users/RoosterDragon","html_url":"https://github.com/RoosterDragon","followers_url":"https://api.github.com/users/RoosterDragon/followers","following_url":"https://api.github.com/users/RoosterDragon/following{/other_user}","gists_url":"https://api.github.com/users/RoosterDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/RoosterDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoosterDragon/subscriptions","organizations_url":"https://api.github.com/users/RoosterDragon/orgs","repos_url":"https://api.github.com/users/RoosterDragon/repos","events_url":"https://api.github.com/users/RoosterDragon/events{/privacy}","received_events_url":"https://api.github.com/users/RoosterDragon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RoosterDragon/OpenRA","description":"An open-source implementation of the Red Alert engine using .NET/mono and OpenGL. Runs on Windows, Linux and Mac OS X.","fork":true,"url":"https://api.github.com/repos/RoosterDragon/OpenRA","forks_url":"https://api.github.com/repos/RoosterDragon/OpenRA/forks","keys_url":"https://api.github.com/repos/RoosterDragon/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RoosterDragon/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RoosterDragon/OpenRA/teams","hooks_url":"https://api.github.com/repos/RoosterDragon/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/RoosterDragon/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/RoosterDragon/OpenRA/events","assignees_url":"https://api.github.com/repos/RoosterDragon/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/RoosterDragon/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/RoosterDragon/OpenRA/tags","blobs_url":"https://api.github.com/repos/RoosterDragon/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RoosterDragon/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RoosterDragon/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/RoosterDragon/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RoosterDragon/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/RoosterDragon/OpenRA/languages","stargazers_url":"https://api.github.com/repos/RoosterDragon/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/RoosterDragon/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/RoosterDragon/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/RoosterDragon/OpenRA/subscription","commits_url":"https://api.github.com/repos/RoosterDragon/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/RoosterDragon/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/RoosterDragon/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/RoosterDragon/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/RoosterDragon/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/RoosterDragon/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RoosterDragon/OpenRA/merges","archive_url":"https://api.github.com/repos/RoosterDragon/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RoosterDragon/OpenRA/downloads","issues_url":"https://api.github.com/repos/RoosterDragon/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/RoosterDragon/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/RoosterDragon/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/RoosterDragon/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RoosterDragon/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/RoosterDragon/OpenRA/releases{/id}","deployments_url":"https://api.github.com/repos/RoosterDragon/OpenRA/deployments","created_at":"2014-05-22T23:21:53Z","updated_at":"2018-03-18T19:38:51Z","pushed_at":"2018-03-20T20:08:14Z","git_url":"git://github.com/RoosterDragon/OpenRA.git","ssh_url":"git@github.com:RoosterDragon/OpenRA.git","clone_url":"https://github.com/RoosterDragon/OpenRA.git","svn_url":"https://github.com/RoosterDragon/OpenRA","homepage":"http://open-ra.org","size":131463,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"9122aac555d7894506c45ec3b5dfce96a8897f10","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars0.githubusercontent.com/u/409046?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars0.githubusercontent.com/u/409046?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"Open Source real-time strategy game engine for early Westwood games such as Command & Conquer: Red Alert written in C# using SDL and OpenGL. Runs on Windows, Linux, *BSD and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","deployments_url":"https://api.github.com/repos/OpenRA/OpenRA/deployments","created_at":"2010-10-04T07:38:05Z","updated_at":"2018-03-21T04:09:10Z","pushed_at":"2018-03-21T04:42:28Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":131980,"stargazers_count":5061,"watchers_count":5061,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1492,"mirror_url":null,"archived":false,"open_issues_count":1453,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":1492,"open_issues":1453,"watchers":5061,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/14943"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/14943"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/14943"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/14943/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/14943/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/14943/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/ad471b5afa799dda0aa8d9e664380b71de162719"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pchote"}}