{"action":"created","issue":{"url":"https://api.github.com/repos/singer-io/tap-postgres/issues/5","repository_url":"https://api.github.com/repos/singer-io/tap-postgres","labels_url":"https://api.github.com/repos/singer-io/tap-postgres/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/singer-io/tap-postgres/issues/5/comments","events_url":"https://api.github.com/repos/singer-io/tap-postgres/issues/5/events","html_url":"https://github.com/singer-io/tap-postgres/pull/5","id":323380355,"number":5,"title":"add dbs_to_discover config option to target specific dbs in discover","user":{"login":"seanbyrne88","id":7132781,"avatar_url":"https://avatars1.githubusercontent.com/u/7132781?v=4","gravatar_id":"","url":"https://api.github.com/users/seanbyrne88","html_url":"https://github.com/seanbyrne88","followers_url":"https://api.github.com/users/seanbyrne88/followers","following_url":"https://api.github.com/users/seanbyrne88/following{/other_user}","gists_url":"https://api.github.com/users/seanbyrne88/gists{/gist_id}","starred_url":"https://api.github.com/users/seanbyrne88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanbyrne88/subscriptions","organizations_url":"https://api.github.com/users/seanbyrne88/orgs","repos_url":"https://api.github.com/users/seanbyrne88/repos","events_url":"https://api.github.com/users/seanbyrne88/events{/privacy}","received_events_url":"https://api.github.com/users/seanbyrne88/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-15T20:56:49Z","updated_at":"2018-05-17T15:41:37Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/singer-io/tap-postgres/pulls/5","html_url":"https://github.com/singer-io/tap-postgres/pull/5","diff_url":"https://github.com/singer-io/tap-postgres/pull/5.diff","patch_url":"https://github.com/singer-io/tap-postgres/pull/5.patch"},"body":"@psantacl Per our discussion today, this is the way i came up with to target specific dbs on discover. "},"comment":{"url":"https://api.github.com/repos/singer-io/tap-postgres/issues/comments/389912183","html_url":"https://github.com/singer-io/tap-postgres/pull/5#issuecomment-389912183","issue_url":"https://api.github.com/repos/singer-io/tap-postgres/issues/5","id":389912183,"user":{"login":"psantacl","id":136452,"avatar_url":"https://avatars3.githubusercontent.com/u/136452?v=4","gravatar_id":"","url":"https://api.github.com/users/psantacl","html_url":"https://github.com/psantacl","followers_url":"https://api.github.com/users/psantacl/followers","following_url":"https://api.github.com/users/psantacl/following{/other_user}","gists_url":"https://api.github.com/users/psantacl/gists{/gist_id}","starred_url":"https://api.github.com/users/psantacl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psantacl/subscriptions","organizations_url":"https://api.github.com/users/psantacl/orgs","repos_url":"https://api.github.com/users/psantacl/repos","events_url":"https://api.github.com/users/psantacl/events{/privacy}","received_events_url":"https://api.github.com/users/psantacl/received_events","type":"User","site_admin":false},"created_at":"2018-05-17T15:41:37Z","updated_at":"2018-05-17T15:41:37Z","author_association":"CONTRIBUTOR","body":"Sorry.  What I mean is that if the user provides a filter_dbs paramter it should be a comma separated list of database names.  Then, the tap can split the property on commas and get a vector of database names.  This vector of database names can then be fed directly in the SQL here: https://github.com/seanbyrne88/tap-postgres/blob/1c2afada3fd66a2aaa6bad8a01726f6dca32d44f/tap_postgres/__init__.py#L273.\r\n\r\n\r\nThis is an important step i believe because it will prevent the tap from trying to discover DB's that do not exist.  DB's that the user erroneously entered into the config."}}
{"actor":{"display_login":"psantacl"}}