{"action":"created","comment":{"url":"https://api.github.com/repos/jsternberg/zap-logfmt/pulls/comments/197805597","pull_request_review_id":131619318,"id":197805597,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzgwNTU5Nw==","diff_hunk":"@@ -5,7 +5,10 @@ import (\n \t\"testing\"\n \t\"time\"\n \n+\t\"go.uber.org/zap/buffer\"","path":"encoder_test.go","position":4,"original_position":4,"commit_id":"cef54f91a42bcdd05b6e46c734f90212e2ea8d41","original_commit_id":"cef54f91a42bcdd05b6e46c734f90212e2ea8d41","user":{"login":"jsternberg","id":1212129,"node_id":"MDQ6VXNlcjEyMTIxMjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1212129?v=4","gravatar_id":"","url":"https://api.github.com/users/jsternberg","html_url":"https://github.com/jsternberg","followers_url":"https://api.github.com/users/jsternberg/followers","following_url":"https://api.github.com/users/jsternberg/following{/other_user}","gists_url":"https://api.github.com/users/jsternberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jsternberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsternberg/subscriptions","organizations_url":"https://api.github.com/users/jsternberg/orgs","repos_url":"https://api.github.com/users/jsternberg/repos","events_url":"https://api.github.com/users/jsternberg/events{/privacy}","received_events_url":"https://api.github.com/users/jsternberg/received_events","type":"User","site_admin":false},"body":"This should be grouped with the others.","created_at":"2018-06-25T13:57:16Z","updated_at":"2018-06-25T13:58:14Z","html_url":"https://github.com/jsternberg/zap-logfmt/pull/2#discussion_r197805597","pull_request_url":"https://api.github.com/repos/jsternberg/zap-logfmt/pulls/2","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jsternberg/zap-logfmt/pulls/comments/197805597"},"html":{"href":"https://github.com/jsternberg/zap-logfmt/pull/2#discussion_r197805597"},"pull_request":{"href":"https://api.github.com/repos/jsternberg/zap-logfmt/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/jsternberg/zap-logfmt/pulls/2","id":151539314,"node_id":"MDExOlB1bGxSZXF1ZXN0MTUxNTM5MzE0","html_url":"https://github.com/jsternberg/zap-logfmt/pull/2","diff_url":"https://github.com/jsternberg/zap-logfmt/pull/2.diff","patch_url":"https://github.com/jsternberg/zap-logfmt/pull/2.patch","issue_url":"https://api.github.com/repos/jsternberg/zap-logfmt/issues/2","number":2,"state":"open","locked":false,"title":"Add logfmt support for caller via EncodeCaller","user":{"login":"ydnar","id":34146,"node_id":"MDQ6VXNlcjM0MTQ2","avatar_url":"https://avatars3.githubusercontent.com/u/34146?v=4","gravatar_id":"","url":"https://api.github.com/users/ydnar","html_url":"https://github.com/ydnar","followers_url":"https://api.github.com/users/ydnar/followers","following_url":"https://api.github.com/users/ydnar/following{/other_user}","gists_url":"https://api.github.com/users/ydnar/gists{/gist_id}","starred_url":"https://api.github.com/users/ydnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ydnar/subscriptions","organizations_url":"https://api.github.com/users/ydnar/orgs","repos_url":"https://api.github.com/users/ydnar/repos","events_url":"https://api.github.com/users/ydnar/events{/privacy}","received_events_url":"https://api.github.com/users/ydnar/received_events","type":"User","site_admin":false},"body":"Thanks for writing the logfmt encoder for zap. This PR adds support for caller for debugging purposes.  The code was copied from https://github.com/uber-go/zap/blob/master/zapcore/json_encoder.go#L321.","created_at":"2017-11-09T01:22:03Z","updated_at":"2018-06-25T13:58:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"447b274b33f10a12113df302eee18a328de6f2d7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jsternberg/zap-logfmt/pulls/2/commits","review_comments_url":"https://api.github.com/repos/jsternberg/zap-logfmt/pulls/2/comments","review_comment_url":"https://api.github.com/repos/jsternberg/zap-logfmt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jsternberg/zap-logfmt/issues/2/comments","statuses_url":"https://api.github.com/repos/jsternberg/zap-logfmt/statuses/cef54f91a42bcdd05b6e46c734f90212e2ea8d41","head":{"label":"nbio:master","ref":"master","sha":"cef54f91a42bcdd05b6e46c734f90212e2ea8d41","user":{"login":"nbio","id":7267891,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNjc4OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7267891?v=4","gravatar_id":"","url":"https://api.github.com/users/nbio","html_url":"https://github.com/nbio","followers_url":"https://api.github.com/users/nbio/followers","following_url":"https://api.github.com/users/nbio/following{/other_user}","gists_url":"https://api.github.com/users/nbio/gists{/gist_id}","starred_url":"https://api.github.com/users/nbio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbio/subscriptions","organizations_url":"https://api.github.com/users/nbio/orgs","repos_url":"https://api.github.com/users/nbio/repos","events_url":"https://api.github.com/users/nbio/events{/privacy}","received_events_url":"https://api.github.com/users/nbio/received_events","type":"Organization","site_admin":false},"repo":{"id":110047147,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAwNDcxNDc=","name":"zap-logfmt","full_name":"nbio/zap-logfmt","owner":{"login":"nbio","id":7267891,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyNjc4OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7267891?v=4","gravatar_id":"","url":"https://api.github.com/users/nbio","html_url":"https://github.com/nbio","followers_url":"https://api.github.com/users/nbio/followers","following_url":"https://api.github.com/users/nbio/following{/other_user}","gists_url":"https://api.github.com/users/nbio/gists{/gist_id}","starred_url":"https://api.github.com/users/nbio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbio/subscriptions","organizations_url":"https://api.github.com/users/nbio/orgs","repos_url":"https://api.github.com/users/nbio/repos","events_url":"https://api.github.com/users/nbio/events{/privacy}","received_events_url":"https://api.github.com/users/nbio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nbio/zap-logfmt","description":null,"fork":true,"url":"https://api.github.com/repos/nbio/zap-logfmt","forks_url":"https://api.github.com/repos/nbio/zap-logfmt/forks","keys_url":"https://api.github.com/repos/nbio/zap-logfmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nbio/zap-logfmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nbio/zap-logfmt/teams","hooks_url":"https://api.github.com/repos/nbio/zap-logfmt/hooks","issue_events_url":"https://api.github.com/repos/nbio/zap-logfmt/issues/events{/number}","events_url":"https://api.github.com/repos/nbio/zap-logfmt/events","assignees_url":"https://api.github.com/repos/nbio/zap-logfmt/assignees{/user}","branches_url":"https://api.github.com/repos/nbio/zap-logfmt/branches{/branch}","tags_url":"https://api.github.com/repos/nbio/zap-logfmt/tags","blobs_url":"https://api.github.com/repos/nbio/zap-logfmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nbio/zap-logfmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nbio/zap-logfmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/nbio/zap-logfmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nbio/zap-logfmt/statuses/{sha}","languages_url":"https://api.github.com/repos/nbio/zap-logfmt/languages","stargazers_url":"https://api.github.com/repos/nbio/zap-logfmt/stargazers","contributors_url":"https://api.github.com/repos/nbio/zap-logfmt/contributors","subscribers_url":"https://api.github.com/repos/nbio/zap-logfmt/subscribers","subscription_url":"https://api.github.com/repos/nbio/zap-logfmt/subscription","commits_url":"https://api.github.com/repos/nbio/zap-logfmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/nbio/zap-logfmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/nbio/zap-logfmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/nbio/zap-logfmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/nbio/zap-logfmt/contents/{+path}","compare_url":"https://api.github.com/repos/nbio/zap-logfmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nbio/zap-logfmt/merges","archive_url":"https://api.github.com/repos/nbio/zap-logfmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nbio/zap-logfmt/downloads","issues_url":"https://api.github.com/repos/nbio/zap-logfmt/issues{/number}","pulls_url":"https://api.github.com/repos/nbio/zap-logfmt/pulls{/number}","milestones_url":"https://api.github.com/repos/nbio/zap-logfmt/milestones{/number}","notifications_url":"https://api.github.com/repos/nbio/zap-logfmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nbio/zap-logfmt/labels{/name}","releases_url":"https://api.github.com/repos/nbio/zap-logfmt/releases{/id}","deployments_url":"https://api.github.com/repos/nbio/zap-logfmt/deployments","created_at":"2017-11-09T00:36:37Z","updated_at":"2017-11-09T00:36:39Z","pushed_at":"2017-11-09T01:19:37Z","git_url":"git://github.com/nbio/zap-logfmt.git","ssh_url":"git@github.com:nbio/zap-logfmt.git","clone_url":"https://github.com/nbio/zap-logfmt.git","svn_url":"https://github.com/nbio/zap-logfmt","homepage":null,"size":6,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jsternberg:master","ref":"master","sha":"5ea53862c7fa897f44ae0b3004283308c0b0c9d1","user":{"login":"jsternberg","id":1212129,"node_id":"MDQ6VXNlcjEyMTIxMjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1212129?v=4","gravatar_id":"","url":"https://api.github.com/users/jsternberg","html_url":"https://github.com/jsternberg","followers_url":"https://api.github.com/users/jsternberg/followers","following_url":"https://api.github.com/users/jsternberg/following{/other_user}","gists_url":"https://api.github.com/users/jsternberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jsternberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsternberg/subscriptions","organizations_url":"https://api.github.com/users/jsternberg/orgs","repos_url":"https://api.github.com/users/jsternberg/repos","events_url":"https://api.github.com/users/jsternberg/events{/privacy}","received_events_url":"https://api.github.com/users/jsternberg/received_events","type":"User","site_admin":false},"repo":{"id":75229106,"node_id":"MDEwOlJlcG9zaXRvcnk3NTIyOTEwNg==","name":"zap-logfmt","full_name":"jsternberg/zap-logfmt","owner":{"login":"jsternberg","id":1212129,"node_id":"MDQ6VXNlcjEyMTIxMjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1212129?v=4","gravatar_id":"","url":"https://api.github.com/users/jsternberg","html_url":"https://github.com/jsternberg","followers_url":"https://api.github.com/users/jsternberg/followers","following_url":"https://api.github.com/users/jsternberg/following{/other_user}","gists_url":"https://api.github.com/users/jsternberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jsternberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsternberg/subscriptions","organizations_url":"https://api.github.com/users/jsternberg/orgs","repos_url":"https://api.github.com/users/jsternberg/repos","events_url":"https://api.github.com/users/jsternberg/events{/privacy}","received_events_url":"https://api.github.com/users/jsternberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsternberg/zap-logfmt","description":null,"fork":false,"url":"https://api.github.com/repos/jsternberg/zap-logfmt","forks_url":"https://api.github.com/repos/jsternberg/zap-logfmt/forks","keys_url":"https://api.github.com/repos/jsternberg/zap-logfmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsternberg/zap-logfmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsternberg/zap-logfmt/teams","hooks_url":"https://api.github.com/repos/jsternberg/zap-logfmt/hooks","issue_events_url":"https://api.github.com/repos/jsternberg/zap-logfmt/issues/events{/number}","events_url":"https://api.github.com/repos/jsternberg/zap-logfmt/events","assignees_url":"https://api.github.com/repos/jsternberg/zap-logfmt/assignees{/user}","branches_url":"https://api.github.com/repos/jsternberg/zap-logfmt/branches{/branch}","tags_url":"https://api.github.com/repos/jsternberg/zap-logfmt/tags","blobs_url":"https://api.github.com/repos/jsternberg/zap-logfmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsternberg/zap-logfmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsternberg/zap-logfmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsternberg/zap-logfmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsternberg/zap-logfmt/statuses/{sha}","languages_url":"https://api.github.com/repos/jsternberg/zap-logfmt/languages","stargazers_url":"https://api.github.com/repos/jsternberg/zap-logfmt/stargazers","contributors_url":"https://api.github.com/repos/jsternberg/zap-logfmt/contributors","subscribers_url":"https://api.github.com/repos/jsternberg/zap-logfmt/subscribers","subscription_url":"https://api.github.com/repos/jsternberg/zap-logfmt/subscription","commits_url":"https://api.github.com/repos/jsternberg/zap-logfmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsternberg/zap-logfmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsternberg/zap-logfmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsternberg/zap-logfmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsternberg/zap-logfmt/contents/{+path}","compare_url":"https://api.github.com/repos/jsternberg/zap-logfmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsternberg/zap-logfmt/merges","archive_url":"https://api.github.com/repos/jsternberg/zap-logfmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsternberg/zap-logfmt/downloads","issues_url":"https://api.github.com/repos/jsternberg/zap-logfmt/issues{/number}","pulls_url":"https://api.github.com/repos/jsternberg/zap-logfmt/pulls{/number}","milestones_url":"https://api.github.com/repos/jsternberg/zap-logfmt/milestones{/number}","notifications_url":"https://api.github.com/repos/jsternberg/zap-logfmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsternberg/zap-logfmt/labels{/name}","releases_url":"https://api.github.com/repos/jsternberg/zap-logfmt/releases{/id}","deployments_url":"https://api.github.com/repos/jsternberg/zap-logfmt/deployments","created_at":"2016-11-30T21:33:39Z","updated_at":"2018-03-17T02:53:26Z","pushed_at":"2018-03-17T02:54:06Z","git_url":"git://github.com/jsternberg/zap-logfmt.git","ssh_url":"git@github.com:jsternberg/zap-logfmt.git","clone_url":"https://github.com/jsternberg/zap-logfmt.git","svn_url":"https://github.com/jsternberg/zap-logfmt","homepage":null,"size":10,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jsternberg/zap-logfmt/pulls/2"},"html":{"href":"https://github.com/jsternberg/zap-logfmt/pull/2"},"issue":{"href":"https://api.github.com/repos/jsternberg/zap-logfmt/issues/2"},"comments":{"href":"https://api.github.com/repos/jsternberg/zap-logfmt/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/jsternberg/zap-logfmt/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/jsternberg/zap-logfmt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jsternberg/zap-logfmt/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/jsternberg/zap-logfmt/statuses/cef54f91a42bcdd05b6e46c734f90212e2ea8d41"}},"author_association":"NONE"}}
{"actor":{"display_login":"jsternberg"}}