{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments/208394364","pull_request_review_id":144195750,"id":208394364,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODM5NDM2NA==","diff_hunk":"@@ -17,13 +17,14 @@\n \n package org.apache.daffodil.processors.unparsers\n \n-import org.apache.daffodil.processors.{ LayerTransformerEv, ModelGroupRuntimeData }\n+import org.apache.daffodil.processors.LayerTransformerEv\n import org.apache.daffodil.io.DirectOrBufferedDataOutputStream\n+import org.apache.daffodil.processors.SequenceRuntimeData\n \n-class LayeredSequenceUnparser(ctxt: ModelGroupRuntimeData,\n+class LayeredSequenceUnparser(ctxt: SequenceRuntimeData,\n   layerTransformerEv: LayerTransformerEv,\n-  childUnparser: Unparser)\n-  extends SequenceCombinatorUnparser(ctxt, Vector(childUnparser)) {","path":"daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/LayeredSequenceUnparser.scala","position":13,"original_position":13,"commit_id":"66cb366949e58eaf2de3f3cc3c865dc481fb2356","original_commit_id":"66cb366949e58eaf2de3f3cc3c865dc481fb2356","user":{"login":"mbeckerle","id":1524099,"node_id":"MDQ6VXNlcjE1MjQwOTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1524099?v=4","gravatar_id":"","url":"https://api.github.com/users/mbeckerle","html_url":"https://github.com/mbeckerle","followers_url":"https://api.github.com/users/mbeckerle/followers","following_url":"https://api.github.com/users/mbeckerle/following{/other_user}","gists_url":"https://api.github.com/users/mbeckerle/gists{/gist_id}","starred_url":"https://api.github.com/users/mbeckerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbeckerle/subscriptions","organizations_url":"https://api.github.com/users/mbeckerle/orgs","repos_url":"https://api.github.com/users/mbeckerle/repos","events_url":"https://api.github.com/users/mbeckerle/events{/privacy}","received_events_url":"https://api.github.com/users/mbeckerle/received_events","type":"User","site_admin":false},"body":"Yes, all these should be vector. In the runtime we don't map/foreach them, we use indexing. ","created_at":"2018-08-07T21:39:21Z","updated_at":"2018-08-07T21:39:21Z","html_url":"https://github.com/apache/incubator-daffodil/pull/88#discussion_r208394364","pull_request_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/88","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments/208394364"},"html":{"href":"https://github.com/apache/incubator-daffodil/pull/88#discussion_r208394364"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/88"}},"in_reply_to_id":208311521},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/88","id":204488417,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NDg4NDE3","html_url":"https://github.com/apache/incubator-daffodil/pull/88","diff_url":"https://github.com/apache/incubator-daffodil/pull/88.diff","patch_url":"https://github.com/apache/incubator-daffodil/pull/88.patch","issue_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/88","number":88,"state":"open","locked":false,"title":"Daffodil 1919 separators","user":{"login":"mbeckerle","id":1524099,"node_id":"MDQ6VXNlcjE1MjQwOTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1524099?v=4","gravatar_id":"","url":"https://api.github.com/users/mbeckerle","html_url":"https://github.com/mbeckerle","followers_url":"https://api.github.com/users/mbeckerle/followers","following_url":"https://api.github.com/users/mbeckerle/following{/other_user}","gists_url":"https://api.github.com/users/mbeckerle/gists{/gist_id}","starred_url":"https://api.github.com/users/mbeckerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbeckerle/subscriptions","organizations_url":"https://api.github.com/users/mbeckerle/orgs","repos_url":"https://api.github.com/users/mbeckerle/repos","events_url":"https://api.github.com/users/mbeckerle/events{/privacy}","received_events_url":"https://api.github.com/users/mbeckerle/received_events","type":"User","site_admin":false},"body":"Review for this large change set. \r\n\r\nThis is a rewrite of the way sequences and separators and repeating/scalar elements work.\r\nThe old structure was really just not up to the job of implementing the required behavior for DFDL's separator suppression capabilities. \r\n\r\nThere is a lot of change here, but the primary architectural \"twist\" is that instead of sequence combinators being trivial, and complexity being in the repeating-element combinators, the new way has complex sequence combinators, that drive occurrence-at-a-time repeating-element combinators. That is, the driver loop isn't in the repeating element combinators, but in the sequence combinators.\r\n\r\nAlso needed TDML \"threePass\" test capability. \r\n","created_at":"2018-07-27T17:05:25Z","updated_at":"2018-08-07T21:39:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62e62b172b76686a7d8948dc64b6758475b138b7","assignee":{"login":"mbeckerle","id":1524099,"node_id":"MDQ6VXNlcjE1MjQwOTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1524099?v=4","gravatar_id":"","url":"https://api.github.com/users/mbeckerle","html_url":"https://github.com/mbeckerle","followers_url":"https://api.github.com/users/mbeckerle/followers","following_url":"https://api.github.com/users/mbeckerle/following{/other_user}","gists_url":"https://api.github.com/users/mbeckerle/gists{/gist_id}","starred_url":"https://api.github.com/users/mbeckerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbeckerle/subscriptions","organizations_url":"https://api.github.com/users/mbeckerle/orgs","repos_url":"https://api.github.com/users/mbeckerle/repos","events_url":"https://api.github.com/users/mbeckerle/events{/privacy}","received_events_url":"https://api.github.com/users/mbeckerle/received_events","type":"User","site_admin":false},"assignees":[{"login":"mbeckerle","id":1524099,"node_id":"MDQ6VXNlcjE1MjQwOTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1524099?v=4","gravatar_id":"","url":"https://api.github.com/users/mbeckerle","html_url":"https://github.com/mbeckerle","followers_url":"https://api.github.com/users/mbeckerle/followers","following_url":"https://api.github.com/users/mbeckerle/following{/other_user}","gists_url":"https://api.github.com/users/mbeckerle/gists{/gist_id}","starred_url":"https://api.github.com/users/mbeckerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbeckerle/subscriptions","organizations_url":"https://api.github.com/users/mbeckerle/orgs","repos_url":"https://api.github.com/users/mbeckerle/repos","events_url":"https://api.github.com/users/mbeckerle/events{/privacy}","received_events_url":"https://api.github.com/users/mbeckerle/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jadams-tresys","id":30659277,"node_id":"MDQ6VXNlcjMwNjU5Mjc3","avatar_url":"https://avatars2.githubusercontent.com/u/30659277?v=4","gravatar_id":"","url":"https://api.github.com/users/jadams-tresys","html_url":"https://github.com/jadams-tresys","followers_url":"https://api.github.com/users/jadams-tresys/followers","following_url":"https://api.github.com/users/jadams-tresys/following{/other_user}","gists_url":"https://api.github.com/users/jadams-tresys/gists{/gist_id}","starred_url":"https://api.github.com/users/jadams-tresys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadams-tresys/subscriptions","organizations_url":"https://api.github.com/users/jadams-tresys/orgs","repos_url":"https://api.github.com/users/jadams-tresys/repos","events_url":"https://api.github.com/users/jadams-tresys/events{/privacy}","received_events_url":"https://api.github.com/users/jadams-tresys/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/88/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/88/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/88/comments","statuses_url":"https://api.github.com/repos/apache/incubator-daffodil/statuses/66cb366949e58eaf2de3f3cc3c865dc481fb2356","head":{"label":"mbeckerle:daffodil-1919-separators","ref":"daffodil-1919-separators","sha":"66cb366949e58eaf2de3f3cc3c865dc481fb2356","user":{"login":"mbeckerle","id":1524099,"node_id":"MDQ6VXNlcjE1MjQwOTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1524099?v=4","gravatar_id":"","url":"https://api.github.com/users/mbeckerle","html_url":"https://github.com/mbeckerle","followers_url":"https://api.github.com/users/mbeckerle/followers","following_url":"https://api.github.com/users/mbeckerle/following{/other_user}","gists_url":"https://api.github.com/users/mbeckerle/gists{/gist_id}","starred_url":"https://api.github.com/users/mbeckerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbeckerle/subscriptions","organizations_url":"https://api.github.com/users/mbeckerle/orgs","repos_url":"https://api.github.com/users/mbeckerle/repos","events_url":"https://api.github.com/users/mbeckerle/events{/privacy}","received_events_url":"https://api.github.com/users/mbeckerle/received_events","type":"User","site_admin":false},"repo":{"id":108433914,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg0MzM5MTQ=","name":"incubator-daffodil","full_name":"mbeckerle/incubator-daffodil","owner":{"login":"mbeckerle","id":1524099,"node_id":"MDQ6VXNlcjE1MjQwOTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1524099?v=4","gravatar_id":"","url":"https://api.github.com/users/mbeckerle","html_url":"https://github.com/mbeckerle","followers_url":"https://api.github.com/users/mbeckerle/followers","following_url":"https://api.github.com/users/mbeckerle/following{/other_user}","gists_url":"https://api.github.com/users/mbeckerle/gists{/gist_id}","starred_url":"https://api.github.com/users/mbeckerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbeckerle/subscriptions","organizations_url":"https://api.github.com/users/mbeckerle/orgs","repos_url":"https://api.github.com/users/mbeckerle/repos","events_url":"https://api.github.com/users/mbeckerle/events{/privacy}","received_events_url":"https://api.github.com/users/mbeckerle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbeckerle/incubator-daffodil","description":"Mirror of Apache daffodil (Incubating)","fork":true,"url":"https://api.github.com/repos/mbeckerle/incubator-daffodil","forks_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/forks","keys_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/teams","hooks_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/hooks","issue_events_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/issues/events{/number}","events_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/events","assignees_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/assignees{/user}","branches_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/branches{/branch}","tags_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/tags","blobs_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/statuses/{sha}","languages_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/languages","stargazers_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/stargazers","contributors_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/contributors","subscribers_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/subscribers","subscription_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/subscription","commits_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/contents/{+path}","compare_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/merges","archive_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/downloads","issues_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/issues{/number}","pulls_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/pulls{/number}","milestones_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/milestones{/number}","notifications_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/labels{/name}","releases_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/releases{/id}","deployments_url":"https://api.github.com/repos/mbeckerle/incubator-daffodil/deployments","created_at":"2017-10-26T16:00:06Z","updated_at":"2018-05-07T21:05:32Z","pushed_at":"2018-08-06T12:59:42Z","git_url":"git://github.com/mbeckerle/incubator-daffodil.git","ssh_url":"git@github.com:mbeckerle/incubator-daffodil.git","clone_url":"https://github.com/mbeckerle/incubator-daffodil.git","svn_url":"https://github.com/mbeckerle/incubator-daffodil","homepage":null,"size":169938,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a83b3772bc5d6eccb127babc7278ef797db29c75","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":101730006,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE3MzAwMDY=","name":"incubator-daffodil","full_name":"apache/incubator-daffodil","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-daffodil","description":"Apache Daffodil (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-daffodil","forks_url":"https://api.github.com/repos/apache/incubator-daffodil/forks","keys_url":"https://api.github.com/repos/apache/incubator-daffodil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-daffodil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-daffodil/teams","hooks_url":"https://api.github.com/repos/apache/incubator-daffodil/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-daffodil/events","assignees_url":"https://api.github.com/repos/apache/incubator-daffodil/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-daffodil/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-daffodil/tags","blobs_url":"https://api.github.com/repos/apache/incubator-daffodil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-daffodil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-daffodil/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-daffodil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-daffodil/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-daffodil/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-daffodil/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-daffodil/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-daffodil/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-daffodil/subscription","commits_url":"https://api.github.com/repos/apache/incubator-daffodil/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-daffodil/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-daffodil/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-daffodil/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-daffodil/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-daffodil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-daffodil/merges","archive_url":"https://api.github.com/repos/apache/incubator-daffodil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-daffodil/downloads","issues_url":"https://api.github.com/repos/apache/incubator-daffodil/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-daffodil/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-daffodil/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-daffodil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-daffodil/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-daffodil/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-daffodil/deployments","created_at":"2017-08-29T07:00:10Z","updated_at":"2018-08-06T13:43:57Z","pushed_at":"2018-08-06T13:43:50Z","git_url":"git://github.com/apache/incubator-daffodil.git","ssh_url":"git@github.com:apache/incubator-daffodil.git","clone_url":"https://github.com/apache/incubator-daffodil.git","svn_url":"https://github.com/apache/incubator-daffodil","homepage":"https://daffodil.apache.org/","size":169793,"stargazers_count":6,"watchers_count":6,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":3,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/88"},"html":{"href":"https://github.com/apache/incubator-daffodil/pull/88"},"issue":{"href":"https://api.github.com/repos/apache/incubator-daffodil/issues/88"},"comments":{"href":"https://api.github.com/repos/apache/incubator-daffodil/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-daffodil/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-daffodil/statuses/66cb366949e58eaf2de3f3cc3c865dc481fb2356"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mbeckerle"}}