{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/166123125","pull_request_review_id":94155416,"id":166123125,"diff_hunk":"@@ -0,0 +1,48 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements. See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License. You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package org.apache.kafka.streams.processor.internals;\n+\n+import org.apache.kafka.streams.processor.To;\n+\n+import java.util.List;\n+\n+class ToInternal extends To {\n+    private final String childName;\n+\n+    ToInternal(final To to, List<ProcessorNode> children) {\n+        super(to);\n+        if (super.childName != null) {\n+            childName = super.childName;\n+        } else if (super.childIndex != -1) {\n+            childName = children.get(super.childIndex).name();\n+        } else {\n+            childName = null;\n+        }\n+    }\n+\n+    boolean hasTimestamp() {\n+        return timestamp != -1;\n+    }\n+\n+    long timestamp() {\n+        return timestamp;\n+    }\n+\n+    boolean hasChild(final String childName) {\n+        return this.childName == null || this.childName.equals(childName);","path":"streams/src/main/java/org/apache/kafka/streams/processor/internals/ToInternal.java","position":46,"original_position":46,"commit_id":"dd9209d7ee58e909bc9062ad32d622a190857ef0","original_commit_id":"dd9209d7ee58e909bc9062ad32d622a190857ef0","user":{"login":"bbejeck","id":199238,"avatar_url":"https://avatars3.githubusercontent.com/u/199238?v=4","gravatar_id":"","url":"https://api.github.com/users/bbejeck","html_url":"https://github.com/bbejeck","followers_url":"https://api.github.com/users/bbejeck/followers","following_url":"https://api.github.com/users/bbejeck/following{/other_user}","gists_url":"https://api.github.com/users/bbejeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bbejeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbejeck/subscriptions","organizations_url":"https://api.github.com/users/bbejeck/orgs","repos_url":"https://api.github.com/users/bbejeck/repos","events_url":"https://api.github.com/users/bbejeck/events{/privacy}","received_events_url":"https://api.github.com/users/bbejeck/received_events","type":"User","site_admin":false},"body":"I agree with you about the constructor.  I like the method idea, but the comment would work as well.","created_at":"2018-02-05T21:50:20Z","updated_at":"2018-02-05T21:50:20Z","html_url":"https://github.com/apache/kafka/pull/4519#discussion_r166123125","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/4519","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/166123125"},"html":{"href":"https://github.com/apache/kafka/pull/4519#discussion_r166123125"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/4519"}},"in_reply_to_id":166023690},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/4519","id":166933871,"html_url":"https://github.com/apache/kafka/pull/4519","diff_url":"https://github.com/apache/kafka/pull/4519.diff","patch_url":"https://github.com/apache/kafka/pull/4519.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/4519","number":4519,"state":"open","locked":false,"title":"KAFKA-6454: Allow timestamp manipulation in Processor API","user":{"login":"mjsax","id":8959638,"avatar_url":"https://avatars1.githubusercontent.com/u/8959638?v=4","gravatar_id":"","url":"https://api.github.com/users/mjsax","html_url":"https://github.com/mjsax","followers_url":"https://api.github.com/users/mjsax/followers","following_url":"https://api.github.com/users/mjsax/following{/other_user}","gists_url":"https://api.github.com/users/mjsax/gists{/gist_id}","starred_url":"https://api.github.com/users/mjsax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjsax/subscriptions","organizations_url":"https://api.github.com/users/mjsax/orgs","repos_url":"https://api.github.com/users/mjsax/repos","events_url":"https://api.github.com/users/mjsax/events{/privacy}","received_events_url":"https://api.github.com/users/mjsax/received_events","type":"User","site_admin":false},"body":"implements KIP-251\r\n","created_at":"2018-02-03T00:34:19Z","updated_at":"2018-02-05T21:50:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"258337826c49c8302549c91bb9b461a87129a31e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dguy","id":54829,"avatar_url":"https://avatars2.githubusercontent.com/u/54829?v=4","gravatar_id":"","url":"https://api.github.com/users/dguy","html_url":"https://github.com/dguy","followers_url":"https://api.github.com/users/dguy/followers","following_url":"https://api.github.com/users/dguy/following{/other_user}","gists_url":"https://api.github.com/users/dguy/gists{/gist_id}","starred_url":"https://api.github.com/users/dguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguy/subscriptions","organizations_url":"https://api.github.com/users/dguy/orgs","repos_url":"https://api.github.com/users/dguy/repos","events_url":"https://api.github.com/users/dguy/events{/privacy}","received_events_url":"https://api.github.com/users/dguy/received_events","type":"User","site_admin":false},{"login":"guozhangwang","id":10729597,"avatar_url":"https://avatars0.githubusercontent.com/u/10729597?v=4","gravatar_id":"","url":"https://api.github.com/users/guozhangwang","html_url":"https://github.com/guozhangwang","followers_url":"https://api.github.com/users/guozhangwang/followers","following_url":"https://api.github.com/users/guozhangwang/following{/other_user}","gists_url":"https://api.github.com/users/guozhangwang/gists{/gist_id}","starred_url":"https://api.github.com/users/guozhangwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guozhangwang/subscriptions","organizations_url":"https://api.github.com/users/guozhangwang/orgs","repos_url":"https://api.github.com/users/guozhangwang/repos","events_url":"https://api.github.com/users/guozhangwang/events{/privacy}","received_events_url":"https://api.github.com/users/guozhangwang/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/4519/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/4519/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/4519/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/dd9209d7ee58e909bc9062ad32d622a190857ef0","head":{"label":"mjsax:kafka-6454-timestamp-papi","ref":"kafka-6454-timestamp-papi","sha":"dd9209d7ee58e909bc9062ad32d622a190857ef0","user":{"login":"mjsax","id":8959638,"avatar_url":"https://avatars1.githubusercontent.com/u/8959638?v=4","gravatar_id":"","url":"https://api.github.com/users/mjsax","html_url":"https://github.com/mjsax","followers_url":"https://api.github.com/users/mjsax/followers","following_url":"https://api.github.com/users/mjsax/following{/other_user}","gists_url":"https://api.github.com/users/mjsax/gists{/gist_id}","starred_url":"https://api.github.com/users/mjsax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjsax/subscriptions","organizations_url":"https://api.github.com/users/mjsax/orgs","repos_url":"https://api.github.com/users/mjsax/repos","events_url":"https://api.github.com/users/mjsax/events{/privacy}","received_events_url":"https://api.github.com/users/mjsax/received_events","type":"User","site_admin":false},"repo":{"id":50839421,"name":"kafka","full_name":"mjsax/kafka","owner":{"login":"mjsax","id":8959638,"avatar_url":"https://avatars1.githubusercontent.com/u/8959638?v=4","gravatar_id":"","url":"https://api.github.com/users/mjsax","html_url":"https://github.com/mjsax","followers_url":"https://api.github.com/users/mjsax/followers","following_url":"https://api.github.com/users/mjsax/following{/other_user}","gists_url":"https://api.github.com/users/mjsax/gists{/gist_id}","starred_url":"https://api.github.com/users/mjsax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjsax/subscriptions","organizations_url":"https://api.github.com/users/mjsax/orgs","repos_url":"https://api.github.com/users/mjsax/repos","events_url":"https://api.github.com/users/mjsax/events{/privacy}","received_events_url":"https://api.github.com/users/mjsax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mjsax/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/mjsax/kafka","forks_url":"https://api.github.com/repos/mjsax/kafka/forks","keys_url":"https://api.github.com/repos/mjsax/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mjsax/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mjsax/kafka/teams","hooks_url":"https://api.github.com/repos/mjsax/kafka/hooks","issue_events_url":"https://api.github.com/repos/mjsax/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/mjsax/kafka/events","assignees_url":"https://api.github.com/repos/mjsax/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/mjsax/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/mjsax/kafka/tags","blobs_url":"https://api.github.com/repos/mjsax/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mjsax/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mjsax/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/mjsax/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mjsax/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/mjsax/kafka/languages","stargazers_url":"https://api.github.com/repos/mjsax/kafka/stargazers","contributors_url":"https://api.github.com/repos/mjsax/kafka/contributors","subscribers_url":"https://api.github.com/repos/mjsax/kafka/subscribers","subscription_url":"https://api.github.com/repos/mjsax/kafka/subscription","commits_url":"https://api.github.com/repos/mjsax/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/mjsax/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/mjsax/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/mjsax/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/mjsax/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/mjsax/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mjsax/kafka/merges","archive_url":"https://api.github.com/repos/mjsax/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mjsax/kafka/downloads","issues_url":"https://api.github.com/repos/mjsax/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/mjsax/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/mjsax/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/mjsax/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mjsax/kafka/labels{/name}","releases_url":"https://api.github.com/repos/mjsax/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/mjsax/kafka/deployments","created_at":"2016-02-01T12:57:30Z","updated_at":"2016-02-01T12:57:34Z","pushed_at":"2018-02-03T22:23:01Z","git_url":"git://github.com/mjsax/kafka.git","ssh_url":"git@github.com:mjsax/kafka.git","clone_url":"https://github.com/mjsax/kafka.git","svn_url":"https://github.com/mjsax/kafka","homepage":null,"size":59955,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"505adefcecc6e7282b73f934aa8c7a59adcb675e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2018-02-05T16:00:02Z","pushed_at":"2018-02-05T21:47:24Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":62506,"stargazers_count":7342,"watchers_count":7342,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4394,"mirror_url":null,"archived":false,"open_issues_count":447,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4394,"open_issues":447,"watchers":7342,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/4519"},"html":{"href":"https://github.com/apache/kafka/pull/4519"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/4519"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/4519/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/4519/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/4519/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/dd9209d7ee58e909bc9062ad32d622a190857ef0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bbejeck"}}