{"action":"created","issue":{"url":"https://api.github.com/repos/mostaphaRoudsari/honeybee/issues/707","repository_url":"https://api.github.com/repos/mostaphaRoudsari/honeybee","labels_url":"https://api.github.com/repos/mostaphaRoudsari/honeybee/issues/707/labels{/name}","comments_url":"https://api.github.com/repos/mostaphaRoudsari/honeybee/issues/707/comments","events_url":"https://api.github.com/repos/mostaphaRoudsari/honeybee/issues/707/events","html_url":"https://github.com/mostaphaRoudsari/honeybee/pull/707","id":374454688,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MTUzNzU5","number":707,"title":"Correction to gbXML to Honeybee component for OS 2.7 compatiblity and correcting material/construction loading into corresponding HB dictionaries","user":{"login":"saeranv","id":1685956,"node_id":"MDQ6VXNlcjE2ODU5NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1685956?v=4","gravatar_id":"","url":"https://api.github.com/users/saeranv","html_url":"https://github.com/saeranv","followers_url":"https://api.github.com/users/saeranv/followers","following_url":"https://api.github.com/users/saeranv/following{/other_user}","gists_url":"https://api.github.com/users/saeranv/gists{/gist_id}","starred_url":"https://api.github.com/users/saeranv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saeranv/subscriptions","organizations_url":"https://api.github.com/users/saeranv/orgs","repos_url":"https://api.github.com/users/saeranv/repos","events_url":"https://api.github.com/users/saeranv/events{/privacy}","received_events_url":"https://api.github.com/users/saeranv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-26T16:20:09Z","updated_at":"2018-10-27T19:14:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mostaphaRoudsari/honeybee/pulls/707","html_url":"https://github.com/mostaphaRoudsari/honeybee/pull/707","diff_url":"https://github.com/mostaphaRoudsari/honeybee/pull/707.diff","patch_url":"https://github.com/mostaphaRoudsari/honeybee/pull/707.patch"},"body":"There are two modifications here, one to the way in which the OpenStudio API is used to load the OSM model from a gbxml file, and secondly to the way materials/constructions are loaded into Honeybee from the gbxml method. \r\n\r\nFor the first one: I've recently been working with a recent build of OpenStudio (2.7+) in order to get access to a working version of the gbXML translator (see details here https://github.com/NREL/OpenStudio/issues/3296). The previous HB method wasn't working to load the gbxml model from the translator, and with some coaching from the OS developers, I changed the file import method. This is for the latest OpenStudio build only, and I haven't tested it on previous releases, so it might make sense to reject this part of the PR for now. I just wanted to make sure it was documented somewhere here in case it was needed when the upgrade to OpenStudio 2.7+ eventually occurs. \r\n\r\nSecondly, the materials/constructions from my gbXML were not being found by the Honeybee Decompose from EPConstruciton component. It looks like it's because of this code in that component: \r\n\r\nhttps://github.com/mostaphaRoudsari/honeybee/blob/4e67a49996da8dba818430a3516474d83105249a/src/Honeybee_Decompose%20EP%20Construction.py#L76-L83\r\n\r\n\r\nwhich is looking for an uppercase version of the gbxml-added construction/material names. \r\n\r\nSo I changed the method in which the gbxml materials/construction names are added to the Honeybee material/constructions library as keys, which seems to have fixed the problem.\r\n\r\nI've never really worked with this part of the HB code, so I'm not sure if this is neccessarily the correct way of dealing with these bugs! However with this I managed to import all the materials/constructions from a gbxml file into Honeybee, which is a crucial workflow process we need at KT. \r\n\r\n-S   \r\n \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mostaphaRoudsari/honeybee/issues/comments/433647567","html_url":"https://github.com/mostaphaRoudsari/honeybee/pull/707#issuecomment-433647567","issue_url":"https://api.github.com/repos/mostaphaRoudsari/honeybee/issues/707","id":433647567,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzY0NzU2Nw==","user":{"login":"chriswmackey","id":5567574,"node_id":"MDQ6VXNlcjU1Njc1NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5567574?v=4","gravatar_id":"","url":"https://api.github.com/users/chriswmackey","html_url":"https://github.com/chriswmackey","followers_url":"https://api.github.com/users/chriswmackey/followers","following_url":"https://api.github.com/users/chriswmackey/following{/other_user}","gists_url":"https://api.github.com/users/chriswmackey/gists{/gist_id}","starred_url":"https://api.github.com/users/chriswmackey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriswmackey/subscriptions","organizations_url":"https://api.github.com/users/chriswmackey/orgs","repos_url":"https://api.github.com/users/chriswmackey/repos","events_url":"https://api.github.com/users/chriswmackey/events{/privacy}","received_events_url":"https://api.github.com/users/chriswmackey/received_events","type":"User","site_admin":false},"created_at":"2018-10-27T19:14:29Z","updated_at":"2018-10-27T19:14:29Z","author_association":"COLLABORATOR","body":"@saeranv ,\r\nThank you for doing this and I know that there were so many changes with OpenStudio 2.7 that broke a lot of existing workflows.  We should definitely get these fixes in before the next stable release of Honeybee legacy.\r\n\r\nYour changes makes sense and, to be honest, the legacy version code here really doesn't have too many rules to it (it's not like the core libraries where we need all of the code to be clean).  As long as the code works, I will merge it but, in order to do so, we need to have it working in both current AND older versions of OpenStudio.  I would parse the path to openstudio like I do here:\r\nhttps://github.com/mostaphaRoudsari/honeybee/blob/master/src/Honeybee_Export%20To%20OpenStudio.py#L111-L120\r\nThen, you can use the version to decide which code to use depending on which version of OpenStudio is loaded.\r\n\r\nThank again!"}}
{"actor":{"display_login":"chriswmackey"}}