{"action":"created","issue":{"url":"https://api.github.com/repos/boostorg/thread/issues/249","repository_url":"https://api.github.com/repos/boostorg/thread","labels_url":"https://api.github.com/repos/boostorg/thread/issues/249/labels{/name}","comments_url":"https://api.github.com/repos/boostorg/thread/issues/249/comments","events_url":"https://api.github.com/repos/boostorg/thread/issues/249/events","html_url":"https://github.com/boostorg/thread/pull/249","id":381858894,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzI1Mzcw","number":249,"title":"Simplify TSS cleanup routines. Fixes #236","user":{"login":"Kojoley","id":2743474,"node_id":"MDQ6VXNlcjI3NDM0NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2743474?v=4","gravatar_id":"","url":"https://api.github.com/users/Kojoley","html_url":"https://github.com/Kojoley","followers_url":"https://api.github.com/users/Kojoley/followers","following_url":"https://api.github.com/users/Kojoley/following{/other_user}","gists_url":"https://api.github.com/users/Kojoley/gists{/gist_id}","starred_url":"https://api.github.com/users/Kojoley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kojoley/subscriptions","organizations_url":"https://api.github.com/users/Kojoley/orgs","repos_url":"https://api.github.com/users/Kojoley/repos","events_url":"https://api.github.com/users/Kojoley/events{/privacy}","received_events_url":"https://api.github.com/users/Kojoley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-11-17T12:30:27Z","updated_at":"2018-11-21T21:04:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/boostorg/thread/pulls/249","html_url":"https://github.com/boostorg/thread/pull/249","diff_url":"https://github.com/boostorg/thread/pull/249.diff","patch_url":"https://github.com/boostorg/thread/pull/249.patch"},"body":"Instead of wrapping a default or user provided destructor into a virtual\r\nclass and placing it into a shared_ptr it is now stored directly with\r\nan elided type, to not introduce UB it is not called directly but through\r\na helper function which casts it back to the original type before calling.\r\n\r\nI tried to touch as little lines as possible to make the review simpler."},"comment":{"url":"https://api.github.com/repos/boostorg/thread/issues/comments/440807693","html_url":"https://github.com/boostorg/thread/pull/249#issuecomment-440807693","issue_url":"https://api.github.com/repos/boostorg/thread/issues/249","id":440807693,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDgwNzY5Mw==","user":{"login":"Kojoley","id":2743474,"node_id":"MDQ6VXNlcjI3NDM0NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2743474?v=4","gravatar_id":"","url":"https://api.github.com/users/Kojoley","html_url":"https://github.com/Kojoley","followers_url":"https://api.github.com/users/Kojoley/followers","following_url":"https://api.github.com/users/Kojoley/following{/other_user}","gists_url":"https://api.github.com/users/Kojoley/gists{/gist_id}","starred_url":"https://api.github.com/users/Kojoley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kojoley/subscriptions","organizations_url":"https://api.github.com/users/Kojoley/orgs","repos_url":"https://api.github.com/users/Kojoley/repos","events_url":"https://api.github.com/users/Kojoley/events{/privacy}","received_events_url":"https://api.github.com/users/Kojoley/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T21:04:05Z","updated_at":"2018-11-21T21:04:05Z","author_association":"CONTRIBUTOR","body":"OMG, you are killig me. The PR:\r\n\r\n  1. Removes (potential) UB.\r\n  2. Simplifies the code by reducing number of dependencies.\r\n  4. Makes TSS faster by removing `shared_ptr`.\r\n"}}
{"actor":{"display_login":"Kojoley"}}