{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59346","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59346/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59346/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59346/events","html_url":"https://github.com/kubernetes/kubernetes/pull/59346","id":294379057,"number":59346,"title":"Don't allow shared types as CRD kinds","user":{"login":"nikhita","id":16105680,"avatar_url":"https://avatars1.githubusercontent.com/u/16105680?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhita","html_url":"https://github.com/nikhita","followers_url":"https://api.github.com/users/nikhita/followers","following_url":"https://api.github.com/users/nikhita/following{/other_user}","gists_url":"https://api.github.com/users/nikhita/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhita/subscriptions","organizations_url":"https://api.github.com/users/nikhita/orgs","repos_url":"https://api.github.com/users/nikhita/repos","events_url":"https://api.github.com/users/nikhita/events{/privacy}","received_events_url":"https://api.github.com/users/nikhita/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":556590057,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/custom-resources","name":"area/custom-resources","color":"0052cc","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173493835,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/37","html_url":"https://github.com/kubernetes/kubernetes/milestone/37","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/37/labels","id":2659046,"number":37,"title":"v1.10","description":null,"creator":{"login":"mtaufen","id":903617,"avatar_url":"https://avatars1.githubusercontent.com/u/903617?v=4","gravatar_id":"","url":"https://api.github.com/users/mtaufen","html_url":"https://github.com/mtaufen","followers_url":"https://api.github.com/users/mtaufen/followers","following_url":"https://api.github.com/users/mtaufen/following{/other_user}","gists_url":"https://api.github.com/users/mtaufen/gists{/gist_id}","starred_url":"https://api.github.com/users/mtaufen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtaufen/subscriptions","organizations_url":"https://api.github.com/users/mtaufen/orgs","repos_url":"https://api.github.com/users/mtaufen/repos","events_url":"https://api.github.com/users/mtaufen/events{/privacy}","received_events_url":"https://api.github.com/users/mtaufen/received_events","type":"User","site_admin":false},"open_issues":80,"closed_issues":183,"state":"open","created_at":"2017-07-24T18:50:54Z","updated_at":"2018-02-25T12:22:28Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2018-02-05T12:39:56Z","updated_at":"2018-02-25T12:48:30Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/59346","html_url":"https://github.com/kubernetes/kubernetes/pull/59346","diff_url":"https://github.com/kubernetes/kubernetes/pull/59346.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/59346.patch"},"body":"Shared types (meta/v1 and unversioned) are top-level types and exist across all group versions. If a CRD kind is a top-level type, it leads to inconsistent behavior with kubectl.\r\n\r\nSo we should exclude such types from valid kind names in CRDs.\r\n\r\nFixes kubernetes/kubectl#186\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nCustomResourceDefinitions containing the following values for `spec.names.kind` are no longer permitted. Before upgrading, ensure CRDs do not contain these values.\r\n\r\n[\"ListOptions\", \"ExportOptions\", \"GetOptions\", \"DeleteOptions\", \"Status\", \"APIVersions\", \"APIGroupList\", \"APIGroup\", \"APIResourceList\", \"WatchEvent\"]\r\n```\r\n\r\n/cc sttts deads2k liggitt adohe \r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/368306677","html_url":"https://github.com/kubernetes/kubernetes/pull/59346#issuecomment-368306677","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/59346","id":368306677,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-02-25T12:48:30Z","updated_at":"2018-02-25T12:48:30Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/59346#\" title=\"Author self-approved\">nikhita</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/59346#issuecomment-366147093\" title=\"Approved\">sttts</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details >\nNeeds approval from an approver in each of these files:\n\n- ~~[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/hack/OWNERS)~~ [sttts]\n- ~~[staging/src/k8s.io/apiextensions-apiserver/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiextensions-apiserver/OWNERS)~~ [sttts]\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}