{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/4438","repository_url":"https://api.github.com/repos/facebook/rocksdb","labels_url":"https://api.github.com/repos/facebook/rocksdb/issues/4438/labels{/name}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/4438/comments","events_url":"https://api.github.com/repos/facebook/rocksdb/issues/4438/events","html_url":"https://github.com/facebook/rocksdb/pull/4438","id":365060878,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTAwNjA3","number":4438,"title":"Fix CompactFiles support for kDisableCompressionOption","user":{"login":"ajkr","id":4780362,"node_id":"MDQ6VXNlcjQ3ODAzNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4780362?v=4","gravatar_id":"","url":"https://api.github.com/users/ajkr","html_url":"https://github.com/ajkr","followers_url":"https://api.github.com/users/ajkr/followers","following_url":"https://api.github.com/users/ajkr/following{/other_user}","gists_url":"https://api.github.com/users/ajkr/gists{/gist_id}","starred_url":"https://api.github.com/users/ajkr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajkr/subscriptions","organizations_url":"https://api.github.com/users/ajkr/orgs","repos_url":"https://api.github.com/users/ajkr/repos","events_url":"https://api.github.com/users/ajkr/events{/privacy}","received_events_url":"https://api.github.com/users/ajkr/received_events","type":"User","site_admin":false},"labels":[{"id":196859108,"node_id":"MDU6TGFiZWwxOTY4NTkxMDg=","url":"https://api.github.com/repos/facebook/rocksdb/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-28T22:30:08Z","updated_at":"2018-09-30T17:49:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/4438","html_url":"https://github.com/facebook/rocksdb/pull/4438","diff_url":"https://github.com/facebook/rocksdb/pull/4438.diff","patch_url":"https://github.com/facebook/rocksdb/pull/4438.patch"},"body":"Previously `CompactFiles` with `CompressionType::kDisableCompressionOption` caused program to crash on assertion failure. This PR fixes the crash by adding support for that setting. Now, that setting will cause RocksDB to choose compression according to the column family's options.\r\n\r\nTest Plan: \r\n- new unit test\r\n- `make check -j64`"},"comment":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/comments/425738341","html_url":"https://github.com/facebook/rocksdb/pull/4438#issuecomment-425738341","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/4438","id":425738341,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTczODM0MQ==","user":{"login":"facebook-github-bot","id":6422482,"node_id":"MDQ6VXNlcjY0MjI0ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/6422482?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2018-09-30T17:49:11Z","updated_at":"2018-09-30T17:49:11Z","author_association":"NONE","body":"[@ajkr](https://github.com/ajkr) has updated the pull request. [Re-import the pull request](https://our.intern.facebook.com/intern/opensource/github/pull_request/confirm/import/248207792551482/)"}}
{"actor":{"display_login":"facebook-github-bot"}}