{"action":"created","comment":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments/173672252","pull_request_review_id":102898690,"id":173672252,"diff_hunk":"@@ -486,11 +516,12 @@ private static Token getMissedHtmlTag(RecognitionException exception) {\n         final Deque<Token> stack = new ArrayDeque<>();\n         for (int i = 0; i < tokenList.size(); i++) {\n             final Token token = tokenList.get(i);\n-            if (token.getType() == JavadocTokenTypes.HTML_TAG_NAME\n+            final int javadocTokenType = getJavadocTokenType(token.getType());","path":"src/main/java/com/puppycrawl/tools/checkstyle/JavadocDetailNodeParser.java","position":51,"original_position":51,"commit_id":"7813ff1d6b1fc49bd39745209bda42c31327e786","original_commit_id":"7813ff1d6b1fc49bd39745209bda42c31327e786","user":{"login":"romani","id":812984,"avatar_url":"https://avatars3.githubusercontent.com/u/812984?v=4","gravatar_id":"","url":"https://api.github.com/users/romani","html_url":"https://github.com/romani","followers_url":"https://api.github.com/users/romani/followers","following_url":"https://api.github.com/users/romani/following{/other_user}","gists_url":"https://api.github.com/users/romani/gists{/gist_id}","starred_url":"https://api.github.com/users/romani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romani/subscriptions","organizations_url":"https://api.github.com/users/romani/orgs","repos_url":"https://api.github.com/users/romani/repos","events_url":"https://api.github.com/users/romani/events{/privacy}","received_events_url":"https://api.github.com/users/romani/received_events","type":"User","site_admin":false},"body":"mapping to JavadocTokentypes should be done in one place, right after parsing. Non of other code should be affected by this mapping nuances.","created_at":"2018-03-11T22:20:49Z","updated_at":"2018-03-11T22:21:35Z","html_url":"https://github.com/checkstyle/checkstyle/pull/5455#discussion_r173672252","pull_request_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/5455","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments/173672252"},"html":{"href":"https://github.com/checkstyle/checkstyle/pull/5455#discussion_r173672252"},"pull_request":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/5455"}}},"pull_request":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/5455","id":162251440,"html_url":"https://github.com/checkstyle/checkstyle/pull/5455","diff_url":"https://github.com/checkstyle/checkstyle/pull/5455.diff","patch_url":"https://github.com/checkstyle/checkstyle/pull/5455.patch","issue_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/5455","number":5455,"state":"open","locked":false,"title":"Issue #5139: Restored token value for HTML_TAG_NAME back to version 8.1","user":{"login":"ps-sp","id":24826492,"avatar_url":"https://avatars3.githubusercontent.com/u/24826492?v=4","gravatar_id":"","url":"https://api.github.com/users/ps-sp","html_url":"https://github.com/ps-sp","followers_url":"https://api.github.com/users/ps-sp/followers","following_url":"https://api.github.com/users/ps-sp/following{/other_user}","gists_url":"https://api.github.com/users/ps-sp/gists{/gist_id}","starred_url":"https://api.github.com/users/ps-sp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ps-sp/subscriptions","organizations_url":"https://api.github.com/users/ps-sp/orgs","repos_url":"https://api.github.com/users/ps-sp/repos","events_url":"https://api.github.com/users/ps-sp/events{/privacy}","received_events_url":"https://api.github.com/users/ps-sp/received_events","type":"User","site_admin":false},"body":"Issue #5139: Restored token value for HTML_TAG_NAME back to version 8.1\r\n\r\n`HTML_TAG_NAME` has been hardcoded to have a value of 87 in `JavadocTokenTypes`, `EMBED_HTML_TAG_NAME` is assigned a value of 87 by ANTLR and has been hardcoded to have a value of 95 in `JavadocTokenTypes` _(95 is the value that's assigned to `HTML_TAG_NAME` by ANTLR)_.\r\n\r\nRelated discussion: https://github.com/checkstyle/checkstyle/pull/5101#pullrequestreview-72671739","created_at":"2018-01-10T22:52:39Z","updated_at":"2018-03-11T22:21:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecfb717de41718a40392a21193c30ea6b7e68437","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/5455/commits","review_comments_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/5455/comments","review_comment_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/5455/comments","statuses_url":"https://api.github.com/repos/checkstyle/checkstyle/statuses/7813ff1d6b1fc49bd39745209bda42c31327e786","head":{"label":"ps-sp:issue_5139-2","ref":"issue_5139-2","sha":"7813ff1d6b1fc49bd39745209bda42c31327e786","user":{"login":"ps-sp","id":24826492,"avatar_url":"https://avatars3.githubusercontent.com/u/24826492?v=4","gravatar_id":"","url":"https://api.github.com/users/ps-sp","html_url":"https://github.com/ps-sp","followers_url":"https://api.github.com/users/ps-sp/followers","following_url":"https://api.github.com/users/ps-sp/following{/other_user}","gists_url":"https://api.github.com/users/ps-sp/gists{/gist_id}","starred_url":"https://api.github.com/users/ps-sp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ps-sp/subscriptions","organizations_url":"https://api.github.com/users/ps-sp/orgs","repos_url":"https://api.github.com/users/ps-sp/repos","events_url":"https://api.github.com/users/ps-sp/events{/privacy}","received_events_url":"https://api.github.com/users/ps-sp/received_events","type":"User","site_admin":false},"repo":{"id":83771161,"name":"checkstyle","full_name":"ps-sp/checkstyle","owner":{"login":"ps-sp","id":24826492,"avatar_url":"https://avatars3.githubusercontent.com/u/24826492?v=4","gravatar_id":"","url":"https://api.github.com/users/ps-sp","html_url":"https://github.com/ps-sp","followers_url":"https://api.github.com/users/ps-sp/followers","following_url":"https://api.github.com/users/ps-sp/following{/other_user}","gists_url":"https://api.github.com/users/ps-sp/gists{/gist_id}","starred_url":"https://api.github.com/users/ps-sp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ps-sp/subscriptions","organizations_url":"https://api.github.com/users/ps-sp/orgs","repos_url":"https://api.github.com/users/ps-sp/repos","events_url":"https://api.github.com/users/ps-sp/events{/privacy}","received_events_url":"https://api.github.com/users/ps-sp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ps-sp/checkstyle","description":"Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.","fork":true,"url":"https://api.github.com/repos/ps-sp/checkstyle","forks_url":"https://api.github.com/repos/ps-sp/checkstyle/forks","keys_url":"https://api.github.com/repos/ps-sp/checkstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ps-sp/checkstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ps-sp/checkstyle/teams","hooks_url":"https://api.github.com/repos/ps-sp/checkstyle/hooks","issue_events_url":"https://api.github.com/repos/ps-sp/checkstyle/issues/events{/number}","events_url":"https://api.github.com/repos/ps-sp/checkstyle/events","assignees_url":"https://api.github.com/repos/ps-sp/checkstyle/assignees{/user}","branches_url":"https://api.github.com/repos/ps-sp/checkstyle/branches{/branch}","tags_url":"https://api.github.com/repos/ps-sp/checkstyle/tags","blobs_url":"https://api.github.com/repos/ps-sp/checkstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ps-sp/checkstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ps-sp/checkstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/ps-sp/checkstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ps-sp/checkstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/ps-sp/checkstyle/languages","stargazers_url":"https://api.github.com/repos/ps-sp/checkstyle/stargazers","contributors_url":"https://api.github.com/repos/ps-sp/checkstyle/contributors","subscribers_url":"https://api.github.com/repos/ps-sp/checkstyle/subscribers","subscription_url":"https://api.github.com/repos/ps-sp/checkstyle/subscription","commits_url":"https://api.github.com/repos/ps-sp/checkstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/ps-sp/checkstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/ps-sp/checkstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/ps-sp/checkstyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/ps-sp/checkstyle/contents/{+path}","compare_url":"https://api.github.com/repos/ps-sp/checkstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ps-sp/checkstyle/merges","archive_url":"https://api.github.com/repos/ps-sp/checkstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ps-sp/checkstyle/downloads","issues_url":"https://api.github.com/repos/ps-sp/checkstyle/issues{/number}","pulls_url":"https://api.github.com/repos/ps-sp/checkstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/ps-sp/checkstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/ps-sp/checkstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ps-sp/checkstyle/labels{/name}","releases_url":"https://api.github.com/repos/ps-sp/checkstyle/releases{/id}","deployments_url":"https://api.github.com/repos/ps-sp/checkstyle/deployments","created_at":"2017-03-03T07:35:24Z","updated_at":"2017-03-03T07:35:30Z","pushed_at":"2018-01-23T13:22:46Z","git_url":"git://github.com/ps-sp/checkstyle.git","ssh_url":"git@github.com:ps-sp/checkstyle.git","clone_url":"https://github.com/ps-sp/checkstyle.git","svn_url":"https://github.com/ps-sp/checkstyle","homepage":"http://checkstyle.sourceforge.net/","size":56729,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"checkstyle:master","ref":"master","sha":"9bcb6bffd03dc4f42f402bd126f22c730007861a","user":{"login":"checkstyle","id":5179750,"avatar_url":"https://avatars0.githubusercontent.com/u/5179750?v=4","gravatar_id":"","url":"https://api.github.com/users/checkstyle","html_url":"https://github.com/checkstyle","followers_url":"https://api.github.com/users/checkstyle/followers","following_url":"https://api.github.com/users/checkstyle/following{/other_user}","gists_url":"https://api.github.com/users/checkstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/checkstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checkstyle/subscriptions","organizations_url":"https://api.github.com/users/checkstyle/orgs","repos_url":"https://api.github.com/users/checkstyle/repos","events_url":"https://api.github.com/users/checkstyle/events{/privacy}","received_events_url":"https://api.github.com/users/checkstyle/received_events","type":"Organization","site_admin":false},"repo":{"id":12499251,"name":"checkstyle","full_name":"checkstyle/checkstyle","owner":{"login":"checkstyle","id":5179750,"avatar_url":"https://avatars0.githubusercontent.com/u/5179750?v=4","gravatar_id":"","url":"https://api.github.com/users/checkstyle","html_url":"https://github.com/checkstyle","followers_url":"https://api.github.com/users/checkstyle/followers","following_url":"https://api.github.com/users/checkstyle/following{/other_user}","gists_url":"https://api.github.com/users/checkstyle/gists{/gist_id}","starred_url":"https://api.github.com/users/checkstyle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/checkstyle/subscriptions","organizations_url":"https://api.github.com/users/checkstyle/orgs","repos_url":"https://api.github.com/users/checkstyle/repos","events_url":"https://api.github.com/users/checkstyle/events{/privacy}","received_events_url":"https://api.github.com/users/checkstyle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/checkstyle/checkstyle","description":"Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.","fork":false,"url":"https://api.github.com/repos/checkstyle/checkstyle","forks_url":"https://api.github.com/repos/checkstyle/checkstyle/forks","keys_url":"https://api.github.com/repos/checkstyle/checkstyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/checkstyle/checkstyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/checkstyle/checkstyle/teams","hooks_url":"https://api.github.com/repos/checkstyle/checkstyle/hooks","issue_events_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/events{/number}","events_url":"https://api.github.com/repos/checkstyle/checkstyle/events","assignees_url":"https://api.github.com/repos/checkstyle/checkstyle/assignees{/user}","branches_url":"https://api.github.com/repos/checkstyle/checkstyle/branches{/branch}","tags_url":"https://api.github.com/repos/checkstyle/checkstyle/tags","blobs_url":"https://api.github.com/repos/checkstyle/checkstyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/checkstyle/checkstyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/checkstyle/checkstyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/checkstyle/checkstyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/checkstyle/checkstyle/statuses/{sha}","languages_url":"https://api.github.com/repos/checkstyle/checkstyle/languages","stargazers_url":"https://api.github.com/repos/checkstyle/checkstyle/stargazers","contributors_url":"https://api.github.com/repos/checkstyle/checkstyle/contributors","subscribers_url":"https://api.github.com/repos/checkstyle/checkstyle/subscribers","subscription_url":"https://api.github.com/repos/checkstyle/checkstyle/subscription","commits_url":"https://api.github.com/repos/checkstyle/checkstyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/checkstyle/checkstyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/checkstyle/checkstyle/contents/{+path}","compare_url":"https://api.github.com/repos/checkstyle/checkstyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/checkstyle/checkstyle/merges","archive_url":"https://api.github.com/repos/checkstyle/checkstyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/checkstyle/checkstyle/downloads","issues_url":"https://api.github.com/repos/checkstyle/checkstyle/issues{/number}","pulls_url":"https://api.github.com/repos/checkstyle/checkstyle/pulls{/number}","milestones_url":"https://api.github.com/repos/checkstyle/checkstyle/milestones{/number}","notifications_url":"https://api.github.com/repos/checkstyle/checkstyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/labels{/name}","releases_url":"https://api.github.com/repos/checkstyle/checkstyle/releases{/id}","deployments_url":"https://api.github.com/repos/checkstyle/checkstyle/deployments","created_at":"2013-08-31T02:05:05Z","updated_at":"2018-03-11T20:00:09Z","pushed_at":"2018-03-11T20:47:55Z","git_url":"git://github.com/checkstyle/checkstyle.git","ssh_url":"git@github.com:checkstyle/checkstyle.git","clone_url":"https://github.com/checkstyle/checkstyle.git","svn_url":"https://github.com/checkstyle/checkstyle","homepage":"http://checkstyle.sourceforge.net/","size":56986,"stargazers_count":3497,"watchers_count":3497,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6354,"mirror_url":null,"archived":false,"open_issues_count":463,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":6354,"open_issues":463,"watchers":3497,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/5455"},"html":{"href":"https://github.com/checkstyle/checkstyle/pull/5455"},"issue":{"href":"https://api.github.com/repos/checkstyle/checkstyle/issues/5455"},"comments":{"href":"https://api.github.com/repos/checkstyle/checkstyle/issues/5455/comments"},"review_comments":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/5455/comments"},"review_comment":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/checkstyle/checkstyle/pulls/5455/commits"},"statuses":{"href":"https://api.github.com/repos/checkstyle/checkstyle/statuses/7813ff1d6b1fc49bd39745209bda42c31327e786"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"romani"}}