{"action":"created","issue":{"url":"https://api.github.com/repos/systemd/systemd/issues/8535","repository_url":"https://api.github.com/repos/systemd/systemd","labels_url":"https://api.github.com/repos/systemd/systemd/issues/8535/labels{/name}","comments_url":"https://api.github.com/repos/systemd/systemd/issues/8535/comments","events_url":"https://api.github.com/repos/systemd/systemd/issues/8535/events","html_url":"https://github.com/systemd/systemd/issues/8535","id":307428815,"number":8535,"title":"`systemd-time-wait-sync.service` seems to be failing to start inside user namespace containers","user":{"login":"evverx","id":10195800,"avatar_url":"https://avatars1.githubusercontent.com/u/10195800?v=4","gravatar_id":"","url":"https://api.github.com/users/evverx","html_url":"https://github.com/evverx","followers_url":"https://api.github.com/users/evverx/followers","following_url":"https://api.github.com/users/evverx/following{/other_user}","gists_url":"https://api.github.com/users/evverx/gists{/gist_id}","starred_url":"https://api.github.com/users/evverx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evverx/subscriptions","organizations_url":"https://api.github.com/users/evverx/orgs","repos_url":"https://api.github.com/users/evverx/repos","events_url":"https://api.github.com/users/evverx/events{/privacy}","received_events_url":"https://api.github.com/users/evverx/received_events","type":"User","site_admin":false},"labels":[{"id":231253570,"url":"https://api.github.com/repos/systemd/systemd/labels/timesync","name":"timesync","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-21T21:43:05Z","updated_at":"2018-03-21T21:51:04Z","closed_at":null,"author_association":"MEMBER","body":"I haven't read https://github.com/systemd/systemd/pull/8494 where `systemd-time-wait-sync.service` was introduced yet, so I'm not sure whether it is a bug or not:\r\n```sh\r\nbash-4.4# systemd-detect-virt\r\nsystemd-nspawn\r\n\r\nbash-4.4# systemd-detect-virt --private-users\r\nbash-4.4# echo $?\r\n0\r\n\r\nbash-4.4# systemctl --failed --no-pager\r\n  UNIT                           LOAD   ACTIVE SUB    DESCRIPTION\r\n● systemd-time-wait-sync.service loaded failed failed Wait Until Kernel Time Synchronized\r\n\r\nLOAD   = Reflects whether the unit definition was properly loaded.\r\nACTIVE = The high-level unit activation state, i.e. generalization of SUB.\r\nSUB    = The low-level unit activation state, values depend on unit type.\r\n\r\n1 loaded units listed. Pass --all to see loaded but inactive units, too.\r\nTo show all installed unit files use 'systemctl list-unit-files'.\r\n\r\nbash-4.4# journalctl -b | grep -i time-wait-sync\r\nMar 20 13:34:27 systemd-testsuite systemd[23]: systemd-time-wait-sync.service: Executing: /usr/lib/systemd/systemd-time-wait-sync\r\nMar 20 13:34:27 systemd-testsuite systemd-time-wait-sync[23]: Failed to read adjtimex state: Operation not permitted\r\n```"},"comment":{"url":"https://api.github.com/repos/systemd/systemd/issues/comments/375107871","html_url":"https://github.com/systemd/systemd/issues/8535#issuecomment-375107871","issue_url":"https://api.github.com/repos/systemd/systemd/issues/8535","id":375107871,"user":{"login":"poettering","id":2130732,"avatar_url":"https://avatars1.githubusercontent.com/u/2130732?v=4","gravatar_id":"","url":"https://api.github.com/users/poettering","html_url":"https://github.com/poettering","followers_url":"https://api.github.com/users/poettering/followers","following_url":"https://api.github.com/users/poettering/following{/other_user}","gists_url":"https://api.github.com/users/poettering/gists{/gist_id}","starred_url":"https://api.github.com/users/poettering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poettering/subscriptions","organizations_url":"https://api.github.com/users/poettering/orgs","repos_url":"https://api.github.com/users/poettering/repos","events_url":"https://api.github.com/users/poettering/events{/privacy}","received_events_url":"https://api.github.com/users/poettering/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T21:51:04Z","updated_at":"2018-03-21T21:51:04Z","author_association":"OWNER","body":"Hmm, I figure adjitemex() will fail in various container setups. Let's handle that gracefully, and simply assume that if we get EPERM or EACCES on adjtimex() we run inside a container, and the clock is set correctly anyway. \r\n\r\n@pabigot any chance you can hack up a quick patch for this?\r\n\r\nMaybe add a brief log_debug() message explaining the assumption when we exit early if adjtimex() fails like this."}}
{"actor":{"display_login":"poettering"}}