{"action":"created","comment":{"url":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/comments/215832720","pull_request_review_id":153187840,"id":215832720,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTgzMjcyMA==","diff_hunk":"@@ -95,3 +95,10 @@ interface Overloads {\n   void foo(DOMString arg, optional long a);\n   void foo(DOMString arg, (float or short) b);\n };\n+\n+callback MyCallback = any();\n+\n+[Constructor()]\n+interface InvokeCallback {\n+  void invoke(MyCallback callback);\n+};","path":"crates/webidl-tests/simple.webidl","position":null,"original_position":10,"commit_id":"457efc0f31f336cffa96eca70994956af01c03ab","original_commit_id":"493aaf7aaf14961acede1fdb39bf36bdf319d8b4","user":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"Sure thing!","created_at":"2018-09-07T02:51:04Z","updated_at":"2018-09-07T02:51:04Z","html_url":"https://github.com/rustwasm/wasm-bindgen/pull/796#discussion_r215832720","pull_request_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/796","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/comments/215832720"},"html":{"href":"https://github.com/rustwasm/wasm-bindgen/pull/796#discussion_r215832720"},"pull_request":{"href":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/796"}},"in_reply_to_id":215814045},"pull_request":{"url":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/796","id":213779680,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzc5Njgw","html_url":"https://github.com/rustwasm/wasm-bindgen/pull/796","diff_url":"https://github.com/rustwasm/wasm-bindgen/pull/796.diff","patch_url":"https://github.com/rustwasm/wasm-bindgen/pull/796.patch","issue_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/issues/796","number":796,"state":"open","locked":false,"title":"Implement support for WebIDL `Callback` types","user":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"This commit adds support for the WebIDL `Callback` type by translating all\r\ncallbacks to the `js_sys::Function` type. This will enable passing raw JS values\r\ninto callbacks as well as Rust valus using the `Closure` type.\r\n\r\nThis commit doesn't currently implement \"callback interfaces\" in WebIDL, that's\r\nleft for a follow-up commit.","created_at":"2018-09-06T23:42:04Z","updated_at":"2018-09-07T02:51:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d06fb5ba1f3be456e4e52f98cde5cb2bcd5663ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/796/commits","review_comments_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/796/comments","review_comment_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/issues/796/comments","statuses_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/statuses/457efc0f31f336cffa96eca70994956af01c03ab","head":{"label":"alexcrichton:callback-types","ref":"callback-types","sha":"457efc0f31f336cffa96eca70994956af01c03ab","user":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"repo":{"id":139736728,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk3MzY3Mjg=","name":"wasm-bindgen","full_name":"alexcrichton/wasm-bindgen","owner":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexcrichton/wasm-bindgen","description":"Repository has moved","fork":true,"url":"https://api.github.com/repos/alexcrichton/wasm-bindgen","forks_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/forks","keys_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/teams","hooks_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/hooks","issue_events_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/issues/events{/number}","events_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/events","assignees_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/assignees{/user}","branches_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/branches{/branch}","tags_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/tags","blobs_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/statuses/{sha}","languages_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/languages","stargazers_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/stargazers","contributors_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/contributors","subscribers_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/subscribers","subscription_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/subscription","commits_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/contents/{+path}","compare_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/merges","archive_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/downloads","issues_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/issues{/number}","pulls_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/pulls{/number}","milestones_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/milestones{/number}","notifications_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/labels{/name}","releases_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/releases{/id}","deployments_url":"https://api.github.com/repos/alexcrichton/wasm-bindgen/deployments","created_at":"2018-07-04T15:04:06Z","updated_at":"2018-07-05T16:38:14Z","pushed_at":"2018-09-07T02:51:01Z","git_url":"git://github.com/alexcrichton/wasm-bindgen.git","ssh_url":"git@github.com:alexcrichton/wasm-bindgen.git","clone_url":"https://github.com/alexcrichton/wasm-bindgen.git","svn_url":"https://github.com/alexcrichton/wasm-bindgen","homepage":"https://github.com/rustwasm/wasm-bindgen","size":4070,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rustwasm:master","ref":"master","sha":"1cd2229c66d37ba0ac38f5b2419573199a2d796f","user":{"login":"rustwasm","id":37272798,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjcyNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/37272798?v=4","gravatar_id":"","url":"https://api.github.com/users/rustwasm","html_url":"https://github.com/rustwasm","followers_url":"https://api.github.com/users/rustwasm/followers","following_url":"https://api.github.com/users/rustwasm/following{/other_user}","gists_url":"https://api.github.com/users/rustwasm/gists{/gist_id}","starred_url":"https://api.github.com/users/rustwasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustwasm/subscriptions","organizations_url":"https://api.github.com/users/rustwasm/orgs","repos_url":"https://api.github.com/users/rustwasm/repos","events_url":"https://api.github.com/users/rustwasm/events{/privacy}","received_events_url":"https://api.github.com/users/rustwasm/received_events","type":"Organization","site_admin":false},"repo":{"id":114685405,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2ODU0MDU=","name":"wasm-bindgen","full_name":"rustwasm/wasm-bindgen","owner":{"login":"rustwasm","id":37272798,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjcyNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/37272798?v=4","gravatar_id":"","url":"https://api.github.com/users/rustwasm","html_url":"https://github.com/rustwasm","followers_url":"https://api.github.com/users/rustwasm/followers","following_url":"https://api.github.com/users/rustwasm/following{/other_user}","gists_url":"https://api.github.com/users/rustwasm/gists{/gist_id}","starred_url":"https://api.github.com/users/rustwasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustwasm/subscriptions","organizations_url":"https://api.github.com/users/rustwasm/orgs","repos_url":"https://api.github.com/users/rustwasm/repos","events_url":"https://api.github.com/users/rustwasm/events{/privacy}","received_events_url":"https://api.github.com/users/rustwasm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rustwasm/wasm-bindgen","description":"Facilitating high-level interactions between wasm modules and JavaScript","fork":false,"url":"https://api.github.com/repos/rustwasm/wasm-bindgen","forks_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/forks","keys_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/teams","hooks_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/hooks","issue_events_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/issues/events{/number}","events_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/events","assignees_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/assignees{/user}","branches_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/branches{/branch}","tags_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/tags","blobs_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/git/refs{/sha}","trees_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/statuses/{sha}","languages_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/languages","stargazers_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/stargazers","contributors_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/contributors","subscribers_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/subscribers","subscription_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/subscription","commits_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/commits{/sha}","git_commits_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/git/commits{/sha}","comments_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/comments{/number}","issue_comment_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/issues/comments{/number}","contents_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/contents/{+path}","compare_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/merges","archive_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/downloads","issues_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/issues{/number}","pulls_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls{/number}","milestones_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/milestones{/number}","notifications_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/labels{/name}","releases_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/releases{/id}","deployments_url":"https://api.github.com/repos/rustwasm/wasm-bindgen/deployments","created_at":"2017-12-18T20:38:44Z","updated_at":"2018-09-06T23:52:19Z","pushed_at":"2018-09-07T02:51:02Z","git_url":"git://github.com/rustwasm/wasm-bindgen.git","ssh_url":"git@github.com:rustwasm/wasm-bindgen.git","clone_url":"https://github.com/rustwasm/wasm-bindgen.git","svn_url":"https://github.com/rustwasm/wasm-bindgen","homepage":"https://rustwasm.github.io/wasm-bindgen/","size":8987,"stargazers_count":1284,"watchers_count":1284,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":138,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":138,"open_issues":66,"watchers":1284,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/796"},"html":{"href":"https://github.com/rustwasm/wasm-bindgen/pull/796"},"issue":{"href":"https://api.github.com/repos/rustwasm/wasm-bindgen/issues/796"},"comments":{"href":"https://api.github.com/repos/rustwasm/wasm-bindgen/issues/796/comments"},"review_comments":{"href":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/796/comments"},"review_comment":{"href":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rustwasm/wasm-bindgen/pulls/796/commits"},"statuses":{"href":"https://api.github.com/repos/rustwasm/wasm-bindgen/statuses/457efc0f31f336cffa96eca70994956af01c03ab"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"alexcrichton"}}