{"action":"closed","issue":{"url":"https://api.github.com/repos/ExchangeUnion/xud/issues/229","repository_url":"https://api.github.com/repos/ExchangeUnion/xud","labels_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/229/labels{/name}","comments_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/229/comments","events_url":"https://api.github.com/repos/ExchangeUnion/xud/issues/229/events","html_url":"https://github.com/ExchangeUnion/xud/issues/229","id":345926440,"node_id":"MDU6SXNzdWUzNDU5MjY0NDA=","number":229,"title":"[Crash] placeOrder with Invalid pairID","user":{"login":"kilrau","id":19181985,"node_id":"MDQ6VXNlcjE5MTgxOTg1","avatar_url":"https://avatars0.githubusercontent.com/u/19181985?v=4","gravatar_id":"","url":"https://api.github.com/users/kilrau","html_url":"https://github.com/kilrau","followers_url":"https://api.github.com/users/kilrau/followers","following_url":"https://api.github.com/users/kilrau/following{/other_user}","gists_url":"https://api.github.com/users/kilrau/gists{/gist_id}","starred_url":"https://api.github.com/users/kilrau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kilrau/subscriptions","organizations_url":"https://api.github.com/users/kilrau/orgs","repos_url":"https://api.github.com/users/kilrau/repos","events_url":"https://api.github.com/users/kilrau/events{/privacy}","received_events_url":"https://api.github.com/users/kilrau/received_events","type":"User","site_admin":false},"labels":[{"id":832646553,"node_id":"MDU6TGFiZWw4MzI2NDY1NTM=","url":"https://api.github.com/repos/ExchangeUnion/xud/labels/bug","name":"bug","color":"d73a4a","default":true},{"id":911812425,"node_id":"MDU6TGFiZWw5MTE4MTI0MjU=","url":"https://api.github.com/repos/ExchangeUnion/xud/labels/grpc","name":"grpc","color":"ff44c7","default":false},{"id":930952990,"node_id":"MDU6TGFiZWw5MzA5NTI5OTA=","url":"https://api.github.com/repos/ExchangeUnion/xud/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":969072887,"node_id":"MDU6TGFiZWw5NjkwNzI4ODc=","url":"https://api.github.com/repos/ExchangeUnion/xud/labels/top%20priority","name":"top priority","color":"e25c1d","default":false}],"state":"closed","locked":false,"assignee":{"login":"sangaman","id":3440835,"node_id":"MDQ6VXNlcjM0NDA4MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3440835?v=4","gravatar_id":"","url":"https://api.github.com/users/sangaman","html_url":"https://github.com/sangaman","followers_url":"https://api.github.com/users/sangaman/followers","following_url":"https://api.github.com/users/sangaman/following{/other_user}","gists_url":"https://api.github.com/users/sangaman/gists{/gist_id}","starred_url":"https://api.github.com/users/sangaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sangaman/subscriptions","organizations_url":"https://api.github.com/users/sangaman/orgs","repos_url":"https://api.github.com/users/sangaman/repos","events_url":"https://api.github.com/users/sangaman/events{/privacy}","received_events_url":"https://api.github.com/users/sangaman/received_events","type":"User","site_admin":false},"assignees":[{"login":"sangaman","id":3440835,"node_id":"MDQ6VXNlcjM0NDA4MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3440835?v=4","gravatar_id":"","url":"https://api.github.com/users/sangaman","html_url":"https://github.com/sangaman","followers_url":"https://api.github.com/users/sangaman/followers","following_url":"https://api.github.com/users/sangaman/following{/other_user}","gists_url":"https://api.github.com/users/sangaman/gists{/gist_id}","starred_url":"https://api.github.com/users/sangaman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sangaman/subscriptions","organizations_url":"https://api.github.com/users/sangaman/orgs","repos_url":"https://api.github.com/users/sangaman/repos","events_url":"https://api.github.com/users/sangaman/events{/privacy}","received_events_url":"https://api.github.com/users/sangaman/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ExchangeUnion/xud/milestones/1","html_url":"https://github.com/ExchangeUnion/xud/milestone/1","labels_url":"https://api.github.com/repos/ExchangeUnion/xud/milestones/1/labels","id":3401414,"node_id":"MDk6TWlsZXN0b25lMzQwMTQxNA==","number":1,"title":"1.0.0-prealpha","description":"Pre-alpha release milestone:\r\n1. Full p2p functionality: discovery (seed address, peer shares known hosts, handshake messages, message formats)\r\n2. Order book, order info exchange+formats, matching (partial matching, market order (needs issue!), limit order)\r\n3. gRPC for exchange with full order functionality (list missing methods to expose (e.g. cancelling orders!), define tasks+create issues(!), web reverse proxy prio low for now)\r\n4. Raiden ERC20 swap (match <-> swap part, which version, what are exact wallet methods)\r\n5. Update typedoc and instructions from exchange perspective\r\n6. Prepare exchange staging environment (test orders, test money)","creator":{"login":"kilrau","id":19181985,"node_id":"MDQ6VXNlcjE5MTgxOTg1","avatar_url":"https://avatars0.githubusercontent.com/u/19181985?v=4","gravatar_id":"","url":"https://api.github.com/users/kilrau","html_url":"https://github.com/kilrau","followers_url":"https://api.github.com/users/kilrau/followers","following_url":"https://api.github.com/users/kilrau/following{/other_user}","gists_url":"https://api.github.com/users/kilrau/gists{/gist_id}","starred_url":"https://api.github.com/users/kilrau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kilrau/subscriptions","organizations_url":"https://api.github.com/users/kilrau/orgs","repos_url":"https://api.github.com/users/kilrau/repos","events_url":"https://api.github.com/users/kilrau/events{/privacy}","received_events_url":"https://api.github.com/users/kilrau/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":23,"state":"open","created_at":"2018-06-05T08:55:08Z","updated_at":"2018-08-02T01:03:29Z","due_on":"2018-07-15T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-07-30T20:41:40Z","updated_at":"2018-08-02T01:03:29Z","closed_at":"2018-08-02T01:03:29Z","author_association":"CONTRIBUTOR","body":"Current Behavior: placeOrder with Invalid pairID causes XUD to crash, due to unhandled gRPC error\r\nHow it should be: gracefully handle all gRPC errors\r\n\r\n```\r\n2018-7-30 13:37:14 [RPC] error: invalid pairId: BTC/LTC\r\nTypeError: Incorrectly typed arguments to startBatch\r\n    at handleError (/home/kilrau/xud/node_modules/grpc/src/server.js:71:8)\r\n    at sendUnaryData (/home/kilrau/xud/node_modules/grpc/src/server.js:597:9)\r\n    at GrpcService.<anonymous> (/home/kilrau/xud/dist/grpc/GrpcService.js:40:17)\r\n    at Generator.throw (<anonymous>)\r\n    at rejected (/home/kilrau/xud/dist/grpc/GrpcService.js:5:65)\r\n    at <anonymous>\r\n    at runMicrotasksCallback (internal/process/next_tick.js:121:5)\r\n    at _combinedTickCallback (internal/process/next_tick.js:131:7)\r\n    at process._tickCallback (internal/process/next_tick.js:180:9)\r\n/home/kilrau/xud/dist/bootstrap.js:13\r\n        throw err;\r\n        ^\r\n\r\nTypeError: Incorrectly typed arguments to startBatch\r\n    at handleError (/home/kilrau/xud/node_modules/grpc/src/server.js:71:8)\r\n    at sendUnaryData (/home/kilrau/xud/node_modules/grpc/src/server.js:597:9)\r\n    at GrpcService.<anonymous> (/home/kilrau/xud/dist/grpc/GrpcService.js:40:17)\r\n    at Generator.throw (<anonymous>)\r\n    at rejected (/home/kilrau/xud/dist/grpc/GrpcService.js:5:65)\r\n    at <anonymous>\r\n    at runMicrotasksCallback (internal/process/next_tick.js:121:5)\r\n    at _combinedTickCallback (internal/process/next_tick.js:131:7)\r\n    at process._tickCallback (internal/process/next_tick.js:180:9)\r\nnpm ERR! code ELIFECYCLE\r\nnpm ERR! errno 1\r\nnpm ERR! xud@1.0.0-alpha.1 start: `node dist/Xud.js`\r\nnpm ERR! Exit status 1\r\nnpm ERR! \r\nnpm ERR! Failed at the xud@1.0.0-alpha.1 start script.\r\nnpm ERR! This is probably not a problem with npm. There is likely additional logging output above.\r\n\r\nnpm ERR! A complete log of this run can be found in:\r\nnpm ERR!     /home/kilrau/.npm/_logs/2018-07-30T20_37_14_899Z-debug.log\r\n```\r\n\r\n[2018-07-30T20_37_14_899Z-debug.log](https://github.com/ExchangeUnion/xud/files/2242807/2018-07-30T20_37_14_899Z-debug.log)"}}
{"actor":{"display_login":"sangaman"}}