{"action":"created","comment":{"url":"https://api.github.com/repos/gomods/athens/pulls/comments/198459451","pull_request_review_id":132391724,"id":198459451,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODQ1OTQ1MQ==","diff_hunk":"@@ -67,10 +68,19 @@ func (s *Storage) Save(ctx context.Context, module, version string, mod, zip, in\n \t\t_, err := url.Upload(ctx, content, httpHeaders(contentType), emptyMeta, emptyBlobAccessCond)\n \t\tuploadErrs <- err\n \t}\n+\tzipRs, ok := zip.(io.ReadSeeker)","path":"pkg/storage/azurecdn/storage.go","position":21,"original_position":21,"commit_id":"8d1f3be3a28b564dbf7ea091a3d16b3ebcc22e5c","original_commit_id":"38854a6e7ef16f9ef344000e9cc5d9fb2b21107e","user":{"login":"marpio","id":1334824,"node_id":"MDQ6VXNlcjEzMzQ4MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1334824?v=4","gravatar_id":"","url":"https://api.github.com/users/marpio","html_url":"https://github.com/marpio","followers_url":"https://api.github.com/users/marpio/followers","following_url":"https://api.github.com/users/marpio/following{/other_user}","gists_url":"https://api.github.com/users/marpio/gists{/gist_id}","starred_url":"https://api.github.com/users/marpio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marpio/subscriptions","organizations_url":"https://api.github.com/users/marpio/orgs","repos_url":"https://api.github.com/users/marpio/repos","events_url":"https://api.github.com/users/marpio/events{/privacy}","received_events_url":"https://api.github.com/users/marpio/received_events","type":"User","site_admin":false},"body":"The only thing that comes to my mind is to save the zip to a temp file and upload it from there to the cdn or using something like this https://godoc.org/github.com/aws/aws-sdk-go/service/s3/s3manager","created_at":"2018-06-27T11:30:11Z","updated_at":"2018-06-27T11:30:11Z","html_url":"https://github.com/gomods/athens/pull/200#discussion_r198459451","pull_request_url":"https://api.github.com/repos/gomods/athens/pulls/200","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gomods/athens/pulls/comments/198459451"},"html":{"href":"https://github.com/gomods/athens/pull/200#discussion_r198459451"},"pull_request":{"href":"https://api.github.com/repos/gomods/athens/pulls/200"}},"in_reply_to_id":198304854},"pull_request":{"url":"https://api.github.com/repos/gomods/athens/pulls/200","id":197557417,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NTU3NDE3","html_url":"https://github.com/gomods/athens/pull/200","diff_url":"https://github.com/gomods/athens/pull/200.diff","patch_url":"https://github.com/gomods/athens/pull/200.patch","issue_url":"https://api.github.com/repos/gomods/athens/issues/200","number":200,"state":"open","locked":false,"title":"[WIP] Stream zips","user":{"login":"marpio","id":1334824,"node_id":"MDQ6VXNlcjEzMzQ4MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1334824?v=4","gravatar_id":"","url":"https://api.github.com/users/marpio","html_url":"https://github.com/marpio","followers_url":"https://api.github.com/users/marpio/followers","following_url":"https://api.github.com/users/marpio/following{/other_user}","gists_url":"https://api.github.com/users/marpio/gists{/gist_id}","starred_url":"https://api.github.com/users/marpio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marpio/subscriptions","organizations_url":"https://api.github.com/users/marpio/orgs","repos_url":"https://api.github.com/users/marpio/repos","events_url":"https://api.github.com/users/marpio/events{/privacy}","received_events_url":"https://api.github.com/users/marpio/received_events","type":"User","site_admin":false},"body":"Fixes #176 \r\nChanging to WIP since there are some open questions.","created_at":"2018-06-26T21:32:01Z","updated_at":"2018-06-27T11:30:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c7e05fcf7f48fc030c4e1bfcf7dcefcb56aa76e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gomods/athens/pulls/200/commits","review_comments_url":"https://api.github.com/repos/gomods/athens/pulls/200/comments","review_comment_url":"https://api.github.com/repos/gomods/athens/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gomods/athens/issues/200/comments","statuses_url":"https://api.github.com/repos/gomods/athens/statuses/8d1f3be3a28b564dbf7ea091a3d16b3ebcc22e5c","head":{"label":"marpio:stream_zip","ref":"stream_zip","sha":"8d1f3be3a28b564dbf7ea091a3d16b3ebcc22e5c","user":{"login":"marpio","id":1334824,"node_id":"MDQ6VXNlcjEzMzQ4MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1334824?v=4","gravatar_id":"","url":"https://api.github.com/users/marpio","html_url":"https://github.com/marpio","followers_url":"https://api.github.com/users/marpio/followers","following_url":"https://api.github.com/users/marpio/following{/other_user}","gists_url":"https://api.github.com/users/marpio/gists{/gist_id}","starred_url":"https://api.github.com/users/marpio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marpio/subscriptions","organizations_url":"https://api.github.com/users/marpio/orgs","repos_url":"https://api.github.com/users/marpio/repos","events_url":"https://api.github.com/users/marpio/events{/privacy}","received_events_url":"https://api.github.com/users/marpio/received_events","type":"User","site_admin":false},"repo":{"id":126237724,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyMzc3MjQ=","name":"athens","full_name":"marpio/athens","owner":{"login":"marpio","id":1334824,"node_id":"MDQ6VXNlcjEzMzQ4MjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1334824?v=4","gravatar_id":"","url":"https://api.github.com/users/marpio","html_url":"https://github.com/marpio","followers_url":"https://api.github.com/users/marpio/followers","following_url":"https://api.github.com/users/marpio/following{/other_user}","gists_url":"https://api.github.com/users/marpio/gists{/gist_id}","starred_url":"https://api.github.com/users/marpio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marpio/subscriptions","organizations_url":"https://api.github.com/users/marpio/orgs","repos_url":"https://api.github.com/users/marpio/repos","events_url":"https://api.github.com/users/marpio/events{/privacy}","received_events_url":"https://api.github.com/users/marpio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marpio/athens","description":"A proxy server and registry for vgo","fork":true,"url":"https://api.github.com/repos/marpio/athens","forks_url":"https://api.github.com/repos/marpio/athens/forks","keys_url":"https://api.github.com/repos/marpio/athens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marpio/athens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marpio/athens/teams","hooks_url":"https://api.github.com/repos/marpio/athens/hooks","issue_events_url":"https://api.github.com/repos/marpio/athens/issues/events{/number}","events_url":"https://api.github.com/repos/marpio/athens/events","assignees_url":"https://api.github.com/repos/marpio/athens/assignees{/user}","branches_url":"https://api.github.com/repos/marpio/athens/branches{/branch}","tags_url":"https://api.github.com/repos/marpio/athens/tags","blobs_url":"https://api.github.com/repos/marpio/athens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marpio/athens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marpio/athens/git/refs{/sha}","trees_url":"https://api.github.com/repos/marpio/athens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marpio/athens/statuses/{sha}","languages_url":"https://api.github.com/repos/marpio/athens/languages","stargazers_url":"https://api.github.com/repos/marpio/athens/stargazers","contributors_url":"https://api.github.com/repos/marpio/athens/contributors","subscribers_url":"https://api.github.com/repos/marpio/athens/subscribers","subscription_url":"https://api.github.com/repos/marpio/athens/subscription","commits_url":"https://api.github.com/repos/marpio/athens/commits{/sha}","git_commits_url":"https://api.github.com/repos/marpio/athens/git/commits{/sha}","comments_url":"https://api.github.com/repos/marpio/athens/comments{/number}","issue_comment_url":"https://api.github.com/repos/marpio/athens/issues/comments{/number}","contents_url":"https://api.github.com/repos/marpio/athens/contents/{+path}","compare_url":"https://api.github.com/repos/marpio/athens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marpio/athens/merges","archive_url":"https://api.github.com/repos/marpio/athens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marpio/athens/downloads","issues_url":"https://api.github.com/repos/marpio/athens/issues{/number}","pulls_url":"https://api.github.com/repos/marpio/athens/pulls{/number}","milestones_url":"https://api.github.com/repos/marpio/athens/milestones{/number}","notifications_url":"https://api.github.com/repos/marpio/athens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marpio/athens/labels{/name}","releases_url":"https://api.github.com/repos/marpio/athens/releases{/id}","deployments_url":"https://api.github.com/repos/marpio/athens/deployments","created_at":"2018-03-21T20:39:00Z","updated_at":"2018-05-15T20:23:28Z","pushed_at":"2018-06-26T21:36:51Z","git_url":"git://github.com/marpio/athens.git","ssh_url":"git@github.com:marpio/athens.git","clone_url":"https://github.com/marpio/athens.git","svn_url":"https://github.com/marpio/athens","homepage":"https://research.swtch.com/vgo-module","size":51088,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gomods:master","ref":"master","sha":"5101e1ea6dcfddb33b663925b4fd3c068a1a8abb","user":{"login":"gomods","id":36861827,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2ODYxODI3","avatar_url":"https://avatars3.githubusercontent.com/u/36861827?v=4","gravatar_id":"","url":"https://api.github.com/users/gomods","html_url":"https://github.com/gomods","followers_url":"https://api.github.com/users/gomods/followers","following_url":"https://api.github.com/users/gomods/following{/other_user}","gists_url":"https://api.github.com/users/gomods/gists{/gist_id}","starred_url":"https://api.github.com/users/gomods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gomods/subscriptions","organizations_url":"https://api.github.com/users/gomods/orgs","repos_url":"https://api.github.com/users/gomods/repos","events_url":"https://api.github.com/users/gomods/events{/privacy}","received_events_url":"https://api.github.com/users/gomods/received_events","type":"Organization","site_admin":false},"repo":{"id":122872932,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI4NzI5MzI=","name":"athens","full_name":"gomods/athens","owner":{"login":"gomods","id":36861827,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2ODYxODI3","avatar_url":"https://avatars3.githubusercontent.com/u/36861827?v=4","gravatar_id":"","url":"https://api.github.com/users/gomods","html_url":"https://github.com/gomods","followers_url":"https://api.github.com/users/gomods/followers","following_url":"https://api.github.com/users/gomods/following{/other_user}","gists_url":"https://api.github.com/users/gomods/gists{/gist_id}","starred_url":"https://api.github.com/users/gomods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gomods/subscriptions","organizations_url":"https://api.github.com/users/gomods/orgs","repos_url":"https://api.github.com/users/gomods/repos","events_url":"https://api.github.com/users/gomods/events{/privacy}","received_events_url":"https://api.github.com/users/gomods/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gomods/athens","description":"A package registry and proxy server for Go","fork":false,"url":"https://api.github.com/repos/gomods/athens","forks_url":"https://api.github.com/repos/gomods/athens/forks","keys_url":"https://api.github.com/repos/gomods/athens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gomods/athens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gomods/athens/teams","hooks_url":"https://api.github.com/repos/gomods/athens/hooks","issue_events_url":"https://api.github.com/repos/gomods/athens/issues/events{/number}","events_url":"https://api.github.com/repos/gomods/athens/events","assignees_url":"https://api.github.com/repos/gomods/athens/assignees{/user}","branches_url":"https://api.github.com/repos/gomods/athens/branches{/branch}","tags_url":"https://api.github.com/repos/gomods/athens/tags","blobs_url":"https://api.github.com/repos/gomods/athens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gomods/athens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gomods/athens/git/refs{/sha}","trees_url":"https://api.github.com/repos/gomods/athens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gomods/athens/statuses/{sha}","languages_url":"https://api.github.com/repos/gomods/athens/languages","stargazers_url":"https://api.github.com/repos/gomods/athens/stargazers","contributors_url":"https://api.github.com/repos/gomods/athens/contributors","subscribers_url":"https://api.github.com/repos/gomods/athens/subscribers","subscription_url":"https://api.github.com/repos/gomods/athens/subscription","commits_url":"https://api.github.com/repos/gomods/athens/commits{/sha}","git_commits_url":"https://api.github.com/repos/gomods/athens/git/commits{/sha}","comments_url":"https://api.github.com/repos/gomods/athens/comments{/number}","issue_comment_url":"https://api.github.com/repos/gomods/athens/issues/comments{/number}","contents_url":"https://api.github.com/repos/gomods/athens/contents/{+path}","compare_url":"https://api.github.com/repos/gomods/athens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gomods/athens/merges","archive_url":"https://api.github.com/repos/gomods/athens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gomods/athens/downloads","issues_url":"https://api.github.com/repos/gomods/athens/issues{/number}","pulls_url":"https://api.github.com/repos/gomods/athens/pulls{/number}","milestones_url":"https://api.github.com/repos/gomods/athens/milestones{/number}","notifications_url":"https://api.github.com/repos/gomods/athens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gomods/athens/labels{/name}","releases_url":"https://api.github.com/repos/gomods/athens/releases{/id}","deployments_url":"https://api.github.com/repos/gomods/athens/deployments","created_at":"2018-02-25T20:19:41Z","updated_at":"2018-06-26T18:37:24Z","pushed_at":"2018-06-27T07:08:53Z","git_url":"git://github.com/gomods/athens.git","ssh_url":"git@github.com:gomods/athens.git","clone_url":"https://github.com/gomods/athens.git","svn_url":"https://github.com/gomods/athens","homepage":"","size":43491,"stargazers_count":294,"watchers_count":294,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19,"open_issues":62,"watchers":294,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gomods/athens/pulls/200"},"html":{"href":"https://github.com/gomods/athens/pull/200"},"issue":{"href":"https://api.github.com/repos/gomods/athens/issues/200"},"comments":{"href":"https://api.github.com/repos/gomods/athens/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/gomods/athens/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/gomods/athens/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gomods/athens/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/gomods/athens/statuses/8d1f3be3a28b564dbf7ea091a3d16b3ebcc22e5c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"marpio"}}