{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/test-infra/issues/9462","repository_url":"https://api.github.com/repos/kubernetes/test-infra","labels_url":"https://api.github.com/repos/kubernetes/test-infra/issues/9462/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/9462/comments","events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/9462/events","html_url":"https://github.com/kubernetes/test-infra/issues/9462","id":361440021,"node_id":"MDU6SXNzdWUzNjE0NDAwMjE=","number":9462,"title":"clonerefs needs to require a non-empty clone_uri","user":{"login":"fejta","id":940341,"node_id":"MDQ6VXNlcjk0MDM0MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/940341?v=4","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"labels":[{"id":412127043,"node_id":"MDU6TGFiZWw0MTIxMjcwNDM=","url":"https://api.github.com/repos/kubernetes/test-infra/labels/area/prow","name":"area/prow","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-18T19:03:43Z","updated_at":"2018-09-30T22:50:12Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Magically filling in this value with `https://github.com/{{.Org}}/{{.Repo}}.git` leaks potentially private and/or high value information to github on any misconfiguration. Therefore is an unsafe default.\r\n\r\nPlank, Gerrit or whatever controller creates the prow job has a duty to furnish valid clone_uris. We should update plank to auto-populate this field (which will make this a noop for users/admins).\r\n\r\nAt this point we update clonerefs to blow up whenever any refs have an empty clone_uri field.\r\n\r\n/cc @stevekuznetsov @cjwagner @munnerz \r\n\r\n/area prow"},"comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments/425758416","html_url":"https://github.com/kubernetes/test-infra/issues/9462#issuecomment-425758416","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/9462","id":425758416,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTc1ODQxNg==","user":{"login":"stevekuznetsov","id":7328370,"node_id":"MDQ6VXNlcjczMjgzNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/7328370?v=4","gravatar_id":"","url":"https://api.github.com/users/stevekuznetsov","html_url":"https://github.com/stevekuznetsov","followers_url":"https://api.github.com/users/stevekuznetsov/followers","following_url":"https://api.github.com/users/stevekuznetsov/following{/other_user}","gists_url":"https://api.github.com/users/stevekuznetsov/gists{/gist_id}","starred_url":"https://api.github.com/users/stevekuznetsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevekuznetsov/subscriptions","organizations_url":"https://api.github.com/users/stevekuznetsov/orgs","repos_url":"https://api.github.com/users/stevekuznetsov/repos","events_url":"https://api.github.com/users/stevekuznetsov/events{/privacy}","received_events_url":"https://api.github.com/users/stevekuznetsov/received_events","type":"User","site_admin":false},"created_at":"2018-09-30T22:50:12Z","updated_at":"2018-09-30T22:50:12Z","author_association":"CONTRIBUTOR","body":"Also unclear to me what the ask here is -- validation for the configuration that the field is non-nil? If you've added a `kube.Refs` with the org and repo, how is it unsafe to take those public values and use them in a template string?"}}
{"actor":{"display_login":"stevekuznetsov"}}