{"action":"opened","number":163,"pull_request":{"url":"https://api.github.com/repos/ionic-team/capacitor/pulls/163","id":170559168,"html_url":"https://github.com/ionic-team/capacitor/pull/163","diff_url":"https://github.com/ionic-team/capacitor/pull/163.diff","patch_url":"https://github.com/ionic-team/capacitor/pull/163.patch","issue_url":"https://api.github.com/repos/ionic-team/capacitor/issues/163","number":163,"state":"open","locked":false,"title":"Improve cordova.js file","user":{"login":"jcesarmobile","id":1637892,"avatar_url":"https://avatars3.githubusercontent.com/u/1637892?v=4","gravatar_id":"","url":"https://api.github.com/users/jcesarmobile","html_url":"https://github.com/jcesarmobile","followers_url":"https://api.github.com/users/jcesarmobile/followers","following_url":"https://api.github.com/users/jcesarmobile/following{/other_user}","gists_url":"https://api.github.com/users/jcesarmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/jcesarmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcesarmobile/subscriptions","organizations_url":"https://api.github.com/users/jcesarmobile/orgs","repos_url":"https://api.github.com/users/jcesarmobile/repos","events_url":"https://api.github.com/users/jcesarmobile/events{/privacy}","received_events_url":"https://api.github.com/users/jcesarmobile/received_events","type":"User","site_admin":false},"body":"The cordova.js is based on the cordova-ios cordova.js.\r\nRemove traces of ios by renaming iOSExec to capacitorExec\r\nUse Capacitor.platform as platform.id instead of hardcode it to ios so cordova.platformId returns the right value.\r\n\r\nSet version to 1.0.0, not sure if we can automate this with lerna to match the actual capacitor version","created_at":"2018-02-21T19:01:45Z","updated_at":"2018-02-21T19:01:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ionic-team/capacitor/pulls/163/commits","review_comments_url":"https://api.github.com/repos/ionic-team/capacitor/pulls/163/comments","review_comment_url":"https://api.github.com/repos/ionic-team/capacitor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ionic-team/capacitor/issues/163/comments","statuses_url":"https://api.github.com/repos/ionic-team/capacitor/statuses/4f440807207c28fa7675acec01d231c430fd9078","head":{"label":"jcesarmobile:cordova-improvements","ref":"cordova-improvements","sha":"4f440807207c28fa7675acec01d231c430fd9078","user":{"login":"jcesarmobile","id":1637892,"avatar_url":"https://avatars3.githubusercontent.com/u/1637892?v=4","gravatar_id":"","url":"https://api.github.com/users/jcesarmobile","html_url":"https://github.com/jcesarmobile","followers_url":"https://api.github.com/users/jcesarmobile/followers","following_url":"https://api.github.com/users/jcesarmobile/following{/other_user}","gists_url":"https://api.github.com/users/jcesarmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/jcesarmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcesarmobile/subscriptions","organizations_url":"https://api.github.com/users/jcesarmobile/orgs","repos_url":"https://api.github.com/users/jcesarmobile/repos","events_url":"https://api.github.com/users/jcesarmobile/events{/privacy}","received_events_url":"https://api.github.com/users/jcesarmobile/received_events","type":"User","site_admin":false},"repo":{"id":117088991,"name":"capacitor","full_name":"jcesarmobile/capacitor","owner":{"login":"jcesarmobile","id":1637892,"avatar_url":"https://avatars3.githubusercontent.com/u/1637892?v=4","gravatar_id":"","url":"https://api.github.com/users/jcesarmobile","html_url":"https://github.com/jcesarmobile","followers_url":"https://api.github.com/users/jcesarmobile/followers","following_url":"https://api.github.com/users/jcesarmobile/following{/other_user}","gists_url":"https://api.github.com/users/jcesarmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/jcesarmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcesarmobile/subscriptions","organizations_url":"https://api.github.com/users/jcesarmobile/orgs","repos_url":"https://api.github.com/users/jcesarmobile/repos","events_url":"https://api.github.com/users/jcesarmobile/events{/privacy}","received_events_url":"https://api.github.com/users/jcesarmobile/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcesarmobile/capacitor","description":"⚡️ Build cross-platform Native Progressive Web Apps for iOS, Android, and the web","fork":true,"url":"https://api.github.com/repos/jcesarmobile/capacitor","forks_url":"https://api.github.com/repos/jcesarmobile/capacitor/forks","keys_url":"https://api.github.com/repos/jcesarmobile/capacitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcesarmobile/capacitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcesarmobile/capacitor/teams","hooks_url":"https://api.github.com/repos/jcesarmobile/capacitor/hooks","issue_events_url":"https://api.github.com/repos/jcesarmobile/capacitor/issues/events{/number}","events_url":"https://api.github.com/repos/jcesarmobile/capacitor/events","assignees_url":"https://api.github.com/repos/jcesarmobile/capacitor/assignees{/user}","branches_url":"https://api.github.com/repos/jcesarmobile/capacitor/branches{/branch}","tags_url":"https://api.github.com/repos/jcesarmobile/capacitor/tags","blobs_url":"https://api.github.com/repos/jcesarmobile/capacitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcesarmobile/capacitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcesarmobile/capacitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcesarmobile/capacitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcesarmobile/capacitor/statuses/{sha}","languages_url":"https://api.github.com/repos/jcesarmobile/capacitor/languages","stargazers_url":"https://api.github.com/repos/jcesarmobile/capacitor/stargazers","contributors_url":"https://api.github.com/repos/jcesarmobile/capacitor/contributors","subscribers_url":"https://api.github.com/repos/jcesarmobile/capacitor/subscribers","subscription_url":"https://api.github.com/repos/jcesarmobile/capacitor/subscription","commits_url":"https://api.github.com/repos/jcesarmobile/capacitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcesarmobile/capacitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcesarmobile/capacitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcesarmobile/capacitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcesarmobile/capacitor/contents/{+path}","compare_url":"https://api.github.com/repos/jcesarmobile/capacitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcesarmobile/capacitor/merges","archive_url":"https://api.github.com/repos/jcesarmobile/capacitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcesarmobile/capacitor/downloads","issues_url":"https://api.github.com/repos/jcesarmobile/capacitor/issues{/number}","pulls_url":"https://api.github.com/repos/jcesarmobile/capacitor/pulls{/number}","milestones_url":"https://api.github.com/repos/jcesarmobile/capacitor/milestones{/number}","notifications_url":"https://api.github.com/repos/jcesarmobile/capacitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcesarmobile/capacitor/labels{/name}","releases_url":"https://api.github.com/repos/jcesarmobile/capacitor/releases{/id}","deployments_url":"https://api.github.com/repos/jcesarmobile/capacitor/deployments","created_at":"2018-01-11T11:03:53Z","updated_at":"2018-02-08T19:58:59Z","pushed_at":"2018-02-21T18:57:52Z","git_url":"git://github.com/jcesarmobile/capacitor.git","ssh_url":"git@github.com:jcesarmobile/capacitor.git","clone_url":"https://github.com/jcesarmobile/capacitor.git","svn_url":"https://github.com/jcesarmobile/capacitor","homepage":"http://ionic-team.github.io/capacitor","size":28370,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ionic-team:master","ref":"master","sha":"c1f26b5de4892acf696a6915315117182d25cbb6","user":{"login":"ionic-team","id":3171503,"avatar_url":"https://avatars0.githubusercontent.com/u/3171503?v=4","gravatar_id":"","url":"https://api.github.com/users/ionic-team","html_url":"https://github.com/ionic-team","followers_url":"https://api.github.com/users/ionic-team/followers","following_url":"https://api.github.com/users/ionic-team/following{/other_user}","gists_url":"https://api.github.com/users/ionic-team/gists{/gist_id}","starred_url":"https://api.github.com/users/ionic-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionic-team/subscriptions","organizations_url":"https://api.github.com/users/ionic-team/orgs","repos_url":"https://api.github.com/users/ionic-team/repos","events_url":"https://api.github.com/users/ionic-team/events{/privacy}","received_events_url":"https://api.github.com/users/ionic-team/received_events","type":"Organization","site_admin":false},"repo":{"id":111241370,"name":"capacitor","full_name":"ionic-team/capacitor","owner":{"login":"ionic-team","id":3171503,"avatar_url":"https://avatars0.githubusercontent.com/u/3171503?v=4","gravatar_id":"","url":"https://api.github.com/users/ionic-team","html_url":"https://github.com/ionic-team","followers_url":"https://api.github.com/users/ionic-team/followers","following_url":"https://api.github.com/users/ionic-team/following{/other_user}","gists_url":"https://api.github.com/users/ionic-team/gists{/gist_id}","starred_url":"https://api.github.com/users/ionic-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ionic-team/subscriptions","organizations_url":"https://api.github.com/users/ionic-team/orgs","repos_url":"https://api.github.com/users/ionic-team/repos","events_url":"https://api.github.com/users/ionic-team/events{/privacy}","received_events_url":"https://api.github.com/users/ionic-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ionic-team/capacitor","description":"Build cross-platform Native Progressive Web Apps for iOS, Android, and the web ⚡️","fork":false,"url":"https://api.github.com/repos/ionic-team/capacitor","forks_url":"https://api.github.com/repos/ionic-team/capacitor/forks","keys_url":"https://api.github.com/repos/ionic-team/capacitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ionic-team/capacitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ionic-team/capacitor/teams","hooks_url":"https://api.github.com/repos/ionic-team/capacitor/hooks","issue_events_url":"https://api.github.com/repos/ionic-team/capacitor/issues/events{/number}","events_url":"https://api.github.com/repos/ionic-team/capacitor/events","assignees_url":"https://api.github.com/repos/ionic-team/capacitor/assignees{/user}","branches_url":"https://api.github.com/repos/ionic-team/capacitor/branches{/branch}","tags_url":"https://api.github.com/repos/ionic-team/capacitor/tags","blobs_url":"https://api.github.com/repos/ionic-team/capacitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ionic-team/capacitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ionic-team/capacitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/ionic-team/capacitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ionic-team/capacitor/statuses/{sha}","languages_url":"https://api.github.com/repos/ionic-team/capacitor/languages","stargazers_url":"https://api.github.com/repos/ionic-team/capacitor/stargazers","contributors_url":"https://api.github.com/repos/ionic-team/capacitor/contributors","subscribers_url":"https://api.github.com/repos/ionic-team/capacitor/subscribers","subscription_url":"https://api.github.com/repos/ionic-team/capacitor/subscription","commits_url":"https://api.github.com/repos/ionic-team/capacitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/ionic-team/capacitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/ionic-team/capacitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/ionic-team/capacitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/ionic-team/capacitor/contents/{+path}","compare_url":"https://api.github.com/repos/ionic-team/capacitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ionic-team/capacitor/merges","archive_url":"https://api.github.com/repos/ionic-team/capacitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ionic-team/capacitor/downloads","issues_url":"https://api.github.com/repos/ionic-team/capacitor/issues{/number}","pulls_url":"https://api.github.com/repos/ionic-team/capacitor/pulls{/number}","milestones_url":"https://api.github.com/repos/ionic-team/capacitor/milestones{/number}","notifications_url":"https://api.github.com/repos/ionic-team/capacitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ionic-team/capacitor/labels{/name}","releases_url":"https://api.github.com/repos/ionic-team/capacitor/releases{/id}","deployments_url":"https://api.github.com/repos/ionic-team/capacitor/deployments","created_at":"2017-11-18T21:38:09Z","updated_at":"2018-02-21T17:42:59Z","pushed_at":"2018-02-21T18:33:24Z","git_url":"git://github.com/ionic-team/capacitor.git","ssh_url":"git@github.com:ionic-team/capacitor.git","clone_url":"https://github.com/ionic-team/capacitor.git","svn_url":"https://github.com/ionic-team/capacitor","homepage":"https://capacitor.ionicframework.com/","size":28442,"stargazers_count":443,"watchers_count":443,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":21,"open_issues":32,"watchers":443,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ionic-team/capacitor/pulls/163"},"html":{"href":"https://github.com/ionic-team/capacitor/pull/163"},"issue":{"href":"https://api.github.com/repos/ionic-team/capacitor/issues/163"},"comments":{"href":"https://api.github.com/repos/ionic-team/capacitor/issues/163/comments"},"review_comments":{"href":"https://api.github.com/repos/ionic-team/capacitor/pulls/163/comments"},"review_comment":{"href":"https://api.github.com/repos/ionic-team/capacitor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ionic-team/capacitor/pulls/163/commits"},"statuses":{"href":"https://api.github.com/repos/ionic-team/capacitor/statuses/4f440807207c28fa7675acec01d231c430fd9078"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":8,"deletions":14,"changed_files":1}}
{"actor":{"display_login":"jcesarmobile"}}