{"action":"created","issue":{"url":"https://api.github.com/repos/MohamedISoliman/Androiddev/issues/3","repository_url":"https://api.github.com/repos/MohamedISoliman/Androiddev","labels_url":"https://api.github.com/repos/MohamedISoliman/Androiddev/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/MohamedISoliman/Androiddev/issues/3/comments","events_url":"https://api.github.com/repos/MohamedISoliman/Androiddev/issues/3/events","html_url":"https://github.com/MohamedISoliman/Androiddev/issues/3","id":349066519,"node_id":"MDU6SXNzdWUzNDkwNjY1MTk=","number":3,"title":"There is some mix between Rx and non-functional programming in some spots","user":{"login":"fadi-botros","id":22801132,"node_id":"MDQ6VXNlcjIyODAxMTMy","avatar_url":"https://avatars2.githubusercontent.com/u/22801132?v=4","gravatar_id":"","url":"https://api.github.com/users/fadi-botros","html_url":"https://github.com/fadi-botros","followers_url":"https://api.github.com/users/fadi-botros/followers","following_url":"https://api.github.com/users/fadi-botros/following{/other_user}","gists_url":"https://api.github.com/users/fadi-botros/gists{/gist_id}","starred_url":"https://api.github.com/users/fadi-botros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fadi-botros/subscriptions","organizations_url":"https://api.github.com/users/fadi-botros/orgs","repos_url":"https://api.github.com/users/fadi-botros/repos","events_url":"https://api.github.com/users/fadi-botros/events{/privacy}","received_events_url":"https://api.github.com/users/fadi-botros/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-09T10:19:51Z","updated_at":"2018-08-09T19:44:52Z","closed_at":null,"author_association":"NONE","body":"Like\r\n\r\nhttps://github.com/MohamedISoliman/Androiddev/blob/2b26346bad0f3bccb1a2101ec2866bebc8d9a2c0/app/src/main/java/io/github/mohamedisoliman/androiddev/data/GettingTopPostsWorker.java#L24-L25\r\n\r\nI think it maybe more Rx to make `insertTopFive` to accept an `Observable`, then you give it the `take(5)` as is, without mapping,  or wrap it in other observable using `.asObservable`, this makes more customizability, and is more Rx"},"comment":{"url":"https://api.github.com/repos/MohamedISoliman/Androiddev/issues/comments/411874439","html_url":"https://github.com/MohamedISoliman/Androiddev/issues/3#issuecomment-411874439","issue_url":"https://api.github.com/repos/MohamedISoliman/Androiddev/issues/3","id":411874439,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTg3NDQzOQ==","user":{"login":"MohamedISoliman","id":12463348,"node_id":"MDQ6VXNlcjEyNDYzMzQ4","avatar_url":"https://avatars3.githubusercontent.com/u/12463348?v=4","gravatar_id":"","url":"https://api.github.com/users/MohamedISoliman","html_url":"https://github.com/MohamedISoliman","followers_url":"https://api.github.com/users/MohamedISoliman/followers","following_url":"https://api.github.com/users/MohamedISoliman/following{/other_user}","gists_url":"https://api.github.com/users/MohamedISoliman/gists{/gist_id}","starred_url":"https://api.github.com/users/MohamedISoliman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MohamedISoliman/subscriptions","organizations_url":"https://api.github.com/users/MohamedISoliman/orgs","repos_url":"https://api.github.com/users/MohamedISoliman/repos","events_url":"https://api.github.com/users/MohamedISoliman/events{/privacy}","received_events_url":"https://api.github.com/users/MohamedISoliman/received_events","type":"User","site_admin":false},"created_at":"2018-08-09T19:44:52Z","updated_at":"2018-08-09T19:44:52Z","author_association":"OWNER","body":"I don't see any problem in doing this way, what I think I will change is the insertTopFive() function parameter .. otherwise the code is written in Rx .. "}}
{"actor":{"display_login":"MohamedISoliman"}}