{"action":"created","issue":{"url":"https://api.github.com/repos/zmaster587/AdvancedRocketry/issues/1439","repository_url":"https://api.github.com/repos/zmaster587/AdvancedRocketry","labels_url":"https://api.github.com/repos/zmaster587/AdvancedRocketry/issues/1439/labels{/name}","comments_url":"https://api.github.com/repos/zmaster587/AdvancedRocketry/issues/1439/comments","events_url":"https://api.github.com/repos/zmaster587/AdvancedRocketry/issues/1439/events","html_url":"https://github.com/zmaster587/AdvancedRocketry/issues/1439","id":380591586,"node_id":"MDU6SXNzdWUzODA1OTE1ODY=","number":1439,"title":"Planets/Stars data not sent to client on Sponge server (With a working temporary fix)","user":{"login":"takarabako","id":45030491,"node_id":"MDQ6VXNlcjQ1MDMwNDkx","avatar_url":"https://avatars3.githubusercontent.com/u/45030491?v=4","gravatar_id":"","url":"https://api.github.com/users/takarabako","html_url":"https://github.com/takarabako","followers_url":"https://api.github.com/users/takarabako/followers","following_url":"https://api.github.com/users/takarabako/following{/other_user}","gists_url":"https://api.github.com/users/takarabako/gists{/gist_id}","starred_url":"https://api.github.com/users/takarabako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takarabako/subscriptions","organizations_url":"https://api.github.com/users/takarabako/orgs","repos_url":"https://api.github.com/users/takarabako/repos","events_url":"https://api.github.com/users/takarabako/events{/privacy}","received_events_url":"https://api.github.com/users/takarabako/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-14T08:45:14Z","updated_at":"2018-11-15T06:03:36Z","closed_at":null,"author_association":"NONE","body":"## Version of Advanced Rocketry\r\n1.12.2-1.4.1-113\r\n## Have you verified this is an issue in the latest unstable build\r\nY\r\n## Version of LibVulpes\r\n1.12.2-0.3.0-44\r\n## Version of Minecraft\r\n1.12.2\r\n## Crash report or log (if applicable)\r\nN/A\r\n\r\n## Description of the problem\r\nI'm playing FTB continuum on a sponge server and there are several bugs (client crashing when go to space, not able to select Luna, etc. Not happening on native Forge server) on the server. After some hours of work I managed to track down to a single problem: The ServerConnectionFromClientEvent is somehow not fired on spongeforge-1.12.2-2768-7.1.4 Recommand build. The same mod pack also features ProjectE inside and they are sending data to client correctly so I dig into their source and find out they are using PlayerLoggedInEvent to sync data. I modified AR to use PlayerLoggedInEvent and problem solved(I only applied the fix on server, client still using 1.4.1-113). Here's the modified method https://gist.github.com/takarabako/c3e6940e0249192e248544787fe7ee40"},"comment":{"url":"https://api.github.com/repos/zmaster587/AdvancedRocketry/issues/comments/438928089","html_url":"https://github.com/zmaster587/AdvancedRocketry/issues/1439#issuecomment-438928089","issue_url":"https://api.github.com/repos/zmaster587/AdvancedRocketry/issues/1439","id":438928089,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODkyODA4OQ==","user":{"login":"takarabako","id":45030491,"node_id":"MDQ6VXNlcjQ1MDMwNDkx","avatar_url":"https://avatars3.githubusercontent.com/u/45030491?v=4","gravatar_id":"","url":"https://api.github.com/users/takarabako","html_url":"https://github.com/takarabako","followers_url":"https://api.github.com/users/takarabako/followers","following_url":"https://api.github.com/users/takarabako/following{/other_user}","gists_url":"https://api.github.com/users/takarabako/gists{/gist_id}","starred_url":"https://api.github.com/users/takarabako/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takarabako/subscriptions","organizations_url":"https://api.github.com/users/takarabako/orgs","repos_url":"https://api.github.com/users/takarabako/repos","events_url":"https://api.github.com/users/takarabako/events{/privacy}","received_events_url":"https://api.github.com/users/takarabako/received_events","type":"User","site_admin":false},"created_at":"2018-11-15T06:03:36Z","updated_at":"2018-11-15T06:03:36Z","author_association":"NONE","body":"> Does this work when a player is logging into the world on a non-sponge server when he's on another planet as opposed to a vanilla or world added by a mod other than AR on a dedicated server? Reason I ask is that I had tried using the playerloggedin event initially and it caused a client crash due to the world not yet existing, though it was in MC1.7.10.\r\n\r\nIt crashed, only when you log out on a AR dimension, RESTART the whole client and join back. My guess is the data is a bit slow than the client trying to render the first frame. It won't crash if you set the sky overrides to false. I made some additional changes to RenderPlanetarySky to check when the star is null just don't do anything. as far as I can tell, I can't see any difference."}}
{"actor":{"display_login":"takarabako"}}