{"action":"closed","number":5485,"pull_request":{"url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/5485","id":168661086,"html_url":"https://github.com/SeleniumHQ/selenium/pull/5485","diff_url":"https://github.com/SeleniumHQ/selenium/pull/5485.diff","patch_url":"https://github.com/SeleniumHQ/selenium/pull/5485.patch","issue_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/5485","number":5485,"state":"closed","locked":false,"title":"Fix 'Selenium-Version' manifest attr to be in 'Build-Info' section","user":{"login":"timsutton-sl","id":31670411,"avatar_url":"https://avatars0.githubusercontent.com/u/31670411?v=4","gravatar_id":"","url":"https://api.github.com/users/timsutton-sl","html_url":"https://github.com/timsutton-sl","followers_url":"https://api.github.com/users/timsutton-sl/followers","following_url":"https://api.github.com/users/timsutton-sl/following{/other_user}","gists_url":"https://api.github.com/users/timsutton-sl/gists{/gist_id}","starred_url":"https://api.github.com/users/timsutton-sl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timsutton-sl/subscriptions","organizations_url":"https://api.github.com/users/timsutton-sl/orgs","repos_url":"https://api.github.com/users/timsutton-sl/repos","events_url":"https://api.github.com/users/timsutton-sl/events{/privacy}","received_events_url":"https://api.github.com/users/timsutton-sl/received_events","type":"User","site_admin":false},"body":"- [X] By placing an `X` in the preceding checkbox, I verify that I have signed the [Contributor License Agreement](https://github.com/SeleniumHQ/selenium/blob/master/CONTRIBUTING.md#step-6-sign-the-cla)\r\n\r\nI noticed in the selenium standalone releases since 3.9.0 that the `Build-Info` manifest section is missing `Selenium-Version`, which seems to be due to some refactoring in https://github.com/SeleniumHQ/selenium/commit/adc87a46fe08edca1a3bc0132643f4c306f95668#diff-f7acb1b90eea8308d4e04f861f59cd4a.\r\n\r\nThe standalone jar for 3.8.1 for example has this snippet of manifest data:\r\n```python\r\n'Build-Info': {'Build-Revision': '6e95a6684b',\r\n   'Build-Time': '2017-12-01T19:05:32.194Z',\r\n   'Build-User': 'alexei',\r\n   'Name': 'Build-Info',\r\n   'Selenium-Version': '3.8.1   '}\r\n```\r\n\r\nCompare to 3.9.1:\r\n\r\n```python\r\n'Build-Info': {'Build-Revision': '63f7b50',\r\n   'Build-Time': '2018-02-07T22:42:28.403Z',\r\n   'Build-User': 'shs',\r\n   'Name': 'Build-Info'},\r\n  'Selenium': {'Name': 'Selenium', 'Selenium-Version': '3.9.1'}\r\n```\r\n\r\nThe reason for this PR is that at Sauce we've been parsing this attribute at job run time so that we can dynamically determine the Selenium version being used, even if a user submits a custom jar file to run (which would not be version-controlled by us).\r\n\r\nThis PR just writes out the manifest file as it was originally before that adc87a46fe08edca1a3bc0132643f4c306f95668 commit, so that `Build-Info` is given for the name and thus `Selenium-Version` is written within that section.\r\n\r\nThanks for your consideration!\r\n","created_at":"2018-02-12T19:00:54Z","updated_at":"2018-02-14T14:24:51Z","closed_at":"2018-02-14T14:24:51Z","merged_at":"2018-02-14T14:24:51Z","merge_commit_sha":"d0e16794a400c1488758cdf39efb1bbec75ab577","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":182509154,"url":"https://api.github.com/repos/SeleniumHQ/selenium/labels/C-java","name":"C-java","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/5485/commits","review_comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/5485/comments","review_comment_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/5485/comments","statuses_url":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/f175ade2186173169ff02dd5072c5d91293b31bd","head":{"label":"timsutton-sl:manifest-build-info-selenium-version","ref":"manifest-build-info-selenium-version","sha":"f175ade2186173169ff02dd5072c5d91293b31bd","user":{"login":"timsutton-sl","id":31670411,"avatar_url":"https://avatars0.githubusercontent.com/u/31670411?v=4","gravatar_id":"","url":"https://api.github.com/users/timsutton-sl","html_url":"https://github.com/timsutton-sl","followers_url":"https://api.github.com/users/timsutton-sl/followers","following_url":"https://api.github.com/users/timsutton-sl/following{/other_user}","gists_url":"https://api.github.com/users/timsutton-sl/gists{/gist_id}","starred_url":"https://api.github.com/users/timsutton-sl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timsutton-sl/subscriptions","organizations_url":"https://api.github.com/users/timsutton-sl/orgs","repos_url":"https://api.github.com/users/timsutton-sl/repos","events_url":"https://api.github.com/users/timsutton-sl/events{/privacy}","received_events_url":"https://api.github.com/users/timsutton-sl/received_events","type":"User","site_admin":false},"repo":{"id":121287300,"name":"selenium","full_name":"timsutton-sl/selenium","owner":{"login":"timsutton-sl","id":31670411,"avatar_url":"https://avatars0.githubusercontent.com/u/31670411?v=4","gravatar_id":"","url":"https://api.github.com/users/timsutton-sl","html_url":"https://github.com/timsutton-sl","followers_url":"https://api.github.com/users/timsutton-sl/followers","following_url":"https://api.github.com/users/timsutton-sl/following{/other_user}","gists_url":"https://api.github.com/users/timsutton-sl/gists{/gist_id}","starred_url":"https://api.github.com/users/timsutton-sl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timsutton-sl/subscriptions","organizations_url":"https://api.github.com/users/timsutton-sl/orgs","repos_url":"https://api.github.com/users/timsutton-sl/repos","events_url":"https://api.github.com/users/timsutton-sl/events{/privacy}","received_events_url":"https://api.github.com/users/timsutton-sl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timsutton-sl/selenium","description":"A browser automation framework and ecosystem.","fork":true,"url":"https://api.github.com/repos/timsutton-sl/selenium","forks_url":"https://api.github.com/repos/timsutton-sl/selenium/forks","keys_url":"https://api.github.com/repos/timsutton-sl/selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timsutton-sl/selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timsutton-sl/selenium/teams","hooks_url":"https://api.github.com/repos/timsutton-sl/selenium/hooks","issue_events_url":"https://api.github.com/repos/timsutton-sl/selenium/issues/events{/number}","events_url":"https://api.github.com/repos/timsutton-sl/selenium/events","assignees_url":"https://api.github.com/repos/timsutton-sl/selenium/assignees{/user}","branches_url":"https://api.github.com/repos/timsutton-sl/selenium/branches{/branch}","tags_url":"https://api.github.com/repos/timsutton-sl/selenium/tags","blobs_url":"https://api.github.com/repos/timsutton-sl/selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timsutton-sl/selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timsutton-sl/selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/timsutton-sl/selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timsutton-sl/selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/timsutton-sl/selenium/languages","stargazers_url":"https://api.github.com/repos/timsutton-sl/selenium/stargazers","contributors_url":"https://api.github.com/repos/timsutton-sl/selenium/contributors","subscribers_url":"https://api.github.com/repos/timsutton-sl/selenium/subscribers","subscription_url":"https://api.github.com/repos/timsutton-sl/selenium/subscription","commits_url":"https://api.github.com/repos/timsutton-sl/selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/timsutton-sl/selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/timsutton-sl/selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/timsutton-sl/selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/timsutton-sl/selenium/contents/{+path}","compare_url":"https://api.github.com/repos/timsutton-sl/selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timsutton-sl/selenium/merges","archive_url":"https://api.github.com/repos/timsutton-sl/selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timsutton-sl/selenium/downloads","issues_url":"https://api.github.com/repos/timsutton-sl/selenium/issues{/number}","pulls_url":"https://api.github.com/repos/timsutton-sl/selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/timsutton-sl/selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/timsutton-sl/selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timsutton-sl/selenium/labels{/name}","releases_url":"https://api.github.com/repos/timsutton-sl/selenium/releases{/id}","deployments_url":"https://api.github.com/repos/timsutton-sl/selenium/deployments","created_at":"2018-02-12T18:49:42Z","updated_at":"2018-02-12T18:49:56Z","pushed_at":"2018-02-12T18:50:18Z","git_url":"git://github.com/timsutton-sl/selenium.git","ssh_url":"git@github.com:timsutton-sl/selenium.git","clone_url":"https://github.com/timsutton-sl/selenium.git","svn_url":"https://github.com/timsutton-sl/selenium","homepage":"http://seleniumhq.org/","size":1535233,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SeleniumHQ:master","ref":"master","sha":"5710a3285482b0ec5fa824058d366cc9e0bd793b","user":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars2.githubusercontent.com/u/983927?v=4","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":7613257,"name":"selenium","full_name":"SeleniumHQ/selenium","owner":{"login":"SeleniumHQ","id":983927,"avatar_url":"https://avatars2.githubusercontent.com/u/983927?v=4","gravatar_id":"","url":"https://api.github.com/users/SeleniumHQ","html_url":"https://github.com/SeleniumHQ","followers_url":"https://api.github.com/users/SeleniumHQ/followers","following_url":"https://api.github.com/users/SeleniumHQ/following{/other_user}","gists_url":"https://api.github.com/users/SeleniumHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/SeleniumHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeleniumHQ/subscriptions","organizations_url":"https://api.github.com/users/SeleniumHQ/orgs","repos_url":"https://api.github.com/users/SeleniumHQ/repos","events_url":"https://api.github.com/users/SeleniumHQ/events{/privacy}","received_events_url":"https://api.github.com/users/SeleniumHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SeleniumHQ/selenium","description":"A browser automation framework and ecosystem.","fork":false,"url":"https://api.github.com/repos/SeleniumHQ/selenium","forks_url":"https://api.github.com/repos/SeleniumHQ/selenium/forks","keys_url":"https://api.github.com/repos/SeleniumHQ/selenium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SeleniumHQ/selenium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SeleniumHQ/selenium/teams","hooks_url":"https://api.github.com/repos/SeleniumHQ/selenium/hooks","issue_events_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/events{/number}","events_url":"https://api.github.com/repos/SeleniumHQ/selenium/events","assignees_url":"https://api.github.com/repos/SeleniumHQ/selenium/assignees{/user}","branches_url":"https://api.github.com/repos/SeleniumHQ/selenium/branches{/branch}","tags_url":"https://api.github.com/repos/SeleniumHQ/selenium/tags","blobs_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/refs{/sha}","trees_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/{sha}","languages_url":"https://api.github.com/repos/SeleniumHQ/selenium/languages","stargazers_url":"https://api.github.com/repos/SeleniumHQ/selenium/stargazers","contributors_url":"https://api.github.com/repos/SeleniumHQ/selenium/contributors","subscribers_url":"https://api.github.com/repos/SeleniumHQ/selenium/subscribers","subscription_url":"https://api.github.com/repos/SeleniumHQ/selenium/subscription","commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/commits{/sha}","git_commits_url":"https://api.github.com/repos/SeleniumHQ/selenium/git/commits{/sha}","comments_url":"https://api.github.com/repos/SeleniumHQ/selenium/comments{/number}","issue_comment_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues/comments{/number}","contents_url":"https://api.github.com/repos/SeleniumHQ/selenium/contents/{+path}","compare_url":"https://api.github.com/repos/SeleniumHQ/selenium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SeleniumHQ/selenium/merges","archive_url":"https://api.github.com/repos/SeleniumHQ/selenium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SeleniumHQ/selenium/downloads","issues_url":"https://api.github.com/repos/SeleniumHQ/selenium/issues{/number}","pulls_url":"https://api.github.com/repos/SeleniumHQ/selenium/pulls{/number}","milestones_url":"https://api.github.com/repos/SeleniumHQ/selenium/milestones{/number}","notifications_url":"https://api.github.com/repos/SeleniumHQ/selenium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SeleniumHQ/selenium/labels{/name}","releases_url":"https://api.github.com/repos/SeleniumHQ/selenium/releases{/id}","deployments_url":"https://api.github.com/repos/SeleniumHQ/selenium/deployments","created_at":"2013-01-14T21:40:56Z","updated_at":"2018-02-14T12:07:12Z","pushed_at":"2018-02-14T14:24:51Z","git_url":"git://github.com/SeleniumHQ/selenium.git","ssh_url":"git@github.com:SeleniumHQ/selenium.git","clone_url":"https://github.com/SeleniumHQ/selenium.git","svn_url":"https://github.com/SeleniumHQ/selenium","homepage":"http://seleniumhq.org/","size":1535274,"stargazers_count":9478,"watchers_count":9478,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3666,"mirror_url":null,"archived":false,"open_issues_count":443,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3666,"open_issues":443,"watchers":9478,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/5485"},"html":{"href":"https://github.com/SeleniumHQ/selenium/pull/5485"},"issue":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/issues/5485"},"comments":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/issues/5485/comments"},"review_comments":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/5485/comments"},"review_comment":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/pulls/5485/commits"},"statuses":{"href":"https://api.github.com/repos/SeleniumHQ/selenium/statuses/f175ade2186173169ff02dd5072c5d91293b31bd"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"shs96c","id":28229,"avatar_url":"https://avatars2.githubusercontent.com/u/28229?v=4","gravatar_id":"","url":"https://api.github.com/users/shs96c","html_url":"https://github.com/shs96c","followers_url":"https://api.github.com/users/shs96c/followers","following_url":"https://api.github.com/users/shs96c/following{/other_user}","gists_url":"https://api.github.com/users/shs96c/gists{/gist_id}","starred_url":"https://api.github.com/users/shs96c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shs96c/subscriptions","organizations_url":"https://api.github.com/users/shs96c/orgs","repos_url":"https://api.github.com/users/shs96c/repos","events_url":"https://api.github.com/users/shs96c/events{/privacy}","received_events_url":"https://api.github.com/users/shs96c/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"shs96c"}}