{"action":"opened","number":880,"pull_request":{"url":"https://api.github.com/repos/umijs/umi/pulls/880","id":209555803,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NTU1ODAz","html_url":"https://github.com/umijs/umi/pull/880","diff_url":"https://github.com/umijs/umi/pull/880.diff","patch_url":"https://github.com/umijs/umi/pull/880.patch","issue_url":"https://api.github.com/repos/umijs/umi/issues/880","number":880,"state":"open","locked":false,"title":"fix: umi-plugin-dll does not play nice with HMR","user":{"login":"dilidili","id":5905726,"node_id":"MDQ6VXNlcjU5MDU3MjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5905726?v=4","gravatar_id":"","url":"https://api.github.com/users/dilidili","html_url":"https://github.com/dilidili","followers_url":"https://api.github.com/users/dilidili/followers","following_url":"https://api.github.com/users/dilidili/following{/other_user}","gists_url":"https://api.github.com/users/dilidili/gists{/gist_id}","starred_url":"https://api.github.com/users/dilidili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilidili/subscriptions","organizations_url":"https://api.github.com/users/dilidili/orgs","repos_url":"https://api.github.com/users/dilidili/repos","events_url":"https://api.github.com/users/dilidili/events{/privacy}","received_events_url":"https://api.github.com/users/dilidili/received_events","type":"User","site_admin":false},"body":"Fix Issue #606 \r\n\r\n将```webpackHotDevClientPath```从 DLL 中移除的原因是：如果将 ```webpackHotDevClientPath.js```打入 DLL 中，则会导致```module.hot.check```被覆盖从而优先调用存在于 DLL 中的```hotCheck```(DLL 也是由 webpack 打包得来)。DLL 中的 ```hotCheck``` 的 scope 中被静态打入了 ```var hotCurrentHash = \"d7fb783d864595d5799b\";```，webpack-dev-server 内存中不可能存在这个打 DLL 时候的 update hash，从而导致 HMR 失效。\r\n\r\n@sorrycc 不知道有没有其他更好的方法来避免 DLL 中覆盖 module.hot，我看了下 Webpack 中的 MainTemplate.js 好像并找不到可配置的地方。","created_at":"2018-08-20T15:18:21Z","updated_at":"2018-08-20T15:18:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/umijs/umi/pulls/880/commits","review_comments_url":"https://api.github.com/repos/umijs/umi/pulls/880/comments","review_comment_url":"https://api.github.com/repos/umijs/umi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/umijs/umi/issues/880/comments","statuses_url":"https://api.github.com/repos/umijs/umi/statuses/62d1120afa4a652bb65f2596bdf37095ae2f7b2e","head":{"label":"dilidili:master","ref":"master","sha":"62d1120afa4a652bb65f2596bdf37095ae2f7b2e","user":{"login":"dilidili","id":5905726,"node_id":"MDQ6VXNlcjU5MDU3MjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5905726?v=4","gravatar_id":"","url":"https://api.github.com/users/dilidili","html_url":"https://github.com/dilidili","followers_url":"https://api.github.com/users/dilidili/followers","following_url":"https://api.github.com/users/dilidili/following{/other_user}","gists_url":"https://api.github.com/users/dilidili/gists{/gist_id}","starred_url":"https://api.github.com/users/dilidili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilidili/subscriptions","organizations_url":"https://api.github.com/users/dilidili/orgs","repos_url":"https://api.github.com/users/dilidili/repos","events_url":"https://api.github.com/users/dilidili/events{/privacy}","received_events_url":"https://api.github.com/users/dilidili/received_events","type":"User","site_admin":false},"repo":{"id":144512151,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1MTIxNTE=","name":"umi","full_name":"dilidili/umi","owner":{"login":"dilidili","id":5905726,"node_id":"MDQ6VXNlcjU5MDU3MjY=","avatar_url":"https://avatars2.githubusercontent.com/u/5905726?v=4","gravatar_id":"","url":"https://api.github.com/users/dilidili","html_url":"https://github.com/dilidili","followers_url":"https://api.github.com/users/dilidili/followers","following_url":"https://api.github.com/users/dilidili/following{/other_user}","gists_url":"https://api.github.com/users/dilidili/gists{/gist_id}","starred_url":"https://api.github.com/users/dilidili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilidili/subscriptions","organizations_url":"https://api.github.com/users/dilidili/orgs","repos_url":"https://api.github.com/users/dilidili/repos","events_url":"https://api.github.com/users/dilidili/events{/privacy}","received_events_url":"https://api.github.com/users/dilidili/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dilidili/umi","description":"🚀 Blazing-fast next.js-like framework for React apps.","fork":true,"url":"https://api.github.com/repos/dilidili/umi","forks_url":"https://api.github.com/repos/dilidili/umi/forks","keys_url":"https://api.github.com/repos/dilidili/umi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dilidili/umi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dilidili/umi/teams","hooks_url":"https://api.github.com/repos/dilidili/umi/hooks","issue_events_url":"https://api.github.com/repos/dilidili/umi/issues/events{/number}","events_url":"https://api.github.com/repos/dilidili/umi/events","assignees_url":"https://api.github.com/repos/dilidili/umi/assignees{/user}","branches_url":"https://api.github.com/repos/dilidili/umi/branches{/branch}","tags_url":"https://api.github.com/repos/dilidili/umi/tags","blobs_url":"https://api.github.com/repos/dilidili/umi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dilidili/umi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dilidili/umi/git/refs{/sha}","trees_url":"https://api.github.com/repos/dilidili/umi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dilidili/umi/statuses/{sha}","languages_url":"https://api.github.com/repos/dilidili/umi/languages","stargazers_url":"https://api.github.com/repos/dilidili/umi/stargazers","contributors_url":"https://api.github.com/repos/dilidili/umi/contributors","subscribers_url":"https://api.github.com/repos/dilidili/umi/subscribers","subscription_url":"https://api.github.com/repos/dilidili/umi/subscription","commits_url":"https://api.github.com/repos/dilidili/umi/commits{/sha}","git_commits_url":"https://api.github.com/repos/dilidili/umi/git/commits{/sha}","comments_url":"https://api.github.com/repos/dilidili/umi/comments{/number}","issue_comment_url":"https://api.github.com/repos/dilidili/umi/issues/comments{/number}","contents_url":"https://api.github.com/repos/dilidili/umi/contents/{+path}","compare_url":"https://api.github.com/repos/dilidili/umi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dilidili/umi/merges","archive_url":"https://api.github.com/repos/dilidili/umi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dilidili/umi/downloads","issues_url":"https://api.github.com/repos/dilidili/umi/issues{/number}","pulls_url":"https://api.github.com/repos/dilidili/umi/pulls{/number}","milestones_url":"https://api.github.com/repos/dilidili/umi/milestones{/number}","notifications_url":"https://api.github.com/repos/dilidili/umi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dilidili/umi/labels{/name}","releases_url":"https://api.github.com/repos/dilidili/umi/releases{/id}","deployments_url":"https://api.github.com/repos/dilidili/umi/deployments","created_at":"2018-08-13T00:49:50Z","updated_at":"2018-08-20T15:04:35Z","pushed_at":"2018-08-20T15:04:31Z","git_url":"git://github.com/dilidili/umi.git","ssh_url":"git@github.com:dilidili/umi.git","clone_url":"https://github.com/dilidili/umi.git","svn_url":"https://github.com/dilidili/umi","homepage":"https://umijs.org/","size":2373,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"umijs:master","ref":"master","sha":"9bfaface64f77d60e52fe0cd2e1060f70d7b7dce","user":{"login":"umijs","id":33895495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODk1NDk1","avatar_url":"https://avatars1.githubusercontent.com/u/33895495?v=4","gravatar_id":"","url":"https://api.github.com/users/umijs","html_url":"https://github.com/umijs","followers_url":"https://api.github.com/users/umijs/followers","following_url":"https://api.github.com/users/umijs/following{/other_user}","gists_url":"https://api.github.com/users/umijs/gists{/gist_id}","starred_url":"https://api.github.com/users/umijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umijs/subscriptions","organizations_url":"https://api.github.com/users/umijs/orgs","repos_url":"https://api.github.com/users/umijs/repos","events_url":"https://api.github.com/users/umijs/events{/privacy}","received_events_url":"https://api.github.com/users/umijs/received_events","type":"Organization","site_admin":false},"repo":{"id":111667959,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE2Njc5NTk=","name":"umi","full_name":"umijs/umi","owner":{"login":"umijs","id":33895495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODk1NDk1","avatar_url":"https://avatars1.githubusercontent.com/u/33895495?v=4","gravatar_id":"","url":"https://api.github.com/users/umijs","html_url":"https://github.com/umijs","followers_url":"https://api.github.com/users/umijs/followers","following_url":"https://api.github.com/users/umijs/following{/other_user}","gists_url":"https://api.github.com/users/umijs/gists{/gist_id}","starred_url":"https://api.github.com/users/umijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umijs/subscriptions","organizations_url":"https://api.github.com/users/umijs/orgs","repos_url":"https://api.github.com/users/umijs/repos","events_url":"https://api.github.com/users/umijs/events{/privacy}","received_events_url":"https://api.github.com/users/umijs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/umijs/umi","description":"🚀 Blazing-fast next.js-like framework for React apps.","fork":false,"url":"https://api.github.com/repos/umijs/umi","forks_url":"https://api.github.com/repos/umijs/umi/forks","keys_url":"https://api.github.com/repos/umijs/umi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umijs/umi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umijs/umi/teams","hooks_url":"https://api.github.com/repos/umijs/umi/hooks","issue_events_url":"https://api.github.com/repos/umijs/umi/issues/events{/number}","events_url":"https://api.github.com/repos/umijs/umi/events","assignees_url":"https://api.github.com/repos/umijs/umi/assignees{/user}","branches_url":"https://api.github.com/repos/umijs/umi/branches{/branch}","tags_url":"https://api.github.com/repos/umijs/umi/tags","blobs_url":"https://api.github.com/repos/umijs/umi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umijs/umi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umijs/umi/git/refs{/sha}","trees_url":"https://api.github.com/repos/umijs/umi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umijs/umi/statuses/{sha}","languages_url":"https://api.github.com/repos/umijs/umi/languages","stargazers_url":"https://api.github.com/repos/umijs/umi/stargazers","contributors_url":"https://api.github.com/repos/umijs/umi/contributors","subscribers_url":"https://api.github.com/repos/umijs/umi/subscribers","subscription_url":"https://api.github.com/repos/umijs/umi/subscription","commits_url":"https://api.github.com/repos/umijs/umi/commits{/sha}","git_commits_url":"https://api.github.com/repos/umijs/umi/git/commits{/sha}","comments_url":"https://api.github.com/repos/umijs/umi/comments{/number}","issue_comment_url":"https://api.github.com/repos/umijs/umi/issues/comments{/number}","contents_url":"https://api.github.com/repos/umijs/umi/contents/{+path}","compare_url":"https://api.github.com/repos/umijs/umi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umijs/umi/merges","archive_url":"https://api.github.com/repos/umijs/umi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umijs/umi/downloads","issues_url":"https://api.github.com/repos/umijs/umi/issues{/number}","pulls_url":"https://api.github.com/repos/umijs/umi/pulls{/number}","milestones_url":"https://api.github.com/repos/umijs/umi/milestones{/number}","notifications_url":"https://api.github.com/repos/umijs/umi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umijs/umi/labels{/name}","releases_url":"https://api.github.com/repos/umijs/umi/releases{/id}","deployments_url":"https://api.github.com/repos/umijs/umi/deployments","created_at":"2017-11-22T10:09:36Z","updated_at":"2018-08-20T11:39:01Z","pushed_at":"2018-08-20T15:18:22Z","git_url":"git://github.com/umijs/umi.git","ssh_url":"git@github.com:umijs/umi.git","clone_url":"https://github.com/umijs/umi.git","svn_url":"https://github.com/umijs/umi","homepage":"https://umijs.org/","size":2467,"stargazers_count":1754,"watchers_count":1754,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":188,"open_issues":27,"watchers":1754,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/umijs/umi/pulls/880"},"html":{"href":"https://github.com/umijs/umi/pull/880"},"issue":{"href":"https://api.github.com/repos/umijs/umi/issues/880"},"comments":{"href":"https://api.github.com/repos/umijs/umi/issues/880/comments"},"review_comments":{"href":"https://api.github.com/repos/umijs/umi/pulls/880/comments"},"review_comment":{"href":"https://api.github.com/repos/umijs/umi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/umijs/umi/pulls/880/commits"},"statuses":{"href":"https://api.github.com/repos/umijs/umi/statuses/62d1120afa4a652bb65f2596bdf37095ae2f7b2e"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":0,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"dilidili"}}