{"action":"created","issue":{"url":"https://api.github.com/repos/all-of-us/workbench/issues/1074","repository_url":"https://api.github.com/repos/all-of-us/workbench","labels_url":"https://api.github.com/repos/all-of-us/workbench/issues/1074/labels{/name}","comments_url":"https://api.github.com/repos/all-of-us/workbench/issues/1074/comments","events_url":"https://api.github.com/repos/all-of-us/workbench/issues/1074/events","html_url":"https://github.com/all-of-us/workbench/pull/1074","id":349288645,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDQyMTM2","number":1074,"title":"[RW-1055][risk=no] Drop the login \"from\" feature for now","user":{"login":"calbach","id":822298,"node_id":"MDQ6VXNlcjgyMjI5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/822298?v=4","gravatar_id":"","url":"https://api.github.com/users/calbach","html_url":"https://github.com/calbach","followers_url":"https://api.github.com/users/calbach/followers","following_url":"https://api.github.com/users/calbach/following{/other_user}","gists_url":"https://api.github.com/users/calbach/gists{/gist_id}","starred_url":"https://api.github.com/users/calbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calbach/subscriptions","organizations_url":"https://api.github.com/users/calbach/orgs","repos_url":"https://api.github.com/users/calbach/repos","events_url":"https://api.github.com/users/calbach/events{/privacy}","received_events_url":"https://api.github.com/users/calbach/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-09T20:59:33Z","updated_at":"2018-08-10T16:38:54Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/all-of-us/workbench/pulls/1074","html_url":"https://github.com/all-of-us/workbench/pull/1074","diff_url":"https://github.com/all-of-us/workbench/pull/1074.diff","patch_url":"https://github.com/all-of-us/workbench/pull/1074.patch"},"body":"Unfortunately we can’t fix this without doing a deeper rework of our sign in flow (switching to server side oauth) or breaking certain users' ability to login (reverting to the previous pop-up approach) because we can’t generate a dynamic redirect URI while also matchin our redirect whitelist. I tried tacking on query parameters and hash fragments, nothing makes it through, and GoogleAuth doesn't appear to have any capability to attach extras onto the sign in call.\r\n\r\nSecondarily, this removes the navigation on user signout, as this caused a navigate/reload combo which made the page half-navigate and half-render on sign out before reloading the page."},"comment":{"url":"https://api.github.com/repos/all-of-us/workbench/issues/comments/412138088","html_url":"https://github.com/all-of-us/workbench/pull/1074#issuecomment-412138088","issue_url":"https://api.github.com/repos/all-of-us/workbench/issues/1074","id":412138088,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjEzODA4OA==","user":{"login":"blrubenstein","id":15351021,"node_id":"MDQ6VXNlcjE1MzUxMDIx","avatar_url":"https://avatars0.githubusercontent.com/u/15351021?v=4","gravatar_id":"","url":"https://api.github.com/users/blrubenstein","html_url":"https://github.com/blrubenstein","followers_url":"https://api.github.com/users/blrubenstein/followers","following_url":"https://api.github.com/users/blrubenstein/following{/other_user}","gists_url":"https://api.github.com/users/blrubenstein/gists{/gist_id}","starred_url":"https://api.github.com/users/blrubenstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blrubenstein/subscriptions","organizations_url":"https://api.github.com/users/blrubenstein/orgs","repos_url":"https://api.github.com/users/blrubenstein/repos","events_url":"https://api.github.com/users/blrubenstein/events{/privacy}","received_events_url":"https://api.github.com/users/blrubenstein/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T16:38:54Z","updated_at":"2018-08-10T16:38:54Z","author_association":"COLLABORATOR","body":"Got it. Makes sense."}}
{"actor":{"display_login":"blrubenstein"}}