{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/kibana/issues/19733","repository_url":"https://api.github.com/repos/elastic/kibana","labels_url":"https://api.github.com/repos/elastic/kibana/issues/19733/labels{/name}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/19733/comments","events_url":"https://api.github.com/repos/elastic/kibana/issues/19733/events","html_url":"https://github.com/elastic/kibana/pull/19733","id":330308058,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMzQ5MDM3","number":19733,"title":"Wait until loading has finished","user":{"login":"LeeDr","id":13542669,"node_id":"MDQ6VXNlcjEzNTQyNjY5","avatar_url":"https://avatars1.githubusercontent.com/u/13542669?v=4","gravatar_id":"","url":"https://api.github.com/users/LeeDr","html_url":"https://github.com/LeeDr","followers_url":"https://api.github.com/users/LeeDr/followers","following_url":"https://api.github.com/users/LeeDr/following{/other_user}","gists_url":"https://api.github.com/users/LeeDr/gists{/gist_id}","starred_url":"https://api.github.com/users/LeeDr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeeDr/subscriptions","organizations_url":"https://api.github.com/users/LeeDr/orgs","repos_url":"https://api.github.com/users/LeeDr/repos","events_url":"https://api.github.com/users/LeeDr/events{/privacy}","received_events_url":"https://api.github.com/users/LeeDr/received_events","type":"User","site_admin":false},"labels":[{"id":135307740,"node_id":"MDU6TGFiZWwxMzUzMDc3NDA=","url":"https://api.github.com/repos/elastic/kibana/labels/review","name":"review","color":"0052cc","default":false},{"id":140008186,"node_id":"MDU6TGFiZWwxNDAwMDgxODY=","url":"https://api.github.com/repos/elastic/kibana/labels/test","name":"test","color":"5319e7","default":false},{"id":934760184,"node_id":"MDU6TGFiZWw5MzQ3NjAxODQ=","url":"https://api.github.com/repos/elastic/kibana/labels/v6.3.1","name":"v6.3.1","color":"ffffff","default":false},{"id":883958396,"node_id":"MDU6TGFiZWw4ODM5NTgzOTY=","url":"https://api.github.com/repos/elastic/kibana/labels/v6.4.0","name":"v6.4.0","color":"ffffff","default":false},{"id":654061976,"node_id":"MDU6TGFiZWw2NTQwNjE5NzY=","url":"https://api.github.com/repos/elastic/kibana/labels/v7.0.0","name":"v7.0.0","color":"ffffff","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-06-07T14:50:34Z","updated_at":"2018-06-22T22:38:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/19733","html_url":"https://github.com/elastic/kibana/pull/19733","diff_url":"https://github.com/elastic/kibana/pull/19733.diff","patch_url":"https://github.com/elastic/kibana/pull/19733.patch"},"body":"This PR mainly adds `await PageObjects.header.waitUntilLoadingHasFinished();` to some pageObject methods which cause a request/response to/from Elasticsearch.  In general I think those pageObject methods should always wait for the loading indicator to be hidden before returning.  This should reduce the need to use `retry.try` type of logic in as many places.\r\n\r\nThe second thing addressed by the PR is to fix the `describe` statements in many of the Visualization tests.  Very many of them had a separate describe for their before method which is not necessary.  And many of them were all named the same `visualize app` which made it more difficult to figure out a failure based on the log output.\r\n\r\nLastly the `context` tests had been commented-out because of a bug.  I've change them to `skip` so they report as pending in the results."},"comment":{"url":"https://api.github.com/repos/elastic/kibana/issues/comments/399601713","html_url":"https://github.com/elastic/kibana/pull/19733#issuecomment-399601713","issue_url":"https://api.github.com/repos/elastic/kibana/issues/19733","id":399601713,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTYwMTcxMw==","user":{"login":"liza-mae","id":23424008,"node_id":"MDQ6VXNlcjIzNDI0MDA4","avatar_url":"https://avatars1.githubusercontent.com/u/23424008?v=4","gravatar_id":"","url":"https://api.github.com/users/liza-mae","html_url":"https://github.com/liza-mae","followers_url":"https://api.github.com/users/liza-mae/followers","following_url":"https://api.github.com/users/liza-mae/following{/other_user}","gists_url":"https://api.github.com/users/liza-mae/gists{/gist_id}","starred_url":"https://api.github.com/users/liza-mae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liza-mae/subscriptions","organizations_url":"https://api.github.com/users/liza-mae/orgs","repos_url":"https://api.github.com/users/liza-mae/repos","events_url":"https://api.github.com/users/liza-mae/events{/privacy}","received_events_url":"https://api.github.com/users/liza-mae/received_events","type":"User","site_admin":false},"created_at":"2018-06-22T22:38:27Z","updated_at":"2018-06-22T22:38:27Z","author_association":"MEMBER","body":"Looks like there are other formatting changes like fixing spaces in the files and I see some changes between master and 6.x. \r\n\r\nAnother recommendation, is to check formatting changes first, it will make it easier to identify functional changes, for example like in _input_control_vis.js. "}}
{"actor":{"display_login":"liza-mae"}}