{"action":"created","issue":{"url":"https://api.github.com/repos/bjjb/ebayr/issues/21","repository_url":"https://api.github.com/repos/bjjb/ebayr","labels_url":"https://api.github.com/repos/bjjb/ebayr/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/bjjb/ebayr/issues/21/comments","events_url":"https://api.github.com/repos/bjjb/ebayr/issues/21/events","html_url":"https://github.com/bjjb/ebayr/pull/21","id":108868450,"number":21,"title":"Make Array handling in payload values more compact to reflect subsequent equal tags","user":{"login":"meismann","id":1921091,"avatar_url":"https://avatars1.githubusercontent.com/u/1921091?v=4","gravatar_id":"","url":"https://api.github.com/users/meismann","html_url":"https://github.com/meismann","followers_url":"https://api.github.com/users/meismann/followers","following_url":"https://api.github.com/users/meismann/following{/other_user}","gists_url":"https://api.github.com/users/meismann/gists{/gist_id}","starred_url":"https://api.github.com/users/meismann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meismann/subscriptions","organizations_url":"https://api.github.com/users/meismann/orgs","repos_url":"https://api.github.com/users/meismann/repos","events_url":"https://api.github.com/users/meismann/events{/privacy}","received_events_url":"https://api.github.com/users/meismann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2015-09-29T13:25:12Z","updated_at":"2018-03-09T07:28:45Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/bjjb/ebayr/pulls/21","html_url":"https://github.com/bjjb/ebayr/pull/21","diff_url":"https://github.com/bjjb/ebayr/pull/21.diff","patch_url":"https://github.com/bjjb/ebayr/pull/21.patch"},"body":"Old behaviour:\n\n``` ruby\n# Adds: \"<a>1</a><a><b>1</b><b>2</b></a>\" to the ebay request body\nargs = [{ :a => 1 }, { :a => [{:b => 1 }, { :b => 2 }] }]\nEbayr::Request.new(:Blah, :input => args)\n```\n\nNew behaviour:\n\nIf a value in this Hash is an Array, then each of the Array's elements is wrapped in the same tag (which is the value's key), like here (1 and 2 are both wrapped in the tag `b`):\n\n``` ruby\n# Adds: \"<a>1</a><a><b>1</b><b>2</b></a>\" to the ebay request body\nargs = {a: [ 1, { b: [1, 2] } ]}\nEbayr::Request.new(:Blah, :input => args)\n```\n\nIf you have to, you can switch the legacy syntax on with this setting:\n\n``` ruby\nEbayr.use_old_hash_to_xml_conversion = true\n```\n\nAlso:\nThese methods cannot be used from outside of `Ebayr::Request` any more:\n.xml, .serialize_input, .camelize, #input_xml\n"},"comment":{"url":"https://api.github.com/repos/bjjb/ebayr/issues/comments/371735174","html_url":"https://github.com/bjjb/ebayr/pull/21#issuecomment-371735174","issue_url":"https://api.github.com/repos/bjjb/ebayr/issues/21","id":371735174,"user":{"login":"meismann","id":1921091,"avatar_url":"https://avatars1.githubusercontent.com/u/1921091?v=4","gravatar_id":"","url":"https://api.github.com/users/meismann","html_url":"https://github.com/meismann","followers_url":"https://api.github.com/users/meismann/followers","following_url":"https://api.github.com/users/meismann/following{/other_user}","gists_url":"https://api.github.com/users/meismann/gists{/gist_id}","starred_url":"https://api.github.com/users/meismann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meismann/subscriptions","organizations_url":"https://api.github.com/users/meismann/orgs","repos_url":"https://api.github.com/users/meismann/repos","events_url":"https://api.github.com/users/meismann/events{/privacy}","received_events_url":"https://api.github.com/users/meismann/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T07:28:45Z","updated_at":"2018-03-09T07:28:45Z","author_association":"NONE","body":"Any chance that theses changes will make it into master? If not, let us close it."}}
{"actor":{"display_login":"meismann"}}