{"action":"closed","number":222,"pull_request":{"url":"https://api.github.com/repos/jarun/googler/pulls/222","id":178501865,"html_url":"https://github.com/jarun/googler/pull/222","diff_url":"https://github.com/jarun/googler/pull/222.diff","patch_url":"https://github.com/jarun/googler/pull/222.patch","issue_url":"https://api.github.com/repos/jarun/googler/issues/222","number":222,"state":"closed","locked":false,"title":"If proxy environment variable has '/' after port number, googler fails.","user":{"login":"dilawar","id":895681,"avatar_url":"https://avatars3.githubusercontent.com/u/895681?v=4","gravatar_id":"","url":"https://api.github.com/users/dilawar","html_url":"https://github.com/dilawar","followers_url":"https://api.github.com/users/dilawar/followers","following_url":"https://api.github.com/users/dilawar/following{/other_user}","gists_url":"https://api.github.com/users/dilawar/gists{/gist_id}","starred_url":"https://api.github.com/users/dilawar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilawar/subscriptions","organizations_url":"https://api.github.com/users/dilawar/orgs","repos_url":"https://api.github.com/users/dilawar/repos","events_url":"https://api.github.com/users/dilawar/events{/privacy}","received_events_url":"https://api.github.com/users/dilawar/received_events","type":"User","site_admin":false},"body":"For proxy environemtn variable such as https_proyx=http://proxy.abc.in:3128/ with leading '/' after port number\r\n, currently googler would not work because '3128/' is not a numeric port. This PR fixes this. This format with '/' works with almost many other tools such as wget, curl etc. '/' after port number is suggested at many places including arch https://wiki.archlinux.org/index.php/proxy_settings .\r\n\r\n- ~~~Applicable only for environment variable.~~~\r\n- ~~~If user is passing `--proxy=http://proxy.abc.in:3128/' from command line, it is not applicable.~~~","created_at":"2018-03-30T06:22:57Z","updated_at":"2018-03-31T07:47:25Z","closed_at":"2018-03-31T07:47:25Z","merged_at":"2018-03-31T07:47:25Z","merge_commit_sha":"625f86a27ce9c71ec9f962b6e7b97bd4cc3355d6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jarun/googler/pulls/222/commits","review_comments_url":"https://api.github.com/repos/jarun/googler/pulls/222/comments","review_comment_url":"https://api.github.com/repos/jarun/googler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jarun/googler/issues/222/comments","statuses_url":"https://api.github.com/repos/jarun/googler/statuses/2e2b6ab7b7e37147ed5009ec0268221ae44e70f4","head":{"label":"dilawar:master","ref":"master","sha":"2e2b6ab7b7e37147ed5009ec0268221ae44e70f4","user":{"login":"dilawar","id":895681,"avatar_url":"https://avatars3.githubusercontent.com/u/895681?v=4","gravatar_id":"","url":"https://api.github.com/users/dilawar","html_url":"https://github.com/dilawar","followers_url":"https://api.github.com/users/dilawar/followers","following_url":"https://api.github.com/users/dilawar/following{/other_user}","gists_url":"https://api.github.com/users/dilawar/gists{/gist_id}","starred_url":"https://api.github.com/users/dilawar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilawar/subscriptions","organizations_url":"https://api.github.com/users/dilawar/orgs","repos_url":"https://api.github.com/users/dilawar/repos","events_url":"https://api.github.com/users/dilawar/events{/privacy}","received_events_url":"https://api.github.com/users/dilawar/received_events","type":"User","site_admin":false},"repo":{"id":127388594,"name":"googler","full_name":"dilawar/googler","owner":{"login":"dilawar","id":895681,"avatar_url":"https://avatars3.githubusercontent.com/u/895681?v=4","gravatar_id":"","url":"https://api.github.com/users/dilawar","html_url":"https://github.com/dilawar","followers_url":"https://api.github.com/users/dilawar/followers","following_url":"https://api.github.com/users/dilawar/following{/other_user}","gists_url":"https://api.github.com/users/dilawar/gists{/gist_id}","starred_url":"https://api.github.com/users/dilawar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dilawar/subscriptions","organizations_url":"https://api.github.com/users/dilawar/orgs","repos_url":"https://api.github.com/users/dilawar/repos","events_url":"https://api.github.com/users/dilawar/events{/privacy}","received_events_url":"https://api.github.com/users/dilawar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dilawar/googler","description":":eyes: Google Search, Google Site Search, Google News from the terminal","fork":true,"url":"https://api.github.com/repos/dilawar/googler","forks_url":"https://api.github.com/repos/dilawar/googler/forks","keys_url":"https://api.github.com/repos/dilawar/googler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dilawar/googler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dilawar/googler/teams","hooks_url":"https://api.github.com/repos/dilawar/googler/hooks","issue_events_url":"https://api.github.com/repos/dilawar/googler/issues/events{/number}","events_url":"https://api.github.com/repos/dilawar/googler/events","assignees_url":"https://api.github.com/repos/dilawar/googler/assignees{/user}","branches_url":"https://api.github.com/repos/dilawar/googler/branches{/branch}","tags_url":"https://api.github.com/repos/dilawar/googler/tags","blobs_url":"https://api.github.com/repos/dilawar/googler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dilawar/googler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dilawar/googler/git/refs{/sha}","trees_url":"https://api.github.com/repos/dilawar/googler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dilawar/googler/statuses/{sha}","languages_url":"https://api.github.com/repos/dilawar/googler/languages","stargazers_url":"https://api.github.com/repos/dilawar/googler/stargazers","contributors_url":"https://api.github.com/repos/dilawar/googler/contributors","subscribers_url":"https://api.github.com/repos/dilawar/googler/subscribers","subscription_url":"https://api.github.com/repos/dilawar/googler/subscription","commits_url":"https://api.github.com/repos/dilawar/googler/commits{/sha}","git_commits_url":"https://api.github.com/repos/dilawar/googler/git/commits{/sha}","comments_url":"https://api.github.com/repos/dilawar/googler/comments{/number}","issue_comment_url":"https://api.github.com/repos/dilawar/googler/issues/comments{/number}","contents_url":"https://api.github.com/repos/dilawar/googler/contents/{+path}","compare_url":"https://api.github.com/repos/dilawar/googler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dilawar/googler/merges","archive_url":"https://api.github.com/repos/dilawar/googler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dilawar/googler/downloads","issues_url":"https://api.github.com/repos/dilawar/googler/issues{/number}","pulls_url":"https://api.github.com/repos/dilawar/googler/pulls{/number}","milestones_url":"https://api.github.com/repos/dilawar/googler/milestones{/number}","notifications_url":"https://api.github.com/repos/dilawar/googler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dilawar/googler/labels{/name}","releases_url":"https://api.github.com/repos/dilawar/googler/releases{/id}","deployments_url":"https://api.github.com/repos/dilawar/googler/deployments","created_at":"2018-03-30T06:07:39Z","updated_at":"2018-03-31T06:24:27Z","pushed_at":"2018-03-31T06:24:26Z","git_url":"git://github.com/dilawar/googler.git","ssh_url":"git@github.com:dilawar/googler.git","clone_url":"https://github.com/dilawar/googler.git","svn_url":"https://github.com/dilawar/googler","homepage":"","size":1623,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jarun:master","ref":"master","sha":"6281e10e6a01ea0ded2be38934fbd5bda23f4440","user":{"login":"jarun","id":5959286,"avatar_url":"https://avatars3.githubusercontent.com/u/5959286?v=4","gravatar_id":"","url":"https://api.github.com/users/jarun","html_url":"https://github.com/jarun","followers_url":"https://api.github.com/users/jarun/followers","following_url":"https://api.github.com/users/jarun/following{/other_user}","gists_url":"https://api.github.com/users/jarun/gists{/gist_id}","starred_url":"https://api.github.com/users/jarun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarun/subscriptions","organizations_url":"https://api.github.com/users/jarun/orgs","repos_url":"https://api.github.com/users/jarun/repos","events_url":"https://api.github.com/users/jarun/events{/privacy}","received_events_url":"https://api.github.com/users/jarun/received_events","type":"User","site_admin":false},"repo":{"id":40797633,"name":"googler","full_name":"jarun/googler","owner":{"login":"jarun","id":5959286,"avatar_url":"https://avatars3.githubusercontent.com/u/5959286?v=4","gravatar_id":"","url":"https://api.github.com/users/jarun","html_url":"https://github.com/jarun","followers_url":"https://api.github.com/users/jarun/followers","following_url":"https://api.github.com/users/jarun/following{/other_user}","gists_url":"https://api.github.com/users/jarun/gists{/gist_id}","starred_url":"https://api.github.com/users/jarun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarun/subscriptions","organizations_url":"https://api.github.com/users/jarun/orgs","repos_url":"https://api.github.com/users/jarun/repos","events_url":"https://api.github.com/users/jarun/events{/privacy}","received_events_url":"https://api.github.com/users/jarun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jarun/googler","description":":eyes: Google Search, Google Site Search, Google News from the terminal","fork":false,"url":"https://api.github.com/repos/jarun/googler","forks_url":"https://api.github.com/repos/jarun/googler/forks","keys_url":"https://api.github.com/repos/jarun/googler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jarun/googler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jarun/googler/teams","hooks_url":"https://api.github.com/repos/jarun/googler/hooks","issue_events_url":"https://api.github.com/repos/jarun/googler/issues/events{/number}","events_url":"https://api.github.com/repos/jarun/googler/events","assignees_url":"https://api.github.com/repos/jarun/googler/assignees{/user}","branches_url":"https://api.github.com/repos/jarun/googler/branches{/branch}","tags_url":"https://api.github.com/repos/jarun/googler/tags","blobs_url":"https://api.github.com/repos/jarun/googler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jarun/googler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jarun/googler/git/refs{/sha}","trees_url":"https://api.github.com/repos/jarun/googler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jarun/googler/statuses/{sha}","languages_url":"https://api.github.com/repos/jarun/googler/languages","stargazers_url":"https://api.github.com/repos/jarun/googler/stargazers","contributors_url":"https://api.github.com/repos/jarun/googler/contributors","subscribers_url":"https://api.github.com/repos/jarun/googler/subscribers","subscription_url":"https://api.github.com/repos/jarun/googler/subscription","commits_url":"https://api.github.com/repos/jarun/googler/commits{/sha}","git_commits_url":"https://api.github.com/repos/jarun/googler/git/commits{/sha}","comments_url":"https://api.github.com/repos/jarun/googler/comments{/number}","issue_comment_url":"https://api.github.com/repos/jarun/googler/issues/comments{/number}","contents_url":"https://api.github.com/repos/jarun/googler/contents/{+path}","compare_url":"https://api.github.com/repos/jarun/googler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jarun/googler/merges","archive_url":"https://api.github.com/repos/jarun/googler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jarun/googler/downloads","issues_url":"https://api.github.com/repos/jarun/googler/issues{/number}","pulls_url":"https://api.github.com/repos/jarun/googler/pulls{/number}","milestones_url":"https://api.github.com/repos/jarun/googler/milestones{/number}","notifications_url":"https://api.github.com/repos/jarun/googler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jarun/googler/labels{/name}","releases_url":"https://api.github.com/repos/jarun/googler/releases{/id}","deployments_url":"https://api.github.com/repos/jarun/googler/deployments","created_at":"2015-08-16T03:33:02Z","updated_at":"2018-03-30T13:44:21Z","pushed_at":"2018-03-31T07:47:25Z","git_url":"git://github.com/jarun/googler.git","ssh_url":"git@github.com:jarun/googler.git","clone_url":"https://github.com/jarun/googler.git","svn_url":"https://github.com/jarun/googler","homepage":"","size":1592,"stargazers_count":2317,"watchers_count":2317,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":247,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":247,"open_issues":1,"watchers":2317,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jarun/googler/pulls/222"},"html":{"href":"https://github.com/jarun/googler/pull/222"},"issue":{"href":"https://api.github.com/repos/jarun/googler/issues/222"},"comments":{"href":"https://api.github.com/repos/jarun/googler/issues/222/comments"},"review_comments":{"href":"https://api.github.com/repos/jarun/googler/pulls/222/comments"},"review_comment":{"href":"https://api.github.com/repos/jarun/googler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jarun/googler/pulls/222/commits"},"statuses":{"href":"https://api.github.com/repos/jarun/googler/statuses/2e2b6ab7b7e37147ed5009ec0268221ae44e70f4"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jarun","id":5959286,"avatar_url":"https://avatars3.githubusercontent.com/u/5959286?v=4","gravatar_id":"","url":"https://api.github.com/users/jarun","html_url":"https://github.com/jarun","followers_url":"https://api.github.com/users/jarun/followers","following_url":"https://api.github.com/users/jarun/following{/other_user}","gists_url":"https://api.github.com/users/jarun/gists{/gist_id}","starred_url":"https://api.github.com/users/jarun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarun/subscriptions","organizations_url":"https://api.github.com/users/jarun/orgs","repos_url":"https://api.github.com/users/jarun/repos","events_url":"https://api.github.com/users/jarun/events{/privacy}","received_events_url":"https://api.github.com/users/jarun/received_events","type":"User","site_admin":false},"comments":1,"review_comments":4,"maintainer_can_modify":false,"commits":3,"additions":3,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"jarun"}}