{"action":"created","comment":{"url":"https://api.github.com/repos/premake/premake-core/pulls/comments/184344518","pull_request_review_id":115519382,"id":184344518,"diff_hunk":"@@ -365,7 +365,7 @@ int premake_locate_executable(lua_State* L, const char* argv0)\n \t}\n #endif\n \n-#if PLATFORM_BSD\n+#if PLATFORM_BSD && !defined(__OpenBSD__)","path":"src/host/premake.c","position":5,"original_position":5,"commit_id":"63a83af8446de27bb9b255bc8b681de1c288835a","original_commit_id":"63a83af8446de27bb9b255bc8b681de1c288835a","user":{"login":"samsinsane","id":11887457,"avatar_url":"https://avatars2.githubusercontent.com/u/11887457?v=4","gravatar_id":"","url":"https://api.github.com/users/samsinsane","html_url":"https://github.com/samsinsane","followers_url":"https://api.github.com/users/samsinsane/followers","following_url":"https://api.github.com/users/samsinsane/following{/other_user}","gists_url":"https://api.github.com/users/samsinsane/gists{/gist_id}","starred_url":"https://api.github.com/users/samsinsane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samsinsane/subscriptions","organizations_url":"https://api.github.com/users/samsinsane/orgs","repos_url":"https://api.github.com/users/samsinsane/repos","events_url":"https://api.github.com/users/samsinsane/events{/privacy}","received_events_url":"https://api.github.com/users/samsinsane/received_events","type":"User","site_admin":false},"body":"That's fair enough, perhaps wrapping that block instead would be better? Not required, if the none of it will work on OpenBSD it's probably pointless reducing it down to what doesn't compile.","created_at":"2018-04-26T10:38:37Z","updated_at":"2018-04-26T10:38:37Z","html_url":"https://github.com/premake/premake-core/pull/1070#discussion_r184344518","pull_request_url":"https://api.github.com/repos/premake/premake-core/pulls/1070","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/premake/premake-core/pulls/comments/184344518"},"html":{"href":"https://github.com/premake/premake-core/pull/1070#discussion_r184344518"},"pull_request":{"href":"https://api.github.com/repos/premake/premake-core/pulls/1070"}},"in_reply_to_id":184331513},"pull_request":{"url":"https://api.github.com/repos/premake/premake-core/pulls/1070","id":184243182,"html_url":"https://github.com/premake/premake-core/pull/1070","diff_url":"https://github.com/premake/premake-core/pull/1070.diff","patch_url":"https://github.com/premake/premake-core/pull/1070.patch","issue_url":"https://api.github.com/repos/premake/premake-core/issues/1070","number":1070,"state":"open","locked":false,"title":"Support successfully bootstrapping on OpenBSD.","user":{"login":"lanurmi","id":5632407,"avatar_url":"https://avatars1.githubusercontent.com/u/5632407?v=4","gravatar_id":"","url":"https://api.github.com/users/lanurmi","html_url":"https://github.com/lanurmi","followers_url":"https://api.github.com/users/lanurmi/followers","following_url":"https://api.github.com/users/lanurmi/following{/other_user}","gists_url":"https://api.github.com/users/lanurmi/gists{/gist_id}","starred_url":"https://api.github.com/users/lanurmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanurmi/subscriptions","organizations_url":"https://api.github.com/users/lanurmi/orgs","repos_url":"https://api.github.com/users/lanurmi/repos","events_url":"https://api.github.com/users/lanurmi/events{/privacy}","received_events_url":"https://api.github.com/users/lanurmi/received_events","type":"User","site_admin":false},"body":"This PR depends on PR #1068, which should be applied first.","created_at":"2018-04-26T06:59:27Z","updated_at":"2018-04-26T10:38:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a80e8f708e8b6cd65181131d7492298e827f5c2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/premake/premake-core/pulls/1070/commits","review_comments_url":"https://api.github.com/repos/premake/premake-core/pulls/1070/comments","review_comment_url":"https://api.github.com/repos/premake/premake-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/premake/premake-core/issues/1070/comments","statuses_url":"https://api.github.com/repos/premake/premake-core/statuses/63a83af8446de27bb9b255bc8b681de1c288835a","head":{"label":"lanurmi:fix-openbsd-depends-on-1068","ref":"fix-openbsd-depends-on-1068","sha":"63a83af8446de27bb9b255bc8b681de1c288835a","user":{"login":"lanurmi","id":5632407,"avatar_url":"https://avatars1.githubusercontent.com/u/5632407?v=4","gravatar_id":"","url":"https://api.github.com/users/lanurmi","html_url":"https://github.com/lanurmi","followers_url":"https://api.github.com/users/lanurmi/followers","following_url":"https://api.github.com/users/lanurmi/following{/other_user}","gists_url":"https://api.github.com/users/lanurmi/gists{/gist_id}","starred_url":"https://api.github.com/users/lanurmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanurmi/subscriptions","organizations_url":"https://api.github.com/users/lanurmi/orgs","repos_url":"https://api.github.com/users/lanurmi/repos","events_url":"https://api.github.com/users/lanurmi/events{/privacy}","received_events_url":"https://api.github.com/users/lanurmi/received_events","type":"User","site_admin":false},"repo":{"id":131039126,"name":"premake-core","full_name":"lanurmi/premake-core","owner":{"login":"lanurmi","id":5632407,"avatar_url":"https://avatars1.githubusercontent.com/u/5632407?v=4","gravatar_id":"","url":"https://api.github.com/users/lanurmi","html_url":"https://github.com/lanurmi","followers_url":"https://api.github.com/users/lanurmi/followers","following_url":"https://api.github.com/users/lanurmi/following{/other_user}","gists_url":"https://api.github.com/users/lanurmi/gists{/gist_id}","starred_url":"https://api.github.com/users/lanurmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lanurmi/subscriptions","organizations_url":"https://api.github.com/users/lanurmi/orgs","repos_url":"https://api.github.com/users/lanurmi/repos","events_url":"https://api.github.com/users/lanurmi/events{/privacy}","received_events_url":"https://api.github.com/users/lanurmi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lanurmi/premake-core","description":"Premake","fork":true,"url":"https://api.github.com/repos/lanurmi/premake-core","forks_url":"https://api.github.com/repos/lanurmi/premake-core/forks","keys_url":"https://api.github.com/repos/lanurmi/premake-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lanurmi/premake-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lanurmi/premake-core/teams","hooks_url":"https://api.github.com/repos/lanurmi/premake-core/hooks","issue_events_url":"https://api.github.com/repos/lanurmi/premake-core/issues/events{/number}","events_url":"https://api.github.com/repos/lanurmi/premake-core/events","assignees_url":"https://api.github.com/repos/lanurmi/premake-core/assignees{/user}","branches_url":"https://api.github.com/repos/lanurmi/premake-core/branches{/branch}","tags_url":"https://api.github.com/repos/lanurmi/premake-core/tags","blobs_url":"https://api.github.com/repos/lanurmi/premake-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lanurmi/premake-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lanurmi/premake-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/lanurmi/premake-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lanurmi/premake-core/statuses/{sha}","languages_url":"https://api.github.com/repos/lanurmi/premake-core/languages","stargazers_url":"https://api.github.com/repos/lanurmi/premake-core/stargazers","contributors_url":"https://api.github.com/repos/lanurmi/premake-core/contributors","subscribers_url":"https://api.github.com/repos/lanurmi/premake-core/subscribers","subscription_url":"https://api.github.com/repos/lanurmi/premake-core/subscription","commits_url":"https://api.github.com/repos/lanurmi/premake-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/lanurmi/premake-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/lanurmi/premake-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/lanurmi/premake-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/lanurmi/premake-core/contents/{+path}","compare_url":"https://api.github.com/repos/lanurmi/premake-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lanurmi/premake-core/merges","archive_url":"https://api.github.com/repos/lanurmi/premake-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lanurmi/premake-core/downloads","issues_url":"https://api.github.com/repos/lanurmi/premake-core/issues{/number}","pulls_url":"https://api.github.com/repos/lanurmi/premake-core/pulls{/number}","milestones_url":"https://api.github.com/repos/lanurmi/premake-core/milestones{/number}","notifications_url":"https://api.github.com/repos/lanurmi/premake-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lanurmi/premake-core/labels{/name}","releases_url":"https://api.github.com/repos/lanurmi/premake-core/releases{/id}","deployments_url":"https://api.github.com/repos/lanurmi/premake-core/deployments","created_at":"2018-04-25T17:08:44Z","updated_at":"2018-04-25T17:08:51Z","pushed_at":"2018-04-26T06:54:16Z","git_url":"git://github.com/lanurmi/premake-core.git","ssh_url":"git@github.com:lanurmi/premake-core.git","clone_url":"https://github.com/lanurmi/premake-core.git","svn_url":"https://github.com/lanurmi/premake-core","homepage":"https://premake.github.io/","size":25729,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"premake:master","ref":"master","sha":"8d0dce9c65346513c640547fd0e6f8b0a206cc26","user":{"login":"premake","id":11135954,"avatar_url":"https://avatars0.githubusercontent.com/u/11135954?v=4","gravatar_id":"","url":"https://api.github.com/users/premake","html_url":"https://github.com/premake","followers_url":"https://api.github.com/users/premake/followers","following_url":"https://api.github.com/users/premake/following{/other_user}","gists_url":"https://api.github.com/users/premake/gists{/gist_id}","starred_url":"https://api.github.com/users/premake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/premake/subscriptions","organizations_url":"https://api.github.com/users/premake/orgs","repos_url":"https://api.github.com/users/premake/repos","events_url":"https://api.github.com/users/premake/events{/privacy}","received_events_url":"https://api.github.com/users/premake/received_events","type":"Organization","site_admin":false},"repo":{"id":32634405,"name":"premake-core","full_name":"premake/premake-core","owner":{"login":"premake","id":11135954,"avatar_url":"https://avatars0.githubusercontent.com/u/11135954?v=4","gravatar_id":"","url":"https://api.github.com/users/premake","html_url":"https://github.com/premake","followers_url":"https://api.github.com/users/premake/followers","following_url":"https://api.github.com/users/premake/following{/other_user}","gists_url":"https://api.github.com/users/premake/gists{/gist_id}","starred_url":"https://api.github.com/users/premake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/premake/subscriptions","organizations_url":"https://api.github.com/users/premake/orgs","repos_url":"https://api.github.com/users/premake/repos","events_url":"https://api.github.com/users/premake/events{/privacy}","received_events_url":"https://api.github.com/users/premake/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/premake/premake-core","description":"Premake","fork":false,"url":"https://api.github.com/repos/premake/premake-core","forks_url":"https://api.github.com/repos/premake/premake-core/forks","keys_url":"https://api.github.com/repos/premake/premake-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/premake/premake-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/premake/premake-core/teams","hooks_url":"https://api.github.com/repos/premake/premake-core/hooks","issue_events_url":"https://api.github.com/repos/premake/premake-core/issues/events{/number}","events_url":"https://api.github.com/repos/premake/premake-core/events","assignees_url":"https://api.github.com/repos/premake/premake-core/assignees{/user}","branches_url":"https://api.github.com/repos/premake/premake-core/branches{/branch}","tags_url":"https://api.github.com/repos/premake/premake-core/tags","blobs_url":"https://api.github.com/repos/premake/premake-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/premake/premake-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/premake/premake-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/premake/premake-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/premake/premake-core/statuses/{sha}","languages_url":"https://api.github.com/repos/premake/premake-core/languages","stargazers_url":"https://api.github.com/repos/premake/premake-core/stargazers","contributors_url":"https://api.github.com/repos/premake/premake-core/contributors","subscribers_url":"https://api.github.com/repos/premake/premake-core/subscribers","subscription_url":"https://api.github.com/repos/premake/premake-core/subscription","commits_url":"https://api.github.com/repos/premake/premake-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/premake/premake-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/premake/premake-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/premake/premake-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/premake/premake-core/contents/{+path}","compare_url":"https://api.github.com/repos/premake/premake-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/premake/premake-core/merges","archive_url":"https://api.github.com/repos/premake/premake-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/premake/premake-core/downloads","issues_url":"https://api.github.com/repos/premake/premake-core/issues{/number}","pulls_url":"https://api.github.com/repos/premake/premake-core/pulls{/number}","milestones_url":"https://api.github.com/repos/premake/premake-core/milestones{/number}","notifications_url":"https://api.github.com/repos/premake/premake-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/premake/premake-core/labels{/name}","releases_url":"https://api.github.com/repos/premake/premake-core/releases{/id}","deployments_url":"https://api.github.com/repos/premake/premake-core/deployments","created_at":"2015-03-21T14:08:15Z","updated_at":"2018-04-25T20:24:30Z","pushed_at":"2018-04-26T06:59:28Z","git_url":"git://github.com/premake/premake-core.git","ssh_url":"git@github.com:premake/premake-core.git","clone_url":"https://github.com/premake/premake-core.git","svn_url":"https://github.com/premake/premake-core","homepage":"https://premake.github.io/","size":25716,"stargazers_count":907,"watchers_count":907,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":241,"mirror_url":null,"archived":false,"open_issues_count":131,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":241,"open_issues":131,"watchers":907,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/premake/premake-core/pulls/1070"},"html":{"href":"https://github.com/premake/premake-core/pull/1070"},"issue":{"href":"https://api.github.com/repos/premake/premake-core/issues/1070"},"comments":{"href":"https://api.github.com/repos/premake/premake-core/issues/1070/comments"},"review_comments":{"href":"https://api.github.com/repos/premake/premake-core/pulls/1070/comments"},"review_comment":{"href":"https://api.github.com/repos/premake/premake-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/premake/premake-core/pulls/1070/commits"},"statuses":{"href":"https://api.github.com/repos/premake/premake-core/statuses/63a83af8446de27bb9b255bc8b681de1c288835a"}},"author_association":"NONE"}}
{"actor":{"display_login":"samsinsane"}}