{"action":"created","issue":{"url":"https://api.github.com/repos/SpiNNakerManchester/SpiNNFrontEndCommon/issues/364","repository_url":"https://api.github.com/repos/SpiNNakerManchester/SpiNNFrontEndCommon","labels_url":"https://api.github.com/repos/SpiNNakerManchester/SpiNNFrontEndCommon/issues/364/labels{/name}","comments_url":"https://api.github.com/repos/SpiNNakerManchester/SpiNNFrontEndCommon/issues/364/comments","events_url":"https://api.github.com/repos/SpiNNakerManchester/SpiNNFrontEndCommon/issues/364/events","html_url":"https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/issues/364","id":373844198,"node_id":"MDU6SXNzdWUzNzM4NDQxOTg=","number":364,"title":"duplicated code in reocrding.c","user":{"login":"alan-stokes","id":7520968,"node_id":"MDQ6VXNlcjc1MjA5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/7520968?v=4","gravatar_id":"","url":"https://api.github.com/users/alan-stokes","html_url":"https://github.com/alan-stokes","followers_url":"https://api.github.com/users/alan-stokes/followers","following_url":"https://api.github.com/users/alan-stokes/following{/other_user}","gists_url":"https://api.github.com/users/alan-stokes/gists{/gist_id}","starred_url":"https://api.github.com/users/alan-stokes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan-stokes/subscriptions","organizations_url":"https://api.github.com/users/alan-stokes/orgs","repos_url":"https://api.github.com/users/alan-stokes/repos","events_url":"https://api.github.com/users/alan-stokes/events{/privacy}","received_events_url":"https://api.github.com/users/alan-stokes/received_events","type":"User","site_admin":false},"labels":[{"id":144490156,"node_id":"MDU6TGFiZWwxNDQ0OTAxNTY=","url":"https://api.github.com/repos/SpiNNakerManchester/SpiNNFrontEndCommon/labels/bug","name":"bug","color":"fc2929","default":true},{"id":144490158,"node_id":"MDU6TGFiZWwxNDQ0OTAxNTg=","url":"https://api.github.com/repos/SpiNNakerManchester/SpiNNFrontEndCommon/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"Christian-B","id":548453,"node_id":"MDQ6VXNlcjU0ODQ1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/548453?v=4","gravatar_id":"","url":"https://api.github.com/users/Christian-B","html_url":"https://github.com/Christian-B","followers_url":"https://api.github.com/users/Christian-B/followers","following_url":"https://api.github.com/users/Christian-B/following{/other_user}","gists_url":"https://api.github.com/users/Christian-B/gists{/gist_id}","starred_url":"https://api.github.com/users/Christian-B/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Christian-B/subscriptions","organizations_url":"https://api.github.com/users/Christian-B/orgs","repos_url":"https://api.github.com/users/Christian-B/repos","events_url":"https://api.github.com/users/Christian-B/events{/privacy}","received_events_url":"https://api.github.com/users/Christian-B/received_events","type":"User","site_admin":false},"assignees":[{"login":"Christian-B","id":548453,"node_id":"MDQ6VXNlcjU0ODQ1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/548453?v=4","gravatar_id":"","url":"https://api.github.com/users/Christian-B","html_url":"https://github.com/Christian-B","followers_url":"https://api.github.com/users/Christian-B/followers","following_url":"https://api.github.com/users/Christian-B/following{/other_user}","gists_url":"https://api.github.com/users/Christian-B/gists{/gist_id}","starred_url":"https://api.github.com/users/Christian-B/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Christian-B/subscriptions","organizations_url":"https://api.github.com/users/Christian-B/orgs","repos_url":"https://api.github.com/users/Christian-B/repos","events_url":"https://api.github.com/users/Christian-B/events{/privacy}","received_events_url":"https://api.github.com/users/Christian-B/received_events","type":"User","site_admin":false},{"login":"rowleya","id":7584931,"node_id":"MDQ6VXNlcjc1ODQ5MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/7584931?v=4","gravatar_id":"","url":"https://api.github.com/users/rowleya","html_url":"https://github.com/rowleya","followers_url":"https://api.github.com/users/rowleya/followers","following_url":"https://api.github.com/users/rowleya/following{/other_user}","gists_url":"https://api.github.com/users/rowleya/gists{/gist_id}","starred_url":"https://api.github.com/users/rowleya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rowleya/subscriptions","organizations_url":"https://api.github.com/users/rowleya/orgs","repos_url":"https://api.github.com/users/rowleya/repos","events_url":"https://api.github.com/users/rowleya/events{/privacy}","received_events_url":"https://api.github.com/users/rowleya/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/SpiNNakerManchester/SpiNNFrontEndCommon/milestones/14","html_url":"https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/milestone/14","labels_url":"https://api.github.com/repos/SpiNNakerManchester/SpiNNFrontEndCommon/milestones/14/labels","id":2732619,"node_id":"MDk6TWlsZXN0b25lMjczMjYxOQ==","number":14,"title":"5.0.0","description":null,"creator":{"login":"alan-stokes","id":7520968,"node_id":"MDQ6VXNlcjc1MjA5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/7520968?v=4","gravatar_id":"","url":"https://api.github.com/users/alan-stokes","html_url":"https://github.com/alan-stokes","followers_url":"https://api.github.com/users/alan-stokes/followers","following_url":"https://api.github.com/users/alan-stokes/following{/other_user}","gists_url":"https://api.github.com/users/alan-stokes/gists{/gist_id}","starred_url":"https://api.github.com/users/alan-stokes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan-stokes/subscriptions","organizations_url":"https://api.github.com/users/alan-stokes/orgs","repos_url":"https://api.github.com/users/alan-stokes/repos","events_url":"https://api.github.com/users/alan-stokes/events{/privacy}","received_events_url":"https://api.github.com/users/alan-stokes/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":72,"state":"open","created_at":"2017-08-30T12:56:14Z","updated_at":"2018-10-25T17:54:16Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-10-25T09:04:01Z","updated_at":"2018-10-26T08:19:12Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/blob/master/c_common/front_end_common_lib/src/recording.c#L77-L85\r\n\r\nand this method which is no longer being used and i fear no longer works with the new process. the private method needs to replace the public method. \r\n\r\nhttps://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/blob/master/c_common/front_end_common_lib/include/recording.h#L52-L59\r\n"},"comment":{"url":"https://api.github.com/repos/SpiNNakerManchester/SpiNNFrontEndCommon/issues/comments/433327514","html_url":"https://github.com/SpiNNakerManchester/SpiNNFrontEndCommon/issues/364#issuecomment-433327514","issue_url":"https://api.github.com/repos/SpiNNakerManchester/SpiNNFrontEndCommon/issues/364","id":433327514,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzMyNzUxNA==","user":{"login":"alan-stokes","id":7520968,"node_id":"MDQ6VXNlcjc1MjA5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/7520968?v=4","gravatar_id":"","url":"https://api.github.com/users/alan-stokes","html_url":"https://github.com/alan-stokes","followers_url":"https://api.github.com/users/alan-stokes/followers","following_url":"https://api.github.com/users/alan-stokes/following{/other_user}","gists_url":"https://api.github.com/users/alan-stokes/gists{/gist_id}","starred_url":"https://api.github.com/users/alan-stokes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alan-stokes/subscriptions","organizations_url":"https://api.github.com/users/alan-stokes/orgs","repos_url":"https://api.github.com/users/alan-stokes/repos","events_url":"https://api.github.com/users/alan-stokes/events{/privacy}","received_events_url":"https://api.github.com/users/alan-stokes/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T08:19:12Z","updated_at":"2018-10-26T08:19:12Z","author_association":"CONTRIBUTOR","body":"well having the recording flags seems only to be to support the .h call. The .c call seems to be the current way the recording api operates. So having that as a private method when it could replace the .h one and remove the recording flags..... id do it, less things to go wrong. "}}
{"actor":{"display_login":"alan-stokes"}}