{"action":"created","comment":{"url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/comments/226483563","pull_request_review_id":166317994,"id":226483563,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjQ4MzU2Mw==","diff_hunk":"@@ -0,0 +1,69 @@\n+/*\n+ * Copyright 2013-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"). You may not use this file except in compliance with\n+ * the License. A copy of the License is located at\n+ *\n+ * http://aws.amazon.com/apache2.0\n+ *\n+ * or in the \"license\" file accompanying this file. This file is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR\n+ * CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions\n+ * and limitations under the License.\n+ */\n+\n+package software.amazon.awssdk.regions;\n+\n+import java.util.AbstractMap;\n+import java.util.Collections;\n+import java.util.Map;\n+import java.util.stream.Collectors;\n+import java.util.stream.Stream;\n+import software.amazon.awssdk.annotations.Generated;\n+import software.amazon.awssdk.annotations.SdkPublicApi;\n+import software.amazon.awssdk.regions.regionmetadata.ApNortheast1;\n+import software.amazon.awssdk.regions.regionmetadata.ApNortheast2;\n+import software.amazon.awssdk.regions.regionmetadata.ApSouth1;\n+import software.amazon.awssdk.regions.regionmetadata.ApSoutheast1;\n+import software.amazon.awssdk.regions.regionmetadata.ApSoutheast2;\n+import software.amazon.awssdk.regions.regionmetadata.CaCentral1;\n+import software.amazon.awssdk.regions.regionmetadata.CnNorth1;\n+import software.amazon.awssdk.regions.regionmetadata.CnNorthwest1;\n+import software.amazon.awssdk.regions.regionmetadata.EuCentral1;\n+import software.amazon.awssdk.regions.regionmetadata.EuWest1;\n+import software.amazon.awssdk.regions.regionmetadata.EuWest2;\n+import software.amazon.awssdk.regions.regionmetadata.EuWest3;\n+import software.amazon.awssdk.regions.regionmetadata.SaEast1;\n+import software.amazon.awssdk.regions.regionmetadata.UsEast1;\n+import software.amazon.awssdk.regions.regionmetadata.UsEast2;\n+import software.amazon.awssdk.regions.regionmetadata.UsGovWest1;\n+import software.amazon.awssdk.regions.regionmetadata.UsWest1;\n+import software.amazon.awssdk.regions.regionmetadata.UsWest2;\n+\n+@Generated(\"software.amazon.awssdk:codegen\")\n+@SdkPublicApi\n+public final class RegionMetadataProvider {","path":"codegen-lite/src/test/resources/software/amazon/awssdk/codegen/lite/regions/region-metadata-provider.java","position":44,"original_position":44,"commit_id":"e7ea5087b3c3244cfd5f250ca43ad9fb168c61e5","original_commit_id":"e7ea5087b3c3244cfd5f250ca43ad9fb168c61e5","user":{"login":"spfink","id":20525381,"node_id":"MDQ6VXNlcjIwNTI1Mzgx","avatar_url":"https://avatars1.githubusercontent.com/u/20525381?v=4","gravatar_id":"","url":"https://api.github.com/users/spfink","html_url":"https://github.com/spfink","followers_url":"https://api.github.com/users/spfink/followers","following_url":"https://api.github.com/users/spfink/following{/other_user}","gists_url":"https://api.github.com/users/spfink/gists{/gist_id}","starred_url":"https://api.github.com/users/spfink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spfink/subscriptions","organizations_url":"https://api.github.com/users/spfink/orgs","repos_url":"https://api.github.com/users/spfink/repos","events_url":"https://api.github.com/users/spfink/events{/privacy}","received_events_url":"https://api.github.com/users/spfink/received_events","type":"User","site_admin":false},"body":"Makes sense. Will do.","created_at":"2018-10-18T22:17:26Z","updated_at":"2018-10-18T22:17:26Z","html_url":"https://github.com/aws/aws-sdk-java-v2/pull/759#discussion_r226483563","pull_request_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/759","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/comments/226483563"},"html":{"href":"https://github.com/aws/aws-sdk-java-v2/pull/759#discussion_r226483563"},"pull_request":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/759"}},"in_reply_to_id":226482411},"pull_request":{"url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/759","id":222986499,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTg2NDk5","html_url":"https://github.com/aws/aws-sdk-java-v2/pull/759","diff_url":"https://github.com/aws/aws-sdk-java-v2/pull/759.diff","patch_url":"https://github.com/aws/aws-sdk-java-v2/pull/759.patch","issue_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/759","number":759,"state":"open","locked":false,"title":"Generation region/service metadata","user":{"login":"spfink","id":20525381,"node_id":"MDQ6VXNlcjIwNTI1Mzgx","avatar_url":"https://avatars1.githubusercontent.com/u/20525381?v=4","gravatar_id":"","url":"https://api.github.com/users/spfink","html_url":"https://github.com/spfink","followers_url":"https://api.github.com/users/spfink/followers","following_url":"https://api.github.com/users/spfink/following{/other_user}","gists_url":"https://api.github.com/users/spfink/gists{/gist_id}","starred_url":"https://api.github.com/users/spfink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spfink/subscriptions","organizations_url":"https://api.github.com/users/spfink/orgs","repos_url":"https://api.github.com/users/spfink/repos","events_url":"https://api.github.com/users/spfink/events{/privacy}","received_events_url":"https://api.github.com/users/spfink/received_events","type":"User","site_admin":false},"body":"Introduces two new modules, codegen-lite and codegen-lite-maven-plugin in order to be able to generate region and service metadata for the regions module. \r\n\r\nCould also refactor codegen-lite into codegen-core and move the core non-service related codegen files to this module \r\n\r\n```java\r\n@Generated(\"software.amazon.awssdk:codegen\")\r\n@SdkPublicApi\r\npublic final class Batch implements ServiceMetadata {\r\n    private static final String ENDPOINT_PREFIX = \"batch\";\r\n\r\n    private static final Map<String, String> REGION_OVERRIDDEN_ENDPOINTS = new HashMap();\r\n\r\n    private static final List<Region> REGIONS = Collections.unmodifiableList(Arrays.asList(Region.AP_NORTHEAST_1,\r\n            Region.AP_NORTHEAST_2, Region.AP_SOUTH_1, Region.AP_SOUTHEAST_1, Region.AP_SOUTHEAST_2, Region.CA_CENTRAL_1,\r\n            Region.EU_CENTRAL_1, Region.EU_WEST_1, Region.EU_WEST_2, Region.EU_WEST_3, Region.SA_EAST_1, Region.US_EAST_1,\r\n            Region.US_EAST_2, Region.US_WEST_1, Region.US_WEST_2));\r\n\r\n    private static final Map<String, String> SIGNING_REGION_OVERRIDES = new HashMap();\r\n\r\n    @Override\r\n    public List<Region> regions() {\r\n        return REGIONS;\r\n    }\r\n\r\n    @Override\r\n    public URI endpointFor(Region region) {\r\n        return URI.create(REGION_OVERRIDDEN_ENDPOINTS.getOrDefault(region.id(), computeEndpoint(ENDPOINT_PREFIX, region)));\r\n    }\r\n\r\n    @Override\r\n    public Region signingRegion(Region region) {\r\n        return Region.of(SIGNING_REGION_OVERRIDES.getOrDefault(region.id(), region.id()));\r\n    }\r\n}\r\n```\r\n```java\r\n@Generated(\"software.amazon.awssdk:codegen\")\r\n@SdkPublicApi\r\npublic final class UsEast1 implements RegionMetadata {\r\n    private static final String ID = \"us-east-1\";\r\n\r\n    private static final String DOMAIN = \"amazonaws.com\";\r\n\r\n    private static final String NAME = \"US East (N. Virginia)\";\r\n\r\n    private static final String PARTITION = \"aws\";\r\n\r\n    public String name() {\r\n        return NAME;\r\n    }\r\n\r\n    public String domain() {\r\n        return DOMAIN;\r\n    }\r\n\r\n    public String id() {\r\n        return ID;\r\n    }\r\n\r\n    public String partition() {\r\n        return PARTITION;\r\n    }\r\n}\r\n```","created_at":"2018-10-15T17:37:42Z","updated_at":"2018-10-18T22:17:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"185da1ca8e054172a1f04d8966dd52f136ff3809","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/759/commits","review_comments_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/759/comments","review_comment_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/759/comments","statuses_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/statuses/e7ea5087b3c3244cfd5f250ca43ad9fb168c61e5","head":{"label":"aws:finks/region-metadata-generation","ref":"finks/region-metadata-generation","sha":"e7ea5087b3c3244cfd5f250ca43ad9fb168c61e5","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":95247959,"node_id":"MDEwOlJlcG9zaXRvcnk5NTI0Nzk1OQ==","name":"aws-sdk-java-v2","full_name":"aws/aws-sdk-java-v2","private":false,"owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws/aws-sdk-java-v2","description":"The official AWS SDK for Java - Version 2 (Developer Preview)","fork":false,"url":"https://api.github.com/repos/aws/aws-sdk-java-v2","forks_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/forks","keys_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/teams","hooks_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/events","assignees_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/tags","blobs_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/languages","stargazers_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/subscription","commits_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/merges","archive_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/downloads","issues_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/releases{/id}","deployments_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/deployments","created_at":"2017-06-23T18:56:01Z","updated_at":"2018-10-18T19:46:12Z","pushed_at":"2018-10-18T21:46:06Z","git_url":"git://github.com/aws/aws-sdk-java-v2.git","ssh_url":"git@github.com:aws/aws-sdk-java-v2.git","clone_url":"https://github.com/aws/aws-sdk-java-v2.git","svn_url":"https://github.com/aws/aws-sdk-java-v2","homepage":"","size":14899,"stargazers_count":288,"watchers_count":288,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":130,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":72,"open_issues":130,"watchers":288,"default_branch":"master"}},"base":{"label":"aws:master","ref":"master","sha":"38679273a6782b72f7d6b8f47e16f8738e216d5f","user":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":95247959,"node_id":"MDEwOlJlcG9zaXRvcnk5NTI0Nzk1OQ==","name":"aws-sdk-java-v2","full_name":"aws/aws-sdk-java-v2","private":false,"owner":{"login":"aws","id":2232217,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMzIyMTc=","avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aws/aws-sdk-java-v2","description":"The official AWS SDK for Java - Version 2 (Developer Preview)","fork":false,"url":"https://api.github.com/repos/aws/aws-sdk-java-v2","forks_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/forks","keys_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/teams","hooks_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/hooks","issue_events_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/events{/number}","events_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/events","assignees_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/assignees{/user}","branches_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/branches{/branch}","tags_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/tags","blobs_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/languages","stargazers_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/stargazers","contributors_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/contributors","subscribers_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/subscribers","subscription_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/subscription","commits_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/contents/{+path}","compare_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/merges","archive_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/downloads","issues_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues{/number}","pulls_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/labels{/name}","releases_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/releases{/id}","deployments_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/deployments","created_at":"2017-06-23T18:56:01Z","updated_at":"2018-10-18T19:46:12Z","pushed_at":"2018-10-18T21:46:06Z","git_url":"git://github.com/aws/aws-sdk-java-v2.git","ssh_url":"git@github.com:aws/aws-sdk-java-v2.git","clone_url":"https://github.com/aws/aws-sdk-java-v2.git","svn_url":"https://github.com/aws/aws-sdk-java-v2","homepage":"","size":14899,"stargazers_count":288,"watchers_count":288,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":130,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":72,"open_issues":130,"watchers":288,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/759"},"html":{"href":"https://github.com/aws/aws-sdk-java-v2/pull/759"},"issue":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/759"},"comments":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/759/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/759/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/759/commits"},"statuses":{"href":"https://api.github.com/repos/aws/aws-sdk-java-v2/statuses/e7ea5087b3c3244cfd5f250ca43ad9fb168c61e5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"spfink"}}