{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/autorest.typescript/pulls/comments/213516714","pull_request_review_id":150369638,"id":213516714,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzUxNjcxNA==","diff_hunk":"@@ -85,13 +85,18 @@ class AzureCompositeModel extends AzureCompositeModelContext {\n    *\n    * @reject {Error|ServiceError} The error object.\n    */\n-  listWithHttpOperationResponse(resourceGroupName: string, options?: msRest.RequestOptionsBase): Promise<Models.ListResponse> {\n+  list(resourceGroupName: string): Promise<Models.ListResponse>;\n+  list(resourceGroupName: string, options: msRest.RequestOptionsBase): Promise<Models.ListResponse>;\n+  list(resourceGroupName: string, callback: msRest.ServiceCallback<Models.CatalogArray>): void;","path":"test/azure/generated/AzureCompositeModelClient/azureCompositeModel.ts","position":7,"original_position":7,"commit_id":"f830e9aa8c07a38438db9e8abbed55addad663f0","original_commit_id":"f830e9aa8c07a38438db9e8abbed55addad663f0","user":{"login":"RikkiGibson","id":5833655,"node_id":"MDQ6VXNlcjU4MzM2NTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5833655?v=4","gravatar_id":"","url":"https://api.github.com/users/RikkiGibson","html_url":"https://github.com/RikkiGibson","followers_url":"https://api.github.com/users/RikkiGibson/followers","following_url":"https://api.github.com/users/RikkiGibson/following{/other_user}","gists_url":"https://api.github.com/users/RikkiGibson/gists{/gist_id}","starred_url":"https://api.github.com/users/RikkiGibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RikkiGibson/subscriptions","organizations_url":"https://api.github.com/users/RikkiGibson/orgs","repos_url":"https://api.github.com/users/RikkiGibson/repos","events_url":"https://api.github.com/users/RikkiGibson/events{/privacy}","received_events_url":"https://api.github.com/users/RikkiGibson/received_events","type":"User","site_admin":false},"body":"remaining design decision: should the ServiceCallback receive only the original body, or should it get the new flattened response value? Keeping in mind that the HttpOperationResponse is still available by defining additional parameters on the callback.","created_at":"2018-08-29T00:56:17Z","updated_at":"2018-08-29T00:56:17Z","html_url":"https://github.com/Azure/autorest.typescript/pull/263#discussion_r213516714","pull_request_url":"https://api.github.com/repos/Azure/autorest.typescript/pulls/263","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/autorest.typescript/pulls/comments/213516714"},"html":{"href":"https://github.com/Azure/autorest.typescript/pull/263#discussion_r213516714"},"pull_request":{"href":"https://api.github.com/repos/Azure/autorest.typescript/pulls/263"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/autorest.typescript/pulls/263","id":211576962,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTc2OTYy","html_url":"https://github.com/Azure/autorest.typescript/pull/263","diff_url":"https://github.com/Azure/autorest.typescript/pull/263.diff","patch_url":"https://github.com/Azure/autorest.typescript/pull/263.patch","issue_url":"https://api.github.com/repos/Azure/autorest.typescript/issues/263","number":263,"state":"open","locked":false,"title":"Response flattening","user":{"login":"RikkiGibson","id":5833655,"node_id":"MDQ6VXNlcjU4MzM2NTU=","avatar_url":"https://avatars2.githubusercontent.com/u/5833655?v=4","gravatar_id":"","url":"https://api.github.com/users/RikkiGibson","html_url":"https://github.com/RikkiGibson","followers_url":"https://api.github.com/users/RikkiGibson/followers","following_url":"https://api.github.com/users/RikkiGibson/following{/other_user}","gists_url":"https://api.github.com/users/RikkiGibson/gists{/gist_id}","starred_url":"https://api.github.com/users/RikkiGibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RikkiGibson/subscriptions","organizations_url":"https://api.github.com/users/RikkiGibson/orgs","repos_url":"https://api.github.com/users/RikkiGibson/repos","events_url":"https://api.github.com/users/RikkiGibson/events{/privacy}","received_events_url":"https://api.github.com/users/RikkiGibson/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-28T22:28:25Z","updated_at":"2018-08-29T00:56:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a77a0241217863074f902c6990b4a8411db9ecc9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"daschult","id":7052303,"node_id":"MDQ6VXNlcjcwNTIzMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7052303?v=4","gravatar_id":"","url":"https://api.github.com/users/daschult","html_url":"https://github.com/daschult","followers_url":"https://api.github.com/users/daschult/followers","following_url":"https://api.github.com/users/daschult/following{/other_user}","gists_url":"https://api.github.com/users/daschult/gists{/gist_id}","starred_url":"https://api.github.com/users/daschult/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschult/subscriptions","organizations_url":"https://api.github.com/users/daschult/orgs","repos_url":"https://api.github.com/users/daschult/repos","events_url":"https://api.github.com/users/daschult/events{/privacy}","received_events_url":"https://api.github.com/users/daschult/received_events","type":"User","site_admin":false},{"login":"kpajdzik","id":41709775,"node_id":"MDQ6VXNlcjQxNzA5Nzc1","avatar_url":"https://avatars3.githubusercontent.com/u/41709775?v=4","gravatar_id":"","url":"https://api.github.com/users/kpajdzik","html_url":"https://github.com/kpajdzik","followers_url":"https://api.github.com/users/kpajdzik/followers","following_url":"https://api.github.com/users/kpajdzik/following{/other_user}","gists_url":"https://api.github.com/users/kpajdzik/gists{/gist_id}","starred_url":"https://api.github.com/users/kpajdzik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpajdzik/subscriptions","organizations_url":"https://api.github.com/users/kpajdzik/orgs","repos_url":"https://api.github.com/users/kpajdzik/repos","events_url":"https://api.github.com/users/kpajdzik/events{/privacy}","received_events_url":"https://api.github.com/users/kpajdzik/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":874065322,"node_id":"MDU6TGFiZWw4NzQwNjUzMjI=","url":"https://api.github.com/repos/Azure/autorest.typescript/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/autorest.typescript/pulls/263/commits","review_comments_url":"https://api.github.com/repos/Azure/autorest.typescript/pulls/263/comments","review_comment_url":"https://api.github.com/repos/Azure/autorest.typescript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/autorest.typescript/issues/263/comments","statuses_url":"https://api.github.com/repos/Azure/autorest.typescript/statuses/f830e9aa8c07a38438db9e8abbed55addad663f0","head":{"label":"Azure:response-flattening","ref":"response-flattening","sha":"f830e9aa8c07a38438db9e8abbed55addad663f0","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":101261687,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyNjE2ODc=","name":"autorest.typescript","full_name":"Azure/autorest.typescript","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/autorest.typescript","description":"Extension for AutoRest (https://github.com/Azure/autorest) that generates TypeScript code. The transpiled javascript code is isomorphic. It can be run in browser and in node.js environment.","fork":false,"url":"https://api.github.com/repos/Azure/autorest.typescript","forks_url":"https://api.github.com/repos/Azure/autorest.typescript/forks","keys_url":"https://api.github.com/repos/Azure/autorest.typescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/autorest.typescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/autorest.typescript/teams","hooks_url":"https://api.github.com/repos/Azure/autorest.typescript/hooks","issue_events_url":"https://api.github.com/repos/Azure/autorest.typescript/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/autorest.typescript/events","assignees_url":"https://api.github.com/repos/Azure/autorest.typescript/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/autorest.typescript/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/autorest.typescript/tags","blobs_url":"https://api.github.com/repos/Azure/autorest.typescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/autorest.typescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/autorest.typescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/autorest.typescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/autorest.typescript/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/autorest.typescript/languages","stargazers_url":"https://api.github.com/repos/Azure/autorest.typescript/stargazers","contributors_url":"https://api.github.com/repos/Azure/autorest.typescript/contributors","subscribers_url":"https://api.github.com/repos/Azure/autorest.typescript/subscribers","subscription_url":"https://api.github.com/repos/Azure/autorest.typescript/subscription","commits_url":"https://api.github.com/repos/Azure/autorest.typescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/autorest.typescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/autorest.typescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/autorest.typescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/autorest.typescript/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/autorest.typescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/autorest.typescript/merges","archive_url":"https://api.github.com/repos/Azure/autorest.typescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/autorest.typescript/downloads","issues_url":"https://api.github.com/repos/Azure/autorest.typescript/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/autorest.typescript/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/autorest.typescript/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/autorest.typescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/autorest.typescript/labels{/name}","releases_url":"https://api.github.com/repos/Azure/autorest.typescript/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/autorest.typescript/deployments","created_at":"2017-08-24T06:29:08Z","updated_at":"2018-08-28T17:16:16Z","pushed_at":"2018-08-29T00:19:39Z","git_url":"git://github.com/Azure/autorest.typescript.git","ssh_url":"git@github.com:Azure/autorest.typescript.git","clone_url":"https://github.com/Azure/autorest.typescript.git","svn_url":"https://github.com/Azure/autorest.typescript","homepage":"","size":5019,"stargazers_count":22,"watchers_count":22,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":22,"watchers":22,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"598c841301ad131cbef2a1e33c27cbd97744d2ad","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":101261687,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEyNjE2ODc=","name":"autorest.typescript","full_name":"Azure/autorest.typescript","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/autorest.typescript","description":"Extension for AutoRest (https://github.com/Azure/autorest) that generates TypeScript code. The transpiled javascript code is isomorphic. It can be run in browser and in node.js environment.","fork":false,"url":"https://api.github.com/repos/Azure/autorest.typescript","forks_url":"https://api.github.com/repos/Azure/autorest.typescript/forks","keys_url":"https://api.github.com/repos/Azure/autorest.typescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/autorest.typescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/autorest.typescript/teams","hooks_url":"https://api.github.com/repos/Azure/autorest.typescript/hooks","issue_events_url":"https://api.github.com/repos/Azure/autorest.typescript/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/autorest.typescript/events","assignees_url":"https://api.github.com/repos/Azure/autorest.typescript/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/autorest.typescript/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/autorest.typescript/tags","blobs_url":"https://api.github.com/repos/Azure/autorest.typescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/autorest.typescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/autorest.typescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/autorest.typescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/autorest.typescript/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/autorest.typescript/languages","stargazers_url":"https://api.github.com/repos/Azure/autorest.typescript/stargazers","contributors_url":"https://api.github.com/repos/Azure/autorest.typescript/contributors","subscribers_url":"https://api.github.com/repos/Azure/autorest.typescript/subscribers","subscription_url":"https://api.github.com/repos/Azure/autorest.typescript/subscription","commits_url":"https://api.github.com/repos/Azure/autorest.typescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/autorest.typescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/autorest.typescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/autorest.typescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/autorest.typescript/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/autorest.typescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/autorest.typescript/merges","archive_url":"https://api.github.com/repos/Azure/autorest.typescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/autorest.typescript/downloads","issues_url":"https://api.github.com/repos/Azure/autorest.typescript/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/autorest.typescript/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/autorest.typescript/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/autorest.typescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/autorest.typescript/labels{/name}","releases_url":"https://api.github.com/repos/Azure/autorest.typescript/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/autorest.typescript/deployments","created_at":"2017-08-24T06:29:08Z","updated_at":"2018-08-28T17:16:16Z","pushed_at":"2018-08-29T00:19:39Z","git_url":"git://github.com/Azure/autorest.typescript.git","ssh_url":"git@github.com:Azure/autorest.typescript.git","clone_url":"https://github.com/Azure/autorest.typescript.git","svn_url":"https://github.com/Azure/autorest.typescript","homepage":"","size":5019,"stargazers_count":22,"watchers_count":22,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":22,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/autorest.typescript/pulls/263"},"html":{"href":"https://github.com/Azure/autorest.typescript/pull/263"},"issue":{"href":"https://api.github.com/repos/Azure/autorest.typescript/issues/263"},"comments":{"href":"https://api.github.com/repos/Azure/autorest.typescript/issues/263/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/autorest.typescript/pulls/263/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/autorest.typescript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/autorest.typescript/pulls/263/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/autorest.typescript/statuses/f830e9aa8c07a38438db9e8abbed55addad663f0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"RikkiGibson"}}