{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71033","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71033/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71033/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71033/events","html_url":"https://github.com/kubernetes/kubernetes/pull/71033","id":380646369,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNzk0MDA3","number":71033,"title":"Forbid inter unstructured conversion in default converter","user":{"login":"yue9944882","id":12049380,"node_id":"MDQ6VXNlcjEyMDQ5Mzgw","avatar_url":"https://avatars1.githubusercontent.com/u/12049380?v=4","gravatar_id":"","url":"https://api.github.com/users/yue9944882","html_url":"https://github.com/yue9944882","followers_url":"https://api.github.com/users/yue9944882/followers","following_url":"https://api.github.com/users/yue9944882/following{/other_user}","gists_url":"https://api.github.com/users/yue9944882/gists{/gist_id}","starred_url":"https://api.github.com/users/yue9944882/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yue9944882/subscriptions","organizations_url":"https://api.github.com/users/yue9944882/orgs","repos_url":"https://api.github.com/users/yue9944882/repos","events_url":"https://api.github.com/users/yue9944882/events{/privacy}","received_events_url":"https://api.github.com/users/yue9944882/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":349530249,"node_id":"MDU6TGFiZWwzNDk1MzAyNDk=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":253450793,"node_id":"MDU6TGFiZWwyNTM0NTA3OTM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-14T11:03:10Z","updated_at":"2018-11-14T11:09:34Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/71033","html_url":"https://github.com/kubernetes/kubernetes/pull/71033","diff_url":"https://github.com/kubernetes/kubernetes/pull/71033.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/71033.patch"},"body":"today, the default converter allows any conversion between unstructured objects via this reflection equality check. but unstructured converion itself is not making sense. this pull explicitly forbids that usage. \r\n\r\n[https://github.com/kubernetes/kubernetes/blob/a44c2b9eeb745c0d4b56e5058859743f5ef5ef69/staging/src/k8s.io/apimachinery/pkg/runtime/scheme.go#L116-L134](https://github.com/kubernetes/kubernetes/blob/a44c2b9eeb745c0d4b56e5058859743f5ef5ef69/staging/src/k8s.io/apimachinery/pkg/runtime/scheme.go#L116-L134)\r\n\r\nnote that for CR, we have another dedicated convertor so the default convertor won't do any inter-unstructured conversion there. \r\n\r\n/sig api-machinery\r\n/kind bug\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n<!--  \r\nIf no, just write \"NONE\".\r\nIf yes, a release note is required:\r\nEnter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. \r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/438625847","html_url":"https://github.com/kubernetes/kubernetes/pull/71033#issuecomment-438625847","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/71033","id":438625847,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODYyNTg0Nw==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-11-14T11:09:34Z","updated_at":"2018-11-14T11:09:34Z","author_association":"CONTRIBUTOR","body":"@yue9944882: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-node-e2e | 792e6c611826de3a0c57685f0a550f8e05a40de2 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/71033/pull-kubernetes-node-e2e/111515/) | `/test pull-kubernetes-node-e2e`\npull-kubernetes-bazel-build | 792e6c611826de3a0c57685f0a550f8e05a40de2 | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/71033/pull-kubernetes-bazel-build/65023/) | `/test pull-kubernetes-bazel-build`\n\n[Full PR test history](https://gubernator.k8s.io/pr/71033). [Your PR dashboard](https://gubernator.k8s.io/pr/yue9944882). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}