{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/32713","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/32713/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/32713/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/32713/events","html_url":"https://github.com/cockroachdb/cockroach/pull/32713","id":385717337,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NjIyNTM4","number":32713,"title":"sql: prevent a crash and add telemetry for an assertion","user":{"login":"knz","id":642886,"node_id":"MDQ6VXNlcjY0Mjg4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/642886?v=4","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-29T12:38:30Z","updated_at":"2018-11-30T12:11:46Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/32713","html_url":"https://github.com/cockroachdb/cockroach/pull/32713","diff_url":"https://github.com/cockroachdb/cockroach/pull/32713.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/32713.patch"},"body":"Informs  #32517.\r\n\r\nWe got reports in the wild that CockroachDB crashes upon SHOW\r\nSESSIONS/QUERIES due to an invalid session ID in a ListSessions\r\nresponse.\r\n\r\nAn invalid session ID should never happen; also conceptually it makes\r\nno sense because if a session exists (insofar that it gets reported by\r\nListsessions) it must hav ean ID.\r\n\r\nHowever I was not able to find how an invalid session ID could be\r\ncreated, if at all. So the root cause of the problem remains\r\nuncovered.\r\n\r\nIn the meantime, this patch prevents a crash when encountering an\r\ninvalid session ID. nil entries are transformed to SQL NULLs, and\r\nnon-nil entries with a non-16 size are reported as `<invalid>`. Also\r\nthe values are recorded and reported in telemetry.\r\n\r\nRelease note (bug fix): CockroachDB does not longer crash when\r\nencountering an internal error related to invalid entries in the\r\noutput of SHOW SESSIONs."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/443185842","html_url":"https://github.com/cockroachdb/cockroach/pull/32713#issuecomment-443185842","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/32713","id":443185842,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzE4NTg0Mg==","user":{"login":"knz","id":642886,"node_id":"MDQ6VXNlcjY0Mjg4Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/642886?v=4","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"created_at":"2018-11-30T12:11:46Z","updated_at":"2018-11-30T12:11:46Z","author_association":"MEMBER","body":"oh now it's done.\r\n\r\nbors r+"}}
{"actor":{"display_login":"knz"}}