{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/190759122","pull_request_review_id":122782415,"id":190759122,"diff_hunk":"@@ -311,6 +318,22 @@ EffectButtonParameterSlotPointer EffectsManager::getEffectButtonParameterSlot(\n     return pParameterSlot;\n }\n \n+void EffectsManager::setEffectVisibility(EffectManifestPointer pManifest, bool visible) {\n+    if (visible && !m_visibleEffectManifests.contains(pManifest)) {\n+        auto insertion_point = std::lower_bound(m_visibleEffectManifests.begin(),\n+                                                m_visibleEffectManifests.end(),\n+                                                pManifest, alphabetizeEffectManifests);\n+        m_visibleEffectManifests.insert(insertion_point, pManifest);\n+        emit visibleEffectsUpdated();","path":"src/effects/effectsmanager.cpp","position":49,"original_position":46,"commit_id":"72b1f91d4365cbc8319741c7c4205da7d4b5cefa","original_commit_id":"92acfe0f134ad0132f9312c4f43bf1ede3bf48cb","user":{"login":"Be-ing","id":9455094,"avatar_url":"https://avatars3.githubusercontent.com/u/9455094?v=4","gravatar_id":"","url":"https://api.github.com/users/Be-ing","html_url":"https://github.com/Be-ing","followers_url":"https://api.github.com/users/Be-ing/followers","following_url":"https://api.github.com/users/Be-ing/following{/other_user}","gists_url":"https://api.github.com/users/Be-ing/gists{/gist_id}","starred_url":"https://api.github.com/users/Be-ing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Be-ing/subscriptions","organizations_url":"https://api.github.com/users/Be-ing/orgs","repos_url":"https://api.github.com/users/Be-ing/repos","events_url":"https://api.github.com/users/Be-ing/events{/privacy}","received_events_url":"https://api.github.com/users/Be-ing/received_events","type":"User","site_admin":false},"body":"Hmm, I thought you needed parentheses around the signal name: `emit(visibleEffectsUpdated())`","created_at":"2018-05-24T23:38:44Z","updated_at":"2018-05-24T23:44:57Z","html_url":"https://github.com/mixxxdj/mixxx/pull/1674#discussion_r190759122","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1674","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/190759122"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1674#discussion_r190759122"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1674"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1674","id":189231680,"html_url":"https://github.com/mixxxdj/mixxx/pull/1674","diff_url":"https://github.com/mixxxdj/mixxx/pull/1674.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1674.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1674","number":1674,"state":"open","locked":false,"title":"Effect Blacklisting","user":{"login":"kshitij98","id":12982388,"avatar_url":"https://avatars0.githubusercontent.com/u/12982388?v=4","gravatar_id":"","url":"https://api.github.com/users/kshitij98","html_url":"https://github.com/kshitij98","followers_url":"https://api.github.com/users/kshitij98/followers","following_url":"https://api.github.com/users/kshitij98/following{/other_user}","gists_url":"https://api.github.com/users/kshitij98/gists{/gist_id}","starred_url":"https://api.github.com/users/kshitij98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshitij98/subscriptions","organizations_url":"https://api.github.com/users/kshitij98/orgs","repos_url":"https://api.github.com/users/kshitij98/repos","events_url":"https://api.github.com/users/kshitij98/events{/privacy}","received_events_url":"https://api.github.com/users/kshitij98/received_events","type":"User","site_admin":false},"body":"Implemented a functionality to hide effects through the effects tab in Preferences. LV2 Effects are hidden by default.\r\n\r\nA few things are still left to be done:\r\n- Add a signal to connect visibility mode update to effect selector.\r\n- Debug segmentation fault triggered in `EffectChain::refreshAllEffects()` on clicking `OK` in preferences.\r\n\r\n[https://bugs.launchpad.net/mixxx/+bug/1653140](https://bugs.launchpad.net/mixxx/+bug/1653140)","created_at":"2018-05-20T12:25:16Z","updated_at":"2018-05-24T23:44:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"205a677ec36ed8fb76c39505a0de0e7ca1a40612","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":519656126,"url":"https://api.github.com/repos/mixxxdj/mixxx/labels/effects","name":"effects","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/mixxxdj/mixxx/milestones/3","html_url":"https://github.com/mixxxdj/mixxx/milestone/3","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones/3/labels","id":2936538,"number":3,"title":"2.2.0","description":"","creator":{"login":"uklotzde","id":1474154,"avatar_url":"https://avatars1.githubusercontent.com/u/1474154?v=4","gravatar_id":"","url":"https://api.github.com/users/uklotzde","html_url":"https://github.com/uklotzde","followers_url":"https://api.github.com/users/uklotzde/followers","following_url":"https://api.github.com/users/uklotzde/following{/other_user}","gists_url":"https://api.github.com/users/uklotzde/gists{/gist_id}","starred_url":"https://api.github.com/users/uklotzde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uklotzde/subscriptions","organizations_url":"https://api.github.com/users/uklotzde/orgs","repos_url":"https://api.github.com/users/uklotzde/repos","events_url":"https://api.github.com/users/uklotzde/events{/privacy}","received_events_url":"https://api.github.com/users/uklotzde/received_events","type":"User","site_admin":false},"open_issues":34,"closed_issues":14,"state":"open","created_at":"2017-11-25T09:20:16Z","updated_at":"2018-05-23T17:32:26Z","due_on":"2018-09-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1674/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1674/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1674/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/72b1f91d4365cbc8319741c7c4205da7d4b5cefa","head":{"label":"kshitij98:effect_blacklisting","ref":"effect_blacklisting","sha":"72b1f91d4365cbc8319741c7c4205da7d4b5cefa","user":{"login":"kshitij98","id":12982388,"avatar_url":"https://avatars0.githubusercontent.com/u/12982388?v=4","gravatar_id":"","url":"https://api.github.com/users/kshitij98","html_url":"https://github.com/kshitij98","followers_url":"https://api.github.com/users/kshitij98/followers","following_url":"https://api.github.com/users/kshitij98/following{/other_user}","gists_url":"https://api.github.com/users/kshitij98/gists{/gist_id}","starred_url":"https://api.github.com/users/kshitij98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshitij98/subscriptions","organizations_url":"https://api.github.com/users/kshitij98/orgs","repos_url":"https://api.github.com/users/kshitij98/repos","events_url":"https://api.github.com/users/kshitij98/events{/privacy}","received_events_url":"https://api.github.com/users/kshitij98/received_events","type":"User","site_admin":false},"repo":{"id":116240129,"name":"mixxx","full_name":"kshitij98/mixxx","owner":{"login":"kshitij98","id":12982388,"avatar_url":"https://avatars0.githubusercontent.com/u/12982388?v=4","gravatar_id":"","url":"https://api.github.com/users/kshitij98","html_url":"https://github.com/kshitij98","followers_url":"https://api.github.com/users/kshitij98/followers","following_url":"https://api.github.com/users/kshitij98/following{/other_user}","gists_url":"https://api.github.com/users/kshitij98/gists{/gist_id}","starred_url":"https://api.github.com/users/kshitij98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshitij98/subscriptions","organizations_url":"https://api.github.com/users/kshitij98/orgs","repos_url":"https://api.github.com/users/kshitij98/repos","events_url":"https://api.github.com/users/kshitij98/events{/privacy}","received_events_url":"https://api.github.com/users/kshitij98/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kshitij98/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/kshitij98/mixxx","forks_url":"https://api.github.com/repos/kshitij98/mixxx/forks","keys_url":"https://api.github.com/repos/kshitij98/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kshitij98/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kshitij98/mixxx/teams","hooks_url":"https://api.github.com/repos/kshitij98/mixxx/hooks","issue_events_url":"https://api.github.com/repos/kshitij98/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/kshitij98/mixxx/events","assignees_url":"https://api.github.com/repos/kshitij98/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/kshitij98/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/kshitij98/mixxx/tags","blobs_url":"https://api.github.com/repos/kshitij98/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kshitij98/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kshitij98/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/kshitij98/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kshitij98/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/kshitij98/mixxx/languages","stargazers_url":"https://api.github.com/repos/kshitij98/mixxx/stargazers","contributors_url":"https://api.github.com/repos/kshitij98/mixxx/contributors","subscribers_url":"https://api.github.com/repos/kshitij98/mixxx/subscribers","subscription_url":"https://api.github.com/repos/kshitij98/mixxx/subscription","commits_url":"https://api.github.com/repos/kshitij98/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/kshitij98/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/kshitij98/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/kshitij98/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/kshitij98/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/kshitij98/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kshitij98/mixxx/merges","archive_url":"https://api.github.com/repos/kshitij98/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kshitij98/mixxx/downloads","issues_url":"https://api.github.com/repos/kshitij98/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/kshitij98/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/kshitij98/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/kshitij98/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kshitij98/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/kshitij98/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/kshitij98/mixxx/deployments","created_at":"2018-01-04T09:20:11Z","updated_at":"2018-03-29T07:43:22Z","pushed_at":"2018-05-24T07:30:28Z","git_url":"git://github.com/kshitij98/mixxx.git","ssh_url":"git@github.com:kshitij98/mixxx.git","clone_url":"https://github.com/kshitij98/mixxx.git","svn_url":"https://github.com/kshitij98/mixxx","homepage":"http://mixxx.org","size":289361,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:lv2_support2","ref":"lv2_support2","sha":"1defdebb235dd1c4c3013c1b96ce98b3f1e7d331","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars3.githubusercontent.com/u/1743769?v=4","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars3.githubusercontent.com/u/1743769?v=4","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/mixxxdj/mixxx/deployments","created_at":"2013-05-17T15:14:38Z","updated_at":"2018-05-24T21:13:42Z","pushed_at":"2018-05-24T22:54:57Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":290006,"stargazers_count":1019,"watchers_count":1019,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":505,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":505,"open_issues":65,"watchers":1019,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1674"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1674"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1674"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1674/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1674/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1674/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/72b1f91d4365cbc8319741c7c4205da7d4b5cefa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Be-ing"}}