{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/graphs/pulls/comments/232713965","pull_request_review_id":173970905,"id":232713965,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjcxMzk2NQ==","diff_hunk":"@@ -26,25 +26,25 @@ final _empty = Future<Null>.value(null);\n /// the graph. If missing nodes are important they should be tracked within the\n /// [readNode] callback.\n ///\n-/// If either [readNode] or [children] throws the error will be forwarded\n+/// If either [readNode] or [edges] throws the error will be forwarded\n /// through the result stream and no further nodes will be crawled, though some\n /// work may have already been started.\n Stream<V> crawlAsync<K, V>(Iterable<K> roots, FutureOr<V> Function(K) readNode,\n-    FutureOr<Iterable<K>> Function(K, V) children) {\n-  final crawl = _CrawlAsync(roots, readNode, children)..run();\n+    FutureOr<Iterable<K>> Function(K, V) edges) {","path":"lib/src/crawl_async.dart","position":26,"original_position":26,"commit_id":"3d52b816e36225f8bc7b74094ebccd56d758c5df","original_commit_id":"3d52b816e36225f8bc7b74094ebccd56d758c5df","user":{"login":"kevmoo","id":17034,"node_id":"MDQ6VXNlcjE3MDM0","avatar_url":"https://avatars2.githubusercontent.com/u/17034?v=4","gravatar_id":"","url":"https://api.github.com/users/kevmoo","html_url":"https://github.com/kevmoo","followers_url":"https://api.github.com/users/kevmoo/followers","following_url":"https://api.github.com/users/kevmoo/following{/other_user}","gists_url":"https://api.github.com/users/kevmoo/gists{/gist_id}","starred_url":"https://api.github.com/users/kevmoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevmoo/subscriptions","organizations_url":"https://api.github.com/users/kevmoo/orgs","repos_url":"https://api.github.com/users/kevmoo/repos","events_url":"https://api.github.com/users/kevmoo/events{/privacy}","received_events_url":"https://api.github.com/users/kevmoo/received_events","type":"User","site_admin":false},"body":"ack","created_at":"2018-11-12T15:59:50Z","updated_at":"2018-11-12T15:59:50Z","html_url":"https://github.com/dart-lang/graphs/pull/30#discussion_r232713965","pull_request_url":"https://api.github.com/repos/dart-lang/graphs/pulls/30","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/graphs/pulls/comments/232713965"},"html":{"href":"https://github.com/dart-lang/graphs/pull/30#discussion_r232713965"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/graphs/pulls/30"}},"in_reply_to_id":232356876},"pull_request":{"url":"https://api.github.com/repos/dart-lang/graphs/pulls/30","id":229432889,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDMyODg5","html_url":"https://github.com/dart-lang/graphs/pull/30","diff_url":"https://github.com/dart-lang/graphs/pull/30.diff","patch_url":"https://github.com/dart-lang/graphs/pull/30.patch","issue_url":"https://api.github.com/repos/dart-lang/graphs/issues/30","number":30,"state":"open","locked":false,"title":"BREAKING: use hashCode/equals instead of keys for handling non-identity values","user":{"login":"kevmoo","id":17034,"node_id":"MDQ6VXNlcjE3MDM0","avatar_url":"https://avatars2.githubusercontent.com/u/17034?v=4","gravatar_id":"","url":"https://api.github.com/users/kevmoo","html_url":"https://github.com/kevmoo","followers_url":"https://api.github.com/users/kevmoo/followers","following_url":"https://api.github.com/users/kevmoo/following{/other_user}","gists_url":"https://api.github.com/users/kevmoo/gists{/gist_id}","starred_url":"https://api.github.com/users/kevmoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevmoo/subscriptions","organizations_url":"https://api.github.com/users/kevmoo/orgs","repos_url":"https://api.github.com/users/kevmoo/repos","events_url":"https://api.github.com/users/kevmoo/events{/privacy}","received_events_url":"https://api.github.com/users/kevmoo/received_events","type":"User","site_admin":false},"body":"@natebosch – I think we can take a page from the `HashMap`, `LinkedHashMap` constructors here.\r\n\r\nThe idea of having a `key` object is just a proxy for supporting custom equals/hashCode on an object.\r\n\r\nThoughts? (If this seems reasonable, we can roll the other functions to do something similar)\r\n\r\nCC @jakemac53 as FYI","created_at":"2018-11-08T16:39:52Z","updated_at":"2018-11-12T15:59:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc1342db06ec3aaf64261ee9ba1413be29426c65","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/graphs/pulls/30/commits","review_comments_url":"https://api.github.com/repos/dart-lang/graphs/pulls/30/comments","review_comment_url":"https://api.github.com/repos/dart-lang/graphs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/graphs/issues/30/comments","statuses_url":"https://api.github.com/repos/dart-lang/graphs/statuses/3d52b816e36225f8bc7b74094ebccd56d758c5df","head":{"label":"dart-lang:v2","ref":"v2","sha":"3d52b816e36225f8bc7b74094ebccd56d758c5df","user":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":111734416,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE3MzQ0MTY=","name":"graphs","full_name":"dart-lang/graphs","private":false,"owner":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dart-lang/graphs","description":"Graph algorithms","fork":false,"url":"https://api.github.com/repos/dart-lang/graphs","forks_url":"https://api.github.com/repos/dart-lang/graphs/forks","keys_url":"https://api.github.com/repos/dart-lang/graphs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/graphs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/graphs/teams","hooks_url":"https://api.github.com/repos/dart-lang/graphs/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/graphs/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/graphs/events","assignees_url":"https://api.github.com/repos/dart-lang/graphs/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/graphs/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/graphs/tags","blobs_url":"https://api.github.com/repos/dart-lang/graphs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/graphs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/graphs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/graphs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/graphs/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/graphs/languages","stargazers_url":"https://api.github.com/repos/dart-lang/graphs/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/graphs/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/graphs/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/graphs/subscription","commits_url":"https://api.github.com/repos/dart-lang/graphs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/graphs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/graphs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/graphs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/graphs/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/graphs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/graphs/merges","archive_url":"https://api.github.com/repos/dart-lang/graphs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/graphs/downloads","issues_url":"https://api.github.com/repos/dart-lang/graphs/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/graphs/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/graphs/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/graphs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/graphs/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/graphs/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/graphs/deployments","created_at":"2017-11-22T21:32:56Z","updated_at":"2018-11-08T18:44:29Z","pushed_at":"2018-11-09T17:40:01Z","git_url":"git://github.com/dart-lang/graphs.git","ssh_url":"git@github.com:dart-lang/graphs.git","clone_url":"https://github.com/dart-lang/graphs.git","svn_url":"https://github.com/dart-lang/graphs","homepage":"https://pub.dartlang.org/packages/graphs","size":56,"stargazers_count":5,"watchers_count":5,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3,"open_issues":2,"watchers":5,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"936759082f814a95e408e5393815fc4f081ca496","user":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":111734416,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE3MzQ0MTY=","name":"graphs","full_name":"dart-lang/graphs","private":false,"owner":{"login":"dart-lang","id":1609975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDk5NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1609975?v=4","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dart-lang/graphs","description":"Graph algorithms","fork":false,"url":"https://api.github.com/repos/dart-lang/graphs","forks_url":"https://api.github.com/repos/dart-lang/graphs/forks","keys_url":"https://api.github.com/repos/dart-lang/graphs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/graphs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/graphs/teams","hooks_url":"https://api.github.com/repos/dart-lang/graphs/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/graphs/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/graphs/events","assignees_url":"https://api.github.com/repos/dart-lang/graphs/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/graphs/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/graphs/tags","blobs_url":"https://api.github.com/repos/dart-lang/graphs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/graphs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/graphs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/graphs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/graphs/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/graphs/languages","stargazers_url":"https://api.github.com/repos/dart-lang/graphs/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/graphs/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/graphs/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/graphs/subscription","commits_url":"https://api.github.com/repos/dart-lang/graphs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/graphs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/graphs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/graphs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/graphs/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/graphs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/graphs/merges","archive_url":"https://api.github.com/repos/dart-lang/graphs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/graphs/downloads","issues_url":"https://api.github.com/repos/dart-lang/graphs/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/graphs/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/graphs/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/graphs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/graphs/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/graphs/releases{/id}","deployments_url":"https://api.github.com/repos/dart-lang/graphs/deployments","created_at":"2017-11-22T21:32:56Z","updated_at":"2018-11-08T18:44:29Z","pushed_at":"2018-11-09T17:40:01Z","git_url":"git://github.com/dart-lang/graphs.git","ssh_url":"git@github.com:dart-lang/graphs.git","clone_url":"https://github.com/dart-lang/graphs.git","svn_url":"https://github.com/dart-lang/graphs","homepage":"https://pub.dartlang.org/packages/graphs","size":56,"stargazers_count":5,"watchers_count":5,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":3,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/graphs/pulls/30"},"html":{"href":"https://github.com/dart-lang/graphs/pull/30"},"issue":{"href":"https://api.github.com/repos/dart-lang/graphs/issues/30"},"comments":{"href":"https://api.github.com/repos/dart-lang/graphs/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/graphs/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/graphs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/graphs/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/graphs/statuses/3d52b816e36225f8bc7b74094ebccd56d758c5df"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"kevmoo"}}