{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/244613178","pull_request_review_id":188530166,"id":244613178,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDYxMzE3OA==","diff_hunk":"@@ -1715,14 +1720,28 @@ internal static void CheckStringLength(int length)\n \n         internal static void CheckStringLength(uint length)\n         {\n-            if (length > 0x7ffffff0)\n+            if (length > MaxStringLength)\n             {\n-                throw new MarshalDirectiveException(SR.Marshaler_StringTooLong);\n+                ThrowStringTooLong();\n             }\n         }\n \n-        [MethodImplAttribute(MethodImplOptions.InternalCall)]\n-        internal static extern unsafe int strlen(sbyte* ptr);\n+        [MethodImpl(MethodImplOptions.AggressiveInlining)]\n+        internal static unsafe int strlen(byte* ptr)","path":"src/System.Private.CoreLib/src/System/StubHelpers.cs","position":49,"original_position":49,"commit_id":"1f667bd5fd4c1d0497906651f9155cb2ce8582df","original_commit_id":"1f667bd5fd4c1d0497906651f9155cb2ce8582df","user":{"login":"jkotas","id":6668460,"node_id":"MDQ6VXNlcjY2Njg0NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/6668460?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"I am wondering whether it would be better for this to live in String.cs next to `wcslen`; or in some other place not related to index (maybe SpanHelpers?).","created_at":"2018-12-31T19:39:04Z","updated_at":"2018-12-31T19:39:05Z","html_url":"https://github.com/dotnet/coreclr/pull/21729#discussion_r244613178","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/21729","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/244613178"},"html":{"href":"https://github.com/dotnet/coreclr/pull/21729#discussion_r244613178"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/21729"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/21729","id":241591478,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNTkxNDc4","html_url":"https://github.com/dotnet/coreclr/pull/21729","diff_url":"https://github.com/dotnet/coreclr/pull/21729.diff","patch_url":"https://github.com/dotnet/coreclr/pull/21729.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/21729","number":21729,"state":"open","locked":false,"title":"strlen to managed code and vectorize","user":{"login":"benaadams","id":1142958,"node_id":"MDQ6VXNlcjExNDI5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1142958?v=4","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"body":"Follow up to https://github.com/dotnet/coreclr/pull/21720\r\n\r\n/cc @jkotas ","created_at":"2018-12-31T18:46:12Z","updated_at":"2018-12-31T19:39:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9874b44a2855e0b1895c1064514febe247f7fa60","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/21729/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/21729/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/21729/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/1f667bd5fd4c1d0497906651f9155cb2ce8582df","head":{"label":"benaadams:strlen","ref":"strlen","sha":"1f667bd5fd4c1d0497906651f9155cb2ce8582df","user":{"login":"benaadams","id":1142958,"node_id":"MDQ6VXNlcjExNDI5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1142958?v=4","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"repo":{"id":30264189,"node_id":"MDEwOlJlcG9zaXRvcnkzMDI2NDE4OQ==","name":"coreclr","full_name":"benaadams/coreclr","private":false,"owner":{"login":"benaadams","id":1142958,"node_id":"MDQ6VXNlcjExNDI5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1142958?v=4","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"html_url":"https://github.com/benaadams/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/benaadams/coreclr","forks_url":"https://api.github.com/repos/benaadams/coreclr/forks","keys_url":"https://api.github.com/repos/benaadams/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benaadams/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benaadams/coreclr/teams","hooks_url":"https://api.github.com/repos/benaadams/coreclr/hooks","issue_events_url":"https://api.github.com/repos/benaadams/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/benaadams/coreclr/events","assignees_url":"https://api.github.com/repos/benaadams/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/benaadams/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/benaadams/coreclr/tags","blobs_url":"https://api.github.com/repos/benaadams/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benaadams/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benaadams/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/benaadams/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benaadams/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/benaadams/coreclr/languages","stargazers_url":"https://api.github.com/repos/benaadams/coreclr/stargazers","contributors_url":"https://api.github.com/repos/benaadams/coreclr/contributors","subscribers_url":"https://api.github.com/repos/benaadams/coreclr/subscribers","subscription_url":"https://api.github.com/repos/benaadams/coreclr/subscription","commits_url":"https://api.github.com/repos/benaadams/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/benaadams/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/benaadams/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/benaadams/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/benaadams/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/benaadams/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benaadams/coreclr/merges","archive_url":"https://api.github.com/repos/benaadams/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benaadams/coreclr/downloads","issues_url":"https://api.github.com/repos/benaadams/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/benaadams/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/benaadams/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/benaadams/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benaadams/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/benaadams/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/benaadams/coreclr/deployments","created_at":"2015-02-03T20:56:42Z","updated_at":"2018-11-03T00:39:56Z","pushed_at":"2018-12-31T18:41:42Z","git_url":"git://github.com/benaadams/coreclr.git","ssh_url":"git@github.com:benaadams/coreclr.git","clone_url":"https://github.com/benaadams/coreclr.git","svn_url":"https://github.com/benaadams/coreclr","homepage":"","size":259236,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"73d7d224ae6fb9b13bb641440c06606f426215cb","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA5Mjg5Mw==","name":"coreclr","full_name":"dotnet/coreclr","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/coreclr","description":"CoreCLR is the runtime for .NET Core. It includes the garbage collector, JIT compiler, primitive data types and low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2018-12-31T17:57:35Z","pushed_at":"2018-12-31T19:33:23Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://docs.microsoft.com/dotnet/core/","size":301250,"stargazers_count":10732,"watchers_count":10732,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2553,"mirror_url":null,"archived":false,"open_issues_count":2086,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2553,"open_issues":2086,"watchers":10732,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/21729"},"html":{"href":"https://github.com/dotnet/coreclr/pull/21729"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/21729"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/21729/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/21729/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/21729/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/1f667bd5fd4c1d0497906651f9155cb2ce8582df"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jkotas"}}