{"action":"closed","issue":{"url":"https://api.github.com/repos/openfaas/faas/issues/510","repository_url":"https://api.github.com/repos/openfaas/faas","labels_url":"https://api.github.com/repos/openfaas/faas/issues/510/labels{/name}","comments_url":"https://api.github.com/repos/openfaas/faas/issues/510/comments","events_url":"https://api.github.com/repos/openfaas/faas/issues/510/events","html_url":"https://github.com/openfaas/faas/issues/510","id":295058191,"number":510,"title":"Support Go durations for timeout values","user":{"login":"alexellis","id":6358735,"avatar_url":"https://avatars1.githubusercontent.com/u/6358735?v=4","gravatar_id":"","url":"https://api.github.com/users/alexellis","html_url":"https://github.com/alexellis","followers_url":"https://api.github.com/users/alexellis/followers","following_url":"https://api.github.com/users/alexellis/following{/other_user}","gists_url":"https://api.github.com/users/alexellis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexellis/subscriptions","organizations_url":"https://api.github.com/users/alexellis/orgs","repos_url":"https://api.github.com/users/alexellis/repos","events_url":"https://api.github.com/users/alexellis/events{/privacy}","received_events_url":"https://api.github.com/users/alexellis/received_events","type":"User","site_admin":false},"labels":[{"id":505489877,"url":"https://api.github.com/repos/openfaas/faas/labels/help%20wanted","name":"help wanted","color":"128A0C","default":true},{"id":653679586,"url":"https://api.github.com/repos/openfaas/faas/labels/skill/beginner","name":"skill/beginner","color":"bfdadc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-07T09:10:35Z","updated_at":"2018-02-10T18:46:24Z","closed_at":"2018-02-10T18:46:24Z","author_association":"OWNER","body":"## Description\r\n\r\nSupport Golang durations such as \"10s\" or \"1m20s\" in the gateway configuration.\r\n\r\nCurrent behaviour:\r\n\r\n```\r\nENV read_timeout=\"10\" # 10 seconds\r\n```\r\n\r\nExpected behaviour:\r\n\r\n```\r\nENV read_timeout=\"1m\" # 60 seconds aka 1 minute\r\n\r\nENV read_timeout=\"10s\" # 10 seconds\r\n\r\nENV read_timeout=\"10\" # 10 seconds\r\n```\r\n\r\nThis should be backwards compatible with the old method where the configuration for timeouts was assumed to be an integer representing seconds.\r\n\r\nSee https://github.com/openfaas/faas-netes/blob/master/test/read_config_test.go#L68 for the code I've written to do this there.\r\n\r\n## Acceptance criteria\r\n\r\n- [ ] Tested end-to-end\r\n- [ ] Code copied from faas-netesd\r\n- [ ] Unit tests updated or copied from faas-netesd\r\n\r\n"}}
{"actor":{"display_login":"alexellis"}}