{"action":"created","comment":{"url":"https://api.github.com/repos/novnc/noVNC/pulls/comments/210333528","pull_request_review_id":146526110,"id":210333528,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDMzMzUyOA==","diff_hunk":"@@ -213,3 +215,23 @@ export default class Cursor {\n         this._canvas.style.top = this._position.y + \"px\";\n     }\n }\n+\n+Cursor.none = {\n+    rgbaPixels: [],\n+    w: 0,\n+    h: 0,\n+    x: 0,\n+    y: 0,\n+};\n+\n+Cursor.dot = {\n+    rgbaPixels: Base64.decode(\n+        \"/////wAAAP//////\" +\n+        \"AAAA/wAAAAAAAAD/\" +\n+        \"/////wAAAP//////\"\n+    ),\n+    w: 3,\n+    h: 3,\n+    x: 1,\n+    y: 1,\n+};","path":"core/util/cursor.js","position":72,"original_position":39,"commit_id":"127818bc48c3088b4f9cee48e45aafbb6ab64ded","original_commit_id":"f7cf5942350d3e2948e383b4cb15ae264d1620db","user":{"login":"patrakov","id":2943163,"node_id":"MDQ6VXNlcjI5NDMxNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2943163?v=4","gravatar_id":"","url":"https://api.github.com/users/patrakov","html_url":"https://github.com/patrakov","followers_url":"https://api.github.com/users/patrakov/followers","following_url":"https://api.github.com/users/patrakov/following{/other_user}","gists_url":"https://api.github.com/users/patrakov/gists{/gist_id}","starred_url":"https://api.github.com/users/patrakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrakov/subscriptions","organizations_url":"https://api.github.com/users/patrakov/orgs","repos_url":"https://api.github.com/users/patrakov/repos","events_url":"https://api.github.com/users/patrakov/events{/privacy}","received_events_url":"https://api.github.com/users/patrakov/received_events","type":"User","site_admin":false},"body":"OK","created_at":"2018-08-15T16:52:04Z","updated_at":"2018-08-15T16:52:04Z","html_url":"https://github.com/novnc/noVNC/pull/1119#discussion_r210333528","pull_request_url":"https://api.github.com/repos/novnc/noVNC/pulls/1119","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/comments/210333528"},"html":{"href":"https://github.com/novnc/noVNC/pull/1119#discussion_r210333528"},"pull_request":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/1119"}},"in_reply_to_id":210286348},"pull_request":{"url":"https://api.github.com/repos/novnc/noVNC/pulls/1119","id":204961384,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0OTYxMzg0","html_url":"https://github.com/novnc/noVNC/pull/1119","diff_url":"https://github.com/novnc/noVNC/pull/1119.diff","patch_url":"https://github.com/novnc/noVNC/pull/1119.patch","issue_url":"https://api.github.com/repos/novnc/noVNC/issues/1119","number":1119,"state":"open","locked":false,"title":"Show dot when there otherwise would be no visible cursor","user":{"login":"patrakov","id":2943163,"node_id":"MDQ6VXNlcjI5NDMxNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2943163?v=4","gravatar_id":"","url":"https://api.github.com/users/patrakov","html_url":"https://github.com/patrakov","followers_url":"https://api.github.com/users/patrakov/followers","following_url":"https://api.github.com/users/patrakov/following{/other_user}","gists_url":"https://api.github.com/users/patrakov/gists{/gist_id}","starred_url":"https://api.github.com/users/patrakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrakov/subscriptions","organizations_url":"https://api.github.com/users/patrakov/orgs","repos_url":"https://api.github.com/users/patrakov/repos","events_url":"https://api.github.com/users/patrakov/events{/privacy}","received_events_url":"https://api.github.com/users/patrakov/received_events","type":"User","site_admin":false},"body":"Fixes #1031.\r\n\r\nThe dot is currently enabled unconditionally, I can hide it behind a preference if you want.\r\n\r\nI thought about disabling this by default on touch devices, but had to say \"no\" because my Lenovo Yoga 2 Pro laptop is detected under Linux as a touch device but I still want the dot to be shown there. The laptop has a touchscreen but for me it is an unused extra.","created_at":"2018-07-30T23:55:26Z","updated_at":"2018-08-15T16:52:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fba5473485f97d5177a06962bd5327586dc9564f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":45485,"node_id":"MDU6TGFiZWw0NTQ4NQ==","url":"https://api.github.com/repos/novnc/noVNC/labels/feature","name":"feature","color":"a7faa0","default":false}],"milestone":{"url":"https://api.github.com/repos/novnc/noVNC/milestones/3","html_url":"https://github.com/novnc/noVNC/milestone/3","labels_url":"https://api.github.com/repos/novnc/noVNC/milestones/3/labels","id":3361104,"node_id":"MDk6TWlsZXN0b25lMzM2MTEwNA==","number":3,"title":"v1.1.0","description":"","creator":{"login":"samhed","id":4117162,"node_id":"MDQ6VXNlcjQxMTcxNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/4117162?v=4","gravatar_id":"","url":"https://api.github.com/users/samhed","html_url":"https://github.com/samhed","followers_url":"https://api.github.com/users/samhed/followers","following_url":"https://api.github.com/users/samhed/following{/other_user}","gists_url":"https://api.github.com/users/samhed/gists{/gist_id}","starred_url":"https://api.github.com/users/samhed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samhed/subscriptions","organizations_url":"https://api.github.com/users/samhed/orgs","repos_url":"https://api.github.com/users/samhed/repos","events_url":"https://api.github.com/users/samhed/events{/privacy}","received_events_url":"https://api.github.com/users/samhed/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":28,"state":"open","created_at":"2018-05-21T11:28:56Z","updated_at":"2018-08-15T07:13:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/novnc/noVNC/pulls/1119/commits","review_comments_url":"https://api.github.com/repos/novnc/noVNC/pulls/1119/comments","review_comment_url":"https://api.github.com/repos/novnc/noVNC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/novnc/noVNC/issues/1119/comments","statuses_url":"https://api.github.com/repos/novnc/noVNC/statuses/127818bc48c3088b4f9cee48e45aafbb6ab64ded","head":{"label":"patrakov:master","ref":"master","sha":"127818bc48c3088b4f9cee48e45aafbb6ab64ded","user":{"login":"patrakov","id":2943163,"node_id":"MDQ6VXNlcjI5NDMxNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2943163?v=4","gravatar_id":"","url":"https://api.github.com/users/patrakov","html_url":"https://github.com/patrakov","followers_url":"https://api.github.com/users/patrakov/followers","following_url":"https://api.github.com/users/patrakov/following{/other_user}","gists_url":"https://api.github.com/users/patrakov/gists{/gist_id}","starred_url":"https://api.github.com/users/patrakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrakov/subscriptions","organizations_url":"https://api.github.com/users/patrakov/orgs","repos_url":"https://api.github.com/users/patrakov/repos","events_url":"https://api.github.com/users/patrakov/events{/privacy}","received_events_url":"https://api.github.com/users/patrakov/received_events","type":"User","site_admin":false},"repo":{"id":141368610,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzNjg2MTA=","name":"noVNC","full_name":"patrakov/noVNC","owner":{"login":"patrakov","id":2943163,"node_id":"MDQ6VXNlcjI5NDMxNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2943163?v=4","gravatar_id":"","url":"https://api.github.com/users/patrakov","html_url":"https://github.com/patrakov","followers_url":"https://api.github.com/users/patrakov/followers","following_url":"https://api.github.com/users/patrakov/following{/other_user}","gists_url":"https://api.github.com/users/patrakov/gists{/gist_id}","starred_url":"https://api.github.com/users/patrakov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrakov/subscriptions","organizations_url":"https://api.github.com/users/patrakov/orgs","repos_url":"https://api.github.com/users/patrakov/repos","events_url":"https://api.github.com/users/patrakov/events{/privacy}","received_events_url":"https://api.github.com/users/patrakov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/patrakov/noVNC","description":"VNC client using HTML5 (Web Sockets, Canvas) with encryption (wss://) support.","fork":true,"url":"https://api.github.com/repos/patrakov/noVNC","forks_url":"https://api.github.com/repos/patrakov/noVNC/forks","keys_url":"https://api.github.com/repos/patrakov/noVNC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patrakov/noVNC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patrakov/noVNC/teams","hooks_url":"https://api.github.com/repos/patrakov/noVNC/hooks","issue_events_url":"https://api.github.com/repos/patrakov/noVNC/issues/events{/number}","events_url":"https://api.github.com/repos/patrakov/noVNC/events","assignees_url":"https://api.github.com/repos/patrakov/noVNC/assignees{/user}","branches_url":"https://api.github.com/repos/patrakov/noVNC/branches{/branch}","tags_url":"https://api.github.com/repos/patrakov/noVNC/tags","blobs_url":"https://api.github.com/repos/patrakov/noVNC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patrakov/noVNC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patrakov/noVNC/git/refs{/sha}","trees_url":"https://api.github.com/repos/patrakov/noVNC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patrakov/noVNC/statuses/{sha}","languages_url":"https://api.github.com/repos/patrakov/noVNC/languages","stargazers_url":"https://api.github.com/repos/patrakov/noVNC/stargazers","contributors_url":"https://api.github.com/repos/patrakov/noVNC/contributors","subscribers_url":"https://api.github.com/repos/patrakov/noVNC/subscribers","subscription_url":"https://api.github.com/repos/patrakov/noVNC/subscription","commits_url":"https://api.github.com/repos/patrakov/noVNC/commits{/sha}","git_commits_url":"https://api.github.com/repos/patrakov/noVNC/git/commits{/sha}","comments_url":"https://api.github.com/repos/patrakov/noVNC/comments{/number}","issue_comment_url":"https://api.github.com/repos/patrakov/noVNC/issues/comments{/number}","contents_url":"https://api.github.com/repos/patrakov/noVNC/contents/{+path}","compare_url":"https://api.github.com/repos/patrakov/noVNC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patrakov/noVNC/merges","archive_url":"https://api.github.com/repos/patrakov/noVNC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patrakov/noVNC/downloads","issues_url":"https://api.github.com/repos/patrakov/noVNC/issues{/number}","pulls_url":"https://api.github.com/repos/patrakov/noVNC/pulls{/number}","milestones_url":"https://api.github.com/repos/patrakov/noVNC/milestones{/number}","notifications_url":"https://api.github.com/repos/patrakov/noVNC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patrakov/noVNC/labels{/name}","releases_url":"https://api.github.com/repos/patrakov/noVNC/releases{/id}","deployments_url":"https://api.github.com/repos/patrakov/noVNC/deployments","created_at":"2018-07-18T02:11:48Z","updated_at":"2018-08-12T15:09:48Z","pushed_at":"2018-08-12T15:09:46Z","git_url":"git://github.com/patrakov/noVNC.git","ssh_url":"git@github.com:patrakov/noVNC.git","clone_url":"https://github.com/patrakov/noVNC.git","svn_url":"https://github.com/patrakov/noVNC","homepage":"novnc.com","size":9266,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"novnc:master","ref":"master","sha":"3b7c47417e1625f04916c6515e6a9630e50a79b9","user":{"login":"novnc","id":24572588,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTcyNTg4","avatar_url":"https://avatars2.githubusercontent.com/u/24572588?v=4","gravatar_id":"","url":"https://api.github.com/users/novnc","html_url":"https://github.com/novnc","followers_url":"https://api.github.com/users/novnc/followers","following_url":"https://api.github.com/users/novnc/following{/other_user}","gists_url":"https://api.github.com/users/novnc/gists{/gist_id}","starred_url":"https://api.github.com/users/novnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novnc/subscriptions","organizations_url":"https://api.github.com/users/novnc/orgs","repos_url":"https://api.github.com/users/novnc/repos","events_url":"https://api.github.com/users/novnc/events{/privacy}","received_events_url":"https://api.github.com/users/novnc/received_events","type":"Organization","site_admin":false},"repo":{"id":598164,"node_id":"MDEwOlJlcG9zaXRvcnk1OTgxNjQ=","name":"noVNC","full_name":"novnc/noVNC","owner":{"login":"novnc","id":24572588,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTcyNTg4","avatar_url":"https://avatars2.githubusercontent.com/u/24572588?v=4","gravatar_id":"","url":"https://api.github.com/users/novnc","html_url":"https://github.com/novnc","followers_url":"https://api.github.com/users/novnc/followers","following_url":"https://api.github.com/users/novnc/following{/other_user}","gists_url":"https://api.github.com/users/novnc/gists{/gist_id}","starred_url":"https://api.github.com/users/novnc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/novnc/subscriptions","organizations_url":"https://api.github.com/users/novnc/orgs","repos_url":"https://api.github.com/users/novnc/repos","events_url":"https://api.github.com/users/novnc/events{/privacy}","received_events_url":"https://api.github.com/users/novnc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/novnc/noVNC","description":"VNC client using HTML5 (Web Sockets, Canvas) with encryption (wss://) support.","fork":false,"url":"https://api.github.com/repos/novnc/noVNC","forks_url":"https://api.github.com/repos/novnc/noVNC/forks","keys_url":"https://api.github.com/repos/novnc/noVNC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/novnc/noVNC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/novnc/noVNC/teams","hooks_url":"https://api.github.com/repos/novnc/noVNC/hooks","issue_events_url":"https://api.github.com/repos/novnc/noVNC/issues/events{/number}","events_url":"https://api.github.com/repos/novnc/noVNC/events","assignees_url":"https://api.github.com/repos/novnc/noVNC/assignees{/user}","branches_url":"https://api.github.com/repos/novnc/noVNC/branches{/branch}","tags_url":"https://api.github.com/repos/novnc/noVNC/tags","blobs_url":"https://api.github.com/repos/novnc/noVNC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/novnc/noVNC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/novnc/noVNC/git/refs{/sha}","trees_url":"https://api.github.com/repos/novnc/noVNC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/novnc/noVNC/statuses/{sha}","languages_url":"https://api.github.com/repos/novnc/noVNC/languages","stargazers_url":"https://api.github.com/repos/novnc/noVNC/stargazers","contributors_url":"https://api.github.com/repos/novnc/noVNC/contributors","subscribers_url":"https://api.github.com/repos/novnc/noVNC/subscribers","subscription_url":"https://api.github.com/repos/novnc/noVNC/subscription","commits_url":"https://api.github.com/repos/novnc/noVNC/commits{/sha}","git_commits_url":"https://api.github.com/repos/novnc/noVNC/git/commits{/sha}","comments_url":"https://api.github.com/repos/novnc/noVNC/comments{/number}","issue_comment_url":"https://api.github.com/repos/novnc/noVNC/issues/comments{/number}","contents_url":"https://api.github.com/repos/novnc/noVNC/contents/{+path}","compare_url":"https://api.github.com/repos/novnc/noVNC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/novnc/noVNC/merges","archive_url":"https://api.github.com/repos/novnc/noVNC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/novnc/noVNC/downloads","issues_url":"https://api.github.com/repos/novnc/noVNC/issues{/number}","pulls_url":"https://api.github.com/repos/novnc/noVNC/pulls{/number}","milestones_url":"https://api.github.com/repos/novnc/noVNC/milestones{/number}","notifications_url":"https://api.github.com/repos/novnc/noVNC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/novnc/noVNC/labels{/name}","releases_url":"https://api.github.com/repos/novnc/noVNC/releases{/id}","deployments_url":"https://api.github.com/repos/novnc/noVNC/deployments","created_at":"2010-04-07T01:55:44Z","updated_at":"2018-08-15T07:37:49Z","pushed_at":"2018-08-15T06:10:38Z","git_url":"git://github.com/novnc/noVNC.git","ssh_url":"git@github.com:novnc/noVNC.git","clone_url":"https://github.com/novnc/noVNC.git","svn_url":"https://github.com/novnc/noVNC","homepage":"novnc.com","size":9259,"stargazers_count":4522,"watchers_count":4522,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":973,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":973,"open_issues":45,"watchers":4522,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/1119"},"html":{"href":"https://github.com/novnc/noVNC/pull/1119"},"issue":{"href":"https://api.github.com/repos/novnc/noVNC/issues/1119"},"comments":{"href":"https://api.github.com/repos/novnc/noVNC/issues/1119/comments"},"review_comments":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/1119/comments"},"review_comment":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/novnc/noVNC/pulls/1119/commits"},"statuses":{"href":"https://api.github.com/repos/novnc/noVNC/statuses/127818bc48c3088b4f9cee48e45aafbb6ab64ded"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"patrakov"}}