{"action":"created","issue":{"url":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/699","repository_url":"https://api.github.com/repos/oVirt/ovirt-web-ui","labels_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/699/labels{/name}","comments_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/699/comments","events_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/699/events","html_url":"https://github.com/oVirt/ovirt-web-ui/pull/699","id":347464792,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDgzMjEy","number":699,"title":"ux-redesign: Base VM Details page with stub cards","user":{"login":"sjd78","id":3985964,"node_id":"MDQ6VXNlcjM5ODU5NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3985964?v=4","gravatar_id":"","url":"https://api.github.com/users/sjd78","html_url":"https://github.com/sjd78","followers_url":"https://api.github.com/users/sjd78/followers","following_url":"https://api.github.com/users/sjd78/following{/other_user}","gists_url":"https://api.github.com/users/sjd78/gists{/gist_id}","starred_url":"https://api.github.com/users/sjd78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjd78/subscriptions","organizations_url":"https://api.github.com/users/sjd78/orgs","repos_url":"https://api.github.com/users/sjd78/repos","events_url":"https://api.github.com/users/sjd78/events{/privacy}","received_events_url":"https://api.github.com/users/sjd78/received_events","type":"User","site_admin":false},"labels":[{"id":968933840,"node_id":"MDU6TGFiZWw5Njg5MzM4NDA=","url":"https://api.github.com/repos/oVirt/ovirt-web-ui/labels/redesign","name":"redesign","color":"d0a9f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-03T16:43:46Z","updated_at":"2018-08-08T22:15:23Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/oVirt/ovirt-web-ui/pulls/699","html_url":"https://github.com/oVirt/ovirt-web-ui/pull/699","diff_url":"https://github.com/oVirt/ovirt-web-ui/pull/699.diff","patch_url":"https://github.com/oVirt/ovirt-web-ui/pull/699.patch"},"body":" - Use flex-box to layout the grid (created grid components to mimic bootstrap4 / patternfly4 style grids). These new grid components may be used in other places as well.\r\n\r\n - All of the cards use `BaseCard` to keep common layout and edit logic\r\n\r\n - `BaseCard` edit state is controllable if needed and its event handlers can be aborted to prevent transition the edit state.\r\n\r\n - The page supports tracking the edit and dirty edit state of any component cards (via `onStartEdit` of `BaseCard` and `handleEditChange` of `VmDetailsContainer`).  Card are responsible to notify the layout page via the `onEditChange` callback about its **Edit** state and if any changes have been made on the Edit that need to be saved (**Dirty Edit**).\r\n\r\n - If any card reports **Dirty Edit**, the page will confirm prompt any navigation (or reload) request.\r\n\r\n - Cards in this commit are placeholders. View and edit details to follow in later commits.\r\n\r\n---\r\n\r\nAs of the last edit, the first 2 commits currently correspond to PRs:\r\n - ~~#659 &rarr; getRoutes() to fix breadcrumb titles~~\r\n - #678 &rarr; flex-box layout\r\n - ~~#689 &rarr; fix render of on page console buttons (margins and separators)~~\r\n - ~~#679 &rarr; refactor `ovritapi`~~\r\n - #690 &rarr; better handling for \"deep fetch\" / linked / sub VM resources\r\n"},"comment":{"url":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/comments/411570536","html_url":"https://github.com/oVirt/ovirt-web-ui/pull/699#issuecomment-411570536","issue_url":"https://api.github.com/repos/oVirt/ovirt-web-ui/issues/699","id":411570536,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTU3MDUzNg==","user":{"login":"sjd78","id":3985964,"node_id":"MDQ6VXNlcjM5ODU5NjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3985964?v=4","gravatar_id":"","url":"https://api.github.com/users/sjd78","html_url":"https://github.com/sjd78","followers_url":"https://api.github.com/users/sjd78/followers","following_url":"https://api.github.com/users/sjd78/following{/other_user}","gists_url":"https://api.github.com/users/sjd78/gists{/gist_id}","starred_url":"https://api.github.com/users/sjd78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjd78/subscriptions","organizations_url":"https://api.github.com/users/sjd78/orgs","repos_url":"https://api.github.com/users/sjd78/repos","events_url":"https://api.github.com/users/sjd78/events{/privacy}","received_events_url":"https://api.github.com/users/sjd78/received_events","type":"User","site_admin":false},"created_at":"2018-08-08T22:15:23Z","updated_at":"2018-08-08T22:15:23Z","author_association":"MEMBER","body":"This PR is concerned with:\r\n - the layout of the cards, \r\n - the pending next_run changes info message, \r\n - keeping the cards the same height,\r\n - keeping the edit buttons at the bottom of the card, and\r\n - handling the navigation prompt for a dirty edit\r\n\r\nLayout for an unmodified VM looks like:\r\n![screenshot-localhost-3000-2018 08 08-18-09-26](https://user-images.githubusercontent.com/3985964/43867185-4bd72060-9b36-11e8-94dd-645278926a37.png)\r\n\r\nIf the VM has next_run pending changes:\r\n![screenshot-localhost-3000-2018 08 08-18-08-46](https://user-images.githubusercontent.com/3985964/43867205-5b55120e-9b36-11e8-8ed3-b90442af6628.png)\r\n"}}
{"actor":{"display_login":"sjd78"}}