{"action":"created","comment":{"url":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/comments/226989638","pull_request_review_id":166905322,"id":226989638,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjk4OTYzOA==","diff_hunk":"@@ -16,21 +16,20 @@ include::prerequisites-kubernetes.adoc[leveloffset=+1]\n \n . Download one of the releases from https://github.com/EnMasseProject/enmasse/releases and unpack it.\n \n-. Create the namespace where you want to deploy {ProductName}\n+. (Optional) Replace namespace if you want to deploy to something other than `{ProductNamespace}` (and substitute `{ProductNamespace}` in subsequent steps):\n +\n [options=\"nowrap\",subs=\"attributes\"]\n ----\n-kubectl create namespace enmasse\n-kubectl config set-context $(kubectl config current-context) --namespace=enmasse\n+sed -i \"s/{ProductNamespace}/_<my-namespace>_/\" install/bundles/enmasse-with-none-authservice/*.yaml\n ----\n \n-. Replace namespace references in bundle\n+. Create the namespace where you want to deploy {ProductName}\n +\n [options=\"nowrap\",subs=\"attributes\"]\n ----\n-sed -i \"s/myproject/enmasse/\" install/bundles/enmasse-with-none-authservice/*.yaml\n+kubectl create namespace {ProductNamespace}\n+kubectl config set-context $(kubectl config current-context) --namespace={ProductNamespace}\n ----","path":"documentation/getting_started/kubernetes.adoc","position":22,"original_position":22,"commit_id":"c6019175192d37ffb22da2e11d8692e91889c2ed","original_commit_id":"c6019175192d37ffb22da2e11d8692e91889c2ed","user":{"login":"jenmalloy","id":19193696,"node_id":"MDQ6VXNlcjE5MTkzNjk2","avatar_url":"https://avatars2.githubusercontent.com/u/19193696?v=4","gravatar_id":"","url":"https://api.github.com/users/jenmalloy","html_url":"https://github.com/jenmalloy","followers_url":"https://api.github.com/users/jenmalloy/followers","following_url":"https://api.github.com/users/jenmalloy/following{/other_user}","gists_url":"https://api.github.com/users/jenmalloy/gists{/gist_id}","starred_url":"https://api.github.com/users/jenmalloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenmalloy/subscriptions","organizations_url":"https://api.github.com/users/jenmalloy/orgs","repos_url":"https://api.github.com/users/jenmalloy/repos","events_url":"https://api.github.com/users/jenmalloy/events{/privacy}","received_events_url":"https://api.github.com/users/jenmalloy/received_events","type":"User","site_admin":false},"body":"Add:\r\n\"where <{ProductNamespace}> is the namespace where {ProductName} is deployed.\"","created_at":"2018-10-22T13:36:18Z","updated_at":"2018-10-22T13:52:24Z","html_url":"https://github.com/EnMasseProject/enmasse/pull/1816#discussion_r226989638","pull_request_url":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/1816","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/comments/226989638"},"html":{"href":"https://github.com/EnMasseProject/enmasse/pull/1816#discussion_r226989638"},"pull_request":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/1816"}}},"pull_request":{"url":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/1816","id":224242539,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MjQyNTM5","html_url":"https://github.com/EnMasseProject/enmasse/pull/1816","diff_url":"https://github.com/EnMasseProject/enmasse/pull/1816.diff","patch_url":"https://github.com/EnMasseProject/enmasse/pull/1816.patch","issue_url":"https://api.github.com/repos/EnMasseProject/enmasse/issues/1816","number":1816,"state":"open","locked":false,"title":"Image location and doc fixes","user":{"login":"lulf","id":19670,"node_id":"MDQ6VXNlcjE5Njcw","avatar_url":"https://avatars0.githubusercontent.com/u/19670?v=4","gravatar_id":"","url":"https://api.github.com/users/lulf","html_url":"https://github.com/lulf","followers_url":"https://api.github.com/users/lulf/followers","following_url":"https://api.github.com/users/lulf/following{/other_user}","gists_url":"https://api.github.com/users/lulf/gists{/gist_id}","starred_url":"https://api.github.com/users/lulf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lulf/subscriptions","organizations_url":"https://api.github.com/users/lulf/orgs","repos_url":"https://api.github.com/users/lulf/repos","events_url":"https://api.github.com/users/lulf/events{/privacy}","received_events_url":"https://api.github.com/users/lulf/received_events","type":"User","site_admin":false},"body":"This change moves to use 'enmasse-infra' instead 'myproject' as the default project assumed by the YAML files, and makes it configurable at template build time.\r\n\r\nThe documentation is updated to support installation using the YAML bundles, and there are some cleanup/fixes in the docs to be able to substitute the default project in the documentation.","created_at":"2018-10-19T10:34:48Z","updated_at":"2018-10-22T13:52:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f62c3af0a6092a190d1e72795e8dd93799ce0a8b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"k-wall","id":18440250,"node_id":"MDQ6VXNlcjE4NDQwMjUw","avatar_url":"https://avatars2.githubusercontent.com/u/18440250?v=4","gravatar_id":"","url":"https://api.github.com/users/k-wall","html_url":"https://github.com/k-wall","followers_url":"https://api.github.com/users/k-wall/followers","following_url":"https://api.github.com/users/k-wall/following{/other_user}","gists_url":"https://api.github.com/users/k-wall/gists{/gist_id}","starred_url":"https://api.github.com/users/k-wall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-wall/subscriptions","organizations_url":"https://api.github.com/users/k-wall/orgs","repos_url":"https://api.github.com/users/k-wall/repos","events_url":"https://api.github.com/users/k-wall/events{/privacy}","received_events_url":"https://api.github.com/users/k-wall/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":711505568,"node_id":"MDU6TGFiZWw3MTE1MDU1Njg=","url":"https://api.github.com/repos/EnMasseProject/enmasse/labels/Peer%20Review%20Needed","name":"Peer Review Needed","color":"fbca04","default":false},{"id":816167394,"node_id":"MDU6TGFiZWw4MTYxNjczOTQ=","url":"https://api.github.com/repos/EnMasseProject/enmasse/labels/component/documentation","name":"component/documentation","color":"82f226","default":false},{"id":816079807,"node_id":"MDU6TGFiZWw4MTYwNzk4MDc=","url":"https://api.github.com/repos/EnMasseProject/enmasse/labels/component/templates","name":"component/templates","color":"9da8ea","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/1816/commits","review_comments_url":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/1816/comments","review_comment_url":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EnMasseProject/enmasse/issues/1816/comments","statuses_url":"https://api.github.com/repos/EnMasseProject/enmasse/statuses/c6019175192d37ffb22da2e11d8692e91889c2ed","head":{"label":"lulf:image-location-and-doc-fixes","ref":"image-location-and-doc-fixes","sha":"c6019175192d37ffb22da2e11d8692e91889c2ed","user":{"login":"lulf","id":19670,"node_id":"MDQ6VXNlcjE5Njcw","avatar_url":"https://avatars0.githubusercontent.com/u/19670?v=4","gravatar_id":"","url":"https://api.github.com/users/lulf","html_url":"https://github.com/lulf","followers_url":"https://api.github.com/users/lulf/followers","following_url":"https://api.github.com/users/lulf/following{/other_user}","gists_url":"https://api.github.com/users/lulf/gists{/gist_id}","starred_url":"https://api.github.com/users/lulf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lulf/subscriptions","organizations_url":"https://api.github.com/users/lulf/orgs","repos_url":"https://api.github.com/users/lulf/repos","events_url":"https://api.github.com/users/lulf/events{/privacy}","received_events_url":"https://api.github.com/users/lulf/received_events","type":"User","site_admin":false},"repo":{"id":135259492,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUyNTk0OTI=","name":"enmasse","full_name":"lulf/enmasse","private":false,"owner":{"login":"lulf","id":19670,"node_id":"MDQ6VXNlcjE5Njcw","avatar_url":"https://avatars0.githubusercontent.com/u/19670?v=4","gravatar_id":"","url":"https://api.github.com/users/lulf","html_url":"https://github.com/lulf","followers_url":"https://api.github.com/users/lulf/followers","following_url":"https://api.github.com/users/lulf/following{/other_user}","gists_url":"https://api.github.com/users/lulf/gists{/gist_id}","starred_url":"https://api.github.com/users/lulf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lulf/subscriptions","organizations_url":"https://api.github.com/users/lulf/orgs","repos_url":"https://api.github.com/users/lulf/repos","events_url":"https://api.github.com/users/lulf/events{/privacy}","received_events_url":"https://api.github.com/users/lulf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lulf/enmasse","description":"EnMasse main repository","fork":true,"url":"https://api.github.com/repos/lulf/enmasse","forks_url":"https://api.github.com/repos/lulf/enmasse/forks","keys_url":"https://api.github.com/repos/lulf/enmasse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lulf/enmasse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lulf/enmasse/teams","hooks_url":"https://api.github.com/repos/lulf/enmasse/hooks","issue_events_url":"https://api.github.com/repos/lulf/enmasse/issues/events{/number}","events_url":"https://api.github.com/repos/lulf/enmasse/events","assignees_url":"https://api.github.com/repos/lulf/enmasse/assignees{/user}","branches_url":"https://api.github.com/repos/lulf/enmasse/branches{/branch}","tags_url":"https://api.github.com/repos/lulf/enmasse/tags","blobs_url":"https://api.github.com/repos/lulf/enmasse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lulf/enmasse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lulf/enmasse/git/refs{/sha}","trees_url":"https://api.github.com/repos/lulf/enmasse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lulf/enmasse/statuses/{sha}","languages_url":"https://api.github.com/repos/lulf/enmasse/languages","stargazers_url":"https://api.github.com/repos/lulf/enmasse/stargazers","contributors_url":"https://api.github.com/repos/lulf/enmasse/contributors","subscribers_url":"https://api.github.com/repos/lulf/enmasse/subscribers","subscription_url":"https://api.github.com/repos/lulf/enmasse/subscription","commits_url":"https://api.github.com/repos/lulf/enmasse/commits{/sha}","git_commits_url":"https://api.github.com/repos/lulf/enmasse/git/commits{/sha}","comments_url":"https://api.github.com/repos/lulf/enmasse/comments{/number}","issue_comment_url":"https://api.github.com/repos/lulf/enmasse/issues/comments{/number}","contents_url":"https://api.github.com/repos/lulf/enmasse/contents/{+path}","compare_url":"https://api.github.com/repos/lulf/enmasse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lulf/enmasse/merges","archive_url":"https://api.github.com/repos/lulf/enmasse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lulf/enmasse/downloads","issues_url":"https://api.github.com/repos/lulf/enmasse/issues{/number}","pulls_url":"https://api.github.com/repos/lulf/enmasse/pulls{/number}","milestones_url":"https://api.github.com/repos/lulf/enmasse/milestones{/number}","notifications_url":"https://api.github.com/repos/lulf/enmasse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lulf/enmasse/labels{/name}","releases_url":"https://api.github.com/repos/lulf/enmasse/releases{/id}","deployments_url":"https://api.github.com/repos/lulf/enmasse/deployments","created_at":"2018-05-29T07:40:48Z","updated_at":"2018-10-22T05:33:04Z","pushed_at":"2018-10-22T11:40:33Z","git_url":"git://github.com/lulf/enmasse.git","ssh_url":"git@github.com:lulf/enmasse.git","clone_url":"https://github.com/lulf/enmasse.git","svn_url":"https://github.com/lulf/enmasse","homepage":"","size":29099,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EnMasseProject:master","ref":"master","sha":"7d2ad9a971733e9e5ae42be4d014ea4a89c83d07","user":{"login":"EnMasseProject","id":19907745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTA3NzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/19907745?v=4","gravatar_id":"","url":"https://api.github.com/users/EnMasseProject","html_url":"https://github.com/EnMasseProject","followers_url":"https://api.github.com/users/EnMasseProject/followers","following_url":"https://api.github.com/users/EnMasseProject/following{/other_user}","gists_url":"https://api.github.com/users/EnMasseProject/gists{/gist_id}","starred_url":"https://api.github.com/users/EnMasseProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnMasseProject/subscriptions","organizations_url":"https://api.github.com/users/EnMasseProject/orgs","repos_url":"https://api.github.com/users/EnMasseProject/repos","events_url":"https://api.github.com/users/EnMasseProject/events{/privacy}","received_events_url":"https://api.github.com/users/EnMasseProject/received_events","type":"Organization","site_admin":false},"repo":{"id":62793144,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjc5MzE0NA==","name":"enmasse","full_name":"EnMasseProject/enmasse","private":false,"owner":{"login":"EnMasseProject","id":19907745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5OTA3NzQ1","avatar_url":"https://avatars1.githubusercontent.com/u/19907745?v=4","gravatar_id":"","url":"https://api.github.com/users/EnMasseProject","html_url":"https://github.com/EnMasseProject","followers_url":"https://api.github.com/users/EnMasseProject/followers","following_url":"https://api.github.com/users/EnMasseProject/following{/other_user}","gists_url":"https://api.github.com/users/EnMasseProject/gists{/gist_id}","starred_url":"https://api.github.com/users/EnMasseProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EnMasseProject/subscriptions","organizations_url":"https://api.github.com/users/EnMasseProject/orgs","repos_url":"https://api.github.com/users/EnMasseProject/repos","events_url":"https://api.github.com/users/EnMasseProject/events{/privacy}","received_events_url":"https://api.github.com/users/EnMasseProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EnMasseProject/enmasse","description":"EnMasse - Self-service messaging on Kubernetes and OpenShift","fork":false,"url":"https://api.github.com/repos/EnMasseProject/enmasse","forks_url":"https://api.github.com/repos/EnMasseProject/enmasse/forks","keys_url":"https://api.github.com/repos/EnMasseProject/enmasse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EnMasseProject/enmasse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EnMasseProject/enmasse/teams","hooks_url":"https://api.github.com/repos/EnMasseProject/enmasse/hooks","issue_events_url":"https://api.github.com/repos/EnMasseProject/enmasse/issues/events{/number}","events_url":"https://api.github.com/repos/EnMasseProject/enmasse/events","assignees_url":"https://api.github.com/repos/EnMasseProject/enmasse/assignees{/user}","branches_url":"https://api.github.com/repos/EnMasseProject/enmasse/branches{/branch}","tags_url":"https://api.github.com/repos/EnMasseProject/enmasse/tags","blobs_url":"https://api.github.com/repos/EnMasseProject/enmasse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EnMasseProject/enmasse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EnMasseProject/enmasse/git/refs{/sha}","trees_url":"https://api.github.com/repos/EnMasseProject/enmasse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EnMasseProject/enmasse/statuses/{sha}","languages_url":"https://api.github.com/repos/EnMasseProject/enmasse/languages","stargazers_url":"https://api.github.com/repos/EnMasseProject/enmasse/stargazers","contributors_url":"https://api.github.com/repos/EnMasseProject/enmasse/contributors","subscribers_url":"https://api.github.com/repos/EnMasseProject/enmasse/subscribers","subscription_url":"https://api.github.com/repos/EnMasseProject/enmasse/subscription","commits_url":"https://api.github.com/repos/EnMasseProject/enmasse/commits{/sha}","git_commits_url":"https://api.github.com/repos/EnMasseProject/enmasse/git/commits{/sha}","comments_url":"https://api.github.com/repos/EnMasseProject/enmasse/comments{/number}","issue_comment_url":"https://api.github.com/repos/EnMasseProject/enmasse/issues/comments{/number}","contents_url":"https://api.github.com/repos/EnMasseProject/enmasse/contents/{+path}","compare_url":"https://api.github.com/repos/EnMasseProject/enmasse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EnMasseProject/enmasse/merges","archive_url":"https://api.github.com/repos/EnMasseProject/enmasse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EnMasseProject/enmasse/downloads","issues_url":"https://api.github.com/repos/EnMasseProject/enmasse/issues{/number}","pulls_url":"https://api.github.com/repos/EnMasseProject/enmasse/pulls{/number}","milestones_url":"https://api.github.com/repos/EnMasseProject/enmasse/milestones{/number}","notifications_url":"https://api.github.com/repos/EnMasseProject/enmasse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EnMasseProject/enmasse/labels{/name}","releases_url":"https://api.github.com/repos/EnMasseProject/enmasse/releases{/id}","deployments_url":"https://api.github.com/repos/EnMasseProject/enmasse/deployments","created_at":"2016-07-07T09:18:27Z","updated_at":"2018-10-22T12:57:25Z","pushed_at":"2018-10-22T13:01:54Z","git_url":"git://github.com/EnMasseProject/enmasse.git","ssh_url":"git@github.com:EnMasseProject/enmasse.git","clone_url":"https://github.com/EnMasseProject/enmasse.git","svn_url":"https://github.com/EnMasseProject/enmasse","homepage":"http://enmasse.io","size":28605,"stargazers_count":105,"watchers_count":105,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":196,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":46,"open_issues":196,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/1816"},"html":{"href":"https://github.com/EnMasseProject/enmasse/pull/1816"},"issue":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/issues/1816"},"comments":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/issues/1816/comments"},"review_comments":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/1816/comments"},"review_comment":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/pulls/1816/commits"},"statuses":{"href":"https://api.github.com/repos/EnMasseProject/enmasse/statuses/c6019175192d37ffb22da2e11d8692e91889c2ed"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jenmalloy"}}