{"action":"closed","number":746,"pull_request":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/746","id":169549794,"html_url":"https://github.com/confluentinc/ksql/pull/746","diff_url":"https://github.com/confluentinc/ksql/pull/746.diff","patch_url":"https://github.com/confluentinc/ksql/pull/746.patch","issue_url":"https://api.github.com/repos/confluentinc/ksql/issues/746","number":746,"state":"closed","locked":false,"title":"Use equals/compareTo for comparison expressions","user":{"login":"rodesai","id":2610028,"avatar_url":"https://avatars0.githubusercontent.com/u/2610028?v=4","gravatar_id":"","url":"https://api.github.com/users/rodesai","html_url":"https://github.com/rodesai","followers_url":"https://api.github.com/users/rodesai/followers","following_url":"https://api.github.com/users/rodesai/following{/other_user}","gists_url":"https://api.github.com/users/rodesai/gists{/gist_id}","starred_url":"https://api.github.com/users/rodesai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodesai/subscriptions","organizations_url":"https://api.github.com/users/rodesai/orgs","repos_url":"https://api.github.com/users/rodesai/repos","events_url":"https://api.github.com/users/rodesai/events{/privacy}","received_events_url":"https://api.github.com/users/rodesai/received_events","type":"User","site_admin":false},"body":"Use equals instead of ==/!= operators for comparison expressions. This\r\nensures that we check value equality for primitive types rather than\r\nreference equality of the wrapper objets. This patch also includes a\r\nchange to use compareTo for ordering comparisons. Though not necessary\r\nfor primitives, this lets us support ordering comparisons for Strings\r\nwhich would previously have failed.\r\n\r\nFixes #733 ","created_at":"2018-02-16T05:18:22Z","updated_at":"2018-02-16T22:12:13Z","closed_at":"2018-02-16T22:12:13Z","merged_at":null,"merge_commit_sha":"8ac3fdbe6692e26856a098369907a1c2aa8eff90","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dguy","id":54829,"avatar_url":"https://avatars2.githubusercontent.com/u/54829?v=4","gravatar_id":"","url":"https://api.github.com/users/dguy","html_url":"https://github.com/dguy","followers_url":"https://api.github.com/users/dguy/followers","following_url":"https://api.github.com/users/dguy/following{/other_user}","gists_url":"https://api.github.com/users/dguy/gists{/gist_id}","starred_url":"https://api.github.com/users/dguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguy/subscriptions","organizations_url":"https://api.github.com/users/dguy/orgs","repos_url":"https://api.github.com/users/dguy/repos","events_url":"https://api.github.com/users/dguy/events{/privacy}","received_events_url":"https://api.github.com/users/dguy/received_events","type":"User","site_admin":false},{"login":"apurvam","id":830220,"avatar_url":"https://avatars0.githubusercontent.com/u/830220?v=4","gravatar_id":"","url":"https://api.github.com/users/apurvam","html_url":"https://github.com/apurvam","followers_url":"https://api.github.com/users/apurvam/followers","following_url":"https://api.github.com/users/apurvam/following{/other_user}","gists_url":"https://api.github.com/users/apurvam/gists{/gist_id}","starred_url":"https://api.github.com/users/apurvam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apurvam/subscriptions","organizations_url":"https://api.github.com/users/apurvam/orgs","repos_url":"https://api.github.com/users/apurvam/repos","events_url":"https://api.github.com/users/apurvam/events{/privacy}","received_events_url":"https://api.github.com/users/apurvam/received_events","type":"User","site_admin":false},{"login":"bluemonk3y","id":10532006,"avatar_url":"https://avatars3.githubusercontent.com/u/10532006?v=4","gravatar_id":"","url":"https://api.github.com/users/bluemonk3y","html_url":"https://github.com/bluemonk3y","followers_url":"https://api.github.com/users/bluemonk3y/followers","following_url":"https://api.github.com/users/bluemonk3y/following{/other_user}","gists_url":"https://api.github.com/users/bluemonk3y/gists{/gist_id}","starred_url":"https://api.github.com/users/bluemonk3y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluemonk3y/subscriptions","organizations_url":"https://api.github.com/users/bluemonk3y/orgs","repos_url":"https://api.github.com/users/bluemonk3y/repos","events_url":"https://api.github.com/users/bluemonk3y/events{/privacy}","received_events_url":"https://api.github.com/users/bluemonk3y/received_events","type":"User","site_admin":false},{"login":"hjafarpour","id":16784742,"avatar_url":"https://avatars3.githubusercontent.com/u/16784742?v=4","gravatar_id":"","url":"https://api.github.com/users/hjafarpour","html_url":"https://github.com/hjafarpour","followers_url":"https://api.github.com/users/hjafarpour/followers","following_url":"https://api.github.com/users/hjafarpour/following{/other_user}","gists_url":"https://api.github.com/users/hjafarpour/gists{/gist_id}","starred_url":"https://api.github.com/users/hjafarpour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjafarpour/subscriptions","organizations_url":"https://api.github.com/users/hjafarpour/orgs","repos_url":"https://api.github.com/users/hjafarpour/repos","events_url":"https://api.github.com/users/hjafarpour/events{/privacy}","received_events_url":"https://api.github.com/users/hjafarpour/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/ksql/pulls/746/commits","review_comments_url":"https://api.github.com/repos/confluentinc/ksql/pulls/746/comments","review_comment_url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/ksql/issues/746/comments","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/f5433ff9e30d7fac124f8b79a05c25ace6c4c2c7","head":{"label":"confluentinc:codegen_comparisons_fix","ref":"codegen_comparisons_fix","sha":"f5433ff9e30d7fac124f8b79a05c25ace6c4c2c7","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":69400326,"name":"ksql","full_name":"confluentinc/ksql","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/ksql","description":"KSQL - the Streaming SQL Engine for Apache Kafka ","fork":false,"url":"https://api.github.com/repos/confluentinc/ksql","forks_url":"https://api.github.com/repos/confluentinc/ksql/forks","keys_url":"https://api.github.com/repos/confluentinc/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/ksql/teams","hooks_url":"https://api.github.com/repos/confluentinc/ksql/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/ksql/events","assignees_url":"https://api.github.com/repos/confluentinc/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/ksql/tags","blobs_url":"https://api.github.com/repos/confluentinc/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/ksql/languages","stargazers_url":"https://api.github.com/repos/confluentinc/ksql/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/ksql/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/ksql/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/ksql/subscription","commits_url":"https://api.github.com/repos/confluentinc/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/ksql/merges","archive_url":"https://api.github.com/repos/confluentinc/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/ksql/downloads","issues_url":"https://api.github.com/repos/confluentinc/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/ksql/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/ksql/deployments","created_at":"2016-09-27T21:30:15Z","updated_at":"2018-02-16T18:47:38Z","pushed_at":"2018-02-16T20:45:55Z","git_url":"git://github.com/confluentinc/ksql.git","ssh_url":"git@github.com:confluentinc/ksql.git","clone_url":"https://github.com/confluentinc/ksql.git","svn_url":"https://github.com/confluentinc/ksql","homepage":"","size":5953,"stargazers_count":1370,"watchers_count":1370,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":247,"mirror_url":null,"archived":false,"open_issues_count":124,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":247,"open_issues":124,"watchers":1370,"default_branch":"master"}},"base":{"label":"confluentinc:master","ref":"master","sha":"929e9398be26d296313fbc0497ace86ff60d8458","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":69400326,"name":"ksql","full_name":"confluentinc/ksql","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/ksql","description":"KSQL - the Streaming SQL Engine for Apache Kafka ","fork":false,"url":"https://api.github.com/repos/confluentinc/ksql","forks_url":"https://api.github.com/repos/confluentinc/ksql/forks","keys_url":"https://api.github.com/repos/confluentinc/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/ksql/teams","hooks_url":"https://api.github.com/repos/confluentinc/ksql/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/ksql/events","assignees_url":"https://api.github.com/repos/confluentinc/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/ksql/tags","blobs_url":"https://api.github.com/repos/confluentinc/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/ksql/languages","stargazers_url":"https://api.github.com/repos/confluentinc/ksql/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/ksql/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/ksql/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/ksql/subscription","commits_url":"https://api.github.com/repos/confluentinc/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/ksql/merges","archive_url":"https://api.github.com/repos/confluentinc/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/ksql/downloads","issues_url":"https://api.github.com/repos/confluentinc/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/ksql/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/ksql/deployments","created_at":"2016-09-27T21:30:15Z","updated_at":"2018-02-16T18:47:38Z","pushed_at":"2018-02-16T20:45:55Z","git_url":"git://github.com/confluentinc/ksql.git","ssh_url":"git@github.com:confluentinc/ksql.git","clone_url":"https://github.com/confluentinc/ksql.git","svn_url":"https://github.com/confluentinc/ksql","homepage":"","size":5953,"stargazers_count":1370,"watchers_count":1370,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":247,"mirror_url":null,"archived":false,"open_issues_count":124,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":247,"open_issues":124,"watchers":1370,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/746"},"html":{"href":"https://github.com/confluentinc/ksql/pull/746"},"issue":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/746"},"comments":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/746/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/746/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/746/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/ksql/statuses/f5433ff9e30d7fac124f8b79a05c25ace6c4c2c7"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":185,"deletions":17,"changed_files":3}}
{"actor":{"display_login":"rodesai"}}