{"action":"created","issue":{"url":"https://api.github.com/repos/semperfiwebdesign/all-in-one-seo-pack/issues/1774","repository_url":"https://api.github.com/repos/semperfiwebdesign/all-in-one-seo-pack","labels_url":"https://api.github.com/repos/semperfiwebdesign/all-in-one-seo-pack/issues/1774/labels{/name}","comments_url":"https://api.github.com/repos/semperfiwebdesign/all-in-one-seo-pack/issues/1774/comments","events_url":"https://api.github.com/repos/semperfiwebdesign/all-in-one-seo-pack/issues/1774/events","html_url":"https://github.com/semperfiwebdesign/all-in-one-seo-pack/issues/1774","id":340481656,"node_id":"MDU6SXNzdWUzNDA0ODE2NTY=","number":1774,"title":"FTP credentials required on every pageload bug","user":{"login":"michaeltorbert","id":17364998,"node_id":"MDQ6VXNlcjE3MzY0OTk4","avatar_url":"https://avatars1.githubusercontent.com/u/17364998?v=4","gravatar_id":"","url":"https://api.github.com/users/michaeltorbert","html_url":"https://github.com/michaeltorbert","followers_url":"https://api.github.com/users/michaeltorbert/followers","following_url":"https://api.github.com/users/michaeltorbert/following{/other_user}","gists_url":"https://api.github.com/users/michaeltorbert/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeltorbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeltorbert/subscriptions","organizations_url":"https://api.github.com/users/michaeltorbert/orgs","repos_url":"https://api.github.com/users/michaeltorbert/repos","events_url":"https://api.github.com/users/michaeltorbert/events{/privacy}","received_events_url":"https://api.github.com/users/michaeltorbert/received_events","type":"User","site_admin":false},"labels":[{"id":333861260,"node_id":"MDU6TGFiZWwzMzM4NjEyNjA=","url":"https://api.github.com/repos/semperfiwebdesign/all-in-one-seo-pack/labels/Needs%20Testing","name":"Needs Testing","color":"FFFF00","default":false},{"id":346514943,"node_id":"MDU6TGFiZWwzNDY1MTQ5NDM=","url":"https://api.github.com/repos/semperfiwebdesign/all-in-one-seo-pack/labels/Priority%20%7C%20High","name":"Priority | High","color":"ff0000","default":false}],"state":"open","locked":false,"assignee":{"login":"wpsmort","id":17548525,"node_id":"MDQ6VXNlcjE3NTQ4NTI1","avatar_url":"https://avatars1.githubusercontent.com/u/17548525?v=4","gravatar_id":"","url":"https://api.github.com/users/wpsmort","html_url":"https://github.com/wpsmort","followers_url":"https://api.github.com/users/wpsmort/followers","following_url":"https://api.github.com/users/wpsmort/following{/other_user}","gists_url":"https://api.github.com/users/wpsmort/gists{/gist_id}","starred_url":"https://api.github.com/users/wpsmort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpsmort/subscriptions","organizations_url":"https://api.github.com/users/wpsmort/orgs","repos_url":"https://api.github.com/users/wpsmort/repos","events_url":"https://api.github.com/users/wpsmort/events{/privacy}","received_events_url":"https://api.github.com/users/wpsmort/received_events","type":"User","site_admin":false},"assignees":[{"login":"wpsmort","id":17548525,"node_id":"MDQ6VXNlcjE3NTQ4NTI1","avatar_url":"https://avatars1.githubusercontent.com/u/17548525?v=4","gravatar_id":"","url":"https://api.github.com/users/wpsmort","html_url":"https://github.com/wpsmort","followers_url":"https://api.github.com/users/wpsmort/followers","following_url":"https://api.github.com/users/wpsmort/following{/other_user}","gists_url":"https://api.github.com/users/wpsmort/gists{/gist_id}","starred_url":"https://api.github.com/users/wpsmort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpsmort/subscriptions","organizations_url":"https://api.github.com/users/wpsmort/orgs","repos_url":"https://api.github.com/users/wpsmort/repos","events_url":"https://api.github.com/users/wpsmort/events{/privacy}","received_events_url":"https://api.github.com/users/wpsmort/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/semperfiwebdesign/all-in-one-seo-pack/milestones/75","html_url":"https://github.com/semperfiwebdesign/all-in-one-seo-pack/milestone/75","labels_url":"https://api.github.com/repos/semperfiwebdesign/all-in-one-seo-pack/milestones/75/labels","id":3445094,"node_id":"MDk6TWlsZXN0b25lMzQ0NTA5NA==","number":75,"title":"2.7.1","description":null,"creator":{"login":"michaeltorbert","id":17364998,"node_id":"MDQ6VXNlcjE3MzY0OTk4","avatar_url":"https://avatars1.githubusercontent.com/u/17364998?v=4","gravatar_id":"","url":"https://api.github.com/users/michaeltorbert","html_url":"https://github.com/michaeltorbert","followers_url":"https://api.github.com/users/michaeltorbert/followers","following_url":"https://api.github.com/users/michaeltorbert/following{/other_user}","gists_url":"https://api.github.com/users/michaeltorbert/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeltorbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeltorbert/subscriptions","organizations_url":"https://api.github.com/users/michaeltorbert/orgs","repos_url":"https://api.github.com/users/michaeltorbert/repos","events_url":"https://api.github.com/users/michaeltorbert/events{/privacy}","received_events_url":"https://api.github.com/users/michaeltorbert/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":3,"state":"open","created_at":"2018-06-22T14:50:50Z","updated_at":"2018-07-13T19:57:28Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-07-12T04:03:05Z","updated_at":"2018-07-13T19:58:24Z","closed_at":null,"author_association":"MEMBER","body":"This happens with some sites that have whatever filesystem issues (no suexec, incorrect permissions, not having FS_METHOD as direct, or whatever). (Reported by Eric in email)\r\n\r\nFor testing, we can force the issue by changing FS_Method to ftpsockets in wp-config.php\r\n\r\n<img width=\"1408\" alt=\"screen shot 2018-07-12 at 12 02 04 am\" src=\"https://user-images.githubusercontent.com/17364998/42612011-e516c14e-8566-11e8-83bf-6b3dd6f6a556.png\">\r\n\r\nThe problem is has_physical_file() may be getting called on every pageload, ultimately meaning request_filesystem_credentials() is getting called on every pageload.\r\n\r\nhttps://github.com/semperfiwebdesign/all-in-one-seo-pack/commit/6b15775b799d5f90ea78d0b9139f7af69c74df04#diff-afdd82b6421840c82e93c85bac49b713R82\r\n\r\n\r\nOffhand I'd recommend something like this to move it out of the construct:\r\n\r\n\r\n\r\n$dirname = AIOSEOP_PLUGIN_DIRNAME;\r\n\t\t\t$robots_admin_page = \"all-in-one-seo_page_$dirname/modules/aioseop_robots\";\r\n\t\t    add_action('load-'.$my_admin_page, array( $this, function_to_wrap_has_physical_file_call_in ) );\r\n\t\t}\r\n\t\t\r\n\t\t\tfunction function_to_wrap_has_physical_file_call_in\r\n\r\n\t\t\tif ( $this->has_physical_file() ) {\r\n\t\t\t\tif ( ( is_multisite() && is_network_admin() ) || ( ! is_multisite() && current_user_can( 'manage_options') ) ) {\r\n\t\t\r\n\r\n\r\n-----------\r\n\r\nThis will at least restrict it to the robots.txt options page... then we need to figure out where to go from there to not have it request filesystem credentials every time we want to access the filesystem. If we can't access it, we should fail gracefully.\r\n\r\nIn the sitemap module, it uses add_action( $this->prefix . 'settings_header'...  \r\nin add_page_hooks()\r\n"},"comment":{"url":"https://api.github.com/repos/semperfiwebdesign/all-in-one-seo-pack/issues/comments/404937960","html_url":"https://github.com/semperfiwebdesign/all-in-one-seo-pack/issues/1774#issuecomment-404937960","issue_url":"https://api.github.com/repos/semperfiwebdesign/all-in-one-seo-pack/issues/1774","id":404937960,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDkzNzk2MA==","user":{"login":"wpsmort","id":17548525,"node_id":"MDQ6VXNlcjE3NTQ4NTI1","avatar_url":"https://avatars1.githubusercontent.com/u/17548525?v=4","gravatar_id":"","url":"https://api.github.com/users/wpsmort","html_url":"https://github.com/wpsmort","followers_url":"https://api.github.com/users/wpsmort/followers","following_url":"https://api.github.com/users/wpsmort/following{/other_user}","gists_url":"https://api.github.com/users/wpsmort/gists{/gist_id}","starred_url":"https://api.github.com/users/wpsmort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wpsmort/subscriptions","organizations_url":"https://api.github.com/users/wpsmort/orgs","repos_url":"https://api.github.com/users/wpsmort/repos","events_url":"https://api.github.com/users/wpsmort/events{/privacy}","received_events_url":"https://api.github.com/users/wpsmort/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T19:58:24Z","updated_at":"2018-07-13T19:58:24Z","author_association":"MEMBER","body":"Testing identified a bug and issue #1785 was opened to fix this in v2.7.2.  Leaving this open until everything has been resolved and users have been notified."}}
{"actor":{"display_login":"wpsmort"}}