{"action":"created","comment":{"url":"https://api.github.com/repos/livecode/livecode/pulls/comments/210221302","pull_request_review_id":146387648,"id":210221302,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDIyMTMwMg==","diff_hunk":"@@ -76,6 +80,188 @@ UTC that the clock should display.\n property timeZone\t\tget mTimeZone\t\tset setTimeZone\n metadata timeZone.editor is \"com.livecode.pi.timezone\"\n metadata timeZone.label is \"Timezone\"\n+\n+/**\n+Syntax: set the dayNumberColor of <widget> to <color>\n+Syntax: get the dayNumberColor of <widget>\n+\n+Summary: Determines the color of the numbers on the clock during the day\n+\n+Description:\n+Use the <dayNumberColor> property to get or set the text color of the numbers\n+on the face of the clock during the day. To determine if the clock is\n+displaying its daytime or night-time colors use the read-only property\n+<isDay>.\n+*/\n+property dayNumberColor get getDayNumberColor set setDayNumberColor\n+metadata dayNumberColor.editor is \"com.livecode.pi.color\"\n+metadata dayNumberColor.default is \"0,0,0\"\n+metadata dayNumberColor.section is \"Colors\"\n+metadata dayNumberColor.label is \"Number color (day)\"","path":"extensions/widgets/clock/clock.lcb","position":52,"original_position":52,"commit_id":"5a8c55556a1d3dbe0cbb69841b5167f3aaffdb0e","original_commit_id":"5a8c55556a1d3dbe0cbb69841b5167f3aaffdb0e","user":{"login":"livecodeali","id":3985854,"node_id":"MDQ6VXNlcjM5ODU4NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3985854?v=4","gravatar_id":"","url":"https://api.github.com/users/livecodeali","html_url":"https://github.com/livecodeali","followers_url":"https://api.github.com/users/livecodeali/followers","following_url":"https://api.github.com/users/livecodeali/following{/other_user}","gists_url":"https://api.github.com/users/livecodeali/gists{/gist_id}","starred_url":"https://api.github.com/users/livecodeali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecodeali/subscriptions","organizations_url":"https://api.github.com/users/livecodeali/orgs","repos_url":"https://api.github.com/users/livecodeali/repos","events_url":"https://api.github.com/users/livecodeali/events{/privacy}","received_events_url":"https://api.github.com/users/livecodeali/received_events","type":"User","site_admin":false},"body":"There's (probably) no reason not to allow the colors to have alpha values - all you'd need to do is use the \r\n`\"com.livecode.pi.colorwithalpha\"` editor and make sure all the default color strings have full opacity as the fourth item","created_at":"2018-08-15T09:51:45Z","updated_at":"2018-08-15T09:52:42Z","html_url":"https://github.com/livecode/livecode/pull/6638#discussion_r210221302","pull_request_url":"https://api.github.com/repos/livecode/livecode/pulls/6638","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments/210221302"},"html":{"href":"https://github.com/livecode/livecode/pull/6638#discussion_r210221302"},"pull_request":{"href":"https://api.github.com/repos/livecode/livecode/pulls/6638"}}},"pull_request":{"url":"https://api.github.com/repos/livecode/livecode/pulls/6638","id":208516980,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NTE2OTgw","html_url":"https://github.com/livecode/livecode/pull/6638","diff_url":"https://github.com/livecode/livecode/pull/6638.diff","patch_url":"https://github.com/livecode/livecode/pull/6638.patch","issue_url":"https://api.github.com/repos/livecode/livecode/issues/6638","number":6638,"state":"open","locked":false,"title":"[[Bugfix 19619]] Add color to the clock widget","user":{"login":"andrewferguson","id":13520045,"node_id":"MDQ6VXNlcjEzNTIwMDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/13520045?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewferguson","html_url":"https://github.com/andrewferguson","followers_url":"https://api.github.com/users/andrewferguson/followers","following_url":"https://api.github.com/users/andrewferguson/following{/other_user}","gists_url":"https://api.github.com/users/andrewferguson/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewferguson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewferguson/subscriptions","organizations_url":"https://api.github.com/users/andrewferguson/orgs","repos_url":"https://api.github.com/users/andrewferguson/repos","events_url":"https://api.github.com/users/andrewferguson/events{/privacy}","received_events_url":"https://api.github.com/users/andrewferguson/received_events","type":"User","site_admin":false},"body":"I've added several new properties to the clock widget to allow for the colors of the various components (numbers, second hand, minute hand, hour hand, face) to be changed. In total there are ten new properties: five for the day and five for night.\r\n\r\nI did consider trying to use existing LiveCode properties such as the backgroundColor for the face color and the foregroundColor for the number color, but this was complicated by the clock having day and night modes which meant that either the colors would be inverted at night (potentially leading to an ugly appearance - particularly because the night mode cannot be disabled) or a separate set of properties would be created for the night. In the end I decided on going for a whole new set of properties that could be named consistently.\r\n\r\nI've updated both the tests and the documentation for the clock widget to include these new properties.","created_at":"2018-08-15T09:40:59Z","updated_at":"2018-08-15T09:52:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"548c9f865af513169d9b4b516c393cbb5219f1f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/livecode/livecode/pulls/6638/commits","review_comments_url":"https://api.github.com/repos/livecode/livecode/pulls/6638/comments","review_comment_url":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/livecode/livecode/issues/6638/comments","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/5a8c55556a1d3dbe0cbb69841b5167f3aaffdb0e","head":{"label":"andrewferguson:bugfix-19619","ref":"bugfix-19619","sha":"5a8c55556a1d3dbe0cbb69841b5167f3aaffdb0e","user":{"login":"andrewferguson","id":13520045,"node_id":"MDQ6VXNlcjEzNTIwMDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/13520045?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewferguson","html_url":"https://github.com/andrewferguson","followers_url":"https://api.github.com/users/andrewferguson/followers","following_url":"https://api.github.com/users/andrewferguson/following{/other_user}","gists_url":"https://api.github.com/users/andrewferguson/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewferguson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewferguson/subscriptions","organizations_url":"https://api.github.com/users/andrewferguson/orgs","repos_url":"https://api.github.com/users/andrewferguson/repos","events_url":"https://api.github.com/users/andrewferguson/events{/privacy}","received_events_url":"https://api.github.com/users/andrewferguson/received_events","type":"User","site_admin":false},"repo":{"id":144571181,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1NzExODE=","name":"livecode","full_name":"andrewferguson/livecode","owner":{"login":"andrewferguson","id":13520045,"node_id":"MDQ6VXNlcjEzNTIwMDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/13520045?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewferguson","html_url":"https://github.com/andrewferguson","followers_url":"https://api.github.com/users/andrewferguson/followers","following_url":"https://api.github.com/users/andrewferguson/following{/other_user}","gists_url":"https://api.github.com/users/andrewferguson/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewferguson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewferguson/subscriptions","organizations_url":"https://api.github.com/users/andrewferguson/orgs","repos_url":"https://api.github.com/users/andrewferguson/repos","events_url":"https://api.github.com/users/andrewferguson/events{/privacy}","received_events_url":"https://api.github.com/users/andrewferguson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewferguson/livecode","description":"LiveCode cross-platform development environment (engine)","fork":true,"url":"https://api.github.com/repos/andrewferguson/livecode","forks_url":"https://api.github.com/repos/andrewferguson/livecode/forks","keys_url":"https://api.github.com/repos/andrewferguson/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewferguson/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewferguson/livecode/teams","hooks_url":"https://api.github.com/repos/andrewferguson/livecode/hooks","issue_events_url":"https://api.github.com/repos/andrewferguson/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/andrewferguson/livecode/events","assignees_url":"https://api.github.com/repos/andrewferguson/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/andrewferguson/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/andrewferguson/livecode/tags","blobs_url":"https://api.github.com/repos/andrewferguson/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewferguson/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewferguson/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewferguson/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewferguson/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewferguson/livecode/languages","stargazers_url":"https://api.github.com/repos/andrewferguson/livecode/stargazers","contributors_url":"https://api.github.com/repos/andrewferguson/livecode/contributors","subscribers_url":"https://api.github.com/repos/andrewferguson/livecode/subscribers","subscription_url":"https://api.github.com/repos/andrewferguson/livecode/subscription","commits_url":"https://api.github.com/repos/andrewferguson/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewferguson/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewferguson/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewferguson/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewferguson/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/andrewferguson/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewferguson/livecode/merges","archive_url":"https://api.github.com/repos/andrewferguson/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewferguson/livecode/downloads","issues_url":"https://api.github.com/repos/andrewferguson/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/andrewferguson/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewferguson/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewferguson/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewferguson/livecode/labels{/name}","releases_url":"https://api.github.com/repos/andrewferguson/livecode/releases{/id}","deployments_url":"https://api.github.com/repos/andrewferguson/livecode/deployments","created_at":"2018-08-13T11:34:03Z","updated_at":"2018-08-13T11:34:18Z","pushed_at":"2018-08-15T09:32:26Z","git_url":"git://github.com/andrewferguson/livecode.git","ssh_url":"git@github.com:andrewferguson/livecode.git","clone_url":"https://github.com/andrewferguson/livecode.git","svn_url":"https://github.com/andrewferguson/livecode","homepage":"https://livecode.com/","size":137052,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"livecode:develop","ref":"develop","sha":"12780f0013863491164799da9d80a809996974ce","user":{"login":"livecode","id":3985749,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODU3NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/3985749?v=4","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"repo":{"id":9334445,"node_id":"MDEwOlJlcG9zaXRvcnk5MzM0NDQ1","name":"livecode","full_name":"livecode/livecode","owner":{"login":"livecode","id":3985749,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5ODU3NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/3985749?v=4","gravatar_id":"","url":"https://api.github.com/users/livecode","html_url":"https://github.com/livecode","followers_url":"https://api.github.com/users/livecode/followers","following_url":"https://api.github.com/users/livecode/following{/other_user}","gists_url":"https://api.github.com/users/livecode/gists{/gist_id}","starred_url":"https://api.github.com/users/livecode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/livecode/subscriptions","organizations_url":"https://api.github.com/users/livecode/orgs","repos_url":"https://api.github.com/users/livecode/repos","events_url":"https://api.github.com/users/livecode/events{/privacy}","received_events_url":"https://api.github.com/users/livecode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/livecode/livecode","description":"LiveCode cross-platform development environment (engine)","fork":false,"url":"https://api.github.com/repos/livecode/livecode","forks_url":"https://api.github.com/repos/livecode/livecode/forks","keys_url":"https://api.github.com/repos/livecode/livecode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/livecode/livecode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/livecode/livecode/teams","hooks_url":"https://api.github.com/repos/livecode/livecode/hooks","issue_events_url":"https://api.github.com/repos/livecode/livecode/issues/events{/number}","events_url":"https://api.github.com/repos/livecode/livecode/events","assignees_url":"https://api.github.com/repos/livecode/livecode/assignees{/user}","branches_url":"https://api.github.com/repos/livecode/livecode/branches{/branch}","tags_url":"https://api.github.com/repos/livecode/livecode/tags","blobs_url":"https://api.github.com/repos/livecode/livecode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/livecode/livecode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/livecode/livecode/git/refs{/sha}","trees_url":"https://api.github.com/repos/livecode/livecode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/livecode/livecode/statuses/{sha}","languages_url":"https://api.github.com/repos/livecode/livecode/languages","stargazers_url":"https://api.github.com/repos/livecode/livecode/stargazers","contributors_url":"https://api.github.com/repos/livecode/livecode/contributors","subscribers_url":"https://api.github.com/repos/livecode/livecode/subscribers","subscription_url":"https://api.github.com/repos/livecode/livecode/subscription","commits_url":"https://api.github.com/repos/livecode/livecode/commits{/sha}","git_commits_url":"https://api.github.com/repos/livecode/livecode/git/commits{/sha}","comments_url":"https://api.github.com/repos/livecode/livecode/comments{/number}","issue_comment_url":"https://api.github.com/repos/livecode/livecode/issues/comments{/number}","contents_url":"https://api.github.com/repos/livecode/livecode/contents/{+path}","compare_url":"https://api.github.com/repos/livecode/livecode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/livecode/livecode/merges","archive_url":"https://api.github.com/repos/livecode/livecode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/livecode/livecode/downloads","issues_url":"https://api.github.com/repos/livecode/livecode/issues{/number}","pulls_url":"https://api.github.com/repos/livecode/livecode/pulls{/number}","milestones_url":"https://api.github.com/repos/livecode/livecode/milestones{/number}","notifications_url":"https://api.github.com/repos/livecode/livecode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/livecode/livecode/labels{/name}","releases_url":"https://api.github.com/repos/livecode/livecode/releases{/id}","deployments_url":"https://api.github.com/repos/livecode/livecode/deployments","created_at":"2013-04-10T00:15:57Z","updated_at":"2018-07-25T07:27:17Z","pushed_at":"2018-08-15T09:41:00Z","git_url":"git://github.com/livecode/livecode.git","ssh_url":"git@github.com:livecode/livecode.git","clone_url":"https://github.com/livecode/livecode.git","svn_url":"https://github.com/livecode/livecode","homepage":"https://livecode.com/","size":137547,"stargazers_count":211,"watchers_count":211,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"open_issues_count":148,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":137,"open_issues":148,"watchers":211,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/livecode/livecode/pulls/6638"},"html":{"href":"https://github.com/livecode/livecode/pull/6638"},"issue":{"href":"https://api.github.com/repos/livecode/livecode/issues/6638"},"comments":{"href":"https://api.github.com/repos/livecode/livecode/issues/6638/comments"},"review_comments":{"href":"https://api.github.com/repos/livecode/livecode/pulls/6638/comments"},"review_comment":{"href":"https://api.github.com/repos/livecode/livecode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/livecode/livecode/pulls/6638/commits"},"statuses":{"href":"https://api.github.com/repos/livecode/livecode/statuses/5a8c55556a1d3dbe0cbb69841b5167f3aaffdb0e"}},"author_association":"NONE"}}
{"actor":{"display_login":"livecodeali"}}