{"action":"closed","issue":{"url":"https://api.github.com/repos/aowen87/BAR/issues/2177","repository_url":"https://api.github.com/repos/aowen87/BAR","labels_url":"https://api.github.com/repos/aowen87/BAR/issues/2177/labels{/name}","comments_url":"https://api.github.com/repos/aowen87/BAR/issues/2177/comments","events_url":"https://api.github.com/repos/aowen87/BAR/issues/2177/events","html_url":"https://github.com/aowen87/BAR/issues/2177","id":351516579,"node_id":"MDU6SXNzdWUzNTE1MTY1Nzk=","number":2177,"title":"adding \"-o\" or \"-sessionfile\" on the command line for GUI launch fails/crashes regularly","user":{"login":"aowen87","id":11658578,"node_id":"MDQ6VXNlcjExNjU4NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/11658578?v=4","gravatar_id":"","url":"https://api.github.com/users/aowen87","html_url":"https://github.com/aowen87","followers_url":"https://api.github.com/users/aowen87/followers","following_url":"https://api.github.com/users/aowen87/following{/other_user}","gists_url":"https://api.github.com/users/aowen87/gists{/gist_id}","starred_url":"https://api.github.com/users/aowen87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aowen87/subscriptions","organizations_url":"https://api.github.com/users/aowen87/orgs","repos_url":"https://api.github.com/users/aowen87/repos","events_url":"https://api.github.com/users/aowen87/events{/privacy}","received_events_url":"https://api.github.com/users/aowen87/received_events","type":"User","site_admin":false},"labels":[{"id":1026660337,"node_id":"MDU6TGFiZWwxMDI2NjYwMzM3","url":"https://api.github.com/repos/aowen87/BAR/labels/Bug","name":"Bug","color":"111E6C","default":false},{"id":1026660370,"node_id":"MDU6TGFiZWwxMDI2NjYwMzcw","url":"https://api.github.com/repos/aowen87/BAR/labels/Likelihood:%203%20-%20Occasional","name":"Likelihood: 3 - Occasional","color":"008ECC","default":false},{"id":1026660469,"node_id":"MDU6TGFiZWwxMDI2NjYwNDY5","url":"https://api.github.com/repos/aowen87/BAR/labels/Priority:%20High","name":"Priority: High","color":"008081","default":false},{"id":1026660460,"node_id":"MDU6TGFiZWwxMDI2NjYwNDYw","url":"https://api.github.com/repos/aowen87/BAR/labels/Severity:%204%20-%20Crash%20/%20Wrong%20Results","name":"Severity: 4 - Crash / Wrong Results","color":"4682B4","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/aowen87/BAR/milestones/33","html_url":"https://github.com/aowen87/BAR/milestone/33","labels_url":"https://api.github.com/repos/aowen87/BAR/milestones/33/labels","id":3577487,"node_id":"MDk6TWlsZXN0b25lMzU3NzQ4Nw==","number":33,"title":"2.2.1","description":null,"creator":{"login":"aowen87","id":11658578,"node_id":"MDQ6VXNlcjExNjU4NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/11658578?v=4","gravatar_id":"","url":"https://api.github.com/users/aowen87","html_url":"https://github.com/aowen87","followers_url":"https://api.github.com/users/aowen87/followers","following_url":"https://api.github.com/users/aowen87/following{/other_user}","gists_url":"https://api.github.com/users/aowen87/gists{/gist_id}","starred_url":"https://api.github.com/users/aowen87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aowen87/subscriptions","organizations_url":"https://api.github.com/users/aowen87/orgs","repos_url":"https://api.github.com/users/aowen87/repos","events_url":"https://api.github.com/users/aowen87/events{/privacy}","received_events_url":"https://api.github.com/users/aowen87/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":25,"state":"open","created_at":"2018-08-16T22:22:29Z","updated_at":"2018-08-17T09:09:33Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-08-17T09:09:29Z","updated_at":"2018-08-17T09:09:33Z","closed_at":"2018-08-17T09:09:33Z","author_association":"OWNER","body":"This used to be an occasional problem, but now is occurring almost every time I open a file using \"-o\" on the command line.\r\n\r\nThe symptom varies between:\r\n(1) the file mostly appears to open, but all plots are still grayed out, so acts like it didn't open\r\n(2) I get an error saying \"the file /home/jeremy/PickAttributes doesn't exist\" (or some other state object-related string, maybe a memory error?)\r\n(3) visit immediately crashes\r\n(4) visit starts to work, and then crashes when you try to do anything with a big glibc memory error trace\r\n\r\nAnd occasionally, it works.  Typically, it will work if I'm starting visit from cold start, i.e. no visit libraries cached.  But if I've just launched visit, then try this (so that the total launch takes only a few seconds), it almost always fails.  This would imply a race condition, but the path of how this delayed-open-launch behavior works is hard to debug since I'm not familiar with it.\r\n\r\nNote that I don't see a problem with using the CLI, just the GUI.  This is on linux (where I often use \"-o\").\r\n\r\nAlso, I believe that \"-sessionfile\" seems to cause problems as well.  This might cause problems with movie making!\r\n\n\n\n\n\n\n-----------------------REDMINE MIGRATION-----------------------\nThis ticket was migrated from Redmine. As such, not all \ninformation was able to be captured in the transition. Below is\na complete record of the original redmine ticket.\n\nTicket number: 379\nStatus: Resolved\nProject: VisIt\nTracker: Bug\nPriority: High\nSubject: adding \"-o\" or \"-sessionfile\" on the command line for GUI launch fails/crashes regularly\nAssigned to: Brad Whitlock\nCategory: \nTarget version: 2.2.1\nAuthor: Jeremy Meredith\nStart: 09/03/2010\nDue date: \n% Done: 100\nEstimated time: \nCreated: 09/03/2010 03:00 pm\nUpdated: 02/24/2011 05:14 am\nLikelihood: 3 - Occasional\nSeverity: 4 - Crash / Wrong Results\nFound in version: 2.0.1\nImpact: \nExpected Use: \nOS: All\nSupport Group: Any\nDescription:\n This used to be an occasional problem, but now is occurring almost every time I open a file using \"-o\" on the command line.\r\n\r\nThe symptom varies between:\r\n(1) the file mostly appears to open, but all plots are still grayed out, so acts like it didn't open\r\n(2) I get an error saying \"the file /home/jeremy/PickAttributes doesn't exist\" (or some other state object-related string, maybe a memory error?)\r\n(3) visit immediately crashes\r\n(4) visit starts to work, and then crashes when you try to do anything with a big glibc memory error trace\r\n\r\nAnd occasionally, it works.  Typically, it will work if I'm starting visit from cold start, i.e. no visit libraries cached.  But if I've just launched visit, then try this (so that the total launch takes only a few seconds), it almost always fails.  This would imply a race condition, but the path of how this delayed-open-launch behavior works is hard to debug since I'm not familiar with it.\r\n\r\nNote that I don't see a problem with using the CLI, just the GUI.  This is on linux (where I often use \"-o\").\r\n\r\nAlso, I believe that \"-sessionfile\" seems to cause problems as well.  This might cause problems with movie making!\r\n\n\nComments:\nQuick note: \"-sessionfile\" does not appear to fail as often as \"-o\", but still pretty regularly.  maybe 25% - 50%.\nOh, and when VisIt crashes, it's a \"VisIt's viewer has exited abnormally\" crash.\nJeremy,Can you provide an example of the -o failure. The platform and the file type. Obviously one of our test files would be great. Also, does -noconfig affect it?\nEric Brugger wrote:Jeremy,Can you provide an example of the -o failure. The platform and the file type. Obviously one of our test files would be great. Also, does -noconfig affect it?This is on my linux workstation.  It's a reasonably fast one, though: eight-core 2.5GHz (Harpertown Xeons, I believe), 8GB RAM, running entirely off of local SATA disk.  I can get it to happen with most files -- silo_hdf5_test_data/csg.silo and ProteinDataBank_test_data/1A51.pdb are the ones I tried today.  Note that it appears to crash less often with -o today -- less than 50% of the time, so it's not perfectly consistent day-to-day.  Since it's apparently a race condition, it does seem to vary -- for example, sometimes -nosplash keeps it from crashing, sometimes it makes it crash more often, depending on the file.  But it may need a fairly fast machine/local disk to replicate.(I also got a new funny error message: \"the file trunk/data/silo_hdf5_test_data/LEOS try harder level [set to 0, 1, or 2] doesn't exist\".  So yeah, it's some sort of a memory error, since that's just a random string from the PDB reader.)Also, I noticed another symptom variant:(5) the Plots menu will be available, but the Active Sources list is empty.  This is the opposite of #1 (where active sources shows it, but Add Plot was greyed out.)BUT THE GOOD NEWS: so far, -noconfig has kept it from crashing for me today.  Since it appears to be a race condition, that could just be tweaking the timing enough to avoid the issue.  I'll experiment some more.\nJeremy Meredith wrote:so far, -noconfig has kept it from crashing for me today.Well, that was the good news.  Here's the bad news: if I blow away my old config (rm -rf ~/.visit), start visit, and save (entirely clean!) settings, the problem comes back.So it has nothing to do with \"old\" contents of my config files.  It may be something due to us writing bad contents by default, but that seems unlikely since nothing bad seems to happen during a visit run if I skip the -o or -sessionfile on the command line.  (Of course other reports indicate that -noconfig can solve problems which do appear without the use of these commandline args, but that's not necessarily the same problem -- we've had occasional problems with crashes due to old config file contents since the dawn of VisIt, though I admit it's usually failed on startup when that happens.)  So it still seems like it could be a race condition to me, even if it is tied to the config file parsing action itself.Oh, and blowing away \"guiconfig\" didn't help anything.  I have to blow away \"config\".\nJeremy reports this is still happening. It still sounds like a race condition we need a pretty fast machine to tickle.\nI ran on a fast Linux machine, opening a file using -o on the command line and I could reproduce the crash in a debugger. The crash was in ViewerSubject::OpenDatabaseHelper and was due to using some bad file format and path strings from the returned metadata object. Actually, I think the metadata was being read fine and we maintained a pointer to it. Then we kept that pointer around for a long time in the method while some action in the meantime invalidated the metadata object in the ViewerFileServer, causing invalid accesses to metadata fields via the previous pointer.I did 2 things:1. I removed some const char* arguments from various ViewerEngineManager methods since they should use strings anyway. This removed some char*/string conversions.2. In OpenDatabaseHelper, I made a copy of the metadata that we use for various operations. That way, if the cached metadata becomes invalidated, our stack copy of the metadata is still valid.After these changes, I could not get the crash to happen anymore. I didn't search for the method that caused the metadata invalidation but I'm pretty sure that's what was happening. It took a fast machine to reproduce this so the memory would be reused by the OS. I think these changes are pretty safe.I didn't check to see if similar things happened with -sessionfile.\n\n"}}
{"actor":{"display_login":"aowen87"}}