{"action":"created","comment":{"url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/pulls/comments/179601711","pull_request_review_id":109878743,"id":179601711,"diff_hunk":"@@ -11,12 +11,18 @@\n # See the License for the specific language governing permissions and\n # limitations under the License.\n \n+include_directories( ${TensorFlow_INCLUDE_DIR} )\n+include_directories( ${TensorFlow_INCLUDE_DIR}/external/nsync/public )\n+include_directories( ${NGRAPH_DIR}/include )\n+\n+set(CMAKE_INSTALL_RPATH_USE_LINK_PATH TRUE)\n+set(CMAKE_INSTALL_RPATH \"${TensorFlow_DIR}/plugins/ngraph/lib\")\n \n add_library( tensorflow_xla_plugin_framework SHARED IMPORTED)","path":"src/CMakeLists.txt","position":11,"original_position":11,"commit_id":"a53a5b7035325ee1fb0571711150ecb2d131591c","original_commit_id":"a53a5b7035325ee1fb0571711150ecb2d131591c","user":{"login":"avijit-nervana","id":30507445,"avatar_url":"https://avatars0.githubusercontent.com/u/30507445?v=4","gravatar_id":"","url":"https://api.github.com/users/avijit-nervana","html_url":"https://github.com/avijit-nervana","followers_url":"https://api.github.com/users/avijit-nervana/followers","following_url":"https://api.github.com/users/avijit-nervana/following{/other_user}","gists_url":"https://api.github.com/users/avijit-nervana/gists{/gist_id}","starred_url":"https://api.github.com/users/avijit-nervana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avijit-nervana/subscriptions","organizations_url":"https://api.github.com/users/avijit-nervana/orgs","repos_url":"https://api.github.com/users/avijit-nervana/repos","events_url":"https://api.github.com/users/avijit-nervana/events{/privacy}","received_events_url":"https://api.github.com/users/avijit-nervana/received_events","type":"User","site_admin":false},"body":"Don't know. We should be consistent though\r\n","created_at":"2018-04-05T21:09:29Z","updated_at":"2018-04-05T21:09:29Z","html_url":"https://github.com/NervanaSystems/ngraph-tensorflow-bridge/pull/36#discussion_r179601711","pull_request_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/pulls/36","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/pulls/comments/179601711"},"html":{"href":"https://github.com/NervanaSystems/ngraph-tensorflow-bridge/pull/36#discussion_r179601711"},"pull_request":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/pulls/36"}},"in_reply_to_id":179593501},"pull_request":{"url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/pulls/36","id":179423065,"html_url":"https://github.com/NervanaSystems/ngraph-tensorflow-bridge/pull/36","diff_url":"https://github.com/NervanaSystems/ngraph-tensorflow-bridge/pull/36.diff","patch_url":"https://github.com/NervanaSystems/ngraph-tensorflow-bridge/pull/36.patch","issue_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/issues/36","number":36,"state":"open","locked":false,"title":"Avijit/installer fix","user":{"login":"avijit-nervana","id":30507445,"avatar_url":"https://avatars0.githubusercontent.com/u/30507445?v=4","gravatar_id":"","url":"https://api.github.com/users/avijit-nervana","html_url":"https://github.com/avijit-nervana","followers_url":"https://api.github.com/users/avijit-nervana/followers","following_url":"https://api.github.com/users/avijit-nervana/following{/other_user}","gists_url":"https://api.github.com/users/avijit-nervana/gists{/gist_id}","starred_url":"https://api.github.com/users/avijit-nervana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avijit-nervana/subscriptions","organizations_url":"https://api.github.com/users/avijit-nervana/orgs","repos_url":"https://api.github.com/users/avijit-nervana/repos","events_url":"https://api.github.com/users/avijit-nervana/events{/privacy}","received_events_url":"https://api.github.com/users/avijit-nervana/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-04T15:11:47Z","updated_at":"2018-04-05T21:09:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d472383b68e53b5541180096e566795ac125e47","assignee":null,"assignees":[],"requested_reviewers":[{"login":"aprocter","id":680992,"avatar_url":"https://avatars3.githubusercontent.com/u/680992?v=4","gravatar_id":"","url":"https://api.github.com/users/aprocter","html_url":"https://github.com/aprocter","followers_url":"https://api.github.com/users/aprocter/followers","following_url":"https://api.github.com/users/aprocter/following{/other_user}","gists_url":"https://api.github.com/users/aprocter/gists{/gist_id}","starred_url":"https://api.github.com/users/aprocter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aprocter/subscriptions","organizations_url":"https://api.github.com/users/aprocter/orgs","repos_url":"https://api.github.com/users/aprocter/repos","events_url":"https://api.github.com/users/aprocter/events{/privacy}","received_events_url":"https://api.github.com/users/aprocter/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/pulls/36/commits","review_comments_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/pulls/36/comments","review_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/issues/36/comments","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/statuses/a53a5b7035325ee1fb0571711150ecb2d131591c","head":{"label":"NervanaSystems:avijit/installer_fix","ref":"avijit/installer_fix","sha":"a53a5b7035325ee1fb0571711150ecb2d131591c","user":{"login":"NervanaSystems","id":9260121,"avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":124102110,"name":"ngraph-tensorflow-bridge","full_name":"NervanaSystems/ngraph-tensorflow-bridge","owner":{"login":"NervanaSystems","id":9260121,"avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NervanaSystems/ngraph-tensorflow-bridge","description":"nGraph TensorFlow bridge","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/deployments","created_at":"2018-03-06T15:56:05Z","updated_at":"2018-04-04T16:36:55Z","pushed_at":"2018-04-05T20:01:23Z","git_url":"git://github.com/NervanaSystems/ngraph-tensorflow-bridge.git","ssh_url":"git@github.com:NervanaSystems/ngraph-tensorflow-bridge.git","clone_url":"https://github.com/NervanaSystems/ngraph-tensorflow-bridge.git","svn_url":"https://github.com/NervanaSystems/ngraph-tensorflow-bridge","homepage":null,"size":355,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":2,"watchers":10,"default_branch":"master"}},"base":{"label":"NervanaSystems:master","ref":"master","sha":"e7e6687774361368bacd4318ebfb63faaa52c31f","user":{"login":"NervanaSystems","id":9260121,"avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":124102110,"name":"ngraph-tensorflow-bridge","full_name":"NervanaSystems/ngraph-tensorflow-bridge","owner":{"login":"NervanaSystems","id":9260121,"avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NervanaSystems/ngraph-tensorflow-bridge","description":"nGraph TensorFlow bridge","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/deployments","created_at":"2018-03-06T15:56:05Z","updated_at":"2018-04-04T16:36:55Z","pushed_at":"2018-04-05T20:01:23Z","git_url":"git://github.com/NervanaSystems/ngraph-tensorflow-bridge.git","ssh_url":"git@github.com:NervanaSystems/ngraph-tensorflow-bridge.git","clone_url":"https://github.com/NervanaSystems/ngraph-tensorflow-bridge.git","svn_url":"https://github.com/NervanaSystems/ngraph-tensorflow-bridge","homepage":null,"size":355,"stargazers_count":10,"watchers_count":10,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":2,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/pulls/36"},"html":{"href":"https://github.com/NervanaSystems/ngraph-tensorflow-bridge/pull/36"},"issue":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/issues/36"},"comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/NervanaSystems/ngraph-tensorflow-bridge/statuses/a53a5b7035325ee1fb0571711150ecb2d131591c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"avijit-nervana"}}