{"action":"created","issue":{"url":"https://api.github.com/repos/spinnaker/clouddriver/issues/2938","repository_url":"https://api.github.com/repos/spinnaker/clouddriver","labels_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/2938/labels{/name}","comments_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/2938/comments","events_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/2938/events","html_url":"https://github.com/spinnaker/clouddriver/pull/2938","id":356971182,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMDk5OTA5","number":2938,"title":"fix(projects): remove parallel cluster lookups","user":{"login":"cfieber","id":301292,"node_id":"MDQ6VXNlcjMwMTI5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/301292?v=4","gravatar_id":"","url":"https://api.github.com/users/cfieber","html_url":"https://github.com/cfieber","followers_url":"https://api.github.com/users/cfieber/followers","following_url":"https://api.github.com/users/cfieber/following{/other_user}","gists_url":"https://api.github.com/users/cfieber/gists{/gist_id}","starred_url":"https://api.github.com/users/cfieber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfieber/subscriptions","organizations_url":"https://api.github.com/users/cfieber/orgs","repos_url":"https://api.github.com/users/cfieber/repos","events_url":"https://api.github.com/users/cfieber/events{/privacy}","received_events_url":"https://api.github.com/users/cfieber/received_events","type":"User","site_admin":false},"labels":[{"id":866435057,"node_id":"MDU6TGFiZWw4NjY0MzUwNTc=","url":"https://api.github.com/repos/spinnaker/clouddriver/labels/do%20not%20merge","name":"do not merge","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-04T20:50:37Z","updated_at":"2018-09-04T23:03:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/spinnaker/clouddriver/pulls/2938","html_url":"https://github.com/spinnaker/clouddriver/pull/2938","diff_url":"https://github.com/spinnaker/clouddriver/pull/2938.diff","patch_url":"https://github.com/spinnaker/clouddriver/pull/2938.patch"},"body":"A project with a large number of applications can significantly load\r\nthe redis cache by requesting all application clusters in parallel.\r\n\r\nThis removes the Rx code that was parallelizing the lookups in favor\r\nof a linear lookup through all the project's applications, and\r\nadditionally uses the RequestQueue when performing the cluster lookups\r\nin case we are under load and the requests are timing out.\r\n"},"comment":{"url":"https://api.github.com/repos/spinnaker/clouddriver/issues/comments/418545413","html_url":"https://github.com/spinnaker/clouddriver/pull/2938#issuecomment-418545413","issue_url":"https://api.github.com/repos/spinnaker/clouddriver/issues/2938","id":418545413,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODU0NTQxMw==","user":{"login":"cfieber","id":301292,"node_id":"MDQ6VXNlcjMwMTI5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/301292?v=4","gravatar_id":"","url":"https://api.github.com/users/cfieber","html_url":"https://github.com/cfieber","followers_url":"https://api.github.com/users/cfieber/followers","following_url":"https://api.github.com/users/cfieber/following{/other_user}","gists_url":"https://api.github.com/users/cfieber/gists{/gist_id}","starred_url":"https://api.github.com/users/cfieber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfieber/subscriptions","organizations_url":"https://api.github.com/users/cfieber/orgs","repos_url":"https://api.github.com/users/cfieber/repos","events_url":"https://api.github.com/users/cfieber/events{/privacy}","received_events_url":"https://api.github.com/users/cfieber/received_events","type":"User","site_admin":false},"created_at":"2018-09-04T23:03:59Z","updated_at":"2018-09-04T23:03:59Z","author_association":"CONTRIBUTOR","body":"in perf testing seeing one of our more problematic getClusters requests about 60% slower (~10s vs ~6s). This feels like an acceptable tradeoff vs hammering the redis pool with parallel requests so I'm good for this to go in."}}
{"actor":{"display_login":"cfieber"}}