{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/comments/206338101","pull_request_review_id":141736129,"id":206338101,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjMzODEwMQ==","diff_hunk":"@@ -702,3 +705,17 @@ hc_websocket_handle_t HCWebSocketDuplicateHandle(\n STDAPI HCWebSocketCloseHandle(\n     _In_ hc_websocket_handle_t websocket\n     ) HC_NOEXCEPT;\n+\n+/// <summary>\n+/// Used to wrap the JavaVM and ApplicationContext on Android devices.\n+/// </summary>\n+#if HC_PLATFORM == HC_PLATFORM_ANDROID\n+typedef struct _HC_PLATFORM_INIT_ARGS {","path":"Include/httpClient/httpClient.h","position":19,"original_position":19,"commit_id":"327301e7db4c78100f7d032ca1cd4295c037f2db","original_commit_id":"327301e7db4c78100f7d032ca1cd4295c037f2db","user":{"login":"matt-vanderkolk","id":15898678,"node_id":"MDQ6VXNlcjE1ODk4Njc4","avatar_url":"https://avatars0.githubusercontent.com/u/15898678?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-vanderkolk","html_url":"https://github.com/matt-vanderkolk","followers_url":"https://api.github.com/users/matt-vanderkolk/followers","following_url":"https://api.github.com/users/matt-vanderkolk/following{/other_user}","gists_url":"https://api.github.com/users/matt-vanderkolk/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-vanderkolk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-vanderkolk/subscriptions","organizations_url":"https://api.github.com/users/matt-vanderkolk/orgs","repos_url":"https://api.github.com/users/matt-vanderkolk/repos","events_url":"https://api.github.com/users/matt-vanderkolk/events{/privacy}","received_events_url":"https://api.github.com/users/matt-vanderkolk/received_events","type":"User","site_admin":false},"body":"nevermind\r\n\r\n---\r\nIn reply to: [206337845](https://github.com/Microsoft/libHttpClient/pull/217#discussion_r206337845) [](ancestors = 206337845)","created_at":"2018-07-30T22:08:20Z","updated_at":"2018-07-30T22:08:20Z","html_url":"https://github.com/Microsoft/libHttpClient/pull/217#discussion_r206338101","pull_request_url":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/217","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/comments/206338101"},"html":{"href":"https://github.com/Microsoft/libHttpClient/pull/217#discussion_r206338101"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/217"}},"in_reply_to_id":206337845},"pull_request":{"url":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/217","id":204923928,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0OTIzOTI4","html_url":"https://github.com/Microsoft/libHttpClient/pull/217","diff_url":"https://github.com/Microsoft/libHttpClient/pull/217.diff","patch_url":"https://github.com/Microsoft/libHttpClient/pull/217.patch","issue_url":"https://api.github.com/repos/Microsoft/libHttpClient/issues/217","number":217,"state":"open","locked":false,"title":"Detect if there's no network before attempting to make requests","user":{"login":"AesteroidBlues","id":2110799,"node_id":"MDQ6VXNlcjIxMTA3OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2110799?v=4","gravatar_id":"","url":"https://api.github.com/users/AesteroidBlues","html_url":"https://github.com/AesteroidBlues","followers_url":"https://api.github.com/users/AesteroidBlues/followers","following_url":"https://api.github.com/users/AesteroidBlues/following{/other_user}","gists_url":"https://api.github.com/users/AesteroidBlues/gists{/gist_id}","starred_url":"https://api.github.com/users/AesteroidBlues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AesteroidBlues/subscriptions","organizations_url":"https://api.github.com/users/AesteroidBlues/orgs","repos_url":"https://api.github.com/users/AesteroidBlues/repos","events_url":"https://api.github.com/users/AesteroidBlues/events{/privacy}","received_events_url":"https://api.github.com/users/AesteroidBlues/received_events","type":"User","site_admin":false},"body":"Allowing libHttpClient to perform platform-dependent network detection before attempting to make requests. \r\n\r\nThese platform calls ensure we are connected to some kind of network, regardless of whether or not that network is connected to the internet. Therefore, we should still retry as expected in transient network failures.","created_at":"2018-07-30T20:42:35Z","updated_at":"2018-07-30T22:08:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff64ea2ec135880b405310e1b0c7f654f7385e18","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/217/commits","review_comments_url":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/217/comments","review_comment_url":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/libHttpClient/issues/217/comments","statuses_url":"https://api.github.com/repos/Microsoft/libHttpClient/statuses/327301e7db4c78100f7d032ca1cd4295c037f2db","head":{"label":"AesteroidBlues:no-network-detection","ref":"no-network-detection","sha":"327301e7db4c78100f7d032ca1cd4295c037f2db","user":{"login":"AesteroidBlues","id":2110799,"node_id":"MDQ6VXNlcjIxMTA3OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2110799?v=4","gravatar_id":"","url":"https://api.github.com/users/AesteroidBlues","html_url":"https://github.com/AesteroidBlues","followers_url":"https://api.github.com/users/AesteroidBlues/followers","following_url":"https://api.github.com/users/AesteroidBlues/following{/other_user}","gists_url":"https://api.github.com/users/AesteroidBlues/gists{/gist_id}","starred_url":"https://api.github.com/users/AesteroidBlues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AesteroidBlues/subscriptions","organizations_url":"https://api.github.com/users/AesteroidBlues/orgs","repos_url":"https://api.github.com/users/AesteroidBlues/repos","events_url":"https://api.github.com/users/AesteroidBlues/events{/privacy}","received_events_url":"https://api.github.com/users/AesteroidBlues/received_events","type":"User","site_admin":false},"repo":{"id":105923647,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU5MjM2NDc=","name":"libHttpClient","full_name":"AesteroidBlues/libHttpClient","owner":{"login":"AesteroidBlues","id":2110799,"node_id":"MDQ6VXNlcjIxMTA3OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2110799?v=4","gravatar_id":"","url":"https://api.github.com/users/AesteroidBlues","html_url":"https://github.com/AesteroidBlues","followers_url":"https://api.github.com/users/AesteroidBlues/followers","following_url":"https://api.github.com/users/AesteroidBlues/following{/other_user}","gists_url":"https://api.github.com/users/AesteroidBlues/gists{/gist_id}","starred_url":"https://api.github.com/users/AesteroidBlues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AesteroidBlues/subscriptions","organizations_url":"https://api.github.com/users/AesteroidBlues/orgs","repos_url":"https://api.github.com/users/AesteroidBlues/repos","events_url":"https://api.github.com/users/AesteroidBlues/events{/privacy}","received_events_url":"https://api.github.com/users/AesteroidBlues/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AesteroidBlues/libHttpClient","description":"libHttpClient is still under construction and is not ready to use.   You can review the goals below to see what shape the project will have in its final form. If you want to contribute on the project, please talk to us to avoid overlap.","fork":true,"url":"https://api.github.com/repos/AesteroidBlues/libHttpClient","forks_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/forks","keys_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/teams","hooks_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/hooks","issue_events_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/issues/events{/number}","events_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/events","assignees_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/assignees{/user}","branches_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/branches{/branch}","tags_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/tags","blobs_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/git/refs{/sha}","trees_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/statuses/{sha}","languages_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/languages","stargazers_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/stargazers","contributors_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/contributors","subscribers_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/subscribers","subscription_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/subscription","commits_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/commits{/sha}","git_commits_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/git/commits{/sha}","comments_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/comments{/number}","issue_comment_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/issues/comments{/number}","contents_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/contents/{+path}","compare_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/merges","archive_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/downloads","issues_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/issues{/number}","pulls_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/pulls{/number}","milestones_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/milestones{/number}","notifications_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/labels{/name}","releases_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/releases{/id}","deployments_url":"https://api.github.com/repos/AesteroidBlues/libHttpClient/deployments","created_at":"2017-10-05T18:10:19Z","updated_at":"2018-07-30T20:02:00Z","pushed_at":"2018-07-30T20:32:36Z","git_url":"git://github.com/AesteroidBlues/libHttpClient.git","ssh_url":"git@github.com:AesteroidBlues/libHttpClient.git","clone_url":"https://github.com/AesteroidBlues/libHttpClient.git","svn_url":"https://github.com/AesteroidBlues/libHttpClient","homepage":null,"size":2816,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"8aa363590b2b173f77e357b1672dd3dcc6ad2d2b","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":93995266,"node_id":"MDEwOlJlcG9zaXRvcnk5Mzk5NTI2Ng==","name":"libHttpClient","full_name":"Microsoft/libHttpClient","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/libHttpClient","description":"libHttpClient provides a platform abstraction layer for HTTP and WebSocket, and is designed for use by the Microsoft Xbox Live Service API (XSAPI) [https://github.com/Microsoft/xbox-live-api] and game devs.  If you want to contribute to the project, please talk to us to avoid overlap.","fork":false,"url":"https://api.github.com/repos/Microsoft/libHttpClient","forks_url":"https://api.github.com/repos/Microsoft/libHttpClient/forks","keys_url":"https://api.github.com/repos/Microsoft/libHttpClient/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/libHttpClient/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/libHttpClient/teams","hooks_url":"https://api.github.com/repos/Microsoft/libHttpClient/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/libHttpClient/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/libHttpClient/events","assignees_url":"https://api.github.com/repos/Microsoft/libHttpClient/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/libHttpClient/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/libHttpClient/tags","blobs_url":"https://api.github.com/repos/Microsoft/libHttpClient/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/libHttpClient/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/libHttpClient/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/libHttpClient/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/libHttpClient/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/libHttpClient/languages","stargazers_url":"https://api.github.com/repos/Microsoft/libHttpClient/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/libHttpClient/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/libHttpClient/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/libHttpClient/subscription","commits_url":"https://api.github.com/repos/Microsoft/libHttpClient/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/libHttpClient/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/libHttpClient/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/libHttpClient/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/libHttpClient/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/libHttpClient/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/libHttpClient/merges","archive_url":"https://api.github.com/repos/Microsoft/libHttpClient/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/libHttpClient/downloads","issues_url":"https://api.github.com/repos/Microsoft/libHttpClient/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/libHttpClient/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/libHttpClient/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/libHttpClient/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/libHttpClient/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/libHttpClient/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/libHttpClient/deployments","created_at":"2017-06-11T09:45:05Z","updated_at":"2018-07-30T20:28:44Z","pushed_at":"2018-07-30T20:42:36Z","git_url":"git://github.com/Microsoft/libHttpClient.git","ssh_url":"git@github.com:Microsoft/libHttpClient.git","clone_url":"https://github.com/Microsoft/libHttpClient.git","svn_url":"https://github.com/Microsoft/libHttpClient","homepage":"","size":2813,"stargazers_count":81,"watchers_count":81,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":27,"open_issues":1,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/217"},"html":{"href":"https://github.com/Microsoft/libHttpClient/pull/217"},"issue":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/issues/217"},"comments":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/libHttpClient/statuses/327301e7db4c78100f7d032ca1cd4295c037f2db"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"matt-vanderkolk"}}