{"action":"opened","number":615,"pull_request":{"url":"https://api.github.com/repos/eggheads/eggdrop/pulls/615","id":213174986,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMTc0OTg2","html_url":"https://github.com/eggheads/eggdrop/pull/615","diff_url":"https://github.com/eggheads/eggdrop/pull/615.diff","patch_url":"https://github.com/eggheads/eggdrop/pull/615.patch","issue_url":"https://api.github.com/repos/eggheads/eggdrop/issues/615","number":615,"state":"open","locked":false,"title":"Fix a truncation in delignore()","user":{"login":"michaelortmann","id":41313082,"node_id":"MDQ6VXNlcjQxMzEzMDgy","avatar_url":"https://avatars1.githubusercontent.com/u/41313082?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelortmann","html_url":"https://github.com/michaelortmann","followers_url":"https://api.github.com/users/michaelortmann/followers","following_url":"https://api.github.com/users/michaelortmann/following{/other_user}","gists_url":"https://api.github.com/users/michaelortmann/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelortmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelortmann/subscriptions","organizations_url":"https://api.github.com/users/michaelortmann/orgs","repos_url":"https://api.github.com/users/michaelortmann/repos","events_url":"https://api.github.com/users/michaelortmann/events{/privacy}","received_events_url":"https://api.github.com/users/michaelortmann/received_events","type":"User","site_admin":false},"body":"Found by: michaelortmann\r\nPatch by: michaelortmann\r\nFixes: May be relevant to #520\r\n\r\nOne-line summary:\r\nFix a truncation in delignore()\r\n\r\nAdditional description (if needed):\r\ni was able to .+ignore a long string, so that line\r\nstrncpyz(temp, ign, sizeof temp);\r\nin delignore() was truncating the string.\r\nin my case strlen(ign) was 319 and sizeof temp was 256\r\n\r\nTest cases demonstrating functionality (if applicable):\r\nyou could put debug code before line\r\nstrncpyz(temp, ign, sizeof temp);\r\nto output strlen(ign)\r\nand if you then do .+ignore a long string\r\nyou will reach a strlen > 255\r\nthis means truncation\r\n\r\nyou should also be able to demonstrate a real life bug, if the bot would share userlist to another bot. in this case, the other bot should receive a truncated ignore string","created_at":"2018-09-05T05:42:42Z","updated_at":"2018-09-05T05:42:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eggheads/eggdrop/pulls/615/commits","review_comments_url":"https://api.github.com/repos/eggheads/eggdrop/pulls/615/comments","review_comment_url":"https://api.github.com/repos/eggheads/eggdrop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eggheads/eggdrop/issues/615/comments","statuses_url":"https://api.github.com/repos/eggheads/eggdrop/statuses/023e83e7bcb581c0b06c0f34573bc6eb085df8a9","head":{"label":"michaelortmann:delignore","ref":"delignore","sha":"023e83e7bcb581c0b06c0f34573bc6eb085df8a9","user":{"login":"michaelortmann","id":41313082,"node_id":"MDQ6VXNlcjQxMzEzMDgy","avatar_url":"https://avatars1.githubusercontent.com/u/41313082?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelortmann","html_url":"https://github.com/michaelortmann","followers_url":"https://api.github.com/users/michaelortmann/followers","following_url":"https://api.github.com/users/michaelortmann/following{/other_user}","gists_url":"https://api.github.com/users/michaelortmann/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelortmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelortmann/subscriptions","organizations_url":"https://api.github.com/users/michaelortmann/orgs","repos_url":"https://api.github.com/users/michaelortmann/repos","events_url":"https://api.github.com/users/michaelortmann/events{/privacy}","received_events_url":"https://api.github.com/users/michaelortmann/received_events","type":"User","site_admin":false},"repo":{"id":141218945,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyMTg5NDU=","name":"eggdrop","full_name":"michaelortmann/eggdrop","owner":{"login":"michaelortmann","id":41313082,"node_id":"MDQ6VXNlcjQxMzEzMDgy","avatar_url":"https://avatars1.githubusercontent.com/u/41313082?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelortmann","html_url":"https://github.com/michaelortmann","followers_url":"https://api.github.com/users/michaelortmann/followers","following_url":"https://api.github.com/users/michaelortmann/following{/other_user}","gists_url":"https://api.github.com/users/michaelortmann/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelortmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelortmann/subscriptions","organizations_url":"https://api.github.com/users/michaelortmann/orgs","repos_url":"https://api.github.com/users/michaelortmann/repos","events_url":"https://api.github.com/users/michaelortmann/events{/privacy}","received_events_url":"https://api.github.com/users/michaelortmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelortmann/eggdrop","description":"The Eggdrop IRC Bot","fork":true,"url":"https://api.github.com/repos/michaelortmann/eggdrop","forks_url":"https://api.github.com/repos/michaelortmann/eggdrop/forks","keys_url":"https://api.github.com/repos/michaelortmann/eggdrop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelortmann/eggdrop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelortmann/eggdrop/teams","hooks_url":"https://api.github.com/repos/michaelortmann/eggdrop/hooks","issue_events_url":"https://api.github.com/repos/michaelortmann/eggdrop/issues/events{/number}","events_url":"https://api.github.com/repos/michaelortmann/eggdrop/events","assignees_url":"https://api.github.com/repos/michaelortmann/eggdrop/assignees{/user}","branches_url":"https://api.github.com/repos/michaelortmann/eggdrop/branches{/branch}","tags_url":"https://api.github.com/repos/michaelortmann/eggdrop/tags","blobs_url":"https://api.github.com/repos/michaelortmann/eggdrop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelortmann/eggdrop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelortmann/eggdrop/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelortmann/eggdrop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelortmann/eggdrop/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelortmann/eggdrop/languages","stargazers_url":"https://api.github.com/repos/michaelortmann/eggdrop/stargazers","contributors_url":"https://api.github.com/repos/michaelortmann/eggdrop/contributors","subscribers_url":"https://api.github.com/repos/michaelortmann/eggdrop/subscribers","subscription_url":"https://api.github.com/repos/michaelortmann/eggdrop/subscription","commits_url":"https://api.github.com/repos/michaelortmann/eggdrop/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelortmann/eggdrop/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelortmann/eggdrop/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelortmann/eggdrop/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelortmann/eggdrop/contents/{+path}","compare_url":"https://api.github.com/repos/michaelortmann/eggdrop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelortmann/eggdrop/merges","archive_url":"https://api.github.com/repos/michaelortmann/eggdrop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelortmann/eggdrop/downloads","issues_url":"https://api.github.com/repos/michaelortmann/eggdrop/issues{/number}","pulls_url":"https://api.github.com/repos/michaelortmann/eggdrop/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelortmann/eggdrop/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelortmann/eggdrop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelortmann/eggdrop/labels{/name}","releases_url":"https://api.github.com/repos/michaelortmann/eggdrop/releases{/id}","deployments_url":"https://api.github.com/repos/michaelortmann/eggdrop/deployments","created_at":"2018-07-17T02:16:55Z","updated_at":"2018-09-03T02:08:25Z","pushed_at":"2018-09-05T05:36:32Z","git_url":"git://github.com/michaelortmann/eggdrop.git","ssh_url":"git@github.com:michaelortmann/eggdrop.git","clone_url":"https://github.com/michaelortmann/eggdrop.git","svn_url":"https://github.com/michaelortmann/eggdrop","homepage":null,"size":16183,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"eggheads:develop","ref":"develop","sha":"88f49af5cb00ec8586c2362647f35a7fe64f873f","user":{"login":"eggheads","id":1483260,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODMyNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1483260?v=4","gravatar_id":"","url":"https://api.github.com/users/eggheads","html_url":"https://github.com/eggheads","followers_url":"https://api.github.com/users/eggheads/followers","following_url":"https://api.github.com/users/eggheads/following{/other_user}","gists_url":"https://api.github.com/users/eggheads/gists{/gist_id}","starred_url":"https://api.github.com/users/eggheads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggheads/subscriptions","organizations_url":"https://api.github.com/users/eggheads/orgs","repos_url":"https://api.github.com/users/eggheads/repos","events_url":"https://api.github.com/users/eggheads/events{/privacy}","received_events_url":"https://api.github.com/users/eggheads/received_events","type":"Organization","site_admin":false},"repo":{"id":44209137,"node_id":"MDEwOlJlcG9zaXRvcnk0NDIwOTEzNw==","name":"eggdrop","full_name":"eggheads/eggdrop","owner":{"login":"eggheads","id":1483260,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0ODMyNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1483260?v=4","gravatar_id":"","url":"https://api.github.com/users/eggheads","html_url":"https://github.com/eggheads","followers_url":"https://api.github.com/users/eggheads/followers","following_url":"https://api.github.com/users/eggheads/following{/other_user}","gists_url":"https://api.github.com/users/eggheads/gists{/gist_id}","starred_url":"https://api.github.com/users/eggheads/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eggheads/subscriptions","organizations_url":"https://api.github.com/users/eggheads/orgs","repos_url":"https://api.github.com/users/eggheads/repos","events_url":"https://api.github.com/users/eggheads/events{/privacy}","received_events_url":"https://api.github.com/users/eggheads/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eggheads/eggdrop","description":"The Eggdrop IRC Bot","fork":false,"url":"https://api.github.com/repos/eggheads/eggdrop","forks_url":"https://api.github.com/repos/eggheads/eggdrop/forks","keys_url":"https://api.github.com/repos/eggheads/eggdrop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eggheads/eggdrop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eggheads/eggdrop/teams","hooks_url":"https://api.github.com/repos/eggheads/eggdrop/hooks","issue_events_url":"https://api.github.com/repos/eggheads/eggdrop/issues/events{/number}","events_url":"https://api.github.com/repos/eggheads/eggdrop/events","assignees_url":"https://api.github.com/repos/eggheads/eggdrop/assignees{/user}","branches_url":"https://api.github.com/repos/eggheads/eggdrop/branches{/branch}","tags_url":"https://api.github.com/repos/eggheads/eggdrop/tags","blobs_url":"https://api.github.com/repos/eggheads/eggdrop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eggheads/eggdrop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eggheads/eggdrop/git/refs{/sha}","trees_url":"https://api.github.com/repos/eggheads/eggdrop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eggheads/eggdrop/statuses/{sha}","languages_url":"https://api.github.com/repos/eggheads/eggdrop/languages","stargazers_url":"https://api.github.com/repos/eggheads/eggdrop/stargazers","contributors_url":"https://api.github.com/repos/eggheads/eggdrop/contributors","subscribers_url":"https://api.github.com/repos/eggheads/eggdrop/subscribers","subscription_url":"https://api.github.com/repos/eggheads/eggdrop/subscription","commits_url":"https://api.github.com/repos/eggheads/eggdrop/commits{/sha}","git_commits_url":"https://api.github.com/repos/eggheads/eggdrop/git/commits{/sha}","comments_url":"https://api.github.com/repos/eggheads/eggdrop/comments{/number}","issue_comment_url":"https://api.github.com/repos/eggheads/eggdrop/issues/comments{/number}","contents_url":"https://api.github.com/repos/eggheads/eggdrop/contents/{+path}","compare_url":"https://api.github.com/repos/eggheads/eggdrop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eggheads/eggdrop/merges","archive_url":"https://api.github.com/repos/eggheads/eggdrop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eggheads/eggdrop/downloads","issues_url":"https://api.github.com/repos/eggheads/eggdrop/issues{/number}","pulls_url":"https://api.github.com/repos/eggheads/eggdrop/pulls{/number}","milestones_url":"https://api.github.com/repos/eggheads/eggdrop/milestones{/number}","notifications_url":"https://api.github.com/repos/eggheads/eggdrop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eggheads/eggdrop/labels{/name}","releases_url":"https://api.github.com/repos/eggheads/eggdrop/releases{/id}","deployments_url":"https://api.github.com/repos/eggheads/eggdrop/deployments","created_at":"2015-10-13T22:26:59Z","updated_at":"2018-09-02T22:39:52Z","pushed_at":"2018-09-05T05:24:29Z","git_url":"git://github.com/eggheads/eggdrop.git","ssh_url":"git@github.com:eggheads/eggdrop.git","clone_url":"https://github.com/eggheads/eggdrop.git","svn_url":"https://github.com/eggheads/eggdrop","homepage":null,"size":15957,"stargazers_count":181,"watchers_count":181,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":158,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":51,"open_issues":158,"watchers":181,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/eggheads/eggdrop/pulls/615"},"html":{"href":"https://github.com/eggheads/eggdrop/pull/615"},"issue":{"href":"https://api.github.com/repos/eggheads/eggdrop/issues/615"},"comments":{"href":"https://api.github.com/repos/eggheads/eggdrop/issues/615/comments"},"review_comments":{"href":"https://api.github.com/repos/eggheads/eggdrop/pulls/615/comments"},"review_comment":{"href":"https://api.github.com/repos/eggheads/eggdrop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eggheads/eggdrop/pulls/615/commits"},"statuses":{"href":"https://api.github.com/repos/eggheads/eggdrop/statuses/023e83e7bcb581c0b06c0f34573bc6eb085df8a9"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"michaelortmann"}}