{"action":"created","issue":{"url":"https://api.github.com/repos/tomato42/tlsfuzzer/issues/411","repository_url":"https://api.github.com/repos/tomato42/tlsfuzzer","labels_url":"https://api.github.com/repos/tomato42/tlsfuzzer/issues/411/labels{/name}","comments_url":"https://api.github.com/repos/tomato42/tlsfuzzer/issues/411/comments","events_url":"https://api.github.com/repos/tomato42/tlsfuzzer/issues/411/events","html_url":"https://github.com/tomato42/tlsfuzzer/pull/411","id":334443158,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NDE0MTgw","number":411,"title":"Issue 212 tls13 finished fuzzing","user":{"login":"ep69","id":3175530,"node_id":"MDQ6VXNlcjMxNzU1MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/3175530?v=4","gravatar_id":"","url":"https://api.github.com/users/ep69","html_url":"https://github.com/ep69","followers_url":"https://api.github.com/users/ep69/followers","following_url":"https://api.github.com/users/ep69/following{/other_user}","gists_url":"https://api.github.com/users/ep69/gists{/gist_id}","starred_url":"https://api.github.com/users/ep69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ep69/subscriptions","organizations_url":"https://api.github.com/users/ep69/orgs","repos_url":"https://api.github.com/users/ep69/repos","events_url":"https://api.github.com/users/ep69/events{/privacy}","received_events_url":"https://api.github.com/users/ep69/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-21T11:01:07Z","updated_at":"2018-06-21T15:09:04Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/tomato42/tlsfuzzer/pulls/411","html_url":"https://github.com/tomato42/tlsfuzzer/pull/411","diff_url":"https://github.com/tomato42/tlsfuzzer/pull/411.diff","patch_url":"https://github.com/tomato42/tlsfuzzer/pull/411.patch"},"body":"<!-- Provide a general summary of your proposed changes in the Title field above -->\r\n\r\n### Description\r\n<!-- Describe your changes in detail below -->\r\nFuzzing Finished message according to #212 specification.\r\n\r\n### Motivation and Context\r\n<!-- Describe why the change is introduced, if it solves an issue add \"fixes #1\"\r\nwith a correct number -->\r\nfixes #212 \r\n\r\n### Checklist\r\n<!-- go over following points. check them with an `x` if they do apply,\r\n(they turn into clickable checkboxes once the PR is submitted, so no need\r\nto do everything at once)\r\n\r\nif you're unsure about any of those items, just ask in comment to PR\r\n\r\nif the PR resolves an issue, please add further checkboxes that describe the\r\naction items or test scenarios from it\r\n-->\r\n\r\n- [x] I have read the [CONTRIBUTING.md](https://github.com/tomato42/tlsfuzzer/blob/master/CONTRIBUTING.md) document and my PR follows [change requirements](https://github.com/tomato42/tlsfuzzer/blob/master/CONTRIBUTING.md#change-requirements) therein\r\n- [x] the changes are also reflected in documentation and code comments\r\n- [x] all new and existing tests pass (see Travis CI results)\r\n- [x] [test script checklist](https://github.com/tomato42/tlsfuzzer/wiki/Test-script-checklist) was followed for new scripts\r\n- [x] new test script added to `tlslite-ng.json` and `tlslite-ng-random-subset.json`\r\n- [ ] new and modified scripts were ran against popular TLS implementations:\r\n  - [ ] OpenSSL\r\n  - [ ] NSS\r\n  - [ ] GnuTLS\r\n- [x] required version of tlslite-ng updated in requirements.txt and README.md\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/tomato42/tlsfuzzer/411)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/tomato42/tlsfuzzer/issues/comments/399137823","html_url":"https://github.com/tomato42/tlsfuzzer/pull/411#issuecomment-399137823","issue_url":"https://api.github.com/repos/tomato42/tlsfuzzer/issues/411","id":399137823,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTEzNzgyMw==","user":{"login":"ep69","id":3175530,"node_id":"MDQ6VXNlcjMxNzU1MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/3175530?v=4","gravatar_id":"","url":"https://api.github.com/users/ep69","html_url":"https://github.com/ep69","followers_url":"https://api.github.com/users/ep69/followers","following_url":"https://api.github.com/users/ep69/following{/other_user}","gists_url":"https://api.github.com/users/ep69/gists{/gist_id}","starred_url":"https://api.github.com/users/ep69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ep69/subscriptions","organizations_url":"https://api.github.com/users/ep69/orgs","repos_url":"https://api.github.com/users/ep69/repos","events_url":"https://api.github.com/users/ep69/events{/privacy}","received_events_url":"https://api.github.com/users/ep69/received_events","type":"User","site_admin":false},"created_at":"2018-06-21T15:09:03Z","updated_at":"2018-06-21T15:09:03Z","author_association":"COLLABORATOR","body":"\n\n\n\nReview status: 2 of 5 files reviewed, 11 unresolved discussions (waiting on @tomato42 and @ep69)\n\n---\n\n*[a discussion](https://reviewable.io/reviews/tomato42/tlsfuzzer/411#-LFX_hzu2fk1rR4iJARZ:-LFXrf71-1h-VbALFY37:b-896fix) (no related file):*\n<details><summary><i>Previously, tomato42 (Hubert Kario) wrote…</i></summary><blockquote>\n\nunit tests for changes in `messages.py` missing\n</blockquote></details>\n\nDone.\n\n---\n\n*[scripts/test-tls13-finished.py, line 91 at r1](https://reviewable.io/reviews/tomato42/tlsfuzzer/411#-LFXXnAy-Zr3aAz_LudI:-LFXeMVx4E4OLdHPkwHB:b-896fix) ([raw file](https://github.com/tomato42/tlsfuzzer/blob/bb2295ebaf71f96260c77622a7071dd9a4dc6361/scripts/test-tls13-finished.py#L91)):*\n<details><summary><i>Previously, tomato42 (Hubert Kario) wrote…</i></summary><blockquote>\n\nreversed order, won't interoperate with GnuTLS\n</blockquote></details>\n\nDone.\n\n---\n\n*[scripts/test-tls13-finished.py, line 108 at r1](https://reviewable.io/reviews/tomato42/tlsfuzzer/411#-LFXXuk_EyC7ZFR9l8L-:-LFXeequ6RWJrj52BDdI:b-iuk6fv) ([raw file](https://github.com/tomato42/tlsfuzzer/blob/bb2295ebaf71f96260c77622a7071dd9a4dc6361/scripts/test-tls13-finished.py#L108)):*\n<details><summary><i>Previously, tomato42 (Hubert Kario) wrote…</i></summary><blockquote>\n\nNewSessionTicket is optional and can be sent multiple times, use the code from current tls13-conversation to expect this behaviour\n</blockquote></details>\n\nDone.kkkkkkjjkkkjkj\n\n---\n\n*[scripts/test-tls13-finished.py, line 131 at r1](https://reviewable.io/reviews/tomato42/tlsfuzzer/411#-LFXXhvD5aJ3bPGWc-r-:-LFXew8cCCZyd_sV5Gxs:b-896fix) ([raw file](https://github.com/tomato42/tlsfuzzer/blob/bb2295ebaf71f96260c77622a7071dd9a4dc6361/scripts/test-tls13-finished.py#L131)):*\n<details><summary><i>Previously, tomato42 (Hubert Kario) wrote…</i></summary><blockquote>\n\nreversed order, won't interoperate with GnuTLS\n</blockquote></details>\n\nDone.\n\n---\n\n*[scripts/test-tls13-finished.py, line 137 at r1](https://reviewable.io/reviews/tomato42/tlsfuzzer/411#-LFXXM5A7Q7d0PpytTaO:-LFXgPk7EA5Mq-txKJSs:b-896fix) ([raw file](https://github.com/tomato42/tlsfuzzer/blob/bb2295ebaf71f96260c77622a7071dd9a4dc6361/scripts/test-tls13-finished.py#L137)):*\n<details><summary><i>Previously, tomato42 (Hubert Kario) wrote…</i></summary><blockquote>\n\nwhy this larger list of signature algorithms here but not in sanity case?\n</blockquote></details>\n\nDone.\n\n---\n\n*[scripts/test-tls13-finished.py, line 151 at r1](https://reviewable.io/reviews/tomato42/tlsfuzzer/411#-LFXYC-s0cMYrkHI60n0:-LFXk1gN6nFja2mQ_53I:b-896fix) ([raw file](https://github.com/tomato42/tlsfuzzer/blob/bb2295ebaf71f96260c77622a7071dd9a4dc6361/scripts/test-tls13-finished.py#L151)):*\n<details><summary><i>Previously, tomato42 (Hubert Kario) wrote…</i></summary><blockquote>\n\nactually, the server may send a NewSessionTicket now, even before our Finished was sent (if it didn't ask for client authentication)\n</blockquote></details>\n\nDone.\n\n---\n\n*[scripts/test-tls13-finished.py, line 210 at r1](https://reviewable.io/reviews/tomato42/tlsfuzzer/411#-LFXZHiH4GEgRtQIokBb:-LFXgnn-7tYsEcoWGwJO:b-iexgoo) ([raw file](https://github.com/tomato42/tlsfuzzer/blob/bb2295ebaf71f96260c77622a7071dd9a4dc6361/scripts/test-tls13-finished.py#L210)):*\n<details><summary><i>Previously, tomato42 (Hubert Kario) wrote…</i></summary><blockquote>\n\nI'm assuming this is the truncation to size of TLS1.2 Finished while the other ones are to some arbitrary sizes?\n</blockquote></details>\n\nyes, will add comment\n\n---\n\n*[scripts/test-tls13-finished.py, line 223 at r1](https://reviewable.io/reviews/tomato42/tlsfuzzer/411#-LFXZZ1X1zQS5uamOe8U:-LFXi6Ye7o_6HtEe2eN9:bb7f2mf) ([raw file](https://github.com/tomato42/tlsfuzzer/blob/bb2295ebaf71f96260c77622a7071dd9a4dc6361/scripts/test-tls13-finished.py#L223)):*\n<details><summary><i>Previously, tomato42 (Hubert Kario) wrote…</i></summary><blockquote>\n\nwhich one of those will truncate it to the size of SHA256? maybe add comments that mark those special values?\n</blockquote></details>\n\ndone\n\n---\n\n*[scripts/test-tls13-finished.py, line 262 at r1](https://reviewable.io/reviews/tomato42/tlsfuzzer/411#-LFXZkgD9nWduvRFAK3a:-LFXlERS-bZf71QczoTo:b-896fix) ([raw file](https://github.com/tomato42/tlsfuzzer/blob/bb2295ebaf71f96260c77622a7071dd9a4dc6361/scripts/test-tls13-finished.py#L262)):*\n<details><summary><i>Previously, tomato42 (Hubert Kario) wrote…</i></summary><blockquote>\n\nagain, NewSessionTicket can be sent early here\n</blockquote></details>\n\nDone.\n\n---\n\n*[scripts/test-tls13-finished.py, line 276 at r1](https://reviewable.io/reviews/tomato42/tlsfuzzer/411#-LFX_1aO3Ipbxw88KT2t:-LFXjDFJ1fqDd5TQujvl:b-896fix) ([raw file](https://github.com/tomato42/tlsfuzzer/blob/bb2295ebaf71f96260c77622a7071dd9a4dc6361/scripts/test-tls13-finished.py#L276)):*\n<details><summary><i>Previously, tomato42 (Hubert Kario) wrote…</i></summary><blockquote>\n\nmaybe mark it as a value that pads it to the size of SHA384?\n</blockquote></details>\n\nDone.\n\n---\n\n*[tlsfuzzer/messages.py, line 947 at r1](https://reviewable.io/reviews/tomato42/tlsfuzzer/411#-LFX_VIA0yKKIduuGb4I:-LFXjXcE4zCUPExeKvnr:b-n9tkhd) ([raw file](https://github.com/tomato42/tlsfuzzer/blob/bb2295ebaf71f96260c77622a7071dd9a4dc6361/tlsfuzzer/messages.py#L947)):*\n<details><summary><i>Previously, tomato42 (Hubert Kario) wrote…</i></summary><blockquote>\n\nnit: this is over indented, the indent should be four spaces\n</blockquote></details>\n\nchanged\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/tomato42/tlsfuzzer/411)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"ep69"}}