{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/20703","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/20703/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/20703/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/20703/events","html_url":"https://github.com/nodejs/node/pull/20703","id":322610691,"number":20703,"title":"tools: always use a trailing comma in arrays","user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"labels":[{"id":281232761,"url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-05-13T17:06:48Z","updated_at":"2018-05-14T09:29:39Z","closed_at":"2018-05-14T00:40:22Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/20703","html_url":"https://github.com/nodejs/node/pull/20703","diff_url":"https://github.com/nodejs/node/pull/20703.diff","patch_url":"https://github.com/nodejs/node/pull/20703.patch"},"body":"This makes sure all arrays in /lib end with a comma to prevent\r\nfuture churn. Other options are set as before to minimize the\r\nchange.\r\n\r\nSomething like this just came up in a review and I guess it is indeed a good idea\r\nto slowly migrate to a code base that has trailing commas.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/388754756","html_url":"https://github.com/nodejs/node/pull/20703#issuecomment-388754756","issue_url":"https://api.github.com/repos/nodejs/node/issues/20703","id":388754756,"user":{"login":"mcollina","id":52195,"avatar_url":"https://avatars0.githubusercontent.com/u/52195?v=4","gravatar_id":"","url":"https://api.github.com/users/mcollina","html_url":"https://github.com/mcollina","followers_url":"https://api.github.com/users/mcollina/followers","following_url":"https://api.github.com/users/mcollina/following{/other_user}","gists_url":"https://api.github.com/users/mcollina/gists{/gist_id}","starred_url":"https://api.github.com/users/mcollina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcollina/subscriptions","organizations_url":"https://api.github.com/users/mcollina/orgs","repos_url":"https://api.github.com/users/mcollina/repos","events_url":"https://api.github.com/users/mcollina/events{/privacy}","received_events_url":"https://api.github.com/users/mcollina/received_events","type":"User","site_admin":false},"created_at":"2018-05-14T09:29:39Z","updated_at":"2018-05-14T09:29:39Z","author_association":"OWNER","body":"I'm definitely 👍 on having a file-by-file rule."}}
{"actor":{"display_login":"mcollina"}}