{"action":"created","comment":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments/236716189","pull_request_review_id":178847857,"id":236716189,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjcxNjE4OQ==","diff_hunk":"@@ -38,10 +38,10 @@ def __init__(self, MeshSolverSettings, model):\n                     \"time_step\"       : 1.0\n                 },\n                 \"domain_size\"     : 3,\n-                \"linear_solver_settings\" : {\n+                \"mesh_motion_linear_solver_settings\" : {\n                     \"solver_type\" : \"AMGCL\",\n                     \"smoother_type\":\"ilu0\",\n-                    \"krylov_type\": \"gmres\",\n+                    \"krylov_type\": \"bicgstab\",","path":"applications/ShapeOptimizationApplication/python_scripts/mesh_controller_with_solver.py","position":9,"original_position":9,"commit_id":"b248b044e25d11ee5eb2d72158e9689b98a63f27","original_commit_id":"b248b044e25d11ee5eb2d72158e9689b98a63f27","user":{"login":"armingeiser","id":25903585,"node_id":"MDQ6VXNlcjI1OTAzNTg1","avatar_url":"https://avatars2.githubusercontent.com/u/25903585?v=4","gravatar_id":"","url":"https://api.github.com/users/armingeiser","html_url":"https://github.com/armingeiser","followers_url":"https://api.github.com/users/armingeiser/followers","following_url":"https://api.github.com/users/armingeiser/following{/other_user}","gists_url":"https://api.github.com/users/armingeiser/gists{/gist_id}","starred_url":"https://api.github.com/users/armingeiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armingeiser/subscriptions","organizations_url":"https://api.github.com/users/armingeiser/orgs","repos_url":"https://api.github.com/users/armingeiser/repos","events_url":"https://api.github.com/users/armingeiser/events{/privacy}","received_events_url":"https://api.github.com/users/armingeiser/received_events","type":"User","site_admin":false},"body":"Is there a specific reason for this change?","created_at":"2018-11-27T15:33:05Z","updated_at":"2018-11-27T15:33:06Z","html_url":"https://github.com/KratosMultiphysics/Kratos/pull/3246#discussion_r236716189","pull_request_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/3246","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments/236716189"},"html":{"href":"https://github.com/KratosMultiphysics/Kratos/pull/3246#discussion_r236716189"},"pull_request":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/3246"}}},"pull_request":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/3246","id":227877555,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3ODc3NTU1","html_url":"https://github.com/KratosMultiphysics/Kratos/pull/3246","diff_url":"https://github.com/KratosMultiphysics/Kratos/pull/3246.diff","patch_url":"https://github.com/KratosMultiphysics/Kratos/pull/3246.patch","issue_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/3246","number":3246,"state":"open","locked":false,"title":"[ShapeOpt] Adding bead optimization ","user":{"login":"dbaumgaertner","id":25897162,"node_id":"MDQ6VXNlcjI1ODk3MTYy","avatar_url":"https://avatars2.githubusercontent.com/u/25897162?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaumgaertner","html_url":"https://github.com/dbaumgaertner","followers_url":"https://api.github.com/users/dbaumgaertner/followers","following_url":"https://api.github.com/users/dbaumgaertner/following{/other_user}","gists_url":"https://api.github.com/users/dbaumgaertner/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaumgaertner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaumgaertner/subscriptions","organizations_url":"https://api.github.com/users/dbaumgaertner/orgs","repos_url":"https://api.github.com/users/dbaumgaertner/repos","events_url":"https://api.github.com/users/dbaumgaertner/events{/privacy}","received_events_url":"https://api.github.com/users/dbaumgaertner/received_events","type":"User","site_admin":false},"body":"This PR introduces:\r\n\r\n- A new algorithm to perform bead optimization using an Augmented Lagrange approach. The algorithm allows specifying the bead height as well as the bead direction (extrusion on only one side, on both sides, in the local normal direction or in a specified direction) Additionally if specified, the algorithm considers a built-in penalty term which enforces a binary distribution in the control space. Damping and a direct constraint enforcement are included to allow a transition to non-design areas.\r\n\r\n- A value logger that logs the results of a bead optimization in detail. \r\n- A constant filter function\r\n- A unit test for bead optimization\r\n\r\nAdditionally, the following modifications were introduced:\r\n\r\n- The structure of the algorithms slightly changed such that each algorithm introduces its own set of variables to (to avoid an overflow of nodal variables) \r\n\r\n- The output of all value loggers is cleaned\r\n\r\n- The application of the variables TIME / STEP in the analyzer and the mesh solver is corrected. I.e., from the optimizer point of view, the latter variables are not modified anymore. Advancing in time is exclusively controlled by the individual optimization algorithms. In doing so, historical nodal optimization variables may be properly used within an algorithm, which was not the case before.\r\n\r\n- The settings validation in the mesh solver was corrected such that mesh velocities are not computed anymore (creates problems due to the variable DELTA_TIME which is meaningless and not needed in optimization)\r\n\r\n- The import of the model part is moved to the initialize function of each algorithm. By that, the entire workflow is defined and readable from the algorithm. This shall facilitate the process understanding.\r\n\r\n ","created_at":"2018-11-02T09:29:45Z","updated_at":"2018-11-27T15:33:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d1dfa2bd71b7c23013885e7cf046768ae4f0c2d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":538625941,"node_id":"MDU6TGFiZWw1Mzg2MjU5NDE=","url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/Cleanup","name":"Cleanup","color":"77d86e","default":false},{"id":538395921,"node_id":"MDU6TGFiZWw1MzgzOTU5MjE=","url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/Enhancement","name":"Enhancement","color":"77d86e","default":false},{"id":1091391300,"node_id":"MDU6TGFiZWwxMDkxMzkxMzAw","url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/Feature","name":"Feature","color":"77d86e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/3246/commits","review_comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/3246/comments","review_comment_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/3246/comments","statuses_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/b248b044e25d11ee5eb2d72158e9689b98a63f27","head":{"label":"KratosMultiphysics:feature-corrected-bead-optimization","ref":"feature-corrected-bead-optimization","sha":"b248b044e25d11ee5eb2d72158e9689b98a63f27","user":{"login":"KratosMultiphysics","id":24840449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODQwNDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"repo":{"id":81815495,"node_id":"MDEwOlJlcG9zaXRvcnk4MTgxNTQ5NQ==","name":"Kratos","full_name":"KratosMultiphysics/Kratos","private":false,"owner":{"login":"KratosMultiphysics","id":24840449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODQwNDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/KratosMultiphysics/Kratos","description":"Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.","fork":false,"url":"https://api.github.com/repos/KratosMultiphysics/Kratos","forks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/forks","keys_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/teams","hooks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/hooks","issue_events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/events{/number}","events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/events","assignees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/assignees{/user}","branches_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/branches{/branch}","tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/tags","blobs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/refs{/sha}","trees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/{sha}","languages_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/languages","stargazers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/stargazers","contributors_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contributors","subscribers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscribers","subscription_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscription","commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/commits{/sha}","git_commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/commits{/sha}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/comments{/number}","issue_comment_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/comments{/number}","contents_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contents/{+path}","compare_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/merges","archive_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/downloads","issues_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues{/number}","pulls_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls{/number}","milestones_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/milestones{/number}","notifications_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels{/name}","releases_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/releases{/id}","deployments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/deployments","created_at":"2017-02-13T10:58:24Z","updated_at":"2018-11-27T15:02:26Z","pushed_at":"2018-11-27T15:30:28Z","git_url":"git://github.com/KratosMultiphysics/Kratos.git","ssh_url":"git@github.com:KratosMultiphysics/Kratos.git","clone_url":"https://github.com/KratosMultiphysics/Kratos.git","svn_url":"https://github.com/KratosMultiphysics/Kratos","homepage":"http://www.cimne.com/kratos/","size":1297512,"stargazers_count":225,"watchers_count":225,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":202,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":47,"open_issues":202,"watchers":225,"default_branch":"master"}},"base":{"label":"KratosMultiphysics:master","ref":"master","sha":"a3395a3d1ec8d59acc8e3f2deb9d5ad29122d1f5","user":{"login":"KratosMultiphysics","id":24840449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODQwNDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"repo":{"id":81815495,"node_id":"MDEwOlJlcG9zaXRvcnk4MTgxNTQ5NQ==","name":"Kratos","full_name":"KratosMultiphysics/Kratos","private":false,"owner":{"login":"KratosMultiphysics","id":24840449,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODQwNDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/24840449?v=4","gravatar_id":"","url":"https://api.github.com/users/KratosMultiphysics","html_url":"https://github.com/KratosMultiphysics","followers_url":"https://api.github.com/users/KratosMultiphysics/followers","following_url":"https://api.github.com/users/KratosMultiphysics/following{/other_user}","gists_url":"https://api.github.com/users/KratosMultiphysics/gists{/gist_id}","starred_url":"https://api.github.com/users/KratosMultiphysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KratosMultiphysics/subscriptions","organizations_url":"https://api.github.com/users/KratosMultiphysics/orgs","repos_url":"https://api.github.com/users/KratosMultiphysics/repos","events_url":"https://api.github.com/users/KratosMultiphysics/events{/privacy}","received_events_url":"https://api.github.com/users/KratosMultiphysics/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/KratosMultiphysics/Kratos","description":"Kratos Multiphysics (A.K.A Kratos) is a framework for building parallel multi-disciplinary simulation software. Modularity, extensibility and HPC are the main objectives. Kratos has BSD license and is written in C++ with extensive Python interface.","fork":false,"url":"https://api.github.com/repos/KratosMultiphysics/Kratos","forks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/forks","keys_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/teams","hooks_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/hooks","issue_events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/events{/number}","events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/events","assignees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/assignees{/user}","branches_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/branches{/branch}","tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/tags","blobs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/refs{/sha}","trees_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/{sha}","languages_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/languages","stargazers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/stargazers","contributors_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contributors","subscribers_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscribers","subscription_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/subscription","commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/commits{/sha}","git_commits_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/git/commits{/sha}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/comments{/number}","issue_comment_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/comments{/number}","contents_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/contents/{+path}","compare_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/merges","archive_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/downloads","issues_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues{/number}","pulls_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls{/number}","milestones_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/milestones{/number}","notifications_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels{/name}","releases_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/releases{/id}","deployments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/deployments","created_at":"2017-02-13T10:58:24Z","updated_at":"2018-11-27T15:02:26Z","pushed_at":"2018-11-27T15:30:28Z","git_url":"git://github.com/KratosMultiphysics/Kratos.git","ssh_url":"git@github.com:KratosMultiphysics/Kratos.git","clone_url":"https://github.com/KratosMultiphysics/Kratos.git","svn_url":"https://github.com/KratosMultiphysics/Kratos","homepage":"http://www.cimne.com/kratos/","size":1297512,"stargazers_count":225,"watchers_count":225,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":202,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":47,"open_issues":202,"watchers":225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/3246"},"html":{"href":"https://github.com/KratosMultiphysics/Kratos/pull/3246"},"issue":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/3246"},"comments":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/3246/comments"},"review_comments":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/3246/comments"},"review_comment":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/pulls/3246/commits"},"statuses":{"href":"https://api.github.com/repos/KratosMultiphysics/Kratos/statuses/b248b044e25d11ee5eb2d72158e9689b98a63f27"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"armingeiser"}}