{"push_id":2696681143,"size":2,"distinct_size":1,"ref":"refs/heads/master","head":"11db76874387def8c4dd3b2ebbb141c2973235e2","before":"04e553dccd4fde39650dbaf8e59fe5523955019a","commits":[{"sha":"528b5cc66b1d46f02ee191f8a4563bac88b7718e","author":{"name":"Oliver Sander","email":"4e528e1b5c237d907957e752b9d443bb7868cd7d@tu-dresden.de"},"message":"Make file readers return ToUniquePtr instead of a C pointer\n\nAt the 2017 developer meeting in Heidelberg it was decided that\nfile reading methods should return a std::unique_ptr of the\nresulting grid, rather than a C pointer.  The reason is that\na std::unique_ptr makes it clear that the caller receives\nthe ownership of the new object.\n\nSimply changing the return types of the relevant methods is not\nan option, as it will break a lot of user code.  Instead the\nclass ToUniquePtr was introduced in dune-common.  It is a\ncostum pointer class that casts into C-style pointers, std::shared_ptr,\nand std::unique_ptr.  Casting to a C-style pointer will result\nin a deprecation warning.  Using this class for at least one\nrelease will allow a much smoother transition.","distinct":false,"url":"https://api.github.com/repos/dune-project/dune-grid/commits/528b5cc66b1d46f02ee191f8a4563bac88b7718e"},{"sha":"11db76874387def8c4dd3b2ebbb141c2973235e2","author":{"name":"Oliver Sander","email":"4e528e1b5c237d907957e752b9d443bb7868cd7d@tu-dresden.de"},"message":"[!298] Make file readers return ToUniquePtr instead of a C pointer\n\nMerge branch 'feature/grid-readers-return-to_unique_ptr' into 'master'\n\nAt the 2017 developer meeting in Heidelberg it was decided that file reading\nmethods should return a std::unique\\_ptr of the resulting grid, rather than a\nC pointer. The reason is that a std::unique\\_ptr makes it clear that the\ncaller receives the ownership of the new object.\n\nSimply changing the return types of the relevant methods is not an option, as\nit will break a lot of user code. Instead the class ToUniquePtr was introduced\nin dune-common. It is a costum pointer class that casts into C-style pointers,\nstd::shared\\_ptr, and std::unique\\_ptr. Casting to a C-style pointer will\nresult in a deprecation warning. Using this class for at least one release\nwill allow a much smoother transition.\n\n\nSee merge request core/dune-grid!298","distinct":true,"url":"https://api.github.com/repos/dune-project/dune-grid/commits/11db76874387def8c4dd3b2ebbb141c2973235e2"}]}
{"actor":{"display_login":"aburch"}}