{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/recipes/issues/453","repository_url":"https://api.github.com/repos/symfony/recipes","labels_url":"https://api.github.com/repos/symfony/recipes/issues/453/labels{/name}","comments_url":"https://api.github.com/repos/symfony/recipes/issues/453/comments","events_url":"https://api.github.com/repos/symfony/recipes/issues/453/events","html_url":"https://github.com/symfony/recipes/pull/453","id":354469167,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjI0MjI3","number":453,"title":" [FrameworkBundle] New `parameters.yaml` file + Remove `parameters` key from `services.yaml`","user":{"login":"alex2005git","id":3526365,"node_id":"MDQ6VXNlcjM1MjYzNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3526365?v=4","gravatar_id":"","url":"https://api.github.com/users/alex2005git","html_url":"https://github.com/alex2005git","followers_url":"https://api.github.com/users/alex2005git/followers","following_url":"https://api.github.com/users/alex2005git/following{/other_user}","gists_url":"https://api.github.com/users/alex2005git/gists{/gist_id}","starred_url":"https://api.github.com/users/alex2005git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex2005git/subscriptions","organizations_url":"https://api.github.com/users/alex2005git/orgs","repos_url":"https://api.github.com/users/alex2005git/repos","events_url":"https://api.github.com/users/alex2005git/events{/privacy}","received_events_url":"https://api.github.com/users/alex2005git/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-27T20:38:14Z","updated_at":"2018-08-27T21:17:50Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/symfony/recipes/pulls/453","html_url":"https://github.com/symfony/recipes/pull/453","diff_url":"https://github.com/symfony/recipes/pull/453.diff","patch_url":"https://github.com/symfony/recipes/pull/453.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| License       | MIT\r\n\r\nWhat this PR hopes to accomplish, is remove the `parameters` key from `services.yaml`, it's a bit counter intuitive for the parameters to be in the `services.yaml` file.  \r\n  \r\nAlso the parameters could get quite many, also the services, so the separation would make the files more clear as to what they should do.  \r\n  \r\nAnother advantage this has, because the `parameters.yaml` file gets loaded before other configs, an environment could overwrite a parameter (for whatever reason) by providing a `parameters.yaml` file in the `packages/{env}` folder. This is intuitive, you would think that by placing this file in an environment folder it would overwrite the parameters that you set in it.\r\n"},"comment":{"url":"https://api.github.com/repos/symfony/recipes/issues/comments/416371899","html_url":"https://github.com/symfony/recipes/pull/453#issuecomment-416371899","issue_url":"https://api.github.com/repos/symfony/recipes/issues/453","id":416371899,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjM3MTg5OQ==","user":{"login":"BoShurik","id":1428848,"node_id":"MDQ6VXNlcjE0Mjg4NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1428848?v=4","gravatar_id":"","url":"https://api.github.com/users/BoShurik","html_url":"https://github.com/BoShurik","followers_url":"https://api.github.com/users/BoShurik/followers","following_url":"https://api.github.com/users/BoShurik/following{/other_user}","gists_url":"https://api.github.com/users/BoShurik/gists{/gist_id}","starred_url":"https://api.github.com/users/BoShurik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BoShurik/subscriptions","organizations_url":"https://api.github.com/users/BoShurik/orgs","repos_url":"https://api.github.com/users/BoShurik/repos","events_url":"https://api.github.com/users/BoShurik/events{/privacy}","received_events_url":"https://api.github.com/users/BoShurik/received_events","type":"User","site_admin":false},"created_at":"2018-08-27T21:17:50Z","updated_at":"2018-08-27T21:17:50Z","author_association":"NONE","body":"I use it like this in `services.yaml`\r\n```yaml\r\nimports:\r\n    - { resource: 'parameters.yaml' }\r\nparameters:\r\n    locale: 'en'\r\n#...\r\n```\r\n\r\nFor me the problem is that this file has been used as a `.env` before symfony 4, so it might be misleading to use another name in case using `incenteev/composer-parameter-handler`\r\n\r\nBut it's just my opinion, let's wait what others think about it"}}
{"actor":{"display_login":"BoShurik"}}