{"action":"created","comment":{"url":"https://api.github.com/repos/linagora/james-project/pulls/comments/234175923","pull_request_review_id":175763567,"id":234175923,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDE3NTkyMw==","diff_hunk":"@@ -288,4 +291,9 @@ public void addGroupMapping(MappingSource source, String address) throws Recipie\n     public void removeGroupMapping(MappingSource source, String address) throws RecipientRewriteTableException {\n         throw new RecipientRewriteTableException(\"Read-Only RecipientRewriteTable\");\n     }\n+\n+    @Override\n+    public List<MappingSource> listSources(Mapping mapping) throws RecipientRewriteTableException {\n+        return ImmutableList.of();","path":"server/data/data-library/src/main/java/org/apache/james/user/lib/AbstractJamesUsersRepository.java","position":24,"original_position":24,"commit_id":"989a5221c9db79ca21ab1a8b6715f2ff08ae502b","original_commit_id":"989a5221c9db79ca21ab1a8b6715f2ff08ae502b","user":{"login":"chibenwa","id":6928740,"node_id":"MDQ6VXNlcjY5Mjg3NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/6928740?v=4","gravatar_id":"","url":"https://api.github.com/users/chibenwa","html_url":"https://github.com/chibenwa","followers_url":"https://api.github.com/users/chibenwa/followers","following_url":"https://api.github.com/users/chibenwa/following{/other_user}","gists_url":"https://api.github.com/users/chibenwa/gists{/gist_id}","starred_url":"https://api.github.com/users/chibenwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibenwa/subscriptions","organizations_url":"https://api.github.com/users/chibenwa/orgs","repos_url":"https://api.github.com/users/chibenwa/repos","events_url":"https://api.github.com/users/chibenwa/events{/privacy}","received_events_url":"https://api.github.com/users/chibenwa/received_events","type":"User","site_admin":false},"body":"By having `listSources` implemented as a default method we would avoid repeating ourselves.","created_at":"2018-11-16T11:37:06Z","updated_at":"2018-11-16T11:40:09Z","html_url":"https://github.com/linagora/james-project/pull/1923#discussion_r234175923","pull_request_url":"https://api.github.com/repos/linagora/james-project/pulls/1923","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/linagora/james-project/pulls/comments/234175923"},"html":{"href":"https://github.com/linagora/james-project/pull/1923#discussion_r234175923"},"pull_request":{"href":"https://api.github.com/repos/linagora/james-project/pulls/1923"}}},"pull_request":{"url":"https://api.github.com/repos/linagora/james-project/pulls/1923","id":231493228,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNDkzMjI4","html_url":"https://github.com/linagora/james-project/pull/1923","diff_url":"https://github.com/linagora/james-project/pull/1923.diff","patch_url":"https://github.com/linagora/james-project/pull/1923.patch","issue_url":"https://api.github.com/repos/linagora/james-project/issues/1923","number":1923,"state":"open","locked":false,"title":"[WIP] JAMES-2596 Add listSources API to RecipientRewriteTable","user":{"login":"hoangdat","id":6462404,"node_id":"MDQ6VXNlcjY0NjI0MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6462404?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangdat","html_url":"https://github.com/hoangdat","followers_url":"https://api.github.com/users/hoangdat/followers","following_url":"https://api.github.com/users/hoangdat/following{/other_user}","gists_url":"https://api.github.com/users/hoangdat/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangdat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangdat/subscriptions","organizations_url":"https://api.github.com/users/hoangdat/orgs","repos_url":"https://api.github.com/users/hoangdat/repos","events_url":"https://api.github.com/users/hoangdat/events{/privacy}","received_events_url":"https://api.github.com/users/hoangdat/received_events","type":"User","site_admin":false},"body":"JIRA: https://issues.apache.org/jira/browse/JAMES-2596\r\n\r\nI'm not sure about this, please guide me when I misunderstand this ticket","created_at":"2018-11-16T11:03:56Z","updated_at":"2018-11-16T11:40:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dfb44b30c50e653c51b1e88150b811a54f3e2cb7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/linagora/james-project/pulls/1923/commits","review_comments_url":"https://api.github.com/repos/linagora/james-project/pulls/1923/comments","review_comment_url":"https://api.github.com/repos/linagora/james-project/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linagora/james-project/issues/1923/comments","statuses_url":"https://api.github.com/repos/linagora/james-project/statuses/989a5221c9db79ca21ab1a8b6715f2ff08ae502b","head":{"label":"hoangdat:JAMES-2596-list-sources-from-a-mapping","ref":"JAMES-2596-list-sources-from-a-mapping","sha":"989a5221c9db79ca21ab1a8b6715f2ff08ae502b","user":{"login":"hoangdat","id":6462404,"node_id":"MDQ6VXNlcjY0NjI0MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6462404?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangdat","html_url":"https://github.com/hoangdat","followers_url":"https://api.github.com/users/hoangdat/followers","following_url":"https://api.github.com/users/hoangdat/following{/other_user}","gists_url":"https://api.github.com/users/hoangdat/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangdat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangdat/subscriptions","organizations_url":"https://api.github.com/users/hoangdat/orgs","repos_url":"https://api.github.com/users/hoangdat/repos","events_url":"https://api.github.com/users/hoangdat/events{/privacy}","received_events_url":"https://api.github.com/users/hoangdat/received_events","type":"User","site_admin":false},"repo":{"id":155144672,"node_id":"MDEwOlJlcG9zaXRvcnkxNTUxNDQ2NzI=","name":"james-project","full_name":"hoangdat/james-project","private":false,"owner":{"login":"hoangdat","id":6462404,"node_id":"MDQ6VXNlcjY0NjI0MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6462404?v=4","gravatar_id":"","url":"https://api.github.com/users/hoangdat","html_url":"https://github.com/hoangdat","followers_url":"https://api.github.com/users/hoangdat/followers","following_url":"https://api.github.com/users/hoangdat/following{/other_user}","gists_url":"https://api.github.com/users/hoangdat/gists{/gist_id}","starred_url":"https://api.github.com/users/hoangdat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoangdat/subscriptions","organizations_url":"https://api.github.com/users/hoangdat/orgs","repos_url":"https://api.github.com/users/hoangdat/repos","events_url":"https://api.github.com/users/hoangdat/events{/privacy}","received_events_url":"https://api.github.com/users/hoangdat/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hoangdat/james-project","description":"Mirror of Apache James Project","fork":true,"url":"https://api.github.com/repos/hoangdat/james-project","forks_url":"https://api.github.com/repos/hoangdat/james-project/forks","keys_url":"https://api.github.com/repos/hoangdat/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoangdat/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoangdat/james-project/teams","hooks_url":"https://api.github.com/repos/hoangdat/james-project/hooks","issue_events_url":"https://api.github.com/repos/hoangdat/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/hoangdat/james-project/events","assignees_url":"https://api.github.com/repos/hoangdat/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/hoangdat/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/hoangdat/james-project/tags","blobs_url":"https://api.github.com/repos/hoangdat/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoangdat/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoangdat/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoangdat/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoangdat/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/hoangdat/james-project/languages","stargazers_url":"https://api.github.com/repos/hoangdat/james-project/stargazers","contributors_url":"https://api.github.com/repos/hoangdat/james-project/contributors","subscribers_url":"https://api.github.com/repos/hoangdat/james-project/subscribers","subscription_url":"https://api.github.com/repos/hoangdat/james-project/subscription","commits_url":"https://api.github.com/repos/hoangdat/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoangdat/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoangdat/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoangdat/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoangdat/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/hoangdat/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoangdat/james-project/merges","archive_url":"https://api.github.com/repos/hoangdat/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoangdat/james-project/downloads","issues_url":"https://api.github.com/repos/hoangdat/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/hoangdat/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/hoangdat/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/hoangdat/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoangdat/james-project/labels{/name}","releases_url":"https://api.github.com/repos/hoangdat/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/hoangdat/james-project/deployments","created_at":"2018-10-29T03:11:30Z","updated_at":"2018-10-29T03:11:48Z","pushed_at":"2018-11-16T10:57:46Z","git_url":"git://github.com/hoangdat/james-project.git","ssh_url":"git@github.com:hoangdat/james-project.git","clone_url":"https://github.com/hoangdat/james-project.git","svn_url":"https://github.com/hoangdat/james-project","homepage":null,"size":37646,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linagora:master","ref":"master","sha":"ef7c00f2a1666dcc7f1c571adafb6224ca793cbb","user":{"login":"linagora","id":1230365,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAzNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1230365?v=4","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"repo":{"id":39182136,"node_id":"MDEwOlJlcG9zaXRvcnkzOTE4MjEzNg==","name":"james-project","full_name":"linagora/james-project","private":false,"owner":{"login":"linagora","id":1230365,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAzNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1230365?v=4","gravatar_id":"","url":"https://api.github.com/users/linagora","html_url":"https://github.com/linagora","followers_url":"https://api.github.com/users/linagora/followers","following_url":"https://api.github.com/users/linagora/following{/other_user}","gists_url":"https://api.github.com/users/linagora/gists{/gist_id}","starred_url":"https://api.github.com/users/linagora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linagora/subscriptions","organizations_url":"https://api.github.com/users/linagora/orgs","repos_url":"https://api.github.com/users/linagora/repos","events_url":"https://api.github.com/users/linagora/events{/privacy}","received_events_url":"https://api.github.com/users/linagora/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/linagora/james-project","description":"Mirror of Apache James Project","fork":true,"url":"https://api.github.com/repos/linagora/james-project","forks_url":"https://api.github.com/repos/linagora/james-project/forks","keys_url":"https://api.github.com/repos/linagora/james-project/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linagora/james-project/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linagora/james-project/teams","hooks_url":"https://api.github.com/repos/linagora/james-project/hooks","issue_events_url":"https://api.github.com/repos/linagora/james-project/issues/events{/number}","events_url":"https://api.github.com/repos/linagora/james-project/events","assignees_url":"https://api.github.com/repos/linagora/james-project/assignees{/user}","branches_url":"https://api.github.com/repos/linagora/james-project/branches{/branch}","tags_url":"https://api.github.com/repos/linagora/james-project/tags","blobs_url":"https://api.github.com/repos/linagora/james-project/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linagora/james-project/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linagora/james-project/git/refs{/sha}","trees_url":"https://api.github.com/repos/linagora/james-project/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linagora/james-project/statuses/{sha}","languages_url":"https://api.github.com/repos/linagora/james-project/languages","stargazers_url":"https://api.github.com/repos/linagora/james-project/stargazers","contributors_url":"https://api.github.com/repos/linagora/james-project/contributors","subscribers_url":"https://api.github.com/repos/linagora/james-project/subscribers","subscription_url":"https://api.github.com/repos/linagora/james-project/subscription","commits_url":"https://api.github.com/repos/linagora/james-project/commits{/sha}","git_commits_url":"https://api.github.com/repos/linagora/james-project/git/commits{/sha}","comments_url":"https://api.github.com/repos/linagora/james-project/comments{/number}","issue_comment_url":"https://api.github.com/repos/linagora/james-project/issues/comments{/number}","contents_url":"https://api.github.com/repos/linagora/james-project/contents/{+path}","compare_url":"https://api.github.com/repos/linagora/james-project/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linagora/james-project/merges","archive_url":"https://api.github.com/repos/linagora/james-project/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linagora/james-project/downloads","issues_url":"https://api.github.com/repos/linagora/james-project/issues{/number}","pulls_url":"https://api.github.com/repos/linagora/james-project/pulls{/number}","milestones_url":"https://api.github.com/repos/linagora/james-project/milestones{/number}","notifications_url":"https://api.github.com/repos/linagora/james-project/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linagora/james-project/labels{/name}","releases_url":"https://api.github.com/repos/linagora/james-project/releases{/id}","deployments_url":"https://api.github.com/repos/linagora/james-project/deployments","created_at":"2015-07-16T07:04:59Z","updated_at":"2018-11-16T09:58:41Z","pushed_at":"2018-11-16T11:32:37Z","git_url":"git://github.com/linagora/james-project.git","ssh_url":"git@github.com:linagora/james-project.git","clone_url":"https://github.com/linagora/james-project.git","svn_url":"https://github.com/linagora/james-project","homepage":null,"size":37952,"stargazers_count":23,"watchers_count":23,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":88,"license":null,"forks":33,"open_issues":88,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linagora/james-project/pulls/1923"},"html":{"href":"https://github.com/linagora/james-project/pull/1923"},"issue":{"href":"https://api.github.com/repos/linagora/james-project/issues/1923"},"comments":{"href":"https://api.github.com/repos/linagora/james-project/issues/1923/comments"},"review_comments":{"href":"https://api.github.com/repos/linagora/james-project/pulls/1923/comments"},"review_comment":{"href":"https://api.github.com/repos/linagora/james-project/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linagora/james-project/pulls/1923/commits"},"statuses":{"href":"https://api.github.com/repos/linagora/james-project/statuses/989a5221c9db79ca21ab1a8b6715f2ff08ae502b"}},"author_association":"NONE"}}
{"actor":{"display_login":"chibenwa"}}