{"action":"created","comment":{"url":"https://api.github.com/repos/google/gapid/pulls/comments/194325223","pull_request_review_id":127467648,"id":194325223,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDMyNTIyMw==","diff_hunk":"@@ -209,7 +209,7 @@ func compat(ctx context.Context, device *device.Instance, onError onCompatError)\n \t\t\t// TODO(dsrbecky): This might make some commands valid for replay which were invalid on trace.\n \t\t\tscs := FindStaticContextState(s.Arena, cmd.Extras())\n \t\t\tif !scs.IsNil() && !version.IsES && scs.Constants().MajorVersion() < 3 {\n-\t\t\t\tclone := cmd.Clone(s.Arena)\n+\t\t\t\tclone := cmd.Clone(s.Arena).(*EglMakeCurrent)","path":"gapis/api/gles/compat.go","position":5,"original_position":5,"commit_id":"a5897221a65ac18a44276afd41e9c1b6476df0cb","original_commit_id":"6451367bf33b4856516036b7f3b2cf2c7b65c2c7","user":{"login":"ben-clayton","id":11505236,"node_id":"MDQ6VXNlcjExNTA1MjM2","avatar_url":"https://avatars0.githubusercontent.com/u/11505236?v=4","gravatar_id":"","url":"https://api.github.com/users/ben-clayton","html_url":"https://github.com/ben-clayton","followers_url":"https://api.github.com/users/ben-clayton/followers","following_url":"https://api.github.com/users/ben-clayton/following{/other_user}","gists_url":"https://api.github.com/users/ben-clayton/gists{/gist_id}","starred_url":"https://api.github.com/users/ben-clayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ben-clayton/subscriptions","organizations_url":"https://api.github.com/users/ben-clayton/orgs","repos_url":"https://api.github.com/users/ben-clayton/repos","events_url":"https://api.github.com/users/ben-clayton/events{/privacy}","received_events_url":"https://api.github.com/users/ben-clayton/received_events","type":"User","site_admin":false},"body":"Consider adding a `clone(arena.Arena) *T` method (note the lowercase), which `Clone(arena.Arena) api.Cmd` delegates on to.","created_at":"2018-06-11T08:27:10Z","updated_at":"2018-06-11T08:42:00Z","html_url":"https://github.com/google/gapid/pull/1949#discussion_r194325223","pull_request_url":"https://api.github.com/repos/google/gapid/pulls/1949","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/google/gapid/pulls/comments/194325223"},"html":{"href":"https://github.com/google/gapid/pull/1949#discussion_r194325223"},"pull_request":{"href":"https://api.github.com/repos/google/gapid/pulls/1949"}}},"pull_request":{"url":"https://api.github.com/repos/google/gapid/pulls/1949","id":192121017,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMTIxMDE3","html_url":"https://github.com/google/gapid/pull/1949","diff_url":"https://github.com/google/gapid/pull/1949.diff","patch_url":"https://github.com/google/gapid/pull/1949.patch","issue_url":"https://api.github.com/repos/google/gapid/issues/1949","number":1949,"state":"open","locked":false,"title":"Dependency graph","user":{"login":"bjoeris","id":1546096,"node_id":"MDQ6VXNlcjE1NDYwOTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1546096?v=4","gravatar_id":"","url":"https://api.github.com/users/bjoeris","html_url":"https://github.com/bjoeris","followers_url":"https://api.github.com/users/bjoeris/followers","following_url":"https://api.github.com/users/bjoeris/following{/other_user}","gists_url":"https://api.github.com/users/bjoeris/gists{/gist_id}","starred_url":"https://api.github.com/users/bjoeris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjoeris/subscriptions","organizations_url":"https://api.github.com/users/bjoeris/orgs","repos_url":"https://api.github.com/users/bjoeris/repos","events_url":"https://api.github.com/users/bjoeris/events{/privacy}","received_events_url":"https://api.github.com/users/bjoeris/received_events","type":"User","site_admin":false},"body":"This is an initial commit of the Vulkan dependency graph code, and dead code elimination using the dependency graph.\r\n\r\nThe new DCE can work as a drop-in replacement for the existing Vulkan DCE, but this is disabled by default, using a config flag (`NewDeadCodeElimination`). This new DCE has been tested successfully against each vulkan_test_applications and SaschaWillems sample.\r\n\r\nI'm working on a doc describing the design.","created_at":"2018-06-01T19:21:34Z","updated_at":"2018-06-11T08:42:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63d10109689969a98620a3a521cc248effbe6fb3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/gapid/pulls/1949/commits","review_comments_url":"https://api.github.com/repos/google/gapid/pulls/1949/comments","review_comment_url":"https://api.github.com/repos/google/gapid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/gapid/issues/1949/comments","statuses_url":"https://api.github.com/repos/google/gapid/statuses/a5897221a65ac18a44276afd41e9c1b6476df0cb","head":{"label":"bjoeris:dependency-graph-accessors","ref":"dependency-graph-accessors","sha":"a5897221a65ac18a44276afd41e9c1b6476df0cb","user":{"login":"bjoeris","id":1546096,"node_id":"MDQ6VXNlcjE1NDYwOTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1546096?v=4","gravatar_id":"","url":"https://api.github.com/users/bjoeris","html_url":"https://github.com/bjoeris","followers_url":"https://api.github.com/users/bjoeris/followers","following_url":"https://api.github.com/users/bjoeris/following{/other_user}","gists_url":"https://api.github.com/users/bjoeris/gists{/gist_id}","starred_url":"https://api.github.com/users/bjoeris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjoeris/subscriptions","organizations_url":"https://api.github.com/users/bjoeris/orgs","repos_url":"https://api.github.com/users/bjoeris/repos","events_url":"https://api.github.com/users/bjoeris/events{/privacy}","received_events_url":"https://api.github.com/users/bjoeris/received_events","type":"User","site_admin":false},"repo":{"id":131298843,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEyOTg4NDM=","name":"gapid","full_name":"bjoeris/gapid","owner":{"login":"bjoeris","id":1546096,"node_id":"MDQ6VXNlcjE1NDYwOTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1546096?v=4","gravatar_id":"","url":"https://api.github.com/users/bjoeris","html_url":"https://github.com/bjoeris","followers_url":"https://api.github.com/users/bjoeris/followers","following_url":"https://api.github.com/users/bjoeris/following{/other_user}","gists_url":"https://api.github.com/users/bjoeris/gists{/gist_id}","starred_url":"https://api.github.com/users/bjoeris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjoeris/subscriptions","organizations_url":"https://api.github.com/users/bjoeris/orgs","repos_url":"https://api.github.com/users/bjoeris/repos","events_url":"https://api.github.com/users/bjoeris/events{/privacy}","received_events_url":"https://api.github.com/users/bjoeris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjoeris/gapid","description":"Graphics API Debugger","fork":true,"url":"https://api.github.com/repos/bjoeris/gapid","forks_url":"https://api.github.com/repos/bjoeris/gapid/forks","keys_url":"https://api.github.com/repos/bjoeris/gapid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjoeris/gapid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjoeris/gapid/teams","hooks_url":"https://api.github.com/repos/bjoeris/gapid/hooks","issue_events_url":"https://api.github.com/repos/bjoeris/gapid/issues/events{/number}","events_url":"https://api.github.com/repos/bjoeris/gapid/events","assignees_url":"https://api.github.com/repos/bjoeris/gapid/assignees{/user}","branches_url":"https://api.github.com/repos/bjoeris/gapid/branches{/branch}","tags_url":"https://api.github.com/repos/bjoeris/gapid/tags","blobs_url":"https://api.github.com/repos/bjoeris/gapid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjoeris/gapid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjoeris/gapid/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjoeris/gapid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjoeris/gapid/statuses/{sha}","languages_url":"https://api.github.com/repos/bjoeris/gapid/languages","stargazers_url":"https://api.github.com/repos/bjoeris/gapid/stargazers","contributors_url":"https://api.github.com/repos/bjoeris/gapid/contributors","subscribers_url":"https://api.github.com/repos/bjoeris/gapid/subscribers","subscription_url":"https://api.github.com/repos/bjoeris/gapid/subscription","commits_url":"https://api.github.com/repos/bjoeris/gapid/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjoeris/gapid/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjoeris/gapid/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjoeris/gapid/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjoeris/gapid/contents/{+path}","compare_url":"https://api.github.com/repos/bjoeris/gapid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjoeris/gapid/merges","archive_url":"https://api.github.com/repos/bjoeris/gapid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjoeris/gapid/downloads","issues_url":"https://api.github.com/repos/bjoeris/gapid/issues{/number}","pulls_url":"https://api.github.com/repos/bjoeris/gapid/pulls{/number}","milestones_url":"https://api.github.com/repos/bjoeris/gapid/milestones{/number}","notifications_url":"https://api.github.com/repos/bjoeris/gapid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjoeris/gapid/labels{/name}","releases_url":"https://api.github.com/repos/bjoeris/gapid/releases{/id}","deployments_url":"https://api.github.com/repos/bjoeris/gapid/deployments","created_at":"2018-04-27T13:18:02Z","updated_at":"2018-06-01T16:08:49Z","pushed_at":"2018-06-01T19:15:10Z","git_url":"git://github.com/bjoeris/gapid.git","ssh_url":"git@github.com:bjoeris/gapid.git","clone_url":"https://github.com/bjoeris/gapid.git","svn_url":"https://github.com/bjoeris/gapid","homepage":"","size":67895,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"bdaba32e8ed925d6fa02d06953aae5f7f919e3d4","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":81937787,"node_id":"MDEwOlJlcG9zaXRvcnk4MTkzNzc4Nw==","name":"gapid","full_name":"google/gapid","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/gapid","description":"Graphics API Debugger","fork":false,"url":"https://api.github.com/repos/google/gapid","forks_url":"https://api.github.com/repos/google/gapid/forks","keys_url":"https://api.github.com/repos/google/gapid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/gapid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/gapid/teams","hooks_url":"https://api.github.com/repos/google/gapid/hooks","issue_events_url":"https://api.github.com/repos/google/gapid/issues/events{/number}","events_url":"https://api.github.com/repos/google/gapid/events","assignees_url":"https://api.github.com/repos/google/gapid/assignees{/user}","branches_url":"https://api.github.com/repos/google/gapid/branches{/branch}","tags_url":"https://api.github.com/repos/google/gapid/tags","blobs_url":"https://api.github.com/repos/google/gapid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/gapid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/gapid/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/gapid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/gapid/statuses/{sha}","languages_url":"https://api.github.com/repos/google/gapid/languages","stargazers_url":"https://api.github.com/repos/google/gapid/stargazers","contributors_url":"https://api.github.com/repos/google/gapid/contributors","subscribers_url":"https://api.github.com/repos/google/gapid/subscribers","subscription_url":"https://api.github.com/repos/google/gapid/subscription","commits_url":"https://api.github.com/repos/google/gapid/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/gapid/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/gapid/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/gapid/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/gapid/contents/{+path}","compare_url":"https://api.github.com/repos/google/gapid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/gapid/merges","archive_url":"https://api.github.com/repos/google/gapid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/gapid/downloads","issues_url":"https://api.github.com/repos/google/gapid/issues{/number}","pulls_url":"https://api.github.com/repos/google/gapid/pulls{/number}","milestones_url":"https://api.github.com/repos/google/gapid/milestones{/number}","notifications_url":"https://api.github.com/repos/google/gapid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/gapid/labels{/name}","releases_url":"https://api.github.com/repos/google/gapid/releases{/id}","deployments_url":"https://api.github.com/repos/google/gapid/deployments","created_at":"2017-02-14T11:18:43Z","updated_at":"2018-06-11T06:40:17Z","pushed_at":"2018-06-08T21:31:44Z","git_url":"git://github.com/google/gapid.git","ssh_url":"git@github.com:google/gapid.git","clone_url":"https://github.com/google/gapid.git","svn_url":"https://github.com/google/gapid","homepage":"","size":67864,"stargazers_count":767,"watchers_count":767,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":194,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":125,"open_issues":194,"watchers":767,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/gapid/pulls/1949"},"html":{"href":"https://github.com/google/gapid/pull/1949"},"issue":{"href":"https://api.github.com/repos/google/gapid/issues/1949"},"comments":{"href":"https://api.github.com/repos/google/gapid/issues/1949/comments"},"review_comments":{"href":"https://api.github.com/repos/google/gapid/pulls/1949/comments"},"review_comment":{"href":"https://api.github.com/repos/google/gapid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/gapid/pulls/1949/commits"},"statuses":{"href":"https://api.github.com/repos/google/gapid/statuses/a5897221a65ac18a44276afd41e9c1b6476df0cb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ben-clayton"}}