{"action":"created","issue":{"url":"https://api.github.com/repos/loevgaard/SyliusBrandPlugin/issues/1","repository_url":"https://api.github.com/repos/loevgaard/SyliusBrandPlugin","labels_url":"https://api.github.com/repos/loevgaard/SyliusBrandPlugin/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/loevgaard/SyliusBrandPlugin/issues/1/comments","events_url":"https://api.github.com/repos/loevgaard/SyliusBrandPlugin/issues/1/events","html_url":"https://github.com/loevgaard/SyliusBrandPlugin/issues/1","id":340958517,"node_id":"MDU6SXNzdWUzNDA5NTg1MTc=","number":1,"title":"Sylius official plugin","user":{"login":"Zales0123","id":6212718,"node_id":"MDQ6VXNlcjYyMTI3MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6212718?v=4","gravatar_id":"","url":"https://api.github.com/users/Zales0123","html_url":"https://github.com/Zales0123","followers_url":"https://api.github.com/users/Zales0123/followers","following_url":"https://api.github.com/users/Zales0123/following{/other_user}","gists_url":"https://api.github.com/users/Zales0123/gists{/gist_id}","starred_url":"https://api.github.com/users/Zales0123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zales0123/subscriptions","organizations_url":"https://api.github.com/users/Zales0123/orgs","repos_url":"https://api.github.com/users/Zales0123/repos","events_url":"https://api.github.com/users/Zales0123/events{/privacy}","received_events_url":"https://api.github.com/users/Zales0123/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"loevgaard","id":2412177,"node_id":"MDQ6VXNlcjI0MTIxNzc=","avatar_url":"https://avatars2.githubusercontent.com/u/2412177?v=4","gravatar_id":"","url":"https://api.github.com/users/loevgaard","html_url":"https://github.com/loevgaard","followers_url":"https://api.github.com/users/loevgaard/followers","following_url":"https://api.github.com/users/loevgaard/following{/other_user}","gists_url":"https://api.github.com/users/loevgaard/gists{/gist_id}","starred_url":"https://api.github.com/users/loevgaard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loevgaard/subscriptions","organizations_url":"https://api.github.com/users/loevgaard/orgs","repos_url":"https://api.github.com/users/loevgaard/repos","events_url":"https://api.github.com/users/loevgaard/events{/privacy}","received_events_url":"https://api.github.com/users/loevgaard/received_events","type":"User","site_admin":false},"assignees":[{"login":"loevgaard","id":2412177,"node_id":"MDQ6VXNlcjI0MTIxNzc=","avatar_url":"https://avatars2.githubusercontent.com/u/2412177?v=4","gravatar_id":"","url":"https://api.github.com/users/loevgaard","html_url":"https://github.com/loevgaard","followers_url":"https://api.github.com/users/loevgaard/followers","following_url":"https://api.github.com/users/loevgaard/following{/other_user}","gists_url":"https://api.github.com/users/loevgaard/gists{/gist_id}","starred_url":"https://api.github.com/users/loevgaard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loevgaard/subscriptions","organizations_url":"https://api.github.com/users/loevgaard/orgs","repos_url":"https://api.github.com/users/loevgaard/repos","events_url":"https://api.github.com/users/loevgaard/events{/privacy}","received_events_url":"https://api.github.com/users/loevgaard/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-07-13T10:02:14Z","updated_at":"2018-08-08T08:12:59Z","closed_at":null,"author_association":"NONE","body":"Hi Joachim!\r\n\r\nI'm Mateusz, I work in Sylius company and one of my roles is Plugin Curator - I'm responsible for checking out Sylius Plugins that appear in our ecosystem. We would really love to display this one on our officially accepted plugins list (https://sylius.com/plugins/), as I strongly believe it could be useful for other people in the community :)\r\n\r\nThe only problem is, we have some strict requirements for the plugin that is meant to be displayed on our website. One of the most important are the properly developed tests. Sadly, your plugin has neither no acceptance (Behat) tests (good there are some unit tests 👍). Do you think you would be able to provide them? \r\n\r\nI have also some other comments that could improve the code base of your plugin and make it closer to our ideal Sylius Plugin vision :)\r\n\r\nIf you have any question, please, feel free to ask me.\r\nNevertheless, thank you for your great job! 🎉 "},"comment":{"url":"https://api.github.com/repos/loevgaard/SyliusBrandPlugin/issues/comments/411324907","html_url":"https://github.com/loevgaard/SyliusBrandPlugin/issues/1#issuecomment-411324907","issue_url":"https://api.github.com/repos/loevgaard/SyliusBrandPlugin/issues/1","id":411324907,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTMyNDkwNw==","user":{"login":"Zales0123","id":6212718,"node_id":"MDQ6VXNlcjYyMTI3MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6212718?v=4","gravatar_id":"","url":"https://api.github.com/users/Zales0123","html_url":"https://github.com/Zales0123","followers_url":"https://api.github.com/users/Zales0123/followers","following_url":"https://api.github.com/users/Zales0123/following{/other_user}","gists_url":"https://api.github.com/users/Zales0123/gists{/gist_id}","starred_url":"https://api.github.com/users/Zales0123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zales0123/subscriptions","organizations_url":"https://api.github.com/users/Zales0123/orgs","repos_url":"https://api.github.com/users/Zales0123/repos","events_url":"https://api.github.com/users/Zales0123/events{/privacy}","received_events_url":"https://api.github.com/users/Zales0123/received_events","type":"User","site_admin":false},"created_at":"2018-08-08T08:12:59Z","updated_at":"2018-08-08T08:12:59Z","author_association":"NONE","body":"Nice! Regarding your questions:\r\n\r\n1. Indeed, you could just put in installation step \"generate migration for yourself\" and it should work :)\r\n2. The test application should be considered as a regular application using a plugin, that means `Product` class should be in `tests/Application/Entity/Product`, mapping in `tests/Application/Resources/config/doctrine/Product.orm.xml` etc\r\n\r\nRight now I'm missing two things:\r\n1. Adding/editing a brand on a product - there is a form extension, but the template is not overridden... It should be for sure provided with proper Behat test :)\r\n2. Some front-end part - plugin provides right now only the admin part of brand management, which in fact means that it does not provide any business value for the application 😄\r\n\r\nLet me know what you think about these missing features. We should really focus on providing some business value with plugins, as it was not respected in many plugins yet.\r\n\r\nNevertheless, nice work, I'm sure it will be ready for display on our site soon! :)"}}
{"actor":{"display_login":"Zales0123"}}