{"action":"created","comment":{"url":"https://api.github.com/repos/replicatedhq/ship/pulls/comments/236869232","pull_request_review_id":179037633,"id":236869232,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjg2OTIzMg==","diff_hunk":"@@ -50,9 +58,17 @@ Upstream can be one of:\n \tcmd.Flags().Bool(\"rm-asset-dest\", false, \"Always remove asset destinations if already present\")\n \tcmd.Flags().Int(\"retries\", 3, \"Number of times to retry retrieving upstream\")\n \n-\tviper.BindPFlags(cmd.Flags())\n-\tviper.BindPFlags(cmd.PersistentFlags())\n-\tviper.AutomaticEnv()\n-\tviper.SetEnvKeyReplacer(strings.NewReplacer(\"-\", \"_\"))\n+\t// optional flags for \"ship init replicated.app\"\n+\tcmd.Flags().String(\"customer-id\", \"\", \"Customer ID for which to query app specs. Required for all ship operations.\")\n+\tcmd.Flags().String(\"installation-id\", \"\", \"Installation ID for which to query app specs\")\n+\tcmd.Flags().String(\"release-semver\", \"\", \"Specific release version to pin installation to. Requires channel-id\")\n+\n+\t// optional developer flags for \"ship init replicated.app\"\n+\tcmd.Flags().String(\"runbook\", \"\", developerFlagUsage)\n+\tcmd.Flags().String(\"set-channel-name\", \"\", developerFlagUsage)\n+\tcmd.Flags().String(\"set-channel-icon\", \"\", developerFlagUsage)\n+\tcmd.Flags().StringSlice(\"set-github-contents\", []string{}, fmt.Sprintf(\"Specify a REPO:REPO_PATH:REF:LOCAL_PATH to override github checkouts to use a local path on the filesystem. %s. \", developerFlagUsage))\n+\tcmd.Flags().String(\"set-entitlements-json\", \"{\\\"values\\\":[]}\", fmt.Sprintf(\"Specify json for entitlements payload. %s\", developerFlagUsage))","path":"pkg/cli/init.go","position":49,"original_position":49,"commit_id":"a07a87fb93f085ee73748f2bccffa624c3d39da4","original_commit_id":"a07a87fb93f085ee73748f2bccffa624c3d39da4","user":{"login":"dexhorthy","id":3730605,"node_id":"MDQ6VXNlcjM3MzA2MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/3730605?v=4","gravatar_id":"","url":"https://api.github.com/users/dexhorthy","html_url":"https://github.com/dexhorthy","followers_url":"https://api.github.com/users/dexhorthy/followers","following_url":"https://api.github.com/users/dexhorthy/following{/other_user}","gists_url":"https://api.github.com/users/dexhorthy/gists{/gist_id}","starred_url":"https://api.github.com/users/dexhorthy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexhorthy/subscriptions","organizations_url":"https://api.github.com/users/dexhorthy/orgs","repos_url":"https://api.github.com/users/dexhorthy/repos","events_url":"https://api.github.com/users/dexhorthy/events{/privacy}","received_events_url":"https://api.github.com/users/dexhorthy/received_events","type":"User","site_admin":false},"body":"all the rest of these look good","created_at":"2018-11-27T22:17:16Z","updated_at":"2018-11-27T22:17:17Z","html_url":"https://github.com/replicatedhq/ship/pull/725#discussion_r236869232","pull_request_url":"https://api.github.com/repos/replicatedhq/ship/pulls/725","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/replicatedhq/ship/pulls/comments/236869232"},"html":{"href":"https://github.com/replicatedhq/ship/pull/725#discussion_r236869232"},"pull_request":{"href":"https://api.github.com/repos/replicatedhq/ship/pulls/725"}}},"pull_request":{"url":"https://api.github.com/repos/replicatedhq/ship/pulls/725","id":233745603,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNzQ1NjAz","html_url":"https://github.com/replicatedhq/ship/pull/725","diff_url":"https://github.com/replicatedhq/ship/pull/725.diff","patch_url":"https://github.com/replicatedhq/ship/pull/725.patch","issue_url":"https://api.github.com/repos/replicatedhq/ship/issues/725","number":725,"state":"open","locked":false,"title":" support for ship init path/to/local/ship.yaml","user":{"login":"emosbaugh","id":371319,"node_id":"MDQ6VXNlcjM3MTMxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/371319?v=4","gravatar_id":"","url":"https://api.github.com/users/emosbaugh","html_url":"https://github.com/emosbaugh","followers_url":"https://api.github.com/users/emosbaugh/followers","following_url":"https://api.github.com/users/emosbaugh/following{/other_user}","gists_url":"https://api.github.com/users/emosbaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/emosbaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emosbaugh/subscriptions","organizations_url":"https://api.github.com/users/emosbaugh/orgs","repos_url":"https://api.github.com/users/emosbaugh/repos","events_url":"https://api.github.com/users/emosbaugh/events{/privacy}","received_events_url":"https://api.github.com/users/emosbaugh/received_events","type":"User","site_admin":false},"body":"What I Did\r\n------------\r\nThere were two different code paths that have similar functionality, one `ship app` and the other `ship init --runbook path/to/local/ship.yaml`. I've merge all additional functionality from `ship app` into `ship init`.\r\n\r\nHow I Did it\r\n------------\r\nChanged the code.\r\n\r\nHow to verify it\r\n------------\r\n1) Run the integration tests\r\n2) https://github.com/retracedhq/api/pull/389\r\n\r\nDescription for the Changelog\r\n------------\r\nThe `ship app --runbook /path/to/local/ship.yaml` command has been deprecated in favor of `ship init local.replicated.app/myapp --runbook /path/to/local/ship.yaml`\r\n\r\n\r\nPicture of a Boat (not required but encouraged)\r\n------------\r\n\r\n![boat](http://www.netanimations.net/fatcat-Q.gif)\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n<!-- (thanks https://github.com/docker/docker for this template) -->\r\n\r\n","created_at":"2018-11-27T00:56:27Z","updated_at":"2018-11-27T22:17:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cf6bc2d5028a170e53518513adbb332d6684c5a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"marccampbell","id":173451,"node_id":"MDQ6VXNlcjE3MzQ1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/173451?v=4","gravatar_id":"","url":"https://api.github.com/users/marccampbell","html_url":"https://github.com/marccampbell","followers_url":"https://api.github.com/users/marccampbell/followers","following_url":"https://api.github.com/users/marccampbell/following{/other_user}","gists_url":"https://api.github.com/users/marccampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/marccampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marccampbell/subscriptions","organizations_url":"https://api.github.com/users/marccampbell/orgs","repos_url":"https://api.github.com/users/marccampbell/repos","events_url":"https://api.github.com/users/marccampbell/events{/privacy}","received_events_url":"https://api.github.com/users/marccampbell/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/replicatedhq/ship/pulls/725/commits","review_comments_url":"https://api.github.com/repos/replicatedhq/ship/pulls/725/comments","review_comment_url":"https://api.github.com/repos/replicatedhq/ship/pulls/comments{/number}","comments_url":"https://api.github.com/repos/replicatedhq/ship/issues/725/comments","statuses_url":"https://api.github.com/repos/replicatedhq/ship/statuses/a07a87fb93f085ee73748f2bccffa624c3d39da4","head":{"label":"emosbaugh:ship-init-local-app","ref":"ship-init-local-app","sha":"a07a87fb93f085ee73748f2bccffa624c3d39da4","user":{"login":"emosbaugh","id":371319,"node_id":"MDQ6VXNlcjM3MTMxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/371319?v=4","gravatar_id":"","url":"https://api.github.com/users/emosbaugh","html_url":"https://github.com/emosbaugh","followers_url":"https://api.github.com/users/emosbaugh/followers","following_url":"https://api.github.com/users/emosbaugh/following{/other_user}","gists_url":"https://api.github.com/users/emosbaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/emosbaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emosbaugh/subscriptions","organizations_url":"https://api.github.com/users/emosbaugh/orgs","repos_url":"https://api.github.com/users/emosbaugh/repos","events_url":"https://api.github.com/users/emosbaugh/events{/privacy}","received_events_url":"https://api.github.com/users/emosbaugh/received_events","type":"User","site_admin":false},"repo":{"id":149656242,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2NTYyNDI=","name":"ship-1","full_name":"emosbaugh/ship-1","private":false,"owner":{"login":"emosbaugh","id":371319,"node_id":"MDQ6VXNlcjM3MTMxOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/371319?v=4","gravatar_id":"","url":"https://api.github.com/users/emosbaugh","html_url":"https://github.com/emosbaugh","followers_url":"https://api.github.com/users/emosbaugh/followers","following_url":"https://api.github.com/users/emosbaugh/following{/other_user}","gists_url":"https://api.github.com/users/emosbaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/emosbaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emosbaugh/subscriptions","organizations_url":"https://api.github.com/users/emosbaugh/orgs","repos_url":"https://api.github.com/users/emosbaugh/repos","events_url":"https://api.github.com/users/emosbaugh/events{/privacy}","received_events_url":"https://api.github.com/users/emosbaugh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/emosbaugh/ship-1","description":"Reducing the Operational Overhead of Maintaining 3rd-party Applications in Kubernetes","fork":true,"url":"https://api.github.com/repos/emosbaugh/ship-1","forks_url":"https://api.github.com/repos/emosbaugh/ship-1/forks","keys_url":"https://api.github.com/repos/emosbaugh/ship-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emosbaugh/ship-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emosbaugh/ship-1/teams","hooks_url":"https://api.github.com/repos/emosbaugh/ship-1/hooks","issue_events_url":"https://api.github.com/repos/emosbaugh/ship-1/issues/events{/number}","events_url":"https://api.github.com/repos/emosbaugh/ship-1/events","assignees_url":"https://api.github.com/repos/emosbaugh/ship-1/assignees{/user}","branches_url":"https://api.github.com/repos/emosbaugh/ship-1/branches{/branch}","tags_url":"https://api.github.com/repos/emosbaugh/ship-1/tags","blobs_url":"https://api.github.com/repos/emosbaugh/ship-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emosbaugh/ship-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emosbaugh/ship-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/emosbaugh/ship-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emosbaugh/ship-1/statuses/{sha}","languages_url":"https://api.github.com/repos/emosbaugh/ship-1/languages","stargazers_url":"https://api.github.com/repos/emosbaugh/ship-1/stargazers","contributors_url":"https://api.github.com/repos/emosbaugh/ship-1/contributors","subscribers_url":"https://api.github.com/repos/emosbaugh/ship-1/subscribers","subscription_url":"https://api.github.com/repos/emosbaugh/ship-1/subscription","commits_url":"https://api.github.com/repos/emosbaugh/ship-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/emosbaugh/ship-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/emosbaugh/ship-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/emosbaugh/ship-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/emosbaugh/ship-1/contents/{+path}","compare_url":"https://api.github.com/repos/emosbaugh/ship-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emosbaugh/ship-1/merges","archive_url":"https://api.github.com/repos/emosbaugh/ship-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emosbaugh/ship-1/downloads","issues_url":"https://api.github.com/repos/emosbaugh/ship-1/issues{/number}","pulls_url":"https://api.github.com/repos/emosbaugh/ship-1/pulls{/number}","milestones_url":"https://api.github.com/repos/emosbaugh/ship-1/milestones{/number}","notifications_url":"https://api.github.com/repos/emosbaugh/ship-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emosbaugh/ship-1/labels{/name}","releases_url":"https://api.github.com/repos/emosbaugh/ship-1/releases{/id}","deployments_url":"https://api.github.com/repos/emosbaugh/ship-1/deployments","created_at":"2018-09-20T18:56:38Z","updated_at":"2018-11-16T22:43:02Z","pushed_at":"2018-11-27T21:50:43Z","git_url":"git://github.com/emosbaugh/ship-1.git","ssh_url":"git@github.com:emosbaugh/ship-1.git","clone_url":"https://github.com/emosbaugh/ship-1.git","svn_url":"https://github.com/emosbaugh/ship-1","homepage":"","size":116778,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"replicatedhq:master","ref":"master","sha":"df7ff6e80293186161b23786e000b14acd4d3c08","user":{"login":"replicatedhq","id":13105802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTA1ODAy","avatar_url":"https://avatars3.githubusercontent.com/u/13105802?v=4","gravatar_id":"","url":"https://api.github.com/users/replicatedhq","html_url":"https://github.com/replicatedhq","followers_url":"https://api.github.com/users/replicatedhq/followers","following_url":"https://api.github.com/users/replicatedhq/following{/other_user}","gists_url":"https://api.github.com/users/replicatedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/replicatedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/replicatedhq/subscriptions","organizations_url":"https://api.github.com/users/replicatedhq/orgs","repos_url":"https://api.github.com/users/replicatedhq/repos","events_url":"https://api.github.com/users/replicatedhq/events{/privacy}","received_events_url":"https://api.github.com/users/replicatedhq/received_events","type":"Organization","site_admin":false},"repo":{"id":126047712,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYwNDc3MTI=","name":"ship","full_name":"replicatedhq/ship","private":false,"owner":{"login":"replicatedhq","id":13105802,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTA1ODAy","avatar_url":"https://avatars3.githubusercontent.com/u/13105802?v=4","gravatar_id":"","url":"https://api.github.com/users/replicatedhq","html_url":"https://github.com/replicatedhq","followers_url":"https://api.github.com/users/replicatedhq/followers","following_url":"https://api.github.com/users/replicatedhq/following{/other_user}","gists_url":"https://api.github.com/users/replicatedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/replicatedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/replicatedhq/subscriptions","organizations_url":"https://api.github.com/users/replicatedhq/orgs","repos_url":"https://api.github.com/users/replicatedhq/repos","events_url":"https://api.github.com/users/replicatedhq/events{/privacy}","received_events_url":"https://api.github.com/users/replicatedhq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/replicatedhq/ship","description":"Reducing the Operational Overhead of Maintaining 3rd-party Applications in Kubernetes","fork":false,"url":"https://api.github.com/repos/replicatedhq/ship","forks_url":"https://api.github.com/repos/replicatedhq/ship/forks","keys_url":"https://api.github.com/repos/replicatedhq/ship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/replicatedhq/ship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/replicatedhq/ship/teams","hooks_url":"https://api.github.com/repos/replicatedhq/ship/hooks","issue_events_url":"https://api.github.com/repos/replicatedhq/ship/issues/events{/number}","events_url":"https://api.github.com/repos/replicatedhq/ship/events","assignees_url":"https://api.github.com/repos/replicatedhq/ship/assignees{/user}","branches_url":"https://api.github.com/repos/replicatedhq/ship/branches{/branch}","tags_url":"https://api.github.com/repos/replicatedhq/ship/tags","blobs_url":"https://api.github.com/repos/replicatedhq/ship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/replicatedhq/ship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/replicatedhq/ship/git/refs{/sha}","trees_url":"https://api.github.com/repos/replicatedhq/ship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/replicatedhq/ship/statuses/{sha}","languages_url":"https://api.github.com/repos/replicatedhq/ship/languages","stargazers_url":"https://api.github.com/repos/replicatedhq/ship/stargazers","contributors_url":"https://api.github.com/repos/replicatedhq/ship/contributors","subscribers_url":"https://api.github.com/repos/replicatedhq/ship/subscribers","subscription_url":"https://api.github.com/repos/replicatedhq/ship/subscription","commits_url":"https://api.github.com/repos/replicatedhq/ship/commits{/sha}","git_commits_url":"https://api.github.com/repos/replicatedhq/ship/git/commits{/sha}","comments_url":"https://api.github.com/repos/replicatedhq/ship/comments{/number}","issue_comment_url":"https://api.github.com/repos/replicatedhq/ship/issues/comments{/number}","contents_url":"https://api.github.com/repos/replicatedhq/ship/contents/{+path}","compare_url":"https://api.github.com/repos/replicatedhq/ship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/replicatedhq/ship/merges","archive_url":"https://api.github.com/repos/replicatedhq/ship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/replicatedhq/ship/downloads","issues_url":"https://api.github.com/repos/replicatedhq/ship/issues{/number}","pulls_url":"https://api.github.com/repos/replicatedhq/ship/pulls{/number}","milestones_url":"https://api.github.com/repos/replicatedhq/ship/milestones{/number}","notifications_url":"https://api.github.com/repos/replicatedhq/ship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/replicatedhq/ship/labels{/name}","releases_url":"https://api.github.com/repos/replicatedhq/ship/releases{/id}","deployments_url":"https://api.github.com/repos/replicatedhq/ship/deployments","created_at":"2018-03-20T16:24:26Z","updated_at":"2018-11-27T02:55:28Z","pushed_at":"2018-11-27T21:50:44Z","git_url":"git://github.com/replicatedhq/ship.git","ssh_url":"git@github.com:replicatedhq/ship.git","clone_url":"https://github.com/replicatedhq/ship.git","svn_url":"https://github.com/replicatedhq/ship","homepage":"https://ship.replicated.com","size":116727,"stargazers_count":148,"watchers_count":148,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":40,"open_issues":26,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/replicatedhq/ship/pulls/725"},"html":{"href":"https://github.com/replicatedhq/ship/pull/725"},"issue":{"href":"https://api.github.com/repos/replicatedhq/ship/issues/725"},"comments":{"href":"https://api.github.com/repos/replicatedhq/ship/issues/725/comments"},"review_comments":{"href":"https://api.github.com/repos/replicatedhq/ship/pulls/725/comments"},"review_comment":{"href":"https://api.github.com/repos/replicatedhq/ship/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/replicatedhq/ship/pulls/725/commits"},"statuses":{"href":"https://api.github.com/repos/replicatedhq/ship/statuses/a07a87fb93f085ee73748f2bccffa624c3d39da4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dexhorthy"}}