{"action":"created","issue":{"url":"https://api.github.com/repos/FRRouting/frr/issues/1950","repository_url":"https://api.github.com/repos/FRRouting/frr","labels_url":"https://api.github.com/repos/FRRouting/frr/issues/1950/labels{/name}","comments_url":"https://api.github.com/repos/FRRouting/frr/issues/1950/comments","events_url":"https://api.github.com/repos/FRRouting/frr/issues/1950/events","html_url":"https://github.com/FRRouting/frr/pull/1950","id":307548920,"number":1950,"title":" VRF NETNS / add an indirection table for mapping NSID/VRFID","user":{"login":"pguibert6WIND","id":16295538,"avatar_url":"https://avatars2.githubusercontent.com/u/16295538?v=4","gravatar_id":"","url":"https://api.github.com/users/pguibert6WIND","html_url":"https://github.com/pguibert6WIND","followers_url":"https://api.github.com/users/pguibert6WIND/followers","following_url":"https://api.github.com/users/pguibert6WIND/following{/other_user}","gists_url":"https://api.github.com/users/pguibert6WIND/gists{/gist_id}","starred_url":"https://api.github.com/users/pguibert6WIND/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pguibert6WIND/subscriptions","organizations_url":"https://api.github.com/users/pguibert6WIND/orgs","repos_url":"https://api.github.com/users/pguibert6WIND/repos","events_url":"https://api.github.com/users/pguibert6WIND/events{/privacy}","received_events_url":"https://api.github.com/users/pguibert6WIND/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-03-22T08:37:14Z","updated_at":"2018-03-26T11:16:58Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/FRRouting/frr/pulls/1950","html_url":"https://github.com/FRRouting/frr/pull/1950","diff_url":"https://github.com/FRRouting/frr/pull/1950.diff","patch_url":"https://github.com/FRRouting/frr/pull/1950.patch"},"body":"The issue raised here is to deal with the need for zclient daemons to rely on zebra to get all vrf_ids, including the default VRF.\r\n\r\nhttps://github.com/FRRouting/frr/issues/1949\r\n\r\ndefault behaviour : \r\n- default VRF is set to 0 for all zclient daemons, so that zclient suppose 0 value is for default vrf.\r\n- for BGP, there is a mechanism that permits swapping this mechanism.\r\n"},"comment":{"url":"https://api.github.com/repos/FRRouting/frr/issues/comments/376131544","html_url":"https://github.com/FRRouting/frr/pull/1950#issuecomment-376131544","issue_url":"https://api.github.com/repos/FRRouting/frr/issues/1950","id":376131544,"user":{"login":"NetDEF-CI","id":19297776,"avatar_url":"https://avatars3.githubusercontent.com/u/19297776?v=4","gravatar_id":"","url":"https://api.github.com/users/NetDEF-CI","html_url":"https://github.com/NetDEF-CI","followers_url":"https://api.github.com/users/NetDEF-CI/followers","following_url":"https://api.github.com/users/NetDEF-CI/following{/other_user}","gists_url":"https://api.github.com/users/NetDEF-CI/gists{/gist_id}","starred_url":"https://api.github.com/users/NetDEF-CI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetDEF-CI/subscriptions","organizations_url":"https://api.github.com/users/NetDEF-CI/orgs","repos_url":"https://api.github.com/users/NetDEF-CI/repos","events_url":"https://api.github.com/users/NetDEF-CI/events{/privacy}","received_events_url":"https://api.github.com/users/NetDEF-CI/received_events","type":"User","site_admin":false},"created_at":"2018-03-26T11:16:58Z","updated_at":"2018-03-26T11:16:58Z","author_association":"COLLABORATOR","body":"# Continuous Integration Result: FAILED\n\nSee below for issues.\nCI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3092/\n\nThis is a comment from an EXPERIMENTAL automated CI system.\nFor questions and feedback in regards to this CI system, please feel free to email\nMartin Winter - mwinter (at) opensourcerouting.org.\n\n\n## Get source and apply patch from patchwork: Successful\n\n## Building Stage: Successful\n\n## Basic Tests: Failed\n__CentOS 7 rpm pkg check: Successful__\n__Ubuntu 16.04 deb pkg check: Successful__\n__IPv6 protocols on Ubuntu 14.04: Successful__\n__Topotest tests on Ubuntu 16.04 i386: Successful__\n__Fedora 24 rpm pkg check: Successful__\n__Addresssanitizer topotest: Successful__\n__Debian 8 deb pkg check: Successful__\n__IPv4 protocols on Ubuntu 14.04: Successful__\n__CentOS 6 rpm pkg check: Successful__\n__IPv4 ldp protocol on Ubuntu 16.04: Successful__\n__Ubuntu 14.04 deb pkg check: Successful__\n__Debian 9 deb pkg check: Successful__\n__Ubuntu 12.04 deb pkg check: Successful__\n__Static analyzer (clang): Successful__\n\n\n#### Topology tests on Ubuntu 16.04 amd64: Failed\nTopology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-3092/test\n\n__Topology Tests failed for Topology tests on Ubuntu 16.04 amd64__:\n\n    2018-03-26 12:56:12,745 ERROR: assert failed at \"bgp_vrf_netns.test_bgp_vrf_netns_topo/test_bgp_convergence\": BGP router network did not converge\n    assert json[\"ipv4Unicast\"][\"peers\"][\"10.0.1.101\"][\"state\"] value is different (\n      --- Expected value\n      +++ Current value\n      @@ -1 +1 @@\n      -\"Established\"\n      +\"Idle\")\n      json[\"ipv4Unicast\"][\"peers\"][\"10.0.1.101\"][\"prefixReceivedCount\"] value is different (\n      --- Expected value\n      +++ Current value\n      @@ -1 +1 @@\n      -10\n      +0)\n    2018-03-26 12:56:15,964 ERROR: assert failed at \"bgp_vrf_netns.test_bgp_vrf_netns_topo/test_bgp_vrf_netns\": expected routes in \"show ip bgp vrf r1-cust1 ipv4\" output\n    assert expected key(s) ['10.201.3.0/24', '10.201.6.0/24', '10.201.5.0/24', '10.201.8.0/24', '10.201.9.0/24', '10.201.0.0/24', '10.201.2.0/24', '10.201.1.0/24', '10.201.4.0/24', '10.201.7.0/24'] in json[\"routes\"] (have []):\n      --- Expected value\n      +++ Current value\n      @@ -1,52 +1 @@\n      -{\n      -    \"10.201.0.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.1.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.2.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.3.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.4.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.5.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.6.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.7.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.8.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.9.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ]\n      -}\n      +{}\n\n   see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3092/artifact/TOPOU1604/ErrorLog/log_topotests.txt\n\n__Topology Tests memory analysis:__ https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3092/artifact/TOPOU1604/MemoryLeaks/\n-----------------------------\n## Warnings Generated during build:\n\n\n### Checkout code: Successful with additional warnings:\n\n#### Topology tests on Ubuntu 16.04 amd64: Failed\nTopology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-3092/test\n\n__Topology Tests failed for Topology tests on Ubuntu 16.04 amd64__:\n\n    2018-03-26 12:56:12,745 ERROR: assert failed at \"bgp_vrf_netns.test_bgp_vrf_netns_topo/test_bgp_convergence\": BGP router network did not converge\n    assert json[\"ipv4Unicast\"][\"peers\"][\"10.0.1.101\"][\"state\"] value is different (\n      --- Expected value\n      +++ Current value\n      @@ -1 +1 @@\n      -\"Established\"\n      +\"Idle\")\n      json[\"ipv4Unicast\"][\"peers\"][\"10.0.1.101\"][\"prefixReceivedCount\"] value is different (\n      --- Expected value\n      +++ Current value\n      @@ -1 +1 @@\n      -10\n      +0)\n    2018-03-26 12:56:15,964 ERROR: assert failed at \"bgp_vrf_netns.test_bgp_vrf_netns_topo/test_bgp_vrf_netns\": expected routes in \"show ip bgp vrf r1-cust1 ipv4\" output\n    assert expected key(s) ['10.201.3.0/24', '10.201.6.0/24', '10.201.5.0/24', '10.201.8.0/24', '10.201.9.0/24', '10.201.0.0/24', '10.201.2.0/24', '10.201.1.0/24', '10.201.4.0/24', '10.201.7.0/24'] in json[\"routes\"] (have []):\n      --- Expected value\n      +++ Current value\n      @@ -1,52 +1 @@\n      -{\n      -    \"10.201.0.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.1.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.2.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.3.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.4.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.5.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.6.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.7.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.8.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ], \n      -    \"10.201.9.0/24\": [\n      -        {\n      -            \"valid\": true\n      -        }\n      -    ]\n      -}\n      +{}\n\n   see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-3092/artifact/TOPOU1604/ErrorLog/log_topotests.txt\n\n    Report for vrf.c\n    ===============================================\n    < WARNING: line over 80 characters\n    < #341: FILE: /tmp/f1-29975/vrf.c:341:\n    < +static __inline int vrf_map_compare(const struct vrf_map_nsid *a, const struct vrf_map_nsid *b)\n    < \n    < WARNING: plain inline is preferred over __inline\n    < #341: FILE: /tmp/f1-29975/vrf.c:341:\n    < +static __inline int vrf_map_compare(const struct vrf_map_nsid *a, const struct vrf_map_nsid *b)\n    < \n    < ERROR: return is not a function, parentheses are not required\n    < #358: FILE: /tmp/f1-29975/vrf.c:358:\n    < +\treturn (RB_FIND(vrf_map_nsid_head, &vrf_map_nsid_list, &vrf_map));\n    < \n\n\n-----------------------------\n### CLANG Static Analyzer Summary\n- Github Pull Request 1950, comparing to Git base SHA fc9aa7a\n#### No Changes in Static Analysis warnings compared to base\n#### 19 Static Analyzer issues remaining.\nSee details at\nhttps://ci1.netdef.org/browse/FRR-FRRPULLREQ-3092/artifact/shared/static_analysis/index.html\n"}}
{"actor":{"display_login":"NetDEF-CI"}}