{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/pulls/5","id":189356443,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5MzU2NDQz","html_url":"https://github.com/LedgerHQ/ledger-u2f-javacard/pull/5","diff_url":"https://github.com/LedgerHQ/ledger-u2f-javacard/pull/5.diff","patch_url":"https://github.com/LedgerHQ/ledger-u2f-javacard/pull/5.patch","issue_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/issues/5","number":5,"state":"closed","locked":false,"title":"Make non-final fields not static.","user":{"login":"J08nY","id":1296726,"node_id":"MDQ6VXNlcjEyOTY3MjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1296726?v=4","gravatar_id":"","url":"https://api.github.com/users/J08nY","html_url":"https://github.com/J08nY","followers_url":"https://api.github.com/users/J08nY/followers","following_url":"https://api.github.com/users/J08nY/following{/other_user}","gists_url":"https://api.github.com/users/J08nY/gists{/gist_id}","starred_url":"https://api.github.com/users/J08nY/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/J08nY/subscriptions","organizations_url":"https://api.github.com/users/J08nY/orgs","repos_url":"https://api.github.com/users/J08nY/repos","events_url":"https://api.github.com/users/J08nY/events{/privacy}","received_events_url":"https://api.github.com/users/J08nY/received_events","type":"User","site_admin":false},"body":"With static non-final fields, the applet would not be installable in multiple instances, also it is unreasonable to have those fields static(apart from possible minor performance gain on some cards) and makes for a testing nightmare.","created_at":"2018-05-21T11:44:09Z","updated_at":"2018-06-11T23:36:23Z","closed_at":"2018-06-11T23:36:22Z","merged_at":"2018-06-11T23:36:22Z","merge_commit_sha":"d2cc7b1a6ca694268e1e1eeddb4e04972f62d415","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/pulls/5/commits","review_comments_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/pulls/5/comments","review_comment_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/issues/5/comments","statuses_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/statuses/6fd54f51ed1db4b46bcb65c01792f2aa6b146029","head":{"label":"JavaCardSpot-dev:pullrequest/nonfinalnonstatic","ref":"pullrequest/nonfinalnonstatic","sha":"6fd54f51ed1db4b46bcb65c01792f2aa6b146029","user":{"login":"JavaCardSpot-dev","id":36691478,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjkxNDc4","avatar_url":"https://avatars3.githubusercontent.com/u/36691478?v=4","gravatar_id":"","url":"https://api.github.com/users/JavaCardSpot-dev","html_url":"https://github.com/JavaCardSpot-dev","followers_url":"https://api.github.com/users/JavaCardSpot-dev/followers","following_url":"https://api.github.com/users/JavaCardSpot-dev/following{/other_user}","gists_url":"https://api.github.com/users/JavaCardSpot-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/JavaCardSpot-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JavaCardSpot-dev/subscriptions","organizations_url":"https://api.github.com/users/JavaCardSpot-dev/orgs","repos_url":"https://api.github.com/users/JavaCardSpot-dev/repos","events_url":"https://api.github.com/users/JavaCardSpot-dev/events{/privacy}","received_events_url":"https://api.github.com/users/JavaCardSpot-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":122315968,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIzMTU5Njg=","name":"ledger-u2f-javacard","full_name":"JavaCardSpot-dev/ledger-u2f-javacard","owner":{"login":"JavaCardSpot-dev","id":36691478,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjkxNDc4","avatar_url":"https://avatars3.githubusercontent.com/u/36691478?v=4","gravatar_id":"","url":"https://api.github.com/users/JavaCardSpot-dev","html_url":"https://github.com/JavaCardSpot-dev","followers_url":"https://api.github.com/users/JavaCardSpot-dev/followers","following_url":"https://api.github.com/users/JavaCardSpot-dev/following{/other_user}","gists_url":"https://api.github.com/users/JavaCardSpot-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/JavaCardSpot-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JavaCardSpot-dev/subscriptions","organizations_url":"https://api.github.com/users/JavaCardSpot-dev/orgs","repos_url":"https://api.github.com/users/JavaCardSpot-dev/repos","events_url":"https://api.github.com/users/JavaCardSpot-dev/events{/privacy}","received_events_url":"https://api.github.com/users/JavaCardSpot-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JavaCardSpot-dev/ledger-u2f-javacard","description":"Java Card FIDO U2F authenticator for Ledger Unplugged","fork":true,"url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard","forks_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/forks","keys_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/teams","hooks_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/hooks","issue_events_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/issues/events{/number}","events_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/events","assignees_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/assignees{/user}","branches_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/branches{/branch}","tags_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/tags","blobs_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/git/refs{/sha}","trees_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/statuses/{sha}","languages_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/languages","stargazers_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/stargazers","contributors_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/contributors","subscribers_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/subscribers","subscription_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/subscription","commits_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/commits{/sha}","git_commits_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/git/commits{/sha}","comments_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/comments{/number}","issue_comment_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/issues/comments{/number}","contents_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/contents/{+path}","compare_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/merges","archive_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/downloads","issues_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/issues{/number}","pulls_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/pulls{/number}","milestones_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/milestones{/number}","notifications_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/labels{/name}","releases_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/releases{/id}","deployments_url":"https://api.github.com/repos/JavaCardSpot-dev/ledger-u2f-javacard/deployments","created_at":"2018-02-21T09:27:32Z","updated_at":"2018-04-19T21:47:17Z","pushed_at":"2018-05-21T11:48:22Z","git_url":"git://github.com/JavaCardSpot-dev/ledger-u2f-javacard.git","ssh_url":"git@github.com:JavaCardSpot-dev/ledger-u2f-javacard.git","clone_url":"https://github.com/JavaCardSpot-dev/ledger-u2f-javacard.git","svn_url":"https://github.com/JavaCardSpot-dev/ledger-u2f-javacard","homepage":null,"size":300,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"LedgerHQ:master","ref":"master","sha":"89499fb82ac9023726f77a4e65c5c213521a67fc","user":{"login":"LedgerHQ","id":9784193,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3ODQxOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9784193?v=4","gravatar_id":"","url":"https://api.github.com/users/LedgerHQ","html_url":"https://github.com/LedgerHQ","followers_url":"https://api.github.com/users/LedgerHQ/followers","following_url":"https://api.github.com/users/LedgerHQ/following{/other_user}","gists_url":"https://api.github.com/users/LedgerHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LedgerHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LedgerHQ/subscriptions","organizations_url":"https://api.github.com/users/LedgerHQ/orgs","repos_url":"https://api.github.com/users/LedgerHQ/repos","events_url":"https://api.github.com/users/LedgerHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LedgerHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":47921590,"node_id":"MDEwOlJlcG9zaXRvcnk0NzkyMTU5MA==","name":"ledger-u2f-javacard","full_name":"LedgerHQ/ledger-u2f-javacard","owner":{"login":"LedgerHQ","id":9784193,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3ODQxOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9784193?v=4","gravatar_id":"","url":"https://api.github.com/users/LedgerHQ","html_url":"https://github.com/LedgerHQ","followers_url":"https://api.github.com/users/LedgerHQ/followers","following_url":"https://api.github.com/users/LedgerHQ/following{/other_user}","gists_url":"https://api.github.com/users/LedgerHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LedgerHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LedgerHQ/subscriptions","organizations_url":"https://api.github.com/users/LedgerHQ/orgs","repos_url":"https://api.github.com/users/LedgerHQ/repos","events_url":"https://api.github.com/users/LedgerHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LedgerHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LedgerHQ/ledger-u2f-javacard","description":"Java Card FIDO U2F authenticator for Ledger Unplugged","fork":false,"url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard","forks_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/forks","keys_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/teams","hooks_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/hooks","issue_events_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/issues/events{/number}","events_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/events","assignees_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/assignees{/user}","branches_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/branches{/branch}","tags_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/tags","blobs_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/git/refs{/sha}","trees_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/statuses/{sha}","languages_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/languages","stargazers_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/stargazers","contributors_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/contributors","subscribers_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/subscribers","subscription_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/subscription","commits_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/commits{/sha}","git_commits_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/git/commits{/sha}","comments_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/comments{/number}","issue_comment_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/issues/comments{/number}","contents_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/contents/{+path}","compare_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/merges","archive_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/downloads","issues_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/issues{/number}","pulls_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/pulls{/number}","milestones_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/milestones{/number}","notifications_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/labels{/name}","releases_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/releases{/id}","deployments_url":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/deployments","created_at":"2015-12-13T14:06:30Z","updated_at":"2018-05-10T09:39:41Z","pushed_at":"2018-06-11T23:36:23Z","git_url":"git://github.com/LedgerHQ/ledger-u2f-javacard.git","ssh_url":"git@github.com:LedgerHQ/ledger-u2f-javacard.git","clone_url":"https://github.com/LedgerHQ/ledger-u2f-javacard.git","svn_url":"https://github.com/LedgerHQ/ledger-u2f-javacard","homepage":null,"size":89,"stargazers_count":34,"watchers_count":34,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":18,"open_issues":5,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/pulls/5"},"html":{"href":"https://github.com/LedgerHQ/ledger-u2f-javacard/pull/5"},"issue":{"href":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/issues/5"},"comments":{"href":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/LedgerHQ/ledger-u2f-javacard/statuses/6fd54f51ed1db4b46bcb65c01792f2aa6b146029"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"btchip","id":3147216,"node_id":"MDQ6VXNlcjMxNDcyMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3147216?v=4","gravatar_id":"","url":"https://api.github.com/users/btchip","html_url":"https://github.com/btchip","followers_url":"https://api.github.com/users/btchip/followers","following_url":"https://api.github.com/users/btchip/following{/other_user}","gists_url":"https://api.github.com/users/btchip/gists{/gist_id}","starred_url":"https://api.github.com/users/btchip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btchip/subscriptions","organizations_url":"https://api.github.com/users/btchip/orgs","repos_url":"https://api.github.com/users/btchip/repos","events_url":"https://api.github.com/users/btchip/events{/privacy}","received_events_url":"https://api.github.com/users/btchip/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":19,"deletions":19,"changed_files":2}}
{"actor":{"display_login":"btchip"}}