{"action":"closed","number":200,"pull_request":{"url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/pulls/200","id":198757047,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NzU3MDQ3","html_url":"https://github.com/OpenWaterAnalytics/EPANET/pull/200","diff_url":"https://github.com/OpenWaterAnalytics/EPANET/pull/200.diff","patch_url":"https://github.com/OpenWaterAnalytics/EPANET/pull/200.patch","issue_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/200","number":200,"state":"closed","locked":false,"title":"Improved Node Re-Ordering Method (Issue #162)","user":{"login":"LRossman","id":12769926,"node_id":"MDQ6VXNlcjEyNzY5OTI2","avatar_url":"https://avatars2.githubusercontent.com/u/12769926?v=4","gravatar_id":"","url":"https://api.github.com/users/LRossman","html_url":"https://github.com/LRossman","followers_url":"https://api.github.com/users/LRossman/followers","following_url":"https://api.github.com/users/LRossman/following{/other_user}","gists_url":"https://api.github.com/users/LRossman/gists{/gist_id}","starred_url":"https://api.github.com/users/LRossman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LRossman/subscriptions","organizations_url":"https://api.github.com/users/LRossman/orgs","repos_url":"https://api.github.com/users/LRossman/repos","events_url":"https://api.github.com/users/LRossman/events{/privacy}","received_events_url":"https://api.github.com/users/LRossman/received_events","type":"User","site_admin":false},"body":"The original Minimum Degree (MD) node re-ordering method used when solving the linearized set of hydraulic equations was replaced with the more powerful Multiple Minimum Degree (MMD) method. This resulted in reducing steady state hydraulic solution times by an average of more than 50% for eight test networks as seen in the following table:\r\n\r\nNetwork | # Junctions | MMD/MD Time\r\n-------- | ------------ | -------------- |\r\n1           |   7,699        |  0.736\r\n2           |   8,566        | 0.396 \r\n3           |  14,991       | 0.311\r\n4           |  27,006       | 0.486\r\n5           |  28,899       | 0.618\r\n6           |  33,247       | 0.278\r\n7           |  42,664       | 0.400\r\n8           |  100,235     | 0.154\r\n\r\nThe timings used for MMD and MD were processor times monitored between `createsparse()` and `freesparse()` in SMATRIX.C using the C` clock()` function.\r\n\r\nManual regression testing against 21 of the EPANET benchmark networks did show some flow differences in 7 networks. These tended to be no larger than 0.001 flow units, with the first 5 to 6 digits matching in most all cases. It should be noted that because of the approximate nature of floating point arithmetic, simply running EPANET 2.00.12 on the same network with the junctions listed in a different order will produce slightly different flow results than for the original network, with differences of the same order as found here for the MMD-to-MD comparison tests.\r\n","created_at":"2018-07-02T18:32:01Z","updated_at":"2018-07-16T21:24:29Z","closed_at":"2018-07-16T21:24:29Z","merged_at":"2018-07-16T21:24:29Z","merge_commit_sha":"4a0e1a06a97d23a69de6737d52070fc7dea6a485","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":254818273,"node_id":"MDU6TGFiZWwyNTQ4MTgyNzM=","url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/labels/Request%20For%20Input","name":"Request For Input","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/pulls/200/commits","review_comments_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/pulls/200/comments","review_comment_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/200/comments","statuses_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/statuses/e6e794258505099e305cb226a0259526f9dafb2e","head":{"label":"LRossman:contributor-lr","ref":"contributor-lr","sha":"e6e794258505099e305cb226a0259526f9dafb2e","user":{"login":"LRossman","id":12769926,"node_id":"MDQ6VXNlcjEyNzY5OTI2","avatar_url":"https://avatars2.githubusercontent.com/u/12769926?v=4","gravatar_id":"","url":"https://api.github.com/users/LRossman","html_url":"https://github.com/LRossman","followers_url":"https://api.github.com/users/LRossman/followers","following_url":"https://api.github.com/users/LRossman/following{/other_user}","gists_url":"https://api.github.com/users/LRossman/gists{/gist_id}","starred_url":"https://api.github.com/users/LRossman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LRossman/subscriptions","organizations_url":"https://api.github.com/users/LRossman/orgs","repos_url":"https://api.github.com/users/LRossman/repos","events_url":"https://api.github.com/users/LRossman/events{/privacy}","received_events_url":"https://api.github.com/users/LRossman/received_events","type":"User","site_admin":false},"repo":{"id":134431535,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0MzE1MzU=","name":"EPANET","full_name":"LRossman/EPANET","owner":{"login":"LRossman","id":12769926,"node_id":"MDQ6VXNlcjEyNzY5OTI2","avatar_url":"https://avatars2.githubusercontent.com/u/12769926?v=4","gravatar_id":"","url":"https://api.github.com/users/LRossman","html_url":"https://github.com/LRossman","followers_url":"https://api.github.com/users/LRossman/followers","following_url":"https://api.github.com/users/LRossman/following{/other_user}","gists_url":"https://api.github.com/users/LRossman/gists{/gist_id}","starred_url":"https://api.github.com/users/LRossman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LRossman/subscriptions","organizations_url":"https://api.github.com/users/LRossman/orgs","repos_url":"https://api.github.com/users/LRossman/repos","events_url":"https://api.github.com/users/LRossman/events{/privacy}","received_events_url":"https://api.github.com/users/LRossman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LRossman/EPANET","description":"The Water Distribution System Hydraulic and Water Quality Analysis Toolkit","fork":true,"url":"https://api.github.com/repos/LRossman/EPANET","forks_url":"https://api.github.com/repos/LRossman/EPANET/forks","keys_url":"https://api.github.com/repos/LRossman/EPANET/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LRossman/EPANET/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LRossman/EPANET/teams","hooks_url":"https://api.github.com/repos/LRossman/EPANET/hooks","issue_events_url":"https://api.github.com/repos/LRossman/EPANET/issues/events{/number}","events_url":"https://api.github.com/repos/LRossman/EPANET/events","assignees_url":"https://api.github.com/repos/LRossman/EPANET/assignees{/user}","branches_url":"https://api.github.com/repos/LRossman/EPANET/branches{/branch}","tags_url":"https://api.github.com/repos/LRossman/EPANET/tags","blobs_url":"https://api.github.com/repos/LRossman/EPANET/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LRossman/EPANET/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LRossman/EPANET/git/refs{/sha}","trees_url":"https://api.github.com/repos/LRossman/EPANET/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LRossman/EPANET/statuses/{sha}","languages_url":"https://api.github.com/repos/LRossman/EPANET/languages","stargazers_url":"https://api.github.com/repos/LRossman/EPANET/stargazers","contributors_url":"https://api.github.com/repos/LRossman/EPANET/contributors","subscribers_url":"https://api.github.com/repos/LRossman/EPANET/subscribers","subscription_url":"https://api.github.com/repos/LRossman/EPANET/subscription","commits_url":"https://api.github.com/repos/LRossman/EPANET/commits{/sha}","git_commits_url":"https://api.github.com/repos/LRossman/EPANET/git/commits{/sha}","comments_url":"https://api.github.com/repos/LRossman/EPANET/comments{/number}","issue_comment_url":"https://api.github.com/repos/LRossman/EPANET/issues/comments{/number}","contents_url":"https://api.github.com/repos/LRossman/EPANET/contents/{+path}","compare_url":"https://api.github.com/repos/LRossman/EPANET/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LRossman/EPANET/merges","archive_url":"https://api.github.com/repos/LRossman/EPANET/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LRossman/EPANET/downloads","issues_url":"https://api.github.com/repos/LRossman/EPANET/issues{/number}","pulls_url":"https://api.github.com/repos/LRossman/EPANET/pulls{/number}","milestones_url":"https://api.github.com/repos/LRossman/EPANET/milestones{/number}","notifications_url":"https://api.github.com/repos/LRossman/EPANET/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LRossman/EPANET/labels{/name}","releases_url":"https://api.github.com/repos/LRossman/EPANET/releases{/id}","deployments_url":"https://api.github.com/repos/LRossman/EPANET/deployments","created_at":"2018-05-22T14:56:03Z","updated_at":"2018-05-22T14:56:05Z","pushed_at":"2018-07-16T21:18:35Z","git_url":"git://github.com/LRossman/EPANET.git","ssh_url":"git@github.com:LRossman/EPANET.git","clone_url":"https://github.com/LRossman/EPANET.git","svn_url":"https://github.com/LRossman/EPANET","homepage":"","size":8464,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OpenWaterAnalytics:dev","ref":"dev","sha":"e1456718a4234fc677e0438ff8e3f23d8e112446","user":{"login":"OpenWaterAnalytics","id":2392819,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzOTI4MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2392819?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenWaterAnalytics","html_url":"https://github.com/OpenWaterAnalytics","followers_url":"https://api.github.com/users/OpenWaterAnalytics/followers","following_url":"https://api.github.com/users/OpenWaterAnalytics/following{/other_user}","gists_url":"https://api.github.com/users/OpenWaterAnalytics/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenWaterAnalytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenWaterAnalytics/subscriptions","organizations_url":"https://api.github.com/users/OpenWaterAnalytics/orgs","repos_url":"https://api.github.com/users/OpenWaterAnalytics/repos","events_url":"https://api.github.com/users/OpenWaterAnalytics/events{/privacy}","received_events_url":"https://api.github.com/users/OpenWaterAnalytics/received_events","type":"Organization","site_admin":false},"repo":{"id":24166957,"node_id":"MDEwOlJlcG9zaXRvcnkyNDE2Njk1Nw==","name":"EPANET","full_name":"OpenWaterAnalytics/EPANET","owner":{"login":"OpenWaterAnalytics","id":2392819,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzOTI4MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2392819?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenWaterAnalytics","html_url":"https://github.com/OpenWaterAnalytics","followers_url":"https://api.github.com/users/OpenWaterAnalytics/followers","following_url":"https://api.github.com/users/OpenWaterAnalytics/following{/other_user}","gists_url":"https://api.github.com/users/OpenWaterAnalytics/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenWaterAnalytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenWaterAnalytics/subscriptions","organizations_url":"https://api.github.com/users/OpenWaterAnalytics/orgs","repos_url":"https://api.github.com/users/OpenWaterAnalytics/repos","events_url":"https://api.github.com/users/OpenWaterAnalytics/events{/privacy}","received_events_url":"https://api.github.com/users/OpenWaterAnalytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenWaterAnalytics/EPANET","description":"The Water Distribution System Hydraulic and Water Quality Analysis Toolkit","fork":true,"url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET","forks_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/forks","keys_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/teams","hooks_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/hooks","issue_events_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/events{/number}","events_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/events","assignees_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/assignees{/user}","branches_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/branches{/branch}","tags_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/tags","blobs_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/languages","stargazers_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/stargazers","contributors_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/contributors","subscribers_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/subscribers","subscription_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/subscription","commits_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/contents/{+path}","compare_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/merges","archive_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/downloads","issues_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues{/number}","pulls_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/labels{/name}","releases_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/releases{/id}","deployments_url":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/deployments","created_at":"2014-09-18T00:04:36Z","updated_at":"2018-07-16T14:06:49Z","pushed_at":"2018-07-16T21:24:29Z","git_url":"git://github.com/OpenWaterAnalytics/EPANET.git","ssh_url":"git@github.com:OpenWaterAnalytics/EPANET.git","clone_url":"https://github.com/OpenWaterAnalytics/EPANET.git","svn_url":"https://github.com/OpenWaterAnalytics/EPANET","homepage":"","size":8491,"stargazers_count":49,"watchers_count":49,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":62,"open_issues":81,"watchers":49,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/pulls/200"},"html":{"href":"https://github.com/OpenWaterAnalytics/EPANET/pull/200"},"issue":{"href":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/200"},"comments":{"href":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/OpenWaterAnalytics/EPANET/statuses/e6e794258505099e305cb226a0259526f9dafb2e"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"michaeltryby","id":6942309,"node_id":"MDQ6VXNlcjY5NDIzMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6942309?v=4","gravatar_id":"","url":"https://api.github.com/users/michaeltryby","html_url":"https://github.com/michaeltryby","followers_url":"https://api.github.com/users/michaeltryby/followers","following_url":"https://api.github.com/users/michaeltryby/following{/other_user}","gists_url":"https://api.github.com/users/michaeltryby/gists{/gist_id}","starred_url":"https://api.github.com/users/michaeltryby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaeltryby/subscriptions","organizations_url":"https://api.github.com/users/michaeltryby/orgs","repos_url":"https://api.github.com/users/michaeltryby/repos","events_url":"https://api.github.com/users/michaeltryby/events{/privacy}","received_events_url":"https://api.github.com/users/michaeltryby/received_events","type":"User","site_admin":false},"comments":13,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":1487,"deletions":390,"changed_files":10}}
{"actor":{"display_login":"michaeltryby"}}