{"action":"created","issue":{"url":"https://api.github.com/repos/toastmasters-dev/quip-toastmasters/issues/10","repository_url":"https://api.github.com/repos/toastmasters-dev/quip-toastmasters","labels_url":"https://api.github.com/repos/toastmasters-dev/quip-toastmasters/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/toastmasters-dev/quip-toastmasters/issues/10/comments","events_url":"https://api.github.com/repos/toastmasters-dev/quip-toastmasters/issues/10/events","html_url":"https://github.com/toastmasters-dev/quip-toastmasters/pull/10","id":368943560,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTk5NjM4","number":10,"title":"Major style overhaul","user":{"login":"mxxk","id":2456381,"node_id":"MDQ6VXNlcjI0NTYzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/2456381?v=4","gravatar_id":"","url":"https://api.github.com/users/mxxk","html_url":"https://github.com/mxxk","followers_url":"https://api.github.com/users/mxxk/followers","following_url":"https://api.github.com/users/mxxk/following{/other_user}","gists_url":"https://api.github.com/users/mxxk/gists{/gist_id}","starred_url":"https://api.github.com/users/mxxk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxxk/subscriptions","organizations_url":"https://api.github.com/users/mxxk/orgs","repos_url":"https://api.github.com/users/mxxk/repos","events_url":"https://api.github.com/users/mxxk/events{/privacy}","received_events_url":"https://api.github.com/users/mxxk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-11T03:59:44Z","updated_at":"2018-10-11T20:15:31Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/toastmasters-dev/quip-toastmasters/pulls/10","html_url":"https://github.com/toastmasters-dev/quip-toastmasters/pull/10","diff_url":"https://github.com/toastmasters-dev/quip-toastmasters/pull/10.diff","patch_url":"https://github.com/toastmasters-dev/quip-toastmasters/pull/10.patch"},"body":"# More fixes\r\n\r\n- Improve experience on small-width screens (i.e. mobile)\r\n    - Use `\"sizing_mode\": \"fill_container\"` in manifest.json to make app responsive to narrow widths\r\n    - Remove `width: 100%` and `white-space: nowrap` from table\r\n- Adjust keys with spaces in agenda schema version 1.0\r\n- Do not use attribute in `<ul title={...}>` to keep track of speech number\r\n    - Make `PickList` completely unaware of speech number\r\n    - Use `bind` in root.jsx to plumb speech number through to `setSpeech` callback\r\n- Remove \"number\" key from speech slot record\r\n    - Since speech slot is an ordered list record, use list item index for more efficient lookup\r\n- Use functional style to assign data and officers values, rather than performing an imperative modification on the very next line\r\n- Alphabetize CSS properties\r\n\r\n## Mobile Experience\r\n\r\n![image](https://user-images.githubusercontent.com/2456381/46831058-27e57c80-cd57-11e8-9698-48b8d8447297.png)\r\n\r\n# Major style overhaul\r\n\r\n- Introduce CSS files\r\n- Do not uppercase speech project upon selection\r\n- Move `cursor: pointer` style in picklist from `<li>`'s to `<span>` children, to not show hand cursor when hovering over list item bullet\r\n- Use Facebook-style `( ... )` to surround blocks of JSX\r\n- Fix inconsistent use of spaces around property JSX properties a la `{ prop }` by favoring their removal\r\n- Strip trailing spaces\r\n- Remove unnecessary parentheses surrounding single argument of arrow functions: `(arg) => ...` => `arg => ...`\r\n- Prevent display of empty `<ul>` by attaching conditional `display: none` style to it\r\n- Become good friends with `display: flex` as a way of controlling ever-expanding-width of `<quip.apps.ui.RichTextBox>`\r\n\r\n## Before\r\n\r\n![image](https://user-images.githubusercontent.com/2456381/46779495-f3c57980-cccc-11e8-8e66-c077e44e1936.png)\r\n\r\n## After\r\n\r\n![image](https://user-images.githubusercontent.com/2456381/46779499-f9bb5a80-cccc-11e8-9ddf-49e6ca7ff5ad.png)"},"comment":{"url":"https://api.github.com/repos/toastmasters-dev/quip-toastmasters/issues/comments/429102589","html_url":"https://github.com/toastmasters-dev/quip-toastmasters/pull/10#issuecomment-429102589","issue_url":"https://api.github.com/repos/toastmasters-dev/quip-toastmasters/issues/10","id":429102589,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTEwMjU4OQ==","user":{"login":"mxxk","id":2456381,"node_id":"MDQ6VXNlcjI0NTYzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/2456381?v=4","gravatar_id":"","url":"https://api.github.com/users/mxxk","html_url":"https://github.com/mxxk","followers_url":"https://api.github.com/users/mxxk/followers","following_url":"https://api.github.com/users/mxxk/following{/other_user}","gists_url":"https://api.github.com/users/mxxk/gists{/gist_id}","starred_url":"https://api.github.com/users/mxxk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxxk/subscriptions","organizations_url":"https://api.github.com/users/mxxk/orgs","repos_url":"https://api.github.com/users/mxxk/repos","events_url":"https://api.github.com/users/mxxk/events{/privacy}","received_events_url":"https://api.github.com/users/mxxk/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T20:15:31Z","updated_at":"2018-10-11T20:15:31Z","author_association":"CONTRIBUTOR","body":"@annyhe good point about mobile. See screenshot included in latest update to PR description 😄 "}}
{"actor":{"display_login":"mxxk"}}