{"action":"created","issue":{"url":"https://api.github.com/repos/orbingol/NURBS-Python/issues/33","repository_url":"https://api.github.com/repos/orbingol/NURBS-Python","labels_url":"https://api.github.com/repos/orbingol/NURBS-Python/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/orbingol/NURBS-Python/issues/33/comments","events_url":"https://api.github.com/repos/orbingol/NURBS-Python/issues/33/events","html_url":"https://github.com/orbingol/NURBS-Python/pull/33","id":341331205,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNTA0MTIw","number":33,"title":"A3.7 & A3.8 from The Nurbs Book","user":{"login":"Nodli","id":32395687,"node_id":"MDQ6VXNlcjMyMzk1Njg3","avatar_url":"https://avatars2.githubusercontent.com/u/32395687?v=4","gravatar_id":"","url":"https://api.github.com/users/Nodli","html_url":"https://github.com/Nodli","followers_url":"https://api.github.com/users/Nodli/followers","following_url":"https://api.github.com/users/Nodli/following{/other_user}","gists_url":"https://api.github.com/users/Nodli/gists{/gist_id}","starred_url":"https://api.github.com/users/Nodli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nodli/subscriptions","organizations_url":"https://api.github.com/users/Nodli/orgs","repos_url":"https://api.github.com/users/Nodli/repos","events_url":"https://api.github.com/users/Nodli/events{/privacy}","received_events_url":"https://api.github.com/users/Nodli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-15T15:58:30Z","updated_at":"2018-07-15T22:59:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/orbingol/NURBS-Python/pulls/33","html_url":"https://github.com/orbingol/NURBS-Python/pull/33","diff_url":"https://github.com/orbingol/NURBS-Python/pull/33.diff","patch_url":"https://github.com/orbingol/NURBS-Python/pull/33.patch"},"body":"Hi,\r\nI implemented both algorithms in SurfaceEvaluator2. Both deriv_ctrlpts and derivatives_single have tests in test_BSpline_Surface.py. derivatives_single is compared with its equivalent in SurfaceEvaluator1.\r\n\r\nI added tests for deriv_ctrlpts for Curve in test_BSpline_Curve2D.py and test_BSpline_Curve3D.py.\r\n\r\nEverything was tested with pytest for Python 2 and Python 3.\r\nI ran prospector for Python 2 on what I added and left only the warnings related to super() and the number of variables in the functions. I tried the Python 3 version in case there are differences but could not make it work.\r\n\r\nI have two suggestions related to these functions :\r\n- I think default values for r1, r2, s1, s2 in deriv_ctrlpts should be the number of control points so that all control points of the derivated curve / surface are returned when the function is called without these arguments\r\n- I would like to include a method in Surface and Curve to return the output of deriv_ctrlpts\r\n\r\nLet me know your thoughts on these, I can implement them if you agree."},"comment":{"url":"https://api.github.com/repos/orbingol/NURBS-Python/issues/comments/405124783","html_url":"https://github.com/orbingol/NURBS-Python/pull/33#issuecomment-405124783","issue_url":"https://api.github.com/repos/orbingol/NURBS-Python/issues/33","id":405124783,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTEyNDc4Mw==","user":{"login":"orbingol","id":5276943,"node_id":"MDQ6VXNlcjUyNzY5NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/5276943?v=4","gravatar_id":"","url":"https://api.github.com/users/orbingol","html_url":"https://github.com/orbingol","followers_url":"https://api.github.com/users/orbingol/followers","following_url":"https://api.github.com/users/orbingol/following{/other_user}","gists_url":"https://api.github.com/users/orbingol/gists{/gist_id}","starred_url":"https://api.github.com/users/orbingol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbingol/subscriptions","organizations_url":"https://api.github.com/users/orbingol/orgs","repos_url":"https://api.github.com/users/orbingol/repos","events_url":"https://api.github.com/users/orbingol/events{/privacy}","received_events_url":"https://api.github.com/users/orbingol/received_events","type":"User","site_admin":false},"created_at":"2018-07-15T22:59:55Z","updated_at":"2018-07-15T22:59:55Z","author_association":"OWNER","body":"By the way, I forgot to say thanks in my previous message @Nodl. This is an awesome job, I appreciate your time and efforts. Please let me know about your decision on adding `derivatives_ctrlpts`."}}
{"actor":{"display_login":"orbingol"}}