{"action":"created","comment":{"url":"https://api.github.com/repos/reactos/reactos/pulls/comments/192256155","pull_request_review_id":124998694,"id":192256155,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjI1NjE1NQ==","diff_hunk":"@@ -0,0 +1,14 @@\n+# Rules for managing Pull Requests\n+\n+For the sake of trying to maintain an acceptable number of open but idle PRs, the following rules should be considered:\n+- If a PR has at least one approval, it can be merged after 1 week of waiting for additional comments.\n+  - If you consider the change trivial enough or it has at least 3 approvals, it may also be merged right away.\n+- If a PR stays in \"changes requested\" for 2 weeks, and that change has not been done in the meantime, it shall be closed.\n+- If you require a review from a particular person, assign the PR to that person. Don't just rely on the \"review requested\" feature of GitHub.\n+- Don't feel obliged to comment everything you see, just for the sake of commenting. Be it on JIRA, GitHub, or even on IRC.\n+\n+In addition, in order to avoid coming out as rude to helpful contributors, please refrain from","path":"PULL_REQUEST_MANAGEMENT.md","position":10,"original_position":10,"commit_id":"7fb1421114a40ed255ce3f5a3821504197817548","original_commit_id":"7fb1421114a40ed255ce3f5a3821504197817548","user":{"login":"gigaherz","id":685851,"node_id":"MDQ6VXNlcjY4NTg1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/685851?v=4","gravatar_id":"","url":"https://api.github.com/users/gigaherz","html_url":"https://github.com/gigaherz","followers_url":"https://api.github.com/users/gigaherz/followers","following_url":"https://api.github.com/users/gigaherz/following{/other_user}","gists_url":"https://api.github.com/users/gigaherz/gists{/gist_id}","starred_url":"https://api.github.com/users/gigaherz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigaherz/subscriptions","organizations_url":"https://api.github.com/users/gigaherz/orgs","repos_url":"https://api.github.com/users/gigaherz/repos","events_url":"https://api.github.com/users/gigaherz/events{/privacy}","received_events_url":"https://api.github.com/users/gigaherz/received_events","type":"User","site_admin":false},"body":"*silently fixes and pretends it didn't happen...*","created_at":"2018-05-31T22:31:37Z","updated_at":"2018-05-31T22:31:37Z","html_url":"https://github.com/reactos/reactos/pull/585#discussion_r192256155","pull_request_url":"https://api.github.com/repos/reactos/reactos/pulls/585","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments/192256155"},"html":{"href":"https://github.com/reactos/reactos/pull/585#discussion_r192256155"},"pull_request":{"href":"https://api.github.com/repos/reactos/reactos/pulls/585"}},"in_reply_to_id":192253510},"pull_request":{"url":"https://api.github.com/repos/reactos/reactos/pulls/585","id":191884999,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODg0OTk5","html_url":"https://github.com/reactos/reactos/pull/585","diff_url":"https://github.com/reactos/reactos/pull/585.diff","patch_url":"https://github.com/reactos/reactos/pull/585.patch","issue_url":"https://api.github.com/repos/reactos/reactos/issues/585","number":585,"state":"open","locked":false,"title":"Add a document on the rules we should follow while managing/reviewing PRs","user":{"login":"gigaherz","id":685851,"node_id":"MDQ6VXNlcjY4NTg1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/685851?v=4","gravatar_id":"","url":"https://api.github.com/users/gigaherz","html_url":"https://github.com/gigaherz","followers_url":"https://api.github.com/users/gigaherz/followers","following_url":"https://api.github.com/users/gigaherz/following{/other_user}","gists_url":"https://api.github.com/users/gigaherz/gists{/gist_id}","starred_url":"https://api.github.com/users/gigaherz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigaherz/subscriptions","organizations_url":"https://api.github.com/users/gigaherz/orgs","repos_url":"https://api.github.com/users/gigaherz/repos","events_url":"https://api.github.com/users/gigaherz/events{/privacy}","received_events_url":"https://api.github.com/users/gigaherz/received_events","type":"User","site_admin":false},"body":"## Purpose\r\n\r\nAs discussed during the meeting, we have a growing list of idle pull requests, that are either accepted but unmerged, or have been waiting for changes for a long time.\r\n\r\nTo try to alleviate that issue, we came up with a set of rules we should try to follow, in order to avoid making it worse.\r\n\r\n## Proposed changes\r\n\r\nThe rules (helpfully gathered by @ColinFinck) have been written into the new document, and this new document has been linked from CONTRIBUTING.md, and CODE_OF_CONDUCT.md\r\n\r\n## Things that need review\r\n\r\nThis goes to all the team members, specially those that commonly review, merge or reject pull requests.\r\n\r\nWe would want your input on:\r\n- Wording\r\n- Location of the links within the files\r\n- The rules themselves\r\n\r\nSpeak now or forever hold your peace.","created_at":"2018-05-31T21:58:10Z","updated_at":"2018-05-31T22:31:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c1d407fa07486947803aa54b456238599657822","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reactos/reactos/pulls/585/commits","review_comments_url":"https://api.github.com/repos/reactos/reactos/pulls/585/comments","review_comment_url":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactos/reactos/issues/585/comments","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/7fb1421114a40ed255ce3f5a3821504197817548","head":{"label":"gigaherz:pr-rules","ref":"pr-rules","sha":"7fb1421114a40ed255ce3f5a3821504197817548","user":{"login":"gigaherz","id":685851,"node_id":"MDQ6VXNlcjY4NTg1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/685851?v=4","gravatar_id":"","url":"https://api.github.com/users/gigaherz","html_url":"https://github.com/gigaherz","followers_url":"https://api.github.com/users/gigaherz/followers","following_url":"https://api.github.com/users/gigaherz/following{/other_user}","gists_url":"https://api.github.com/users/gigaherz/gists{/gist_id}","starred_url":"https://api.github.com/users/gigaherz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigaherz/subscriptions","organizations_url":"https://api.github.com/users/gigaherz/orgs","repos_url":"https://api.github.com/users/gigaherz/repos","events_url":"https://api.github.com/users/gigaherz/events{/privacy}","received_events_url":"https://api.github.com/users/gigaherz/received_events","type":"User","site_admin":false},"repo":{"id":105639573,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU2Mzk1NzM=","name":"reactos","full_name":"gigaherz/reactos","owner":{"login":"gigaherz","id":685851,"node_id":"MDQ6VXNlcjY4NTg1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/685851?v=4","gravatar_id":"","url":"https://api.github.com/users/gigaherz","html_url":"https://github.com/gigaherz","followers_url":"https://api.github.com/users/gigaherz/followers","following_url":"https://api.github.com/users/gigaherz/following{/other_user}","gists_url":"https://api.github.com/users/gigaherz/gists{/gist_id}","starred_url":"https://api.github.com/users/gigaherz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigaherz/subscriptions","organizations_url":"https://api.github.com/users/gigaherz/orgs","repos_url":"https://api.github.com/users/gigaherz/repos","events_url":"https://api.github.com/users/gigaherz/events{/privacy}","received_events_url":"https://api.github.com/users/gigaherz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gigaherz/reactos","description":"A free Windows-compatible Operating System","fork":true,"url":"https://api.github.com/repos/gigaherz/reactos","forks_url":"https://api.github.com/repos/gigaherz/reactos/forks","keys_url":"https://api.github.com/repos/gigaherz/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gigaherz/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gigaherz/reactos/teams","hooks_url":"https://api.github.com/repos/gigaherz/reactos/hooks","issue_events_url":"https://api.github.com/repos/gigaherz/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/gigaherz/reactos/events","assignees_url":"https://api.github.com/repos/gigaherz/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/gigaherz/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/gigaherz/reactos/tags","blobs_url":"https://api.github.com/repos/gigaherz/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gigaherz/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gigaherz/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/gigaherz/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gigaherz/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/gigaherz/reactos/languages","stargazers_url":"https://api.github.com/repos/gigaherz/reactos/stargazers","contributors_url":"https://api.github.com/repos/gigaherz/reactos/contributors","subscribers_url":"https://api.github.com/repos/gigaherz/reactos/subscribers","subscription_url":"https://api.github.com/repos/gigaherz/reactos/subscription","commits_url":"https://api.github.com/repos/gigaherz/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/gigaherz/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/gigaherz/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/gigaherz/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/gigaherz/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/gigaherz/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gigaherz/reactos/merges","archive_url":"https://api.github.com/repos/gigaherz/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gigaherz/reactos/downloads","issues_url":"https://api.github.com/repos/gigaherz/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/gigaherz/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/gigaherz/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/gigaherz/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gigaherz/reactos/labels{/name}","releases_url":"https://api.github.com/repos/gigaherz/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/gigaherz/reactos/deployments","created_at":"2017-10-03T10:32:35Z","updated_at":"2017-10-03T10:33:57Z","pushed_at":"2018-05-31T21:51:02Z","git_url":"git://github.com/gigaherz/reactos.git","ssh_url":"git@github.com:gigaherz/reactos.git","clone_url":"https://github.com/gigaherz/reactos.git","svn_url":"https://github.com/gigaherz/reactos","homepage":null,"size":375001,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactos:master","ref":"master","sha":"ce5d4fd3e14047402955e14fe002f4cc37c64e12","user":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"repo":{"id":105627846,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU2Mjc4NDY=","name":"reactos","full_name":"reactos/reactos","owner":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reactos/reactos","description":"A free Windows-compatible Operating System","fork":false,"url":"https://api.github.com/repos/reactos/reactos","forks_url":"https://api.github.com/repos/reactos/reactos/forks","keys_url":"https://api.github.com/repos/reactos/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactos/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactos/reactos/teams","hooks_url":"https://api.github.com/repos/reactos/reactos/hooks","issue_events_url":"https://api.github.com/repos/reactos/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/reactos/reactos/events","assignees_url":"https://api.github.com/repos/reactos/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/reactos/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/reactos/reactos/tags","blobs_url":"https://api.github.com/repos/reactos/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactos/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactos/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactos/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/reactos/reactos/languages","stargazers_url":"https://api.github.com/repos/reactos/reactos/stargazers","contributors_url":"https://api.github.com/repos/reactos/reactos/contributors","subscribers_url":"https://api.github.com/repos/reactos/reactos/subscribers","subscription_url":"https://api.github.com/repos/reactos/reactos/subscription","commits_url":"https://api.github.com/repos/reactos/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactos/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactos/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactos/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactos/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/reactos/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactos/reactos/merges","archive_url":"https://api.github.com/repos/reactos/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactos/reactos/downloads","issues_url":"https://api.github.com/repos/reactos/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/reactos/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/reactos/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/reactos/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactos/reactos/labels{/name}","releases_url":"https://api.github.com/repos/reactos/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/reactos/reactos/deployments","created_at":"2017-10-03T08:04:52Z","updated_at":"2018-05-31T21:26:49Z","pushed_at":"2018-05-31T21:58:11Z","git_url":"git://github.com/reactos/reactos.git","ssh_url":"git@github.com:reactos/reactos.git","clone_url":"https://github.com/reactos/reactos.git","svn_url":"https://github.com/reactos/reactos","homepage":null,"size":456306,"stargazers_count":4303,"watchers_count":4303,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":324,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":324,"open_issues":80,"watchers":4303,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/585"},"html":{"href":"https://github.com/reactos/reactos/pull/585"},"issue":{"href":"https://api.github.com/repos/reactos/reactos/issues/585"},"comments":{"href":"https://api.github.com/repos/reactos/reactos/issues/585/comments"},"review_comments":{"href":"https://api.github.com/repos/reactos/reactos/pulls/585/comments"},"review_comment":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactos/reactos/pulls/585/commits"},"statuses":{"href":"https://api.github.com/repos/reactos/reactos/statuses/7fb1421114a40ed255ce3f5a3821504197817548"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gigaherz"}}