{"action":"opened","number":891,"pull_request":{"url":"https://api.github.com/repos/ni/nimi-python/pulls/891","id":192852229,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyODUyMjI5","html_url":"https://github.com/ni/nimi-python/pull/891","diff_url":"https://github.com/ni/nimi-python/pull/891.diff","patch_url":"https://github.com/ni/nimi-python/pull/891.patch","issue_url":"https://api.github.com/repos/ni/nimi-python/issues/891","number":891,"state":"open","locked":false,"title":"Bug596/get fir filter coefficients","user":{"login":"texasaggie97","id":11483903,"node_id":"MDQ6VXNlcjExNDgzOTAz","avatar_url":"https://avatars1.githubusercontent.com/u/11483903?v=4","gravatar_id":"","url":"https://api.github.com/users/texasaggie97","html_url":"https://github.com/texasaggie97","followers_url":"https://api.github.com/users/texasaggie97/followers","following_url":"https://api.github.com/users/texasaggie97/following{/other_user}","gists_url":"https://api.github.com/users/texasaggie97/gists{/gist_id}","starred_url":"https://api.github.com/users/texasaggie97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/texasaggie97/subscriptions","organizations_url":"https://api.github.com/users/texasaggie97/orgs","repos_url":"https://api.github.com/users/texasaggie97/repos","events_url":"https://api.github.com/users/texasaggie97/events{/privacy}","received_events_url":"https://api.github.com/users/texasaggie97/received_events","type":"User","site_admin":false},"body":"- [X] This contribution adheres to [CONTRIBUTING.md](https://github.com/ni/nimi-python/blob/master/CONTRIBUTING.md).\r\n- [X] I've updated [CHANGELOG.md](https://github.com/ni/nimi-python/blob/master/CHANGELOG.md) if applicable.\r\n- [X] I've added tests applicable for this pull request\r\n### What does this Pull Request accomplish?\r\n* Fixed nifgen `get_fir_filter_coefficients()`\r\n  * Create specific implementation instead of relying on code generator\r\n    * Not really ivi-dance because the size is returned in an out parameter instead of the return value (error)\r\n    * Not worth trying to make the code generator support this use case for this one function\r\n  * Don't use code generator for documentation\r\n### List issues fixed by this Pull Request below, if any.\r\n* Fix #535 \r\n* Fix #596 \r\n* We no longer care about #534 \r\n\r\n### What testing has been done?\r\n* Unit\r\n* System\r\n* Visual inspection of generated files","created_at":"2018-06-05T22:19:43Z","updated_at":"2018-06-05T22:19:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ni/nimi-python/pulls/891/commits","review_comments_url":"https://api.github.com/repos/ni/nimi-python/pulls/891/comments","review_comment_url":"https://api.github.com/repos/ni/nimi-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ni/nimi-python/issues/891/comments","statuses_url":"https://api.github.com/repos/ni/nimi-python/statuses/3aa70eacad6a242ec6fa00b21288474e574731f6","head":{"label":"ni:bug596/get_fir_filter_coefficients","ref":"bug596/get_fir_filter_coefficients","sha":"3aa70eacad6a242ec6fa00b21288474e574731f6","user":{"login":"ni","id":5598284,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1OTgyODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5598284?v=4","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"repo":{"id":91020334,"node_id":"MDEwOlJlcG9zaXRvcnk5MTAyMDMzNA==","name":"nimi-python","full_name":"ni/nimi-python","owner":{"login":"ni","id":5598284,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1OTgyODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5598284?v=4","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ni/nimi-python","description":"Python bindings for NI Modular Instrument drivers.","fork":false,"url":"https://api.github.com/repos/ni/nimi-python","forks_url":"https://api.github.com/repos/ni/nimi-python/forks","keys_url":"https://api.github.com/repos/ni/nimi-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ni/nimi-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ni/nimi-python/teams","hooks_url":"https://api.github.com/repos/ni/nimi-python/hooks","issue_events_url":"https://api.github.com/repos/ni/nimi-python/issues/events{/number}","events_url":"https://api.github.com/repos/ni/nimi-python/events","assignees_url":"https://api.github.com/repos/ni/nimi-python/assignees{/user}","branches_url":"https://api.github.com/repos/ni/nimi-python/branches{/branch}","tags_url":"https://api.github.com/repos/ni/nimi-python/tags","blobs_url":"https://api.github.com/repos/ni/nimi-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ni/nimi-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ni/nimi-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/ni/nimi-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ni/nimi-python/statuses/{sha}","languages_url":"https://api.github.com/repos/ni/nimi-python/languages","stargazers_url":"https://api.github.com/repos/ni/nimi-python/stargazers","contributors_url":"https://api.github.com/repos/ni/nimi-python/contributors","subscribers_url":"https://api.github.com/repos/ni/nimi-python/subscribers","subscription_url":"https://api.github.com/repos/ni/nimi-python/subscription","commits_url":"https://api.github.com/repos/ni/nimi-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/ni/nimi-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/ni/nimi-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/ni/nimi-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/ni/nimi-python/contents/{+path}","compare_url":"https://api.github.com/repos/ni/nimi-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ni/nimi-python/merges","archive_url":"https://api.github.com/repos/ni/nimi-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ni/nimi-python/downloads","issues_url":"https://api.github.com/repos/ni/nimi-python/issues{/number}","pulls_url":"https://api.github.com/repos/ni/nimi-python/pulls{/number}","milestones_url":"https://api.github.com/repos/ni/nimi-python/milestones{/number}","notifications_url":"https://api.github.com/repos/ni/nimi-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ni/nimi-python/labels{/name}","releases_url":"https://api.github.com/repos/ni/nimi-python/releases{/id}","deployments_url":"https://api.github.com/repos/ni/nimi-python/deployments","created_at":"2017-05-11T20:24:33Z","updated_at":"2018-06-04T21:58:51Z","pushed_at":"2018-06-05T22:19:41Z","git_url":"git://github.com/ni/nimi-python.git","ssh_url":"git@github.com:ni/nimi-python.git","clone_url":"https://github.com/ni/nimi-python.git","svn_url":"https://github.com/ni/nimi-python","homepage":"","size":7114,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":47,"watchers":22,"default_branch":"master"}},"base":{"label":"ni:master","ref":"master","sha":"24567821af51486d873f2a7fe5daa8a9831d94f6","user":{"login":"ni","id":5598284,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1OTgyODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5598284?v=4","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"repo":{"id":91020334,"node_id":"MDEwOlJlcG9zaXRvcnk5MTAyMDMzNA==","name":"nimi-python","full_name":"ni/nimi-python","owner":{"login":"ni","id":5598284,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1OTgyODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5598284?v=4","gravatar_id":"","url":"https://api.github.com/users/ni","html_url":"https://github.com/ni","followers_url":"https://api.github.com/users/ni/followers","following_url":"https://api.github.com/users/ni/following{/other_user}","gists_url":"https://api.github.com/users/ni/gists{/gist_id}","starred_url":"https://api.github.com/users/ni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ni/subscriptions","organizations_url":"https://api.github.com/users/ni/orgs","repos_url":"https://api.github.com/users/ni/repos","events_url":"https://api.github.com/users/ni/events{/privacy}","received_events_url":"https://api.github.com/users/ni/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ni/nimi-python","description":"Python bindings for NI Modular Instrument drivers.","fork":false,"url":"https://api.github.com/repos/ni/nimi-python","forks_url":"https://api.github.com/repos/ni/nimi-python/forks","keys_url":"https://api.github.com/repos/ni/nimi-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ni/nimi-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ni/nimi-python/teams","hooks_url":"https://api.github.com/repos/ni/nimi-python/hooks","issue_events_url":"https://api.github.com/repos/ni/nimi-python/issues/events{/number}","events_url":"https://api.github.com/repos/ni/nimi-python/events","assignees_url":"https://api.github.com/repos/ni/nimi-python/assignees{/user}","branches_url":"https://api.github.com/repos/ni/nimi-python/branches{/branch}","tags_url":"https://api.github.com/repos/ni/nimi-python/tags","blobs_url":"https://api.github.com/repos/ni/nimi-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ni/nimi-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ni/nimi-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/ni/nimi-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ni/nimi-python/statuses/{sha}","languages_url":"https://api.github.com/repos/ni/nimi-python/languages","stargazers_url":"https://api.github.com/repos/ni/nimi-python/stargazers","contributors_url":"https://api.github.com/repos/ni/nimi-python/contributors","subscribers_url":"https://api.github.com/repos/ni/nimi-python/subscribers","subscription_url":"https://api.github.com/repos/ni/nimi-python/subscription","commits_url":"https://api.github.com/repos/ni/nimi-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/ni/nimi-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/ni/nimi-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/ni/nimi-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/ni/nimi-python/contents/{+path}","compare_url":"https://api.github.com/repos/ni/nimi-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ni/nimi-python/merges","archive_url":"https://api.github.com/repos/ni/nimi-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ni/nimi-python/downloads","issues_url":"https://api.github.com/repos/ni/nimi-python/issues{/number}","pulls_url":"https://api.github.com/repos/ni/nimi-python/pulls{/number}","milestones_url":"https://api.github.com/repos/ni/nimi-python/milestones{/number}","notifications_url":"https://api.github.com/repos/ni/nimi-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ni/nimi-python/labels{/name}","releases_url":"https://api.github.com/repos/ni/nimi-python/releases{/id}","deployments_url":"https://api.github.com/repos/ni/nimi-python/deployments","created_at":"2017-05-11T20:24:33Z","updated_at":"2018-06-04T21:58:51Z","pushed_at":"2018-06-05T22:19:41Z","git_url":"git://github.com/ni/nimi-python.git","ssh_url":"git@github.com:ni/nimi-python.git","clone_url":"https://github.com/ni/nimi-python.git","svn_url":"https://github.com/ni/nimi-python","homepage":"","size":7114,"stargazers_count":22,"watchers_count":22,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":47,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ni/nimi-python/pulls/891"},"html":{"href":"https://github.com/ni/nimi-python/pull/891"},"issue":{"href":"https://api.github.com/repos/ni/nimi-python/issues/891"},"comments":{"href":"https://api.github.com/repos/ni/nimi-python/issues/891/comments"},"review_comments":{"href":"https://api.github.com/repos/ni/nimi-python/pulls/891/comments"},"review_comment":{"href":"https://api.github.com/repos/ni/nimi-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ni/nimi-python/pulls/891/commits"},"statuses":{"href":"https://api.github.com/repos/ni/nimi-python/statuses/3aa70eacad6a242ec6fa00b21288474e574731f6"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":2664,"deletions":2609,"changed_files":8}}
{"actor":{"display_login":"texasaggie97"}}