{"action":"created","comment":{"url":"https://api.github.com/repos/letgoapp/CameraManager/pulls/comments/173752093","pull_request_review_id":102989710,"id":173752093,"diff_hunk":"@@ -214,6 +214,18 @@ open class CameraManager: NSObject, AVCaptureFileOutputRecordingDelegate, UIGest\n         return AVCaptureDevice.default(for: AVMediaType.audio)\n     }()\n     \n+    // MARK: - Core ML\n+    public var pixelsBuffersToForwardPerSecond = 15\n+    public var videoOutputSettings: [String : Any] =\n+        [kCVPixelBufferPixelFormatTypeKey as String: NSNumber(value: kCVPixelFormatType_32BGRA),\n+         kCVPixelBufferWidthKey as String: NSNumber(value: 224),\n+         kCVPixelBufferHeightKey as String: NSNumber(value: 224)]\n+    fileprivate var videoOutput: AVCaptureVideoDataOutput?\n+    fileprivate let videoOutputQueue = DispatchQueue(label: \"camera.manager.video.output.queue\")\n+    public weak var videoOutputDelegate: VideoCaptureDelegate?\n+    fileprivate var videoOutputLastTimestamp = CMTime()","path":"camera/CameraManager.swift","position":24,"original_position":24,"commit_id":"43b20b497ba2f578e821e8fcb499da9ee1414127","original_commit_id":"43b20b497ba2f578e821e8fcb499da9ee1414127","user":{"login":"SwiftTsubame","id":20661975,"avatar_url":"https://avatars3.githubusercontent.com/u/20661975?v=4","gravatar_id":"","url":"https://api.github.com/users/SwiftTsubame","html_url":"https://github.com/SwiftTsubame","followers_url":"https://api.github.com/users/SwiftTsubame/followers","following_url":"https://api.github.com/users/SwiftTsubame/following{/other_user}","gists_url":"https://api.github.com/users/SwiftTsubame/gists{/gist_id}","starred_url":"https://api.github.com/users/SwiftTsubame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwiftTsubame/subscriptions","organizations_url":"https://api.github.com/users/SwiftTsubame/orgs","repos_url":"https://api.github.com/users/SwiftTsubame/repos","events_url":"https://api.github.com/users/SwiftTsubame/events{/privacy}","received_events_url":"https://api.github.com/users/SwiftTsubame/received_events","type":"User","site_admin":false},"body":"maybe `private` instead of `fileprivate`?","created_at":"2018-03-12T10:38:24Z","updated_at":"2018-03-12T10:42:38Z","html_url":"https://github.com/letgoapp/CameraManager/pull/5#discussion_r173752093","pull_request_url":"https://api.github.com/repos/letgoapp/CameraManager/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/letgoapp/CameraManager/pulls/comments/173752093"},"html":{"href":"https://github.com/letgoapp/CameraManager/pull/5#discussion_r173752093"},"pull_request":{"href":"https://api.github.com/repos/letgoapp/CameraManager/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/letgoapp/CameraManager/pulls/5","id":174323851,"html_url":"https://github.com/letgoapp/CameraManager/pull/5","diff_url":"https://github.com/letgoapp/CameraManager/pull/5.diff","patch_url":"https://github.com/letgoapp/CameraManager/pull/5.patch","issue_url":"https://api.github.com/repos/letgoapp/CameraManager/issues/5","number":5,"state":"open","locked":false,"title":"Machine leaning","user":{"login":"nestorgt","id":4219449,"avatar_url":"https://avatars0.githubusercontent.com/u/4219449?v=4","gravatar_id":"","url":"https://api.github.com/users/nestorgt","html_url":"https://github.com/nestorgt","followers_url":"https://api.github.com/users/nestorgt/followers","following_url":"https://api.github.com/users/nestorgt/following{/other_user}","gists_url":"https://api.github.com/users/nestorgt/gists{/gist_id}","starred_url":"https://api.github.com/users/nestorgt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nestorgt/subscriptions","organizations_url":"https://api.github.com/users/nestorgt/orgs","repos_url":"https://api.github.com/users/nestorgt/repos","events_url":"https://api.github.com/users/nestorgt/events{/privacy}","received_events_url":"https://api.github.com/users/nestorgt/received_events","type":"User","site_admin":false},"body":"Added AVCaptureVideoDataOutput to camera\r\n- setSampleBufferDelegate runs on videoOutputQueue (background)\r\n\r\nAdded delegate VideoCaptureDelegate that will pass pixelBuffers to the assigned delegate\r\n\r\nAdded pixelsBuffersToForwardPerSecond to set the amount of frames per second to pass to the delegate (defaults to 15)\r\n\r\nAdded default videoOutputSettings to match our model requirements (32 bit color, 224x224)\r\n\r\n#### :ghost: GIF\r\n![](https://media3.giphy.com/media/W9zNtyI9I4lG/200w.gif?cid=5a38a5a25aa162095152474455ebd18d)","created_at":"2018-03-12T10:19:48Z","updated_at":"2018-03-12T10:42:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0e3610a4dd958ac60e138cbf2f8d0e6a7032b3f","assignee":{"login":"SwiftTsubame","id":20661975,"avatar_url":"https://avatars3.githubusercontent.com/u/20661975?v=4","gravatar_id":"","url":"https://api.github.com/users/SwiftTsubame","html_url":"https://github.com/SwiftTsubame","followers_url":"https://api.github.com/users/SwiftTsubame/followers","following_url":"https://api.github.com/users/SwiftTsubame/following{/other_user}","gists_url":"https://api.github.com/users/SwiftTsubame/gists{/gist_id}","starred_url":"https://api.github.com/users/SwiftTsubame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwiftTsubame/subscriptions","organizations_url":"https://api.github.com/users/SwiftTsubame/orgs","repos_url":"https://api.github.com/users/SwiftTsubame/repos","events_url":"https://api.github.com/users/SwiftTsubame/events{/privacy}","received_events_url":"https://api.github.com/users/SwiftTsubame/received_events","type":"User","site_admin":false},"assignees":[{"login":"SwiftTsubame","id":20661975,"avatar_url":"https://avatars3.githubusercontent.com/u/20661975?v=4","gravatar_id":"","url":"https://api.github.com/users/SwiftTsubame","html_url":"https://github.com/SwiftTsubame","followers_url":"https://api.github.com/users/SwiftTsubame/followers","following_url":"https://api.github.com/users/SwiftTsubame/following{/other_user}","gists_url":"https://api.github.com/users/SwiftTsubame/gists{/gist_id}","starred_url":"https://api.github.com/users/SwiftTsubame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SwiftTsubame/subscriptions","organizations_url":"https://api.github.com/users/SwiftTsubame/orgs","repos_url":"https://api.github.com/users/SwiftTsubame/repos","events_url":"https://api.github.com/users/SwiftTsubame/events{/privacy}","received_events_url":"https://api.github.com/users/SwiftTsubame/received_events","type":"User","site_admin":false},{"login":"rauldeonate","id":22143598,"avatar_url":"https://avatars1.githubusercontent.com/u/22143598?v=4","gravatar_id":"","url":"https://api.github.com/users/rauldeonate","html_url":"https://github.com/rauldeonate","followers_url":"https://api.github.com/users/rauldeonate/followers","following_url":"https://api.github.com/users/rauldeonate/following{/other_user}","gists_url":"https://api.github.com/users/rauldeonate/gists{/gist_id}","starred_url":"https://api.github.com/users/rauldeonate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rauldeonate/subscriptions","organizations_url":"https://api.github.com/users/rauldeonate/orgs","repos_url":"https://api.github.com/users/rauldeonate/repos","events_url":"https://api.github.com/users/rauldeonate/events{/privacy}","received_events_url":"https://api.github.com/users/rauldeonate/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/letgoapp/CameraManager/pulls/5/commits","review_comments_url":"https://api.github.com/repos/letgoapp/CameraManager/pulls/5/comments","review_comment_url":"https://api.github.com/repos/letgoapp/CameraManager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/letgoapp/CameraManager/issues/5/comments","statuses_url":"https://api.github.com/repos/letgoapp/CameraManager/statuses/43b20b497ba2f578e821e8fcb499da9ee1414127","head":{"label":"letgoapp:machine-leaning","ref":"machine-leaning","sha":"43b20b497ba2f578e821e8fcb499da9ee1414127","user":{"login":"letgoapp","id":15359988,"avatar_url":"https://avatars1.githubusercontent.com/u/15359988?v=4","gravatar_id":"","url":"https://api.github.com/users/letgoapp","html_url":"https://github.com/letgoapp","followers_url":"https://api.github.com/users/letgoapp/followers","following_url":"https://api.github.com/users/letgoapp/following{/other_user}","gists_url":"https://api.github.com/users/letgoapp/gists{/gist_id}","starred_url":"https://api.github.com/users/letgoapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letgoapp/subscriptions","organizations_url":"https://api.github.com/users/letgoapp/orgs","repos_url":"https://api.github.com/users/letgoapp/repos","events_url":"https://api.github.com/users/letgoapp/events{/privacy}","received_events_url":"https://api.github.com/users/letgoapp/received_events","type":"Organization","site_admin":false},"repo":{"id":85590246,"name":"CameraManager","full_name":"letgoapp/CameraManager","owner":{"login":"letgoapp","id":15359988,"avatar_url":"https://avatars1.githubusercontent.com/u/15359988?v=4","gravatar_id":"","url":"https://api.github.com/users/letgoapp","html_url":"https://github.com/letgoapp","followers_url":"https://api.github.com/users/letgoapp/followers","following_url":"https://api.github.com/users/letgoapp/following{/other_user}","gists_url":"https://api.github.com/users/letgoapp/gists{/gist_id}","starred_url":"https://api.github.com/users/letgoapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letgoapp/subscriptions","organizations_url":"https://api.github.com/users/letgoapp/orgs","repos_url":"https://api.github.com/users/letgoapp/repos","events_url":"https://api.github.com/users/letgoapp/events{/privacy}","received_events_url":"https://api.github.com/users/letgoapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letgoapp/CameraManager","description":"Simple Swift class to provide all the configurations you need to create custom camera view in your app","fork":true,"url":"https://api.github.com/repos/letgoapp/CameraManager","forks_url":"https://api.github.com/repos/letgoapp/CameraManager/forks","keys_url":"https://api.github.com/repos/letgoapp/CameraManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letgoapp/CameraManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letgoapp/CameraManager/teams","hooks_url":"https://api.github.com/repos/letgoapp/CameraManager/hooks","issue_events_url":"https://api.github.com/repos/letgoapp/CameraManager/issues/events{/number}","events_url":"https://api.github.com/repos/letgoapp/CameraManager/events","assignees_url":"https://api.github.com/repos/letgoapp/CameraManager/assignees{/user}","branches_url":"https://api.github.com/repos/letgoapp/CameraManager/branches{/branch}","tags_url":"https://api.github.com/repos/letgoapp/CameraManager/tags","blobs_url":"https://api.github.com/repos/letgoapp/CameraManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letgoapp/CameraManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letgoapp/CameraManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/letgoapp/CameraManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letgoapp/CameraManager/statuses/{sha}","languages_url":"https://api.github.com/repos/letgoapp/CameraManager/languages","stargazers_url":"https://api.github.com/repos/letgoapp/CameraManager/stargazers","contributors_url":"https://api.github.com/repos/letgoapp/CameraManager/contributors","subscribers_url":"https://api.github.com/repos/letgoapp/CameraManager/subscribers","subscription_url":"https://api.github.com/repos/letgoapp/CameraManager/subscription","commits_url":"https://api.github.com/repos/letgoapp/CameraManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/letgoapp/CameraManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/letgoapp/CameraManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/letgoapp/CameraManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/letgoapp/CameraManager/contents/{+path}","compare_url":"https://api.github.com/repos/letgoapp/CameraManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letgoapp/CameraManager/merges","archive_url":"https://api.github.com/repos/letgoapp/CameraManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letgoapp/CameraManager/downloads","issues_url":"https://api.github.com/repos/letgoapp/CameraManager/issues{/number}","pulls_url":"https://api.github.com/repos/letgoapp/CameraManager/pulls{/number}","milestones_url":"https://api.github.com/repos/letgoapp/CameraManager/milestones{/number}","notifications_url":"https://api.github.com/repos/letgoapp/CameraManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letgoapp/CameraManager/labels{/name}","releases_url":"https://api.github.com/repos/letgoapp/CameraManager/releases{/id}","deployments_url":"https://api.github.com/repos/letgoapp/CameraManager/deployments","created_at":"2017-03-20T14:58:49Z","updated_at":"2017-03-20T14:58:51Z","pushed_at":"2018-03-12T10:19:49Z","git_url":"git://github.com/letgoapp/CameraManager.git","ssh_url":"git@github.com:letgoapp/CameraManager.git","clone_url":"https://github.com/letgoapp/CameraManager.git","svn_url":"https://github.com/letgoapp/CameraManager","homepage":"","size":7953,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"letgoapp:master","ref":"master","sha":"1a220117e2d783b318d9370de7b01213959cff6b","user":{"login":"letgoapp","id":15359988,"avatar_url":"https://avatars1.githubusercontent.com/u/15359988?v=4","gravatar_id":"","url":"https://api.github.com/users/letgoapp","html_url":"https://github.com/letgoapp","followers_url":"https://api.github.com/users/letgoapp/followers","following_url":"https://api.github.com/users/letgoapp/following{/other_user}","gists_url":"https://api.github.com/users/letgoapp/gists{/gist_id}","starred_url":"https://api.github.com/users/letgoapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letgoapp/subscriptions","organizations_url":"https://api.github.com/users/letgoapp/orgs","repos_url":"https://api.github.com/users/letgoapp/repos","events_url":"https://api.github.com/users/letgoapp/events{/privacy}","received_events_url":"https://api.github.com/users/letgoapp/received_events","type":"Organization","site_admin":false},"repo":{"id":85590246,"name":"CameraManager","full_name":"letgoapp/CameraManager","owner":{"login":"letgoapp","id":15359988,"avatar_url":"https://avatars1.githubusercontent.com/u/15359988?v=4","gravatar_id":"","url":"https://api.github.com/users/letgoapp","html_url":"https://github.com/letgoapp","followers_url":"https://api.github.com/users/letgoapp/followers","following_url":"https://api.github.com/users/letgoapp/following{/other_user}","gists_url":"https://api.github.com/users/letgoapp/gists{/gist_id}","starred_url":"https://api.github.com/users/letgoapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letgoapp/subscriptions","organizations_url":"https://api.github.com/users/letgoapp/orgs","repos_url":"https://api.github.com/users/letgoapp/repos","events_url":"https://api.github.com/users/letgoapp/events{/privacy}","received_events_url":"https://api.github.com/users/letgoapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letgoapp/CameraManager","description":"Simple Swift class to provide all the configurations you need to create custom camera view in your app","fork":true,"url":"https://api.github.com/repos/letgoapp/CameraManager","forks_url":"https://api.github.com/repos/letgoapp/CameraManager/forks","keys_url":"https://api.github.com/repos/letgoapp/CameraManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letgoapp/CameraManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letgoapp/CameraManager/teams","hooks_url":"https://api.github.com/repos/letgoapp/CameraManager/hooks","issue_events_url":"https://api.github.com/repos/letgoapp/CameraManager/issues/events{/number}","events_url":"https://api.github.com/repos/letgoapp/CameraManager/events","assignees_url":"https://api.github.com/repos/letgoapp/CameraManager/assignees{/user}","branches_url":"https://api.github.com/repos/letgoapp/CameraManager/branches{/branch}","tags_url":"https://api.github.com/repos/letgoapp/CameraManager/tags","blobs_url":"https://api.github.com/repos/letgoapp/CameraManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letgoapp/CameraManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letgoapp/CameraManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/letgoapp/CameraManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letgoapp/CameraManager/statuses/{sha}","languages_url":"https://api.github.com/repos/letgoapp/CameraManager/languages","stargazers_url":"https://api.github.com/repos/letgoapp/CameraManager/stargazers","contributors_url":"https://api.github.com/repos/letgoapp/CameraManager/contributors","subscribers_url":"https://api.github.com/repos/letgoapp/CameraManager/subscribers","subscription_url":"https://api.github.com/repos/letgoapp/CameraManager/subscription","commits_url":"https://api.github.com/repos/letgoapp/CameraManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/letgoapp/CameraManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/letgoapp/CameraManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/letgoapp/CameraManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/letgoapp/CameraManager/contents/{+path}","compare_url":"https://api.github.com/repos/letgoapp/CameraManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letgoapp/CameraManager/merges","archive_url":"https://api.github.com/repos/letgoapp/CameraManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letgoapp/CameraManager/downloads","issues_url":"https://api.github.com/repos/letgoapp/CameraManager/issues{/number}","pulls_url":"https://api.github.com/repos/letgoapp/CameraManager/pulls{/number}","milestones_url":"https://api.github.com/repos/letgoapp/CameraManager/milestones{/number}","notifications_url":"https://api.github.com/repos/letgoapp/CameraManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letgoapp/CameraManager/labels{/name}","releases_url":"https://api.github.com/repos/letgoapp/CameraManager/releases{/id}","deployments_url":"https://api.github.com/repos/letgoapp/CameraManager/deployments","created_at":"2017-03-20T14:58:49Z","updated_at":"2017-03-20T14:58:51Z","pushed_at":"2018-03-12T10:19:49Z","git_url":"git://github.com/letgoapp/CameraManager.git","ssh_url":"git@github.com:letgoapp/CameraManager.git","clone_url":"https://github.com/letgoapp/CameraManager.git","svn_url":"https://github.com/letgoapp/CameraManager","homepage":"","size":7953,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/letgoapp/CameraManager/pulls/5"},"html":{"href":"https://github.com/letgoapp/CameraManager/pull/5"},"issue":{"href":"https://api.github.com/repos/letgoapp/CameraManager/issues/5"},"comments":{"href":"https://api.github.com/repos/letgoapp/CameraManager/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/letgoapp/CameraManager/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/letgoapp/CameraManager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/letgoapp/CameraManager/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/letgoapp/CameraManager/statuses/43b20b497ba2f578e821e8fcb499da9ee1414127"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"SwiftTsubame"}}