{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka-persistence-couchbase/pulls/comments/230096730","pull_request_review_id":170747865,"id":230096730,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDA5NjczMA==","diff_hunk":"@@ -0,0 +1,100 @@\n+/*\n+ * Copyright (C) 2009-2018 Lightbend Inc. <https://www.lightbend.com>\n+ */\n+package akka.stream.alpakka.couchbase.impl\n+\n+import akka.annotation.InternalApi\n+import akka.dispatch.ExecutionContexts\n+import akka.stream.alpakka.couchbase.CouchbaseWriteSettings\n+import akka.stream.alpakka.couchbase.scaladsl.CouchbaseSession\n+import akka.stream.scaladsl.Source\n+import akka.{ Done, NotUsed }\n+import com.couchbase.client.java.Bucket\n+import com.couchbase.client.java.document.JsonDocument\n+import com.couchbase.client.java.document.json.JsonObject\n+import com.couchbase.client.java.query.{ N1qlQuery, Statement }\n+import rx.RxReactiveStreams\n+\n+import scala.concurrent.Future\n+\n+/**\n+ * InternalAPI\n+ */\n+@InternalApi\n+final private[couchbase] class CouchbaseSessionImpl(bucket: Bucket) extends CouchbaseSession {\n+\n+  private val asyncBucket = bucket.async()","path":"couchbase-client/src/main/scala/akka/stream/alpakka/couchbase/impl/CouchbaseSessionImpl.scala","position":26,"original_position":26,"commit_id":"75c5a032a5096cf6ee740bfb7e1efa5e69b06f70","original_commit_id":"75c5a032a5096cf6ee740bfb7e1efa5e69b06f70","user":{"login":"ygree","id":4147346,"node_id":"MDQ6VXNlcjQxNDczNDY=","avatar_url":"https://avatars1.githubusercontent.com/u/4147346?v=4","gravatar_id":"","url":"https://api.github.com/users/ygree","html_url":"https://github.com/ygree","followers_url":"https://api.github.com/users/ygree/followers","following_url":"https://api.github.com/users/ygree/following{/other_user}","gists_url":"https://api.github.com/users/ygree/gists{/gist_id}","starred_url":"https://api.github.com/users/ygree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ygree/subscriptions","organizations_url":"https://api.github.com/users/ygree/orgs","repos_url":"https://api.github.com/users/ygree/repos","events_url":"https://api.github.com/users/ygree/events{/privacy}","received_events_url":"https://api.github.com/users/ygree/received_events","type":"User","site_admin":false},"body":"Should we pass asyncBucket to prevent accidental usage of some sync methods?","created_at":"2018-11-01T16:02:14Z","updated_at":"2018-11-01T16:19:23Z","html_url":"https://github.com/akka/akka-persistence-couchbase/pull/30#discussion_r230096730","pull_request_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/pulls/30","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/akka/akka-persistence-couchbase/pulls/comments/230096730"},"html":{"href":"https://github.com/akka/akka-persistence-couchbase/pull/30#discussion_r230096730"},"pull_request":{"href":"https://api.github.com/repos/akka/akka-persistence-couchbase/pulls/30"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka-persistence-couchbase/pulls/30","id":227649090,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NjQ5MDkw","html_url":"https://github.com/akka/akka-persistence-couchbase/pull/30","diff_url":"https://github.com/akka/akka-persistence-couchbase/pull/30.diff","patch_url":"https://github.com/akka/akka-persistence-couchbase/pull/30.patch","issue_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/issues/30","number":30,"state":"open","locked":false,"title":"[WiP] Extract client","user":{"login":"johanandren","id":666915,"node_id":"MDQ6VXNlcjY2NjkxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/666915?v=4","gravatar_id":"","url":"https://api.github.com/users/johanandren","html_url":"https://github.com/johanandren","followers_url":"https://api.github.com/users/johanandren/followers","following_url":"https://api.github.com/users/johanandren/following{/other_user}","gists_url":"https://api.github.com/users/johanandren/gists{/gist_id}","starred_url":"https://api.github.com/users/johanandren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanandren/subscriptions","organizations_url":"https://api.github.com/users/johanandren/orgs","repos_url":"https://api.github.com/users/johanandren/repos","events_url":"https://api.github.com/users/johanandren/events{/privacy}","received_events_url":"https://api.github.com/users/johanandren/received_events","type":"User","site_admin":false},"body":"Extracting the interactions with the couchbase client into a clearly defined `Session` API.\r\n\r\nSo far everything compiles but the Journal tests are not passing anymore.","created_at":"2018-11-01T15:01:45Z","updated_at":"2018-11-01T16:19:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c407c4be450a87cad9280c3f6ff7e9e62c940b8b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/pulls/30/commits","review_comments_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/pulls/30/comments","review_comment_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/issues/30/comments","statuses_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/statuses/75c5a032a5096cf6ee740bfb7e1efa5e69b06f70","head":{"label":"johanandren:wip-5-extract-client-johanandren","ref":"wip-5-extract-client-johanandren","sha":"75c5a032a5096cf6ee740bfb7e1efa5e69b06f70","user":{"login":"johanandren","id":666915,"node_id":"MDQ6VXNlcjY2NjkxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/666915?v=4","gravatar_id":"","url":"https://api.github.com/users/johanandren","html_url":"https://github.com/johanandren","followers_url":"https://api.github.com/users/johanandren/followers","following_url":"https://api.github.com/users/johanandren/following{/other_user}","gists_url":"https://api.github.com/users/johanandren/gists{/gist_id}","starred_url":"https://api.github.com/users/johanandren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanandren/subscriptions","organizations_url":"https://api.github.com/users/johanandren/orgs","repos_url":"https://api.github.com/users/johanandren/repos","events_url":"https://api.github.com/users/johanandren/events{/privacy}","received_events_url":"https://api.github.com/users/johanandren/received_events","type":"User","site_admin":false},"repo":{"id":154963993,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ5NjM5OTM=","name":"akka-persistence-couchbase","full_name":"johanandren/akka-persistence-couchbase","private":false,"owner":{"login":"johanandren","id":666915,"node_id":"MDQ6VXNlcjY2NjkxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/666915?v=4","gravatar_id":"","url":"https://api.github.com/users/johanandren","html_url":"https://github.com/johanandren","followers_url":"https://api.github.com/users/johanandren/followers","following_url":"https://api.github.com/users/johanandren/following{/other_user}","gists_url":"https://api.github.com/users/johanandren/gists{/gist_id}","starred_url":"https://api.github.com/users/johanandren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanandren/subscriptions","organizations_url":"https://api.github.com/users/johanandren/orgs","repos_url":"https://api.github.com/users/johanandren/repos","events_url":"https://api.github.com/users/johanandren/events{/privacy}","received_events_url":"https://api.github.com/users/johanandren/received_events","type":"User","site_admin":false},"html_url":"https://github.com/johanandren/akka-persistence-couchbase","description":"PoC for Couchbase as an Akka Persistence Backend","fork":true,"url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase","forks_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/forks","keys_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/teams","hooks_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/hooks","issue_events_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/issues/events{/number}","events_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/events","assignees_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/assignees{/user}","branches_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/branches{/branch}","tags_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/tags","blobs_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/git/refs{/sha}","trees_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/statuses/{sha}","languages_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/languages","stargazers_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/stargazers","contributors_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/contributors","subscribers_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/subscribers","subscription_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/subscription","commits_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/commits{/sha}","git_commits_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/git/commits{/sha}","comments_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/comments{/number}","issue_comment_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/issues/comments{/number}","contents_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/contents/{+path}","compare_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/merges","archive_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/downloads","issues_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/issues{/number}","pulls_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/pulls{/number}","milestones_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/milestones{/number}","notifications_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/labels{/name}","releases_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/releases{/id}","deployments_url":"https://api.github.com/repos/johanandren/akka-persistence-couchbase/deployments","created_at":"2018-10-27T12:49:44Z","updated_at":"2018-10-31T11:21:00Z","pushed_at":"2018-11-01T15:13:11Z","git_url":"git://github.com/johanandren/akka-persistence-couchbase.git","ssh_url":"git@github.com:johanandren/akka-persistence-couchbase.git","clone_url":"https://github.com/johanandren/akka-persistence-couchbase.git","svn_url":"https://github.com/johanandren/akka-persistence-couchbase","homepage":null,"size":114,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"7ae2f27f5f1121a58f75517daf0f7b328a17b43f","user":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":146632320,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2MzIzMjA=","name":"akka-persistence-couchbase","full_name":"akka/akka-persistence-couchbase","private":false,"owner":{"login":"akka","id":1496237,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTYyMzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/akka/akka-persistence-couchbase","description":"PoC for Couchbase as an Akka Persistence Backend","fork":false,"url":"https://api.github.com/repos/akka/akka-persistence-couchbase","forks_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/forks","keys_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/teams","hooks_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/hooks","issue_events_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/events","assignees_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/tags","blobs_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/languages","stargazers_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/stargazers","contributors_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/contributors","subscribers_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/subscribers","subscription_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/subscription","commits_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/merges","archive_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/downloads","issues_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka-persistence-couchbase/deployments","created_at":"2018-08-29T17:04:47Z","updated_at":"2018-11-01T13:49:50Z","pushed_at":"2018-11-01T15:13:12Z","git_url":"git://github.com/akka/akka-persistence-couchbase.git","ssh_url":"git@github.com:akka/akka-persistence-couchbase.git","clone_url":"https://github.com/akka/akka-persistence-couchbase.git","svn_url":"https://github.com/akka/akka-persistence-couchbase","homepage":null,"size":94,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":21,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka-persistence-couchbase/pulls/30"},"html":{"href":"https://github.com/akka/akka-persistence-couchbase/pull/30"},"issue":{"href":"https://api.github.com/repos/akka/akka-persistence-couchbase/issues/30"},"comments":{"href":"https://api.github.com/repos/akka/akka-persistence-couchbase/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka-persistence-couchbase/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka-persistence-couchbase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka-persistence-couchbase/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka-persistence-couchbase/statuses/75c5a032a5096cf6ee740bfb7e1efa5e69b06f70"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ygree"}}