{"action":"closed","number":11404,"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11404","id":193786967,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzg2OTY3","html_url":"https://github.com/matplotlib/matplotlib/pull/11404","diff_url":"https://github.com/matplotlib/matplotlib/pull/11404.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/11404.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/11404","number":11404,"state":"closed","locked":false,"title":"FIX: don't include text at -inf in bbox","user":{"login":"jklymak","id":1562854,"node_id":"MDQ6VXNlcjE1NjI4NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1562854?v=4","gravatar_id":"","url":"https://api.github.com/users/jklymak","html_url":"https://github.com/jklymak","followers_url":"https://api.github.com/users/jklymak/followers","following_url":"https://api.github.com/users/jklymak/following{/other_user}","gists_url":"https://api.github.com/users/jklymak/gists{/gist_id}","starred_url":"https://api.github.com/users/jklymak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklymak/subscriptions","organizations_url":"https://api.github.com/users/jklymak/orgs","repos_url":"https://api.github.com/users/jklymak/repos","events_url":"https://api.github.com/users/jklymak/events{/privacy}","received_events_url":"https://api.github.com/users/jklymak/received_events","type":"User","site_admin":false},"body":"## PR Summary\r\n\r\nAdresses #11386, #5456.  See also #11417 that properly fixes the logit issues...\r\n\r\nCode like below caused anything that required the `tightbbox` of the axes to fail for`logit` axes:\r\n\r\nThis PR does *not* fix logit axes, but instead ignores non-finite values of the text positions when calculating the bbox, since those are assumed to be invalid.  I suppose someone could also figure out how to fix logit, but I'm not too interested in digging into it.\r\n\r\n```python\r\nimport matplotlib.pyplot as plt\r\nimport numpy as np\r\nfig, ax = plt.subplots()\r\n\r\nnp.random.seed(1)\r\ny = np.random.normal(loc=0.5, scale=0.4, size=1000)\r\ny = y[(y > 0) & (y < 1)]\r\ny.sort()\r\nx = np.arange(len(y))\r\nax.plot(x, y)\r\nax.set_yscale('logit')\r\nprint(ax.get_tightbbox(fig.canvas.get_renderer()))\r\n```\r\n### Before\r\n```\r\n/Users/jklymak/matplotlib/lib/matplotlib/transforms.py:402: RuntimeWarning: invalid value encountered in double_scalars\r\n  return points[1, 0] - points[0, 0]\r\nBbox(x0=-inf, y0=nan, x1=1155.5, y1=nan)\r\n```\r\n\r\n### After\r\n\r\n```\r\nBbox(x0=-21.6925048828125, y0=58.15555555555555, x1=1155.5, y1=848.3)\r\n```\r\n\r\n## PR Checklist\r\n\r\n- [ ] Has Pytest style unit tests\r\n- [ ] Code is PEP 8 compliant\r\n- [ ] New features are documented, with examples if plot related\r\n- [ ] Documentation is sphinx and numpydoc compliant\r\n- [ ] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)\r\n- [ ] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way\r\n\r\n<!--\r\nThank you so much for your PR!  To help us review your contribution, please\r\nconsider the following points:\r\n\r\n- A development guide is available at https://matplotlib.org/devdocs/devel/index.html.\r\n\r\n- Help with git and github is available at\r\n  https://matplotlib.org/devel/gitwash/development_workflow.html.\r\n\r\n- Do not create the PR out of master, but out of a separate branch.\r\n\r\n- The PR title should summarize the changes, for example \"Raise ValueError on\r\n  non-numeric input to set_xlim\".  Avoid non-descriptive titles such as\r\n  \"Addresses issue #8576\".\r\n\r\n- The summary should provide at least 1-2 sentences describing the pull request\r\n  in detail (Why is this change required?  What problem does it solve?) and\r\n  link to any relevant issues.\r\n\r\n- If you are contributing fixes to docstrings, please pay attention to\r\n  http://matplotlib.org/devel/documenting_mpl.html#formatting.  In particular,\r\n  note the difference between using single backquotes, double backquotes, and\r\n  asterisks in the markup.\r\n\r\nWe understand that PRs can sometimes be overwhelming, especially as the\r\nreviews start coming in.  Please let us know if the reviews are unclear or\r\nthe recommended next step seems overly demanding, if you would like help in\r\naddressing a reviewer's comments, or if you have been waiting too long to hear\r\nback on your PR.\r\n-->","created_at":"2018-06-09T17:00:07Z","updated_at":"2018-07-03T01:20:29Z","closed_at":"2018-07-03T01:20:28Z","merged_at":"2018-07-03T01:20:28Z","merge_commit_sha":"4d7f8ce62f53f522fef5cb786de6cc049bd0b6c7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/23","html_url":"https://github.com/matplotlib/matplotlib/milestone/23","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/23/labels","id":1542657,"node_id":"MDk6TWlsZXN0b25lMTU0MjY1Nw==","number":23,"title":"v3.0","description":"Big ticket items:\r\n\r\n - drop support for python 2","creator":{"login":"tacaswell","id":199813,"node_id":"MDQ6VXNlcjE5OTgxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/199813?v=4","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":234,"closed_issues":429,"state":"open","created_at":"2016-01-25T21:06:49Z","updated_at":"2018-07-03T01:20:29Z","due_on":"2018-07-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11404/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11404/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/11404/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/aa5537af653263ff6ed124d2f634d6e372584efa","head":{"label":"jklymak:fix-inf-text","ref":"fix-inf-text","sha":"aa5537af653263ff6ed124d2f634d6e372584efa","user":{"login":"jklymak","id":1562854,"node_id":"MDQ6VXNlcjE1NjI4NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1562854?v=4","gravatar_id":"","url":"https://api.github.com/users/jklymak","html_url":"https://github.com/jklymak","followers_url":"https://api.github.com/users/jklymak/followers","following_url":"https://api.github.com/users/jklymak/following{/other_user}","gists_url":"https://api.github.com/users/jklymak/gists{/gist_id}","starred_url":"https://api.github.com/users/jklymak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklymak/subscriptions","organizations_url":"https://api.github.com/users/jklymak/orgs","repos_url":"https://api.github.com/users/jklymak/repos","events_url":"https://api.github.com/users/jklymak/events{/privacy}","received_events_url":"https://api.github.com/users/jklymak/received_events","type":"User","site_admin":false},"repo":{"id":93901119,"node_id":"MDEwOlJlcG9zaXRvcnk5MzkwMTExOQ==","name":"matplotlib","full_name":"jklymak/matplotlib","owner":{"login":"jklymak","id":1562854,"node_id":"MDQ6VXNlcjE1NjI4NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1562854?v=4","gravatar_id":"","url":"https://api.github.com/users/jklymak","html_url":"https://github.com/jklymak","followers_url":"https://api.github.com/users/jklymak/followers","following_url":"https://api.github.com/users/jklymak/following{/other_user}","gists_url":"https://api.github.com/users/jklymak/gists{/gist_id}","starred_url":"https://api.github.com/users/jklymak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklymak/subscriptions","organizations_url":"https://api.github.com/users/jklymak/orgs","repos_url":"https://api.github.com/users/jklymak/repos","events_url":"https://api.github.com/users/jklymak/events{/privacy}","received_events_url":"https://api.github.com/users/jklymak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jklymak/matplotlib","description":"matplotlib: plotting with Python","fork":true,"url":"https://api.github.com/repos/jklymak/matplotlib","forks_url":"https://api.github.com/repos/jklymak/matplotlib/forks","keys_url":"https://api.github.com/repos/jklymak/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jklymak/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jklymak/matplotlib/teams","hooks_url":"https://api.github.com/repos/jklymak/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/jklymak/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/jklymak/matplotlib/events","assignees_url":"https://api.github.com/repos/jklymak/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/jklymak/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/jklymak/matplotlib/tags","blobs_url":"https://api.github.com/repos/jklymak/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jklymak/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jklymak/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/jklymak/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jklymak/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/jklymak/matplotlib/languages","stargazers_url":"https://api.github.com/repos/jklymak/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/jklymak/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/jklymak/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/jklymak/matplotlib/subscription","commits_url":"https://api.github.com/repos/jklymak/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/jklymak/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/jklymak/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/jklymak/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/jklymak/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/jklymak/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jklymak/matplotlib/merges","archive_url":"https://api.github.com/repos/jklymak/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jklymak/matplotlib/downloads","issues_url":"https://api.github.com/repos/jklymak/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/jklymak/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/jklymak/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/jklymak/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jklymak/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/jklymak/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/jklymak/matplotlib/deployments","created_at":"2017-06-09T22:24:38Z","updated_at":"2017-06-10T22:48:17Z","pushed_at":"2018-07-02T20:49:55Z","git_url":"git://github.com/jklymak/matplotlib.git","ssh_url":"git@github.com:jklymak/matplotlib.git","clone_url":"https://github.com/jklymak/matplotlib.git","svn_url":"https://github.com/jklymak/matplotlib","homepage":"http://matplotlib.org/","size":333288,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"placeholder"}},"base":{"label":"matplotlib:master","ref":"master","sha":"0d2c4365e7cc4498d82f0b051ffb46343f44227c","user":{"login":"matplotlib","id":215947,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNTk0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg1MTIy","name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxNTk0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/matplotlib/matplotlib/deployments","created_at":"2011-02-19T03:17:12Z","updated_at":"2018-07-03T00:36:43Z","pushed_at":"2018-07-03T01:20:28Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":328607,"stargazers_count":7505,"watchers_count":7505,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3470,"mirror_url":null,"archived":false,"open_issues_count":1369,"license":null,"forks":3470,"open_issues":1369,"watchers":7505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11404"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/11404"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/11404"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/11404/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11404/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/11404/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/aa5537af653263ff6ed124d2f634d6e372584efa"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"efiring","id":85125,"node_id":"MDQ6VXNlcjg1MTI1","avatar_url":"https://avatars1.githubusercontent.com/u/85125?v=4","gravatar_id":"","url":"https://api.github.com/users/efiring","html_url":"https://github.com/efiring","followers_url":"https://api.github.com/users/efiring/followers","following_url":"https://api.github.com/users/efiring/following{/other_user}","gists_url":"https://api.github.com/users/efiring/gists{/gist_id}","starred_url":"https://api.github.com/users/efiring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efiring/subscriptions","organizations_url":"https://api.github.com/users/efiring/orgs","repos_url":"https://api.github.com/users/efiring/repos","events_url":"https://api.github.com/users/efiring/events{/privacy}","received_events_url":"https://api.github.com/users/efiring/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"efiring"}}