{"action":"closed","number":23,"pull_request":{"url":"https://api.github.com/repos/aalmiray/ikonli/pulls/23","id":188128151,"html_url":"https://github.com/aalmiray/ikonli/pull/23","diff_url":"https://github.com/aalmiray/ikonli/pull/23.diff","patch_url":"https://github.com/aalmiray/ikonli/pull/23.patch","issue_url":"https://api.github.com/repos/aalmiray/ikonli/issues/23","number":23,"state":"closed","locked":false,"title":"fix resolveSize","user":{"login":"Typhon0","id":10800948,"avatar_url":"https://avatars3.githubusercontent.com/u/10800948?v=4","gravatar_id":"","url":"https://api.github.com/users/Typhon0","html_url":"https://github.com/Typhon0","followers_url":"https://api.github.com/users/Typhon0/followers","following_url":"https://api.github.com/users/Typhon0/following{/other_user}","gists_url":"https://api.github.com/users/Typhon0/gists{/gist_id}","starred_url":"https://api.github.com/users/Typhon0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Typhon0/subscriptions","organizations_url":"https://api.github.com/users/Typhon0/orgs","repos_url":"https://api.github.com/users/Typhon0/repos","events_url":"https://api.github.com/users/Typhon0/events{/privacy}","received_events_url":"https://api.github.com/users/Typhon0/received_events","type":"User","site_admin":false},"body":"Hi, I fixed the resolveFunction to not override the icon size. No need to specify the size to use by default if the size is not defined in the literal because the constructor already define the size by default to 16.\r\n\r\n#21 ","created_at":"2018-05-15T13:27:38Z","updated_at":"2018-05-24T09:07:39Z","closed_at":"2018-05-24T09:07:39Z","merged_at":null,"merge_commit_sha":"48f967e2fda24d4e91870a49dd374ed6dba42f6d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aalmiray/ikonli/pulls/23/commits","review_comments_url":"https://api.github.com/repos/aalmiray/ikonli/pulls/23/comments","review_comment_url":"https://api.github.com/repos/aalmiray/ikonli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aalmiray/ikonli/issues/23/comments","statuses_url":"https://api.github.com/repos/aalmiray/ikonli/statuses/51f4a9b5eb2ab7d57659e9c76603cc63df878f26","head":{"label":"Typhon0:fix-resolveSize","ref":"fix-resolveSize","sha":"51f4a9b5eb2ab7d57659e9c76603cc63df878f26","user":{"login":"Typhon0","id":10800948,"avatar_url":"https://avatars3.githubusercontent.com/u/10800948?v=4","gravatar_id":"","url":"https://api.github.com/users/Typhon0","html_url":"https://github.com/Typhon0","followers_url":"https://api.github.com/users/Typhon0/followers","following_url":"https://api.github.com/users/Typhon0/following{/other_user}","gists_url":"https://api.github.com/users/Typhon0/gists{/gist_id}","starred_url":"https://api.github.com/users/Typhon0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Typhon0/subscriptions","organizations_url":"https://api.github.com/users/Typhon0/orgs","repos_url":"https://api.github.com/users/Typhon0/repos","events_url":"https://api.github.com/users/Typhon0/events{/privacy}","received_events_url":"https://api.github.com/users/Typhon0/received_events","type":"User","site_admin":false},"repo":{"id":133274734,"name":"ikonli","full_name":"Typhon0/ikonli","owner":{"login":"Typhon0","id":10800948,"avatar_url":"https://avatars3.githubusercontent.com/u/10800948?v=4","gravatar_id":"","url":"https://api.github.com/users/Typhon0","html_url":"https://github.com/Typhon0","followers_url":"https://api.github.com/users/Typhon0/followers","following_url":"https://api.github.com/users/Typhon0/following{/other_user}","gists_url":"https://api.github.com/users/Typhon0/gists{/gist_id}","starred_url":"https://api.github.com/users/Typhon0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Typhon0/subscriptions","organizations_url":"https://api.github.com/users/Typhon0/orgs","repos_url":"https://api.github.com/users/Typhon0/repos","events_url":"https://api.github.com/users/Typhon0/events{/privacy}","received_events_url":"https://api.github.com/users/Typhon0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Typhon0/ikonli","description":"Icon packs for Java applications","fork":true,"url":"https://api.github.com/repos/Typhon0/ikonli","forks_url":"https://api.github.com/repos/Typhon0/ikonli/forks","keys_url":"https://api.github.com/repos/Typhon0/ikonli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Typhon0/ikonli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Typhon0/ikonli/teams","hooks_url":"https://api.github.com/repos/Typhon0/ikonli/hooks","issue_events_url":"https://api.github.com/repos/Typhon0/ikonli/issues/events{/number}","events_url":"https://api.github.com/repos/Typhon0/ikonli/events","assignees_url":"https://api.github.com/repos/Typhon0/ikonli/assignees{/user}","branches_url":"https://api.github.com/repos/Typhon0/ikonli/branches{/branch}","tags_url":"https://api.github.com/repos/Typhon0/ikonli/tags","blobs_url":"https://api.github.com/repos/Typhon0/ikonli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Typhon0/ikonli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Typhon0/ikonli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Typhon0/ikonli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Typhon0/ikonli/statuses/{sha}","languages_url":"https://api.github.com/repos/Typhon0/ikonli/languages","stargazers_url":"https://api.github.com/repos/Typhon0/ikonli/stargazers","contributors_url":"https://api.github.com/repos/Typhon0/ikonli/contributors","subscribers_url":"https://api.github.com/repos/Typhon0/ikonli/subscribers","subscription_url":"https://api.github.com/repos/Typhon0/ikonli/subscription","commits_url":"https://api.github.com/repos/Typhon0/ikonli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Typhon0/ikonli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Typhon0/ikonli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Typhon0/ikonli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Typhon0/ikonli/contents/{+path}","compare_url":"https://api.github.com/repos/Typhon0/ikonli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Typhon0/ikonli/merges","archive_url":"https://api.github.com/repos/Typhon0/ikonli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Typhon0/ikonli/downloads","issues_url":"https://api.github.com/repos/Typhon0/ikonli/issues{/number}","pulls_url":"https://api.github.com/repos/Typhon0/ikonli/pulls{/number}","milestones_url":"https://api.github.com/repos/Typhon0/ikonli/milestones{/number}","notifications_url":"https://api.github.com/repos/Typhon0/ikonli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Typhon0/ikonli/labels{/name}","releases_url":"https://api.github.com/repos/Typhon0/ikonli/releases{/id}","deployments_url":"https://api.github.com/repos/Typhon0/ikonli/deployments","created_at":"2018-05-13T21:12:33Z","updated_at":"2018-05-15T13:05:06Z","pushed_at":"2018-05-15T13:23:16Z","git_url":"git://github.com/Typhon0/ikonli.git","ssh_url":"git@github.com:Typhon0/ikonli.git","clone_url":"https://github.com/Typhon0/ikonli.git","svn_url":"https://github.com/Typhon0/ikonli","homepage":null,"size":14953,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aalmiray:master","ref":"master","sha":"94c07d2016419a4547d3f557a9001fb6916a110d","user":{"login":"aalmiray","id":13969,"avatar_url":"https://avatars1.githubusercontent.com/u/13969?v=4","gravatar_id":"","url":"https://api.github.com/users/aalmiray","html_url":"https://github.com/aalmiray","followers_url":"https://api.github.com/users/aalmiray/followers","following_url":"https://api.github.com/users/aalmiray/following{/other_user}","gists_url":"https://api.github.com/users/aalmiray/gists{/gist_id}","starred_url":"https://api.github.com/users/aalmiray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aalmiray/subscriptions","organizations_url":"https://api.github.com/users/aalmiray/orgs","repos_url":"https://api.github.com/users/aalmiray/repos","events_url":"https://api.github.com/users/aalmiray/events{/privacy}","received_events_url":"https://api.github.com/users/aalmiray/received_events","type":"User","site_admin":false},"repo":{"id":49275911,"name":"ikonli","full_name":"aalmiray/ikonli","owner":{"login":"aalmiray","id":13969,"avatar_url":"https://avatars1.githubusercontent.com/u/13969?v=4","gravatar_id":"","url":"https://api.github.com/users/aalmiray","html_url":"https://github.com/aalmiray","followers_url":"https://api.github.com/users/aalmiray/followers","following_url":"https://api.github.com/users/aalmiray/following{/other_user}","gists_url":"https://api.github.com/users/aalmiray/gists{/gist_id}","starred_url":"https://api.github.com/users/aalmiray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aalmiray/subscriptions","organizations_url":"https://api.github.com/users/aalmiray/orgs","repos_url":"https://api.github.com/users/aalmiray/repos","events_url":"https://api.github.com/users/aalmiray/events{/privacy}","received_events_url":"https://api.github.com/users/aalmiray/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aalmiray/ikonli","description":"Icon packs for Java applications","fork":false,"url":"https://api.github.com/repos/aalmiray/ikonli","forks_url":"https://api.github.com/repos/aalmiray/ikonli/forks","keys_url":"https://api.github.com/repos/aalmiray/ikonli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aalmiray/ikonli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aalmiray/ikonli/teams","hooks_url":"https://api.github.com/repos/aalmiray/ikonli/hooks","issue_events_url":"https://api.github.com/repos/aalmiray/ikonli/issues/events{/number}","events_url":"https://api.github.com/repos/aalmiray/ikonli/events","assignees_url":"https://api.github.com/repos/aalmiray/ikonli/assignees{/user}","branches_url":"https://api.github.com/repos/aalmiray/ikonli/branches{/branch}","tags_url":"https://api.github.com/repos/aalmiray/ikonli/tags","blobs_url":"https://api.github.com/repos/aalmiray/ikonli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aalmiray/ikonli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aalmiray/ikonli/git/refs{/sha}","trees_url":"https://api.github.com/repos/aalmiray/ikonli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aalmiray/ikonli/statuses/{sha}","languages_url":"https://api.github.com/repos/aalmiray/ikonli/languages","stargazers_url":"https://api.github.com/repos/aalmiray/ikonli/stargazers","contributors_url":"https://api.github.com/repos/aalmiray/ikonli/contributors","subscribers_url":"https://api.github.com/repos/aalmiray/ikonli/subscribers","subscription_url":"https://api.github.com/repos/aalmiray/ikonli/subscription","commits_url":"https://api.github.com/repos/aalmiray/ikonli/commits{/sha}","git_commits_url":"https://api.github.com/repos/aalmiray/ikonli/git/commits{/sha}","comments_url":"https://api.github.com/repos/aalmiray/ikonli/comments{/number}","issue_comment_url":"https://api.github.com/repos/aalmiray/ikonli/issues/comments{/number}","contents_url":"https://api.github.com/repos/aalmiray/ikonli/contents/{+path}","compare_url":"https://api.github.com/repos/aalmiray/ikonli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aalmiray/ikonli/merges","archive_url":"https://api.github.com/repos/aalmiray/ikonli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aalmiray/ikonli/downloads","issues_url":"https://api.github.com/repos/aalmiray/ikonli/issues{/number}","pulls_url":"https://api.github.com/repos/aalmiray/ikonli/pulls{/number}","milestones_url":"https://api.github.com/repos/aalmiray/ikonli/milestones{/number}","notifications_url":"https://api.github.com/repos/aalmiray/ikonli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aalmiray/ikonli/labels{/name}","releases_url":"https://api.github.com/repos/aalmiray/ikonli/releases{/id}","deployments_url":"https://api.github.com/repos/aalmiray/ikonli/deployments","created_at":"2016-01-08T14:17:09Z","updated_at":"2018-05-24T09:07:09Z","pushed_at":"2018-05-24T09:07:06Z","git_url":"git://github.com/aalmiray/ikonli.git","ssh_url":"git@github.com:aalmiray/ikonli.git","clone_url":"https://github.com/aalmiray/ikonli.git","svn_url":"https://github.com/aalmiray/ikonli","homepage":null,"size":15927,"stargazers_count":53,"watchers_count":53,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":10,"open_issues":3,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aalmiray/ikonli/pulls/23"},"html":{"href":"https://github.com/aalmiray/ikonli/pull/23"},"issue":{"href":"https://api.github.com/repos/aalmiray/ikonli/issues/23"},"comments":{"href":"https://api.github.com/repos/aalmiray/ikonli/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/aalmiray/ikonli/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/aalmiray/ikonli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aalmiray/ikonli/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/aalmiray/ikonli/statuses/51f4a9b5eb2ab7d57659e9c76603cc63df878f26"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"aalmiray"}}