{"action":"created","comment":{"url":"https://api.github.com/repos/Normation/rudder-tools/pulls/comments/236652999","pull_request_review_id":178768463,"id":236652999,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjY1Mjk5OQ==","diff_hunk":"@@ -76,7 +76,12 @@ setup_ncf() {\n \n     cd \"${directory}\"\n     # avoid making doc\n-    mkdir doc && touch doc/ncf.1\n+    if [ -d doc ]\n+    then\n+      touch doc/ncf.1\n+    else\n+      mkdir doc && touch doc/ncf.1","path":"scripts/rudder-setup/setup-ncf.sh","position":9,"original_position":9,"commit_id":"b6368b9a6bff48e2998b9cd8680535b4447eb89b","original_commit_id":"b6368b9a6bff48e2998b9cd8680535b4447eb89b","user":{"login":"amousset","id":329388,"node_id":"MDQ6VXNlcjMyOTM4OA==","avatar_url":"https://avatars0.githubusercontent.com/u/329388?v=4","gravatar_id":"","url":"https://api.github.com/users/amousset","html_url":"https://github.com/amousset","followers_url":"https://api.github.com/users/amousset/followers","following_url":"https://api.github.com/users/amousset/following{/other_user}","gists_url":"https://api.github.com/users/amousset/gists{/gist_id}","starred_url":"https://api.github.com/users/amousset/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amousset/subscriptions","organizations_url":"https://api.github.com/users/amousset/orgs","repos_url":"https://api.github.com/users/amousset/repos","events_url":"https://api.github.com/users/amousset/events{/privacy}","received_events_url":"https://api.github.com/users/amousset/received_events","type":"User","site_admin":false},"body":"use `mkdir -p`  instead","created_at":"2018-11-27T13:05:04Z","updated_at":"2018-11-27T13:05:04Z","html_url":"https://github.com/Normation/rudder-tools/pull/438#discussion_r236652999","pull_request_url":"https://api.github.com/repos/Normation/rudder-tools/pulls/438","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Normation/rudder-tools/pulls/comments/236652999"},"html":{"href":"https://github.com/Normation/rudder-tools/pull/438#discussion_r236652999"},"pull_request":{"href":"https://api.github.com/repos/Normation/rudder-tools/pulls/438"}}},"pull_request":{"url":"https://api.github.com/repos/Normation/rudder-tools/pulls/438","id":233876786,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzODc2Nzg2","html_url":"https://github.com/Normation/rudder-tools/pull/438","diff_url":"https://github.com/Normation/rudder-tools/pull/438.diff","patch_url":"https://github.com/Normation/rudder-tools/pull/438.patch","issue_url":"https://api.github.com/repos/Normation/rudder-tools/issues/438","number":438,"state":"open","locked":false,"title":"Fixes #13909: 13908 is only working for 4.3+ rudder installs","user":{"login":"Fdall","id":28622840,"node_id":"MDQ6VXNlcjI4NjIyODQw","avatar_url":"https://avatars3.githubusercontent.com/u/28622840?v=4","gravatar_id":"","url":"https://api.github.com/users/Fdall","html_url":"https://github.com/Fdall","followers_url":"https://api.github.com/users/Fdall/followers","following_url":"https://api.github.com/users/Fdall/following{/other_user}","gists_url":"https://api.github.com/users/Fdall/gists{/gist_id}","starred_url":"https://api.github.com/users/Fdall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fdall/subscriptions","organizations_url":"https://api.github.com/users/Fdall/orgs","repos_url":"https://api.github.com/users/Fdall/repos","events_url":"https://api.github.com/users/Fdall/events{/privacy}","received_events_url":"https://api.github.com/users/Fdall/received_events","type":"User","site_admin":false},"body":"https://issues.rudder.io/issues/13909","created_at":"2018-11-27T11:33:41Z","updated_at":"2018-11-27T13:05:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"085d98c1757bb5ad22e88fefb431e4fa3a6daecb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Normation/rudder-tools/pulls/438/commits","review_comments_url":"https://api.github.com/repos/Normation/rudder-tools/pulls/438/comments","review_comment_url":"https://api.github.com/repos/Normation/rudder-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Normation/rudder-tools/issues/438/comments","statuses_url":"https://api.github.com/repos/Normation/rudder-tools/statuses/b6368b9a6bff48e2998b9cd8680535b4447eb89b","head":{"label":"Fdall:bug_13909/13908_is_only_working_for_4_3_rudder_installs","ref":"bug_13909/13908_is_only_working_for_4_3_rudder_installs","sha":"b6368b9a6bff48e2998b9cd8680535b4447eb89b","user":{"login":"Fdall","id":28622840,"node_id":"MDQ6VXNlcjI4NjIyODQw","avatar_url":"https://avatars3.githubusercontent.com/u/28622840?v=4","gravatar_id":"","url":"https://api.github.com/users/Fdall","html_url":"https://github.com/Fdall","followers_url":"https://api.github.com/users/Fdall/followers","following_url":"https://api.github.com/users/Fdall/following{/other_user}","gists_url":"https://api.github.com/users/Fdall/gists{/gist_id}","starred_url":"https://api.github.com/users/Fdall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fdall/subscriptions","organizations_url":"https://api.github.com/users/Fdall/orgs","repos_url":"https://api.github.com/users/Fdall/repos","events_url":"https://api.github.com/users/Fdall/events{/privacy}","received_events_url":"https://api.github.com/users/Fdall/received_events","type":"User","site_admin":false},"repo":{"id":145105672,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxMDU2NzI=","name":"rudder-tools","full_name":"Fdall/rudder-tools","private":false,"owner":{"login":"Fdall","id":28622840,"node_id":"MDQ6VXNlcjI4NjIyODQw","avatar_url":"https://avatars3.githubusercontent.com/u/28622840?v=4","gravatar_id":"","url":"https://api.github.com/users/Fdall","html_url":"https://github.com/Fdall","followers_url":"https://api.github.com/users/Fdall/followers","following_url":"https://api.github.com/users/Fdall/following{/other_user}","gists_url":"https://api.github.com/users/Fdall/gists{/gist_id}","starred_url":"https://api.github.com/users/Fdall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fdall/subscriptions","organizations_url":"https://api.github.com/users/Fdall/orgs","repos_url":"https://api.github.com/users/Fdall/repos","events_url":"https://api.github.com/users/Fdall/events{/privacy}","received_events_url":"https://api.github.com/users/Fdall/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Fdall/rudder-tools","description":null,"fork":true,"url":"https://api.github.com/repos/Fdall/rudder-tools","forks_url":"https://api.github.com/repos/Fdall/rudder-tools/forks","keys_url":"https://api.github.com/repos/Fdall/rudder-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fdall/rudder-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fdall/rudder-tools/teams","hooks_url":"https://api.github.com/repos/Fdall/rudder-tools/hooks","issue_events_url":"https://api.github.com/repos/Fdall/rudder-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Fdall/rudder-tools/events","assignees_url":"https://api.github.com/repos/Fdall/rudder-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Fdall/rudder-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Fdall/rudder-tools/tags","blobs_url":"https://api.github.com/repos/Fdall/rudder-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fdall/rudder-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fdall/rudder-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fdall/rudder-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fdall/rudder-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Fdall/rudder-tools/languages","stargazers_url":"https://api.github.com/repos/Fdall/rudder-tools/stargazers","contributors_url":"https://api.github.com/repos/Fdall/rudder-tools/contributors","subscribers_url":"https://api.github.com/repos/Fdall/rudder-tools/subscribers","subscription_url":"https://api.github.com/repos/Fdall/rudder-tools/subscription","commits_url":"https://api.github.com/repos/Fdall/rudder-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fdall/rudder-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fdall/rudder-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fdall/rudder-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fdall/rudder-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Fdall/rudder-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fdall/rudder-tools/merges","archive_url":"https://api.github.com/repos/Fdall/rudder-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fdall/rudder-tools/downloads","issues_url":"https://api.github.com/repos/Fdall/rudder-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Fdall/rudder-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Fdall/rudder-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Fdall/rudder-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fdall/rudder-tools/labels{/name}","releases_url":"https://api.github.com/repos/Fdall/rudder-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Fdall/rudder-tools/deployments","created_at":"2018-08-17T10:11:40Z","updated_at":"2018-08-17T10:11:42Z","pushed_at":"2018-11-27T11:33:40Z","git_url":"git://github.com/Fdall/rudder-tools.git","ssh_url":"git@github.com:Fdall/rudder-tools.git","clone_url":"https://github.com/Fdall/rudder-tools.git","svn_url":"https://github.com/Fdall/rudder-tools","homepage":"http://www.rudder-project.org","size":2935,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Normation:master","ref":"master","sha":"f7435c9bac9bd9e11568fb57dbd8c3729e92d466","user":{"login":"Normation","id":695105,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTEwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695105?v=4","gravatar_id":"","url":"https://api.github.com/users/Normation","html_url":"https://github.com/Normation","followers_url":"https://api.github.com/users/Normation/followers","following_url":"https://api.github.com/users/Normation/following{/other_user}","gists_url":"https://api.github.com/users/Normation/gists{/gist_id}","starred_url":"https://api.github.com/users/Normation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Normation/subscriptions","organizations_url":"https://api.github.com/users/Normation/orgs","repos_url":"https://api.github.com/users/Normation/repos","events_url":"https://api.github.com/users/Normation/events{/privacy}","received_events_url":"https://api.github.com/users/Normation/received_events","type":"Organization","site_admin":false},"repo":{"id":12704466,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcwNDQ2Ng==","name":"rudder-tools","full_name":"Normation/rudder-tools","private":false,"owner":{"login":"Normation","id":695105,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTEwNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695105?v=4","gravatar_id":"","url":"https://api.github.com/users/Normation","html_url":"https://github.com/Normation","followers_url":"https://api.github.com/users/Normation/followers","following_url":"https://api.github.com/users/Normation/following{/other_user}","gists_url":"https://api.github.com/users/Normation/gists{/gist_id}","starred_url":"https://api.github.com/users/Normation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Normation/subscriptions","organizations_url":"https://api.github.com/users/Normation/orgs","repos_url":"https://api.github.com/users/Normation/repos","events_url":"https://api.github.com/users/Normation/events{/privacy}","received_events_url":"https://api.github.com/users/Normation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Normation/rudder-tools","description":null,"fork":false,"url":"https://api.github.com/repos/Normation/rudder-tools","forks_url":"https://api.github.com/repos/Normation/rudder-tools/forks","keys_url":"https://api.github.com/repos/Normation/rudder-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Normation/rudder-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Normation/rudder-tools/teams","hooks_url":"https://api.github.com/repos/Normation/rudder-tools/hooks","issue_events_url":"https://api.github.com/repos/Normation/rudder-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Normation/rudder-tools/events","assignees_url":"https://api.github.com/repos/Normation/rudder-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Normation/rudder-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Normation/rudder-tools/tags","blobs_url":"https://api.github.com/repos/Normation/rudder-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Normation/rudder-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Normation/rudder-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Normation/rudder-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Normation/rudder-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Normation/rudder-tools/languages","stargazers_url":"https://api.github.com/repos/Normation/rudder-tools/stargazers","contributors_url":"https://api.github.com/repos/Normation/rudder-tools/contributors","subscribers_url":"https://api.github.com/repos/Normation/rudder-tools/subscribers","subscription_url":"https://api.github.com/repos/Normation/rudder-tools/subscription","commits_url":"https://api.github.com/repos/Normation/rudder-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Normation/rudder-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Normation/rudder-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Normation/rudder-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Normation/rudder-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Normation/rudder-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Normation/rudder-tools/merges","archive_url":"https://api.github.com/repos/Normation/rudder-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Normation/rudder-tools/downloads","issues_url":"https://api.github.com/repos/Normation/rudder-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Normation/rudder-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Normation/rudder-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Normation/rudder-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Normation/rudder-tools/labels{/name}","releases_url":"https://api.github.com/repos/Normation/rudder-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Normation/rudder-tools/deployments","created_at":"2013-09-09T15:04:47Z","updated_at":"2018-11-27T11:18:50Z","pushed_at":"2018-11-27T11:33:42Z","git_url":"git://github.com/Normation/rudder-tools.git","ssh_url":"git@github.com:Normation/rudder-tools.git","clone_url":"https://github.com/Normation/rudder-tools.git","svn_url":"https://github.com/Normation/rudder-tools","homepage":"http://www.rudder-project.org","size":2933,"stargazers_count":6,"watchers_count":6,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":17,"open_issues":2,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Normation/rudder-tools/pulls/438"},"html":{"href":"https://github.com/Normation/rudder-tools/pull/438"},"issue":{"href":"https://api.github.com/repos/Normation/rudder-tools/issues/438"},"comments":{"href":"https://api.github.com/repos/Normation/rudder-tools/issues/438/comments"},"review_comments":{"href":"https://api.github.com/repos/Normation/rudder-tools/pulls/438/comments"},"review_comment":{"href":"https://api.github.com/repos/Normation/rudder-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Normation/rudder-tools/pulls/438/commits"},"statuses":{"href":"https://api.github.com/repos/Normation/rudder-tools/statuses/b6368b9a6bff48e2998b9cd8680535b4447eb89b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"amousset"}}