{"push_id":3149746033,"size":1,"distinct_size":1,"ref":"refs/heads/master-2.6","head":"29e5315c58bc45ba9dab462d86f8af51057c3a86","before":"d0c1069fb105bfc2409e5626a844c765b81f8e18","commits":[{"sha":"29e5315c58bc45ba9dab462d86f8af51057c3a86","author":{"name":"Guy Harris","email":"b5cd271b521acc9a180d5ff625e8f9a71c235729@alum.mit.edu"},"message":"Clean up exp_pdu_open() API.\n\nIt really shouldn't free the comment passed to it, as the caller\nallocated it, and knows how to free it if necessary; it might not even\nhave been allocated.\n\nMake the comment argument a \"const char *\" to 1) allow passing string\nconstants etc. and 2) to catch any attempts to free it in\nexp_pdu_open().\n\nMake the callers free it after exp_pdu_open() returns.\n\n(Alternatively, we could have exp_pdu_open() take the file name argument\nand generate the comment itself, so that all code paths generate the\nsame comment.)\n\nChange-Id: I6e6924b05565761b641a6c3b4d9a2e97f4264e1b\nPing-Bug: 15365\nReviewed-on: https://code.wireshark.org/review/31105\nReviewed-by: Guy Harris <guy@alum.mit.edu>\n(cherry picked from commit 936f3ed6baf7bcc5891ad8dbbcf7a213a264d20d)\nReviewed-on: https://code.wireshark.org/review/31106","distinct":true,"url":"https://api.github.com/repos/wireshark/wireshark/commits/29e5315c58bc45ba9dab462d86f8af51057c3a86"}]}
{"actor":{"display_login":"wireshark-gerrit"}}