{"action":"created","comment":{"url":"https://api.github.com/repos/tc39/test262/pulls/comments/198512074","pull_request_review_id":132453945,"id":198512074,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODUxMjA3NA==","diff_hunk":"@@ -1,9 +1,48 @@\n // Copyright (C) 2017 Ecma International.  All rights reserved.\n // This code is governed by the BSD license found in the LICENSE file.\n /*---\n-description: |\n-    The amount of slack allowed for testing time-related Atomics methods (i.e.\n-    wait and wake). The absolute value of the difference of the observed time\n-    and the expected time must be epsilon-close.\n+description: >\n+    Collection of functions used to interact with Atomics.* operations across agent boundaries.\n ---*/\n+\n+var helper = helper || {};\n+\n+/**\n+ * The amount of slack allowed for testing time-related Atomics methods (i.e. wait and wake).\n+ * The absolute value of the difference of the observed time and the expected time must\n+ * be epsilon-close.\n+ */\n var $ATOMICS_MAX_TIME_EPSILON = 100;\n+\n+/**\n+ *\n+ * @return {String} A report sent from an agent.\n+ */\n+function getReport() {\n+  var r;\n+  while ((r = $262.agent.getReport()) == null) {\n+    $262.agent.sleep(10);\n+  }\n+  return r;\n+}\n+/**\n+ * With a given Int32Array, wait until the expected number of agents have reported themselves by\n+ * calling:\n+ *\n+ *    Atomics.add(i32a, index, 1);\n+ *\n+ * @param {Int32Array} i32a An Int32Array with a SharedArrayBuffer\n+ * @param {Number} index    The index of which all agents will report.\n+ * @param {Number} expected The number of agents that are expected to report as active.\n+ */\n+function waitUntil(i32a, index, expected) {\n+  while (Atomics.load(i32a, index) !== expected) {\n+    /* nothing */\n+  }\n+  const agents = Atomics.load(i32a, index);","path":"harness/atomicsHelper.js","position":46,"original_position":46,"commit_id":"64be6186beb588eb76f0fb7bbbde1c2d61e0698b","original_commit_id":"64be6186beb588eb76f0fb7bbbde1c2d61e0698b","user":{"login":"rwaldron","id":27985,"node_id":"MDQ6VXNlcjI3OTg1","avatar_url":"https://avatars3.githubusercontent.com/u/27985?v=4","gravatar_id":"","url":"https://api.github.com/users/rwaldron","html_url":"https://github.com/rwaldron","followers_url":"https://api.github.com/users/rwaldron/followers","following_url":"https://api.github.com/users/rwaldron/following{/other_user}","gists_url":"https://api.github.com/users/rwaldron/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaldron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaldron/subscriptions","organizations_url":"https://api.github.com/users/rwaldron/orgs","repos_url":"https://api.github.com/users/rwaldron/repos","events_url":"https://api.github.com/users/rwaldron/events{/privacy}","received_events_url":"https://api.github.com/users/rwaldron/received_events","type":"User","site_admin":false},"body":"No it's not and you're right, it could increase. I will fix this","created_at":"2018-06-27T14:17:33Z","updated_at":"2018-06-27T14:17:34Z","html_url":"https://github.com/tc39/test262/pull/1533#discussion_r198512074","pull_request_url":"https://api.github.com/repos/tc39/test262/pulls/1533","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tc39/test262/pulls/comments/198512074"},"html":{"href":"https://github.com/tc39/test262/pull/1533#discussion_r198512074"},"pull_request":{"href":"https://api.github.com/repos/tc39/test262/pulls/1533"}},"in_reply_to_id":198286182},"pull_request":{"url":"https://api.github.com/repos/tc39/test262/pulls/1533","id":184169427,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg0MTY5NDI3","html_url":"https://github.com/tc39/test262/pull/1533","diff_url":"https://github.com/tc39/test262/pull/1533.diff","patch_url":"https://github.com/tc39/test262/pull/1533.patch","issue_url":"https://api.github.com/repos/tc39/test262/issues/1533","number":1533,"state":"open","locked":false,"title":"Atomics: various corrections, nit-picking and BigInt variants","user":{"login":"rwaldron","id":27985,"node_id":"MDQ6VXNlcjI3OTg1","avatar_url":"https://avatars3.githubusercontent.com/u/27985?v=4","gravatar_id":"","url":"https://api.github.com/users/rwaldron","html_url":"https://github.com/rwaldron","followers_url":"https://api.github.com/users/rwaldron/followers","following_url":"https://api.github.com/users/rwaldron/following{/other_user}","gists_url":"https://api.github.com/users/rwaldron/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaldron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaldron/subscriptions","organizations_url":"https://api.github.com/users/rwaldron/orgs","repos_url":"https://api.github.com/users/rwaldron/repos","events_url":"https://api.github.com/users/rwaldron/events{/privacy}","received_events_url":"https://api.github.com/users/rwaldron/received_events","type":"User","site_admin":false},"body":"**DO NOT MERGE**\r\n\r\nThis is not complete, I still have to finish Atomics.wake","created_at":"2018-04-25T21:31:41Z","updated_at":"2018-06-27T14:17:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"342f67dc0f80765d18d822a4d0fe63b7da098cfd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tc39/test262/pulls/1533/commits","review_comments_url":"https://api.github.com/repos/tc39/test262/pulls/1533/comments","review_comment_url":"https://api.github.com/repos/tc39/test262/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tc39/test262/issues/1533/comments","statuses_url":"https://api.github.com/repos/tc39/test262/statuses/64be6186beb588eb76f0fb7bbbde1c2d61e0698b","head":{"label":"rwaldron:1527","ref":"1527","sha":"64be6186beb588eb76f0fb7bbbde1c2d61e0698b","user":{"login":"rwaldron","id":27985,"node_id":"MDQ6VXNlcjI3OTg1","avatar_url":"https://avatars3.githubusercontent.com/u/27985?v=4","gravatar_id":"","url":"https://api.github.com/users/rwaldron","html_url":"https://github.com/rwaldron","followers_url":"https://api.github.com/users/rwaldron/followers","following_url":"https://api.github.com/users/rwaldron/following{/other_user}","gists_url":"https://api.github.com/users/rwaldron/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaldron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaldron/subscriptions","organizations_url":"https://api.github.com/users/rwaldron/orgs","repos_url":"https://api.github.com/users/rwaldron/repos","events_url":"https://api.github.com/users/rwaldron/events{/privacy}","received_events_url":"https://api.github.com/users/rwaldron/received_events","type":"User","site_admin":false},"repo":{"id":24383868,"node_id":"MDEwOlJlcG9zaXRvcnkyNDM4Mzg2OA==","name":"test262","full_name":"rwaldron/test262","owner":{"login":"rwaldron","id":27985,"node_id":"MDQ6VXNlcjI3OTg1","avatar_url":"https://avatars3.githubusercontent.com/u/27985?v=4","gravatar_id":"","url":"https://api.github.com/users/rwaldron","html_url":"https://github.com/rwaldron","followers_url":"https://api.github.com/users/rwaldron/followers","following_url":"https://api.github.com/users/rwaldron/following{/other_user}","gists_url":"https://api.github.com/users/rwaldron/gists{/gist_id}","starred_url":"https://api.github.com/users/rwaldron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwaldron/subscriptions","organizations_url":"https://api.github.com/users/rwaldron/orgs","repos_url":"https://api.github.com/users/rwaldron/repos","events_url":"https://api.github.com/users/rwaldron/events{/privacy}","received_events_url":"https://api.github.com/users/rwaldron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwaldron/test262","description":"Official ECMAScript Conformance Test Suite","fork":true,"url":"https://api.github.com/repos/rwaldron/test262","forks_url":"https://api.github.com/repos/rwaldron/test262/forks","keys_url":"https://api.github.com/repos/rwaldron/test262/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwaldron/test262/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwaldron/test262/teams","hooks_url":"https://api.github.com/repos/rwaldron/test262/hooks","issue_events_url":"https://api.github.com/repos/rwaldron/test262/issues/events{/number}","events_url":"https://api.github.com/repos/rwaldron/test262/events","assignees_url":"https://api.github.com/repos/rwaldron/test262/assignees{/user}","branches_url":"https://api.github.com/repos/rwaldron/test262/branches{/branch}","tags_url":"https://api.github.com/repos/rwaldron/test262/tags","blobs_url":"https://api.github.com/repos/rwaldron/test262/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwaldron/test262/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwaldron/test262/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwaldron/test262/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwaldron/test262/statuses/{sha}","languages_url":"https://api.github.com/repos/rwaldron/test262/languages","stargazers_url":"https://api.github.com/repos/rwaldron/test262/stargazers","contributors_url":"https://api.github.com/repos/rwaldron/test262/contributors","subscribers_url":"https://api.github.com/repos/rwaldron/test262/subscribers","subscription_url":"https://api.github.com/repos/rwaldron/test262/subscription","commits_url":"https://api.github.com/repos/rwaldron/test262/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwaldron/test262/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwaldron/test262/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwaldron/test262/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwaldron/test262/contents/{+path}","compare_url":"https://api.github.com/repos/rwaldron/test262/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwaldron/test262/merges","archive_url":"https://api.github.com/repos/rwaldron/test262/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwaldron/test262/downloads","issues_url":"https://api.github.com/repos/rwaldron/test262/issues{/number}","pulls_url":"https://api.github.com/repos/rwaldron/test262/pulls{/number}","milestones_url":"https://api.github.com/repos/rwaldron/test262/milestones{/number}","notifications_url":"https://api.github.com/repos/rwaldron/test262/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwaldron/test262/labels{/name}","releases_url":"https://api.github.com/repos/rwaldron/test262/releases{/id}","deployments_url":"https://api.github.com/repos/rwaldron/test262/deployments","created_at":"2014-09-23T18:21:08Z","updated_at":"2017-01-20T19:24:49Z","pushed_at":"2018-06-26T19:35:13Z","git_url":"git://github.com/rwaldron/test262.git","ssh_url":"git@github.com:rwaldron/test262.git","clone_url":"https://github.com/rwaldron/test262.git","svn_url":"https://github.com/rwaldron/test262","homepage":"test262.ecmascript.org","size":68418,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tc39:master","ref":"master","sha":"a6c1d05ac4fed084fa047e4c52ab2a8c9c2a8aef","user":{"login":"tc39","id":1725583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjU1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1725583?v=4","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"repo":{"id":16147933,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE0NzkzMw==","name":"test262","full_name":"tc39/test262","owner":{"login":"tc39","id":1725583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjU1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1725583?v=4","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tc39/test262","description":"Official ECMAScript Conformance Test Suite","fork":false,"url":"https://api.github.com/repos/tc39/test262","forks_url":"https://api.github.com/repos/tc39/test262/forks","keys_url":"https://api.github.com/repos/tc39/test262/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tc39/test262/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tc39/test262/teams","hooks_url":"https://api.github.com/repos/tc39/test262/hooks","issue_events_url":"https://api.github.com/repos/tc39/test262/issues/events{/number}","events_url":"https://api.github.com/repos/tc39/test262/events","assignees_url":"https://api.github.com/repos/tc39/test262/assignees{/user}","branches_url":"https://api.github.com/repos/tc39/test262/branches{/branch}","tags_url":"https://api.github.com/repos/tc39/test262/tags","blobs_url":"https://api.github.com/repos/tc39/test262/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tc39/test262/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tc39/test262/git/refs{/sha}","trees_url":"https://api.github.com/repos/tc39/test262/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tc39/test262/statuses/{sha}","languages_url":"https://api.github.com/repos/tc39/test262/languages","stargazers_url":"https://api.github.com/repos/tc39/test262/stargazers","contributors_url":"https://api.github.com/repos/tc39/test262/contributors","subscribers_url":"https://api.github.com/repos/tc39/test262/subscribers","subscription_url":"https://api.github.com/repos/tc39/test262/subscription","commits_url":"https://api.github.com/repos/tc39/test262/commits{/sha}","git_commits_url":"https://api.github.com/repos/tc39/test262/git/commits{/sha}","comments_url":"https://api.github.com/repos/tc39/test262/comments{/number}","issue_comment_url":"https://api.github.com/repos/tc39/test262/issues/comments{/number}","contents_url":"https://api.github.com/repos/tc39/test262/contents/{+path}","compare_url":"https://api.github.com/repos/tc39/test262/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tc39/test262/merges","archive_url":"https://api.github.com/repos/tc39/test262/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tc39/test262/downloads","issues_url":"https://api.github.com/repos/tc39/test262/issues{/number}","pulls_url":"https://api.github.com/repos/tc39/test262/pulls{/number}","milestones_url":"https://api.github.com/repos/tc39/test262/milestones{/number}","notifications_url":"https://api.github.com/repos/tc39/test262/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tc39/test262/labels{/name}","releases_url":"https://api.github.com/repos/tc39/test262/releases{/id}","deployments_url":"https://api.github.com/repos/tc39/test262/deployments","created_at":"2014-01-22T18:20:05Z","updated_at":"2018-06-27T11:06:41Z","pushed_at":"2018-06-27T03:12:23Z","git_url":"git://github.com/tc39/test262.git","ssh_url":"git@github.com:tc39/test262.git","clone_url":"https://github.com/tc39/test262.git","svn_url":"https://github.com/tc39/test262","homepage":"","size":68235,"stargazers_count":813,"watchers_count":813,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":217,"mirror_url":null,"archived":false,"open_issues_count":128,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":217,"open_issues":128,"watchers":813,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tc39/test262/pulls/1533"},"html":{"href":"https://github.com/tc39/test262/pull/1533"},"issue":{"href":"https://api.github.com/repos/tc39/test262/issues/1533"},"comments":{"href":"https://api.github.com/repos/tc39/test262/issues/1533/comments"},"review_comments":{"href":"https://api.github.com/repos/tc39/test262/pulls/1533/comments"},"review_comment":{"href":"https://api.github.com/repos/tc39/test262/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tc39/test262/pulls/1533/commits"},"statuses":{"href":"https://api.github.com/repos/tc39/test262/statuses/64be6186beb588eb76f0fb7bbbde1c2d61e0698b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rwaldron"}}