{"action":"created","comment":{"url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/comments/187286118","pull_request_review_id":119033350,"id":187286118,"diff_hunk":"@@ -1,11 +1,12 @@\n /**\n  * @module @aerogearservices/core\n+ *\n+ * Module used to aggregate common functionalities for AeroGear Services SDK's\n  */\n import console from \"loglevel\";\n console.setDefaultLevel(console.levels.WARN);\n \n // Configuration parsers\n-export * from \"./configuration\";\n+export * from \"./config\";\n \n-// Native platform metrics\n-export *  from \"./metrics\";\n+export * from \"./Core\";","path":"packages/core/src/index.ts","position":15,"original_position":15,"commit_id":"e8a19c0b798f7a9764b5b79afbb3c317209b6be2","original_commit_id":"e8a19c0b798f7a9764b5b79afbb3c317209b6be2","user":{"login":"josemigallas","id":11672286,"avatar_url":"https://avatars0.githubusercontent.com/u/11672286?v=4","gravatar_id":"","url":"https://api.github.com/users/josemigallas","html_url":"https://github.com/josemigallas","followers_url":"https://api.github.com/users/josemigallas/followers","following_url":"https://api.github.com/users/josemigallas/following{/other_user}","gists_url":"https://api.github.com/users/josemigallas/gists{/gist_id}","starred_url":"https://api.github.com/users/josemigallas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josemigallas/subscriptions","organizations_url":"https://api.github.com/users/josemigallas/orgs","repos_url":"https://api.github.com/users/josemigallas/repos","events_url":"https://api.github.com/users/josemigallas/events{/privacy}","received_events_url":"https://api.github.com/users/josemigallas/received_events","type":"User","site_admin":false},"body":"I think we shouldn't export `AgsCore`, only `coreInstance`.","created_at":"2018-05-10T09:46:24Z","updated_at":"2018-05-10T09:46:24Z","html_url":"https://github.com/aerogear/aerogear-js-sdk/pull/86#discussion_r187286118","pull_request_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/86","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/comments/187286118"},"html":{"href":"https://github.com/aerogear/aerogear-js-sdk/pull/86#discussion_r187286118"},"pull_request":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/86","id":186965140,"html_url":"https://github.com/aerogear/aerogear-js-sdk/pull/86","diff_url":"https://github.com/aerogear/aerogear-js-sdk/pull/86.diff","patch_url":"https://github.com/aerogear/aerogear-js-sdk/pull/86.patch","issue_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/86","number":86,"state":"open","locked":false,"title":"Top level api for JavaScript SDK","user":{"login":"wtrocki","id":981838,"avatar_url":"https://avatars3.githubusercontent.com/u/981838?v=4","gravatar_id":"","url":"https://api.github.com/users/wtrocki","html_url":"https://github.com/wtrocki","followers_url":"https://api.github.com/users/wtrocki/followers","following_url":"https://api.github.com/users/wtrocki/following{/other_user}","gists_url":"https://api.github.com/users/wtrocki/gists{/gist_id}","starred_url":"https://api.github.com/users/wtrocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtrocki/subscriptions","organizations_url":"https://api.github.com/users/wtrocki/orgs","repos_url":"https://api.github.com/users/wtrocki/repos","events_url":"https://api.github.com/users/wtrocki/events{/privacy}","received_events_url":"https://api.github.com/users/wtrocki/received_events","type":"User","site_admin":false},"body":"## Motivation\r\n\r\nProvide seamless api that will allow to initialize configuration and services only once. Allow to initialize services behind the scenes (as required for push and metrics)\r\n\r\n## How\r\n```\r\nimport { init } from '@aerogear/app';\r\nlet mobileServiceConfig = require(\"../mobile-services.json\");\r\ninit(mobileServiceConfig);\r\n\r\n// And things will work now :)\r\n```","created_at":"2018-05-09T15:53:04Z","updated_at":"2018-05-10T09:46:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"106adf46ecbd627d0246ccacac8c88688251fe8e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"paolobueno","id":1294893,"avatar_url":"https://avatars0.githubusercontent.com/u/1294893?v=4","gravatar_id":"","url":"https://api.github.com/users/paolobueno","html_url":"https://github.com/paolobueno","followers_url":"https://api.github.com/users/paolobueno/followers","following_url":"https://api.github.com/users/paolobueno/following{/other_user}","gists_url":"https://api.github.com/users/paolobueno/gists{/gist_id}","starred_url":"https://api.github.com/users/paolobueno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paolobueno/subscriptions","organizations_url":"https://api.github.com/users/paolobueno/orgs","repos_url":"https://api.github.com/users/paolobueno/repos","events_url":"https://api.github.com/users/paolobueno/events{/privacy}","received_events_url":"https://api.github.com/users/paolobueno/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/86/commits","review_comments_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/86/comments","review_comment_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/86/comments","statuses_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/statuses/e8a19c0b798f7a9764b5b79afbb3c317209b6be2","head":{"label":"wtrocki:top-level-api","ref":"top-level-api","sha":"e8a19c0b798f7a9764b5b79afbb3c317209b6be2","user":{"login":"wtrocki","id":981838,"avatar_url":"https://avatars3.githubusercontent.com/u/981838?v=4","gravatar_id":"","url":"https://api.github.com/users/wtrocki","html_url":"https://github.com/wtrocki","followers_url":"https://api.github.com/users/wtrocki/followers","following_url":"https://api.github.com/users/wtrocki/following{/other_user}","gists_url":"https://api.github.com/users/wtrocki/gists{/gist_id}","starred_url":"https://api.github.com/users/wtrocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtrocki/subscriptions","organizations_url":"https://api.github.com/users/wtrocki/orgs","repos_url":"https://api.github.com/users/wtrocki/repos","events_url":"https://api.github.com/users/wtrocki/events{/privacy}","received_events_url":"https://api.github.com/users/wtrocki/received_events","type":"User","site_admin":false},"repo":{"id":122468664,"name":"aerogear-js-sdk","full_name":"wtrocki/aerogear-js-sdk","owner":{"login":"wtrocki","id":981838,"avatar_url":"https://avatars3.githubusercontent.com/u/981838?v=4","gravatar_id":"","url":"https://api.github.com/users/wtrocki","html_url":"https://github.com/wtrocki","followers_url":"https://api.github.com/users/wtrocki/followers","following_url":"https://api.github.com/users/wtrocki/following{/other_user}","gists_url":"https://api.github.com/users/wtrocki/gists{/gist_id}","starred_url":"https://api.github.com/users/wtrocki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wtrocki/subscriptions","organizations_url":"https://api.github.com/users/wtrocki/orgs","repos_url":"https://api.github.com/users/wtrocki/repos","events_url":"https://api.github.com/users/wtrocki/events{/privacy}","received_events_url":"https://api.github.com/users/wtrocki/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wtrocki/aerogear-js-sdk","description":"AeroGear SDK for javascript, Apache Cordova and React Native.","fork":true,"url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk","forks_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/forks","keys_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/teams","hooks_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/events","assignees_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/tags","blobs_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/languages","stargazers_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/subscription","commits_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/merges","archive_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/downloads","issues_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/wtrocki/aerogear-js-sdk/deployments","created_at":"2018-02-22T11:16:15Z","updated_at":"2018-02-22T11:16:17Z","pushed_at":"2018-05-09T16:43:06Z","git_url":"git://github.com/wtrocki/aerogear-js-sdk.git","ssh_url":"git@github.com:wtrocki/aerogear-js-sdk.git","clone_url":"https://github.com/wtrocki/aerogear-js-sdk.git","svn_url":"https://github.com/wtrocki/aerogear-js-sdk","homepage":"http://aerogear.org","size":10886,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aerogear:master","ref":"master","sha":"ff91325a44bc6a62a144b38e37fc52d949d2444e","user":{"login":"aerogear","id":954205,"avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"repo":{"id":121781914,"name":"aerogear-js-sdk","full_name":"aerogear/aerogear-js-sdk","owner":{"login":"aerogear","id":954205,"avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aerogear/aerogear-js-sdk","description":"AeroGear SDK for Java Script, Apache Cordova","fork":false,"url":"https://api.github.com/repos/aerogear/aerogear-js-sdk","forks_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/forks","keys_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/teams","hooks_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/hooks","issue_events_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/events","assignees_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/tags","blobs_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/languages","stargazers_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/stargazers","contributors_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/contributors","subscribers_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/subscribers","subscription_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/subscription","commits_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/merges","archive_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/downloads","issues_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/labels{/name}","releases_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/deployments","created_at":"2018-02-16T17:51:49Z","updated_at":"2018-05-10T09:14:02Z","pushed_at":"2018-05-10T09:14:00Z","git_url":"git://github.com/aerogear/aerogear-js-sdk.git","ssh_url":"git@github.com:aerogear/aerogear-js-sdk.git","clone_url":"https://github.com/aerogear/aerogear-js-sdk.git","svn_url":"https://github.com/aerogear/aerogear-js-sdk","homepage":"http://aerogear.org","size":10850,"stargazers_count":3,"watchers_count":3,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":16,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/86"},"html":{"href":"https://github.com/aerogear/aerogear-js-sdk/pull/86"},"issue":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/86"},"comments":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/aerogear/aerogear-js-sdk/statuses/e8a19c0b798f7a9764b5b79afbb3c317209b6be2"}},"author_association":"OWNER"}}
{"actor":{"display_login":"josemigallas"}}