{"action":"created","issue":{"url":"https://api.github.com/repos/opal/opal/issues/1796","repository_url":"https://api.github.com/repos/opal/opal","labels_url":"https://api.github.com/repos/opal/opal/issues/1796/labels{/name}","comments_url":"https://api.github.com/repos/opal/opal/issues/1796/comments","events_url":"https://api.github.com/repos/opal/opal/issues/1796/events","html_url":"https://github.com/opal/opal/pull/1796","id":309264386,"number":1796,"title":"don't substitute . in regexp source","user":{"login":"mojavelinux","id":79351,"avatar_url":"https://avatars2.githubusercontent.com/u/79351?v=4","gravatar_id":"","url":"https://api.github.com/users/mojavelinux","html_url":"https://github.com/mojavelinux","followers_url":"https://api.github.com/users/mojavelinux/followers","following_url":"https://api.github.com/users/mojavelinux/following{/other_user}","gists_url":"https://api.github.com/users/mojavelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/mojavelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojavelinux/subscriptions","organizations_url":"https://api.github.com/users/mojavelinux/orgs","repos_url":"https://api.github.com/users/mojavelinux/repos","events_url":"https://api.github.com/users/mojavelinux/events{/privacy}","received_events_url":"https://api.github.com/users/mojavelinux/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-28T08:17:47Z","updated_at":"2018-03-29T05:13:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/opal/opal/pulls/1796","html_url":"https://github.com/opal/opal/pull/1796","diff_url":"https://github.com/opal/opal/pull/1796.diff","patch_url":"https://github.com/opal/opal/pull/1796.patch"},"body":"It's dangerous to blindly replace `.` (dot) with `[\\s\\S]` in the regexp source. For example, if a dot appears inside a character group (e.g., `[.]`), Opal will cause the regular expression to break.\r\n\r\nThe onus should be on the library author to use `[\\s\\S]` in place of `.` when writing multi-line regular expressions as this syntax is already portable between Ruby and JavaScript. Opal should not try to do surgery on the regular expression."},"comment":{"url":"https://api.github.com/repos/opal/opal/issues/comments/377123885","html_url":"https://github.com/opal/opal/pull/1796#issuecomment-377123885","issue_url":"https://api.github.com/repos/opal/opal/issues/1796","id":377123885,"user":{"login":"mojavelinux","id":79351,"avatar_url":"https://avatars2.githubusercontent.com/u/79351?v=4","gravatar_id":"","url":"https://api.github.com/users/mojavelinux","html_url":"https://github.com/mojavelinux","followers_url":"https://api.github.com/users/mojavelinux/followers","following_url":"https://api.github.com/users/mojavelinux/following{/other_user}","gists_url":"https://api.github.com/users/mojavelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/mojavelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojavelinux/subscriptions","organizations_url":"https://api.github.com/users/mojavelinux/orgs","repos_url":"https://api.github.com/users/mojavelinux/repos","events_url":"https://api.github.com/users/mojavelinux/events{/privacy}","received_events_url":"https://api.github.com/users/mojavelinux/received_events","type":"User","site_admin":false},"created_at":"2018-03-29T05:13:39Z","updated_at":"2018-03-29T05:13:39Z","author_association":"CONTRIBUTOR","body":"I agree it's a breaking change, but I'd say not breaking the original regular expression is more important than breaking a hack that should never have been added in the first place.\r\n\r\nI'll gladly add a CHANGELOG entry to the PR."}}
{"actor":{"display_login":"mojavelinux"}}