{"action":"created","comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/178484875","pull_request_review_id":108546072,"id":178484875,"diff_hunk":"@@ -0,0 +1,10 @@\n+const merge = require('webpack-merge');\n+const common = require('./webpack-main.config.js');\n+\n+module.exports = merge(common, {\n+    mode: 'production',\n+    devtool: 'source-map',","path":"webpack-main-prod.config.js","position":6,"original_position":6,"commit_id":"346bcfc3e57eb2bc6e3bef0394b7cbc1e7b1d2e6","original_commit_id":"346bcfc3e57eb2bc6e3bef0394b7cbc1e7b1d2e6","user":{"login":"Crphang","id":4986717,"avatar_url":"https://avatars3.githubusercontent.com/u/4986717?v=4","gravatar_id":"","url":"https://api.github.com/users/Crphang","html_url":"https://github.com/Crphang","followers_url":"https://api.github.com/users/Crphang/followers","following_url":"https://api.github.com/users/Crphang/following{/other_user}","gists_url":"https://api.github.com/users/Crphang/gists{/gist_id}","starred_url":"https://api.github.com/users/Crphang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crphang/subscriptions","organizations_url":"https://api.github.com/users/Crphang/orgs","repos_url":"https://api.github.com/users/Crphang/repos","events_url":"https://api.github.com/users/Crphang/events{/privacy}","received_events_url":"https://api.github.com/users/Crphang/received_events","type":"User","site_admin":false},"body":"If there is javascript bug on live, having a source-map would help to identify the error much quicker? Initially my concern was that this exposes the source code, but TEAMMATES is an open sourced project.\r\n\r\nIn terms of performance, I think full `source-map` is okay for production build because we only run it once.","created_at":"2018-04-02T04:08:37Z","updated_at":"2018-04-02T04:08:38Z","html_url":"https://github.com/TEAMMATES/teammates/pull/8743#discussion_r178484875","pull_request_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8743","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/178484875"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/8743#discussion_r178484875"},"pull_request":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8743"}},"in_reply_to_id":178463691},"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8743","id":178724534,"html_url":"https://github.com/TEAMMATES/teammates/pull/8743","diff_url":"https://github.com/TEAMMATES/teammates/pull/8743.diff","patch_url":"https://github.com/TEAMMATES/teammates/pull/8743.patch","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8743","number":8743,"state":"open","locked":false,"title":"Webpack: Refactor config to support development and production environment. Add Sourcemap Dev Tool. #8716","user":{"login":"Crphang","id":4986717,"avatar_url":"https://avatars3.githubusercontent.com/u/4986717?v=4","gravatar_id":"","url":"https://api.github.com/users/Crphang","html_url":"https://github.com/Crphang","followers_url":"https://api.github.com/users/Crphang/followers","following_url":"https://api.github.com/users/Crphang/following{/other_user}","gists_url":"https://api.github.com/users/Crphang/gists{/gist_id}","starred_url":"https://api.github.com/users/Crphang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crphang/subscriptions","organizations_url":"https://api.github.com/users/Crphang/orgs","repos_url":"https://api.github.com/users/Crphang/repos","events_url":"https://api.github.com/users/Crphang/events{/privacy}","received_events_url":"https://api.github.com/users/Crphang/received_events","type":"User","site_admin":false},"body":"Fixes #8716 \r\n\r\n**Outline of Solution**\r\n\r\n- [X] Refactor code between Development and Production\r\n- [X] Add source map for development\r\n- [x] Change documentation for new webpack dev command.","created_at":"2018-04-01T11:16:06Z","updated_at":"2018-04-02T04:08:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf1ed9eabb714477260638d58ce023d5b2c4661d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":98049507,"url":"https://api.github.com/repos/TEAMMATES/teammates/labels/s.Ongoing","name":"s.Ongoing","color":"6BC471","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8743/commits","review_comments_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8743/comments","review_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8743/comments","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/346bcfc3e57eb2bc6e3bef0394b7cbc1e7b1d2e6","head":{"label":"Crphang:8716-refactor-webpack-config","ref":"8716-refactor-webpack-config","sha":"346bcfc3e57eb2bc6e3bef0394b7cbc1e7b1d2e6","user":{"login":"Crphang","id":4986717,"avatar_url":"https://avatars3.githubusercontent.com/u/4986717?v=4","gravatar_id":"","url":"https://api.github.com/users/Crphang","html_url":"https://github.com/Crphang","followers_url":"https://api.github.com/users/Crphang/followers","following_url":"https://api.github.com/users/Crphang/following{/other_user}","gists_url":"https://api.github.com/users/Crphang/gists{/gist_id}","starred_url":"https://api.github.com/users/Crphang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crphang/subscriptions","organizations_url":"https://api.github.com/users/Crphang/orgs","repos_url":"https://api.github.com/users/Crphang/repos","events_url":"https://api.github.com/users/Crphang/events{/privacy}","received_events_url":"https://api.github.com/users/Crphang/received_events","type":"User","site_admin":false},"repo":{"id":115333322,"name":"teammates","full_name":"Crphang/teammates","owner":{"login":"Crphang","id":4986717,"avatar_url":"https://avatars3.githubusercontent.com/u/4986717?v=4","gravatar_id":"","url":"https://api.github.com/users/Crphang","html_url":"https://github.com/Crphang","followers_url":"https://api.github.com/users/Crphang/followers","following_url":"https://api.github.com/users/Crphang/following{/other_user}","gists_url":"https://api.github.com/users/Crphang/gists{/gist_id}","starred_url":"https://api.github.com/users/Crphang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crphang/subscriptions","organizations_url":"https://api.github.com/users/Crphang/orgs","repos_url":"https://api.github.com/users/Crphang/repos","events_url":"https://api.github.com/users/Crphang/events{/privacy}","received_events_url":"https://api.github.com/users/Crphang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Crphang/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":true,"url":"https://api.github.com/repos/Crphang/teammates","forks_url":"https://api.github.com/repos/Crphang/teammates/forks","keys_url":"https://api.github.com/repos/Crphang/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Crphang/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Crphang/teammates/teams","hooks_url":"https://api.github.com/repos/Crphang/teammates/hooks","issue_events_url":"https://api.github.com/repos/Crphang/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/Crphang/teammates/events","assignees_url":"https://api.github.com/repos/Crphang/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/Crphang/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/Crphang/teammates/tags","blobs_url":"https://api.github.com/repos/Crphang/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Crphang/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Crphang/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/Crphang/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Crphang/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/Crphang/teammates/languages","stargazers_url":"https://api.github.com/repos/Crphang/teammates/stargazers","contributors_url":"https://api.github.com/repos/Crphang/teammates/contributors","subscribers_url":"https://api.github.com/repos/Crphang/teammates/subscribers","subscription_url":"https://api.github.com/repos/Crphang/teammates/subscription","commits_url":"https://api.github.com/repos/Crphang/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/Crphang/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/Crphang/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/Crphang/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/Crphang/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/Crphang/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Crphang/teammates/merges","archive_url":"https://api.github.com/repos/Crphang/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Crphang/teammates/downloads","issues_url":"https://api.github.com/repos/Crphang/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/Crphang/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/Crphang/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/Crphang/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Crphang/teammates/labels{/name}","releases_url":"https://api.github.com/repos/Crphang/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/Crphang/teammates/deployments","created_at":"2017-12-25T11:38:19Z","updated_at":"2017-12-25T11:38:26Z","pushed_at":"2018-04-01T14:22:14Z","git_url":"git://github.com/Crphang/teammates.git","ssh_url":"git@github.com:Crphang/teammates.git","clone_url":"https://github.com/Crphang/teammates.git","svn_url":"https://github.com/Crphang/teammates","homepage":"https://teammatesv4.appspot.com/","size":196323,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TEAMMATES:master","ref":"master","sha":"76ab9a02fb1c42b93e50adaf62ebeb59338a75cf","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars2.githubusercontent.com/u/7374810?v=4","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"teammates","full_name":"TEAMMATES/teammates","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars2.githubusercontent.com/u/7374810?v=4","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/teammates","forks_url":"https://api.github.com/repos/TEAMMATES/teammates/forks","keys_url":"https://api.github.com/repos/TEAMMATES/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/teammates/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/teammates/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/teammates/events","assignees_url":"https://api.github.com/repos/TEAMMATES/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/teammates/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/teammates/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/teammates/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/teammates/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/teammates/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/teammates/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/teammates/merges","archive_url":"https://api.github.com/repos/TEAMMATES/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/teammates/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/TEAMMATES/teammates/deployments","created_at":"2014-05-02T07:43:00Z","updated_at":"2018-04-01T18:20:20Z","pushed_at":"2018-04-02T04:03:31Z","git_url":"git://github.com/TEAMMATES/teammates.git","ssh_url":"git@github.com:TEAMMATES/teammates.git","clone_url":"https://github.com/TEAMMATES/teammates.git","svn_url":"https://github.com/TEAMMATES/teammates","homepage":"https://teammatesv4.appspot.com/","size":197384,"stargazers_count":579,"watchers_count":579,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1353,"mirror_url":null,"archived":false,"open_issues_count":296,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":1353,"open_issues":296,"watchers":579,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8743"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/8743"},"issue":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/8743"},"comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/8743/comments"},"review_comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8743/comments"},"review_comment":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8743/commits"},"statuses":{"href":"https://api.github.com/repos/TEAMMATES/teammates/statuses/346bcfc3e57eb2bc6e3bef0394b7cbc1e7b1d2e6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Crphang"}}