{"action":"created","comment":{"url":"https://api.github.com/repos/nori-dot-eco/contracts/pulls/comments/203083063","pull_request_review_id":137903820,"id":203083063,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzA4MzA2Mw==","diff_hunk":"@@ -1,5 +1,6 @@\n-module.exports = function deploy(deployer) {\n+module.exports = function deploy(deployer, network) {\n   deployer.then(async () => {\n+    global.network = network;","path":"migrations/0_initial_migration.js","position":4,"original_position":4,"commit_id":"0011fbd0f99dc2845808d6d972a190f1a389945f","original_commit_id":"0011fbd0f99dc2845808d6d972a190f1a389945f","user":{"login":"pcardune","id":124827,"node_id":"MDQ6VXNlcjEyNDgyNw==","avatar_url":"https://avatars1.githubusercontent.com/u/124827?v=4","gravatar_id":"","url":"https://api.github.com/users/pcardune","html_url":"https://github.com/pcardune","followers_url":"https://api.github.com/users/pcardune/followers","following_url":"https://api.github.com/users/pcardune/following{/other_user}","gists_url":"https://api.github.com/users/pcardune/gists{/gist_id}","starred_url":"https://api.github.com/users/pcardune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcardune/subscriptions","organizations_url":"https://api.github.com/users/pcardune/orgs","repos_url":"https://api.github.com/users/pcardune/repos","events_url":"https://api.github.com/users/pcardune/events{/privacy}","received_events_url":"https://api.github.com/users/pcardune/received_events","type":"User","site_admin":false},"body":"Is adding this global really necessary? I don't see where it gets used. If it really is necessary, please add a comment on the line above explaining why and where it gets used.","created_at":"2018-07-17T16:05:07Z","updated_at":"2018-07-17T16:14:27Z","html_url":"https://github.com/nori-dot-eco/contracts/pull/54#discussion_r203083063","pull_request_url":"https://api.github.com/repos/nori-dot-eco/contracts/pulls/54","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nori-dot-eco/contracts/pulls/comments/203083063"},"html":{"href":"https://github.com/nori-dot-eco/contracts/pull/54#discussion_r203083063"},"pull_request":{"href":"https://api.github.com/repos/nori-dot-eco/contracts/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/nori-dot-eco/contracts/pulls/54","id":201434031,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDM0MDMx","html_url":"https://github.com/nori-dot-eco/contracts/pull/54","diff_url":"https://github.com/nori-dot-eco/contracts/pull/54.diff","patch_url":"https://github.com/nori-dot-eco/contracts/pull/54.patch","issue_url":"https://api.github.com/repos/nori-dot-eco/contracts/issues/54","number":54,"state":"open","locked":false,"title":"add helpers to more closely mock test env to prod env","user":{"login":"jaycenhorton","id":18407013,"node_id":"MDQ6VXNlcjE4NDA3MDEz","avatar_url":"https://avatars0.githubusercontent.com/u/18407013?v=4","gravatar_id":"","url":"https://api.github.com/users/jaycenhorton","html_url":"https://github.com/jaycenhorton","followers_url":"https://api.github.com/users/jaycenhorton/followers","following_url":"https://api.github.com/users/jaycenhorton/following{/other_user}","gists_url":"https://api.github.com/users/jaycenhorton/gists{/gist_id}","starred_url":"https://api.github.com/users/jaycenhorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaycenhorton/subscriptions","organizations_url":"https://api.github.com/users/jaycenhorton/orgs","repos_url":"https://api.github.com/users/jaycenhorton/repos","events_url":"https://api.github.com/users/jaycenhorton/events{/privacy}","received_events_url":"https://api.github.com/users/jaycenhorton/received_events","type":"User","site_admin":false},"body":"Adds a couple test helpers so that I can more closely mock a real environment when writing tests. These are consumed in a subsequent pr that contains contracts and tests for new fifo/crc functions to get sale totals","created_at":"2018-07-14T03:39:11Z","updated_at":"2018-07-17T16:14:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d11d056c1688fbff601473331275960c3a83b2d7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nori-dot-eco/contracts/pulls/54/commits","review_comments_url":"https://api.github.com/repos/nori-dot-eco/contracts/pulls/54/comments","review_comment_url":"https://api.github.com/repos/nori-dot-eco/contracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nori-dot-eco/contracts/issues/54/comments","statuses_url":"https://api.github.com/repos/nori-dot-eco/contracts/statuses/0011fbd0f99dc2845808d6d972a190f1a389945f","head":{"label":"nori-dot-eco:jaycen-test-helpers","ref":"jaycen-test-helpers","sha":"0011fbd0f99dc2845808d6d972a190f1a389945f","user":{"login":"nori-dot-eco","id":33469574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNDY5NTc0","avatar_url":"https://avatars1.githubusercontent.com/u/33469574?v=4","gravatar_id":"","url":"https://api.github.com/users/nori-dot-eco","html_url":"https://github.com/nori-dot-eco","followers_url":"https://api.github.com/users/nori-dot-eco/followers","following_url":"https://api.github.com/users/nori-dot-eco/following{/other_user}","gists_url":"https://api.github.com/users/nori-dot-eco/gists{/gist_id}","starred_url":"https://api.github.com/users/nori-dot-eco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nori-dot-eco/subscriptions","organizations_url":"https://api.github.com/users/nori-dot-eco/orgs","repos_url":"https://api.github.com/users/nori-dot-eco/repos","events_url":"https://api.github.com/users/nori-dot-eco/events{/privacy}","received_events_url":"https://api.github.com/users/nori-dot-eco/received_events","type":"Organization","site_admin":false},"repo":{"id":138190130,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxOTAxMzA=","name":"contracts","full_name":"nori-dot-eco/contracts","owner":{"login":"nori-dot-eco","id":33469574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNDY5NTc0","avatar_url":"https://avatars1.githubusercontent.com/u/33469574?v=4","gravatar_id":"","url":"https://api.github.com/users/nori-dot-eco","html_url":"https://github.com/nori-dot-eco","followers_url":"https://api.github.com/users/nori-dot-eco/followers","following_url":"https://api.github.com/users/nori-dot-eco/following{/other_user}","gists_url":"https://api.github.com/users/nori-dot-eco/gists{/gist_id}","starred_url":"https://api.github.com/users/nori-dot-eco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nori-dot-eco/subscriptions","organizations_url":"https://api.github.com/users/nori-dot-eco/orgs","repos_url":"https://api.github.com/users/nori-dot-eco/repos","events_url":"https://api.github.com/users/nori-dot-eco/events{/privacy}","received_events_url":"https://api.github.com/users/nori-dot-eco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nori-dot-eco/contracts","description":"The ethereum smart contracts that power nori.com","fork":false,"url":"https://api.github.com/repos/nori-dot-eco/contracts","forks_url":"https://api.github.com/repos/nori-dot-eco/contracts/forks","keys_url":"https://api.github.com/repos/nori-dot-eco/contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nori-dot-eco/contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nori-dot-eco/contracts/teams","hooks_url":"https://api.github.com/repos/nori-dot-eco/contracts/hooks","issue_events_url":"https://api.github.com/repos/nori-dot-eco/contracts/issues/events{/number}","events_url":"https://api.github.com/repos/nori-dot-eco/contracts/events","assignees_url":"https://api.github.com/repos/nori-dot-eco/contracts/assignees{/user}","branches_url":"https://api.github.com/repos/nori-dot-eco/contracts/branches{/branch}","tags_url":"https://api.github.com/repos/nori-dot-eco/contracts/tags","blobs_url":"https://api.github.com/repos/nori-dot-eco/contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nori-dot-eco/contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nori-dot-eco/contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/nori-dot-eco/contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nori-dot-eco/contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/nori-dot-eco/contracts/languages","stargazers_url":"https://api.github.com/repos/nori-dot-eco/contracts/stargazers","contributors_url":"https://api.github.com/repos/nori-dot-eco/contracts/contributors","subscribers_url":"https://api.github.com/repos/nori-dot-eco/contracts/subscribers","subscription_url":"https://api.github.com/repos/nori-dot-eco/contracts/subscription","commits_url":"https://api.github.com/repos/nori-dot-eco/contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/nori-dot-eco/contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/nori-dot-eco/contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/nori-dot-eco/contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/nori-dot-eco/contracts/contents/{+path}","compare_url":"https://api.github.com/repos/nori-dot-eco/contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nori-dot-eco/contracts/merges","archive_url":"https://api.github.com/repos/nori-dot-eco/contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nori-dot-eco/contracts/downloads","issues_url":"https://api.github.com/repos/nori-dot-eco/contracts/issues{/number}","pulls_url":"https://api.github.com/repos/nori-dot-eco/contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/nori-dot-eco/contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/nori-dot-eco/contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nori-dot-eco/contracts/labels{/name}","releases_url":"https://api.github.com/repos/nori-dot-eco/contracts/releases{/id}","deployments_url":"https://api.github.com/repos/nori-dot-eco/contracts/deployments","created_at":"2018-06-21T15:37:55Z","updated_at":"2018-07-13T19:43:56Z","pushed_at":"2018-07-17T06:13:54Z","git_url":"git://github.com/nori-dot-eco/contracts.git","ssh_url":"git@github.com:nori-dot-eco/contracts.git","clone_url":"https://github.com/nori-dot-eco/contracts.git","svn_url":"https://github.com/nori-dot-eco/contracts","homepage":null,"size":383,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"nori-dot-eco:master","ref":"master","sha":"1606a9e53278560bf789ff79f095e3066e113de5","user":{"login":"nori-dot-eco","id":33469574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNDY5NTc0","avatar_url":"https://avatars1.githubusercontent.com/u/33469574?v=4","gravatar_id":"","url":"https://api.github.com/users/nori-dot-eco","html_url":"https://github.com/nori-dot-eco","followers_url":"https://api.github.com/users/nori-dot-eco/followers","following_url":"https://api.github.com/users/nori-dot-eco/following{/other_user}","gists_url":"https://api.github.com/users/nori-dot-eco/gists{/gist_id}","starred_url":"https://api.github.com/users/nori-dot-eco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nori-dot-eco/subscriptions","organizations_url":"https://api.github.com/users/nori-dot-eco/orgs","repos_url":"https://api.github.com/users/nori-dot-eco/repos","events_url":"https://api.github.com/users/nori-dot-eco/events{/privacy}","received_events_url":"https://api.github.com/users/nori-dot-eco/received_events","type":"Organization","site_admin":false},"repo":{"id":138190130,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxOTAxMzA=","name":"contracts","full_name":"nori-dot-eco/contracts","owner":{"login":"nori-dot-eco","id":33469574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNDY5NTc0","avatar_url":"https://avatars1.githubusercontent.com/u/33469574?v=4","gravatar_id":"","url":"https://api.github.com/users/nori-dot-eco","html_url":"https://github.com/nori-dot-eco","followers_url":"https://api.github.com/users/nori-dot-eco/followers","following_url":"https://api.github.com/users/nori-dot-eco/following{/other_user}","gists_url":"https://api.github.com/users/nori-dot-eco/gists{/gist_id}","starred_url":"https://api.github.com/users/nori-dot-eco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nori-dot-eco/subscriptions","organizations_url":"https://api.github.com/users/nori-dot-eco/orgs","repos_url":"https://api.github.com/users/nori-dot-eco/repos","events_url":"https://api.github.com/users/nori-dot-eco/events{/privacy}","received_events_url":"https://api.github.com/users/nori-dot-eco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nori-dot-eco/contracts","description":"The ethereum smart contracts that power nori.com","fork":false,"url":"https://api.github.com/repos/nori-dot-eco/contracts","forks_url":"https://api.github.com/repos/nori-dot-eco/contracts/forks","keys_url":"https://api.github.com/repos/nori-dot-eco/contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nori-dot-eco/contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nori-dot-eco/contracts/teams","hooks_url":"https://api.github.com/repos/nori-dot-eco/contracts/hooks","issue_events_url":"https://api.github.com/repos/nori-dot-eco/contracts/issues/events{/number}","events_url":"https://api.github.com/repos/nori-dot-eco/contracts/events","assignees_url":"https://api.github.com/repos/nori-dot-eco/contracts/assignees{/user}","branches_url":"https://api.github.com/repos/nori-dot-eco/contracts/branches{/branch}","tags_url":"https://api.github.com/repos/nori-dot-eco/contracts/tags","blobs_url":"https://api.github.com/repos/nori-dot-eco/contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nori-dot-eco/contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nori-dot-eco/contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/nori-dot-eco/contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nori-dot-eco/contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/nori-dot-eco/contracts/languages","stargazers_url":"https://api.github.com/repos/nori-dot-eco/contracts/stargazers","contributors_url":"https://api.github.com/repos/nori-dot-eco/contracts/contributors","subscribers_url":"https://api.github.com/repos/nori-dot-eco/contracts/subscribers","subscription_url":"https://api.github.com/repos/nori-dot-eco/contracts/subscription","commits_url":"https://api.github.com/repos/nori-dot-eco/contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/nori-dot-eco/contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/nori-dot-eco/contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/nori-dot-eco/contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/nori-dot-eco/contracts/contents/{+path}","compare_url":"https://api.github.com/repos/nori-dot-eco/contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nori-dot-eco/contracts/merges","archive_url":"https://api.github.com/repos/nori-dot-eco/contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nori-dot-eco/contracts/downloads","issues_url":"https://api.github.com/repos/nori-dot-eco/contracts/issues{/number}","pulls_url":"https://api.github.com/repos/nori-dot-eco/contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/nori-dot-eco/contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/nori-dot-eco/contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nori-dot-eco/contracts/labels{/name}","releases_url":"https://api.github.com/repos/nori-dot-eco/contracts/releases{/id}","deployments_url":"https://api.github.com/repos/nori-dot-eco/contracts/deployments","created_at":"2018-06-21T15:37:55Z","updated_at":"2018-07-13T19:43:56Z","pushed_at":"2018-07-17T06:13:54Z","git_url":"git://github.com/nori-dot-eco/contracts.git","ssh_url":"git@github.com:nori-dot-eco/contracts.git","clone_url":"https://github.com/nori-dot-eco/contracts.git","svn_url":"https://github.com/nori-dot-eco/contracts","homepage":null,"size":383,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nori-dot-eco/contracts/pulls/54"},"html":{"href":"https://github.com/nori-dot-eco/contracts/pull/54"},"issue":{"href":"https://api.github.com/repos/nori-dot-eco/contracts/issues/54"},"comments":{"href":"https://api.github.com/repos/nori-dot-eco/contracts/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/nori-dot-eco/contracts/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/nori-dot-eco/contracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nori-dot-eco/contracts/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/nori-dot-eco/contracts/statuses/0011fbd0f99dc2845808d6d972a190f1a389945f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pcardune"}}