{"action":"created","comment":{"url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/comments/245023063","pull_request_review_id":189040223,"id":245023063,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTAyMzA2Mw==","diff_hunk":"@@ -308,27 +300,30 @@ void InitCountArtificial(out ToolStripMenuItem toolStripGitStatus, out GitStatus\n                         var status = e.State;\n                         if (status == GitStatusMonitorState.Stopped)\n                         {\n-                            _toolStripGitStatus.Visible = false;\n-                            _toolStripGitStatus.Text = \"\";\n+                            toolStripButtonCommit.Enabled = false;","path":"GitUI/CommandsDialogs/FormBrowse.cs","position":46,"original_position":46,"commit_id":"6b6c9243f9f72a5dc4b33a7b711aaee99a704963","original_commit_id":"6b6c9243f9f72a5dc4b33a7b711aaee99a704963","user":{"login":"drewnoakes","id":350947,"node_id":"MDQ6VXNlcjM1MDk0Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/350947?v=4","gravatar_id":"","url":"https://api.github.com/users/drewnoakes","html_url":"https://github.com/drewnoakes","followers_url":"https://api.github.com/users/drewnoakes/followers","following_url":"https://api.github.com/users/drewnoakes/following{/other_user}","gists_url":"https://api.github.com/users/drewnoakes/gists{/gist_id}","starred_url":"https://api.github.com/users/drewnoakes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drewnoakes/subscriptions","organizations_url":"https://api.github.com/users/drewnoakes/orgs","repos_url":"https://api.github.com/users/drewnoakes/repos","events_url":"https://api.github.com/users/drewnoakes/events{/privacy}","received_events_url":"https://api.github.com/users/drewnoakes/received_events","type":"User","site_admin":false},"body":"Do we need to disable the button at any point? What can go wrong if it's clicked while the monitor's running?","created_at":"2019-01-03T14:54:33Z","updated_at":"2019-01-03T14:58:47Z","html_url":"https://github.com/gitextensions/gitextensions/pull/6020#discussion_r245023063","pull_request_url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/6020","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/comments/245023063"},"html":{"href":"https://github.com/gitextensions/gitextensions/pull/6020#discussion_r245023063"},"pull_request":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/6020"}}},"pull_request":{"url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/6020","id":241515131,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNTE1MTMx","html_url":"https://github.com/gitextensions/gitextensions/pull/6020","diff_url":"https://github.com/gitextensions/gitextensions/pull/6020.diff","patch_url":"https://github.com/gitextensions/gitextensions/pull/6020.patch","issue_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/6020","number":6020,"state":"open","locked":false,"title":"Indicate unknown commit status","user":{"login":"mstv","id":36601201,"node_id":"MDQ6VXNlcjM2NjAxMjAx","avatar_url":"https://avatars3.githubusercontent.com/u/36601201?v=4","gravatar_id":"","url":"https://api.github.com/users/mstv","html_url":"https://github.com/mstv","followers_url":"https://api.github.com/users/mstv/followers","following_url":"https://api.github.com/users/mstv/following{/other_user}","gists_url":"https://api.github.com/users/mstv/gists{/gist_id}","starred_url":"https://api.github.com/users/mstv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstv/subscriptions","organizations_url":"https://api.github.com/users/mstv/orgs","repos_url":"https://api.github.com/users/mstv/repos","events_url":"https://api.github.com/users/mstv/events{/privacy}","received_events_url":"https://api.github.com/users/mstv/received_events","type":"User","site_admin":false},"body":"Fixes #5968\r\n\r\n## Proposed changes\r\n\r\n- always show the toolbar button `Commit`\r\n- indicate unknown commit status\r\n- remove `ToolStripMenuItem _toolStripGitStatus`, always use `toolStripButtonCommit` instead\r\n- invalidate the `GitWorkingDirectoryStatus` synchronously\r\n\r\n## Screenshots\r\n\r\n### Before\r\n\r\n![grafik](https://user-images.githubusercontent.com/36601201/50314956-2354e700-04b1-11e9-9db2-67f5b88cc6f6.png)\r\n\r\n### After\r\n\r\n![grafik](https://user-images.githubusercontent.com/36601201/50552555-0f219e80-0c96-11e9-8c12-815f462ba101.png)\r\n\r\n## Test methodology\r\n\r\n- manual testing (switched repos, switched languages, hit F5)\r\n\r\n## Test environment\r\n\r\n- Git Extensions 3.01.00.0\r\n- Build 4ab496efee633ed1575f26e12300e6e238851484\r\n- Git 2.20.0.windows.1\r\n- Microsoft Windows NT 6.1.7601 Service Pack 1\r\n- .NET Framework 4.7.2117.0\r\n- DPI 96dpi (no scaling)","created_at":"2018-12-30T23:57:49Z","updated_at":"2019-01-03T14:58:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5cffe6e59beb393f6573ef9d2d655a0c81c83a56","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":125936360,"node_id":"MDU6TGFiZWwxMjU5MzYzNjA=","url":"https://api.github.com/repos/gitextensions/gitextensions/labels/status:%20needs%20review","name":"status: needs review","color":"f9812a","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/6020/commits","review_comments_url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/6020/comments","review_comment_url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/6020/comments","statuses_url":"https://api.github.com/repos/gitextensions/gitextensions/statuses/6b6c9243f9f72a5dc4b33a7b711aaee99a704963","head":{"label":"mstv:5968_commit_button","ref":"5968_commit_button","sha":"6b6c9243f9f72a5dc4b33a7b711aaee99a704963","user":{"login":"mstv","id":36601201,"node_id":"MDQ6VXNlcjM2NjAxMjAx","avatar_url":"https://avatars3.githubusercontent.com/u/36601201?v=4","gravatar_id":"","url":"https://api.github.com/users/mstv","html_url":"https://github.com/mstv","followers_url":"https://api.github.com/users/mstv/followers","following_url":"https://api.github.com/users/mstv/following{/other_user}","gists_url":"https://api.github.com/users/mstv/gists{/gist_id}","starred_url":"https://api.github.com/users/mstv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstv/subscriptions","organizations_url":"https://api.github.com/users/mstv/orgs","repos_url":"https://api.github.com/users/mstv/repos","events_url":"https://api.github.com/users/mstv/events{/privacy}","received_events_url":"https://api.github.com/users/mstv/received_events","type":"User","site_admin":false},"repo":{"id":121964208,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE5NjQyMDg=","name":"gitextensions","full_name":"mstv/gitextensions","private":false,"owner":{"login":"mstv","id":36601201,"node_id":"MDQ6VXNlcjM2NjAxMjAx","avatar_url":"https://avatars3.githubusercontent.com/u/36601201?v=4","gravatar_id":"","url":"https://api.github.com/users/mstv","html_url":"https://github.com/mstv","followers_url":"https://api.github.com/users/mstv/followers","following_url":"https://api.github.com/users/mstv/following{/other_user}","gists_url":"https://api.github.com/users/mstv/gists{/gist_id}","starred_url":"https://api.github.com/users/mstv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstv/subscriptions","organizations_url":"https://api.github.com/users/mstv/orgs","repos_url":"https://api.github.com/users/mstv/repos","events_url":"https://api.github.com/users/mstv/events{/privacy}","received_events_url":"https://api.github.com/users/mstv/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mstv/gitextensions","description":"Git Extensions is a standalone UI tool for managing git repositories. It also integrates with Windows Explorer and Microsoft Visual Studio (2010/2012/2013/2015/2017).","fork":true,"url":"https://api.github.com/repos/mstv/gitextensions","forks_url":"https://api.github.com/repos/mstv/gitextensions/forks","keys_url":"https://api.github.com/repos/mstv/gitextensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mstv/gitextensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mstv/gitextensions/teams","hooks_url":"https://api.github.com/repos/mstv/gitextensions/hooks","issue_events_url":"https://api.github.com/repos/mstv/gitextensions/issues/events{/number}","events_url":"https://api.github.com/repos/mstv/gitextensions/events","assignees_url":"https://api.github.com/repos/mstv/gitextensions/assignees{/user}","branches_url":"https://api.github.com/repos/mstv/gitextensions/branches{/branch}","tags_url":"https://api.github.com/repos/mstv/gitextensions/tags","blobs_url":"https://api.github.com/repos/mstv/gitextensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mstv/gitextensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mstv/gitextensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/mstv/gitextensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mstv/gitextensions/statuses/{sha}","languages_url":"https://api.github.com/repos/mstv/gitextensions/languages","stargazers_url":"https://api.github.com/repos/mstv/gitextensions/stargazers","contributors_url":"https://api.github.com/repos/mstv/gitextensions/contributors","subscribers_url":"https://api.github.com/repos/mstv/gitextensions/subscribers","subscription_url":"https://api.github.com/repos/mstv/gitextensions/subscription","commits_url":"https://api.github.com/repos/mstv/gitextensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/mstv/gitextensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/mstv/gitextensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/mstv/gitextensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/mstv/gitextensions/contents/{+path}","compare_url":"https://api.github.com/repos/mstv/gitextensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mstv/gitextensions/merges","archive_url":"https://api.github.com/repos/mstv/gitextensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mstv/gitextensions/downloads","issues_url":"https://api.github.com/repos/mstv/gitextensions/issues{/number}","pulls_url":"https://api.github.com/repos/mstv/gitextensions/pulls{/number}","milestones_url":"https://api.github.com/repos/mstv/gitextensions/milestones{/number}","notifications_url":"https://api.github.com/repos/mstv/gitextensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mstv/gitextensions/labels{/name}","releases_url":"https://api.github.com/repos/mstv/gitextensions/releases{/id}","deployments_url":"https://api.github.com/repos/mstv/gitextensions/deployments","created_at":"2018-02-18T15:32:43Z","updated_at":"2018-04-29T18:44:41Z","pushed_at":"2019-01-02T21:13:32Z","git_url":"git://github.com/mstv/gitextensions.git","ssh_url":"git@github.com:mstv/gitextensions.git","clone_url":"https://github.com/mstv/gitextensions.git","svn_url":"https://github.com/mstv/gitextensions","homepage":"http://gitextensions.github.io/","size":92521,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gitextensions:master","ref":"master","sha":"1be9b2a4c1a84d33ae011705b9b1076465696ee3","user":{"login":"gitextensions","id":1700077,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDAwNzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1700077?v=4","gravatar_id":"","url":"https://api.github.com/users/gitextensions","html_url":"https://github.com/gitextensions","followers_url":"https://api.github.com/users/gitextensions/followers","following_url":"https://api.github.com/users/gitextensions/following{/other_user}","gists_url":"https://api.github.com/users/gitextensions/gists{/gist_id}","starred_url":"https://api.github.com/users/gitextensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitextensions/subscriptions","organizations_url":"https://api.github.com/users/gitextensions/orgs","repos_url":"https://api.github.com/users/gitextensions/repos","events_url":"https://api.github.com/users/gitextensions/events{/privacy}","received_events_url":"https://api.github.com/users/gitextensions/received_events","type":"Organization","site_admin":false},"repo":{"id":85953,"node_id":"MDEwOlJlcG9zaXRvcnk4NTk1Mw==","name":"gitextensions","full_name":"gitextensions/gitextensions","private":false,"owner":{"login":"gitextensions","id":1700077,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MDAwNzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1700077?v=4","gravatar_id":"","url":"https://api.github.com/users/gitextensions","html_url":"https://github.com/gitextensions","followers_url":"https://api.github.com/users/gitextensions/followers","following_url":"https://api.github.com/users/gitextensions/following{/other_user}","gists_url":"https://api.github.com/users/gitextensions/gists{/gist_id}","starred_url":"https://api.github.com/users/gitextensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitextensions/subscriptions","organizations_url":"https://api.github.com/users/gitextensions/orgs","repos_url":"https://api.github.com/users/gitextensions/repos","events_url":"https://api.github.com/users/gitextensions/events{/privacy}","received_events_url":"https://api.github.com/users/gitextensions/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gitextensions/gitextensions","description":"Git Extensions is a standalone UI tool for managing git repositories. It also integrates with Windows Explorer and Microsoft Visual Studio (2010/2012/2013/2015/2017).","fork":false,"url":"https://api.github.com/repos/gitextensions/gitextensions","forks_url":"https://api.github.com/repos/gitextensions/gitextensions/forks","keys_url":"https://api.github.com/repos/gitextensions/gitextensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gitextensions/gitextensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gitextensions/gitextensions/teams","hooks_url":"https://api.github.com/repos/gitextensions/gitextensions/hooks","issue_events_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/events{/number}","events_url":"https://api.github.com/repos/gitextensions/gitextensions/events","assignees_url":"https://api.github.com/repos/gitextensions/gitextensions/assignees{/user}","branches_url":"https://api.github.com/repos/gitextensions/gitextensions/branches{/branch}","tags_url":"https://api.github.com/repos/gitextensions/gitextensions/tags","blobs_url":"https://api.github.com/repos/gitextensions/gitextensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gitextensions/gitextensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gitextensions/gitextensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/gitextensions/gitextensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gitextensions/gitextensions/statuses/{sha}","languages_url":"https://api.github.com/repos/gitextensions/gitextensions/languages","stargazers_url":"https://api.github.com/repos/gitextensions/gitextensions/stargazers","contributors_url":"https://api.github.com/repos/gitextensions/gitextensions/contributors","subscribers_url":"https://api.github.com/repos/gitextensions/gitextensions/subscribers","subscription_url":"https://api.github.com/repos/gitextensions/gitextensions/subscription","commits_url":"https://api.github.com/repos/gitextensions/gitextensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/gitextensions/gitextensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/gitextensions/gitextensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/gitextensions/gitextensions/contents/{+path}","compare_url":"https://api.github.com/repos/gitextensions/gitextensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gitextensions/gitextensions/merges","archive_url":"https://api.github.com/repos/gitextensions/gitextensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gitextensions/gitextensions/downloads","issues_url":"https://api.github.com/repos/gitextensions/gitextensions/issues{/number}","pulls_url":"https://api.github.com/repos/gitextensions/gitextensions/pulls{/number}","milestones_url":"https://api.github.com/repos/gitextensions/gitextensions/milestones{/number}","notifications_url":"https://api.github.com/repos/gitextensions/gitextensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gitextensions/gitextensions/labels{/name}","releases_url":"https://api.github.com/repos/gitextensions/gitextensions/releases{/id}","deployments_url":"https://api.github.com/repos/gitextensions/gitextensions/deployments","created_at":"2008-12-06T09:18:59Z","updated_at":"2019-01-03T14:49:15Z","pushed_at":"2019-01-03T12:14:36Z","git_url":"git://github.com/gitextensions/gitextensions.git","ssh_url":"git@github.com:gitextensions/gitextensions.git","clone_url":"https://github.com/gitextensions/gitextensions.git","svn_url":"https://github.com/gitextensions/gitextensions","homepage":"https://gitextensions.github.io/","size":97909,"stargazers_count":3420,"watchers_count":3420,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1133,"mirror_url":null,"archived":false,"open_issues_count":739,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1133,"open_issues":739,"watchers":3420,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/6020"},"html":{"href":"https://github.com/gitextensions/gitextensions/pull/6020"},"issue":{"href":"https://api.github.com/repos/gitextensions/gitextensions/issues/6020"},"comments":{"href":"https://api.github.com/repos/gitextensions/gitextensions/issues/6020/comments"},"review_comments":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/6020/comments"},"review_comment":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/6020/commits"},"statuses":{"href":"https://api.github.com/repos/gitextensions/gitextensions/statuses/6b6c9243f9f72a5dc4b33a7b711aaee99a704963"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"drewnoakes"}}