{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/2784","repository_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity","labels_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/2784/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/2784/comments","events_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/2784/events","html_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/2784","id":360082212,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NDI4NDA4","number":2784,"title":"[Solver PR 4] Add controller-tracking support to solvers","user":{"login":"keveleigh","id":3580640,"node_id":"MDQ6VXNlcjM1ODA2NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3580640?v=4","gravatar_id":"","url":"https://api.github.com/users/keveleigh","html_url":"https://github.com/keveleigh","followers_url":"https://api.github.com/users/keveleigh/followers","following_url":"https://api.github.com/users/keveleigh/following{/other_user}","gists_url":"https://api.github.com/users/keveleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/keveleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keveleigh/subscriptions","organizations_url":"https://api.github.com/users/keveleigh/orgs","repos_url":"https://api.github.com/users/keveleigh/repos","events_url":"https://api.github.com/users/keveleigh/events{/privacy}","received_events_url":"https://api.github.com/users/keveleigh/received_events","type":"User","site_admin":false},"labels":[{"id":850652486,"node_id":"MDU6TGFiZWw4NTA2NTI0ODY=","url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/labels/MRTK%20vNEXT","name":"MRTK vNEXT","color":"0b4ce5","default":false},{"id":769313068,"node_id":"MDU6TGFiZWw3NjkzMTMwNjg=","url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/labels/Ready%20for%20Review","name":"Ready for Review","color":"88f91d","default":false},{"id":929367119,"node_id":"MDU6TGFiZWw5MjkzNjcxMTk=","url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/labels/Solvers","name":"Solvers","color":"5ecae5","default":false}],"state":"open","locked":false,"assignee":{"login":"keveleigh","id":3580640,"node_id":"MDQ6VXNlcjM1ODA2NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3580640?v=4","gravatar_id":"","url":"https://api.github.com/users/keveleigh","html_url":"https://github.com/keveleigh","followers_url":"https://api.github.com/users/keveleigh/followers","following_url":"https://api.github.com/users/keveleigh/following{/other_user}","gists_url":"https://api.github.com/users/keveleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/keveleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keveleigh/subscriptions","organizations_url":"https://api.github.com/users/keveleigh/orgs","repos_url":"https://api.github.com/users/keveleigh/repos","events_url":"https://api.github.com/users/keveleigh/events{/privacy}","received_events_url":"https://api.github.com/users/keveleigh/received_events","type":"User","site_admin":false},"assignees":[{"login":"keveleigh","id":3580640,"node_id":"MDQ6VXNlcjM1ODA2NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3580640?v=4","gravatar_id":"","url":"https://api.github.com/users/keveleigh","html_url":"https://github.com/keveleigh","followers_url":"https://api.github.com/users/keveleigh/followers","following_url":"https://api.github.com/users/keveleigh/following{/other_user}","gists_url":"https://api.github.com/users/keveleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/keveleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keveleigh/subscriptions","organizations_url":"https://api.github.com/users/keveleigh/orgs","repos_url":"https://api.github.com/users/keveleigh/repos","events_url":"https://api.github.com/users/keveleigh/events{/privacy}","received_events_url":"https://api.github.com/users/keveleigh/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/milestones/1","html_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/milestone/1","labels_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/milestones/1/labels","id":3141032,"node_id":"MDk6TWlsZXN0b25lMzE0MTAzMg==","number":1,"title":"MRTK 2018","description":"Mixed Reality Toolkit 2018","creator":{"login":"StephenHodgson","id":13334553,"node_id":"MDQ6VXNlcjEzMzM0NTUz","avatar_url":"https://avatars2.githubusercontent.com/u/13334553?v=4","gravatar_id":"","url":"https://api.github.com/users/StephenHodgson","html_url":"https://github.com/StephenHodgson","followers_url":"https://api.github.com/users/StephenHodgson/followers","following_url":"https://api.github.com/users/StephenHodgson/following{/other_user}","gists_url":"https://api.github.com/users/StephenHodgson/gists{/gist_id}","starred_url":"https://api.github.com/users/StephenHodgson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StephenHodgson/subscriptions","organizations_url":"https://api.github.com/users/StephenHodgson/orgs","repos_url":"https://api.github.com/users/StephenHodgson/repos","events_url":"https://api.github.com/users/StephenHodgson/events{/privacy}","received_events_url":"https://api.github.com/users/StephenHodgson/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":223,"state":"open","created_at":"2018-02-24T21:08:44Z","updated_at":"2018-09-14T16:35:35Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2018-09-13T22:00:53Z","updated_at":"2018-09-14T17:18:34Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/pulls/2784","html_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/2784","diff_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/2784.diff","patch_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/2784.patch"},"body":"Overview\r\n---\r\nAdds controller finder to the solvers. Now, left and right motion controllers join the head as valid Solver targets. In order to facilitate this, I had to add the controller transform to the base MRController definition in order to expose it.\r\n\r\nThis also ports over the custom inspectors for SolverHandler and ControllerFinder.\r\n\r\nChanges\r\n---\r\nRelated to #2465\r\n\r\nRelated to #2608 (adding passive controller transforms)\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/comments/421426311","html_url":"https://github.com/Microsoft/MixedRealityToolkit-Unity/pull/2784#issuecomment-421426311","issue_url":"https://api.github.com/repos/Microsoft/MixedRealityToolkit-Unity/issues/2784","id":421426311,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTQyNjMxMQ==","user":{"login":"keveleigh","id":3580640,"node_id":"MDQ6VXNlcjM1ODA2NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/3580640?v=4","gravatar_id":"","url":"https://api.github.com/users/keveleigh","html_url":"https://github.com/keveleigh","followers_url":"https://api.github.com/users/keveleigh/followers","following_url":"https://api.github.com/users/keveleigh/following{/other_user}","gists_url":"https://api.github.com/users/keveleigh/gists{/gist_id}","starred_url":"https://api.github.com/users/keveleigh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keveleigh/subscriptions","organizations_url":"https://api.github.com/users/keveleigh/orgs","repos_url":"https://api.github.com/users/keveleigh/repos","events_url":"https://api.github.com/users/keveleigh/events{/privacy}","received_events_url":"https://api.github.com/users/keveleigh/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T17:18:34Z","updated_at":"2018-09-14T17:18:34Z","author_association":"MEMBER","body":"The \"something\" is a Transform. The controller definition already creates a GameObject/Transform when it spawns the controller model. The only change is to actually expose that model/Transform.\r\n\r\nI'm calling methods defined in the base interfaces. Not all device managers need to (or do) implement everything. If no controller representation exists, then no Transform exists, then this falls back gracefully."}}
{"actor":{"display_login":"keveleigh"}}