{"action":"created","comment":{"url":"https://api.github.com/repos/Metaswitch/slog-extlog/pulls/comments/185830575","pull_request_review_id":117298134,"id":185830575,"diff_hunk":"@@ -217,12 +222,42 @@ fn test_extloggable_setto() {\n fn basic_extloggable_grouped_by_string() {\n     let (logger, mut data) = create_logger_buffer(SLOG_TEST_STATS);\n \n-    xlog!(logger, ThirdExternalLog { name: \"bar\".to_string() });\n-    xlog!(logger, ThirdExternalLog { name: \"foo\".to_string() });\n-    xlog!(logger, ThirdExternalLog { name: \"bar\".to_string() });\n-    xlog!(logger, ThirdExternalLog { name: \"bar\".to_string() });\n-    xlog!(logger, ThirdExternalLog { name: \"bar\".to_string() });\n-    xlog!(logger, ThirdExternalLog { name: \"foo\".to_string() });\n+    xlog!(","path":"tests/stats_extlog.rs","position":24,"original_position":24,"commit_id":"90687d136e36e55b207854b4006c53515647b9ac","original_commit_id":"90687d136e36e55b207854b4006c53515647b9ac","user":{"login":"jmlMetaswitch","id":20399716,"avatar_url":"https://avatars3.githubusercontent.com/u/20399716?v=4","gravatar_id":"","url":"https://api.github.com/users/jmlMetaswitch","html_url":"https://github.com/jmlMetaswitch","followers_url":"https://api.github.com/users/jmlMetaswitch/followers","following_url":"https://api.github.com/users/jmlMetaswitch/following{/other_user}","gists_url":"https://api.github.com/users/jmlMetaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/jmlMetaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmlMetaswitch/subscriptions","organizations_url":"https://api.github.com/users/jmlMetaswitch/orgs","repos_url":"https://api.github.com/users/jmlMetaswitch/repos","events_url":"https://api.github.com/users/jmlMetaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/jmlMetaswitch/received_events","type":"User","site_admin":false},"body":"Not sure this is clearer. I assume it was forced by rustfmt? :-(","created_at":"2018-05-03T15:02:32Z","updated_at":"2018-05-03T15:03:21Z","html_url":"https://github.com/Metaswitch/slog-extlog/pull/4#discussion_r185830575","pull_request_url":"https://api.github.com/repos/Metaswitch/slog-extlog/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/slog-extlog/pulls/comments/185830575"},"html":{"href":"https://github.com/Metaswitch/slog-extlog/pull/4#discussion_r185830575"},"pull_request":{"href":"https://api.github.com/repos/Metaswitch/slog-extlog/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/Metaswitch/slog-extlog/pulls/4","id":185741107,"html_url":"https://github.com/Metaswitch/slog-extlog/pull/4","diff_url":"https://github.com/Metaswitch/slog-extlog/pull/4.diff","patch_url":"https://github.com/Metaswitch/slog-extlog/pull/4.patch","issue_url":"https://api.github.com/repos/Metaswitch/slog-extlog/issues/4","number":4,"state":"open","locked":false,"title":"Stats config changes","user":{"login":"mthebridge","id":13729669,"avatar_url":"https://avatars0.githubusercontent.com/u/13729669?v=4","gravatar_id":"","url":"https://api.github.com/users/mthebridge","html_url":"https://github.com/mthebridge","followers_url":"https://api.github.com/users/mthebridge/followers","following_url":"https://api.github.com/users/mthebridge/following{/other_user}","gists_url":"https://api.github.com/users/mthebridge/gists{/gist_id}","starred_url":"https://api.github.com/users/mthebridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mthebridge/subscriptions","organizations_url":"https://api.github.com/users/mthebridge/orgs","repos_url":"https://api.github.com/users/mthebridge/repos","events_url":"https://api.github.com/users/mthebridge/events{/privacy}","received_events_url":"https://api.github.com/users/mthebridge/received_events","type":"User","site_admin":false},"body":"This makes small changes to the stats creation API for some better flexibility in usage.\r\n- No need to provide an instance of the formatter on `StatisticsLogger::new()`, just a type annotation.\r\n- `StatisticsLogger` is now correctly cloneable.\r\n- Can pass multiple stats definition sets into a single logger.\r\n\r\nBreaking change, so bumping major version and getting this in now before the stats tracking is widely used.\r\n\r\n","created_at":"2018-05-03T14:47:47Z","updated_at":"2018-05-03T15:03:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63ebe221c8c2dcfffa3bcb622337ec1bce7fdfe4","assignee":{"login":"jmlMetaswitch","id":20399716,"avatar_url":"https://avatars3.githubusercontent.com/u/20399716?v=4","gravatar_id":"","url":"https://api.github.com/users/jmlMetaswitch","html_url":"https://github.com/jmlMetaswitch","followers_url":"https://api.github.com/users/jmlMetaswitch/followers","following_url":"https://api.github.com/users/jmlMetaswitch/following{/other_user}","gists_url":"https://api.github.com/users/jmlMetaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/jmlMetaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmlMetaswitch/subscriptions","organizations_url":"https://api.github.com/users/jmlMetaswitch/orgs","repos_url":"https://api.github.com/users/jmlMetaswitch/repos","events_url":"https://api.github.com/users/jmlMetaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/jmlMetaswitch/received_events","type":"User","site_admin":false},"assignees":[{"login":"jmlMetaswitch","id":20399716,"avatar_url":"https://avatars3.githubusercontent.com/u/20399716?v=4","gravatar_id":"","url":"https://api.github.com/users/jmlMetaswitch","html_url":"https://github.com/jmlMetaswitch","followers_url":"https://api.github.com/users/jmlMetaswitch/followers","following_url":"https://api.github.com/users/jmlMetaswitch/following{/other_user}","gists_url":"https://api.github.com/users/jmlMetaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/jmlMetaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmlMetaswitch/subscriptions","organizations_url":"https://api.github.com/users/jmlMetaswitch/orgs","repos_url":"https://api.github.com/users/jmlMetaswitch/repos","events_url":"https://api.github.com/users/jmlMetaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/jmlMetaswitch/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"NigelThorpe","id":11216017,"avatar_url":"https://avatars3.githubusercontent.com/u/11216017?v=4","gravatar_id":"","url":"https://api.github.com/users/NigelThorpe","html_url":"https://github.com/NigelThorpe","followers_url":"https://api.github.com/users/NigelThorpe/followers","following_url":"https://api.github.com/users/NigelThorpe/following{/other_user}","gists_url":"https://api.github.com/users/NigelThorpe/gists{/gist_id}","starred_url":"https://api.github.com/users/NigelThorpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NigelThorpe/subscriptions","organizations_url":"https://api.github.com/users/NigelThorpe/orgs","repos_url":"https://api.github.com/users/NigelThorpe/repos","events_url":"https://api.github.com/users/NigelThorpe/events{/privacy}","received_events_url":"https://api.github.com/users/NigelThorpe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Metaswitch/slog-extlog/pulls/4/commits","review_comments_url":"https://api.github.com/repos/Metaswitch/slog-extlog/pulls/4/comments","review_comment_url":"https://api.github.com/repos/Metaswitch/slog-extlog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Metaswitch/slog-extlog/issues/4/comments","statuses_url":"https://api.github.com/repos/Metaswitch/slog-extlog/statuses/90687d136e36e55b207854b4006c53515647b9ac","head":{"label":"Metaswitch:stats-config-changes","ref":"stats-config-changes","sha":"90687d136e36e55b207854b4006c53515647b9ac","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":129888569,"name":"slog-extlog","full_name":"Metaswitch/slog-extlog","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/slog-extlog","description":"Add external logs (loggable objects) for use with the slog ecosystem.","fork":false,"url":"https://api.github.com/repos/Metaswitch/slog-extlog","forks_url":"https://api.github.com/repos/Metaswitch/slog-extlog/forks","keys_url":"https://api.github.com/repos/Metaswitch/slog-extlog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/slog-extlog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/slog-extlog/teams","hooks_url":"https://api.github.com/repos/Metaswitch/slog-extlog/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/slog-extlog/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/slog-extlog/events","assignees_url":"https://api.github.com/repos/Metaswitch/slog-extlog/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/slog-extlog/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/slog-extlog/tags","blobs_url":"https://api.github.com/repos/Metaswitch/slog-extlog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/slog-extlog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/slog-extlog/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/slog-extlog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/slog-extlog/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/slog-extlog/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/slog-extlog/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/slog-extlog/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/slog-extlog/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/slog-extlog/subscription","commits_url":"https://api.github.com/repos/Metaswitch/slog-extlog/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/slog-extlog/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/slog-extlog/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/slog-extlog/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/slog-extlog/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/slog-extlog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/slog-extlog/merges","archive_url":"https://api.github.com/repos/Metaswitch/slog-extlog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/slog-extlog/downloads","issues_url":"https://api.github.com/repos/Metaswitch/slog-extlog/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/slog-extlog/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/slog-extlog/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/slog-extlog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/slog-extlog/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/slog-extlog/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/slog-extlog/deployments","created_at":"2018-04-17T10:37:39Z","updated_at":"2018-04-30T15:24:40Z","pushed_at":"2018-05-03T14:48:39Z","git_url":"git://github.com/Metaswitch/slog-extlog.git","ssh_url":"git@github.com:Metaswitch/slog-extlog.git","clone_url":"https://github.com/Metaswitch/slog-extlog.git","svn_url":"https://github.com/Metaswitch/slog-extlog","homepage":null,"size":80,"stargazers_count":2,"watchers_count":2,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"Metaswitch:master","ref":"master","sha":"2f068cb04e3ad960194e058b2ea06a7f14ee1994","user":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"repo":{"id":129888569,"name":"slog-extlog","full_name":"Metaswitch/slog-extlog","owner":{"login":"Metaswitch","id":453759,"avatar_url":"https://avatars1.githubusercontent.com/u/453759?v=4","gravatar_id":"","url":"https://api.github.com/users/Metaswitch","html_url":"https://github.com/Metaswitch","followers_url":"https://api.github.com/users/Metaswitch/followers","following_url":"https://api.github.com/users/Metaswitch/following{/other_user}","gists_url":"https://api.github.com/users/Metaswitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Metaswitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metaswitch/subscriptions","organizations_url":"https://api.github.com/users/Metaswitch/orgs","repos_url":"https://api.github.com/users/Metaswitch/repos","events_url":"https://api.github.com/users/Metaswitch/events{/privacy}","received_events_url":"https://api.github.com/users/Metaswitch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Metaswitch/slog-extlog","description":"Add external logs (loggable objects) for use with the slog ecosystem.","fork":false,"url":"https://api.github.com/repos/Metaswitch/slog-extlog","forks_url":"https://api.github.com/repos/Metaswitch/slog-extlog/forks","keys_url":"https://api.github.com/repos/Metaswitch/slog-extlog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metaswitch/slog-extlog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metaswitch/slog-extlog/teams","hooks_url":"https://api.github.com/repos/Metaswitch/slog-extlog/hooks","issue_events_url":"https://api.github.com/repos/Metaswitch/slog-extlog/issues/events{/number}","events_url":"https://api.github.com/repos/Metaswitch/slog-extlog/events","assignees_url":"https://api.github.com/repos/Metaswitch/slog-extlog/assignees{/user}","branches_url":"https://api.github.com/repos/Metaswitch/slog-extlog/branches{/branch}","tags_url":"https://api.github.com/repos/Metaswitch/slog-extlog/tags","blobs_url":"https://api.github.com/repos/Metaswitch/slog-extlog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metaswitch/slog-extlog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metaswitch/slog-extlog/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metaswitch/slog-extlog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metaswitch/slog-extlog/statuses/{sha}","languages_url":"https://api.github.com/repos/Metaswitch/slog-extlog/languages","stargazers_url":"https://api.github.com/repos/Metaswitch/slog-extlog/stargazers","contributors_url":"https://api.github.com/repos/Metaswitch/slog-extlog/contributors","subscribers_url":"https://api.github.com/repos/Metaswitch/slog-extlog/subscribers","subscription_url":"https://api.github.com/repos/Metaswitch/slog-extlog/subscription","commits_url":"https://api.github.com/repos/Metaswitch/slog-extlog/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metaswitch/slog-extlog/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metaswitch/slog-extlog/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metaswitch/slog-extlog/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metaswitch/slog-extlog/contents/{+path}","compare_url":"https://api.github.com/repos/Metaswitch/slog-extlog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metaswitch/slog-extlog/merges","archive_url":"https://api.github.com/repos/Metaswitch/slog-extlog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metaswitch/slog-extlog/downloads","issues_url":"https://api.github.com/repos/Metaswitch/slog-extlog/issues{/number}","pulls_url":"https://api.github.com/repos/Metaswitch/slog-extlog/pulls{/number}","milestones_url":"https://api.github.com/repos/Metaswitch/slog-extlog/milestones{/number}","notifications_url":"https://api.github.com/repos/Metaswitch/slog-extlog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metaswitch/slog-extlog/labels{/name}","releases_url":"https://api.github.com/repos/Metaswitch/slog-extlog/releases{/id}","deployments_url":"https://api.github.com/repos/Metaswitch/slog-extlog/deployments","created_at":"2018-04-17T10:37:39Z","updated_at":"2018-04-30T15:24:40Z","pushed_at":"2018-05-03T14:48:39Z","git_url":"git://github.com/Metaswitch/slog-extlog.git","ssh_url":"git@github.com:Metaswitch/slog-extlog.git","clone_url":"https://github.com/Metaswitch/slog-extlog.git","svn_url":"https://github.com/Metaswitch/slog-extlog","homepage":null,"size":80,"stargazers_count":2,"watchers_count":2,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Metaswitch/slog-extlog/pulls/4"},"html":{"href":"https://github.com/Metaswitch/slog-extlog/pull/4"},"issue":{"href":"https://api.github.com/repos/Metaswitch/slog-extlog/issues/4"},"comments":{"href":"https://api.github.com/repos/Metaswitch/slog-extlog/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/Metaswitch/slog-extlog/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/Metaswitch/slog-extlog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Metaswitch/slog-extlog/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/Metaswitch/slog-extlog/statuses/90687d136e36e55b207854b4006c53515647b9ac"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jmlMetaswitch"}}