{"action":"closed","number":23624,"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/23624","id":185067036,"html_url":"https://github.com/angular/angular/pull/23624","diff_url":"https://github.com/angular/angular/pull/23624.diff","patch_url":"https://github.com/angular/angular/pull/23624.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/23624","number":23624,"state":"closed","locked":false,"title":"styles(topMenu):space between .home and .hamburger","user":{"login":"Ardeshir81","id":5755214,"avatar_url":"https://avatars3.githubusercontent.com/u/5755214?v=4","gravatar_id":"","url":"https://api.github.com/users/Ardeshir81","html_url":"https://github.com/Ardeshir81","followers_url":"https://api.github.com/users/Ardeshir81/followers","following_url":"https://api.github.com/users/Ardeshir81/following{/other_user}","gists_url":"https://api.github.com/users/Ardeshir81/gists{/gist_id}","starred_url":"https://api.github.com/users/Ardeshir81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ardeshir81/subscriptions","organizations_url":"https://api.github.com/users/Ardeshir81/orgs","repos_url":"https://api.github.com/users/Ardeshir81/repos","events_url":"https://api.github.com/users/Ardeshir81/events{/privacy}","received_events_url":"https://api.github.com/users/Ardeshir81/received_events","type":"User","site_admin":false},"body":"when hamburger menu is clicked, it's ripple background is drawn until the very edge of home's image, leaving no space. this adds a tiny space there\r\n\r\n## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [ x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[ ] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Documentation content changes\r\n[x ] angular.io application / infrastructure changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\nOn the top header, when hamburger menu button is present, when clicked on it, a ripple background is drawn and is extended just to very edge of the main `Angular` image in home link.\r\n\r\nIssue Number: N/A\r\n\r\n\r\n## What is the new behavior?\r\nI added a tiny space, and in my opinion it just looks nicer\r\n\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[x ] No\r\n```\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n\r\n\r\n## Other information\r\nthis is just self-opinionated. I just saw it on website and felt like there needs to be a small space there","created_at":"2018-04-30T21:16:29Z","updated_at":"2018-05-02T22:55:19Z","closed_at":"2018-05-02T22:55:19Z","merged_at":null,"merge_commit_sha":"0668bb8c8f9e2c130cb1e1fc3abc67750aaa4607","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":133556520,"url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20merge","name":"PR action: merge","color":"99ff66","default":false},{"id":655699838,"url":"https://api.github.com/repos/angular/angular/labels/PR%20target:%20master%20&%20patch","name":"PR target: master & patch","color":"5319e7","default":false},{"id":633027559,"url":"https://api.github.com/repos/angular/angular/labels/aio:%20preview","name":"aio: preview","color":"1d76db","default":false},{"id":149476251,"url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":533874619,"url":"https://api.github.com/repos/angular/angular/labels/comp:%20aio","name":"comp: aio","color":"c7def8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/23624/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/23624/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/23624/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/6789f3bb426e463b890108d674114342f621c18d","head":{"label":"Ardeshir81:patch-1","ref":"patch-1","sha":"6789f3bb426e463b890108d674114342f621c18d","user":{"login":"Ardeshir81","id":5755214,"avatar_url":"https://avatars3.githubusercontent.com/u/5755214?v=4","gravatar_id":"","url":"https://api.github.com/users/Ardeshir81","html_url":"https://github.com/Ardeshir81","followers_url":"https://api.github.com/users/Ardeshir81/followers","following_url":"https://api.github.com/users/Ardeshir81/following{/other_user}","gists_url":"https://api.github.com/users/Ardeshir81/gists{/gist_id}","starred_url":"https://api.github.com/users/Ardeshir81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ardeshir81/subscriptions","organizations_url":"https://api.github.com/users/Ardeshir81/orgs","repos_url":"https://api.github.com/users/Ardeshir81/repos","events_url":"https://api.github.com/users/Ardeshir81/events{/privacy}","received_events_url":"https://api.github.com/users/Ardeshir81/received_events","type":"User","site_admin":false},"repo":{"id":131646652,"name":"angular","full_name":"Ardeshir81/angular","owner":{"login":"Ardeshir81","id":5755214,"avatar_url":"https://avatars3.githubusercontent.com/u/5755214?v=4","gravatar_id":"","url":"https://api.github.com/users/Ardeshir81","html_url":"https://github.com/Ardeshir81","followers_url":"https://api.github.com/users/Ardeshir81/followers","following_url":"https://api.github.com/users/Ardeshir81/following{/other_user}","gists_url":"https://api.github.com/users/Ardeshir81/gists{/gist_id}","starred_url":"https://api.github.com/users/Ardeshir81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ardeshir81/subscriptions","organizations_url":"https://api.github.com/users/Ardeshir81/orgs","repos_url":"https://api.github.com/users/Ardeshir81/repos","events_url":"https://api.github.com/users/Ardeshir81/events{/privacy}","received_events_url":"https://api.github.com/users/Ardeshir81/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ardeshir81/angular","description":"One framework. Mobile & desktop.","fork":true,"url":"https://api.github.com/repos/Ardeshir81/angular","forks_url":"https://api.github.com/repos/Ardeshir81/angular/forks","keys_url":"https://api.github.com/repos/Ardeshir81/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ardeshir81/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ardeshir81/angular/teams","hooks_url":"https://api.github.com/repos/Ardeshir81/angular/hooks","issue_events_url":"https://api.github.com/repos/Ardeshir81/angular/issues/events{/number}","events_url":"https://api.github.com/repos/Ardeshir81/angular/events","assignees_url":"https://api.github.com/repos/Ardeshir81/angular/assignees{/user}","branches_url":"https://api.github.com/repos/Ardeshir81/angular/branches{/branch}","tags_url":"https://api.github.com/repos/Ardeshir81/angular/tags","blobs_url":"https://api.github.com/repos/Ardeshir81/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ardeshir81/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ardeshir81/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ardeshir81/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ardeshir81/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/Ardeshir81/angular/languages","stargazers_url":"https://api.github.com/repos/Ardeshir81/angular/stargazers","contributors_url":"https://api.github.com/repos/Ardeshir81/angular/contributors","subscribers_url":"https://api.github.com/repos/Ardeshir81/angular/subscribers","subscription_url":"https://api.github.com/repos/Ardeshir81/angular/subscription","commits_url":"https://api.github.com/repos/Ardeshir81/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ardeshir81/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ardeshir81/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ardeshir81/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ardeshir81/angular/contents/{+path}","compare_url":"https://api.github.com/repos/Ardeshir81/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ardeshir81/angular/merges","archive_url":"https://api.github.com/repos/Ardeshir81/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ardeshir81/angular/downloads","issues_url":"https://api.github.com/repos/Ardeshir81/angular/issues{/number}","pulls_url":"https://api.github.com/repos/Ardeshir81/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/Ardeshir81/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/Ardeshir81/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ardeshir81/angular/labels{/name}","releases_url":"https://api.github.com/repos/Ardeshir81/angular/releases{/id}","deployments_url":"https://api.github.com/repos/Ardeshir81/angular/deployments","created_at":"2018-04-30T21:06:35Z","updated_at":"2018-04-30T21:06:52Z","pushed_at":"2018-05-02T13:59:00Z","git_url":"git://github.com/Ardeshir81/angular.git","ssh_url":"git@github.com:Ardeshir81/angular.git","clone_url":"https://github.com/Ardeshir81/angular.git","svn_url":"https://github.com/Ardeshir81/angular","homepage":"https://angular.io","size":79541,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"c5cfc3a1b652dd748a774d7f1dbc4ca4e8524b15","user":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2018-05-02T22:54:43Z","pushed_at":"2018-05-02T22:54:20Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":79883,"stargazers_count":35771,"watchers_count":35771,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8681,"mirror_url":null,"archived":false,"open_issues_count":2335,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8681,"open_issues":2335,"watchers":35771,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/23624"},"html":{"href":"https://github.com/angular/angular/pull/23624"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/23624"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/23624/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/23624/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/23624/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/6789f3bb426e463b890108d674114342f621c18d"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":8,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":6,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"IgorMinar"}}