{"action":"closed","number":85,"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/pulls/85","id":226627898,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjI3ODk4","html_url":"https://github.com/wireapp/wire-ios-request-strategy/pull/85","diff_url":"https://github.com/wireapp/wire-ios-request-strategy/pull/85.diff","patch_url":"https://github.com/wireapp/wire-ios-request-strategy/pull/85.patch","issue_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/issues/85","number":85,"state":"closed","locked":false,"title":"Added completion handler for delivery receipts","user":{"login":"vytis","id":33914,"node_id":"MDQ6VXNlcjMzOTE0","avatar_url":"https://avatars2.githubusercontent.com/u/33914?v=4","gravatar_id":"","url":"https://api.github.com/users/vytis","html_url":"https://github.com/vytis","followers_url":"https://api.github.com/users/vytis/followers","following_url":"https://api.github.com/users/vytis/following{/other_user}","gists_url":"https://api.github.com/users/vytis/gists{/gist_id}","starred_url":"https://api.github.com/users/vytis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vytis/subscriptions","organizations_url":"https://api.github.com/users/vytis/orgs","repos_url":"https://api.github.com/users/vytis/repos","events_url":"https://api.github.com/users/vytis/events{/privacy}","received_events_url":"https://api.github.com/users/vytis/received_events","type":"User","site_admin":false},"body":"## What's new in this PR?\r\n\r\n### Issues\r\n\r\nWhen processing push notifications we were calling the completion handler earlier than needed - we were still sending delivery receipts. This might lead to app termination because we still are processing messages, but we tell to iOS that we are done.\r\n\r\n### Solutions\r\n\r\nAdded a possibility to register completion handler which is called when all delivery receipts have been already sent.\r\n","created_at":"2018-10-29T16:28:06Z","updated_at":"2018-11-06T09:19:23Z","closed_at":"2018-11-06T09:19:22Z","merged_at":null,"merge_commit_sha":"89c894c0beddce3cf4374d159c86e0351cc324a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":447419023,"node_id":"MDU6TGFiZWw0NDc0MTkwMjM=","url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/labels/DO%20NOT%20MERGE","name":"DO NOT MERGE","color":"eb6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/pulls/85/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/pulls/85/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/issues/85/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/statuses/2a559f0fbdcf853de051b7f6e2909274eaf51b3b","head":{"label":"wireapp:fix/delivery-completion","ref":"fix/delivery-completion","sha":"2a559f0fbdcf853de051b7f6e2909274eaf51b3b","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":66647494,"node_id":"MDEwOlJlcG9zaXRvcnk2NjY0NzQ5NA==","name":"wire-ios-request-strategy","full_name":"wireapp/wire-ios-request-strategy","private":false,"owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wireapp/wire-ios-request-strategy","description":"iOS synchronization base interfaces for Wire","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy","forks_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/deployments","created_at":"2016-08-26T12:52:44Z","updated_at":"2018-10-23T16:16:58Z","pushed_at":"2018-10-31T14:46:27Z","git_url":"git://github.com/wireapp/wire-ios-request-strategy.git","ssh_url":"git@github.com:wireapp/wire-ios-request-strategy.git","clone_url":"https://github.com/wireapp/wire-ios-request-strategy.git","svn_url":"https://github.com/wireapp/wire-ios-request-strategy","homepage":"https://wire.com","size":2565,"stargazers_count":12,"watchers_count":12,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":4,"open_issues":1,"watchers":12,"default_branch":"develop"}},"base":{"label":"wireapp:develop","ref":"develop","sha":"a53569a460e9603aa4d4709a704bad5b434144a8","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":66647494,"node_id":"MDEwOlJlcG9zaXRvcnk2NjY0NzQ5NA==","name":"wire-ios-request-strategy","full_name":"wireapp/wire-ios-request-strategy","private":false,"owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wireapp/wire-ios-request-strategy","description":"iOS synchronization base interfaces for Wire","fork":false,"url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy","forks_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/forks","keys_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/events","assignees_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/merges","archive_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/deployments","created_at":"2016-08-26T12:52:44Z","updated_at":"2018-10-23T16:16:58Z","pushed_at":"2018-10-31T14:46:27Z","git_url":"git://github.com/wireapp/wire-ios-request-strategy.git","ssh_url":"git@github.com:wireapp/wire-ios-request-strategy.git","clone_url":"https://github.com/wireapp/wire-ios-request-strategy.git","svn_url":"https://github.com/wireapp/wire-ios-request-strategy","homepage":"https://wire.com","size":2565,"stargazers_count":12,"watchers_count":12,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":4,"open_issues":1,"watchers":12,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/pulls/85"},"html":{"href":"https://github.com/wireapp/wire-ios-request-strategy/pull/85"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/issues/85"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-ios-request-strategy/statuses/2a559f0fbdcf853de051b7f6e2909274eaf51b3b"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":6,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"vytis"}}