{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/25234","repository_url":"https://api.github.com/repos/dotnet/roslyn","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/25234/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/25234/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/25234/events","html_url":"https://github.com/dotnet/roslyn/issues/25234","id":302481712,"number":25234,"title":"Misbehaving refactorings in 15.6 RoslynDev crash Visual Studio","user":{"login":"Neme12","id":11444821,"avatar_url":"https://avatars3.githubusercontent.com/u/11444821?v=4","gravatar_id":"","url":"https://api.github.com/users/Neme12","html_url":"https://github.com/Neme12","followers_url":"https://api.github.com/users/Neme12/followers","following_url":"https://api.github.com/users/Neme12/following{/other_user}","gists_url":"https://api.github.com/users/Neme12/gists{/gist_id}","starred_url":"https://api.github.com/users/Neme12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neme12/subscriptions","organizations_url":"https://api.github.com/users/Neme12/orgs","repos_url":"https://api.github.com/users/Neme12/repos","events_url":"https://api.github.com/users/Neme12/events{/privacy}","received_events_url":"https://api.github.com/users/Neme12/received_events","type":"User","site_admin":false},"labels":[{"id":166377917,"url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7","default":false},{"id":273669338,"url":"https://api.github.com/repos/dotnet/roslyn/labels/Contributor%20Pain","name":"Contributor Pain","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-03-05T22:02:39Z","updated_at":"2018-03-06T19:21:59Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"If I run VisualStudioSetup.Next from VS 15.5 and and encounter an exception from a refactoring, I get the usual message about a crashing refactoring with an option to re-enable it.\r\n\r\nBut for some reason if I do this in VS 15.6 P7, the exception from the refactoring causes all of VS to crash (by freezing, forcing me to use Task Manager). This really makes working on these sorts of issues a pain.\r\n\r\nBuilding using the corresponding dev command prompt and then running RoslynDev has the same effect - in 15.5, I get a message, in 15.6, VS crashes. With both Debug & Release builds.\r\n\r\nHere's an example issue: https://github.com/dotnet/roslyn/issues/20943#issuecomment-363138541\r\n\r\nThis is the call stack I get if I debug:\r\n```c#\r\nMicrosoft.CodeAnalysis.Workspaces.dll!Microsoft.CodeAnalysis.ErrorReporting.FatalError.Report(System.Exception exception, System.Action<System.Exception> handler) Line 156\r\n\tat C:\\Users\\neme1\\Source\\Repos\\roslyn\\src\\Compilers\\Core\\Portable\\InternalUtilities\\FatalError.cs(156)\r\nMicrosoft.VisualStudio.IntegrationTest.Setup.dll!Microsoft.VisualStudio.IntegrationTest.Setup.TestExtensionErrorHandler.HandleError(object sender, System.Exception exception) Line 15\r\n\tat C:\\Users\\neme1\\Source\\Repos\\roslyn\\src\\VisualStudio\\IntegrationTest\\TestSetup\\TestExtensionErrorHandler.cs(15)\r\nMicrosoft.VisualStudio.IntegrationTest.Setup.dll!Microsoft.VisualStudio.IntegrationTest.Setup.TestExtensionManager.ExtensionManager.HandleException(object provider, System.Exception exception) Line 49\r\n\tat C:\\Users\\neme1\\Source\\Repos\\roslyn\\src\\VisualStudio\\IntegrationTest\\TestSetup\\TestExtensionManager.cs(49)\r\nMicrosoft.CodeAnalysis.Features.dll!Microsoft.CodeAnalysis.CodeRefactorings.CodeRefactoringService.GetRefactoringFromProviderAsync(Microsoft.CodeAnalysis.Document document, Microsoft.CodeAnalysis.Text.TextSpan state, Microsoft.CodeAnalysis.CodeRefactorings.CodeRefactoringProvider provider, Microsoft.CodeAnalysis.Extensions.IExtensionManager extensionManager, System.Threading.CancellationToken cancellationToken) Line 161\r\n\tat C:\\Users\\neme1\\Source\\Repos\\roslyn\\src\\Features\\Core\\Portable\\CodeRefactorings\\CodeRefactoringService.cs(161)\r\nMicrosoft.CodeAnalysis.Features.dll!Microsoft.CodeAnalysis.CodeRefactorings.CodeRefactoringService.GetRefactoringsAsync.AnonymousMethod__0() Line 105\r\n\tat C:\\Users\\neme1\\Source\\Repos\\roslyn\\src\\Features\\Core\\Portable\\CodeRefactorings\\CodeRefactoringService.cs(105)\r\n[External Code]\r\n```"},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/370896757","html_url":"https://github.com/dotnet/roslyn/issues/25234#issuecomment-370896757","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/25234","id":370896757,"user":{"login":"jmarolf","id":9797472,"avatar_url":"https://avatars2.githubusercontent.com/u/9797472?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarolf","html_url":"https://github.com/jmarolf","followers_url":"https://api.github.com/users/jmarolf/followers","following_url":"https://api.github.com/users/jmarolf/following{/other_user}","gists_url":"https://api.github.com/users/jmarolf/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarolf/subscriptions","organizations_url":"https://api.github.com/users/jmarolf/orgs","repos_url":"https://api.github.com/users/jmarolf/repos","events_url":"https://api.github.com/users/jmarolf/events{/privacy}","received_events_url":"https://api.github.com/users/jmarolf/received_events","type":"User","site_admin":false},"created_at":"2018-03-06T19:21:58Z","updated_at":"2018-03-06T19:21:58Z","author_association":"MEMBER","body":"@CyrusNajmabadi You can uninstall the `TestSetup` extension from your `RoslynDev` hive, or unload the [VisualStudioIntegrationTestSetup](https://github.com/dotnet/roslyn/blob/master/src/VisualStudio/IntegrationTest/TestSetup/VisualStudioIntegrationTestSetup.csproj) project from your solution.\r\n\r\n@Neme12 as @CyrusNajmabadi says, we want the model for developers on roslyn to be fail-fast.  The hope is that the just-in-time debugger launches when an exception is thrown and you can immediately fix it, or file a detailed bug report since you are at the exact location where the error occurred."}}
{"actor":{"display_login":"jmarolf"}}