{"action":"created","issue":{"url":"https://api.github.com/repos/Ulm-IQO/qudi/issues/362","repository_url":"https://api.github.com/repos/Ulm-IQO/qudi","labels_url":"https://api.github.com/repos/Ulm-IQO/qudi/issues/362/labels{/name}","comments_url":"https://api.github.com/repos/Ulm-IQO/qudi/issues/362/comments","events_url":"https://api.github.com/repos/Ulm-IQO/qudi/issues/362/events","html_url":"https://github.com/Ulm-IQO/qudi/pull/362","id":312465280,"number":362,"title":"fixed a bug where the errors of the delta plot were saved incorrectly","user":{"login":"kay-jahnke","id":18718646,"avatar_url":"https://avatars1.githubusercontent.com/u/18718646?v=4","gravatar_id":"","url":"https://api.github.com/users/kay-jahnke","html_url":"https://github.com/kay-jahnke","followers_url":"https://api.github.com/users/kay-jahnke/followers","following_url":"https://api.github.com/users/kay-jahnke/following{/other_user}","gists_url":"https://api.github.com/users/kay-jahnke/gists{/gist_id}","starred_url":"https://api.github.com/users/kay-jahnke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kay-jahnke/subscriptions","organizations_url":"https://api.github.com/users/kay-jahnke/orgs","repos_url":"https://api.github.com/users/kay-jahnke/repos","events_url":"https://api.github.com/users/kay-jahnke/events{/privacy}","received_events_url":"https://api.github.com/users/kay-jahnke/received_events","type":"User","site_admin":false},"labels":[{"id":356267363,"url":"https://api.github.com/repos/Ulm-IQO/qudi/labels/bug","name":"bug","color":"ff9911","default":true},{"id":530788263,"url":"https://api.github.com/repos/Ulm-IQO/qudi/labels/comp:pulsed","name":"comp:pulsed","color":"e99695","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-09T09:51:51Z","updated_at":"2018-04-09T14:12:50Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Ulm-IQO/qudi/pulls/362","html_url":"https://github.com/Ulm-IQO/qudi/pull/362","diff_url":"https://github.com/Ulm-IQO/qudi/pull/362.diff","patch_url":"https://github.com/Ulm-IQO/qudi/pull/362.patch"},"body":"fixed a bug where the errors of the delta plot were not save correctly (or rather the original errors were not saved anymore).\r\n\r\nAlso included the errorbars into the saved data of the delta plot.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an 'x' in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an 'x' in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, ask. -->\r\n- [x] My code follows the code style of this project.\r\n- [x] I have documented my changes in the changelog (`documentation/changelog.md`) -> minor bugfixes\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have checked that the change does not contain obvious errors (syntax, indentation, mutable default values).\r\n- [x] I have tested my changes using 'Load all modules' on the default dummy configuration with my changes included.\r\n- [ ] All changed Jupyter notebooks have been stripped of their output cells.\r\n"},"comment":{"url":"https://api.github.com/repos/Ulm-IQO/qudi/issues/comments/379766312","html_url":"https://github.com/Ulm-IQO/qudi/pull/362#issuecomment-379766312","issue_url":"https://api.github.com/repos/Ulm-IQO/qudi/issues/362","id":379766312,"user":{"login":"kay-jahnke","id":18718646,"avatar_url":"https://avatars1.githubusercontent.com/u/18718646?v=4","gravatar_id":"","url":"https://api.github.com/users/kay-jahnke","html_url":"https://github.com/kay-jahnke","followers_url":"https://api.github.com/users/kay-jahnke/followers","following_url":"https://api.github.com/users/kay-jahnke/following{/other_user}","gists_url":"https://api.github.com/users/kay-jahnke/gists{/gist_id}","starred_url":"https://api.github.com/users/kay-jahnke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kay-jahnke/subscriptions","organizations_url":"https://api.github.com/users/kay-jahnke/orgs","repos_url":"https://api.github.com/users/kay-jahnke/repos","events_url":"https://api.github.com/users/kay-jahnke/events{/privacy}","received_events_url":"https://api.github.com/users/kay-jahnke/received_events","type":"User","site_admin":false},"created_at":"2018-04-09T14:12:49Z","updated_at":"2018-04-09T14:12:49Z","author_association":"MEMBER","body":"@drogenlied these bugs are unrelated but worth fixing.\r\n\r\nThe first one resulted from the order in Initialization in the pulsed gui. I modified the code so the initialization of errorbar and second plot are triggered after everything has been initialized by the measurement file.\r\n\r\nThe second was just me missing a second clause in the if condition.\r\n\r\nShould be all fine now."}}
{"actor":{"display_login":"kay-jahnke"}}