{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/gapic-generator/pulls/comments/217549956","pull_request_review_id":155292057,"id":217549956,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzU0OTk1Ng==","diff_hunk":"@@ -36,20 +36,20 @@ public GapicCodeGeneratorAnnotationsTest(\n       String packageConfigFileName,\n       List<String> snippetName,\n       String apiName,\n-      String baseline) {\n-    super(language, null, null, snippetName, baseline);\n+      String baseline,\n+      String protoPackage) {\n+    //    super(language, null, null, snippetName, baseline);\n+    super(language, null, null, snippetName, baseline, \"google.example.library.v1\");","path":"src/test/java/com/google/api/codegen/GapicCodeGeneratorAnnotationsTest.java","position":9,"original_position":9,"commit_id":"81027d7566436183bb9c0c9ff5a6fbeae0089517","original_commit_id":"8c2e329166ce4cf228085d4e46a8ab058ca78438","user":{"login":"andreamlin","id":4016818,"node_id":"MDQ6VXNlcjQwMTY4MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4016818?v=4","gravatar_id":"","url":"https://api.github.com/users/andreamlin","html_url":"https://github.com/andreamlin","followers_url":"https://api.github.com/users/andreamlin/followers","following_url":"https://api.github.com/users/andreamlin/following{/other_user}","gists_url":"https://api.github.com/users/andreamlin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreamlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreamlin/subscriptions","organizations_url":"https://api.github.com/users/andreamlin/orgs","repos_url":"https://api.github.com/users/andreamlin/repos","events_url":"https://api.github.com/users/andreamlin/events{/privacy}","received_events_url":"https://api.github.com/users/andreamlin/received_events","type":"User","site_admin":false},"body":"Yes, thanks :)","created_at":"2018-09-13T22:11:54Z","updated_at":"2018-09-13T22:11:54Z","html_url":"https://github.com/googleapis/gapic-generator/pull/2308#discussion_r217549956","pull_request_url":"https://api.github.com/repos/googleapis/gapic-generator/pulls/2308","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googleapis/gapic-generator/pulls/comments/217549956"},"html":{"href":"https://github.com/googleapis/gapic-generator/pull/2308#discussion_r217549956"},"pull_request":{"href":"https://api.github.com/repos/googleapis/gapic-generator/pulls/2308"}},"in_reply_to_id":217437041},"pull_request":{"url":"https://api.github.com/repos/googleapis/gapic-generator/pulls/2308","id":215099678,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDk5Njc4","html_url":"https://github.com/googleapis/gapic-generator/pull/2308","diff_url":"https://github.com/googleapis/gapic-generator/pull/2308.diff","patch_url":"https://github.com/googleapis/gapic-generator/pull/2308.patch","issue_url":"https://api.github.com/repos/googleapis/gapic-generator/issues/2308","number":2308,"state":"open","locked":false,"title":"Move around test resources, add GapicCodeGeneratorAnnotationsTest","user":{"login":"andreamlin","id":4016818,"node_id":"MDQ6VXNlcjQwMTY4MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4016818?v=4","gravatar_id":"","url":"https://api.github.com/users/andreamlin","html_url":"https://github.com/andreamlin","followers_url":"https://api.github.com/users/andreamlin/followers","following_url":"https://api.github.com/users/andreamlin/following{/other_user}","gists_url":"https://api.github.com/users/andreamlin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreamlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreamlin/subscriptions","organizations_url":"https://api.github.com/users/andreamlin/orgs","repos_url":"https://api.github.com/users/andreamlin/repos","events_url":"https://api.github.com/users/andreamlin/events{/privacy}","received_events_url":"https://api.github.com/users/andreamlin/received_events","type":"User","site_admin":false},"body":"- Move testdata to a `testdata` directory as is conventional in this codebase.\r\n- Add an empty GapicCodeGeneratorAnnotationsTest.\r\n- Add `protoPackage` to the GapicProductConfig to represent the `--package` option for the proto package; this is a required option if no gapic config is given, and it represents the proto package, out of the protofiles in the descriptor set (which can contain common protos), that we want to generate a client for (e.g. `google.example.library.v1`).","created_at":"2018-09-12T21:20:17Z","updated_at":"2018-09-13T22:11:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6ed9244ad66895e73763600ee3713df312db04d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/gapic-generator/pulls/2308/commits","review_comments_url":"https://api.github.com/repos/googleapis/gapic-generator/pulls/2308/comments","review_comment_url":"https://api.github.com/repos/googleapis/gapic-generator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/gapic-generator/issues/2308/comments","statuses_url":"https://api.github.com/repos/googleapis/gapic-generator/statuses/81027d7566436183bb9c0c9ff5a6fbeae0089517","head":{"label":"andreamlin:testdata","ref":"testdata","sha":"81027d7566436183bb9c0c9ff5a6fbeae0089517","user":{"login":"andreamlin","id":4016818,"node_id":"MDQ6VXNlcjQwMTY4MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4016818?v=4","gravatar_id":"","url":"https://api.github.com/users/andreamlin","html_url":"https://github.com/andreamlin","followers_url":"https://api.github.com/users/andreamlin/followers","following_url":"https://api.github.com/users/andreamlin/following{/other_user}","gists_url":"https://api.github.com/users/andreamlin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreamlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreamlin/subscriptions","organizations_url":"https://api.github.com/users/andreamlin/orgs","repos_url":"https://api.github.com/users/andreamlin/repos","events_url":"https://api.github.com/users/andreamlin/events{/privacy}","received_events_url":"https://api.github.com/users/andreamlin/received_events","type":"User","site_admin":false},"repo":{"id":90909131,"node_id":"MDEwOlJlcG9zaXRvcnk5MDkwOTEzMQ==","name":"toolkit","full_name":"andreamlin/toolkit","owner":{"login":"andreamlin","id":4016818,"node_id":"MDQ6VXNlcjQwMTY4MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4016818?v=4","gravatar_id":"","url":"https://api.github.com/users/andreamlin","html_url":"https://github.com/andreamlin","followers_url":"https://api.github.com/users/andreamlin/followers","following_url":"https://api.github.com/users/andreamlin/following{/other_user}","gists_url":"https://api.github.com/users/andreamlin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreamlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreamlin/subscriptions","organizations_url":"https://api.github.com/users/andreamlin/orgs","repos_url":"https://api.github.com/users/andreamlin/repos","events_url":"https://api.github.com/users/andreamlin/events{/privacy}","received_events_url":"https://api.github.com/users/andreamlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreamlin/toolkit","description":null,"fork":true,"url":"https://api.github.com/repos/andreamlin/toolkit","forks_url":"https://api.github.com/repos/andreamlin/toolkit/forks","keys_url":"https://api.github.com/repos/andreamlin/toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreamlin/toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreamlin/toolkit/teams","hooks_url":"https://api.github.com/repos/andreamlin/toolkit/hooks","issue_events_url":"https://api.github.com/repos/andreamlin/toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/andreamlin/toolkit/events","assignees_url":"https://api.github.com/repos/andreamlin/toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/andreamlin/toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/andreamlin/toolkit/tags","blobs_url":"https://api.github.com/repos/andreamlin/toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreamlin/toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreamlin/toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreamlin/toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreamlin/toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/andreamlin/toolkit/languages","stargazers_url":"https://api.github.com/repos/andreamlin/toolkit/stargazers","contributors_url":"https://api.github.com/repos/andreamlin/toolkit/contributors","subscribers_url":"https://api.github.com/repos/andreamlin/toolkit/subscribers","subscription_url":"https://api.github.com/repos/andreamlin/toolkit/subscription","commits_url":"https://api.github.com/repos/andreamlin/toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreamlin/toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreamlin/toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreamlin/toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreamlin/toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/andreamlin/toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreamlin/toolkit/merges","archive_url":"https://api.github.com/repos/andreamlin/toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreamlin/toolkit/downloads","issues_url":"https://api.github.com/repos/andreamlin/toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/andreamlin/toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/andreamlin/toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/andreamlin/toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreamlin/toolkit/labels{/name}","releases_url":"https://api.github.com/repos/andreamlin/toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/andreamlin/toolkit/deployments","created_at":"2017-05-10T21:16:54Z","updated_at":"2018-08-30T03:31:48Z","pushed_at":"2018-09-13T22:08:57Z","git_url":"git://github.com/andreamlin/toolkit.git","ssh_url":"git@github.com:andreamlin/toolkit.git","clone_url":"https://github.com/andreamlin/toolkit.git","svn_url":"https://github.com/andreamlin/toolkit","homepage":null,"size":23439,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"8bc91a94f9c9782876c4129872976695a53d38bf","user":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":56533838,"node_id":"MDEwOlJlcG9zaXRvcnk1NjUzMzgzOA==","name":"gapic-generator","full_name":"googleapis/gapic-generator","owner":{"login":"googleapis","id":16785467,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Nzg1NDY3","avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googleapis/gapic-generator","description":"Tools for generating API client libraries from API Service Configuration descriptions.","fork":false,"url":"https://api.github.com/repos/googleapis/gapic-generator","forks_url":"https://api.github.com/repos/googleapis/gapic-generator/forks","keys_url":"https://api.github.com/repos/googleapis/gapic-generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/gapic-generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/gapic-generator/teams","hooks_url":"https://api.github.com/repos/googleapis/gapic-generator/hooks","issue_events_url":"https://api.github.com/repos/googleapis/gapic-generator/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/gapic-generator/events","assignees_url":"https://api.github.com/repos/googleapis/gapic-generator/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/gapic-generator/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/gapic-generator/tags","blobs_url":"https://api.github.com/repos/googleapis/gapic-generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/gapic-generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/gapic-generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/gapic-generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/gapic-generator/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/gapic-generator/languages","stargazers_url":"https://api.github.com/repos/googleapis/gapic-generator/stargazers","contributors_url":"https://api.github.com/repos/googleapis/gapic-generator/contributors","subscribers_url":"https://api.github.com/repos/googleapis/gapic-generator/subscribers","subscription_url":"https://api.github.com/repos/googleapis/gapic-generator/subscription","commits_url":"https://api.github.com/repos/googleapis/gapic-generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/gapic-generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/gapic-generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/gapic-generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/gapic-generator/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/gapic-generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/gapic-generator/merges","archive_url":"https://api.github.com/repos/googleapis/gapic-generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/gapic-generator/downloads","issues_url":"https://api.github.com/repos/googleapis/gapic-generator/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/gapic-generator/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/gapic-generator/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/gapic-generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/gapic-generator/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/gapic-generator/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/gapic-generator/deployments","created_at":"2016-04-18T18:58:04Z","updated_at":"2018-09-13T21:21:20Z","pushed_at":"2018-09-13T22:08:58Z","git_url":"git://github.com/googleapis/gapic-generator.git","ssh_url":"git@github.com:googleapis/gapic-generator.git","clone_url":"https://github.com/googleapis/gapic-generator.git","svn_url":"https://github.com/googleapis/gapic-generator","homepage":"","size":23193,"stargazers_count":56,"watchers_count":56,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":177,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":62,"open_issues":177,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/gapic-generator/pulls/2308"},"html":{"href":"https://github.com/googleapis/gapic-generator/pull/2308"},"issue":{"href":"https://api.github.com/repos/googleapis/gapic-generator/issues/2308"},"comments":{"href":"https://api.github.com/repos/googleapis/gapic-generator/issues/2308/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/gapic-generator/pulls/2308/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/gapic-generator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/gapic-generator/pulls/2308/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/gapic-generator/statuses/81027d7566436183bb9c0c9ff5a6fbeae0089517"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"andreamlin"}}