{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments/217143046","pull_request_review_id":154786787,"id":217143046,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzE0MzA0Ng==","diff_hunk":"@@ -1625,6 +1625,19 @@ func validateIoTTopicRuleElasticSearchEndpoint(v interface{}, k string) (ws []st\n \treturn\n }\n \n+func validateIoTTopicRuleFirehoseSeparator(v interface{}, s string) ([]string, []error) {\n+\tswitch v.(string) {\n+\tcase\n+\t\t\",\",\n+\t\t\"\\t\",\n+\t\t\"\\n\",\n+\t\t\"\\r\\n\":\n+\t\treturn nil, nil\n+\t}\n+\n+\treturn nil, []error{fmt.Errorf(\"Separator must be one of ',' (comma), '\\t' (tab) '\\n' (newline) or '\\r\\n' (Windows newline)\")}","path":"aws/validators.go","position":14,"original_position":14,"commit_id":"d0464c975ffcabaec53c04e934d90b2bddaa92bd","original_commit_id":"d0464c975ffcabaec53c04e934d90b2bddaa92bd","user":{"login":"bflad","id":189114,"node_id":"MDQ6VXNlcjE4OTExNA==","avatar_url":"https://avatars3.githubusercontent.com/u/189114?v=4","gravatar_id":"","url":"https://api.github.com/users/bflad","html_url":"https://github.com/bflad","followers_url":"https://api.github.com/users/bflad/followers","following_url":"https://api.github.com/users/bflad/following{/other_user}","gists_url":"https://api.github.com/users/bflad/gists{/gist_id}","starred_url":"https://api.github.com/users/bflad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bflad/subscriptions","organizations_url":"https://api.github.com/users/bflad/orgs","repos_url":"https://api.github.com/users/bflad/repos","events_url":"https://api.github.com/users/bflad/events{/privacy}","received_events_url":"https://api.github.com/users/bflad/received_events","type":"User","site_admin":false},"body":"When printing this error, it is returning the whitespace and not the intended characters:\r\n\r\n```\r\naws_iot_topic_rule.rule: Separator must be one of ',' (comma), '\t' (tab) '\r\n        ' (newline) or '\r\n        ' (Windows newline)\r\n```\r\n\r\nThey need to be escaped appropriately. 👍 ","created_at":"2018-09-12T18:33:53Z","updated_at":"2018-09-12T18:55:55Z","html_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/5734#discussion_r217143046","pull_request_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/5734","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments/217143046"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-aws/pull/5734#discussion_r217143046"},"pull_request":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/5734"}}},"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/5734","id":212084083,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMDg0MDgz","html_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/5734","diff_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/5734.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-aws/pull/5734.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/5734","number":5734,"state":"open","locked":false,"title":"Add 'Seperator' property to AWS IoT Firehose Rule","user":{"login":"bdoepf","id":10085760,"node_id":"MDQ6VXNlcjEwMDg1NzYw","avatar_url":"https://avatars0.githubusercontent.com/u/10085760?v=4","gravatar_id":"","url":"https://api.github.com/users/bdoepf","html_url":"https://github.com/bdoepf","followers_url":"https://api.github.com/users/bdoepf/followers","following_url":"https://api.github.com/users/bdoepf/following{/other_user}","gists_url":"https://api.github.com/users/bdoepf/gists{/gist_id}","starred_url":"https://api.github.com/users/bdoepf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdoepf/subscriptions","organizations_url":"https://api.github.com/users/bdoepf/orgs","repos_url":"https://api.github.com/users/bdoepf/repos","events_url":"https://api.github.com/users/bdoepf/events{/privacy}","received_events_url":"https://api.github.com/users/bdoepf/received_events","type":"User","site_admin":false},"body":"<!--- Information about referencing Github Issues: https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests --->\r\nFixes #5733\r\n\r\nChanges proposed in this pull request:\r\n\r\n* Add 'separator' property to AWS IoT Core Firehose topic rule action.\r\n\r\nOutput from acceptance testing:\r\n\r\n```\r\n$ make testacc TESTARGS='-run=TestAccAWSIoTTopicRule_firehose'\r\n==> Checking that code complies with gofmt requirements...\r\nTF_ACC=1 go test ./... -v -run=TestAccAWSIoTTopicRule_firehose -timeout 120m\r\n?   \tgithub.com/terraform-providers/terraform-provider-aws\t[no test files]\r\n=== RUN   TestAccAWSIoTTopicRule_firehose\r\n--- PASS: TestAccAWSIoTTopicRule_firehose (29.68s)\r\nPASS\r\nok  \tgithub.com/terraform-providers/terraform-provider-aws/aws\t29.698s\r\n```","created_at":"2018-08-30T13:42:47Z","updated_at":"2018-09-12T18:55:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6e1570334fcd187539f119c4b0513e24630b206","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":620316241,"node_id":"MDU6TGFiZWw2MjAzMTYyNDE=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/enhancement","name":"enhancement","color":"d4c5f9","default":true},{"id":806430889,"node_id":"MDU6TGFiZWw4MDY0MzA4ODk=","url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels/service/iot","name":"service/iot","color":"bfd4f2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/5734/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/5734/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/5734/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/d0464c975ffcabaec53c04e934d90b2bddaa92bd","head":{"label":"bdoepf:add-iot-firehose-rule-separator-property","ref":"add-iot-firehose-rule-separator-property","sha":"d0464c975ffcabaec53c04e934d90b2bddaa92bd","user":{"login":"bdoepf","id":10085760,"node_id":"MDQ6VXNlcjEwMDg1NzYw","avatar_url":"https://avatars0.githubusercontent.com/u/10085760?v=4","gravatar_id":"","url":"https://api.github.com/users/bdoepf","html_url":"https://github.com/bdoepf","followers_url":"https://api.github.com/users/bdoepf/followers","following_url":"https://api.github.com/users/bdoepf/following{/other_user}","gists_url":"https://api.github.com/users/bdoepf/gists{/gist_id}","starred_url":"https://api.github.com/users/bdoepf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdoepf/subscriptions","organizations_url":"https://api.github.com/users/bdoepf/orgs","repos_url":"https://api.github.com/users/bdoepf/repos","events_url":"https://api.github.com/users/bdoepf/events{/privacy}","received_events_url":"https://api.github.com/users/bdoepf/received_events","type":"User","site_admin":false},"repo":{"id":145865353,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4NjUzNTM=","name":"terraform-provider-aws","full_name":"bdoepf/terraform-provider-aws","owner":{"login":"bdoepf","id":10085760,"node_id":"MDQ6VXNlcjEwMDg1NzYw","avatar_url":"https://avatars0.githubusercontent.com/u/10085760?v=4","gravatar_id":"","url":"https://api.github.com/users/bdoepf","html_url":"https://github.com/bdoepf","followers_url":"https://api.github.com/users/bdoepf/followers","following_url":"https://api.github.com/users/bdoepf/following{/other_user}","gists_url":"https://api.github.com/users/bdoepf/gists{/gist_id}","starred_url":"https://api.github.com/users/bdoepf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdoepf/subscriptions","organizations_url":"https://api.github.com/users/bdoepf/orgs","repos_url":"https://api.github.com/users/bdoepf/repos","events_url":"https://api.github.com/users/bdoepf/events{/privacy}","received_events_url":"https://api.github.com/users/bdoepf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bdoepf/terraform-provider-aws","description":"Terraform AWS provider","fork":true,"url":"https://api.github.com/repos/bdoepf/terraform-provider-aws","forks_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/forks","keys_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/teams","hooks_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/hooks","issue_events_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/issues/events{/number}","events_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/events","assignees_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/assignees{/user}","branches_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/branches{/branch}","tags_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/tags","blobs_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/languages","stargazers_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/stargazers","contributors_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/contributors","subscribers_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/subscribers","subscription_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/subscription","commits_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/contents/{+path}","compare_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/merges","archive_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/downloads","issues_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/issues{/number}","pulls_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/labels{/name}","releases_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/releases{/id}","deployments_url":"https://api.github.com/repos/bdoepf/terraform-provider-aws/deployments","created_at":"2018-08-23T14:29:53Z","updated_at":"2018-08-23T14:30:01Z","pushed_at":"2018-08-30T13:36:32Z","git_url":"git://github.com/bdoepf/terraform-provider-aws.git","ssh_url":"git@github.com:bdoepf/terraform-provider-aws.git","clone_url":"https://github.com/bdoepf/terraform-provider-aws.git","svn_url":"https://github.com/bdoepf/terraform-provider-aws","homepage":"https://www.terraform.io/docs/providers/aws/","size":50050,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"9668f874d2a6ca1c8653f788ecc5861305f728ff","user":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93444615,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQ0NDYxNQ==","name":"terraform-provider-aws","full_name":"terraform-providers/terraform-provider-aws","owner":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/terraform-providers/terraform-provider-aws","description":"Terraform AWS provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/deployments","created_at":"2017-06-05T20:37:52Z","updated_at":"2018-09-12T18:20:39Z","pushed_at":"2018-09-12T18:52:42Z","git_url":"git://github.com/terraform-providers/terraform-provider-aws.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-aws.git","clone_url":"https://github.com/terraform-providers/terraform-provider-aws.git","svn_url":"https://github.com/terraform-providers/terraform-provider-aws","homepage":"https://www.terraform.io/docs/providers/aws/","size":50926,"stargazers_count":1570,"watchers_count":1570,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1368,"mirror_url":null,"archived":false,"open_issues_count":1894,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":1368,"open_issues":1894,"watchers":1570,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/5734"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-aws/pull/5734"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/5734"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/issues/5734/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/5734/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/pulls/5734/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-aws/statuses/d0464c975ffcabaec53c04e934d90b2bddaa92bd"}},"author_association":"NONE"}}
{"actor":{"display_login":"bflad"}}