{"action":"created","comment":{"url":"https://api.github.com/repos/modern-web-application-uw18/week5/pulls/comments/195892411","pull_request_review_id":129351770,"id":195892411,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTg5MjQxMQ==","diff_hunk":"@@ -0,0 +1,42 @@\n+import React, { Component } from 'react';\n+import './PersonCard.css';\n+import {\n+  Link\n+} from \"react-router-dom\";\n+import PropTypes from 'prop-types';\n+\n+class PersonCard extends Component {\n+\n+  render() {\n+    const people = this.props.people;\n+    const url = people.url;\n+    const indexNumber = url.split('/').reverse()[1];\n+    const backgroundMediaStyles = {\n+        backgroundImage: 'url(\\'/characters/character-' + indexNumber + '.jpg\\')',\n+    };\n+    return (\n+\n+      <div className=\"person-card\">\n+      <Link to={`/people/${indexNumber}`} style={{ textDecoration: 'none' }}>\n+        <div className=\"media\" style={backgroundMediaStyles}></div>\n+        <div className=\"container\">\n+          <p className=\"styleized-font\"><span>{people.name}</span></p>\n+          <h1>{people.name}</h1>\n+        </div>\n+        </Link>\n+      </div>\n+    )\n+  }\n+}\n+\n+// these PropTypes do not appear to work:\n+\n+PersonCard.propTypes = {\n+  people: PropTypes.object.isRequired,","path":"star-wars-films/src/PersonCard/PersonCard.js","position":35,"original_position":35,"commit_id":"12fd7c862b038d84097255bc5e40437ed744b621","original_commit_id":"12fd7c862b038d84097255bc5e40437ed744b621","user":{"login":"irenab1","id":22483633,"node_id":"MDQ6VXNlcjIyNDgzNjMz","avatar_url":"https://avatars3.githubusercontent.com/u/22483633?v=4","gravatar_id":"","url":"https://api.github.com/users/irenab1","html_url":"https://github.com/irenab1","followers_url":"https://api.github.com/users/irenab1/followers","following_url":"https://api.github.com/users/irenab1/following{/other_user}","gists_url":"https://api.github.com/users/irenab1/gists{/gist_id}","starred_url":"https://api.github.com/users/irenab1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irenab1/subscriptions","organizations_url":"https://api.github.com/users/irenab1/orgs","repos_url":"https://api.github.com/users/irenab1/repos","events_url":"https://api.github.com/users/irenab1/events{/privacy}","received_events_url":"https://api.github.com/users/irenab1/received_events","type":"User","site_admin":false},"body":"I'd remove line 35","created_at":"2018-06-16T03:15:07Z","updated_at":"2018-06-16T03:21:47Z","html_url":"https://github.com/modern-web-application-uw18/week5/pull/4#discussion_r195892411","pull_request_url":"https://api.github.com/repos/modern-web-application-uw18/week5/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/modern-web-application-uw18/week5/pulls/comments/195892411"},"html":{"href":"https://github.com/modern-web-application-uw18/week5/pull/4#discussion_r195892411"},"pull_request":{"href":"https://api.github.com/repos/modern-web-application-uw18/week5/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/modern-web-application-uw18/week5/pulls/4","id":190992430,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwOTkyNDMw","html_url":"https://github.com/modern-web-application-uw18/week5/pull/4","diff_url":"https://github.com/modern-web-application-uw18/week5/pull/4.diff","patch_url":"https://github.com/modern-web-application-uw18/week5/pull/4.patch","issue_url":"https://api.github.com/repos/modern-web-application-uw18/week5/issues/4","number":4,"state":"open","locked":false,"title":"Star Wars Characters project","user":{"login":"sheyna","id":8682366,"node_id":"MDQ6VXNlcjg2ODIzNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/8682366?v=4","gravatar_id":"","url":"https://api.github.com/users/sheyna","html_url":"https://github.com/sheyna","followers_url":"https://api.github.com/users/sheyna/followers","following_url":"https://api.github.com/users/sheyna/following{/other_user}","gists_url":"https://api.github.com/users/sheyna/gists{/gist_id}","starred_url":"https://api.github.com/users/sheyna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheyna/subscriptions","organizations_url":"https://api.github.com/users/sheyna/orgs","repos_url":"https://api.github.com/users/sheyna/repos","events_url":"https://api.github.com/users/sheyna/events{/privacy}","received_events_url":"https://api.github.com/users/sheyna/received_events","type":"User","site_admin":false},"body":"# Week 1 HW Submission\r\n\r\nPlease fill out the information below in order to complete your assignment. Feel free to update this comment later if necessary.\r\n\r\n* Comfort rating on this assignment (1-5): 3\r\nI had already figured out route in last week's assignment, but I had problems with getting the tests to take the data from the api in one case. And for some reason most of my PropTypes didn't seem to take.\r\n\r\n* Completion rating on this assignment (complete/incomplete): Look at my PropTypes and PersonCard.test.js, those would be the problem areas.\r\n \r\n* Github handles of code I've reviewed (if any):\r\n","created_at":"2018-05-28T20:24:13Z","updated_at":"2018-06-16T03:21:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebda53ce7a80326695958373c459a2f096fc1aca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/modern-web-application-uw18/week5/pulls/4/commits","review_comments_url":"https://api.github.com/repos/modern-web-application-uw18/week5/pulls/4/comments","review_comment_url":"https://api.github.com/repos/modern-web-application-uw18/week5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/modern-web-application-uw18/week5/issues/4/comments","statuses_url":"https://api.github.com/repos/modern-web-application-uw18/week5/statuses/12fd7c862b038d84097255bc5e40437ed744b621","head":{"label":"sheyna:master","ref":"master","sha":"12fd7c862b038d84097255bc5e40437ed744b621","user":{"login":"sheyna","id":8682366,"node_id":"MDQ6VXNlcjg2ODIzNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/8682366?v=4","gravatar_id":"","url":"https://api.github.com/users/sheyna","html_url":"https://github.com/sheyna","followers_url":"https://api.github.com/users/sheyna/followers","following_url":"https://api.github.com/users/sheyna/following{/other_user}","gists_url":"https://api.github.com/users/sheyna/gists{/gist_id}","starred_url":"https://api.github.com/users/sheyna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheyna/subscriptions","organizations_url":"https://api.github.com/users/sheyna/orgs","repos_url":"https://api.github.com/users/sheyna/repos","events_url":"https://api.github.com/users/sheyna/events{/privacy}","received_events_url":"https://api.github.com/users/sheyna/received_events","type":"User","site_admin":false},"repo":{"id":134096746,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQwOTY3NDY=","name":"week5","full_name":"sheyna/week5","owner":{"login":"sheyna","id":8682366,"node_id":"MDQ6VXNlcjg2ODIzNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/8682366?v=4","gravatar_id":"","url":"https://api.github.com/users/sheyna","html_url":"https://github.com/sheyna","followers_url":"https://api.github.com/users/sheyna/followers","following_url":"https://api.github.com/users/sheyna/following{/other_user}","gists_url":"https://api.github.com/users/sheyna/gists{/gist_id}","starred_url":"https://api.github.com/users/sheyna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheyna/subscriptions","organizations_url":"https://api.github.com/users/sheyna/orgs","repos_url":"https://api.github.com/users/sheyna/repos","events_url":"https://api.github.com/users/sheyna/events{/privacy}","received_events_url":"https://api.github.com/users/sheyna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sheyna/week5","description":"Week 5 Assignment","fork":true,"url":"https://api.github.com/repos/sheyna/week5","forks_url":"https://api.github.com/repos/sheyna/week5/forks","keys_url":"https://api.github.com/repos/sheyna/week5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sheyna/week5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sheyna/week5/teams","hooks_url":"https://api.github.com/repos/sheyna/week5/hooks","issue_events_url":"https://api.github.com/repos/sheyna/week5/issues/events{/number}","events_url":"https://api.github.com/repos/sheyna/week5/events","assignees_url":"https://api.github.com/repos/sheyna/week5/assignees{/user}","branches_url":"https://api.github.com/repos/sheyna/week5/branches{/branch}","tags_url":"https://api.github.com/repos/sheyna/week5/tags","blobs_url":"https://api.github.com/repos/sheyna/week5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sheyna/week5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sheyna/week5/git/refs{/sha}","trees_url":"https://api.github.com/repos/sheyna/week5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sheyna/week5/statuses/{sha}","languages_url":"https://api.github.com/repos/sheyna/week5/languages","stargazers_url":"https://api.github.com/repos/sheyna/week5/stargazers","contributors_url":"https://api.github.com/repos/sheyna/week5/contributors","subscribers_url":"https://api.github.com/repos/sheyna/week5/subscribers","subscription_url":"https://api.github.com/repos/sheyna/week5/subscription","commits_url":"https://api.github.com/repos/sheyna/week5/commits{/sha}","git_commits_url":"https://api.github.com/repos/sheyna/week5/git/commits{/sha}","comments_url":"https://api.github.com/repos/sheyna/week5/comments{/number}","issue_comment_url":"https://api.github.com/repos/sheyna/week5/issues/comments{/number}","contents_url":"https://api.github.com/repos/sheyna/week5/contents/{+path}","compare_url":"https://api.github.com/repos/sheyna/week5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sheyna/week5/merges","archive_url":"https://api.github.com/repos/sheyna/week5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sheyna/week5/downloads","issues_url":"https://api.github.com/repos/sheyna/week5/issues{/number}","pulls_url":"https://api.github.com/repos/sheyna/week5/pulls{/number}","milestones_url":"https://api.github.com/repos/sheyna/week5/milestones{/number}","notifications_url":"https://api.github.com/repos/sheyna/week5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sheyna/week5/labels{/name}","releases_url":"https://api.github.com/repos/sheyna/week5/releases{/id}","deployments_url":"https://api.github.com/repos/sheyna/week5/deployments","created_at":"2018-05-19T20:44:08Z","updated_at":"2018-05-28T20:16:49Z","pushed_at":"2018-05-28T20:16:48Z","git_url":"git://github.com/sheyna/week5.git","ssh_url":"git@github.com:sheyna/week5.git","clone_url":"https://github.com/sheyna/week5.git","svn_url":"https://github.com/sheyna/week5","homepage":null,"size":1393,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"modern-web-application-uw18:master","ref":"master","sha":"b750d91b108596f2bcff75485ab91fa498605e9c","user":{"login":"modern-web-application-uw18","id":36337123,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzM3MTIz","avatar_url":"https://avatars3.githubusercontent.com/u/36337123?v=4","gravatar_id":"","url":"https://api.github.com/users/modern-web-application-uw18","html_url":"https://github.com/modern-web-application-uw18","followers_url":"https://api.github.com/users/modern-web-application-uw18/followers","following_url":"https://api.github.com/users/modern-web-application-uw18/following{/other_user}","gists_url":"https://api.github.com/users/modern-web-application-uw18/gists{/gist_id}","starred_url":"https://api.github.com/users/modern-web-application-uw18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modern-web-application-uw18/subscriptions","organizations_url":"https://api.github.com/users/modern-web-application-uw18/orgs","repos_url":"https://api.github.com/users/modern-web-application-uw18/repos","events_url":"https://api.github.com/users/modern-web-application-uw18/events{/privacy}","received_events_url":"https://api.github.com/users/modern-web-application-uw18/received_events","type":"Organization","site_admin":false},"repo":{"id":133118988,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMxMTg5ODg=","name":"week5","full_name":"modern-web-application-uw18/week5","owner":{"login":"modern-web-application-uw18","id":36337123,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MzM3MTIz","avatar_url":"https://avatars3.githubusercontent.com/u/36337123?v=4","gravatar_id":"","url":"https://api.github.com/users/modern-web-application-uw18","html_url":"https://github.com/modern-web-application-uw18","followers_url":"https://api.github.com/users/modern-web-application-uw18/followers","following_url":"https://api.github.com/users/modern-web-application-uw18/following{/other_user}","gists_url":"https://api.github.com/users/modern-web-application-uw18/gists{/gist_id}","starred_url":"https://api.github.com/users/modern-web-application-uw18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modern-web-application-uw18/subscriptions","organizations_url":"https://api.github.com/users/modern-web-application-uw18/orgs","repos_url":"https://api.github.com/users/modern-web-application-uw18/repos","events_url":"https://api.github.com/users/modern-web-application-uw18/events{/privacy}","received_events_url":"https://api.github.com/users/modern-web-application-uw18/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/modern-web-application-uw18/week5","description":"Week 5 Assignment","fork":false,"url":"https://api.github.com/repos/modern-web-application-uw18/week5","forks_url":"https://api.github.com/repos/modern-web-application-uw18/week5/forks","keys_url":"https://api.github.com/repos/modern-web-application-uw18/week5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modern-web-application-uw18/week5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modern-web-application-uw18/week5/teams","hooks_url":"https://api.github.com/repos/modern-web-application-uw18/week5/hooks","issue_events_url":"https://api.github.com/repos/modern-web-application-uw18/week5/issues/events{/number}","events_url":"https://api.github.com/repos/modern-web-application-uw18/week5/events","assignees_url":"https://api.github.com/repos/modern-web-application-uw18/week5/assignees{/user}","branches_url":"https://api.github.com/repos/modern-web-application-uw18/week5/branches{/branch}","tags_url":"https://api.github.com/repos/modern-web-application-uw18/week5/tags","blobs_url":"https://api.github.com/repos/modern-web-application-uw18/week5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modern-web-application-uw18/week5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modern-web-application-uw18/week5/git/refs{/sha}","trees_url":"https://api.github.com/repos/modern-web-application-uw18/week5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modern-web-application-uw18/week5/statuses/{sha}","languages_url":"https://api.github.com/repos/modern-web-application-uw18/week5/languages","stargazers_url":"https://api.github.com/repos/modern-web-application-uw18/week5/stargazers","contributors_url":"https://api.github.com/repos/modern-web-application-uw18/week5/contributors","subscribers_url":"https://api.github.com/repos/modern-web-application-uw18/week5/subscribers","subscription_url":"https://api.github.com/repos/modern-web-application-uw18/week5/subscription","commits_url":"https://api.github.com/repos/modern-web-application-uw18/week5/commits{/sha}","git_commits_url":"https://api.github.com/repos/modern-web-application-uw18/week5/git/commits{/sha}","comments_url":"https://api.github.com/repos/modern-web-application-uw18/week5/comments{/number}","issue_comment_url":"https://api.github.com/repos/modern-web-application-uw18/week5/issues/comments{/number}","contents_url":"https://api.github.com/repos/modern-web-application-uw18/week5/contents/{+path}","compare_url":"https://api.github.com/repos/modern-web-application-uw18/week5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modern-web-application-uw18/week5/merges","archive_url":"https://api.github.com/repos/modern-web-application-uw18/week5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modern-web-application-uw18/week5/downloads","issues_url":"https://api.github.com/repos/modern-web-application-uw18/week5/issues{/number}","pulls_url":"https://api.github.com/repos/modern-web-application-uw18/week5/pulls{/number}","milestones_url":"https://api.github.com/repos/modern-web-application-uw18/week5/milestones{/number}","notifications_url":"https://api.github.com/repos/modern-web-application-uw18/week5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modern-web-application-uw18/week5/labels{/name}","releases_url":"https://api.github.com/repos/modern-web-application-uw18/week5/releases{/id}","deployments_url":"https://api.github.com/repos/modern-web-application-uw18/week5/deployments","created_at":"2018-05-12T06:06:23Z","updated_at":"2018-05-12T06:06:42Z","pushed_at":"2018-06-15T19:05:25Z","git_url":"git://github.com/modern-web-application-uw18/week5.git","ssh_url":"git@github.com:modern-web-application-uw18/week5.git","clone_url":"https://github.com/modern-web-application-uw18/week5.git","svn_url":"https://github.com/modern-web-application-uw18/week5","homepage":null,"size":1,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":21,"license":null,"forks":26,"open_issues":21,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/modern-web-application-uw18/week5/pulls/4"},"html":{"href":"https://github.com/modern-web-application-uw18/week5/pull/4"},"issue":{"href":"https://api.github.com/repos/modern-web-application-uw18/week5/issues/4"},"comments":{"href":"https://api.github.com/repos/modern-web-application-uw18/week5/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/modern-web-application-uw18/week5/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/modern-web-application-uw18/week5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/modern-web-application-uw18/week5/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/modern-web-application-uw18/week5/statuses/12fd7c862b038d84097255bc5e40437ed744b621"}},"author_association":"NONE"}}
{"actor":{"display_login":"irenab1"}}