{"action":"created","issue":{"url":"https://api.github.com/repos/uber/deck.gl/issues/2468","repository_url":"https://api.github.com/repos/uber/deck.gl","labels_url":"https://api.github.com/repos/uber/deck.gl/issues/2468/labels{/name}","comments_url":"https://api.github.com/repos/uber/deck.gl/issues/2468/comments","events_url":"https://api.github.com/repos/uber/deck.gl/issues/2468/events","html_url":"https://github.com/uber/deck.gl/issues/2468","id":385849457,"node_id":"MDU6SXNzdWUzODU4NDk0NTc=","number":2468,"title":"highlightColor doesn't work on HexagonLayer","user":{"login":"contra","id":425716,"node_id":"MDQ6VXNlcjQyNTcxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/425716?v=4","gravatar_id":"","url":"https://api.github.com/users/contra","html_url":"https://github.com/contra","followers_url":"https://api.github.com/users/contra/followers","following_url":"https://api.github.com/users/contra/following{/other_user}","gists_url":"https://api.github.com/users/contra/gists{/gist_id}","starred_url":"https://api.github.com/users/contra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contra/subscriptions","organizations_url":"https://api.github.com/users/contra/orgs","repos_url":"https://api.github.com/users/contra/repos","events_url":"https://api.github.com/users/contra/events{/privacy}","received_events_url":"https://api.github.com/users/contra/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"1chandu","id":9502731,"node_id":"MDQ6VXNlcjk1MDI3MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/9502731?v=4","gravatar_id":"","url":"https://api.github.com/users/1chandu","html_url":"https://github.com/1chandu","followers_url":"https://api.github.com/users/1chandu/followers","following_url":"https://api.github.com/users/1chandu/following{/other_user}","gists_url":"https://api.github.com/users/1chandu/gists{/gist_id}","starred_url":"https://api.github.com/users/1chandu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1chandu/subscriptions","organizations_url":"https://api.github.com/users/1chandu/orgs","repos_url":"https://api.github.com/users/1chandu/repos","events_url":"https://api.github.com/users/1chandu/events{/privacy}","received_events_url":"https://api.github.com/users/1chandu/received_events","type":"User","site_admin":false},"assignees":[{"login":"1chandu","id":9502731,"node_id":"MDQ6VXNlcjk1MDI3MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/9502731?v=4","gravatar_id":"","url":"https://api.github.com/users/1chandu","html_url":"https://github.com/1chandu","followers_url":"https://api.github.com/users/1chandu/followers","following_url":"https://api.github.com/users/1chandu/following{/other_user}","gists_url":"https://api.github.com/users/1chandu/gists{/gist_id}","starred_url":"https://api.github.com/users/1chandu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1chandu/subscriptions","organizations_url":"https://api.github.com/users/1chandu/orgs","repos_url":"https://api.github.com/users/1chandu/repos","events_url":"https://api.github.com/users/1chandu/events{/privacy}","received_events_url":"https://api.github.com/users/1chandu/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-11-29T17:38:42Z","updated_at":"2018-12-02T06:16:26Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"![kapture 2018-11-29 at 12 41 28](https://user-images.githubusercontent.com/425716/49240816-2722ab80-f3d4-11e8-8776-0845d3489a77.gif)\r\n\r\n`autoHighlight` works great on the hexagon layer, but the color seems to be ignored and the default is used. This would also be a good opportunity to document these options for the hexagon layer. If this seems uncontroversial I'd be happy to submit a PR - let me know.\r\n\r\n#### Actual Result\r\n\r\nHighlighting is the default `cyan` highlightColor.\r\n\r\n#### Expected Result\r\n\r\nHighlighting would be black, given the code sample below.\r\n\r\n#### Code Example\r\n\r\n```js\r\n  new HexagonLayer({\r\n    id: 'test',\r\n\tdata,\r\n    extruded: true,\r\n    radius: 25,\r\n    autoHighlight: true,\r\n    highlightColor: [ 0, 0, 0 ]\r\n  })\r\n```\r\n\r\n#### To Do List <!-- For developer only -->\r\n  - [ ] Add label and assign to milestone\r\n  - [ ] Coding\r\n  - [ ] Test\r\n\r\n<!-- If it is feature/enhancement -->\r\n#### Background <!-- RFC or feature description -->\r\n#### To Do List <!-- For developer only -->\r\n  - [ ] Add label and assign to milestone <!-- Must be major or minor milestone -->\r\n  - [ ] Coding\r\n  - [ ] Doc update\r\n  - [ ] Whats new update <!-- If feature is visible to user -->\r\n  - [ ] Test\r\n"},"comment":{"url":"https://api.github.com/repos/uber/deck.gl/issues/comments/443484715","html_url":"https://github.com/uber/deck.gl/issues/2468#issuecomment-443484715","issue_url":"https://api.github.com/repos/uber/deck.gl/issues/2468","id":443484715,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzQ4NDcxNQ==","user":{"login":"1chandu","id":9502731,"node_id":"MDQ6VXNlcjk1MDI3MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/9502731?v=4","gravatar_id":"","url":"https://api.github.com/users/1chandu","html_url":"https://github.com/1chandu","followers_url":"https://api.github.com/users/1chandu/followers","following_url":"https://api.github.com/users/1chandu/following{/other_user}","gists_url":"https://api.github.com/users/1chandu/gists{/gist_id}","starred_url":"https://api.github.com/users/1chandu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1chandu/subscriptions","organizations_url":"https://api.github.com/users/1chandu/orgs","repos_url":"https://api.github.com/users/1chandu/repos","events_url":"https://api.github.com/users/1chandu/events{/privacy}","received_events_url":"https://api.github.com/users/1chandu/received_events","type":"User","site_admin":false},"created_at":"2018-12-02T06:16:26Z","updated_at":"2018-12-02T06:16:26Z","author_association":"CONTRIBUTOR","body":"@contra , you should see following warnings from luma and webgl : \r\n```\r\nluma: Uniform size should be multiples of 4 (3) [0, 0, 0]\r\nuniforms.js:16 WebGL: INVALID_VALUE: uniform4fv: invalid size\r\n```\r\nI  will update the code to append alpha value similar to how we handle any other color values."}}
{"actor":{"display_login":"1chandu"}}