{"action":"created","issue":{"url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/1376","repository_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage","labels_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/1376/labels{/name}","comments_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/1376/comments","events_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/1376/events","html_url":"https://github.com/samselikoff/ember-cli-mirage/pull/1376","id":353069738,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMjIyNjI2","number":1376,"title":"Use instanceof and overrides to distinguish associations","user":{"login":"jamescdavis","id":348630,"node_id":"MDQ6VXNlcjM0ODYzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/348630?v=4","gravatar_id":"","url":"https://api.github.com/users/jamescdavis","html_url":"https://github.com/jamescdavis","followers_url":"https://api.github.com/users/jamescdavis/followers","following_url":"https://api.github.com/users/jamescdavis/following{/other_user}","gists_url":"https://api.github.com/users/jamescdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescdavis/subscriptions","organizations_url":"https://api.github.com/users/jamescdavis/orgs","repos_url":"https://api.github.com/users/jamescdavis/repos","events_url":"https://api.github.com/users/jamescdavis/events{/privacy}","received_events_url":"https://api.github.com/users/jamescdavis/received_events","type":"User","site_admin":false},"labels":[{"id":171422338,"node_id":"MDU6TGFiZWwxNzE0MjIzMzg=","url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/labels/Bug","name":"Bug","color":"e11d21","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-08-22T18:24:27Z","updated_at":"2018-11-19T16:22:48Z","closed_at":"2018-11-19T16:17:54Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/pulls/1376","html_url":"https://github.com/samselikoff/ember-cli-mirage/pull/1376","diff_url":"https://github.com/samselikoff/ember-cli-mirage/pull/1376.diff","patch_url":"https://github.com/samselikoff/ember-cli-mirage/pull/1376.patch"},"body":"Similarly to #1092 and #1168, https://github.com/samselikoff/ember-cli-mirage/blob/99c927009a539f7e1fbfb8f6e857372e2319856b/addon/orm/associations/association.js#L52-L54 and https://github.com/samselikoff/ember-cli-mirage/blob/99c927009a539f7e1fbfb8f6e857372e2319856b/addon/orm/associations/association.js#L56-L58 fail in production builds due to minification.\r\n\r\nThis PR replaces usages of `isHasMany` and `isBelongsTo` with `instanceof` and uses overrides within the associations classes themselves (for `identifier`)."},"comment":{"url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/comments/439952404","html_url":"https://github.com/samselikoff/ember-cli-mirage/pull/1376#issuecomment-439952404","issue_url":"https://api.github.com/repos/samselikoff/ember-cli-mirage/issues/1376","id":439952404,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTk1MjQwNA==","user":{"login":"jamescdavis","id":348630,"node_id":"MDQ6VXNlcjM0ODYzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/348630?v=4","gravatar_id":"","url":"https://api.github.com/users/jamescdavis","html_url":"https://github.com/jamescdavis","followers_url":"https://api.github.com/users/jamescdavis/followers","following_url":"https://api.github.com/users/jamescdavis/following{/other_user}","gists_url":"https://api.github.com/users/jamescdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/jamescdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamescdavis/subscriptions","organizations_url":"https://api.github.com/users/jamescdavis/orgs","repos_url":"https://api.github.com/users/jamescdavis/repos","events_url":"https://api.github.com/users/jamescdavis/events{/privacy}","received_events_url":"https://api.github.com/users/jamescdavis/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T16:22:48Z","updated_at":"2018-11-19T16:22:48Z","author_association":"CONTRIBUTOR","body":"Thanks, @samselikoff!"}}
{"actor":{"display_login":"jamescdavis"}}