{"action":"created","comment":{"url":"https://api.github.com/repos/rstudio/sparklyr/pulls/comments/231253107","pull_request_review_id":172183816,"id":231253107,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTI1MzEwNw==","diff_hunk":"@@ -10,6 +11,27 @@\n   not yet implemented in Spark.\n   \n - Support for collecting NA values from logical columns (#1729).\n+||||||| merged common ancestors\n+<<<<<<<<< Temporary merge branch 1","path":"NEWS.md","position":10,"original_position":10,"commit_id":"1609b90b54102f61727d181d68922f3165831c2e","original_commit_id":"1609b90b54102f61727d181d68922f3165831c2e","user":{"login":"javierluraschi","id":3478847,"node_id":"MDQ6VXNlcjM0Nzg4NDc=","avatar_url":"https://avatars1.githubusercontent.com/u/3478847?v=4","gravatar_id":"","url":"https://api.github.com/users/javierluraschi","html_url":"https://github.com/javierluraschi","followers_url":"https://api.github.com/users/javierluraschi/followers","following_url":"https://api.github.com/users/javierluraschi/following{/other_user}","gists_url":"https://api.github.com/users/javierluraschi/gists{/gist_id}","starred_url":"https://api.github.com/users/javierluraschi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierluraschi/subscriptions","organizations_url":"https://api.github.com/users/javierluraschi/orgs","repos_url":"https://api.github.com/users/javierluraschi/repos","events_url":"https://api.github.com/users/javierluraschi/events{/privacy}","received_events_url":"https://api.github.com/users/javierluraschi/received_events","type":"User","site_admin":false},"body":"I believe you mentioned you are planning to fix this merge conflicts, just adding this note to make sure we don't forget.","created_at":"2018-11-06T19:08:43Z","updated_at":"2018-11-06T19:08:43Z","html_url":"https://github.com/rstudio/sparklyr/pull/1747#discussion_r231253107","pull_request_url":"https://api.github.com/repos/rstudio/sparklyr/pulls/1747","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rstudio/sparklyr/pulls/comments/231253107"},"html":{"href":"https://github.com/rstudio/sparklyr/pull/1747#discussion_r231253107"},"pull_request":{"href":"https://api.github.com/repos/rstudio/sparklyr/pulls/1747"}}},"pull_request":{"url":"https://api.github.com/repos/rstudio/sparklyr/pulls/1747","id":228152678,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTUyNjc4","html_url":"https://github.com/rstudio/sparklyr/pull/1747","diff_url":"https://github.com/rstudio/sparklyr/pull/1747.diff","patch_url":"https://github.com/rstudio/sparklyr/pull/1747.patch","issue_url":"https://api.github.com/repos/rstudio/sparklyr/issues/1747","number":1747,"state":"open","locked":false,"title":"Broom for mlp","user":{"login":"samuelmacedo83","id":21323641,"node_id":"MDQ6VXNlcjIxMzIzNjQx","avatar_url":"https://avatars1.githubusercontent.com/u/21323641?v=4","gravatar_id":"","url":"https://api.github.com/users/samuelmacedo83","html_url":"https://github.com/samuelmacedo83","followers_url":"https://api.github.com/users/samuelmacedo83/followers","following_url":"https://api.github.com/users/samuelmacedo83/following{/other_user}","gists_url":"https://api.github.com/users/samuelmacedo83/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelmacedo83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelmacedo83/subscriptions","organizations_url":"https://api.github.com/users/samuelmacedo83/orgs","repos_url":"https://api.github.com/users/samuelmacedo83/repos","events_url":"https://api.github.com/users/samuelmacedo83/events{/privacy}","received_events_url":"https://api.github.com/users/samuelmacedo83/received_events","type":"User","site_admin":false},"body":"hi @javierluraschi ,\r\n\r\nI've finished broom for ml_multilayer_perceptron_classifer(). For tidy() I created a data frame with the weight matrix by layer and for glance() I just put the number of nodes in each layer.\r\nI add num_classes in new_ml_multilayer_perceptron_classification_model(), because broom_augment_supervised() need this. \r\nI didn't update NEWS.md yet, I'll put after the reviews.\r\n\r\n```\r\nsc <-  spark_connect(master = \"local\")\r\n\r\niris_tbl <- sdf_copy_to(sc, iris, name = \"iris_tbl\", overwrite = TRUE)\r\n\r\nmlp_model <- iris_tbl %>%\r\n  ml_multilayer_perceptron_classifier(Species ~ ., layers = c(4,3,2,3))\r\n\r\ntidy(mlp_model)\r\naugment(mlp_model)\r\nglance(mlp_model)\r\n```\r\n","created_at":"2018-11-04T02:04:21Z","updated_at":"2018-11-06T19:08:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a13342547c791667f3aab65c034f41bcf56a90eb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rstudio/sparklyr/pulls/1747/commits","review_comments_url":"https://api.github.com/repos/rstudio/sparklyr/pulls/1747/comments","review_comment_url":"https://api.github.com/repos/rstudio/sparklyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rstudio/sparklyr/issues/1747/comments","statuses_url":"https://api.github.com/repos/rstudio/sparklyr/statuses/1609b90b54102f61727d181d68922f3165831c2e","head":{"label":"samuelmacedo83:broom-mlp","ref":"broom-mlp","sha":"1609b90b54102f61727d181d68922f3165831c2e","user":{"login":"samuelmacedo83","id":21323641,"node_id":"MDQ6VXNlcjIxMzIzNjQx","avatar_url":"https://avatars1.githubusercontent.com/u/21323641?v=4","gravatar_id":"","url":"https://api.github.com/users/samuelmacedo83","html_url":"https://github.com/samuelmacedo83","followers_url":"https://api.github.com/users/samuelmacedo83/followers","following_url":"https://api.github.com/users/samuelmacedo83/following{/other_user}","gists_url":"https://api.github.com/users/samuelmacedo83/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelmacedo83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelmacedo83/subscriptions","organizations_url":"https://api.github.com/users/samuelmacedo83/orgs","repos_url":"https://api.github.com/users/samuelmacedo83/repos","events_url":"https://api.github.com/users/samuelmacedo83/events{/privacy}","received_events_url":"https://api.github.com/users/samuelmacedo83/received_events","type":"User","site_admin":false},"repo":{"id":130512463,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA1MTI0NjM=","name":"sparklyr","full_name":"samuelmacedo83/sparklyr","private":false,"owner":{"login":"samuelmacedo83","id":21323641,"node_id":"MDQ6VXNlcjIxMzIzNjQx","avatar_url":"https://avatars1.githubusercontent.com/u/21323641?v=4","gravatar_id":"","url":"https://api.github.com/users/samuelmacedo83","html_url":"https://github.com/samuelmacedo83","followers_url":"https://api.github.com/users/samuelmacedo83/followers","following_url":"https://api.github.com/users/samuelmacedo83/following{/other_user}","gists_url":"https://api.github.com/users/samuelmacedo83/gists{/gist_id}","starred_url":"https://api.github.com/users/samuelmacedo83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samuelmacedo83/subscriptions","organizations_url":"https://api.github.com/users/samuelmacedo83/orgs","repos_url":"https://api.github.com/users/samuelmacedo83/repos","events_url":"https://api.github.com/users/samuelmacedo83/events{/privacy}","received_events_url":"https://api.github.com/users/samuelmacedo83/received_events","type":"User","site_admin":false},"html_url":"https://github.com/samuelmacedo83/sparklyr","description":"R interface for Apache Spark","fork":true,"url":"https://api.github.com/repos/samuelmacedo83/sparklyr","forks_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/forks","keys_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/teams","hooks_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/hooks","issue_events_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/issues/events{/number}","events_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/events","assignees_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/assignees{/user}","branches_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/branches{/branch}","tags_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/tags","blobs_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/statuses/{sha}","languages_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/languages","stargazers_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/stargazers","contributors_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/contributors","subscribers_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/subscribers","subscription_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/subscription","commits_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/contents/{+path}","compare_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/merges","archive_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/downloads","issues_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/issues{/number}","pulls_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/pulls{/number}","milestones_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/milestones{/number}","notifications_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/labels{/name}","releases_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/releases{/id}","deployments_url":"https://api.github.com/repos/samuelmacedo83/sparklyr/deployments","created_at":"2018-04-21T21:13:22Z","updated_at":"2018-11-04T01:51:17Z","pushed_at":"2018-11-04T04:52:45Z","git_url":"git://github.com/samuelmacedo83/sparklyr.git","ssh_url":"git@github.com:samuelmacedo83/sparklyr.git","clone_url":"https://github.com/samuelmacedo83/sparklyr.git","svn_url":"https://github.com/samuelmacedo83/sparklyr","homepage":"https://spark.rstudio.com","size":53286,"stargazers_count":1,"watchers_count":1,"language":"R","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rstudio:master","ref":"master","sha":"78bbe0a8327b439088203ec5f588161c1ede73d2","user":{"login":"rstudio","id":513560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/513560?v=4","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"repo":{"id":59305491,"node_id":"MDEwOlJlcG9zaXRvcnk1OTMwNTQ5MQ==","name":"sparklyr","full_name":"rstudio/sparklyr","private":false,"owner":{"login":"rstudio","id":513560,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxMzU2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/513560?v=4","gravatar_id":"","url":"https://api.github.com/users/rstudio","html_url":"https://github.com/rstudio","followers_url":"https://api.github.com/users/rstudio/followers","following_url":"https://api.github.com/users/rstudio/following{/other_user}","gists_url":"https://api.github.com/users/rstudio/gists{/gist_id}","starred_url":"https://api.github.com/users/rstudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rstudio/subscriptions","organizations_url":"https://api.github.com/users/rstudio/orgs","repos_url":"https://api.github.com/users/rstudio/repos","events_url":"https://api.github.com/users/rstudio/events{/privacy}","received_events_url":"https://api.github.com/users/rstudio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rstudio/sparklyr","description":"R interface for Apache Spark","fork":false,"url":"https://api.github.com/repos/rstudio/sparklyr","forks_url":"https://api.github.com/repos/rstudio/sparklyr/forks","keys_url":"https://api.github.com/repos/rstudio/sparklyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rstudio/sparklyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rstudio/sparklyr/teams","hooks_url":"https://api.github.com/repos/rstudio/sparklyr/hooks","issue_events_url":"https://api.github.com/repos/rstudio/sparklyr/issues/events{/number}","events_url":"https://api.github.com/repos/rstudio/sparklyr/events","assignees_url":"https://api.github.com/repos/rstudio/sparklyr/assignees{/user}","branches_url":"https://api.github.com/repos/rstudio/sparklyr/branches{/branch}","tags_url":"https://api.github.com/repos/rstudio/sparklyr/tags","blobs_url":"https://api.github.com/repos/rstudio/sparklyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rstudio/sparklyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rstudio/sparklyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/rstudio/sparklyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rstudio/sparklyr/statuses/{sha}","languages_url":"https://api.github.com/repos/rstudio/sparklyr/languages","stargazers_url":"https://api.github.com/repos/rstudio/sparklyr/stargazers","contributors_url":"https://api.github.com/repos/rstudio/sparklyr/contributors","subscribers_url":"https://api.github.com/repos/rstudio/sparklyr/subscribers","subscription_url":"https://api.github.com/repos/rstudio/sparklyr/subscription","commits_url":"https://api.github.com/repos/rstudio/sparklyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/rstudio/sparklyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/rstudio/sparklyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/rstudio/sparklyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/rstudio/sparklyr/contents/{+path}","compare_url":"https://api.github.com/repos/rstudio/sparklyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rstudio/sparklyr/merges","archive_url":"https://api.github.com/repos/rstudio/sparklyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rstudio/sparklyr/downloads","issues_url":"https://api.github.com/repos/rstudio/sparklyr/issues{/number}","pulls_url":"https://api.github.com/repos/rstudio/sparklyr/pulls{/number}","milestones_url":"https://api.github.com/repos/rstudio/sparklyr/milestones{/number}","notifications_url":"https://api.github.com/repos/rstudio/sparklyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rstudio/sparklyr/labels{/name}","releases_url":"https://api.github.com/repos/rstudio/sparklyr/releases{/id}","deployments_url":"https://api.github.com/repos/rstudio/sparklyr/deployments","created_at":"2016-05-20T15:28:53Z","updated_at":"2018-11-06T18:41:41Z","pushed_at":"2018-11-06T18:41:38Z","git_url":"git://github.com/rstudio/sparklyr.git","ssh_url":"git@github.com:rstudio/sparklyr.git","clone_url":"https://github.com/rstudio/sparklyr.git","svn_url":"https://github.com/rstudio/sparklyr","homepage":"https://spark.rstudio.com","size":55465,"stargazers_count":591,"watchers_count":591,"language":"R","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":214,"mirror_url":null,"archived":false,"open_issues_count":294,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":214,"open_issues":294,"watchers":591,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rstudio/sparklyr/pulls/1747"},"html":{"href":"https://github.com/rstudio/sparklyr/pull/1747"},"issue":{"href":"https://api.github.com/repos/rstudio/sparklyr/issues/1747"},"comments":{"href":"https://api.github.com/repos/rstudio/sparklyr/issues/1747/comments"},"review_comments":{"href":"https://api.github.com/repos/rstudio/sparklyr/pulls/1747/comments"},"review_comment":{"href":"https://api.github.com/repos/rstudio/sparklyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rstudio/sparklyr/pulls/1747/commits"},"statuses":{"href":"https://api.github.com/repos/rstudio/sparklyr/statuses/1609b90b54102f61727d181d68922f3165831c2e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"javierluraschi"}}