{"action":"closed","issue":{"url":"https://api.github.com/repos/transloadit/uppy-server/issues/96","repository_url":"https://api.github.com/repos/transloadit/uppy-server","labels_url":"https://api.github.com/repos/transloadit/uppy-server/issues/96/labels{/name}","comments_url":"https://api.github.com/repos/transloadit/uppy-server/issues/96/comments","events_url":"https://api.github.com/repos/transloadit/uppy-server/issues/96/events","html_url":"https://github.com/transloadit/uppy-server/issues/96","id":329788005,"node_id":"MDU6SXNzdWUzMjk3ODgwMDU=","number":96,"title":"Rename `host` and `hostPattern`","user":{"login":"kvz","id":26752,"node_id":"MDQ6VXNlcjI2NzUy","avatar_url":"https://avatars2.githubusercontent.com/u/26752?v=4","gravatar_id":"","url":"https://api.github.com/users/kvz","html_url":"https://github.com/kvz","followers_url":"https://api.github.com/users/kvz/followers","following_url":"https://api.github.com/users/kvz/following{/other_user}","gists_url":"https://api.github.com/users/kvz/gists{/gist_id}","starred_url":"https://api.github.com/users/kvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvz/subscriptions","organizations_url":"https://api.github.com/users/kvz/orgs","repos_url":"https://api.github.com/users/kvz/repos","events_url":"https://api.github.com/users/kvz/events{/privacy}","received_events_url":"https://api.github.com/users/kvz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"ifedapoolarewaju","id":8383781,"node_id":"MDQ6VXNlcjgzODM3ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/8383781?v=4","gravatar_id":"","url":"https://api.github.com/users/ifedapoolarewaju","html_url":"https://github.com/ifedapoolarewaju","followers_url":"https://api.github.com/users/ifedapoolarewaju/followers","following_url":"https://api.github.com/users/ifedapoolarewaju/following{/other_user}","gists_url":"https://api.github.com/users/ifedapoolarewaju/gists{/gist_id}","starred_url":"https://api.github.com/users/ifedapoolarewaju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifedapoolarewaju/subscriptions","organizations_url":"https://api.github.com/users/ifedapoolarewaju/orgs","repos_url":"https://api.github.com/users/ifedapoolarewaju/repos","events_url":"https://api.github.com/users/ifedapoolarewaju/events{/privacy}","received_events_url":"https://api.github.com/users/ifedapoolarewaju/received_events","type":"User","site_admin":false},"assignees":[{"login":"ifedapoolarewaju","id":8383781,"node_id":"MDQ6VXNlcjgzODM3ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/8383781?v=4","gravatar_id":"","url":"https://api.github.com/users/ifedapoolarewaju","html_url":"https://github.com/ifedapoolarewaju","followers_url":"https://api.github.com/users/ifedapoolarewaju/followers","following_url":"https://api.github.com/users/ifedapoolarewaju/following{/other_user}","gists_url":"https://api.github.com/users/ifedapoolarewaju/gists{/gist_id}","starred_url":"https://api.github.com/users/ifedapoolarewaju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifedapoolarewaju/subscriptions","organizations_url":"https://api.github.com/users/ifedapoolarewaju/orgs","repos_url":"https://api.github.com/users/ifedapoolarewaju/repos","events_url":"https://api.github.com/users/ifedapoolarewaju/events{/privacy}","received_events_url":"https://api.github.com/users/ifedapoolarewaju/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-06-06T09:27:10Z","updated_at":"2018-06-15T01:07:50Z","closed_at":"2018-06-15T01:07:50Z","author_association":"MEMBER","body":"Host is usually: `jane.transloadit.com` but since `host` in our case contains a full url with many more components (protocol, path, etc), I'd vote to name it `endpoint`.\r\n\r\n`hostPattern` could than be named `allowedOrigins` which could either take (an array for a list of flat origins, a function to be executed on a string which returns true or false, or) a RegExp.\r\n\r\nThe proposals are up for discussion, but I do think a change is needed.\r\n\r\nFor BC-compat, we could likely still accept `host` and throw a Deprecation warning at the console for a release or two.\r\n"}}
{"actor":{"display_login":"ifedapoolarewaju"}}