{"action":"created","comment":{"url":"https://api.github.com/repos/openzfsonwindows/ZFSin/pulls/comments/197701324","pull_request_review_id":131493986,"id":197701324,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzcwMTMyNA==","diff_hunk":"@@ -925,8 +926,14 @@ int   vnode_unlink(vnode_t *vp)\n \n void   vnode_setunlink(vnode_t *vp)\n {\n+\tif (vp && VTOZ(vp) && VTOZ(vp)->z_pflags & (ZFS_IMMUTABLE | ZFS_NOUNLINK)) {","path":"ZFSin/spl/module/spl/spl-vnode.c","position":12,"original_position":12,"commit_id":"9c7ba1f640a71644fb2ddfa91ceb79868c706f17","original_commit_id":"9c7ba1f640a71644fb2ddfa91ceb79868c706f17","user":{"login":"jheuking","id":39560536,"node_id":"MDQ6VXNlcjM5NTYwNTM2","avatar_url":"https://avatars2.githubusercontent.com/u/39560536?v=4","gravatar_id":"","url":"https://api.github.com/users/jheuking","html_url":"https://github.com/jheuking","followers_url":"https://api.github.com/users/jheuking/followers","following_url":"https://api.github.com/users/jheuking/following{/other_user}","gists_url":"https://api.github.com/users/jheuking/gists{/gist_id}","starred_url":"https://api.github.com/users/jheuking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jheuking/subscriptions","organizations_url":"https://api.github.com/users/jheuking/orgs","repos_url":"https://api.github.com/users/jheuking/repos","events_url":"https://api.github.com/users/jheuking/events{/privacy}","received_events_url":"https://api.github.com/users/jheuking/received_events","type":"User","site_admin":false},"body":"it gets called via fsdispatcher->IRP_MJ_CLEANUP->delete_entry->zfs_remove or ->zfs_rmdir in zfs_vnops.c like this:\r\n```\r\nif ((error = zfs_zaccess_delete(dzp, zp, cr))) {\r\n\tgoto out;\r\n}\r\n```\r\nthis led me to the error initially. But I think, instead of picking single conditions out of zfs_zaccess_delete() and getting the same error again if any other condition is satisfied, it would be better to just use the function itself to determine whether we are going to run into access denied in IRP_MJ_CLEANUP...\r\n","created_at":"2018-06-25T07:32:11Z","updated_at":"2018-06-25T07:32:11Z","html_url":"https://github.com/openzfsonwindows/ZFSin/pull/48#discussion_r197701324","pull_request_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/pulls/48","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openzfsonwindows/ZFSin/pulls/comments/197701324"},"html":{"href":"https://github.com/openzfsonwindows/ZFSin/pull/48#discussion_r197701324"},"pull_request":{"href":"https://api.github.com/repos/openzfsonwindows/ZFSin/pulls/48"}},"in_reply_to_id":197408062},"pull_request":{"url":"https://api.github.com/repos/openzfsonwindows/ZFSin/pulls/48","id":196697853,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2Njk3ODUz","html_url":"https://github.com/openzfsonwindows/ZFSin/pull/48","diff_url":"https://github.com/openzfsonwindows/ZFSin/pull/48.diff","patch_url":"https://github.com/openzfsonwindows/ZFSin/pull/48.patch","issue_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/issues/48","number":48,"state":"open","locked":false,"title":"return access denied when deleting files ","user":{"login":"jheuking","id":39560536,"node_id":"MDQ6VXNlcjM5NTYwNTM2","avatar_url":"https://avatars2.githubusercontent.com/u/39560536?v=4","gravatar_id":"","url":"https://api.github.com/users/jheuking","html_url":"https://github.com/jheuking","followers_url":"https://api.github.com/users/jheuking/followers","following_url":"https://api.github.com/users/jheuking/following{/other_user}","gists_url":"https://api.github.com/users/jheuking/gists{/gist_id}","starred_url":"https://api.github.com/users/jheuking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jheuking/subscriptions","organizations_url":"https://api.github.com/users/jheuking/orgs","repos_url":"https://api.github.com/users/jheuking/repos","events_url":"https://api.github.com/users/jheuking/events{/privacy}","received_events_url":"https://api.github.com/users/jheuking/received_events","type":"User","site_admin":false},"body":"When deleting files with z_pflags ZFS_IMMUTABLE or ZFS_NOUNLINK set, zfs_zaccess_delete() returns EPERM and aborts. This function is called within IRP_MJ_CLEANUP though, which is too late to return STATUS_ACCESS_DENIED, so this has to be checked earlier, when v_unlink is set. The user now gets an error message when trying to delete such files. \r\n\r\n","created_at":"2018-06-22T10:21:46Z","updated_at":"2018-06-25T07:32:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f9349d703402eacd1b7133c3d0c42fcc55dea4d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/pulls/48/commits","review_comments_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/pulls/48/comments","review_comment_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/issues/48/comments","statuses_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/statuses/9c7ba1f640a71644fb2ddfa91ceb79868c706f17","head":{"label":"jheuking:return_access_denied_for_lundman","ref":"return_access_denied_for_lundman","sha":"9c7ba1f640a71644fb2ddfa91ceb79868c706f17","user":{"login":"jheuking","id":39560536,"node_id":"MDQ6VXNlcjM5NTYwNTM2","avatar_url":"https://avatars2.githubusercontent.com/u/39560536?v=4","gravatar_id":"","url":"https://api.github.com/users/jheuking","html_url":"https://github.com/jheuking","followers_url":"https://api.github.com/users/jheuking/followers","following_url":"https://api.github.com/users/jheuking/following{/other_user}","gists_url":"https://api.github.com/users/jheuking/gists{/gist_id}","starred_url":"https://api.github.com/users/jheuking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jheuking/subscriptions","organizations_url":"https://api.github.com/users/jheuking/orgs","repos_url":"https://api.github.com/users/jheuking/repos","events_url":"https://api.github.com/users/jheuking/events{/privacy}","received_events_url":"https://api.github.com/users/jheuking/received_events","type":"User","site_admin":false},"repo":{"id":134829884,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ4Mjk4ODQ=","name":"ZFSin","full_name":"jheuking/ZFSin","owner":{"login":"jheuking","id":39560536,"node_id":"MDQ6VXNlcjM5NTYwNTM2","avatar_url":"https://avatars2.githubusercontent.com/u/39560536?v=4","gravatar_id":"","url":"https://api.github.com/users/jheuking","html_url":"https://github.com/jheuking","followers_url":"https://api.github.com/users/jheuking/followers","following_url":"https://api.github.com/users/jheuking/following{/other_user}","gists_url":"https://api.github.com/users/jheuking/gists{/gist_id}","starred_url":"https://api.github.com/users/jheuking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jheuking/subscriptions","organizations_url":"https://api.github.com/users/jheuking/orgs","repos_url":"https://api.github.com/users/jheuking/repos","events_url":"https://api.github.com/users/jheuking/events{/privacy}","received_events_url":"https://api.github.com/users/jheuking/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jheuking/ZFSin","description":"OpenZFS ports","fork":true,"url":"https://api.github.com/repos/jheuking/ZFSin","forks_url":"https://api.github.com/repos/jheuking/ZFSin/forks","keys_url":"https://api.github.com/repos/jheuking/ZFSin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jheuking/ZFSin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jheuking/ZFSin/teams","hooks_url":"https://api.github.com/repos/jheuking/ZFSin/hooks","issue_events_url":"https://api.github.com/repos/jheuking/ZFSin/issues/events{/number}","events_url":"https://api.github.com/repos/jheuking/ZFSin/events","assignees_url":"https://api.github.com/repos/jheuking/ZFSin/assignees{/user}","branches_url":"https://api.github.com/repos/jheuking/ZFSin/branches{/branch}","tags_url":"https://api.github.com/repos/jheuking/ZFSin/tags","blobs_url":"https://api.github.com/repos/jheuking/ZFSin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jheuking/ZFSin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jheuking/ZFSin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jheuking/ZFSin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jheuking/ZFSin/statuses/{sha}","languages_url":"https://api.github.com/repos/jheuking/ZFSin/languages","stargazers_url":"https://api.github.com/repos/jheuking/ZFSin/stargazers","contributors_url":"https://api.github.com/repos/jheuking/ZFSin/contributors","subscribers_url":"https://api.github.com/repos/jheuking/ZFSin/subscribers","subscription_url":"https://api.github.com/repos/jheuking/ZFSin/subscription","commits_url":"https://api.github.com/repos/jheuking/ZFSin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jheuking/ZFSin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jheuking/ZFSin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jheuking/ZFSin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jheuking/ZFSin/contents/{+path}","compare_url":"https://api.github.com/repos/jheuking/ZFSin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jheuking/ZFSin/merges","archive_url":"https://api.github.com/repos/jheuking/ZFSin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jheuking/ZFSin/downloads","issues_url":"https://api.github.com/repos/jheuking/ZFSin/issues{/number}","pulls_url":"https://api.github.com/repos/jheuking/ZFSin/pulls{/number}","milestones_url":"https://api.github.com/repos/jheuking/ZFSin/milestones{/number}","notifications_url":"https://api.github.com/repos/jheuking/ZFSin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jheuking/ZFSin/labels{/name}","releases_url":"https://api.github.com/repos/jheuking/ZFSin/releases{/id}","deployments_url":"https://api.github.com/repos/jheuking/ZFSin/deployments","created_at":"2018-05-25T08:48:12Z","updated_at":"2018-05-25T08:48:20Z","pushed_at":"2018-06-22T09:57:58Z","git_url":"git://github.com/jheuking/ZFSin.git","ssh_url":"git@github.com:jheuking/ZFSin.git","clone_url":"https://github.com/jheuking/ZFSin.git","svn_url":"https://github.com/jheuking/ZFSin","homepage":null,"size":8702,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openzfsonwindows:master","ref":"master","sha":"ce9b2671daa456486fa8439159ae743b53377724","user":{"login":"openzfsonwindows","id":33284003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg0MDAz","avatar_url":"https://avatars2.githubusercontent.com/u/33284003?v=4","gravatar_id":"","url":"https://api.github.com/users/openzfsonwindows","html_url":"https://github.com/openzfsonwindows","followers_url":"https://api.github.com/users/openzfsonwindows/followers","following_url":"https://api.github.com/users/openzfsonwindows/following{/other_user}","gists_url":"https://api.github.com/users/openzfsonwindows/gists{/gist_id}","starred_url":"https://api.github.com/users/openzfsonwindows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzfsonwindows/subscriptions","organizations_url":"https://api.github.com/users/openzfsonwindows/orgs","repos_url":"https://api.github.com/users/openzfsonwindows/repos","events_url":"https://api.github.com/users/openzfsonwindows/events{/privacy}","received_events_url":"https://api.github.com/users/openzfsonwindows/received_events","type":"Organization","site_admin":false},"repo":{"id":85033083,"node_id":"MDEwOlJlcG9zaXRvcnk4NTAzMzA4Mw==","name":"ZFSin","full_name":"openzfsonwindows/ZFSin","owner":{"login":"openzfsonwindows","id":33284003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg0MDAz","avatar_url":"https://avatars2.githubusercontent.com/u/33284003?v=4","gravatar_id":"","url":"https://api.github.com/users/openzfsonwindows","html_url":"https://github.com/openzfsonwindows","followers_url":"https://api.github.com/users/openzfsonwindows/followers","following_url":"https://api.github.com/users/openzfsonwindows/following{/other_user}","gists_url":"https://api.github.com/users/openzfsonwindows/gists{/gist_id}","starred_url":"https://api.github.com/users/openzfsonwindows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzfsonwindows/subscriptions","organizations_url":"https://api.github.com/users/openzfsonwindows/orgs","repos_url":"https://api.github.com/users/openzfsonwindows/repos","events_url":"https://api.github.com/users/openzfsonwindows/events{/privacy}","received_events_url":"https://api.github.com/users/openzfsonwindows/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzfsonwindows/ZFSin","description":"OpenZFS ports","fork":false,"url":"https://api.github.com/repos/openzfsonwindows/ZFSin","forks_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/forks","keys_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/teams","hooks_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/hooks","issue_events_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/issues/events{/number}","events_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/events","assignees_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/assignees{/user}","branches_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/branches{/branch}","tags_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/tags","blobs_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/statuses/{sha}","languages_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/languages","stargazers_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/stargazers","contributors_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/contributors","subscribers_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/subscribers","subscription_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/subscription","commits_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/contents/{+path}","compare_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/merges","archive_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/downloads","issues_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/issues{/number}","pulls_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/pulls{/number}","milestones_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/milestones{/number}","notifications_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/labels{/name}","releases_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/releases{/id}","deployments_url":"https://api.github.com/repos/openzfsonwindows/ZFSin/deployments","created_at":"2017-03-15T05:33:15Z","updated_at":"2018-06-20T06:16:43Z","pushed_at":"2018-06-22T10:21:47Z","git_url":"git://github.com/openzfsonwindows/ZFSin.git","ssh_url":"git@github.com:openzfsonwindows/ZFSin.git","clone_url":"https://github.com/openzfsonwindows/ZFSin.git","svn_url":"https://github.com/openzfsonwindows/ZFSin","homepage":null,"size":8645,"stargazers_count":368,"watchers_count":368,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":23,"license":null,"forks":16,"open_issues":23,"watchers":368,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzfsonwindows/ZFSin/pulls/48"},"html":{"href":"https://github.com/openzfsonwindows/ZFSin/pull/48"},"issue":{"href":"https://api.github.com/repos/openzfsonwindows/ZFSin/issues/48"},"comments":{"href":"https://api.github.com/repos/openzfsonwindows/ZFSin/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/openzfsonwindows/ZFSin/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/openzfsonwindows/ZFSin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzfsonwindows/ZFSin/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/openzfsonwindows/ZFSin/statuses/9c7ba1f640a71644fb2ddfa91ceb79868c706f17"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jheuking"}}