{"action":"created","comment":{"url":"https://api.github.com/repos/MainframeHQ/contracts/pulls/comments/190724735","pull_request_review_id":123164791,"id":190724735,"diff_hunk":"@@ -47,11 +46,11 @@ contract MainframeToken is ERC827Token, Pausable, Claimable {\n \n   // ERC827 Methods\n \n-  function transferAndCall(address to, uint256 value, bytes data) public validDestination(to) payable isTradeable returns (bool) {\n+  function transferAndCall(address to, uint256 value, bytes data) public payable isTradeable returns (bool) {\n     return super.transferAndCall(to, value, data);\n   }\n \n-  function transferFromAndCall(address from, address to, uint256 value, bytes data) public validDestination(to) payable isTradeable returns (bool) {\n+  function transferFromAndCall(address from, address to, uint256 value, bytes data) public payable isTradeable returns (bool) {","path":"contracts/MainframeToken.sol","position":18,"original_position":18,"commit_id":"f2db4a27c683b575845b3764fa9b529656fcad98","original_commit_id":"f2db4a27c683b575845b3764fa9b529656fcad98","user":{"login":"howleysv","id":4747933,"avatar_url":"https://avatars0.githubusercontent.com/u/4747933?v=4","gravatar_id":"","url":"https://api.github.com/users/howleysv","html_url":"https://github.com/howleysv","followers_url":"https://api.github.com/users/howleysv/followers","following_url":"https://api.github.com/users/howleysv/following{/other_user}","gists_url":"https://api.github.com/users/howleysv/gists{/gist_id}","starred_url":"https://api.github.com/users/howleysv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howleysv/subscriptions","organizations_url":"https://api.github.com/users/howleysv/orgs","repos_url":"https://api.github.com/users/howleysv/repos","events_url":"https://api.github.com/users/howleysv/events{/privacy}","received_events_url":"https://api.github.com/users/howleysv/received_events","type":"User","site_admin":false},"body":"Ah, I see where the checks are already happening in `AndCall` versions in `ERC827Token`","created_at":"2018-05-24T20:43:46Z","updated_at":"2018-05-24T20:43:46Z","html_url":"https://github.com/MainframeHQ/contracts/pull/23#discussion_r190724735","pull_request_url":"https://api.github.com/repos/MainframeHQ/contracts/pulls/23","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/MainframeHQ/contracts/pulls/comments/190724735"},"html":{"href":"https://github.com/MainframeHQ/contracts/pull/23#discussion_r190724735"},"pull_request":{"href":"https://api.github.com/repos/MainframeHQ/contracts/pulls/23"}},"in_reply_to_id":190723290},"pull_request":{"url":"https://api.github.com/repos/MainframeHQ/contracts/pulls/23","id":190352331,"html_url":"https://github.com/MainframeHQ/contracts/pull/23","diff_url":"https://github.com/MainframeHQ/contracts/pull/23.diff","patch_url":"https://github.com/MainframeHQ/contracts/pull/23.patch","issue_url":"https://api.github.com/repos/MainframeHQ/contracts/issues/23","number":23,"state":"open","locked":false,"title":"Remove unnecessary validation checks to save gas","user":{"login":"avclarke","id":3802342,"avatar_url":"https://avatars0.githubusercontent.com/u/3802342?v=4","gravatar_id":"","url":"https://api.github.com/users/avclarke","html_url":"https://github.com/avclarke","followers_url":"https://api.github.com/users/avclarke/followers","following_url":"https://api.github.com/users/avclarke/following{/other_user}","gists_url":"https://api.github.com/users/avclarke/gists{/gist_id}","starred_url":"https://api.github.com/users/avclarke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avclarke/subscriptions","organizations_url":"https://api.github.com/users/avclarke/orgs","repos_url":"https://api.github.com/users/avclarke/repos","events_url":"https://api.github.com/users/avclarke/events{/privacy}","received_events_url":"https://api.github.com/users/avclarke/received_events","type":"User","site_admin":false},"body":"• require(to != address(0x0)) check is already being done in the methods of StandardToken\r\n• transferFromAndCall and transferAndCall super methods already validate against address being self or 0x\r\n• distribution validation fails without pre-checking the balance and allowance ","created_at":"2018-05-24T16:40:22Z","updated_at":"2018-05-24T20:43:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4494253566be3be7eaca4c37a6f0b5dcd0d4d98","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MainframeHQ/contracts/pulls/23/commits","review_comments_url":"https://api.github.com/repos/MainframeHQ/contracts/pulls/23/comments","review_comment_url":"https://api.github.com/repos/MainframeHQ/contracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MainframeHQ/contracts/issues/23/comments","statuses_url":"https://api.github.com/repos/MainframeHQ/contracts/statuses/f2db4a27c683b575845b3764fa9b529656fcad98","head":{"label":"MainframeHQ:contract-updates","ref":"contract-updates","sha":"f2db4a27c683b575845b3764fa9b529656fcad98","user":{"login":"MainframeHQ","id":4616210,"avatar_url":"https://avatars2.githubusercontent.com/u/4616210?v=4","gravatar_id":"","url":"https://api.github.com/users/MainframeHQ","html_url":"https://github.com/MainframeHQ","followers_url":"https://api.github.com/users/MainframeHQ/followers","following_url":"https://api.github.com/users/MainframeHQ/following{/other_user}","gists_url":"https://api.github.com/users/MainframeHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/MainframeHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MainframeHQ/subscriptions","organizations_url":"https://api.github.com/users/MainframeHQ/orgs","repos_url":"https://api.github.com/users/MainframeHQ/repos","events_url":"https://api.github.com/users/MainframeHQ/events{/privacy}","received_events_url":"https://api.github.com/users/MainframeHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":120617206,"name":"contracts","full_name":"MainframeHQ/contracts","owner":{"login":"MainframeHQ","id":4616210,"avatar_url":"https://avatars2.githubusercontent.com/u/4616210?v=4","gravatar_id":"","url":"https://api.github.com/users/MainframeHQ","html_url":"https://github.com/MainframeHQ","followers_url":"https://api.github.com/users/MainframeHQ/followers","following_url":"https://api.github.com/users/MainframeHQ/following{/other_user}","gists_url":"https://api.github.com/users/MainframeHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/MainframeHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MainframeHQ/subscriptions","organizations_url":"https://api.github.com/users/MainframeHQ/orgs","repos_url":"https://api.github.com/users/MainframeHQ/repos","events_url":"https://api.github.com/users/MainframeHQ/events{/privacy}","received_events_url":"https://api.github.com/users/MainframeHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MainframeHQ/contracts","description":"Mainframe smart contracts","fork":false,"url":"https://api.github.com/repos/MainframeHQ/contracts","forks_url":"https://api.github.com/repos/MainframeHQ/contracts/forks","keys_url":"https://api.github.com/repos/MainframeHQ/contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MainframeHQ/contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MainframeHQ/contracts/teams","hooks_url":"https://api.github.com/repos/MainframeHQ/contracts/hooks","issue_events_url":"https://api.github.com/repos/MainframeHQ/contracts/issues/events{/number}","events_url":"https://api.github.com/repos/MainframeHQ/contracts/events","assignees_url":"https://api.github.com/repos/MainframeHQ/contracts/assignees{/user}","branches_url":"https://api.github.com/repos/MainframeHQ/contracts/branches{/branch}","tags_url":"https://api.github.com/repos/MainframeHQ/contracts/tags","blobs_url":"https://api.github.com/repos/MainframeHQ/contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MainframeHQ/contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MainframeHQ/contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/MainframeHQ/contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MainframeHQ/contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/MainframeHQ/contracts/languages","stargazers_url":"https://api.github.com/repos/MainframeHQ/contracts/stargazers","contributors_url":"https://api.github.com/repos/MainframeHQ/contracts/contributors","subscribers_url":"https://api.github.com/repos/MainframeHQ/contracts/subscribers","subscription_url":"https://api.github.com/repos/MainframeHQ/contracts/subscription","commits_url":"https://api.github.com/repos/MainframeHQ/contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/MainframeHQ/contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/MainframeHQ/contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/MainframeHQ/contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/MainframeHQ/contracts/contents/{+path}","compare_url":"https://api.github.com/repos/MainframeHQ/contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MainframeHQ/contracts/merges","archive_url":"https://api.github.com/repos/MainframeHQ/contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MainframeHQ/contracts/downloads","issues_url":"https://api.github.com/repos/MainframeHQ/contracts/issues{/number}","pulls_url":"https://api.github.com/repos/MainframeHQ/contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/MainframeHQ/contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/MainframeHQ/contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MainframeHQ/contracts/labels{/name}","releases_url":"https://api.github.com/repos/MainframeHQ/contracts/releases{/id}","deployments_url":"https://api.github.com/repos/MainframeHQ/contracts/deployments","created_at":"2018-02-07T13:15:25Z","updated_at":"2018-05-24T15:54:46Z","pushed_at":"2018-05-24T16:40:23Z","git_url":"git://github.com/MainframeHQ/contracts.git","ssh_url":"git@github.com:MainframeHQ/contracts.git","clone_url":"https://github.com/MainframeHQ/contracts.git","svn_url":"https://github.com/MainframeHQ/contracts","homepage":"","size":1094,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"MainframeHQ:master","ref":"master","sha":"ca97b0a488d91c443ed849498cac95433f84c5d2","user":{"login":"MainframeHQ","id":4616210,"avatar_url":"https://avatars2.githubusercontent.com/u/4616210?v=4","gravatar_id":"","url":"https://api.github.com/users/MainframeHQ","html_url":"https://github.com/MainframeHQ","followers_url":"https://api.github.com/users/MainframeHQ/followers","following_url":"https://api.github.com/users/MainframeHQ/following{/other_user}","gists_url":"https://api.github.com/users/MainframeHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/MainframeHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MainframeHQ/subscriptions","organizations_url":"https://api.github.com/users/MainframeHQ/orgs","repos_url":"https://api.github.com/users/MainframeHQ/repos","events_url":"https://api.github.com/users/MainframeHQ/events{/privacy}","received_events_url":"https://api.github.com/users/MainframeHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":120617206,"name":"contracts","full_name":"MainframeHQ/contracts","owner":{"login":"MainframeHQ","id":4616210,"avatar_url":"https://avatars2.githubusercontent.com/u/4616210?v=4","gravatar_id":"","url":"https://api.github.com/users/MainframeHQ","html_url":"https://github.com/MainframeHQ","followers_url":"https://api.github.com/users/MainframeHQ/followers","following_url":"https://api.github.com/users/MainframeHQ/following{/other_user}","gists_url":"https://api.github.com/users/MainframeHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/MainframeHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MainframeHQ/subscriptions","organizations_url":"https://api.github.com/users/MainframeHQ/orgs","repos_url":"https://api.github.com/users/MainframeHQ/repos","events_url":"https://api.github.com/users/MainframeHQ/events{/privacy}","received_events_url":"https://api.github.com/users/MainframeHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MainframeHQ/contracts","description":"Mainframe smart contracts","fork":false,"url":"https://api.github.com/repos/MainframeHQ/contracts","forks_url":"https://api.github.com/repos/MainframeHQ/contracts/forks","keys_url":"https://api.github.com/repos/MainframeHQ/contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MainframeHQ/contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MainframeHQ/contracts/teams","hooks_url":"https://api.github.com/repos/MainframeHQ/contracts/hooks","issue_events_url":"https://api.github.com/repos/MainframeHQ/contracts/issues/events{/number}","events_url":"https://api.github.com/repos/MainframeHQ/contracts/events","assignees_url":"https://api.github.com/repos/MainframeHQ/contracts/assignees{/user}","branches_url":"https://api.github.com/repos/MainframeHQ/contracts/branches{/branch}","tags_url":"https://api.github.com/repos/MainframeHQ/contracts/tags","blobs_url":"https://api.github.com/repos/MainframeHQ/contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MainframeHQ/contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MainframeHQ/contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/MainframeHQ/contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MainframeHQ/contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/MainframeHQ/contracts/languages","stargazers_url":"https://api.github.com/repos/MainframeHQ/contracts/stargazers","contributors_url":"https://api.github.com/repos/MainframeHQ/contracts/contributors","subscribers_url":"https://api.github.com/repos/MainframeHQ/contracts/subscribers","subscription_url":"https://api.github.com/repos/MainframeHQ/contracts/subscription","commits_url":"https://api.github.com/repos/MainframeHQ/contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/MainframeHQ/contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/MainframeHQ/contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/MainframeHQ/contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/MainframeHQ/contracts/contents/{+path}","compare_url":"https://api.github.com/repos/MainframeHQ/contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MainframeHQ/contracts/merges","archive_url":"https://api.github.com/repos/MainframeHQ/contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MainframeHQ/contracts/downloads","issues_url":"https://api.github.com/repos/MainframeHQ/contracts/issues{/number}","pulls_url":"https://api.github.com/repos/MainframeHQ/contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/MainframeHQ/contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/MainframeHQ/contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MainframeHQ/contracts/labels{/name}","releases_url":"https://api.github.com/repos/MainframeHQ/contracts/releases{/id}","deployments_url":"https://api.github.com/repos/MainframeHQ/contracts/deployments","created_at":"2018-02-07T13:15:25Z","updated_at":"2018-05-24T15:54:46Z","pushed_at":"2018-05-24T16:40:23Z","git_url":"git://github.com/MainframeHQ/contracts.git","ssh_url":"git@github.com:MainframeHQ/contracts.git","clone_url":"https://github.com/MainframeHQ/contracts.git","svn_url":"https://github.com/MainframeHQ/contracts","homepage":"","size":1094,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MainframeHQ/contracts/pulls/23"},"html":{"href":"https://github.com/MainframeHQ/contracts/pull/23"},"issue":{"href":"https://api.github.com/repos/MainframeHQ/contracts/issues/23"},"comments":{"href":"https://api.github.com/repos/MainframeHQ/contracts/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/MainframeHQ/contracts/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/MainframeHQ/contracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MainframeHQ/contracts/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/MainframeHQ/contracts/statuses/f2db4a27c683b575845b3764fa9b529656fcad98"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"howleysv"}}