{"action":"created","issue":{"url":"https://api.github.com/repos/golang/protobuf/issues/617","repository_url":"https://api.github.com/repos/golang/protobuf","labels_url":"https://api.github.com/repos/golang/protobuf/issues/617/labels{/name}","comments_url":"https://api.github.com/repos/golang/protobuf/issues/617/comments","events_url":"https://api.github.com/repos/golang/protobuf/issues/617/events","html_url":"https://github.com/golang/protobuf/issues/617","id":325854185,"number":617,"title":"Upstream changes breaking compatibility with Kubernetes","user":{"login":"pbarker","id":5533189,"avatar_url":"https://avatars3.githubusercontent.com/u/5533189?v=4","gravatar_id":"","url":"https://api.github.com/users/pbarker","html_url":"https://github.com/pbarker","followers_url":"https://api.github.com/users/pbarker/followers","following_url":"https://api.github.com/users/pbarker/following{/other_user}","gists_url":"https://api.github.com/users/pbarker/gists{/gist_id}","starred_url":"https://api.github.com/users/pbarker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbarker/subscriptions","organizations_url":"https://api.github.com/users/pbarker/orgs","repos_url":"https://api.github.com/users/pbarker/repos","events_url":"https://api.github.com/users/pbarker/events{/privacy}","received_events_url":"https://api.github.com/users/pbarker/received_events","type":"User","site_admin":false},"labels":[{"id":608290199,"url":"https://api.github.com/repos/golang/protobuf/labels/waiting-for-info","name":"waiting-for-info","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-05-23T20:06:14Z","updated_at":"2018-05-29T22:55:45Z","closed_at":null,"author_association":"NONE","body":"https://github.com/golang/protobuf/commit/8cc9e46429bfb16289d40d30b2ee3f4923b47345 breaks compatibility with kubernetes. \r\n\r\nhttps://github.com/golang/protobuf/blob/master/proto/table_unmarshal.go#L331 mandates that all struct fields have proto tags. The `TypeMeta` fields in kubernetes structs do not contain a proto tag, https://github.com/kubernetes/apiserver/blob/master/pkg/apis/audit/v1beta1/types.go#L145 is a typical example.\r\n\r\nIf this change is necessitated we should work to put it in a major revision and allow `v1` to be compatible without tags."},"comment":{"url":"https://api.github.com/repos/golang/protobuf/issues/comments/392973806","html_url":"https://github.com/golang/protobuf/issues/617#issuecomment-392973806","issue_url":"https://api.github.com/repos/golang/protobuf/issues/617","id":392973806,"user":{"login":"thockin","id":5595220,"avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"created_at":"2018-05-29T22:55:45Z","updated_at":"2018-05-29T22:55:45Z","author_association":"NONE","body":"The history is awkward - gRPC didn't exist yet, so we did things the way \"everyone else\" did - JSON.  Then gRPC and proto hit the big time (outside G of course), and we were left holding the bag.\r\n\r\nI don't know which cases go through this codepath any more.\r\n\r\n@lavalamp @smarterclayton"}}
{"actor":{"display_login":"thockin"}}