{"action":"created","issue":{"url":"https://api.github.com/repos/PowerShell/xWindowsEventForwarding/issues/11","repository_url":"https://api.github.com/repos/PowerShell/xWindowsEventForwarding","labels_url":"https://api.github.com/repos/PowerShell/xWindowsEventForwarding/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/PowerShell/xWindowsEventForwarding/issues/11/comments","events_url":"https://api.github.com/repos/PowerShell/xWindowsEventForwarding/issues/11/events","html_url":"https://github.com/PowerShell/xWindowsEventForwarding/pull/11","id":206793807,"number":11,"title":"BREAKING CHANGE: Corrected the CredentialsType to only be used on CollectorInitiated Subscriptions","user":{"login":"dotps1","id":1016996,"avatar_url":"https://avatars0.githubusercontent.com/u/1016996?v=4","gravatar_id":"","url":"https://api.github.com/users/dotps1","html_url":"https://github.com/dotps1","followers_url":"https://api.github.com/users/dotps1/followers","following_url":"https://api.github.com/users/dotps1/following{/other_user}","gists_url":"https://api.github.com/users/dotps1/gists{/gist_id}","starred_url":"https://api.github.com/users/dotps1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotps1/subscriptions","organizations_url":"https://api.github.com/users/dotps1/orgs","repos_url":"https://api.github.com/users/dotps1/repos","events_url":"https://api.github.com/users/dotps1/events{/privacy}","received_events_url":"https://api.github.com/users/dotps1/received_events","type":"User","site_admin":false},"labels":[{"id":427237409,"url":"https://api.github.com/repos/PowerShell/xWindowsEventForwarding/labels/breaking%20change","name":"breaking change","color":"ff9900","default":false},{"id":427237794,"url":"https://api.github.com/repos/PowerShell/xWindowsEventForwarding/labels/waiting%20for%20author%20response","name":"waiting for author response","color":"ffff99","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-02-10T13:17:54Z","updated_at":"2018-05-16T12:35:21Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/PowerShell/xWindowsEventForwarding/pulls/11","html_url":"https://github.com/PowerShell/xWindowsEventForwarding/pull/11","diff_url":"https://github.com/PowerShell/xWindowsEventForwarding/pull/11.diff","patch_url":"https://github.com/PowerShell/xWindowsEventForwarding/pull/11.patch"},"body":"Ok, I know there is a lot of commits here, but I think its all set.  Basically I found that if I removed the `<CredentialsType>` tag in the generated xml, the subscription would create successfully, so I assumed the tag name was wrong (the plural Credentials looks wrong to me).  Well, what I think is happening is that wecutil just ignores tags it doesn't know, so changing it from `<CredentialsType>` to `<CredentialType>` _seemed_ to fix it.  But after further research, even using `wecutil cs -?` you can see in the example, it is in fact `<CredentialsType>`.  So, with that being said, I restored all the files back to your current dev branch, so things would be back to how it was, and I then just moved the `<CredentialsType>` tag to only be applied to the generated XML if a `CollectionInitiated` subscription is created.  This seems to fix the issue.\r\nI did however still change the `TransportPort` to default to null, and I added it the `Get-TargetRescource` function because that property was missing.\r\nI also fixed some not functional things to pass the tests that where failing, replacing tabs, and adding new lines at the end of files.\r\n\r\nFixes #9 \r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/powershell/xwindowseventforwarding/11)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/PowerShell/xWindowsEventForwarding/issues/comments/389502521","html_url":"https://github.com/PowerShell/xWindowsEventForwarding/pull/11#issuecomment-389502521","issue_url":"https://api.github.com/repos/PowerShell/xWindowsEventForwarding/issues/11","id":389502521,"user":{"login":"johlju","id":7189721,"avatar_url":"https://avatars0.githubusercontent.com/u/7189721?v=4","gravatar_id":"","url":"https://api.github.com/users/johlju","html_url":"https://github.com/johlju","followers_url":"https://api.github.com/users/johlju/followers","following_url":"https://api.github.com/users/johlju/following{/other_user}","gists_url":"https://api.github.com/users/johlju/gists{/gist_id}","starred_url":"https://api.github.com/users/johlju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johlju/subscriptions","organizations_url":"https://api.github.com/users/johlju/orgs","repos_url":"https://api.github.com/users/johlju/repos","events_url":"https://api.github.com/users/johlju/events{/privacy}","received_events_url":"https://api.github.com/users/johlju/received_events","type":"User","site_admin":false},"created_at":"2018-05-16T12:35:21Z","updated_at":"2018-05-16T12:35:21Z","author_association":"NONE","body":"\n\n\n\nReview status: 0 of 5 files reviewed at latest revision, 1 unresolved discussion.\n\n---\n\n*[DSCResources/MSFT_xWEFSubscription/MSFT_xWEFSubscription.psm1, line 176 at r3](https://reviewable.io/reviews/powershell/xwindowseventforwarding/11#-LCcwT1BElKqGQUdXhvU:-LCcwT1BElKqGQUdXhvV:b-wcp916) ([raw file](https://github.com/powershell/xwindowseventforwarding/blob/c281bbc2a5cada81bbb287bb7d4a47687f6a798e/DSCResources/MSFT_xWEFSubscription/MSFT_xWEFSubscription.psm1#L176)):*\n> ```\n> <CredentialsType>\n> ```\n\nIn the issue that this solved it says that this should be `<CredentialType>` (singluar on credential). What should we use here? :thinking: \n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/powershell/xwindowseventforwarding/11)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"johlju"}}