{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/210723951","pull_request_review_id":147000733,"id":210723951,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDcyMzk1MQ==","diff_hunk":"@@ -1062,6 +1062,13 @@ DEFINE_double(cuckoo_hash_ratio, 0.9, \"Hash ratio for Cuckoo SST table.\");\n DEFINE_bool(use_hash_search, false, \"if use kHashSearch \"\n             \"instead of kBinarySearch. \"\n             \"This is valid if only we use BlockTable\");\n+DEFINE_bool(use_data_block_hash_index, false, \"if use kDataBlockBinaryAndHash \"\n+            \"instead of kDataBlockBinarySearch. \"\n+            \"This is valid if only we use BlockTable\");\n+DEFINE_double(data_block_hash_table_util_ratio, 0.75,\n+              \"util ratio for data block hash index table. \"\n+              \"This is only valid if use_data_block_hash_index is \"\n+              \"set to true\");","path":"tools/db_bench_tool.cc","position":10,"original_position":10,"commit_id":"f6d4b7501c8cdca21282f851a693f9cff8fb1444","original_commit_id":"f6d4b7501c8cdca21282f851a693f9cff8fb1444","user":{"login":"sagar0","id":1087535,"node_id":"MDQ6VXNlcjEwODc1MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1087535?v=4","gravatar_id":"","url":"https://api.github.com/users/sagar0","html_url":"https://github.com/sagar0","followers_url":"https://api.github.com/users/sagar0/followers","following_url":"https://api.github.com/users/sagar0/following{/other_user}","gists_url":"https://api.github.com/users/sagar0/gists{/gist_id}","starred_url":"https://api.github.com/users/sagar0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sagar0/subscriptions","organizations_url":"https://api.github.com/users/sagar0/orgs","repos_url":"https://api.github.com/users/sagar0/repos","events_url":"https://api.github.com/users/sagar0/events{/privacy}","received_events_url":"https://api.github.com/users/sagar0/received_events","type":"User","site_admin":false},"body":"I still think these should go closer to line ~467, where many other block table options are located. ","created_at":"2018-08-16T20:01:31Z","updated_at":"2018-08-16T20:02:07Z","html_url":"https://github.com/facebook/rocksdb/pull/4281#discussion_r210723951","pull_request_url":"https://api.github.com/repos/facebook/rocksdb/pulls/4281","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments/210723951"},"html":{"href":"https://github.com/facebook/rocksdb/pull/4281#discussion_r210723951"},"pull_request":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/4281"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/4281","id":208922037,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTIyMDM3","html_url":"https://github.com/facebook/rocksdb/pull/4281","diff_url":"https://github.com/facebook/rocksdb/pull/4281.diff","patch_url":"https://github.com/facebook/rocksdb/pull/4281.patch","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/4281","number":4281,"state":"open","locked":false,"title":"Add db_bench options of data block hash index","user":{"login":"fgwu","id":2732324,"node_id":"MDQ6VXNlcjI3MzIzMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2732324?v=4","gravatar_id":"","url":"https://api.github.com/users/fgwu","html_url":"https://github.com/fgwu","followers_url":"https://api.github.com/users/fgwu/followers","following_url":"https://api.github.com/users/fgwu/following{/other_user}","gists_url":"https://api.github.com/users/fgwu/gists{/gist_id}","starred_url":"https://api.github.com/users/fgwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgwu/subscriptions","organizations_url":"https://api.github.com/users/fgwu/orgs","repos_url":"https://api.github.com/users/fgwu/repos","events_url":"https://api.github.com/users/fgwu/events{/privacy}","received_events_url":"https://api.github.com/users/fgwu/received_events","type":"User","site_admin":false},"body":"Summary:\r\nAdd `--data_block_index_type` and `--data_block_hash_table_util_ratio` option to `db_bench`.\r\n\r\n`--data_block_index_type` can be either of `binary` (default) or `binary_and_hash`;  \r\n`--data_block_hash_table_util_ratio` will be a double. The default value is `0.75`.\r\n\r\nTest Plan:\r\n`make check -j32` and make sure all tests pass","created_at":"2018-08-16T16:53:50Z","updated_at":"2018-08-16T20:02:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf149c46dd34ad03e8ea07520e2c26f1aa6b465a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196859108,"node_id":"MDU6TGFiZWwxOTY4NTkxMDg=","url":"https://api.github.com/repos/facebook/rocksdb/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/rocksdb/pulls/4281/commits","review_comments_url":"https://api.github.com/repos/facebook/rocksdb/pulls/4281/comments","review_comment_url":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/4281/comments","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/f6d4b7501c8cdca21282f851a693f9cff8fb1444","head":{"label":"fgwu:fwu_data_block_hash_index_db_bench_rebase","ref":"fwu_data_block_hash_index_db_bench_rebase","sha":"f6d4b7501c8cdca21282f851a693f9cff8fb1444","user":{"login":"fgwu","id":2732324,"node_id":"MDQ6VXNlcjI3MzIzMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2732324?v=4","gravatar_id":"","url":"https://api.github.com/users/fgwu","html_url":"https://github.com/fgwu","followers_url":"https://api.github.com/users/fgwu/followers","following_url":"https://api.github.com/users/fgwu/following{/other_user}","gists_url":"https://api.github.com/users/fgwu/gists{/gist_id}","starred_url":"https://api.github.com/users/fgwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgwu/subscriptions","organizations_url":"https://api.github.com/users/fgwu/orgs","repos_url":"https://api.github.com/users/fgwu/repos","events_url":"https://api.github.com/users/fgwu/events{/privacy}","received_events_url":"https://api.github.com/users/fgwu/received_events","type":"User","site_admin":false},"repo":{"id":136265617,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYyNjU2MTc=","name":"rocksdb","full_name":"fgwu/rocksdb","owner":{"login":"fgwu","id":2732324,"node_id":"MDQ6VXNlcjI3MzIzMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2732324?v=4","gravatar_id":"","url":"https://api.github.com/users/fgwu","html_url":"https://github.com/fgwu","followers_url":"https://api.github.com/users/fgwu/followers","following_url":"https://api.github.com/users/fgwu/following{/other_user}","gists_url":"https://api.github.com/users/fgwu/gists{/gist_id}","starred_url":"https://api.github.com/users/fgwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgwu/subscriptions","organizations_url":"https://api.github.com/users/fgwu/orgs","repos_url":"https://api.github.com/users/fgwu/repos","events_url":"https://api.github.com/users/fgwu/events{/privacy}","received_events_url":"https://api.github.com/users/fgwu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fgwu/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":true,"url":"https://api.github.com/repos/fgwu/rocksdb","forks_url":"https://api.github.com/repos/fgwu/rocksdb/forks","keys_url":"https://api.github.com/repos/fgwu/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fgwu/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fgwu/rocksdb/teams","hooks_url":"https://api.github.com/repos/fgwu/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/fgwu/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/fgwu/rocksdb/events","assignees_url":"https://api.github.com/repos/fgwu/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/fgwu/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/fgwu/rocksdb/tags","blobs_url":"https://api.github.com/repos/fgwu/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fgwu/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fgwu/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/fgwu/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fgwu/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/fgwu/rocksdb/languages","stargazers_url":"https://api.github.com/repos/fgwu/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/fgwu/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/fgwu/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/fgwu/rocksdb/subscription","commits_url":"https://api.github.com/repos/fgwu/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/fgwu/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/fgwu/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/fgwu/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/fgwu/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/fgwu/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fgwu/rocksdb/merges","archive_url":"https://api.github.com/repos/fgwu/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fgwu/rocksdb/downloads","issues_url":"https://api.github.com/repos/fgwu/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/fgwu/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/fgwu/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/fgwu/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fgwu/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/fgwu/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/fgwu/rocksdb/deployments","created_at":"2018-06-06T03:16:25Z","updated_at":"2018-08-16T16:41:36Z","pushed_at":"2018-08-16T19:47:10Z","git_url":"git://github.com/fgwu/rocksdb.git","ssh_url":"git@github.com:fgwu/rocksdb.git","clone_url":"https://github.com/fgwu/rocksdb.git","svn_url":"https://github.com/fgwu/rocksdb","homepage":"http://rocksdb.org","size":117629,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"19ec44fd392beff927cacbd3a976415edb3d27e9","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":6934395,"node_id":"MDEwOlJlcG9zaXRvcnk2OTM0Mzk1","name":"rocksdb","full_name":"facebook/rocksdb","owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/rocksdb","description":"A library that provides an embeddable, persistent key-value store for fast storage.","fork":false,"url":"https://api.github.com/repos/facebook/rocksdb","forks_url":"https://api.github.com/repos/facebook/rocksdb/forks","keys_url":"https://api.github.com/repos/facebook/rocksdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/rocksdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/rocksdb/teams","hooks_url":"https://api.github.com/repos/facebook/rocksdb/hooks","issue_events_url":"https://api.github.com/repos/facebook/rocksdb/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/rocksdb/events","assignees_url":"https://api.github.com/repos/facebook/rocksdb/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/rocksdb/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/rocksdb/tags","blobs_url":"https://api.github.com/repos/facebook/rocksdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/rocksdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/rocksdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/rocksdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/rocksdb/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/rocksdb/languages","stargazers_url":"https://api.github.com/repos/facebook/rocksdb/stargazers","contributors_url":"https://api.github.com/repos/facebook/rocksdb/contributors","subscribers_url":"https://api.github.com/repos/facebook/rocksdb/subscribers","subscription_url":"https://api.github.com/repos/facebook/rocksdb/subscription","commits_url":"https://api.github.com/repos/facebook/rocksdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/rocksdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/rocksdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/rocksdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/rocksdb/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/rocksdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/rocksdb/merges","archive_url":"https://api.github.com/repos/facebook/rocksdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/rocksdb/downloads","issues_url":"https://api.github.com/repos/facebook/rocksdb/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/rocksdb/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/rocksdb/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/rocksdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/rocksdb/labels{/name}","releases_url":"https://api.github.com/repos/facebook/rocksdb/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/rocksdb/deployments","created_at":"2012-11-30T06:16:18Z","updated_at":"2018-08-16T17:58:49Z","pushed_at":"2018-08-16T19:47:14Z","git_url":"git://github.com/facebook/rocksdb.git","ssh_url":"git@github.com:facebook/rocksdb.git","clone_url":"https://github.com/facebook/rocksdb.git","svn_url":"https://github.com/facebook/rocksdb","homepage":"http://rocksdb.org","size":117049,"stargazers_count":11289,"watchers_count":11289,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2476,"mirror_url":null,"archived":false,"open_issues_count":210,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2476,"open_issues":210,"watchers":11289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/4281"},"html":{"href":"https://github.com/facebook/rocksdb/pull/4281"},"issue":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/4281"},"comments":{"href":"https://api.github.com/repos/facebook/rocksdb/issues/4281/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/4281/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/rocksdb/pulls/4281/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/rocksdb/statuses/f6d4b7501c8cdca21282f851a693f9cff8fb1444"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sagar0"}}