{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cordova-paramedic/issues/51","repository_url":"https://api.github.com/repos/apache/cordova-paramedic","labels_url":"https://api.github.com/repos/apache/cordova-paramedic/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/apache/cordova-paramedic/issues/51/comments","events_url":"https://api.github.com/repos/apache/cordova-paramedic/issues/51/events","html_url":"https://github.com/apache/cordova-paramedic/pull/51","id":366622096,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMjQ5NTgy","number":51,"title":"[GH-38] execute launching app and waiting results in parallel","user":{"login":"knight9999","id":5112183,"node_id":"MDQ6VXNlcjUxMTIxODM=","avatar_url":"https://avatars0.githubusercontent.com/u/5112183?v=4","gravatar_id":"","url":"https://api.github.com/users/knight9999","html_url":"https://github.com/knight9999","followers_url":"https://api.github.com/users/knight9999/followers","following_url":"https://api.github.com/users/knight9999/following{/other_user}","gists_url":"https://api.github.com/users/knight9999/gists{/gist_id}","starred_url":"https://api.github.com/users/knight9999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knight9999/subscriptions","organizations_url":"https://api.github.com/users/knight9999/orgs","repos_url":"https://api.github.com/users/knight9999/repos","events_url":"https://api.github.com/users/knight9999/events{/privacy}","received_events_url":"https://api.github.com/users/knight9999/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-04T04:56:13Z","updated_at":"2018-10-05T04:44:11Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/cordova-paramedic/pulls/51","html_url":"https://github.com/apache/cordova-paramedic/pull/51","diff_url":"https://github.com/apache/cordova-paramedic/pull/51.diff","patch_url":"https://github.com/apache/cordova-paramedic/pull/51.patch"},"body":"<!--\r\nPlease make sure the checklist boxes are all checked before submitting the PR. The checklist\r\nis intended as a quick reference, for complete details please see our Contributor Guidelines:\r\n\r\nhttp://cordova.apache.org/contribute/contribute_guidelines.html\r\n\r\nThanks!\r\n-->\r\n\r\n### Platforms affected\r\nAll platforms (tests only)\r\nMain target is Windows 10.\r\n\r\n### What does this PR do?\r\n\r\nFix #38 .\r\n\r\nIn `runLocalTests` following tasks are called in order.\r\n\r\n1. launching test application\r\n2. waiting application test results \r\n\r\nHowever sometimes jasmine tests in application are finished before wating test results in cordova-paramedic. At least I met this issue in Windows 10. (Please see #38)\r\n\r\nAfter this PR,  these two tasks are called in parallel.\r\nThen the cordova-paramedic can detect jasmine tests results normally. \r\n\r\n### What testing has been done on this change?\r\nIn my local PC (Windows 10),\r\n```\r\nnpm run test-windows\r\n```\r\n(with Windows Loopback Exemption Manager as mentioned https://github.com/apache/cordova-paramedic#windows-quirks )\r\n\r\nThis test fails in appveyor.\r\nThat is another issue reported #37\r\n\r\n### Checklist\r\n- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database\r\n- [ ] Commit message follows the format: \"CB-3232: (android) Fix bug with resolving file paths\", where CB-xxxx is the JIRA ID & \"android\" is the platform affected.\r\n- [ ] Added automated test coverage as appropriate for this change.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/cordova-paramedic/issues/comments/427244702","html_url":"https://github.com/apache/cordova-paramedic/pull/51#issuecomment-427244702","issue_url":"https://api.github.com/repos/apache/cordova-paramedic/issues/51","id":427244702,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzI0NDcwMg==","user":{"login":"knight9999","id":5112183,"node_id":"MDQ6VXNlcjUxMTIxODM=","avatar_url":"https://avatars0.githubusercontent.com/u/5112183?v=4","gravatar_id":"","url":"https://api.github.com/users/knight9999","html_url":"https://github.com/knight9999","followers_url":"https://api.github.com/users/knight9999/followers","following_url":"https://api.github.com/users/knight9999/following{/other_user}","gists_url":"https://api.github.com/users/knight9999/gists{/gist_id}","starred_url":"https://api.github.com/users/knight9999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knight9999/subscriptions","organizations_url":"https://api.github.com/users/knight9999/orgs","repos_url":"https://api.github.com/users/knight9999/repos","events_url":"https://api.github.com/users/knight9999/events{/privacy}","received_events_url":"https://api.github.com/users/knight9999/received_events","type":"User","site_admin":false},"created_at":"2018-10-05T04:44:11Z","updated_at":"2018-10-05T04:44:11Z","author_association":"NONE","body":"Thanks for the feedback. It won't increase the overall testing time, since the fix is to wait the Jasmine execution properly. I also changed multiple tests to run in parallel (previous it was sequencial) so the overall time should not increase.\r\n\r\nConverting all Q to the native promise can be done later in my opinion since we need to convert all other Qs used there into promises. I can send another PR that converts to the native promises but in the later phase."}}
{"actor":{"display_login":"knight9999"}}