{"action":"created","comment":{"url":"https://api.github.com/repos/scummvm/scummvm/pulls/comments/238466965","pull_request_review_id":181016022,"id":238466965,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODQ2Njk2NQ==","diff_hunk":"@@ -8217,6 +8217,46 @@ static const uint16 qfg4ConditionalVoidPatch[] = {\n \tPATCH_END\n };\n \n+// The copy protection in floppy versions has a script bug which uses disposed\n+//  objects and crashes our interpreter. This appears to work in Sierra's\n+//  interpreter although they fixed the script bug in the CD version.","path":"engines/sci/engine/script_patches.cpp","position":6,"original_position":6,"commit_id":"aa4626abaab8460b3e462d354c94a3be1ca0427f","original_commit_id":"aa4626abaab8460b3e462d354c94a3be1ca0427f","user":{"login":"sluicebox","id":22204938,"node_id":"MDQ6VXNlcjIyMjA0OTM4","avatar_url":"https://avatars1.githubusercontent.com/u/22204938?v=4","gravatar_id":"","url":"https://api.github.com/users/sluicebox","html_url":"https://github.com/sluicebox","followers_url":"https://api.github.com/users/sluicebox/followers","following_url":"https://api.github.com/users/sluicebox/following{/other_user}","gists_url":"https://api.github.com/users/sluicebox/gists{/gist_id}","starred_url":"https://api.github.com/users/sluicebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sluicebox/subscriptions","organizations_url":"https://api.github.com/users/sluicebox/orgs","repos_url":"https://api.github.com/users/sluicebox/repos","events_url":"https://api.github.com/users/sluicebox/events{/privacy}","received_events_url":"https://api.github.com/users/sluicebox/received_events","type":"User","site_admin":false},"body":"What would you prefer? I don't see what's inaccurate about that high level description. Sierra fixed this the script bug by adding logic to not dispose these objects so that they wouldn't use disposed objects, so I don't know how this is anything other than a use-after-free class of bug that appears to work in the original.\r\n\r\nIs your concern that the comment implies that it's a bug to re-use any object after disposal? I get that that's okay, but in this case that's specifically the bug: disposing sets View:plane to 0 so using that View it leads to kAddItemToScreen erroring. If \"uses\" were changed to \"displays\" would that be better?","created_at":"2018-12-03T22:40:58Z","updated_at":"2018-12-03T22:40:59Z","html_url":"https://github.com/scummvm/scummvm/pull/1431#discussion_r238466965","pull_request_url":"https://api.github.com/repos/scummvm/scummvm/pulls/1431","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/comments/238466965"},"html":{"href":"https://github.com/scummvm/scummvm/pull/1431#discussion_r238466965"},"pull_request":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/1431"}},"in_reply_to_id":238430604},"pull_request":{"url":"https://api.github.com/repos/scummvm/scummvm/pulls/1431","id":235375422,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1Mzc1NDIy","html_url":"https://github.com/scummvm/scummvm/pull/1431","diff_url":"https://github.com/scummvm/scummvm/pull/1431.diff","patch_url":"https://github.com/scummvm/scummvm/pull/1431.patch","issue_url":"https://api.github.com/repos/scummvm/scummvm/issues/1431","number":1431,"state":"closed","locked":false,"title":"SCI32: Fix QFG4 copy protection crash, bug #10773","user":{"login":"sluicebox","id":22204938,"node_id":"MDQ6VXNlcjIyMjA0OTM4","avatar_url":"https://avatars1.githubusercontent.com/u/22204938?v=4","gravatar_id":"","url":"https://api.github.com/users/sluicebox","html_url":"https://github.com/sluicebox","followers_url":"https://api.github.com/users/sluicebox/followers","following_url":"https://api.github.com/users/sluicebox/following{/other_user}","gists_url":"https://api.github.com/users/sluicebox/gists{/gist_id}","starred_url":"https://api.github.com/users/sluicebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sluicebox/subscriptions","organizations_url":"https://api.github.com/users/sluicebox/orgs","repos_url":"https://api.github.com/users/sluicebox/repos","events_url":"https://api.github.com/users/sluicebox/events{/privacy}","received_events_url":"https://api.github.com/users/sluicebox/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-03T09:21:54Z","updated_at":"2018-12-03T22:40:59Z","closed_at":"2018-12-03T20:34:14Z","merged_at":"2018-12-03T20:34:14Z","merge_commit_sha":"b9c60558369f0c503e82ba029eb5c78583dc3e6b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scummvm/scummvm/pulls/1431/commits","review_comments_url":"https://api.github.com/repos/scummvm/scummvm/pulls/1431/comments","review_comment_url":"https://api.github.com/repos/scummvm/scummvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scummvm/scummvm/issues/1431/comments","statuses_url":"https://api.github.com/repos/scummvm/scummvm/statuses/aa4626abaab8460b3e462d354c94a3be1ca0427f","head":{"label":"sluicebox:qfg4copyprotectionfix","ref":"qfg4copyprotectionfix","sha":"aa4626abaab8460b3e462d354c94a3be1ca0427f","user":{"login":"sluicebox","id":22204938,"node_id":"MDQ6VXNlcjIyMjA0OTM4","avatar_url":"https://avatars1.githubusercontent.com/u/22204938?v=4","gravatar_id":"","url":"https://api.github.com/users/sluicebox","html_url":"https://github.com/sluicebox","followers_url":"https://api.github.com/users/sluicebox/followers","following_url":"https://api.github.com/users/sluicebox/following{/other_user}","gists_url":"https://api.github.com/users/sluicebox/gists{/gist_id}","starred_url":"https://api.github.com/users/sluicebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sluicebox/subscriptions","organizations_url":"https://api.github.com/users/sluicebox/orgs","repos_url":"https://api.github.com/users/sluicebox/repos","events_url":"https://api.github.com/users/sluicebox/events{/privacy}","received_events_url":"https://api.github.com/users/sluicebox/received_events","type":"User","site_admin":false},"repo":{"id":148263061,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyNjMwNjE=","name":"scummvm","full_name":"sluicebox/scummvm","private":false,"owner":{"login":"sluicebox","id":22204938,"node_id":"MDQ6VXNlcjIyMjA0OTM4","avatar_url":"https://avatars1.githubusercontent.com/u/22204938?v=4","gravatar_id":"","url":"https://api.github.com/users/sluicebox","html_url":"https://github.com/sluicebox","followers_url":"https://api.github.com/users/sluicebox/followers","following_url":"https://api.github.com/users/sluicebox/following{/other_user}","gists_url":"https://api.github.com/users/sluicebox/gists{/gist_id}","starred_url":"https://api.github.com/users/sluicebox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sluicebox/subscriptions","organizations_url":"https://api.github.com/users/sluicebox/orgs","repos_url":"https://api.github.com/users/sluicebox/repos","events_url":"https://api.github.com/users/sluicebox/events{/privacy}","received_events_url":"https://api.github.com/users/sluicebox/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sluicebox/scummvm","description":"ScummVM main repository","fork":true,"url":"https://api.github.com/repos/sluicebox/scummvm","forks_url":"https://api.github.com/repos/sluicebox/scummvm/forks","keys_url":"https://api.github.com/repos/sluicebox/scummvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sluicebox/scummvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sluicebox/scummvm/teams","hooks_url":"https://api.github.com/repos/sluicebox/scummvm/hooks","issue_events_url":"https://api.github.com/repos/sluicebox/scummvm/issues/events{/number}","events_url":"https://api.github.com/repos/sluicebox/scummvm/events","assignees_url":"https://api.github.com/repos/sluicebox/scummvm/assignees{/user}","branches_url":"https://api.github.com/repos/sluicebox/scummvm/branches{/branch}","tags_url":"https://api.github.com/repos/sluicebox/scummvm/tags","blobs_url":"https://api.github.com/repos/sluicebox/scummvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sluicebox/scummvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sluicebox/scummvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/sluicebox/scummvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sluicebox/scummvm/statuses/{sha}","languages_url":"https://api.github.com/repos/sluicebox/scummvm/languages","stargazers_url":"https://api.github.com/repos/sluicebox/scummvm/stargazers","contributors_url":"https://api.github.com/repos/sluicebox/scummvm/contributors","subscribers_url":"https://api.github.com/repos/sluicebox/scummvm/subscribers","subscription_url":"https://api.github.com/repos/sluicebox/scummvm/subscription","commits_url":"https://api.github.com/repos/sluicebox/scummvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/sluicebox/scummvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/sluicebox/scummvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/sluicebox/scummvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/sluicebox/scummvm/contents/{+path}","compare_url":"https://api.github.com/repos/sluicebox/scummvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sluicebox/scummvm/merges","archive_url":"https://api.github.com/repos/sluicebox/scummvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sluicebox/scummvm/downloads","issues_url":"https://api.github.com/repos/sluicebox/scummvm/issues{/number}","pulls_url":"https://api.github.com/repos/sluicebox/scummvm/pulls{/number}","milestones_url":"https://api.github.com/repos/sluicebox/scummvm/milestones{/number}","notifications_url":"https://api.github.com/repos/sluicebox/scummvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sluicebox/scummvm/labels{/name}","releases_url":"https://api.github.com/repos/sluicebox/scummvm/releases{/id}","deployments_url":"https://api.github.com/repos/sluicebox/scummvm/deployments","created_at":"2018-09-11T05:04:48Z","updated_at":"2018-12-03T08:50:18Z","pushed_at":"2018-12-03T09:20:33Z","git_url":"git://github.com/sluicebox/scummvm.git","ssh_url":"git@github.com:sluicebox/scummvm.git","clone_url":"https://github.com/sluicebox/scummvm.git","svn_url":"https://github.com/sluicebox/scummvm","homepage":"http://www.scummvm.org/","size":309533,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scummvm:master","ref":"master","sha":"40ff3048f4c22696b9bcdb9af6cbea87c15951c3","user":{"login":"scummvm","id":365181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTE4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/365181?v=4","gravatar_id":"","url":"https://api.github.com/users/scummvm","html_url":"https://github.com/scummvm","followers_url":"https://api.github.com/users/scummvm/followers","following_url":"https://api.github.com/users/scummvm/following{/other_user}","gists_url":"https://api.github.com/users/scummvm/gists{/gist_id}","starred_url":"https://api.github.com/users/scummvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scummvm/subscriptions","organizations_url":"https://api.github.com/users/scummvm/orgs","repos_url":"https://api.github.com/users/scummvm/repos","events_url":"https://api.github.com/users/scummvm/events{/privacy}","received_events_url":"https://api.github.com/users/scummvm/received_events","type":"Organization","site_admin":false},"repo":{"id":1358940,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU4OTQw","name":"scummvm","full_name":"scummvm/scummvm","private":false,"owner":{"login":"scummvm","id":365181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTE4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/365181?v=4","gravatar_id":"","url":"https://api.github.com/users/scummvm","html_url":"https://github.com/scummvm","followers_url":"https://api.github.com/users/scummvm/followers","following_url":"https://api.github.com/users/scummvm/following{/other_user}","gists_url":"https://api.github.com/users/scummvm/gists{/gist_id}","starred_url":"https://api.github.com/users/scummvm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scummvm/subscriptions","organizations_url":"https://api.github.com/users/scummvm/orgs","repos_url":"https://api.github.com/users/scummvm/repos","events_url":"https://api.github.com/users/scummvm/events{/privacy}","received_events_url":"https://api.github.com/users/scummvm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scummvm/scummvm","description":"ScummVM main repository","fork":false,"url":"https://api.github.com/repos/scummvm/scummvm","forks_url":"https://api.github.com/repos/scummvm/scummvm/forks","keys_url":"https://api.github.com/repos/scummvm/scummvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scummvm/scummvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scummvm/scummvm/teams","hooks_url":"https://api.github.com/repos/scummvm/scummvm/hooks","issue_events_url":"https://api.github.com/repos/scummvm/scummvm/issues/events{/number}","events_url":"https://api.github.com/repos/scummvm/scummvm/events","assignees_url":"https://api.github.com/repos/scummvm/scummvm/assignees{/user}","branches_url":"https://api.github.com/repos/scummvm/scummvm/branches{/branch}","tags_url":"https://api.github.com/repos/scummvm/scummvm/tags","blobs_url":"https://api.github.com/repos/scummvm/scummvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scummvm/scummvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scummvm/scummvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/scummvm/scummvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scummvm/scummvm/statuses/{sha}","languages_url":"https://api.github.com/repos/scummvm/scummvm/languages","stargazers_url":"https://api.github.com/repos/scummvm/scummvm/stargazers","contributors_url":"https://api.github.com/repos/scummvm/scummvm/contributors","subscribers_url":"https://api.github.com/repos/scummvm/scummvm/subscribers","subscription_url":"https://api.github.com/repos/scummvm/scummvm/subscription","commits_url":"https://api.github.com/repos/scummvm/scummvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/scummvm/scummvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/scummvm/scummvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/scummvm/scummvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/scummvm/scummvm/contents/{+path}","compare_url":"https://api.github.com/repos/scummvm/scummvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scummvm/scummvm/merges","archive_url":"https://api.github.com/repos/scummvm/scummvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scummvm/scummvm/downloads","issues_url":"https://api.github.com/repos/scummvm/scummvm/issues{/number}","pulls_url":"https://api.github.com/repos/scummvm/scummvm/pulls{/number}","milestones_url":"https://api.github.com/repos/scummvm/scummvm/milestones{/number}","notifications_url":"https://api.github.com/repos/scummvm/scummvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scummvm/scummvm/labels{/name}","releases_url":"https://api.github.com/repos/scummvm/scummvm/releases{/id}","deployments_url":"https://api.github.com/repos/scummvm/scummvm/deployments","created_at":"2011-02-12T15:50:57Z","updated_at":"2018-12-03T20:34:23Z","pushed_at":"2018-12-03T20:34:14Z","git_url":"git://github.com/scummvm/scummvm.git","ssh_url":"git@github.com:scummvm/scummvm.git","clone_url":"https://github.com/scummvm/scummvm.git","svn_url":"https://github.com/scummvm/scummvm","homepage":"http://www.scummvm.org/","size":309358,"stargazers_count":981,"watchers_count":981,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":477,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":477,"open_issues":37,"watchers":981,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/1431"},"html":{"href":"https://github.com/scummvm/scummvm/pull/1431"},"issue":{"href":"https://api.github.com/repos/scummvm/scummvm/issues/1431"},"comments":{"href":"https://api.github.com/repos/scummvm/scummvm/issues/1431/comments"},"review_comments":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/1431/comments"},"review_comment":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scummvm/scummvm/pulls/1431/commits"},"statuses":{"href":"https://api.github.com/repos/scummvm/scummvm/statuses/aa4626abaab8460b3e462d354c94a3be1ca0427f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sluicebox"}}