{"action":"created","issue":{"url":"https://api.github.com/repos/espressomd/espresso/issues/2368","repository_url":"https://api.github.com/repos/espressomd/espresso","labels_url":"https://api.github.com/repos/espressomd/espresso/issues/2368/labels{/name}","comments_url":"https://api.github.com/repos/espressomd/espresso/issues/2368/comments","events_url":"https://api.github.com/repos/espressomd/espresso/issues/2368/events","html_url":"https://github.com/espressomd/espresso/pull/2368","id":378794688,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDEzOTE3","number":2368,"title":"testsuite: guard LB tests from evil SHANCHEN feature.","user":{"login":"KaiSzuttor","id":2150555,"node_id":"MDQ6VXNlcjIxNTA1NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/2150555?v=4","gravatar_id":"","url":"https://api.github.com/users/KaiSzuttor","html_url":"https://github.com/KaiSzuttor","followers_url":"https://api.github.com/users/KaiSzuttor/followers","following_url":"https://api.github.com/users/KaiSzuttor/following{/other_user}","gists_url":"https://api.github.com/users/KaiSzuttor/gists{/gist_id}","starred_url":"https://api.github.com/users/KaiSzuttor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaiSzuttor/subscriptions","organizations_url":"https://api.github.com/users/KaiSzuttor/orgs","repos_url":"https://api.github.com/users/KaiSzuttor/repos","events_url":"https://api.github.com/users/KaiSzuttor/events{/privacy}","received_events_url":"https://api.github.com/users/KaiSzuttor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-08T15:53:23Z","updated_at":"2018-11-08T16:31:17Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/espressomd/espresso/pulls/2368","html_url":"https://github.com/espressomd/espresso/pull/2368","diff_url":"https://github.com/espressomd/espresso/pull/2368.diff","patch_url":"https://github.com/espressomd/espresso/pull/2368.patch"},"body":"\r\n"},"comment":{"url":"https://api.github.com/repos/espressomd/espresso/issues/comments/437060713","html_url":"https://github.com/espressomd/espresso/pull/2368#issuecomment-437060713","issue_url":"https://api.github.com/repos/espressomd/espresso/issues/2368","id":437060713,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzA2MDcxMw==","user":{"login":"espresso-ci","id":31063763,"node_id":"MDQ6VXNlcjMxMDYzNzYz","avatar_url":"https://avatars2.githubusercontent.com/u/31063763?v=4","gravatar_id":"","url":"https://api.github.com/users/espresso-ci","html_url":"https://github.com/espresso-ci","followers_url":"https://api.github.com/users/espresso-ci/followers","following_url":"https://api.github.com/users/espresso-ci/following{/other_user}","gists_url":"https://api.github.com/users/espresso-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/espresso-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/espresso-ci/subscriptions","organizations_url":"https://api.github.com/users/espresso-ci/orgs","repos_url":"https://api.github.com/users/espresso-ci/repos","events_url":"https://api.github.com/users/espresso-ci/events{/privacy}","received_events_url":"https://api.github.com/users/espresso-ci/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T16:31:17Z","updated_at":"2018-11-08T16:31:17Z","author_association":"NONE","body":"Your pull request does not meet our code formatting rules. Specifically, I suggest you make the following changes:\n```diff\ndiff --git a/testsuite/python/lb.py b/testsuite/python/lb.py\nindex ede6c70..d6d55cb 100644\n--- a/testsuite/python/lb.py\n+++ b/testsuite/python/lb.py\n@@ -239,7 +239,8 @@ class TestLB(object):\n                 np.copy(self.lbf[n].velocity), fluid_velocity, atol=1E-6)\n \n \n-@ut.skipIf(not espressomd.has_features([\"LB\"]) or espressomd.has_features(\"SHANCHEN\"),\n+@ut.skipIf(\n+    not espressomd.has_features([\"LB\"]) or espressomd.has_features(\"SHANCHEN\"),\n            \"Features not available, skipping test!\")\n class TestLBCPU(TestLB, ut.TestCase):\n```\nTo apply these changes, please do one of the following:\n- You can download a patch with my suggested changes [here](https://gitlab.icp.uni-stuttgart.de/espressomd/espresso/-/jobs/50346/artifacts/raw/style.patch), inspect it and make changes manually.\n- You can directly apply it to your repository by running `curl https://gitlab.icp.uni-stuttgart.de/espressomd/espresso/-/jobs/50346/artifacts/raw/style.patch | git apply -`.\n- You can run `maintainer/CI/fix_style.sh` to automatically fix your coding style. This is the same command that I have executed to generate the patch above, but it requires certain tools to be installed on your computer.\n\nYou can run `gitlab-runner exec docker style` afterwards to check if your changes worked out properly.\n\nPlease note that there are often multiple ways to correctly format code. As I am just a robot, I sometimes fail to identify the most aesthetically pleasing way. So please look over my suggested changes and adapt them where the style does not make sense."}}
{"actor":{"display_login":"espresso-ci"}}