{"action":"created","comment":{"url":"https://api.github.com/repos/axtimwalde/mpicbg/pulls/comments/227076433","pull_request_review_id":167036127,"id":227076433,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzA3NjQzMw==","diff_hunk":"@@ -282,6 +282,20 @@ final public void set( final AffineModel1D m )\n \t\tinvert();\n \t}\n \n+\t@Override\n+\tfinal public void reset()\n+\t{\n+\t\tset( new AffineModel1D() );","path":"mpicbg/src/main/java/mpicbg/models/AffineModel1D.java","position":null,"original_position":7,"commit_id":"4560652c187165dc0cb7e1e9db600b574b1e1d8b","original_commit_id":"09be63c0b4475fc01cfa31cf96d80cf4354afc27","user":{"login":"igorpisarev","id":6253116,"node_id":"MDQ6VXNlcjYyNTMxMTY=","avatar_url":"https://avatars0.githubusercontent.com/u/6253116?v=4","gravatar_id":"","url":"https://api.github.com/users/igorpisarev","html_url":"https://github.com/igorpisarev","followers_url":"https://api.github.com/users/igorpisarev/followers","following_url":"https://api.github.com/users/igorpisarev/following{/other_user}","gists_url":"https://api.github.com/users/igorpisarev/gists{/gist_id}","starred_url":"https://api.github.com/users/igorpisarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorpisarev/subscriptions","organizations_url":"https://api.github.com/users/igorpisarev/orgs","repos_url":"https://api.github.com/users/igorpisarev/repos","events_url":"https://api.github.com/users/igorpisarev/events{/privacy}","received_events_url":"https://api.github.com/users/igorpisarev/received_events","type":"User","site_admin":false},"body":"I believe this changeset is outdated, as I already pushed the new code for that 34eb8cc","created_at":"2018-10-22T18:06:15Z","updated_at":"2018-10-22T18:06:16Z","html_url":"https://github.com/axtimwalde/mpicbg/pull/42#discussion_r227076433","pull_request_url":"https://api.github.com/repos/axtimwalde/mpicbg/pulls/42","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/axtimwalde/mpicbg/pulls/comments/227076433"},"html":{"href":"https://github.com/axtimwalde/mpicbg/pull/42#discussion_r227076433"},"pull_request":{"href":"https://api.github.com/repos/axtimwalde/mpicbg/pulls/42"}},"in_reply_to_id":226777773},"pull_request":{"url":"https://api.github.com/repos/axtimwalde/mpicbg/pulls/42","id":223641610,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjQxNjEw","html_url":"https://github.com/axtimwalde/mpicbg/pull/42","diff_url":"https://github.com/axtimwalde/mpicbg/pull/42.diff","patch_url":"https://github.com/axtimwalde/mpicbg/pull/42.patch","issue_url":"https://api.github.com/repos/axtimwalde/mpicbg/issues/42","number":42,"state":"open","locked":false,"title":"Better set() methods for models","user":{"login":"igorpisarev","id":6253116,"node_id":"MDQ6VXNlcjYyNTMxMTY=","avatar_url":"https://avatars0.githubusercontent.com/u/6253116?v=4","gravatar_id":"","url":"https://api.github.com/users/igorpisarev","html_url":"https://github.com/igorpisarev","followers_url":"https://api.github.com/users/igorpisarev/followers","following_url":"https://api.github.com/users/igorpisarev/following{/other_user}","gists_url":"https://api.github.com/users/igorpisarev/gists{/gist_id}","starred_url":"https://api.github.com/users/igorpisarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorpisarev/subscriptions","organizations_url":"https://api.github.com/users/igorpisarev/orgs","repos_url":"https://api.github.com/users/igorpisarev/repos","events_url":"https://api.github.com/users/igorpisarev/events{/privacy}","received_events_url":"https://api.github.com/users/igorpisarev/received_events","type":"User","site_admin":false},"body":"* For each model type, add `set()` methods that take a more restricted model as an input (for example, `SimilarityModel3D` now can also be initialized with `TranslationModel3D` and `RigidModel3D`)\r\n* Add `reset()` method which sets the model to identity\r\n* Make `interpolate()` an abstract method of `InterpolatedModel`. This is to allow initializing the interpolated models properly (the caller can use the above `set()` methods for `A` and `B` and then call `interpolate()` to ensure consistency).","created_at":"2018-10-17T15:05:18Z","updated_at":"2018-10-22T18:06:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f6491e69c6901b90c4bcad24f1bb5e38819501e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/axtimwalde/mpicbg/pulls/42/commits","review_comments_url":"https://api.github.com/repos/axtimwalde/mpicbg/pulls/42/comments","review_comment_url":"https://api.github.com/repos/axtimwalde/mpicbg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/axtimwalde/mpicbg/issues/42/comments","statuses_url":"https://api.github.com/repos/axtimwalde/mpicbg/statuses/4560652c187165dc0cb7e1e9db600b574b1e1d8b","head":{"label":"igorpisarev:better-set-methods-for-models","ref":"better-set-methods-for-models","sha":"4560652c187165dc0cb7e1e9db600b574b1e1d8b","user":{"login":"igorpisarev","id":6253116,"node_id":"MDQ6VXNlcjYyNTMxMTY=","avatar_url":"https://avatars0.githubusercontent.com/u/6253116?v=4","gravatar_id":"","url":"https://api.github.com/users/igorpisarev","html_url":"https://github.com/igorpisarev","followers_url":"https://api.github.com/users/igorpisarev/followers","following_url":"https://api.github.com/users/igorpisarev/following{/other_user}","gists_url":"https://api.github.com/users/igorpisarev/gists{/gist_id}","starred_url":"https://api.github.com/users/igorpisarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorpisarev/subscriptions","organizations_url":"https://api.github.com/users/igorpisarev/orgs","repos_url":"https://api.github.com/users/igorpisarev/repos","events_url":"https://api.github.com/users/igorpisarev/events{/privacy}","received_events_url":"https://api.github.com/users/igorpisarev/received_events","type":"User","site_admin":false},"repo":{"id":74587397,"node_id":"MDEwOlJlcG9zaXRvcnk3NDU4NzM5Nw==","name":"mpicbg","full_name":"igorpisarev/mpicbg","private":false,"owner":{"login":"igorpisarev","id":6253116,"node_id":"MDQ6VXNlcjYyNTMxMTY=","avatar_url":"https://avatars0.githubusercontent.com/u/6253116?v=4","gravatar_id":"","url":"https://api.github.com/users/igorpisarev","html_url":"https://github.com/igorpisarev","followers_url":"https://api.github.com/users/igorpisarev/followers","following_url":"https://api.github.com/users/igorpisarev/following{/other_user}","gists_url":"https://api.github.com/users/igorpisarev/gists{/gist_id}","starred_url":"https://api.github.com/users/igorpisarev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igorpisarev/subscriptions","organizations_url":"https://api.github.com/users/igorpisarev/orgs","repos_url":"https://api.github.com/users/igorpisarev/repos","events_url":"https://api.github.com/users/igorpisarev/events{/privacy}","received_events_url":"https://api.github.com/users/igorpisarev/received_events","type":"User","site_admin":false},"html_url":"https://github.com/igorpisarev/mpicbg","description":"Fiji module for image transformation and related algorithms","fork":true,"url":"https://api.github.com/repos/igorpisarev/mpicbg","forks_url":"https://api.github.com/repos/igorpisarev/mpicbg/forks","keys_url":"https://api.github.com/repos/igorpisarev/mpicbg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igorpisarev/mpicbg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igorpisarev/mpicbg/teams","hooks_url":"https://api.github.com/repos/igorpisarev/mpicbg/hooks","issue_events_url":"https://api.github.com/repos/igorpisarev/mpicbg/issues/events{/number}","events_url":"https://api.github.com/repos/igorpisarev/mpicbg/events","assignees_url":"https://api.github.com/repos/igorpisarev/mpicbg/assignees{/user}","branches_url":"https://api.github.com/repos/igorpisarev/mpicbg/branches{/branch}","tags_url":"https://api.github.com/repos/igorpisarev/mpicbg/tags","blobs_url":"https://api.github.com/repos/igorpisarev/mpicbg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igorpisarev/mpicbg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igorpisarev/mpicbg/git/refs{/sha}","trees_url":"https://api.github.com/repos/igorpisarev/mpicbg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igorpisarev/mpicbg/statuses/{sha}","languages_url":"https://api.github.com/repos/igorpisarev/mpicbg/languages","stargazers_url":"https://api.github.com/repos/igorpisarev/mpicbg/stargazers","contributors_url":"https://api.github.com/repos/igorpisarev/mpicbg/contributors","subscribers_url":"https://api.github.com/repos/igorpisarev/mpicbg/subscribers","subscription_url":"https://api.github.com/repos/igorpisarev/mpicbg/subscription","commits_url":"https://api.github.com/repos/igorpisarev/mpicbg/commits{/sha}","git_commits_url":"https://api.github.com/repos/igorpisarev/mpicbg/git/commits{/sha}","comments_url":"https://api.github.com/repos/igorpisarev/mpicbg/comments{/number}","issue_comment_url":"https://api.github.com/repos/igorpisarev/mpicbg/issues/comments{/number}","contents_url":"https://api.github.com/repos/igorpisarev/mpicbg/contents/{+path}","compare_url":"https://api.github.com/repos/igorpisarev/mpicbg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igorpisarev/mpicbg/merges","archive_url":"https://api.github.com/repos/igorpisarev/mpicbg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igorpisarev/mpicbg/downloads","issues_url":"https://api.github.com/repos/igorpisarev/mpicbg/issues{/number}","pulls_url":"https://api.github.com/repos/igorpisarev/mpicbg/pulls{/number}","milestones_url":"https://api.github.com/repos/igorpisarev/mpicbg/milestones{/number}","notifications_url":"https://api.github.com/repos/igorpisarev/mpicbg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igorpisarev/mpicbg/labels{/name}","releases_url":"https://api.github.com/repos/igorpisarev/mpicbg/releases{/id}","deployments_url":"https://api.github.com/repos/igorpisarev/mpicbg/deployments","created_at":"2016-11-23T15:04:24Z","updated_at":"2018-10-16T18:31:12Z","pushed_at":"2018-10-22T15:54:50Z","git_url":"git://github.com/igorpisarev/mpicbg.git","ssh_url":"git@github.com:igorpisarev/mpicbg.git","clone_url":"https://github.com/igorpisarev/mpicbg.git","svn_url":"https://github.com/igorpisarev/mpicbg","homepage":"http://fly.mpi-cbg.de/saalfeld/Projects","size":1864,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"axtimwalde:master","ref":"master","sha":"9f69de3966f6d647fd0e243c282a1791e494b816","user":{"login":"axtimwalde","id":385072,"node_id":"MDQ6VXNlcjM4NTA3Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/385072?v=4","gravatar_id":"","url":"https://api.github.com/users/axtimwalde","html_url":"https://github.com/axtimwalde","followers_url":"https://api.github.com/users/axtimwalde/followers","following_url":"https://api.github.com/users/axtimwalde/following{/other_user}","gists_url":"https://api.github.com/users/axtimwalde/gists{/gist_id}","starred_url":"https://api.github.com/users/axtimwalde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axtimwalde/subscriptions","organizations_url":"https://api.github.com/users/axtimwalde/orgs","repos_url":"https://api.github.com/users/axtimwalde/repos","events_url":"https://api.github.com/users/axtimwalde/events{/privacy}","received_events_url":"https://api.github.com/users/axtimwalde/received_events","type":"User","site_admin":false},"repo":{"id":3661550,"node_id":"MDEwOlJlcG9zaXRvcnkzNjYxNTUw","name":"mpicbg","full_name":"axtimwalde/mpicbg","private":false,"owner":{"login":"axtimwalde","id":385072,"node_id":"MDQ6VXNlcjM4NTA3Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/385072?v=4","gravatar_id":"","url":"https://api.github.com/users/axtimwalde","html_url":"https://github.com/axtimwalde","followers_url":"https://api.github.com/users/axtimwalde/followers","following_url":"https://api.github.com/users/axtimwalde/following{/other_user}","gists_url":"https://api.github.com/users/axtimwalde/gists{/gist_id}","starred_url":"https://api.github.com/users/axtimwalde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axtimwalde/subscriptions","organizations_url":"https://api.github.com/users/axtimwalde/orgs","repos_url":"https://api.github.com/users/axtimwalde/repos","events_url":"https://api.github.com/users/axtimwalde/events{/privacy}","received_events_url":"https://api.github.com/users/axtimwalde/received_events","type":"User","site_admin":false},"html_url":"https://github.com/axtimwalde/mpicbg","description":"Fiji module for image transformation and related algorithms","fork":false,"url":"https://api.github.com/repos/axtimwalde/mpicbg","forks_url":"https://api.github.com/repos/axtimwalde/mpicbg/forks","keys_url":"https://api.github.com/repos/axtimwalde/mpicbg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axtimwalde/mpicbg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axtimwalde/mpicbg/teams","hooks_url":"https://api.github.com/repos/axtimwalde/mpicbg/hooks","issue_events_url":"https://api.github.com/repos/axtimwalde/mpicbg/issues/events{/number}","events_url":"https://api.github.com/repos/axtimwalde/mpicbg/events","assignees_url":"https://api.github.com/repos/axtimwalde/mpicbg/assignees{/user}","branches_url":"https://api.github.com/repos/axtimwalde/mpicbg/branches{/branch}","tags_url":"https://api.github.com/repos/axtimwalde/mpicbg/tags","blobs_url":"https://api.github.com/repos/axtimwalde/mpicbg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axtimwalde/mpicbg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axtimwalde/mpicbg/git/refs{/sha}","trees_url":"https://api.github.com/repos/axtimwalde/mpicbg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axtimwalde/mpicbg/statuses/{sha}","languages_url":"https://api.github.com/repos/axtimwalde/mpicbg/languages","stargazers_url":"https://api.github.com/repos/axtimwalde/mpicbg/stargazers","contributors_url":"https://api.github.com/repos/axtimwalde/mpicbg/contributors","subscribers_url":"https://api.github.com/repos/axtimwalde/mpicbg/subscribers","subscription_url":"https://api.github.com/repos/axtimwalde/mpicbg/subscription","commits_url":"https://api.github.com/repos/axtimwalde/mpicbg/commits{/sha}","git_commits_url":"https://api.github.com/repos/axtimwalde/mpicbg/git/commits{/sha}","comments_url":"https://api.github.com/repos/axtimwalde/mpicbg/comments{/number}","issue_comment_url":"https://api.github.com/repos/axtimwalde/mpicbg/issues/comments{/number}","contents_url":"https://api.github.com/repos/axtimwalde/mpicbg/contents/{+path}","compare_url":"https://api.github.com/repos/axtimwalde/mpicbg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axtimwalde/mpicbg/merges","archive_url":"https://api.github.com/repos/axtimwalde/mpicbg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axtimwalde/mpicbg/downloads","issues_url":"https://api.github.com/repos/axtimwalde/mpicbg/issues{/number}","pulls_url":"https://api.github.com/repos/axtimwalde/mpicbg/pulls{/number}","milestones_url":"https://api.github.com/repos/axtimwalde/mpicbg/milestones{/number}","notifications_url":"https://api.github.com/repos/axtimwalde/mpicbg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axtimwalde/mpicbg/labels{/name}","releases_url":"https://api.github.com/repos/axtimwalde/mpicbg/releases{/id}","deployments_url":"https://api.github.com/repos/axtimwalde/mpicbg/deployments","created_at":"2012-03-08T16:01:20Z","updated_at":"2018-08-30T17:18:27Z","pushed_at":"2018-10-22T15:54:52Z","git_url":"git://github.com/axtimwalde/mpicbg.git","ssh_url":"git@github.com:axtimwalde/mpicbg.git","clone_url":"https://github.com/axtimwalde/mpicbg.git","svn_url":"https://github.com/axtimwalde/mpicbg","homepage":"http://fly.mpi-cbg.de/saalfeld/Projects","size":1810,"stargazers_count":33,"watchers_count":33,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":49,"open_issues":4,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/axtimwalde/mpicbg/pulls/42"},"html":{"href":"https://github.com/axtimwalde/mpicbg/pull/42"},"issue":{"href":"https://api.github.com/repos/axtimwalde/mpicbg/issues/42"},"comments":{"href":"https://api.github.com/repos/axtimwalde/mpicbg/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/axtimwalde/mpicbg/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/axtimwalde/mpicbg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/axtimwalde/mpicbg/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/axtimwalde/mpicbg/statuses/4560652c187165dc0cb7e1e9db600b574b1e1d8b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"igorpisarev"}}