{"action":"created","issue":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/22783","repository_url":"https://api.github.com/repos/TrinityCore/TrinityCore","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/22783/labels{/name}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/22783/comments","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/22783/events","html_url":"https://github.com/TrinityCore/TrinityCore/pull/22783","id":379465219,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTE1NzAx","number":22783,"title":"Core/Misc: Log more information in asserts","user":{"login":"jackpoz","id":1153754,"node_id":"MDQ6VXNlcjExNTM3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1153754?v=4","gravatar_id":"","url":"https://api.github.com/users/jackpoz","html_url":"https://github.com/jackpoz","followers_url":"https://api.github.com/users/jackpoz/followers","following_url":"https://api.github.com/users/jackpoz/following{/other_user}","gists_url":"https://api.github.com/users/jackpoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jackpoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackpoz/subscriptions","organizations_url":"https://api.github.com/users/jackpoz/orgs","repos_url":"https://api.github.com/users/jackpoz/repos","events_url":"https://api.github.com/users/jackpoz/events{/privacy}","received_events_url":"https://api.github.com/users/jackpoz/received_events","type":"User","site_admin":false},"labels":[{"id":36087725,"node_id":"MDU6TGFiZWwzNjA4NzcyNQ==","url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Branch-3.3.5a","name":"Branch-3.3.5a","color":"188846","default":false},{"id":26232644,"node_id":"MDU6TGFiZWwyNjIzMjY0NA==","url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Comp-Core","name":"Comp-Core","color":"FF6600","default":false},{"id":11363043,"node_id":"MDU6TGFiZWwxMTM2MzA0Mw==","url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Feedback-FixOutdatedMissingWIP","name":"Feedback-FixOutdatedMissingWIP","color":"d7e102","default":false},{"id":121973,"node_id":"MDU6TGFiZWwxMjE5NzM=","url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels/Priority-FutureFeatureRequest","name":"Priority-FutureFeatureRequest","color":"e102d8","default":false}],"state":"open","locked":false,"assignee":{"login":"jackpoz","id":1153754,"node_id":"MDQ6VXNlcjExNTM3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1153754?v=4","gravatar_id":"","url":"https://api.github.com/users/jackpoz","html_url":"https://github.com/jackpoz","followers_url":"https://api.github.com/users/jackpoz/followers","following_url":"https://api.github.com/users/jackpoz/following{/other_user}","gists_url":"https://api.github.com/users/jackpoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jackpoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackpoz/subscriptions","organizations_url":"https://api.github.com/users/jackpoz/orgs","repos_url":"https://api.github.com/users/jackpoz/repos","events_url":"https://api.github.com/users/jackpoz/events{/privacy}","received_events_url":"https://api.github.com/users/jackpoz/received_events","type":"User","site_admin":false},"assignees":[{"login":"jackpoz","id":1153754,"node_id":"MDQ6VXNlcjExNTM3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1153754?v=4","gravatar_id":"","url":"https://api.github.com/users/jackpoz","html_url":"https://github.com/jackpoz","followers_url":"https://api.github.com/users/jackpoz/followers","following_url":"https://api.github.com/users/jackpoz/following{/other_user}","gists_url":"https://api.github.com/users/jackpoz/gists{/gist_id}","starred_url":"https://api.github.com/users/jackpoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackpoz/subscriptions","organizations_url":"https://api.github.com/users/jackpoz/orgs","repos_url":"https://api.github.com/users/jackpoz/repos","events_url":"https://api.github.com/users/jackpoz/events{/privacy}","received_events_url":"https://api.github.com/users/jackpoz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-11-10T21:55:05Z","updated_at":"2018-11-20T14:44:26Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/22783","html_url":"https://github.com/TrinityCore/TrinityCore/pull/22783","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/22783.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/22783.patch"},"body":"<!--- (**********************************)\r\n      (** Fill in the following fields **)\r\n      (**********************************) --->\r\n\r\n**Changes proposed:**\r\n\r\n-  Add a new function GetDebugInfos() to types that could trigger an ASSERT() to easily include more useful information in crashlogs.\r\n-  If the type doesn't have the function, the global default one is picked which doesn't log anything.\r\n- Types supported:\r\n  - [x] Object\r\n  - [x] WorldLocation\r\n  - [x] WorldObject\r\n  - [x] Unit\r\n  - [ ] Creature\r\n    - [ ] add SpawnId\r\n\r\n**Target branch(es):** 3.3.5/master\r\n\r\n- [x] 3.3.5\r\n- [ ] master\r\n\r\n**Issues addressed:** Closes #  (insert issue tracker number)\r\nNo issues\r\n\r\n**Tests performed:** (Does it build, tested in-game, etc.)\r\nIt builds, still need to trigger a few asserts on purpose to properly test it\r\n\r\n**Known issues and TODO list:** (add/remove lines as needed)\r\n\r\n- Add GetDebugInfos() function to more types\r\n  - [ ] GameObject\r\n  - [ ] Player\r\n  - [ ] Item\r\n  - [ ] Spell\r\n  - [ ] Aura\r\n  - [ ] Map\r\n  - [ ] base-AI classes\r\n  - [ ] Missed anything ?\r\n\r\n\r\n<!--- Notes\r\n- Enable the setting \"[√] Allow edits from maintainers.\" when creating your pull request.\r\n- If this PR only contains SQL files, open a new issue instead and post or link the SQL in the issue.\r\n- When adding new SQL files, name them 9999_99_99_99_db_name.sql to reduce the chance of possible merge conflicts.\r\n--->\r\n"},"comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments/440297380","html_url":"https://github.com/TrinityCore/TrinityCore/pull/22783#issuecomment-440297380","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/22783","id":440297380,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDI5NzM4MA==","user":{"login":"ccrs","id":4329612,"node_id":"MDQ6VXNlcjQzMjk2MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/4329612?v=4","gravatar_id":"","url":"https://api.github.com/users/ccrs","html_url":"https://github.com/ccrs","followers_url":"https://api.github.com/users/ccrs/followers","following_url":"https://api.github.com/users/ccrs/following{/other_user}","gists_url":"https://api.github.com/users/ccrs/gists{/gist_id}","starred_url":"https://api.github.com/users/ccrs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccrs/subscriptions","organizations_url":"https://api.github.com/users/ccrs/orgs","repos_url":"https://api.github.com/users/ccrs/repos","events_url":"https://api.github.com/users/ccrs/events{/privacy}","received_events_url":"https://api.github.com/users/ccrs/received_events","type":"User","site_admin":false},"created_at":"2018-11-20T14:44:26Z","updated_at":"2018-11-20T14:44:26Z","author_association":"CONTRIBUTOR","body":"my mistake, I was thinking about https://github.com/TrinityCore/TrinityCore/blob/3.3.5/src/server/scripts/Commands/cs_misc.cpp#L2109\r\nbut actually thats useful information too 💃 "}}
{"actor":{"display_login":"ccrs"}}