{"action":"created","issue":{"url":"https://api.github.com/repos/battlesnakeio/engine/issues/13","repository_url":"https://api.github.com/repos/battlesnakeio/engine","labels_url":"https://api.github.com/repos/battlesnakeio/engine/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/battlesnakeio/engine/issues/13/comments","events_url":"https://api.github.com/repos/battlesnakeio/engine/issues/13/events","html_url":"https://github.com/battlesnakeio/engine/pull/13","id":313493801,"number":13,"title":"Error handling in engine API","user":{"login":"graeme-hill","id":637257,"avatar_url":"https://avatars2.githubusercontent.com/u/637257?v=4","gravatar_id":"","url":"https://api.github.com/users/graeme-hill","html_url":"https://github.com/graeme-hill","followers_url":"https://api.github.com/users/graeme-hill/followers","following_url":"https://api.github.com/users/graeme-hill/following{/other_user}","gists_url":"https://api.github.com/users/graeme-hill/gists{/gist_id}","starred_url":"https://api.github.com/users/graeme-hill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graeme-hill/subscriptions","organizations_url":"https://api.github.com/users/graeme-hill/orgs","repos_url":"https://api.github.com/users/graeme-hill/repos","events_url":"https://api.github.com/users/graeme-hill/events{/privacy}","received_events_url":"https://api.github.com/users/graeme-hill/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-11T21:24:45Z","updated_at":"2018-04-11T21:28:04Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/battlesnakeio/engine/pulls/13","html_url":"https://github.com/battlesnakeio/engine/pull/13","diff_url":"https://github.com/battlesnakeio/engine/pull/13.diff","patch_url":"https://github.com/battlesnakeio/engine/pull/13.patch"},"body":"Fixes battlesnakeio/roadmap#22\r\n\r\n1. /game/create handles invalid request JSON and returns 400 response including unit test.\r\n2. /game/create handles errors from ControllerClient.Create and returns 500 response including unit test.\r\n3. /game/create handles json serialization errors, but there is actually no value you can pass that will create an error (according to docs) based on the type. This is really a \"just in case\" error handler.\r\n4. /game/status/:id handles json serialization errors like in 3.\r\n5. .gitignore ignores *.test which is generated by `go test -c ...` or when you run tests from vscode."},"comment":{"url":"https://api.github.com/repos/battlesnakeio/engine/issues/comments/380601368","html_url":"https://github.com/battlesnakeio/engine/pull/13#issuecomment-380601368","issue_url":"https://api.github.com/repos/battlesnakeio/engine/issues/13","id":380601368,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-04-11T21:28:03Z","updated_at":"2018-04-11T21:28:03Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/battlesnakeio/engine/pull/13?src=pr&el=h1) Report\n> Merging [#13](https://codecov.io/gh/battlesnakeio/engine/pull/13?src=pr&el=desc) into [master](https://codecov.io/gh/battlesnakeio/engine/commit/4ddb303250b572fbfeb70494c2a24b8b194f7ea9?src=pr&el=desc) will **decrease** coverage by `1.02%`.\n> The diff coverage is `56.52%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/battlesnakeio/engine/pull/13/graphs/tree.svg?src=pr&token=OjbOzrTEQ2&width=650&height=150)](https://codecov.io/gh/battlesnakeio/engine/pull/13?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master      #13      +/-   ##\n==========================================\n- Coverage   73.76%   72.74%   -1.03%     \n==========================================\n  Files          17       17              \n  Lines         667      686      +19     \n==========================================\n+ Hits          492      499       +7     \n- Misses        142      151       +9     \n- Partials       33       36       +3\n```\n\n\n| [Impacted Files](https://codecov.io/gh/battlesnakeio/engine/pull/13?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [api/server.go](https://codecov.io/gh/battlesnakeio/engine/pull/13/diff?src=pr&el=tree#diff-YXBpL3NlcnZlci5nbw==) | `54.54% <56.52%> (-2.91%)` | :arrow_down: |\n| [worker/worker.go](https://codecov.io/gh/battlesnakeio/engine/pull/13/diff?src=pr&el=tree#diff-d29ya2VyL3dvcmtlci5nbw==) | `64.78% <0%> (-2.82%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/battlesnakeio/engine/pull/13?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/battlesnakeio/engine/pull/13?src=pr&el=footer). Last update [4ddb303...8a4a080](https://codecov.io/gh/battlesnakeio/engine/pull/13?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}