{"action":"created","issue":{"url":"https://api.github.com/repos/eBay/skin/issues/359","repository_url":"https://api.github.com/repos/eBay/skin","labels_url":"https://api.github.com/repos/eBay/skin/issues/359/labels{/name}","comments_url":"https://api.github.com/repos/eBay/skin/issues/359/comments","events_url":"https://api.github.com/repos/eBay/skin/issues/359/events","html_url":"https://github.com/eBay/skin/pull/359","id":354937204,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTg0NTI4","number":359,"title":"Tabs: port to DS6","user":{"login":"yomed","id":3595986,"node_id":"MDQ6VXNlcjM1OTU5ODY=","avatar_url":"https://avatars3.githubusercontent.com/u/3595986?v=4","gravatar_id":"","url":"https://api.github.com/users/yomed","html_url":"https://github.com/yomed","followers_url":"https://api.github.com/users/yomed/followers","following_url":"https://api.github.com/users/yomed/following{/other_user}","gists_url":"https://api.github.com/users/yomed/gists{/gist_id}","starred_url":"https://api.github.com/users/yomed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yomed/subscriptions","organizations_url":"https://api.github.com/users/yomed/orgs","repos_url":"https://api.github.com/users/yomed/repos","events_url":"https://api.github.com/users/yomed/events{/privacy}","received_events_url":"https://api.github.com/users/yomed/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-28T23:11:53Z","updated_at":"2018-08-29T16:18:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/eBay/skin/pulls/359","html_url":"https://github.com/eBay/skin/pull/359","diff_url":"https://github.com/eBay/skin/pull/359.diff","patch_url":"https://github.com/eBay/skin/pull/359.patch"},"body":"<!--  Delete any sections below that are not relevant to this PR -->\r\n\r\n## Description\r\n<!--- What are the changes? -->\r\n- create DS6 version of `tabs`\r\n- remove `hijax-tabs`\r\n- minor cleanup\r\n\r\n## Context\r\n<!--- Why did you make these changes, and why in this particular way? -->\r\nThe `tabs` component has never existed in Skin DS6... until now! A few caveats:\r\n- The DS4 tabs use jquery for the js functionality in the demo page. I did not try to set up the js for the DS6 version in the demo, but I did `link` it locally to eBayUI, and it works fine.\r\n- The design specs call out for more variants and complex behavior like horizontal scrollable tabs. I did not account for that functionality here, and instead focused on getting a working DS6 version up in close parity to the DS4 version.\r\n\r\nDuring some of the cleanup/refactor, I saw that `hijax-tabs` has been commented out of the demo page for a long time, so I simplified the component by removing it.\r\n\r\n## References\r\n<!-- Include links to JIRA, Github, etc. if appropriate -->\r\nCloses #352 \r\nDesign: https://ebay.invisionapp.com/share/CWN9X1JF6MA#/screens/278353515_Tabs\r\n\r\n## Screenshots\r\n<!-- Upload screenshots if appropriate-->\r\n<img width=\"947\" alt=\"screen shot 2018-08-28 at 4 10 11 pm\" src=\"https://user-images.githubusercontent.com/3595986/44755887-e1a4c880-aadc-11e8-9719-3563a29935e1.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/eBay/skin/issues/comments/417013182","html_url":"https://github.com/eBay/skin/pull/359#issuecomment-417013182","issue_url":"https://api.github.com/repos/eBay/skin/issues/359","id":417013182,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzAxMzE4Mg==","user":{"login":"msendlakowski","id":1562843,"node_id":"MDQ6VXNlcjE1NjI4NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1562843?v=4","gravatar_id":"","url":"https://api.github.com/users/msendlakowski","html_url":"https://github.com/msendlakowski","followers_url":"https://api.github.com/users/msendlakowski/followers","following_url":"https://api.github.com/users/msendlakowski/following{/other_user}","gists_url":"https://api.github.com/users/msendlakowski/gists{/gist_id}","starred_url":"https://api.github.com/users/msendlakowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msendlakowski/subscriptions","organizations_url":"https://api.github.com/users/msendlakowski/orgs","repos_url":"https://api.github.com/users/msendlakowski/repos","events_url":"https://api.github.com/users/msendlakowski/events{/privacy}","received_events_url":"https://api.github.com/users/msendlakowski/received_events","type":"User","site_admin":false},"created_at":"2018-08-29T16:18:15Z","updated_at":"2018-08-29T16:18:15Z","author_association":"MEMBER","body":"I think this is the last new feature we should add to the v1 release though. If we get all bugs fixed and verified we can publish a final release."}}
{"actor":{"display_login":"msendlakowski"}}