{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/10260","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/10260/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/10260/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/10260/events","html_url":"https://github.com/RobotLocomotion/drake/pull/10260","id":391845311,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MjQ4NDIx","number":10260,"title":"Simulator denormalization fix (addresses issue #10244)","user":{"login":"edrumwri","id":2224335,"node_id":"MDQ6VXNlcjIyMjQzMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/2224335?v=4","gravatar_id":"","url":"https://api.github.com/users/edrumwri","html_url":"https://github.com/edrumwri","followers_url":"https://api.github.com/users/edrumwri/followers","following_url":"https://api.github.com/users/edrumwri/following{/other_user}","gists_url":"https://api.github.com/users/edrumwri/gists{/gist_id}","starred_url":"https://api.github.com/users/edrumwri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edrumwri/subscriptions","organizations_url":"https://api.github.com/users/edrumwri/orgs","repos_url":"https://api.github.com/users/edrumwri/repos","events_url":"https://api.github.com/users/edrumwri/events{/privacy}","received_events_url":"https://api.github.com/users/edrumwri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"sherm1","id":4088016,"node_id":"MDQ6VXNlcjQwODgwMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4088016?v=4","gravatar_id":"","url":"https://api.github.com/users/sherm1","html_url":"https://github.com/sherm1","followers_url":"https://api.github.com/users/sherm1/followers","following_url":"https://api.github.com/users/sherm1/following{/other_user}","gists_url":"https://api.github.com/users/sherm1/gists{/gist_id}","starred_url":"https://api.github.com/users/sherm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherm1/subscriptions","organizations_url":"https://api.github.com/users/sherm1/orgs","repos_url":"https://api.github.com/users/sherm1/repos","events_url":"https://api.github.com/users/sherm1/events{/privacy}","received_events_url":"https://api.github.com/users/sherm1/received_events","type":"User","site_admin":false},"assignees":[{"login":"sherm1","id":4088016,"node_id":"MDQ6VXNlcjQwODgwMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4088016?v=4","gravatar_id":"","url":"https://api.github.com/users/sherm1","html_url":"https://github.com/sherm1","followers_url":"https://api.github.com/users/sherm1/followers","following_url":"https://api.github.com/users/sherm1/following{/other_user}","gists_url":"https://api.github.com/users/sherm1/gists{/gist_id}","starred_url":"https://api.github.com/users/sherm1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherm1/subscriptions","organizations_url":"https://api.github.com/users/sherm1/orgs","repos_url":"https://api.github.com/users/sherm1/repos","events_url":"https://api.github.com/users/sherm1/events{/privacy}","received_events_url":"https://api.github.com/users/sherm1/received_events","type":"User","site_admin":false},{"login":"jwnimmer-tri","id":17596505,"node_id":"MDQ6VXNlcjE3NTk2NTA1","avatar_url":"https://avatars3.githubusercontent.com/u/17596505?v=4","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-12-17T18:54:10Z","updated_at":"2018-12-17T23:22:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/10260","html_url":"https://github.com/RobotLocomotion/drake/pull/10260","diff_url":"https://github.com/RobotLocomotion/drake/pull/10260.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/10260.patch"},"body":"Avoids denormalized numbers in Simulator::Initialize(.), and re-enables test that was failing as a result.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/10260)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/448036980","html_url":"https://github.com/RobotLocomotion/drake/pull/10260#issuecomment-448036980","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/10260","id":448036980,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODAzNjk4MA==","user":{"login":"jwnimmer-tri","id":17596505,"node_id":"MDQ6VXNlcjE3NTk2NTA1","avatar_url":"https://avatars3.githubusercontent.com/u/17596505?v=4","gravatar_id":"","url":"https://api.github.com/users/jwnimmer-tri","html_url":"https://github.com/jwnimmer-tri","followers_url":"https://api.github.com/users/jwnimmer-tri/followers","following_url":"https://api.github.com/users/jwnimmer-tri/following{/other_user}","gists_url":"https://api.github.com/users/jwnimmer-tri/gists{/gist_id}","starred_url":"https://api.github.com/users/jwnimmer-tri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwnimmer-tri/subscriptions","organizations_url":"https://api.github.com/users/jwnimmer-tri/orgs","repos_url":"https://api.github.com/users/jwnimmer-tri/repos","events_url":"https://api.github.com/users/jwnimmer-tri/events{/privacy}","received_events_url":"https://api.github.com/users/jwnimmer-tri/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T23:22:57Z","updated_at":"2018-12-17T23:22:57Z","author_association":"COLLABORATOR","body":"\n\n\n\n___\n*[systems/analysis/simulator.h, line 645 at r2](https://reviewable.io/reviews/robotlocomotion/drake/10260#-LTyTSTS7e1DxEZPBHmr:-LTyTSTS7e1DxEZPBHms:b2j02jk) ([raw file](https://github.com/robotlocomotion/drake/blob/975fa3f1fd51f44e2a3d1ab7237867b0272cc46f/systems/analysis/simulator.h#L645)):*\n> ```objc\n> }\n> \n> // This function computes the previous (i.e., that which is one step closer to\n> ```\n\nFYI This might be easier to unit test as a free function in an `internal` namespace, instead of only being able to tickle it via Initialize and/or StepTo.  Those are good acceptance tests, but only allow us to indirectly reason about which conditions are being tested here.\n\n\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"jwnimmer-tri"}}