{"action":"created","issue":{"url":"https://api.github.com/repos/kubevirt/kubevirt/issues/990","repository_url":"https://api.github.com/repos/kubevirt/kubevirt","labels_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/990/labels{/name}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/990/comments","events_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/990/events","html_url":"https://github.com/kubevirt/kubevirt/pull/990","id":320347804,"number":990,"title":"Use virtio for cirros vms in our functests","user":{"login":"rmohr","id":4534621,"avatar_url":"https://avatars3.githubusercontent.com/u/4534621?v=4","gravatar_id":"","url":"https://api.github.com/users/rmohr","html_url":"https://github.com/rmohr","followers_url":"https://api.github.com/users/rmohr/followers","following_url":"https://api.github.com/users/rmohr/following{/other_user}","gists_url":"https://api.github.com/users/rmohr/gists{/gist_id}","starred_url":"https://api.github.com/users/rmohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmohr/subscriptions","organizations_url":"https://api.github.com/users/rmohr/orgs","repos_url":"https://api.github.com/users/rmohr/repos","events_url":"https://api.github.com/users/rmohr/events{/privacy}","received_events_url":"https://api.github.com/users/rmohr/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-04T16:53:39Z","updated_at":"2018-05-11T13:49:20Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/990","html_url":"https://github.com/kubevirt/kubevirt/pull/990","diff_url":"https://github.com/kubevirt/kubevirt/pull/990.diff","patch_url":"https://github.com/kubevirt/kubevirt/pull/990.patch"},"body":"Fixes #936 for our tests. The solution here is intended to buy us some time until we have decided on how to properly represent network devices on the API. If \"kubevirt.io/os=cirros\" is present in the annotations, kubevirt will choose virtio for the network type.\r\n\r\nUsing \"kubevirt.io/os\" for that purpose is not that nice, but it kind of fits into what this label is meant for: Allowing special configurations based on the operating system used. See also https://www.kubevirt.io/user-guide/#/workloads/virtual-machines/guest-operating-system-information?id=guest-operating-system-information for more context."},"comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt/issues/comments/388369183","html_url":"https://github.com/kubevirt/kubevirt/pull/990#issuecomment-388369183","issue_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/990","id":388369183,"user":{"login":"rmohr","id":4534621,"avatar_url":"https://avatars3.githubusercontent.com/u/4534621?v=4","gravatar_id":"","url":"https://api.github.com/users/rmohr","html_url":"https://github.com/rmohr","followers_url":"https://api.github.com/users/rmohr/followers","following_url":"https://api.github.com/users/rmohr/following{/other_user}","gists_url":"https://api.github.com/users/rmohr/gists{/gist_id}","starred_url":"https://api.github.com/users/rmohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmohr/subscriptions","organizations_url":"https://api.github.com/users/rmohr/orgs","repos_url":"https://api.github.com/users/rmohr/repos","events_url":"https://api.github.com/users/rmohr/events{/privacy}","received_events_url":"https://api.github.com/users/rmohr/received_events","type":"User","site_admin":false},"created_at":"2018-05-11T13:49:20Z","updated_at":"2018-05-11T13:49:20Z","author_association":"OWNER","body":"> should virtio be the default and os=windows be the exception that toggles e1000?\r\n\r\nwe could say, if it starts with \"win\", then use e1000. libos-info shows these windows tags:\r\n\r\n```\r\n win1.0               | Microsoft Windows 1.0                              | 1.0      | http://microsoft.com/win/1.0            \r\n win10                | Microsoft Windows 10                               | 10.0     | http://microsoft.com/win/10             \r\n win2.0               | Microsoft Windows 2.0                              | 2.0      | http://microsoft.com/win/2.0            \r\n win2.1               | Microsoft Windows 2.1                              | 2.1      | http://microsoft.com/win/2.1            \r\n win2k                | Microsoft Windows 2000                             | 5.0      | http://microsoft.com/win/2k             \r\n win2k12              | Microsoft Windows Server 2012                      | 6.3      | http://microsoft.com/win/2k12           \r\n win2k12r2            | Microsoft Windows Server 2012 R2                   | 6.3      | http://microsoft.com/win/2k12r2         \r\n win2k16              | Microsoft Windows Server 2016                      | 1709     | http://microsoft.com/win/2k16           \r\n win2k3               | Microsoft Windows Server 2003                      | 5.2      | http://microsoft.com/win/2k3            \r\n win2k3r2             | Microsoft Windows Server 2003 R2                   | 5.2      | http://microsoft.com/win/2k3r2          \r\n win2k8               | Microsoft Windows Server 2008                      | 6.0      | http://microsoft.com/win/2k8            \r\n win2k8r2             | Microsoft Windows Server 2008 R2                   | 6.1      | http://microsoft.com/win/2k8r2          \r\n win3.1               | Microsoft Windows 3.1                              | 3.1      | http://microsoft.com/win/3.1            \r\n win7                 | Microsoft Windows 7                                | 6.1      | http://microsoft.com/win/7              \r\n win8                 | Microsoft Windows 8                                | 6.2      | http://microsoft.com/win/8              \r\n win8.1               | Microsoft Windows 8.1                              | 6.3      | http://microsoft.com/win/8.1            \r\n win95                | Microsoft Windows 95                               | 4.0      | http://microsoft.com/win/95             \r\n win98                | Microsoft Windows 98                               | 4.1      | http://microsoft.com/win/98             \r\n winme                | Microsoft Windows Millennium Edition               | 4.9      | http://microsoft.com/win/me             \r\n winnt3.1             | Microsoft Windows NT Server 3.1                    | 3.1      | http://microsoft.com/winnt/3.1          \r\n winnt3.5             | Microsoft Windows NT Server 3.5                    | 3.5      | http://microsoft.com/winnt/3.5          \r\n winnt3.51            | Microsoft Windows NT Server 3.51                   | 3.51     | http://microsoft.com/winnt/3.51         \r\n winnt4.0             | Microsoft Windows NT Server 4.0                    | 4.0      | http://microsoft.com/winnt/4.0          \r\n winvista             | Microsoft Windows Vista                            | 6.0      | http://microsoft.com/win/vista          \r\n winxp                | Microsoft Windows XP                               | 5.1      | http://microsoft.com/win/xp  \r\n```"}}
{"actor":{"display_login":"rmohr"}}