{"action":"created","issue":{"url":"https://api.github.com/repos/WayfireWM/wayfire/issues/106","repository_url":"https://api.github.com/repos/WayfireWM/wayfire","labels_url":"https://api.github.com/repos/WayfireWM/wayfire/issues/106/labels{/name}","comments_url":"https://api.github.com/repos/WayfireWM/wayfire/issues/106/comments","events_url":"https://api.github.com/repos/WayfireWM/wayfire/issues/106/events","html_url":"https://github.com/WayfireWM/wayfire/pull/106","id":387258704,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1Nzg3MzEy","number":106,"title":"Blur v6","user":{"login":"alex47","id":10761683,"node_id":"MDQ6VXNlcjEwNzYxNjgz","avatar_url":"https://avatars1.githubusercontent.com/u/10761683?v=4","gravatar_id":"","url":"https://api.github.com/users/alex47","html_url":"https://github.com/alex47","followers_url":"https://api.github.com/users/alex47/followers","following_url":"https://api.github.com/users/alex47/following{/other_user}","gists_url":"https://api.github.com/users/alex47/gists{/gist_id}","starred_url":"https://api.github.com/users/alex47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex47/subscriptions","organizations_url":"https://api.github.com/users/alex47/orgs","repos_url":"https://api.github.com/users/alex47/repos","events_url":"https://api.github.com/users/alex47/events{/privacy}","received_events_url":"https://api.github.com/users/alex47/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-12-04T12:16:22Z","updated_at":"2018-12-05T09:57:59Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/WayfireWM/wayfire/pulls/106","html_url":"https://github.com/WayfireWM/wayfire/pull/106","diff_url":"https://github.com/WayfireWM/wayfire/pull/106.diff","patch_url":"https://github.com/WayfireWM/wayfire/pull/106.patch"},"body":"Previous dual kawase blur implementation was not working correctly at all.\r\nThe down and upscaling was completely left out, shader \"mode\" was assigned in reverse.\r\nRemoved \"if\" from shader, it shouldn't be used."},"comment":{"url":"https://api.github.com/repos/WayfireWM/wayfire/issues/comments/444427184","html_url":"https://github.com/WayfireWM/wayfire/pull/106#issuecomment-444427184","issue_url":"https://api.github.com/repos/WayfireWM/wayfire/issues/106","id":444427184,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDQyNzE4NA==","user":{"login":"soreau","id":1450125,"node_id":"MDQ6VXNlcjE0NTAxMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1450125?v=4","gravatar_id":"","url":"https://api.github.com/users/soreau","html_url":"https://github.com/soreau","followers_url":"https://api.github.com/users/soreau/followers","following_url":"https://api.github.com/users/soreau/following{/other_user}","gists_url":"https://api.github.com/users/soreau/gists{/gist_id}","starred_url":"https://api.github.com/users/soreau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soreau/subscriptions","organizations_url":"https://api.github.com/users/soreau/orgs","repos_url":"https://api.github.com/users/soreau/repos","events_url":"https://api.github.com/users/soreau/events{/privacy}","received_events_url":"https://api.github.com/users/soreau/received_events","type":"User","site_admin":false},"created_at":"2018-12-05T09:57:59Z","updated_at":"2018-12-05T09:57:59Z","author_association":"MEMBER","body":"@alex47 Thank you for this. I have reviewed it and it looks pretty good. Just a few things:\r\n1) blur-v6 has been force-pushed so please rebase to latest blur-v6\r\n2) Do not s/kawase/dual_kawase/ everywhere, the kawase name is preferred internally for variables and config option names.\r\n3) Please use this in calculate_blur_radius:\r\n`pow(2, (wf_blur_base::iterations_opt->as_int() + 2) * offset_opt->as_double() * degrade_opt->as_int())`\r\n4) Remove the #include \"debug.hpp\" from kawase.cpp"}}
{"actor":{"display_login":"soreau"}}