{"action":"created","issue":{"url":"https://api.github.com/repos/BOINC/boinc/issues/2576","repository_url":"https://api.github.com/repos/BOINC/boinc","labels_url":"https://api.github.com/repos/BOINC/boinc/issues/2576/labels{/name}","comments_url":"https://api.github.com/repos/BOINC/boinc/issues/2576/comments","events_url":"https://api.github.com/repos/BOINC/boinc/issues/2576/events","html_url":"https://github.com/BOINC/boinc/pull/2576","id":335815912,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDE5NzA5","number":2576,"title":"[WIP] Generic Mac build script for branded version of Mac manager/screen saver","user":{"login":"armstrdj","id":26032147,"node_id":"MDQ6VXNlcjI2MDMyMTQ3","avatar_url":"https://avatars2.githubusercontent.com/u/26032147?v=4","gravatar_id":"","url":"https://api.github.com/users/armstrdj","html_url":"https://github.com/armstrdj","followers_url":"https://api.github.com/users/armstrdj/followers","following_url":"https://api.github.com/users/armstrdj/following{/other_user}","gists_url":"https://api.github.com/users/armstrdj/gists{/gist_id}","starred_url":"https://api.github.com/users/armstrdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armstrdj/subscriptions","organizations_url":"https://api.github.com/users/armstrdj/orgs","repos_url":"https://api.github.com/users/armstrdj/repos","events_url":"https://api.github.com/users/armstrdj/events{/privacy}","received_events_url":"https://api.github.com/users/armstrdj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-26T13:19:37Z","updated_at":"2018-06-28T11:02:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/BOINC/boinc/pulls/2576","html_url":"https://github.com/BOINC/boinc/pull/2576","diff_url":"https://github.com/BOINC/boinc/pull/2576.diff","patch_url":"https://github.com/BOINC/boinc/pull/2576.patch"},"body":"@CharlieFenton here is the current script. I still need to look at your suggestion for PostInstall.cpp to fix finding the branding file in the installer. Also I need to add support for setting up an account manager in the script. We have not finalized all the images/content for the WCG branded installer/manager so I have not checked in all of those images yet. \r\n\r\nAlso I am still looking into some issues that I think are unrelated to the installer but may be issues in general with the manager or installer code.\r\n1. The snooze/disconnect image is not showing up over the WCG icon in the taskbar.\r\n2. The logo in the upper right notification bar uses the appropriate WCG logo defined in the skin. However if I switch the skin to default it properly switches the logo to boinc but does not switch the logo back when switching back to WCG skin.\r\n3. The BOINC Installer icon displays in the screen saver popup during install instead of the bundle branded installer icon."},"comment":{"url":"https://api.github.com/repos/BOINC/boinc/issues/comments/400997825","html_url":"https://github.com/BOINC/boinc/pull/2576#issuecomment-400997825","issue_url":"https://api.github.com/repos/BOINC/boinc/issues/2576","id":400997825,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDk5NzgyNQ==","user":{"login":"CharlieFenton","id":10470356,"node_id":"MDQ6VXNlcjEwNDcwMzU2","avatar_url":"https://avatars2.githubusercontent.com/u/10470356?v=4","gravatar_id":"","url":"https://api.github.com/users/CharlieFenton","html_url":"https://github.com/CharlieFenton","followers_url":"https://api.github.com/users/CharlieFenton/followers","following_url":"https://api.github.com/users/CharlieFenton/following{/other_user}","gists_url":"https://api.github.com/users/CharlieFenton/gists{/gist_id}","starred_url":"https://api.github.com/users/CharlieFenton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharlieFenton/subscriptions","organizations_url":"https://api.github.com/users/CharlieFenton/orgs","repos_url":"https://api.github.com/users/CharlieFenton/repos","events_url":"https://api.github.com/users/CharlieFenton/events{/privacy}","received_events_url":"https://api.github.com/users/CharlieFenton/received_events","type":"User","site_admin":false},"created_at":"2018-06-28T11:02:58Z","updated_at":"2018-06-28T11:02:58Z","author_association":"CONTRIBUTOR","body":"@armstrdjI want to clear up some potential confusion about nomenclature. On the Mac, the row of icons (usually) at the bottom of the screen are called the _Dock_. The row of menus at the top of the screen is called the _menubar_. BOINC's 16 X 16 _play_, _pause/snooze_ and _disconnected_ icons in the right hand portion of the Mac menubar containing small icons with pull-down menus are called the _status bar_ in the Mac world. But since they are the Mac equivalent of the taskbar icon on Windows, we in the world of BOINC generally refer to those as BOINC's taskbar icons, even on the Mac.\r\n\r\nSo I think you are saying that you have now fixed the issue with the 16 X 16 icons in the Mac status bar but you are not yet seeing the pause/snooze or disconnected indicators in the Dock. I'll look into that, but I find it surprising because of the way I implemented those for the Dock. The Dock always shows the application icon (the same icon from the *.icns file that is shown in the Finder for the application.) The BOINC code superimposes the pause/snooze or disconnected symbol on top of that icon as a badge (in Mac terminology) when appropriate, so nothing special should be required for that to work with a branded icon.\r\n\r\nOnce you have committed you skin file changes, I'll try building the WCG branded installer so I can look into this and any other issues you find."}}
{"actor":{"display_login":"CharlieFenton"}}