{"action":"opened","issue":{"url":"https://api.github.com/repos/aowen87/TicketTester/issues/710","repository_url":"https://api.github.com/repos/aowen87/TicketTester","labels_url":"https://api.github.com/repos/aowen87/TicketTester/issues/710/labels{/name}","comments_url":"https://api.github.com/repos/aowen87/TicketTester/issues/710/comments","events_url":"https://api.github.com/repos/aowen87/TicketTester/issues/710/events","html_url":"https://github.com/aowen87/TicketTester/issues/710","id":388487417,"node_id":"MDU6SXNzdWUzODg0ODc0MTc=","number":710,"title":"Update the internallauncher with a fix from Jean Favre","user":{"login":"aowen87","id":11658578,"node_id":"MDQ6VXNlcjExNjU4NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/11658578?v=4","gravatar_id":"","url":"https://api.github.com/users/aowen87","html_url":"https://github.com/aowen87","followers_url":"https://api.github.com/users/aowen87/followers","following_url":"https://api.github.com/users/aowen87/following{/other_user}","gists_url":"https://api.github.com/users/aowen87/gists{/gist_id}","starred_url":"https://api.github.com/users/aowen87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aowen87/subscriptions","organizations_url":"https://api.github.com/users/aowen87/orgs","repos_url":"https://api.github.com/users/aowen87/repos","events_url":"https://api.github.com/users/aowen87/events{/privacy}","received_events_url":"https://api.github.com/users/aowen87/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/aowen87/TicketTester/milestones/17","html_url":"https://github.com/aowen87/TicketTester/milestone/17","labels_url":"https://api.github.com/repos/aowen87/TicketTester/milestones/17/labels","id":3878225,"node_id":"MDk6TWlsZXN0b25lMzg3ODIyNQ==","number":17,"title":"2.7.2","description":null,"creator":{"login":"aowen87","id":11658578,"node_id":"MDQ6VXNlcjExNjU4NTc4","avatar_url":"https://avatars0.githubusercontent.com/u/11658578?v=4","gravatar_id":"","url":"https://api.github.com/users/aowen87","html_url":"https://github.com/aowen87","followers_url":"https://api.github.com/users/aowen87/followers","following_url":"https://api.github.com/users/aowen87/following{/other_user}","gists_url":"https://api.github.com/users/aowen87/gists{/gist_id}","starred_url":"https://api.github.com/users/aowen87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aowen87/subscriptions","organizations_url":"https://api.github.com/users/aowen87/orgs","repos_url":"https://api.github.com/users/aowen87/repos","events_url":"https://api.github.com/users/aowen87/events{/privacy}","received_events_url":"https://api.github.com/users/aowen87/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":15,"state":"open","created_at":"2018-12-06T23:49:25Z","updated_at":"2018-12-07T03:07:17Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-12-07T03:07:17Z","updated_at":"2018-12-07T03:07:17Z","closed_at":null,"author_association":"OWNER","body":"Here is Jean's e-mail:\r\n\r\nhello there\r\n\r\non our Crays at CSCS, we use SLURM, on top of Cray's own scheduler aprun.\r\nI have found that the internallauncher passes the wrong -N option to aprun (this is different than srun)\r\n\r\nas per the man page of aprun, -N indicates the number of processing elts per node.\r\n     [-N | --pes-per-node pes_per_node ]\r\n\r\nI therefore patched our internallauncher to the following; Otherwise the jobs don't run because resources are not enabled.\r\n\r\n\r\n184,186c184,185\r\n<         #if self.parallel.nn != None:\r\n<             #parcmd = parcmd + [\"-N\", self.parallel.nn]\r\n<         parcmd = parcmd + [\"-N\", self.PPN()]\r\n---\r\n>         if self.parallel.nn != None:\r\n>             parcmd = parcmd + [\"-N\", self.parallel.nn]\r\n530d528\r\n<             mpicmd = mpicmd + [\"-N\", self.PPN()]\r\n\r\nI'd appreciate if this patch (against v 2.7.1) would be included in the next version of VisIt.\r\nI have verified that it works as required.\n\n\n\n\n\n-----------------------REDMINE MIGRATION-----------------------\nThis ticket was migrated from Redmine. As such, not all \ninformation was able to be captured in the transition. Below is\na complete record of the original redmine ticket.\n\nTicket number: 1759\nStatus: Resolved\nProject: VisIt\nTracker: Bug\nPriority: Normal\nSubject: Update the internallauncher with a fix from Jean Favre\nAssigned to: Eric Brugger\nCategory: \nTarget version: 2.7.2\nAuthor: Eric Brugger\nStart: 02/28/2014\nDue date: \n% Done: 100\nEstimated time: 2.0\nCreated: 02/28/2014 12:50 pm\nUpdated: 03/10/2014 04:00 pm\nLikelihood: 3 - Occasional\nSeverity: 2 - Minor Irritation\nFound in version: 2.7.1\nImpact: \nExpected Use: \nOS: All\nSupport Group: Any\nDescription:\n Here is Jean's e-mail:\r\n\r\nhello there\r\n\r\non our Crays at CSCS, we use SLURM, on top of Cray's own scheduler aprun.\r\nI have found that the internallauncher passes the wrong -N option to aprun (this is different than srun)\r\n\r\nas per the man page of aprun, -N indicates the number of processing elts per node.\r\n     [-N | --pes-per-node pes_per_node ]\r\n\r\nI therefore patched our internallauncher to the following; Otherwise the jobs don't run because resources are not enabled.\r\n\r\n\r\n184,186c184,185\r\n<         #if self.parallel.nn != None:\r\n<             #parcmd = parcmd + [\"-N\", self.parallel.nn]\r\n<         parcmd = parcmd + [\"-N\", self.PPN()]\r\n---\r\n>         if self.parallel.nn != None:\r\n>             parcmd = parcmd + [\"-N\", self.parallel.nn]\r\n530d528\r\n<             mpicmd = mpicmd + [\"-N\", self.PPN()]\r\n\r\nI'd appreciate if this patch (against v 2.7.1) would be included in the next version of VisIt.\r\nI have verified that it works as required.\n\nComments:\nI committed revisions 22922 and 22924 to the 2.7 RC and trunk with thefollowing change:1) I added a fix to the internal launcher from Jean Favre that corrected   the setting of the -N option when using aprun to launch VisIt. I added   a blurb about the fix to the release notes. This resolves #1759.M       bin/internallauncherM       resources/help/en_US/relnotes2.7.2.html\nI committed revision 22963 to the trunk with the following change:1) I updated the test suite results for a couple of tests that test job   launching with aprun that changed as a result of a fix from Jean Favre.   This fully resolves #1759.M       baseline/unit/launcher/aprun.txtM       baseline/unit/launcher/sbatch_aprun.txt\n\n"}}
{"actor":{"display_login":"aowen87"}}