{"action":"created","comment":{"url":"https://api.github.com/repos/runconduit/conduit/pulls/comments/191480876","pull_request_review_id":124061002,"id":191480876,"diff_hunk":"@@ -0,0 +1,87 @@\n+import _ from 'lodash';\n+import Adapter from 'enzyme-adapter-react-16';\n+import CallToAction from '../js/components/CallToAction.jsx';\n+import ConduitSpinner from '../js/components/ConduitSpinner.jsx';\n+import deployRollup from './fixtures/deployRollup.json';\n+import Enzyme from 'enzyme';\n+import ErrorBanner from '../js/components/ErrorBanner.jsx';\n+import { expect } from 'chai';\n+import MetricsTable from '../js/components/MetricsTable.jsx';\n+import PageHeader from '../js/components/PageHeader.jsx';\n+import { processSingleResourceRollup } from '../js/components/util/MetricUtils.js';","path":"web/app/test/ResourceListTest.jsx","position":11,"original_position":11,"commit_id":"717e4c8e036c4b8f792b9990570d18ea58dcff41","original_commit_id":"717e4c8e036c4b8f792b9990570d18ea58dcff41","user":{"login":"grampelberg","id":47992,"avatar_url":"https://avatars0.githubusercontent.com/u/47992?v=4","gravatar_id":"","url":"https://api.github.com/users/grampelberg","html_url":"https://github.com/grampelberg","followers_url":"https://api.github.com/users/grampelberg/followers","following_url":"https://api.github.com/users/grampelberg/following{/other_user}","gists_url":"https://api.github.com/users/grampelberg/gists{/gist_id}","starred_url":"https://api.github.com/users/grampelberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grampelberg/subscriptions","organizations_url":"https://api.github.com/users/grampelberg/orgs","repos_url":"https://api.github.com/users/grampelberg/repos","events_url":"https://api.github.com/users/grampelberg/events{/privacy}","received_events_url":"https://api.github.com/users/grampelberg/received_events","type":"User","site_admin":false},"body":"Good catch. Do we have this in eslint? I feel like some kind of tool should have yelled at me about it.","created_at":"2018-05-29T16:00:43Z","updated_at":"2018-05-29T16:00:43Z","html_url":"https://github.com/runconduit/conduit/pull/989#discussion_r191480876","pull_request_url":"https://api.github.com/repos/runconduit/conduit/pulls/989","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/comments/191480876"},"html":{"href":"https://github.com/runconduit/conduit/pull/989#discussion_r191480876"},"pull_request":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/989"}},"in_reply_to_id":190680131},"pull_request":{"url":"https://api.github.com/repos/runconduit/conduit/pulls/989","id":190035997,"html_url":"https://github.com/runconduit/conduit/pull/989","diff_url":"https://github.com/runconduit/conduit/pull/989.diff","patch_url":"https://github.com/runconduit/conduit/pull/989.patch","issue_url":"https://api.github.com/repos/runconduit/conduit/issues/989","number":989,"state":"open","locked":false,"title":"Add a HOC for the REST API tooling","user":{"login":"grampelberg","id":47992,"avatar_url":"https://avatars0.githubusercontent.com/u/47992?v=4","gravatar_id":"","url":"https://api.github.com/users/grampelberg","html_url":"https://github.com/grampelberg","followers_url":"https://api.github.com/users/grampelberg/followers","following_url":"https://api.github.com/users/grampelberg/following{/other_user}","gists_url":"https://api.github.com/users/grampelberg/gists{/gist_id}","starred_url":"https://api.github.com/users/grampelberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grampelberg/subscriptions","organizations_url":"https://api.github.com/users/grampelberg/orgs","repos_url":"https://api.github.com/users/grampelberg/repos","events_url":"https://api.github.com/users/grampelberg/events{/privacy}","received_events_url":"https://api.github.com/users/grampelberg/received_events","type":"User","site_admin":false},"body":"We're copying and duplicating logic all over the place with components that need to talk to the API.\r\n\r\nMoves most of the REST API tooling into a HOC that can be used by other components. Now, a component can use `withREST`, pass in the promises that it would like resolved and receive the responses as props.","created_at":"2018-05-23T16:31:52Z","updated_at":"2018-05-29T16:00:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c31587a462fb02a0c5d92ded6520fb0e1c15434","assignee":{"login":"grampelberg","id":47992,"avatar_url":"https://avatars0.githubusercontent.com/u/47992?v=4","gravatar_id":"","url":"https://api.github.com/users/grampelberg","html_url":"https://github.com/grampelberg","followers_url":"https://api.github.com/users/grampelberg/followers","following_url":"https://api.github.com/users/grampelberg/following{/other_user}","gists_url":"https://api.github.com/users/grampelberg/gists{/gist_id}","starred_url":"https://api.github.com/users/grampelberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grampelberg/subscriptions","organizations_url":"https://api.github.com/users/grampelberg/orgs","repos_url":"https://api.github.com/users/grampelberg/repos","events_url":"https://api.github.com/users/grampelberg/events{/privacy}","received_events_url":"https://api.github.com/users/grampelberg/received_events","type":"User","site_admin":false},"assignees":[{"login":"grampelberg","id":47992,"avatar_url":"https://avatars0.githubusercontent.com/u/47992?v=4","gravatar_id":"","url":"https://api.github.com/users/grampelberg","html_url":"https://github.com/grampelberg","followers_url":"https://api.github.com/users/grampelberg/followers","following_url":"https://api.github.com/users/grampelberg/following{/other_user}","gists_url":"https://api.github.com/users/grampelberg/gists{/gist_id}","starred_url":"https://api.github.com/users/grampelberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grampelberg/subscriptions","organizations_url":"https://api.github.com/users/grampelberg/orgs","repos_url":"https://api.github.com/users/grampelberg/repos","events_url":"https://api.github.com/users/grampelberg/events{/privacy}","received_events_url":"https://api.github.com/users/grampelberg/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"rmars","id":549258,"avatar_url":"https://avatars3.githubusercontent.com/u/549258?v=4","gravatar_id":"","url":"https://api.github.com/users/rmars","html_url":"https://github.com/rmars","followers_url":"https://api.github.com/users/rmars/followers","following_url":"https://api.github.com/users/rmars/following{/other_user}","gists_url":"https://api.github.com/users/rmars/gists{/gist_id}","starred_url":"https://api.github.com/users/rmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmars/subscriptions","organizations_url":"https://api.github.com/users/rmars/orgs","repos_url":"https://api.github.com/users/rmars/repos","events_url":"https://api.github.com/users/rmars/events{/privacy}","received_events_url":"https://api.github.com/users/rmars/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":777123402,"url":"https://api.github.com/repos/runconduit/conduit/labels/area/web","name":"area/web","color":"0052CC","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/runconduit/conduit/pulls/989/commits","review_comments_url":"https://api.github.com/repos/runconduit/conduit/pulls/989/comments","review_comment_url":"https://api.github.com/repos/runconduit/conduit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/runconduit/conduit/issues/989/comments","statuses_url":"https://api.github.com/repos/runconduit/conduit/statuses/717e4c8e036c4b8f792b9990570d18ea58dcff41","head":{"label":"runconduit:grampelberg/api-hoc","ref":"grampelberg/api-hoc","sha":"717e4c8e036c4b8f792b9990570d18ea58dcff41","user":{"login":"runconduit","id":33942733,"avatar_url":"https://avatars2.githubusercontent.com/u/33942733?v=4","gravatar_id":"","url":"https://api.github.com/users/runconduit","html_url":"https://github.com/runconduit","followers_url":"https://api.github.com/users/runconduit/followers","following_url":"https://api.github.com/users/runconduit/following{/other_user}","gists_url":"https://api.github.com/users/runconduit/gists{/gist_id}","starred_url":"https://api.github.com/users/runconduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runconduit/subscriptions","organizations_url":"https://api.github.com/users/runconduit/orgs","repos_url":"https://api.github.com/users/runconduit/repos","events_url":"https://api.github.com/users/runconduit/events{/privacy}","received_events_url":"https://api.github.com/users/runconduit/received_events","type":"Organization","site_admin":false},"repo":{"id":113106184,"name":"conduit","full_name":"runconduit/conduit","owner":{"login":"runconduit","id":33942733,"avatar_url":"https://avatars2.githubusercontent.com/u/33942733?v=4","gravatar_id":"","url":"https://api.github.com/users/runconduit","html_url":"https://github.com/runconduit","followers_url":"https://api.github.com/users/runconduit/followers","following_url":"https://api.github.com/users/runconduit/following{/other_user}","gists_url":"https://api.github.com/users/runconduit/gists{/gist_id}","starred_url":"https://api.github.com/users/runconduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runconduit/subscriptions","organizations_url":"https://api.github.com/users/runconduit/orgs","repos_url":"https://api.github.com/users/runconduit/repos","events_url":"https://api.github.com/users/runconduit/events{/privacy}","received_events_url":"https://api.github.com/users/runconduit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runconduit/conduit","description":"Ultralight service mesh for Kubernetes","fork":false,"url":"https://api.github.com/repos/runconduit/conduit","forks_url":"https://api.github.com/repos/runconduit/conduit/forks","keys_url":"https://api.github.com/repos/runconduit/conduit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runconduit/conduit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runconduit/conduit/teams","hooks_url":"https://api.github.com/repos/runconduit/conduit/hooks","issue_events_url":"https://api.github.com/repos/runconduit/conduit/issues/events{/number}","events_url":"https://api.github.com/repos/runconduit/conduit/events","assignees_url":"https://api.github.com/repos/runconduit/conduit/assignees{/user}","branches_url":"https://api.github.com/repos/runconduit/conduit/branches{/branch}","tags_url":"https://api.github.com/repos/runconduit/conduit/tags","blobs_url":"https://api.github.com/repos/runconduit/conduit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runconduit/conduit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runconduit/conduit/git/refs{/sha}","trees_url":"https://api.github.com/repos/runconduit/conduit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runconduit/conduit/statuses/{sha}","languages_url":"https://api.github.com/repos/runconduit/conduit/languages","stargazers_url":"https://api.github.com/repos/runconduit/conduit/stargazers","contributors_url":"https://api.github.com/repos/runconduit/conduit/contributors","subscribers_url":"https://api.github.com/repos/runconduit/conduit/subscribers","subscription_url":"https://api.github.com/repos/runconduit/conduit/subscription","commits_url":"https://api.github.com/repos/runconduit/conduit/commits{/sha}","git_commits_url":"https://api.github.com/repos/runconduit/conduit/git/commits{/sha}","comments_url":"https://api.github.com/repos/runconduit/conduit/comments{/number}","issue_comment_url":"https://api.github.com/repos/runconduit/conduit/issues/comments{/number}","contents_url":"https://api.github.com/repos/runconduit/conduit/contents/{+path}","compare_url":"https://api.github.com/repos/runconduit/conduit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runconduit/conduit/merges","archive_url":"https://api.github.com/repos/runconduit/conduit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runconduit/conduit/downloads","issues_url":"https://api.github.com/repos/runconduit/conduit/issues{/number}","pulls_url":"https://api.github.com/repos/runconduit/conduit/pulls{/number}","milestones_url":"https://api.github.com/repos/runconduit/conduit/milestones{/number}","notifications_url":"https://api.github.com/repos/runconduit/conduit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runconduit/conduit/labels{/name}","releases_url":"https://api.github.com/repos/runconduit/conduit/releases{/id}","deployments_url":"https://api.github.com/repos/runconduit/conduit/deployments","created_at":"2017-12-04T23:16:56Z","updated_at":"2018-05-29T12:10:49Z","pushed_at":"2018-05-28T13:52:20Z","git_url":"git://github.com/runconduit/conduit.git","ssh_url":"git@github.com:runconduit/conduit.git","clone_url":"https://github.com/runconduit/conduit.git","svn_url":"https://github.com/runconduit/conduit","homepage":"https://conduit.io","size":5252,"stargazers_count":1741,"watchers_count":1741,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"archived":false,"open_issues_count":181,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":99,"open_issues":181,"watchers":1741,"default_branch":"master"}},"base":{"label":"runconduit:master","ref":"master","sha":"d0f0eecbc8811d1fa72ec75f61e82d5cd2ee177d","user":{"login":"runconduit","id":33942733,"avatar_url":"https://avatars2.githubusercontent.com/u/33942733?v=4","gravatar_id":"","url":"https://api.github.com/users/runconduit","html_url":"https://github.com/runconduit","followers_url":"https://api.github.com/users/runconduit/followers","following_url":"https://api.github.com/users/runconduit/following{/other_user}","gists_url":"https://api.github.com/users/runconduit/gists{/gist_id}","starred_url":"https://api.github.com/users/runconduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runconduit/subscriptions","organizations_url":"https://api.github.com/users/runconduit/orgs","repos_url":"https://api.github.com/users/runconduit/repos","events_url":"https://api.github.com/users/runconduit/events{/privacy}","received_events_url":"https://api.github.com/users/runconduit/received_events","type":"Organization","site_admin":false},"repo":{"id":113106184,"name":"conduit","full_name":"runconduit/conduit","owner":{"login":"runconduit","id":33942733,"avatar_url":"https://avatars2.githubusercontent.com/u/33942733?v=4","gravatar_id":"","url":"https://api.github.com/users/runconduit","html_url":"https://github.com/runconduit","followers_url":"https://api.github.com/users/runconduit/followers","following_url":"https://api.github.com/users/runconduit/following{/other_user}","gists_url":"https://api.github.com/users/runconduit/gists{/gist_id}","starred_url":"https://api.github.com/users/runconduit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/runconduit/subscriptions","organizations_url":"https://api.github.com/users/runconduit/orgs","repos_url":"https://api.github.com/users/runconduit/repos","events_url":"https://api.github.com/users/runconduit/events{/privacy}","received_events_url":"https://api.github.com/users/runconduit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/runconduit/conduit","description":"Ultralight service mesh for Kubernetes","fork":false,"url":"https://api.github.com/repos/runconduit/conduit","forks_url":"https://api.github.com/repos/runconduit/conduit/forks","keys_url":"https://api.github.com/repos/runconduit/conduit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/runconduit/conduit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/runconduit/conduit/teams","hooks_url":"https://api.github.com/repos/runconduit/conduit/hooks","issue_events_url":"https://api.github.com/repos/runconduit/conduit/issues/events{/number}","events_url":"https://api.github.com/repos/runconduit/conduit/events","assignees_url":"https://api.github.com/repos/runconduit/conduit/assignees{/user}","branches_url":"https://api.github.com/repos/runconduit/conduit/branches{/branch}","tags_url":"https://api.github.com/repos/runconduit/conduit/tags","blobs_url":"https://api.github.com/repos/runconduit/conduit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/runconduit/conduit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/runconduit/conduit/git/refs{/sha}","trees_url":"https://api.github.com/repos/runconduit/conduit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/runconduit/conduit/statuses/{sha}","languages_url":"https://api.github.com/repos/runconduit/conduit/languages","stargazers_url":"https://api.github.com/repos/runconduit/conduit/stargazers","contributors_url":"https://api.github.com/repos/runconduit/conduit/contributors","subscribers_url":"https://api.github.com/repos/runconduit/conduit/subscribers","subscription_url":"https://api.github.com/repos/runconduit/conduit/subscription","commits_url":"https://api.github.com/repos/runconduit/conduit/commits{/sha}","git_commits_url":"https://api.github.com/repos/runconduit/conduit/git/commits{/sha}","comments_url":"https://api.github.com/repos/runconduit/conduit/comments{/number}","issue_comment_url":"https://api.github.com/repos/runconduit/conduit/issues/comments{/number}","contents_url":"https://api.github.com/repos/runconduit/conduit/contents/{+path}","compare_url":"https://api.github.com/repos/runconduit/conduit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/runconduit/conduit/merges","archive_url":"https://api.github.com/repos/runconduit/conduit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/runconduit/conduit/downloads","issues_url":"https://api.github.com/repos/runconduit/conduit/issues{/number}","pulls_url":"https://api.github.com/repos/runconduit/conduit/pulls{/number}","milestones_url":"https://api.github.com/repos/runconduit/conduit/milestones{/number}","notifications_url":"https://api.github.com/repos/runconduit/conduit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/runconduit/conduit/labels{/name}","releases_url":"https://api.github.com/repos/runconduit/conduit/releases{/id}","deployments_url":"https://api.github.com/repos/runconduit/conduit/deployments","created_at":"2017-12-04T23:16:56Z","updated_at":"2018-05-29T12:10:49Z","pushed_at":"2018-05-28T13:52:20Z","git_url":"git://github.com/runconduit/conduit.git","ssh_url":"git@github.com:runconduit/conduit.git","clone_url":"https://github.com/runconduit/conduit.git","svn_url":"https://github.com/runconduit/conduit","homepage":"https://conduit.io","size":5252,"stargazers_count":1741,"watchers_count":1741,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"archived":false,"open_issues_count":181,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":99,"open_issues":181,"watchers":1741,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/989"},"html":{"href":"https://github.com/runconduit/conduit/pull/989"},"issue":{"href":"https://api.github.com/repos/runconduit/conduit/issues/989"},"comments":{"href":"https://api.github.com/repos/runconduit/conduit/issues/989/comments"},"review_comments":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/989/comments"},"review_comment":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/runconduit/conduit/pulls/989/commits"},"statuses":{"href":"https://api.github.com/repos/runconduit/conduit/statuses/717e4c8e036c4b8f792b9990570d18ea58dcff41"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"grampelberg"}}