{"action":"created","issue":{"url":"https://api.github.com/repos/duplicati/duplicati/issues/3354","repository_url":"https://api.github.com/repos/duplicati/duplicati","labels_url":"https://api.github.com/repos/duplicati/duplicati/issues/3354/labels{/name}","comments_url":"https://api.github.com/repos/duplicati/duplicati/issues/3354/comments","events_url":"https://api.github.com/repos/duplicati/duplicati/issues/3354/events","html_url":"https://github.com/duplicati/duplicati/pull/3354","id":355839974,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMjc0NjMy","number":3354,"title":"Use ordinal sort rules to compare path names","user":{"login":"warwickmm","id":17345532,"node_id":"MDQ6VXNlcjE3MzQ1NTMy","avatar_url":"https://avatars2.githubusercontent.com/u/17345532?v=4","gravatar_id":"","url":"https://api.github.com/users/warwickmm","html_url":"https://github.com/warwickmm","followers_url":"https://api.github.com/users/warwickmm/followers","following_url":"https://api.github.com/users/warwickmm/following{/other_user}","gists_url":"https://api.github.com/users/warwickmm/gists{/gist_id}","starred_url":"https://api.github.com/users/warwickmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warwickmm/subscriptions","organizations_url":"https://api.github.com/users/warwickmm/orgs","repos_url":"https://api.github.com/users/warwickmm/repos","events_url":"https://api.github.com/users/warwickmm/events{/privacy}","received_events_url":"https://api.github.com/users/warwickmm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-31T05:01:10Z","updated_at":"2018-08-31T05:08:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/duplicati/duplicati/pulls/3354","html_url":"https://github.com/duplicati/duplicati/pull/3354","diff_url":"https://github.com/duplicati/duplicati/pull/3354.diff","patch_url":"https://github.com/duplicati/duplicati/pull/3354.patch"},"body":"It's [recommended](https://docs.microsoft.com/en-us/dotnet/standard/base-types/best-practices-strings) that file paths be compared using ordinal rules.  However, the `Utility.ClientFilenameStringComparer` and `Utility.ClientFilenameStringComparison` properties returned values that resulted in culture-aware comparisons.  By using ordinal sort rules, we avoid issues where two different files on the filesystem can have names that are equivalent in certain cultures (e.g., `\"ddzs\"` and `\"dzsdzs\"` are equivalent with respect to the `hu-HU` culture), which could lead to strange \"collisions\" in the code.\r\n\r\nThis addresses issue #3342."},"comment":{"url":"https://api.github.com/repos/duplicati/duplicati/issues/comments/417553131","html_url":"https://github.com/duplicati/duplicati/pull/3354#issuecomment-417553131","issue_url":"https://api.github.com/repos/duplicati/duplicati/issues/3354","id":417553131,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzU1MzEzMQ==","user":{"login":"warwickmm","id":17345532,"node_id":"MDQ6VXNlcjE3MzQ1NTMy","avatar_url":"https://avatars2.githubusercontent.com/u/17345532?v=4","gravatar_id":"","url":"https://api.github.com/users/warwickmm","html_url":"https://github.com/warwickmm","followers_url":"https://api.github.com/users/warwickmm/followers","following_url":"https://api.github.com/users/warwickmm/following{/other_user}","gists_url":"https://api.github.com/users/warwickmm/gists{/gist_id}","starred_url":"https://api.github.com/users/warwickmm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warwickmm/subscriptions","organizations_url":"https://api.github.com/users/warwickmm/orgs","repos_url":"https://api.github.com/users/warwickmm/repos","events_url":"https://api.github.com/users/warwickmm/events{/privacy}","received_events_url":"https://api.github.com/users/warwickmm/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T05:08:22Z","updated_at":"2018-08-31T05:08:22Z","author_association":"CONTRIBUTOR","body":"Could this change adversely affect existing backups, where some paths stored in the local database (or in the remote filelist) might now compare differently to those on the filesystem?"}}
{"actor":{"display_login":"warwickmm"}}