{"action":"created","issue":{"url":"https://api.github.com/repos/LLNL/GridDyn/issues/28","repository_url":"https://api.github.com/repos/LLNL/GridDyn","labels_url":"https://api.github.com/repos/LLNL/GridDyn/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/LLNL/GridDyn/issues/28/comments","events_url":"https://api.github.com/repos/LLNL/GridDyn/issues/28/events","html_url":"https://github.com/LLNL/GridDyn/pull/28","id":342122254,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMDk5ODc5","number":28,"title":"Clang tidy fixes","user":{"login":"mcneish1","id":35310375,"node_id":"MDQ6VXNlcjM1MzEwMzc1","avatar_url":"https://avatars3.githubusercontent.com/u/35310375?v=4","gravatar_id":"","url":"https://api.github.com/users/mcneish1","html_url":"https://github.com/mcneish1","followers_url":"https://api.github.com/users/mcneish1/followers","following_url":"https://api.github.com/users/mcneish1/following{/other_user}","gists_url":"https://api.github.com/users/mcneish1/gists{/gist_id}","starred_url":"https://api.github.com/users/mcneish1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcneish1/subscriptions","organizations_url":"https://api.github.com/users/mcneish1/orgs","repos_url":"https://api.github.com/users/mcneish1/repos","events_url":"https://api.github.com/users/mcneish1/events{/privacy}","received_events_url":"https://api.github.com/users/mcneish1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-07-17T23:18:32Z","updated_at":"2018-07-23T16:13:59Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/LLNL/GridDyn/pulls/28","html_url":"https://github.com/LLNL/GridDyn/pull/28","diff_url":"https://github.com/LLNL/GridDyn/pull/28.diff","patch_url":"https://github.com/LLNL/GridDyn/pull/28.patch"},"body":"(work in progress)\r\n\r\nLook at this diff vs [this branch](https://github.com/mcneish1/GridDyn/tree/formatting_fixup) (or just https://github.com/LLNL/GridDyn/pull/28/commits/f158def93be8cccdf6d9919b77dfadb057ccce10 and onward), formatting_fixup is the result of running clang-format on everything I can compile (still missing a few things).\r\n\r\nBefore:\r\n```\r\nTotal warnings: 1048\r\n * clang-analyzer-core.uninitialized.UndefReturn: 1\r\n * hicpp-use-auto: 1\r\n * performance-unnecessary-copy-initialization: 1\r\n * clang-diagnostic-unused-const-variable: 1\r\n * clang-diagnostic-unused-lambda-capture: 1\r\n * cert-dcl50-cpp: 1\r\n * readability-non-const-parameter: 1\r\n * clang-diagnostic-shadow: 1\r\n * performance-inefficient-string-concatenation: 1\r\n * hicpp-member-init: 1\r\n * clang-diagnostic-unreachable-code: 1\r\n * cert-err34-c: 2\r\n * hicpp-move-const-arg: 2\r\n * google-readability-casting: 2\r\n * llvm-namespace-comment: 2\r\n * clang-diagnostic-deprecated-declarations: 3\r\n * modernize-loop-convert: 3\r\n * hicpp-noexcept-move: 4\r\n * performance-unnecessary-value-param: 5\r\n * clang-diagnostic-unused-variable: 7\r\n * clang-analyzer-optin.cplusplus.VirtualCall: 9\r\n * hicpp-no-array-decay: 10\r\n * misc-misplaced-const: 11\r\n * readability-else-after-return: 11\r\n * clang-analyzer-core.CallAndMessage: 11\r\n * clang-analyzer-deadcode.DeadStores: 12\r\n * modernize-pass-by-value: 13\r\n * google-runtime-int: 14\r\n * hicpp-use-equals-default: 22\r\n * hicpp-signed-bitwise: 25\r\n * cppcoreguidelines-pro-type-const-cast: 28\r\n * cppcoreguidelines-pro-type-member-init: 31\r\n * clang-diagnostic-unused-parameter: 53\r\n * readability-named-parameter: 75\r\n * cppcoreguidelines-pro-bounds-array-to-pointer-decay: 83\r\n * readability-inconsistent-declaration-parameter-name: 91\r\n * readability-implicit-bool-conversion: 117\r\n * cppcoreguidelines-pro-type-cstyle-cast: 123\r\n * cppcoreguidelines-owning-memory: 126\r\n * hicpp-vararg: 142\r\n```\r\n\r\nCurrently:\r\n```\r\nTotal warnings: 802\r\n * clang-analyzer-core.uninitialized.UndefReturn: 1\r\n * google-readability-casting: 1\r\n * performance-unnecessary-copy-initialization: 1\r\n * clang-diagnostic-unused-const-variable: 1\r\n * cert-dcl50-cpp: 1\r\n * hicpp-member-init: 1\r\n * performance-inefficient-string-concatenation: 1\r\n * clang-diagnostic-unreachable-code: 1\r\n * cert-err34-c: 2\r\n * clang-diagnostic-deprecated-declarations: 3\r\n * modernize-loop-convert: 3\r\n * hicpp-noexcept-move: 4\r\n * performance-unnecessary-value-param: 5\r\n * hicpp-no-array-decay: 5\r\n * clang-diagnostic-unused-variable: 7\r\n * readability-named-parameter: 7\r\n * clang-analyzer-optin.cplusplus.VirtualCall: 9\r\n * clang-analyzer-core.CallAndMessage: 11\r\n * misc-misplaced-const: 11\r\n * clang-analyzer-deadcode.DeadStores: 12\r\n * modernize-pass-by-value: 13\r\n * google-runtime-int: 13\r\n * hicpp-use-equals-default: 22\r\n * clang-diagnostic-unused-parameter: 24\r\n * hicpp-signed-bitwise: 25\r\n * cppcoreguidelines-pro-type-const-cast: 28\r\n * cppcoreguidelines-pro-type-member-init: 29\r\n * readability-implicit-bool-conversion: 31\r\n * readability-inconsistent-declaration-parameter-name: 54\r\n * cppcoreguidelines-pro-bounds-array-to-pointer-decay: 85\r\n * cppcoreguidelines-pro-type-cstyle-cast: 123\r\n * cppcoreguidelines-owning-memory: 126\r\n * hicpp-vararg: 142\r\n```\r\n\r\n\r\nOne worrying thing:\r\n~clang-format mislabels `}  // namespace loads` in [approximating|gridLabD]Load.cpp, thinking it's supposed to be `namespace griddyn`. I'm not sure quite why, maybe something the preprocessor takes out?~"},"comment":{"url":"https://api.github.com/repos/LLNL/GridDyn/issues/comments/407114307","html_url":"https://github.com/LLNL/GridDyn/pull/28#issuecomment-407114307","issue_url":"https://api.github.com/repos/LLNL/GridDyn/issues/28","id":407114307,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzExNDMwNw==","user":{"login":"phlptp","id":20667153,"node_id":"MDQ6VXNlcjIwNjY3MTUz","avatar_url":"https://avatars0.githubusercontent.com/u/20667153?v=4","gravatar_id":"","url":"https://api.github.com/users/phlptp","html_url":"https://github.com/phlptp","followers_url":"https://api.github.com/users/phlptp/followers","following_url":"https://api.github.com/users/phlptp/following{/other_user}","gists_url":"https://api.github.com/users/phlptp/gists{/gist_id}","starred_url":"https://api.github.com/users/phlptp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phlptp/subscriptions","organizations_url":"https://api.github.com/users/phlptp/orgs","repos_url":"https://api.github.com/users/phlptp/repos","events_url":"https://api.github.com/users/phlptp/events{/privacy}","received_events_url":"https://api.github.com/users/phlptp/received_events","type":"User","site_admin":false},"created_at":"2018-07-23T16:13:59Z","updated_at":"2018-07-23T16:13:59Z","author_association":"COLLABORATOR","body":"@mcneish1 if you can resolve these conflicts we can do a quick turnaround and get this merged.  Having all the formatting updated would be good.  "}}
{"actor":{"display_login":"phlptp"}}