{"action":"closed","number":803,"pull_request":{"url":"https://api.github.com/repos/LN-Zap/zap-desktop/pulls/803","id":216998700,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2OTk4NzAw","html_url":"https://github.com/LN-Zap/zap-desktop/pull/803","diff_url":"https://github.com/LN-Zap/zap-desktop/pull/803.diff","patch_url":"https://github.com/LN-Zap/zap-desktop/pull/803.patch","issue_url":"https://api.github.com/repos/LN-Zap/zap-desktop/issues/803","number":803,"state":"closed","locked":false,"title":"test(e2e): combine e2e test setup/teardown steps","user":{"login":"mrfelton","id":200251,"node_id":"MDQ6VXNlcjIwMDI1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/200251?v=4","gravatar_id":"","url":"https://api.github.com/users/mrfelton","html_url":"https://github.com/mrfelton","followers_url":"https://api.github.com/users/mrfelton/followers","following_url":"https://api.github.com/users/mrfelton/following{/other_user}","gists_url":"https://api.github.com/users/mrfelton/gists{/gist_id}","starred_url":"https://api.github.com/users/mrfelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrfelton/subscriptions","organizations_url":"https://api.github.com/users/mrfelton/orgs","repos_url":"https://api.github.com/users/mrfelton/repos","events_url":"https://api.github.com/users/mrfelton/events{/privacy}","received_events_url":"https://api.github.com/users/mrfelton/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\nCombine the e2e tests so that they use a single setup/teardown step which will reduce the frequency of random test failures.\r\n\r\n## Motivation and Context:\r\n\r\nThere is currently a bug with Spectron which is causing random test failures due to `app.quit` not working as it should.\r\n\r\nSee:\r\n - https://github.com/electron/spectron/issues/131\r\n - https://github.com/electron/spectron/issues/186\r\n - https://github.com/electron/spectron/issues/272\r\n\r\n## Types of changes:\r\n\r\nCI Improvement\r\n","created_at":"2018-09-20T14:43:06Z","updated_at":"2018-09-20T15:01:38Z","closed_at":"2018-09-20T15:01:38Z","merged_at":"2018-09-20T15:01:38Z","merge_commit_sha":"afdb7cedddae0bd7f997a77817a1fb844cf4fbce","assignee":{"login":"mrfelton","id":200251,"node_id":"MDQ6VXNlcjIwMDI1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/200251?v=4","gravatar_id":"","url":"https://api.github.com/users/mrfelton","html_url":"https://github.com/mrfelton","followers_url":"https://api.github.com/users/mrfelton/followers","following_url":"https://api.github.com/users/mrfelton/following{/other_user}","gists_url":"https://api.github.com/users/mrfelton/gists{/gist_id}","starred_url":"https://api.github.com/users/mrfelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrfelton/subscriptions","organizations_url":"https://api.github.com/users/mrfelton/orgs","repos_url":"https://api.github.com/users/mrfelton/repos","events_url":"https://api.github.com/users/mrfelton/events{/privacy}","received_events_url":"https://api.github.com/users/mrfelton/received_events","type":"User","site_admin":false},"assignees":[{"login":"mrfelton","id":200251,"node_id":"MDQ6VXNlcjIwMDI1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/200251?v=4","gravatar_id":"","url":"https://api.github.com/users/mrfelton","html_url":"https://github.com/mrfelton","followers_url":"https://api.github.com/users/mrfelton/followers","following_url":"https://api.github.com/users/mrfelton/following{/other_user}","gists_url":"https://api.github.com/users/mrfelton/gists{/gist_id}","starred_url":"https://api.github.com/users/mrfelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrfelton/subscriptions","organizations_url":"https://api.github.com/users/mrfelton/orgs","repos_url":"https://api.github.com/users/mrfelton/repos","events_url":"https://api.github.com/users/mrfelton/events{/privacy}","received_events_url":"https://api.github.com/users/mrfelton/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1004384372,"node_id":"MDU6TGFiZWwxMDA0Mzg0Mzcy","url":"https://api.github.com/repos/LN-Zap/zap-desktop/labels/devops","name":"devops","color":"b2adff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/LN-Zap/zap-desktop/pulls/803/commits","review_comments_url":"https://api.github.com/repos/LN-Zap/zap-desktop/pulls/803/comments","review_comment_url":"https://api.github.com/repos/LN-Zap/zap-desktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LN-Zap/zap-desktop/issues/803/comments","statuses_url":"https://api.github.com/repos/LN-Zap/zap-desktop/statuses/1081db81c491b6edf80218715e59c2207aaf32b1","head":{"label":"mrfelton:test/combine-e2e-tests","ref":"test/combine-e2e-tests","sha":"1081db81c491b6edf80218715e59c2207aaf32b1","user":{"login":"mrfelton","id":200251,"node_id":"MDQ6VXNlcjIwMDI1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/200251?v=4","gravatar_id":"","url":"https://api.github.com/users/mrfelton","html_url":"https://github.com/mrfelton","followers_url":"https://api.github.com/users/mrfelton/followers","following_url":"https://api.github.com/users/mrfelton/following{/other_user}","gists_url":"https://api.github.com/users/mrfelton/gists{/gist_id}","starred_url":"https://api.github.com/users/mrfelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrfelton/subscriptions","organizations_url":"https://api.github.com/users/mrfelton/orgs","repos_url":"https://api.github.com/users/mrfelton/repos","events_url":"https://api.github.com/users/mrfelton/events{/privacy}","received_events_url":"https://api.github.com/users/mrfelton/received_events","type":"User","site_admin":false},"repo":{"id":124420476,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ0MjA0NzY=","name":"zap-desktop","full_name":"mrfelton/zap-desktop","private":false,"owner":{"login":"mrfelton","id":200251,"node_id":"MDQ6VXNlcjIwMDI1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/200251?v=4","gravatar_id":"","url":"https://api.github.com/users/mrfelton","html_url":"https://github.com/mrfelton","followers_url":"https://api.github.com/users/mrfelton/followers","following_url":"https://api.github.com/users/mrfelton/following{/other_user}","gists_url":"https://api.github.com/users/mrfelton/gists{/gist_id}","starred_url":"https://api.github.com/users/mrfelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrfelton/subscriptions","organizations_url":"https://api.github.com/users/mrfelton/orgs","repos_url":"https://api.github.com/users/mrfelton/repos","events_url":"https://api.github.com/users/mrfelton/events{/privacy}","received_events_url":"https://api.github.com/users/mrfelton/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mrfelton/zap-desktop","description":"Lightning Network desktop application ","fork":true,"url":"https://api.github.com/repos/mrfelton/zap-desktop","forks_url":"https://api.github.com/repos/mrfelton/zap-desktop/forks","keys_url":"https://api.github.com/repos/mrfelton/zap-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrfelton/zap-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrfelton/zap-desktop/teams","hooks_url":"https://api.github.com/repos/mrfelton/zap-desktop/hooks","issue_events_url":"https://api.github.com/repos/mrfelton/zap-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/mrfelton/zap-desktop/events","assignees_url":"https://api.github.com/repos/mrfelton/zap-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/mrfelton/zap-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/mrfelton/zap-desktop/tags","blobs_url":"https://api.github.com/repos/mrfelton/zap-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrfelton/zap-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrfelton/zap-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrfelton/zap-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrfelton/zap-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/mrfelton/zap-desktop/languages","stargazers_url":"https://api.github.com/repos/mrfelton/zap-desktop/stargazers","contributors_url":"https://api.github.com/repos/mrfelton/zap-desktop/contributors","subscribers_url":"https://api.github.com/repos/mrfelton/zap-desktop/subscribers","subscription_url":"https://api.github.com/repos/mrfelton/zap-desktop/subscription","commits_url":"https://api.github.com/repos/mrfelton/zap-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrfelton/zap-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrfelton/zap-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrfelton/zap-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrfelton/zap-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/mrfelton/zap-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrfelton/zap-desktop/merges","archive_url":"https://api.github.com/repos/mrfelton/zap-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrfelton/zap-desktop/downloads","issues_url":"https://api.github.com/repos/mrfelton/zap-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/mrfelton/zap-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/mrfelton/zap-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/mrfelton/zap-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrfelton/zap-desktop/labels{/name}","releases_url":"https://api.github.com/repos/mrfelton/zap-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/mrfelton/zap-desktop/deployments","created_at":"2018-03-08T16:45:15Z","updated_at":"2018-08-23T14:32:35Z","pushed_at":"2018-09-20T14:32:48Z","git_url":"git://github.com/mrfelton/zap-desktop.git","ssh_url":"git@github.com:mrfelton/zap-desktop.git","clone_url":"https://github.com/mrfelton/zap-desktop.git","svn_url":"https://github.com/mrfelton/zap-desktop","homepage":"","size":114377,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LN-Zap:master","ref":"master","sha":"2906649fff736595fa1a6b1ff4e820a987c3897a","user":{"login":"LN-Zap","id":30905490,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwOTA1NDkw","avatar_url":"https://avatars1.githubusercontent.com/u/30905490?v=4","gravatar_id":"","url":"https://api.github.com/users/LN-Zap","html_url":"https://github.com/LN-Zap","followers_url":"https://api.github.com/users/LN-Zap/followers","following_url":"https://api.github.com/users/LN-Zap/following{/other_user}","gists_url":"https://api.github.com/users/LN-Zap/gists{/gist_id}","starred_url":"https://api.github.com/users/LN-Zap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LN-Zap/subscriptions","organizations_url":"https://api.github.com/users/LN-Zap/orgs","repos_url":"https://api.github.com/users/LN-Zap/repos","events_url":"https://api.github.com/users/LN-Zap/events{/privacy}","received_events_url":"https://api.github.com/users/LN-Zap/received_events","type":"Organization","site_admin":false},"repo":{"id":99942301,"node_id":"MDEwOlJlcG9zaXRvcnk5OTk0MjMwMQ==","name":"zap-desktop","full_name":"LN-Zap/zap-desktop","private":false,"owner":{"login":"LN-Zap","id":30905490,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwOTA1NDkw","avatar_url":"https://avatars1.githubusercontent.com/u/30905490?v=4","gravatar_id":"","url":"https://api.github.com/users/LN-Zap","html_url":"https://github.com/LN-Zap","followers_url":"https://api.github.com/users/LN-Zap/followers","following_url":"https://api.github.com/users/LN-Zap/following{/other_user}","gists_url":"https://api.github.com/users/LN-Zap/gists{/gist_id}","starred_url":"https://api.github.com/users/LN-Zap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LN-Zap/subscriptions","organizations_url":"https://api.github.com/users/LN-Zap/orgs","repos_url":"https://api.github.com/users/LN-Zap/repos","events_url":"https://api.github.com/users/LN-Zap/events{/privacy}","received_events_url":"https://api.github.com/users/LN-Zap/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LN-Zap/zap-desktop","description":"Cross platform Lightning Network wallet focused on user experience and ease of use ⚡️","fork":false,"url":"https://api.github.com/repos/LN-Zap/zap-desktop","forks_url":"https://api.github.com/repos/LN-Zap/zap-desktop/forks","keys_url":"https://api.github.com/repos/LN-Zap/zap-desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LN-Zap/zap-desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LN-Zap/zap-desktop/teams","hooks_url":"https://api.github.com/repos/LN-Zap/zap-desktop/hooks","issue_events_url":"https://api.github.com/repos/LN-Zap/zap-desktop/issues/events{/number}","events_url":"https://api.github.com/repos/LN-Zap/zap-desktop/events","assignees_url":"https://api.github.com/repos/LN-Zap/zap-desktop/assignees{/user}","branches_url":"https://api.github.com/repos/LN-Zap/zap-desktop/branches{/branch}","tags_url":"https://api.github.com/repos/LN-Zap/zap-desktop/tags","blobs_url":"https://api.github.com/repos/LN-Zap/zap-desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LN-Zap/zap-desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LN-Zap/zap-desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/LN-Zap/zap-desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LN-Zap/zap-desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/LN-Zap/zap-desktop/languages","stargazers_url":"https://api.github.com/repos/LN-Zap/zap-desktop/stargazers","contributors_url":"https://api.github.com/repos/LN-Zap/zap-desktop/contributors","subscribers_url":"https://api.github.com/repos/LN-Zap/zap-desktop/subscribers","subscription_url":"https://api.github.com/repos/LN-Zap/zap-desktop/subscription","commits_url":"https://api.github.com/repos/LN-Zap/zap-desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/LN-Zap/zap-desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/LN-Zap/zap-desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/LN-Zap/zap-desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/LN-Zap/zap-desktop/contents/{+path}","compare_url":"https://api.github.com/repos/LN-Zap/zap-desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LN-Zap/zap-desktop/merges","archive_url":"https://api.github.com/repos/LN-Zap/zap-desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LN-Zap/zap-desktop/downloads","issues_url":"https://api.github.com/repos/LN-Zap/zap-desktop/issues{/number}","pulls_url":"https://api.github.com/repos/LN-Zap/zap-desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/LN-Zap/zap-desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/LN-Zap/zap-desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LN-Zap/zap-desktop/labels{/name}","releases_url":"https://api.github.com/repos/LN-Zap/zap-desktop/releases{/id}","deployments_url":"https://api.github.com/repos/LN-Zap/zap-desktop/deployments","created_at":"2017-08-10T16:14:13Z","updated_at":"2018-09-20T14:31:48Z","pushed_at":"2018-09-20T15:01:38Z","git_url":"git://github.com/LN-Zap/zap-desktop.git","ssh_url":"git@github.com:LN-Zap/zap-desktop.git","clone_url":"https://github.com/LN-Zap/zap-desktop.git","svn_url":"https://github.com/LN-Zap/zap-desktop","homepage":"","size":113914,"stargazers_count":715,"watchers_count":715,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":136,"open_issues":48,"watchers":715,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LN-Zap/zap-desktop/pulls/803"},"html":{"href":"https://github.com/LN-Zap/zap-desktop/pull/803"},"issue":{"href":"https://api.github.com/repos/LN-Zap/zap-desktop/issues/803"},"comments":{"href":"https://api.github.com/repos/LN-Zap/zap-desktop/issues/803/comments"},"review_comments":{"href":"https://api.github.com/repos/LN-Zap/zap-desktop/pulls/803/comments"},"review_comment":{"href":"https://api.github.com/repos/LN-Zap/zap-desktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LN-Zap/zap-desktop/pulls/803/commits"},"statuses":{"href":"https://api.github.com/repos/LN-Zap/zap-desktop/statuses/1081db81c491b6edf80218715e59c2207aaf32b1"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mrfelton","id":200251,"node_id":"MDQ6VXNlcjIwMDI1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/200251?v=4","gravatar_id":"","url":"https://api.github.com/users/mrfelton","html_url":"https://github.com/mrfelton","followers_url":"https://api.github.com/users/mrfelton/followers","following_url":"https://api.github.com/users/mrfelton/following{/other_user}","gists_url":"https://api.github.com/users/mrfelton/gists{/gist_id}","starred_url":"https://api.github.com/users/mrfelton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrfelton/subscriptions","organizations_url":"https://api.github.com/users/mrfelton/orgs","repos_url":"https://api.github.com/users/mrfelton/repos","events_url":"https://api.github.com/users/mrfelton/events{/privacy}","received_events_url":"https://api.github.com/users/mrfelton/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"mrfelton"}}