{"action":"closed","number":371,"pull_request":{"url":"https://api.github.com/repos/digitalocean/doctl/pulls/371","id":233772076,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNzcyMDc2","html_url":"https://github.com/digitalocean/doctl/pull/371","diff_url":"https://github.com/digitalocean/doctl/pull/371.diff","patch_url":"https://github.com/digitalocean/doctl/pull/371.patch","issue_url":"https://api.github.com/repos/digitalocean/doctl/issues/371","number":371,"state":"closed","locked":false,"title":"k8saas: add tests and fix bugs","user":{"login":"aybabtme","id":1189716,"node_id":"MDQ6VXNlcjExODk3MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1189716?v=4","gravatar_id":"","url":"https://api.github.com/users/aybabtme","html_url":"https://github.com/aybabtme","followers_url":"https://api.github.com/users/aybabtme/followers","following_url":"https://api.github.com/users/aybabtme/following{/other_user}","gists_url":"https://api.github.com/users/aybabtme/gists{/gist_id}","starred_url":"https://api.github.com/users/aybabtme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aybabtme/subscriptions","organizations_url":"https://api.github.com/users/aybabtme/orgs","repos_url":"https://api.github.com/users/aybabtme/repos","events_url":"https://api.github.com/users/aybabtme/events{/privacy}","received_events_url":"https://api.github.com/users/aybabtme/received_events","type":"User","site_admin":false},"body":"Doing this iTDD style.\r\n\r\n- generate the mocks for testing calls to the k8s service\r\n- extract the error into funcs for consistency and easier testing\r\n- extract the sub commands into funcs for testing\r\n- fix reference-on-range bugs\r\n- fix missing `--force` check on `node-pool delete`\r\n- check that all the \"by name\" helpers work\r\n\r\nr: @nanzhong @bouk @fatih ","created_at":"2018-11-27T03:57:34Z","updated_at":"2018-11-27T09:12:53Z","closed_at":"2018-11-27T09:12:53Z","merged_at":"2018-11-27T09:12:53Z","merge_commit_sha":"f23c62a230dbc8f0e8b7cef1d60a537ed182b0bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/digitalocean/doctl/pulls/371/commits","review_comments_url":"https://api.github.com/repos/digitalocean/doctl/pulls/371/comments","review_comment_url":"https://api.github.com/repos/digitalocean/doctl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/digitalocean/doctl/issues/371/comments","statuses_url":"https://api.github.com/repos/digitalocean/doctl/statuses/8eedd0a9d69f6cf032076cae7ef797783336b609","head":{"label":"digitalocean:k8saas-support","ref":"k8saas-support","sha":"8eedd0a9d69f6cf032076cae7ef797783336b609","user":{"login":"digitalocean","id":4650108,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NTAxMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4650108?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalocean","html_url":"https://github.com/digitalocean","followers_url":"https://api.github.com/users/digitalocean/followers","following_url":"https://api.github.com/users/digitalocean/following{/other_user}","gists_url":"https://api.github.com/users/digitalocean/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalocean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalocean/subscriptions","organizations_url":"https://api.github.com/users/digitalocean/orgs","repos_url":"https://api.github.com/users/digitalocean/repos","events_url":"https://api.github.com/users/digitalocean/events{/privacy}","received_events_url":"https://api.github.com/users/digitalocean/received_events","type":"Organization","site_admin":false},"repo":{"id":36529854,"node_id":"MDEwOlJlcG9zaXRvcnkzNjUyOTg1NA==","name":"doctl","full_name":"digitalocean/doctl","private":false,"owner":{"login":"digitalocean","id":4650108,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NTAxMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4650108?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalocean","html_url":"https://github.com/digitalocean","followers_url":"https://api.github.com/users/digitalocean/followers","following_url":"https://api.github.com/users/digitalocean/following{/other_user}","gists_url":"https://api.github.com/users/digitalocean/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalocean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalocean/subscriptions","organizations_url":"https://api.github.com/users/digitalocean/orgs","repos_url":"https://api.github.com/users/digitalocean/repos","events_url":"https://api.github.com/users/digitalocean/events{/privacy}","received_events_url":"https://api.github.com/users/digitalocean/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/digitalocean/doctl","description":"A command line tool for DigitalOcean services","fork":false,"url":"https://api.github.com/repos/digitalocean/doctl","forks_url":"https://api.github.com/repos/digitalocean/doctl/forks","keys_url":"https://api.github.com/repos/digitalocean/doctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digitalocean/doctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digitalocean/doctl/teams","hooks_url":"https://api.github.com/repos/digitalocean/doctl/hooks","issue_events_url":"https://api.github.com/repos/digitalocean/doctl/issues/events{/number}","events_url":"https://api.github.com/repos/digitalocean/doctl/events","assignees_url":"https://api.github.com/repos/digitalocean/doctl/assignees{/user}","branches_url":"https://api.github.com/repos/digitalocean/doctl/branches{/branch}","tags_url":"https://api.github.com/repos/digitalocean/doctl/tags","blobs_url":"https://api.github.com/repos/digitalocean/doctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digitalocean/doctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digitalocean/doctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/digitalocean/doctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digitalocean/doctl/statuses/{sha}","languages_url":"https://api.github.com/repos/digitalocean/doctl/languages","stargazers_url":"https://api.github.com/repos/digitalocean/doctl/stargazers","contributors_url":"https://api.github.com/repos/digitalocean/doctl/contributors","subscribers_url":"https://api.github.com/repos/digitalocean/doctl/subscribers","subscription_url":"https://api.github.com/repos/digitalocean/doctl/subscription","commits_url":"https://api.github.com/repos/digitalocean/doctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/digitalocean/doctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/digitalocean/doctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/digitalocean/doctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/digitalocean/doctl/contents/{+path}","compare_url":"https://api.github.com/repos/digitalocean/doctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digitalocean/doctl/merges","archive_url":"https://api.github.com/repos/digitalocean/doctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digitalocean/doctl/downloads","issues_url":"https://api.github.com/repos/digitalocean/doctl/issues{/number}","pulls_url":"https://api.github.com/repos/digitalocean/doctl/pulls{/number}","milestones_url":"https://api.github.com/repos/digitalocean/doctl/milestones{/number}","notifications_url":"https://api.github.com/repos/digitalocean/doctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digitalocean/doctl/labels{/name}","releases_url":"https://api.github.com/repos/digitalocean/doctl/releases{/id}","deployments_url":"https://api.github.com/repos/digitalocean/doctl/deployments","created_at":"2015-05-29T21:24:39Z","updated_at":"2018-11-26T20:15:35Z","pushed_at":"2018-11-27T09:12:53Z","git_url":"git://github.com/digitalocean/doctl.git","ssh_url":"git@github.com:digitalocean/doctl.git","clone_url":"https://github.com/digitalocean/doctl.git","svn_url":"https://github.com/digitalocean/doctl","homepage":"","size":14989,"stargazers_count":1571,"watchers_count":1571,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":136,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":136,"open_issues":31,"watchers":1571,"default_branch":"master"}},"base":{"label":"digitalocean:master","ref":"master","sha":"42f3c2174cd31b992dd6cf143e451ca1c006b52e","user":{"login":"digitalocean","id":4650108,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NTAxMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4650108?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalocean","html_url":"https://github.com/digitalocean","followers_url":"https://api.github.com/users/digitalocean/followers","following_url":"https://api.github.com/users/digitalocean/following{/other_user}","gists_url":"https://api.github.com/users/digitalocean/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalocean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalocean/subscriptions","organizations_url":"https://api.github.com/users/digitalocean/orgs","repos_url":"https://api.github.com/users/digitalocean/repos","events_url":"https://api.github.com/users/digitalocean/events{/privacy}","received_events_url":"https://api.github.com/users/digitalocean/received_events","type":"Organization","site_admin":false},"repo":{"id":36529854,"node_id":"MDEwOlJlcG9zaXRvcnkzNjUyOTg1NA==","name":"doctl","full_name":"digitalocean/doctl","private":false,"owner":{"login":"digitalocean","id":4650108,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NTAxMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4650108?v=4","gravatar_id":"","url":"https://api.github.com/users/digitalocean","html_url":"https://github.com/digitalocean","followers_url":"https://api.github.com/users/digitalocean/followers","following_url":"https://api.github.com/users/digitalocean/following{/other_user}","gists_url":"https://api.github.com/users/digitalocean/gists{/gist_id}","starred_url":"https://api.github.com/users/digitalocean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digitalocean/subscriptions","organizations_url":"https://api.github.com/users/digitalocean/orgs","repos_url":"https://api.github.com/users/digitalocean/repos","events_url":"https://api.github.com/users/digitalocean/events{/privacy}","received_events_url":"https://api.github.com/users/digitalocean/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/digitalocean/doctl","description":"A command line tool for DigitalOcean services","fork":false,"url":"https://api.github.com/repos/digitalocean/doctl","forks_url":"https://api.github.com/repos/digitalocean/doctl/forks","keys_url":"https://api.github.com/repos/digitalocean/doctl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/digitalocean/doctl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/digitalocean/doctl/teams","hooks_url":"https://api.github.com/repos/digitalocean/doctl/hooks","issue_events_url":"https://api.github.com/repos/digitalocean/doctl/issues/events{/number}","events_url":"https://api.github.com/repos/digitalocean/doctl/events","assignees_url":"https://api.github.com/repos/digitalocean/doctl/assignees{/user}","branches_url":"https://api.github.com/repos/digitalocean/doctl/branches{/branch}","tags_url":"https://api.github.com/repos/digitalocean/doctl/tags","blobs_url":"https://api.github.com/repos/digitalocean/doctl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/digitalocean/doctl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/digitalocean/doctl/git/refs{/sha}","trees_url":"https://api.github.com/repos/digitalocean/doctl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/digitalocean/doctl/statuses/{sha}","languages_url":"https://api.github.com/repos/digitalocean/doctl/languages","stargazers_url":"https://api.github.com/repos/digitalocean/doctl/stargazers","contributors_url":"https://api.github.com/repos/digitalocean/doctl/contributors","subscribers_url":"https://api.github.com/repos/digitalocean/doctl/subscribers","subscription_url":"https://api.github.com/repos/digitalocean/doctl/subscription","commits_url":"https://api.github.com/repos/digitalocean/doctl/commits{/sha}","git_commits_url":"https://api.github.com/repos/digitalocean/doctl/git/commits{/sha}","comments_url":"https://api.github.com/repos/digitalocean/doctl/comments{/number}","issue_comment_url":"https://api.github.com/repos/digitalocean/doctl/issues/comments{/number}","contents_url":"https://api.github.com/repos/digitalocean/doctl/contents/{+path}","compare_url":"https://api.github.com/repos/digitalocean/doctl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/digitalocean/doctl/merges","archive_url":"https://api.github.com/repos/digitalocean/doctl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/digitalocean/doctl/downloads","issues_url":"https://api.github.com/repos/digitalocean/doctl/issues{/number}","pulls_url":"https://api.github.com/repos/digitalocean/doctl/pulls{/number}","milestones_url":"https://api.github.com/repos/digitalocean/doctl/milestones{/number}","notifications_url":"https://api.github.com/repos/digitalocean/doctl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/digitalocean/doctl/labels{/name}","releases_url":"https://api.github.com/repos/digitalocean/doctl/releases{/id}","deployments_url":"https://api.github.com/repos/digitalocean/doctl/deployments","created_at":"2015-05-29T21:24:39Z","updated_at":"2018-11-26T20:15:35Z","pushed_at":"2018-11-27T09:12:53Z","git_url":"git://github.com/digitalocean/doctl.git","ssh_url":"git@github.com:digitalocean/doctl.git","clone_url":"https://github.com/digitalocean/doctl.git","svn_url":"https://github.com/digitalocean/doctl","homepage":"","size":14989,"stargazers_count":1571,"watchers_count":1571,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":136,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":136,"open_issues":31,"watchers":1571,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/digitalocean/doctl/pulls/371"},"html":{"href":"https://github.com/digitalocean/doctl/pull/371"},"issue":{"href":"https://api.github.com/repos/digitalocean/doctl/issues/371"},"comments":{"href":"https://api.github.com/repos/digitalocean/doctl/issues/371/comments"},"review_comments":{"href":"https://api.github.com/repos/digitalocean/doctl/pulls/371/comments"},"review_comment":{"href":"https://api.github.com/repos/digitalocean/doctl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/digitalocean/doctl/pulls/371/commits"},"statuses":{"href":"https://api.github.com/repos/digitalocean/doctl/statuses/8eedd0a9d69f6cf032076cae7ef797783336b609"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"aybabtme","id":1189716,"node_id":"MDQ6VXNlcjExODk3MTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1189716?v=4","gravatar_id":"","url":"https://api.github.com/users/aybabtme","html_url":"https://github.com/aybabtme","followers_url":"https://api.github.com/users/aybabtme/followers","following_url":"https://api.github.com/users/aybabtme/following{/other_user}","gists_url":"https://api.github.com/users/aybabtme/gists{/gist_id}","starred_url":"https://api.github.com/users/aybabtme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aybabtme/subscriptions","organizations_url":"https://api.github.com/users/aybabtme/orgs","repos_url":"https://api.github.com/users/aybabtme/repos","events_url":"https://api.github.com/users/aybabtme/events{/privacy}","received_events_url":"https://api.github.com/users/aybabtme/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":653,"deletions":42,"changed_files":5}}
{"actor":{"display_login":"aybabtme"}}