{"action":"created","comment":{"url":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/comments/187671154","pull_request_review_id":119504547,"id":187671154,"diff_hunk":"@@ -7214,18 +7207,30 @@ of the same shape.\n \tthe computed value. This function MUST respect the following\n \tcharacteristics:\n \n+\t1. Let <var>threshold</var> and <var>knee</var> have the\n+\t\tvalues of {{DynamicsCompressorNode/threshold}} and\n+\t\t{{DynamicsCompressorNode/knee}}, respectively,\n+\t\t[=decibels to linear gain unit|converted to linear\n+\t\tunits=] sampled at the time of processing of this\n+\t\tblock (as [=k-rate=] parameters).\n+\n+\t2. Let <var>ratio</var> have the value of the","path":"index.bs","position":null,"original_position":58,"commit_id":"3a7004f9060aefc96ff120a6da309b87bf4c63e2","original_commit_id":"d6db66fe2a78f1657037cc1100318affc2c51888","user":{"login":"rtoy","id":663356,"avatar_url":"https://avatars3.githubusercontent.com/u/663356?v=4","gravatar_id":"","url":"https://api.github.com/users/rtoy","html_url":"https://github.com/rtoy","followers_url":"https://api.github.com/users/rtoy/followers","following_url":"https://api.github.com/users/rtoy/following{/other_user}","gists_url":"https://api.github.com/users/rtoy/gists{/gist_id}","starred_url":"https://api.github.com/users/rtoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtoy/subscriptions","organizations_url":"https://api.github.com/users/rtoy/orgs","repos_url":"https://api.github.com/users/rtoy/repos","events_url":"https://api.github.com/users/rtoy/events{/privacy}","received_events_url":"https://api.github.com/users/rtoy/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-05-11T16:50:28Z","updated_at":"2018-05-11T16:51:06Z","html_url":"https://github.com/WebAudio/web-audio-api/pull/1568#discussion_r187671154","pull_request_url":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/1568","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/comments/187671154"},"html":{"href":"https://github.com/WebAudio/web-audio-api/pull/1568#discussion_r187671154"},"pull_request":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/1568"}},"in_reply_to_id":187453750},"pull_request":{"url":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/1568","id":181573921,"html_url":"https://github.com/WebAudio/web-audio-api/pull/1568","diff_url":"https://github.com/WebAudio/web-audio-api/pull/1568.diff","patch_url":"https://github.com/WebAudio/web-audio-api/pull/1568.patch","issue_url":"https://api.github.com/repos/WebAudio/web-audio-api/issues/1568","number":1568,"state":"open","locked":false,"title":"Issue #1502: Fix single use of threshold, knee, and ratio","user":{"login":"rtoy","id":663356,"avatar_url":"https://avatars3.githubusercontent.com/u/663356?v=4","gravatar_id":"","url":"https://api.github.com/users/rtoy","html_url":"https://github.com/rtoy","followers_url":"https://api.github.com/users/rtoy/followers","following_url":"https://api.github.com/users/rtoy/following{/other_user}","gists_url":"https://api.github.com/users/rtoy/gists{/gist_id}","starred_url":"https://api.github.com/users/rtoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtoy/subscriptions","organizations_url":"https://api.github.com/users/rtoy/orgs","repos_url":"https://api.github.com/users/rtoy/repos","events_url":"https://api.github.com/users/rtoy/events{/privacy}","received_events_url":"https://api.github.com/users/rtoy/received_events","type":"User","site_admin":false},"body":"Move the vars `threshold`, `knee`, and `ratio` from the reduction gain\nalgorithm to the compressor curve algorithm.\n\n\n<!--\n    This comment and the below content is programatically generated.\n    You may add a comma-separated list of anchors you'd like a\n    direct link to below (e.g. #idl-serializers, #idl-sequence):\n\n    Don't remove this comment or modify anything below this line.\n    If you don't want a preview generated for this pull request,\n    just replace the whole of this comment's content by \"no preview\"\n    and remove what's below.\n-->\n***\n<a href=\"https://pr-preview.s3.amazonaws.com/rtoy/web-audio-api/pull/1568.html\" title=\"Last updated on May 11, 2018, 4:50 PM GMT (3a7004f)\">Preview</a> | <a href=\"https://pr-preview.s3.amazonaws.com/WebAudio/web-audio-api/1568/cf8b377...rtoy:3a7004f.html\" title=\"Last updated on May 11, 2018, 4:50 PM GMT (3a7004f)\">Diff</a>","created_at":"2018-04-13T19:14:54Z","updated_at":"2018-05-11T16:51:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd937b0d18d34a34db156233a3c184059392f83a","assignee":{"login":"rtoy","id":663356,"avatar_url":"https://avatars3.githubusercontent.com/u/663356?v=4","gravatar_id":"","url":"https://api.github.com/users/rtoy","html_url":"https://github.com/rtoy","followers_url":"https://api.github.com/users/rtoy/followers","following_url":"https://api.github.com/users/rtoy/following{/other_user}","gists_url":"https://api.github.com/users/rtoy/gists{/gist_id}","starred_url":"https://api.github.com/users/rtoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtoy/subscriptions","organizations_url":"https://api.github.com/users/rtoy/orgs","repos_url":"https://api.github.com/users/rtoy/repos","events_url":"https://api.github.com/users/rtoy/events{/privacy}","received_events_url":"https://api.github.com/users/rtoy/received_events","type":"User","site_admin":false},"assignees":[{"login":"rtoy","id":663356,"avatar_url":"https://avatars3.githubusercontent.com/u/663356?v=4","gravatar_id":"","url":"https://api.github.com/users/rtoy","html_url":"https://github.com/rtoy","followers_url":"https://api.github.com/users/rtoy/followers","following_url":"https://api.github.com/users/rtoy/following{/other_user}","gists_url":"https://api.github.com/users/rtoy/gists{/gist_id}","starred_url":"https://api.github.com/users/rtoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtoy/subscriptions","organizations_url":"https://api.github.com/users/rtoy/orgs","repos_url":"https://api.github.com/users/rtoy/repos","events_url":"https://api.github.com/users/rtoy/events{/privacy}","received_events_url":"https://api.github.com/users/rtoy/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"padenot","id":270485,"avatar_url":"https://avatars1.githubusercontent.com/u/270485?v=4","gravatar_id":"","url":"https://api.github.com/users/padenot","html_url":"https://github.com/padenot","followers_url":"https://api.github.com/users/padenot/followers","following_url":"https://api.github.com/users/padenot/following{/other_user}","gists_url":"https://api.github.com/users/padenot/gists{/gist_id}","starred_url":"https://api.github.com/users/padenot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/padenot/subscriptions","organizations_url":"https://api.github.com/users/padenot/orgs","repos_url":"https://api.github.com/users/padenot/repos","events_url":"https://api.github.com/users/padenot/events{/privacy}","received_events_url":"https://api.github.com/users/padenot/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/1568/commits","review_comments_url":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/1568/comments","review_comment_url":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WebAudio/web-audio-api/issues/1568/comments","statuses_url":"https://api.github.com/repos/WebAudio/web-audio-api/statuses/3a7004f9060aefc96ff120a6da309b87bf4c63e2","head":{"label":"rtoy:1502a-dynamics-compressor-single-use-vars","ref":"1502a-dynamics-compressor-single-use-vars","sha":"3a7004f9060aefc96ff120a6da309b87bf4c63e2","user":{"login":"rtoy","id":663356,"avatar_url":"https://avatars3.githubusercontent.com/u/663356?v=4","gravatar_id":"","url":"https://api.github.com/users/rtoy","html_url":"https://github.com/rtoy","followers_url":"https://api.github.com/users/rtoy/followers","following_url":"https://api.github.com/users/rtoy/following{/other_user}","gists_url":"https://api.github.com/users/rtoy/gists{/gist_id}","starred_url":"https://api.github.com/users/rtoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtoy/subscriptions","organizations_url":"https://api.github.com/users/rtoy/orgs","repos_url":"https://api.github.com/users/rtoy/repos","events_url":"https://api.github.com/users/rtoy/events{/privacy}","received_events_url":"https://api.github.com/users/rtoy/received_events","type":"User","site_admin":false},"repo":{"id":14219840,"name":"web-audio-api","full_name":"rtoy/web-audio-api","owner":{"login":"rtoy","id":663356,"avatar_url":"https://avatars3.githubusercontent.com/u/663356?v=4","gravatar_id":"","url":"https://api.github.com/users/rtoy","html_url":"https://github.com/rtoy","followers_url":"https://api.github.com/users/rtoy/followers","following_url":"https://api.github.com/users/rtoy/following{/other_user}","gists_url":"https://api.github.com/users/rtoy/gists{/gist_id}","starred_url":"https://api.github.com/users/rtoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtoy/subscriptions","organizations_url":"https://api.github.com/users/rtoy/orgs","repos_url":"https://api.github.com/users/rtoy/repos","events_url":"https://api.github.com/users/rtoy/events{/privacy}","received_events_url":"https://api.github.com/users/rtoy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rtoy/web-audio-api","description":"The Web Audio API, developed by the W3C Audio WG","fork":true,"url":"https://api.github.com/repos/rtoy/web-audio-api","forks_url":"https://api.github.com/repos/rtoy/web-audio-api/forks","keys_url":"https://api.github.com/repos/rtoy/web-audio-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtoy/web-audio-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtoy/web-audio-api/teams","hooks_url":"https://api.github.com/repos/rtoy/web-audio-api/hooks","issue_events_url":"https://api.github.com/repos/rtoy/web-audio-api/issues/events{/number}","events_url":"https://api.github.com/repos/rtoy/web-audio-api/events","assignees_url":"https://api.github.com/repos/rtoy/web-audio-api/assignees{/user}","branches_url":"https://api.github.com/repos/rtoy/web-audio-api/branches{/branch}","tags_url":"https://api.github.com/repos/rtoy/web-audio-api/tags","blobs_url":"https://api.github.com/repos/rtoy/web-audio-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtoy/web-audio-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtoy/web-audio-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtoy/web-audio-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtoy/web-audio-api/statuses/{sha}","languages_url":"https://api.github.com/repos/rtoy/web-audio-api/languages","stargazers_url":"https://api.github.com/repos/rtoy/web-audio-api/stargazers","contributors_url":"https://api.github.com/repos/rtoy/web-audio-api/contributors","subscribers_url":"https://api.github.com/repos/rtoy/web-audio-api/subscribers","subscription_url":"https://api.github.com/repos/rtoy/web-audio-api/subscription","commits_url":"https://api.github.com/repos/rtoy/web-audio-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtoy/web-audio-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtoy/web-audio-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtoy/web-audio-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtoy/web-audio-api/contents/{+path}","compare_url":"https://api.github.com/repos/rtoy/web-audio-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtoy/web-audio-api/merges","archive_url":"https://api.github.com/repos/rtoy/web-audio-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtoy/web-audio-api/downloads","issues_url":"https://api.github.com/repos/rtoy/web-audio-api/issues{/number}","pulls_url":"https://api.github.com/repos/rtoy/web-audio-api/pulls{/number}","milestones_url":"https://api.github.com/repos/rtoy/web-audio-api/milestones{/number}","notifications_url":"https://api.github.com/repos/rtoy/web-audio-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtoy/web-audio-api/labels{/name}","releases_url":"https://api.github.com/repos/rtoy/web-audio-api/releases{/id}","deployments_url":"https://api.github.com/repos/rtoy/web-audio-api/deployments","created_at":"2013-11-08T00:13:52Z","updated_at":"2018-05-11T15:45:22Z","pushed_at":"2018-05-11T16:50:13Z","git_url":"git://github.com/rtoy/web-audio-api.git","ssh_url":"git@github.com:rtoy/web-audio-api.git","clone_url":"https://github.com/rtoy/web-audio-api.git","svn_url":"https://github.com/rtoy/web-audio-api","homepage":"http://www.w3.org/2011/audio/wiki/","size":26082,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"gh-pages"}},"base":{"label":"WebAudio:gh-pages","ref":"gh-pages","sha":"cf8b377780ef1e9e4a14f698fd73d61cf9888a7e","user":{"login":"WebAudio","id":3079689,"avatar_url":"https://avatars2.githubusercontent.com/u/3079689?v=4","gravatar_id":"","url":"https://api.github.com/users/WebAudio","html_url":"https://github.com/WebAudio","followers_url":"https://api.github.com/users/WebAudio/followers","following_url":"https://api.github.com/users/WebAudio/following{/other_user}","gists_url":"https://api.github.com/users/WebAudio/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAudio/subscriptions","organizations_url":"https://api.github.com/users/WebAudio/orgs","repos_url":"https://api.github.com/users/WebAudio/repos","events_url":"https://api.github.com/users/WebAudio/events{/privacy}","received_events_url":"https://api.github.com/users/WebAudio/received_events","type":"Organization","site_admin":false},"repo":{"id":12484936,"name":"web-audio-api","full_name":"WebAudio/web-audio-api","owner":{"login":"WebAudio","id":3079689,"avatar_url":"https://avatars2.githubusercontent.com/u/3079689?v=4","gravatar_id":"","url":"https://api.github.com/users/WebAudio","html_url":"https://github.com/WebAudio","followers_url":"https://api.github.com/users/WebAudio/followers","following_url":"https://api.github.com/users/WebAudio/following{/other_user}","gists_url":"https://api.github.com/users/WebAudio/gists{/gist_id}","starred_url":"https://api.github.com/users/WebAudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WebAudio/subscriptions","organizations_url":"https://api.github.com/users/WebAudio/orgs","repos_url":"https://api.github.com/users/WebAudio/repos","events_url":"https://api.github.com/users/WebAudio/events{/privacy}","received_events_url":"https://api.github.com/users/WebAudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WebAudio/web-audio-api","description":"The Web Audio API, developed by the W3C Audio WG","fork":false,"url":"https://api.github.com/repos/WebAudio/web-audio-api","forks_url":"https://api.github.com/repos/WebAudio/web-audio-api/forks","keys_url":"https://api.github.com/repos/WebAudio/web-audio-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WebAudio/web-audio-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WebAudio/web-audio-api/teams","hooks_url":"https://api.github.com/repos/WebAudio/web-audio-api/hooks","issue_events_url":"https://api.github.com/repos/WebAudio/web-audio-api/issues/events{/number}","events_url":"https://api.github.com/repos/WebAudio/web-audio-api/events","assignees_url":"https://api.github.com/repos/WebAudio/web-audio-api/assignees{/user}","branches_url":"https://api.github.com/repos/WebAudio/web-audio-api/branches{/branch}","tags_url":"https://api.github.com/repos/WebAudio/web-audio-api/tags","blobs_url":"https://api.github.com/repos/WebAudio/web-audio-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WebAudio/web-audio-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WebAudio/web-audio-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/WebAudio/web-audio-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WebAudio/web-audio-api/statuses/{sha}","languages_url":"https://api.github.com/repos/WebAudio/web-audio-api/languages","stargazers_url":"https://api.github.com/repos/WebAudio/web-audio-api/stargazers","contributors_url":"https://api.github.com/repos/WebAudio/web-audio-api/contributors","subscribers_url":"https://api.github.com/repos/WebAudio/web-audio-api/subscribers","subscription_url":"https://api.github.com/repos/WebAudio/web-audio-api/subscription","commits_url":"https://api.github.com/repos/WebAudio/web-audio-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/WebAudio/web-audio-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/WebAudio/web-audio-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/WebAudio/web-audio-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/WebAudio/web-audio-api/contents/{+path}","compare_url":"https://api.github.com/repos/WebAudio/web-audio-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WebAudio/web-audio-api/merges","archive_url":"https://api.github.com/repos/WebAudio/web-audio-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WebAudio/web-audio-api/downloads","issues_url":"https://api.github.com/repos/WebAudio/web-audio-api/issues{/number}","pulls_url":"https://api.github.com/repos/WebAudio/web-audio-api/pulls{/number}","milestones_url":"https://api.github.com/repos/WebAudio/web-audio-api/milestones{/number}","notifications_url":"https://api.github.com/repos/WebAudio/web-audio-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WebAudio/web-audio-api/labels{/name}","releases_url":"https://api.github.com/repos/WebAudio/web-audio-api/releases{/id}","deployments_url":"https://api.github.com/repos/WebAudio/web-audio-api/deployments","created_at":"2013-08-30T11:29:49Z","updated_at":"2018-05-10T20:38:30Z","pushed_at":"2018-05-11T16:50:14Z","git_url":"git://github.com/WebAudio/web-audio-api.git","ssh_url":"git@github.com:WebAudio/web-audio-api.git","clone_url":"https://github.com/WebAudio/web-audio-api.git","svn_url":"https://github.com/WebAudio/web-audio-api","homepage":"https://webaudio.github.com/web-audio-api/","size":26096,"stargazers_count":555,"watchers_count":555,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":105,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":105,"open_issues":84,"watchers":555,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/1568"},"html":{"href":"https://github.com/WebAudio/web-audio-api/pull/1568"},"issue":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/issues/1568"},"comments":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/issues/1568/comments"},"review_comments":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/1568/comments"},"review_comment":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/pulls/1568/commits"},"statuses":{"href":"https://api.github.com/repos/WebAudio/web-audio-api/statuses/3a7004f9060aefc96ff120a6da309b87bf4c63e2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rtoy"}}