{"action":"created","issue":{"url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/5849","repository_url":"https://api.github.com/repos/pentaho/pentaho-kettle","labels_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/5849/labels{/name}","comments_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/5849/comments","events_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/5849/events","html_url":"https://github.com/pentaho/pentaho-kettle/pull/5849","id":368705310,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxODIwNjAy","number":5849,"title":"[BACKLOG-24360] Error reading (g)zip files in Text File Input","user":{"login":"NJtwentyone","id":2119761,"node_id":"MDQ6VXNlcjIxMTk3NjE=","avatar_url":"https://avatars3.githubusercontent.com/u/2119761?v=4","gravatar_id":"","url":"https://api.github.com/users/NJtwentyone","html_url":"https://github.com/NJtwentyone","followers_url":"https://api.github.com/users/NJtwentyone/followers","following_url":"https://api.github.com/users/NJtwentyone/following{/other_user}","gists_url":"https://api.github.com/users/NJtwentyone/gists{/gist_id}","starred_url":"https://api.github.com/users/NJtwentyone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NJtwentyone/subscriptions","organizations_url":"https://api.github.com/users/NJtwentyone/orgs","repos_url":"https://api.github.com/users/NJtwentyone/repos","events_url":"https://api.github.com/users/NJtwentyone/events{/privacy}","received_events_url":"https://api.github.com/users/NJtwentyone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-10T14:51:16Z","updated_at":"2018-10-10T16:45:39Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/pentaho/pentaho-kettle/pulls/5849","html_url":"https://github.com/pentaho/pentaho-kettle/pull/5849","diff_url":"https://github.com/pentaho/pentaho-kettle/pull/5849.diff","patch_url":"https://github.com/pentaho/pentaho-kettle/pull/5849.patch"},"body":"-- assumption is external code will use apache vfs2 uri selector to get list of files inside (g)zip\r\n\r\nsee jira issue for more details on background and implementation "},"comment":{"url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/comments/428645494","html_url":"https://github.com/pentaho/pentaho-kettle/pull/5849#issuecomment-428645494","issue_url":"https://api.github.com/repos/pentaho/pentaho-kettle/issues/5849","id":428645494,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODY0NTQ5NA==","user":{"login":"wingman-pentaho","id":18704365,"node_id":"MDQ6VXNlcjE4NzA0MzY1","avatar_url":"https://avatars1.githubusercontent.com/u/18704365?v=4","gravatar_id":"","url":"https://api.github.com/users/wingman-pentaho","html_url":"https://github.com/wingman-pentaho","followers_url":"https://api.github.com/users/wingman-pentaho/followers","following_url":"https://api.github.com/users/wingman-pentaho/following{/other_user}","gists_url":"https://api.github.com/users/wingman-pentaho/gists{/gist_id}","starred_url":"https://api.github.com/users/wingman-pentaho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wingman-pentaho/subscriptions","organizations_url":"https://api.github.com/users/wingman-pentaho/orgs","repos_url":"https://api.github.com/users/wingman-pentaho/repos","events_url":"https://api.github.com/users/wingman-pentaho/events{/privacy}","received_events_url":"https://api.github.com/users/wingman-pentaho/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T16:45:39Z","updated_at":"2018-10-10T16:45:39Z","author_association":"NONE","body":"### Build Completed\n\n:x: This pull request has errors. They will need to be addressed before it can be accepted. See below for more details. Some links are also available below for further assistance in addressing those issues.\n\n#### Build Commands\n\n```sh\nmvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -Dsurefire.runOrder=alphabetical -Daudit -amd clean install\n```\n\n#### Cleanup Commands\n```sh\nmvn -B -f 'pom.xml' -pl 'engine' -P '!assemblies' -amd build-helper:remove-project-artifact\n```\n\n#### Changed files\n\n```console\n  engine/src/main/java/org/pentaho/di/core/compress/gzip/GZIPCompressionInputStream.java\n  engine/src/main/java/org/pentaho/di/core/compress/zip/ZIPCompressionInputStream.java\n  engine/src/test/java/org/pentaho/di/core/compress/gzip/GZIPCompressionInputStreamTest.java\n  engine/src/test/java/org/pentaho/di/core/compress/snappy/SnappyCompressionInputStreamTest.java\n  engine/src/test/java/org/pentaho/di/core/compress/zip/ZIPCompressionInputStreamTest.java\n  engine/src/test/resources/org/pentaho/di/core/compress/gzip/test_customer.tar.gz\n  engine/src/test/resources/org/pentaho/di/core/compress/gzip/test_customer1.csv.gz\n  engine/src/test/resources/org/pentaho/di/core/compress/gzip/test_customer2.csv.gz\n  engine/src/test/resources/org/pentaho/di/core/compress/snappy/test_customer2.csv.sz\n  engine/src/test/resources/org/pentaho/di/core/compress/test_customer1.csv\n  engine/src/test/resources/org/pentaho/di/core/compress/test_customer2.csv\n  engine/src/test/resources/org/pentaho/di/core/compress/zip/test_customer.zip\n```\n\nNewly Broken Tests:\n======================\n###### org.pentaho.di.trans.steps.fileinput.text.TextFileInputContentParsingTest.testGzipCompression:\n\n:red_circle: `java.lang.AssertionError`\n\n```java\njava.lang.AssertionError: Wrong rows count expected:<3> but was:<0>\n\tat org.pentaho.di.trans.steps.fileinput.text.TextFileInputContentParsingTest.testGzipCompression(TextFileInputContentParsingTest.java:104)\n\n```\n\n#### Unit Test Coverage\n\nThese statistics help you identify how your changes have affected the coverage of the following files. If a file is not in this list, then its coverage was not affected by your changes. To get some help interpreting these metrics, please refer to [Jacoco's documentation](http://eclemma.org/jacoco/trunk/doc/counters.html).\n\n<details>\n<summary>:warning: <b>Coverage Changes</b> (click to expand)</summary>\n\n###### org.pentaho.di.trans.steps.checksum.CheckSumMeta\n * Instruction Change: **-0.2%** :small_red_triangle_down:\n\n###### org.pentaho.di.job.entries.ftpsget.JobEntryFTPSGet\n * Branch Change: **-0.6%** :small_red_triangle_down:\n * Complexity Change: **-0.5%** :small_red_triangle_down:\n * Instruction Change: **-0.1%** :small_red_triangle_down:\n\n###### org.pentaho.di.trans.step.StepMeta\n * Branch Change: **-0.6%** :small_red_triangle_down:\n * Complexity Change: **-0.5%** :small_red_triangle_down:\n * Instruction Change: **-0.2%** :small_red_triangle_down:\n * Line Change: **-0.3%** :small_red_triangle_down:\n\n###### org.pentaho.di.trans.steps.calculator.CalculatorMetaFunction\n * Branch Change: **-8.7%** :small_red_triangle_down:\n * Complexity Change: **-3%** :small_red_triangle_down:\n * Instruction Change: **-0.7%** :small_red_triangle_down:\n * Line Change: **-0.9%** :small_red_triangle_down:\n\n###### org.pentaho.di.trans.steps.constant.ConstantMeta\n * Instruction Change: **-0.1%** :small_red_triangle_down:\n\n###### org.pentaho.di.trans.steps.dbproc.DBProcMeta\n * Instruction Change: **-0.1%** :small_red_triangle_down:\n\n###### org.pentaho.di.trans.steps.memgroupby.MemoryGroupByMeta\n * Branch Change: **-1.1%** :small_red_triangle_down:\n * Complexity Change: **-1.3%** :small_red_triangle_down:\n\n###### org.pentaho.di.trans.steps.replacestring.ReplaceStringMeta\n * Instruction Change: **-0.1%** :small_red_triangle_down:\n\n###### org.pentaho.di.trans.steps.sortedmerge.SortedMergeMeta\n * Instruction Change: **-0.2%** :small_red_triangle_down:\n\n</details>"}}
{"actor":{"display_login":"wingman-pentaho"}}