{"action":"created","issue":{"url":"https://api.github.com/repos/google/googletest/issues/1524","repository_url":"https://api.github.com/repos/google/googletest","labels_url":"https://api.github.com/repos/google/googletest/issues/1524/labels{/name}","comments_url":"https://api.github.com/repos/google/googletest/issues/1524/comments","events_url":"https://api.github.com/repos/google/googletest/issues/1524/events","html_url":"https://github.com/google/googletest/pull/1524","id":309640326,"number":1524,"title":"DRY in function mockers pumpfile","user":{"login":"scraimer","id":2108202,"avatar_url":"https://avatars0.githubusercontent.com/u/2108202?v=4","gravatar_id":"","url":"https://api.github.com/users/scraimer","html_url":"https://github.com/scraimer","followers_url":"https://api.github.com/users/scraimer/followers","following_url":"https://api.github.com/users/scraimer/following{/other_user}","gists_url":"https://api.github.com/users/scraimer/gists{/gist_id}","starred_url":"https://api.github.com/users/scraimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scraimer/subscriptions","organizations_url":"https://api.github.com/users/scraimer/orgs","repos_url":"https://api.github.com/users/scraimer/repos","events_url":"https://api.github.com/users/scraimer/events{/privacy}","received_events_url":"https://api.github.com/users/scraimer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-29T06:57:16Z","updated_at":"2018-04-06T02:59:59Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/google/googletest/pulls/1524","html_url":"https://github.com/google/googletest/pull/1524","diff_url":"https://github.com/google/googletest/pull/1524.diff","patch_url":"https://github.com/google/googletest/pull/1524.patch"},"body":"The pump file has a repeated bit of code: `MOCK_CONST_METHOD` and `MOCK_METHOD`. If we could generate both the CONST and non-CONST versions for all the `MOCK_*_METHOD` macros from the same source, we could cut he size of the pump file in half.\r\n\r\nTo do that, I refactored the code in `gmock-generated-function-mockers.h.pump` so that\r\nboth CONST and non-CONST mocks are generated from the same line.\r\n\r\n(When reviewing, please ignore the generated `gmock-generated-function-mockers.h` file, and only look at the changes in the `gmock-generated-function-mockers.h.pump`)"},"comment":{"url":"https://api.github.com/repos/google/googletest/issues/comments/379135117","html_url":"https://github.com/google/googletest/pull/1524#issuecomment-379135117","issue_url":"https://api.github.com/repos/google/googletest/issues/1524","id":379135117,"user":{"login":"gennadiycivil","id":12735026,"avatar_url":"https://avatars1.githubusercontent.com/u/12735026?v=4","gravatar_id":"","url":"https://api.github.com/users/gennadiycivil","html_url":"https://github.com/gennadiycivil","followers_url":"https://api.github.com/users/gennadiycivil/followers","following_url":"https://api.github.com/users/gennadiycivil/following{/other_user}","gists_url":"https://api.github.com/users/gennadiycivil/gists{/gist_id}","starred_url":"https://api.github.com/users/gennadiycivil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gennadiycivil/subscriptions","organizations_url":"https://api.github.com/users/gennadiycivil/orgs","repos_url":"https://api.github.com/users/gennadiycivil/repos","events_url":"https://api.github.com/users/gennadiycivil/events{/privacy}","received_events_url":"https://api.github.com/users/gennadiycivil/received_events","type":"User","site_admin":false},"created_at":"2018-04-06T02:59:59Z","updated_at":"2018-04-06T02:59:59Z","author_association":"MEMBER","body":"@scraimer Thank you for your contribution. We are not really accepting changes to pump anymore because it is about to become irrelevant when googletest drops C++98 support. See https://github.com/google/googletest/issues/1366"}}
{"actor":{"display_login":"gennadiycivil"}}