{"action":"created","comment":{"url":"https://api.github.com/repos/coveo/CoveoTerraformModules/pulls/comments/183398051","pull_request_review_id":114387153,"id":183398051,"diff_hunk":"@@ -0,0 +1,20 @@\n+/**\n+ * Copyright (c) 2011 - 2017, Coveo Solutions Inc.\n+ */\n+\n+variable \"parameter_store_path\" {}\n+\n+variable \"schema_name\" {}\n+\n+variable \"username\" {}\n+\n+variable \"password\" {}\n+\n+variable \"password_kms_key_id\" {\n+  default = \"\"","path":"mysql_schema_configuration/variables.tf","position":14,"original_position":14,"commit_id":"3dad33eb2c4eb978a3afc9f8823cfe0e60b40340","original_commit_id":"3dad33eb2c4eb978a3afc9f8823cfe0e60b40340","user":{"login":"jmorissette","id":8169381,"avatar_url":"https://avatars1.githubusercontent.com/u/8169381?v=4","gravatar_id":"","url":"https://api.github.com/users/jmorissette","html_url":"https://github.com/jmorissette","followers_url":"https://api.github.com/users/jmorissette/followers","following_url":"https://api.github.com/users/jmorissette/following{/other_user}","gists_url":"https://api.github.com/users/jmorissette/gists{/gist_id}","starred_url":"https://api.github.com/users/jmorissette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmorissette/subscriptions","organizations_url":"https://api.github.com/users/jmorissette/orgs","repos_url":"https://api.github.com/users/jmorissette/repos","events_url":"https://api.github.com/users/jmorissette/events{/privacy}","received_events_url":"https://api.github.com/users/jmorissette/received_events","type":"User","site_admin":false},"body":"Si le user passe pas de kms_key_id le password est créée correctement? Je me demande si on devrait pas forcer l'user  à fournir une key et enlever le default = \"\"","created_at":"2018-04-23T13:40:47Z","updated_at":"2018-04-23T13:43:11Z","html_url":"https://github.com/coveo/CoveoTerraformModules/pull/11#discussion_r183398051","pull_request_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/pulls/11","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/coveo/CoveoTerraformModules/pulls/comments/183398051"},"html":{"href":"https://github.com/coveo/CoveoTerraformModules/pull/11#discussion_r183398051"},"pull_request":{"href":"https://api.github.com/repos/coveo/CoveoTerraformModules/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/coveo/CoveoTerraformModules/pulls/11","id":159514621,"html_url":"https://github.com/coveo/CoveoTerraformModules/pull/11","diff_url":"https://github.com/coveo/CoveoTerraformModules/pull/11.diff","patch_url":"https://github.com/coveo/CoveoTerraformModules/pull/11.patch","issue_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/issues/11","number":11,"state":"open","locked":false,"title":"Add mysql schema & user creation module","user":{"login":"yrivardmulrooney","id":12157573,"avatar_url":"https://avatars1.githubusercontent.com/u/12157573?v=4","gravatar_id":"","url":"https://api.github.com/users/yrivardmulrooney","html_url":"https://github.com/yrivardmulrooney","followers_url":"https://api.github.com/users/yrivardmulrooney/followers","following_url":"https://api.github.com/users/yrivardmulrooney/following{/other_user}","gists_url":"https://api.github.com/users/yrivardmulrooney/gists{/gist_id}","starred_url":"https://api.github.com/users/yrivardmulrooney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrivardmulrooney/subscriptions","organizations_url":"https://api.github.com/users/yrivardmulrooney/orgs","repos_url":"https://api.github.com/users/yrivardmulrooney/repos","events_url":"https://api.github.com/users/yrivardmulrooney/events{/privacy}","received_events_url":"https://api.github.com/users/yrivardmulrooney/received_events","type":"User","site_admin":false},"body":"Add module for mysql schema config","created_at":"2017-12-20T20:48:51Z","updated_at":"2018-04-23T13:43:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"865d8c5599f6c64bad3eb11db57fb6c3d9428e88","assignee":{"login":"jmorissette","id":8169381,"avatar_url":"https://avatars1.githubusercontent.com/u/8169381?v=4","gravatar_id":"","url":"https://api.github.com/users/jmorissette","html_url":"https://github.com/jmorissette","followers_url":"https://api.github.com/users/jmorissette/followers","following_url":"https://api.github.com/users/jmorissette/following{/other_user}","gists_url":"https://api.github.com/users/jmorissette/gists{/gist_id}","starred_url":"https://api.github.com/users/jmorissette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmorissette/subscriptions","organizations_url":"https://api.github.com/users/jmorissette/orgs","repos_url":"https://api.github.com/users/jmorissette/repos","events_url":"https://api.github.com/users/jmorissette/events{/privacy}","received_events_url":"https://api.github.com/users/jmorissette/received_events","type":"User","site_admin":false},"assignees":[{"login":"jmorissette","id":8169381,"avatar_url":"https://avatars1.githubusercontent.com/u/8169381?v=4","gravatar_id":"","url":"https://api.github.com/users/jmorissette","html_url":"https://github.com/jmorissette","followers_url":"https://api.github.com/users/jmorissette/followers","following_url":"https://api.github.com/users/jmorissette/following{/other_user}","gists_url":"https://api.github.com/users/jmorissette/gists{/gist_id}","starred_url":"https://api.github.com/users/jmorissette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmorissette/subscriptions","organizations_url":"https://api.github.com/users/jmorissette/orgs","repos_url":"https://api.github.com/users/jmorissette/repos","events_url":"https://api.github.com/users/jmorissette/events{/privacy}","received_events_url":"https://api.github.com/users/jmorissette/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/pulls/11/commits","review_comments_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/pulls/11/comments","review_comment_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/issues/11/comments","statuses_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/statuses/3dad33eb2c4eb978a3afc9f8823cfe0e60b40340","head":{"label":"coveo:add-mysql-schema-user","ref":"add-mysql-schema-user","sha":"3dad33eb2c4eb978a3afc9f8823cfe0e60b40340","user":{"login":"coveo","id":8632328,"avatar_url":"https://avatars2.githubusercontent.com/u/8632328?v=4","gravatar_id":"","url":"https://api.github.com/users/coveo","html_url":"https://github.com/coveo","followers_url":"https://api.github.com/users/coveo/followers","following_url":"https://api.github.com/users/coveo/following{/other_user}","gists_url":"https://api.github.com/users/coveo/gists{/gist_id}","starred_url":"https://api.github.com/users/coveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveo/subscriptions","organizations_url":"https://api.github.com/users/coveo/orgs","repos_url":"https://api.github.com/users/coveo/repos","events_url":"https://api.github.com/users/coveo/events{/privacy}","received_events_url":"https://api.github.com/users/coveo/received_events","type":"Organization","site_admin":false},"repo":{"id":101650073,"name":"CoveoTerraformModules","full_name":"coveo/CoveoTerraformModules","owner":{"login":"coveo","id":8632328,"avatar_url":"https://avatars2.githubusercontent.com/u/8632328?v=4","gravatar_id":"","url":"https://api.github.com/users/coveo","html_url":"https://github.com/coveo","followers_url":"https://api.github.com/users/coveo/followers","following_url":"https://api.github.com/users/coveo/following{/other_user}","gists_url":"https://api.github.com/users/coveo/gists{/gist_id}","starred_url":"https://api.github.com/users/coveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveo/subscriptions","organizations_url":"https://api.github.com/users/coveo/orgs","repos_url":"https://api.github.com/users/coveo/repos","events_url":"https://api.github.com/users/coveo/events{/privacy}","received_events_url":"https://api.github.com/users/coveo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coveo/CoveoTerraformModules","description":"A selection of Terraform modules we used at Coveo.","fork":false,"url":"https://api.github.com/repos/coveo/CoveoTerraformModules","forks_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/forks","keys_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/teams","hooks_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/hooks","issue_events_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/issues/events{/number}","events_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/events","assignees_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/assignees{/user}","branches_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/branches{/branch}","tags_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/tags","blobs_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/git/refs{/sha}","trees_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/statuses/{sha}","languages_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/languages","stargazers_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/stargazers","contributors_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/contributors","subscribers_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/subscribers","subscription_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/subscription","commits_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/commits{/sha}","git_commits_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/git/commits{/sha}","comments_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/comments{/number}","issue_comment_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/issues/comments{/number}","contents_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/contents/{+path}","compare_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/merges","archive_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/downloads","issues_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/issues{/number}","pulls_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/pulls{/number}","milestones_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/milestones{/number}","notifications_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/labels{/name}","releases_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/releases{/id}","deployments_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/deployments","created_at":"2017-08-28T14:12:27Z","updated_at":"2017-08-29T19:38:22Z","pushed_at":"2017-12-21T19:48:37Z","git_url":"git://github.com/coveo/CoveoTerraformModules.git","ssh_url":"git@github.com:coveo/CoveoTerraformModules.git","clone_url":"https://github.com/coveo/CoveoTerraformModules.git","svn_url":"https://github.com/coveo/CoveoTerraformModules","homepage":null,"size":22,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"coveo:master","ref":"master","sha":"0a16b9239f1fea1b876fee4d47c936db801ee38b","user":{"login":"coveo","id":8632328,"avatar_url":"https://avatars2.githubusercontent.com/u/8632328?v=4","gravatar_id":"","url":"https://api.github.com/users/coveo","html_url":"https://github.com/coveo","followers_url":"https://api.github.com/users/coveo/followers","following_url":"https://api.github.com/users/coveo/following{/other_user}","gists_url":"https://api.github.com/users/coveo/gists{/gist_id}","starred_url":"https://api.github.com/users/coveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveo/subscriptions","organizations_url":"https://api.github.com/users/coveo/orgs","repos_url":"https://api.github.com/users/coveo/repos","events_url":"https://api.github.com/users/coveo/events{/privacy}","received_events_url":"https://api.github.com/users/coveo/received_events","type":"Organization","site_admin":false},"repo":{"id":101650073,"name":"CoveoTerraformModules","full_name":"coveo/CoveoTerraformModules","owner":{"login":"coveo","id":8632328,"avatar_url":"https://avatars2.githubusercontent.com/u/8632328?v=4","gravatar_id":"","url":"https://api.github.com/users/coveo","html_url":"https://github.com/coveo","followers_url":"https://api.github.com/users/coveo/followers","following_url":"https://api.github.com/users/coveo/following{/other_user}","gists_url":"https://api.github.com/users/coveo/gists{/gist_id}","starred_url":"https://api.github.com/users/coveo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveo/subscriptions","organizations_url":"https://api.github.com/users/coveo/orgs","repos_url":"https://api.github.com/users/coveo/repos","events_url":"https://api.github.com/users/coveo/events{/privacy}","received_events_url":"https://api.github.com/users/coveo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coveo/CoveoTerraformModules","description":"A selection of Terraform modules we used at Coveo.","fork":false,"url":"https://api.github.com/repos/coveo/CoveoTerraformModules","forks_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/forks","keys_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/teams","hooks_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/hooks","issue_events_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/issues/events{/number}","events_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/events","assignees_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/assignees{/user}","branches_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/branches{/branch}","tags_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/tags","blobs_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/git/refs{/sha}","trees_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/statuses/{sha}","languages_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/languages","stargazers_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/stargazers","contributors_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/contributors","subscribers_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/subscribers","subscription_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/subscription","commits_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/commits{/sha}","git_commits_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/git/commits{/sha}","comments_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/comments{/number}","issue_comment_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/issues/comments{/number}","contents_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/contents/{+path}","compare_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/merges","archive_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/downloads","issues_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/issues{/number}","pulls_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/pulls{/number}","milestones_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/milestones{/number}","notifications_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/labels{/name}","releases_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/releases{/id}","deployments_url":"https://api.github.com/repos/coveo/CoveoTerraformModules/deployments","created_at":"2017-08-28T14:12:27Z","updated_at":"2017-08-29T19:38:22Z","pushed_at":"2017-12-21T19:48:37Z","git_url":"git://github.com/coveo/CoveoTerraformModules.git","ssh_url":"git@github.com:coveo/CoveoTerraformModules.git","clone_url":"https://github.com/coveo/CoveoTerraformModules.git","svn_url":"https://github.com/coveo/CoveoTerraformModules","homepage":null,"size":22,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coveo/CoveoTerraformModules/pulls/11"},"html":{"href":"https://github.com/coveo/CoveoTerraformModules/pull/11"},"issue":{"href":"https://api.github.com/repos/coveo/CoveoTerraformModules/issues/11"},"comments":{"href":"https://api.github.com/repos/coveo/CoveoTerraformModules/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/coveo/CoveoTerraformModules/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/coveo/CoveoTerraformModules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coveo/CoveoTerraformModules/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/coveo/CoveoTerraformModules/statuses/3dad33eb2c4eb978a3afc9f8823cfe0e60b40340"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jmorissette"}}