{"action":"created","issue":{"url":"https://api.github.com/repos/r-spatial/sf/issues/774","repository_url":"https://api.github.com/repos/r-spatial/sf","labels_url":"https://api.github.com/repos/r-spatial/sf/issues/774/labels{/name}","comments_url":"https://api.github.com/repos/r-spatial/sf/issues/774/comments","events_url":"https://api.github.com/repos/r-spatial/sf/issues/774/events","html_url":"https://github.com/r-spatial/sf/pull/774","id":333225250,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NDkwODY5","number":774,"title":"Enhance `c.sfc()` empty geometry output","user":{"login":"uribo","id":228649,"node_id":"MDQ6VXNlcjIyODY0OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/228649?v=4","gravatar_id":"","url":"https://api.github.com/users/uribo","html_url":"https://github.com/uribo","followers_url":"https://api.github.com/users/uribo/followers","following_url":"https://api.github.com/users/uribo/following{/other_user}","gists_url":"https://api.github.com/users/uribo/gists{/gist_id}","starred_url":"https://api.github.com/users/uribo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uribo/subscriptions","organizations_url":"https://api.github.com/users/uribo/orgs","repos_url":"https://api.github.com/users/uribo/repos","events_url":"https://api.github.com/users/uribo/events{/privacy}","received_events_url":"https://api.github.com/users/uribo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-18T11:08:29Z","updated_at":"2018-06-18T12:40:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/r-spatial/sf/pulls/774","html_url":"https://github.com/r-spatial/sf/pull/774","diff_url":"https://github.com/r-spatial/sf/pull/774.diff","patch_url":"https://github.com/r-spatial/sf/pull/774.patch"},"body":"First proposal #773 \r\n\r\nI modified to assign the sum of `st_is_empty()` of sfg object given to `st_sfc (...)`.\r\n\r\nExample:\r\n\r\n```r\r\nlibrary(sf)\r\nc(st_sfc(st_point(c(NA_real_, NA_real_))),\r\n  st_sfc(st_point(c(NA_real_, NA_real_))),\r\n  st_sfc(st_point(c(134, 43))))\r\n# Geometry set for 3 features  (with 2 geometries empty)\r\n# geometry type:  POINT\r\n# dimension:      XY\r\n# bbox:           xmin: 134 ymin: 43 xmax: 134 ymax: 43\r\n# epsg (SRID):    NA\r\n# proj4string:    NA\r\n# POINT EMPTY\r\n# POINT EMPTY\r\n# POINT (134 43)\r\n```"},"comment":{"url":"https://api.github.com/repos/r-spatial/sf/issues/comments/398040518","html_url":"https://github.com/r-spatial/sf/pull/774#issuecomment-398040518","issue_url":"https://api.github.com/repos/r-spatial/sf/issues/774","id":398040518,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODA0MDUxOA==","user":{"login":"uribo","id":228649,"node_id":"MDQ6VXNlcjIyODY0OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/228649?v=4","gravatar_id":"","url":"https://api.github.com/users/uribo","html_url":"https://github.com/uribo","followers_url":"https://api.github.com/users/uribo/followers","following_url":"https://api.github.com/users/uribo/following{/other_user}","gists_url":"https://api.github.com/users/uribo/gists{/gist_id}","starred_url":"https://api.github.com/users/uribo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uribo/subscriptions","organizations_url":"https://api.github.com/users/uribo/orgs","repos_url":"https://api.github.com/users/uribo/repos","events_url":"https://api.github.com/users/uribo/events{/privacy}","received_events_url":"https://api.github.com/users/uribo/received_events","type":"User","site_admin":false},"created_at":"2018-06-18T12:40:22Z","updated_at":"2018-06-18T12:40:22Z","author_association":"CONTRIBUTOR","body":"Thanks, @edzer!\r\nMy understanding was not enough.\r\n\r\n`st_is_empty()` is calls `sfc()`.  https://github.com/r-spatial/sf/blob/616a23c463bf7de893f4906b1d68761f30a54625/R/RcppExports.R#L165\r\n\r\nSo I reverted to the first method without using `st_is_empty()`. Is there anything else to check?"}}
{"actor":{"display_login":"uribo"}}