{"action":"closed","number":9493,"pull_request":{"url":"https://api.github.com/repos/scipy/scipy/pulls/9493","id":231677735,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNjc3NzM1","html_url":"https://github.com/scipy/scipy/pull/9493","diff_url":"https://github.com/scipy/scipy/pull/9493.diff","patch_url":"https://github.com/scipy/scipy/pull/9493.patch","issue_url":"https://api.github.com/repos/scipy/scipy/issues/9493","number":9493,"state":"closed","locked":false,"title":"TST: 32-bit test_distance.py now passes","user":{"login":"tylerjereddy","id":7903078,"node_id":"MDQ6VXNlcjc5MDMwNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7903078?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerjereddy","html_url":"https://github.com/tylerjereddy","followers_url":"https://api.github.com/users/tylerjereddy/followers","following_url":"https://api.github.com/users/tylerjereddy/following{/other_user}","gists_url":"https://api.github.com/users/tylerjereddy/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerjereddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerjereddy/subscriptions","organizations_url":"https://api.github.com/users/tylerjereddy/orgs","repos_url":"https://api.github.com/users/tylerjereddy/repos","events_url":"https://api.github.com/users/tylerjereddy/events{/privacy}","received_events_url":"https://api.github.com/users/tylerjereddy/received_events","type":"User","site_admin":false},"body":"As [discussed](https://github.com/MacPython/scipy-wheels/pull/37#issuecomment-439281762) for SciPy wheel building related to `1.2.x`, there was a [test failure with 32-bit Python interpreters](https://travis-ci.org/MacPython/scipy-wheels/jobs/455687598) in our wheel build matrix in `scipy/spatial/tests/test_distance.py::TestPdist::test_pdist_jensenshannon_iris_nonC`\r\n\r\nI've reduced the stringency of the test a bit so that it can pass with a 32-bit interpreter. This isn't caught by our current test matrix (wheel matrix only), but I did reproduce locally using an i386 Ubuntu docker container -- I'll put the sequence of commands used below in case a reviewer wants to check (I should probably just upload an image / dockerfile I suppose):\r\n\r\n<details>\r\n\r\n- `docker pull i386/ubuntu`\r\n- `docker run -it i386/ubuntu`\r\n- `apt-get update`\r\n- `apt-get install python2.7-dev`\r\n- `apt-get install python-pip`\r\n- `pip2 install cython==0.29.0 numpy==1.8.2`\r\n- `apt-get install git`\r\n- `git clone https://github.com/scipy/scipy.git`\r\n- `apt-get install libopenblas-dev`\r\n- `apt-get install gfortran`\r\n- `pip2 install pytest`\r\n- `apt-get install vim`\r\n- in scipy repo on master at hash 3651d2d7  again:\r\n- `python setup.py install`\r\n- `python runtests.py -t \"scipy/spatial/tests/test_distance.py::TestPdist::test_pdist_jensenshannon_iris_nonC\"`\r\n  - fails without patch here\r\n</details>","created_at":"2018-11-16T22:54:07Z","updated_at":"2018-11-19T04:44:13Z","closed_at":"2018-11-19T04:44:13Z","merged_at":"2018-11-19T04:44:13Z","merge_commit_sha":"b255ca64331529d082ec381c4300b34a8e39e0ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":194191458,"node_id":"MDU6TGFiZWwxOTQxOTE0NTg=","url":"https://api.github.com/repos/scipy/scipy/labels/backport-candidate","name":"backport-candidate","color":"5319e7","default":false},{"id":37345293,"node_id":"MDU6TGFiZWwzNzM0NTI5Mw==","url":"https://api.github.com/repos/scipy/scipy/labels/scipy.spatial","name":"scipy.spatial","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/scipy/scipy/pulls/9493/commits","review_comments_url":"https://api.github.com/repos/scipy/scipy/pulls/9493/comments","review_comment_url":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/9493/comments","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/195b782d26a72e502d7fb26af9301bc33c827174","head":{"label":"tylerjereddy:jensenshannon_eps_fix","ref":"jensenshannon_eps_fix","sha":"195b782d26a72e502d7fb26af9301bc33c827174","user":{"login":"tylerjereddy","id":7903078,"node_id":"MDQ6VXNlcjc5MDMwNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7903078?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerjereddy","html_url":"https://github.com/tylerjereddy","followers_url":"https://api.github.com/users/tylerjereddy/followers","following_url":"https://api.github.com/users/tylerjereddy/following{/other_user}","gists_url":"https://api.github.com/users/tylerjereddy/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerjereddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerjereddy/subscriptions","organizations_url":"https://api.github.com/users/tylerjereddy/orgs","repos_url":"https://api.github.com/users/tylerjereddy/repos","events_url":"https://api.github.com/users/tylerjereddy/events{/privacy}","received_events_url":"https://api.github.com/users/tylerjereddy/received_events","type":"User","site_admin":false},"repo":{"id":41598782,"node_id":"MDEwOlJlcG9zaXRvcnk0MTU5ODc4Mg==","name":"scipy","full_name":"tylerjereddy/scipy","private":false,"owner":{"login":"tylerjereddy","id":7903078,"node_id":"MDQ6VXNlcjc5MDMwNzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7903078?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerjereddy","html_url":"https://github.com/tylerjereddy","followers_url":"https://api.github.com/users/tylerjereddy/followers","following_url":"https://api.github.com/users/tylerjereddy/following{/other_user}","gists_url":"https://api.github.com/users/tylerjereddy/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerjereddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerjereddy/subscriptions","organizations_url":"https://api.github.com/users/tylerjereddy/orgs","repos_url":"https://api.github.com/users/tylerjereddy/repos","events_url":"https://api.github.com/users/tylerjereddy/events{/privacy}","received_events_url":"https://api.github.com/users/tylerjereddy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tylerjereddy/scipy","description":"Scipy library main repository","fork":true,"url":"https://api.github.com/repos/tylerjereddy/scipy","forks_url":"https://api.github.com/repos/tylerjereddy/scipy/forks","keys_url":"https://api.github.com/repos/tylerjereddy/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tylerjereddy/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tylerjereddy/scipy/teams","hooks_url":"https://api.github.com/repos/tylerjereddy/scipy/hooks","issue_events_url":"https://api.github.com/repos/tylerjereddy/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/tylerjereddy/scipy/events","assignees_url":"https://api.github.com/repos/tylerjereddy/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/tylerjereddy/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/tylerjereddy/scipy/tags","blobs_url":"https://api.github.com/repos/tylerjereddy/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tylerjereddy/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tylerjereddy/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/tylerjereddy/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tylerjereddy/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/tylerjereddy/scipy/languages","stargazers_url":"https://api.github.com/repos/tylerjereddy/scipy/stargazers","contributors_url":"https://api.github.com/repos/tylerjereddy/scipy/contributors","subscribers_url":"https://api.github.com/repos/tylerjereddy/scipy/subscribers","subscription_url":"https://api.github.com/repos/tylerjereddy/scipy/subscription","commits_url":"https://api.github.com/repos/tylerjereddy/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/tylerjereddy/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/tylerjereddy/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/tylerjereddy/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/tylerjereddy/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/tylerjereddy/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tylerjereddy/scipy/merges","archive_url":"https://api.github.com/repos/tylerjereddy/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tylerjereddy/scipy/downloads","issues_url":"https://api.github.com/repos/tylerjereddy/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/tylerjereddy/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/tylerjereddy/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/tylerjereddy/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tylerjereddy/scipy/labels{/name}","releases_url":"https://api.github.com/repos/tylerjereddy/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/tylerjereddy/scipy/deployments","created_at":"2015-08-29T15:59:44Z","updated_at":"2018-11-11T05:16:23Z","pushed_at":"2018-11-16T23:57:26Z","git_url":"git://github.com/tylerjereddy/scipy.git","ssh_url":"git@github.com:tylerjereddy/scipy.git","clone_url":"https://github.com/tylerjereddy/scipy.git","svn_url":"https://github.com/tylerjereddy/scipy","homepage":"http://scipy.org/scipylib/","size":81284,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"scipy:master","ref":"master","sha":"3651d2d7d3380c4dcd80303ae50b563d38b4c037","user":{"login":"scipy","id":288277,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/288277?v=4","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"repo":{"id":1460385,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwMzg1","name":"scipy","full_name":"scipy/scipy","private":false,"owner":{"login":"scipy","id":288277,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/288277?v=4","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/scipy/scipy","description":"Scipy library main repository","fork":false,"url":"https://api.github.com/repos/scipy/scipy","forks_url":"https://api.github.com/repos/scipy/scipy/forks","keys_url":"https://api.github.com/repos/scipy/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scipy/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scipy/scipy/teams","hooks_url":"https://api.github.com/repos/scipy/scipy/hooks","issue_events_url":"https://api.github.com/repos/scipy/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/scipy/scipy/events","assignees_url":"https://api.github.com/repos/scipy/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/scipy/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/scipy/scipy/tags","blobs_url":"https://api.github.com/repos/scipy/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scipy/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scipy/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scipy/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/scipy/scipy/languages","stargazers_url":"https://api.github.com/repos/scipy/scipy/stargazers","contributors_url":"https://api.github.com/repos/scipy/scipy/contributors","subscribers_url":"https://api.github.com/repos/scipy/scipy/subscribers","subscription_url":"https://api.github.com/repos/scipy/scipy/subscription","commits_url":"https://api.github.com/repos/scipy/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scipy/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scipy/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scipy/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scipy/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/scipy/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scipy/scipy/merges","archive_url":"https://api.github.com/repos/scipy/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scipy/scipy/downloads","issues_url":"https://api.github.com/repos/scipy/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/scipy/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/scipy/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/scipy/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scipy/scipy/labels{/name}","releases_url":"https://api.github.com/repos/scipy/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/scipy/scipy/deployments","created_at":"2011-03-09T18:52:03Z","updated_at":"2018-11-19T04:09:16Z","pushed_at":"2018-11-19T04:44:13Z","git_url":"git://github.com/scipy/scipy.git","ssh_url":"git@github.com:scipy/scipy.git","clone_url":"https://github.com/scipy/scipy.git","svn_url":"https://github.com/scipy/scipy","homepage":"https://scipy.org/scipylib/","size":83526,"stargazers_count":5107,"watchers_count":5107,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2563,"mirror_url":null,"archived":false,"open_issues_count":1312,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2563,"open_issues":1312,"watchers":5107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/9493"},"html":{"href":"https://github.com/scipy/scipy/pull/9493"},"issue":{"href":"https://api.github.com/repos/scipy/scipy/issues/9493"},"comments":{"href":"https://api.github.com/repos/scipy/scipy/issues/9493/comments"},"review_comments":{"href":"https://api.github.com/repos/scipy/scipy/pulls/9493/comments"},"review_comment":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scipy/scipy/pulls/9493/commits"},"statuses":{"href":"https://api.github.com/repos/scipy/scipy/statuses/195b782d26a72e502d7fb26af9301bc33c827174"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rgommers","id":98330,"node_id":"MDQ6VXNlcjk4MzMw","avatar_url":"https://avatars3.githubusercontent.com/u/98330?v=4","gravatar_id":"","url":"https://api.github.com/users/rgommers","html_url":"https://github.com/rgommers","followers_url":"https://api.github.com/users/rgommers/followers","following_url":"https://api.github.com/users/rgommers/following{/other_user}","gists_url":"https://api.github.com/users/rgommers/gists{/gist_id}","starred_url":"https://api.github.com/users/rgommers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgommers/subscriptions","organizations_url":"https://api.github.com/users/rgommers/orgs","repos_url":"https://api.github.com/users/rgommers/repos","events_url":"https://api.github.com/users/rgommers/events{/privacy}","received_events_url":"https://api.github.com/users/rgommers/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"rgommers"}}