{"action":"created","issue":{"url":"https://api.github.com/repos/muflihun/easyloggingpp/issues/561","repository_url":"https://api.github.com/repos/muflihun/easyloggingpp","labels_url":"https://api.github.com/repos/muflihun/easyloggingpp/issues/561/labels{/name}","comments_url":"https://api.github.com/repos/muflihun/easyloggingpp/issues/561/comments","events_url":"https://api.github.com/repos/muflihun/easyloggingpp/issues/561/events","html_url":"https://github.com/muflihun/easyloggingpp/pull/561","id":250595624,"number":561,"title":"Disable log file *initially* when using ELPP_NO_LOG_TO_FILE, to be consistent with documentation","user":{"login":"rggjan","id":128554,"avatar_url":"https://avatars2.githubusercontent.com/u/128554?v=4","gravatar_id":"","url":"https://api.github.com/users/rggjan","html_url":"https://github.com/rggjan","followers_url":"https://api.github.com/users/rggjan/followers","following_url":"https://api.github.com/users/rggjan/following{/other_user}","gists_url":"https://api.github.com/users/rggjan/gists{/gist_id}","starred_url":"https://api.github.com/users/rggjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rggjan/subscriptions","organizations_url":"https://api.github.com/users/rggjan/orgs","repos_url":"https://api.github.com/users/rggjan/repos","events_url":"https://api.github.com/users/rggjan/events{/privacy}","received_events_url":"https://api.github.com/users/rggjan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-16T11:35:13Z","updated_at":"2018-02-14T05:27:03Z","closed_at":"2018-02-14T05:27:03Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/muflihun/easyloggingpp/pulls/561","html_url":"https://github.com/muflihun/easyloggingpp/pull/561","diff_url":"https://github.com/muflihun/easyloggingpp/pull/561.diff","patch_url":"https://github.com/muflihun/easyloggingpp/pull/561.patch"},"body":"Currently, setting \"ELPP_NO_LOG_TO_FILE\" disables logging to file entirely. However, the documentation says it is only disabled initially.\r\n\r\nWhen applying the current pull request, it is possible to disable it initially and set a custom log file location at runtime like this:\r\n\r\n```\r\n#define ELPP_NO_LOG_TO_FILE\r\n#define ELPP_NO_DEFAULT_LOG_FILE\r\n\r\n#include <easylogging++.h>\r\n\r\nINITIALIZE_EASYLOGGINGPP\r\n\r\nint main(int, char **) {\r\n  el::Loggers::reconfigureAllLoggers(el::ConfigurationType::Filename,\r\n                                     \"test.log\");\r\n  el::Loggers::reconfigureAllLoggers(el::ConfigurationType::ToFile, \"true\");\r\n\r\n  LOG(INFO) << \"Test\";\r\n}\r\n```\r\n\r\nThis is impossible with the current implementation.\r\n\r\n### This is a\r\n\r\n- [ ] Breaking change\r\n- [ ] New feature\r\n- [ x] Bugfix\r\n"},"comment":{"url":"https://api.github.com/repos/muflihun/easyloggingpp/issues/comments/365500288","html_url":"https://github.com/muflihun/easyloggingpp/pull/561#issuecomment-365500288","issue_url":"https://api.github.com/repos/muflihun/easyloggingpp/issues/561","id":365500288,"user":{"login":"abumusamq","id":1683515,"avatar_url":"https://avatars1.githubusercontent.com/u/1683515?v=4","gravatar_id":"","url":"https://api.github.com/users/abumusamq","html_url":"https://github.com/abumusamq","followers_url":"https://api.github.com/users/abumusamq/followers","following_url":"https://api.github.com/users/abumusamq/following{/other_user}","gists_url":"https://api.github.com/users/abumusamq/gists{/gist_id}","starred_url":"https://api.github.com/users/abumusamq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abumusamq/subscriptions","organizations_url":"https://api.github.com/users/abumusamq/orgs","repos_url":"https://api.github.com/users/abumusamq/repos","events_url":"https://api.github.com/users/abumusamq/events{/privacy}","received_events_url":"https://api.github.com/users/abumusamq/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T05:27:03Z","updated_at":"2018-02-14T05:27:03Z","author_association":"COLLABORATOR","body":"I have applied this change manually in fb67e3a"}}
{"actor":{"display_login":"abumusamq"}}