{"action":"created","issue":{"url":"https://api.github.com/repos/CrowdHailer/raxx/issues/143","repository_url":"https://api.github.com/repos/CrowdHailer/raxx","labels_url":"https://api.github.com/repos/CrowdHailer/raxx/issues/143/labels{/name}","comments_url":"https://api.github.com/repos/CrowdHailer/raxx/issues/143/comments","events_url":"https://api.github.com/repos/CrowdHailer/raxx/issues/143/events","html_url":"https://github.com/CrowdHailer/raxx/pull/143","id":374279200,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MDE1ODcy","number":143,"title":"Introduce separate behaviour for streaming and simple cases","user":{"login":"CrowdHailer","id":5862302,"node_id":"MDQ6VXNlcjU4NjIzMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/5862302?v=4","gravatar_id":"","url":"https://api.github.com/users/CrowdHailer","html_url":"https://github.com/CrowdHailer","followers_url":"https://api.github.com/users/CrowdHailer/followers","following_url":"https://api.github.com/users/CrowdHailer/following{/other_user}","gists_url":"https://api.github.com/users/CrowdHailer/gists{/gist_id}","starred_url":"https://api.github.com/users/CrowdHailer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CrowdHailer/subscriptions","organizations_url":"https://api.github.com/users/CrowdHailer/orgs","repos_url":"https://api.github.com/users/CrowdHailer/repos","events_url":"https://api.github.com/users/CrowdHailer/events{/privacy}","received_events_url":"https://api.github.com/users/CrowdHailer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-26T08:30:06Z","updated_at":"2018-10-27T12:43:39Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/CrowdHailer/raxx/pulls/143","html_url":"https://github.com/CrowdHailer/raxx/pull/143","diff_url":"https://github.com/CrowdHailer/raxx/pull/143.diff","patch_url":"https://github.com/CrowdHailer/raxx/pull/143.patch"},"body":"Streaming interfaces never needed to implement a handle_request callback, this included middleware like the router that had a nonsense return to satisfy the compiler warnings about an unimplemented callback.\r\nThis PR separates the handle_request callback to it's own new behaviour `Raxx.SimpleServer`\r\nTo help with the upgrade path `use Raxx.Server` now requires a type. No type raises an error, this should be helpful in alerting users who upgrade to the changes.\r\n\r\nWhich should be the preferred style? Both lines below are equivalent.\r\n\r\n```elixir\r\nuse Raxx.Server, type: :simple\r\n# or\r\nuse Raxx.SimpleServer\r\n```\r\n\r\nThis PR requires an update to Ace\r\nhttps://github.com/CrowdHailer/Ace/pull/122\r\n\r\nAn example of using the new interface can be found in this PR\r\nhttps://github.com/CrowdHailer/watercooler/pull/2"},"comment":{"url":"https://api.github.com/repos/CrowdHailer/raxx/issues/comments/433617244","html_url":"https://github.com/CrowdHailer/raxx/pull/143#issuecomment-433617244","issue_url":"https://api.github.com/repos/CrowdHailer/raxx/issues/143","id":433617244,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzYxNzI0NA==","user":{"login":"CrowdHailer","id":5862302,"node_id":"MDQ6VXNlcjU4NjIzMDI=","avatar_url":"https://avatars3.githubusercontent.com/u/5862302?v=4","gravatar_id":"","url":"https://api.github.com/users/CrowdHailer","html_url":"https://github.com/CrowdHailer","followers_url":"https://api.github.com/users/CrowdHailer/followers","following_url":"https://api.github.com/users/CrowdHailer/following{/other_user}","gists_url":"https://api.github.com/users/CrowdHailer/gists{/gist_id}","starred_url":"https://api.github.com/users/CrowdHailer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CrowdHailer/subscriptions","organizations_url":"https://api.github.com/users/CrowdHailer/orgs","repos_url":"https://api.github.com/users/CrowdHailer/repos","events_url":"https://api.github.com/users/CrowdHailer/events{/privacy}","received_events_url":"https://api.github.com/users/CrowdHailer/received_events","type":"User","site_admin":false},"created_at":"2018-10-27T12:43:39Z","updated_at":"2018-10-27T12:43:39Z","author_association":"OWNER","body":"> `use Raxx.Server` (without any type) mean the streaming server\r\n\r\nI would actually like this to be the end case. Just annoying that that is already used to mean the simple server in so many applications. Will investigate some further macro magic, see what warnings I can get"}}
{"actor":{"display_login":"CrowdHailer"}}