{"push_id":2296963438,"size":151,"distinct_size":0,"ref":"refs/heads/v9.x-staging","head":"81da708f73e5eb2554c9945acff7cc86bafa1c30","before":"dd56bd15912199a699f9c6e4ab9ec5be55ea1453","commits":[{"sha":"8f8e7479cbbb23d5a9c23e759d2a38973476ea8b","author":{"name":"Anna Henningsen","email":"6ab69d5d0413b53c075e34a831dd9f590ea00ac1@addaleax.net"},"message":"lib: remove queue implementation from JSStreamWrap\n\nThe streams implementation generally ensures that only one write()\ncall is active at a time. `JSStreamWrap` instances still kept\nqueue of write reqeuests in spite of that; refactor it away.\n\nAlso, fold `isAlive()` into a constant function on the native side.\n\nPR-URL: https://github.com/nodejs/node/pull/17918\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Tobias Nießen <tniessen@tnie.de>\nReviewed-By: Minwoo Jung <minwoo@nodesource.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Tiancheng \"Timothy\" Gu <timothygu99@gmail.com>\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/8f8e7479cbbb23d5a9c23e759d2a38973476ea8b"},{"sha":"dd72f9c9b7d22b3d836623fe321cc5d2a44b0072","author":{"name":"Qingyan Li","email":"fe7f7342cdf01a6a2cb99c4bd7e1d76f4b29c3ae@alibaba-inc.com"},"message":"build: fix cctest target with --enable-static\n\nCurrently the cctest target build will fail if configured with --enable-static\n\n$ ./configure --enable-static\n$ make\n\nThere're some function multiple definition errors such as:\n  out/Release/obj.target/node/src/node_crypto.o: In function `node::crypto::RandomBytesWork(uv_work_s*)':\n  node_crypto.cc:(.text+0x60): multiple definition of `node::crypto::RandomBytesWork(uv_work_s*)'\n  out/Release/obj.target/node/src/node_crypto.o:node_crypto.cc:(.text+0x60): first defined here\n\nIt's caused by repetition objects in libraries and libnode.a.\nThis CL makes those libraries guarded by 'node_target_type!=\"static_library\"'.\n\nPR-URL: https://github.com/nodejs/node/pull/17992\nReviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/dd72f9c9b7d22b3d836623fe321cc5d2a44b0072"},{"sha":"278450fc72609636e77bac78559c879fb4f837d5","author":{"name":"Rich Trott","email":"c1321c10e42359e7caa6e441829d03e9d30a4048@gmail.com"},"message":"doc: multiple updates to child_process.md\n\n* use serial comma in child_process.md\n* use American spelling of unsanitized in child_process.md\n* hyphenate general-purpose in child_process.md\n* remove errant commas in child_process.md\n\nPR-URL: https://github.com/nodejs/node/pull/17990\nReviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>\nReviewed-By: Jon Moss <me@jonathanmoss.me>\nReviewed-By: Weijia Wang <starkwang@126.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/278450fc72609636e77bac78559c879fb4f837d5"},{"sha":"3456e61b44c707aae6e78f7e3ee2a49ee2703847","author":{"name":"Rich Trott","email":"c1321c10e42359e7caa6e441829d03e9d30a4048@gmail.com"},"message":"test: use smaller input file for test-zlib.js\n\nPR-URL: https://github.com/nodejs/node/pull/17988\nFixes: https://github.com/nodejs/node/issues/17986\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>\nReviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/3456e61b44c707aae6e78f7e3ee2a49ee2703847"},{"sha":"f0a0fdd83ae4fa898fc1d48d6c7d7906f085b91a","author":{"name":"Rich Trott","email":"c1321c10e42359e7caa6e441829d03e9d30a4048@gmail.com"},"message":"doc: multiple updates to BUILDING.md\n\n* remove spaces around slash in BUILDING.md\n* hyphenate _end-of-life_ in BUILDING.md\n* add missing comma in BUILDING.md\n* add missing backticks in BUILDING.md\n* add missing comma to BUILDING.md\n\nPR-URL: https://github.com/nodejs/node/pull/17985\nReviewed-By: Richard Lau <riclau@uk.ibm.com>\nReviewed-By: Yuta Hiroto <hello@about-hiroppy.com>\nReviewed-By: Jon Moss <me@jonathanmoss.me>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/f0a0fdd83ae4fa898fc1d48d6c7d7906f085b91a"},{"sha":"a4ba7915663faaaaf86bbdfd87c4916087603b3a","author":{"name":"Anna Henningsen","email":"6ab69d5d0413b53c075e34a831dd9f590ea00ac1@addaleax.net"},"message":"benchmark: add JSStreamWrap benchmark\n\nThis is made to mirror the connection-bound net benchmarks.\n\nPR-URL: https://github.com/nodejs/node/pull/17983\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/a4ba7915663faaaaf86bbdfd87c4916087603b3a"},{"sha":"f693e81ee51d6da80280388f908425bc0e179b8a","author":{"name":"Jinho Bang","email":"862b9e2c1b1fc0a2468cdee5ed10d53d20536455@chromium.org"},"message":"n-api: throw RangeError in napi_create_dataview() with invalid range\n\nThe API is required that `byte_length + byte_offset` is less than or\nequal to the size in bytes of the array passed in. If not, a RangeError\nexception is raised[1].\n\n[1] https://nodejs.org/api/n-api.html#n_api_napi_create_dataview\n\nPR-URL: https://github.com/nodejs/node/pull/17869\nReviewed-By: Tiancheng \"Timothy\" Gu <timothygu99@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>\nReviewed-By: James M Snell <jasnell@gmail.com>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/f693e81ee51d6da80280388f908425bc0e179b8a"},{"sha":"7911b9b493cc6dbd7f8881478e90c0ba12b8cfd2","author":{"name":"Refael Ackermann","email":"32dbbc12802946e4055eb8c7855b3554704adeef@gmail.com"},"message":"doc: examples for fast-tracking regression fixes\n\nPR-URL: https://github.com/nodejs/node/pull/17379\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: Joyee Cheung <joyeec9h3@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/7911b9b493cc6dbd7f8881478e90c0ba12b8cfd2"},{"sha":"5ebd0178a6d13050dd111b107e3c157f079606a5","author":{"name":"James M Snell","email":"b0bb7a8fecaaa9b5986f6f19a6b09d78632bd248@gmail.com"},"message":"doc: add descriptions of state properties\n\nFixes: https://github.com/nodejs/node/issues/15268\n\nPR-URL: https://github.com/nodejs/node/pull/18044\nFixes: https://github.com/nodejs/node/issues/15268\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/5ebd0178a6d13050dd111b107e3c157f079606a5"},{"sha":"470832f2036b996d648bc8f783e9519359e82554","author":{"name":"Weijia Wang","email":"aaaf1b3b47f3a028b3036918c04fa39d3ca0ff30@qq.com"},"message":"path: fix path.normalize for relative paths\n\nAfter slicing, the `lastSegmentLength` should be calculated again,\ninstead of assigning value `j`.\n\nPR-URL: https://github.com/nodejs/node/pull/17974\nFixes: https://github.com/nodejs/node/issues/17928\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/470832f2036b996d648bc8f783e9519359e82554"},{"sha":"969c89bf553f30ea47359391eeb829aa3ac6c27d","author":{"name":"Yang Guo","email":"c18326b1b7bf9a80898d6a62a0518598412a77c0@chromium.org"},"message":"build: fix Makefile wrt finding node executable\n\nNot all shells set PWD, so use CURDIR instead.\n\n`which node` may return the empty string, so guard against\nthat too. Consider:\nif [ -x `which velociraptor` ] && [ -e `which velociprator` ];\\\nthen echo \"run\"; else echo \"keep calm\"; fi;\n\nPR-URL: https://github.com/nodejs/node/pull/18040\nReviewed-By: Evan Lucas <evanlucas@me.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Joyee Cheung <joyeec9h3@gmail.com>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/969c89bf553f30ea47359391eeb829aa3ac6c27d"},{"sha":"4bc4d004b1caf0ce0860efc0df20ab5366850169","author":{"name":"Michaël Zasso","email":"54d3360a79da4580550861cc3e6a4860bfea84be@protonmail.com"},"message":"tools: move eslint from tools to tools/node_modules\n\nThis is required because we need to add the babel-eslint dependency\nand it has to be able to resolve \"eslint\".\nbabel-eslint is required to support future ES features such as async\niterators and import.meta.\n\nRefs: https://github.com/nodejs/node/pull/17755\nPR-URL: https://github.com/nodejs/node/pull/17820\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/4bc4d004b1caf0ce0860efc0df20ab5366850169"},{"sha":"d349fcae115595a9514224b5a052477db782674c","author":{"name":"Michaël Zasso","email":"54d3360a79da4580550861cc3e6a4860bfea84be@protonmail.com"},"message":"tools: update ESLint to 4.15.0\n\nPR-URL: https://github.com/nodejs/node/pull/17820\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/d349fcae115595a9514224b5a052477db782674c"},{"sha":"715e673d06e8e92d416c1079c0db83d5dae9606c","author":{"name":"Michaël Zasso","email":"54d3360a79da4580550861cc3e6a4860bfea84be@protonmail.com"},"message":"tools: add babel-eslint\n\nCreate tools/update-babel-eslint.sh script and execute it to do the\nfirst installation of the package.\nUpdate tools/license-builder.sh and execute it to add babel-eslint's\nlicense to our LICENSE file.\n\nPR-URL: https://github.com/nodejs/node/pull/17820\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/715e673d06e8e92d416c1079c0db83d5dae9606c"},{"sha":"be9958afb6277003a57909b010cd4b796d57c131","author":{"name":"Michaël Zasso","email":"54d3360a79da4580550861cc3e6a4860bfea84be@protonmail.com"},"message":"tools: use babel-eslint as ESLint parser\n\nPR-URL: https://github.com/nodejs/node/pull/17820\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/be9958afb6277003a57909b010cd4b796d57c131"},{"sha":"5fccb6ea3a2e21e3aeb48359f58d068474873f65","author":{"name":"Tobias Nießen","email":"142a59064c43ef03d7bd9438a5ec1ccb9e13bf5b@tnie.de"},"message":"test: fix spelling in test case comments\n\nPR-URL: https://github.com/nodejs/node/pull/18018\nReviewed-By: Jon Moss <me@jonathanmoss.me>\nReviewed-By: Anatoli Papirovski <apapirovski@mac.com>\nReviewed-By: Weijia Wang <starkwang@126.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Yuta Hiroto <hello@about-hiroppy.com>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/5fccb6ea3a2e21e3aeb48359f58d068474873f65"},{"sha":"dcdb646ada01f03207ddec99e3c8b0ce8ab8e9f4","author":{"name":"Tobias Nießen","email":"142a59064c43ef03d7bd9438a5ec1ccb9e13bf5b@tnie.de"},"message":"lib: fix spelling in comments\n\nPR-URL: https://github.com/nodejs/node/pull/18018\nReviewed-By: Jon Moss <me@jonathanmoss.me>\nReviewed-By: Anatoli Papirovski <apapirovski@mac.com>\nReviewed-By: Weijia Wang <starkwang@126.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Yuta Hiroto <hello@about-hiroppy.com>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/dcdb646ada01f03207ddec99e3c8b0ce8ab8e9f4"},{"sha":"96b072233a361c46dc642b208ae64bd4293c3ec9","author":{"name":"Anna Henningsen","email":"6ab69d5d0413b53c075e34a831dd9f590ea00ac1@addaleax.net"},"message":"tls: refactor write queues away\n\nThe TLS implementation previously had two separate queues for\nWriteWrap instances, one for currently active and one for\nfinishing writes (i.e. where the encrypted output is being written\nto the underlying socket).\n\nHowever, the streams implementation in Node doesn’t allow for\nmore than one write to be active at a time; effectively,\nthe only possible states were that:\n\n- No write was active.\n- The first write queue had one item, the second one was empty.\n- Only the second write queue had one item, the first one was empty.\n\nTo reduce overhead and implementation complexity, remove these\nqueues, and instead store a single `WriteWrap` pointer and\nkeep track of whether its write callback should be called\non the next invocation of `InvokeQueued()` or not\n(which is what being in the second queue previously effected).\n\nPR-URL: https://github.com/nodejs/node/pull/17883\nReviewed-By: Ben Noordhuis <info@bnoordhuis.nl>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Tobias Nießen <tniessen@tnie.de>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/96b072233a361c46dc642b208ae64bd4293c3ec9"},{"sha":"de70a363ebf551d9dc0ad7253928fa3144843f2f","author":{"name":"Rich Trott","email":"c1321c10e42359e7caa6e441829d03e9d30a4048@gmail.com"},"message":"doc: be less tentative about undefined behavior\n\nIn the documentation for the buffer module, change instances of \"the\nresult is considered undefined behavior\" to \"the resulting behavior is\nundefined\". It's less ambiguous in meaning and less awkward\nstylistically.\n\nPR-URL: https://github.com/nodejs/node/pull/18091\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>\nReviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>\nReviewed-By: Minwoo Jung <minwoo@nodesource.com>\nReviewed-By: Khaidi Chu <i@2333.moe>\nReviewed-By: Tobias Nießen <tniessen@tnie.de>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/de70a363ebf551d9dc0ad7253928fa3144843f2f"},{"sha":"7706e5f1eaee5e880362d26615ad6e3d2d3e2aeb","author":{"name":"Kyle Farnung","email":"70e45da877e6a1c92d625c166354710e6230f2b3@microsoft.com"},"message":"test: remove orphaned entries from status\n\nPR-URL: https://github.com/nodejs/node/pull/18092\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>\nReviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>","distinct":false,"url":"https://api.github.com/repos/nodejs/node/commits/7706e5f1eaee5e880362d26615ad6e3d2d3e2aeb"}]}
{"actor":{"display_login":"evanlucas"}}