{"action":"created","issue":{"url":"https://api.github.com/repos/heroku/heroku-buildpack-nodejs/issues/531","repository_url":"https://api.github.com/repos/heroku/heroku-buildpack-nodejs","labels_url":"https://api.github.com/repos/heroku/heroku-buildpack-nodejs/issues/531/labels{/name}","comments_url":"https://api.github.com/repos/heroku/heroku-buildpack-nodejs/issues/531/comments","events_url":"https://api.github.com/repos/heroku/heroku-buildpack-nodejs/issues/531/events","html_url":"https://github.com/heroku/heroku-buildpack-nodejs/pull/531","id":302055558,"node_id":"MDExOlB1bGxSZXF1ZXN0MTcyNzAxNDA3","number":531,"title":"fix: handle case where memory.limit_in_bytes is nonsensically large","user":{"login":"josegonzalez","id":65675,"node_id":"MDQ6VXNlcjY1Njc1","avatar_url":"https://avatars2.githubusercontent.com/u/65675?v=4","gravatar_id":"","url":"https://api.github.com/users/josegonzalez","html_url":"https://github.com/josegonzalez","followers_url":"https://api.github.com/users/josegonzalez/followers","following_url":"https://api.github.com/users/josegonzalez/following{/other_user}","gists_url":"https://api.github.com/users/josegonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/josegonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josegonzalez/subscriptions","organizations_url":"https://api.github.com/users/josegonzalez/orgs","repos_url":"https://api.github.com/users/josegonzalez/repos","events_url":"https://api.github.com/users/josegonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/josegonzalez/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-04T04:07:35Z","updated_at":"2018-11-09T01:05:10Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/heroku/heroku-buildpack-nodejs/pulls/531","html_url":"https://github.com/heroku/heroku-buildpack-nodejs/pull/531","diff_url":"https://github.com/heroku/heroku-buildpack-nodejs/pull/531.diff","patch_url":"https://github.com/heroku/heroku-buildpack-nodejs/pull/531.patch"},"body":"In certain CI environments, this value can be misreported, resulting in an invalid initial `MEMORY_AVAILABLE` value.\r\n\r\n> Note: I have a client who has some deployments to Heroku but does not wish to use Heroku CI and currently deploys to GCP, so this fix is so that their CI doesn't throw warnings when they run on servers with 16GB+ memory."},"comment":{"url":"https://api.github.com/repos/heroku/heroku-buildpack-nodejs/issues/comments/437213084","html_url":"https://github.com/heroku/heroku-buildpack-nodejs/pull/531#issuecomment-437213084","issue_url":"https://api.github.com/repos/heroku/heroku-buildpack-nodejs/issues/531","id":437213084,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzIxMzA4NA==","user":{"login":"jmorrell","id":175496,"node_id":"MDQ6VXNlcjE3NTQ5Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/175496?v=4","gravatar_id":"","url":"https://api.github.com/users/jmorrell","html_url":"https://github.com/jmorrell","followers_url":"https://api.github.com/users/jmorrell/followers","following_url":"https://api.github.com/users/jmorrell/following{/other_user}","gists_url":"https://api.github.com/users/jmorrell/gists{/gist_id}","starred_url":"https://api.github.com/users/jmorrell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmorrell/subscriptions","organizations_url":"https://api.github.com/users/jmorrell/orgs","repos_url":"https://api.github.com/users/jmorrell/repos","events_url":"https://api.github.com/users/jmorrell/events{/privacy}","received_events_url":"https://api.github.com/users/jmorrell/received_events","type":"User","site_admin":false},"created_at":"2018-11-09T01:05:10Z","updated_at":"2018-11-09T01:05:10Z","author_association":"CONTRIBUTOR","body":"Hi @josegonzalez, sorry for letting this sit for so long.\r\n\r\nCan you tell me more about how this works? How does `\"$(cat /sys/fs/cgroup/memory/memory.limit_in_bytes)\"` being very large trigger the `||` expression here?\r\n\r\nI'm not sure how to test this, but tests would help give me confidence here. Maybe make `\"$(cat /sys/fs/cgroup/memory/memory.limit_in_bytes)\"` an input to the function?"}}
{"actor":{"display_login":"jmorrell"}}