{"action":"created","issue":{"url":"https://api.github.com/repos/tokio-rs/tokio/issues/649","repository_url":"https://api.github.com/repos/tokio-rs/tokio","labels_url":"https://api.github.com/repos/tokio-rs/tokio/issues/649/labels{/name}","comments_url":"https://api.github.com/repos/tokio-rs/tokio/issues/649/comments","events_url":"https://api.github.com/repos/tokio-rs/tokio/issues/649/events","html_url":"https://github.com/tokio-rs/tokio/pull/649","id":361641795,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NTU5MzY4","number":649,"title":"threadpool: impl Drop for Queue","user":{"login":"stjepang","id":1303843,"node_id":"MDQ6VXNlcjEzMDM4NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1303843?v=4","gravatar_id":"","url":"https://api.github.com/users/stjepang","html_url":"https://github.com/stjepang","followers_url":"https://api.github.com/users/stjepang/followers","following_url":"https://api.github.com/users/stjepang/following{/other_user}","gists_url":"https://api.github.com/users/stjepang/gists{/gist_id}","starred_url":"https://api.github.com/users/stjepang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stjepang/subscriptions","organizations_url":"https://api.github.com/users/stjepang/orgs","repos_url":"https://api.github.com/users/stjepang/repos","events_url":"https://api.github.com/users/stjepang/events{/privacy}","received_events_url":"https://api.github.com/users/stjepang/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-09-19T08:46:19Z","updated_at":"2018-09-21T17:20:24Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/tokio-rs/tokio/pulls/649","html_url":"https://github.com/tokio-rs/tokio/pull/649","diff_url":"https://github.com/tokio-rs/tokio/pull/649.diff","patch_url":"https://github.com/tokio-rs/tokio/pull/649.patch"},"body":"We need to drain the queue when dropping, or else those `Arc<Task>`s\r\nwill be leaked.\r\n\r\nThis seems to fix #542."},"comment":{"url":"https://api.github.com/repos/tokio-rs/tokio/issues/comments/423611125","html_url":"https://github.com/tokio-rs/tokio/pull/649#issuecomment-423611125","issue_url":"https://api.github.com/repos/tokio-rs/tokio/issues/649","id":423611125,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzYxMTEyNQ==","user":{"login":"carllerche","id":6180,"node_id":"MDQ6VXNlcjYxODA=","avatar_url":"https://avatars3.githubusercontent.com/u/6180?v=4","gravatar_id":"","url":"https://api.github.com/users/carllerche","html_url":"https://github.com/carllerche","followers_url":"https://api.github.com/users/carllerche/followers","following_url":"https://api.github.com/users/carllerche/following{/other_user}","gists_url":"https://api.github.com/users/carllerche/gists{/gist_id}","starred_url":"https://api.github.com/users/carllerche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carllerche/subscriptions","organizations_url":"https://api.github.com/users/carllerche/orgs","repos_url":"https://api.github.com/users/carllerche/repos","events_url":"https://api.github.com/users/carllerche/events{/privacy}","received_events_url":"https://api.github.com/users/carllerche/received_events","type":"User","site_admin":false},"created_at":"2018-09-21T17:20:24Z","updated_at":"2018-09-21T17:20:24Z","author_association":"MEMBER","body":"It doesn't solve #428 because that is the reverse problem: the pool doesn't hold a reference to the future so it can't force it to drop (clear it from the Arc)."}}
{"actor":{"display_login":"carllerche"}}