{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/20878","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/20878/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/20878/comments","events_url":"https://api.github.com/repos/apache/spark/issues/20878/events","html_url":"https://github.com/apache/spark/pull/20878","id":307548595,"number":20878,"title":"[MINOR][PYTHON] Remove unused codes in schema parsing logics of PySpark","user":{"login":"HyukjinKwon","id":6477701,"avatar_url":"https://avatars0.githubusercontent.com/u/6477701?v=4","gravatar_id":"","url":"https://api.github.com/users/HyukjinKwon","html_url":"https://github.com/HyukjinKwon","followers_url":"https://api.github.com/users/HyukjinKwon/followers","following_url":"https://api.github.com/users/HyukjinKwon/following{/other_user}","gists_url":"https://api.github.com/users/HyukjinKwon/gists{/gist_id}","starred_url":"https://api.github.com/users/HyukjinKwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HyukjinKwon/subscriptions","organizations_url":"https://api.github.com/users/HyukjinKwon/orgs","repos_url":"https://api.github.com/users/HyukjinKwon/repos","events_url":"https://api.github.com/users/HyukjinKwon/events{/privacy}","received_events_url":"https://api.github.com/users/HyukjinKwon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-22T08:36:00Z","updated_at":"2018-03-23T04:21:04Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/20878","html_url":"https://github.com/apache/spark/pull/20878","diff_url":"https://github.com/apache/spark/pull/20878.diff","patch_url":"https://github.com/apache/spark/pull/20878.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nThis PR proposes to remove out unused codes, `_ignore_brackets_split` and `_BRACKETS`.\r\n\r\n`_ignore_brackets_split` was introduced in https://github.com/apache/spark/commit/d57daf1f7732a7ac54a91fe112deeda0a254f9ef to refactor and support `toDF(\"...\")`; however, https://github.com/apache/spark/commit/ebc124d4c44d4c84f7868f390f778c0ff5cd66cb replaced the logics here. Seems `_ignore_brackets_split` is not referred anymore.\r\n\r\n`_BRACKETS` was introduced in https://github.com/apache/spark/commit/880eabec37c69ce4e9594d7babfac291b0f93f50; however, all other usages were removed out in https://github.com/apache/spark/commit/648a8626b82d27d84db3e48bccfd73d020828586.\r\n\r\nThis is rather a followup for https://github.com/apache/spark/commit/ebc124d4c44d4c84f7868f390f778c0ff5cd66cb which I missed in that PR.\r\n\r\n## How was this patch tested?\r\n\r\nManually tested. Existing tests should cover this. I also double checked by `grep` in the whole repo.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/375540500","html_url":"https://github.com/apache/spark/pull/20878#issuecomment-375540500","issue_url":"https://api.github.com/repos/apache/spark/issues/20878","id":375540500,"user":{"login":"cloud-fan","id":3182036,"avatar_url":"https://avatars3.githubusercontent.com/u/3182036?v=4","gravatar_id":"","url":"https://api.github.com/users/cloud-fan","html_url":"https://github.com/cloud-fan","followers_url":"https://api.github.com/users/cloud-fan/followers","following_url":"https://api.github.com/users/cloud-fan/following{/other_user}","gists_url":"https://api.github.com/users/cloud-fan/gists{/gist_id}","starred_url":"https://api.github.com/users/cloud-fan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloud-fan/subscriptions","organizations_url":"https://api.github.com/users/cloud-fan/orgs","repos_url":"https://api.github.com/users/cloud-fan/repos","events_url":"https://api.github.com/users/cloud-fan/events{/privacy}","received_events_url":"https://api.github.com/users/cloud-fan/received_events","type":"User","site_admin":false},"created_at":"2018-03-23T04:21:04Z","updated_at":"2018-03-23T04:21:04Z","author_association":"CONTRIBUTOR","body":"thanks, merging to master!"}}
{"actor":{"display_login":"cloud-fan"}}