{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/49033","repository_url":"https://api.github.com/repos/ansible/ansible","labels_url":"https://api.github.com/repos/ansible/ansible/issues/49033/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/49033/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/49033/events","html_url":"https://github.com/ansible/ansible/pull/49033","id":383633555,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDU2MjYy","number":49033,"title":"Add service discovery registry","user":{"login":"ezmac","id":810629,"node_id":"MDQ6VXNlcjgxMDYyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/810629?v=4","gravatar_id":"","url":"https://api.github.com/users/ezmac","html_url":"https://github.com/ezmac","followers_url":"https://api.github.com/users/ezmac/followers","following_url":"https://api.github.com/users/ezmac/following{/other_user}","gists_url":"https://api.github.com/users/ezmac/gists{/gist_id}","starred_url":"https://api.github.com/users/ezmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezmac/subscriptions","organizations_url":"https://api.github.com/users/ezmac/orgs","repos_url":"https://api.github.com/users/ezmac/repos","events_url":"https://api.github.com/users/ezmac/events{/privacy}","received_events_url":"https://api.github.com/users/ezmac/received_events","type":"User","site_admin":false},"labels":[{"id":1043397454,"node_id":"MDU6TGFiZWwxMDQzMzk3NDU0","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.8","name":"affects_2.8","color":"ededed","default":false},{"id":379680333,"node_id":"MDU6TGFiZWwzNzk2ODAzMzM=","url":"https://api.github.com/repos/ansible/ansible/labels/aws","name":"aws","color":"c5def5","default":false},{"id":61528803,"node_id":"MDU6TGFiZWw2MTUyODgwMw==","url":"https://api.github.com/repos/ansible/ansible/labels/cloud","name":"cloud","color":"c7def8","default":false},{"id":501518759,"node_id":"MDU6TGFiZWw1MDE1MTg3NTk=","url":"https://api.github.com/repos/ansible/ansible/labels/community_review","name":"community_review","color":"f9d0c4","default":false},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":503572087,"node_id":"MDU6TGFiZWw1MDM1NzIwODc=","url":"https://api.github.com/repos/ansible/ansible/labels/needs_triage","name":"needs_triage","color":"0e8a16","default":false},{"id":723150340,"node_id":"MDU6TGFiZWw3MjMxNTAzNDA=","url":"https://api.github.com/repos/ansible/ansible/labels/new_contributor","name":"new_contributor","color":"c2e0c6","default":false},{"id":473225334,"node_id":"MDU6TGFiZWw0NzMyMjUzMzQ=","url":"https://api.github.com/repos/ansible/ansible/labels/new_module","name":"new_module","color":"c2e0c6","default":false},{"id":153577825,"node_id":"MDU6TGFiZWwxNTM1Nzc4MjU=","url":"https://api.github.com/repos/ansible/ansible/labels/new_plugin","name":"new_plugin","color":"bfe5bf","default":false},{"id":636327968,"node_id":"MDU6TGFiZWw2MzYzMjc5Njg=","url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-22T18:42:21Z","updated_at":"2018-11-22T18:52:13Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/49033","html_url":"https://github.com/ansible/ansible/pull/49033","diff_url":"https://github.com/ansible/ansible/pull/49033.diff","patch_url":"https://github.com/ansible/ansible/pull/49033.patch"},"body":"##### SUMMARY\r\n<!--- Describe the change below, including rationale and design decisions -->\r\nAdds service discovery registry module. \r\n\r\nService discovery is part of route53.  A service discovery namespace is a hosted zone in route53.  Once the namespace exists, registries can be created within that namespace.  This module handles only the registries.  https://github.com/ansible/ansible/pull/48764 handles namespaces\r\n\r\nTests were written for both, but with the single module per PR rule, they were disabled for this commit.\r\n\r\nIn this particular commit (7cf7c97d), I'm using the route53_facts module to see if there is a hosted zone in the CI environment that can be used to run tests before the namespace module exists.  If there isn't, I will remove that test and mark them as unsupported.\r\n\r\n<!--- HINT: Include \"Fixes #nnn\" if you are fixing an existing issue -->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest -->\r\n- New Module Pull Request\r\n\r\n##### COMPONENT NAME\r\n<!--- Write the short name of the module, plugin, task or feature below -->\r\nservice_discovery_registry\r\n\r\n##### ADDITIONAL INFORMATION\r\n<!--- Include additional information to help people understand the change here -->\r\n<!--- A step-by-step reproduction of the problem is helpful if there is no related issue -->\r\n\r\n<!--- Paste verbatim command output below, e.g. before and after your change -->\r\n```paste below\r\n\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/441103614","html_url":"https://github.com/ansible/ansible/pull/49033#issuecomment-441103614","issue_url":"https://api.github.com/repos/ansible/ansible/issues/49033","id":441103614,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTEwMzYxNA==","user":{"login":"ansibot","id":6585283,"node_id":"MDQ6VXNlcjY1ODUyODM=","avatar_url":"https://avatars0.githubusercontent.com/u/6585283?v=4","gravatar_id":"","url":"https://api.github.com/users/ansibot","html_url":"https://github.com/ansibot","followers_url":"https://api.github.com/users/ansibot/followers","following_url":"https://api.github.com/users/ansibot/following{/other_user}","gists_url":"https://api.github.com/users/ansibot/gists{/gist_id}","starred_url":"https://api.github.com/users/ansibot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansibot/subscriptions","organizations_url":"https://api.github.com/users/ansibot/orgs","repos_url":"https://api.github.com/users/ansibot/repos","events_url":"https://api.github.com/users/ansibot/events{/privacy}","received_events_url":"https://api.github.com/users/ansibot/received_events","type":"User","site_admin":false},"created_at":"2018-11-22T18:52:13Z","updated_at":"2018-11-22T18:52:13Z","author_association":"CONTRIBUTOR","body":"@Constantin007 @Constantin07 @Deepakkothandan @Etherdaemon @Java1Guy @Madhura-CSI @MichaelBaydoun @Sodki @Zeekin @adq @akazakov @alachaum @amir343 @anryko @bekelchik @bpennypacker @brandond @chenl87 @defunctio @dennisconrad @dkhenry @fiunchinho @fivethreeo @flowerysong @garethr @gobins @gunzy83 @gurumaia @hsingh @hyperized @iiibrad @infectsoldier @j-carl @jarv @java1guy @jimbydamonk @jmenga @joelthompson @jonhadfield @jonmer85 @joshsouza @jsdalton @jsmartin @kaczynskid @leedm777 @linuxdynasty @loia @lwade @michaeljs1990 @minichate @mjschultz @mmochan @nand0p @naslanidis @nathanwebsterdotme @nerzhul @nickball @orthanc @ozbillwang @piontas @pjodouin @prasadkatti @psykotox @ptux @pwnall @raags @rickmendes @roadmapper @ryansb @ryansydnor @scicoin-project @scottanderson42 @sdubrul @shepdelacreme @silviud @skvidal @slapula @steynovich @tastychutney @tedder @tgerla @timmahoney @tombamford @tomislacker @tsiganenok @viper233 @whiter @willricardo @wilvk @wimnat @yaakov-github @zacblazic @zbal @zimbatm\n\n\nAs a maintainer of a module in the same namespace this new module has been submitted to, your vote counts for shipits. Please review this module and add `shipit` if you would like to see it merged.\n\n[click here for bot help](https://github.com/ansible/ansibullbot/blob/master/ISSUE_HELP.md)\n<!--- boilerplate: community_shipit_notify --->"}}
{"actor":{"display_login":"ansibot"}}