{"action":"created","issue":{"url":"https://api.github.com/repos/spring-projects/spring-security/issues/4841","repository_url":"https://api.github.com/repos/spring-projects/spring-security","labels_url":"https://api.github.com/repos/spring-projects/spring-security/issues/4841/labels{/name}","comments_url":"https://api.github.com/repos/spring-projects/spring-security/issues/4841/comments","events_url":"https://api.github.com/repos/spring-projects/spring-security/issues/4841/events","html_url":"https://github.com/spring-projects/spring-security/issues/4841","id":274671528,"node_id":"MDU6SXNzdWUyNzQ2NzE1Mjg=","number":4841,"title":"Support Mono<Boolean> for Method Security","user":{"login":"rwinch","id":362503,"node_id":"MDQ6VXNlcjM2MjUwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/362503?v=4","gravatar_id":"","url":"https://api.github.com/users/rwinch","html_url":"https://github.com/rwinch","followers_url":"https://api.github.com/users/rwinch/followers","following_url":"https://api.github.com/users/rwinch/following{/other_user}","gists_url":"https://api.github.com/users/rwinch/gists{/gist_id}","starred_url":"https://api.github.com/users/rwinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwinch/subscriptions","organizations_url":"https://api.github.com/users/rwinch/orgs","repos_url":"https://api.github.com/users/rwinch/repos","events_url":"https://api.github.com/users/rwinch/events{/privacy}","received_events_url":"https://api.github.com/users/rwinch/received_events","type":"User","site_admin":false},"labels":[{"id":322225045,"node_id":"MDU6TGFiZWwzMjIyMjUwNDU=","url":"https://api.github.com/repos/spring-projects/spring-security/labels/Core","name":"Core","color":"000000","default":false},{"id":322225080,"node_id":"MDU6TGFiZWwzMjIyMjUwODA=","url":"https://api.github.com/repos/spring-projects/spring-security/labels/New%20Feature","name":"New Feature","color":"eeeeee","default":false},{"id":516101141,"node_id":"MDU6TGFiZWw1MTYxMDExNDE=","url":"https://api.github.com/repos/spring-projects/spring-security/labels/Reactive","name":"Reactive","color":"000000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-11-16T21:33:55Z","updated_at":"2018-10-10T17:11:46Z","closed_at":null,"author_association":"MEMBER","body":"### Summary\r\n\r\nReactive method security requires a method return Boolean which does not work of the logic to determine access is blocking. We should allow the result to be `Mono<Boolean>`"},"comment":{"url":"https://api.github.com/repos/spring-projects/spring-security/issues/comments/428654334","html_url":"https://github.com/spring-projects/spring-security/issues/4841#issuecomment-428654334","issue_url":"https://api.github.com/repos/spring-projects/spring-security/issues/4841","id":428654334,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODY1NDMzNA==","user":{"login":"rwinch","id":362503,"node_id":"MDQ6VXNlcjM2MjUwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/362503?v=4","gravatar_id":"","url":"https://api.github.com/users/rwinch","html_url":"https://github.com/rwinch","followers_url":"https://api.github.com/users/rwinch/followers","following_url":"https://api.github.com/users/rwinch/following{/other_user}","gists_url":"https://api.github.com/users/rwinch/gists{/gist_id}","starred_url":"https://api.github.com/users/rwinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwinch/subscriptions","organizations_url":"https://api.github.com/users/rwinch/orgs","repos_url":"https://api.github.com/users/rwinch/repos","events_url":"https://api.github.com/users/rwinch/events{/privacy}","received_events_url":"https://api.github.com/users/rwinch/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T17:11:46Z","updated_at":"2018-10-10T17:11:46Z","author_association":"MEMBER","body":"> Isn't PrePostAdviceReactiveMethodInterceptor already reactive? \r\n\r\nYou are right but it would need to accept the reactive advice.\r\n\r\n> Would it be better to create a new version of PrePostAdviceReactiveMethodInterceptor or to modify the existing one to support the reactive pre/post advice classes?\r\n\r\nModify the existing one, deprecate the existing constructor (modify it to just adapt to use the reactive APIs to simplify the code), add a new constructor w/ reactive equivalents\r\n\r\n> Would you be open to a PR for this or is it something you are already actively working on?\r\n\r\nI'd love a PR for this."}}
{"actor":{"display_login":"rwinch"}}