{"action":"created","comment":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/comments/231707145","pull_request_review_id":172735877,"id":231707145,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTcwNzE0NQ==","diff_hunk":"@@ -21,6 +21,8 @@ const (\n \texpiredCertGrace = 24 * time.Hour * 7\n \t// inbuilt default subnet size\n \tinbuiltSubnetSize = 24\n+\t// VxLan default port\n+\tdefaultVxlanPort = 4789","path":"manager/controlapi/cluster.go","position":5,"original_position":5,"commit_id":"c66b4acec11a069c8a62cc0eff6121f0c5165a12","original_commit_id":"80e5f7ebc3398e0f33f4e53c6028030f53518294","user":{"login":"wk8","id":2536231,"node_id":"MDQ6VXNlcjI1MzYyMzE=","avatar_url":"https://avatars3.githubusercontent.com/u/2536231?v=4","gravatar_id":"","url":"https://api.github.com/users/wk8","html_url":"https://github.com/wk8","followers_url":"https://api.github.com/users/wk8/followers","following_url":"https://api.github.com/users/wk8/following{/other_user}","gists_url":"https://api.github.com/users/wk8/gists{/gist_id}","starred_url":"https://api.github.com/users/wk8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wk8/subscriptions","organizations_url":"https://api.github.com/users/wk8/orgs","repos_url":"https://api.github.com/users/wk8/repos","events_url":"https://api.github.com/users/wk8/events{/privacy}","received_events_url":"https://api.github.com/users/wk8/received_events","type":"User","site_admin":false},"body":"Couldn't we define that constant in libnetwork and expose it publicly in that package so that it's only defined in one place?","created_at":"2018-11-07T22:44:43Z","updated_at":"2018-11-07T22:48:09Z","html_url":"https://github.com/docker/swarmkit/pull/2772#discussion_r231707145","pull_request_url":"https://api.github.com/repos/docker/swarmkit/pulls/2772","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments/231707145"},"html":{"href":"https://github.com/docker/swarmkit/pull/2772#discussion_r231707145"},"pull_request":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/2772"}},"in_reply_to_id":231207247},"pull_request":{"url":"https://api.github.com/repos/docker/swarmkit/pulls/2772","id":226712573,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NzEyNTcz","html_url":"https://github.com/docker/swarmkit/pull/2772","diff_url":"https://github.com/docker/swarmkit/pull/2772.diff","patch_url":"https://github.com/docker/swarmkit/pull/2772.patch","issue_url":"https://api.github.com/repos/docker/swarmkit/issues/2772","number":2772,"state":"open","locked":false,"title":" VXLAN UDP Port configuration support","user":{"login":"selansen","id":10554015,"node_id":"MDQ6VXNlcjEwNTU0MDE1","avatar_url":"https://avatars3.githubusercontent.com/u/10554015?v=4","gravatar_id":"","url":"https://api.github.com/users/selansen","html_url":"https://github.com/selansen","followers_url":"https://api.github.com/users/selansen/followers","following_url":"https://api.github.com/users/selansen/following{/other_user}","gists_url":"https://api.github.com/users/selansen/gists{/gist_id}","starred_url":"https://api.github.com/users/selansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selansen/subscriptions","organizations_url":"https://api.github.com/users/selansen/orgs","repos_url":"https://api.github.com/users/selansen/repos","events_url":"https://api.github.com/users/selansen/events{/privacy}","received_events_url":"https://api.github.com/users/selansen/received_events","type":"User","site_admin":false},"body":"    This PR chnages allow user to configure VxLAN UDP\r\n    port number. By default we use 4789 port number. But this commit\r\n    will allow user to configure port number during swarm init.\r\n    VxLAN port can't be modified after swarm init.\r\n\r\nSigned-off-by: selansen <elango.siva@docker.com>\r\n\r\n<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/docker/swarmkit/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\n\r\n**- How I did it**\r\n\r\n**- How to test it**\r\n\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n","created_at":"2018-10-29T21:02:36Z","updated_at":"2018-11-07T22:48:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1d747e45e56d90de5895d728419b5a1ba40d03d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/swarmkit/pulls/2772/commits","review_comments_url":"https://api.github.com/repos/docker/swarmkit/pulls/2772/comments","review_comment_url":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/swarmkit/issues/2772/comments","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/c66b4acec11a069c8a62cc0eff6121f0c5165a12","head":{"label":"selansen:master","ref":"master","sha":"c66b4acec11a069c8a62cc0eff6121f0c5165a12","user":{"login":"selansen","id":10554015,"node_id":"MDQ6VXNlcjEwNTU0MDE1","avatar_url":"https://avatars3.githubusercontent.com/u/10554015?v=4","gravatar_id":"","url":"https://api.github.com/users/selansen","html_url":"https://github.com/selansen","followers_url":"https://api.github.com/users/selansen/followers","following_url":"https://api.github.com/users/selansen/following{/other_user}","gists_url":"https://api.github.com/users/selansen/gists{/gist_id}","starred_url":"https://api.github.com/users/selansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selansen/subscriptions","organizations_url":"https://api.github.com/users/selansen/orgs","repos_url":"https://api.github.com/users/selansen/repos","events_url":"https://api.github.com/users/selansen/events{/privacy}","received_events_url":"https://api.github.com/users/selansen/received_events","type":"User","site_admin":false},"repo":{"id":142243930,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIyNDM5MzA=","name":"swarmkit","full_name":"selansen/swarmkit","private":false,"owner":{"login":"selansen","id":10554015,"node_id":"MDQ6VXNlcjEwNTU0MDE1","avatar_url":"https://avatars3.githubusercontent.com/u/10554015?v=4","gravatar_id":"","url":"https://api.github.com/users/selansen","html_url":"https://github.com/selansen","followers_url":"https://api.github.com/users/selansen/followers","following_url":"https://api.github.com/users/selansen/following{/other_user}","gists_url":"https://api.github.com/users/selansen/gists{/gist_id}","starred_url":"https://api.github.com/users/selansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/selansen/subscriptions","organizations_url":"https://api.github.com/users/selansen/orgs","repos_url":"https://api.github.com/users/selansen/repos","events_url":"https://api.github.com/users/selansen/events{/privacy}","received_events_url":"https://api.github.com/users/selansen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/selansen/swarmkit","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":true,"url":"https://api.github.com/repos/selansen/swarmkit","forks_url":"https://api.github.com/repos/selansen/swarmkit/forks","keys_url":"https://api.github.com/repos/selansen/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/selansen/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/selansen/swarmkit/teams","hooks_url":"https://api.github.com/repos/selansen/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/selansen/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/selansen/swarmkit/events","assignees_url":"https://api.github.com/repos/selansen/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/selansen/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/selansen/swarmkit/tags","blobs_url":"https://api.github.com/repos/selansen/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/selansen/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/selansen/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/selansen/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/selansen/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/selansen/swarmkit/languages","stargazers_url":"https://api.github.com/repos/selansen/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/selansen/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/selansen/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/selansen/swarmkit/subscription","commits_url":"https://api.github.com/repos/selansen/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/selansen/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/selansen/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/selansen/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/selansen/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/selansen/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/selansen/swarmkit/merges","archive_url":"https://api.github.com/repos/selansen/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/selansen/swarmkit/downloads","issues_url":"https://api.github.com/repos/selansen/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/selansen/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/selansen/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/selansen/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/selansen/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/selansen/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/selansen/swarmkit/deployments","created_at":"2018-07-25T03:43:34Z","updated_at":"2018-11-07T20:17:10Z","pushed_at":"2018-11-07T20:17:07Z","git_url":"git://github.com/selansen/swarmkit.git","ssh_url":"git@github.com:selansen/swarmkit.git","clone_url":"https://github.com/selansen/swarmkit.git","svn_url":"https://github.com/selansen/swarmkit","homepage":"","size":22068,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"69319523f621057d6d697801835eb16327f9ba98","user":{"login":"docker","id":5429470,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0Mjk0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/5429470?v=4","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":51556828,"node_id":"MDEwOlJlcG9zaXRvcnk1MTU1NjgyOA==","name":"swarmkit","full_name":"docker/swarmkit","private":false,"owner":{"login":"docker","id":5429470,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0Mjk0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/5429470?v=4","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/docker/swarmkit","description":"A toolkit for orchestrating distributed systems at any scale. It includes primitives for node discovery, raft-based consensus, task scheduling and more.","fork":false,"url":"https://api.github.com/repos/docker/swarmkit","forks_url":"https://api.github.com/repos/docker/swarmkit/forks","keys_url":"https://api.github.com/repos/docker/swarmkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/swarmkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/swarmkit/teams","hooks_url":"https://api.github.com/repos/docker/swarmkit/hooks","issue_events_url":"https://api.github.com/repos/docker/swarmkit/issues/events{/number}","events_url":"https://api.github.com/repos/docker/swarmkit/events","assignees_url":"https://api.github.com/repos/docker/swarmkit/assignees{/user}","branches_url":"https://api.github.com/repos/docker/swarmkit/branches{/branch}","tags_url":"https://api.github.com/repos/docker/swarmkit/tags","blobs_url":"https://api.github.com/repos/docker/swarmkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/swarmkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/swarmkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/swarmkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/swarmkit/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/swarmkit/languages","stargazers_url":"https://api.github.com/repos/docker/swarmkit/stargazers","contributors_url":"https://api.github.com/repos/docker/swarmkit/contributors","subscribers_url":"https://api.github.com/repos/docker/swarmkit/subscribers","subscription_url":"https://api.github.com/repos/docker/swarmkit/subscription","commits_url":"https://api.github.com/repos/docker/swarmkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/swarmkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/swarmkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/swarmkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/swarmkit/contents/{+path}","compare_url":"https://api.github.com/repos/docker/swarmkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/swarmkit/merges","archive_url":"https://api.github.com/repos/docker/swarmkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/swarmkit/downloads","issues_url":"https://api.github.com/repos/docker/swarmkit/issues{/number}","pulls_url":"https://api.github.com/repos/docker/swarmkit/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/swarmkit/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/swarmkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/swarmkit/labels{/name}","releases_url":"https://api.github.com/repos/docker/swarmkit/releases{/id}","deployments_url":"https://api.github.com/repos/docker/swarmkit/deployments","created_at":"2016-02-12T00:02:15Z","updated_at":"2018-11-07T16:56:44Z","pushed_at":"2018-11-07T20:17:09Z","git_url":"git://github.com/docker/swarmkit.git","ssh_url":"git@github.com:docker/swarmkit.git","clone_url":"https://github.com/docker/swarmkit.git","svn_url":"https://github.com/docker/swarmkit","homepage":"","size":22102,"stargazers_count":1885,"watchers_count":1885,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":431,"mirror_url":null,"archived":false,"open_issues_count":253,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":431,"open_issues":253,"watchers":1885,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/2772"},"html":{"href":"https://github.com/docker/swarmkit/pull/2772"},"issue":{"href":"https://api.github.com/repos/docker/swarmkit/issues/2772"},"comments":{"href":"https://api.github.com/repos/docker/swarmkit/issues/2772/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/2772/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/swarmkit/pulls/2772/commits"},"statuses":{"href":"https://api.github.com/repos/docker/swarmkit/statuses/c66b4acec11a069c8a62cc0eff6121f0c5165a12"}},"author_association":"NONE"}}
{"actor":{"display_login":"wk8"}}