{"push_id":2861732449,"size":1,"distinct_size":1,"ref":"refs/heads/radon-cm-mm-rebase","head":"b0585b8d8ac3f51e71986edf0f87a5d5fde57bb8","before":"fafca7af9dfe52c8c26cc89c12af0e89aee33e1b","commits":[{"sha":"b0585b8d8ac3f51e71986edf0f87a5d5fde57bb8","author":{"name":"Guillaume Nault","email":"c9cf31cb6c9821bed82e940f06145b026ca536b5@alphalink.fr"},"message":"l2tp: pass tunnel pointer to ->session_create()\n\nUsing l2tp_tunnel_find() in pppol2tp_session_create() and\nl2tp_eth_create() is racy, because no reference is held on the\nreturned session. These functions are only used to implement the\n->session_create callback which is run by l2tp_nl_cmd_session_create().\nTherefore searching for the parent tunnel isn't necessary because\nl2tp_nl_cmd_session_create() already has a pointer to it and holds a\nreference.\n\nThis patch modifies ->session_create()'s prototype to directly pass the\nthe parent tunnel as parameter, thus avoiding searching for it in\npppol2tp_session_create() and l2tp_eth_create().\n\nSince we have to touch the ->session_create() call in\nl2tp_nl_cmd_session_create(), let's also remove the useless conditional:\nwe know that ->session_create isn't NULL at this point because it's\nalready been checked earlier in this same function.\n\nFinally, one might be tempted to think that the removed\nl2tp_tunnel_find() calls were harmless because they would return the\nsame tunnel as the one held by l2tp_nl_cmd_session_create() anyway.\nBut that tunnel might be removed and a new one created with same tunnel\nId before the l2tp_tunnel_find() call. In this case l2tp_tunnel_find()\nwould return the new tunnel which wouldn't be protected by the\nreference held by l2tp_nl_cmd_session_create().\n\nFixes: 309795f4bec2 (\"l2tp: Add netlink control API for L2TP\")\nFixes: d9e31d17ceba (\"l2tp: Add L2TP ethernet pseudowire support\")\nSigned-off-by: Guillaume Nault <g.nault@alphalink.fr>\nSigned-off-by: David S. Miller <davem@davemloft.net>","distinct":true,"url":"https://api.github.com/repos/gismoZ/SecuRadon/commits/b0585b8d8ac3f51e71986edf0f87a5d5fde57bb8"}]}
{"actor":{"display_login":"gismoZ"}}