{"action":"created","issue":{"url":"https://api.github.com/repos/guardian/frontend/issues/19905","repository_url":"https://api.github.com/repos/guardian/frontend","labels_url":"https://api.github.com/repos/guardian/frontend/issues/19905/labels{/name}","comments_url":"https://api.github.com/repos/guardian/frontend/issues/19905/comments","events_url":"https://api.github.com/repos/guardian/frontend/issues/19905/events","html_url":"https://github.com/guardian/frontend/pull/19905","id":335466628,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MTU4Njky","number":19905,"title":"Don't load carrot traffic driver when ad free","user":{"login":"JustinPinner","id":690395,"node_id":"MDQ6VXNlcjY5MDM5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/690395?v=4","gravatar_id":"","url":"https://api.github.com/users/JustinPinner","html_url":"https://github.com/JustinPinner","followers_url":"https://api.github.com/users/JustinPinner/followers","following_url":"https://api.github.com/users/JustinPinner/following{/other_user}","gists_url":"https://api.github.com/users/JustinPinner/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinPinner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinPinner/subscriptions","organizations_url":"https://api.github.com/users/JustinPinner/orgs","repos_url":"https://api.github.com/users/JustinPinner/repos","events_url":"https://api.github.com/users/JustinPinner/events{/privacy}","received_events_url":"https://api.github.com/users/JustinPinner/received_events","type":"User","site_admin":false},"labels":[{"id":512259700,"node_id":"MDU6TGFiZWw1MTIyNTk3MDA=","url":"https://api.github.com/repos/guardian/frontend/labels/Seen-on-PROD","name":"Seen-on-PROD","color":"bfe5bf","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-25T15:51:54Z","updated_at":"2018-06-26T13:37:46Z","closed_at":"2018-06-26T13:19:52Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/guardian/frontend/pulls/19905","html_url":"https://github.com/guardian/frontend/pull/19905","diff_url":"https://github.com/guardian/frontend/pull/19905.diff","patch_url":"https://github.com/guardian/frontend/pull/19905.patch"},"body":"## What does this change?\r\nThe carrot traffic driver module (!) that creates new DFP ad-slots in pages is being loaded unnecessarily in ad-free mode. It's dependent on `articleBodyAdverts` which itself is sensitive to the ad-free state, and so would never run anyway.\r\n\r\nThis PR moves the module loading into the specifically not  ad-free group so we don't waste time spinning it up. It also makes sure that `carrotTrafficDriver` is independently sensitive to ad-free so that any future changes to the relationship with `articleBodyAdverts` won't have any unexpected side-effects.\r\n\r\n## Screenshots\r\nN/A\r\n\r\n## What is the value of this and can you measure success?\r\nDon't load things we don't need to\r\n\r\n### Does this affect other platforms?\r\nNo, web only\r\n\r\n### Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?\r\nNo\r\n\r\n### Accessibility test checklist\r\nN/A\r\n\r\n### Tested\r\n- [x] Locally\r\n- [ ] On CODE (optional)\r\n\r\n<!-- Does this PR meet the contributing guidelines? https://git.io/v1VEJ -->\r\n"},"comment":{"url":"https://api.github.com/repos/guardian/frontend/issues/comments/400311590","html_url":"https://github.com/guardian/frontend/pull/19905#issuecomment-400311590","issue_url":"https://api.github.com/repos/guardian/frontend/issues/19905","id":400311590,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDMxMTU5MA==","user":{"login":"prout-bot","id":8896019,"node_id":"MDQ6VXNlcjg4OTYwMTk=","avatar_url":"https://avatars2.githubusercontent.com/u/8896019?v=4","gravatar_id":"","url":"https://api.github.com/users/prout-bot","html_url":"https://github.com/prout-bot","followers_url":"https://api.github.com/users/prout-bot/followers","following_url":"https://api.github.com/users/prout-bot/following{/other_user}","gists_url":"https://api.github.com/users/prout-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/prout-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prout-bot/subscriptions","organizations_url":"https://api.github.com/users/prout-bot/orgs","repos_url":"https://api.github.com/users/prout-bot/repos","events_url":"https://api.github.com/users/prout-bot/events{/privacy}","received_events_url":"https://api.github.com/users/prout-bot/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T13:37:46Z","updated_at":"2018-06-26T13:37:46Z","author_association":"COLLABORATOR","body":"Seen on [PROD](https://frontend.gutools.co.uk/deploys?stage=PROD&pageSize=50) (merged by @JustinPinner 17 minutes and 53 seconds ago) \n- Check your changes on [www.theguardian.com](https://www.theguardian.com) ✔️\n- Keep an eye on the [deploy dashboard](https://logs.gutools.co.uk/app/kibana#/dashboard/8730df10-49fd-11e7-b778-ebbe55169b8f?_g=(refreshInterval:(display:Off,pause:!f,value:0),time:(from:now-15m,mode:quick,to:now))&_a=(description:'',filters:!(),fullScreenMode:!f,options:(darkTheme:!f,useMargins:!f),panels:!((gridData:(h:4,i:'4',w:6,x:6,y:0),id:'735f9ce0-4a04-11e7-9f15-395e2d1c9b1f',panelIndex:'4',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'5',w:6,x:0,y:0),id:b9249830-4a03-11e7-91e8-2fbfd59c38bb,panelIndex:'5',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'7',w:6,x:0,y:4),id:ac507b90-4a0f-11e7-9f15-395e2d1c9b1f,panelIndex:'7',type:visualization,version:'6.2.4'),(gridData:(h:4,i:'9',w:6,x:6,y:4),id:a5f78860-4ad2-11e7-9930-73b4968e85d8,panelIndex:'9',type:visualization,version:'6.2.4')),query:(language:lucene,query:(query_string:(analyze_wildcard:!t,query:'stage:PROD%20NOT%20app:preview'))),timeRestore:!f,title:'Frontend%20PROD%20Deploy',viewMode:view)) 📉\n"}}
{"actor":{"display_login":"prout-bot"}}