{"action":"created","issue":{"url":"https://api.github.com/repos/bold-commerce/go-shopify/issues/7","repository_url":"https://api.github.com/repos/bold-commerce/go-shopify","labels_url":"https://api.github.com/repos/bold-commerce/go-shopify/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/bold-commerce/go-shopify/issues/7/comments","events_url":"https://api.github.com/repos/bold-commerce/go-shopify/issues/7/events","html_url":"https://github.com/bold-commerce/go-shopify/issues/7","id":358166904,"node_id":"MDU6SXNzdWUzNTgxNjY5MDQ=","number":7,"title":"IDs should use int64 instead of int","user":{"login":"andrewhoff","id":2424906,"node_id":"MDQ6VXNlcjI0MjQ5MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/2424906?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewhoff","html_url":"https://github.com/andrewhoff","followers_url":"https://api.github.com/users/andrewhoff/followers","following_url":"https://api.github.com/users/andrewhoff/following{/other_user}","gists_url":"https://api.github.com/users/andrewhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewhoff/subscriptions","organizations_url":"https://api.github.com/users/andrewhoff/orgs","repos_url":"https://api.github.com/users/andrewhoff/repos","events_url":"https://api.github.com/users/andrewhoff/events{/privacy}","received_events_url":"https://api.github.com/users/andrewhoff/received_events","type":"User","site_admin":false},"labels":[{"id":1013809084,"node_id":"MDU6TGFiZWwxMDEzODA5MDg0","url":"https://api.github.com/repos/bold-commerce/go-shopify/labels/question","name":"question","color":"d876e3","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-07T18:26:46Z","updated_at":"2018-09-07T18:26:46Z","closed_at":null,"author_association":"COLLABORATOR","body":"_From @orian on June 8, 2018 6:27_\n\nFor some objects Shopify is using a global ID space and recently the threshold of 2^31-1 has been exceeded.\r\n\r\nThe Go's int size is at least 32 bits, but not guaranteed to be bigger (e.g. `int64`).\r\n\r\nI propose to switch all `int` ids into `int64`.\n\n_Copied from original issue: getconversio/go-shopify#92_"},"comment":{"url":"https://api.github.com/repos/bold-commerce/go-shopify/issues/comments/419526291","html_url":"https://github.com/bold-commerce/go-shopify/issues/7#issuecomment-419526291","issue_url":"https://api.github.com/repos/bold-commerce/go-shopify/issues/7","id":419526291,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTUyNjI5MQ==","user":{"login":"andrewhoff","id":2424906,"node_id":"MDQ6VXNlcjI0MjQ5MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/2424906?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewhoff","html_url":"https://github.com/andrewhoff","followers_url":"https://api.github.com/users/andrewhoff/followers","following_url":"https://api.github.com/users/andrewhoff/following{/other_user}","gists_url":"https://api.github.com/users/andrewhoff/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewhoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewhoff/subscriptions","organizations_url":"https://api.github.com/users/andrewhoff/orgs","repos_url":"https://api.github.com/users/andrewhoff/repos","events_url":"https://api.github.com/users/andrewhoff/events{/privacy}","received_events_url":"https://api.github.com/users/andrewhoff/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T18:26:46Z","updated_at":"2018-09-07T18:26:46Z","author_association":"COLLABORATOR","body":"_From @dlebech on June 11, 2018 20:9_\n\nThanks for bringing this up. This was on my mind as well when I initially created the library. The reason I went with `int` was simplicity and the fact that I don't expect anyone to run 32 bit Go servers (It is my understanding that if a 64-bit processor is available, `int` will always be a 64 bit integer.) Of course, this could be the wrong assumption, and I would be curious to know what the best practice is currently (I'm a bit out of touch 🙂 ) *and* whether changing all `int`s to `int64` will actually be a breaking change in the library. `int` and `int64` are different types, after all 🤔 "}}
{"actor":{"display_login":"andrewhoff"}}