{"action":"closed","number":4338,"pull_request":{"url":"https://api.github.com/repos/raster-foundry/raster-foundry/pulls/4338","id":234722577,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NzIyNTc3","html_url":"https://github.com/raster-foundry/raster-foundry/pull/4338","diff_url":"https://github.com/raster-foundry/raster-foundry/pull/4338.diff","patch_url":"https://github.com/raster-foundry/raster-foundry/pull/4338.patch","issue_url":"https://api.github.com/repos/raster-foundry/raster-foundry/issues/4338","number":4338,"state":"closed","locked":false,"title":"Webpack 4 import fixes","user":{"login":"Lknechtli","id":4392704,"node_id":"MDQ6VXNlcjQzOTI3MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4392704?v=4","gravatar_id":"","url":"https://api.github.com/users/Lknechtli","html_url":"https://github.com/Lknechtli","followers_url":"https://api.github.com/users/Lknechtli/followers","following_url":"https://api.github.com/users/Lknechtli/following{/other_user}","gists_url":"https://api.github.com/users/Lknechtli/gists{/gist_id}","starred_url":"https://api.github.com/users/Lknechtli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lknechtli/subscriptions","organizations_url":"https://api.github.com/users/Lknechtli/orgs","repos_url":"https://api.github.com/users/Lknechtli/repos","events_url":"https://api.github.com/users/Lknechtli/events{/privacy}","received_events_url":"https://api.github.com/users/Lknechtli/received_events","type":"User","site_admin":false},"body":"## Overview\r\nFix a bunch of misc webpack errors:\r\n* Use async webpack requires for joint.js, math.js, and plyr.js\r\n* Split out vendor and main app bundles\r\n* Fix favicons\r\n\r\n### Checklist\r\n\r\n- ~Description of PR is in an appropriate section of the [changelog](https://github.com/raster-foundry/raster-foundry/blob/develop/CHANGELOG.md) and grouped with similar changes if possible~ changelog will be edited in anchor pr\r\n- ~Styleguide updated, if necessary~\r\n- ~[Swagger specification](https://github.com/raster-foundry/raster-foundry-api-spec) updated~\r\n- ~Symlinks from new migrations present or corrected for any new migrations~\r\n- [x] Any content changes are properly templated using `BUILDCONFIG.APP_NAME`\r\n- ~Any new SQL strings have tests~\r\n\r\n### Demo:\r\nBuild times on develop:\r\n![image](https://user-images.githubusercontent.com/4392704/49240772-08bcb000-f3d4-11e8-89b5-26ec33911663.png)\r\nBuild times on webpack 4:\r\n![image](https://user-images.githubusercontent.com/4392704/49240797-1a9e5300-f3d4-11e8-88fe-bf9f94252583.png)\r\n\r\n\r\n## Testing Instructions\r\n* Use a modern version of node (>8)\r\n* Build the app using `yarn build-nginx` and verify that the bundle is now found in `app-frontend/dist` and `nginx/srv/dist`\r\n* Verify that all favicon related files (images, manifest, etc) are present in `dist/favicons`\r\n* Verify that there are no weird import errors for the manifest file\r\n* re-build your nginx-api container, and start everything using `./scripts/server`\r\n* Load `localhost:9100` and verify that bundle size is reduced, and code is split over multiple bundles.\r\n* Turn caching off in dev tools and verify that favicons are fetched correctly\r\n* Delete `app-frontend/dist` and verify that favicons etc are still served by the dev server\r\n* Create a new template, and verify that the math.js bundle is fetched on demand while preserving functionality\r\n* Verify that the lab loads correctly in the previous step, then reload the page so the lab is the first view loaded and verify that it initializes correctly.\r\n* Verify that plyr is loaded on demand. See https://github.com/raster-foundry/raster-foundry/pull/3083 for more detailed testing instructions\r\n* Verify that scene uploads still work (tests loam.js)\r\n* Go to a bunch of places in the app and look for broken image imports\r\n\r\nCloses #4200 \r\nCloses #4204\r\nCloses https://github.com/azavea/raster-foundry-platform/issues/527\r\nDepends on #4325 (branched off of, rebase once that's merged)","created_at":"2018-11-29T17:24:48Z","updated_at":"2018-12-04T21:35:43Z","closed_at":"2018-12-04T21:35:43Z","merged_at":"2018-12-04T21:35:43Z","merge_commit_sha":"bb4da0cb7371d2504c41ffd05d0f764569bece12","assignee":{"login":"alkamin","id":2442245,"node_id":"MDQ6VXNlcjI0NDIyNDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2442245?v=4","gravatar_id":"","url":"https://api.github.com/users/alkamin","html_url":"https://github.com/alkamin","followers_url":"https://api.github.com/users/alkamin/followers","following_url":"https://api.github.com/users/alkamin/following{/other_user}","gists_url":"https://api.github.com/users/alkamin/gists{/gist_id}","starred_url":"https://api.github.com/users/alkamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alkamin/subscriptions","organizations_url":"https://api.github.com/users/alkamin/orgs","repos_url":"https://api.github.com/users/alkamin/repos","events_url":"https://api.github.com/users/alkamin/events{/privacy}","received_events_url":"https://api.github.com/users/alkamin/received_events","type":"User","site_admin":false},"assignees":[{"login":"alkamin","id":2442245,"node_id":"MDQ6VXNlcjI0NDIyNDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2442245?v=4","gravatar_id":"","url":"https://api.github.com/users/alkamin","html_url":"https://github.com/alkamin","followers_url":"https://api.github.com/users/alkamin/followers","following_url":"https://api.github.com/users/alkamin/following{/other_user}","gists_url":"https://api.github.com/users/alkamin/gists{/gist_id}","starred_url":"https://api.github.com/users/alkamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alkamin/subscriptions","organizations_url":"https://api.github.com/users/alkamin/orgs","repos_url":"https://api.github.com/users/alkamin/repos","events_url":"https://api.github.com/users/alkamin/events{/privacy}","received_events_url":"https://api.github.com/users/alkamin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/raster-foundry/raster-foundry/pulls/4338/commits","review_comments_url":"https://api.github.com/repos/raster-foundry/raster-foundry/pulls/4338/comments","review_comment_url":"https://api.github.com/repos/raster-foundry/raster-foundry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/raster-foundry/raster-foundry/issues/4338/comments","statuses_url":"https://api.github.com/repos/raster-foundry/raster-foundry/statuses/3428c8aaedee3030920aed80d761a02739fe9afb","head":{"label":"raster-foundry:feature/lk/remaining-import-fixes","ref":"feature/lk/remaining-import-fixes","sha":"3428c8aaedee3030920aed80d761a02739fe9afb","user":{"login":"raster-foundry","id":30530043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNTMwMDQz","avatar_url":"https://avatars3.githubusercontent.com/u/30530043?v=4","gravatar_id":"","url":"https://api.github.com/users/raster-foundry","html_url":"https://github.com/raster-foundry","followers_url":"https://api.github.com/users/raster-foundry/followers","following_url":"https://api.github.com/users/raster-foundry/following{/other_user}","gists_url":"https://api.github.com/users/raster-foundry/gists{/gist_id}","starred_url":"https://api.github.com/users/raster-foundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raster-foundry/subscriptions","organizations_url":"https://api.github.com/users/raster-foundry/orgs","repos_url":"https://api.github.com/users/raster-foundry/repos","events_url":"https://api.github.com/users/raster-foundry/events{/privacy}","received_events_url":"https://api.github.com/users/raster-foundry/received_events","type":"Organization","site_admin":false},"repo":{"id":36464140,"node_id":"MDEwOlJlcG9zaXRvcnkzNjQ2NDE0MA==","name":"raster-foundry","full_name":"raster-foundry/raster-foundry","private":false,"owner":{"login":"raster-foundry","id":30530043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNTMwMDQz","avatar_url":"https://avatars3.githubusercontent.com/u/30530043?v=4","gravatar_id":"","url":"https://api.github.com/users/raster-foundry","html_url":"https://github.com/raster-foundry","followers_url":"https://api.github.com/users/raster-foundry/followers","following_url":"https://api.github.com/users/raster-foundry/following{/other_user}","gists_url":"https://api.github.com/users/raster-foundry/gists{/gist_id}","starred_url":"https://api.github.com/users/raster-foundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raster-foundry/subscriptions","organizations_url":"https://api.github.com/users/raster-foundry/orgs","repos_url":"https://api.github.com/users/raster-foundry/repos","events_url":"https://api.github.com/users/raster-foundry/events{/privacy}","received_events_url":"https://api.github.com/users/raster-foundry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/raster-foundry/raster-foundry","description":"The Raster Foundry web application.","fork":false,"url":"https://api.github.com/repos/raster-foundry/raster-foundry","forks_url":"https://api.github.com/repos/raster-foundry/raster-foundry/forks","keys_url":"https://api.github.com/repos/raster-foundry/raster-foundry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raster-foundry/raster-foundry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raster-foundry/raster-foundry/teams","hooks_url":"https://api.github.com/repos/raster-foundry/raster-foundry/hooks","issue_events_url":"https://api.github.com/repos/raster-foundry/raster-foundry/issues/events{/number}","events_url":"https://api.github.com/repos/raster-foundry/raster-foundry/events","assignees_url":"https://api.github.com/repos/raster-foundry/raster-foundry/assignees{/user}","branches_url":"https://api.github.com/repos/raster-foundry/raster-foundry/branches{/branch}","tags_url":"https://api.github.com/repos/raster-foundry/raster-foundry/tags","blobs_url":"https://api.github.com/repos/raster-foundry/raster-foundry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raster-foundry/raster-foundry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raster-foundry/raster-foundry/git/refs{/sha}","trees_url":"https://api.github.com/repos/raster-foundry/raster-foundry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raster-foundry/raster-foundry/statuses/{sha}","languages_url":"https://api.github.com/repos/raster-foundry/raster-foundry/languages","stargazers_url":"https://api.github.com/repos/raster-foundry/raster-foundry/stargazers","contributors_url":"https://api.github.com/repos/raster-foundry/raster-foundry/contributors","subscribers_url":"https://api.github.com/repos/raster-foundry/raster-foundry/subscribers","subscription_url":"https://api.github.com/repos/raster-foundry/raster-foundry/subscription","commits_url":"https://api.github.com/repos/raster-foundry/raster-foundry/commits{/sha}","git_commits_url":"https://api.github.com/repos/raster-foundry/raster-foundry/git/commits{/sha}","comments_url":"https://api.github.com/repos/raster-foundry/raster-foundry/comments{/number}","issue_comment_url":"https://api.github.com/repos/raster-foundry/raster-foundry/issues/comments{/number}","contents_url":"https://api.github.com/repos/raster-foundry/raster-foundry/contents/{+path}","compare_url":"https://api.github.com/repos/raster-foundry/raster-foundry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raster-foundry/raster-foundry/merges","archive_url":"https://api.github.com/repos/raster-foundry/raster-foundry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raster-foundry/raster-foundry/downloads","issues_url":"https://api.github.com/repos/raster-foundry/raster-foundry/issues{/number}","pulls_url":"https://api.github.com/repos/raster-foundry/raster-foundry/pulls{/number}","milestones_url":"https://api.github.com/repos/raster-foundry/raster-foundry/milestones{/number}","notifications_url":"https://api.github.com/repos/raster-foundry/raster-foundry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raster-foundry/raster-foundry/labels{/name}","releases_url":"https://api.github.com/repos/raster-foundry/raster-foundry/releases{/id}","deployments_url":"https://api.github.com/repos/raster-foundry/raster-foundry/deployments","created_at":"2015-05-28T20:25:45Z","updated_at":"2018-12-01T16:26:51Z","pushed_at":"2018-12-04T21:35:43Z","git_url":"git://github.com/raster-foundry/raster-foundry.git","ssh_url":"git@github.com:raster-foundry/raster-foundry.git","clone_url":"https://github.com/raster-foundry/raster-foundry.git","svn_url":"https://github.com/raster-foundry/raster-foundry","homepage":"https://www.rasterfoundry.com","size":38344,"stargazers_count":74,"watchers_count":74,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":450,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":29,"open_issues":450,"watchers":74,"default_branch":"develop"}},"base":{"label":"raster-foundry:feature/lk/upgrade-webpack","ref":"feature/lk/upgrade-webpack","sha":"249a3cb1c4c09b3a120fe233c20e76c3fbd455c6","user":{"login":"raster-foundry","id":30530043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNTMwMDQz","avatar_url":"https://avatars3.githubusercontent.com/u/30530043?v=4","gravatar_id":"","url":"https://api.github.com/users/raster-foundry","html_url":"https://github.com/raster-foundry","followers_url":"https://api.github.com/users/raster-foundry/followers","following_url":"https://api.github.com/users/raster-foundry/following{/other_user}","gists_url":"https://api.github.com/users/raster-foundry/gists{/gist_id}","starred_url":"https://api.github.com/users/raster-foundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raster-foundry/subscriptions","organizations_url":"https://api.github.com/users/raster-foundry/orgs","repos_url":"https://api.github.com/users/raster-foundry/repos","events_url":"https://api.github.com/users/raster-foundry/events{/privacy}","received_events_url":"https://api.github.com/users/raster-foundry/received_events","type":"Organization","site_admin":false},"repo":{"id":36464140,"node_id":"MDEwOlJlcG9zaXRvcnkzNjQ2NDE0MA==","name":"raster-foundry","full_name":"raster-foundry/raster-foundry","private":false,"owner":{"login":"raster-foundry","id":30530043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNTMwMDQz","avatar_url":"https://avatars3.githubusercontent.com/u/30530043?v=4","gravatar_id":"","url":"https://api.github.com/users/raster-foundry","html_url":"https://github.com/raster-foundry","followers_url":"https://api.github.com/users/raster-foundry/followers","following_url":"https://api.github.com/users/raster-foundry/following{/other_user}","gists_url":"https://api.github.com/users/raster-foundry/gists{/gist_id}","starred_url":"https://api.github.com/users/raster-foundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raster-foundry/subscriptions","organizations_url":"https://api.github.com/users/raster-foundry/orgs","repos_url":"https://api.github.com/users/raster-foundry/repos","events_url":"https://api.github.com/users/raster-foundry/events{/privacy}","received_events_url":"https://api.github.com/users/raster-foundry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/raster-foundry/raster-foundry","description":"The Raster Foundry web application.","fork":false,"url":"https://api.github.com/repos/raster-foundry/raster-foundry","forks_url":"https://api.github.com/repos/raster-foundry/raster-foundry/forks","keys_url":"https://api.github.com/repos/raster-foundry/raster-foundry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/raster-foundry/raster-foundry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/raster-foundry/raster-foundry/teams","hooks_url":"https://api.github.com/repos/raster-foundry/raster-foundry/hooks","issue_events_url":"https://api.github.com/repos/raster-foundry/raster-foundry/issues/events{/number}","events_url":"https://api.github.com/repos/raster-foundry/raster-foundry/events","assignees_url":"https://api.github.com/repos/raster-foundry/raster-foundry/assignees{/user}","branches_url":"https://api.github.com/repos/raster-foundry/raster-foundry/branches{/branch}","tags_url":"https://api.github.com/repos/raster-foundry/raster-foundry/tags","blobs_url":"https://api.github.com/repos/raster-foundry/raster-foundry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/raster-foundry/raster-foundry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/raster-foundry/raster-foundry/git/refs{/sha}","trees_url":"https://api.github.com/repos/raster-foundry/raster-foundry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/raster-foundry/raster-foundry/statuses/{sha}","languages_url":"https://api.github.com/repos/raster-foundry/raster-foundry/languages","stargazers_url":"https://api.github.com/repos/raster-foundry/raster-foundry/stargazers","contributors_url":"https://api.github.com/repos/raster-foundry/raster-foundry/contributors","subscribers_url":"https://api.github.com/repos/raster-foundry/raster-foundry/subscribers","subscription_url":"https://api.github.com/repos/raster-foundry/raster-foundry/subscription","commits_url":"https://api.github.com/repos/raster-foundry/raster-foundry/commits{/sha}","git_commits_url":"https://api.github.com/repos/raster-foundry/raster-foundry/git/commits{/sha}","comments_url":"https://api.github.com/repos/raster-foundry/raster-foundry/comments{/number}","issue_comment_url":"https://api.github.com/repos/raster-foundry/raster-foundry/issues/comments{/number}","contents_url":"https://api.github.com/repos/raster-foundry/raster-foundry/contents/{+path}","compare_url":"https://api.github.com/repos/raster-foundry/raster-foundry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/raster-foundry/raster-foundry/merges","archive_url":"https://api.github.com/repos/raster-foundry/raster-foundry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/raster-foundry/raster-foundry/downloads","issues_url":"https://api.github.com/repos/raster-foundry/raster-foundry/issues{/number}","pulls_url":"https://api.github.com/repos/raster-foundry/raster-foundry/pulls{/number}","milestones_url":"https://api.github.com/repos/raster-foundry/raster-foundry/milestones{/number}","notifications_url":"https://api.github.com/repos/raster-foundry/raster-foundry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/raster-foundry/raster-foundry/labels{/name}","releases_url":"https://api.github.com/repos/raster-foundry/raster-foundry/releases{/id}","deployments_url":"https://api.github.com/repos/raster-foundry/raster-foundry/deployments","created_at":"2015-05-28T20:25:45Z","updated_at":"2018-12-01T16:26:51Z","pushed_at":"2018-12-04T21:35:43Z","git_url":"git://github.com/raster-foundry/raster-foundry.git","ssh_url":"git@github.com:raster-foundry/raster-foundry.git","clone_url":"https://github.com/raster-foundry/raster-foundry.git","svn_url":"https://github.com/raster-foundry/raster-foundry","homepage":"https://www.rasterfoundry.com","size":38344,"stargazers_count":74,"watchers_count":74,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":450,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":29,"open_issues":450,"watchers":74,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/raster-foundry/raster-foundry/pulls/4338"},"html":{"href":"https://github.com/raster-foundry/raster-foundry/pull/4338"},"issue":{"href":"https://api.github.com/repos/raster-foundry/raster-foundry/issues/4338"},"comments":{"href":"https://api.github.com/repos/raster-foundry/raster-foundry/issues/4338/comments"},"review_comments":{"href":"https://api.github.com/repos/raster-foundry/raster-foundry/pulls/4338/comments"},"review_comment":{"href":"https://api.github.com/repos/raster-foundry/raster-foundry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/raster-foundry/raster-foundry/pulls/4338/commits"},"statuses":{"href":"https://api.github.com/repos/raster-foundry/raster-foundry/statuses/3428c8aaedee3030920aed80d761a02739fe9afb"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Lknechtli","id":4392704,"node_id":"MDQ6VXNlcjQzOTI3MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/4392704?v=4","gravatar_id":"","url":"https://api.github.com/users/Lknechtli","html_url":"https://github.com/Lknechtli","followers_url":"https://api.github.com/users/Lknechtli/followers","following_url":"https://api.github.com/users/Lknechtli/following{/other_user}","gists_url":"https://api.github.com/users/Lknechtli/gists{/gist_id}","starred_url":"https://api.github.com/users/Lknechtli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lknechtli/subscriptions","organizations_url":"https://api.github.com/users/Lknechtli/orgs","repos_url":"https://api.github.com/users/Lknechtli/repos","events_url":"https://api.github.com/users/Lknechtli/events{/privacy}","received_events_url":"https://api.github.com/users/Lknechtli/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":12,"additions":766,"deletions":2468,"changed_files":52}}
{"actor":{"display_login":"Lknechtli"}}