{"action":"created","issue":{"url":"https://api.github.com/repos/ndbroadbent/icloud_photos_downloader/issues/72","repository_url":"https://api.github.com/repos/ndbroadbent/icloud_photos_downloader","labels_url":"https://api.github.com/repos/ndbroadbent/icloud_photos_downloader/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/ndbroadbent/icloud_photos_downloader/issues/72/comments","events_url":"https://api.github.com/repos/ndbroadbent/icloud_photos_downloader/issues/72/events","html_url":"https://github.com/ndbroadbent/icloud_photos_downloader/issues/72","id":326701508,"node_id":"MDU6SXNzdWUzMjY3MDE1MDg=","number":72,"title":"Skipped videos result in \"Could not process\" message","user":{"login":"ezheidtmann","id":1178915,"node_id":"MDQ6VXNlcjExNzg5MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1178915?v=4","gravatar_id":"","url":"https://api.github.com/users/ezheidtmann","html_url":"https://github.com/ezheidtmann","followers_url":"https://api.github.com/users/ezheidtmann/followers","following_url":"https://api.github.com/users/ezheidtmann/following{/other_user}","gists_url":"https://api.github.com/users/ezheidtmann/gists{/gist_id}","starred_url":"https://api.github.com/users/ezheidtmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezheidtmann/subscriptions","organizations_url":"https://api.github.com/users/ezheidtmann/orgs","repos_url":"https://api.github.com/users/ezheidtmann/repos","events_url":"https://api.github.com/users/ezheidtmann/events{/privacy}","received_events_url":"https://api.github.com/users/ezheidtmann/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-26T02:02:45Z","updated_at":"2018-07-21T21:47:06Z","closed_at":"2018-07-21T21:47:06Z","author_association":"NONE","body":"I think a `continue` should be a a `break`.  Will patch if I remember."},"comment":{"url":"https://api.github.com/repos/ndbroadbent/icloud_photos_downloader/issues/comments/406825396","html_url":"https://github.com/ndbroadbent/icloud_photos_downloader/issues/72#issuecomment-406825396","issue_url":"https://api.github.com/repos/ndbroadbent/icloud_photos_downloader/issues/72","id":406825396,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjgyNTM5Ng==","user":{"login":"ndbroadbent","id":139536,"node_id":"MDQ6VXNlcjEzOTUzNg==","avatar_url":"https://avatars2.githubusercontent.com/u/139536?v=4","gravatar_id":"","url":"https://api.github.com/users/ndbroadbent","html_url":"https://github.com/ndbroadbent","followers_url":"https://api.github.com/users/ndbroadbent/followers","following_url":"https://api.github.com/users/ndbroadbent/following{/other_user}","gists_url":"https://api.github.com/users/ndbroadbent/gists{/gist_id}","starred_url":"https://api.github.com/users/ndbroadbent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndbroadbent/subscriptions","organizations_url":"https://api.github.com/users/ndbroadbent/orgs","repos_url":"https://api.github.com/users/ndbroadbent/repos","events_url":"https://api.github.com/users/ndbroadbent/events{/privacy}","received_events_url":"https://api.github.com/users/ndbroadbent/received_events","type":"User","site_admin":false},"created_at":"2018-07-21T21:47:06Z","updated_at":"2018-07-21T21:47:06Z","author_association":"OWNER","body":"Thanks @ezheidtmann, you're right, that should have been a `break`. Otherwise it just continues until reaching the max retries. Have pushed the fix\r\n\r\n@Max-Pol Thanks for the feedback! You're right, I think a `--skip-videos` flag makes way more sense than `--download-videos`. I was thinking that a lot of these 4K and slow motion videos can be pretty huge, and I just wanted a copy of my photos. But yeah I think it makes sense to download videos by default. Have pushed the change: https://github.com/ndbroadbent/icloud_photos_downloader/commit/9cb9fdd0db7866f625544f1a7dbb38d3a9804934\r\n\r\nThanks everyone!\r\n"}}
{"actor":{"display_login":"ndbroadbent"}}