{"action":"created","comment":{"url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/pulls/comments/199096206","pull_request_review_id":133148059,"id":199096206,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTA5NjIwNg==","diff_hunk":"@@ -150,7 +150,7 @@ export default class EventSimulator {\n             button:        options.button === void 0 ? eventUtils.BUTTON.left : options.button,\n             buttons:       options.buttons === void 0 ? eventUtils.BUTTONS_PARAMETER.leftButton : options.buttons,\n             relatedTarget: options.relatedTarget || null,\n-            which:         options.which === void 0 ? eventUtils.WHICH_PARAMETER.leftButton : options.which\n+            which:         options.which","path":"src/client/sandbox/event/simulator.js","position":5,"original_position":5,"commit_id":"07fe2616a0e37a1641f3a70964f9a99b99ee3d97","original_commit_id":"d57053e9380ee6397f84d8c6dc814aa047585cfe","user":{"login":"AlexKamaev","id":1678902,"node_id":"MDQ6VXNlcjE2Nzg5MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1678902?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexKamaev","html_url":"https://github.com/AlexKamaev","followers_url":"https://api.github.com/users/AlexKamaev/followers","following_url":"https://api.github.com/users/AlexKamaev/following{/other_user}","gists_url":"https://api.github.com/users/AlexKamaev/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexKamaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexKamaev/subscriptions","organizations_url":"https://api.github.com/users/AlexKamaev/orgs","repos_url":"https://api.github.com/users/AlexKamaev/repos","events_url":"https://api.github.com/users/AlexKamaev/events{/privacy}","received_events_url":"https://api.github.com/users/AlexKamaev/received_events","type":"User","site_admin":false},"body":"We don't need to send it for each event, even created via `document.createEvent`. The `which` property is calculated correctly depending on `button` property. We need `which` param for events with not working `which` property, i.e. `mousemove`. So we pass `which` from testcafe to hammerhead on `mousemove`. But, I've mentioned that in any cases we do not have proper set of `button`, `buttons`, `which` prioperties for some events even now. Let's discuss it","created_at":"2018-06-29T08:55:30Z","updated_at":"2018-06-29T08:55:30Z","html_url":"https://github.com/DevExpress/testcafe-hammerhead/pull/1659#discussion_r199096206","pull_request_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/pulls/1659","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/pulls/comments/199096206"},"html":{"href":"https://github.com/DevExpress/testcafe-hammerhead/pull/1659#discussion_r199096206"},"pull_request":{"href":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/pulls/1659"}},"in_reply_to_id":198543443},"pull_request":{"url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/pulls/1659","id":196676418,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2Njc2NDE4","html_url":"https://github.com/DevExpress/testcafe-hammerhead/pull/1659","diff_url":"https://github.com/DevExpress/testcafe-hammerhead/pull/1659.diff","patch_url":"https://github.com/DevExpress/testcafe-hammerhead/pull/1659.patch","issue_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/issues/1659","number":1659,"state":"open","locked":false,"title":"fix `buttons` property for mouse events and refactor `which` property (closes #1658)","user":{"login":"AlexKamaev","id":1678902,"node_id":"MDQ6VXNlcjE2Nzg5MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1678902?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexKamaev","html_url":"https://github.com/AlexKamaev","followers_url":"https://api.github.com/users/AlexKamaev/followers","following_url":"https://api.github.com/users/AlexKamaev/following{/other_user}","gists_url":"https://api.github.com/users/AlexKamaev/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexKamaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexKamaev/subscriptions","organizations_url":"https://api.github.com/users/AlexKamaev/orgs","repos_url":"https://api.github.com/users/AlexKamaev/repos","events_url":"https://api.github.com/users/AlexKamaev/events{/privacy}","received_events_url":"https://api.github.com/users/AlexKamaev/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-22T08:55:27Z","updated_at":"2018-06-29T08:55:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21c1f7452c246c5840edb76fd91b822ec63bd298","assignee":null,"assignees":[],"requested_reviewers":[{"login":"miherlosev","id":4133518,"node_id":"MDQ6VXNlcjQxMzM1MTg=","avatar_url":"https://avatars2.githubusercontent.com/u/4133518?v=4","gravatar_id":"","url":"https://api.github.com/users/miherlosev","html_url":"https://github.com/miherlosev","followers_url":"https://api.github.com/users/miherlosev/followers","following_url":"https://api.github.com/users/miherlosev/following{/other_user}","gists_url":"https://api.github.com/users/miherlosev/gists{/gist_id}","starred_url":"https://api.github.com/users/miherlosev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miherlosev/subscriptions","organizations_url":"https://api.github.com/users/miherlosev/orgs","repos_url":"https://api.github.com/users/miherlosev/repos","events_url":"https://api.github.com/users/miherlosev/events{/privacy}","received_events_url":"https://api.github.com/users/miherlosev/received_events","type":"User","site_admin":false},{"login":"AndreyBelym","id":4479386,"node_id":"MDQ6VXNlcjQ0NzkzODY=","avatar_url":"https://avatars1.githubusercontent.com/u/4479386?v=4","gravatar_id":"","url":"https://api.github.com/users/AndreyBelym","html_url":"https://github.com/AndreyBelym","followers_url":"https://api.github.com/users/AndreyBelym/followers","following_url":"https://api.github.com/users/AndreyBelym/following{/other_user}","gists_url":"https://api.github.com/users/AndreyBelym/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyBelym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyBelym/subscriptions","organizations_url":"https://api.github.com/users/AndreyBelym/orgs","repos_url":"https://api.github.com/users/AndreyBelym/repos","events_url":"https://api.github.com/users/AndreyBelym/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyBelym/received_events","type":"User","site_admin":false},{"login":"LavrovArtem","id":5373460,"node_id":"MDQ6VXNlcjUzNzM0NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/5373460?v=4","gravatar_id":"","url":"https://api.github.com/users/LavrovArtem","html_url":"https://github.com/LavrovArtem","followers_url":"https://api.github.com/users/LavrovArtem/followers","following_url":"https://api.github.com/users/LavrovArtem/following{/other_user}","gists_url":"https://api.github.com/users/LavrovArtem/gists{/gist_id}","starred_url":"https://api.github.com/users/LavrovArtem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LavrovArtem/subscriptions","organizations_url":"https://api.github.com/users/LavrovArtem/orgs","repos_url":"https://api.github.com/users/LavrovArtem/repos","events_url":"https://api.github.com/users/LavrovArtem/events{/privacy}","received_events_url":"https://api.github.com/users/LavrovArtem/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/pulls/1659/commits","review_comments_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/pulls/1659/comments","review_comment_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/issues/1659/comments","statuses_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/statuses/07fe2616a0e37a1641f3a70964f9a99b99ee3d97","head":{"label":"AlexKamaev:gh-1658","ref":"gh-1658","sha":"07fe2616a0e37a1641f3a70964f9a99b99ee3d97","user":{"login":"AlexKamaev","id":1678902,"node_id":"MDQ6VXNlcjE2Nzg5MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1678902?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexKamaev","html_url":"https://github.com/AlexKamaev","followers_url":"https://api.github.com/users/AlexKamaev/followers","following_url":"https://api.github.com/users/AlexKamaev/following{/other_user}","gists_url":"https://api.github.com/users/AlexKamaev/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexKamaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexKamaev/subscriptions","organizations_url":"https://api.github.com/users/AlexKamaev/orgs","repos_url":"https://api.github.com/users/AlexKamaev/repos","events_url":"https://api.github.com/users/AlexKamaev/events{/privacy}","received_events_url":"https://api.github.com/users/AlexKamaev/received_events","type":"User","site_admin":false},"repo":{"id":116919315,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY5MTkzMTU=","name":"testcafe-hammerhead","full_name":"AlexKamaev/testcafe-hammerhead","owner":{"login":"AlexKamaev","id":1678902,"node_id":"MDQ6VXNlcjE2Nzg5MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1678902?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexKamaev","html_url":"https://github.com/AlexKamaev","followers_url":"https://api.github.com/users/AlexKamaev/followers","following_url":"https://api.github.com/users/AlexKamaev/following{/other_user}","gists_url":"https://api.github.com/users/AlexKamaev/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexKamaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexKamaev/subscriptions","organizations_url":"https://api.github.com/users/AlexKamaev/orgs","repos_url":"https://api.github.com/users/AlexKamaev/repos","events_url":"https://api.github.com/users/AlexKamaev/events{/privacy}","received_events_url":"https://api.github.com/users/AlexKamaev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlexKamaev/testcafe-hammerhead","description":"A powerful web-proxy used as a core for the TestCafe testing framework. :hammer: :smiley: ","fork":true,"url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead","forks_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/forks","keys_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/teams","hooks_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/hooks","issue_events_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/issues/events{/number}","events_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/events","assignees_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/assignees{/user}","branches_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/branches{/branch}","tags_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/tags","blobs_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/languages","stargazers_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/stargazers","contributors_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/contributors","subscribers_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/subscribers","subscription_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/subscription","commits_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/contents/{+path}","compare_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/merges","archive_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/downloads","issues_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/issues{/number}","pulls_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/labels{/name}","releases_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/releases{/id}","deployments_url":"https://api.github.com/repos/AlexKamaev/testcafe-hammerhead/deployments","created_at":"2018-01-10T06:47:17Z","updated_at":"2018-03-14T11:00:56Z","pushed_at":"2018-06-29T08:40:29Z","git_url":"git://github.com/AlexKamaev/testcafe-hammerhead.git","ssh_url":"git@github.com:AlexKamaev/testcafe-hammerhead.git","clone_url":"https://github.com/AlexKamaev/testcafe-hammerhead.git","svn_url":"https://github.com/AlexKamaev/testcafe-hammerhead","homepage":"https://devexpress.github.io/testcafe/","size":5019,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DevExpress:master","ref":"master","sha":"bf48103612b2a59fbed5e2c23d0e5e3064d72a8e","user":{"login":"DevExpress","id":4243232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDMyMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4243232?v=4","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"repo":{"id":36883823,"node_id":"MDEwOlJlcG9zaXRvcnkzNjg4MzgyMw==","name":"testcafe-hammerhead","full_name":"DevExpress/testcafe-hammerhead","owner":{"login":"DevExpress","id":4243232,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNDMyMzI=","avatar_url":"https://avatars0.githubusercontent.com/u/4243232?v=4","gravatar_id":"","url":"https://api.github.com/users/DevExpress","html_url":"https://github.com/DevExpress","followers_url":"https://api.github.com/users/DevExpress/followers","following_url":"https://api.github.com/users/DevExpress/following{/other_user}","gists_url":"https://api.github.com/users/DevExpress/gists{/gist_id}","starred_url":"https://api.github.com/users/DevExpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevExpress/subscriptions","organizations_url":"https://api.github.com/users/DevExpress/orgs","repos_url":"https://api.github.com/users/DevExpress/repos","events_url":"https://api.github.com/users/DevExpress/events{/privacy}","received_events_url":"https://api.github.com/users/DevExpress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DevExpress/testcafe-hammerhead","description":"A powerful web-proxy used as a core for the TestCafe testing framework. :hammer: :smiley: ","fork":false,"url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead","forks_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/forks","keys_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/teams","hooks_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/hooks","issue_events_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/issues/events{/number}","events_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/events","assignees_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/assignees{/user}","branches_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/branches{/branch}","tags_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/tags","blobs_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/statuses/{sha}","languages_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/languages","stargazers_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/stargazers","contributors_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/contributors","subscribers_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/subscribers","subscription_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/subscription","commits_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/contents/{+path}","compare_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/merges","archive_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/downloads","issues_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/issues{/number}","pulls_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/pulls{/number}","milestones_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/milestones{/number}","notifications_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/labels{/name}","releases_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/releases{/id}","deployments_url":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/deployments","created_at":"2015-06-04T16:56:53Z","updated_at":"2018-06-29T07:58:44Z","pushed_at":"2018-06-29T08:40:30Z","git_url":"git://github.com/DevExpress/testcafe-hammerhead.git","ssh_url":"git@github.com:DevExpress/testcafe-hammerhead.git","clone_url":"https://github.com/DevExpress/testcafe-hammerhead.git","svn_url":"https://github.com/DevExpress/testcafe-hammerhead","homepage":"https://devexpress.github.io/testcafe/","size":4727,"stargazers_count":43,"watchers_count":43,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":130,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":25,"open_issues":130,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/pulls/1659"},"html":{"href":"https://github.com/DevExpress/testcafe-hammerhead/pull/1659"},"issue":{"href":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/issues/1659"},"comments":{"href":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/issues/1659/comments"},"review_comments":{"href":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/pulls/1659/comments"},"review_comment":{"href":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/pulls/1659/commits"},"statuses":{"href":"https://api.github.com/repos/DevExpress/testcafe-hammerhead/statuses/07fe2616a0e37a1641f3a70964f9a99b99ee3d97"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AlexKamaev"}}