{"action":"created","issue":{"url":"https://api.github.com/repos/crawl/crawl/issues/721","repository_url":"https://api.github.com/repos/crawl/crawl","labels_url":"https://api.github.com/repos/crawl/crawl/issues/721/labels{/name}","comments_url":"https://api.github.com/repos/crawl/crawl/issues/721/comments","events_url":"https://api.github.com/repos/crawl/crawl/issues/721/events","html_url":"https://github.com/crawl/crawl/pull/721","id":305550915,"number":721,"title":"Datify species definitions","user":{"login":"alexjurkiewicz","id":379509,"avatar_url":"https://avatars0.githubusercontent.com/u/379509?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjurkiewicz","html_url":"https://github.com/alexjurkiewicz","followers_url":"https://api.github.com/users/alexjurkiewicz/followers","following_url":"https://api.github.com/users/alexjurkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/alexjurkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjurkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjurkiewicz/subscriptions","organizations_url":"https://api.github.com/users/alexjurkiewicz/orgs","repos_url":"https://api.github.com/users/alexjurkiewicz/repos","events_url":"https://api.github.com/users/alexjurkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/alexjurkiewicz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-03-15T13:24:12Z","updated_at":"2018-04-23T13:14:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/crawl/crawl/pulls/721","html_url":"https://github.com/crawl/crawl/pull/721","diff_url":"https://github.com/crawl/crawl/pull/721.diff","patch_url":"https://github.com/crawl/crawl/pull/721.patch"},"body":"After seeing a mini-explosion of new/revived species in many active forks and lots of proposals (with patches!) on the forum, I thought it would be nice to make building a new species faster and easier. One way to do this would be convert species definitions into data files, similar to `art-data.txt`, which is what these commits do.\r\n\r\nI would like to data-ise `species-data.h` and `aptitudes.h` to start with (longer term this approach could also apply to backgrounds and monsters).\r\n\r\nI wanted to open this early to get some feedback on the approach before I spent more time on it. What do you think?"},"comment":{"url":"https://api.github.com/repos/crawl/crawl/issues/comments/383570595","html_url":"https://github.com/crawl/crawl/pull/721#issuecomment-383570595","issue_url":"https://api.github.com/repos/crawl/crawl/issues/721","id":383570595,"user":{"login":"alexjurkiewicz","id":379509,"avatar_url":"https://avatars0.githubusercontent.com/u/379509?v=4","gravatar_id":"","url":"https://api.github.com/users/alexjurkiewicz","html_url":"https://github.com/alexjurkiewicz","followers_url":"https://api.github.com/users/alexjurkiewicz/followers","following_url":"https://api.github.com/users/alexjurkiewicz/following{/other_user}","gists_url":"https://api.github.com/users/alexjurkiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/alexjurkiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexjurkiewicz/subscriptions","organizations_url":"https://api.github.com/users/alexjurkiewicz/orgs","repos_url":"https://api.github.com/users/alexjurkiewicz/repos","events_url":"https://api.github.com/users/alexjurkiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/alexjurkiewicz/received_events","type":"User","site_admin":false},"created_at":"2018-04-23T13:14:40Z","updated_at":"2018-04-23T13:14:40Z","author_association":"CONTRIBUTOR","body":"Thanks, I've cleaned up `newgame.cc` more properly as part of fixing random/viable character building that was broken after 27845c7.\r\n\r\nOne thing I turned up is an undocumented(?) Crawl convention. Species without any recommended jobs, and jobs without any recommended species are considered \"disabled\" and do not show on the character select screen. I decided to codify this and made it part of the species data format (`recommended_jobs` is mandatory, for advanced use you can make it optional by setting `starting_species` to `False` (I thought it better to have an explicit override for advanced users rather than allowing blank `recommended_jobs` because that seemed like something that would trip up new contributors.))"}}
{"actor":{"display_login":"alexjurkiewicz"}}