{"comment":{"url":"https://api.github.com/repos/Microsoft/vscode-go/comments/30321602","html_url":"https://github.com/Microsoft/vscode-go/commit/97ffefc4287cb23ffcee2e0848dcbc7faea30125#commitcomment-30321602","id":30321602,"node_id":"MDEzOkNvbW1pdENvbW1lbnQzMDMyMTYwMg==","user":{"login":"mgood","id":29016,"node_id":"MDQ6VXNlcjI5MDE2","avatar_url":"https://avatars2.githubusercontent.com/u/29016?v=4","gravatar_id":"","url":"https://api.github.com/users/mgood","html_url":"https://github.com/mgood","followers_url":"https://api.github.com/users/mgood/followers","following_url":"https://api.github.com/users/mgood/following{/other_user}","gists_url":"https://api.github.com/users/mgood/gists{/gist_id}","starred_url":"https://api.github.com/users/mgood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgood/subscriptions","organizations_url":"https://api.github.com/users/mgood/orgs","repos_url":"https://api.github.com/users/mgood/repos","events_url":"https://api.github.com/users/mgood/events{/privacy}","received_events_url":"https://api.github.com/users/mgood/received_events","type":"User","site_admin":false},"position":77,"line":77,"path":"src/goBuild.ts","commit_id":"97ffefc4287cb23ffcee2e0848dcbc7faea30125","created_at":"2018-08-29T00:49:40Z","updated_at":"2018-08-29T00:49:40Z","author_association":"NONE","body":"This could be rather inefficient if there are a large number of results since it's going to be O(N^2).\r\n\r\nIt seems like the duplicates here are likely a result of it calling `go build` individually for each package, so compilation errors in shared dependencies will be repeated.\r\n\r\nAs I noted in #1890 it seems like you could pass the list of packages to a single call of `go build` instead. Then you should only get one set of results back for the whole list of packages that shouldn't contain the duplication."}}
{"actor":{"display_login":"mgood"}}