{"action":"created","comment":{"url":"https://api.github.com/repos/SpongePowered/Ore/pulls/comments/203396268","pull_request_review_id":138276042,"id":203396268,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzM5NjI2OA==","diff_hunk":"@@ -38,18 +38,18 @@ object RoleTypes extends Enumeration {\n   // Project\n \n   val ProjectOwner   = new RoleType(17, \"Project_Owner\",    -1, classOf[ProjectRole], Absolute, \"Owner\",    Transparent, isAssignable = false)\n-  val ProjectDev     = new RoleType(18, \"Project_Developer\",-2, classOf[ProjectRole], Standard, \"Developer\",Transparent)\n+  val ProjectDev     = new RoleType(18, \"Project_Developer\",-2, classOf[ProjectRole], Lifted,   \"Developer\",Transparent)","path":"app/ore/permission/role/RoleTypes.scala","position":38,"original_position":38,"commit_id":"e8d2acfdd649a4c44dc19722cf5c9adffb2ef447","original_commit_id":"e8d2acfdd649a4c44dc19722cf5c9adffb2ef447","user":{"login":"dualspiral","id":1904167,"node_id":"MDQ6VXNlcjE5MDQxNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1904167?v=4","gravatar_id":"","url":"https://api.github.com/users/dualspiral","html_url":"https://github.com/dualspiral","followers_url":"https://api.github.com/users/dualspiral/followers","following_url":"https://api.github.com/users/dualspiral/following{/other_user}","gists_url":"https://api.github.com/users/dualspiral/gists{/gist_id}","starred_url":"https://api.github.com/users/dualspiral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dualspiral/subscriptions","organizations_url":"https://api.github.com/users/dualspiral/orgs","repos_url":"https://api.github.com/users/dualspiral/repos","events_url":"https://api.github.com/users/dualspiral/events{/privacy}","received_events_url":"https://api.github.com/users/dualspiral/received_events","type":"User","site_admin":false},"body":"I'm concerned about this, because we're potentially giving admin permissions to those marked as developers on project teams when this wasn't the case before, **particularly user admin** - this in itself may be a problem in some teams. It looks to me (and tell me if I'm wrong) that a developer could invite a person onto the team when they couldn't before and give them developer access. Worse, this wouldn't be a visible change and would have to be noticed, if it's noticed by the wrong person, this could be a serious problem.\r\n\r\nI know there are other changes coming to Ore that should help fix this permissions problem long term, but right now, this isn't a good solution. It trades one problem with another.\r\n\r\nIs there some way we can mitigate this?","created_at":"2018-07-18T14:17:30Z","updated_at":"2018-07-18T14:17:30Z","html_url":"https://github.com/SpongePowered/Ore/pull/575#discussion_r203396268","pull_request_url":"https://api.github.com/repos/SpongePowered/Ore/pulls/575","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/Ore/pulls/comments/203396268"},"html":{"href":"https://github.com/SpongePowered/Ore/pull/575#discussion_r203396268"},"pull_request":{"href":"https://api.github.com/repos/SpongePowered/Ore/pulls/575"}}},"pull_request":{"url":"https://api.github.com/repos/SpongePowered/Ore/pulls/575","id":202259675,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjU5Njc1","html_url":"https://github.com/SpongePowered/Ore/pull/575","diff_url":"https://github.com/SpongePowered/Ore/pull/575.diff","patch_url":"https://github.com/SpongePowered/Ore/pull/575.patch","issue_url":"https://api.github.com/repos/SpongePowered/Ore/issues/575","number":575,"state":"open","locked":false,"title":"Reorganizing Permissions for Moderators","user":{"login":"phase","id":7685133,"node_id":"MDQ6VXNlcjc2ODUxMzM=","avatar_url":"https://avatars1.githubusercontent.com/u/7685133?v=4","gravatar_id":"","url":"https://api.github.com/users/phase","html_url":"https://github.com/phase","followers_url":"https://api.github.com/users/phase/followers","following_url":"https://api.github.com/users/phase/following{/other_user}","gists_url":"https://api.github.com/users/phase/gists{/gist_id}","starred_url":"https://api.github.com/users/phase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phase/subscriptions","organizations_url":"https://api.github.com/users/phase/orgs","repos_url":"https://api.github.com/users/phase/repos","events_url":"https://api.github.com/users/phase/events{/privacy}","received_events_url":"https://api.github.com/users/phase/received_events","type":"User","site_admin":false},"body":"This should give everyone the proper permissions.\r\nModerators uploading versions was the main issue.","created_at":"2018-07-18T13:49:11Z","updated_at":"2018-07-18T14:17:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44dcf62da3c4a4765d8d1e35e76f373430025021","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":795801013,"node_id":"MDU6TGFiZWw3OTU4MDEwMTM=","url":"https://api.github.com/repos/SpongePowered/Ore/labels/component:%20backend","name":"component: backend","color":"b7315c","default":false},{"id":337110832,"node_id":"MDU6TGFiZWwzMzcxMTA4MzI=","url":"https://api.github.com/repos/SpongePowered/Ore/labels/status:%20input%20wanted","name":"status: input wanted","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SpongePowered/Ore/pulls/575/commits","review_comments_url":"https://api.github.com/repos/SpongePowered/Ore/pulls/575/comments","review_comment_url":"https://api.github.com/repos/SpongePowered/Ore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpongePowered/Ore/issues/575/comments","statuses_url":"https://api.github.com/repos/SpongePowered/Ore/statuses/e8d2acfdd649a4c44dc19722cf5c9adffb2ef447","head":{"label":"SpongePowered:fix/moderator-permissions","ref":"fix/moderator-permissions","sha":"e8d2acfdd649a4c44dc19722cf5c9adffb2ef447","user":{"login":"SpongePowered","id":8683473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODM0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":52847258,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjg0NzI1OA==","name":"Ore","full_name":"SpongePowered/Ore","owner":{"login":"SpongePowered","id":8683473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODM0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/Ore","description":"Repository software for Sponge plugins and Forge mods","fork":false,"url":"https://api.github.com/repos/SpongePowered/Ore","forks_url":"https://api.github.com/repos/SpongePowered/Ore/forks","keys_url":"https://api.github.com/repos/SpongePowered/Ore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/Ore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/Ore/teams","hooks_url":"https://api.github.com/repos/SpongePowered/Ore/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/Ore/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/Ore/events","assignees_url":"https://api.github.com/repos/SpongePowered/Ore/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/Ore/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/Ore/tags","blobs_url":"https://api.github.com/repos/SpongePowered/Ore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/Ore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/Ore/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/Ore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/Ore/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/Ore/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/Ore/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/Ore/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/Ore/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/Ore/subscription","commits_url":"https://api.github.com/repos/SpongePowered/Ore/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/Ore/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/Ore/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/Ore/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/Ore/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/Ore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/Ore/merges","archive_url":"https://api.github.com/repos/SpongePowered/Ore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/Ore/downloads","issues_url":"https://api.github.com/repos/SpongePowered/Ore/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/Ore/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/Ore/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/Ore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/Ore/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/Ore/releases{/id}","deployments_url":"https://api.github.com/repos/SpongePowered/Ore/deployments","created_at":"2016-03-01T04:12:53Z","updated_at":"2018-07-18T01:41:38Z","pushed_at":"2018-07-18T13:49:12Z","git_url":"git://github.com/SpongePowered/Ore.git","ssh_url":"git@github.com:SpongePowered/Ore.git","clone_url":"https://github.com/SpongePowered/Ore.git","svn_url":"https://github.com/SpongePowered/Ore","homepage":"https://ore.spongepowered.org/","size":5971,"stargazers_count":43,"watchers_count":43,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":22,"open_issues":106,"watchers":43,"default_branch":"master"}},"base":{"label":"SpongePowered:master","ref":"master","sha":"f04f74ec7e1c7757dbec9b7be4d405e1d9c290f0","user":{"login":"SpongePowered","id":8683473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODM0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":52847258,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjg0NzI1OA==","name":"Ore","full_name":"SpongePowered/Ore","owner":{"login":"SpongePowered","id":8683473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2ODM0NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/Ore","description":"Repository software for Sponge plugins and Forge mods","fork":false,"url":"https://api.github.com/repos/SpongePowered/Ore","forks_url":"https://api.github.com/repos/SpongePowered/Ore/forks","keys_url":"https://api.github.com/repos/SpongePowered/Ore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/Ore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/Ore/teams","hooks_url":"https://api.github.com/repos/SpongePowered/Ore/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/Ore/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/Ore/events","assignees_url":"https://api.github.com/repos/SpongePowered/Ore/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/Ore/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/Ore/tags","blobs_url":"https://api.github.com/repos/SpongePowered/Ore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/Ore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/Ore/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/Ore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/Ore/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/Ore/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/Ore/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/Ore/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/Ore/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/Ore/subscription","commits_url":"https://api.github.com/repos/SpongePowered/Ore/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/Ore/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/Ore/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/Ore/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/Ore/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/Ore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/Ore/merges","archive_url":"https://api.github.com/repos/SpongePowered/Ore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/Ore/downloads","issues_url":"https://api.github.com/repos/SpongePowered/Ore/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/Ore/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/Ore/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/Ore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/Ore/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/Ore/releases{/id}","deployments_url":"https://api.github.com/repos/SpongePowered/Ore/deployments","created_at":"2016-03-01T04:12:53Z","updated_at":"2018-07-18T01:41:38Z","pushed_at":"2018-07-18T13:49:12Z","git_url":"git://github.com/SpongePowered/Ore.git","ssh_url":"git@github.com:SpongePowered/Ore.git","clone_url":"https://github.com/SpongePowered/Ore.git","svn_url":"https://github.com/SpongePowered/Ore","homepage":"https://ore.spongepowered.org/","size":5971,"stargazers_count":43,"watchers_count":43,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":22,"open_issues":106,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/Ore/pulls/575"},"html":{"href":"https://github.com/SpongePowered/Ore/pull/575"},"issue":{"href":"https://api.github.com/repos/SpongePowered/Ore/issues/575"},"comments":{"href":"https://api.github.com/repos/SpongePowered/Ore/issues/575/comments"},"review_comments":{"href":"https://api.github.com/repos/SpongePowered/Ore/pulls/575/comments"},"review_comment":{"href":"https://api.github.com/repos/SpongePowered/Ore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpongePowered/Ore/pulls/575/commits"},"statuses":{"href":"https://api.github.com/repos/SpongePowered/Ore/statuses/e8d2acfdd649a4c44dc19722cf5c9adffb2ef447"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"dualspiral"}}