{"action":"created","issue":{"url":"https://api.github.com/repos/bridgedotnet/Bridge/issues/3709","repository_url":"https://api.github.com/repos/bridgedotnet/Bridge","labels_url":"https://api.github.com/repos/bridgedotnet/Bridge/issues/3709/labels{/name}","comments_url":"https://api.github.com/repos/bridgedotnet/Bridge/issues/3709/comments","events_url":"https://api.github.com/repos/bridgedotnet/Bridge/issues/3709/events","html_url":"https://github.com/bridgedotnet/Bridge/issues/3709","id":358366307,"node_id":"MDU6SXNzdWUzNTgzNjYzMDc=","number":3709,"title":"Guid.ToString seems unneccessarily performance-inefficient","user":{"login":"ChrML","id":38761430,"node_id":"MDQ6VXNlcjM4NzYxNDMw","avatar_url":"https://avatars1.githubusercontent.com/u/38761430?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrML","html_url":"https://github.com/ChrML","followers_url":"https://api.github.com/users/ChrML/followers","following_url":"https://api.github.com/users/ChrML/following{/other_user}","gists_url":"https://api.github.com/users/ChrML/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrML/subscriptions","organizations_url":"https://api.github.com/users/ChrML/orgs","repos_url":"https://api.github.com/users/ChrML/repos","events_url":"https://api.github.com/users/ChrML/events{/privacy}","received_events_url":"https://api.github.com/users/ChrML/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-09T10:10:16Z","updated_at":"2018-09-15T19:11:10Z","closed_at":null,"author_association":"NONE","body":"Not a very important issue, but reporting it and you guys can choose what to do with it.\r\n\r\nBeen tracking the performance of my application lately to improve experience on lower-end pads/cellphones, and seems one of the major single points of slowdowns is caused by Guid.ToString. My application calls it not really more times than neccessary, just once each time a new Guid is generated in a loop with 30-40 items.\r\n\r\nLooking at the calltree caused by Guid.ToString it seems there is significantly room for improvement / complexity reduction. A single call to Guid.ToString seems to:\r\n- Visit 67 distinct javascript functions\r\n- Construct a significant number of temporary items for immediate garbage disposal\r\n\r\n\r\nSee attached calltree.\r\n\r\n![guid tostring](https://user-images.githubusercontent.com/38761430/45263423-74bcf700-b429-11e8-99a1-3122974f7526.png)"},"comment":{"url":"https://api.github.com/repos/bridgedotnet/Bridge/issues/comments/421619003","html_url":"https://github.com/bridgedotnet/Bridge/issues/3709#issuecomment-421619003","issue_url":"https://api.github.com/repos/bridgedotnet/Bridge/issues/3709","id":421619003,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTYxOTAwMw==","user":{"login":"fabriciomurta","id":10730372,"node_id":"MDQ6VXNlcjEwNzMwMzcy","avatar_url":"https://avatars2.githubusercontent.com/u/10730372?v=4","gravatar_id":"","url":"https://api.github.com/users/fabriciomurta","html_url":"https://github.com/fabriciomurta","followers_url":"https://api.github.com/users/fabriciomurta/followers","following_url":"https://api.github.com/users/fabriciomurta/following{/other_user}","gists_url":"https://api.github.com/users/fabriciomurta/gists{/gist_id}","starred_url":"https://api.github.com/users/fabriciomurta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabriciomurta/subscriptions","organizations_url":"https://api.github.com/users/fabriciomurta/orgs","repos_url":"https://api.github.com/users/fabriciomurta/repos","events_url":"https://api.github.com/users/fabriciomurta/events{/privacy}","received_events_url":"https://api.github.com/users/fabriciomurta/received_events","type":"User","site_admin":false},"created_at":"2018-09-15T19:11:10Z","updated_at":"2018-09-15T19:11:10Z","author_association":"CONTRIBUTOR","body":"Thanks for the performance bottleneck pointing! Sometimes to keep code more readable we may not make the best judgement given the frequency or loophole the function may do, and having someone point it so that we can review in the future really helps. At the least, we know that people use it and that it affected negatively a real world application.\r\n\r\nIf this annoys you and you just know what to do to improve it, remember you can always post pull requests to Bridge. They are really welcome!"}}
{"actor":{"display_login":"fabriciomurta"}}