{"action":"created","issue":{"url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/issues/3055","repository_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv","labels_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/issues/3055/labels{/name}","comments_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/issues/3055/comments","events_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/issues/3055/events","html_url":"https://github.com/LibreELEC/LibreELEC.tv/pull/3055","id":373392500,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzMxNTg5","number":3055,"title":"RFC: initial coding standards","user":{"login":"MilhouseVH","id":805038,"node_id":"MDQ6VXNlcjgwNTAzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/805038?v=4","gravatar_id":"","url":"https://api.github.com/users/MilhouseVH","html_url":"https://github.com/MilhouseVH","followers_url":"https://api.github.com/users/MilhouseVH/followers","following_url":"https://api.github.com/users/MilhouseVH/following{/other_user}","gists_url":"https://api.github.com/users/MilhouseVH/gists{/gist_id}","starred_url":"https://api.github.com/users/MilhouseVH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MilhouseVH/subscriptions","organizations_url":"https://api.github.com/users/MilhouseVH/orgs","repos_url":"https://api.github.com/users/MilhouseVH/repos","events_url":"https://api.github.com/users/MilhouseVH/events{/privacy}","received_events_url":"https://api.github.com/users/MilhouseVH/received_events","type":"User","site_admin":false},"labels":[{"id":346342086,"node_id":"MDU6TGFiZWwzNDYzNDIwODY=","url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/labels/BUILDSYSTEM","name":"BUILDSYSTEM","color":"c2e0c6","default":false},{"id":344180628,"node_id":"MDU6TGFiZWwzNDQxODA2Mjg=","url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/labels/DOCUMENTATION","name":"DOCUMENTATION","color":"c2e0c6","default":false},{"id":909329436,"node_id":"MDU6TGFiZWw5MDkzMjk0MzY=","url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/labels/HELP%20WANTED","name":"HELP WANTED","color":"8ea5db","default":false},{"id":343716825,"node_id":"MDU6TGFiZWwzNDM3MTY4MjU=","url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/labels/WORK%20IN%20PROGRESS","name":"WORK IN PROGRESS","color":"ff9933","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2018-10-24T09:37:51Z","updated_at":"2018-11-10T06:06:37Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/pulls/3055","html_url":"https://github.com/LibreELEC/LibreELEC.tv/pull/3055","diff_url":"https://github.com/LibreELEC/LibreELEC.tv/pull/3055.diff","patch_url":"https://github.com/LibreELEC/LibreELEC.tv/pull/3055.patch"},"body":"#### This is for discussion!\r\n\r\nI've created the initial coding \"standards\" list based on my personal interpretation of how the code is currently written, and should be written. It is an incomplete list. It may also be wrong.\r\n\r\nAny existing standard in the list is open for change (for instance, we could decide to use `source` instead of `.`, or always use braces etc.).\r\n\r\nWe can change existing code only once we agree what the coding standard for the project is, or should be. It's surprising that we have survived this long without such a document.\r\n\r\nPlease discuss and suggest changes - if we can agree on changes (maybe use thumbsup/thumbsdown reactions to a suggestion?) then I will update the list.\r\n\r\nEventually we can merge this and new code should then conform to the \"standard\", and existing code can be updated (either en-mass or as it is changed - to be decided...)."},"comment":{"url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/issues/comments/437561414","html_url":"https://github.com/LibreELEC/LibreELEC.tv/pull/3055#issuecomment-437561414","issue_url":"https://api.github.com/repos/LibreELEC/LibreELEC.tv/issues/3055","id":437561414,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzU2MTQxNA==","user":{"login":"antonlacon","id":8174351,"node_id":"MDQ6VXNlcjgxNzQzNTE=","avatar_url":"https://avatars1.githubusercontent.com/u/8174351?v=4","gravatar_id":"","url":"https://api.github.com/users/antonlacon","html_url":"https://github.com/antonlacon","followers_url":"https://api.github.com/users/antonlacon/followers","following_url":"https://api.github.com/users/antonlacon/following{/other_user}","gists_url":"https://api.github.com/users/antonlacon/gists{/gist_id}","starred_url":"https://api.github.com/users/antonlacon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonlacon/subscriptions","organizations_url":"https://api.github.com/users/antonlacon/orgs","repos_url":"https://api.github.com/users/antonlacon/repos","events_url":"https://api.github.com/users/antonlacon/events{/privacy}","received_events_url":"https://api.github.com/users/antonlacon/received_events","type":"User","site_admin":false},"created_at":"2018-11-10T06:06:37Z","updated_at":"2018-11-10T06:06:37Z","author_association":"CONTRIBUTOR","body":"> @antonlacon thanks - added reference to `[ test1 -o test2 ]` versus `[[ test1 ]] || [[ test2 ]]`.\r\n\r\nI came across this: https://stackoverflow.com/questions/3184164/what-is-the-bash-test-command-evaluation-order when looking for test operator precedence in reviewing if I was missing something in the if test comment inPR3098. Of note is that `bash` handles the `-a and -o` operators differently from `&& and ||`.\r\n\r\nOf note is that if you have a test result like `TRUE or FALSE`, then whatever evaluation reaches `FALSE` will not be tested when using `||` (because the `TRUE` already determines the end result), but will be evaluated when using `-o`.\r\n\r\nIt may be a minor micro-optimization, but may be worth changing going forward considering some of the tests fire off subshells?"}}
{"actor":{"display_login":"antonlacon"}}