{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/hyl/node-warc/pulls/3","id":224530665,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTMwNjY1","html_url":"https://github.com/hyl/node-warc/pull/3","diff_url":"https://github.com/hyl/node-warc/pull/3.diff","patch_url":"https://github.com/hyl/node-warc/pull/3.patch","issue_url":"https://api.github.com/repos/hyl/node-warc/issues/3","number":3,"state":"open","locked":false,"title":"Added support for capturing Request (library!) requests","user":{"login":"hyl","id":1311302,"node_id":"MDQ6VXNlcjEzMTEzMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1311302?v=4","gravatar_id":"","url":"https://api.github.com/users/hyl","html_url":"https://github.com/hyl","followers_url":"https://api.github.com/users/hyl/followers","following_url":"https://api.github.com/users/hyl/following{/other_user}","gists_url":"https://api.github.com/users/hyl/gists{/gist_id}","starred_url":"https://api.github.com/users/hyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyl/subscriptions","organizations_url":"https://api.github.com/users/hyl/orgs","repos_url":"https://api.github.com/users/hyl/repos","events_url":"https://api.github.com/users/hyl/events{/privacy}","received_events_url":"https://api.github.com/users/hyl/received_events","type":"User","site_admin":false},"body":"Hi! I've written a WARC writer for [request](https://github.com/request/request), erm... requests. Due to the nature of WARC files and the opinionated defaults that `request` has, the request made (or the Request library defaults) need to be instantiated with the following options:\r\n\r\n```\r\n{\r\n    resolveWithFullResponse: true, // get all request and response properties\r\n    simple: false // return 4xx, 5xx etc as \"successful\" responses so we can WARC the result \r\n}\r\n```\r\n\r\nAgain, using this PR to try and kick off a wider discussion on this: the main thing that concerns me is the need to configure `request` in a certain matter for WARC writing to work. Could we optionally expose our own version of `request` from inside `node-warc` as a RequestCap that is pre-configured to make the request in the right manner?","created_at":"2018-10-21T10:07:51Z","updated_at":"2018-10-21T10:07:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyl/node-warc/pulls/3/commits","review_comments_url":"https://api.github.com/repos/hyl/node-warc/pulls/3/comments","review_comment_url":"https://api.github.com/repos/hyl/node-warc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyl/node-warc/issues/3/comments","statuses_url":"https://api.github.com/repos/hyl/node-warc/statuses/dbd119865d70e99fc2a6c1ab5ff6378b39e033c9","head":{"label":"hyl:feature/request-library-generator","ref":"feature/request-library-generator","sha":"dbd119865d70e99fc2a6c1ab5ff6378b39e033c9","user":{"login":"hyl","id":1311302,"node_id":"MDQ6VXNlcjEzMTEzMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1311302?v=4","gravatar_id":"","url":"https://api.github.com/users/hyl","html_url":"https://github.com/hyl","followers_url":"https://api.github.com/users/hyl/followers","following_url":"https://api.github.com/users/hyl/following{/other_user}","gists_url":"https://api.github.com/users/hyl/gists{/gist_id}","starred_url":"https://api.github.com/users/hyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyl/subscriptions","organizations_url":"https://api.github.com/users/hyl/orgs","repos_url":"https://api.github.com/users/hyl/repos","events_url":"https://api.github.com/users/hyl/events{/privacy}","received_events_url":"https://api.github.com/users/hyl/received_events","type":"User","site_admin":false},"repo":{"id":147105038,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcxMDUwMzg=","name":"node-warc","full_name":"hyl/node-warc","private":false,"owner":{"login":"hyl","id":1311302,"node_id":"MDQ6VXNlcjEzMTEzMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1311302?v=4","gravatar_id":"","url":"https://api.github.com/users/hyl","html_url":"https://github.com/hyl","followers_url":"https://api.github.com/users/hyl/followers","following_url":"https://api.github.com/users/hyl/following{/other_user}","gists_url":"https://api.github.com/users/hyl/gists{/gist_id}","starred_url":"https://api.github.com/users/hyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyl/subscriptions","organizations_url":"https://api.github.com/users/hyl/orgs","repos_url":"https://api.github.com/users/hyl/repos","events_url":"https://api.github.com/users/hyl/events{/privacy}","received_events_url":"https://api.github.com/users/hyl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hyl/node-warc","description":"Parse And Create Web ARChive  (WARC) files with node.js","fork":true,"url":"https://api.github.com/repos/hyl/node-warc","forks_url":"https://api.github.com/repos/hyl/node-warc/forks","keys_url":"https://api.github.com/repos/hyl/node-warc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyl/node-warc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyl/node-warc/teams","hooks_url":"https://api.github.com/repos/hyl/node-warc/hooks","issue_events_url":"https://api.github.com/repos/hyl/node-warc/issues/events{/number}","events_url":"https://api.github.com/repos/hyl/node-warc/events","assignees_url":"https://api.github.com/repos/hyl/node-warc/assignees{/user}","branches_url":"https://api.github.com/repos/hyl/node-warc/branches{/branch}","tags_url":"https://api.github.com/repos/hyl/node-warc/tags","blobs_url":"https://api.github.com/repos/hyl/node-warc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyl/node-warc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyl/node-warc/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyl/node-warc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyl/node-warc/statuses/{sha}","languages_url":"https://api.github.com/repos/hyl/node-warc/languages","stargazers_url":"https://api.github.com/repos/hyl/node-warc/stargazers","contributors_url":"https://api.github.com/repos/hyl/node-warc/contributors","subscribers_url":"https://api.github.com/repos/hyl/node-warc/subscribers","subscription_url":"https://api.github.com/repos/hyl/node-warc/subscription","commits_url":"https://api.github.com/repos/hyl/node-warc/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyl/node-warc/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyl/node-warc/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyl/node-warc/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyl/node-warc/contents/{+path}","compare_url":"https://api.github.com/repos/hyl/node-warc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyl/node-warc/merges","archive_url":"https://api.github.com/repos/hyl/node-warc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyl/node-warc/downloads","issues_url":"https://api.github.com/repos/hyl/node-warc/issues{/number}","pulls_url":"https://api.github.com/repos/hyl/node-warc/pulls{/number}","milestones_url":"https://api.github.com/repos/hyl/node-warc/milestones{/number}","notifications_url":"https://api.github.com/repos/hyl/node-warc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyl/node-warc/labels{/name}","releases_url":"https://api.github.com/repos/hyl/node-warc/releases{/id}","deployments_url":"https://api.github.com/repos/hyl/node-warc/deployments","created_at":"2018-09-02T17:02:49Z","updated_at":"2018-10-19T09:25:24Z","pushed_at":"2018-10-21T10:01:53Z","git_url":"git://github.com/hyl/node-warc.git","ssh_url":"git@github.com:hyl/node-warc.git","clone_url":"https://github.com/hyl/node-warc.git","svn_url":"https://github.com/hyl/node-warc","homepage":"","size":3341,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hyl:master","ref":"master","sha":"24b8024ba8bf38b232d6c0a68cee121500a8d536","user":{"login":"hyl","id":1311302,"node_id":"MDQ6VXNlcjEzMTEzMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1311302?v=4","gravatar_id":"","url":"https://api.github.com/users/hyl","html_url":"https://github.com/hyl","followers_url":"https://api.github.com/users/hyl/followers","following_url":"https://api.github.com/users/hyl/following{/other_user}","gists_url":"https://api.github.com/users/hyl/gists{/gist_id}","starred_url":"https://api.github.com/users/hyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyl/subscriptions","organizations_url":"https://api.github.com/users/hyl/orgs","repos_url":"https://api.github.com/users/hyl/repos","events_url":"https://api.github.com/users/hyl/events{/privacy}","received_events_url":"https://api.github.com/users/hyl/received_events","type":"User","site_admin":false},"repo":{"id":147105038,"node_id":"MDEwOlJlcG9zaXRvcnkxNDcxMDUwMzg=","name":"node-warc","full_name":"hyl/node-warc","private":false,"owner":{"login":"hyl","id":1311302,"node_id":"MDQ6VXNlcjEzMTEzMDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1311302?v=4","gravatar_id":"","url":"https://api.github.com/users/hyl","html_url":"https://github.com/hyl","followers_url":"https://api.github.com/users/hyl/followers","following_url":"https://api.github.com/users/hyl/following{/other_user}","gists_url":"https://api.github.com/users/hyl/gists{/gist_id}","starred_url":"https://api.github.com/users/hyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyl/subscriptions","organizations_url":"https://api.github.com/users/hyl/orgs","repos_url":"https://api.github.com/users/hyl/repos","events_url":"https://api.github.com/users/hyl/events{/privacy}","received_events_url":"https://api.github.com/users/hyl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hyl/node-warc","description":"Parse And Create Web ARChive  (WARC) files with node.js","fork":true,"url":"https://api.github.com/repos/hyl/node-warc","forks_url":"https://api.github.com/repos/hyl/node-warc/forks","keys_url":"https://api.github.com/repos/hyl/node-warc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyl/node-warc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyl/node-warc/teams","hooks_url":"https://api.github.com/repos/hyl/node-warc/hooks","issue_events_url":"https://api.github.com/repos/hyl/node-warc/issues/events{/number}","events_url":"https://api.github.com/repos/hyl/node-warc/events","assignees_url":"https://api.github.com/repos/hyl/node-warc/assignees{/user}","branches_url":"https://api.github.com/repos/hyl/node-warc/branches{/branch}","tags_url":"https://api.github.com/repos/hyl/node-warc/tags","blobs_url":"https://api.github.com/repos/hyl/node-warc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyl/node-warc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyl/node-warc/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyl/node-warc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyl/node-warc/statuses/{sha}","languages_url":"https://api.github.com/repos/hyl/node-warc/languages","stargazers_url":"https://api.github.com/repos/hyl/node-warc/stargazers","contributors_url":"https://api.github.com/repos/hyl/node-warc/contributors","subscribers_url":"https://api.github.com/repos/hyl/node-warc/subscribers","subscription_url":"https://api.github.com/repos/hyl/node-warc/subscription","commits_url":"https://api.github.com/repos/hyl/node-warc/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyl/node-warc/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyl/node-warc/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyl/node-warc/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyl/node-warc/contents/{+path}","compare_url":"https://api.github.com/repos/hyl/node-warc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyl/node-warc/merges","archive_url":"https://api.github.com/repos/hyl/node-warc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyl/node-warc/downloads","issues_url":"https://api.github.com/repos/hyl/node-warc/issues{/number}","pulls_url":"https://api.github.com/repos/hyl/node-warc/pulls{/number}","milestones_url":"https://api.github.com/repos/hyl/node-warc/milestones{/number}","notifications_url":"https://api.github.com/repos/hyl/node-warc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyl/node-warc/labels{/name}","releases_url":"https://api.github.com/repos/hyl/node-warc/releases{/id}","deployments_url":"https://api.github.com/repos/hyl/node-warc/deployments","created_at":"2018-09-02T17:02:49Z","updated_at":"2018-10-19T09:25:24Z","pushed_at":"2018-10-21T10:01:53Z","git_url":"git://github.com/hyl/node-warc.git","ssh_url":"git@github.com:hyl/node-warc.git","clone_url":"https://github.com/hyl/node-warc.git","svn_url":"https://github.com/hyl/node-warc","homepage":"","size":3341,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyl/node-warc/pulls/3"},"html":{"href":"https://github.com/hyl/node-warc/pull/3"},"issue":{"href":"https://api.github.com/repos/hyl/node-warc/issues/3"},"comments":{"href":"https://api.github.com/repos/hyl/node-warc/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/hyl/node-warc/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/hyl/node-warc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyl/node-warc/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/hyl/node-warc/statuses/dbd119865d70e99fc2a6c1ab5ff6378b39e033c9"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":77,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"hyl"}}