{"action":"created","comment":{"url":"https://api.github.com/repos/dedemorton/beats-docs-review/pulls/comments/230853995","pull_request_review_id":171686841,"id":230853995,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDg1Mzk5NQ==","diff_hunk":"@@ -0,0 +1,66 @@\n+[[configuration-general-options]]\n+== Specify general settings\n+\n+You can specify settings in the +{beatname_lc}.yml+ config file to control the\n+general behavior of {beatname_uc}. This includes:\n+\n+* <<configuration-global-options,Global options>> that control things like\n+publisher behavior and the location of some files.\n+\n+* <<configuration-general,General options>> that are supported by all Elastic\n+Beats.\n+\n+[float]\n+[[configuration-global-options]]\n+=== Global {beatname_uc} configuration options\n+\n+These options are in the +{beatname_lc}+ namespace.\n+\n+[float]\n+[id=\"{beatname_lc}-registry-file\"]\n+==== `registry_file`\n+\n+The name of the registry file. If a relative path is used, it is considered relative to the\n+data path. See the <<directory-layout>> section for details. The default is `${path.data}/registry`.\n+\n+[\"source\",\"sh\",subs=\"attributes\"]\n+----\n+{beatname_lc}.registry_file: registry\n+----\n+\n+[float]\n+[id=\"{beatname_lc}-backoff\"]\n+==== `backoff`\n+\n+The number of seconds to wait before trying to read again from journals. The\n+default is 1s.","path":"journalbeat/docs/general-options.asciidoc","position":36,"original_position":36,"commit_id":"be9a996830be63c7341014f01fe3bc0a0808ff31","original_commit_id":"be9a996830be63c7341014f01fe3bc0a0808ff31","user":{"login":"urso","id":75886,"node_id":"MDQ6VXNlcjc1ODg2","avatar_url":"https://avatars1.githubusercontent.com/u/75886?v=4","gravatar_id":"","url":"https://api.github.com/users/urso","html_url":"https://github.com/urso","followers_url":"https://api.github.com/users/urso/followers","following_url":"https://api.github.com/users/urso/following{/other_user}","gists_url":"https://api.github.com/users/urso/gists{/gist_id}","starred_url":"https://api.github.com/users/urso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urso/subscriptions","organizations_url":"https://api.github.com/users/urso/orgs","repos_url":"https://api.github.com/users/urso/repos","events_url":"https://api.github.com/users/urso/events{/privacy}","received_events_url":"https://api.github.com/users/urso/received_events","type":"User","site_admin":false},"body":"why is backoff global?","created_at":"2018-11-05T18:08:53Z","updated_at":"2018-11-05T18:08:53Z","html_url":"https://github.com/dedemorton/beats-docs-review/pull/1#discussion_r230853995","pull_request_url":"https://api.github.com/repos/dedemorton/beats-docs-review/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dedemorton/beats-docs-review/pulls/comments/230853995"},"html":{"href":"https://github.com/dedemorton/beats-docs-review/pull/1#discussion_r230853995"},"pull_request":{"href":"https://api.github.com/repos/dedemorton/beats-docs-review/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/dedemorton/beats-docs-review/pulls/1","id":227788492,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Nzg4NDky","html_url":"https://github.com/dedemorton/beats-docs-review/pull/1","diff_url":"https://github.com/dedemorton/beats-docs-review/pull/1.diff","patch_url":"https://github.com/dedemorton/beats-docs-review/pull/1.patch","issue_url":"https://api.github.com/repos/dedemorton/beats-docs-review/issues/1","number":1,"state":"open","locked":false,"title":"Full review of files in beats/journalbeat/docs","user":{"login":"dedemorton","id":14206422,"node_id":"MDQ6VXNlcjE0MjA2NDIy","avatar_url":"https://avatars3.githubusercontent.com/u/14206422?v=4","gravatar_id":"","url":"https://api.github.com/users/dedemorton","html_url":"https://github.com/dedemorton","followers_url":"https://api.github.com/users/dedemorton/followers","following_url":"https://api.github.com/users/dedemorton/following{/other_user}","gists_url":"https://api.github.com/users/dedemorton/gists{/gist_id}","starred_url":"https://api.github.com/users/dedemorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedemorton/subscriptions","organizations_url":"https://api.github.com/users/dedemorton/orgs","repos_url":"https://api.github.com/users/dedemorton/repos","events_url":"https://api.github.com/users/dedemorton/events{/privacy}","received_events_url":"https://api.github.com/users/dedemorton/received_events","type":"User","site_admin":false},"body":"This PR contains all files added to /beats/journalbeat/docs for 6.5. It does not include files from beats/libbeat/docs. The beats-docs-review repository is intended for review purposes only. You will not be able to build/test the files in this repo.\r\n\r\nPlease review the proposed additions and add your comments to this PR. After we're through reviewing/updating the files in /beats/journalbeat/docs, you'll have an opportunity to do a final review of all the files (including the files from libbeat) in the Beats repo.\r\n\r\nYou can preview the docs here: https://journalbeat-62556.firebaseapp.com/index.html\r\n\r\nHere's a list of open issues that you can help me resolve. Please identify anything else that is missing:\r\n\r\n- [ ] Verify package names in the installation topic (they were missing from BC1).\r\n- [ ] Check to see if apt/yum repos will be available. If not, remove the note.\r\n- [ ] Verify that `seek: cursor` is the default.\r\n- [ ] Determine whether we want to recommend using sudo in the install topic.\r\n- [ ] Improve descriptions of `backoff_factor` and and `max_backoff`. Looked at the descritpions for Filebeat, but TBH I couldn't follow them very well. \r\n\r\nNote that I plan to do the following work in separate PRs:\r\n\r\n- Update the command reference (I'm also updating it for Functionbeat)\r\n- Add linux command examples to the shared files.\r\n\r\nWhen this review is closed, go to https://github.com/elastic/beats/pull/8864 to complete the final review.\r\n","created_at":"2018-11-01T23:18:57Z","updated_at":"2018-11-05T18:08:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59f729c3ff750c9c549b1ad4f329aeff30880570","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1113221571,"node_id":"MDU6TGFiZWwxMTEzMjIxNTcx","url":"https://api.github.com/repos/dedemorton/beats-docs-review/labels/6.5","name":"6.5","color":"51ff62","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dedemorton/beats-docs-review/pulls/1/commits","review_comments_url":"https://api.github.com/repos/dedemorton/beats-docs-review/pulls/1/comments","review_comment_url":"https://api.github.com/repos/dedemorton/beats-docs-review/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dedemorton/beats-docs-review/issues/1/comments","statuses_url":"https://api.github.com/repos/dedemorton/beats-docs-review/statuses/be9a996830be63c7341014f01fe3bc0a0808ff31","head":{"label":"dedemorton:journalbeat-docs","ref":"journalbeat-docs","sha":"be9a996830be63c7341014f01fe3bc0a0808ff31","user":{"login":"dedemorton","id":14206422,"node_id":"MDQ6VXNlcjE0MjA2NDIy","avatar_url":"https://avatars3.githubusercontent.com/u/14206422?v=4","gravatar_id":"","url":"https://api.github.com/users/dedemorton","html_url":"https://github.com/dedemorton","followers_url":"https://api.github.com/users/dedemorton/followers","following_url":"https://api.github.com/users/dedemorton/following{/other_user}","gists_url":"https://api.github.com/users/dedemorton/gists{/gist_id}","starred_url":"https://api.github.com/users/dedemorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedemorton/subscriptions","organizations_url":"https://api.github.com/users/dedemorton/orgs","repos_url":"https://api.github.com/users/dedemorton/repos","events_url":"https://api.github.com/users/dedemorton/events{/privacy}","received_events_url":"https://api.github.com/users/dedemorton/received_events","type":"User","site_admin":false},"repo":{"id":155784229,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU3ODQyMjk=","name":"beats-docs-review","full_name":"dedemorton/beats-docs-review","private":false,"owner":{"login":"dedemorton","id":14206422,"node_id":"MDQ6VXNlcjE0MjA2NDIy","avatar_url":"https://avatars3.githubusercontent.com/u/14206422?v=4","gravatar_id":"","url":"https://api.github.com/users/dedemorton","html_url":"https://github.com/dedemorton","followers_url":"https://api.github.com/users/dedemorton/followers","following_url":"https://api.github.com/users/dedemorton/following{/other_user}","gists_url":"https://api.github.com/users/dedemorton/gists{/gist_id}","starred_url":"https://api.github.com/users/dedemorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedemorton/subscriptions","organizations_url":"https://api.github.com/users/dedemorton/orgs","repos_url":"https://api.github.com/users/dedemorton/repos","events_url":"https://api.github.com/users/dedemorton/events{/privacy}","received_events_url":"https://api.github.com/users/dedemorton/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dedemorton/beats-docs-review","description":"Documentation reviews for the Elastic Beats project","fork":false,"url":"https://api.github.com/repos/dedemorton/beats-docs-review","forks_url":"https://api.github.com/repos/dedemorton/beats-docs-review/forks","keys_url":"https://api.github.com/repos/dedemorton/beats-docs-review/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dedemorton/beats-docs-review/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dedemorton/beats-docs-review/teams","hooks_url":"https://api.github.com/repos/dedemorton/beats-docs-review/hooks","issue_events_url":"https://api.github.com/repos/dedemorton/beats-docs-review/issues/events{/number}","events_url":"https://api.github.com/repos/dedemorton/beats-docs-review/events","assignees_url":"https://api.github.com/repos/dedemorton/beats-docs-review/assignees{/user}","branches_url":"https://api.github.com/repos/dedemorton/beats-docs-review/branches{/branch}","tags_url":"https://api.github.com/repos/dedemorton/beats-docs-review/tags","blobs_url":"https://api.github.com/repos/dedemorton/beats-docs-review/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dedemorton/beats-docs-review/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dedemorton/beats-docs-review/git/refs{/sha}","trees_url":"https://api.github.com/repos/dedemorton/beats-docs-review/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dedemorton/beats-docs-review/statuses/{sha}","languages_url":"https://api.github.com/repos/dedemorton/beats-docs-review/languages","stargazers_url":"https://api.github.com/repos/dedemorton/beats-docs-review/stargazers","contributors_url":"https://api.github.com/repos/dedemorton/beats-docs-review/contributors","subscribers_url":"https://api.github.com/repos/dedemorton/beats-docs-review/subscribers","subscription_url":"https://api.github.com/repos/dedemorton/beats-docs-review/subscription","commits_url":"https://api.github.com/repos/dedemorton/beats-docs-review/commits{/sha}","git_commits_url":"https://api.github.com/repos/dedemorton/beats-docs-review/git/commits{/sha}","comments_url":"https://api.github.com/repos/dedemorton/beats-docs-review/comments{/number}","issue_comment_url":"https://api.github.com/repos/dedemorton/beats-docs-review/issues/comments{/number}","contents_url":"https://api.github.com/repos/dedemorton/beats-docs-review/contents/{+path}","compare_url":"https://api.github.com/repos/dedemorton/beats-docs-review/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dedemorton/beats-docs-review/merges","archive_url":"https://api.github.com/repos/dedemorton/beats-docs-review/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dedemorton/beats-docs-review/downloads","issues_url":"https://api.github.com/repos/dedemorton/beats-docs-review/issues{/number}","pulls_url":"https://api.github.com/repos/dedemorton/beats-docs-review/pulls{/number}","milestones_url":"https://api.github.com/repos/dedemorton/beats-docs-review/milestones{/number}","notifications_url":"https://api.github.com/repos/dedemorton/beats-docs-review/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dedemorton/beats-docs-review/labels{/name}","releases_url":"https://api.github.com/repos/dedemorton/beats-docs-review/releases{/id}","deployments_url":"https://api.github.com/repos/dedemorton/beats-docs-review/deployments","created_at":"2018-11-01T22:37:18Z","updated_at":"2018-11-01T22:37:20Z","pushed_at":"2018-11-01T23:18:58Z","git_url":"git://github.com/dedemorton/beats-docs-review.git","ssh_url":"git@github.com:dedemorton/beats-docs-review.git","clone_url":"https://github.com/dedemorton/beats-docs-review.git","svn_url":"https://github.com/dedemorton/beats-docs-review","homepage":null,"size":16,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dedemorton:master","ref":"master","sha":"d6fc3745873683ee5c47cf274eacf37ae26009ba","user":{"login":"dedemorton","id":14206422,"node_id":"MDQ6VXNlcjE0MjA2NDIy","avatar_url":"https://avatars3.githubusercontent.com/u/14206422?v=4","gravatar_id":"","url":"https://api.github.com/users/dedemorton","html_url":"https://github.com/dedemorton","followers_url":"https://api.github.com/users/dedemorton/followers","following_url":"https://api.github.com/users/dedemorton/following{/other_user}","gists_url":"https://api.github.com/users/dedemorton/gists{/gist_id}","starred_url":"https://api.github.com/users/dedemorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedemorton/subscriptions","organizations_url":"https://api.github.com/users/dedemorton/orgs","repos_url":"https://api.github.com/users/dedemorton/repos","events_url":"https://api.github.com/users/dedemorton/events{/privacy}","received_events_url":"https://api.github.com/users/dedemorton/received_events","type":"User","site_admin":false},"repo":{"id":155784229,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU3ODQyMjk=","name":"beats-docs-review","full_name":"dedemorton/beats-docs-review","private":false,"owner":{"login":"dedemorton","id":14206422,"node_id":"MDQ6VXNlcjE0MjA2NDIy","avatar_url":"https://avatars3.githubusercontent.com/u/14206422?v=4","gravatar_id":"","url":"https://api.github.com/users/dedemorton","html_url":"https://github.com/dedemorton","followers_url":"https://api.github.com/users/dedemorton/followers","following_url":"https://api.github.com/users/dedemorton/following{/other_user}","gists_url":"https://api.github.com/users/dedemorton/gists{/gist_id}","starred_url":"https://api.github.com/users/dedemorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dedemorton/subscriptions","organizations_url":"https://api.github.com/users/dedemorton/orgs","repos_url":"https://api.github.com/users/dedemorton/repos","events_url":"https://api.github.com/users/dedemorton/events{/privacy}","received_events_url":"https://api.github.com/users/dedemorton/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dedemorton/beats-docs-review","description":"Documentation reviews for the Elastic Beats project","fork":false,"url":"https://api.github.com/repos/dedemorton/beats-docs-review","forks_url":"https://api.github.com/repos/dedemorton/beats-docs-review/forks","keys_url":"https://api.github.com/repos/dedemorton/beats-docs-review/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dedemorton/beats-docs-review/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dedemorton/beats-docs-review/teams","hooks_url":"https://api.github.com/repos/dedemorton/beats-docs-review/hooks","issue_events_url":"https://api.github.com/repos/dedemorton/beats-docs-review/issues/events{/number}","events_url":"https://api.github.com/repos/dedemorton/beats-docs-review/events","assignees_url":"https://api.github.com/repos/dedemorton/beats-docs-review/assignees{/user}","branches_url":"https://api.github.com/repos/dedemorton/beats-docs-review/branches{/branch}","tags_url":"https://api.github.com/repos/dedemorton/beats-docs-review/tags","blobs_url":"https://api.github.com/repos/dedemorton/beats-docs-review/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dedemorton/beats-docs-review/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dedemorton/beats-docs-review/git/refs{/sha}","trees_url":"https://api.github.com/repos/dedemorton/beats-docs-review/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dedemorton/beats-docs-review/statuses/{sha}","languages_url":"https://api.github.com/repos/dedemorton/beats-docs-review/languages","stargazers_url":"https://api.github.com/repos/dedemorton/beats-docs-review/stargazers","contributors_url":"https://api.github.com/repos/dedemorton/beats-docs-review/contributors","subscribers_url":"https://api.github.com/repos/dedemorton/beats-docs-review/subscribers","subscription_url":"https://api.github.com/repos/dedemorton/beats-docs-review/subscription","commits_url":"https://api.github.com/repos/dedemorton/beats-docs-review/commits{/sha}","git_commits_url":"https://api.github.com/repos/dedemorton/beats-docs-review/git/commits{/sha}","comments_url":"https://api.github.com/repos/dedemorton/beats-docs-review/comments{/number}","issue_comment_url":"https://api.github.com/repos/dedemorton/beats-docs-review/issues/comments{/number}","contents_url":"https://api.github.com/repos/dedemorton/beats-docs-review/contents/{+path}","compare_url":"https://api.github.com/repos/dedemorton/beats-docs-review/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dedemorton/beats-docs-review/merges","archive_url":"https://api.github.com/repos/dedemorton/beats-docs-review/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dedemorton/beats-docs-review/downloads","issues_url":"https://api.github.com/repos/dedemorton/beats-docs-review/issues{/number}","pulls_url":"https://api.github.com/repos/dedemorton/beats-docs-review/pulls{/number}","milestones_url":"https://api.github.com/repos/dedemorton/beats-docs-review/milestones{/number}","notifications_url":"https://api.github.com/repos/dedemorton/beats-docs-review/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dedemorton/beats-docs-review/labels{/name}","releases_url":"https://api.github.com/repos/dedemorton/beats-docs-review/releases{/id}","deployments_url":"https://api.github.com/repos/dedemorton/beats-docs-review/deployments","created_at":"2018-11-01T22:37:18Z","updated_at":"2018-11-01T22:37:20Z","pushed_at":"2018-11-01T23:18:58Z","git_url":"git://github.com/dedemorton/beats-docs-review.git","ssh_url":"git@github.com:dedemorton/beats-docs-review.git","clone_url":"https://github.com/dedemorton/beats-docs-review.git","svn_url":"https://github.com/dedemorton/beats-docs-review","homepage":null,"size":16,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dedemorton/beats-docs-review/pulls/1"},"html":{"href":"https://github.com/dedemorton/beats-docs-review/pull/1"},"issue":{"href":"https://api.github.com/repos/dedemorton/beats-docs-review/issues/1"},"comments":{"href":"https://api.github.com/repos/dedemorton/beats-docs-review/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/dedemorton/beats-docs-review/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/dedemorton/beats-docs-review/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dedemorton/beats-docs-review/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/dedemorton/beats-docs-review/statuses/be9a996830be63c7341014f01fe3bc0a0808ff31"}},"author_association":"OWNER"}}
{"actor":{"display_login":"urso"}}