{"action":"closed","number":179,"pull_request":{"url":"https://api.github.com/repos/google/ci_edit/pulls/179","id":235768347,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NzY4MzQ3","html_url":"https://github.com/google/ci_edit/pull/179","diff_url":"https://github.com/google/ci_edit/pull/179.diff","patch_url":"https://github.com/google/ci_edit/pull/179.patch","issue_url":"https://api.github.com/repos/google/ci_edit/issues/179","number":179,"state":"closed","locked":false,"title":"Correct improper 'assert' statements","user":{"login":"cclauss","id":3709715,"node_id":"MDQ6VXNlcjM3MDk3MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3709715?v=4","gravatar_id":"","url":"https://api.github.com/users/cclauss","html_url":"https://github.com/cclauss","followers_url":"https://api.github.com/users/cclauss/followers","following_url":"https://api.github.com/users/cclauss/following{/other_user}","gists_url":"https://api.github.com/users/cclauss/gists{/gist_id}","starred_url":"https://api.github.com/users/cclauss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclauss/subscriptions","organizations_url":"https://api.github.com/users/cclauss/orgs","repos_url":"https://api.github.com/users/cclauss/repos","events_url":"https://api.github.com/users/cclauss/events{/privacy}","received_events_url":"https://api.github.com/users/cclauss/received_events","type":"User","site_admin":false},"body":"From: https://docs.python.org/3/reference/simple_stmts.html?#the-assert-statement\r\n__assert__ statements in Python are equivalent to:\r\n* __if not expression1: raise AssertionError(expression2)__\r\n\r\nWhich means that __assert type(string), unicode__ is equivalent to:\r\n* __if not bool(type(string)): raise AssertionError(unicode)__\r\n\r\nThe assertions will _always_ pass because even __bool(type(None))__ is True.\r\n\r\nAlso, Python best practice is to avoid directly comparing types but to use __isinstance()__ instead.","created_at":"2018-12-04T11:11:12Z","updated_at":"2018-12-14T03:30:18Z","closed_at":"2018-12-14T03:30:18Z","merged_at":"2018-12-14T03:30:18Z","merge_commit_sha":"b6c3733296441709bafa0327a546635dfe91b9d0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/ci_edit/pulls/179/commits","review_comments_url":"https://api.github.com/repos/google/ci_edit/pulls/179/comments","review_comment_url":"https://api.github.com/repos/google/ci_edit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/ci_edit/issues/179/comments","statuses_url":"https://api.github.com/repos/google/ci_edit/statuses/27ea5497e42770f006ebbf94a770c0bb501d0a93","head":{"label":"cclauss:patch-2","ref":"patch-2","sha":"27ea5497e42770f006ebbf94a770c0bb501d0a93","user":{"login":"cclauss","id":3709715,"node_id":"MDQ6VXNlcjM3MDk3MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3709715?v=4","gravatar_id":"","url":"https://api.github.com/users/cclauss","html_url":"https://github.com/cclauss","followers_url":"https://api.github.com/users/cclauss/followers","following_url":"https://api.github.com/users/cclauss/following{/other_user}","gists_url":"https://api.github.com/users/cclauss/gists{/gist_id}","starred_url":"https://api.github.com/users/cclauss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclauss/subscriptions","organizations_url":"https://api.github.com/users/cclauss/orgs","repos_url":"https://api.github.com/users/cclauss/repos","events_url":"https://api.github.com/users/cclauss/events{/privacy}","received_events_url":"https://api.github.com/users/cclauss/received_events","type":"User","site_admin":false},"repo":{"id":160340061,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAzNDAwNjE=","name":"ci_edit","full_name":"cclauss/ci_edit","private":false,"owner":{"login":"cclauss","id":3709715,"node_id":"MDQ6VXNlcjM3MDk3MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3709715?v=4","gravatar_id":"","url":"https://api.github.com/users/cclauss","html_url":"https://github.com/cclauss","followers_url":"https://api.github.com/users/cclauss/followers","following_url":"https://api.github.com/users/cclauss/following{/other_user}","gists_url":"https://api.github.com/users/cclauss/gists{/gist_id}","starred_url":"https://api.github.com/users/cclauss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cclauss/subscriptions","organizations_url":"https://api.github.com/users/cclauss/orgs","repos_url":"https://api.github.com/users/cclauss/repos","events_url":"https://api.github.com/users/cclauss/events{/privacy}","received_events_url":"https://api.github.com/users/cclauss/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cclauss/ci_edit","description":"A terminal text editor with mouse support and ctrl+Q to quit.","fork":true,"url":"https://api.github.com/repos/cclauss/ci_edit","forks_url":"https://api.github.com/repos/cclauss/ci_edit/forks","keys_url":"https://api.github.com/repos/cclauss/ci_edit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cclauss/ci_edit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cclauss/ci_edit/teams","hooks_url":"https://api.github.com/repos/cclauss/ci_edit/hooks","issue_events_url":"https://api.github.com/repos/cclauss/ci_edit/issues/events{/number}","events_url":"https://api.github.com/repos/cclauss/ci_edit/events","assignees_url":"https://api.github.com/repos/cclauss/ci_edit/assignees{/user}","branches_url":"https://api.github.com/repos/cclauss/ci_edit/branches{/branch}","tags_url":"https://api.github.com/repos/cclauss/ci_edit/tags","blobs_url":"https://api.github.com/repos/cclauss/ci_edit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cclauss/ci_edit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cclauss/ci_edit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cclauss/ci_edit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cclauss/ci_edit/statuses/{sha}","languages_url":"https://api.github.com/repos/cclauss/ci_edit/languages","stargazers_url":"https://api.github.com/repos/cclauss/ci_edit/stargazers","contributors_url":"https://api.github.com/repos/cclauss/ci_edit/contributors","subscribers_url":"https://api.github.com/repos/cclauss/ci_edit/subscribers","subscription_url":"https://api.github.com/repos/cclauss/ci_edit/subscription","commits_url":"https://api.github.com/repos/cclauss/ci_edit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cclauss/ci_edit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cclauss/ci_edit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cclauss/ci_edit/issues/comments{/number}","contents_url":"https://api.github.com/repos/cclauss/ci_edit/contents/{+path}","compare_url":"https://api.github.com/repos/cclauss/ci_edit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cclauss/ci_edit/merges","archive_url":"https://api.github.com/repos/cclauss/ci_edit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cclauss/ci_edit/downloads","issues_url":"https://api.github.com/repos/cclauss/ci_edit/issues{/number}","pulls_url":"https://api.github.com/repos/cclauss/ci_edit/pulls{/number}","milestones_url":"https://api.github.com/repos/cclauss/ci_edit/milestones{/number}","notifications_url":"https://api.github.com/repos/cclauss/ci_edit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cclauss/ci_edit/labels{/name}","releases_url":"https://api.github.com/repos/cclauss/ci_edit/releases{/id}","deployments_url":"https://api.github.com/repos/cclauss/ci_edit/deployments","created_at":"2018-12-04T10:28:37Z","updated_at":"2018-12-04T10:28:40Z","pushed_at":"2018-12-14T03:27:17Z","git_url":"git://github.com/cclauss/ci_edit.git","ssh_url":"git@github.com:cclauss/ci_edit.git","clone_url":"https://github.com/cclauss/ci_edit.git","svn_url":"https://github.com/cclauss/ci_edit","homepage":"","size":2094,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"55b1186b0cfa36678217d1fc0a2bd9ecbe737b6b","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":92321329,"node_id":"MDEwOlJlcG9zaXRvcnk5MjMyMTMyOQ==","name":"ci_edit","full_name":"google/ci_edit","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/ci_edit","description":"A terminal text editor with mouse support and ctrl+Q to quit.","fork":false,"url":"https://api.github.com/repos/google/ci_edit","forks_url":"https://api.github.com/repos/google/ci_edit/forks","keys_url":"https://api.github.com/repos/google/ci_edit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/ci_edit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/ci_edit/teams","hooks_url":"https://api.github.com/repos/google/ci_edit/hooks","issue_events_url":"https://api.github.com/repos/google/ci_edit/issues/events{/number}","events_url":"https://api.github.com/repos/google/ci_edit/events","assignees_url":"https://api.github.com/repos/google/ci_edit/assignees{/user}","branches_url":"https://api.github.com/repos/google/ci_edit/branches{/branch}","tags_url":"https://api.github.com/repos/google/ci_edit/tags","blobs_url":"https://api.github.com/repos/google/ci_edit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/ci_edit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/ci_edit/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/ci_edit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/ci_edit/statuses/{sha}","languages_url":"https://api.github.com/repos/google/ci_edit/languages","stargazers_url":"https://api.github.com/repos/google/ci_edit/stargazers","contributors_url":"https://api.github.com/repos/google/ci_edit/contributors","subscribers_url":"https://api.github.com/repos/google/ci_edit/subscribers","subscription_url":"https://api.github.com/repos/google/ci_edit/subscription","commits_url":"https://api.github.com/repos/google/ci_edit/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/ci_edit/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/ci_edit/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/ci_edit/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/ci_edit/contents/{+path}","compare_url":"https://api.github.com/repos/google/ci_edit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/ci_edit/merges","archive_url":"https://api.github.com/repos/google/ci_edit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/ci_edit/downloads","issues_url":"https://api.github.com/repos/google/ci_edit/issues{/number}","pulls_url":"https://api.github.com/repos/google/ci_edit/pulls{/number}","milestones_url":"https://api.github.com/repos/google/ci_edit/milestones{/number}","notifications_url":"https://api.github.com/repos/google/ci_edit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/ci_edit/labels{/name}","releases_url":"https://api.github.com/repos/google/ci_edit/releases{/id}","deployments_url":"https://api.github.com/repos/google/ci_edit/deployments","created_at":"2017-05-24T18:00:36Z","updated_at":"2018-12-14T03:22:26Z","pushed_at":"2018-12-14T03:30:18Z","git_url":"git://github.com/google/ci_edit.git","ssh_url":"git@github.com:google/ci_edit.git","clone_url":"https://github.com/google/ci_edit.git","svn_url":"https://github.com/google/ci_edit","homepage":"","size":2675,"stargazers_count":97,"watchers_count":97,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":39,"open_issues":46,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/ci_edit/pulls/179"},"html":{"href":"https://github.com/google/ci_edit/pull/179"},"issue":{"href":"https://api.github.com/repos/google/ci_edit/issues/179"},"comments":{"href":"https://api.github.com/repos/google/ci_edit/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/google/ci_edit/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/google/ci_edit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/ci_edit/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/google/ci_edit/statuses/27ea5497e42770f006ebbf94a770c0bb501d0a93"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dschuyler","id":13840539,"node_id":"MDQ6VXNlcjEzODQwNTM5","avatar_url":"https://avatars2.githubusercontent.com/u/13840539?v=4","gravatar_id":"","url":"https://api.github.com/users/dschuyler","html_url":"https://github.com/dschuyler","followers_url":"https://api.github.com/users/dschuyler/followers","following_url":"https://api.github.com/users/dschuyler/following{/other_user}","gists_url":"https://api.github.com/users/dschuyler/gists{/gist_id}","starred_url":"https://api.github.com/users/dschuyler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschuyler/subscriptions","organizations_url":"https://api.github.com/users/dschuyler/orgs","repos_url":"https://api.github.com/users/dschuyler/repos","events_url":"https://api.github.com/users/dschuyler/events{/privacy}","received_events_url":"https://api.github.com/users/dschuyler/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":16,"deletions":11,"changed_files":1}}
{"actor":{"display_login":"dschuyler"}}