{"action":"created","comment":{"url":"https://api.github.com/repos/telerik/kendo-themes/pulls/comments/226602339","pull_request_review_id":166465908,"id":226602339,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjYwMjMzOQ==","diff_hunk":"@@ -72,31 +72,27 @@\n     }\n \n     // RTL\n-    &[dir='rtl'] .k-notification-wrap,\n-    .k-rtl .k-notification-wrap {\n-        padding-left: $notification-padding-end;\n-        padding-right: $notification-padding-x;\n+    .k-notification,\n+    .k-notification-container {\n+        &[dir='rtl'],\n+        .k-rtl & {","path":"packages/default/scss/notification/_layout.scss","position":11,"original_position":11,"commit_id":"d958ddae85fd96932b4d94022a855e912c7e4a16","original_commit_id":"d958ddae85fd96932b4d94022a855e912c7e4a16","user":{"login":"gyoshev","id":90405,"node_id":"MDQ6VXNlcjkwNDA1","avatar_url":"https://avatars2.githubusercontent.com/u/90405?v=4","gravatar_id":"","url":"https://api.github.com/users/gyoshev","html_url":"https://github.com/gyoshev","followers_url":"https://api.github.com/users/gyoshev/followers","following_url":"https://api.github.com/users/gyoshev/following{/other_user}","gists_url":"https://api.github.com/users/gyoshev/gists{/gist_id}","starred_url":"https://api.github.com/users/gyoshev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyoshev/subscriptions","organizations_url":"https://api.github.com/users/gyoshev/orgs","repos_url":"https://api.github.com/users/gyoshev/repos","events_url":"https://api.github.com/users/gyoshev/events{/privacy}","received_events_url":"https://api.github.com/users/gyoshev/received_events","type":"User","site_admin":false},"body":"I think these selectors can be simplified a bit, since the `.k-rtl` class is always applied to an enclosing element (typically the `<html>` / `<body>` tags). Thus instead of generating 4 rules for each nested selector, the enclosing styles could be\r\n\r\n```scss\r\n.k-notification-container[dir='rtl'],\r\n.k-rtl .k-notification {\r\n   ...\r\n}\r\n```\r\n\r\nThis should work because .k-rtl is used only in jQuery widgets that don't have a notification container, otherwise the dir=rtl is set to only the k-notification-container class.","created_at":"2018-10-19T10:32:21Z","updated_at":"2018-10-19T10:32:21Z","html_url":"https://github.com/telerik/kendo-themes/pull/379#discussion_r226602339","pull_request_url":"https://api.github.com/repos/telerik/kendo-themes/pulls/379","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/telerik/kendo-themes/pulls/comments/226602339"},"html":{"href":"https://github.com/telerik/kendo-themes/pull/379#discussion_r226602339"},"pull_request":{"href":"https://api.github.com/repos/telerik/kendo-themes/pulls/379"}}},"pull_request":{"url":"https://api.github.com/repos/telerik/kendo-themes/pulls/379","id":223910893,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzOTEwODkz","html_url":"https://github.com/telerik/kendo-themes/pull/379","diff_url":"https://github.com/telerik/kendo-themes/pull/379.diff","patch_url":"https://github.com/telerik/kendo-themes/pull/379.patch","issue_url":"https://api.github.com/repos/telerik/kendo-themes/issues/379","number":379,"state":"open","locked":false,"title":"fix(notification): base-level rules for RTL throwing SASS compiler error","user":{"login":"elena-gancheva","id":8842674,"node_id":"MDQ6VXNlcjg4NDI2NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8842674?v=4","gravatar_id":"","url":"https://api.github.com/users/elena-gancheva","html_url":"https://github.com/elena-gancheva","followers_url":"https://api.github.com/users/elena-gancheva/followers","following_url":"https://api.github.com/users/elena-gancheva/following{/other_user}","gists_url":"https://api.github.com/users/elena-gancheva/gists{/gist_id}","starred_url":"https://api.github.com/users/elena-gancheva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elena-gancheva/subscriptions","organizations_url":"https://api.github.com/users/elena-gancheva/orgs","repos_url":"https://api.github.com/users/elena-gancheva/repos","events_url":"https://api.github.com/users/elena-gancheva/events{/privacy}","received_events_url":"https://api.github.com/users/elena-gancheva/received_events","type":"User","site_admin":false},"body":"see telerik/kendo-themes#378","created_at":"2018-10-18T10:53:11Z","updated_at":"2018-10-19T10:32:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68f1c5c3c5a05e3bc18d56eb5de06aa50bbc1a3e","assignee":{"login":"elena-gancheva","id":8842674,"node_id":"MDQ6VXNlcjg4NDI2NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8842674?v=4","gravatar_id":"","url":"https://api.github.com/users/elena-gancheva","html_url":"https://github.com/elena-gancheva","followers_url":"https://api.github.com/users/elena-gancheva/followers","following_url":"https://api.github.com/users/elena-gancheva/following{/other_user}","gists_url":"https://api.github.com/users/elena-gancheva/gists{/gist_id}","starred_url":"https://api.github.com/users/elena-gancheva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elena-gancheva/subscriptions","organizations_url":"https://api.github.com/users/elena-gancheva/orgs","repos_url":"https://api.github.com/users/elena-gancheva/repos","events_url":"https://api.github.com/users/elena-gancheva/events{/privacy}","received_events_url":"https://api.github.com/users/elena-gancheva/received_events","type":"User","site_admin":false},"assignees":[{"login":"elena-gancheva","id":8842674,"node_id":"MDQ6VXNlcjg4NDI2NzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8842674?v=4","gravatar_id":"","url":"https://api.github.com/users/elena-gancheva","html_url":"https://github.com/elena-gancheva","followers_url":"https://api.github.com/users/elena-gancheva/followers","following_url":"https://api.github.com/users/elena-gancheva/following{/other_user}","gists_url":"https://api.github.com/users/elena-gancheva/gists{/gist_id}","starred_url":"https://api.github.com/users/elena-gancheva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elena-gancheva/subscriptions","organizations_url":"https://api.github.com/users/elena-gancheva/orgs","repos_url":"https://api.github.com/users/elena-gancheva/repos","events_url":"https://api.github.com/users/elena-gancheva/events{/privacy}","received_events_url":"https://api.github.com/users/elena-gancheva/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":820225600,"node_id":"MDU6TGFiZWw4MjAyMjU2MDA=","url":"https://api.github.com/repos/telerik/kendo-themes/labels/bug","name":"bug","color":"d73a4a","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/telerik/kendo-themes/pulls/379/commits","review_comments_url":"https://api.github.com/repos/telerik/kendo-themes/pulls/379/comments","review_comment_url":"https://api.github.com/repos/telerik/kendo-themes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/telerik/kendo-themes/issues/379/comments","statuses_url":"https://api.github.com/repos/telerik/kendo-themes/statuses/d958ddae85fd96932b4d94022a855e912c7e4a16","head":{"label":"telerik:fix-missing-root-level-rtl","ref":"fix-missing-root-level-rtl","sha":"d958ddae85fd96932b4d94022a855e912c7e4a16","user":{"login":"telerik","id":568561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODU2MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/568561?v=4","gravatar_id":"","url":"https://api.github.com/users/telerik","html_url":"https://github.com/telerik","followers_url":"https://api.github.com/users/telerik/followers","following_url":"https://api.github.com/users/telerik/following{/other_user}","gists_url":"https://api.github.com/users/telerik/gists{/gist_id}","starred_url":"https://api.github.com/users/telerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telerik/subscriptions","organizations_url":"https://api.github.com/users/telerik/orgs","repos_url":"https://api.github.com/users/telerik/repos","events_url":"https://api.github.com/users/telerik/events{/privacy}","received_events_url":"https://api.github.com/users/telerik/received_events","type":"Organization","site_admin":false},"repo":{"id":119403247,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk0MDMyNDc=","name":"kendo-themes","full_name":"telerik/kendo-themes","private":false,"owner":{"login":"telerik","id":568561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODU2MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/568561?v=4","gravatar_id":"","url":"https://api.github.com/users/telerik","html_url":"https://github.com/telerik","followers_url":"https://api.github.com/users/telerik/followers","following_url":"https://api.github.com/users/telerik/following{/other_user}","gists_url":"https://api.github.com/users/telerik/gists{/gist_id}","starred_url":"https://api.github.com/users/telerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telerik/subscriptions","organizations_url":"https://api.github.com/users/telerik/orgs","repos_url":"https://api.github.com/users/telerik/repos","events_url":"https://api.github.com/users/telerik/events{/privacy}","received_events_url":"https://api.github.com/users/telerik/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/telerik/kendo-themes","description":"Monorepo for SASS-based Kendo UI themes","fork":false,"url":"https://api.github.com/repos/telerik/kendo-themes","forks_url":"https://api.github.com/repos/telerik/kendo-themes/forks","keys_url":"https://api.github.com/repos/telerik/kendo-themes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telerik/kendo-themes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telerik/kendo-themes/teams","hooks_url":"https://api.github.com/repos/telerik/kendo-themes/hooks","issue_events_url":"https://api.github.com/repos/telerik/kendo-themes/issues/events{/number}","events_url":"https://api.github.com/repos/telerik/kendo-themes/events","assignees_url":"https://api.github.com/repos/telerik/kendo-themes/assignees{/user}","branches_url":"https://api.github.com/repos/telerik/kendo-themes/branches{/branch}","tags_url":"https://api.github.com/repos/telerik/kendo-themes/tags","blobs_url":"https://api.github.com/repos/telerik/kendo-themes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telerik/kendo-themes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telerik/kendo-themes/git/refs{/sha}","trees_url":"https://api.github.com/repos/telerik/kendo-themes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telerik/kendo-themes/statuses/{sha}","languages_url":"https://api.github.com/repos/telerik/kendo-themes/languages","stargazers_url":"https://api.github.com/repos/telerik/kendo-themes/stargazers","contributors_url":"https://api.github.com/repos/telerik/kendo-themes/contributors","subscribers_url":"https://api.github.com/repos/telerik/kendo-themes/subscribers","subscription_url":"https://api.github.com/repos/telerik/kendo-themes/subscription","commits_url":"https://api.github.com/repos/telerik/kendo-themes/commits{/sha}","git_commits_url":"https://api.github.com/repos/telerik/kendo-themes/git/commits{/sha}","comments_url":"https://api.github.com/repos/telerik/kendo-themes/comments{/number}","issue_comment_url":"https://api.github.com/repos/telerik/kendo-themes/issues/comments{/number}","contents_url":"https://api.github.com/repos/telerik/kendo-themes/contents/{+path}","compare_url":"https://api.github.com/repos/telerik/kendo-themes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telerik/kendo-themes/merges","archive_url":"https://api.github.com/repos/telerik/kendo-themes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telerik/kendo-themes/downloads","issues_url":"https://api.github.com/repos/telerik/kendo-themes/issues{/number}","pulls_url":"https://api.github.com/repos/telerik/kendo-themes/pulls{/number}","milestones_url":"https://api.github.com/repos/telerik/kendo-themes/milestones{/number}","notifications_url":"https://api.github.com/repos/telerik/kendo-themes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telerik/kendo-themes/labels{/name}","releases_url":"https://api.github.com/repos/telerik/kendo-themes/releases{/id}","deployments_url":"https://api.github.com/repos/telerik/kendo-themes/deployments","created_at":"2018-01-29T15:44:58Z","updated_at":"2018-10-19T09:41:58Z","pushed_at":"2018-10-19T08:36:18Z","git_url":"git://github.com/telerik/kendo-themes.git","ssh_url":"git@github.com:telerik/kendo-themes.git","clone_url":"https://github.com/telerik/kendo-themes.git","svn_url":"https://github.com/telerik/kendo-themes","homepage":null,"size":23408,"stargazers_count":17,"watchers_count":17,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":88,"license":null,"forks":17,"open_issues":88,"watchers":17,"default_branch":"develop"}},"base":{"label":"telerik:develop","ref":"develop","sha":"cf9857638d0c538671782616c7241a39de49a5c4","user":{"login":"telerik","id":568561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODU2MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/568561?v=4","gravatar_id":"","url":"https://api.github.com/users/telerik","html_url":"https://github.com/telerik","followers_url":"https://api.github.com/users/telerik/followers","following_url":"https://api.github.com/users/telerik/following{/other_user}","gists_url":"https://api.github.com/users/telerik/gists{/gist_id}","starred_url":"https://api.github.com/users/telerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telerik/subscriptions","organizations_url":"https://api.github.com/users/telerik/orgs","repos_url":"https://api.github.com/users/telerik/repos","events_url":"https://api.github.com/users/telerik/events{/privacy}","received_events_url":"https://api.github.com/users/telerik/received_events","type":"Organization","site_admin":false},"repo":{"id":119403247,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk0MDMyNDc=","name":"kendo-themes","full_name":"telerik/kendo-themes","private":false,"owner":{"login":"telerik","id":568561,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2ODU2MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/568561?v=4","gravatar_id":"","url":"https://api.github.com/users/telerik","html_url":"https://github.com/telerik","followers_url":"https://api.github.com/users/telerik/followers","following_url":"https://api.github.com/users/telerik/following{/other_user}","gists_url":"https://api.github.com/users/telerik/gists{/gist_id}","starred_url":"https://api.github.com/users/telerik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telerik/subscriptions","organizations_url":"https://api.github.com/users/telerik/orgs","repos_url":"https://api.github.com/users/telerik/repos","events_url":"https://api.github.com/users/telerik/events{/privacy}","received_events_url":"https://api.github.com/users/telerik/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/telerik/kendo-themes","description":"Monorepo for SASS-based Kendo UI themes","fork":false,"url":"https://api.github.com/repos/telerik/kendo-themes","forks_url":"https://api.github.com/repos/telerik/kendo-themes/forks","keys_url":"https://api.github.com/repos/telerik/kendo-themes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telerik/kendo-themes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telerik/kendo-themes/teams","hooks_url":"https://api.github.com/repos/telerik/kendo-themes/hooks","issue_events_url":"https://api.github.com/repos/telerik/kendo-themes/issues/events{/number}","events_url":"https://api.github.com/repos/telerik/kendo-themes/events","assignees_url":"https://api.github.com/repos/telerik/kendo-themes/assignees{/user}","branches_url":"https://api.github.com/repos/telerik/kendo-themes/branches{/branch}","tags_url":"https://api.github.com/repos/telerik/kendo-themes/tags","blobs_url":"https://api.github.com/repos/telerik/kendo-themes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telerik/kendo-themes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telerik/kendo-themes/git/refs{/sha}","trees_url":"https://api.github.com/repos/telerik/kendo-themes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telerik/kendo-themes/statuses/{sha}","languages_url":"https://api.github.com/repos/telerik/kendo-themes/languages","stargazers_url":"https://api.github.com/repos/telerik/kendo-themes/stargazers","contributors_url":"https://api.github.com/repos/telerik/kendo-themes/contributors","subscribers_url":"https://api.github.com/repos/telerik/kendo-themes/subscribers","subscription_url":"https://api.github.com/repos/telerik/kendo-themes/subscription","commits_url":"https://api.github.com/repos/telerik/kendo-themes/commits{/sha}","git_commits_url":"https://api.github.com/repos/telerik/kendo-themes/git/commits{/sha}","comments_url":"https://api.github.com/repos/telerik/kendo-themes/comments{/number}","issue_comment_url":"https://api.github.com/repos/telerik/kendo-themes/issues/comments{/number}","contents_url":"https://api.github.com/repos/telerik/kendo-themes/contents/{+path}","compare_url":"https://api.github.com/repos/telerik/kendo-themes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telerik/kendo-themes/merges","archive_url":"https://api.github.com/repos/telerik/kendo-themes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telerik/kendo-themes/downloads","issues_url":"https://api.github.com/repos/telerik/kendo-themes/issues{/number}","pulls_url":"https://api.github.com/repos/telerik/kendo-themes/pulls{/number}","milestones_url":"https://api.github.com/repos/telerik/kendo-themes/milestones{/number}","notifications_url":"https://api.github.com/repos/telerik/kendo-themes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telerik/kendo-themes/labels{/name}","releases_url":"https://api.github.com/repos/telerik/kendo-themes/releases{/id}","deployments_url":"https://api.github.com/repos/telerik/kendo-themes/deployments","created_at":"2018-01-29T15:44:58Z","updated_at":"2018-10-19T09:41:58Z","pushed_at":"2018-10-19T08:36:18Z","git_url":"git://github.com/telerik/kendo-themes.git","ssh_url":"git@github.com:telerik/kendo-themes.git","clone_url":"https://github.com/telerik/kendo-themes.git","svn_url":"https://github.com/telerik/kendo-themes","homepage":null,"size":23408,"stargazers_count":17,"watchers_count":17,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":88,"license":null,"forks":17,"open_issues":88,"watchers":17,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/telerik/kendo-themes/pulls/379"},"html":{"href":"https://github.com/telerik/kendo-themes/pull/379"},"issue":{"href":"https://api.github.com/repos/telerik/kendo-themes/issues/379"},"comments":{"href":"https://api.github.com/repos/telerik/kendo-themes/issues/379/comments"},"review_comments":{"href":"https://api.github.com/repos/telerik/kendo-themes/pulls/379/comments"},"review_comment":{"href":"https://api.github.com/repos/telerik/kendo-themes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/telerik/kendo-themes/pulls/379/commits"},"statuses":{"href":"https://api.github.com/repos/telerik/kendo-themes/statuses/d958ddae85fd96932b4d94022a855e912c7e4a16"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gyoshev"}}