{"action":"created","comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments/203583717","pull_request_review_id":138501822,"id":203583717,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzU4MzcxNw==","diff_hunk":"@@ -25,6 +26,9 @@ import './editor.scss';\n export const name = 'core/text-columns';\n \n export const settings = {\n+\t// Use an empty parent array to indicate this block should no longer be available for insertion.\n+\tparent: [],","path":"core-blocks/text-columns/index.js","position":13,"original_position":13,"commit_id":"aeabe6e92e616ba9086b56b91236b8317d3ffae9","original_commit_id":"aeabe6e92e616ba9086b56b91236b8317d3ffae9","user":{"login":"noisysocks","id":612155,"node_id":"MDQ6VXNlcjYxMjE1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/612155?v=4","gravatar_id":"","url":"https://api.github.com/users/noisysocks","html_url":"https://github.com/noisysocks","followers_url":"https://api.github.com/users/noisysocks/followers","following_url":"https://api.github.com/users/noisysocks/following{/other_user}","gists_url":"https://api.github.com/users/noisysocks/gists{/gist_id}","starred_url":"https://api.github.com/users/noisysocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noisysocks/subscriptions","organizations_url":"https://api.github.com/users/noisysocks/orgs","repos_url":"https://api.github.com/users/noisysocks/repos","events_url":"https://api.github.com/users/noisysocks/events{/privacy}","received_events_url":"https://api.github.com/users/noisysocks/received_events","type":"User","site_admin":false},"body":"A more \"official\" way of doing this is to use `supports.inserter: false`. Up to you which way you go—they should be functionally equivalent 🙂\r\n\r\nhttps://github.com/WordPress/gutenberg/blob/7ab5a9e8a6d07bb2d16e21fe2841e4619e64f0c1/core-blocks/block/index.js#L23-L27","created_at":"2018-07-19T02:08:02Z","updated_at":"2018-07-19T02:17:18Z","html_url":"https://github.com/WordPress/gutenberg/pull/8036#discussion_r203583717","pull_request_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/8036","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments/203583717"},"html":{"href":"https://github.com/WordPress/gutenberg/pull/8036#discussion_r203583717"},"pull_request":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/8036"}}},"pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/8036","id":202369099,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzY5MDk5","html_url":"https://github.com/WordPress/gutenberg/pull/8036","diff_url":"https://github.com/WordPress/gutenberg/pull/8036.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/8036.patch","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/8036","number":8036,"state":"open","locked":false,"title":"Remove Text Columns block from insertion menus","user":{"login":"brandonpayton","id":530877,"node_id":"MDQ6VXNlcjUzMDg3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/530877?v=4","gravatar_id":"","url":"https://api.github.com/users/brandonpayton","html_url":"https://github.com/brandonpayton","followers_url":"https://api.github.com/users/brandonpayton/followers","following_url":"https://api.github.com/users/brandonpayton/following{/other_user}","gists_url":"https://api.github.com/users/brandonpayton/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonpayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonpayton/subscriptions","organizations_url":"https://api.github.com/users/brandonpayton/orgs","repos_url":"https://api.github.com/users/brandonpayton/repos","events_url":"https://api.github.com/users/brandonpayton/events{/privacy}","received_events_url":"https://api.github.com/users/brandonpayton/received_events","type":"User","site_admin":false},"body":"## Description\r\nThis is a simple PR to remove the Text Columns block from the block library and other insertion menus. It also prints a deprecation warning when loading a Text Columns block in the editor.\r\n\r\nIt works by adding an empty `parent` block setting for the Text Columns block so the block has no valid contexts for insertion.\r\n\r\nCloses #6506.\r\nNOTE: It doesn't do everything called for in #6506 but follows Matías' direction on the issue and addresses the concern for the Try Gutenberg callout.\r\n\r\n## How has this been tested?\r\n* Ran unit and e2e tests.\r\n* Loaded the editor and verified that the `core/text-columns` block is not present in the block library or the block autocompletion menu.\r\n* Loaded a post with a pre-existing Text Columns block and observed that the block was loaded as a Text Columns block and editable.\r\n\r\n## Checklist:\r\n- [x] My code is tested.\r\n- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->\r\n- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->\r\n- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->\r\n","created_at":"2018-07-18T20:23:05Z","updated_at":"2018-07-19T02:17:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c9c9e203055dfaf7ee015841fbf38109ef1d0f7","assignee":{"login":"brandonpayton","id":530877,"node_id":"MDQ6VXNlcjUzMDg3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/530877?v=4","gravatar_id":"","url":"https://api.github.com/users/brandonpayton","html_url":"https://github.com/brandonpayton","followers_url":"https://api.github.com/users/brandonpayton/followers","following_url":"https://api.github.com/users/brandonpayton/following{/other_user}","gists_url":"https://api.github.com/users/brandonpayton/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonpayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonpayton/subscriptions","organizations_url":"https://api.github.com/users/brandonpayton/orgs","repos_url":"https://api.github.com/users/brandonpayton/repos","events_url":"https://api.github.com/users/brandonpayton/events{/privacy}","received_events_url":"https://api.github.com/users/brandonpayton/received_events","type":"User","site_admin":false},"assignees":[{"login":"brandonpayton","id":530877,"node_id":"MDQ6VXNlcjUzMDg3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/530877?v=4","gravatar_id":"","url":"https://api.github.com/users/brandonpayton","html_url":"https://github.com/brandonpayton","followers_url":"https://api.github.com/users/brandonpayton/followers","following_url":"https://api.github.com/users/brandonpayton/following{/other_user}","gists_url":"https://api.github.com/users/brandonpayton/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonpayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonpayton/subscriptions","organizations_url":"https://api.github.com/users/brandonpayton/orgs","repos_url":"https://api.github.com/users/brandonpayton/repos","events_url":"https://api.github.com/users/brandonpayton/events{/privacy}","received_events_url":"https://api.github.com/users/brandonpayton/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":570263070,"node_id":"MDU6TGFiZWw1NzAyNjMwNzA=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/Blocks","name":"Blocks","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/8036/commits","review_comments_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/8036/comments","review_comment_url":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/8036/comments","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/aeabe6e92e616ba9086b56b91236b8317d3ffae9","head":{"label":"WordPress:deprecate/text-columns-block","ref":"deprecate/text-columns-block","sha":"aeabe6e92e616ba9086b56b91236b8317d3ffae9","user":{"login":"WordPress","id":276006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NjAwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"repo":{"id":80862584,"node_id":"MDEwOlJlcG9zaXRvcnk4MDg2MjU4NA==","name":"gutenberg","full_name":"WordPress/gutenberg","owner":{"login":"WordPress","id":276006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NjAwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WordPress/gutenberg","description":"Printing since 1440. Development hub for the editor focus in core. Beta plugin is available from the official WordPress repository.","fork":false,"url":"https://api.github.com/repos/WordPress/gutenberg","forks_url":"https://api.github.com/repos/WordPress/gutenberg/forks","keys_url":"https://api.github.com/repos/WordPress/gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WordPress/gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WordPress/gutenberg/teams","hooks_url":"https://api.github.com/repos/WordPress/gutenberg/hooks","issue_events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/WordPress/gutenberg/events","assignees_url":"https://api.github.com/repos/WordPress/gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/WordPress/gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/WordPress/gutenberg/tags","blobs_url":"https://api.github.com/repos/WordPress/gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WordPress/gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WordPress/gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/WordPress/gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/WordPress/gutenberg/languages","stargazers_url":"https://api.github.com/repos/WordPress/gutenberg/stargazers","contributors_url":"https://api.github.com/repos/WordPress/gutenberg/contributors","subscribers_url":"https://api.github.com/repos/WordPress/gutenberg/subscribers","subscription_url":"https://api.github.com/repos/WordPress/gutenberg/subscription","commits_url":"https://api.github.com/repos/WordPress/gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/WordPress/gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/WordPress/gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/WordPress/gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WordPress/gutenberg/merges","archive_url":"https://api.github.com/repos/WordPress/gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WordPress/gutenberg/downloads","issues_url":"https://api.github.com/repos/WordPress/gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/WordPress/gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/WordPress/gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/WordPress/gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WordPress/gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/WordPress/gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/WordPress/gutenberg/deployments","created_at":"2017-02-03T19:34:19Z","updated_at":"2018-07-18T19:31:55Z","pushed_at":"2018-07-19T00:08:53Z","git_url":"git://github.com/WordPress/gutenberg.git","ssh_url":"git@github.com:WordPress/gutenberg.git","clone_url":"https://github.com/WordPress/gutenberg.git","svn_url":"https://github.com/WordPress/gutenberg","homepage":"https://wordpress.org/plugins/gutenberg/ ","size":18015,"stargazers_count":2807,"watchers_count":2807,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":719,"mirror_url":null,"archived":false,"open_issues_count":971,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":719,"open_issues":971,"watchers":2807,"default_branch":"master"}},"base":{"label":"WordPress:master","ref":"master","sha":"7ab5a9e8a6d07bb2d16e21fe2841e4619e64f0c1","user":{"login":"WordPress","id":276006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NjAwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"repo":{"id":80862584,"node_id":"MDEwOlJlcG9zaXRvcnk4MDg2MjU4NA==","name":"gutenberg","full_name":"WordPress/gutenberg","owner":{"login":"WordPress","id":276006,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NjAwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/276006?v=4","gravatar_id":"","url":"https://api.github.com/users/WordPress","html_url":"https://github.com/WordPress","followers_url":"https://api.github.com/users/WordPress/followers","following_url":"https://api.github.com/users/WordPress/following{/other_user}","gists_url":"https://api.github.com/users/WordPress/gists{/gist_id}","starred_url":"https://api.github.com/users/WordPress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WordPress/subscriptions","organizations_url":"https://api.github.com/users/WordPress/orgs","repos_url":"https://api.github.com/users/WordPress/repos","events_url":"https://api.github.com/users/WordPress/events{/privacy}","received_events_url":"https://api.github.com/users/WordPress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WordPress/gutenberg","description":"Printing since 1440. Development hub for the editor focus in core. Beta plugin is available from the official WordPress repository.","fork":false,"url":"https://api.github.com/repos/WordPress/gutenberg","forks_url":"https://api.github.com/repos/WordPress/gutenberg/forks","keys_url":"https://api.github.com/repos/WordPress/gutenberg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WordPress/gutenberg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WordPress/gutenberg/teams","hooks_url":"https://api.github.com/repos/WordPress/gutenberg/hooks","issue_events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/events{/number}","events_url":"https://api.github.com/repos/WordPress/gutenberg/events","assignees_url":"https://api.github.com/repos/WordPress/gutenberg/assignees{/user}","branches_url":"https://api.github.com/repos/WordPress/gutenberg/branches{/branch}","tags_url":"https://api.github.com/repos/WordPress/gutenberg/tags","blobs_url":"https://api.github.com/repos/WordPress/gutenberg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WordPress/gutenberg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WordPress/gutenberg/git/refs{/sha}","trees_url":"https://api.github.com/repos/WordPress/gutenberg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WordPress/gutenberg/statuses/{sha}","languages_url":"https://api.github.com/repos/WordPress/gutenberg/languages","stargazers_url":"https://api.github.com/repos/WordPress/gutenberg/stargazers","contributors_url":"https://api.github.com/repos/WordPress/gutenberg/contributors","subscribers_url":"https://api.github.com/repos/WordPress/gutenberg/subscribers","subscription_url":"https://api.github.com/repos/WordPress/gutenberg/subscription","commits_url":"https://api.github.com/repos/WordPress/gutenberg/commits{/sha}","git_commits_url":"https://api.github.com/repos/WordPress/gutenberg/git/commits{/sha}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/comments{/number}","issue_comment_url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments{/number}","contents_url":"https://api.github.com/repos/WordPress/gutenberg/contents/{+path}","compare_url":"https://api.github.com/repos/WordPress/gutenberg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WordPress/gutenberg/merges","archive_url":"https://api.github.com/repos/WordPress/gutenberg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WordPress/gutenberg/downloads","issues_url":"https://api.github.com/repos/WordPress/gutenberg/issues{/number}","pulls_url":"https://api.github.com/repos/WordPress/gutenberg/pulls{/number}","milestones_url":"https://api.github.com/repos/WordPress/gutenberg/milestones{/number}","notifications_url":"https://api.github.com/repos/WordPress/gutenberg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WordPress/gutenberg/labels{/name}","releases_url":"https://api.github.com/repos/WordPress/gutenberg/releases{/id}","deployments_url":"https://api.github.com/repos/WordPress/gutenberg/deployments","created_at":"2017-02-03T19:34:19Z","updated_at":"2018-07-18T19:31:55Z","pushed_at":"2018-07-19T00:08:53Z","git_url":"git://github.com/WordPress/gutenberg.git","ssh_url":"git@github.com:WordPress/gutenberg.git","clone_url":"https://github.com/WordPress/gutenberg.git","svn_url":"https://github.com/WordPress/gutenberg","homepage":"https://wordpress.org/plugins/gutenberg/ ","size":18015,"stargazers_count":2807,"watchers_count":2807,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":719,"mirror_url":null,"archived":false,"open_issues_count":971,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":719,"open_issues":971,"watchers":2807,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/8036"},"html":{"href":"https://github.com/WordPress/gutenberg/pull/8036"},"issue":{"href":"https://api.github.com/repos/WordPress/gutenberg/issues/8036"},"comments":{"href":"https://api.github.com/repos/WordPress/gutenberg/issues/8036/comments"},"review_comments":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/8036/comments"},"review_comment":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WordPress/gutenberg/pulls/8036/commits"},"statuses":{"href":"https://api.github.com/repos/WordPress/gutenberg/statuses/aeabe6e92e616ba9086b56b91236b8317d3ffae9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"noisysocks"}}