{"push_id":2924470568,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"2b9ba4049e94eaa4e6299d1d1c1d37fb236af99b","before":"acebd2df114c9d4f0ac226fbc2e7139fb9218251","commits":[{"sha":"cacc3c2057ab14faaf6c5b679bb2dbb6f8b98f8e","author":{"name":"Joe Urciuoli","email":"ef083fce3e0e28f4ef4776fc298a305aa595543c@gmail.com"},"message":"Fix dependency_for final argument\n\nFixed issue where part of the utility language helper internals was passing\nthe wrong kind of argument to the Python ``__import__`` builtin as the list\nof modules to be imported.  The issue produced no symptoms within the core\nlibrary but could cause issues with external applications that redefine the\n``__import__`` builtin or otherwise instrument it. Pull request courtesy Joe\nUrciuoli.\n\nPer the submitter: \"The fourth argument provided to `__import__`  (which\n`import_` feeds in to) is supposed to be a a list of strings, but this code is\npassing a single string. This was causing the sqlalchemy `import_` function to\nbreak the string (for example 'interfaces') into an array of single characters\n['i', 'n', ...], which causes the actual `__import__` to not find the module\n`sqlalchemy.orm.i` (since it's trying to import `sqlalchemy.orm.i` and\n`sqlalchemy.orm.n` .. etc)\"\n\nNo issue could be reproduced locally as it seems you can put anything non-\nempty/None into that last argument, even a list like ``['X']``, and  all the\nsub-modules seem to appear.  Omit it, and then the sub-modules aren't present.\nPerhaps it just runs the module or not if this attribute is present.\n\nChange-Id: Ia15c74620f24d24f0df4882f9b36a04e2c3725b8\nPull-request: https://github.com/zzzeek/sqlalchemy/pull/473","distinct":true,"url":"https://api.github.com/repos/zzzeek/sqlalchemy/commits/cacc3c2057ab14faaf6c5b679bb2dbb6f8b98f8e"},{"sha":"2b9ba4049e94eaa4e6299d1d1c1d37fb236af99b","author":{"name":"mike bayer","email":"bb10354a889e9c8a6c713f2ff3dd3581d4bb27e4@zzzcomputing.com"},"message":"Merge \"Fix dependency_for final argument\"","distinct":true,"url":"https://api.github.com/repos/zzzeek/sqlalchemy/commits/2b9ba4049e94eaa4e6299d1d1c1d37fb236af99b"}]}
{"actor":{"display_login":"zzzeek"}}