{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/24459","repository_url":"https://api.github.com/repos/ceph/ceph","labels_url":"https://api.github.com/repos/ceph/ceph/issues/24459/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/24459/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/24459/events","html_url":"https://github.com/ceph/ceph/pull/24459","id":367603415,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTc5ODIw","number":24459,"title":"os: Transaction uses append_hole() to minimize bl:_buffers inflation. ","user":{"login":"rzarzynski","id":1891217,"node_id":"MDQ6VXNlcjE4OTEyMTc=","avatar_url":"https://avatars2.githubusercontent.com/u/1891217?v=4","gravatar_id":"","url":"https://api.github.com/users/rzarzynski","html_url":"https://github.com/rzarzynski","followers_url":"https://api.github.com/users/rzarzynski/followers","following_url":"https://api.github.com/users/rzarzynski/following{/other_user}","gists_url":"https://api.github.com/users/rzarzynski/gists{/gist_id}","starred_url":"https://api.github.com/users/rzarzynski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzarzynski/subscriptions","organizations_url":"https://api.github.com/users/rzarzynski/orgs","repos_url":"https://api.github.com/users/rzarzynski/repos","events_url":"https://api.github.com/users/rzarzynski/events{/privacy}","received_events_url":"https://api.github.com/users/rzarzynski/received_events","type":"User","site_admin":false},"labels":[{"id":144329561,"node_id":"MDU6TGFiZWwxNDQzMjk1NjE=","url":"https://api.github.com/repos/ceph/ceph/labels/core","name":"core","color":"0041a2","default":false},{"id":204137300,"node_id":"MDU6TGFiZWwyMDQxMzczMDA=","url":"https://api.github.com/repos/ceph/ceph/labels/performance","name":"performance","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-07T23:07:09Z","updated_at":"2018-10-09T17:59:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/24459","html_url":"https://github.com/ceph/ceph/pull/24459","diff_url":"https://github.com/ceph/ceph/pull/24459.diff","patch_url":"https://github.com/ceph/ceph/pull/24459.patch"},"body":"This could be useful as the currently employed `::append(const ptr&)` variant does not provide any measures (like coalescing adjacent bptrs) to prevent inflation of the internal structures of a bufferlist. That is, each call was reflected in dynamic node allocation for the `_buffers` list. Secondary effect of this behavior is increased iteration cost driven by large number of elements likely scattered over memory.\r\n\r\nThis is derivative work of PR #24229."},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/428289866","html_url":"https://github.com/ceph/ceph/pull/24459#issuecomment-428289866","issue_url":"https://api.github.com/repos/ceph/ceph/issues/24459","id":428289866,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODI4OTg2Ng==","user":{"login":"gregsfortytwo","id":908479,"node_id":"MDQ6VXNlcjkwODQ3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/908479?v=4","gravatar_id":"","url":"https://api.github.com/users/gregsfortytwo","html_url":"https://github.com/gregsfortytwo","followers_url":"https://api.github.com/users/gregsfortytwo/followers","following_url":"https://api.github.com/users/gregsfortytwo/following{/other_user}","gists_url":"https://api.github.com/users/gregsfortytwo/gists{/gist_id}","starred_url":"https://api.github.com/users/gregsfortytwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregsfortytwo/subscriptions","organizations_url":"https://api.github.com/users/gregsfortytwo/orgs","repos_url":"https://api.github.com/users/gregsfortytwo/repos","events_url":"https://api.github.com/users/gregsfortytwo/events{/privacy}","received_events_url":"https://api.github.com/users/gregsfortytwo/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T17:59:14Z","updated_at":"2018-10-09T17:59:14Z","author_association":"MEMBER","body":"The new patch here (just the final one in ObjectStore, right?) LGTM, anyway."}}
{"actor":{"display_login":"gregsfortytwo"}}