{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/andela/ah-backend-spaces/pulls/17","id":205714781,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NzE0Nzgx","html_url":"https://github.com/andela/ah-backend-spaces/pull/17","diff_url":"https://github.com/andela/ah-backend-spaces/pull/17.diff","patch_url":"https://github.com/andela/ah-backend-spaces/pull/17.patch","issue_url":"https://api.github.com/repos/andela/ah-backend-spaces/issues/17","number":17,"state":"closed","locked":false,"title":"#159082373 send descriptive signup/registration error messages","user":{"login":"abulojoshua1","id":29429135,"node_id":"MDQ6VXNlcjI5NDI5MTM1","avatar_url":"https://avatars3.githubusercontent.com/u/29429135?v=4","gravatar_id":"","url":"https://api.github.com/users/abulojoshua1","html_url":"https://github.com/abulojoshua1","followers_url":"https://api.github.com/users/abulojoshua1/followers","following_url":"https://api.github.com/users/abulojoshua1/following{/other_user}","gists_url":"https://api.github.com/users/abulojoshua1/gists{/gist_id}","starred_url":"https://api.github.com/users/abulojoshua1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abulojoshua1/subscriptions","organizations_url":"https://api.github.com/users/abulojoshua1/orgs","repos_url":"https://api.github.com/users/abulojoshua1/repos","events_url":"https://api.github.com/users/abulojoshua1/events{/privacy}","received_events_url":"https://api.github.com/users/abulojoshua1/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n- Send a user descriptive signup/login error messages\r\n\r\n### Description of Task to be completed?\r\n- I modified the error message sent to a user when his/her username is not between 5 to 25 characters. \r\n- I modified the message sent to a user when when his/her username contains other special characters apart from an underscore `(_)`.\r\n- I modified the message sent to a user when his/her password does not contain atleast an upper case letter `(A-Z)` or a number `(0-1)` and a special character.\r\n- I made sure that a user name cannot contain a hyphen i.e `(-)`.\r\n\r\n### How should this be manually tested?\r\n- Test the signup user route i.e. `/api/users/` and parse in a username with a length longer than 25 or less than 5 characters.\r\n- Test the signup route i.e. `/api/users/` a parse in a password not containing letters \r\n\r\n### Background Information\r\n- I removed serializer.py from being omitted in the test coverage.\r\n\r\n### What are the relevant pivotal tracker stories?\r\n- [#159082373](https://www.pivotaltracker.com/story/show/159082373)\r\n","created_at":"2018-08-02T12:18:12Z","updated_at":"2018-08-02T14:27:50Z","closed_at":"2018-08-02T14:27:50Z","merged_at":"2018-08-02T14:27:50Z","merge_commit_sha":"ff1e00218c9a9e646801769f77de3b4b00f17780","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ssewilliam","id":21138053,"node_id":"MDQ6VXNlcjIxMTM4MDUz","avatar_url":"https://avatars2.githubusercontent.com/u/21138053?v=4","gravatar_id":"","url":"https://api.github.com/users/ssewilliam","html_url":"https://github.com/ssewilliam","followers_url":"https://api.github.com/users/ssewilliam/followers","following_url":"https://api.github.com/users/ssewilliam/following{/other_user}","gists_url":"https://api.github.com/users/ssewilliam/gists{/gist_id}","starred_url":"https://api.github.com/users/ssewilliam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssewilliam/subscriptions","organizations_url":"https://api.github.com/users/ssewilliam/orgs","repos_url":"https://api.github.com/users/ssewilliam/repos","events_url":"https://api.github.com/users/ssewilliam/events{/privacy}","received_events_url":"https://api.github.com/users/ssewilliam/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/ah-backend-spaces/pulls/17/commits","review_comments_url":"https://api.github.com/repos/andela/ah-backend-spaces/pulls/17/comments","review_comment_url":"https://api.github.com/repos/andela/ah-backend-spaces/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/ah-backend-spaces/issues/17/comments","statuses_url":"https://api.github.com/repos/andela/ah-backend-spaces/statuses/894bbf4ebd0eafee0599d8b124d60e3700d9ad62","head":{"label":"andela:ft-descriptive-error-messages-159082373","ref":"ft-descriptive-error-messages-159082373","sha":"894bbf4ebd0eafee0599d8b124d60e3700d9ad62","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":141235330,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyMzUzMzA=","name":"ah-backend-spaces","full_name":"andela/ah-backend-spaces","owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/ah-backend-spaces","description":null,"fork":false,"url":"https://api.github.com/repos/andela/ah-backend-spaces","forks_url":"https://api.github.com/repos/andela/ah-backend-spaces/forks","keys_url":"https://api.github.com/repos/andela/ah-backend-spaces/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/ah-backend-spaces/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/ah-backend-spaces/teams","hooks_url":"https://api.github.com/repos/andela/ah-backend-spaces/hooks","issue_events_url":"https://api.github.com/repos/andela/ah-backend-spaces/issues/events{/number}","events_url":"https://api.github.com/repos/andela/ah-backend-spaces/events","assignees_url":"https://api.github.com/repos/andela/ah-backend-spaces/assignees{/user}","branches_url":"https://api.github.com/repos/andela/ah-backend-spaces/branches{/branch}","tags_url":"https://api.github.com/repos/andela/ah-backend-spaces/tags","blobs_url":"https://api.github.com/repos/andela/ah-backend-spaces/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/ah-backend-spaces/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/ah-backend-spaces/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/ah-backend-spaces/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/ah-backend-spaces/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/ah-backend-spaces/languages","stargazers_url":"https://api.github.com/repos/andela/ah-backend-spaces/stargazers","contributors_url":"https://api.github.com/repos/andela/ah-backend-spaces/contributors","subscribers_url":"https://api.github.com/repos/andela/ah-backend-spaces/subscribers","subscription_url":"https://api.github.com/repos/andela/ah-backend-spaces/subscription","commits_url":"https://api.github.com/repos/andela/ah-backend-spaces/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/ah-backend-spaces/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/ah-backend-spaces/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/ah-backend-spaces/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/ah-backend-spaces/contents/{+path}","compare_url":"https://api.github.com/repos/andela/ah-backend-spaces/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/ah-backend-spaces/merges","archive_url":"https://api.github.com/repos/andela/ah-backend-spaces/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/ah-backend-spaces/downloads","issues_url":"https://api.github.com/repos/andela/ah-backend-spaces/issues{/number}","pulls_url":"https://api.github.com/repos/andela/ah-backend-spaces/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/ah-backend-spaces/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/ah-backend-spaces/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/ah-backend-spaces/labels{/name}","releases_url":"https://api.github.com/repos/andela/ah-backend-spaces/releases{/id}","deployments_url":"https://api.github.com/repos/andela/ah-backend-spaces/deployments","created_at":"2018-07-17T05:22:33Z","updated_at":"2018-08-01T13:39:10Z","pushed_at":"2018-08-02T14:27:50Z","git_url":"git://github.com/andela/ah-backend-spaces.git","ssh_url":"git@github.com:andela/ah-backend-spaces.git","clone_url":"https://github.com/andela/ah-backend-spaces.git","svn_url":"https://github.com/andela/ah-backend-spaces","homepage":null,"size":47,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"1deec7bba694bbfb12ca97cbc32040bff616ee44","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":141235330,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyMzUzMzA=","name":"ah-backend-spaces","full_name":"andela/ah-backend-spaces","owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/ah-backend-spaces","description":null,"fork":false,"url":"https://api.github.com/repos/andela/ah-backend-spaces","forks_url":"https://api.github.com/repos/andela/ah-backend-spaces/forks","keys_url":"https://api.github.com/repos/andela/ah-backend-spaces/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/ah-backend-spaces/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/ah-backend-spaces/teams","hooks_url":"https://api.github.com/repos/andela/ah-backend-spaces/hooks","issue_events_url":"https://api.github.com/repos/andela/ah-backend-spaces/issues/events{/number}","events_url":"https://api.github.com/repos/andela/ah-backend-spaces/events","assignees_url":"https://api.github.com/repos/andela/ah-backend-spaces/assignees{/user}","branches_url":"https://api.github.com/repos/andela/ah-backend-spaces/branches{/branch}","tags_url":"https://api.github.com/repos/andela/ah-backend-spaces/tags","blobs_url":"https://api.github.com/repos/andela/ah-backend-spaces/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/ah-backend-spaces/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/ah-backend-spaces/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/ah-backend-spaces/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/ah-backend-spaces/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/ah-backend-spaces/languages","stargazers_url":"https://api.github.com/repos/andela/ah-backend-spaces/stargazers","contributors_url":"https://api.github.com/repos/andela/ah-backend-spaces/contributors","subscribers_url":"https://api.github.com/repos/andela/ah-backend-spaces/subscribers","subscription_url":"https://api.github.com/repos/andela/ah-backend-spaces/subscription","commits_url":"https://api.github.com/repos/andela/ah-backend-spaces/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/ah-backend-spaces/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/ah-backend-spaces/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/ah-backend-spaces/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/ah-backend-spaces/contents/{+path}","compare_url":"https://api.github.com/repos/andela/ah-backend-spaces/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/ah-backend-spaces/merges","archive_url":"https://api.github.com/repos/andela/ah-backend-spaces/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/ah-backend-spaces/downloads","issues_url":"https://api.github.com/repos/andela/ah-backend-spaces/issues{/number}","pulls_url":"https://api.github.com/repos/andela/ah-backend-spaces/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/ah-backend-spaces/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/ah-backend-spaces/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/ah-backend-spaces/labels{/name}","releases_url":"https://api.github.com/repos/andela/ah-backend-spaces/releases{/id}","deployments_url":"https://api.github.com/repos/andela/ah-backend-spaces/deployments","created_at":"2018-07-17T05:22:33Z","updated_at":"2018-08-01T13:39:10Z","pushed_at":"2018-08-02T14:27:50Z","git_url":"git://github.com/andela/ah-backend-spaces.git","ssh_url":"git@github.com:andela/ah-backend-spaces.git","clone_url":"https://github.com/andela/ah-backend-spaces.git","svn_url":"https://github.com/andela/ah-backend-spaces","homepage":null,"size":47,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/ah-backend-spaces/pulls/17"},"html":{"href":"https://github.com/andela/ah-backend-spaces/pull/17"},"issue":{"href":"https://api.github.com/repos/andela/ah-backend-spaces/issues/17"},"comments":{"href":"https://api.github.com/repos/andela/ah-backend-spaces/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/ah-backend-spaces/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/ah-backend-spaces/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/ah-backend-spaces/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/andela/ah-backend-spaces/statuses/894bbf4ebd0eafee0599d8b124d60e3700d9ad62"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"geofrocker","id":22788274,"node_id":"MDQ6VXNlcjIyNzg4Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22788274?v=4","gravatar_id":"","url":"https://api.github.com/users/geofrocker","html_url":"https://github.com/geofrocker","followers_url":"https://api.github.com/users/geofrocker/followers","following_url":"https://api.github.com/users/geofrocker/following{/other_user}","gists_url":"https://api.github.com/users/geofrocker/gists{/gist_id}","starred_url":"https://api.github.com/users/geofrocker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geofrocker/subscriptions","organizations_url":"https://api.github.com/users/geofrocker/orgs","repos_url":"https://api.github.com/users/geofrocker/repos","events_url":"https://api.github.com/users/geofrocker/events{/privacy}","received_events_url":"https://api.github.com/users/geofrocker/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":8,"deletions":9,"changed_files":3}}
{"actor":{"display_login":"geofrocker"}}