{"action":"created","issue":{"url":"https://api.github.com/repos/StanfordAHA/garnet/issues/83","repository_url":"https://api.github.com/repos/StanfordAHA/garnet","labels_url":"https://api.github.com/repos/StanfordAHA/garnet/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/StanfordAHA/garnet/issues/83/comments","events_url":"https://api.github.com/repos/StanfordAHA/garnet/issues/83/events","html_url":"https://github.com/StanfordAHA/garnet/pull/83","id":349777463,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODAwNzMz","number":83,"title":"Update code based on upstream bv/fault changes","user":{"login":"leonardt","id":3766436,"node_id":"MDQ6VXNlcjM3NjY0MzY=","avatar_url":"https://avatars3.githubusercontent.com/u/3766436?v=4","gravatar_id":"","url":"https://api.github.com/users/leonardt","html_url":"https://github.com/leonardt","followers_url":"https://api.github.com/users/leonardt/followers","following_url":"https://api.github.com/users/leonardt/following{/other_user}","gists_url":"https://api.github.com/users/leonardt/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardt/subscriptions","organizations_url":"https://api.github.com/users/leonardt/orgs","repos_url":"https://api.github.com/users/leonardt/repos","events_url":"https://api.github.com/users/leonardt/events{/privacy}","received_events_url":"https://api.github.com/users/leonardt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-12T02:01:48Z","updated_at":"2018-08-12T02:04:41Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/StanfordAHA/garnet/pulls/83","html_url":"https://github.com/StanfordAHA/garnet/pull/83","diff_url":"https://github.com/StanfordAHA/garnet/pull/83.diff","patch_url":"https://github.com/StanfordAHA/garnet/pull/83.patch"},"body":"* Support for None values were removed.  Changed the functional models\r\nto use fault.UnknownValue (X) by default. Then the test logic was\r\nupdated to expect `AnyValue` on the outputs when they are\r\nunspecified/undefined. For example, the test expects AnyValue for\r\noutputs of the memory during the reset sequence since the values are\r\nundefined.\r\n\r\n* bit_vector `as_uint()` instead of `as_int()`, since `as_int()` returns\r\nthe signed representation now (before it depended on whether the signed\r\nflag was set on initialization).\r\n\r\n* bit_vector `as_uint()` instead of `.unsigned_value` since the API\r\nhas changed to be consistent with the `as_int` pattern.\r\n\r\n* Explicitly cast lists to BitVectors for tests since the BitVector\r\n`==` operator no longer does implicit conversions."},"comment":{"url":"https://api.github.com/repos/StanfordAHA/garnet/issues/comments/412313333","html_url":"https://github.com/StanfordAHA/garnet/pull/83#issuecomment-412313333","issue_url":"https://api.github.com/repos/StanfordAHA/garnet/issues/83","id":412313333,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjMxMzMzMw==","user":{"login":"coveralls","id":2354108,"node_id":"MDQ6VXNlcjIzNTQxMDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2018-08-12T02:04:41Z","updated_at":"2018-08-12T02:04:41Z","author_association":"NONE","body":"## Pull Request Test Coverage Report for [Build 618](https://coveralls.io/builds/18442476)\n\n* **27** of **27**   **(100.0%)**  changed or added relevant lines in **5** files are covered.\n* **1** unchanged line in **1** file lost coverage.\n* Overall coverage increased (+**0.04%**) to **94.828%**\n\n---\n\n\n|  Files with Coverage Reduction | New Missed Lines | % |\n| :-----|--------------|--: |\n| [simple_cb/simple_cb.py](https://coveralls.io/builds/18442476/source?filename=simple_cb%2Fsimple_cb.py#L41) | 1 | 96.55% |\n<!-- | **Total:** | **1** |  | -->\n\n|  Totals | [![Coverage Status](https://coveralls.io/builds/18442476/badge)](https://coveralls.io/builds/18442476) |\n| :-- | --: |\n| Change from base [Build 606](https://coveralls.io/builds/18399713): |  0.04% |\n| Covered Lines: | 440 |\n| Relevant Lines: | 464 |\n\n---\n##### 💛  - [Coveralls](https://coveralls.io)\n"}}
{"actor":{"display_login":"coveralls"}}