{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/193265953","pull_request_review_id":126204199,"id":193265953,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzI2NTk1Mw==","diff_hunk":"@@ -408,4 +407,18 @@ protected void scan(URL url) {\n             }\n         }\n     }\n+\n+    @Override\n+    public URL getResource(String name) {","path":"connect/runtime/src/main/java/org/apache/kafka/connect/runtime/isolation/DelegatingClassLoader.java","position":31,"original_position":31,"commit_id":"8788910c82315e57eb48224ebd66b800784a0437","original_commit_id":"8788910c82315e57eb48224ebd66b800784a0437","user":{"login":"kkonstantine","id":16238634,"node_id":"MDQ6VXNlcjE2MjM4NjM0","avatar_url":"https://avatars1.githubusercontent.com/u/16238634?v=4","gravatar_id":"","url":"https://api.github.com/users/kkonstantine","html_url":"https://github.com/kkonstantine","followers_url":"https://api.github.com/users/kkonstantine/followers","following_url":"https://api.github.com/users/kkonstantine/following{/other_user}","gists_url":"https://api.github.com/users/kkonstantine/gists{/gist_id}","starred_url":"https://api.github.com/users/kkonstantine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkonstantine/subscriptions","organizations_url":"https://api.github.com/users/kkonstantine/orgs","repos_url":"https://api.github.com/users/kkonstantine/repos","events_url":"https://api.github.com/users/kkonstantine/events{/privacy}","received_events_url":"https://api.github.com/users/kkonstantine/received_events","type":"User","site_admin":false},"body":"Yeah, I was a little bit optimistic here. The good thing as you both mention is that we don't have to blacklist anything. We just need to whitelist the plugins we are interested in not delegating to the parent. That's all. ","created_at":"2018-06-06T01:04:06Z","updated_at":"2018-06-06T01:04:06Z","html_url":"https://github.com/apache/kafka/pull/5135#discussion_r193265953","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/5135","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/193265953"},"html":{"href":"https://github.com/apache/kafka/pull/5135#discussion_r193265953"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/5135"}},"in_reply_to_id":193247780},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/5135","id":192593855,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNTkzODU1","html_url":"https://github.com/apache/kafka/pull/5135","diff_url":"https://github.com/apache/kafka/pull/5135.diff","patch_url":"https://github.com/apache/kafka/pull/5135.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/5135","number":5135,"state":"open","locked":false,"title":"KAFKA-6991 : KIP-285 : Fix ServiceLoader issue with PluginClassLoader","user":{"login":"mageshn","id":7535516,"node_id":"MDQ6VXNlcjc1MzU1MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7535516?v=4","gravatar_id":"","url":"https://api.github.com/users/mageshn","html_url":"https://github.com/mageshn","followers_url":"https://api.github.com/users/mageshn/followers","following_url":"https://api.github.com/users/mageshn/following{/other_user}","gists_url":"https://api.github.com/users/mageshn/gists{/gist_id}","starred_url":"https://api.github.com/users/mageshn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mageshn/subscriptions","organizations_url":"https://api.github.com/users/mageshn/orgs","repos_url":"https://api.github.com/users/mageshn/repos","events_url":"https://api.github.com/users/mageshn/events{/privacy}","received_events_url":"https://api.github.com/users/mageshn/received_events","type":"User","site_admin":false},"body":"Fix ServiceLoader issue with PluginClassLoader and add basic-auth-extension packaging & classpath\r\n\r\n*More detailed description of your change,\r\nif necessary. The PR title and PR message become\r\nthe squashed commit message, so use a separate\r\ncomment to ping reviewers.*\r\n\r\n*Summary of testing strategy (including rationale)\r\nfor the feature or bug fix. Unit and/or integration\r\ntests are expected for any behaviour change and\r\nsystem tests should be considered for larger changes.*\r\n\r\n### Committer Checklist (excluded from commit message)\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation (including upgrade notes)\r\n","created_at":"2018-06-05T05:24:58Z","updated_at":"2018-06-06T01:04:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8c1d27387da8852c57ea511b6e72ad8268b1f40","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/5135/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/5135/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/5135/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/8788910c82315e57eb48224ebd66b800784a0437","head":{"label":"mageshn:KAFKA-6991","ref":"KAFKA-6991","sha":"8788910c82315e57eb48224ebd66b800784a0437","user":{"login":"mageshn","id":7535516,"node_id":"MDQ6VXNlcjc1MzU1MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7535516?v=4","gravatar_id":"","url":"https://api.github.com/users/mageshn","html_url":"https://github.com/mageshn","followers_url":"https://api.github.com/users/mageshn/followers","following_url":"https://api.github.com/users/mageshn/following{/other_user}","gists_url":"https://api.github.com/users/mageshn/gists{/gist_id}","starred_url":"https://api.github.com/users/mageshn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mageshn/subscriptions","organizations_url":"https://api.github.com/users/mageshn/orgs","repos_url":"https://api.github.com/users/mageshn/repos","events_url":"https://api.github.com/users/mageshn/events{/privacy}","received_events_url":"https://api.github.com/users/mageshn/received_events","type":"User","site_admin":false},"repo":{"id":118654341,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg2NTQzNDE=","name":"kafka","full_name":"mageshn/kafka","owner":{"login":"mageshn","id":7535516,"node_id":"MDQ6VXNlcjc1MzU1MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7535516?v=4","gravatar_id":"","url":"https://api.github.com/users/mageshn","html_url":"https://github.com/mageshn","followers_url":"https://api.github.com/users/mageshn/followers","following_url":"https://api.github.com/users/mageshn/following{/other_user}","gists_url":"https://api.github.com/users/mageshn/gists{/gist_id}","starred_url":"https://api.github.com/users/mageshn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mageshn/subscriptions","organizations_url":"https://api.github.com/users/mageshn/orgs","repos_url":"https://api.github.com/users/mageshn/repos","events_url":"https://api.github.com/users/mageshn/events{/privacy}","received_events_url":"https://api.github.com/users/mageshn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mageshn/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/mageshn/kafka","forks_url":"https://api.github.com/repos/mageshn/kafka/forks","keys_url":"https://api.github.com/repos/mageshn/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mageshn/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mageshn/kafka/teams","hooks_url":"https://api.github.com/repos/mageshn/kafka/hooks","issue_events_url":"https://api.github.com/repos/mageshn/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/mageshn/kafka/events","assignees_url":"https://api.github.com/repos/mageshn/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/mageshn/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/mageshn/kafka/tags","blobs_url":"https://api.github.com/repos/mageshn/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mageshn/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mageshn/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/mageshn/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mageshn/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/mageshn/kafka/languages","stargazers_url":"https://api.github.com/repos/mageshn/kafka/stargazers","contributors_url":"https://api.github.com/repos/mageshn/kafka/contributors","subscribers_url":"https://api.github.com/repos/mageshn/kafka/subscribers","subscription_url":"https://api.github.com/repos/mageshn/kafka/subscription","commits_url":"https://api.github.com/repos/mageshn/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/mageshn/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/mageshn/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/mageshn/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/mageshn/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/mageshn/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mageshn/kafka/merges","archive_url":"https://api.github.com/repos/mageshn/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mageshn/kafka/downloads","issues_url":"https://api.github.com/repos/mageshn/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/mageshn/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/mageshn/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/mageshn/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mageshn/kafka/labels{/name}","releases_url":"https://api.github.com/repos/mageshn/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/mageshn/kafka/deployments","created_at":"2018-01-23T18:53:00Z","updated_at":"2018-05-31T21:27:39Z","pushed_at":"2018-06-05T19:57:03Z","git_url":"git://github.com/mageshn/kafka.git","ssh_url":"git@github.com:mageshn/kafka.git","clone_url":"https://github.com/mageshn/kafka.git","svn_url":"https://github.com/mageshn/kafka","homepage":null,"size":65937,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"e8ddb76573d0aba659dd97d42ac02f5ec24516d2","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"node_id":"MDEwOlJlcG9zaXRvcnkyMjExMjQz","name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2018-06-05T23:33:49Z","pushed_at":"2018-06-06T00:39:12Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":66773,"stargazers_count":8543,"watchers_count":8543,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4956,"mirror_url":null,"archived":false,"open_issues_count":453,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4956,"open_issues":453,"watchers":8543,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/5135"},"html":{"href":"https://github.com/apache/kafka/pull/5135"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/5135"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/5135/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/5135/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/5135/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/8788910c82315e57eb48224ebd66b800784a0437"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kkonstantine"}}