{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/console/pulls/comments/196187679","pull_request_review_id":129692677,"id":196187679,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjE4NzY3OQ==","diff_hunk":"@@ -327,9 +328,17 @@ export const List = connect(stateToProps, {sortList: UIActions.sortList})(\n       <Rows key=\"rows\" expand={expand} Row={Row} {...componentProps} />\n     </React.Fragment>;\n \n-    return <div className=\"co-m-table-grid co-m-table-grid--bordered\">\n-      { fake ? children : <StatusBox {...props}>{children}</StatusBox> }\n-    </div>;\n+    const content = fake ? children : <StatusBox {...props}>{children}</StatusBox>;\n+","path":"frontend/public/components/factory/list.jsx","position":29,"original_position":29,"commit_id":"d1832a85a9b8d58139ba2a58498f07669b2b1831","original_commit_id":"d1832a85a9b8d58139ba2a58498f07669b2b1831","user":{"login":"benjaminapetersen","id":280512,"node_id":"MDQ6VXNlcjI4MDUxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/280512?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"body":"For the record, we considered doing `<List responsive={true} {...props} />` vs `<ResponsiveList><List {...props} /></ResponsiveList />`.  I think this single attribute addition works fine.  Its possible we would want to revisit if we keep adding props in the future. ","created_at":"2018-06-18T18:55:11Z","updated_at":"2018-06-18T18:57:59Z","html_url":"https://github.com/openshift/console/pull/138#discussion_r196187679","pull_request_url":"https://api.github.com/repos/openshift/console/pulls/138","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/console/pulls/comments/196187679"},"html":{"href":"https://github.com/openshift/console/pull/138#discussion_r196187679"},"pull_request":{"href":"https://api.github.com/repos/openshift/console/pulls/138"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/console/pulls/138","id":195280750,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjgwNzUw","html_url":"https://github.com/openshift/console/pull/138","diff_url":"https://github.com/openshift/console/pull/138.diff","patch_url":"https://github.com/openshift/console/pull/138.patch","issue_url":"https://api.github.com/repos/openshift/console/issues/138","number":138,"state":"open","locked":false,"title":"[WIP] Introduce optional horizontally scrollable table functionality for review","user":{"login":"sg00dwin","id":1874151,"node_id":"MDQ6VXNlcjE4NzQxNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1874151?v=4","gravatar_id":"","url":"https://api.github.com/users/sg00dwin","html_url":"https://github.com/sg00dwin","followers_url":"https://api.github.com/users/sg00dwin/followers","following_url":"https://api.github.com/users/sg00dwin/following{/other_user}","gists_url":"https://api.github.com/users/sg00dwin/gists{/gist_id}","starred_url":"https://api.github.com/users/sg00dwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sg00dwin/subscriptions","organizations_url":"https://api.github.com/users/sg00dwin/orgs","repos_url":"https://api.github.com/users/sg00dwin/repos","events_url":"https://api.github.com/users/sg00dwin/events{/privacy}","received_events_url":"https://api.github.com/users/sg00dwin/received_events","type":"User","site_admin":false},"body":"These changes are a carry over of work from an earlier PR to the /bridge repo https://github.com/coreos-inc/bridge/pull/2293\r\n\r\nBy adding `responsive={true}` to a sections `<List ...>` at mobile widths (>768), a table would be enabled to horizontally scroll, and set at a min width, based on the number of columns.\r\n\r\nIn this PR the only views with tables enabled to scroll are on Pods and Ingress pages.\r\n\r\n@spadgett, @robszumski, @rhamilto \r\n","created_at":"2018-06-15T20:54:57Z","updated_at":"2018-06-18T18:57:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"659912383ab6c3cb29878636be091b55c64d0c13","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":926924641,"node_id":"MDU6TGFiZWw5MjY5MjQ2NDE=","url":"https://api.github.com/repos/openshift/console/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":926924366,"node_id":"MDU6TGFiZWw5MjY5MjQzNjY=","url":"https://api.github.com/repos/openshift/console/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/console/pulls/138/commits","review_comments_url":"https://api.github.com/repos/openshift/console/pulls/138/comments","review_comment_url":"https://api.github.com/repos/openshift/console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/console/issues/138/comments","statuses_url":"https://api.github.com/repos/openshift/console/statuses/d1832a85a9b8d58139ba2a58498f07669b2b1831","head":{"label":"sg00dwin:scrollable-mobile-table","ref":"scrollable-mobile-table","sha":"d1832a85a9b8d58139ba2a58498f07669b2b1831","user":{"login":"sg00dwin","id":1874151,"node_id":"MDQ6VXNlcjE4NzQxNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1874151?v=4","gravatar_id":"","url":"https://api.github.com/users/sg00dwin","html_url":"https://github.com/sg00dwin","followers_url":"https://api.github.com/users/sg00dwin/followers","following_url":"https://api.github.com/users/sg00dwin/following{/other_user}","gists_url":"https://api.github.com/users/sg00dwin/gists{/gist_id}","starred_url":"https://api.github.com/users/sg00dwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sg00dwin/subscriptions","organizations_url":"https://api.github.com/users/sg00dwin/orgs","repos_url":"https://api.github.com/users/sg00dwin/repos","events_url":"https://api.github.com/users/sg00dwin/events{/privacy}","received_events_url":"https://api.github.com/users/sg00dwin/received_events","type":"User","site_admin":false},"repo":{"id":133385850,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMzODU4NTA=","name":"console","full_name":"sg00dwin/console","owner":{"login":"sg00dwin","id":1874151,"node_id":"MDQ6VXNlcjE4NzQxNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1874151?v=4","gravatar_id":"","url":"https://api.github.com/users/sg00dwin","html_url":"https://github.com/sg00dwin","followers_url":"https://api.github.com/users/sg00dwin/followers","following_url":"https://api.github.com/users/sg00dwin/following{/other_user}","gists_url":"https://api.github.com/users/sg00dwin/gists{/gist_id}","starred_url":"https://api.github.com/users/sg00dwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sg00dwin/subscriptions","organizations_url":"https://api.github.com/users/sg00dwin/orgs","repos_url":"https://api.github.com/users/sg00dwin/repos","events_url":"https://api.github.com/users/sg00dwin/events{/privacy}","received_events_url":"https://api.github.com/users/sg00dwin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sg00dwin/console","description":"OpenShift Cluster Console UI","fork":true,"url":"https://api.github.com/repos/sg00dwin/console","forks_url":"https://api.github.com/repos/sg00dwin/console/forks","keys_url":"https://api.github.com/repos/sg00dwin/console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sg00dwin/console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sg00dwin/console/teams","hooks_url":"https://api.github.com/repos/sg00dwin/console/hooks","issue_events_url":"https://api.github.com/repos/sg00dwin/console/issues/events{/number}","events_url":"https://api.github.com/repos/sg00dwin/console/events","assignees_url":"https://api.github.com/repos/sg00dwin/console/assignees{/user}","branches_url":"https://api.github.com/repos/sg00dwin/console/branches{/branch}","tags_url":"https://api.github.com/repos/sg00dwin/console/tags","blobs_url":"https://api.github.com/repos/sg00dwin/console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sg00dwin/console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sg00dwin/console/git/refs{/sha}","trees_url":"https://api.github.com/repos/sg00dwin/console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sg00dwin/console/statuses/{sha}","languages_url":"https://api.github.com/repos/sg00dwin/console/languages","stargazers_url":"https://api.github.com/repos/sg00dwin/console/stargazers","contributors_url":"https://api.github.com/repos/sg00dwin/console/contributors","subscribers_url":"https://api.github.com/repos/sg00dwin/console/subscribers","subscription_url":"https://api.github.com/repos/sg00dwin/console/subscription","commits_url":"https://api.github.com/repos/sg00dwin/console/commits{/sha}","git_commits_url":"https://api.github.com/repos/sg00dwin/console/git/commits{/sha}","comments_url":"https://api.github.com/repos/sg00dwin/console/comments{/number}","issue_comment_url":"https://api.github.com/repos/sg00dwin/console/issues/comments{/number}","contents_url":"https://api.github.com/repos/sg00dwin/console/contents/{+path}","compare_url":"https://api.github.com/repos/sg00dwin/console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sg00dwin/console/merges","archive_url":"https://api.github.com/repos/sg00dwin/console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sg00dwin/console/downloads","issues_url":"https://api.github.com/repos/sg00dwin/console/issues{/number}","pulls_url":"https://api.github.com/repos/sg00dwin/console/pulls{/number}","milestones_url":"https://api.github.com/repos/sg00dwin/console/milestones{/number}","notifications_url":"https://api.github.com/repos/sg00dwin/console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sg00dwin/console/labels{/name}","releases_url":"https://api.github.com/repos/sg00dwin/console/releases{/id}","deployments_url":"https://api.github.com/repos/sg00dwin/console/deployments","created_at":"2018-05-14T15:50:09Z","updated_at":"2018-06-11T15:52:33Z","pushed_at":"2018-06-18T15:04:08Z","git_url":"git://github.com/sg00dwin/console.git","ssh_url":"git@github.com:sg00dwin/console.git","clone_url":"https://github.com/sg00dwin/console.git","svn_url":"https://github.com/sg00dwin/console","homepage":"","size":86509,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"275b3d15e4dbe2e4618fc715b0e079e6175fe111","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":129436456,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk0MzY0NTY=","name":"console","full_name":"openshift/console","owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/console","description":"OpenShift Cluster Console UI","fork":false,"url":"https://api.github.com/repos/openshift/console","forks_url":"https://api.github.com/repos/openshift/console/forks","keys_url":"https://api.github.com/repos/openshift/console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/console/teams","hooks_url":"https://api.github.com/repos/openshift/console/hooks","issue_events_url":"https://api.github.com/repos/openshift/console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/console/events","assignees_url":"https://api.github.com/repos/openshift/console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/console/tags","blobs_url":"https://api.github.com/repos/openshift/console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/console/languages","stargazers_url":"https://api.github.com/repos/openshift/console/stargazers","contributors_url":"https://api.github.com/repos/openshift/console/contributors","subscribers_url":"https://api.github.com/repos/openshift/console/subscribers","subscription_url":"https://api.github.com/repos/openshift/console/subscription","commits_url":"https://api.github.com/repos/openshift/console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/console/merges","archive_url":"https://api.github.com/repos/openshift/console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/console/downloads","issues_url":"https://api.github.com/repos/openshift/console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/console/deployments","created_at":"2018-04-13T17:54:59Z","updated_at":"2018-06-18T15:26:57Z","pushed_at":"2018-06-18T18:15:51Z","git_url":"git://github.com/openshift/console.git","ssh_url":"git@github.com:openshift/console.git","clone_url":"https://github.com/openshift/console.git","svn_url":"https://github.com/openshift/console","homepage":"https://www.openshift.org","size":86527,"stargazers_count":10,"watchers_count":10,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":22,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/console/pulls/138"},"html":{"href":"https://github.com/openshift/console/pull/138"},"issue":{"href":"https://api.github.com/repos/openshift/console/issues/138"},"comments":{"href":"https://api.github.com/repos/openshift/console/issues/138/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/console/pulls/138/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/console/pulls/138/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/console/statuses/d1832a85a9b8d58139ba2a58498f07669b2b1831"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"benjaminapetersen"}}