{"action":"created","issue":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2604","repository_url":"https://api.github.com/repos/KratosMultiphysics/Kratos","labels_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2604/labels{/name}","comments_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2604/comments","events_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2604/events","html_url":"https://github.com/KratosMultiphysics/Kratos/issues/2604","id":345786424,"node_id":"MDU6SXNzdWUzNDU3ODY0MjQ=","number":2604,"title":"B&S assembling procedure check for position to assemble","user":{"login":"adityaghantasala","id":2531316,"node_id":"MDQ6VXNlcjI1MzEzMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2531316?v=4","gravatar_id":"","url":"https://api.github.com/users/adityaghantasala","html_url":"https://github.com/adityaghantasala","followers_url":"https://api.github.com/users/adityaghantasala/followers","following_url":"https://api.github.com/users/adityaghantasala/following{/other_user}","gists_url":"https://api.github.com/users/adityaghantasala/gists{/gist_id}","starred_url":"https://api.github.com/users/adityaghantasala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adityaghantasala/subscriptions","organizations_url":"https://api.github.com/users/adityaghantasala/orgs","repos_url":"https://api.github.com/users/adityaghantasala/repos","events_url":"https://api.github.com/users/adityaghantasala/events{/privacy}","received_events_url":"https://api.github.com/users/adityaghantasala/received_events","type":"User","site_admin":false},"labels":[{"id":539269431,"node_id":"MDU6TGFiZWw1MzkyNjk0MzE=","url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/C++","name":"C++","color":"afea2e","default":false},{"id":538609887,"node_id":"MDU6TGFiZWw1Mzg2MDk4ODc=","url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/Discussion","name":"Discussion","color":"cc317c","default":false},{"id":539268135,"node_id":"MDU6TGFiZWw1MzkyNjgxMzU=","url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/Kratos%20Core","name":"Kratos Core","color":"0052cc","default":false},{"id":538395924,"node_id":"MDU6TGFiZWw1MzgzOTU5MjQ=","url":"https://api.github.com/repos/KratosMultiphysics/Kratos/labels/Question","name":"Question","color":"cc317c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-30T14:37:48Z","updated_at":"2018-07-30T15:23:42Z","closed_at":null,"author_association":"MEMBER","body":"During the assembling process in the residual_based_builder_and_solver.h specifically in the function AssembleRowContribution, there is an if condition checking if the position to assemble is less than or greater than previous position : \r\n\r\nhttps://github.com/KratosMultiphysics/Kratos/blob/59a94ce5394cee532c9ad9f0f8a33be19594ade2/kratos/solving_strategies/builder_and_solvers/residualbased_block_builder_and_solver.h#L1325\r\n\r\nshould there be check if there it is equal also ?  Something like this : \r\n```\r\n            if(id_to_find > last_found)\r\n                pos = ForwardFind(id_to_find,last_pos+1,index2_vector);\r\n            else if(id_to_find < last_found)\r\n                pos = BackwardFind(id_to_find,last_pos-1,index2_vector);\r\n            else\r\n                pos = last_pos;\r\n```\r\nThis is necessary for the implementation of Constraints. Since when there are constraints, there is a possibility that there is a repeated entry in EquationIds.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/comments/408902845","html_url":"https://github.com/KratosMultiphysics/Kratos/issues/2604#issuecomment-408902845","issue_url":"https://api.github.com/repos/KratosMultiphysics/Kratos/issues/2604","id":408902845,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODkwMjg0NQ==","user":{"login":"RiccardoRossi","id":8059665,"node_id":"MDQ6VXNlcjgwNTk2NjU=","avatar_url":"https://avatars1.githubusercontent.com/u/8059665?v=4","gravatar_id":"","url":"https://api.github.com/users/RiccardoRossi","html_url":"https://github.com/RiccardoRossi","followers_url":"https://api.github.com/users/RiccardoRossi/followers","following_url":"https://api.github.com/users/RiccardoRossi/following{/other_user}","gists_url":"https://api.github.com/users/RiccardoRossi/gists{/gist_id}","starred_url":"https://api.github.com/users/RiccardoRossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RiccardoRossi/subscriptions","organizations_url":"https://api.github.com/users/RiccardoRossi/orgs","repos_url":"https://api.github.com/users/RiccardoRossi/repos","events_url":"https://api.github.com/users/RiccardoRossi/events{/privacy}","received_events_url":"https://api.github.com/users/RiccardoRossi/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T15:23:42Z","updated_at":"2018-07-30T15:23:42Z","author_association":"MEMBER","body":"they should have the same EquationId in the assembled system"}}
{"actor":{"display_login":"RiccardoRossi"}}