{"action":"created","issue":{"url":"https://api.github.com/repos/akitojp/products_app/issues/20","repository_url":"https://api.github.com/repos/akitojp/products_app","labels_url":"https://api.github.com/repos/akitojp/products_app/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/akitojp/products_app/issues/20/comments","events_url":"https://api.github.com/repos/akitojp/products_app/issues/20/events","html_url":"https://github.com/akitojp/products_app/pull/20","id":340266165,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzE4NjQ1","number":20,"title":"ProductへのLike機能を追加 と細かい変更、バグ修正","user":{"login":"akitojp","id":5659538,"node_id":"MDQ6VXNlcjU2NTk1Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5659538?v=4","gravatar_id":"","url":"https://api.github.com/users/akitojp","html_url":"https://github.com/akitojp","followers_url":"https://api.github.com/users/akitojp/followers","following_url":"https://api.github.com/users/akitojp/following{/other_user}","gists_url":"https://api.github.com/users/akitojp/gists{/gist_id}","starred_url":"https://api.github.com/users/akitojp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akitojp/subscriptions","organizations_url":"https://api.github.com/users/akitojp/orgs","repos_url":"https://api.github.com/users/akitojp/repos","events_url":"https://api.github.com/users/akitojp/events{/privacy}","received_events_url":"https://api.github.com/users/akitojp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-11T14:25:06Z","updated_at":"2018-07-17T04:47:32Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/akitojp/products_app/pulls/20","html_url":"https://github.com/akitojp/products_app/pull/20","diff_url":"https://github.com/akitojp/products_app/pull/20.diff","patch_url":"https://github.com/akitojp/products_app/pull/20.patch"},"body":"お疲れ様です。ProductへのLike機能を追加 https://github.com/akitojp/products_app/issues/15 と細かい変更、バグ修正 https://github.com/akitojp/products_app/issues/17  を行いました。\r\n\r\nコミットの記録が煩雑になってしまい申し訳ございません。\r\n\r\nRSpecを調べながら書いていたのですが、少々時間がかかってしまいそうなので、一旦PRを作成させていただきました。そのため、RSpecの以外の部分をレビューしていただけたら幸いです。\r\n\r\n行なったこと\r\n- application設定を変更\r\n- 不要なファイルの削除\r\n- タイムゾーンを東京に変更\r\n- 新規登録ができないエラー対応\r\n- Like機能の実装\r\n- fontawesomeの導入\r\n- Like Countの実装\r\n- page_titleヘルパーの導入"},"comment":{"url":"https://api.github.com/repos/akitojp/products_app/issues/comments/405458235","html_url":"https://github.com/akitojp/products_app/pull/20#issuecomment-405458235","issue_url":"https://api.github.com/repos/akitojp/products_app/issues/20","id":405458235,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTQ1ODIzNQ==","user":{"login":"akitojp","id":5659538,"node_id":"MDQ6VXNlcjU2NTk1Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5659538?v=4","gravatar_id":"","url":"https://api.github.com/users/akitojp","html_url":"https://github.com/akitojp","followers_url":"https://api.github.com/users/akitojp/followers","following_url":"https://api.github.com/users/akitojp/following{/other_user}","gists_url":"https://api.github.com/users/akitojp/gists{/gist_id}","starred_url":"https://api.github.com/users/akitojp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akitojp/subscriptions","organizations_url":"https://api.github.com/users/akitojp/orgs","repos_url":"https://api.github.com/users/akitojp/repos","events_url":"https://api.github.com/users/akitojp/events{/privacy}","received_events_url":"https://api.github.com/users/akitojp/received_events","type":"User","site_admin":false},"created_at":"2018-07-17T04:47:32Z","updated_at":"2018-07-17T04:47:32Z","author_association":"OWNER","body":"@shoheis \r\n\r\nレビューありがとうございました！Rspecの部分を修正いたしました。\r\n\r\n>テストもだいたい良さそうですね。\r\nリレーションの部分を少し理解できたので、テストデータの作り方などわかってきました。ありがとうございます。\r\n\r\n> validationのテストですが(練習という意味ではとても良いです！)実際の開発ですとあまりやることはないです。自作のvalidationだとやることはあります。\r\nそうなんですね。テストの作成範囲など良くわかってなかったので、そのような線引の考え方を教えてくださってとても助かりました!\r\n"}}
{"actor":{"display_login":"akitojp"}}