{"action":"opened","issue":{"url":"https://api.github.com/repos/requests/toolbelt/issues/226","repository_url":"https://api.github.com/repos/requests/toolbelt","labels_url":"https://api.github.com/repos/requests/toolbelt/issues/226/labels{/name}","comments_url":"https://api.github.com/repos/requests/toolbelt/issues/226/comments","events_url":"https://api.github.com/repos/requests/toolbelt/issues/226/events","html_url":"https://github.com/requests/toolbelt/issues/226","id":366264764,"node_id":"MDU6SXNzdWUzNjYyNjQ3NjQ=","number":226,"title":"Redacting sensitive headers when dumping request/response","user":{"login":"mortenlj","id":746078,"node_id":"MDQ6VXNlcjc0NjA3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/746078?v=4","gravatar_id":"","url":"https://api.github.com/users/mortenlj","html_url":"https://github.com/mortenlj","followers_url":"https://api.github.com/users/mortenlj/followers","following_url":"https://api.github.com/users/mortenlj/following{/other_user}","gists_url":"https://api.github.com/users/mortenlj/gists{/gist_id}","starred_url":"https://api.github.com/users/mortenlj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortenlj/subscriptions","organizations_url":"https://api.github.com/users/mortenlj/orgs","repos_url":"https://api.github.com/users/mortenlj/repos","events_url":"https://api.github.com/users/mortenlj/events{/privacy}","received_events_url":"https://api.github.com/users/mortenlj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-03T10:10:50Z","updated_at":"2018-10-03T10:10:50Z","closed_at":null,"author_association":"NONE","body":"In our project we have implemented dumping of request and response when debug-mode is enabled. Since this might end up in logfiles or other places where sensitive data is unwanted, we implemented a blacklist for sensitive headers.\r\n\r\nCould something similar be implemented in the `dump_response` and `dump_all` methods here? Then we could get rid of our own implementation and just use toolbelt. Maybe make it optional?\r\n\r\nFeel free to look at/borrow from our implementation here: https://github.com/fiaas/k8s/blob/master/k8s/client.py\r\n"}}
{"actor":{"display_login":"mortenlj"}}