{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/225199774","pull_request_review_id":164748851,"id":225199774,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTE5OTc3NA==","diff_hunk":"@@ -3082,8 +3082,11 @@ public static function get(\n      *\n      * @return DataObject|null The first item matching the query\n      */\n-    public static function get_one($callerClass, $filter = \"\", $cache = true, $orderby = \"\")\n+    public static function get_one($callerClass = null, $filter = \"\", $cache = true, $orderby = \"\")","path":"src/ORM/DataObject.php","position":5,"original_position":5,"commit_id":"62c750bf95eac811ee41cc184f771dcd0a346f06","original_commit_id":"62c750bf95eac811ee41cc184f771dcd0a346f06","user":{"login":"robbieaverill","id":5170590,"node_id":"MDQ6VXNlcjUxNzA1OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5170590?v=4","gravatar_id":"","url":"https://api.github.com/users/robbieaverill","html_url":"https://github.com/robbieaverill","followers_url":"https://api.github.com/users/robbieaverill/followers","following_url":"https://api.github.com/users/robbieaverill/following{/other_user}","gists_url":"https://api.github.com/users/robbieaverill/gists{/gist_id}","starred_url":"https://api.github.com/users/robbieaverill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbieaverill/subscriptions","organizations_url":"https://api.github.com/users/robbieaverill/orgs","repos_url":"https://api.github.com/users/robbieaverill/repos","events_url":"https://api.github.com/users/robbieaverill/events{/privacy}","received_events_url":"https://api.github.com/users/robbieaverill/received_events","type":"User","site_admin":false},"body":"LGTM, the docblock for the callerClass argument could do with a little tweak tho","created_at":"2018-10-15T15:00:49Z","updated_at":"2018-10-15T15:00:50Z","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/8480#discussion_r225199774","pull_request_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8480","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/225199774"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/8480#discussion_r225199774"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8480"}}},"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8480","id":222932020,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTMyMDIw","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/8480","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/8480.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/8480.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/8480","number":8480,"state":"open","locked":false,"title":"allow dataobject get_one without passing a class","user":{"login":"andrewandante","id":9702648,"node_id":"MDQ6VXNlcjk3MDI2NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/9702648?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewandante","html_url":"https://github.com/andrewandante","followers_url":"https://api.github.com/users/andrewandante/followers","following_url":"https://api.github.com/users/andrewandante/following{/other_user}","gists_url":"https://api.github.com/users/andrewandante/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewandante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewandante/subscriptions","organizations_url":"https://api.github.com/users/andrewandante/orgs","repos_url":"https://api.github.com/users/andrewandante/repos","events_url":"https://api.github.com/users/andrewandante/events{/privacy}","received_events_url":"https://api.github.com/users/andrewandante/received_events","type":"User","site_admin":false},"body":"Moved #8479 because of non-BC","created_at":"2018-10-15T14:43:05Z","updated_at":"2018-10-15T15:00:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fdf9d097e6cf03b9d358288896b6295f4739af63","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8480/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8480/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/8480/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/62c750bf95eac811ee41cc184f771dcd0a346f06","head":{"label":"andrewandante:pulls/5/allow_implied_dataobject_get_one_class","ref":"pulls/5/allow_implied_dataobject_get_one_class","sha":"62c750bf95eac811ee41cc184f771dcd0a346f06","user":{"login":"andrewandante","id":9702648,"node_id":"MDQ6VXNlcjk3MDI2NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/9702648?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewandante","html_url":"https://github.com/andrewandante","followers_url":"https://api.github.com/users/andrewandante/followers","following_url":"https://api.github.com/users/andrewandante/following{/other_user}","gists_url":"https://api.github.com/users/andrewandante/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewandante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewandante/subscriptions","organizations_url":"https://api.github.com/users/andrewandante/orgs","repos_url":"https://api.github.com/users/andrewandante/repos","events_url":"https://api.github.com/users/andrewandante/events{/privacy}","received_events_url":"https://api.github.com/users/andrewandante/received_events","type":"User","site_admin":false},"repo":{"id":64725084,"node_id":"MDEwOlJlcG9zaXRvcnk2NDcyNTA4NA==","name":"silverstripe-framework","full_name":"andrewandante/silverstripe-framework","private":false,"owner":{"login":"andrewandante","id":9702648,"node_id":"MDQ6VXNlcjk3MDI2NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/9702648?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewandante","html_url":"https://github.com/andrewandante","followers_url":"https://api.github.com/users/andrewandante/followers","following_url":"https://api.github.com/users/andrewandante/following{/other_user}","gists_url":"https://api.github.com/users/andrewandante/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewandante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewandante/subscriptions","organizations_url":"https://api.github.com/users/andrewandante/orgs","repos_url":"https://api.github.com/users/andrewandante/repos","events_url":"https://api.github.com/users/andrewandante/events{/privacy}","received_events_url":"https://api.github.com/users/andrewandante/received_events","type":"User","site_admin":false},"html_url":"https://github.com/andrewandante/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":true,"url":"https://api.github.com/repos/andrewandante/silverstripe-framework","forks_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/releases{/id}","deployments_url":"https://api.github.com/repos/andrewandante/silverstripe-framework/deployments","created_at":"2016-08-02T04:49:21Z","updated_at":"2017-02-06T09:19:38Z","pushed_at":"2018-10-15T14:41:45Z","git_url":"git://github.com/andrewandante/silverstripe-framework.git","ssh_url":"git@github.com:andrewandante/silverstripe-framework.git","clone_url":"https://github.com/andrewandante/silverstripe-framework.git","svn_url":"https://github.com/andrewandante/silverstripe-framework","homepage":"http://silverstripe.org/","size":100596,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"silverstripe:master","ref":"master","sha":"4051f86b15e2e355c3998985feba2966eb88a8dd","user":{"login":"silverstripe","id":379348,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTM0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/379348?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1318892,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE4ODky","name":"silverstripe-framework","full_name":"silverstripe/silverstripe-framework","private":false,"owner":{"login":"silverstripe","id":379348,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTM0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/379348?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/silverstripe/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-framework","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/deployments","created_at":"2011-02-02T02:04:13Z","updated_at":"2018-10-15T12:10:55Z","pushed_at":"2018-10-15T14:43:06Z","git_url":"git://github.com/silverstripe/silverstripe-framework.git","ssh_url":"git@github.com:silverstripe/silverstripe-framework.git","clone_url":"https://github.com/silverstripe/silverstripe-framework.git","svn_url":"https://github.com/silverstripe/silverstripe-framework","homepage":"http://silverstripe.org/","size":101186,"stargazers_count":607,"watchers_count":607,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":710,"mirror_url":null,"archived":false,"open_issues_count":497,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":710,"open_issues":497,"watchers":607,"default_branch":"4"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8480"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/8480"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/8480"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/8480/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8480/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8480/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/62c750bf95eac811ee41cc184f771dcd0a346f06"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robbieaverill"}}