{"action":"created","comment":{"url":"https://api.github.com/repos/plotly/orca/pulls/comments/217507118","pull_request_review_id":155237612,"id":217507118,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzUwNzExOA==","diff_hunk":"@@ -43,6 +54,13 @@ spec:\n         ports:\n         - name: http-server\n           containerPort: 9091\n+        resources:\n+         limits:\n+           cpu: 600m\n+           memory: 1Gi","path":"deployment/kube/stage/frontend.yaml","position":32,"original_position":32,"commit_id":"404034a6268c1814c4a64e3b27ca5995f4da4896","original_commit_id":"404034a6268c1814c4a64e3b27ca5995f4da4896","user":{"login":"scjody","id":1136329,"node_id":"MDQ6VXNlcjExMzYzMjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1136329?v=4","gravatar_id":"","url":"https://api.github.com/users/scjody","html_url":"https://github.com/scjody","followers_url":"https://api.github.com/users/scjody/followers","following_url":"https://api.github.com/users/scjody/following{/other_user}","gists_url":"https://api.github.com/users/scjody/gists{/gist_id}","starred_url":"https://api.github.com/users/scjody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scjody/subscriptions","organizations_url":"https://api.github.com/users/scjody/orgs","repos_url":"https://api.github.com/users/scjody/repos","events_url":"https://api.github.com/users/scjody/events{/privacy}","received_events_url":"https://api.github.com/users/scjody/received_events","type":"User","site_admin":false},"body":"OK, sounds good.","created_at":"2018-09-13T19:31:51Z","updated_at":"2018-09-13T19:31:51Z","html_url":"https://github.com/plotly/orca/pull/128#discussion_r217507118","pull_request_url":"https://api.github.com/repos/plotly/orca/pulls/128","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/plotly/orca/pulls/comments/217507118"},"html":{"href":"https://github.com/plotly/orca/pull/128#discussion_r217507118"},"pull_request":{"href":"https://api.github.com/repos/plotly/orca/pulls/128"}},"in_reply_to_id":217429412},"pull_request":{"url":"https://api.github.com/repos/plotly/orca/pulls/128","id":214718779,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NzE4Nzc5","html_url":"https://github.com/plotly/orca/pull/128","diff_url":"https://github.com/plotly/orca/pull/128.diff","patch_url":"https://github.com/plotly/orca/pull/128.patch","issue_url":"https://api.github.com/repos/plotly/orca/issues/128","number":128,"state":"open","locked":false,"title":"WIP add resources limit for proper scaling","user":{"login":"mag009","id":1110783,"node_id":"MDQ6VXNlcjExMTA3ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/1110783?v=4","gravatar_id":"","url":"https://api.github.com/users/mag009","html_url":"https://github.com/mag009","followers_url":"https://api.github.com/users/mag009/followers","following_url":"https://api.github.com/users/mag009/following{/other_user}","gists_url":"https://api.github.com/users/mag009/gists{/gist_id}","starred_url":"https://api.github.com/users/mag009/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mag009/subscriptions","organizations_url":"https://api.github.com/users/mag009/orgs","repos_url":"https://api.github.com/users/mag009/repos","events_url":"https://api.github.com/users/mag009/events{/privacy}","received_events_url":"https://api.github.com/users/mag009/received_events","type":"User","site_admin":false},"body":"See plotly/streambed#9865 and plotly/streambed#11037\r\n\r\nReason for removing the --request-limit is because currently when we hit the 1000 requests the server exit but the container stays up monit handle the restart and when you do that the container is still healthy on the LB. So it is possible that client connect and hit a connection refused.\r\n\r\nTo avoid that I'm limiting the resources of the container cpu and memory in which if the app have a memory leak it will kill the container and making it unavailable to the LB and just spin a new container.\r\n\r\nThe annotation is required to scale-down, if a container spin-up on a node where kube-system is running so it tells it's okay to kill that node.\r\n\r\n- [x] issues with down-scale, does not down-scale node that should\r\n- [ ] fined tuning the resources\r\n- [ ] ~~preemptive instances~~\r\n- [x] deal with evicted instances\r\n\r\ntested with : \r\nab -r -c 100 -n 100000 -p 86eac25f-4de9-4da2-82a9-0c7d28db1454_200.json http://10.128.0.17:9091/","created_at":"2018-09-11T18:08:23Z","updated_at":"2018-09-13T19:31:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4548a3aaadf636aaf787fa674f5bdbd182772e34","assignee":{"login":"mag009","id":1110783,"node_id":"MDQ6VXNlcjExMTA3ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/1110783?v=4","gravatar_id":"","url":"https://api.github.com/users/mag009","html_url":"https://github.com/mag009","followers_url":"https://api.github.com/users/mag009/followers","following_url":"https://api.github.com/users/mag009/following{/other_user}","gists_url":"https://api.github.com/users/mag009/gists{/gist_id}","starred_url":"https://api.github.com/users/mag009/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mag009/subscriptions","organizations_url":"https://api.github.com/users/mag009/orgs","repos_url":"https://api.github.com/users/mag009/repos","events_url":"https://api.github.com/users/mag009/events{/privacy}","received_events_url":"https://api.github.com/users/mag009/received_events","type":"User","site_admin":false},"assignees":[{"login":"mag009","id":1110783,"node_id":"MDQ6VXNlcjExMTA3ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/1110783?v=4","gravatar_id":"","url":"https://api.github.com/users/mag009","html_url":"https://github.com/mag009","followers_url":"https://api.github.com/users/mag009/followers","following_url":"https://api.github.com/users/mag009/following{/other_user}","gists_url":"https://api.github.com/users/mag009/gists{/gist_id}","starred_url":"https://api.github.com/users/mag009/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mag009/subscriptions","organizations_url":"https://api.github.com/users/mag009/orgs","repos_url":"https://api.github.com/users/mag009/repos","events_url":"https://api.github.com/users/mag009/events{/privacy}","received_events_url":"https://api.github.com/users/mag009/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"etpinard","id":6675409,"node_id":"MDQ6VXNlcjY2NzU0MDk=","avatar_url":"https://avatars0.githubusercontent.com/u/6675409?v=4","gravatar_id":"","url":"https://api.github.com/users/etpinard","html_url":"https://github.com/etpinard","followers_url":"https://api.github.com/users/etpinard/followers","following_url":"https://api.github.com/users/etpinard/following{/other_user}","gists_url":"https://api.github.com/users/etpinard/gists{/gist_id}","starred_url":"https://api.github.com/users/etpinard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etpinard/subscriptions","organizations_url":"https://api.github.com/users/etpinard/orgs","repos_url":"https://api.github.com/users/etpinard/repos","events_url":"https://api.github.com/users/etpinard/events{/privacy}","received_events_url":"https://api.github.com/users/etpinard/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":759502919,"node_id":"MDU6TGFiZWw3NTk1MDI5MTk=","url":"https://api.github.com/repos/plotly/orca/labels/in%20progress","name":"in progress","color":"8ff711","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/plotly/orca/pulls/128/commits","review_comments_url":"https://api.github.com/repos/plotly/orca/pulls/128/comments","review_comment_url":"https://api.github.com/repos/plotly/orca/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plotly/orca/issues/128/comments","statuses_url":"https://api.github.com/repos/plotly/orca/statuses/404034a6268c1814c4a64e3b27ca5995f4da4896","head":{"label":"plotly:autoscale_k8s","ref":"autoscale_k8s","sha":"404034a6268c1814c4a64e3b27ca5995f4da4896","user":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":99037241,"node_id":"MDEwOlJlcG9zaXRvcnk5OTAzNzI0MQ==","name":"orca","full_name":"plotly/orca","owner":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plotly/orca","description":"Command line application for generating static images of interactive plotly charts","fork":false,"url":"https://api.github.com/repos/plotly/orca","forks_url":"https://api.github.com/repos/plotly/orca/forks","keys_url":"https://api.github.com/repos/plotly/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/orca/teams","hooks_url":"https://api.github.com/repos/plotly/orca/hooks","issue_events_url":"https://api.github.com/repos/plotly/orca/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/orca/events","assignees_url":"https://api.github.com/repos/plotly/orca/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/orca/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/orca/tags","blobs_url":"https://api.github.com/repos/plotly/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/orca/languages","stargazers_url":"https://api.github.com/repos/plotly/orca/stargazers","contributors_url":"https://api.github.com/repos/plotly/orca/contributors","subscribers_url":"https://api.github.com/repos/plotly/orca/subscribers","subscription_url":"https://api.github.com/repos/plotly/orca/subscription","commits_url":"https://api.github.com/repos/plotly/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/plotly/orca/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/orca/merges","archive_url":"https://api.github.com/repos/plotly/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/orca/downloads","issues_url":"https://api.github.com/repos/plotly/orca/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/orca/labels{/name}","releases_url":"https://api.github.com/repos/plotly/orca/releases{/id}","deployments_url":"https://api.github.com/repos/plotly/orca/deployments","created_at":"2017-08-01T19:45:43Z","updated_at":"2018-09-13T16:43:53Z","pushed_at":"2018-09-13T19:31:39Z","git_url":"git://github.com/plotly/orca.git","ssh_url":"git@github.com:plotly/orca.git","clone_url":"https://github.com/plotly/orca.git","svn_url":"https://github.com/plotly/orca","homepage":"","size":648,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":34,"watchers":38,"default_branch":"master"}},"base":{"label":"plotly:master","ref":"master","sha":"d50563f4d6dbc20c4a5a37e15c9465f90e97a37a","user":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"repo":{"id":99037241,"node_id":"MDEwOlJlcG9zaXRvcnk5OTAzNzI0MQ==","name":"orca","full_name":"plotly/orca","owner":{"login":"plotly","id":5997976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5OTc5NzY=","avatar_url":"https://avatars2.githubusercontent.com/u/5997976?v=4","gravatar_id":"","url":"https://api.github.com/users/plotly","html_url":"https://github.com/plotly","followers_url":"https://api.github.com/users/plotly/followers","following_url":"https://api.github.com/users/plotly/following{/other_user}","gists_url":"https://api.github.com/users/plotly/gists{/gist_id}","starred_url":"https://api.github.com/users/plotly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plotly/subscriptions","organizations_url":"https://api.github.com/users/plotly/orgs","repos_url":"https://api.github.com/users/plotly/repos","events_url":"https://api.github.com/users/plotly/events{/privacy}","received_events_url":"https://api.github.com/users/plotly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plotly/orca","description":"Command line application for generating static images of interactive plotly charts","fork":false,"url":"https://api.github.com/repos/plotly/orca","forks_url":"https://api.github.com/repos/plotly/orca/forks","keys_url":"https://api.github.com/repos/plotly/orca/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plotly/orca/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plotly/orca/teams","hooks_url":"https://api.github.com/repos/plotly/orca/hooks","issue_events_url":"https://api.github.com/repos/plotly/orca/issues/events{/number}","events_url":"https://api.github.com/repos/plotly/orca/events","assignees_url":"https://api.github.com/repos/plotly/orca/assignees{/user}","branches_url":"https://api.github.com/repos/plotly/orca/branches{/branch}","tags_url":"https://api.github.com/repos/plotly/orca/tags","blobs_url":"https://api.github.com/repos/plotly/orca/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plotly/orca/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plotly/orca/git/refs{/sha}","trees_url":"https://api.github.com/repos/plotly/orca/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plotly/orca/statuses/{sha}","languages_url":"https://api.github.com/repos/plotly/orca/languages","stargazers_url":"https://api.github.com/repos/plotly/orca/stargazers","contributors_url":"https://api.github.com/repos/plotly/orca/contributors","subscribers_url":"https://api.github.com/repos/plotly/orca/subscribers","subscription_url":"https://api.github.com/repos/plotly/orca/subscription","commits_url":"https://api.github.com/repos/plotly/orca/commits{/sha}","git_commits_url":"https://api.github.com/repos/plotly/orca/git/commits{/sha}","comments_url":"https://api.github.com/repos/plotly/orca/comments{/number}","issue_comment_url":"https://api.github.com/repos/plotly/orca/issues/comments{/number}","contents_url":"https://api.github.com/repos/plotly/orca/contents/{+path}","compare_url":"https://api.github.com/repos/plotly/orca/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plotly/orca/merges","archive_url":"https://api.github.com/repos/plotly/orca/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plotly/orca/downloads","issues_url":"https://api.github.com/repos/plotly/orca/issues{/number}","pulls_url":"https://api.github.com/repos/plotly/orca/pulls{/number}","milestones_url":"https://api.github.com/repos/plotly/orca/milestones{/number}","notifications_url":"https://api.github.com/repos/plotly/orca/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plotly/orca/labels{/name}","releases_url":"https://api.github.com/repos/plotly/orca/releases{/id}","deployments_url":"https://api.github.com/repos/plotly/orca/deployments","created_at":"2017-08-01T19:45:43Z","updated_at":"2018-09-13T16:43:53Z","pushed_at":"2018-09-13T19:31:39Z","git_url":"git://github.com/plotly/orca.git","ssh_url":"git@github.com:plotly/orca.git","clone_url":"https://github.com/plotly/orca.git","svn_url":"https://github.com/plotly/orca","homepage":"","size":648,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":34,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plotly/orca/pulls/128"},"html":{"href":"https://github.com/plotly/orca/pull/128"},"issue":{"href":"https://api.github.com/repos/plotly/orca/issues/128"},"comments":{"href":"https://api.github.com/repos/plotly/orca/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/plotly/orca/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/plotly/orca/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plotly/orca/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/plotly/orca/statuses/404034a6268c1814c4a64e3b27ca5995f4da4896"}},"author_association":"NONE"}}
{"actor":{"display_login":"scjody"}}