{"action":"created","comment":{"url":"https://api.github.com/repos/Parsely/wp-parsely/pulls/comments/217554724","pull_request_review_id":155297716,"id":217554724,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzU1NDcyNA==","diff_hunk":"@@ -721,7 +721,29 @@ public function insert_parsely_page() {\n \n \t\t$current_url = $this->get_current_url();\n \n-\t\tif ( in_array( get_post_type(), $parsely_options['track_post_types'], true ) && 'publish' === $post->post_status ) {\n+\t\tif ( is_home() ) {\n+\t\t\t$parsely_page['@type'] = 'WebPage';\n+\t\t\t// If front page is set to display a static page, get the URL of the posts page.","path":"wp-parsely.php","position":7,"original_position":7,"commit_id":"41f4f5b9853eabc3e4898b25ada7f01f4147ce14","original_commit_id":"41f4f5b9853eabc3e4898b25ada7f01f4147ce14","user":{"login":"joshuarrrr","id":1679762,"node_id":"MDQ6VXNlcjE2Nzk3NjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1679762?v=4","gravatar_id":"","url":"https://api.github.com/users/joshuarrrr","html_url":"https://github.com/joshuarrrr","followers_url":"https://api.github.com/users/joshuarrrr/followers","following_url":"https://api.github.com/users/joshuarrrr/following{/other_user}","gists_url":"https://api.github.com/users/joshuarrrr/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuarrrr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuarrrr/subscriptions","organizations_url":"https://api.github.com/users/joshuarrrr/orgs","repos_url":"https://api.github.com/users/joshuarrrr/repos","events_url":"https://api.github.com/users/joshuarrrr/events{/privacy}","received_events_url":"https://api.github.com/users/joshuarrrr/received_events","type":"User","site_admin":false},"body":"I'm having a hard time visualizing these two situations and the urls they will return. I'm sure I'm missing something obvious about why we can't just use `get_home_url` for both. Docstring examples would be nice, but test cases are probably preferable.","created_at":"2018-09-13T22:34:57Z","updated_at":"2018-09-13T22:41:52Z","html_url":"https://github.com/Parsely/wp-parsely/pull/107#discussion_r217554724","pull_request_url":"https://api.github.com/repos/Parsely/wp-parsely/pulls/107","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Parsely/wp-parsely/pulls/comments/217554724"},"html":{"href":"https://github.com/Parsely/wp-parsely/pull/107#discussion_r217554724"},"pull_request":{"href":"https://api.github.com/repos/Parsely/wp-parsely/pulls/107"}}},"pull_request":{"url":"https://api.github.com/repos/Parsely/wp-parsely/pulls/107","id":214717816,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NzE3ODE2","html_url":"https://github.com/Parsely/wp-parsely/pull/107","diff_url":"https://github.com/Parsely/wp-parsely/pull/107.diff","patch_url":"https://github.com/Parsely/wp-parsely/pull/107.patch","issue_url":"https://api.github.com/repos/Parsely/wp-parsely/issues/107","number":107,"state":"open","locked":false,"title":"Handle home pages that are posts pages","user":{"login":"katjwinter","id":4388345,"node_id":"MDQ6VXNlcjQzODgzNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/4388345?v=4","gravatar_id":"","url":"https://api.github.com/users/katjwinter","html_url":"https://github.com/katjwinter","followers_url":"https://api.github.com/users/katjwinter/followers","following_url":"https://api.github.com/users/katjwinter/following{/other_user}","gists_url":"https://api.github.com/users/katjwinter/gists{/gist_id}","starred_url":"https://api.github.com/users/katjwinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katjwinter/subscriptions","organizations_url":"https://api.github.com/users/katjwinter/orgs","repos_url":"https://api.github.com/users/katjwinter/repos","events_url":"https://api.github.com/users/katjwinter/events{/privacy}","received_events_url":"https://api.github.com/users/katjwinter/received_events","type":"User","site_admin":false},"body":"Need to treat like archive pages instead of like a static page, because it loops through posts so we can't just grab the post information like we normally would, or else we'll just wind up with metadata for the first listed post and not the actual index page itself.\r\n\r\nAddresses problems such as: https://github.com/Parsely/web/issues/8201","created_at":"2018-09-11T18:04:36Z","updated_at":"2018-09-13T22:41:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec33e8b16d0323edd09835b2b00030f6d1caf1bd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Parsely/wp-parsely/pulls/107/commits","review_comments_url":"https://api.github.com/repos/Parsely/wp-parsely/pulls/107/comments","review_comment_url":"https://api.github.com/repos/Parsely/wp-parsely/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Parsely/wp-parsely/issues/107/comments","statuses_url":"https://api.github.com/repos/Parsely/wp-parsely/statuses/41f4f5b9853eabc3e4898b25ada7f01f4147ce14","head":{"label":"Parsely:bugfix/handle-home-posts-pages","ref":"bugfix/handle-home-posts-pages","sha":"41f4f5b9853eabc3e4898b25ada7f01f4147ce14","user":{"login":"Parsely","id":779641,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3OTY0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/779641?v=4","gravatar_id":"","url":"https://api.github.com/users/Parsely","html_url":"https://github.com/Parsely","followers_url":"https://api.github.com/users/Parsely/followers","following_url":"https://api.github.com/users/Parsely/following{/other_user}","gists_url":"https://api.github.com/users/Parsely/gists{/gist_id}","starred_url":"https://api.github.com/users/Parsely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parsely/subscriptions","organizations_url":"https://api.github.com/users/Parsely/orgs","repos_url":"https://api.github.com/users/Parsely/repos","events_url":"https://api.github.com/users/Parsely/events{/privacy}","received_events_url":"https://api.github.com/users/Parsely/received_events","type":"Organization","site_admin":false},"repo":{"id":5023534,"node_id":"MDEwOlJlcG9zaXRvcnk1MDIzNTM0","name":"wp-parsely","full_name":"Parsely/wp-parsely","owner":{"login":"Parsely","id":779641,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3OTY0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/779641?v=4","gravatar_id":"","url":"https://api.github.com/users/Parsely","html_url":"https://github.com/Parsely","followers_url":"https://api.github.com/users/Parsely/followers","following_url":"https://api.github.com/users/Parsely/following{/other_user}","gists_url":"https://api.github.com/users/Parsely/gists{/gist_id}","starred_url":"https://api.github.com/users/Parsely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parsely/subscriptions","organizations_url":"https://api.github.com/users/Parsely/orgs","repos_url":"https://api.github.com/users/Parsely/repos","events_url":"https://api.github.com/users/Parsely/events{/privacy}","received_events_url":"https://api.github.com/users/Parsely/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Parsely/wp-parsely","description":"The official WordPress plugin for Parse.ly - makes it a snap to add the required tracking code to enable Parse.ly on your WordPress site.","fork":false,"url":"https://api.github.com/repos/Parsely/wp-parsely","forks_url":"https://api.github.com/repos/Parsely/wp-parsely/forks","keys_url":"https://api.github.com/repos/Parsely/wp-parsely/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Parsely/wp-parsely/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Parsely/wp-parsely/teams","hooks_url":"https://api.github.com/repos/Parsely/wp-parsely/hooks","issue_events_url":"https://api.github.com/repos/Parsely/wp-parsely/issues/events{/number}","events_url":"https://api.github.com/repos/Parsely/wp-parsely/events","assignees_url":"https://api.github.com/repos/Parsely/wp-parsely/assignees{/user}","branches_url":"https://api.github.com/repos/Parsely/wp-parsely/branches{/branch}","tags_url":"https://api.github.com/repos/Parsely/wp-parsely/tags","blobs_url":"https://api.github.com/repos/Parsely/wp-parsely/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Parsely/wp-parsely/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Parsely/wp-parsely/git/refs{/sha}","trees_url":"https://api.github.com/repos/Parsely/wp-parsely/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Parsely/wp-parsely/statuses/{sha}","languages_url":"https://api.github.com/repos/Parsely/wp-parsely/languages","stargazers_url":"https://api.github.com/repos/Parsely/wp-parsely/stargazers","contributors_url":"https://api.github.com/repos/Parsely/wp-parsely/contributors","subscribers_url":"https://api.github.com/repos/Parsely/wp-parsely/subscribers","subscription_url":"https://api.github.com/repos/Parsely/wp-parsely/subscription","commits_url":"https://api.github.com/repos/Parsely/wp-parsely/commits{/sha}","git_commits_url":"https://api.github.com/repos/Parsely/wp-parsely/git/commits{/sha}","comments_url":"https://api.github.com/repos/Parsely/wp-parsely/comments{/number}","issue_comment_url":"https://api.github.com/repos/Parsely/wp-parsely/issues/comments{/number}","contents_url":"https://api.github.com/repos/Parsely/wp-parsely/contents/{+path}","compare_url":"https://api.github.com/repos/Parsely/wp-parsely/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Parsely/wp-parsely/merges","archive_url":"https://api.github.com/repos/Parsely/wp-parsely/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Parsely/wp-parsely/downloads","issues_url":"https://api.github.com/repos/Parsely/wp-parsely/issues{/number}","pulls_url":"https://api.github.com/repos/Parsely/wp-parsely/pulls{/number}","milestones_url":"https://api.github.com/repos/Parsely/wp-parsely/milestones{/number}","notifications_url":"https://api.github.com/repos/Parsely/wp-parsely/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Parsely/wp-parsely/labels{/name}","releases_url":"https://api.github.com/repos/Parsely/wp-parsely/releases{/id}","deployments_url":"https://api.github.com/repos/Parsely/wp-parsely/deployments","created_at":"2012-07-13T18:45:48Z","updated_at":"2018-06-18T16:03:27Z","pushed_at":"2018-09-13T01:39:26Z","git_url":"git://github.com/Parsely/wp-parsely.git","ssh_url":"git@github.com:Parsely/wp-parsely.git","clone_url":"https://github.com/Parsely/wp-parsely.git","svn_url":"https://github.com/Parsely/wp-parsely","homepage":"","size":2142,"stargazers_count":11,"watchers_count":11,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":18,"license":null,"forks":14,"open_issues":18,"watchers":11,"default_branch":"master"}},"base":{"label":"Parsely:master","ref":"master","sha":"bbeeed1cf373c2fc59d481c661861dbbc337ab73","user":{"login":"Parsely","id":779641,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3OTY0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/779641?v=4","gravatar_id":"","url":"https://api.github.com/users/Parsely","html_url":"https://github.com/Parsely","followers_url":"https://api.github.com/users/Parsely/followers","following_url":"https://api.github.com/users/Parsely/following{/other_user}","gists_url":"https://api.github.com/users/Parsely/gists{/gist_id}","starred_url":"https://api.github.com/users/Parsely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parsely/subscriptions","organizations_url":"https://api.github.com/users/Parsely/orgs","repos_url":"https://api.github.com/users/Parsely/repos","events_url":"https://api.github.com/users/Parsely/events{/privacy}","received_events_url":"https://api.github.com/users/Parsely/received_events","type":"Organization","site_admin":false},"repo":{"id":5023534,"node_id":"MDEwOlJlcG9zaXRvcnk1MDIzNTM0","name":"wp-parsely","full_name":"Parsely/wp-parsely","owner":{"login":"Parsely","id":779641,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3OTY0MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/779641?v=4","gravatar_id":"","url":"https://api.github.com/users/Parsely","html_url":"https://github.com/Parsely","followers_url":"https://api.github.com/users/Parsely/followers","following_url":"https://api.github.com/users/Parsely/following{/other_user}","gists_url":"https://api.github.com/users/Parsely/gists{/gist_id}","starred_url":"https://api.github.com/users/Parsely/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Parsely/subscriptions","organizations_url":"https://api.github.com/users/Parsely/orgs","repos_url":"https://api.github.com/users/Parsely/repos","events_url":"https://api.github.com/users/Parsely/events{/privacy}","received_events_url":"https://api.github.com/users/Parsely/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Parsely/wp-parsely","description":"The official WordPress plugin for Parse.ly - makes it a snap to add the required tracking code to enable Parse.ly on your WordPress site.","fork":false,"url":"https://api.github.com/repos/Parsely/wp-parsely","forks_url":"https://api.github.com/repos/Parsely/wp-parsely/forks","keys_url":"https://api.github.com/repos/Parsely/wp-parsely/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Parsely/wp-parsely/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Parsely/wp-parsely/teams","hooks_url":"https://api.github.com/repos/Parsely/wp-parsely/hooks","issue_events_url":"https://api.github.com/repos/Parsely/wp-parsely/issues/events{/number}","events_url":"https://api.github.com/repos/Parsely/wp-parsely/events","assignees_url":"https://api.github.com/repos/Parsely/wp-parsely/assignees{/user}","branches_url":"https://api.github.com/repos/Parsely/wp-parsely/branches{/branch}","tags_url":"https://api.github.com/repos/Parsely/wp-parsely/tags","blobs_url":"https://api.github.com/repos/Parsely/wp-parsely/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Parsely/wp-parsely/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Parsely/wp-parsely/git/refs{/sha}","trees_url":"https://api.github.com/repos/Parsely/wp-parsely/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Parsely/wp-parsely/statuses/{sha}","languages_url":"https://api.github.com/repos/Parsely/wp-parsely/languages","stargazers_url":"https://api.github.com/repos/Parsely/wp-parsely/stargazers","contributors_url":"https://api.github.com/repos/Parsely/wp-parsely/contributors","subscribers_url":"https://api.github.com/repos/Parsely/wp-parsely/subscribers","subscription_url":"https://api.github.com/repos/Parsely/wp-parsely/subscription","commits_url":"https://api.github.com/repos/Parsely/wp-parsely/commits{/sha}","git_commits_url":"https://api.github.com/repos/Parsely/wp-parsely/git/commits{/sha}","comments_url":"https://api.github.com/repos/Parsely/wp-parsely/comments{/number}","issue_comment_url":"https://api.github.com/repos/Parsely/wp-parsely/issues/comments{/number}","contents_url":"https://api.github.com/repos/Parsely/wp-parsely/contents/{+path}","compare_url":"https://api.github.com/repos/Parsely/wp-parsely/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Parsely/wp-parsely/merges","archive_url":"https://api.github.com/repos/Parsely/wp-parsely/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Parsely/wp-parsely/downloads","issues_url":"https://api.github.com/repos/Parsely/wp-parsely/issues{/number}","pulls_url":"https://api.github.com/repos/Parsely/wp-parsely/pulls{/number}","milestones_url":"https://api.github.com/repos/Parsely/wp-parsely/milestones{/number}","notifications_url":"https://api.github.com/repos/Parsely/wp-parsely/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Parsely/wp-parsely/labels{/name}","releases_url":"https://api.github.com/repos/Parsely/wp-parsely/releases{/id}","deployments_url":"https://api.github.com/repos/Parsely/wp-parsely/deployments","created_at":"2012-07-13T18:45:48Z","updated_at":"2018-06-18T16:03:27Z","pushed_at":"2018-09-13T01:39:26Z","git_url":"git://github.com/Parsely/wp-parsely.git","ssh_url":"git@github.com:Parsely/wp-parsely.git","clone_url":"https://github.com/Parsely/wp-parsely.git","svn_url":"https://github.com/Parsely/wp-parsely","homepage":"","size":2142,"stargazers_count":11,"watchers_count":11,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":18,"license":null,"forks":14,"open_issues":18,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Parsely/wp-parsely/pulls/107"},"html":{"href":"https://github.com/Parsely/wp-parsely/pull/107"},"issue":{"href":"https://api.github.com/repos/Parsely/wp-parsely/issues/107"},"comments":{"href":"https://api.github.com/repos/Parsely/wp-parsely/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/Parsely/wp-parsely/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/Parsely/wp-parsely/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Parsely/wp-parsely/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/Parsely/wp-parsely/statuses/41f4f5b9853eabc3e4898b25ada7f01f4147ce14"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joshuarrrr"}}