{"action":"created","comment":{"url":"https://api.github.com/repos/gemini-testing/html-reporter/pulls/comments/171394558","pull_request_review_id":100240105,"id":171394558,"diff_hunk":"@@ -55,4 +55,12 @@ module.exports = class HermioneTestResultAdapter extends TestAdapter {\n     get description() {\n         return this._testResult.description;\n     }\n+\n+    get hasImageForError() {\n+        return !!this.currentPath || !!this.screenshot;\n+    }\n+\n+    get hasImageForSuccess() {\n+        return false;","path":"lib/test-adapter/hermione-test-adapter.js","position":10,"original_position":10,"commit_id":"6fd2aa3f7d7ab1f12f24d0deef606857f6081e58","original_commit_id":"6fd2aa3f7d7ab1f12f24d0deef606857f6081e58","user":{"login":"Dmitriy-kiselyov","id":25789153,"avatar_url":"https://avatars0.githubusercontent.com/u/25789153?v=4","gravatar_id":"","url":"https://api.github.com/users/Dmitriy-kiselyov","html_url":"https://github.com/Dmitriy-kiselyov","followers_url":"https://api.github.com/users/Dmitriy-kiselyov/followers","following_url":"https://api.github.com/users/Dmitriy-kiselyov/following{/other_user}","gists_url":"https://api.github.com/users/Dmitriy-kiselyov/gists{/gist_id}","starred_url":"https://api.github.com/users/Dmitriy-kiselyov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dmitriy-kiselyov/subscriptions","organizations_url":"https://api.github.com/users/Dmitriy-kiselyov/orgs","repos_url":"https://api.github.com/users/Dmitriy-kiselyov/repos","events_url":"https://api.github.com/users/Dmitriy-kiselyov/events{/privacy}","received_events_url":"https://api.github.com/users/Dmitriy-kiselyov/received_events","type":"User","site_admin":false},"body":"Раз пока не генериться правильная data скриншотов для hermione, возможность отображать скриншоты выключил","created_at":"2018-02-28T21:42:16Z","updated_at":"2018-02-28T21:42:16Z","html_url":"https://github.com/gemini-testing/html-reporter/pull/55#discussion_r171394558","pull_request_url":"https://api.github.com/repos/gemini-testing/html-reporter/pulls/55","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gemini-testing/html-reporter/pulls/comments/171394558"},"html":{"href":"https://github.com/gemini-testing/html-reporter/pull/55#discussion_r171394558"},"pull_request":{"href":"https://api.github.com/repos/gemini-testing/html-reporter/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/gemini-testing/html-reporter/pulls/55","id":172012503,"html_url":"https://github.com/gemini-testing/html-reporter/pull/55","diff_url":"https://github.com/gemini-testing/html-reporter/pull/55.diff","patch_url":"https://github.com/gemini-testing/html-reporter/pull/55.patch","issue_url":"https://api.github.com/repos/gemini-testing/html-reporter/issues/55","number":55,"state":"open","locked":false,"title":"Do not try to show image if screenshot has not been made","user":{"login":"Dmitriy-kiselyov","id":25789153,"avatar_url":"https://avatars0.githubusercontent.com/u/25789153?v=4","gravatar_id":"","url":"https://api.github.com/users/Dmitriy-kiselyov","html_url":"https://github.com/Dmitriy-kiselyov","followers_url":"https://api.github.com/users/Dmitriy-kiselyov/followers","following_url":"https://api.github.com/users/Dmitriy-kiselyov/following{/other_user}","gists_url":"https://api.github.com/users/Dmitriy-kiselyov/gists{/gist_id}","starred_url":"https://api.github.com/users/Dmitriy-kiselyov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dmitriy-kiselyov/subscriptions","organizations_url":"https://api.github.com/users/Dmitriy-kiselyov/orgs","repos_url":"https://api.github.com/users/Dmitriy-kiselyov/repos","events_url":"https://api.github.com/users/Dmitriy-kiselyov/events{/privacy}","received_events_url":"https://api.github.com/users/Dmitriy-kiselyov/received_events","type":"User","site_admin":false},"body":"Теперь все ок\r\n![image](https://user-images.githubusercontent.com/25789153/36800540-d5cc20ee-1cc0-11e8-8bc4-3a825ce5221f.png)\r\n\r\nЛогика про поле `image` уже была при событии `ERROR`, я дублировал ее на событие `SUCCESS`. При событии `FAIL` скриншоты есть всегда.\r\n\r\nКак раньше html-reporter не работал c `assertView`, так не работает и сейчас.\r\n\r\nТесты скоро добавлю","created_at":"2018-02-28T16:57:32Z","updated_at":"2018-02-28T21:42:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7344852dcc4c6ef1e2353597f8bd185e2c5b3d5a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gemini-testing/html-reporter/pulls/55/commits","review_comments_url":"https://api.github.com/repos/gemini-testing/html-reporter/pulls/55/comments","review_comment_url":"https://api.github.com/repos/gemini-testing/html-reporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gemini-testing/html-reporter/issues/55/comments","statuses_url":"https://api.github.com/repos/gemini-testing/html-reporter/statuses/6fd2aa3f7d7ab1f12f24d0deef606857f6081e58","head":{"label":"gemini-testing:hermione_without_screenshot","ref":"hermione_without_screenshot","sha":"6fd2aa3f7d7ab1f12f24d0deef606857f6081e58","user":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars3.githubusercontent.com/u/11424134?v=4","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"repo":{"id":90853055,"name":"html-reporter","full_name":"gemini-testing/html-reporter","owner":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars3.githubusercontent.com/u/11424134?v=4","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-testing/html-reporter","description":"Html reporter for gemini","fork":false,"url":"https://api.github.com/repos/gemini-testing/html-reporter","forks_url":"https://api.github.com/repos/gemini-testing/html-reporter/forks","keys_url":"https://api.github.com/repos/gemini-testing/html-reporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-testing/html-reporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-testing/html-reporter/teams","hooks_url":"https://api.github.com/repos/gemini-testing/html-reporter/hooks","issue_events_url":"https://api.github.com/repos/gemini-testing/html-reporter/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-testing/html-reporter/events","assignees_url":"https://api.github.com/repos/gemini-testing/html-reporter/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-testing/html-reporter/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-testing/html-reporter/tags","blobs_url":"https://api.github.com/repos/gemini-testing/html-reporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-testing/html-reporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-testing/html-reporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-testing/html-reporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-testing/html-reporter/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-testing/html-reporter/languages","stargazers_url":"https://api.github.com/repos/gemini-testing/html-reporter/stargazers","contributors_url":"https://api.github.com/repos/gemini-testing/html-reporter/contributors","subscribers_url":"https://api.github.com/repos/gemini-testing/html-reporter/subscribers","subscription_url":"https://api.github.com/repos/gemini-testing/html-reporter/subscription","commits_url":"https://api.github.com/repos/gemini-testing/html-reporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-testing/html-reporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-testing/html-reporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-testing/html-reporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemini-testing/html-reporter/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-testing/html-reporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-testing/html-reporter/merges","archive_url":"https://api.github.com/repos/gemini-testing/html-reporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-testing/html-reporter/downloads","issues_url":"https://api.github.com/repos/gemini-testing/html-reporter/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-testing/html-reporter/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-testing/html-reporter/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-testing/html-reporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-testing/html-reporter/labels{/name}","releases_url":"https://api.github.com/repos/gemini-testing/html-reporter/releases{/id}","deployments_url":"https://api.github.com/repos/gemini-testing/html-reporter/deployments","created_at":"2017-05-10T10:41:08Z","updated_at":"2018-02-27T14:08:02Z","pushed_at":"2018-02-28T16:57:33Z","git_url":"git://github.com/gemini-testing/html-reporter.git","ssh_url":"git@github.com:gemini-testing/html-reporter.git","clone_url":"https://github.com/gemini-testing/html-reporter.git","svn_url":"https://github.com/gemini-testing/html-reporter","homepage":null,"size":775,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":6,"watchers":4,"default_branch":"master"}},"base":{"label":"gemini-testing:master","ref":"master","sha":"536b2053b9fadb59752a3e29aa7fb464cc40e414","user":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars3.githubusercontent.com/u/11424134?v=4","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"repo":{"id":90853055,"name":"html-reporter","full_name":"gemini-testing/html-reporter","owner":{"login":"gemini-testing","id":11424134,"avatar_url":"https://avatars3.githubusercontent.com/u/11424134?v=4","gravatar_id":"","url":"https://api.github.com/users/gemini-testing","html_url":"https://github.com/gemini-testing","followers_url":"https://api.github.com/users/gemini-testing/followers","following_url":"https://api.github.com/users/gemini-testing/following{/other_user}","gists_url":"https://api.github.com/users/gemini-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/gemini-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gemini-testing/subscriptions","organizations_url":"https://api.github.com/users/gemini-testing/orgs","repos_url":"https://api.github.com/users/gemini-testing/repos","events_url":"https://api.github.com/users/gemini-testing/events{/privacy}","received_events_url":"https://api.github.com/users/gemini-testing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gemini-testing/html-reporter","description":"Html reporter for gemini","fork":false,"url":"https://api.github.com/repos/gemini-testing/html-reporter","forks_url":"https://api.github.com/repos/gemini-testing/html-reporter/forks","keys_url":"https://api.github.com/repos/gemini-testing/html-reporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gemini-testing/html-reporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gemini-testing/html-reporter/teams","hooks_url":"https://api.github.com/repos/gemini-testing/html-reporter/hooks","issue_events_url":"https://api.github.com/repos/gemini-testing/html-reporter/issues/events{/number}","events_url":"https://api.github.com/repos/gemini-testing/html-reporter/events","assignees_url":"https://api.github.com/repos/gemini-testing/html-reporter/assignees{/user}","branches_url":"https://api.github.com/repos/gemini-testing/html-reporter/branches{/branch}","tags_url":"https://api.github.com/repos/gemini-testing/html-reporter/tags","blobs_url":"https://api.github.com/repos/gemini-testing/html-reporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gemini-testing/html-reporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gemini-testing/html-reporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/gemini-testing/html-reporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gemini-testing/html-reporter/statuses/{sha}","languages_url":"https://api.github.com/repos/gemini-testing/html-reporter/languages","stargazers_url":"https://api.github.com/repos/gemini-testing/html-reporter/stargazers","contributors_url":"https://api.github.com/repos/gemini-testing/html-reporter/contributors","subscribers_url":"https://api.github.com/repos/gemini-testing/html-reporter/subscribers","subscription_url":"https://api.github.com/repos/gemini-testing/html-reporter/subscription","commits_url":"https://api.github.com/repos/gemini-testing/html-reporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/gemini-testing/html-reporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/gemini-testing/html-reporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/gemini-testing/html-reporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/gemini-testing/html-reporter/contents/{+path}","compare_url":"https://api.github.com/repos/gemini-testing/html-reporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gemini-testing/html-reporter/merges","archive_url":"https://api.github.com/repos/gemini-testing/html-reporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gemini-testing/html-reporter/downloads","issues_url":"https://api.github.com/repos/gemini-testing/html-reporter/issues{/number}","pulls_url":"https://api.github.com/repos/gemini-testing/html-reporter/pulls{/number}","milestones_url":"https://api.github.com/repos/gemini-testing/html-reporter/milestones{/number}","notifications_url":"https://api.github.com/repos/gemini-testing/html-reporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gemini-testing/html-reporter/labels{/name}","releases_url":"https://api.github.com/repos/gemini-testing/html-reporter/releases{/id}","deployments_url":"https://api.github.com/repos/gemini-testing/html-reporter/deployments","created_at":"2017-05-10T10:41:08Z","updated_at":"2018-02-27T14:08:02Z","pushed_at":"2018-02-28T16:57:33Z","git_url":"git://github.com/gemini-testing/html-reporter.git","ssh_url":"git@github.com:gemini-testing/html-reporter.git","clone_url":"https://github.com/gemini-testing/html-reporter.git","svn_url":"https://github.com/gemini-testing/html-reporter","homepage":null,"size":775,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":6,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gemini-testing/html-reporter/pulls/55"},"html":{"href":"https://github.com/gemini-testing/html-reporter/pull/55"},"issue":{"href":"https://api.github.com/repos/gemini-testing/html-reporter/issues/55"},"comments":{"href":"https://api.github.com/repos/gemini-testing/html-reporter/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/gemini-testing/html-reporter/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/gemini-testing/html-reporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gemini-testing/html-reporter/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/gemini-testing/html-reporter/statuses/6fd2aa3f7d7ab1f12f24d0deef606857f6081e58"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Dmitriy-kiselyov"}}