{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/171032444","pull_request_review_id":99814399,"id":171032444,"diff_hunk":"@@ -0,0 +1,160 @@\n+﻿// Copyright (c) .NET Foundation. All rights reserved.\n+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.\n+\n+using System;\n+using System.Collections.Generic;\n+using Microsoft.AspNetCore.Http;\n+using Microsoft.AspNetCore.Mvc.Controllers;\n+using Microsoft.AspNetCore.Mvc.Filters;\n+using Microsoft.AspNetCore.Mvc.ModelBinding;\n+using Microsoft.AspNetCore.Routing;\n+using Xunit;\n+\n+namespace Microsoft.AspNetCore.Mvc.ViewFeatures.Internal\n+{\n+    public class ControllerBoundPropertyFilterTest\n+    {\n+        [Fact]\n+        public void OnActionExecuting_PopulatesPropertiesWithAttributes()\n+        {\n+            // Arrange\n+            var tempDataFactory = GetTempDataFactory(new Dictionary<string, object>\n+            {\n+                { \"TempDataProperty\", \"ValueFromRequest\" },\n+            });\n+\n+            var handler = new TestController();\n+            var actionContext = CreateActionContext();\n+            var filter = CreateFilter(tempDataFactory, handler);\n+            var actionExecutingContext = CreateActionExecutingContext(handler, actionContext);\n+\n+            // Act\n+            filter.OnActionExecuting(actionExecutingContext);\n+\n+            // Assert\n+            Assert.Equal(\"ValueFromRequest\", handler.TempDataProperty);\n+            Assert.Null(handler.ViewDataProperty);\n+        }\n+\n+        [Fact]\n+        public void OnResultExecuting_WritesValuesToCollections()\n+        {\n+            // Arrange\n+            var tempDataFactory = GetTempDataFactory(new Dictionary<string, object>\n+            {\n+                { \"TempDataProperty\", \"ValueFromRequest\" },\n+            });\n+            var viewDataFactory = new ControllerViewDataDictionaryFactory(new EmptyModelMetadataProvider());\n+\n+            var handler = new TestController\n+            {\n+                TempDataProperty = \"New-TempDataValue\",\n+                ViewDataProperty = \"New-ViewDataValue\",\n+            };\n+            var actionContext = CreateActionContext();\n+            var filter = CreateFilter(tempDataFactory, handler, viewDataFactory);\n+            var resultExecutingContext = CreateResultExecutingContext(handler, actionContext);\n+\n+            // Act\n+            filter.OnResultExecuting(resultExecutingContext);\n+\n+            // Assert\n+            var tempData = (TempDataDictionary)tempDataFactory.GetTempData(actionContext.HttpContext);\n+            Assert.Equal(\"New-TempDataValue\", tempData[\"TempDataProperty\"]);\n+            var viewData = viewDataFactory.GetViewDataDictionary(actionContext);\n+            Assert.Equal(\"New-ViewDataValue\", viewData[\"ViewDataProperty\"]);\n+\n+            // Ensure the key is retained\n+            Assert.Equal(new[] { \"TempDataProperty\" }, tempData.RetainedKeys);\n+        }\n+\n+        [Fact]\n+        public void OnResultExecuting_SkipsWritingToDictionary_IfValueIsUnchaned()\n+        {\n+            // Arrange\n+            var tempDataFactory = GetTempDataFactory(new Dictionary<string, object>\n+            {\n+                { \"TempDataProperty\", \"ValueFromRequest\" },\n+            });\n+            var viewDataFactory = new ControllerViewDataDictionaryFactory(new EmptyModelMetadataProvider());\n+\n+            var handler = new TestController\n+            {\n+                TempDataProperty = \"ValueFromRequest\",\n+                ViewDataProperty = null,\n+            };\n+            var actionContext = CreateActionContext();\n+            var filter = CreateFilter(tempDataFactory, handler, viewDataFactory);\n+            var resultExecutingContext = CreateResultExecutingContext(handler, actionContext);\n+\n+            // Act\n+            filter.OnResultExecuting(resultExecutingContext);\n+\n+            // Assert\n+            var tempData = (TempDataDictionary)tempDataFactory.GetTempData(actionContext.HttpContext);","path":"test/Microsoft.AspNetCore.Mvc.ViewFeatures.Test/Internal/ControllerBoundPropertyFilterTest.cs","position":62,"original_position":94,"commit_id":"5dec822e1a21d1ea403b9dcc0ae898ca5801aaad","original_commit_id":"5dec822e1a21d1ea403b9dcc0ae898ca5801aaad","user":{"login":"jbagga","id":6234561,"avatar_url":"https://avatars0.githubusercontent.com/u/6234561?v=4","gravatar_id":"","url":"https://api.github.com/users/jbagga","html_url":"https://github.com/jbagga","followers_url":"https://api.github.com/users/jbagga/followers","following_url":"https://api.github.com/users/jbagga/following{/other_user}","gists_url":"https://api.github.com/users/jbagga/gists{/gist_id}","starred_url":"https://api.github.com/users/jbagga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbagga/subscriptions","organizations_url":"https://api.github.com/users/jbagga/orgs","repos_url":"https://api.github.com/users/jbagga/repos","events_url":"https://api.github.com/users/jbagga/events{/privacy}","received_events_url":"https://api.github.com/users/jbagga/received_events","type":"User","site_admin":false},"body":"Why do we have an explicit cast to `TempDataDictionary` here?","created_at":"2018-02-27T19:06:54Z","updated_at":"2018-02-27T19:06:54Z","html_url":"https://github.com/aspnet/Mvc/pull/7385#discussion_r171032444","pull_request_url":"https://api.github.com/repos/aspnet/Mvc/pulls/7385","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments/171032444"},"html":{"href":"https://github.com/aspnet/Mvc/pull/7385#discussion_r171032444"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/7385"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Mvc/pulls/7385","id":169532886,"html_url":"https://github.com/aspnet/Mvc/pull/7385","diff_url":"https://github.com/aspnet/Mvc/pull/7385.diff","patch_url":"https://github.com/aspnet/Mvc/pull/7385.patch","issue_url":"https://api.github.com/repos/aspnet/Mvc/issues/7385","number":7385,"state":"open","locked":false,"title":"Add ViewDataAttribute","user":{"login":"pranavkm","id":174281,"avatar_url":"https://avatars2.githubusercontent.com/u/174281?v=4","gravatar_id":"","url":"https://api.github.com/users/pranavkm","html_url":"https://github.com/pranavkm","followers_url":"https://api.github.com/users/pranavkm/followers","following_url":"https://api.github.com/users/pranavkm/following{/other_user}","gists_url":"https://api.github.com/users/pranavkm/gists{/gist_id}","starred_url":"https://api.github.com/users/pranavkm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pranavkm/subscriptions","organizations_url":"https://api.github.com/users/pranavkm/orgs","repos_url":"https://api.github.com/users/pranavkm/repos","events_url":"https://api.github.com/users/pranavkm/events{/privacy}","received_events_url":"https://api.github.com/users/pranavkm/received_events","type":"User","site_admin":false},"body":"* Support ViewDataAttribute on controllers and Razor Page models\r\n* Share infrastructure between ViewDataAttribute and TempDataAttribute","created_at":"2018-02-16T01:53:12Z","updated_at":"2018-02-27T19:06:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5423a7d41c40db9d833185eee2f29a6a3edb592","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Mvc/pulls/7385/commits","review_comments_url":"https://api.github.com/repos/aspnet/Mvc/pulls/7385/comments","review_comment_url":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/Mvc/issues/7385/comments","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/5dec822e1a21d1ea403b9dcc0ae898ca5801aaad","head":{"label":"aspnet:prkrishn/viewdataattribute","ref":"prkrishn/viewdataattribute","sha":"5dec822e1a21d1ea403b9dcc0ae898ca5801aaad","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"ASP.NET Core MVC is a model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Mvc/deployments","created_at":"2013-12-12T03:54:00Z","updated_at":"2018-02-27T05:17:29Z","pushed_at":"2018-02-27T17:28:07Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":68892,"stargazers_count":5068,"watchers_count":5068,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1993,"mirror_url":null,"archived":false,"open_issues_count":327,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1993,"open_issues":327,"watchers":5068,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"bdcf2a9bed83c12f85a1cac063be3490d2e2e22a","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15126429,"name":"Mvc","full_name":"aspnet/Mvc","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Mvc","description":"ASP.NET Core MVC is a model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor.","fork":false,"url":"https://api.github.com/repos/aspnet/Mvc","forks_url":"https://api.github.com/repos/aspnet/Mvc/forks","keys_url":"https://api.github.com/repos/aspnet/Mvc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Mvc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Mvc/teams","hooks_url":"https://api.github.com/repos/aspnet/Mvc/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Mvc/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Mvc/events","assignees_url":"https://api.github.com/repos/aspnet/Mvc/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Mvc/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Mvc/tags","blobs_url":"https://api.github.com/repos/aspnet/Mvc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Mvc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Mvc/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Mvc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Mvc/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Mvc/languages","stargazers_url":"https://api.github.com/repos/aspnet/Mvc/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Mvc/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Mvc/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Mvc/subscription","commits_url":"https://api.github.com/repos/aspnet/Mvc/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Mvc/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Mvc/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Mvc/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/Mvc/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Mvc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Mvc/merges","archive_url":"https://api.github.com/repos/aspnet/Mvc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Mvc/downloads","issues_url":"https://api.github.com/repos/aspnet/Mvc/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Mvc/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Mvc/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Mvc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Mvc/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Mvc/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/Mvc/deployments","created_at":"2013-12-12T03:54:00Z","updated_at":"2018-02-27T05:17:29Z","pushed_at":"2018-02-27T17:28:07Z","git_url":"git://github.com/aspnet/Mvc.git","ssh_url":"git@github.com:aspnet/Mvc.git","clone_url":"https://github.com/aspnet/Mvc.git","svn_url":"https://github.com/aspnet/Mvc","homepage":"","size":68892,"stargazers_count":5068,"watchers_count":5068,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1993,"mirror_url":null,"archived":false,"open_issues_count":327,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1993,"open_issues":327,"watchers":5068,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/7385"},"html":{"href":"https://github.com/aspnet/Mvc/pull/7385"},"issue":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/7385"},"comments":{"href":"https://api.github.com/repos/aspnet/Mvc/issues/7385/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/7385/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Mvc/pulls/7385/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Mvc/statuses/5dec822e1a21d1ea403b9dcc0ae898ca5801aaad"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jbagga"}}