{"action":"created","issue":{"url":"https://api.github.com/repos/bazelbuild/rules_docker/issues/633","repository_url":"https://api.github.com/repos/bazelbuild/rules_docker","labels_url":"https://api.github.com/repos/bazelbuild/rules_docker/issues/633/labels{/name}","comments_url":"https://api.github.com/repos/bazelbuild/rules_docker/issues/633/comments","events_url":"https://api.github.com/repos/bazelbuild/rules_docker/issues/633/events","html_url":"https://github.com/bazelbuild/rules_docker/issues/633","id":393451505,"node_id":"MDU6SXNzdWUzOTM0NTE1MDU=","number":633,"title":"Allow storing file timestamps","user":{"login":"wjywbs","id":6233680,"node_id":"MDQ6VXNlcjYyMzM2ODA=","avatar_url":"https://avatars0.githubusercontent.com/u/6233680?v=4","gravatar_id":"","url":"https://api.github.com/users/wjywbs","html_url":"https://github.com/wjywbs","followers_url":"https://api.github.com/users/wjywbs/followers","following_url":"https://api.github.com/users/wjywbs/following{/other_user}","gists_url":"https://api.github.com/users/wjywbs/gists{/gist_id}","starred_url":"https://api.github.com/users/wjywbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wjywbs/subscriptions","organizations_url":"https://api.github.com/users/wjywbs/orgs","repos_url":"https://api.github.com/users/wjywbs/repos","events_url":"https://api.github.com/users/wjywbs/events{/privacy}","received_events_url":"https://api.github.com/users/wjywbs/received_events","type":"User","site_admin":false},"labels":[{"id":573163634,"node_id":"MDU6TGFiZWw1NzMxNjM2MzQ=","url":"https://api.github.com/repos/bazelbuild/rules_docker/labels/feature%20request","name":"feature request","color":"84b6eb","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-21T13:02:29Z","updated_at":"2018-12-21T17:14:47Z","closed_at":null,"author_association":"NONE","body":"I'm not sure if this was requested before, but all files copied in the image in the container_image rule have unix time 0. While this does not affect binary files and makes the image reproducible, some static assets like html, js and image files are expected to have timestamps. Then web servers serving static files in the container can set Last-Modified header, and browsers can cache the files and issue If-Modified-Since requests.\r\n\r\nAn option to keep the file timestamps will be helpful.\r\n\r\nGo's http server does not set Last-Modified header if the modified time is 0:\r\nhttps://github.com/golang/go/blob/master/src/net/http/fs.go#L484"},"comment":{"url":"https://api.github.com/repos/bazelbuild/rules_docker/issues/comments/449445540","html_url":"https://github.com/bazelbuild/rules_docker/issues/633#issuecomment-449445540","issue_url":"https://api.github.com/repos/bazelbuild/rules_docker/issues/633","id":449445540,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTQ0NTU0MA==","user":{"login":"nlopezgi","id":4062751,"node_id":"MDQ6VXNlcjQwNjI3NTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4062751?v=4","gravatar_id":"","url":"https://api.github.com/users/nlopezgi","html_url":"https://github.com/nlopezgi","followers_url":"https://api.github.com/users/nlopezgi/followers","following_url":"https://api.github.com/users/nlopezgi/following{/other_user}","gists_url":"https://api.github.com/users/nlopezgi/gists{/gist_id}","starred_url":"https://api.github.com/users/nlopezgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlopezgi/subscriptions","organizations_url":"https://api.github.com/users/nlopezgi/orgs","repos_url":"https://api.github.com/users/nlopezgi/repos","events_url":"https://api.github.com/users/nlopezgi/events{/privacy}","received_events_url":"https://api.github.com/users/nlopezgi/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T17:14:47Z","updated_at":"2018-12-21T17:14:47Z","author_association":"MEMBER","body":"thanks for the clarifications @wjywbs \r\nWe dont currently support setting timestamps for the individual files. How would you see such a feature working (i.e., would it set the BUILD_TIMESTAMP on all the files, or something else?). I have not had anyone else ask for this feature before. I'd be happy to work with you so you can design it in detail and implement it."}}
{"actor":{"display_login":"nlopezgi"}}