{"action":"created","comment":{"url":"https://api.github.com/repos/apache/struts/pulls/comments/176652837","pull_request_review_id":106394513,"id":176652837,"diff_hunk":"@@ -185,6 +187,10 @@ public void setContextMap(Map<String, Object> contextMap) {\n      * @return the context map.\n      */\n     public Map<String, Object> getContextMap() {\n+        Map<String, Object> context = getContext().context;\n+        if (context instanceof OgnlContext) {\n+            ((OgnlContext) context).put(TypeConverter.TYPE_CONVERTER_CONTEXT_KEY, ((OgnlContext) context).getTypeConverter());","path":"core/src/main/java/com/opensymphony/xwork2/ActionContext.java","position":17,"original_position":17,"commit_id":"5f2ed584517cda8d7fe45b0003b595ebc54c9576","original_commit_id":"5f2ed584517cda8d7fe45b0003b595ebc54c9576","user":{"login":"lukaszlenart","id":170103,"avatar_url":"https://avatars0.githubusercontent.com/u/170103?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaszlenart","html_url":"https://github.com/lukaszlenart","followers_url":"https://api.github.com/users/lukaszlenart/followers","following_url":"https://api.github.com/users/lukaszlenart/following{/other_user}","gists_url":"https://api.github.com/users/lukaszlenart/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszlenart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszlenart/subscriptions","organizations_url":"https://api.github.com/users/lukaszlenart/orgs","repos_url":"https://api.github.com/users/lukaszlenart/repos","events_url":"https://api.github.com/users/lukaszlenart/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszlenart/received_events","type":"User","site_admin":false},"body":"Whooops... it can be thrown away, goot catch 👍 ","created_at":"2018-03-23T07:10:09Z","updated_at":"2018-03-23T07:10:09Z","html_url":"https://github.com/apache/struts/pull/125#discussion_r176652837","pull_request_url":"https://api.github.com/repos/apache/struts/pulls/125","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/struts/pulls/comments/176652837"},"html":{"href":"https://github.com/apache/struts/pull/125#discussion_r176652837"},"pull_request":{"href":"https://api.github.com/repos/apache/struts/pulls/125"}},"in_reply_to_id":176223137},"pull_request":{"url":"https://api.github.com/repos/apache/struts/pulls/125","id":112422454,"html_url":"https://github.com/apache/struts/pull/125","diff_url":"https://github.com/apache/struts/pull/125.diff","patch_url":"https://github.com/apache/struts/pull/125.patch","issue_url":"https://api.github.com/repos/apache/struts/issues/125","number":125,"state":"open","locked":false,"title":"Immutable context","user":{"login":"lukaszlenart","id":170103,"avatar_url":"https://avatars0.githubusercontent.com/u/170103?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaszlenart","html_url":"https://github.com/lukaszlenart","followers_url":"https://api.github.com/users/lukaszlenart/followers","following_url":"https://api.github.com/users/lukaszlenart/following{/other_user}","gists_url":"https://api.github.com/users/lukaszlenart/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszlenart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszlenart/subscriptions","organizations_url":"https://api.github.com/users/lukaszlenart/orgs","repos_url":"https://api.github.com/users/lukaszlenart/repos","events_url":"https://api.github.com/users/lukaszlenart/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszlenart/received_events","type":"User","site_admin":false},"body":"This PR uses the latest OGNL version which drops access to `#context` via a magical key and makes `OgnlContext` a bit immutable.\r\n\r\n[OGNL 3.2 version notes](https://github.com/jkuhnert/ognl#release-notes---version-32)\r\n\r\nImplements [WW-4927](https://issues.apache.org/jira/browse/WW-4927)","created_at":"2017-03-24T10:04:07Z","updated_at":"2018-03-23T07:10:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f71622fc19433b3af1b1d6617fbd353a36dfff04","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/struts/pulls/125/commits","review_comments_url":"https://api.github.com/repos/apache/struts/pulls/125/comments","review_comment_url":"https://api.github.com/repos/apache/struts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/struts/issues/125/comments","statuses_url":"https://api.github.com/repos/apache/struts/statuses/5f2ed584517cda8d7fe45b0003b595ebc54c9576","head":{"label":"lukaszlenart:immutable-context","ref":"immutable-context","sha":"5f2ed584517cda8d7fe45b0003b595ebc54c9576","user":{"login":"lukaszlenart","id":170103,"avatar_url":"https://avatars0.githubusercontent.com/u/170103?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaszlenart","html_url":"https://github.com/lukaszlenart","followers_url":"https://api.github.com/users/lukaszlenart/followers","following_url":"https://api.github.com/users/lukaszlenart/following{/other_user}","gists_url":"https://api.github.com/users/lukaszlenart/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszlenart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszlenart/subscriptions","organizations_url":"https://api.github.com/users/lukaszlenart/orgs","repos_url":"https://api.github.com/users/lukaszlenart/repos","events_url":"https://api.github.com/users/lukaszlenart/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszlenart/received_events","type":"User","site_admin":false},"repo":{"id":24301251,"name":"struts","full_name":"lukaszlenart/struts","owner":{"login":"lukaszlenart","id":170103,"avatar_url":"https://avatars0.githubusercontent.com/u/170103?v=4","gravatar_id":"","url":"https://api.github.com/users/lukaszlenart","html_url":"https://github.com/lukaszlenart","followers_url":"https://api.github.com/users/lukaszlenart/followers","following_url":"https://api.github.com/users/lukaszlenart/following{/other_user}","gists_url":"https://api.github.com/users/lukaszlenart/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszlenart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszlenart/subscriptions","organizations_url":"https://api.github.com/users/lukaszlenart/orgs","repos_url":"https://api.github.com/users/lukaszlenart/repos","events_url":"https://api.github.com/users/lukaszlenart/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszlenart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukaszlenart/struts","description":"Mirror of Apache Struts","fork":true,"url":"https://api.github.com/repos/lukaszlenart/struts","forks_url":"https://api.github.com/repos/lukaszlenart/struts/forks","keys_url":"https://api.github.com/repos/lukaszlenart/struts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukaszlenart/struts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukaszlenart/struts/teams","hooks_url":"https://api.github.com/repos/lukaszlenart/struts/hooks","issue_events_url":"https://api.github.com/repos/lukaszlenart/struts/issues/events{/number}","events_url":"https://api.github.com/repos/lukaszlenart/struts/events","assignees_url":"https://api.github.com/repos/lukaszlenart/struts/assignees{/user}","branches_url":"https://api.github.com/repos/lukaszlenart/struts/branches{/branch}","tags_url":"https://api.github.com/repos/lukaszlenart/struts/tags","blobs_url":"https://api.github.com/repos/lukaszlenart/struts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukaszlenart/struts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukaszlenart/struts/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukaszlenart/struts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukaszlenart/struts/statuses/{sha}","languages_url":"https://api.github.com/repos/lukaszlenart/struts/languages","stargazers_url":"https://api.github.com/repos/lukaszlenart/struts/stargazers","contributors_url":"https://api.github.com/repos/lukaszlenart/struts/contributors","subscribers_url":"https://api.github.com/repos/lukaszlenart/struts/subscribers","subscription_url":"https://api.github.com/repos/lukaszlenart/struts/subscription","commits_url":"https://api.github.com/repos/lukaszlenart/struts/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukaszlenart/struts/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukaszlenart/struts/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukaszlenart/struts/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukaszlenart/struts/contents/{+path}","compare_url":"https://api.github.com/repos/lukaszlenart/struts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukaszlenart/struts/merges","archive_url":"https://api.github.com/repos/lukaszlenart/struts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukaszlenart/struts/downloads","issues_url":"https://api.github.com/repos/lukaszlenart/struts/issues{/number}","pulls_url":"https://api.github.com/repos/lukaszlenart/struts/pulls{/number}","milestones_url":"https://api.github.com/repos/lukaszlenart/struts/milestones{/number}","notifications_url":"https://api.github.com/repos/lukaszlenart/struts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukaszlenart/struts/labels{/name}","releases_url":"https://api.github.com/repos/lukaszlenart/struts/releases{/id}","deployments_url":"https://api.github.com/repos/lukaszlenart/struts/deployments","created_at":"2014-09-21T19:31:45Z","updated_at":"2018-01-30T08:27:47Z","pushed_at":"2018-03-21T08:08:45Z","git_url":"git://github.com/lukaszlenart/struts.git","ssh_url":"git@github.com:lukaszlenart/struts.git","clone_url":"https://github.com/lukaszlenart/struts.git","svn_url":"https://github.com/lukaszlenart/struts","homepage":null,"size":73171,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"845ab413cd077d06de8dcc33c68a1e236067b346","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":15928650,"name":"struts","full_name":"apache/struts","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/struts","description":"Mirror of Apache Struts","fork":false,"url":"https://api.github.com/repos/apache/struts","forks_url":"https://api.github.com/repos/apache/struts/forks","keys_url":"https://api.github.com/repos/apache/struts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/struts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/struts/teams","hooks_url":"https://api.github.com/repos/apache/struts/hooks","issue_events_url":"https://api.github.com/repos/apache/struts/issues/events{/number}","events_url":"https://api.github.com/repos/apache/struts/events","assignees_url":"https://api.github.com/repos/apache/struts/assignees{/user}","branches_url":"https://api.github.com/repos/apache/struts/branches{/branch}","tags_url":"https://api.github.com/repos/apache/struts/tags","blobs_url":"https://api.github.com/repos/apache/struts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/struts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/struts/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/struts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/struts/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/struts/languages","stargazers_url":"https://api.github.com/repos/apache/struts/stargazers","contributors_url":"https://api.github.com/repos/apache/struts/contributors","subscribers_url":"https://api.github.com/repos/apache/struts/subscribers","subscription_url":"https://api.github.com/repos/apache/struts/subscription","commits_url":"https://api.github.com/repos/apache/struts/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/struts/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/struts/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/struts/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/struts/contents/{+path}","compare_url":"https://api.github.com/repos/apache/struts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/struts/merges","archive_url":"https://api.github.com/repos/apache/struts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/struts/downloads","issues_url":"https://api.github.com/repos/apache/struts/issues{/number}","pulls_url":"https://api.github.com/repos/apache/struts/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/struts/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/struts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/struts/labels{/name}","releases_url":"https://api.github.com/repos/apache/struts/releases{/id}","deployments_url":"https://api.github.com/repos/apache/struts/deployments","created_at":"2014-01-15T08:00:08Z","updated_at":"2018-03-23T06:44:08Z","pushed_at":"2018-03-23T06:44:05Z","git_url":"git://github.com/apache/struts.git","ssh_url":"git@github.com:apache/struts.git","clone_url":"https://github.com/apache/struts.git","svn_url":"https://github.com/apache/struts","homepage":null,"size":74366,"stargazers_count":806,"watchers_count":806,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":578,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":578,"open_issues":5,"watchers":806,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/struts/pulls/125"},"html":{"href":"https://github.com/apache/struts/pull/125"},"issue":{"href":"https://api.github.com/repos/apache/struts/issues/125"},"comments":{"href":"https://api.github.com/repos/apache/struts/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/struts/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/struts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/struts/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/apache/struts/statuses/5f2ed584517cda8d7fe45b0003b595ebc54c9576"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lukaszlenart"}}