{"action":"created","comment":{"url":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/comments/205941819","pull_request_review_id":141315458,"id":205941819,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTk0MTgxOQ==","diff_hunk":"@@ -0,0 +1,282 @@\n+package org.wso2.carbon.apimgt.rest.api.publisher.impl;","path":"components/apimgt/org.wso2.carbon.apimgt.rest.api.publisher/src/main/java/org/wso2/carbon/apimgt/rest/api/publisher/impl/CertificatesApiServiceImpl.java","position":1,"original_position":1,"commit_id":"3abb307475721933b0140898f604a51785913f06","original_commit_id":"3abb307475721933b0140898f604a51785913f06","user":{"login":"Megala21","id":4003116,"node_id":"MDQ6VXNlcjQwMDMxMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4003116?v=4","gravatar_id":"","url":"https://api.github.com/users/Megala21","html_url":"https://github.com/Megala21","followers_url":"https://api.github.com/users/Megala21/followers","following_url":"https://api.github.com/users/Megala21/following{/other_user}","gists_url":"https://api.github.com/users/Megala21/gists{/gist_id}","starred_url":"https://api.github.com/users/Megala21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Megala21/subscriptions","organizations_url":"https://api.github.com/users/Megala21/orgs","repos_url":"https://api.github.com/users/Megala21/repos","events_url":"https://api.github.com/users/Megala21/events{/privacy}","received_events_url":"https://api.github.com/users/Megala21/received_events","type":"User","site_admin":false},"body":"Missing license header","created_at":"2018-07-28T12:12:25Z","updated_at":"2018-07-28T12:15:42Z","html_url":"https://github.com/wso2/carbon-apimgt/pull/5564#discussion_r205941819","pull_request_url":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/5564","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/comments/205941819"},"html":{"href":"https://github.com/wso2/carbon-apimgt/pull/5564#discussion_r205941819"},"pull_request":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/5564"}}},"pull_request":{"url":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/5564","id":204080448,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MDgwNDQ4","html_url":"https://github.com/wso2/carbon-apimgt/pull/5564","diff_url":"https://github.com/wso2/carbon-apimgt/pull/5564.diff","patch_url":"https://github.com/wso2/carbon-apimgt/pull/5564.patch","issue_url":"https://api.github.com/repos/wso2/carbon-apimgt/issues/5564","number":5564,"state":"open","locked":false,"title":"REST API support for Dynamic Certificate Management.","user":{"login":"menakaj","id":10165411,"node_id":"MDQ6VXNlcjEwMTY1NDEx","avatar_url":"https://avatars1.githubusercontent.com/u/10165411?v=4","gravatar_id":"","url":"https://api.github.com/users/menakaj","html_url":"https://github.com/menakaj","followers_url":"https://api.github.com/users/menakaj/followers","following_url":"https://api.github.com/users/menakaj/following{/other_user}","gists_url":"https://api.github.com/users/menakaj/gists{/gist_id}","starred_url":"https://api.github.com/users/menakaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menakaj/subscriptions","organizations_url":"https://api.github.com/users/menakaj/orgs","repos_url":"https://api.github.com/users/menakaj/repos","events_url":"https://api.github.com/users/menakaj/events{/privacy}","received_events_url":"https://api.github.com/users/menakaj/received_events","type":"User","site_admin":false},"body":"### Proposed changes in this pull request\r\nAdd the Certificate Management Rest API.\r\nFixes wso2/product-apim/issues/3504\r\n\r\n### When should this PR be merged\r\n\r\n[Please describe any preconditions that need to be addressed before we\r\ncan merge this pull request.]\r\n\r\n\r\n### Follow up actions\r\n\r\n[List any possible follow-up actions here; for instance, testing data\r\nmigrations, software that we need to install on staging and production\r\nenvironments.]\r\n\r\n-\r\n\r\n\r\n### Checklist (for reviewing)\r\n\r\n#### General\r\n\r\n- [ ] **Is this PR explained thoroughly?** All code changes must be accounted for in the PR description.\r\n- [ ] **Is the PR labeled correctly?**\r\n\r\n#### Functionality\r\n\r\n- [ ] **Are all requirements met?** Compare implemented functionality with the requirements specification.\r\n- [ ] **Does the UI work as expected?** There should be no Javascript errors in the console; all resources should load. There should be no unexpected errors. Deliberately try to break the feature to find out if there are corner cases that are not handled.\r\n\r\n#### Code\r\n\r\n- [ ] **Do you fully understand the introduced changes to the code?** If not ask for clarification, it might uncover ways to solve a problem in a more elegant and efficient way.\r\n- [ ] **Does the PR introduce any inefficient database requests?** Use the debug server to check for duplicate requests.\r\n- [ ] **Are all necessary strings marked for translation?** All strings that are exposed to users via the UI must be [marked for translation](https://docs.djangoproject.com/en/1.10/topics/i18n/translation/).\r\n\r\n#### Tests\r\n\r\n- [ ] **Are there sufficient test cases?** Ensure that all components are tested individually; models, forms, and serializers should be tested in isolation even if a test for a view covers these components.\r\n- [ ] **If this is a bug fix, are tests for the issue in place?**  There must be a test case for the bug to ensure the issue won’t regress. Make sure that the tests break without the new code to fix the issue.\r\n- [ ] **If this is a new feature or a significant change to an existing feature?** has the manual testing spreadsheet been updated with instructions for manual testing?\r\n\r\n#### Security\r\n\r\n- [ ] **Confirm this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.**\r\n- [ ] **Are all UI and API inputs run through forms or serializers?**\r\n- [ ] **Are all external inputs validated and sanitized appropriately?**\r\n- [ ] **Does all branching logic have a default case?**\r\n- [ ] **Does this solution handle outliers and edge cases gracefully?**\r\n- [ ] **Are all external communications secured and restricted to SSL?**\r\n\r\n#### Documentation\r\n\r\n- [ ] **Are changes to the UI documented in the platform docs?** If this PR introduces new platform site functionality or changes existing ones, the changes should be documented.\r\n- [ ] **Are changes to the API documented in the API docs?** If this PR introduces new API functionality or changes existing ones, the changes must be documented.\r\n- [ ] **Are reusable components documented?** If this PR introduces components that are relevant to other developers (for instance a mixin for a view or a generic form) they should be documented in the Wiki.\r\n","created_at":"2018-07-26T09:27:21Z","updated_at":"2018-07-28T12:15:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"253b4dc7ce34a1f1f40c9e9ec023e7a1449f3782","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/5564/commits","review_comments_url":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/5564/comments","review_comment_url":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wso2/carbon-apimgt/issues/5564/comments","statuses_url":"https://api.github.com/repos/wso2/carbon-apimgt/statuses/3abb307475721933b0140898f604a51785913f06","head":{"label":"menakaj:6.x","ref":"6.x","sha":"3abb307475721933b0140898f604a51785913f06","user":{"login":"menakaj","id":10165411,"node_id":"MDQ6VXNlcjEwMTY1NDEx","avatar_url":"https://avatars1.githubusercontent.com/u/10165411?v=4","gravatar_id":"","url":"https://api.github.com/users/menakaj","html_url":"https://github.com/menakaj","followers_url":"https://api.github.com/users/menakaj/followers","following_url":"https://api.github.com/users/menakaj/following{/other_user}","gists_url":"https://api.github.com/users/menakaj/gists{/gist_id}","starred_url":"https://api.github.com/users/menakaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menakaj/subscriptions","organizations_url":"https://api.github.com/users/menakaj/orgs","repos_url":"https://api.github.com/users/menakaj/repos","events_url":"https://api.github.com/users/menakaj/events{/privacy}","received_events_url":"https://api.github.com/users/menakaj/received_events","type":"User","site_admin":false},"repo":{"id":108243210,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgyNDMyMTA=","name":"carbon-apimgt","full_name":"menakaj/carbon-apimgt","owner":{"login":"menakaj","id":10165411,"node_id":"MDQ6VXNlcjEwMTY1NDEx","avatar_url":"https://avatars1.githubusercontent.com/u/10165411?v=4","gravatar_id":"","url":"https://api.github.com/users/menakaj","html_url":"https://github.com/menakaj","followers_url":"https://api.github.com/users/menakaj/followers","following_url":"https://api.github.com/users/menakaj/following{/other_user}","gists_url":"https://api.github.com/users/menakaj/gists{/gist_id}","starred_url":"https://api.github.com/users/menakaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/menakaj/subscriptions","organizations_url":"https://api.github.com/users/menakaj/orgs","repos_url":"https://api.github.com/users/menakaj/repos","events_url":"https://api.github.com/users/menakaj/events{/privacy}","received_events_url":"https://api.github.com/users/menakaj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/menakaj/carbon-apimgt","description":null,"fork":true,"url":"https://api.github.com/repos/menakaj/carbon-apimgt","forks_url":"https://api.github.com/repos/menakaj/carbon-apimgt/forks","keys_url":"https://api.github.com/repos/menakaj/carbon-apimgt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/menakaj/carbon-apimgt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/menakaj/carbon-apimgt/teams","hooks_url":"https://api.github.com/repos/menakaj/carbon-apimgt/hooks","issue_events_url":"https://api.github.com/repos/menakaj/carbon-apimgt/issues/events{/number}","events_url":"https://api.github.com/repos/menakaj/carbon-apimgt/events","assignees_url":"https://api.github.com/repos/menakaj/carbon-apimgt/assignees{/user}","branches_url":"https://api.github.com/repos/menakaj/carbon-apimgt/branches{/branch}","tags_url":"https://api.github.com/repos/menakaj/carbon-apimgt/tags","blobs_url":"https://api.github.com/repos/menakaj/carbon-apimgt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/menakaj/carbon-apimgt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/menakaj/carbon-apimgt/git/refs{/sha}","trees_url":"https://api.github.com/repos/menakaj/carbon-apimgt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/menakaj/carbon-apimgt/statuses/{sha}","languages_url":"https://api.github.com/repos/menakaj/carbon-apimgt/languages","stargazers_url":"https://api.github.com/repos/menakaj/carbon-apimgt/stargazers","contributors_url":"https://api.github.com/repos/menakaj/carbon-apimgt/contributors","subscribers_url":"https://api.github.com/repos/menakaj/carbon-apimgt/subscribers","subscription_url":"https://api.github.com/repos/menakaj/carbon-apimgt/subscription","commits_url":"https://api.github.com/repos/menakaj/carbon-apimgt/commits{/sha}","git_commits_url":"https://api.github.com/repos/menakaj/carbon-apimgt/git/commits{/sha}","comments_url":"https://api.github.com/repos/menakaj/carbon-apimgt/comments{/number}","issue_comment_url":"https://api.github.com/repos/menakaj/carbon-apimgt/issues/comments{/number}","contents_url":"https://api.github.com/repos/menakaj/carbon-apimgt/contents/{+path}","compare_url":"https://api.github.com/repos/menakaj/carbon-apimgt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/menakaj/carbon-apimgt/merges","archive_url":"https://api.github.com/repos/menakaj/carbon-apimgt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/menakaj/carbon-apimgt/downloads","issues_url":"https://api.github.com/repos/menakaj/carbon-apimgt/issues{/number}","pulls_url":"https://api.github.com/repos/menakaj/carbon-apimgt/pulls{/number}","milestones_url":"https://api.github.com/repos/menakaj/carbon-apimgt/milestones{/number}","notifications_url":"https://api.github.com/repos/menakaj/carbon-apimgt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/menakaj/carbon-apimgt/labels{/name}","releases_url":"https://api.github.com/repos/menakaj/carbon-apimgt/releases{/id}","deployments_url":"https://api.github.com/repos/menakaj/carbon-apimgt/deployments","created_at":"2017-10-25T08:42:39Z","updated_at":"2017-10-25T08:42:47Z","pushed_at":"2018-07-26T13:14:07Z","git_url":"git://github.com/menakaj/carbon-apimgt.git","ssh_url":"git@github.com:menakaj/carbon-apimgt.git","clone_url":"https://github.com/menakaj/carbon-apimgt.git","svn_url":"https://github.com/menakaj/carbon-apimgt","homepage":null,"size":262914,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wso2:6.x","ref":"6.x","sha":"ec47884749080b357e25c1c15c075ac46351dc57","user":{"login":"wso2","id":533043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzA0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"repo":{"id":17201744,"node_id":"MDEwOlJlcG9zaXRvcnkxNzIwMTc0NA==","name":"carbon-apimgt","full_name":"wso2/carbon-apimgt","owner":{"login":"wso2","id":533043,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzMzA0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/533043?v=4","gravatar_id":"","url":"https://api.github.com/users/wso2","html_url":"https://github.com/wso2","followers_url":"https://api.github.com/users/wso2/followers","following_url":"https://api.github.com/users/wso2/following{/other_user}","gists_url":"https://api.github.com/users/wso2/gists{/gist_id}","starred_url":"https://api.github.com/users/wso2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wso2/subscriptions","organizations_url":"https://api.github.com/users/wso2/orgs","repos_url":"https://api.github.com/users/wso2/repos","events_url":"https://api.github.com/users/wso2/events{/privacy}","received_events_url":"https://api.github.com/users/wso2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wso2/carbon-apimgt","description":null,"fork":false,"url":"https://api.github.com/repos/wso2/carbon-apimgt","forks_url":"https://api.github.com/repos/wso2/carbon-apimgt/forks","keys_url":"https://api.github.com/repos/wso2/carbon-apimgt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wso2/carbon-apimgt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wso2/carbon-apimgt/teams","hooks_url":"https://api.github.com/repos/wso2/carbon-apimgt/hooks","issue_events_url":"https://api.github.com/repos/wso2/carbon-apimgt/issues/events{/number}","events_url":"https://api.github.com/repos/wso2/carbon-apimgt/events","assignees_url":"https://api.github.com/repos/wso2/carbon-apimgt/assignees{/user}","branches_url":"https://api.github.com/repos/wso2/carbon-apimgt/branches{/branch}","tags_url":"https://api.github.com/repos/wso2/carbon-apimgt/tags","blobs_url":"https://api.github.com/repos/wso2/carbon-apimgt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wso2/carbon-apimgt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wso2/carbon-apimgt/git/refs{/sha}","trees_url":"https://api.github.com/repos/wso2/carbon-apimgt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wso2/carbon-apimgt/statuses/{sha}","languages_url":"https://api.github.com/repos/wso2/carbon-apimgt/languages","stargazers_url":"https://api.github.com/repos/wso2/carbon-apimgt/stargazers","contributors_url":"https://api.github.com/repos/wso2/carbon-apimgt/contributors","subscribers_url":"https://api.github.com/repos/wso2/carbon-apimgt/subscribers","subscription_url":"https://api.github.com/repos/wso2/carbon-apimgt/subscription","commits_url":"https://api.github.com/repos/wso2/carbon-apimgt/commits{/sha}","git_commits_url":"https://api.github.com/repos/wso2/carbon-apimgt/git/commits{/sha}","comments_url":"https://api.github.com/repos/wso2/carbon-apimgt/comments{/number}","issue_comment_url":"https://api.github.com/repos/wso2/carbon-apimgt/issues/comments{/number}","contents_url":"https://api.github.com/repos/wso2/carbon-apimgt/contents/{+path}","compare_url":"https://api.github.com/repos/wso2/carbon-apimgt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wso2/carbon-apimgt/merges","archive_url":"https://api.github.com/repos/wso2/carbon-apimgt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wso2/carbon-apimgt/downloads","issues_url":"https://api.github.com/repos/wso2/carbon-apimgt/issues{/number}","pulls_url":"https://api.github.com/repos/wso2/carbon-apimgt/pulls{/number}","milestones_url":"https://api.github.com/repos/wso2/carbon-apimgt/milestones{/number}","notifications_url":"https://api.github.com/repos/wso2/carbon-apimgt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wso2/carbon-apimgt/labels{/name}","releases_url":"https://api.github.com/repos/wso2/carbon-apimgt/releases{/id}","deployments_url":"https://api.github.com/repos/wso2/carbon-apimgt/deployments","created_at":"2014-02-26T06:46:48Z","updated_at":"2018-07-25T05:24:57Z","pushed_at":"2018-07-27T16:00:52Z","git_url":"git://github.com/wso2/carbon-apimgt.git","ssh_url":"git@github.com:wso2/carbon-apimgt.git","clone_url":"https://github.com/wso2/carbon-apimgt.git","svn_url":"https://github.com/wso2/carbon-apimgt","homepage":null,"size":262817,"stargazers_count":51,"watchers_count":51,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":322,"mirror_url":null,"archived":false,"open_issues_count":68,"license":null,"forks":322,"open_issues":68,"watchers":51,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/5564"},"html":{"href":"https://github.com/wso2/carbon-apimgt/pull/5564"},"issue":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/issues/5564"},"comments":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/issues/5564/comments"},"review_comments":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/5564/comments"},"review_comment":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/pulls/5564/commits"},"statuses":{"href":"https://api.github.com/repos/wso2/carbon-apimgt/statuses/3abb307475721933b0140898f604a51785913f06"}},"author_association":"NONE"}}
{"actor":{"display_login":"Megala21"}}