{"action":"opened","number":1759,"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1759","id":204586762,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTg2NzYy","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1759","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1759.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1759.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1759","number":1759,"state":"open","locked":false,"title":"GetAccount was throwing a RPCServerException which is not correct.","user":{"login":"ferdeen","id":16000683,"node_id":"MDQ6VXNlcjE2MDAwNjgz","avatar_url":"https://avatars3.githubusercontent.com/u/16000683?v=4","gravatar_id":"","url":"https://api.github.com/users/ferdeen","html_url":"https://github.com/ferdeen","followers_url":"https://api.github.com/users/ferdeen/followers","following_url":"https://api.github.com/users/ferdeen/following{/other_user}","gists_url":"https://api.github.com/users/ferdeen/gists{/gist_id}","starred_url":"https://api.github.com/users/ferdeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferdeen/subscriptions","organizations_url":"https://api.github.com/users/ferdeen/orgs","repos_url":"https://api.github.com/users/ferdeen/repos","events_url":"https://api.github.com/users/ferdeen/events{/privacy}","received_events_url":"https://api.github.com/users/ferdeen/received_events","type":"User","site_admin":false},"body":"I noticed when I created the `MiningApiController` based on the `MiningRPCController` it was still throwing RPC type exceptions, which is wrong.\r\n\r\nThis small PR is to throw a normal exception.\r\n\r\nRelated to work carried out in #1691.","created_at":"2018-07-28T10:07:09Z","updated_at":"2018-07-28T10:07:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":435911027,"node_id":"MDU6TGFiZWw0MzU5MTEwMjc=","url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels/bug","name":"bug","color":"ee0701","default":true},{"id":926801084,"node_id":"MDU6TGFiZWw5MjY4MDEwODQ=","url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels/pr-review-low","name":"pr-review-low","color":"68A7F3","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1759/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1759/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1759/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/2eead4d6594971d81ff32462eb5db34936583d7f","head":{"label":"ferdeen:return_correct_exception_from_miningapicontroller","ref":"return_correct_exception_from_miningapicontroller","sha":"2eead4d6594971d81ff32462eb5db34936583d7f","user":{"login":"ferdeen","id":16000683,"node_id":"MDQ6VXNlcjE2MDAwNjgz","avatar_url":"https://avatars3.githubusercontent.com/u/16000683?v=4","gravatar_id":"","url":"https://api.github.com/users/ferdeen","html_url":"https://github.com/ferdeen","followers_url":"https://api.github.com/users/ferdeen/followers","following_url":"https://api.github.com/users/ferdeen/following{/other_user}","gists_url":"https://api.github.com/users/ferdeen/gists{/gist_id}","starred_url":"https://api.github.com/users/ferdeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferdeen/subscriptions","organizations_url":"https://api.github.com/users/ferdeen/orgs","repos_url":"https://api.github.com/users/ferdeen/repos","events_url":"https://api.github.com/users/ferdeen/events{/privacy}","received_events_url":"https://api.github.com/users/ferdeen/received_events","type":"User","site_admin":false},"repo":{"id":123270487,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMyNzA0ODc=","name":"StratisBitcoinFullNode","full_name":"ferdeen/StratisBitcoinFullNode","owner":{"login":"ferdeen","id":16000683,"node_id":"MDQ6VXNlcjE2MDAwNjgz","avatar_url":"https://avatars3.githubusercontent.com/u/16000683?v=4","gravatar_id":"","url":"https://api.github.com/users/ferdeen","html_url":"https://github.com/ferdeen","followers_url":"https://api.github.com/users/ferdeen/followers","following_url":"https://api.github.com/users/ferdeen/following{/other_user}","gists_url":"https://api.github.com/users/ferdeen/gists{/gist_id}","starred_url":"https://api.github.com/users/ferdeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferdeen/subscriptions","organizations_url":"https://api.github.com/users/ferdeen/orgs","repos_url":"https://api.github.com/users/ferdeen/repos","events_url":"https://api.github.com/users/ferdeen/events{/privacy}","received_events_url":"https://api.github.com/users/ferdeen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferdeen/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":true,"url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/deployments","created_at":"2018-02-28T10:40:08Z","updated_at":"2018-07-28T09:36:45Z","pushed_at":"2018-07-28T10:03:06Z","git_url":"git://github.com/ferdeen/StratisBitcoinFullNode.git","ssh_url":"git@github.com:ferdeen/StratisBitcoinFullNode.git","clone_url":"https://github.com/ferdeen/StratisBitcoinFullNode.git","svn_url":"https://github.com/ferdeen/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":30634,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"stratisproject:master","ref":"master","sha":"ce08ce6226d4ae7ec3a22c11411ab05657edc6a1","user":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"node_id":"MDEwOlJlcG9zaXRvcnk2NzI3MTI5MA==","name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","owner":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-07-27T18:16:32Z","pushed_at":"2018-07-28T05:40:51Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":32135,"stargazers_count":524,"watchers_count":524,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":240,"mirror_url":null,"archived":false,"open_issues_count":129,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":240,"open_issues":129,"watchers":524,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1759"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1759"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1759"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1759/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1759/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1759/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/2eead4d6594971d81ff32462eb5db34936583d7f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":16,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"ferdeen"}}