{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/42677","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/42677/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/42677/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/42677/events","html_url":"https://github.com/NixOS/nixpkgs/pull/42677","id":336386888,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODUzMTc4","number":42677,"title":"nixos/xsession: check for env vars","user":{"login":"Kmeakin","id":19665139,"node_id":"MDQ6VXNlcjE5NjY1MTM5","avatar_url":"https://avatars0.githubusercontent.com/u/19665139?v=4","gravatar_id":"","url":"https://api.github.com/users/Kmeakin","html_url":"https://github.com/Kmeakin","followers_url":"https://api.github.com/users/Kmeakin/followers","following_url":"https://api.github.com/users/Kmeakin/following{/other_user}","gists_url":"https://api.github.com/users/Kmeakin/gists{/gist_id}","starred_url":"https://api.github.com/users/Kmeakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kmeakin/subscriptions","organizations_url":"https://api.github.com/users/Kmeakin/orgs","repos_url":"https://api.github.com/users/Kmeakin/repos","events_url":"https://api.github.com/users/Kmeakin/events{/privacy}","received_events_url":"https://api.github.com/users/Kmeakin/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"node_id":"MDU6TGFiZWw3Mzc2NDI0MDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"node_id":"MDU6TGFiZWw2MDI2NTIxMg==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122884,"node_id":"MDU6TGFiZWwyOTAxMjI4ODQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-27T21:04:28Z","updated_at":"2018-07-02T19:51:48Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/42677","html_url":"https://github.com/NixOS/nixpkgs/pull/42677","diff_url":"https://github.com/NixOS/nixpkgs/pull/42677.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/42677.patch"},"body":"Read $XCOMPOSECACHE and $XDG_DATA_HOME environment variables when writing ~/.compose-cache and ~/.local/share, otherwise use default values.\r\n\r\n###### Motivation for this change\r\nOld script did not check for $XCOMPOSECACHE and $XDG_DATA_HOME\r\nenvironment variables.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [x] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/401914651","html_url":"https://github.com/NixOS/nixpkgs/pull/42677#issuecomment-401914651","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/42677","id":401914651,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTkxNDY1MQ==","user":{"login":"Infinisil","id":20525370,"node_id":"MDQ6VXNlcjIwNTI1Mzcw","avatar_url":"https://avatars0.githubusercontent.com/u/20525370?v=4","gravatar_id":"","url":"https://api.github.com/users/Infinisil","html_url":"https://github.com/Infinisil","followers_url":"https://api.github.com/users/Infinisil/followers","following_url":"https://api.github.com/users/Infinisil/following{/other_user}","gists_url":"https://api.github.com/users/Infinisil/gists{/gist_id}","starred_url":"https://api.github.com/users/Infinisil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Infinisil/subscriptions","organizations_url":"https://api.github.com/users/Infinisil/orgs","repos_url":"https://api.github.com/users/Infinisil/repos","events_url":"https://api.github.com/users/Infinisil/events{/privacy}","received_events_url":"https://api.github.com/users/Infinisil/received_events","type":"User","site_admin":false},"created_at":"2018-07-02T19:51:48Z","updated_at":"2018-07-02T19:51:48Z","author_association":"CONTRIBUTOR","body":"The problem is that `~/.xsession` isn't a file you source, but rather execute. It represents the full user session, and it only exits once the user logs out."}}
{"actor":{"display_login":"Infinisil"}}