{"action":"created","comment":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/165541940","pull_request_review_id":93500621,"id":165541940,"diff_hunk":"@@ -193,7 +193,22 @@ def _collect_inputs(self, tool, trans, incoming, history, current_user_roles):\n         # Collect any input datasets from the incoming parameters\n         inp_data = self._collect_input_datasets(tool, incoming, trans, history=history, current_user_roles=current_user_roles)\n \n-        return history, inp_data, inp_dataset_collections\n+        # grap tags from incoming HDAs\n+        preserved_tags = {}\n+        for data in inp_data.values():\n+            for tag in [t for t in data.tags if t.user_tname == 'name']:","path":"lib/galaxy/tools/actions/__init__.py","position":8,"original_position":8,"commit_id":"8a01d20f16d29f34babcc962845b0f571777b32a","original_commit_id":"8a01d20f16d29f34babcc962845b0f571777b32a","user":{"login":"jmchilton","id":216771,"avatar_url":"https://avatars0.githubusercontent.com/u/216771?v=4","gravatar_id":"","url":"https://api.github.com/users/jmchilton","html_url":"https://github.com/jmchilton","followers_url":"https://api.github.com/users/jmchilton/followers","following_url":"https://api.github.com/users/jmchilton/following{/other_user}","gists_url":"https://api.github.com/users/jmchilton/gists{/gist_id}","starred_url":"https://api.github.com/users/jmchilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmchilton/subscriptions","organizations_url":"https://api.github.com/users/jmchilton/orgs","repos_url":"https://api.github.com/users/jmchilton/repos","events_url":"https://api.github.com/users/jmchilton/events{/privacy}","received_events_url":"https://api.github.com/users/jmchilton/received_events","type":"User","site_admin":false},"body":"Ahh - okay - thanks!","created_at":"2018-02-02T02:01:11Z","updated_at":"2018-02-02T02:01:12Z","html_url":"https://github.com/galaxyproject/galaxy/pull/5403#discussion_r165541940","pull_request_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/5403","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments/165541940"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/5403#discussion_r165541940"},"pull_request":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/5403"}},"in_reply_to_id":165283450},"pull_request":{"url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/5403","id":165517973,"html_url":"https://github.com/galaxyproject/galaxy/pull/5403","diff_url":"https://github.com/galaxyproject/galaxy/pull/5403.diff","patch_url":"https://github.com/galaxyproject/galaxy/pull/5403.patch","issue_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/5403","number":5403,"state":"open","locked":false,"title":"[18.01] More robust nametag discovery and propagation.","user":{"login":"jmchilton","id":216771,"avatar_url":"https://avatars0.githubusercontent.com/u/216771?v=4","gravatar_id":"","url":"https://api.github.com/users/jmchilton","html_url":"https://github.com/jmchilton","followers_url":"https://api.github.com/users/jmchilton/followers","following_url":"https://api.github.com/users/jmchilton/following{/other_user}","gists_url":"https://api.github.com/users/jmchilton/gists{/gist_id}","starred_url":"https://api.github.com/users/jmchilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmchilton/subscriptions","organizations_url":"https://api.github.com/users/jmchilton/orgs","repos_url":"https://api.github.com/users/jmchilton/repos","events_url":"https://api.github.com/users/jmchilton/events{/privacy}","received_events_url":"https://api.github.com/users/jmchilton/received_events","type":"User","site_admin":false},"body":"- Nametags weren't being discovered on collection inputs - so for instance tools that take in a single collection and produce a dataset or file weren't propagating nametags (unless the collection contents had tags). To see this create two unnamed datasets without tags, create a pair from them, add a tag to the pair, and run the pair through the \"paired_test\" test tool.\r\n- Nametags weren't being propagated to the outputs of collection operations - to either dataset or collection outputs.\r\n\r\nThis PR fixes both problems I think.\r\n\r\nPing @nekrut ","created_at":"2018-01-27T13:26:51Z","updated_at":"2018-02-02T02:01:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"daf3d4dc20c86cc74221776c2fb649962c6d34bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":{"url":"https://api.github.com/repos/galaxyproject/galaxy/milestones/9","html_url":"https://github.com/galaxyproject/galaxy/milestone/9","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones/9/labels","id":2583272,"number":9,"title":"18.01","description":"Galaxy release 18.01","creator":{"login":"martenson","id":1814954,"avatar_url":"https://avatars2.githubusercontent.com/u/1814954?v=4","gravatar_id":"","url":"https://api.github.com/users/martenson","html_url":"https://github.com/martenson","followers_url":"https://api.github.com/users/martenson/followers","following_url":"https://api.github.com/users/martenson/following{/other_user}","gists_url":"https://api.github.com/users/martenson/gists{/gist_id}","starred_url":"https://api.github.com/users/martenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martenson/subscriptions","organizations_url":"https://api.github.com/users/martenson/orgs","repos_url":"https://api.github.com/users/martenson/repos","events_url":"https://api.github.com/users/martenson/events{/privacy}","received_events_url":"https://api.github.com/users/martenson/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":406,"state":"open","created_at":"2017-06-14T17:01:44Z","updated_at":"2018-02-01T21:38:51Z","due_on":"2018-01-08T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/5403/commits","review_comments_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/5403/comments","review_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/5403/comments","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/8a01d20f16d29f34babcc962845b0f571777b32a","head":{"label":"jmchilton:collection_operation_tags","ref":"collection_operation_tags","sha":"8a01d20f16d29f34babcc962845b0f571777b32a","user":{"login":"jmchilton","id":216771,"avatar_url":"https://avatars0.githubusercontent.com/u/216771?v=4","gravatar_id":"","url":"https://api.github.com/users/jmchilton","html_url":"https://github.com/jmchilton","followers_url":"https://api.github.com/users/jmchilton/followers","following_url":"https://api.github.com/users/jmchilton/following{/other_user}","gists_url":"https://api.github.com/users/jmchilton/gists{/gist_id}","starred_url":"https://api.github.com/users/jmchilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmchilton/subscriptions","organizations_url":"https://api.github.com/users/jmchilton/orgs","repos_url":"https://api.github.com/users/jmchilton/repos","events_url":"https://api.github.com/users/jmchilton/events{/privacy}","received_events_url":"https://api.github.com/users/jmchilton/received_events","type":"User","site_admin":false},"repo":{"id":31215230,"name":"galaxy","full_name":"jmchilton/galaxy","owner":{"login":"jmchilton","id":216771,"avatar_url":"https://avatars0.githubusercontent.com/u/216771?v=4","gravatar_id":"","url":"https://api.github.com/users/jmchilton","html_url":"https://github.com/jmchilton","followers_url":"https://api.github.com/users/jmchilton/followers","following_url":"https://api.github.com/users/jmchilton/following{/other_user}","gists_url":"https://api.github.com/users/jmchilton/gists{/gist_id}","starred_url":"https://api.github.com/users/jmchilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmchilton/subscriptions","organizations_url":"https://api.github.com/users/jmchilton/orgs","repos_url":"https://api.github.com/users/jmchilton/repos","events_url":"https://api.github.com/users/jmchilton/events{/privacy}","received_events_url":"https://api.github.com/users/jmchilton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmchilton/galaxy","description":"Galaxy Github repository BETA 2. May be destroyed and recreated if additional post-conversion problems are found (but post-conversion commits on this repo will be reapplied to any recreations). Full details:","fork":true,"url":"https://api.github.com/repos/jmchilton/galaxy","forks_url":"https://api.github.com/repos/jmchilton/galaxy/forks","keys_url":"https://api.github.com/repos/jmchilton/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmchilton/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmchilton/galaxy/teams","hooks_url":"https://api.github.com/repos/jmchilton/galaxy/hooks","issue_events_url":"https://api.github.com/repos/jmchilton/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/jmchilton/galaxy/events","assignees_url":"https://api.github.com/repos/jmchilton/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/jmchilton/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/jmchilton/galaxy/tags","blobs_url":"https://api.github.com/repos/jmchilton/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmchilton/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmchilton/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmchilton/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmchilton/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/jmchilton/galaxy/languages","stargazers_url":"https://api.github.com/repos/jmchilton/galaxy/stargazers","contributors_url":"https://api.github.com/repos/jmchilton/galaxy/contributors","subscribers_url":"https://api.github.com/repos/jmchilton/galaxy/subscribers","subscription_url":"https://api.github.com/repos/jmchilton/galaxy/subscription","commits_url":"https://api.github.com/repos/jmchilton/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmchilton/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmchilton/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmchilton/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmchilton/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/jmchilton/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmchilton/galaxy/merges","archive_url":"https://api.github.com/repos/jmchilton/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmchilton/galaxy/downloads","issues_url":"https://api.github.com/repos/jmchilton/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/jmchilton/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/jmchilton/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/jmchilton/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmchilton/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/jmchilton/galaxy/releases{/id}","deployments_url":"https://api.github.com/repos/jmchilton/galaxy/deployments","created_at":"2015-02-23T15:54:52Z","updated_at":"2017-06-26T15:34:02Z","pushed_at":"2018-02-01T21:39:15Z","git_url":"git://github.com/jmchilton/galaxy.git","ssh_url":"git@github.com:jmchilton/galaxy.git","clone_url":"https://github.com/jmchilton/galaxy.git","svn_url":"https://github.com/jmchilton/galaxy","homepage":"https://trello.com/c/iiSBweRQ","size":441170,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":28,"watchers":4,"default_branch":"dev"}},"base":{"label":"galaxyproject:release_18.01","ref":"release_18.01","sha":"baae416472b00ad4f33278ae48850146740ae299","user":{"login":"galaxyproject","id":7937847,"avatar_url":"https://avatars3.githubusercontent.com/u/7937847?v=4","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"repo":{"id":31211061,"name":"galaxy","full_name":"galaxyproject/galaxy","owner":{"login":"galaxyproject","id":7937847,"avatar_url":"https://avatars3.githubusercontent.com/u/7937847?v=4","gravatar_id":"","url":"https://api.github.com/users/galaxyproject","html_url":"https://github.com/galaxyproject","followers_url":"https://api.github.com/users/galaxyproject/followers","following_url":"https://api.github.com/users/galaxyproject/following{/other_user}","gists_url":"https://api.github.com/users/galaxyproject/gists{/gist_id}","starred_url":"https://api.github.com/users/galaxyproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galaxyproject/subscriptions","organizations_url":"https://api.github.com/users/galaxyproject/orgs","repos_url":"https://api.github.com/users/galaxyproject/repos","events_url":"https://api.github.com/users/galaxyproject/events{/privacy}","received_events_url":"https://api.github.com/users/galaxyproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/galaxyproject/galaxy","description":"Data intensive science for everyone.","fork":false,"url":"https://api.github.com/repos/galaxyproject/galaxy","forks_url":"https://api.github.com/repos/galaxyproject/galaxy/forks","keys_url":"https://api.github.com/repos/galaxyproject/galaxy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galaxyproject/galaxy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galaxyproject/galaxy/teams","hooks_url":"https://api.github.com/repos/galaxyproject/galaxy/hooks","issue_events_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/events{/number}","events_url":"https://api.github.com/repos/galaxyproject/galaxy/events","assignees_url":"https://api.github.com/repos/galaxyproject/galaxy/assignees{/user}","branches_url":"https://api.github.com/repos/galaxyproject/galaxy/branches{/branch}","tags_url":"https://api.github.com/repos/galaxyproject/galaxy/tags","blobs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galaxyproject/galaxy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galaxyproject/galaxy/git/refs{/sha}","trees_url":"https://api.github.com/repos/galaxyproject/galaxy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galaxyproject/galaxy/statuses/{sha}","languages_url":"https://api.github.com/repos/galaxyproject/galaxy/languages","stargazers_url":"https://api.github.com/repos/galaxyproject/galaxy/stargazers","contributors_url":"https://api.github.com/repos/galaxyproject/galaxy/contributors","subscribers_url":"https://api.github.com/repos/galaxyproject/galaxy/subscribers","subscription_url":"https://api.github.com/repos/galaxyproject/galaxy/subscription","commits_url":"https://api.github.com/repos/galaxyproject/galaxy/commits{/sha}","git_commits_url":"https://api.github.com/repos/galaxyproject/galaxy/git/commits{/sha}","comments_url":"https://api.github.com/repos/galaxyproject/galaxy/comments{/number}","issue_comment_url":"https://api.github.com/repos/galaxyproject/galaxy/issues/comments{/number}","contents_url":"https://api.github.com/repos/galaxyproject/galaxy/contents/{+path}","compare_url":"https://api.github.com/repos/galaxyproject/galaxy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galaxyproject/galaxy/merges","archive_url":"https://api.github.com/repos/galaxyproject/galaxy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galaxyproject/galaxy/downloads","issues_url":"https://api.github.com/repos/galaxyproject/galaxy/issues{/number}","pulls_url":"https://api.github.com/repos/galaxyproject/galaxy/pulls{/number}","milestones_url":"https://api.github.com/repos/galaxyproject/galaxy/milestones{/number}","notifications_url":"https://api.github.com/repos/galaxyproject/galaxy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galaxyproject/galaxy/labels{/name}","releases_url":"https://api.github.com/repos/galaxyproject/galaxy/releases{/id}","deployments_url":"https://api.github.com/repos/galaxyproject/galaxy/deployments","created_at":"2015-02-23T14:18:06Z","updated_at":"2018-01-31T22:57:29Z","pushed_at":"2018-02-01T21:38:51Z","git_url":"git://github.com/galaxyproject/galaxy.git","ssh_url":"git@github.com:galaxyproject/galaxy.git","clone_url":"https://github.com/galaxyproject/galaxy.git","svn_url":"https://github.com/galaxyproject/galaxy","homepage":"https://galaxyproject.org/","size":421184,"stargazers_count":410,"watchers_count":410,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":416,"mirror_url":null,"archived":false,"open_issues_count":1000,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":416,"open_issues":1000,"watchers":410,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/5403"},"html":{"href":"https://github.com/galaxyproject/galaxy/pull/5403"},"issue":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/5403"},"comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/issues/5403/comments"},"review_comments":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/5403/comments"},"review_comment":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/galaxyproject/galaxy/pulls/5403/commits"},"statuses":{"href":"https://api.github.com/repos/galaxyproject/galaxy/statuses/8a01d20f16d29f34babcc962845b0f571777b32a"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jmchilton"}}