{"action":"created","issue":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/11783","repository_url":"https://api.github.com/repos/civicrm/civicrm-core","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/11783/labels{/name}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/11783/comments","events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/11783/events","html_url":"https://github.com/civicrm/civicrm-core/pull/11783","id":303267501,"number":11783,"title":"(WIP) CRM-21827: Add Membership External Id As New Field To Core","user":{"login":"vinuvarshith","id":36624620,"avatar_url":"https://avatars1.githubusercontent.com/u/36624620?v=4","gravatar_id":"","url":"https://api.github.com/users/vinuvarshith","html_url":"https://github.com/vinuvarshith","followers_url":"https://api.github.com/users/vinuvarshith/followers","following_url":"https://api.github.com/users/vinuvarshith/following{/other_user}","gists_url":"https://api.github.com/users/vinuvarshith/gists{/gist_id}","starred_url":"https://api.github.com/users/vinuvarshith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinuvarshith/subscriptions","organizations_url":"https://api.github.com/users/vinuvarshith/orgs","repos_url":"https://api.github.com/users/vinuvarshith/repos","events_url":"https://api.github.com/users/vinuvarshith/events{/privacy}","received_events_url":"https://api.github.com/users/vinuvarshith/received_events","type":"User","site_admin":false},"labels":[{"id":246037889,"url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":19,"created_at":"2018-03-07T21:33:12Z","updated_at":"2018-03-13T17:07:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/11783","html_url":"https://github.com/civicrm/civicrm-core/pull/11783","diff_url":"https://github.com/civicrm/civicrm-core/pull/11783.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/11783.patch"},"body":"Overview\r\n----------------------------------------\r\nWe need to add a new field to the core -\r\nMembership External ID\r\nThis field will be helpful in uploading Contributions through Civi's standard contribution importer as we will be able to reference it to a membership.\r\n\r\nBefore\r\n----------------------------------------\r\nCurrently there is no external field to map when working with memberships\r\n\r\nAfter\r\n----------------------------------------\r\nA new field 'External Membership Id' is available for memberships similar to external_identifier field for contacts. \r\n\r\nComments\r\n----------------------------------------\r\nI have added SQL to add the new column to membership table in CRM/Upgrade/Incremental/sql/4.7.32.mysql.tpl\n\n---\n\n * [CRM-21827: Add Membership External ID as a new field to core](https://issues.civicrm.org/jira/browse/CRM-21827)"},"comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments/372742699","html_url":"https://github.com/civicrm/civicrm-core/pull/11783#issuecomment-372742699","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/11783","id":372742699,"user":{"login":"JoeMurray","id":300943,"avatar_url":"https://avatars1.githubusercontent.com/u/300943?v=4","gravatar_id":"","url":"https://api.github.com/users/JoeMurray","html_url":"https://github.com/JoeMurray","followers_url":"https://api.github.com/users/JoeMurray/followers","following_url":"https://api.github.com/users/JoeMurray/following{/other_user}","gists_url":"https://api.github.com/users/JoeMurray/gists{/gist_id}","starred_url":"https://api.github.com/users/JoeMurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoeMurray/subscriptions","organizations_url":"https://api.github.com/users/JoeMurray/orgs","repos_url":"https://api.github.com/users/JoeMurray/repos","events_url":"https://api.github.com/users/JoeMurray/events{/privacy}","received_events_url":"https://api.github.com/users/JoeMurray/received_events","type":"User","site_admin":false},"created_at":"2018-03-13T17:07:06Z","updated_at":"2018-03-13T17:07:06Z","author_association":"CONTRIBUTOR","body":"I sympathize with the back and forth on whether this should be core or extension. We've hacked this type of field numerous times on various objects to help with an import. I think @agh1's suggestion is the best for a couple of reasons:\r\n1. It supports multiple external identifiers. We recently migrated 4 legacy systems into one and had to setup several of these fields for contacts. Would be very convenient to have a mechanism in core for this.\r\n2. Consistent with LExIM, for systems that don't need it, the schema is unchanged."}}
{"actor":{"display_login":"JoeMurray"}}