{"action":"created","comment":{"url":"https://api.github.com/repos/veritone/veritone-sdk/pulls/comments/185898069","pull_request_review_id":117380827,"id":185898069,"diff_hunk":"@@ -38,6 +38,10 @@ class _VeritoneApp {\n     if (OAuthToken) {\n       this._store.dispatch(authModule.setOAuthToken(OAuthToken));\n     }\n+\n+    if (!OAuthToken && !sessionToken) {\n+      this._store.dispatch(authModule.checkAuthNoToken());","path":"packages/veritone-widgets/src/shared/VeritoneApp.js","position":6,"original_position":6,"commit_id":"0d1a20ab82b1d626a2ac025e37fa796f3dd7b2d0","original_commit_id":"0d1a20ab82b1d626a2ac025e37fa796f3dd7b2d0","user":{"login":"olslash","id":693493,"avatar_url":"https://avatars3.githubusercontent.com/u/693493?v=4","gravatar_id":"","url":"https://api.github.com/users/olslash","html_url":"https://github.com/olslash","followers_url":"https://api.github.com/users/olslash/followers","following_url":"https://api.github.com/users/olslash/following{/other_user}","gists_url":"https://api.github.com/users/olslash/gists{/gist_id}","starred_url":"https://api.github.com/users/olslash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olslash/subscriptions","organizations_url":"https://api.github.com/users/olslash/orgs","repos_url":"https://api.github.com/users/olslash/repos","events_url":"https://api.github.com/users/olslash/events{/privacy}","received_events_url":"https://api.github.com/users/olslash/received_events","type":"User","site_admin":false},"body":"thinking about it, we should probaby make this whole thing an if-else-if-else chain, since you wouldn't reasonably provide both tokens\r\n\r\nif (sessionToken)\r\nelse if (oauthToken)\r\nelse { checkAuthNoToken }","created_at":"2018-05-03T18:35:10Z","updated_at":"2018-05-03T18:43:42Z","html_url":"https://github.com/veritone/veritone-sdk/pull/125#discussion_r185898069","pull_request_url":"https://api.github.com/repos/veritone/veritone-sdk/pulls/125","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/veritone/veritone-sdk/pulls/comments/185898069"},"html":{"href":"https://github.com/veritone/veritone-sdk/pull/125#discussion_r185898069"},"pull_request":{"href":"https://api.github.com/repos/veritone/veritone-sdk/pulls/125"}}},"pull_request":{"url":"https://api.github.com/repos/veritone/veritone-sdk/pulls/125","id":185790883,"html_url":"https://github.com/veritone/veritone-sdk/pull/125","diff_url":"https://github.com/veritone/veritone-sdk/pull/125.diff","patch_url":"https://github.com/veritone/veritone-sdk/pull/125.patch","issue_url":"https://api.github.com/repos/veritone/veritone-sdk/issues/125","number":125,"state":"open","locked":false,"title":"Fix/vtn 7479 veritone app.login should attempt cookie auth","user":{"login":"mclenithan","id":2336599,"avatar_url":"https://avatars1.githubusercontent.com/u/2336599?v=4","gravatar_id":"","url":"https://api.github.com/users/mclenithan","html_url":"https://github.com/mclenithan","followers_url":"https://api.github.com/users/mclenithan/followers","following_url":"https://api.github.com/users/mclenithan/following{/other_user}","gists_url":"https://api.github.com/users/mclenithan/gists{/gist_id}","starred_url":"https://api.github.com/users/mclenithan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mclenithan/subscriptions","organizations_url":"https://api.github.com/users/mclenithan/orgs","repos_url":"https://api.github.com/users/mclenithan/repos","events_url":"https://api.github.com/users/mclenithan/events{/privacy}","received_events_url":"https://api.github.com/users/mclenithan/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-03T17:49:47Z","updated_at":"2018-05-03T18:43:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4c93b64e365d8d9ce04035eeed23ff8b2364114","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/veritone/veritone-sdk/pulls/125/commits","review_comments_url":"https://api.github.com/repos/veritone/veritone-sdk/pulls/125/comments","review_comment_url":"https://api.github.com/repos/veritone/veritone-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/veritone/veritone-sdk/issues/125/comments","statuses_url":"https://api.github.com/repos/veritone/veritone-sdk/statuses/0d1a20ab82b1d626a2ac025e37fa796f3dd7b2d0","head":{"label":"veritone:fix/VTN-7479-VeritoneApp.login-should-attempt-cookie-auth","ref":"fix/VTN-7479-VeritoneApp.login-should-attempt-cookie-auth","sha":"0d1a20ab82b1d626a2ac025e37fa796f3dd7b2d0","user":{"login":"veritone","id":6934985,"avatar_url":"https://avatars3.githubusercontent.com/u/6934985?v=4","gravatar_id":"","url":"https://api.github.com/users/veritone","html_url":"https://github.com/veritone","followers_url":"https://api.github.com/users/veritone/followers","following_url":"https://api.github.com/users/veritone/following{/other_user}","gists_url":"https://api.github.com/users/veritone/gists{/gist_id}","starred_url":"https://api.github.com/users/veritone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veritone/subscriptions","organizations_url":"https://api.github.com/users/veritone/orgs","repos_url":"https://api.github.com/users/veritone/repos","events_url":"https://api.github.com/users/veritone/events{/privacy}","received_events_url":"https://api.github.com/users/veritone/received_events","type":"Organization","site_admin":false},"repo":{"id":103306211,"name":"veritone-sdk","full_name":"veritone/veritone-sdk","owner":{"login":"veritone","id":6934985,"avatar_url":"https://avatars3.githubusercontent.com/u/6934985?v=4","gravatar_id":"","url":"https://api.github.com/users/veritone","html_url":"https://github.com/veritone","followers_url":"https://api.github.com/users/veritone/followers","following_url":"https://api.github.com/users/veritone/following{/other_user}","gists_url":"https://api.github.com/users/veritone/gists{/gist_id}","starred_url":"https://api.github.com/users/veritone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veritone/subscriptions","organizations_url":"https://api.github.com/users/veritone/orgs","repos_url":"https://api.github.com/users/veritone/repos","events_url":"https://api.github.com/users/veritone/events{/privacy}","received_events_url":"https://api.github.com/users/veritone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/veritone/veritone-sdk","description":"Monorepo for Veritone's open source developer packages","fork":false,"url":"https://api.github.com/repos/veritone/veritone-sdk","forks_url":"https://api.github.com/repos/veritone/veritone-sdk/forks","keys_url":"https://api.github.com/repos/veritone/veritone-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/veritone/veritone-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/veritone/veritone-sdk/teams","hooks_url":"https://api.github.com/repos/veritone/veritone-sdk/hooks","issue_events_url":"https://api.github.com/repos/veritone/veritone-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/veritone/veritone-sdk/events","assignees_url":"https://api.github.com/repos/veritone/veritone-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/veritone/veritone-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/veritone/veritone-sdk/tags","blobs_url":"https://api.github.com/repos/veritone/veritone-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/veritone/veritone-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/veritone/veritone-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/veritone/veritone-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/veritone/veritone-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/veritone/veritone-sdk/languages","stargazers_url":"https://api.github.com/repos/veritone/veritone-sdk/stargazers","contributors_url":"https://api.github.com/repos/veritone/veritone-sdk/contributors","subscribers_url":"https://api.github.com/repos/veritone/veritone-sdk/subscribers","subscription_url":"https://api.github.com/repos/veritone/veritone-sdk/subscription","commits_url":"https://api.github.com/repos/veritone/veritone-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/veritone/veritone-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/veritone/veritone-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/veritone/veritone-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/veritone/veritone-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/veritone/veritone-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/veritone/veritone-sdk/merges","archive_url":"https://api.github.com/repos/veritone/veritone-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/veritone/veritone-sdk/downloads","issues_url":"https://api.github.com/repos/veritone/veritone-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/veritone/veritone-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/veritone/veritone-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/veritone/veritone-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/veritone/veritone-sdk/labels{/name}","releases_url":"https://api.github.com/repos/veritone/veritone-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/veritone/veritone-sdk/deployments","created_at":"2017-09-12T18:21:09Z","updated_at":"2018-05-02T20:02:04Z","pushed_at":"2018-05-03T18:22:56Z","git_url":"git://github.com/veritone/veritone-sdk.git","ssh_url":"git@github.com:veritone/veritone-sdk.git","clone_url":"https://github.com/veritone/veritone-sdk.git","svn_url":"https://github.com/veritone/veritone-sdk","homepage":"https://www.veritone.com","size":6584,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":8,"watchers":8,"default_branch":"master"}},"base":{"label":"veritone:master","ref":"master","sha":"02d7c391fe3ff6cc16e3e4d895feb494f7815cfa","user":{"login":"veritone","id":6934985,"avatar_url":"https://avatars3.githubusercontent.com/u/6934985?v=4","gravatar_id":"","url":"https://api.github.com/users/veritone","html_url":"https://github.com/veritone","followers_url":"https://api.github.com/users/veritone/followers","following_url":"https://api.github.com/users/veritone/following{/other_user}","gists_url":"https://api.github.com/users/veritone/gists{/gist_id}","starred_url":"https://api.github.com/users/veritone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veritone/subscriptions","organizations_url":"https://api.github.com/users/veritone/orgs","repos_url":"https://api.github.com/users/veritone/repos","events_url":"https://api.github.com/users/veritone/events{/privacy}","received_events_url":"https://api.github.com/users/veritone/received_events","type":"Organization","site_admin":false},"repo":{"id":103306211,"name":"veritone-sdk","full_name":"veritone/veritone-sdk","owner":{"login":"veritone","id":6934985,"avatar_url":"https://avatars3.githubusercontent.com/u/6934985?v=4","gravatar_id":"","url":"https://api.github.com/users/veritone","html_url":"https://github.com/veritone","followers_url":"https://api.github.com/users/veritone/followers","following_url":"https://api.github.com/users/veritone/following{/other_user}","gists_url":"https://api.github.com/users/veritone/gists{/gist_id}","starred_url":"https://api.github.com/users/veritone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/veritone/subscriptions","organizations_url":"https://api.github.com/users/veritone/orgs","repos_url":"https://api.github.com/users/veritone/repos","events_url":"https://api.github.com/users/veritone/events{/privacy}","received_events_url":"https://api.github.com/users/veritone/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/veritone/veritone-sdk","description":"Monorepo for Veritone's open source developer packages","fork":false,"url":"https://api.github.com/repos/veritone/veritone-sdk","forks_url":"https://api.github.com/repos/veritone/veritone-sdk/forks","keys_url":"https://api.github.com/repos/veritone/veritone-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/veritone/veritone-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/veritone/veritone-sdk/teams","hooks_url":"https://api.github.com/repos/veritone/veritone-sdk/hooks","issue_events_url":"https://api.github.com/repos/veritone/veritone-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/veritone/veritone-sdk/events","assignees_url":"https://api.github.com/repos/veritone/veritone-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/veritone/veritone-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/veritone/veritone-sdk/tags","blobs_url":"https://api.github.com/repos/veritone/veritone-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/veritone/veritone-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/veritone/veritone-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/veritone/veritone-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/veritone/veritone-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/veritone/veritone-sdk/languages","stargazers_url":"https://api.github.com/repos/veritone/veritone-sdk/stargazers","contributors_url":"https://api.github.com/repos/veritone/veritone-sdk/contributors","subscribers_url":"https://api.github.com/repos/veritone/veritone-sdk/subscribers","subscription_url":"https://api.github.com/repos/veritone/veritone-sdk/subscription","commits_url":"https://api.github.com/repos/veritone/veritone-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/veritone/veritone-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/veritone/veritone-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/veritone/veritone-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/veritone/veritone-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/veritone/veritone-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/veritone/veritone-sdk/merges","archive_url":"https://api.github.com/repos/veritone/veritone-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/veritone/veritone-sdk/downloads","issues_url":"https://api.github.com/repos/veritone/veritone-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/veritone/veritone-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/veritone/veritone-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/veritone/veritone-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/veritone/veritone-sdk/labels{/name}","releases_url":"https://api.github.com/repos/veritone/veritone-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/veritone/veritone-sdk/deployments","created_at":"2017-09-12T18:21:09Z","updated_at":"2018-05-02T20:02:04Z","pushed_at":"2018-05-03T18:22:56Z","git_url":"git://github.com/veritone/veritone-sdk.git","ssh_url":"git@github.com:veritone/veritone-sdk.git","clone_url":"https://github.com/veritone/veritone-sdk.git","svn_url":"https://github.com/veritone/veritone-sdk","homepage":"https://www.veritone.com","size":6584,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":8,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/veritone/veritone-sdk/pulls/125"},"html":{"href":"https://github.com/veritone/veritone-sdk/pull/125"},"issue":{"href":"https://api.github.com/repos/veritone/veritone-sdk/issues/125"},"comments":{"href":"https://api.github.com/repos/veritone/veritone-sdk/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/veritone/veritone-sdk/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/veritone/veritone-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/veritone/veritone-sdk/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/veritone/veritone-sdk/statuses/0d1a20ab82b1d626a2ac025e37fa796f3dd7b2d0"}},"author_association":"NONE"}}
{"actor":{"display_login":"olslash"}}