{"action":"created","comment":{"url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/comments/180085880","pull_request_review_id":110443759,"id":180085880,"diff_hunk":"@@ -89,15 +87,32 @@ namespace hpx { namespace plugins\n     )(__VA_ARGS__))                                                           \\\n /**/\n \n-#define HPX_REGISTER_PLUGIN_REGISTRY_2(PluginType, pluginname)                \\\n-    typedef hpx::plugins::plugin_registry<PluginType>                         \\\n-        pluginname ## _plugin_registry_type;                                  \\\n-    HPX_REGISTER_PLUGIN_BASE_REGISTRY(                                        \\\n-        pluginname ## _plugin_registry_type, pluginname)                      \\\n-    HPX_DEF_UNIQUE_PLUGIN_NAME(                                               \\\n-        pluginname ## _plugin_registry_type, pluginname)                      \\\n-    template struct hpx::plugins::plugin_registry<PluginType >;               \\\n-/**/\n+#define HPX_REGISTER_PLUGIN_REGISTRY_2(PluginType, pluginname)                 \\\n+    HPX_REGISTER_PLUGIN_REGISTRY_5(                                            \\\n+        PluginType, pluginname, HPX_PLUGIN_NAME, \"hpx\", \"hpx\")                 \\\n+    /**/\n+#define HPX_REGISTER_PLUGIN_REGISTRY_4(                                        \\\n+    PluginType, pluginname, pluginsection, pluginsuffix)                       \\\n+    HPX_REGISTER_PLUGIN_REGISTRY_5(PluginType, pluginname, HPX_PLUGIN_NAME,    \\\n+        pluginsection, \"pluginsuffix\")                                         \\\n+    /**/\n+#define HPX_REGISTER_PLUGIN_REGISTRY_5(                                        \\\n+        PluginType, pluginname, pluginstring, pluginsection, pluginsuffix)     \\\n+    HPX_CXX14_CONSTEXPR char __##pluginname##_string[] =                       \\\n+        HPX_PP_STRINGIZE(pluginstring);                                        \\\n+    HPX_CXX14_CONSTEXPR char __##pluginname##_section[] = pluginsection;       \\\n+    HPX_CXX14_CONSTEXPR char __##pluginname##_suffix[] = pluginsuffix;         \\\n+    typedef hpx::plugins::plugin_registry<PluginType, __##pluginname##_string, \\\n+        __##pluginname##_section, __##pluginname##_suffix>                     \\\n+        __##pluginname##_plugin_registry_type;                                 \\\n+    HPX_REGISTER_PLUGIN_BASE_REGISTRY(                                         \\\n+        __##pluginname##_plugin_registry_type, pluginname)                     \\\n+    HPX_DEF_UNIQUE_PLUGIN_NAME(                                                \\\n+        __##pluginname##_plugin_registry_type, pluginname)                     \\\n+    template struct hpx::plugins::plugin_registry<PluginType,                  \\\n+        __##pluginname##_string, __##pluginname##_section,                     \\\n+        __##pluginname##_suffix>;                                              \\","path":"hpx/plugins/plugin_registry.hpp","position":71,"original_position":71,"commit_id":"20ee5e4484c249ccfea080f7fcdfaf2ad5e62833","original_commit_id":"20ee5e4484c249ccfea080f7fcdfaf2ad5e62833","user":{"login":"hkaiser","id":568063,"avatar_url":"https://avatars1.githubusercontent.com/u/568063?v=4","gravatar_id":"","url":"https://api.github.com/users/hkaiser","html_url":"https://github.com/hkaiser","followers_url":"https://api.github.com/users/hkaiser/followers","following_url":"https://api.github.com/users/hkaiser/following{/other_user}","gists_url":"https://api.github.com/users/hkaiser/gists{/gist_id}","starred_url":"https://api.github.com/users/hkaiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkaiser/subscriptions","organizations_url":"https://api.github.com/users/hkaiser/orgs","repos_url":"https://api.github.com/users/hkaiser/repos","events_url":"https://api.github.com/users/hkaiser/events{/privacy}","received_events_url":"https://api.github.com/users/hkaiser/received_events","type":"User","site_admin":false},"body":"This is only necessary if the parameters `pluginname` is a macro itself.. Not sure if it's worth the trouble.","created_at":"2018-04-09T13:01:14Z","updated_at":"2018-04-09T13:01:14Z","html_url":"https://github.com/STEllAR-GROUP/hpx/pull/3277#discussion_r180085880","pull_request_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/3277","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/comments/180085880"},"html":{"href":"https://github.com/STEllAR-GROUP/hpx/pull/3277#discussion_r180085880"},"pull_request":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/3277"}},"in_reply_to_id":180085014},"pull_request":{"url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/3277","id":180107945,"html_url":"https://github.com/STEllAR-GROUP/hpx/pull/3277","diff_url":"https://github.com/STEllAR-GROUP/hpx/pull/3277.diff","patch_url":"https://github.com/STEllAR-GROUP/hpx/pull/3277.patch","issue_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/3277","number":3277,"state":"open","locked":false,"title":"Support external plugins","user":{"login":"hkaiser","id":568063,"avatar_url":"https://avatars1.githubusercontent.com/u/568063?v=4","gravatar_id":"","url":"https://api.github.com/users/hkaiser","html_url":"https://github.com/hkaiser","followers_url":"https://api.github.com/users/hkaiser/followers","following_url":"https://api.github.com/users/hkaiser/following{/other_user}","gists_url":"https://api.github.com/users/hkaiser/gists{/gist_id}","starred_url":"https://api.github.com/users/hkaiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkaiser/subscriptions","organizations_url":"https://api.github.com/users/hkaiser/orgs","repos_url":"https://api.github.com/users/hkaiser/repos","events_url":"https://api.github.com/users/hkaiser/events{/privacy}","received_events_url":"https://api.github.com/users/hkaiser/received_events","type":"User","site_admin":false},"body":"A couple of minor changes allowing for external libraries to load their own plugins through HPX's plugin infrastructure. \r\n\r\nThese are changes required by Phylanx.","created_at":"2018-04-07T14:25:21Z","updated_at":"2018-04-09T13:01:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05ffbe4c74ed0f7addbdf65a0e7ee1fec50f0bc1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":11450887,"url":"https://api.github.com/repos/STEllAR-GROUP/hpx/labels/category:%20core","name":"category: core","color":"02e10c","default":false},{"id":12168892,"url":"https://api.github.com/repos/STEllAR-GROUP/hpx/labels/type:%20enhancement","name":"type: enhancement","color":"e10c02","default":false}],"milestone":{"url":"https://api.github.com/repos/STEllAR-GROUP/hpx/milestones/28","html_url":"https://github.com/STEllAR-GROUP/hpx/milestone/28","labels_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/milestones/28/labels","id":2907693,"number":28,"title":"1.2.0","description":"","creator":{"login":"biddisco","id":941548,"avatar_url":"https://avatars3.githubusercontent.com/u/941548?v=4","gravatar_id":"","url":"https://api.github.com/users/biddisco","html_url":"https://github.com/biddisco","followers_url":"https://api.github.com/users/biddisco/followers","following_url":"https://api.github.com/users/biddisco/following{/other_user}","gists_url":"https://api.github.com/users/biddisco/gists{/gist_id}","starred_url":"https://api.github.com/users/biddisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biddisco/subscriptions","organizations_url":"https://api.github.com/users/biddisco/orgs","repos_url":"https://api.github.com/users/biddisco/repos","events_url":"https://api.github.com/users/biddisco/events{/privacy}","received_events_url":"https://api.github.com/users/biddisco/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":22,"state":"open","created_at":"2017-11-13T10:07:21Z","updated_at":"2018-04-09T12:50:58Z","due_on":"2018-09-19T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/3277/commits","review_comments_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/3277/comments","review_comment_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/3277/comments","statuses_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/statuses/20ee5e4484c249ccfea080f7fcdfaf2ad5e62833","head":{"label":"STEllAR-GROUP:external_plugins","ref":"external_plugins","sha":"20ee5e4484c249ccfea080f7fcdfaf2ad5e62833","user":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars1.githubusercontent.com/u/1780988?v=4","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"repo":{"id":4455628,"name":"hpx","full_name":"STEllAR-GROUP/hpx","owner":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars1.githubusercontent.com/u/1780988?v=4","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/STEllAR-GROUP/hpx","description":"The C++ Standard Library for Parallelism and Concurrency","fork":false,"url":"https://api.github.com/repos/STEllAR-GROUP/hpx","forks_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/forks","keys_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/teams","hooks_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/hooks","issue_events_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/events{/number}","events_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/events","assignees_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/assignees{/user}","branches_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/branches{/branch}","tags_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/tags","blobs_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/refs{/sha}","trees_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/statuses/{sha}","languages_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/languages","stargazers_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/stargazers","contributors_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/contributors","subscribers_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/subscribers","subscription_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/subscription","commits_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/commits{/sha}","git_commits_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/commits{/sha}","comments_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/comments{/number}","issue_comment_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/comments{/number}","contents_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/contents/{+path}","compare_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/merges","archive_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/downloads","issues_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues{/number}","pulls_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls{/number}","milestones_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/milestones{/number}","notifications_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/labels{/name}","releases_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/releases{/id}","deployments_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/deployments","created_at":"2012-05-26T15:02:39Z","updated_at":"2018-04-09T12:51:04Z","pushed_at":"2018-04-09T12:53:49Z","git_url":"git://github.com/STEllAR-GROUP/hpx.git","ssh_url":"git@github.com:STEllAR-GROUP/hpx.git","clone_url":"https://github.com/STEllAR-GROUP/hpx.git","svn_url":"https://github.com/STEllAR-GROUP/hpx","homepage":"http://stellar-group.org/libraries/hpx","size":711875,"stargazers_count":868,"watchers_count":868,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":210,"mirror_url":null,"archived":false,"open_issues_count":163,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":210,"open_issues":163,"watchers":868,"default_branch":"master"}},"base":{"label":"STEllAR-GROUP:master","ref":"master","sha":"5e3f0c4b5bd80423b90c75c674460912f7272d7d","user":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars1.githubusercontent.com/u/1780988?v=4","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"repo":{"id":4455628,"name":"hpx","full_name":"STEllAR-GROUP/hpx","owner":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars1.githubusercontent.com/u/1780988?v=4","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/STEllAR-GROUP/hpx","description":"The C++ Standard Library for Parallelism and Concurrency","fork":false,"url":"https://api.github.com/repos/STEllAR-GROUP/hpx","forks_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/forks","keys_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/teams","hooks_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/hooks","issue_events_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/events{/number}","events_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/events","assignees_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/assignees{/user}","branches_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/branches{/branch}","tags_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/tags","blobs_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/refs{/sha}","trees_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/statuses/{sha}","languages_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/languages","stargazers_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/stargazers","contributors_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/contributors","subscribers_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/subscribers","subscription_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/subscription","commits_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/commits{/sha}","git_commits_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/commits{/sha}","comments_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/comments{/number}","issue_comment_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/comments{/number}","contents_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/contents/{+path}","compare_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/merges","archive_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/downloads","issues_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues{/number}","pulls_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls{/number}","milestones_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/milestones{/number}","notifications_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/labels{/name}","releases_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/releases{/id}","deployments_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/deployments","created_at":"2012-05-26T15:02:39Z","updated_at":"2018-04-09T12:51:04Z","pushed_at":"2018-04-09T12:53:49Z","git_url":"git://github.com/STEllAR-GROUP/hpx.git","ssh_url":"git@github.com:STEllAR-GROUP/hpx.git","clone_url":"https://github.com/STEllAR-GROUP/hpx.git","svn_url":"https://github.com/STEllAR-GROUP/hpx","homepage":"http://stellar-group.org/libraries/hpx","size":711875,"stargazers_count":868,"watchers_count":868,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":210,"mirror_url":null,"archived":false,"open_issues_count":163,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":210,"open_issues":163,"watchers":868,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/3277"},"html":{"href":"https://github.com/STEllAR-GROUP/hpx/pull/3277"},"issue":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/3277"},"comments":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/3277/comments"},"review_comments":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/3277/comments"},"review_comment":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/3277/commits"},"statuses":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/statuses/20ee5e4484c249ccfea080f7fcdfaf2ad5e62833"}},"author_association":"OWNER"}}
{"actor":{"display_login":"hkaiser"}}