{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/carto-vl/pulls/comments/202071137","pull_request_review_id":136695897,"id":202071137,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjA3MTEzNw==","diff_hunk":"@@ -0,0 +1,47 @@\n+import * as carto from '../../../../src';\n+import features from './features';\n+import mapboxgl from '@carto/mapbox-gl';\n+\n+describe('viewport features', () => {\n+    describe('given a list of features', () => {\n+        describe('when the viewport is in a predefined place (center/zoom)', () => {\n+            let map, source, viz, layer, div;\n+            beforeEach(() => {\n+                div = document.createElement('div');\n+                div.id = 'map';\n+                div.style.width = '500px';\n+                div.style.height = '500px';\n+                div.style.position = 'absolute';\n+                document.body.style.margin = '0';\n+                document.body.style.padding = '0';\n+                document.body.appendChild(div);\n+\n+                map = new mapboxgl.Map({\n+                    container: 'map',\n+                    style: 'https://basemaps.cartocdn.com/gl/dark-matter-gl-style/style.json',\n+                    center: [-6.754536880813703, 35.30378023840868],","path":"test/integration/user/test/featureInViewport.test.js","position":22,"original_position":22,"commit_id":"eb56228ff82b04863449758850f10aad82a1f148","original_commit_id":"eb56228ff82b04863449758850f10aad82a1f148","user":{"login":"davidmanzanares","id":1692175,"node_id":"MDQ6VXNlcjE2OTIxNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1692175?v=4","gravatar_id":"","url":"https://api.github.com/users/davidmanzanares","html_url":"https://github.com/davidmanzanares","followers_url":"https://api.github.com/users/davidmanzanares/followers","following_url":"https://api.github.com/users/davidmanzanares/following{/other_user}","gists_url":"https://api.github.com/users/davidmanzanares/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmanzanares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmanzanares/subscriptions","organizations_url":"https://api.github.com/users/davidmanzanares/orgs","repos_url":"https://api.github.com/users/davidmanzanares/repos","events_url":"https://api.github.com/users/davidmanzanares/events{/privacy}","received_events_url":"https://api.github.com/users/davidmanzanares/received_events","type":"User","site_admin":false},"body":"Which `.hmtl`?","created_at":"2018-07-12T15:09:03Z","updated_at":"2018-07-12T15:09:03Z","html_url":"https://github.com/CartoDB/carto-vl/pull/635#discussion_r202071137","pull_request_url":"https://api.github.com/repos/CartoDB/carto-vl/pulls/635","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/carto-vl/pulls/comments/202071137"},"html":{"href":"https://github.com/CartoDB/carto-vl/pull/635#discussion_r202071137"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/carto-vl/pulls/635"}},"in_reply_to_id":202063886},"pull_request":{"url":"https://api.github.com/repos/CartoDB/carto-vl/pulls/635","id":197963759,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3OTYzNzU5","html_url":"https://github.com/CartoDB/carto-vl/pull/635","diff_url":"https://github.com/CartoDB/carto-vl/pull/635.diff","patch_url":"https://github.com/CartoDB/carto-vl/pull/635.patch","issue_url":"https://api.github.com/repos/CartoDB/carto-vl/issues/635","number":635,"state":"open","locked":false,"title":"Viewport agg precision","user":{"login":"elenatorro","id":3824953,"node_id":"MDQ6VXNlcjM4MjQ5NTM=","avatar_url":"https://avatars2.githubusercontent.com/u/3824953?v=4","gravatar_id":"","url":"https://api.github.com/users/elenatorro","html_url":"https://github.com/elenatorro","followers_url":"https://api.github.com/users/elenatorro/followers","following_url":"https://api.github.com/users/elenatorro/following{/other_user}","gists_url":"https://api.github.com/users/elenatorro/gists{/gist_id}","starred_url":"https://api.github.com/users/elenatorro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elenatorro/subscriptions","organizations_url":"https://api.github.com/users/elenatorro/orgs","repos_url":"https://api.github.com/users/elenatorro/repos","events_url":"https://api.github.com/users/elenatorro/events{/privacy}","received_events_url":"https://api.github.com/users/elenatorro/received_events","type":"User","site_admin":false},"body":"Related issue: https://github.com/CartoDB/carto-vl/issues/536\r\n\r\nInstead of detecting collisions between bounding boxes, this is a PoC to use a SAT (*[Separation Axis Theorem](https://gamedevelopment.tutsplus.com/tutorials/collision-detection-using-the-separating-axis-theorem--gamedev-169)*) algorithm to detect collisions between geometries.\r\n\r\n* [x] Add collision algorithm\r\n* [x] Use it for lines and polygons\r\n* [x] Points (?)\r\n* [x] Testing: Add specs\r\n* [x] Testing: Add scenarios","created_at":"2018-06-28T09:08:03Z","updated_at":"2018-07-12T15:09:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00a095ac228fe1e995cc6d0f902fdc83b46f5263","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Jesus89","id":2227572,"node_id":"MDQ6VXNlcjIyMjc1NzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2227572?v=4","gravatar_id":"","url":"https://api.github.com/users/Jesus89","html_url":"https://github.com/Jesus89","followers_url":"https://api.github.com/users/Jesus89/followers","following_url":"https://api.github.com/users/Jesus89/following{/other_user}","gists_url":"https://api.github.com/users/Jesus89/gists{/gist_id}","starred_url":"https://api.github.com/users/Jesus89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jesus89/subscriptions","organizations_url":"https://api.github.com/users/Jesus89/orgs","repos_url":"https://api.github.com/users/Jesus89/repos","events_url":"https://api.github.com/users/Jesus89/events{/privacy}","received_events_url":"https://api.github.com/users/Jesus89/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/carto-vl/pulls/635/commits","review_comments_url":"https://api.github.com/repos/CartoDB/carto-vl/pulls/635/comments","review_comment_url":"https://api.github.com/repos/CartoDB/carto-vl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/carto-vl/issues/635/comments","statuses_url":"https://api.github.com/repos/CartoDB/carto-vl/statuses/eb56228ff82b04863449758850f10aad82a1f148","head":{"label":"CartoDB:536-viewport-agg-precision","ref":"536-viewport-agg-precision","sha":"eb56228ff82b04863449758850f10aad82a1f148","user":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":106824313,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY4MjQzMTM=","name":"carto-vl","full_name":"CartoDB/carto-vl","owner":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/carto-vl","description":"CARTO VL: a Javascript library to create vector-based visualizations","fork":false,"url":"https://api.github.com/repos/CartoDB/carto-vl","forks_url":"https://api.github.com/repos/CartoDB/carto-vl/forks","keys_url":"https://api.github.com/repos/CartoDB/carto-vl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/carto-vl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/carto-vl/teams","hooks_url":"https://api.github.com/repos/CartoDB/carto-vl/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/carto-vl/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/carto-vl/events","assignees_url":"https://api.github.com/repos/CartoDB/carto-vl/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/carto-vl/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/carto-vl/tags","blobs_url":"https://api.github.com/repos/CartoDB/carto-vl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/carto-vl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/carto-vl/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/carto-vl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/carto-vl/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/carto-vl/languages","stargazers_url":"https://api.github.com/repos/CartoDB/carto-vl/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/carto-vl/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/carto-vl/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/carto-vl/subscription","commits_url":"https://api.github.com/repos/CartoDB/carto-vl/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/carto-vl/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/carto-vl/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/carto-vl/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/carto-vl/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/carto-vl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/carto-vl/merges","archive_url":"https://api.github.com/repos/CartoDB/carto-vl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/carto-vl/downloads","issues_url":"https://api.github.com/repos/CartoDB/carto-vl/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/carto-vl/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/carto-vl/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/carto-vl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/carto-vl/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/carto-vl/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/carto-vl/deployments","created_at":"2017-10-13T12:56:39Z","updated_at":"2018-07-12T10:02:44Z","pushed_at":"2018-07-12T15:06:21Z","git_url":"git://github.com/CartoDB/carto-vl.git","ssh_url":"git@github.com:CartoDB/carto-vl.git","clone_url":"https://github.com/CartoDB/carto-vl.git","svn_url":"https://github.com/CartoDB/carto-vl","homepage":"","size":35657,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6,"open_issues":106,"watchers":38,"default_branch":"master"}},"base":{"label":"CartoDB:master","ref":"master","sha":"62cf8f652d7f1637e3fd565cec017bd6f534ae27","user":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":106824313,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY4MjQzMTM=","name":"carto-vl","full_name":"CartoDB/carto-vl","owner":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CartoDB/carto-vl","description":"CARTO VL: a Javascript library to create vector-based visualizations","fork":false,"url":"https://api.github.com/repos/CartoDB/carto-vl","forks_url":"https://api.github.com/repos/CartoDB/carto-vl/forks","keys_url":"https://api.github.com/repos/CartoDB/carto-vl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/carto-vl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/carto-vl/teams","hooks_url":"https://api.github.com/repos/CartoDB/carto-vl/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/carto-vl/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/carto-vl/events","assignees_url":"https://api.github.com/repos/CartoDB/carto-vl/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/carto-vl/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/carto-vl/tags","blobs_url":"https://api.github.com/repos/CartoDB/carto-vl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/carto-vl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/carto-vl/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/carto-vl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/carto-vl/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/carto-vl/languages","stargazers_url":"https://api.github.com/repos/CartoDB/carto-vl/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/carto-vl/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/carto-vl/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/carto-vl/subscription","commits_url":"https://api.github.com/repos/CartoDB/carto-vl/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/carto-vl/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/carto-vl/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/carto-vl/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/carto-vl/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/carto-vl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/carto-vl/merges","archive_url":"https://api.github.com/repos/CartoDB/carto-vl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/carto-vl/downloads","issues_url":"https://api.github.com/repos/CartoDB/carto-vl/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/carto-vl/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/carto-vl/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/carto-vl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/carto-vl/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/carto-vl/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/carto-vl/deployments","created_at":"2017-10-13T12:56:39Z","updated_at":"2018-07-12T10:02:44Z","pushed_at":"2018-07-12T15:06:21Z","git_url":"git://github.com/CartoDB/carto-vl.git","ssh_url":"git@github.com:CartoDB/carto-vl.git","clone_url":"https://github.com/CartoDB/carto-vl.git","svn_url":"https://github.com/CartoDB/carto-vl","homepage":"","size":35657,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":6,"open_issues":106,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/carto-vl/pulls/635"},"html":{"href":"https://github.com/CartoDB/carto-vl/pull/635"},"issue":{"href":"https://api.github.com/repos/CartoDB/carto-vl/issues/635"},"comments":{"href":"https://api.github.com/repos/CartoDB/carto-vl/issues/635/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/carto-vl/pulls/635/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/carto-vl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/carto-vl/pulls/635/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/carto-vl/statuses/eb56228ff82b04863449758850f10aad82a1f148"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"davidmanzanares"}}