{"action":"created","comment":{"url":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/comments/243952832","pull_request_review_id":187841956,"id":243952832,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzk1MjgzMg==","diff_hunk":"@@ -727,6 +726,52 @@ TEST_CASE(\"whitelist\", \"[herder]\")\n         REQUIRE(txSet->checkValid(*app));\n     }\n \n+    SECTION(\"all whitelisted\")\n+    {\n+\n+        DataValue value;\n+        value.resize(4);\n+        SignatureHint hint = SignatureUtils::getHint(accountWL.getPublicKey().ed25519());\n+        for (int n = 0; n < 4; n++)\n+        {\n+            value[n] = (unsigned char)hint[n];\n+        }\n+\n+        whitelist.manageData(KeyUtils::toStrKey(accountWL.getPublicKey()),\n+                             &value);\n+\n+        closeLedgerOn(*app, 2, 4, 11, 2018, txSet->mTransactions);","path":"src/herder/HerderTests.cpp","position":28,"original_position":28,"commit_id":"e2a046dcce1b398e392f7b2f73ea6e4ba72eb9a5","original_commit_id":"e2a046dcce1b398e392f7b2f73ea6e4ba72eb9a5","user":{"login":"avi-kik","id":33251112,"node_id":"MDQ6VXNlcjMzMjUxMTEy","avatar_url":"https://avatars0.githubusercontent.com/u/33251112?v=4","gravatar_id":"","url":"https://api.github.com/users/avi-kik","html_url":"https://github.com/avi-kik","followers_url":"https://api.github.com/users/avi-kik/followers","following_url":"https://api.github.com/users/avi-kik/following{/other_user}","gists_url":"https://api.github.com/users/avi-kik/gists{/gist_id}","starred_url":"https://api.github.com/users/avi-kik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avi-kik/subscriptions","organizations_url":"https://api.github.com/users/avi-kik/orgs","repos_url":"https://api.github.com/users/avi-kik/repos","events_url":"https://api.github.com/users/avi-kik/events{/privacy}","received_events_url":"https://api.github.com/users/avi-kik/received_events","type":"User","site_admin":false},"body":"More data:\r\n\r\nThe date is converted into a timestamp, with a hard-coded time of midnight.  This is why successive closings in the same test must be on different dates.\r\n\r\nIn addition, the genesis ledger for tests is hardcoded to 1/7/2014, which sets a lower bound for valid dates, but does not impose an upper bound.","created_at":"2018-12-26T07:17:04Z","updated_at":"2018-12-26T07:17:04Z","html_url":"https://github.com/kinecosystem/stellar-core/pull/13#discussion_r243952832","pull_request_url":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/13","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/comments/243952832"},"html":{"href":"https://github.com/kinecosystem/stellar-core/pull/13#discussion_r243952832"},"pull_request":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/13"}},"in_reply_to_id":243950021},"pull_request":{"url":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/13","id":240889134,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwODg5MTM0","html_url":"https://github.com/kinecosystem/stellar-core/pull/13","diff_url":"https://github.com/kinecosystem/stellar-core/pull/13.diff","patch_url":"https://github.com/kinecosystem/stellar-core/pull/13.patch","issue_url":"https://api.github.com/repos/kinecosystem/stellar-core/issues/13","number":13,"state":"open","locked":false,"title":"Fix to have whitelisted txs use all available capacity","user":{"login":"avi-kik","id":33251112,"node_id":"MDQ6VXNlcjMzMjUxMTEy","avatar_url":"https://avatars0.githubusercontent.com/u/33251112?v=4","gravatar_id":"","url":"https://api.github.com/users/avi-kik","html_url":"https://github.com/avi-kik","followers_url":"https://api.github.com/users/avi-kik/followers","following_url":"https://api.github.com/users/avi-kik/following{/other_user}","gists_url":"https://api.github.com/users/avi-kik/gists{/gist_id}","starred_url":"https://api.github.com/users/avi-kik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avi-kik/subscriptions","organizations_url":"https://api.github.com/users/avi-kik/orgs","repos_url":"https://api.github.com/users/avi-kik/repos","events_url":"https://api.github.com/users/avi-kik/events{/privacy}","received_events_url":"https://api.github.com/users/avi-kik/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-25T18:34:32Z","updated_at":"2018-12-26T07:17:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62986a576d856dc47e7321f8788a50a7f6d49b53","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gadisr","id":454859,"node_id":"MDQ6VXNlcjQ1NDg1OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/454859?v=4","gravatar_id":"","url":"https://api.github.com/users/gadisr","html_url":"https://github.com/gadisr","followers_url":"https://api.github.com/users/gadisr/followers","following_url":"https://api.github.com/users/gadisr/following{/other_user}","gists_url":"https://api.github.com/users/gadisr/gists{/gist_id}","starred_url":"https://api.github.com/users/gadisr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gadisr/subscriptions","organizations_url":"https://api.github.com/users/gadisr/orgs","repos_url":"https://api.github.com/users/gadisr/repos","events_url":"https://api.github.com/users/gadisr/events{/privacy}","received_events_url":"https://api.github.com/users/gadisr/received_events","type":"User","site_admin":false},{"login":"ordemri","id":7921320,"node_id":"MDQ6VXNlcjc5MjEzMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/7921320?v=4","gravatar_id":"","url":"https://api.github.com/users/ordemri","html_url":"https://github.com/ordemri","followers_url":"https://api.github.com/users/ordemri/followers","following_url":"https://api.github.com/users/ordemri/following{/other_user}","gists_url":"https://api.github.com/users/ordemri/gists{/gist_id}","starred_url":"https://api.github.com/users/ordemri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordemri/subscriptions","organizations_url":"https://api.github.com/users/ordemri/orgs","repos_url":"https://api.github.com/users/ordemri/repos","events_url":"https://api.github.com/users/ordemri/events{/privacy}","received_events_url":"https://api.github.com/users/ordemri/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/13/commits","review_comments_url":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/13/comments","review_comment_url":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kinecosystem/stellar-core/issues/13/comments","statuses_url":"https://api.github.com/repos/kinecosystem/stellar-core/statuses/e2a046dcce1b398e392f7b2f73ea6e4ba72eb9a5","head":{"label":"kinecosystem:reserve_capacity_fix","ref":"reserve_capacity_fix","sha":"e2a046dcce1b398e392f7b2f73ea6e4ba72eb9a5","user":{"login":"kinecosystem","id":28860603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODYwNjAz","avatar_url":"https://avatars2.githubusercontent.com/u/28860603?v=4","gravatar_id":"","url":"https://api.github.com/users/kinecosystem","html_url":"https://github.com/kinecosystem","followers_url":"https://api.github.com/users/kinecosystem/followers","following_url":"https://api.github.com/users/kinecosystem/following{/other_user}","gists_url":"https://api.github.com/users/kinecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/kinecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinecosystem/subscriptions","organizations_url":"https://api.github.com/users/kinecosystem/orgs","repos_url":"https://api.github.com/users/kinecosystem/repos","events_url":"https://api.github.com/users/kinecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/kinecosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":143736474,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3MzY0NzQ=","name":"stellar-core","full_name":"kinecosystem/stellar-core","private":false,"owner":{"login":"kinecosystem","id":28860603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODYwNjAz","avatar_url":"https://avatars2.githubusercontent.com/u/28860603?v=4","gravatar_id":"","url":"https://api.github.com/users/kinecosystem","html_url":"https://github.com/kinecosystem","followers_url":"https://api.github.com/users/kinecosystem/followers","following_url":"https://api.github.com/users/kinecosystem/following{/other_user}","gists_url":"https://api.github.com/users/kinecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/kinecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinecosystem/subscriptions","organizations_url":"https://api.github.com/users/kinecosystem/orgs","repos_url":"https://api.github.com/users/kinecosystem/repos","events_url":"https://api.github.com/users/kinecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/kinecosystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kinecosystem/stellar-core","description":"stellar-core is the backbone of the Stellar network. It maintains a local copy of the ledger, communicating and staying in sync with other instances of stellar-core on the network. Optionally, stellar-core can store historical records of the ledger and participate in consensus.","fork":true,"url":"https://api.github.com/repos/kinecosystem/stellar-core","forks_url":"https://api.github.com/repos/kinecosystem/stellar-core/forks","keys_url":"https://api.github.com/repos/kinecosystem/stellar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinecosystem/stellar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinecosystem/stellar-core/teams","hooks_url":"https://api.github.com/repos/kinecosystem/stellar-core/hooks","issue_events_url":"https://api.github.com/repos/kinecosystem/stellar-core/issues/events{/number}","events_url":"https://api.github.com/repos/kinecosystem/stellar-core/events","assignees_url":"https://api.github.com/repos/kinecosystem/stellar-core/assignees{/user}","branches_url":"https://api.github.com/repos/kinecosystem/stellar-core/branches{/branch}","tags_url":"https://api.github.com/repos/kinecosystem/stellar-core/tags","blobs_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinecosystem/stellar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/kinecosystem/stellar-core/languages","stargazers_url":"https://api.github.com/repos/kinecosystem/stellar-core/stargazers","contributors_url":"https://api.github.com/repos/kinecosystem/stellar-core/contributors","subscribers_url":"https://api.github.com/repos/kinecosystem/stellar-core/subscribers","subscription_url":"https://api.github.com/repos/kinecosystem/stellar-core/subscription","commits_url":"https://api.github.com/repos/kinecosystem/stellar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinecosystem/stellar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinecosystem/stellar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinecosystem/stellar-core/contents/{+path}","compare_url":"https://api.github.com/repos/kinecosystem/stellar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinecosystem/stellar-core/merges","archive_url":"https://api.github.com/repos/kinecosystem/stellar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinecosystem/stellar-core/downloads","issues_url":"https://api.github.com/repos/kinecosystem/stellar-core/issues{/number}","pulls_url":"https://api.github.com/repos/kinecosystem/stellar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/kinecosystem/stellar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/kinecosystem/stellar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinecosystem/stellar-core/labels{/name}","releases_url":"https://api.github.com/repos/kinecosystem/stellar-core/releases{/id}","deployments_url":"https://api.github.com/repos/kinecosystem/stellar-core/deployments","created_at":"2018-08-06T14:01:00Z","updated_at":"2018-12-25T12:10:39Z","pushed_at":"2018-12-26T02:48:21Z","git_url":"git://github.com/kinecosystem/stellar-core.git","ssh_url":"git@github.com:kinecosystem/stellar-core.git","clone_url":"https://github.com/kinecosystem/stellar-core.git","svn_url":"https://github.com/kinecosystem/stellar-core","homepage":"","size":15676,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":1,"watchers":0,"default_branch":"kinecosystem/master"}},"base":{"label":"kinecosystem:kinecosystem/master","ref":"kinecosystem/master","sha":"e8f61457f7e61b33cf1beb0a337be94011a88682","user":{"login":"kinecosystem","id":28860603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODYwNjAz","avatar_url":"https://avatars2.githubusercontent.com/u/28860603?v=4","gravatar_id":"","url":"https://api.github.com/users/kinecosystem","html_url":"https://github.com/kinecosystem","followers_url":"https://api.github.com/users/kinecosystem/followers","following_url":"https://api.github.com/users/kinecosystem/following{/other_user}","gists_url":"https://api.github.com/users/kinecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/kinecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinecosystem/subscriptions","organizations_url":"https://api.github.com/users/kinecosystem/orgs","repos_url":"https://api.github.com/users/kinecosystem/repos","events_url":"https://api.github.com/users/kinecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/kinecosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":143736474,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3MzY0NzQ=","name":"stellar-core","full_name":"kinecosystem/stellar-core","private":false,"owner":{"login":"kinecosystem","id":28860603,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODYwNjAz","avatar_url":"https://avatars2.githubusercontent.com/u/28860603?v=4","gravatar_id":"","url":"https://api.github.com/users/kinecosystem","html_url":"https://github.com/kinecosystem","followers_url":"https://api.github.com/users/kinecosystem/followers","following_url":"https://api.github.com/users/kinecosystem/following{/other_user}","gists_url":"https://api.github.com/users/kinecosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/kinecosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinecosystem/subscriptions","organizations_url":"https://api.github.com/users/kinecosystem/orgs","repos_url":"https://api.github.com/users/kinecosystem/repos","events_url":"https://api.github.com/users/kinecosystem/events{/privacy}","received_events_url":"https://api.github.com/users/kinecosystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kinecosystem/stellar-core","description":"stellar-core is the backbone of the Stellar network. It maintains a local copy of the ledger, communicating and staying in sync with other instances of stellar-core on the network. Optionally, stellar-core can store historical records of the ledger and participate in consensus.","fork":true,"url":"https://api.github.com/repos/kinecosystem/stellar-core","forks_url":"https://api.github.com/repos/kinecosystem/stellar-core/forks","keys_url":"https://api.github.com/repos/kinecosystem/stellar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinecosystem/stellar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinecosystem/stellar-core/teams","hooks_url":"https://api.github.com/repos/kinecosystem/stellar-core/hooks","issue_events_url":"https://api.github.com/repos/kinecosystem/stellar-core/issues/events{/number}","events_url":"https://api.github.com/repos/kinecosystem/stellar-core/events","assignees_url":"https://api.github.com/repos/kinecosystem/stellar-core/assignees{/user}","branches_url":"https://api.github.com/repos/kinecosystem/stellar-core/branches{/branch}","tags_url":"https://api.github.com/repos/kinecosystem/stellar-core/tags","blobs_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinecosystem/stellar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/kinecosystem/stellar-core/languages","stargazers_url":"https://api.github.com/repos/kinecosystem/stellar-core/stargazers","contributors_url":"https://api.github.com/repos/kinecosystem/stellar-core/contributors","subscribers_url":"https://api.github.com/repos/kinecosystem/stellar-core/subscribers","subscription_url":"https://api.github.com/repos/kinecosystem/stellar-core/subscription","commits_url":"https://api.github.com/repos/kinecosystem/stellar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinecosystem/stellar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinecosystem/stellar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinecosystem/stellar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinecosystem/stellar-core/contents/{+path}","compare_url":"https://api.github.com/repos/kinecosystem/stellar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinecosystem/stellar-core/merges","archive_url":"https://api.github.com/repos/kinecosystem/stellar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinecosystem/stellar-core/downloads","issues_url":"https://api.github.com/repos/kinecosystem/stellar-core/issues{/number}","pulls_url":"https://api.github.com/repos/kinecosystem/stellar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/kinecosystem/stellar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/kinecosystem/stellar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinecosystem/stellar-core/labels{/name}","releases_url":"https://api.github.com/repos/kinecosystem/stellar-core/releases{/id}","deployments_url":"https://api.github.com/repos/kinecosystem/stellar-core/deployments","created_at":"2018-08-06T14:01:00Z","updated_at":"2018-12-25T12:10:39Z","pushed_at":"2018-12-26T02:48:21Z","git_url":"git://github.com/kinecosystem/stellar-core.git","ssh_url":"git@github.com:kinecosystem/stellar-core.git","clone_url":"https://github.com/kinecosystem/stellar-core.git","svn_url":"https://github.com/kinecosystem/stellar-core","homepage":"","size":15676,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":1,"watchers":0,"default_branch":"kinecosystem/master"}},"_links":{"self":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/13"},"html":{"href":"https://github.com/kinecosystem/stellar-core/pull/13"},"issue":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/issues/13"},"comments":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/kinecosystem/stellar-core/statuses/e2a046dcce1b398e392f7b2f73ea6e4ba72eb9a5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"avi-kik"}}