{"action":"created","comment":{"url":"https://api.github.com/repos/OPM/opm-common/pulls/comments/183421660","pull_request_review_id":114416311,"id":183421660,"diff_hunk":"@@ -484,8 +484,13 @@ namespace Opm {\n                 WellCommon::StatusFromString(record.getItem(\"STATUS\").getTrimmedString(0));\n \n             auto wells = getWells(wellNamePattern);\n+            if (wells.empty()) {","path":"src/opm/parser/eclipse/EclipseState/Schedule/Schedule.cpp","position":35,"original_position":26,"commit_id":"4a5316ceec0c7fecd3be5518263cdaca9c88b8af","original_commit_id":"4a5316ceec0c7fecd3be5518263cdaca9c88b8af","user":{"login":"joakim-hove","id":1321665,"avatar_url":"https://avatars3.githubusercontent.com/u/1321665?v=4","gravatar_id":"","url":"https://api.github.com/users/joakim-hove","html_url":"https://github.com/joakim-hove","followers_url":"https://api.github.com/users/joakim-hove/followers","following_url":"https://api.github.com/users/joakim-hove/following{/other_user}","gists_url":"https://api.github.com/users/joakim-hove/gists{/gist_id}","starred_url":"https://api.github.com/users/joakim-hove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakim-hove/subscriptions","organizations_url":"https://api.github.com/users/joakim-hove/orgs","repos_url":"https://api.github.com/users/joakim-hove/repos","events_url":"https://api.github.com/users/joakim-hove/events{/privacy}","received_events_url":"https://api.github.com/users/joakim-hove/received_events","type":"User","site_admin":false},"body":"For simplicity I would say the handling of empty well sets should be in the `getWells( )` method, otherwise you have to duplicate the `if (wells.empty()) { .... }` code block many places.\r\n","created_at":"2018-04-23T14:45:52Z","updated_at":"2018-04-23T14:45:52Z","html_url":"https://github.com/OPM/opm-common/pull/387#discussion_r183421660","pull_request_url":"https://api.github.com/repos/OPM/opm-common/pulls/387","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-common/pulls/comments/183421660"},"html":{"href":"https://github.com/OPM/opm-common/pull/387#discussion_r183421660"},"pull_request":{"href":"https://api.github.com/repos/OPM/opm-common/pulls/387"}}},"pull_request":{"url":"https://api.github.com/repos/OPM/opm-common/pulls/387","id":183409533,"html_url":"https://github.com/OPM/opm-common/pull/387","diff_url":"https://github.com/OPM/opm-common/pull/387.diff","patch_url":"https://github.com/OPM/opm-common/pull/387.patch","issue_url":"https://api.github.com/repos/OPM/opm-common/issues/387","number":387,"state":"open","locked":false,"title":"[WIP] Invalid wells context","user":{"login":"lars-petter-hauge","id":26920711,"avatar_url":"https://avatars3.githubusercontent.com/u/26920711?v=4","gravatar_id":"","url":"https://api.github.com/users/lars-petter-hauge","html_url":"https://github.com/lars-petter-hauge","followers_url":"https://api.github.com/users/lars-petter-hauge/followers","following_url":"https://api.github.com/users/lars-petter-hauge/following{/other_user}","gists_url":"https://api.github.com/users/lars-petter-hauge/gists{/gist_id}","starred_url":"https://api.github.com/users/lars-petter-hauge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lars-petter-hauge/subscriptions","organizations_url":"https://api.github.com/users/lars-petter-hauge/orgs","repos_url":"https://api.github.com/users/lars-petter-hauge/repos","events_url":"https://api.github.com/users/lars-petter-hauge/events{/privacy}","received_events_url":"https://api.github.com/users/lars-petter-hauge/received_events","type":"User","site_admin":false},"body":"This PR relates to https://github.com/OPM/opm-common/issues/361\r\n\r\nHandle invalid wellpatterns for COMPDAT/WCONPROD.\r\n\r\nGiven a deck (either COMPDAT or WCONPROD with wellpattern that does not match any WELSPECS):\r\n\r\n```\r\nWELSPECS\r\n  'PROD' 'G1'  10 10 8400 'OIL' /\r\n/\r\nCOMPDAT\r\n  'SOMETHINGELSE' 10 10 3 3 'OPEN' 1* 1* 0.5 /\r\n/\r\nWCONPROD\r\n  'SOMETHINGELSE' 'OPEN' 'ORAT' 20000 4* 1000 /\r\n /\r\n```\r\n\r\nOPM will now by default abort and inform the user that no well match\r\n\"SOMETHINGELSE\".\r\n\r\n-------------------------------\r\nI'll add a few more to this ( like WCONINJE..). I also need to make sure I don't make it too strict (e.g. for cases that could default..)","created_at":"2018-04-23T11:53:21Z","updated_at":"2018-04-23T14:45:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98d462d51d528d45a50ab450c435610940f231db","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OPM/opm-common/pulls/387/commits","review_comments_url":"https://api.github.com/repos/OPM/opm-common/pulls/387/comments","review_comment_url":"https://api.github.com/repos/OPM/opm-common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OPM/opm-common/issues/387/comments","statuses_url":"https://api.github.com/repos/OPM/opm-common/statuses/4a5316ceec0c7fecd3be5518263cdaca9c88b8af","head":{"label":"lars-petter-hauge:invalid_wells_context","ref":"invalid_wells_context","sha":"4a5316ceec0c7fecd3be5518263cdaca9c88b8af","user":{"login":"lars-petter-hauge","id":26920711,"avatar_url":"https://avatars3.githubusercontent.com/u/26920711?v=4","gravatar_id":"","url":"https://api.github.com/users/lars-petter-hauge","html_url":"https://github.com/lars-petter-hauge","followers_url":"https://api.github.com/users/lars-petter-hauge/followers","following_url":"https://api.github.com/users/lars-petter-hauge/following{/other_user}","gists_url":"https://api.github.com/users/lars-petter-hauge/gists{/gist_id}","starred_url":"https://api.github.com/users/lars-petter-hauge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lars-petter-hauge/subscriptions","organizations_url":"https://api.github.com/users/lars-petter-hauge/orgs","repos_url":"https://api.github.com/users/lars-petter-hauge/repos","events_url":"https://api.github.com/users/lars-petter-hauge/events{/privacy}","received_events_url":"https://api.github.com/users/lars-petter-hauge/received_events","type":"User","site_admin":false},"repo":{"id":124199105,"name":"opm-common","full_name":"lars-petter-hauge/opm-common","owner":{"login":"lars-petter-hauge","id":26920711,"avatar_url":"https://avatars3.githubusercontent.com/u/26920711?v=4","gravatar_id":"","url":"https://api.github.com/users/lars-petter-hauge","html_url":"https://github.com/lars-petter-hauge","followers_url":"https://api.github.com/users/lars-petter-hauge/followers","following_url":"https://api.github.com/users/lars-petter-hauge/following{/other_user}","gists_url":"https://api.github.com/users/lars-petter-hauge/gists{/gist_id}","starred_url":"https://api.github.com/users/lars-petter-hauge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lars-petter-hauge/subscriptions","organizations_url":"https://api.github.com/users/lars-petter-hauge/orgs","repos_url":"https://api.github.com/users/lars-petter-hauge/repos","events_url":"https://api.github.com/users/lars-petter-hauge/events{/privacy}","received_events_url":"https://api.github.com/users/lars-petter-hauge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lars-petter-hauge/opm-common","description":"Common components for OPM, in particular build system (cmake).","fork":true,"url":"https://api.github.com/repos/lars-petter-hauge/opm-common","forks_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/forks","keys_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/teams","hooks_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/hooks","issue_events_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/issues/events{/number}","events_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/events","assignees_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/assignees{/user}","branches_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/branches{/branch}","tags_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/tags","blobs_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/statuses/{sha}","languages_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/languages","stargazers_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/stargazers","contributors_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/contributors","subscribers_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/subscribers","subscription_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/subscription","commits_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/contents/{+path}","compare_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/merges","archive_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/downloads","issues_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/issues{/number}","pulls_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/pulls{/number}","milestones_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/milestones{/number}","notifications_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/labels{/name}","releases_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/releases{/id}","deployments_url":"https://api.github.com/repos/lars-petter-hauge/opm-common/deployments","created_at":"2018-03-07T07:49:11Z","updated_at":"2018-03-07T07:49:14Z","pushed_at":"2018-04-23T11:46:40Z","git_url":"git://github.com/lars-petter-hauge/opm-common.git","ssh_url":"git@github.com:lars-petter-hauge/opm-common.git","clone_url":"https://github.com/lars-petter-hauge/opm-common.git","svn_url":"https://github.com/lars-petter-hauge/opm-common","homepage":"http://www.opm-project.org","size":7647,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OPM:master","ref":"master","sha":"122158d71389f5b66508ed1238c00203fb78d7b4","user":{"login":"OPM","id":1827197,"avatar_url":"https://avatars0.githubusercontent.com/u/1827197?v=4","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"repo":{"id":32443143,"name":"opm-common","full_name":"OPM/opm-common","owner":{"login":"OPM","id":1827197,"avatar_url":"https://avatars0.githubusercontent.com/u/1827197?v=4","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OPM/opm-common","description":"Common components for OPM, in particular build system (cmake).","fork":false,"url":"https://api.github.com/repos/OPM/opm-common","forks_url":"https://api.github.com/repos/OPM/opm-common/forks","keys_url":"https://api.github.com/repos/OPM/opm-common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPM/opm-common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPM/opm-common/teams","hooks_url":"https://api.github.com/repos/OPM/opm-common/hooks","issue_events_url":"https://api.github.com/repos/OPM/opm-common/issues/events{/number}","events_url":"https://api.github.com/repos/OPM/opm-common/events","assignees_url":"https://api.github.com/repos/OPM/opm-common/assignees{/user}","branches_url":"https://api.github.com/repos/OPM/opm-common/branches{/branch}","tags_url":"https://api.github.com/repos/OPM/opm-common/tags","blobs_url":"https://api.github.com/repos/OPM/opm-common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPM/opm-common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPM/opm-common/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPM/opm-common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPM/opm-common/statuses/{sha}","languages_url":"https://api.github.com/repos/OPM/opm-common/languages","stargazers_url":"https://api.github.com/repos/OPM/opm-common/stargazers","contributors_url":"https://api.github.com/repos/OPM/opm-common/contributors","subscribers_url":"https://api.github.com/repos/OPM/opm-common/subscribers","subscription_url":"https://api.github.com/repos/OPM/opm-common/subscription","commits_url":"https://api.github.com/repos/OPM/opm-common/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPM/opm-common/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPM/opm-common/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPM/opm-common/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPM/opm-common/contents/{+path}","compare_url":"https://api.github.com/repos/OPM/opm-common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPM/opm-common/merges","archive_url":"https://api.github.com/repos/OPM/opm-common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPM/opm-common/downloads","issues_url":"https://api.github.com/repos/OPM/opm-common/issues{/number}","pulls_url":"https://api.github.com/repos/OPM/opm-common/pulls{/number}","milestones_url":"https://api.github.com/repos/OPM/opm-common/milestones{/number}","notifications_url":"https://api.github.com/repos/OPM/opm-common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPM/opm-common/labels{/name}","releases_url":"https://api.github.com/repos/OPM/opm-common/releases{/id}","deployments_url":"https://api.github.com/repos/OPM/opm-common/deployments","created_at":"2015-03-18T06:59:50Z","updated_at":"2018-04-23T14:30:54Z","pushed_at":"2018-04-23T14:30:52Z","git_url":"git://github.com/OPM/opm-common.git","ssh_url":"git@github.com:OPM/opm-common.git","clone_url":"https://github.com/OPM/opm-common.git","svn_url":"https://github.com/OPM/opm-common","homepage":"http://www.opm-project.org","size":7641,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":41,"open_issues":18,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-common/pulls/387"},"html":{"href":"https://github.com/OPM/opm-common/pull/387"},"issue":{"href":"https://api.github.com/repos/OPM/opm-common/issues/387"},"comments":{"href":"https://api.github.com/repos/OPM/opm-common/issues/387/comments"},"review_comments":{"href":"https://api.github.com/repos/OPM/opm-common/pulls/387/comments"},"review_comment":{"href":"https://api.github.com/repos/OPM/opm-common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OPM/opm-common/pulls/387/commits"},"statuses":{"href":"https://api.github.com/repos/OPM/opm-common/statuses/4a5316ceec0c7fecd3be5518263cdaca9c88b8af"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"joakim-hove"}}