{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/3937","repository_url":"https://api.github.com/repos/codice/ddf","labels_url":"https://api.github.com/repos/codice/ddf/issues/3937/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3937/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/3937/events","html_url":"https://github.com/codice/ddf/pull/3937","id":374111301,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODg3MjU0","number":3937,"title":"DDF-4270 Remove Workspace Templates","user":{"login":"willwill96","id":10997562,"node_id":"MDQ6VXNlcjEwOTk3NTYy","avatar_url":"https://avatars1.githubusercontent.com/u/10997562?v=4","gravatar_id":"","url":"https://api.github.com/users/willwill96","html_url":"https://github.com/willwill96","followers_url":"https://api.github.com/users/willwill96/followers","following_url":"https://api.github.com/users/willwill96/following{/other_user}","gists_url":"https://api.github.com/users/willwill96/gists{/gist_id}","starred_url":"https://api.github.com/users/willwill96/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willwill96/subscriptions","organizations_url":"https://api.github.com/users/willwill96/orgs","repos_url":"https://api.github.com/users/willwill96/repos","events_url":"https://api.github.com/users/willwill96/events{/privacy}","received_events_url":"https://api.github.com/users/willwill96/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"djblue","id":1986211,"node_id":"MDQ6VXNlcjE5ODYyMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1986211?v=4","gravatar_id":"","url":"https://api.github.com/users/djblue","html_url":"https://github.com/djblue","followers_url":"https://api.github.com/users/djblue/followers","following_url":"https://api.github.com/users/djblue/following{/other_user}","gists_url":"https://api.github.com/users/djblue/gists{/gist_id}","starred_url":"https://api.github.com/users/djblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djblue/subscriptions","organizations_url":"https://api.github.com/users/djblue/orgs","repos_url":"https://api.github.com/users/djblue/repos","events_url":"https://api.github.com/users/djblue/events{/privacy}","received_events_url":"https://api.github.com/users/djblue/received_events","type":"User","site_admin":false},"assignees":[{"login":"djblue","id":1986211,"node_id":"MDQ6VXNlcjE5ODYyMTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1986211?v=4","gravatar_id":"","url":"https://api.github.com/users/djblue","html_url":"https://github.com/djblue","followers_url":"https://api.github.com/users/djblue/followers","following_url":"https://api.github.com/users/djblue/following{/other_user}","gists_url":"https://api.github.com/users/djblue/gists{/gist_id}","starred_url":"https://api.github.com/users/djblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djblue/subscriptions","organizations_url":"https://api.github.com/users/djblue/orgs","repos_url":"https://api.github.com/users/djblue/repos","events_url":"https://api.github.com/users/djblue/events{/privacy}","received_events_url":"https://api.github.com/users/djblue/received_events","type":"User","site_admin":false},{"login":"bdeining","id":6551038,"node_id":"MDQ6VXNlcjY1NTEwMzg=","avatar_url":"https://avatars2.githubusercontent.com/u/6551038?v=4","gravatar_id":"","url":"https://api.github.com/users/bdeining","html_url":"https://github.com/bdeining","followers_url":"https://api.github.com/users/bdeining/followers","following_url":"https://api.github.com/users/bdeining/following{/other_user}","gists_url":"https://api.github.com/users/bdeining/gists{/gist_id}","starred_url":"https://api.github.com/users/bdeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdeining/subscriptions","organizations_url":"https://api.github.com/users/bdeining/orgs","repos_url":"https://api.github.com/users/bdeining/repos","events_url":"https://api.github.com/users/bdeining/events{/privacy}","received_events_url":"https://api.github.com/users/bdeining/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2018-10-25T20:07:53Z","updated_at":"2018-10-30T23:21:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3937","html_url":"https://github.com/codice/ddf/pull/3937","diff_url":"https://github.com/codice/ddf/pull/3937.diff","patch_url":"https://github.com/codice/ddf/pull/3937.patch"},"body":"#### What does this PR do?\r\n\t- Removes workspace templates from DDF workspace home page\r\n\t- Adds `Add New Workspace` button to allow creation of a blank workspace\r\n#### Who is reviewing it? \r\n@djblue \r\n@rymach \r\n@GabrielFabian \r\n@gjvera \r\n\r\n#### Select relevant component teams: \r\n<!--\r\n@codice/build \r\n@codice/continuous-integration \r\n@codice/core-apis \r\n@codice/data \r\n@codice/docs \r\n@codice/io \r\n@codice/ogc \r\n@codice/security \r\n@codice/solr \r\n@codice/test \r\n@codice/ui \r\n@codice/website \r\n-->\r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n@bdeining\r\n@djblue\r\n#### How should this be tested?\r\n1. Build and install\r\n2. Navigate to `Workspaces` home page\r\n3. Ensure that there is no dropdown in the top right for workspace templates\r\n4. Create a Blank Workspace by clicking the `New Workspace` button\r\n\t- Ensure that the workspace does not run a search immediately\r\n5. Mess with theme settings to ensure correct scaling of the `Create Workspace` area\r\n6. Spot test workspace functionality and view logs for any potential regressions\r\n\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\n[DDF-4270](https://codice.atlassian.net/browse/DDF-4270)\r\n#### Screenshots\r\nBefore:\r\n![image](https://user-images.githubusercontent.com/10997562/47527174-1922bd80-d85f-11e8-8b03-cf920c66aa64.png)\r\n\r\nAfter:\r\n![image](https://user-images.githubusercontent.com/10997562/47665701-4fb24e00-db67-11e8-94b5-2bc3532d35d7.png)\r\n\r\n\r\n\r\n\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/434506102","html_url":"https://github.com/codice/ddf/pull/3937#issuecomment-434506102","issue_url":"https://api.github.com/repos/codice/ddf/issues/3937","id":434506102,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDUwNjEwMg==","user":{"login":"GabrielFabian","id":12813760,"node_id":"MDQ6VXNlcjEyODEzNzYw","avatar_url":"https://avatars1.githubusercontent.com/u/12813760?v=4","gravatar_id":"","url":"https://api.github.com/users/GabrielFabian","html_url":"https://github.com/GabrielFabian","followers_url":"https://api.github.com/users/GabrielFabian/followers","following_url":"https://api.github.com/users/GabrielFabian/following{/other_user}","gists_url":"https://api.github.com/users/GabrielFabian/gists{/gist_id}","starred_url":"https://api.github.com/users/GabrielFabian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabrielFabian/subscriptions","organizations_url":"https://api.github.com/users/GabrielFabian/orgs","repos_url":"https://api.github.com/users/GabrielFabian/repos","events_url":"https://api.github.com/users/GabrielFabian/events{/privacy}","received_events_url":"https://api.github.com/users/GabrielFabian/received_events","type":"User","site_admin":false},"created_at":"2018-10-30T23:21:25Z","updated_at":"2018-10-30T23:21:25Z","author_association":"CONTRIBUTOR","body":"🎉 Hero build successful! 🎉 \r\n\r\n- verified new button\r\n- verified functionality of creating a new workspace\r\n- verified when creating new workspace, a search is not run by default\r\n- verified no regressions\r\n- logged in as admin and as guest\r\n\r\nLGTM!\r\n\r\n<img width=\"1680\" alt=\"screen shot 2018-10-30 at 5 18 20 pm\" src=\"https://user-images.githubusercontent.com/12813760/47756550-32b17400-dc68-11e8-9013-c372c31f1c4f.png\">\r\n<img width=\"1680\" alt=\"screen shot 2018-10-30 at 5 18 56 pm\" src=\"https://user-images.githubusercontent.com/12813760/47756551-32b17400-dc68-11e8-9563-baa80a1fd776.png\">\r\n"}}
{"actor":{"display_login":"GabrielFabian"}}