{"action":"created","comment":{"url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments/213845945","pull_request_review_id":150768592,"id":213845945,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzg0NTk0NQ==","diff_hunk":"@@ -29,7 +29,8 @@\n     margin-left: -1px;\n   }\n   /* stylelint-enable */\n-  .pf-m-invalid {\n+\n+  .pf-c-form-control[aria-invalid=\"true\"] {\n     margin-left: 0;\n \n     &:not(:last-child) {","path":"src/patternfly/components/InputGroup/styles.scss","position":9,"original_position":9,"commit_id":"ee55b8246b5faa06a6bf646c05eef1be7b355c5e","original_commit_id":"ee55b8246b5faa06a6bf646c05eef1be7b355c5e","user":{"login":"michael-coker","id":35148959,"node_id":"MDQ6VXNlcjM1MTQ4OTU5","avatar_url":"https://avatars0.githubusercontent.com/u/35148959?v=4","gravatar_id":"","url":"https://api.github.com/users/michael-coker","html_url":"https://github.com/michael-coker","followers_url":"https://api.github.com/users/michael-coker/followers","following_url":"https://api.github.com/users/michael-coker/following{/other_user}","gists_url":"https://api.github.com/users/michael-coker/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-coker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-coker/subscriptions","organizations_url":"https://api.github.com/users/michael-coker/orgs","repos_url":"https://api.github.com/users/michael-coker/repos","events_url":"https://api.github.com/users/michael-coker/events{/privacy}","received_events_url":"https://api.github.com/users/michael-coker/received_events","type":"User","site_admin":false},"body":"same here, I think it looks better without the margin and with `position: relative` (to give it a z-index) so the red border is on top on the right side.","created_at":"2018-08-29T21:48:25Z","updated_at":"2018-08-29T21:48:26Z","html_url":"https://github.com/patternfly/patternfly-next/pull/659#discussion_r213845945","pull_request_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/659","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments/213845945"},"html":{"href":"https://github.com/patternfly/patternfly-next/pull/659#discussion_r213845945"},"pull_request":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/659"}}},"pull_request":{"url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/659","id":211711434,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNzExNDM0","html_url":"https://github.com/patternfly/patternfly-next/pull/659","diff_url":"https://github.com/patternfly/patternfly-next/pull/659.diff","patch_url":"https://github.com/patternfly/patternfly-next/pull/659.patch","issue_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/659","number":659,"state":"open","locked":false,"title":"Feat(forms):a11y updates","user":{"login":"matthewcarleton","id":287880,"node_id":"MDQ6VXNlcjI4Nzg4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/287880?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewcarleton","html_url":"https://github.com/matthewcarleton","followers_url":"https://api.github.com/users/matthewcarleton/followers","following_url":"https://api.github.com/users/matthewcarleton/following{/other_user}","gists_url":"https://api.github.com/users/matthewcarleton/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewcarleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewcarleton/subscriptions","organizations_url":"https://api.github.com/users/matthewcarleton/orgs","repos_url":"https://api.github.com/users/matthewcarleton/repos","events_url":"https://api.github.com/users/matthewcarleton/events{/privacy}","received_events_url":"https://api.github.com/users/matthewcarleton/received_events","type":"User","site_admin":false},"body":"Closes #587 \r\n\r\nThese are changes that were required after doing further testing with voiceover. It also includes changes that @mattnolting requested in #587. I've kept the nested conditional, although looking at it now I'm not sure what it is doing exactly.\r\n\r\nThings to note:\r\n\r\n- After moving to styling `aria-invalid=\"true\"` instead of `:invalid` I'm wondering if we need the `pf-m-invalid` at all.\r\n- I've added the modifier `.pf-m-inactive` to handle inactive helper text. \r\n- I've added notes for `aria-errormessage` and `aria-invalid=true` in the form accessibility docs. Not sure if this is how we want to document the requirements of Javascript.\r\n","created_at":"2018-08-29T10:57:12Z","updated_at":"2018-08-29T21:48:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65c5388af3e248032f63813908572e3c6d079847","assignee":null,"assignees":[],"requested_reviewers":[{"login":"srambach","id":19825616,"node_id":"MDQ6VXNlcjE5ODI1NjE2","avatar_url":"https://avatars3.githubusercontent.com/u/19825616?v=4","gravatar_id":"","url":"https://api.github.com/users/srambach","html_url":"https://github.com/srambach","followers_url":"https://api.github.com/users/srambach/followers","following_url":"https://api.github.com/users/srambach/following{/other_user}","gists_url":"https://api.github.com/users/srambach/gists{/gist_id}","starred_url":"https://api.github.com/users/srambach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srambach/subscriptions","organizations_url":"https://api.github.com/users/srambach/orgs","repos_url":"https://api.github.com/users/srambach/repos","events_url":"https://api.github.com/users/srambach/events{/privacy}","received_events_url":"https://api.github.com/users/srambach/received_events","type":"User","site_admin":false},{"login":"jgiardino","id":21063328,"node_id":"MDQ6VXNlcjIxMDYzMzI4","avatar_url":"https://avatars1.githubusercontent.com/u/21063328?v=4","gravatar_id":"","url":"https://api.github.com/users/jgiardino","html_url":"https://github.com/jgiardino","followers_url":"https://api.github.com/users/jgiardino/followers","following_url":"https://api.github.com/users/jgiardino/following{/other_user}","gists_url":"https://api.github.com/users/jgiardino/gists{/gist_id}","starred_url":"https://api.github.com/users/jgiardino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgiardino/subscriptions","organizations_url":"https://api.github.com/users/jgiardino/orgs","repos_url":"https://api.github.com/users/jgiardino/repos","events_url":"https://api.github.com/users/jgiardino/events{/privacy}","received_events_url":"https://api.github.com/users/jgiardino/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/659/commits","review_comments_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/659/comments","review_comment_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/659/comments","statuses_url":"https://api.github.com/repos/patternfly/patternfly-next/statuses/ee55b8246b5faa06a6bf646c05eef1be7b355c5e","head":{"label":"matthewcarleton:form-control-a11y","ref":"form-control-a11y","sha":"ee55b8246b5faa06a6bf646c05eef1be7b355c5e","user":{"login":"matthewcarleton","id":287880,"node_id":"MDQ6VXNlcjI4Nzg4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/287880?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewcarleton","html_url":"https://github.com/matthewcarleton","followers_url":"https://api.github.com/users/matthewcarleton/followers","following_url":"https://api.github.com/users/matthewcarleton/following{/other_user}","gists_url":"https://api.github.com/users/matthewcarleton/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewcarleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewcarleton/subscriptions","organizations_url":"https://api.github.com/users/matthewcarleton/orgs","repos_url":"https://api.github.com/users/matthewcarleton/repos","events_url":"https://api.github.com/users/matthewcarleton/events{/privacy}","received_events_url":"https://api.github.com/users/matthewcarleton/received_events","type":"User","site_admin":false},"repo":{"id":124263241,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQyNjMyNDE=","name":"patternfly-next","full_name":"matthewcarleton/patternfly-next","owner":{"login":"matthewcarleton","id":287880,"node_id":"MDQ6VXNlcjI4Nzg4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/287880?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewcarleton","html_url":"https://github.com/matthewcarleton","followers_url":"https://api.github.com/users/matthewcarleton/followers","following_url":"https://api.github.com/users/matthewcarleton/following{/other_user}","gists_url":"https://api.github.com/users/matthewcarleton/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewcarleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewcarleton/subscriptions","organizations_url":"https://api.github.com/users/matthewcarleton/orgs","repos_url":"https://api.github.com/users/matthewcarleton/repos","events_url":"https://api.github.com/users/matthewcarleton/events{/privacy}","received_events_url":"https://api.github.com/users/matthewcarleton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewcarleton/patternfly-next","description":"Working repo for patternfly next","fork":true,"url":"https://api.github.com/repos/matthewcarleton/patternfly-next","forks_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/forks","keys_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/teams","hooks_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/hooks","issue_events_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/issues/events{/number}","events_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/events","assignees_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/assignees{/user}","branches_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/branches{/branch}","tags_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/tags","blobs_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/languages","stargazers_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/stargazers","contributors_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/contributors","subscribers_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/subscribers","subscription_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/subscription","commits_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/contents/{+path}","compare_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/merges","archive_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/downloads","issues_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/issues{/number}","pulls_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/labels{/name}","releases_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/releases{/id}","deployments_url":"https://api.github.com/repos/matthewcarleton/patternfly-next/deployments","created_at":"2018-03-07T16:26:31Z","updated_at":"2018-04-20T19:33:18Z","pushed_at":"2018-08-29T16:46:46Z","git_url":"git://github.com/matthewcarleton/patternfly-next.git","ssh_url":"git@github.com:matthewcarleton/patternfly-next.git","clone_url":"https://github.com/matthewcarleton/patternfly-next.git","svn_url":"https://github.com/matthewcarleton/patternfly-next","homepage":null,"size":18218,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"patternfly:master","ref":"master","sha":"2bb4c7fecdc18394a824cc34fc0337406cebb9b5","user":{"login":"patternfly","id":6391110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTExMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"repo":{"id":122507459,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI1MDc0NTk=","name":"patternfly-next","full_name":"patternfly/patternfly-next","owner":{"login":"patternfly","id":6391110,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzOTExMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6391110?v=4","gravatar_id":"","url":"https://api.github.com/users/patternfly","html_url":"https://github.com/patternfly","followers_url":"https://api.github.com/users/patternfly/followers","following_url":"https://api.github.com/users/patternfly/following{/other_user}","gists_url":"https://api.github.com/users/patternfly/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly/subscriptions","organizations_url":"https://api.github.com/users/patternfly/orgs","repos_url":"https://api.github.com/users/patternfly/repos","events_url":"https://api.github.com/users/patternfly/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/patternfly/patternfly-next","description":"Working repo for PatternFly 4","fork":false,"url":"https://api.github.com/repos/patternfly/patternfly-next","forks_url":"https://api.github.com/repos/patternfly/patternfly-next/forks","keys_url":"https://api.github.com/repos/patternfly/patternfly-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patternfly/patternfly-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patternfly/patternfly-next/teams","hooks_url":"https://api.github.com/repos/patternfly/patternfly-next/hooks","issue_events_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/events{/number}","events_url":"https://api.github.com/repos/patternfly/patternfly-next/events","assignees_url":"https://api.github.com/repos/patternfly/patternfly-next/assignees{/user}","branches_url":"https://api.github.com/repos/patternfly/patternfly-next/branches{/branch}","tags_url":"https://api.github.com/repos/patternfly/patternfly-next/tags","blobs_url":"https://api.github.com/repos/patternfly/patternfly-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patternfly/patternfly-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patternfly/patternfly-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/patternfly/patternfly-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patternfly/patternfly-next/statuses/{sha}","languages_url":"https://api.github.com/repos/patternfly/patternfly-next/languages","stargazers_url":"https://api.github.com/repos/patternfly/patternfly-next/stargazers","contributors_url":"https://api.github.com/repos/patternfly/patternfly-next/contributors","subscribers_url":"https://api.github.com/repos/patternfly/patternfly-next/subscribers","subscription_url":"https://api.github.com/repos/patternfly/patternfly-next/subscription","commits_url":"https://api.github.com/repos/patternfly/patternfly-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/patternfly/patternfly-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/patternfly/patternfly-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/patternfly/patternfly-next/contents/{+path}","compare_url":"https://api.github.com/repos/patternfly/patternfly-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patternfly/patternfly-next/merges","archive_url":"https://api.github.com/repos/patternfly/patternfly-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patternfly/patternfly-next/downloads","issues_url":"https://api.github.com/repos/patternfly/patternfly-next/issues{/number}","pulls_url":"https://api.github.com/repos/patternfly/patternfly-next/pulls{/number}","milestones_url":"https://api.github.com/repos/patternfly/patternfly-next/milestones{/number}","notifications_url":"https://api.github.com/repos/patternfly/patternfly-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patternfly/patternfly-next/labels{/name}","releases_url":"https://api.github.com/repos/patternfly/patternfly-next/releases{/id}","deployments_url":"https://api.github.com/repos/patternfly/patternfly-next/deployments","created_at":"2018-02-22T16:52:59Z","updated_at":"2018-08-29T17:51:27Z","pushed_at":"2018-08-29T18:57:58Z","git_url":"git://github.com/patternfly/patternfly-next.git","ssh_url":"git@github.com:patternfly/patternfly-next.git","clone_url":"https://github.com/patternfly/patternfly-next.git","svn_url":"https://github.com/patternfly/patternfly-next","homepage":"","size":39336,"stargazers_count":35,"watchers_count":35,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":185,"license":null,"forks":35,"open_issues":185,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/659"},"html":{"href":"https://github.com/patternfly/patternfly-next/pull/659"},"issue":{"href":"https://api.github.com/repos/patternfly/patternfly-next/issues/659"},"comments":{"href":"https://api.github.com/repos/patternfly/patternfly-next/issues/659/comments"},"review_comments":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/659/comments"},"review_comment":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patternfly/patternfly-next/pulls/659/commits"},"statuses":{"href":"https://api.github.com/repos/patternfly/patternfly-next/statuses/ee55b8246b5faa06a6bf646c05eef1be7b355c5e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"michael-coker"}}