{"action":"created","comment":{"url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/comments/219803371","pull_request_review_id":158062118,"id":219803371,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTgwMzM3MQ==","diff_hunk":"@@ -104,26 +104,51 @@ Spins up the Storybook development server.\n \n ## Environment Variables\n \n-Your project can consume variables declared in your environment as if they were declared locally in your JS files. By\n-default you will have `NODE_ENV` defined for you, and any other environment variables starting with\n-`REACT_APP_`.\n-\n->Note: You must create custom environment variables beginning with `REACT_APP_`. Any other variables except `NODE_ENV` will be ignored to avoid accidentally [exposing a private key on the machine that could have the same name](https://github.com/facebookincubator/create-react-app/issues/865#issuecomment-252199527).\n-\n-These environment variables will be defined for you on `process.env`. For example, having an environment\n-variable named `REACT_APP_SECRET_CODE` will be exposed in your JS as `process.env.REACT_APP_SECRET_CODE`, in addition\n-to `process.env.NODE_ENV`.\n-\n-### Adding Development Environment Variables In `.env`\n-\n-To define permanent environment variables, add them to the `.env` file in the root of the project:\n-\n-```\n-REACT_APP_SECRET_CODE=abcdef\n-```\n-\n-These variables will act as the defaults if the machine does not explicitly set them.<br>\n-Please refer to the [dotenv documentation](https://github.com/motdotla/dotenv) for more details.\n+# Authentication","path":"README.md","position":33,"original_position":33,"commit_id":"c99c4929a805561e38b0a9e8a52853ed83c84163","original_commit_id":"c99c4929a805561e38b0a9e8a52853ed83c84163","user":{"login":"samiwel","id":4097796,"node_id":"MDQ6VXNlcjQwOTc3OTY=","avatar_url":"https://avatars1.githubusercontent.com/u/4097796?v=4","gravatar_id":"","url":"https://api.github.com/users/samiwel","html_url":"https://github.com/samiwel","followers_url":"https://api.github.com/users/samiwel/followers","following_url":"https://api.github.com/users/samiwel/following{/other_user}","gists_url":"https://api.github.com/users/samiwel/gists{/gist_id}","starred_url":"https://api.github.com/users/samiwel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samiwel/subscriptions","organizations_url":"https://api.github.com/users/samiwel/orgs","repos_url":"https://api.github.com/users/samiwel/repos","events_url":"https://api.github.com/users/samiwel/events{/privacy}","received_events_url":"https://api.github.com/users/samiwel/received_events","type":"User","site_admin":false},"body":"As these are under the `Environment Variables` section they should probably be `<h3>` elements.\r\ni.e.\r\n\r\n```markdown\r\n### Authentication\r\n### Functional\r\n```","created_at":"2018-09-24T11:29:45Z","updated_at":"2018-09-24T11:30:39Z","html_url":"https://github.com/ONSdigital/eq-author/pull/435#discussion_r219803371","pull_request_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/435","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/comments/219803371"},"html":{"href":"https://github.com/ONSdigital/eq-author/pull/435#discussion_r219803371"},"pull_request":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/435"}}},"pull_request":{"url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/435","id":216997491,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2OTk3NDkx","html_url":"https://github.com/ONSdigital/eq-author/pull/435","diff_url":"https://github.com/ONSdigital/eq-author/pull/435.diff","patch_url":"https://github.com/ONSdigital/eq-author/pull/435.patch","issue_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/435","number":435,"state":"open","locked":false,"title":"Updated Environment Variable Documentation","user":{"login":"rmccar","id":42928680,"node_id":"MDQ6VXNlcjQyOTI4Njgw","avatar_url":"https://avatars0.githubusercontent.com/u/42928680?v=4","gravatar_id":"","url":"https://api.github.com/users/rmccar","html_url":"https://github.com/rmccar","followers_url":"https://api.github.com/users/rmccar/followers","following_url":"https://api.github.com/users/rmccar/following{/other_user}","gists_url":"https://api.github.com/users/rmccar/gists{/gist_id}","starred_url":"https://api.github.com/users/rmccar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmccar/subscriptions","organizations_url":"https://api.github.com/users/rmccar/orgs","repos_url":"https://api.github.com/users/rmccar/repos","events_url":"https://api.github.com/users/rmccar/events{/privacy}","received_events_url":"https://api.github.com/users/rmccar/received_events","type":"User","site_admin":false},"body":"### What is the context of this PR?\r\nUpdated Documentation on Environment Variables\r\n\r\n### How to review \r\nRead Readme file to make sure it makes sense\r\n","created_at":"2018-09-20T14:39:50Z","updated_at":"2018-09-24T11:30:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2217d207c8b5ac35f0c22373ebcd1c45b94a2ab1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/435/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/435/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/435/comments","statuses_url":"https://api.github.com/repos/ONSdigital/eq-author/statuses/c99c4929a805561e38b0a9e8a52853ed83c84163","head":{"label":"ONSdigital:590-Update-project-documentation-for-new-starters","ref":"590-Update-project-documentation-for-new-starters","sha":"c99c4929a805561e38b0a9e8a52853ed83c84163","user":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":82051674,"node_id":"MDEwOlJlcG9zaXRvcnk4MjA1MTY3NA==","name":"eq-author","full_name":"ONSdigital/eq-author","private":false,"owner":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ONSdigital/eq-author","description":"Author application","fork":false,"url":"https://api.github.com/repos/ONSdigital/eq-author","forks_url":"https://api.github.com/repos/ONSdigital/eq-author/forks","keys_url":"https://api.github.com/repos/ONSdigital/eq-author/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/eq-author/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/eq-author/teams","hooks_url":"https://api.github.com/repos/ONSdigital/eq-author/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/eq-author/events","assignees_url":"https://api.github.com/repos/ONSdigital/eq-author/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/eq-author/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/eq-author/tags","blobs_url":"https://api.github.com/repos/ONSdigital/eq-author/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/eq-author/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/eq-author/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/eq-author/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/eq-author/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/eq-author/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/eq-author/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/eq-author/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/eq-author/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/eq-author/subscription","commits_url":"https://api.github.com/repos/ONSdigital/eq-author/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/eq-author/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/eq-author/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/eq-author/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/eq-author/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/eq-author/merges","archive_url":"https://api.github.com/repos/ONSdigital/eq-author/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/eq-author/downloads","issues_url":"https://api.github.com/repos/ONSdigital/eq-author/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/eq-author/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/eq-author/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/eq-author/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/eq-author/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/eq-author/deployments","created_at":"2017-02-15T11:06:14Z","updated_at":"2018-09-24T10:12:17Z","pushed_at":"2018-09-24T10:36:13Z","git_url":"git://github.com/ONSdigital/eq-author.git","ssh_url":"git@github.com:ONSdigital/eq-author.git","clone_url":"https://github.com/ONSdigital/eq-author.git","svn_url":"https://github.com/ONSdigital/eq-author","homepage":"https://staging-author.dev.eq.ons.digital/","size":4662,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":0,"open_issues":8,"watchers":4,"default_branch":"master"}},"base":{"label":"ONSdigital:master","ref":"master","sha":"63b173243a04d4877f9b55badff4083a05358375","user":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":82051674,"node_id":"MDEwOlJlcG9zaXRvcnk4MjA1MTY3NA==","name":"eq-author","full_name":"ONSdigital/eq-author","private":false,"owner":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ONSdigital/eq-author","description":"Author application","fork":false,"url":"https://api.github.com/repos/ONSdigital/eq-author","forks_url":"https://api.github.com/repos/ONSdigital/eq-author/forks","keys_url":"https://api.github.com/repos/ONSdigital/eq-author/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/eq-author/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/eq-author/teams","hooks_url":"https://api.github.com/repos/ONSdigital/eq-author/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/eq-author/events","assignees_url":"https://api.github.com/repos/ONSdigital/eq-author/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/eq-author/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/eq-author/tags","blobs_url":"https://api.github.com/repos/ONSdigital/eq-author/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/eq-author/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/eq-author/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/eq-author/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/eq-author/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/eq-author/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/eq-author/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/eq-author/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/eq-author/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/eq-author/subscription","commits_url":"https://api.github.com/repos/ONSdigital/eq-author/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/eq-author/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/eq-author/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/eq-author/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/eq-author/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/eq-author/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/eq-author/merges","archive_url":"https://api.github.com/repos/ONSdigital/eq-author/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/eq-author/downloads","issues_url":"https://api.github.com/repos/ONSdigital/eq-author/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/eq-author/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/eq-author/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/eq-author/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/eq-author/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/eq-author/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/eq-author/deployments","created_at":"2017-02-15T11:06:14Z","updated_at":"2018-09-24T10:12:17Z","pushed_at":"2018-09-24T10:36:13Z","git_url":"git://github.com/ONSdigital/eq-author.git","ssh_url":"git@github.com:ONSdigital/eq-author.git","clone_url":"https://github.com/ONSdigital/eq-author.git","svn_url":"https://github.com/ONSdigital/eq-author","homepage":"https://staging-author.dev.eq.ons.digital/","size":4662,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":0,"open_issues":8,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/435"},"html":{"href":"https://github.com/ONSdigital/eq-author/pull/435"},"issue":{"href":"https://api.github.com/repos/ONSdigital/eq-author/issues/435"},"comments":{"href":"https://api.github.com/repos/ONSdigital/eq-author/issues/435/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/435/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/eq-author/pulls/435/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/eq-author/statuses/c99c4929a805561e38b0a9e8a52853ed83c84163"}},"author_association":"NONE"}}
{"actor":{"display_login":"samiwel"}}