{"action":"closed","issue":{"url":"https://api.github.com/repos/ripple/rippled/issues/2795","repository_url":"https://api.github.com/repos/ripple/rippled","labels_url":"https://api.github.com/repos/ripple/rippled/issues/2795/labels{/name}","comments_url":"https://api.github.com/repos/ripple/rippled/issues/2795/comments","events_url":"https://api.github.com/repos/ripple/rippled/issues/2795/events","html_url":"https://github.com/ripple/rippled/issues/2795","id":386042796,"node_id":"MDU6SXNzdWUzODYwNDI3OTY=","number":2795,"title":"Clustered peers can't bypass connection limits","user":{"login":"nbougalis","id":5085415,"node_id":"MDQ6VXNlcjUwODU0MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5085415?v=4","gravatar_id":"","url":"https://api.github.com/users/nbougalis","html_url":"https://github.com/nbougalis","followers_url":"https://api.github.com/users/nbougalis/followers","following_url":"https://api.github.com/users/nbougalis/following{/other_user}","gists_url":"https://api.github.com/users/nbougalis/gists{/gist_id}","starred_url":"https://api.github.com/users/nbougalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbougalis/subscriptions","organizations_url":"https://api.github.com/users/nbougalis/orgs","repos_url":"https://api.github.com/users/nbougalis/repos","events_url":"https://api.github.com/users/nbougalis/events{/privacy}","received_events_url":"https://api.github.com/users/nbougalis/received_events","type":"User","site_admin":false},"labels":[{"id":1112157227,"node_id":"MDU6TGFiZWwxMTEyMTU3MjI3","url":"https://api.github.com/repos/ripple/rippled/labels/Bug","name":"Bug","color":"FD0000","default":false}],"state":"closed","locked":false,"assignee":{"login":"nbougalis","id":5085415,"node_id":"MDQ6VXNlcjUwODU0MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5085415?v=4","gravatar_id":"","url":"https://api.github.com/users/nbougalis","html_url":"https://github.com/nbougalis","followers_url":"https://api.github.com/users/nbougalis/followers","following_url":"https://api.github.com/users/nbougalis/following{/other_user}","gists_url":"https://api.github.com/users/nbougalis/gists{/gist_id}","starred_url":"https://api.github.com/users/nbougalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbougalis/subscriptions","organizations_url":"https://api.github.com/users/nbougalis/orgs","repos_url":"https://api.github.com/users/nbougalis/repos","events_url":"https://api.github.com/users/nbougalis/events{/privacy}","received_events_url":"https://api.github.com/users/nbougalis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nbougalis","id":5085415,"node_id":"MDQ6VXNlcjUwODU0MTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5085415?v=4","gravatar_id":"","url":"https://api.github.com/users/nbougalis","html_url":"https://github.com/nbougalis","followers_url":"https://api.github.com/users/nbougalis/followers","following_url":"https://api.github.com/users/nbougalis/following{/other_user}","gists_url":"https://api.github.com/users/nbougalis/gists{/gist_id}","starred_url":"https://api.github.com/users/nbougalis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbougalis/subscriptions","organizations_url":"https://api.github.com/users/nbougalis/orgs","repos_url":"https://api.github.com/users/nbougalis/repos","events_url":"https://api.github.com/users/nbougalis/events{/privacy}","received_events_url":"https://api.github.com/users/nbougalis/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-11-30T05:25:09Z","updated_at":"2018-12-12T04:02:51Z","closed_at":"2018-12-12T04:02:51Z","author_association":"MEMBER","body":"A casual reading of the code at https://github.com/ripple/rippled/blob/72e6005f562a8f0818bc94803d222ac9345e1e40/src/ripple/peerfinder/impl/Counts.h#L74 suggests that slots associated with a peer that is configured as \"fixed\" or part of a \"cluster should bypass certain connection limits and always be allowed to connect.\r\n\r\nThat's not always the case.\r\n\r\nLooking at https://github.com/ripple/rippled/blob/72e6005f562a8f0818bc94803d222ac9345e1e40/src/ripple/peerfinder/impl/Logic.h#L396 the problem becomes obvious: we don't actually mark the slot as being for a peer that's part of a `cluster` until 12 lines later. :man_facepalming:"}}
{"actor":{"display_login":"nbougalis"}}