{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/226225479","pull_request_review_id":165992949,"id":226225479,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjIyNTQ3OQ==","diff_hunk":"@@ -64,6 +64,18 @@ class PDOConnector extends DBConnector\n      */\n     protected $cachedStatements = array();\n \n+    /**\n+     * Driver\n+     * @var string\n+     */\n+    private $driver = null;","path":"src/ORM/Connect/PDOConnector.php","position":33,"original_position":17,"commit_id":"b1a34223249c25b0dcf5407554541f5e5e4ac9e8","original_commit_id":"25fe371e8f0324252ded4d41550f0357771b6a57","user":{"login":"robbieaverill","id":5170590,"node_id":"MDQ6VXNlcjUxNzA1OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/5170590?v=4","gravatar_id":"","url":"https://api.github.com/users/robbieaverill","html_url":"https://github.com/robbieaverill","followers_url":"https://api.github.com/users/robbieaverill/followers","following_url":"https://api.github.com/users/robbieaverill/following{/other_user}","gists_url":"https://api.github.com/users/robbieaverill/gists{/gist_id}","starred_url":"https://api.github.com/users/robbieaverill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbieaverill/subscriptions","organizations_url":"https://api.github.com/users/robbieaverill/orgs","repos_url":"https://api.github.com/users/robbieaverill/repos","events_url":"https://api.github.com/users/robbieaverill/events{/privacy}","received_events_url":"https://api.github.com/users/robbieaverill/received_events","type":"User","site_admin":false},"body":"Yeah I guess it's a topic for another conversation, but at the moment our codebase is almost all protected over private so I guess we should keep it consistent?","created_at":"2018-10-18T09:05:04Z","updated_at":"2018-10-18T09:05:04Z","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/8448#discussion_r226225479","pull_request_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8448","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/226225479"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/8448#discussion_r226225479"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8448"}},"in_reply_to_id":226205341},"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8448","id":220237787,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMjM3Nzg3","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/8448","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/8448.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/8448.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/8448","number":8448,"state":"open","locked":false,"title":"FIX: Ensure that types are preserved fetching from database","user":{"login":"sminnee","id":59968,"node_id":"MDQ6VXNlcjU5OTY4","avatar_url":"https://avatars1.githubusercontent.com/u/59968?v=4","gravatar_id":"","url":"https://api.github.com/users/sminnee","html_url":"https://github.com/sminnee","followers_url":"https://api.github.com/users/sminnee/followers","following_url":"https://api.github.com/users/sminnee/following{/other_user}","gists_url":"https://api.github.com/users/sminnee/gists{/gist_id}","starred_url":"https://api.github.com/users/sminnee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sminnee/subscriptions","organizations_url":"https://api.github.com/users/sminnee/orgs","repos_url":"https://api.github.com/users/sminnee/repos","events_url":"https://api.github.com/users/sminnee/events{/privacy}","received_events_url":"https://api.github.com/users/sminnee/received_events","type":"User","site_admin":false},"body":"This ensures that numeric fields appear in PHP as int/float values\r\nrather than strings, which allows the development of more type-safe PHP\r\ncode.\r\n\r\nThis doesn’t work on the legacy mysql driver and this will now throw\r\na notice-level error. It requires mysqlnd.\r\n\r\nFixes #7039, and other bugs such as #6709\r\n\r\nAlso requires https://github.com/silverstripe/silverstripe-postgresql/pull/91\r\n\r\nTaken from https://github.com/open-sausages/silverstripe-framework/commit/f4e6aae411f2ffcfd52ff08e6bf66dbe4eeee464\r\n","created_at":"2018-10-04T03:14:35Z","updated_at":"2018-10-18T09:05:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7758ff0fd8fdf00b16e498cc4f08893c8053d017","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8448/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8448/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/8448/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/b1a34223249c25b0dcf5407554541f5e5e4ac9e8","head":{"label":"sminnee:int-types","ref":"int-types","sha":"b1a34223249c25b0dcf5407554541f5e5e4ac9e8","user":{"login":"sminnee","id":59968,"node_id":"MDQ6VXNlcjU5OTY4","avatar_url":"https://avatars1.githubusercontent.com/u/59968?v=4","gravatar_id":"","url":"https://api.github.com/users/sminnee","html_url":"https://github.com/sminnee","followers_url":"https://api.github.com/users/sminnee/followers","following_url":"https://api.github.com/users/sminnee/following{/other_user}","gists_url":"https://api.github.com/users/sminnee/gists{/gist_id}","starred_url":"https://api.github.com/users/sminnee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sminnee/subscriptions","organizations_url":"https://api.github.com/users/sminnee/orgs","repos_url":"https://api.github.com/users/sminnee/repos","events_url":"https://api.github.com/users/sminnee/events{/privacy}","received_events_url":"https://api.github.com/users/sminnee/received_events","type":"User","site_admin":false},"repo":{"id":2668449,"node_id":"MDEwOlJlcG9zaXRvcnkyNjY4NDQ5","name":"silverstripe-framework","full_name":"sminnee/silverstripe-framework","private":false,"owner":{"login":"sminnee","id":59968,"node_id":"MDQ6VXNlcjU5OTY4","avatar_url":"https://avatars1.githubusercontent.com/u/59968?v=4","gravatar_id":"","url":"https://api.github.com/users/sminnee","html_url":"https://github.com/sminnee","followers_url":"https://api.github.com/users/sminnee/followers","following_url":"https://api.github.com/users/sminnee/following{/other_user}","gists_url":"https://api.github.com/users/sminnee/gists{/gist_id}","starred_url":"https://api.github.com/users/sminnee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sminnee/subscriptions","organizations_url":"https://api.github.com/users/sminnee/orgs","repos_url":"https://api.github.com/users/sminnee/repos","events_url":"https://api.github.com/users/sminnee/events{/privacy}","received_events_url":"https://api.github.com/users/sminnee/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sminnee/silverstripe-framework","description":"SilverStripe's Sapphire Framework","fork":true,"url":"https://api.github.com/repos/sminnee/silverstripe-framework","forks_url":"https://api.github.com/repos/sminnee/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/sminnee/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sminnee/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sminnee/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/sminnee/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/sminnee/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/sminnee/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/sminnee/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/sminnee/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/sminnee/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/sminnee/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sminnee/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sminnee/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/sminnee/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sminnee/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/sminnee/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/sminnee/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/sminnee/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/sminnee/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/sminnee/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/sminnee/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/sminnee/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/sminnee/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/sminnee/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/sminnee/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/sminnee/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sminnee/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/sminnee/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sminnee/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/sminnee/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/sminnee/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/sminnee/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/sminnee/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sminnee/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/sminnee/silverstripe-framework/releases{/id}","deployments_url":"https://api.github.com/repos/sminnee/silverstripe-framework/deployments","created_at":"2011-10-28T23:04:11Z","updated_at":"2014-07-05T02:55:22Z","pushed_at":"2018-10-18T09:00:31Z","git_url":"git://github.com/sminnee/silverstripe-framework.git","ssh_url":"git@github.com:sminnee/silverstripe-framework.git","clone_url":"https://github.com/sminnee/silverstripe-framework.git","svn_url":"https://github.com/sminnee/silverstripe-framework","homepage":"http://silverstripe.org/","size":101006,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"silverstripe:4","ref":"4","sha":"22dae0f74c1d1f716727958892f37710cf4f5edc","user":{"login":"silverstripe","id":379348,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTM0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/379348?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1318892,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE4ODky","name":"silverstripe-framework","full_name":"silverstripe/silverstripe-framework","private":false,"owner":{"login":"silverstripe","id":379348,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTM0OA==","avatar_url":"https://avatars0.githubusercontent.com/u/379348?v=4","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/silverstripe/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-framework","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/releases{/id}","deployments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/deployments","created_at":"2011-02-02T02:04:13Z","updated_at":"2018-10-16T12:48:03Z","pushed_at":"2018-10-18T09:00:33Z","git_url":"git://github.com/silverstripe/silverstripe-framework.git","ssh_url":"git@github.com:silverstripe/silverstripe-framework.git","clone_url":"https://github.com/silverstripe/silverstripe-framework.git","svn_url":"https://github.com/silverstripe/silverstripe-framework","homepage":"http://silverstripe.org/","size":101213,"stargazers_count":607,"watchers_count":607,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":710,"mirror_url":null,"archived":false,"open_issues_count":503,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":710,"open_issues":503,"watchers":607,"default_branch":"4"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8448"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/8448"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/8448"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/8448/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8448/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/8448/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/b1a34223249c25b0dcf5407554541f5e5e4ac9e8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"robbieaverill"}}