{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/comments/165485260","pull_request_review_id":93434629,"id":165485260,"diff_hunk":"@@ -96,6 +99,13 @@ class ConstraintVariable {\n   }\n \n   virtual ~ConstraintVariable() {};\n+","path":"tools/checked-c-convert/ProgramInfo.h","position":21,"original_position":21,"commit_id":"21c878467221f604558944b9560d5729ebbae75b","original_commit_id":"1c079dfe4ced4b992adc74b27aac5b445103186b","user":{"login":"awruef","id":2530731,"avatar_url":"https://avatars3.githubusercontent.com/u/2530731?v=4","gravatar_id":"","url":"https://api.github.com/users/awruef","html_url":"https://github.com/awruef","followers_url":"https://api.github.com/users/awruef/followers","following_url":"https://api.github.com/users/awruef/following{/other_user}","gists_url":"https://api.github.com/users/awruef/gists{/gist_id}","starred_url":"https://api.github.com/users/awruef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awruef/subscriptions","organizations_url":"https://api.github.com/users/awruef/orgs","repos_url":"https://api.github.com/users/awruef/repos","events_url":"https://api.github.com/users/awruef/events{/privacy}","received_events_url":"https://api.github.com/users/awruef/received_events","type":"User","site_admin":false},"body":"Yes. ","created_at":"2018-02-01T20:57:24Z","updated_at":"2018-02-01T20:57:25Z","html_url":"https://github.com/Microsoft/checkedc-clang/pull/446#discussion_r165485260","pull_request_url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/446","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/comments/165485260"},"html":{"href":"https://github.com/Microsoft/checkedc-clang/pull/446#discussion_r165485260"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/446"}},"in_reply_to_id":165474738},"pull_request":{"url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/446","id":166627223,"html_url":"https://github.com/Microsoft/checkedc-clang/pull/446","diff_url":"https://github.com/Microsoft/checkedc-clang/pull/446.diff","patch_url":"https://github.com/Microsoft/checkedc-clang/pull/446.patch","issue_url":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/446","number":446,"state":"open","locked":false,"title":"Beginning of changes for merge of cast placement algorithm","user":{"login":"awruef","id":2530731,"avatar_url":"https://avatars3.githubusercontent.com/u/2530731?v=4","gravatar_id":"","url":"https://api.github.com/users/awruef","html_url":"https://github.com/awruef","followers_url":"https://api.github.com/users/awruef/followers","following_url":"https://api.github.com/users/awruef/following{/other_user}","gists_url":"https://api.github.com/users/awruef/gists{/gist_id}","starred_url":"https://api.github.com/users/awruef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awruef/subscriptions","organizations_url":"https://api.github.com/users/awruef/orgs","repos_url":"https://api.github.com/users/awruef/repos","events_url":"https://api.github.com/users/awruef/events{/privacy}","received_events_url":"https://api.github.com/users/awruef/received_events","type":"User","site_admin":false},"body":"This change brings over the lower level infrastructure for doing cast placement. Specifically, the resolution mechanisms for function declarations can return either a declaration or definition reference, and that is tracked separately by ProgramInfo.","created_at":"2018-02-01T19:18:04Z","updated_at":"2018-02-01T20:57:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df72120dbe4ae4dd052cedef7de8cd1fbb25d95e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/446/commits","review_comments_url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/446/comments","review_comment_url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/446/comments","statuses_url":"https://api.github.com/repos/Microsoft/checkedc-clang/statuses/21c878467221f604558944b9560d5729ebbae75b","head":{"label":"awruef:awr_29","ref":"awr_29","sha":"21c878467221f604558944b9560d5729ebbae75b","user":{"login":"awruef","id":2530731,"avatar_url":"https://avatars3.githubusercontent.com/u/2530731?v=4","gravatar_id":"","url":"https://api.github.com/users/awruef","html_url":"https://github.com/awruef","followers_url":"https://api.github.com/users/awruef/followers","following_url":"https://api.github.com/users/awruef/following{/other_user}","gists_url":"https://api.github.com/users/awruef/gists{/gist_id}","starred_url":"https://api.github.com/users/awruef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awruef/subscriptions","organizations_url":"https://api.github.com/users/awruef/orgs","repos_url":"https://api.github.com/users/awruef/repos","events_url":"https://api.github.com/users/awruef/events{/privacy}","received_events_url":"https://api.github.com/users/awruef/received_events","type":"User","site_admin":false},"repo":{"id":85587992,"name":"checkedc-clang","full_name":"awruef/checkedc-clang","owner":{"login":"awruef","id":2530731,"avatar_url":"https://avatars3.githubusercontent.com/u/2530731?v=4","gravatar_id":"","url":"https://api.github.com/users/awruef","html_url":"https://github.com/awruef","followers_url":"https://api.github.com/users/awruef/followers","following_url":"https://api.github.com/users/awruef/following{/other_user}","gists_url":"https://api.github.com/users/awruef/gists{/gist_id}","starred_url":"https://api.github.com/users/awruef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awruef/subscriptions","organizations_url":"https://api.github.com/users/awruef/orgs","repos_url":"https://api.github.com/users/awruef/repos","events_url":"https://api.github.com/users/awruef/events{/privacy}","received_events_url":"https://api.github.com/users/awruef/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awruef/checkedc-clang","description":"This repo contains a version of clang that is being modified to support Checked C.   Checked C is an extension to C that adds checking to detect or prevent common programming errors such as out-of-bounds memory accesses.","fork":true,"url":"https://api.github.com/repos/awruef/checkedc-clang","forks_url":"https://api.github.com/repos/awruef/checkedc-clang/forks","keys_url":"https://api.github.com/repos/awruef/checkedc-clang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awruef/checkedc-clang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awruef/checkedc-clang/teams","hooks_url":"https://api.github.com/repos/awruef/checkedc-clang/hooks","issue_events_url":"https://api.github.com/repos/awruef/checkedc-clang/issues/events{/number}","events_url":"https://api.github.com/repos/awruef/checkedc-clang/events","assignees_url":"https://api.github.com/repos/awruef/checkedc-clang/assignees{/user}","branches_url":"https://api.github.com/repos/awruef/checkedc-clang/branches{/branch}","tags_url":"https://api.github.com/repos/awruef/checkedc-clang/tags","blobs_url":"https://api.github.com/repos/awruef/checkedc-clang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awruef/checkedc-clang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awruef/checkedc-clang/git/refs{/sha}","trees_url":"https://api.github.com/repos/awruef/checkedc-clang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awruef/checkedc-clang/statuses/{sha}","languages_url":"https://api.github.com/repos/awruef/checkedc-clang/languages","stargazers_url":"https://api.github.com/repos/awruef/checkedc-clang/stargazers","contributors_url":"https://api.github.com/repos/awruef/checkedc-clang/contributors","subscribers_url":"https://api.github.com/repos/awruef/checkedc-clang/subscribers","subscription_url":"https://api.github.com/repos/awruef/checkedc-clang/subscription","commits_url":"https://api.github.com/repos/awruef/checkedc-clang/commits{/sha}","git_commits_url":"https://api.github.com/repos/awruef/checkedc-clang/git/commits{/sha}","comments_url":"https://api.github.com/repos/awruef/checkedc-clang/comments{/number}","issue_comment_url":"https://api.github.com/repos/awruef/checkedc-clang/issues/comments{/number}","contents_url":"https://api.github.com/repos/awruef/checkedc-clang/contents/{+path}","compare_url":"https://api.github.com/repos/awruef/checkedc-clang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awruef/checkedc-clang/merges","archive_url":"https://api.github.com/repos/awruef/checkedc-clang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awruef/checkedc-clang/downloads","issues_url":"https://api.github.com/repos/awruef/checkedc-clang/issues{/number}","pulls_url":"https://api.github.com/repos/awruef/checkedc-clang/pulls{/number}","milestones_url":"https://api.github.com/repos/awruef/checkedc-clang/milestones{/number}","notifications_url":"https://api.github.com/repos/awruef/checkedc-clang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awruef/checkedc-clang/labels{/name}","releases_url":"https://api.github.com/repos/awruef/checkedc-clang/releases{/id}","deployments_url":"https://api.github.com/repos/awruef/checkedc-clang/deployments","created_at":"2017-03-20T14:38:55Z","updated_at":"2017-03-20T14:39:20Z","pushed_at":"2018-02-01T20:57:04Z","git_url":"git://github.com/awruef/checkedc-clang.git","ssh_url":"git@github.com:awruef/checkedc-clang.git","clone_url":"https://github.com/awruef/checkedc-clang.git","svn_url":"https://github.com/awruef/checkedc-clang","homepage":"","size":290140,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"3dd9b0b0a0d918fce3a7eab62ef10ce8675e925f","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":60645050,"name":"checkedc-clang","full_name":"Microsoft/checkedc-clang","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/checkedc-clang","description":"This repo contains a version of clang that is being modified to support Checked C.   Checked C is an extension to C that adds checking to detect or prevent common programming errors such as out-of-bounds memory accesses.","fork":false,"url":"https://api.github.com/repos/Microsoft/checkedc-clang","forks_url":"https://api.github.com/repos/Microsoft/checkedc-clang/forks","keys_url":"https://api.github.com/repos/Microsoft/checkedc-clang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/checkedc-clang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/checkedc-clang/teams","hooks_url":"https://api.github.com/repos/Microsoft/checkedc-clang/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/checkedc-clang/events","assignees_url":"https://api.github.com/repos/Microsoft/checkedc-clang/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/checkedc-clang/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/checkedc-clang/tags","blobs_url":"https://api.github.com/repos/Microsoft/checkedc-clang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/checkedc-clang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/checkedc-clang/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/checkedc-clang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/checkedc-clang/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/checkedc-clang/languages","stargazers_url":"https://api.github.com/repos/Microsoft/checkedc-clang/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/checkedc-clang/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/checkedc-clang/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/checkedc-clang/subscription","commits_url":"https://api.github.com/repos/Microsoft/checkedc-clang/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/checkedc-clang/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/checkedc-clang/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/checkedc-clang/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/checkedc-clang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/checkedc-clang/merges","archive_url":"https://api.github.com/repos/Microsoft/checkedc-clang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/checkedc-clang/downloads","issues_url":"https://api.github.com/repos/Microsoft/checkedc-clang/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/checkedc-clang/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/checkedc-clang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/checkedc-clang/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/checkedc-clang/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/checkedc-clang/deployments","created_at":"2016-06-07T20:43:32Z","updated_at":"2018-01-27T06:02:26Z","pushed_at":"2018-02-01T20:57:05Z","git_url":"git://github.com/Microsoft/checkedc-clang.git","ssh_url":"git@github.com:Microsoft/checkedc-clang.git","clone_url":"https://github.com/Microsoft/checkedc-clang.git","svn_url":"https://github.com/Microsoft/checkedc-clang","homepage":"","size":290011,"stargazers_count":134,"watchers_count":134,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":79,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":21,"open_issues":79,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/446"},"html":{"href":"https://github.com/Microsoft/checkedc-clang/pull/446"},"issue":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/446"},"comments":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/issues/446/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/446/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/pulls/446/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/checkedc-clang/statuses/21c878467221f604558944b9560d5729ebbae75b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"awruef"}}