{"action":"created","comment":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/comments/210558699","pull_request_review_id":146797773,"id":210558699,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDU1ODY5OQ==","diff_hunk":"@@ -60,7 +62,12 @@ func SetExternalKey(controllerID string, containerID string, key string) error {\n \t\tContainerID: containerID,\n \t\tKey:         key}\n \n-\tc, err := net.Dial(\"unix\", udsBase+controllerID+\".sock\")\n+\texecRoot := \"/run/docker\"\n+\tif v := os.Getenv(\"_LIBNETWORK_EXEC_ROOT\"); v != \"\" {","path":"sandbox_externalkey_unix.go","position":29,"original_position":29,"commit_id":"9ac90d5be6bac27a7e1a53ac2087e55c6fcb6735","original_commit_id":"9ac90d5be6bac27a7e1a53ac2087e55c6fcb6735","user":{"login":"AkihiroSuda","id":9248427,"node_id":"MDQ6VXNlcjkyNDg0Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/9248427?v=4","gravatar_id":"","url":"https://api.github.com/users/AkihiroSuda","html_url":"https://github.com/AkihiroSuda","followers_url":"https://api.github.com/users/AkihiroSuda/followers","following_url":"https://api.github.com/users/AkihiroSuda/following{/other_user}","gists_url":"https://api.github.com/users/AkihiroSuda/gists{/gist_id}","starred_url":"https://api.github.com/users/AkihiroSuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkihiroSuda/subscriptions","organizations_url":"https://api.github.com/users/AkihiroSuda/orgs","repos_url":"https://api.github.com/users/AkihiroSuda/repos","events_url":"https://api.github.com/users/AkihiroSuda/events{/privacy}","received_events_url":"https://api.github.com/users/AkihiroSuda/received_events","type":"User","site_admin":false},"body":"On second thought, maybe the underscore prefix is not needed?","created_at":"2018-08-16T11:17:11Z","updated_at":"2018-08-16T11:17:11Z","html_url":"https://github.com/docker/libnetwork/pull/2248#discussion_r210558699","pull_request_url":"https://api.github.com/repos/docker/libnetwork/pulls/2248","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments/210558699"},"html":{"href":"https://github.com/docker/libnetwork/pull/2248#discussion_r210558699"},"pull_request":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/2248"}}},"pull_request":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/2248","id":207772832,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzcyODMy","html_url":"https://github.com/docker/libnetwork/pull/2248","diff_url":"https://github.com/docker/libnetwork/pull/2248.diff","patch_url":"https://github.com/docker/libnetwork/pull/2248.patch","issue_url":"https://api.github.com/repos/docker/libnetwork/issues/2248","number":2248,"state":"open","locked":false,"title":"allow propagating custom exec-root (e.g. \"/run/docker\") to libnetwork-setkey","user":{"login":"AkihiroSuda","id":9248427,"node_id":"MDQ6VXNlcjkyNDg0Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/9248427?v=4","gravatar_id":"","url":"https://api.github.com/users/AkihiroSuda","html_url":"https://github.com/AkihiroSuda","followers_url":"https://api.github.com/users/AkihiroSuda/followers","following_url":"https://api.github.com/users/AkihiroSuda/following{/other_user}","gists_url":"https://api.github.com/users/AkihiroSuda/gists{/gist_id}","starred_url":"https://api.github.com/users/AkihiroSuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkihiroSuda/subscriptions","organizations_url":"https://api.github.com/users/AkihiroSuda/orgs","repos_url":"https://api.github.com/users/AkihiroSuda/repos","events_url":"https://api.github.com/users/AkihiroSuda/events{/privacy}","received_events_url":"https://api.github.com/users/AkihiroSuda/received_events","type":"User","site_admin":false},"body":"part of https://github.com/moby/moby/issues/37375 (in rootless mode, exec-root should be like `/run/user/4242/docker` rather than `/run/docker`)\r\n\r\nThe docker daemon needs to be modified as follows:\r\n\r\n\t--- a/daemon/oci_linux.go\r\n\t+++ b/daemon/oci_linux.go\r\n\t@@ -811,6 +811,7 @@ func (daemon *Daemon) createSpec(c *container.Container) (retSpec *specs.Spec, e\r\n\t                                Prestart: []specs.Hook{{\r\n\t                                        Path: target,\r\n\t                                        Args: []string{\"libnetwork-setkey\", c.ID, daemon.netController.ID()},\r\n\t+                                       Env:  []string{\"_LIBNETWORK_EXEC_ROOT=\" + daemon.configStore.GetExecRoot()},\r\n\t                                }},\r\n\t                        }\r\n\t                }\r\n\r\nSigned-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>\r\n\r\n","created_at":"2018-08-11T12:31:39Z","updated_at":"2018-08-16T11:17:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fe5ab0cc543b7d89902de954198005a9e66e60e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/libnetwork/pulls/2248/commits","review_comments_url":"https://api.github.com/repos/docker/libnetwork/pulls/2248/comments","review_comment_url":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/libnetwork/issues/2248/comments","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/9ac90d5be6bac27a7e1a53ac2087e55c6fcb6735","head":{"label":"AkihiroSuda:propagte-exec-root","ref":"propagte-exec-root","sha":"9ac90d5be6bac27a7e1a53ac2087e55c6fcb6735","user":{"login":"AkihiroSuda","id":9248427,"node_id":"MDQ6VXNlcjkyNDg0Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/9248427?v=4","gravatar_id":"","url":"https://api.github.com/users/AkihiroSuda","html_url":"https://github.com/AkihiroSuda","followers_url":"https://api.github.com/users/AkihiroSuda/followers","following_url":"https://api.github.com/users/AkihiroSuda/following{/other_user}","gists_url":"https://api.github.com/users/AkihiroSuda/gists{/gist_id}","starred_url":"https://api.github.com/users/AkihiroSuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkihiroSuda/subscriptions","organizations_url":"https://api.github.com/users/AkihiroSuda/orgs","repos_url":"https://api.github.com/users/AkihiroSuda/repos","events_url":"https://api.github.com/users/AkihiroSuda/events{/privacy}","received_events_url":"https://api.github.com/users/AkihiroSuda/received_events","type":"User","site_admin":false},"repo":{"id":68716971,"node_id":"MDEwOlJlcG9zaXRvcnk2ODcxNjk3MQ==","name":"libnetwork","full_name":"AkihiroSuda/libnetwork","owner":{"login":"AkihiroSuda","id":9248427,"node_id":"MDQ6VXNlcjkyNDg0Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/9248427?v=4","gravatar_id":"","url":"https://api.github.com/users/AkihiroSuda","html_url":"https://github.com/AkihiroSuda","followers_url":"https://api.github.com/users/AkihiroSuda/followers","following_url":"https://api.github.com/users/AkihiroSuda/following{/other_user}","gists_url":"https://api.github.com/users/AkihiroSuda/gists{/gist_id}","starred_url":"https://api.github.com/users/AkihiroSuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkihiroSuda/subscriptions","organizations_url":"https://api.github.com/users/AkihiroSuda/orgs","repos_url":"https://api.github.com/users/AkihiroSuda/repos","events_url":"https://api.github.com/users/AkihiroSuda/events{/privacy}","received_events_url":"https://api.github.com/users/AkihiroSuda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AkihiroSuda/libnetwork","description":"Docker Networking","fork":true,"url":"https://api.github.com/repos/AkihiroSuda/libnetwork","forks_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/forks","keys_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/teams","hooks_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/events","assignees_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/tags","blobs_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/languages","stargazers_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/subscription","commits_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/merges","archive_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/downloads","issues_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/releases{/id}","deployments_url":"https://api.github.com/repos/AkihiroSuda/libnetwork/deployments","created_at":"2016-09-20T13:53:59Z","updated_at":"2016-09-20T13:54:00Z","pushed_at":"2018-08-16T11:01:39Z","git_url":"git://github.com/AkihiroSuda/libnetwork.git","ssh_url":"git@github.com:AkihiroSuda/libnetwork.git","clone_url":"https://github.com/AkihiroSuda/libnetwork.git","svn_url":"https://github.com/AkihiroSuda/libnetwork","homepage":"","size":14111,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"9ffeaf7d8b64fa0eb64cc27835dc1a5a90328024","user":{"login":"docker","id":5429470,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0Mjk0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/5429470?v=4","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":31046054,"node_id":"MDEwOlJlcG9zaXRvcnkzMTA0NjA1NA==","name":"libnetwork","full_name":"docker/libnetwork","owner":{"login":"docker","id":5429470,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0Mjk0NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/5429470?v=4","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libnetwork","description":"Docker Networking","fork":false,"url":"https://api.github.com/repos/docker/libnetwork","forks_url":"https://api.github.com/repos/docker/libnetwork/forks","keys_url":"https://api.github.com/repos/docker/libnetwork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libnetwork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libnetwork/teams","hooks_url":"https://api.github.com/repos/docker/libnetwork/hooks","issue_events_url":"https://api.github.com/repos/docker/libnetwork/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libnetwork/events","assignees_url":"https://api.github.com/repos/docker/libnetwork/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libnetwork/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libnetwork/tags","blobs_url":"https://api.github.com/repos/docker/libnetwork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libnetwork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libnetwork/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libnetwork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libnetwork/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libnetwork/languages","stargazers_url":"https://api.github.com/repos/docker/libnetwork/stargazers","contributors_url":"https://api.github.com/repos/docker/libnetwork/contributors","subscribers_url":"https://api.github.com/repos/docker/libnetwork/subscribers","subscription_url":"https://api.github.com/repos/docker/libnetwork/subscription","commits_url":"https://api.github.com/repos/docker/libnetwork/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libnetwork/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libnetwork/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libnetwork/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/libnetwork/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libnetwork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libnetwork/merges","archive_url":"https://api.github.com/repos/docker/libnetwork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libnetwork/downloads","issues_url":"https://api.github.com/repos/docker/libnetwork/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libnetwork/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libnetwork/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libnetwork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libnetwork/labels{/name}","releases_url":"https://api.github.com/repos/docker/libnetwork/releases{/id}","deployments_url":"https://api.github.com/repos/docker/libnetwork/deployments","created_at":"2015-02-20T01:20:15Z","updated_at":"2018-08-15T08:47:26Z","pushed_at":"2018-08-16T11:01:41Z","git_url":"git://github.com/docker/libnetwork.git","ssh_url":"git@github.com:docker/libnetwork.git","clone_url":"https://github.com/docker/libnetwork.git","svn_url":"https://github.com/docker/libnetwork","homepage":"","size":14545,"stargazers_count":1192,"watchers_count":1192,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":628,"mirror_url":null,"archived":false,"open_issues_count":196,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":628,"open_issues":196,"watchers":1192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/2248"},"html":{"href":"https://github.com/docker/libnetwork/pull/2248"},"issue":{"href":"https://api.github.com/repos/docker/libnetwork/issues/2248"},"comments":{"href":"https://api.github.com/repos/docker/libnetwork/issues/2248/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/2248/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/libnetwork/pulls/2248/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libnetwork/statuses/9ac90d5be6bac27a7e1a53ac2087e55c6fcb6735"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"AkihiroSuda"}}