{"action":"created","comment":{"url":"https://api.github.com/repos/spacetelescope/cubeviz/pulls/comments/170081063","pull_request_review_id":98713216,"id":170081063,"diff_hunk":"@@ -58,6 +58,19 @@ def name(self):\n     def type(self):\n         return self._type\n \n+    def get_units(self, header):\n+        \"\"\"\n+        Extract BUNIT from header\n+        :param header: header\n+        :return: str: Shortened unit\n+        \"\"\"\n+        units = str(header['BUNIT'])\n+\n+        # Unit label shorten depending on data type here\n+        if 'MANGA' == self.type:\n+            units = units.replace(\"Ang\", \"A\")","path":"cubeviz/data_factories/__init__.py","position":14,"original_position":14,"commit_id":"e2d5e4974861ce5dcc8846eada5984129d743187","original_commit_id":"e2d5e4974861ce5dcc8846eada5984129d743187","user":{"login":"drdavella","id":2458487,"avatar_url":"https://avatars0.githubusercontent.com/u/2458487?v=4","gravatar_id":"","url":"https://api.github.com/users/drdavella","html_url":"https://github.com/drdavella","followers_url":"https://api.github.com/users/drdavella/followers","following_url":"https://api.github.com/users/drdavella/following{/other_user}","gists_url":"https://api.github.com/users/drdavella/gists{/gist_id}","starred_url":"https://api.github.com/users/drdavella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drdavella/subscriptions","organizations_url":"https://api.github.com/users/drdavella/orgs","repos_url":"https://api.github.com/users/drdavella/repos","events_url":"https://api.github.com/users/drdavella/events{/privacy}","received_events_url":"https://api.github.com/users/drdavella/received_events","type":"User","site_admin":false},"body":"It's maybe not that important right now, but it would probably be useful to encode this replacement logic in the data factory configuration file somehow.","created_at":"2018-02-22T20:18:13Z","updated_at":"2018-02-22T20:18:13Z","html_url":"https://github.com/spacetelescope/cubeviz/pull/248#discussion_r170081063","pull_request_url":"https://api.github.com/repos/spacetelescope/cubeviz/pulls/248","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/spacetelescope/cubeviz/pulls/comments/170081063"},"html":{"href":"https://github.com/spacetelescope/cubeviz/pull/248#discussion_r170081063"},"pull_request":{"href":"https://api.github.com/repos/spacetelescope/cubeviz/pulls/248"}}},"pull_request":{"url":"https://api.github.com/repos/spacetelescope/cubeviz/pulls/248","id":170838488,"html_url":"https://github.com/spacetelescope/cubeviz/pull/248","diff_url":"https://github.com/spacetelescope/cubeviz/pull/248.diff","patch_url":"https://github.com/spacetelescope/cubeviz/pull/248.patch","issue_url":"https://api.github.com/repos/spacetelescope/cubeviz/issues/248","number":248,"state":"open","locked":false,"title":"Flux Units","user":{"login":"robelgeda","id":10345916,"avatar_url":"https://avatars2.githubusercontent.com/u/10345916?v=4","gravatar_id":"","url":"https://api.github.com/users/robelgeda","html_url":"https://github.com/robelgeda","followers_url":"https://api.github.com/users/robelgeda/followers","following_url":"https://api.github.com/users/robelgeda/following{/other_user}","gists_url":"https://api.github.com/users/robelgeda/gists{/gist_id}","starred_url":"https://api.github.com/users/robelgeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robelgeda/subscriptions","organizations_url":"https://api.github.com/users/robelgeda/orgs","repos_url":"https://api.github.com/users/robelgeda/repos","events_url":"https://api.github.com/users/robelgeda/events{/privacy}","received_events_url":"https://api.github.com/users/robelgeda/received_events","type":"User","site_admin":false},"body":"Added flux units to each component's units (i.e. `component.units`) as a string. SpecViz y axes and the coordinate displays now show this information. The data factory looks for a `BUNIT` key in the data file headers for each component and adds the unit to `component.units` as a string. If no unit is there it will display an empty string. \r\n\r\nAlso, matplotlib messages and coordinate messages don't display at the same time on the status bar (they alternate), the matplotlib messages are hidden while the coords display is active and returns to the original status bar message one the mouse is out of the plotted area. ","created_at":"2018-02-22T19:06:18Z","updated_at":"2018-02-22T20:18:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a8570b0537dce6e32441a36a58bdb840518a8457","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nmearl","id":4141126,"avatar_url":"https://avatars2.githubusercontent.com/u/4141126?v=4","gravatar_id":"","url":"https://api.github.com/users/nmearl","html_url":"https://github.com/nmearl","followers_url":"https://api.github.com/users/nmearl/followers","following_url":"https://api.github.com/users/nmearl/following{/other_user}","gists_url":"https://api.github.com/users/nmearl/gists{/gist_id}","starred_url":"https://api.github.com/users/nmearl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmearl/subscriptions","organizations_url":"https://api.github.com/users/nmearl/orgs","repos_url":"https://api.github.com/users/nmearl/repos","events_url":"https://api.github.com/users/nmearl/events{/privacy}","received_events_url":"https://api.github.com/users/nmearl/received_events","type":"User","site_admin":false},{"login":"brechmos-stsci","id":18348847,"avatar_url":"https://avatars1.githubusercontent.com/u/18348847?v=4","gravatar_id":"","url":"https://api.github.com/users/brechmos-stsci","html_url":"https://github.com/brechmos-stsci","followers_url":"https://api.github.com/users/brechmos-stsci/followers","following_url":"https://api.github.com/users/brechmos-stsci/following{/other_user}","gists_url":"https://api.github.com/users/brechmos-stsci/gists{/gist_id}","starred_url":"https://api.github.com/users/brechmos-stsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brechmos-stsci/subscriptions","organizations_url":"https://api.github.com/users/brechmos-stsci/orgs","repos_url":"https://api.github.com/users/brechmos-stsci/repos","events_url":"https://api.github.com/users/brechmos-stsci/events{/privacy}","received_events_url":"https://api.github.com/users/brechmos-stsci/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spacetelescope/cubeviz/pulls/248/commits","review_comments_url":"https://api.github.com/repos/spacetelescope/cubeviz/pulls/248/comments","review_comment_url":"https://api.github.com/repos/spacetelescope/cubeviz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spacetelescope/cubeviz/issues/248/comments","statuses_url":"https://api.github.com/repos/spacetelescope/cubeviz/statuses/e2d5e4974861ce5dcc8846eada5984129d743187","head":{"label":"robelgeda:coords","ref":"coords","sha":"e2d5e4974861ce5dcc8846eada5984129d743187","user":{"login":"robelgeda","id":10345916,"avatar_url":"https://avatars2.githubusercontent.com/u/10345916?v=4","gravatar_id":"","url":"https://api.github.com/users/robelgeda","html_url":"https://github.com/robelgeda","followers_url":"https://api.github.com/users/robelgeda/followers","following_url":"https://api.github.com/users/robelgeda/following{/other_user}","gists_url":"https://api.github.com/users/robelgeda/gists{/gist_id}","starred_url":"https://api.github.com/users/robelgeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robelgeda/subscriptions","organizations_url":"https://api.github.com/users/robelgeda/orgs","repos_url":"https://api.github.com/users/robelgeda/repos","events_url":"https://api.github.com/users/robelgeda/events{/privacy}","received_events_url":"https://api.github.com/users/robelgeda/received_events","type":"User","site_admin":false},"repo":{"id":103183607,"name":"cubeviz","full_name":"robelgeda/cubeviz","owner":{"login":"robelgeda","id":10345916,"avatar_url":"https://avatars2.githubusercontent.com/u/10345916?v=4","gravatar_id":"","url":"https://api.github.com/users/robelgeda","html_url":"https://github.com/robelgeda","followers_url":"https://api.github.com/users/robelgeda/followers","following_url":"https://api.github.com/users/robelgeda/following{/other_user}","gists_url":"https://api.github.com/users/robelgeda/gists{/gist_id}","starred_url":"https://api.github.com/users/robelgeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robelgeda/subscriptions","organizations_url":"https://api.github.com/users/robelgeda/orgs","repos_url":"https://api.github.com/users/robelgeda/repos","events_url":"https://api.github.com/users/robelgeda/events{/privacy}","received_events_url":"https://api.github.com/users/robelgeda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robelgeda/cubeviz","description":"Data analysis package for cubes.","fork":true,"url":"https://api.github.com/repos/robelgeda/cubeviz","forks_url":"https://api.github.com/repos/robelgeda/cubeviz/forks","keys_url":"https://api.github.com/repos/robelgeda/cubeviz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robelgeda/cubeviz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robelgeda/cubeviz/teams","hooks_url":"https://api.github.com/repos/robelgeda/cubeviz/hooks","issue_events_url":"https://api.github.com/repos/robelgeda/cubeviz/issues/events{/number}","events_url":"https://api.github.com/repos/robelgeda/cubeviz/events","assignees_url":"https://api.github.com/repos/robelgeda/cubeviz/assignees{/user}","branches_url":"https://api.github.com/repos/robelgeda/cubeviz/branches{/branch}","tags_url":"https://api.github.com/repos/robelgeda/cubeviz/tags","blobs_url":"https://api.github.com/repos/robelgeda/cubeviz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robelgeda/cubeviz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robelgeda/cubeviz/git/refs{/sha}","trees_url":"https://api.github.com/repos/robelgeda/cubeviz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robelgeda/cubeviz/statuses/{sha}","languages_url":"https://api.github.com/repos/robelgeda/cubeviz/languages","stargazers_url":"https://api.github.com/repos/robelgeda/cubeviz/stargazers","contributors_url":"https://api.github.com/repos/robelgeda/cubeviz/contributors","subscribers_url":"https://api.github.com/repos/robelgeda/cubeviz/subscribers","subscription_url":"https://api.github.com/repos/robelgeda/cubeviz/subscription","commits_url":"https://api.github.com/repos/robelgeda/cubeviz/commits{/sha}","git_commits_url":"https://api.github.com/repos/robelgeda/cubeviz/git/commits{/sha}","comments_url":"https://api.github.com/repos/robelgeda/cubeviz/comments{/number}","issue_comment_url":"https://api.github.com/repos/robelgeda/cubeviz/issues/comments{/number}","contents_url":"https://api.github.com/repos/robelgeda/cubeviz/contents/{+path}","compare_url":"https://api.github.com/repos/robelgeda/cubeviz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robelgeda/cubeviz/merges","archive_url":"https://api.github.com/repos/robelgeda/cubeviz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robelgeda/cubeviz/downloads","issues_url":"https://api.github.com/repos/robelgeda/cubeviz/issues{/number}","pulls_url":"https://api.github.com/repos/robelgeda/cubeviz/pulls{/number}","milestones_url":"https://api.github.com/repos/robelgeda/cubeviz/milestones{/number}","notifications_url":"https://api.github.com/repos/robelgeda/cubeviz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robelgeda/cubeviz/labels{/name}","releases_url":"https://api.github.com/repos/robelgeda/cubeviz/releases{/id}","deployments_url":"https://api.github.com/repos/robelgeda/cubeviz/deployments","created_at":"2017-09-11T20:17:53Z","updated_at":"2017-09-11T20:17:55Z","pushed_at":"2018-02-22T19:40:15Z","git_url":"git://github.com/robelgeda/cubeviz.git","ssh_url":"git@github.com:robelgeda/cubeviz.git","clone_url":"https://github.com/robelgeda/cubeviz.git","svn_url":"https://github.com/robelgeda/cubeviz","homepage":null,"size":68203,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spacetelescope:master","ref":"master","sha":"5aebeef3e23a968d9465d16c9d17437adbf2ef68","user":{"login":"spacetelescope","id":2751928,"avatar_url":"https://avatars3.githubusercontent.com/u/2751928?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetelescope","html_url":"https://github.com/spacetelescope","followers_url":"https://api.github.com/users/spacetelescope/followers","following_url":"https://api.github.com/users/spacetelescope/following{/other_user}","gists_url":"https://api.github.com/users/spacetelescope/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetelescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetelescope/subscriptions","organizations_url":"https://api.github.com/users/spacetelescope/orgs","repos_url":"https://api.github.com/users/spacetelescope/repos","events_url":"https://api.github.com/users/spacetelescope/events{/privacy}","received_events_url":"https://api.github.com/users/spacetelescope/received_events","type":"Organization","site_admin":false},"repo":{"id":36305330,"name":"cubeviz","full_name":"spacetelescope/cubeviz","owner":{"login":"spacetelescope","id":2751928,"avatar_url":"https://avatars3.githubusercontent.com/u/2751928?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetelescope","html_url":"https://github.com/spacetelescope","followers_url":"https://api.github.com/users/spacetelescope/followers","following_url":"https://api.github.com/users/spacetelescope/following{/other_user}","gists_url":"https://api.github.com/users/spacetelescope/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetelescope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetelescope/subscriptions","organizations_url":"https://api.github.com/users/spacetelescope/orgs","repos_url":"https://api.github.com/users/spacetelescope/repos","events_url":"https://api.github.com/users/spacetelescope/events{/privacy}","received_events_url":"https://api.github.com/users/spacetelescope/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spacetelescope/cubeviz","description":"Data analysis package for cubes.","fork":false,"url":"https://api.github.com/repos/spacetelescope/cubeviz","forks_url":"https://api.github.com/repos/spacetelescope/cubeviz/forks","keys_url":"https://api.github.com/repos/spacetelescope/cubeviz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spacetelescope/cubeviz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spacetelescope/cubeviz/teams","hooks_url":"https://api.github.com/repos/spacetelescope/cubeviz/hooks","issue_events_url":"https://api.github.com/repos/spacetelescope/cubeviz/issues/events{/number}","events_url":"https://api.github.com/repos/spacetelescope/cubeviz/events","assignees_url":"https://api.github.com/repos/spacetelescope/cubeviz/assignees{/user}","branches_url":"https://api.github.com/repos/spacetelescope/cubeviz/branches{/branch}","tags_url":"https://api.github.com/repos/spacetelescope/cubeviz/tags","blobs_url":"https://api.github.com/repos/spacetelescope/cubeviz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spacetelescope/cubeviz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spacetelescope/cubeviz/git/refs{/sha}","trees_url":"https://api.github.com/repos/spacetelescope/cubeviz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spacetelescope/cubeviz/statuses/{sha}","languages_url":"https://api.github.com/repos/spacetelescope/cubeviz/languages","stargazers_url":"https://api.github.com/repos/spacetelescope/cubeviz/stargazers","contributors_url":"https://api.github.com/repos/spacetelescope/cubeviz/contributors","subscribers_url":"https://api.github.com/repos/spacetelescope/cubeviz/subscribers","subscription_url":"https://api.github.com/repos/spacetelescope/cubeviz/subscription","commits_url":"https://api.github.com/repos/spacetelescope/cubeviz/commits{/sha}","git_commits_url":"https://api.github.com/repos/spacetelescope/cubeviz/git/commits{/sha}","comments_url":"https://api.github.com/repos/spacetelescope/cubeviz/comments{/number}","issue_comment_url":"https://api.github.com/repos/spacetelescope/cubeviz/issues/comments{/number}","contents_url":"https://api.github.com/repos/spacetelescope/cubeviz/contents/{+path}","compare_url":"https://api.github.com/repos/spacetelescope/cubeviz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spacetelescope/cubeviz/merges","archive_url":"https://api.github.com/repos/spacetelescope/cubeviz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spacetelescope/cubeviz/downloads","issues_url":"https://api.github.com/repos/spacetelescope/cubeviz/issues{/number}","pulls_url":"https://api.github.com/repos/spacetelescope/cubeviz/pulls{/number}","milestones_url":"https://api.github.com/repos/spacetelescope/cubeviz/milestones{/number}","notifications_url":"https://api.github.com/repos/spacetelescope/cubeviz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spacetelescope/cubeviz/labels{/name}","releases_url":"https://api.github.com/repos/spacetelescope/cubeviz/releases{/id}","deployments_url":"https://api.github.com/repos/spacetelescope/cubeviz/deployments","created_at":"2015-05-26T15:29:57Z","updated_at":"2018-01-05T19:30:20Z","pushed_at":"2018-02-22T19:40:16Z","git_url":"git://github.com/spacetelescope/cubeviz.git","ssh_url":"git@github.com:spacetelescope/cubeviz.git","clone_url":"https://github.com/spacetelescope/cubeviz.git","svn_url":"https://github.com/spacetelescope/cubeviz","homepage":null,"size":68214,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":70,"license":null,"forks":15,"open_issues":70,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spacetelescope/cubeviz/pulls/248"},"html":{"href":"https://github.com/spacetelescope/cubeviz/pull/248"},"issue":{"href":"https://api.github.com/repos/spacetelescope/cubeviz/issues/248"},"comments":{"href":"https://api.github.com/repos/spacetelescope/cubeviz/issues/248/comments"},"review_comments":{"href":"https://api.github.com/repos/spacetelescope/cubeviz/pulls/248/comments"},"review_comment":{"href":"https://api.github.com/repos/spacetelescope/cubeviz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spacetelescope/cubeviz/pulls/248/commits"},"statuses":{"href":"https://api.github.com/repos/spacetelescope/cubeviz/statuses/e2d5e4974861ce5dcc8846eada5984129d743187"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"drdavella"}}