{"action":"created","issue":{"url":"https://api.github.com/repos/melt-umn/silver/issues/231","repository_url":"https://api.github.com/repos/melt-umn/silver","labels_url":"https://api.github.com/repos/melt-umn/silver/issues/231/labels{/name}","comments_url":"https://api.github.com/repos/melt-umn/silver/issues/231/comments","events_url":"https://api.github.com/repos/melt-umn/silver/issues/231/events","html_url":"https://github.com/melt-umn/silver/pull/231","id":305810052,"number":231,"title":"Fixes to built-in type conversion functions","user":{"login":"krame505","id":8467850,"avatar_url":"https://avatars3.githubusercontent.com/u/8467850?v=4","gravatar_id":"","url":"https://api.github.com/users/krame505","html_url":"https://github.com/krame505","followers_url":"https://api.github.com/users/krame505/followers","following_url":"https://api.github.com/users/krame505/following{/other_user}","gists_url":"https://api.github.com/users/krame505/gists{/gist_id}","starred_url":"https://api.github.com/users/krame505/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krame505/subscriptions","organizations_url":"https://api.github.com/users/krame505/orgs","repos_url":"https://api.github.com/users/krame505/repos","events_url":"https://api.github.com/users/krame505/events{/privacy}","received_events_url":"https://api.github.com/users/krame505/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-16T05:51:20Z","updated_at":"2018-03-17T22:06:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/melt-umn/silver/pulls/231","html_url":"https://github.com/melt-umn/silver/pull/231","diff_url":"https://github.com/melt-umn/silver/pull/231.diff","patch_url":"https://github.com/melt-umn/silver/pull/231.patch"},"body":"I ran into a bug where Silver crashes when translating `toInt(Boolean)`, so I decided to actually fix this.  I also implemented the `toBoolean` builtin function, converting `Integer`, `Float`, or `String` values to `Boolean` values.  \r\n\r\nThis still needs tests, but I figured I'd open a PR first to check if I'm on the right track.  \r\n\r\nWhile I'm fixing these conversion things, I've also been thinking of renaming `toInt` -> `toInteger` to be consistent, and depericating `toInt`.  Thoughts?  "},"comment":{"url":"https://api.github.com/repos/melt-umn/silver/issues/comments/373956370","html_url":"https://github.com/melt-umn/silver/pull/231#issuecomment-373956370","issue_url":"https://api.github.com/repos/melt-umn/silver/issues/231","id":373956370,"user":{"login":"krame505","id":8467850,"avatar_url":"https://avatars3.githubusercontent.com/u/8467850?v=4","gravatar_id":"","url":"https://api.github.com/users/krame505","html_url":"https://github.com/krame505","followers_url":"https://api.github.com/users/krame505/followers","following_url":"https://api.github.com/users/krame505/following{/other_user}","gists_url":"https://api.github.com/users/krame505/gists{/gist_id}","starred_url":"https://api.github.com/users/krame505/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krame505/subscriptions","organizations_url":"https://api.github.com/users/krame505/orgs","repos_url":"https://api.github.com/users/krame505/repos","events_url":"https://api.github.com/users/krame505/events{/privacy}","received_events_url":"https://api.github.com/users/krame505/received_events","type":"User","site_admin":false},"created_at":"2018-03-17T22:06:29Z","updated_at":"2018-03-17T22:06:29Z","author_association":"CONTRIBUTOR","body":"> I kinda dislike Float<->Boolean at all, but oh well.\r\nAgreed, but that would make type checking more complicated...\r\n\r\nI'll add `toInteger` and tests soon when I get a chance.  "}}
{"actor":{"display_login":"krame505"}}