{"action":"created","comment":{"url":"https://api.github.com/repos/elementary/switchboard-plug-networking/pulls/comments/178473935","pull_request_review_id":108534257,"id":178473935,"diff_hunk":"@@ -108,13 +113,27 @@ namespace Network.Widgets {\n                 try {\n                     device.disconnect (null);\n                 } catch (Error e) {\n-                    warning (e.message);\n+                    show_dialog (\n+                        _(\"Failed To Disconnect\"),\n+                        _(\"Could not disconnect: %s.\").printf (e.message),","path":"src/Widgets/Page.vala","position":37,"original_position":37,"commit_id":"fd9b2c376213f466e88cb66ebea097b159f3df2b","original_commit_id":"fd9b2c376213f466e88cb66ebea097b159f3df2b","user":{"login":"danrabbit","id":7277719,"avatar_url":"https://avatars3.githubusercontent.com/u/7277719?v=4","gravatar_id":"","url":"https://api.github.com/users/danrabbit","html_url":"https://github.com/danrabbit","followers_url":"https://api.github.com/users/danrabbit/followers","following_url":"https://api.github.com/users/danrabbit/following{/other_user}","gists_url":"https://api.github.com/users/danrabbit/gists{/gist_id}","starred_url":"https://api.github.com/users/danrabbit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrabbit/subscriptions","organizations_url":"https://api.github.com/users/danrabbit/orgs","repos_url":"https://api.github.com/users/danrabbit/repos","events_url":"https://api.github.com/users/danrabbit/events{/privacy}","received_events_url":"https://api.github.com/users/danrabbit/received_events","type":"User","site_admin":false},"body":"\"Failed to Disconnect\" and \"Could not disconnect\" are basically the same phrase. Probably don't need to repeat it :p ","created_at":"2018-04-02T00:59:27Z","updated_at":"2018-04-02T00:59:27Z","html_url":"https://github.com/elementary/switchboard-plug-networking/pull/118#discussion_r178473935","pull_request_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/pulls/118","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/elementary/switchboard-plug-networking/pulls/comments/178473935"},"html":{"href":"https://github.com/elementary/switchboard-plug-networking/pull/118#discussion_r178473935"},"pull_request":{"href":"https://api.github.com/repos/elementary/switchboard-plug-networking/pulls/118"}}},"pull_request":{"url":"https://api.github.com/repos/elementary/switchboard-plug-networking/pulls/118","id":178745165,"html_url":"https://github.com/elementary/switchboard-plug-networking/pull/118","diff_url":"https://github.com/elementary/switchboard-plug-networking/pull/118.diff","patch_url":"https://github.com/elementary/switchboard-plug-networking/pull/118.patch","issue_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/issues/118","number":118,"state":"open","locked":false,"title":"Refactor Page.vala","user":{"login":"donadigo","id":8205284,"avatar_url":"https://avatars3.githubusercontent.com/u/8205284?v=4","gravatar_id":"","url":"https://api.github.com/users/donadigo","html_url":"https://github.com/donadigo","followers_url":"https://api.github.com/users/donadigo/followers","following_url":"https://api.github.com/users/donadigo/following{/other_user}","gists_url":"https://api.github.com/users/donadigo/gists{/gist_id}","starred_url":"https://api.github.com/users/donadigo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/donadigo/subscriptions","organizations_url":"https://api.github.com/users/donadigo/orgs","repos_url":"https://api.github.com/users/donadigo/repos","events_url":"https://api.github.com/users/donadigo/events{/privacy}","received_events_url":"https://api.github.com/users/donadigo/received_events","type":"User","site_admin":false},"body":"* Show error dialogs on connection / disconnection failure\r\n* Remove unneded signal\r\n* Use `Path.build_filename` for building stats filenames\r\n* Remove `this.`\r\n* Use `warning` instead of `error`","created_at":"2018-04-01T20:05:54Z","updated_at":"2018-04-02T00:59:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d60882231b115d040a8e16b6a8c299a8480a7ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/pulls/118/commits","review_comments_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/pulls/118/comments","review_comment_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/issues/118/comments","statuses_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/statuses/fd9b2c376213f466e88cb66ebea097b159f3df2b","head":{"label":"elementary:refactor-page","ref":"refactor-page","sha":"fd9b2c376213f466e88cb66ebea097b159f3df2b","user":{"login":"elementary","id":1978534,"avatar_url":"https://avatars0.githubusercontent.com/u/1978534?v=4","gravatar_id":"","url":"https://api.github.com/users/elementary","html_url":"https://github.com/elementary","followers_url":"https://api.github.com/users/elementary/followers","following_url":"https://api.github.com/users/elementary/following{/other_user}","gists_url":"https://api.github.com/users/elementary/gists{/gist_id}","starred_url":"https://api.github.com/users/elementary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elementary/subscriptions","organizations_url":"https://api.github.com/users/elementary/orgs","repos_url":"https://api.github.com/users/elementary/repos","events_url":"https://api.github.com/users/elementary/events{/privacy}","received_events_url":"https://api.github.com/users/elementary/received_events","type":"Organization","site_admin":false},"repo":{"id":88916715,"name":"switchboard-plug-networking","full_name":"elementary/switchboard-plug-networking","owner":{"login":"elementary","id":1978534,"avatar_url":"https://avatars0.githubusercontent.com/u/1978534?v=4","gravatar_id":"","url":"https://api.github.com/users/elementary","html_url":"https://github.com/elementary","followers_url":"https://api.github.com/users/elementary/followers","following_url":"https://api.github.com/users/elementary/following{/other_user}","gists_url":"https://api.github.com/users/elementary/gists{/gist_id}","starred_url":"https://api.github.com/users/elementary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elementary/subscriptions","organizations_url":"https://api.github.com/users/elementary/orgs","repos_url":"https://api.github.com/users/elementary/repos","events_url":"https://api.github.com/users/elementary/events{/privacy}","received_events_url":"https://api.github.com/users/elementary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elementary/switchboard-plug-networking","description":"Switchboard Network Plug","fork":false,"url":"https://api.github.com/repos/elementary/switchboard-plug-networking","forks_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/forks","keys_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/teams","hooks_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/hooks","issue_events_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/issues/events{/number}","events_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/events","assignees_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/assignees{/user}","branches_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/branches{/branch}","tags_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/tags","blobs_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/git/refs{/sha}","trees_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/statuses/{sha}","languages_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/languages","stargazers_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/stargazers","contributors_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/contributors","subscribers_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/subscribers","subscription_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/subscription","commits_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/commits{/sha}","git_commits_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/git/commits{/sha}","comments_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/comments{/number}","issue_comment_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/issues/comments{/number}","contents_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/contents/{+path}","compare_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/merges","archive_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/downloads","issues_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/issues{/number}","pulls_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/pulls{/number}","milestones_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/milestones{/number}","notifications_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/labels{/name}","releases_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/releases{/id}","deployments_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/deployments","created_at":"2017-04-20T22:43:30Z","updated_at":"2018-04-01T19:47:17Z","pushed_at":"2018-04-01T20:06:01Z","git_url":"git://github.com/elementary/switchboard-plug-networking.git","ssh_url":"git@github.com:elementary/switchboard-plug-networking.git","clone_url":"https://github.com/elementary/switchboard-plug-networking.git","svn_url":"https://github.com/elementary/switchboard-plug-networking","homepage":null,"size":3457,"stargazers_count":3,"watchers_count":3,"language":"Vala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":4,"open_issues":62,"watchers":3,"default_branch":"master"}},"base":{"label":"elementary:master","ref":"master","sha":"1f0b497b9efa0cc589fe332181b78289740408fe","user":{"login":"elementary","id":1978534,"avatar_url":"https://avatars0.githubusercontent.com/u/1978534?v=4","gravatar_id":"","url":"https://api.github.com/users/elementary","html_url":"https://github.com/elementary","followers_url":"https://api.github.com/users/elementary/followers","following_url":"https://api.github.com/users/elementary/following{/other_user}","gists_url":"https://api.github.com/users/elementary/gists{/gist_id}","starred_url":"https://api.github.com/users/elementary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elementary/subscriptions","organizations_url":"https://api.github.com/users/elementary/orgs","repos_url":"https://api.github.com/users/elementary/repos","events_url":"https://api.github.com/users/elementary/events{/privacy}","received_events_url":"https://api.github.com/users/elementary/received_events","type":"Organization","site_admin":false},"repo":{"id":88916715,"name":"switchboard-plug-networking","full_name":"elementary/switchboard-plug-networking","owner":{"login":"elementary","id":1978534,"avatar_url":"https://avatars0.githubusercontent.com/u/1978534?v=4","gravatar_id":"","url":"https://api.github.com/users/elementary","html_url":"https://github.com/elementary","followers_url":"https://api.github.com/users/elementary/followers","following_url":"https://api.github.com/users/elementary/following{/other_user}","gists_url":"https://api.github.com/users/elementary/gists{/gist_id}","starred_url":"https://api.github.com/users/elementary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elementary/subscriptions","organizations_url":"https://api.github.com/users/elementary/orgs","repos_url":"https://api.github.com/users/elementary/repos","events_url":"https://api.github.com/users/elementary/events{/privacy}","received_events_url":"https://api.github.com/users/elementary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elementary/switchboard-plug-networking","description":"Switchboard Network Plug","fork":false,"url":"https://api.github.com/repos/elementary/switchboard-plug-networking","forks_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/forks","keys_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/teams","hooks_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/hooks","issue_events_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/issues/events{/number}","events_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/events","assignees_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/assignees{/user}","branches_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/branches{/branch}","tags_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/tags","blobs_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/git/refs{/sha}","trees_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/statuses/{sha}","languages_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/languages","stargazers_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/stargazers","contributors_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/contributors","subscribers_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/subscribers","subscription_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/subscription","commits_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/commits{/sha}","git_commits_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/git/commits{/sha}","comments_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/comments{/number}","issue_comment_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/issues/comments{/number}","contents_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/contents/{+path}","compare_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/merges","archive_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/downloads","issues_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/issues{/number}","pulls_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/pulls{/number}","milestones_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/milestones{/number}","notifications_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/labels{/name}","releases_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/releases{/id}","deployments_url":"https://api.github.com/repos/elementary/switchboard-plug-networking/deployments","created_at":"2017-04-20T22:43:30Z","updated_at":"2018-04-01T19:47:17Z","pushed_at":"2018-04-01T20:06:01Z","git_url":"git://github.com/elementary/switchboard-plug-networking.git","ssh_url":"git@github.com:elementary/switchboard-plug-networking.git","clone_url":"https://github.com/elementary/switchboard-plug-networking.git","svn_url":"https://github.com/elementary/switchboard-plug-networking","homepage":null,"size":3457,"stargazers_count":3,"watchers_count":3,"language":"Vala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":4,"open_issues":62,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elementary/switchboard-plug-networking/pulls/118"},"html":{"href":"https://github.com/elementary/switchboard-plug-networking/pull/118"},"issue":{"href":"https://api.github.com/repos/elementary/switchboard-plug-networking/issues/118"},"comments":{"href":"https://api.github.com/repos/elementary/switchboard-plug-networking/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/elementary/switchboard-plug-networking/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/elementary/switchboard-plug-networking/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elementary/switchboard-plug-networking/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/elementary/switchboard-plug-networking/statuses/fd9b2c376213f466e88cb66ebea097b159f3df2b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"danrabbit"}}