{"action":"created","issue":{"url":"https://api.github.com/repos/FormidableLabs/nuka-carousel/issues/68","repository_url":"https://api.github.com/repos/FormidableLabs/nuka-carousel","labels_url":"https://api.github.com/repos/FormidableLabs/nuka-carousel/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/FormidableLabs/nuka-carousel/issues/68/comments","events_url":"https://api.github.com/repos/FormidableLabs/nuka-carousel/issues/68/events","html_url":"https://github.com/FormidableLabs/nuka-carousel/pull/68","id":144145665,"node_id":"MDExOlB1bGxSZXF1ZXN0NjQ0MDkwNTI=","number":68,"title":"Refactor props.children.count to only include valid react elements","user":{"login":"lauriejones","id":11398624,"node_id":"MDQ6VXNlcjExMzk4NjI0","avatar_url":"https://avatars3.githubusercontent.com/u/11398624?v=4","gravatar_id":"","url":"https://api.github.com/users/lauriejones","html_url":"https://github.com/lauriejones","followers_url":"https://api.github.com/users/lauriejones/followers","following_url":"https://api.github.com/users/lauriejones/following{/other_user}","gists_url":"https://api.github.com/users/lauriejones/gists{/gist_id}","starred_url":"https://api.github.com/users/lauriejones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lauriejones/subscriptions","organizations_url":"https://api.github.com/users/lauriejones/orgs","repos_url":"https://api.github.com/users/lauriejones/repos","events_url":"https://api.github.com/users/lauriejones/events{/privacy}","received_events_url":"https://api.github.com/users/lauriejones/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2016-03-29T03:28:27Z","updated_at":"2018-07-17T20:59:28Z","closed_at":"2018-07-17T20:59:28Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/FormidableLabs/nuka-carousel/pulls/68","html_url":"https://github.com/FormidableLabs/nuka-carousel/pull/68","diff_url":"https://github.com/FormidableLabs/nuka-carousel/pull/68.diff","patch_url":"https://github.com/FormidableLabs/nuka-carousel/pull/68.patch"},"body":"Hi Ken -- Awesome carousel. Thanks very much for open-sourcing it.\n\nI am looking to use it in a project at work to swipe between a few products based on some filtering by a user.\n\nI had a small issue with how the slideCount is calculated.\n\nOur use case should show 3 products based on the user's choices. If our search returned less than 3 products we were displaying a message in place of the missing third product. If not, this just returned `null`. In this situation Nuka Carousel was adding an extra slide to the carousel for `null` so that we were always showing 4 slides instead of the 3 we should have been.\n\nThis solution checks that each of the children are valid elements before adding them to the count.\n\nI have adjusted the example to show the problem this PR solves. If you want to try the current version with an invalid element you'll see that it allows you to swipe to an empty slide.\n\nThanks again,\nLaurie\n"},"comment":{"url":"https://api.github.com/repos/FormidableLabs/nuka-carousel/issues/comments/405725958","html_url":"https://github.com/FormidableLabs/nuka-carousel/pull/68#issuecomment-405725958","issue_url":"https://api.github.com/repos/FormidableLabs/nuka-carousel/issues/68","id":405725958,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTcyNTk1OA==","user":{"login":"mariano-formidable","id":40646372,"node_id":"MDQ6VXNlcjQwNjQ2Mzcy","avatar_url":"https://avatars2.githubusercontent.com/u/40646372?v=4","gravatar_id":"","url":"https://api.github.com/users/mariano-formidable","html_url":"https://github.com/mariano-formidable","followers_url":"https://api.github.com/users/mariano-formidable/followers","following_url":"https://api.github.com/users/mariano-formidable/following{/other_user}","gists_url":"https://api.github.com/users/mariano-formidable/gists{/gist_id}","starred_url":"https://api.github.com/users/mariano-formidable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariano-formidable/subscriptions","organizations_url":"https://api.github.com/users/mariano-formidable/orgs","repos_url":"https://api.github.com/users/mariano-formidable/repos","events_url":"https://api.github.com/users/mariano-formidable/events{/privacy}","received_events_url":"https://api.github.com/users/mariano-formidable/received_events","type":"User","site_admin":false},"created_at":"2018-07-17T20:59:28Z","updated_at":"2018-07-17T20:59:28Z","author_association":"MEMBER","body":"Closing this PR because it's too old to merge, but addressing this issue in our current build under PR #379 "}}
{"actor":{"display_login":"mariano-formidable"}}