{"action":"closed","number":854,"pull_request":{"url":"https://api.github.com/repos/bhilburn/powerlevel9k/pulls/854","id":192080899,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMDgwODk5","html_url":"https://github.com/bhilburn/powerlevel9k/pull/854","diff_url":"https://github.com/bhilburn/powerlevel9k/pull/854.diff","patch_url":"https://github.com/bhilburn/powerlevel9k/pull/854.patch","issue_url":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/854","number":854,"state":"closed","locked":false,"title":"Fix icons cut off in some terminal emulators","user":{"login":"ytang","id":88049,"node_id":"MDQ6VXNlcjg4MDQ5","avatar_url":"https://avatars0.githubusercontent.com/u/88049?v=4","gravatar_id":"","url":"https://api.github.com/users/ytang","html_url":"https://github.com/ytang","followers_url":"https://api.github.com/users/ytang/followers","following_url":"https://api.github.com/users/ytang/following{/other_user}","gists_url":"https://api.github.com/users/ytang/gists{/gist_id}","starred_url":"https://api.github.com/users/ytang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ytang/subscriptions","organizations_url":"https://api.github.com/users/ytang/orgs","repos_url":"https://api.github.com/users/ytang/repos","events_url":"https://api.github.com/users/ytang/events{/privacy}","received_events_url":"https://api.github.com/users/ytang/received_events","type":"User","site_admin":false},"body":"For terminal emulators such as [suckless](https://st.suckless.org/), the most common scenario of icons being cut off is the virtual identifier before the segment content, even though there is a space between the icon and the text. The reason is that we add color only to the icon but not to the space next to it. To fix it, just add color to both the icon and its neighboring space. It allows the terminal emulator to render the icon correctly without introducing any visual side effects.\r\n\r\nHere is a screenshot showing the cut-off before (the first line) and after (the second line) applying the patch:\r\n![powerlevel9k-fix-icons-cut-off](https://user-images.githubusercontent.com/88049/40850943-ee3c920a-6593-11e8-8a32-460b922c1410.png)\r\n\r\nThis is superior to existing workarounds mentioned in #231 #453 #794 since we do not need to waste an extra space.","created_at":"2018-06-01T16:16:57Z","updated_at":"2018-07-10T17:34:53Z","closed_at":"2018-07-10T17:34:53Z","merged_at":"2018-07-10T17:34:53Z","merge_commit_sha":"9c4203bdf80440b43b5f559b5d8856f6b817ad9e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bhilburn/powerlevel9k/pulls/854/commits","review_comments_url":"https://api.github.com/repos/bhilburn/powerlevel9k/pulls/854/comments","review_comment_url":"https://api.github.com/repos/bhilburn/powerlevel9k/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/854/comments","statuses_url":"https://api.github.com/repos/bhilburn/powerlevel9k/statuses/9c4203bdf80440b43b5f559b5d8856f6b817ad9e","head":{"label":"ytang:fix-icons-cut-off","ref":"fix-icons-cut-off","sha":"9c4203bdf80440b43b5f559b5d8856f6b817ad9e","user":{"login":"ytang","id":88049,"node_id":"MDQ6VXNlcjg4MDQ5","avatar_url":"https://avatars0.githubusercontent.com/u/88049?v=4","gravatar_id":"","url":"https://api.github.com/users/ytang","html_url":"https://github.com/ytang","followers_url":"https://api.github.com/users/ytang/followers","following_url":"https://api.github.com/users/ytang/following{/other_user}","gists_url":"https://api.github.com/users/ytang/gists{/gist_id}","starred_url":"https://api.github.com/users/ytang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ytang/subscriptions","organizations_url":"https://api.github.com/users/ytang/orgs","repos_url":"https://api.github.com/users/ytang/repos","events_url":"https://api.github.com/users/ytang/events{/privacy}","received_events_url":"https://api.github.com/users/ytang/received_events","type":"User","site_admin":false},"repo":{"id":135735495,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3MzU0OTU=","name":"powerlevel9k","full_name":"ytang/powerlevel9k","owner":{"login":"ytang","id":88049,"node_id":"MDQ6VXNlcjg4MDQ5","avatar_url":"https://avatars0.githubusercontent.com/u/88049?v=4","gravatar_id":"","url":"https://api.github.com/users/ytang","html_url":"https://github.com/ytang","followers_url":"https://api.github.com/users/ytang/followers","following_url":"https://api.github.com/users/ytang/following{/other_user}","gists_url":"https://api.github.com/users/ytang/gists{/gist_id}","starred_url":"https://api.github.com/users/ytang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ytang/subscriptions","organizations_url":"https://api.github.com/users/ytang/orgs","repos_url":"https://api.github.com/users/ytang/repos","events_url":"https://api.github.com/users/ytang/events{/privacy}","received_events_url":"https://api.github.com/users/ytang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ytang/powerlevel9k","description":"The most awesome Powerline theme for ZSH around!","fork":true,"url":"https://api.github.com/repos/ytang/powerlevel9k","forks_url":"https://api.github.com/repos/ytang/powerlevel9k/forks","keys_url":"https://api.github.com/repos/ytang/powerlevel9k/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ytang/powerlevel9k/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ytang/powerlevel9k/teams","hooks_url":"https://api.github.com/repos/ytang/powerlevel9k/hooks","issue_events_url":"https://api.github.com/repos/ytang/powerlevel9k/issues/events{/number}","events_url":"https://api.github.com/repos/ytang/powerlevel9k/events","assignees_url":"https://api.github.com/repos/ytang/powerlevel9k/assignees{/user}","branches_url":"https://api.github.com/repos/ytang/powerlevel9k/branches{/branch}","tags_url":"https://api.github.com/repos/ytang/powerlevel9k/tags","blobs_url":"https://api.github.com/repos/ytang/powerlevel9k/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ytang/powerlevel9k/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ytang/powerlevel9k/git/refs{/sha}","trees_url":"https://api.github.com/repos/ytang/powerlevel9k/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ytang/powerlevel9k/statuses/{sha}","languages_url":"https://api.github.com/repos/ytang/powerlevel9k/languages","stargazers_url":"https://api.github.com/repos/ytang/powerlevel9k/stargazers","contributors_url":"https://api.github.com/repos/ytang/powerlevel9k/contributors","subscribers_url":"https://api.github.com/repos/ytang/powerlevel9k/subscribers","subscription_url":"https://api.github.com/repos/ytang/powerlevel9k/subscription","commits_url":"https://api.github.com/repos/ytang/powerlevel9k/commits{/sha}","git_commits_url":"https://api.github.com/repos/ytang/powerlevel9k/git/commits{/sha}","comments_url":"https://api.github.com/repos/ytang/powerlevel9k/comments{/number}","issue_comment_url":"https://api.github.com/repos/ytang/powerlevel9k/issues/comments{/number}","contents_url":"https://api.github.com/repos/ytang/powerlevel9k/contents/{+path}","compare_url":"https://api.github.com/repos/ytang/powerlevel9k/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ytang/powerlevel9k/merges","archive_url":"https://api.github.com/repos/ytang/powerlevel9k/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ytang/powerlevel9k/downloads","issues_url":"https://api.github.com/repos/ytang/powerlevel9k/issues{/number}","pulls_url":"https://api.github.com/repos/ytang/powerlevel9k/pulls{/number}","milestones_url":"https://api.github.com/repos/ytang/powerlevel9k/milestones{/number}","notifications_url":"https://api.github.com/repos/ytang/powerlevel9k/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ytang/powerlevel9k/labels{/name}","releases_url":"https://api.github.com/repos/ytang/powerlevel9k/releases{/id}","deployments_url":"https://api.github.com/repos/ytang/powerlevel9k/deployments","created_at":"2018-06-01T15:38:52Z","updated_at":"2018-06-01T15:38:54Z","pushed_at":"2018-06-01T18:19:37Z","git_url":"git://github.com/ytang/powerlevel9k.git","ssh_url":"git@github.com:ytang/powerlevel9k.git","clone_url":"https://github.com/ytang/powerlevel9k.git","svn_url":"https://github.com/ytang/powerlevel9k","homepage":"","size":1607,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bhilburn:master","ref":"master","sha":"0e3c1924fe40835dfe189227b8a165de147e65a1","user":{"login":"bhilburn","id":569571,"node_id":"MDQ6VXNlcjU2OTU3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/569571?v=4","gravatar_id":"","url":"https://api.github.com/users/bhilburn","html_url":"https://github.com/bhilburn","followers_url":"https://api.github.com/users/bhilburn/followers","following_url":"https://api.github.com/users/bhilburn/following{/other_user}","gists_url":"https://api.github.com/users/bhilburn/gists{/gist_id}","starred_url":"https://api.github.com/users/bhilburn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhilburn/subscriptions","organizations_url":"https://api.github.com/users/bhilburn/orgs","repos_url":"https://api.github.com/users/bhilburn/repos","events_url":"https://api.github.com/users/bhilburn/events{/privacy}","received_events_url":"https://api.github.com/users/bhilburn/received_events","type":"User","site_admin":false},"repo":{"id":30003816,"node_id":"MDEwOlJlcG9zaXRvcnkzMDAwMzgxNg==","name":"powerlevel9k","full_name":"bhilburn/powerlevel9k","owner":{"login":"bhilburn","id":569571,"node_id":"MDQ6VXNlcjU2OTU3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/569571?v=4","gravatar_id":"","url":"https://api.github.com/users/bhilburn","html_url":"https://github.com/bhilburn","followers_url":"https://api.github.com/users/bhilburn/followers","following_url":"https://api.github.com/users/bhilburn/following{/other_user}","gists_url":"https://api.github.com/users/bhilburn/gists{/gist_id}","starred_url":"https://api.github.com/users/bhilburn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhilburn/subscriptions","organizations_url":"https://api.github.com/users/bhilburn/orgs","repos_url":"https://api.github.com/users/bhilburn/repos","events_url":"https://api.github.com/users/bhilburn/events{/privacy}","received_events_url":"https://api.github.com/users/bhilburn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bhilburn/powerlevel9k","description":"The most awesome Powerline theme for ZSH around!","fork":false,"url":"https://api.github.com/repos/bhilburn/powerlevel9k","forks_url":"https://api.github.com/repos/bhilburn/powerlevel9k/forks","keys_url":"https://api.github.com/repos/bhilburn/powerlevel9k/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bhilburn/powerlevel9k/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bhilburn/powerlevel9k/teams","hooks_url":"https://api.github.com/repos/bhilburn/powerlevel9k/hooks","issue_events_url":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/events{/number}","events_url":"https://api.github.com/repos/bhilburn/powerlevel9k/events","assignees_url":"https://api.github.com/repos/bhilburn/powerlevel9k/assignees{/user}","branches_url":"https://api.github.com/repos/bhilburn/powerlevel9k/branches{/branch}","tags_url":"https://api.github.com/repos/bhilburn/powerlevel9k/tags","blobs_url":"https://api.github.com/repos/bhilburn/powerlevel9k/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bhilburn/powerlevel9k/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bhilburn/powerlevel9k/git/refs{/sha}","trees_url":"https://api.github.com/repos/bhilburn/powerlevel9k/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bhilburn/powerlevel9k/statuses/{sha}","languages_url":"https://api.github.com/repos/bhilburn/powerlevel9k/languages","stargazers_url":"https://api.github.com/repos/bhilburn/powerlevel9k/stargazers","contributors_url":"https://api.github.com/repos/bhilburn/powerlevel9k/contributors","subscribers_url":"https://api.github.com/repos/bhilburn/powerlevel9k/subscribers","subscription_url":"https://api.github.com/repos/bhilburn/powerlevel9k/subscription","commits_url":"https://api.github.com/repos/bhilburn/powerlevel9k/commits{/sha}","git_commits_url":"https://api.github.com/repos/bhilburn/powerlevel9k/git/commits{/sha}","comments_url":"https://api.github.com/repos/bhilburn/powerlevel9k/comments{/number}","issue_comment_url":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/comments{/number}","contents_url":"https://api.github.com/repos/bhilburn/powerlevel9k/contents/{+path}","compare_url":"https://api.github.com/repos/bhilburn/powerlevel9k/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bhilburn/powerlevel9k/merges","archive_url":"https://api.github.com/repos/bhilburn/powerlevel9k/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bhilburn/powerlevel9k/downloads","issues_url":"https://api.github.com/repos/bhilburn/powerlevel9k/issues{/number}","pulls_url":"https://api.github.com/repos/bhilburn/powerlevel9k/pulls{/number}","milestones_url":"https://api.github.com/repos/bhilburn/powerlevel9k/milestones{/number}","notifications_url":"https://api.github.com/repos/bhilburn/powerlevel9k/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bhilburn/powerlevel9k/labels{/name}","releases_url":"https://api.github.com/repos/bhilburn/powerlevel9k/releases{/id}","deployments_url":"https://api.github.com/repos/bhilburn/powerlevel9k/deployments","created_at":"2015-01-29T04:36:00Z","updated_at":"2018-07-10T17:04:43Z","pushed_at":"2018-07-10T17:34:46Z","git_url":"git://github.com/bhilburn/powerlevel9k.git","ssh_url":"git@github.com:bhilburn/powerlevel9k.git","clone_url":"https://github.com/bhilburn/powerlevel9k.git","svn_url":"https://github.com/bhilburn/powerlevel9k","homepage":"","size":1702,"stargazers_count":5283,"watchers_count":5283,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":450,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":450,"open_issues":104,"watchers":5283,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bhilburn/powerlevel9k/pulls/854"},"html":{"href":"https://github.com/bhilburn/powerlevel9k/pull/854"},"issue":{"href":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/854"},"comments":{"href":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/854/comments"},"review_comments":{"href":"https://api.github.com/repos/bhilburn/powerlevel9k/pulls/854/comments"},"review_comment":{"href":"https://api.github.com/repos/bhilburn/powerlevel9k/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bhilburn/powerlevel9k/pulls/854/commits"},"statuses":{"href":"https://api.github.com/repos/bhilburn/powerlevel9k/statuses/9c4203bdf80440b43b5f559b5d8856f6b817ad9e"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bhilburn","id":569571,"node_id":"MDQ6VXNlcjU2OTU3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/569571?v=4","gravatar_id":"","url":"https://api.github.com/users/bhilburn","html_url":"https://github.com/bhilburn","followers_url":"https://api.github.com/users/bhilburn/followers","following_url":"https://api.github.com/users/bhilburn/following{/other_user}","gists_url":"https://api.github.com/users/bhilburn/gists{/gist_id}","starred_url":"https://api.github.com/users/bhilburn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhilburn/subscriptions","organizations_url":"https://api.github.com/users/bhilburn/orgs","repos_url":"https://api.github.com/users/bhilburn/repos","events_url":"https://api.github.com/users/bhilburn/events{/privacy}","received_events_url":"https://api.github.com/users/bhilburn/received_events","type":"User","site_admin":false},"comments":4,"review_comments":4,"maintainer_can_modify":false,"commits":3,"additions":25,"deletions":21,"changed_files":6}}
{"actor":{"display_login":"bhilburn"}}