{"action":"created","comment":{"url":"https://api.github.com/repos/EFForg/privacybadger/pulls/comments/218984956","pull_request_review_id":157045535,"id":218984956,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODk4NDk1Ng==","diff_hunk":"@@ -239,9 +239,15 @@ Badger.prototype = {\n       };\n     }\n \n+    let host = window.extractHostFromURL(frameUrl);\n+    //if frame URL is 'about:blank', inherit parent host\n+    if (frameUrl === \"about:blank\") {\n+      host = self.tabData[tabId].frames[parentFrameId].host;","path":"src/js/background.js","position":7,"original_position":7,"commit_id":"0a8722fb0f0966e1fcab578fc2b3f6daec1a4f23","original_commit_id":"0a8722fb0f0966e1fcab578fc2b3f6daec1a4f23","user":{"login":"ghostwords","id":794578,"node_id":"MDQ6VXNlcjc5NDU3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/794578?v=4","gravatar_id":"","url":"https://api.github.com/users/ghostwords","html_url":"https://github.com/ghostwords","followers_url":"https://api.github.com/users/ghostwords/followers","following_url":"https://api.github.com/users/ghostwords/following{/other_user}","gists_url":"https://api.github.com/users/ghostwords/gists{/gist_id}","starred_url":"https://api.github.com/users/ghostwords/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghostwords/subscriptions","organizations_url":"https://api.github.com/users/ghostwords/orgs","repos_url":"https://api.github.com/users/ghostwords/repos","events_url":"https://api.github.com/users/ghostwords/events{/privacy}","received_events_url":"https://api.github.com/users/ghostwords/received_events","type":"User","site_admin":false},"body":"It would be great if we could make `tabData.frames` reliable but if we can't for now, should we instead travel up the document tree inside the localStorage content script and get the first http/https parent frame's URL and send that together with what we currently send to the background page?","created_at":"2018-09-19T22:30:50Z","updated_at":"2018-09-19T22:31:22Z","html_url":"https://github.com/EFForg/privacybadger/pull/2167#discussion_r218984956","pull_request_url":"https://api.github.com/repos/EFForg/privacybadger/pulls/2167","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/EFForg/privacybadger/pulls/comments/218984956"},"html":{"href":"https://github.com/EFForg/privacybadger/pull/2167#discussion_r218984956"},"pull_request":{"href":"https://api.github.com/repos/EFForg/privacybadger/pulls/2167"}},"in_reply_to_id":218982802},"pull_request":{"url":"https://api.github.com/repos/EFForg/privacybadger/pulls/2167","id":216777248,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2Nzc3MjQ4","html_url":"https://github.com/EFForg/privacybadger/pull/2167","diff_url":"https://github.com/EFForg/privacybadger/pull/2167.diff","patch_url":"https://github.com/EFForg/privacybadger/pull/2167.patch","issue_url":"https://api.github.com/repos/EFForg/privacybadger/issues/2167","number":2167,"state":"open","locked":false,"title":"Use parent host for about:blank frames","user":{"login":"Jsnhlbr5","id":4733108,"node_id":"MDQ6VXNlcjQ3MzMxMDg=","avatar_url":"https://avatars3.githubusercontent.com/u/4733108?v=4","gravatar_id":"","url":"https://api.github.com/users/Jsnhlbr5","html_url":"https://github.com/Jsnhlbr5","followers_url":"https://api.github.com/users/Jsnhlbr5/followers","following_url":"https://api.github.com/users/Jsnhlbr5/following{/other_user}","gists_url":"https://api.github.com/users/Jsnhlbr5/gists{/gist_id}","starred_url":"https://api.github.com/users/Jsnhlbr5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jsnhlbr5/subscriptions","organizations_url":"https://api.github.com/users/Jsnhlbr5/orgs","repos_url":"https://api.github.com/users/Jsnhlbr5/repos","events_url":"https://api.github.com/users/Jsnhlbr5/events{/privacy}","received_events_url":"https://api.github.com/users/Jsnhlbr5/received_events","type":"User","site_admin":false},"body":"When recording frames into badger's frame data, use the parent frame's\r\nhost for frames with a URL of 'about:blank', and then use the frame data\r\nfor sender.frameId instead of sender.url when dealing with subframes.\r\nThis records a useful entry for supercookies (and possibly others),\r\ninstead of '' caused by a failure to parse 'about:blank' as a URL.\r\n\r\nFixes #1447 ","created_at":"2018-09-19T21:08:58Z","updated_at":"2018-09-19T22:31:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01b98ad763817518fd06a6ab710e666da883f8b2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/EFForg/privacybadger/pulls/2167/commits","review_comments_url":"https://api.github.com/repos/EFForg/privacybadger/pulls/2167/comments","review_comment_url":"https://api.github.com/repos/EFForg/privacybadger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EFForg/privacybadger/issues/2167/comments","statuses_url":"https://api.github.com/repos/EFForg/privacybadger/statuses/0a8722fb0f0966e1fcab578fc2b3f6daec1a4f23","head":{"label":"Jsnhlbr5:handle-about-blank-frames","ref":"handle-about-blank-frames","sha":"0a8722fb0f0966e1fcab578fc2b3f6daec1a4f23","user":{"login":"Jsnhlbr5","id":4733108,"node_id":"MDQ6VXNlcjQ3MzMxMDg=","avatar_url":"https://avatars3.githubusercontent.com/u/4733108?v=4","gravatar_id":"","url":"https://api.github.com/users/Jsnhlbr5","html_url":"https://github.com/Jsnhlbr5","followers_url":"https://api.github.com/users/Jsnhlbr5/followers","following_url":"https://api.github.com/users/Jsnhlbr5/following{/other_user}","gists_url":"https://api.github.com/users/Jsnhlbr5/gists{/gist_id}","starred_url":"https://api.github.com/users/Jsnhlbr5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jsnhlbr5/subscriptions","organizations_url":"https://api.github.com/users/Jsnhlbr5/orgs","repos_url":"https://api.github.com/users/Jsnhlbr5/repos","events_url":"https://api.github.com/users/Jsnhlbr5/events{/privacy}","received_events_url":"https://api.github.com/users/Jsnhlbr5/received_events","type":"User","site_admin":false},"repo":{"id":146336170,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYzMzYxNzA=","name":"privacybadger","full_name":"Jsnhlbr5/privacybadger","private":false,"owner":{"login":"Jsnhlbr5","id":4733108,"node_id":"MDQ6VXNlcjQ3MzMxMDg=","avatar_url":"https://avatars3.githubusercontent.com/u/4733108?v=4","gravatar_id":"","url":"https://api.github.com/users/Jsnhlbr5","html_url":"https://github.com/Jsnhlbr5","followers_url":"https://api.github.com/users/Jsnhlbr5/followers","following_url":"https://api.github.com/users/Jsnhlbr5/following{/other_user}","gists_url":"https://api.github.com/users/Jsnhlbr5/gists{/gist_id}","starred_url":"https://api.github.com/users/Jsnhlbr5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jsnhlbr5/subscriptions","organizations_url":"https://api.github.com/users/Jsnhlbr5/orgs","repos_url":"https://api.github.com/users/Jsnhlbr5/repos","events_url":"https://api.github.com/users/Jsnhlbr5/events{/privacy}","received_events_url":"https://api.github.com/users/Jsnhlbr5/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Jsnhlbr5/privacybadger","description":"Privacy Badger is a browser extension that automatically learns to block invisible trackers.","fork":true,"url":"https://api.github.com/repos/Jsnhlbr5/privacybadger","forks_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/forks","keys_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/teams","hooks_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/hooks","issue_events_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/issues/events{/number}","events_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/events","assignees_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/assignees{/user}","branches_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/branches{/branch}","tags_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/tags","blobs_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/statuses/{sha}","languages_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/languages","stargazers_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/stargazers","contributors_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/contributors","subscribers_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/subscribers","subscription_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/subscription","commits_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/contents/{+path}","compare_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/merges","archive_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/downloads","issues_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/issues{/number}","pulls_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/pulls{/number}","milestones_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/milestones{/number}","notifications_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/labels{/name}","releases_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/releases{/id}","deployments_url":"https://api.github.com/repos/Jsnhlbr5/privacybadger/deployments","created_at":"2018-08-27T18:14:02Z","updated_at":"2018-09-19T00:34:40Z","pushed_at":"2018-09-19T21:07:09Z","git_url":"git://github.com/Jsnhlbr5/privacybadger.git","ssh_url":"git@github.com:Jsnhlbr5/privacybadger.git","clone_url":"https://github.com/Jsnhlbr5/privacybadger.git","svn_url":"https://github.com/Jsnhlbr5/privacybadger","homepage":"https://www.eff.org/pb","size":26212,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EFForg:master","ref":"master","sha":"683bcf379a9e9c199ef4e4c0f6b58864e2691495","user":{"login":"EFForg","id":2120271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjAyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/2120271?v=4","gravatar_id":"","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"repo":{"id":11321096,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMyMTA5Ng==","name":"privacybadger","full_name":"EFForg/privacybadger","private":false,"owner":{"login":"EFForg","id":2120271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjAyNzE=","avatar_url":"https://avatars3.githubusercontent.com/u/2120271?v=4","gravatar_id":"","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EFForg/privacybadger","description":"Privacy Badger is a browser extension that automatically learns to block invisible trackers.","fork":false,"url":"https://api.github.com/repos/EFForg/privacybadger","forks_url":"https://api.github.com/repos/EFForg/privacybadger/forks","keys_url":"https://api.github.com/repos/EFForg/privacybadger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EFForg/privacybadger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EFForg/privacybadger/teams","hooks_url":"https://api.github.com/repos/EFForg/privacybadger/hooks","issue_events_url":"https://api.github.com/repos/EFForg/privacybadger/issues/events{/number}","events_url":"https://api.github.com/repos/EFForg/privacybadger/events","assignees_url":"https://api.github.com/repos/EFForg/privacybadger/assignees{/user}","branches_url":"https://api.github.com/repos/EFForg/privacybadger/branches{/branch}","tags_url":"https://api.github.com/repos/EFForg/privacybadger/tags","blobs_url":"https://api.github.com/repos/EFForg/privacybadger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EFForg/privacybadger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EFForg/privacybadger/git/refs{/sha}","trees_url":"https://api.github.com/repos/EFForg/privacybadger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EFForg/privacybadger/statuses/{sha}","languages_url":"https://api.github.com/repos/EFForg/privacybadger/languages","stargazers_url":"https://api.github.com/repos/EFForg/privacybadger/stargazers","contributors_url":"https://api.github.com/repos/EFForg/privacybadger/contributors","subscribers_url":"https://api.github.com/repos/EFForg/privacybadger/subscribers","subscription_url":"https://api.github.com/repos/EFForg/privacybadger/subscription","commits_url":"https://api.github.com/repos/EFForg/privacybadger/commits{/sha}","git_commits_url":"https://api.github.com/repos/EFForg/privacybadger/git/commits{/sha}","comments_url":"https://api.github.com/repos/EFForg/privacybadger/comments{/number}","issue_comment_url":"https://api.github.com/repos/EFForg/privacybadger/issues/comments{/number}","contents_url":"https://api.github.com/repos/EFForg/privacybadger/contents/{+path}","compare_url":"https://api.github.com/repos/EFForg/privacybadger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EFForg/privacybadger/merges","archive_url":"https://api.github.com/repos/EFForg/privacybadger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EFForg/privacybadger/downloads","issues_url":"https://api.github.com/repos/EFForg/privacybadger/issues{/number}","pulls_url":"https://api.github.com/repos/EFForg/privacybadger/pulls{/number}","milestones_url":"https://api.github.com/repos/EFForg/privacybadger/milestones{/number}","notifications_url":"https://api.github.com/repos/EFForg/privacybadger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EFForg/privacybadger/labels{/name}","releases_url":"https://api.github.com/repos/EFForg/privacybadger/releases{/id}","deployments_url":"https://api.github.com/repos/EFForg/privacybadger/deployments","created_at":"2013-07-10T18:59:11Z","updated_at":"2018-09-19T13:55:10Z","pushed_at":"2018-09-19T21:08:59Z","git_url":"git://github.com/EFForg/privacybadger.git","ssh_url":"git@github.com:EFForg/privacybadger.git","clone_url":"https://github.com/EFForg/privacybadger.git","svn_url":"https://github.com/EFForg/privacybadger","homepage":"https://www.eff.org/pb","size":26219,"stargazers_count":1184,"watchers_count":1184,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":236,"mirror_url":null,"archived":false,"open_issues_count":275,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":236,"open_issues":275,"watchers":1184,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EFForg/privacybadger/pulls/2167"},"html":{"href":"https://github.com/EFForg/privacybadger/pull/2167"},"issue":{"href":"https://api.github.com/repos/EFForg/privacybadger/issues/2167"},"comments":{"href":"https://api.github.com/repos/EFForg/privacybadger/issues/2167/comments"},"review_comments":{"href":"https://api.github.com/repos/EFForg/privacybadger/pulls/2167/comments"},"review_comment":{"href":"https://api.github.com/repos/EFForg/privacybadger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EFForg/privacybadger/pulls/2167/commits"},"statuses":{"href":"https://api.github.com/repos/EFForg/privacybadger/statuses/0a8722fb0f0966e1fcab578fc2b3f6daec1a4f23"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ghostwords"}}