{"action":"created","comment":{"url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/pulls/comments/172055050","pull_request_review_id":101011327,"id":172055050,"diff_hunk":"@@ -89,6 +89,9 @@ const audqt::MenuItem StatusIcon::items[] =\n     audqt::MenuSep (),\n     audqt::MenuCommand ({N_(\"_Open Files ...\"), \"document-open\"}, StatusIcon::open_files),\n     audqt::MenuCommand ({N_(\"Se_ttings ...\"), \"preferences-system\"}, audqt::prefswin_show),\n+#ifdef Q_OS_MACOS\n+    audqt::MenuCommand ({N_(\"_Hide\"), \"hide-application\"}, StatusIcon::toggle_aud_ui),","path":"src/statusicon-qt/statusicon.cc","position":5,"original_position":5,"commit_id":"89fbc5e83a7693951b89d39e6a0f457884808970","original_commit_id":"c77b7f230dd4dac93d1c52c2212d7228236eb5cc","user":{"login":"RJVB","id":1756884,"avatar_url":"https://avatars0.githubusercontent.com/u/1756884?v=4","gravatar_id":"","url":"https://api.github.com/users/RJVB","html_url":"https://github.com/RJVB","followers_url":"https://api.github.com/users/RJVB/followers","following_url":"https://api.github.com/users/RJVB/following{/other_user}","gists_url":"https://api.github.com/users/RJVB/gists{/gist_id}","starred_url":"https://api.github.com/users/RJVB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJVB/subscriptions","organizations_url":"https://api.github.com/users/RJVB/orgs","repos_url":"https://api.github.com/users/RJVB/repos","events_url":"https://api.github.com/users/RJVB/events{/privacy}","received_events_url":"https://api.github.com/users/RJVB/received_events","type":"User","site_admin":false},"body":"No, \"Hide\" is the proper platform terminology, but there's actually no need for an extra platform-specific item here. There's already a \"Hide Audacious\" item with shortcut in the Application menu (provided by the OS).","created_at":"2018-03-04T16:37:49Z","updated_at":"2018-03-04T16:37:49Z","html_url":"https://github.com/audacious-media-player/audacious-plugins/pull/63#discussion_r172055050","pull_request_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/pulls/63","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/audacious-media-player/audacious-plugins/pulls/comments/172055050"},"html":{"href":"https://github.com/audacious-media-player/audacious-plugins/pull/63#discussion_r172055050"},"pull_request":{"href":"https://api.github.com/repos/audacious-media-player/audacious-plugins/pulls/63"}},"in_reply_to_id":163745142},"pull_request":{"url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/pulls/63","id":163508689,"html_url":"https://github.com/audacious-media-player/audacious-plugins/pull/63","diff_url":"https://github.com/audacious-media-player/audacious-plugins/pull/63.diff","patch_url":"https://github.com/audacious-media-player/audacious-plugins/pull/63.patch","issue_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/issues/63","number":63,"state":"open","locked":false,"title":"Mac/CoreAudio improvements","user":{"login":"RJVB","id":1756884,"avatar_url":"https://avatars0.githubusercontent.com/u/1756884?v=4","gravatar_id":"","url":"https://api.github.com/users/RJVB","html_url":"https://github.com/RJVB","followers_url":"https://api.github.com/users/RJVB/followers","following_url":"https://api.github.com/users/RJVB/following{/other_user}","gists_url":"https://api.github.com/users/RJVB/gists{/gist_id}","starred_url":"https://api.github.com/users/RJVB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJVB/subscriptions","organizations_url":"https://api.github.com/users/RJVB/orgs","repos_url":"https://api.github.com/users/RJVB/repos","events_url":"https://api.github.com/users/RJVB/events{/privacy}","received_events_url":"https://api.github.com/users/RJVB/received_events","type":"User","site_admin":false},"body":"This is a companion to https://github.com/audacious-media-player/audacious/pull/29\r\n\r\nLike that PR this englobes a number of patches aimed at improving the Mac/Qt version of the player (plus the build system update). The main changes:\r\n\r\n- fixes the CoreAudio plugin (it didn't play for me, and apparently not just for me)\r\n- look, menu and systray tweaks; use of more appropriate fonts, alternatives for a few missing icons in the QtUI theme (text-labelled buttons), clickable playlist headers, rich-text support in the search widget.\r\n- support for a simple form of bitperfect audio output over CoreAudio, where the current default output device is switched to the sample rate of the content being played (or an appropriate multiple that should reduce beating and aliasing).\r\n\r\nI've considered adding a device selection UI like the one in the ALSA plugin, but dropped that idea for now as the Mac already has 3 easy mechanisms for audio device selection; users who have multiple devices are bound to be familiar with them.\r\n\r\nIt would be nice if the Sort menu actions were coupled to the playlist headers (and incidentally, got checkmarks to show the current sorting method).\r\n","created_at":"2018-01-17T17:45:50Z","updated_at":"2018-03-04T16:37:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"70df4b9bc3abe1924da836afbcc25f4cb80e7ec3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/pulls/63/commits","review_comments_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/pulls/63/comments","review_comment_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/issues/63/comments","statuses_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/statuses/89fbc5e83a7693951b89d39e6a0f457884808970","head":{"label":"RJVB:RJVB-MP-Qt","ref":"RJVB-MP-Qt","sha":"89fbc5e83a7693951b89d39e6a0f457884808970","user":{"login":"RJVB","id":1756884,"avatar_url":"https://avatars0.githubusercontent.com/u/1756884?v=4","gravatar_id":"","url":"https://api.github.com/users/RJVB","html_url":"https://github.com/RJVB","followers_url":"https://api.github.com/users/RJVB/followers","following_url":"https://api.github.com/users/RJVB/following{/other_user}","gists_url":"https://api.github.com/users/RJVB/gists{/gist_id}","starred_url":"https://api.github.com/users/RJVB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJVB/subscriptions","organizations_url":"https://api.github.com/users/RJVB/orgs","repos_url":"https://api.github.com/users/RJVB/repos","events_url":"https://api.github.com/users/RJVB/events{/privacy}","received_events_url":"https://api.github.com/users/RJVB/received_events","type":"User","site_admin":false},"repo":{"id":117557035,"name":"audacious-plugins","full_name":"RJVB/audacious-plugins","owner":{"login":"RJVB","id":1756884,"avatar_url":"https://avatars0.githubusercontent.com/u/1756884?v=4","gravatar_id":"","url":"https://api.github.com/users/RJVB","html_url":"https://github.com/RJVB","followers_url":"https://api.github.com/users/RJVB/followers","following_url":"https://api.github.com/users/RJVB/following{/other_user}","gists_url":"https://api.github.com/users/RJVB/gists{/gist_id}","starred_url":"https://api.github.com/users/RJVB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJVB/subscriptions","organizations_url":"https://api.github.com/users/RJVB/orgs","repos_url":"https://api.github.com/users/RJVB/repos","events_url":"https://api.github.com/users/RJVB/events{/privacy}","received_events_url":"https://api.github.com/users/RJVB/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RJVB/audacious-plugins","description":"Plugins for Audacious music player","fork":true,"url":"https://api.github.com/repos/RJVB/audacious-plugins","forks_url":"https://api.github.com/repos/RJVB/audacious-plugins/forks","keys_url":"https://api.github.com/repos/RJVB/audacious-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RJVB/audacious-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RJVB/audacious-plugins/teams","hooks_url":"https://api.github.com/repos/RJVB/audacious-plugins/hooks","issue_events_url":"https://api.github.com/repos/RJVB/audacious-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/RJVB/audacious-plugins/events","assignees_url":"https://api.github.com/repos/RJVB/audacious-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/RJVB/audacious-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/RJVB/audacious-plugins/tags","blobs_url":"https://api.github.com/repos/RJVB/audacious-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RJVB/audacious-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RJVB/audacious-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/RJVB/audacious-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RJVB/audacious-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/RJVB/audacious-plugins/languages","stargazers_url":"https://api.github.com/repos/RJVB/audacious-plugins/stargazers","contributors_url":"https://api.github.com/repos/RJVB/audacious-plugins/contributors","subscribers_url":"https://api.github.com/repos/RJVB/audacious-plugins/subscribers","subscription_url":"https://api.github.com/repos/RJVB/audacious-plugins/subscription","commits_url":"https://api.github.com/repos/RJVB/audacious-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/RJVB/audacious-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/RJVB/audacious-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/RJVB/audacious-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/RJVB/audacious-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/RJVB/audacious-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RJVB/audacious-plugins/merges","archive_url":"https://api.github.com/repos/RJVB/audacious-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RJVB/audacious-plugins/downloads","issues_url":"https://api.github.com/repos/RJVB/audacious-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/RJVB/audacious-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/RJVB/audacious-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/RJVB/audacious-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RJVB/audacious-plugins/labels{/name}","releases_url":"https://api.github.com/repos/RJVB/audacious-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/RJVB/audacious-plugins/deployments","created_at":"2018-01-15T14:41:59Z","updated_at":"2018-01-15T14:42:03Z","pushed_at":"2018-01-25T13:34:38Z","git_url":"git://github.com/RJVB/audacious-plugins.git","ssh_url":"git@github.com:RJVB/audacious-plugins.git","clone_url":"https://github.com/RJVB/audacious-plugins.git","svn_url":"https://github.com/RJVB/audacious-plugins","homepage":"","size":37175,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"RJVB-MP-Qt"}},"base":{"label":"audacious-media-player:master","ref":"master","sha":"0e08701220e0a544b62831282c9bc152cb3faa59","user":{"login":"audacious-media-player","id":1249822,"avatar_url":"https://avatars1.githubusercontent.com/u/1249822?v=4","gravatar_id":"","url":"https://api.github.com/users/audacious-media-player","html_url":"https://github.com/audacious-media-player","followers_url":"https://api.github.com/users/audacious-media-player/followers","following_url":"https://api.github.com/users/audacious-media-player/following{/other_user}","gists_url":"https://api.github.com/users/audacious-media-player/gists{/gist_id}","starred_url":"https://api.github.com/users/audacious-media-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/audacious-media-player/subscriptions","organizations_url":"https://api.github.com/users/audacious-media-player/orgs","repos_url":"https://api.github.com/users/audacious-media-player/repos","events_url":"https://api.github.com/users/audacious-media-player/events{/privacy}","received_events_url":"https://api.github.com/users/audacious-media-player/received_events","type":"Organization","site_admin":false},"repo":{"id":2926159,"name":"audacious-plugins","full_name":"audacious-media-player/audacious-plugins","owner":{"login":"audacious-media-player","id":1249822,"avatar_url":"https://avatars1.githubusercontent.com/u/1249822?v=4","gravatar_id":"","url":"https://api.github.com/users/audacious-media-player","html_url":"https://github.com/audacious-media-player","followers_url":"https://api.github.com/users/audacious-media-player/followers","following_url":"https://api.github.com/users/audacious-media-player/following{/other_user}","gists_url":"https://api.github.com/users/audacious-media-player/gists{/gist_id}","starred_url":"https://api.github.com/users/audacious-media-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/audacious-media-player/subscriptions","organizations_url":"https://api.github.com/users/audacious-media-player/orgs","repos_url":"https://api.github.com/users/audacious-media-player/repos","events_url":"https://api.github.com/users/audacious-media-player/events{/privacy}","received_events_url":"https://api.github.com/users/audacious-media-player/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/audacious-media-player/audacious-plugins","description":"Plugins for Audacious music player","fork":false,"url":"https://api.github.com/repos/audacious-media-player/audacious-plugins","forks_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/forks","keys_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/teams","hooks_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/hooks","issue_events_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/issues/events{/number}","events_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/events","assignees_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/assignees{/user}","branches_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/branches{/branch}","tags_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/tags","blobs_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/languages","stargazers_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/stargazers","contributors_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/contributors","subscribers_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/subscribers","subscription_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/subscription","commits_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/contents/{+path}","compare_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/merges","archive_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/downloads","issues_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/issues{/number}","pulls_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/labels{/name}","releases_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/releases{/id}","deployments_url":"https://api.github.com/repos/audacious-media-player/audacious-plugins/deployments","created_at":"2011-12-06T16:44:08Z","updated_at":"2018-01-13T13:51:37Z","pushed_at":"2018-02-10T16:00:48Z","git_url":"git://github.com/audacious-media-player/audacious-plugins.git","ssh_url":"git@github.com:audacious-media-player/audacious-plugins.git","clone_url":"https://github.com/audacious-media-player/audacious-plugins.git","svn_url":"https://github.com/audacious-media-player/audacious-plugins","homepage":"","size":37155,"stargazers_count":79,"watchers_count":79,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":61,"open_issues":5,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/audacious-media-player/audacious-plugins/pulls/63"},"html":{"href":"https://github.com/audacious-media-player/audacious-plugins/pull/63"},"issue":{"href":"https://api.github.com/repos/audacious-media-player/audacious-plugins/issues/63"},"comments":{"href":"https://api.github.com/repos/audacious-media-player/audacious-plugins/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/audacious-media-player/audacious-plugins/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/audacious-media-player/audacious-plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/audacious-media-player/audacious-plugins/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/audacious-media-player/audacious-plugins/statuses/89fbc5e83a7693951b89d39e6a0f457884808970"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"RJVB"}}