{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/comments/195109440","pull_request_review_id":128410165,"id":195109440,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTEwOTQ0MA==","diff_hunk":"@@ -196,7 +201,10 @@ func ScaleUp(context *context.AutoscalingContext, processors *ca_processors.Auto\n \t\t\terrCP)\n \t}\n \n-\tscaleUpResourcesLeft := computeScaleUpResourcesLeftLimits(nodeGroups, nodeInfos, resourceLimiter)\n+\tscaleUpResourcesLeft, errLimits := computeScaleUpResourcesLeftLimits(nodeGroups, nodeInfos, resourceLimiter)\n+\tif errLimits != nil {\n+\t\treturn nil, errors.ToAutoscalerError(errors.InternalError, errLimits).AddPrefix(\"Could not compute total resources: \")","path":"cluster-autoscaler/core/scale_up.go","position":null,"original_position":37,"commit_id":"e4746e99bb5898d22547ec22df2c4fe1b5fa9888","original_commit_id":"aae2340ae99eee4599874e78bea2a067bfe9c836","user":{"login":"MaciekPytel","id":7901030,"node_id":"MDQ6VXNlcjc5MDEwMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/7901030?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciekPytel","html_url":"https://github.com/MaciekPytel","followers_url":"https://api.github.com/users/MaciekPytel/followers","following_url":"https://api.github.com/users/MaciekPytel/following{/other_user}","gists_url":"https://api.github.com/users/MaciekPytel/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciekPytel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciekPytel/subscriptions","organizations_url":"https://api.github.com/users/MaciekPytel/orgs","repos_url":"https://api.github.com/users/MaciekPytel/repos","events_url":"https://api.github.com/users/MaciekPytel/events{/privacy}","received_events_url":"https://api.github.com/users/MaciekPytel/received_events","type":"User","site_admin":false},"body":"Shouldn't that be a cloudprovider error?","created_at":"2018-06-13T14:40:34Z","updated_at":"2018-06-13T14:40:34Z","html_url":"https://github.com/kubernetes/autoscaler/pull/955#discussion_r195109440","pull_request_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/955","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/comments/195109440"},"html":{"href":"https://github.com/kubernetes/autoscaler/pull/955#discussion_r195109440"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/955"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/955","id":194225344,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MjI1MzQ0","html_url":"https://github.com/kubernetes/autoscaler/pull/955","diff_url":"https://github.com/kubernetes/autoscaler/pull/955.diff","patch_url":"https://github.com/kubernetes/autoscaler/pull/955.patch","issue_url":"https://api.github.com/repos/kubernetes/autoscaler/issues/955","number":955,"state":"open","locked":false,"title":"Restructure checking resource limits in scale_up.go","user":{"login":"losipiuk","id":890111,"node_id":"MDQ6VXNlcjg5MDExMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/890111?v=4","gravatar_id":"","url":"https://api.github.com/users/losipiuk","html_url":"https://github.com/losipiuk","followers_url":"https://api.github.com/users/losipiuk/followers","following_url":"https://api.github.com/users/losipiuk/following{/other_user}","gists_url":"https://api.github.com/users/losipiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/losipiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/losipiuk/subscriptions","organizations_url":"https://api.github.com/users/losipiuk/orgs","repos_url":"https://api.github.com/users/losipiuk/repos","events_url":"https://api.github.com/users/losipiuk/events{/privacy}","received_events_url":"https://api.github.com/users/losipiuk/received_events","type":"User","site_admin":false},"body":"Preparatory work for before introducing GPU limits","created_at":"2018-06-12T09:52:57Z","updated_at":"2018-06-13T14:40:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9e69b79806f3ff0ad778f3964c1c34e2c795c715","assignee":{"login":"aleksandra-malinowska","id":4884414,"node_id":"MDQ6VXNlcjQ4ODQ0MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4884414?v=4","gravatar_id":"","url":"https://api.github.com/users/aleksandra-malinowska","html_url":"https://github.com/aleksandra-malinowska","followers_url":"https://api.github.com/users/aleksandra-malinowska/followers","following_url":"https://api.github.com/users/aleksandra-malinowska/following{/other_user}","gists_url":"https://api.github.com/users/aleksandra-malinowska/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandra-malinowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandra-malinowska/subscriptions","organizations_url":"https://api.github.com/users/aleksandra-malinowska/orgs","repos_url":"https://api.github.com/users/aleksandra-malinowska/repos","events_url":"https://api.github.com/users/aleksandra-malinowska/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandra-malinowska/received_events","type":"User","site_admin":false},"assignees":[{"login":"aleksandra-malinowska","id":4884414,"node_id":"MDQ6VXNlcjQ4ODQ0MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4884414?v=4","gravatar_id":"","url":"https://api.github.com/users/aleksandra-malinowska","html_url":"https://github.com/aleksandra-malinowska","followers_url":"https://api.github.com/users/aleksandra-malinowska/followers","following_url":"https://api.github.com/users/aleksandra-malinowska/following{/other_user}","gists_url":"https://api.github.com/users/aleksandra-malinowska/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandra-malinowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandra-malinowska/subscriptions","organizations_url":"https://api.github.com/users/aleksandra-malinowska/orgs","repos_url":"https://api.github.com/users/aleksandra-malinowska/repos","events_url":"https://api.github.com/users/aleksandra-malinowska/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandra-malinowska/received_events","type":"User","site_admin":false},{"login":"MaciekPytel","id":7901030,"node_id":"MDQ6VXNlcjc5MDEwMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/7901030?v=4","gravatar_id":"","url":"https://api.github.com/users/MaciekPytel","html_url":"https://github.com/MaciekPytel","followers_url":"https://api.github.com/users/MaciekPytel/followers","following_url":"https://api.github.com/users/MaciekPytel/following{/other_user}","gists_url":"https://api.github.com/users/MaciekPytel/gists{/gist_id}","starred_url":"https://api.github.com/users/MaciekPytel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaciekPytel/subscriptions","organizations_url":"https://api.github.com/users/MaciekPytel/orgs","repos_url":"https://api.github.com/users/MaciekPytel/repos","events_url":"https://api.github.com/users/MaciekPytel/events{/privacy}","received_events_url":"https://api.github.com/users/MaciekPytel/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":586404823,"node_id":"MDU6TGFiZWw1ODY0MDQ4MjM=","url":"https://api.github.com/repos/kubernetes/autoscaler/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":675980930,"node_id":"MDU6TGFiZWw2NzU5ODA5MzA=","url":"https://api.github.com/repos/kubernetes/autoscaler/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/955/commits","review_comments_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/955/comments","review_comment_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/autoscaler/issues/955/comments","statuses_url":"https://api.github.com/repos/kubernetes/autoscaler/statuses/e4746e99bb5898d22547ec22df2c4fe1b5fa9888","head":{"label":"losipiuk:lo/scale_up_limits_refactor","ref":"lo/scale_up_limits_refactor","sha":"e4746e99bb5898d22547ec22df2c4fe1b5fa9888","user":{"login":"losipiuk","id":890111,"node_id":"MDQ6VXNlcjg5MDExMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/890111?v=4","gravatar_id":"","url":"https://api.github.com/users/losipiuk","html_url":"https://github.com/losipiuk","followers_url":"https://api.github.com/users/losipiuk/followers","following_url":"https://api.github.com/users/losipiuk/following{/other_user}","gists_url":"https://api.github.com/users/losipiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/losipiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/losipiuk/subscriptions","organizations_url":"https://api.github.com/users/losipiuk/orgs","repos_url":"https://api.github.com/users/losipiuk/repos","events_url":"https://api.github.com/users/losipiuk/events{/privacy}","received_events_url":"https://api.github.com/users/losipiuk/received_events","type":"User","site_admin":false},"repo":{"id":130706569,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA3MDY1Njk=","name":"autoscaler","full_name":"losipiuk/autoscaler","owner":{"login":"losipiuk","id":890111,"node_id":"MDQ6VXNlcjg5MDExMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/890111?v=4","gravatar_id":"","url":"https://api.github.com/users/losipiuk","html_url":"https://github.com/losipiuk","followers_url":"https://api.github.com/users/losipiuk/followers","following_url":"https://api.github.com/users/losipiuk/following{/other_user}","gists_url":"https://api.github.com/users/losipiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/losipiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/losipiuk/subscriptions","organizations_url":"https://api.github.com/users/losipiuk/orgs","repos_url":"https://api.github.com/users/losipiuk/repos","events_url":"https://api.github.com/users/losipiuk/events{/privacy}","received_events_url":"https://api.github.com/users/losipiuk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/losipiuk/autoscaler","description":"Autoscaling components for Kubernetes","fork":true,"url":"https://api.github.com/repos/losipiuk/autoscaler","forks_url":"https://api.github.com/repos/losipiuk/autoscaler/forks","keys_url":"https://api.github.com/repos/losipiuk/autoscaler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/losipiuk/autoscaler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/losipiuk/autoscaler/teams","hooks_url":"https://api.github.com/repos/losipiuk/autoscaler/hooks","issue_events_url":"https://api.github.com/repos/losipiuk/autoscaler/issues/events{/number}","events_url":"https://api.github.com/repos/losipiuk/autoscaler/events","assignees_url":"https://api.github.com/repos/losipiuk/autoscaler/assignees{/user}","branches_url":"https://api.github.com/repos/losipiuk/autoscaler/branches{/branch}","tags_url":"https://api.github.com/repos/losipiuk/autoscaler/tags","blobs_url":"https://api.github.com/repos/losipiuk/autoscaler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/losipiuk/autoscaler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/losipiuk/autoscaler/git/refs{/sha}","trees_url":"https://api.github.com/repos/losipiuk/autoscaler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/losipiuk/autoscaler/statuses/{sha}","languages_url":"https://api.github.com/repos/losipiuk/autoscaler/languages","stargazers_url":"https://api.github.com/repos/losipiuk/autoscaler/stargazers","contributors_url":"https://api.github.com/repos/losipiuk/autoscaler/contributors","subscribers_url":"https://api.github.com/repos/losipiuk/autoscaler/subscribers","subscription_url":"https://api.github.com/repos/losipiuk/autoscaler/subscription","commits_url":"https://api.github.com/repos/losipiuk/autoscaler/commits{/sha}","git_commits_url":"https://api.github.com/repos/losipiuk/autoscaler/git/commits{/sha}","comments_url":"https://api.github.com/repos/losipiuk/autoscaler/comments{/number}","issue_comment_url":"https://api.github.com/repos/losipiuk/autoscaler/issues/comments{/number}","contents_url":"https://api.github.com/repos/losipiuk/autoscaler/contents/{+path}","compare_url":"https://api.github.com/repos/losipiuk/autoscaler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/losipiuk/autoscaler/merges","archive_url":"https://api.github.com/repos/losipiuk/autoscaler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/losipiuk/autoscaler/downloads","issues_url":"https://api.github.com/repos/losipiuk/autoscaler/issues{/number}","pulls_url":"https://api.github.com/repos/losipiuk/autoscaler/pulls{/number}","milestones_url":"https://api.github.com/repos/losipiuk/autoscaler/milestones{/number}","notifications_url":"https://api.github.com/repos/losipiuk/autoscaler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/losipiuk/autoscaler/labels{/name}","releases_url":"https://api.github.com/repos/losipiuk/autoscaler/releases{/id}","deployments_url":"https://api.github.com/repos/losipiuk/autoscaler/deployments","created_at":"2018-04-23T14:10:25Z","updated_at":"2018-04-23T14:10:30Z","pushed_at":"2018-06-13T14:37:36Z","git_url":"git://github.com/losipiuk/autoscaler.git","ssh_url":"git@github.com:losipiuk/autoscaler.git","clone_url":"https://github.com/losipiuk/autoscaler.git","svn_url":"https://github.com/losipiuk/autoscaler","homepage":"","size":32605,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"a686c674ac1402f7553aa1e6d63ad761d83fc96e","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":87990209,"node_id":"MDEwOlJlcG9zaXRvcnk4Nzk5MDIwOQ==","name":"autoscaler","full_name":"kubernetes/autoscaler","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/autoscaler","description":"Autoscaling components for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/autoscaler","forks_url":"https://api.github.com/repos/kubernetes/autoscaler/forks","keys_url":"https://api.github.com/repos/kubernetes/autoscaler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/autoscaler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/autoscaler/teams","hooks_url":"https://api.github.com/repos/kubernetes/autoscaler/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/autoscaler/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/autoscaler/events","assignees_url":"https://api.github.com/repos/kubernetes/autoscaler/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/autoscaler/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/autoscaler/tags","blobs_url":"https://api.github.com/repos/kubernetes/autoscaler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/autoscaler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/autoscaler/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/autoscaler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/autoscaler/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/autoscaler/languages","stargazers_url":"https://api.github.com/repos/kubernetes/autoscaler/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/autoscaler/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/autoscaler/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/autoscaler/subscription","commits_url":"https://api.github.com/repos/kubernetes/autoscaler/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/autoscaler/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/autoscaler/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/autoscaler/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/autoscaler/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/autoscaler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/autoscaler/merges","archive_url":"https://api.github.com/repos/kubernetes/autoscaler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/autoscaler/downloads","issues_url":"https://api.github.com/repos/kubernetes/autoscaler/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/autoscaler/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/autoscaler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/autoscaler/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/autoscaler/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/autoscaler/deployments","created_at":"2017-04-12T00:03:40Z","updated_at":"2018-06-13T14:01:47Z","pushed_at":"2018-06-13T14:37:38Z","git_url":"git://github.com/kubernetes/autoscaler.git","ssh_url":"git@github.com:kubernetes/autoscaler.git","clone_url":"https://github.com/kubernetes/autoscaler.git","svn_url":"https://github.com/kubernetes/autoscaler","homepage":"","size":32607,"stargazers_count":771,"watchers_count":771,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":336,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":336,"open_issues":66,"watchers":771,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/955"},"html":{"href":"https://github.com/kubernetes/autoscaler/pull/955"},"issue":{"href":"https://api.github.com/repos/kubernetes/autoscaler/issues/955"},"comments":{"href":"https://api.github.com/repos/kubernetes/autoscaler/issues/955/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/955/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/955/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/autoscaler/statuses/e4746e99bb5898d22547ec22df2c4fe1b5fa9888"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MaciekPytel"}}