{"action":"created","comment":{"url":"https://api.github.com/repos/googlecartographer/cartographer_ros/pulls/comments/191243143","pull_request_review_id":123778017,"id":191243143,"diff_hunk":"@@ -39,13 +39,15 @@ DEFINE_bool(\n DEFINE_string(\n     save_state_filename, \"\",\n     \"If non-empty, serialize state and write it to disk before shutting down.\");\n+DEFINE_double(tf_buffer_cache_time_seconds, 1e2,","path":"cartographer_ros/cartographer_ros/node_main.cc","position":4,"original_position":4,"commit_id":"f2877d27151bdf541772471f3c794b6bd7c140a8","original_commit_id":"f2877d27151bdf541772471f3c794b6bd7c140a8","user":{"login":"MichaelGrupp","id":8985495,"avatar_url":"https://avatars3.githubusercontent.com/u/8985495?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelGrupp","html_url":"https://github.com/MichaelGrupp","followers_url":"https://api.github.com/users/MichaelGrupp/followers","following_url":"https://api.github.com/users/MichaelGrupp/following{/other_user}","gists_url":"https://api.github.com/users/MichaelGrupp/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelGrupp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelGrupp/subscriptions","organizations_url":"https://api.github.com/users/MichaelGrupp/orgs","repos_url":"https://api.github.com/users/MichaelGrupp/repos","events_url":"https://api.github.com/users/MichaelGrupp/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelGrupp/received_events","type":"User","site_admin":false},"body":"So far, *our* system also worked with just `1e1`... however it would be interesting if there are any cases where a longer period is required, as I asked in my other comment.","created_at":"2018-05-28T16:32:22Z","updated_at":"2018-05-28T16:32:22Z","html_url":"https://github.com/googlecartographer/cartographer_ros/pull/879#discussion_r191243143","pull_request_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/pulls/879","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googlecartographer/cartographer_ros/pulls/comments/191243143"},"html":{"href":"https://github.com/googlecartographer/cartographer_ros/pull/879#discussion_r191243143"},"pull_request":{"href":"https://api.github.com/repos/googlecartographer/cartographer_ros/pulls/879"}},"in_reply_to_id":191238562},"pull_request":{"url":"https://api.github.com/repos/googlecartographer/cartographer_ros/pulls/879","id":190885081,"html_url":"https://github.com/googlecartographer/cartographer_ros/pull/879","diff_url":"https://github.com/googlecartographer/cartographer_ros/pull/879.diff","patch_url":"https://github.com/googlecartographer/cartographer_ros/pull/879.patch","issue_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/issues/879","number":879,"state":"open","locked":false,"title":"Sanitize memory consumption with smaller default TF buffer size.","user":{"login":"MichaelGrupp","id":8985495,"avatar_url":"https://avatars3.githubusercontent.com/u/8985495?v=4","gravatar_id":"","url":"https://api.github.com/users/MichaelGrupp","html_url":"https://github.com/MichaelGrupp","followers_url":"https://api.github.com/users/MichaelGrupp/followers","following_url":"https://api.github.com/users/MichaelGrupp/following{/other_user}","gists_url":"https://api.github.com/users/MichaelGrupp/gists{/gist_id}","starred_url":"https://api.github.com/users/MichaelGrupp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichaelGrupp/subscriptions","organizations_url":"https://api.github.com/users/MichaelGrupp/orgs","repos_url":"https://api.github.com/users/MichaelGrupp/repos","events_url":"https://api.github.com/users/MichaelGrupp/events{/privacy}","received_events_url":"https://api.github.com/users/MichaelGrupp/received_events","type":"User","site_admin":false},"body":"Fixes an (almost) unbounded growth of the TF buffer.\r\n\r\nMakes the buffer size configurable as an CLI option.","created_at":"2018-05-28T09:44:34Z","updated_at":"2018-05-28T16:32:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"527381ecbe9d29eb078869a499b7326c743b94fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":418857802,"url":"https://api.github.com/repos/googlecartographer/cartographer_ros/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/pulls/879/commits","review_comments_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/pulls/879/comments","review_comment_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/issues/879/comments","statuses_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/statuses/f2877d27151bdf541772471f3c794b6bd7c140a8","head":{"label":"magazino:memory-leak","ref":"memory-leak","sha":"f2877d27151bdf541772471f3c794b6bd7c140a8","user":{"login":"magazino","id":18398034,"avatar_url":"https://avatars1.githubusercontent.com/u/18398034?v=4","gravatar_id":"","url":"https://api.github.com/users/magazino","html_url":"https://github.com/magazino","followers_url":"https://api.github.com/users/magazino/followers","following_url":"https://api.github.com/users/magazino/following{/other_user}","gists_url":"https://api.github.com/users/magazino/gists{/gist_id}","starred_url":"https://api.github.com/users/magazino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magazino/subscriptions","organizations_url":"https://api.github.com/users/magazino/orgs","repos_url":"https://api.github.com/users/magazino/repos","events_url":"https://api.github.com/users/magazino/events{/privacy}","received_events_url":"https://api.github.com/users/magazino/received_events","type":"Organization","site_admin":false},"repo":{"id":65812950,"name":"cartographer_ros","full_name":"magazino/cartographer_ros","owner":{"login":"magazino","id":18398034,"avatar_url":"https://avatars1.githubusercontent.com/u/18398034?v=4","gravatar_id":"","url":"https://api.github.com/users/magazino","html_url":"https://github.com/magazino","followers_url":"https://api.github.com/users/magazino/followers","following_url":"https://api.github.com/users/magazino/following{/other_user}","gists_url":"https://api.github.com/users/magazino/gists{/gist_id}","starred_url":"https://api.github.com/users/magazino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magazino/subscriptions","organizations_url":"https://api.github.com/users/magazino/orgs","repos_url":"https://api.github.com/users/magazino/repos","events_url":"https://api.github.com/users/magazino/events{/privacy}","received_events_url":"https://api.github.com/users/magazino/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magazino/cartographer_ros","description":"Provides ROS integration for Cartographer.","fork":true,"url":"https://api.github.com/repos/magazino/cartographer_ros","forks_url":"https://api.github.com/repos/magazino/cartographer_ros/forks","keys_url":"https://api.github.com/repos/magazino/cartographer_ros/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magazino/cartographer_ros/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magazino/cartographer_ros/teams","hooks_url":"https://api.github.com/repos/magazino/cartographer_ros/hooks","issue_events_url":"https://api.github.com/repos/magazino/cartographer_ros/issues/events{/number}","events_url":"https://api.github.com/repos/magazino/cartographer_ros/events","assignees_url":"https://api.github.com/repos/magazino/cartographer_ros/assignees{/user}","branches_url":"https://api.github.com/repos/magazino/cartographer_ros/branches{/branch}","tags_url":"https://api.github.com/repos/magazino/cartographer_ros/tags","blobs_url":"https://api.github.com/repos/magazino/cartographer_ros/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magazino/cartographer_ros/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magazino/cartographer_ros/git/refs{/sha}","trees_url":"https://api.github.com/repos/magazino/cartographer_ros/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magazino/cartographer_ros/statuses/{sha}","languages_url":"https://api.github.com/repos/magazino/cartographer_ros/languages","stargazers_url":"https://api.github.com/repos/magazino/cartographer_ros/stargazers","contributors_url":"https://api.github.com/repos/magazino/cartographer_ros/contributors","subscribers_url":"https://api.github.com/repos/magazino/cartographer_ros/subscribers","subscription_url":"https://api.github.com/repos/magazino/cartographer_ros/subscription","commits_url":"https://api.github.com/repos/magazino/cartographer_ros/commits{/sha}","git_commits_url":"https://api.github.com/repos/magazino/cartographer_ros/git/commits{/sha}","comments_url":"https://api.github.com/repos/magazino/cartographer_ros/comments{/number}","issue_comment_url":"https://api.github.com/repos/magazino/cartographer_ros/issues/comments{/number}","contents_url":"https://api.github.com/repos/magazino/cartographer_ros/contents/{+path}","compare_url":"https://api.github.com/repos/magazino/cartographer_ros/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magazino/cartographer_ros/merges","archive_url":"https://api.github.com/repos/magazino/cartographer_ros/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magazino/cartographer_ros/downloads","issues_url":"https://api.github.com/repos/magazino/cartographer_ros/issues{/number}","pulls_url":"https://api.github.com/repos/magazino/cartographer_ros/pulls{/number}","milestones_url":"https://api.github.com/repos/magazino/cartographer_ros/milestones{/number}","notifications_url":"https://api.github.com/repos/magazino/cartographer_ros/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magazino/cartographer_ros/labels{/name}","releases_url":"https://api.github.com/repos/magazino/cartographer_ros/releases{/id}","deployments_url":"https://api.github.com/repos/magazino/cartographer_ros/deployments","created_at":"2016-08-16T10:58:38Z","updated_at":"2018-03-29T13:24:26Z","pushed_at":"2018-05-28T10:48:48Z","git_url":"git://github.com/magazino/cartographer_ros.git","ssh_url":"git@github.com:magazino/cartographer_ros.git","clone_url":"https://github.com/magazino/cartographer_ros.git","svn_url":"https://github.com/magazino/cartographer_ros","homepage":"","size":1154,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googlecartographer:master","ref":"master","sha":"4ecf04b49fbcaee96086c8b409e9365b07593e55","user":{"login":"googlecartographer","id":20636162,"avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"repo":{"id":64838142,"name":"cartographer_ros","full_name":"googlecartographer/cartographer_ros","owner":{"login":"googlecartographer","id":20636162,"avatar_url":"https://avatars3.githubusercontent.com/u/20636162?v=4","gravatar_id":"","url":"https://api.github.com/users/googlecartographer","html_url":"https://github.com/googlecartographer","followers_url":"https://api.github.com/users/googlecartographer/followers","following_url":"https://api.github.com/users/googlecartographer/following{/other_user}","gists_url":"https://api.github.com/users/googlecartographer/gists{/gist_id}","starred_url":"https://api.github.com/users/googlecartographer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googlecartographer/subscriptions","organizations_url":"https://api.github.com/users/googlecartographer/orgs","repos_url":"https://api.github.com/users/googlecartographer/repos","events_url":"https://api.github.com/users/googlecartographer/events{/privacy}","received_events_url":"https://api.github.com/users/googlecartographer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googlecartographer/cartographer_ros","description":"Provides ROS integration for Cartographer.","fork":false,"url":"https://api.github.com/repos/googlecartographer/cartographer_ros","forks_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/forks","keys_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/teams","hooks_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/hooks","issue_events_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/issues/events{/number}","events_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/events","assignees_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/assignees{/user}","branches_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/branches{/branch}","tags_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/tags","blobs_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/git/refs{/sha}","trees_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/statuses/{sha}","languages_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/languages","stargazers_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/stargazers","contributors_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/contributors","subscribers_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/subscribers","subscription_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/subscription","commits_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/commits{/sha}","git_commits_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/git/commits{/sha}","comments_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/comments{/number}","issue_comment_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/issues/comments{/number}","contents_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/contents/{+path}","compare_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/merges","archive_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/downloads","issues_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/issues{/number}","pulls_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/pulls{/number}","milestones_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/milestones{/number}","notifications_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/labels{/name}","releases_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/releases{/id}","deployments_url":"https://api.github.com/repos/googlecartographer/cartographer_ros/deployments","created_at":"2016-08-03T10:43:23Z","updated_at":"2018-05-26T13:27:48Z","pushed_at":"2018-05-28T10:48:50Z","git_url":"git://github.com/googlecartographer/cartographer_ros.git","ssh_url":"git@github.com:googlecartographer/cartographer_ros.git","clone_url":"https://github.com/googlecartographer/cartographer_ros.git","svn_url":"https://github.com/googlecartographer/cartographer_ros","homepage":"","size":1097,"stargazers_count":542,"watchers_count":542,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":429,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":429,"open_issues":43,"watchers":542,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googlecartographer/cartographer_ros/pulls/879"},"html":{"href":"https://github.com/googlecartographer/cartographer_ros/pull/879"},"issue":{"href":"https://api.github.com/repos/googlecartographer/cartographer_ros/issues/879"},"comments":{"href":"https://api.github.com/repos/googlecartographer/cartographer_ros/issues/879/comments"},"review_comments":{"href":"https://api.github.com/repos/googlecartographer/cartographer_ros/pulls/879/comments"},"review_comment":{"href":"https://api.github.com/repos/googlecartographer/cartographer_ros/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googlecartographer/cartographer_ros/pulls/879/commits"},"statuses":{"href":"https://api.github.com/repos/googlecartographer/cartographer_ros/statuses/f2877d27151bdf541772471f3c794b6bd7c140a8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MichaelGrupp"}}