{"action":"created","issue":{"url":"https://api.github.com/repos/vue-generators/vue-form-generator/issues/443","repository_url":"https://api.github.com/repos/vue-generators/vue-form-generator","labels_url":"https://api.github.com/repos/vue-generators/vue-form-generator/issues/443/labels{/name}","comments_url":"https://api.github.com/repos/vue-generators/vue-form-generator/issues/443/comments","events_url":"https://api.github.com/repos/vue-generators/vue-form-generator/issues/443/events","html_url":"https://github.com/vue-generators/vue-form-generator/pull/443","id":316586600,"number":443,"title":"closes #434, #408 - added $event to onValidationError","user":{"login":"zoul0813","id":1064917,"avatar_url":"https://avatars1.githubusercontent.com/u/1064917?v=4","gravatar_id":"","url":"https://api.github.com/users/zoul0813","html_url":"https://github.com/zoul0813","followers_url":"https://api.github.com/users/zoul0813/followers","following_url":"https://api.github.com/users/zoul0813/following{/other_user}","gists_url":"https://api.github.com/users/zoul0813/gists{/gist_id}","starred_url":"https://api.github.com/users/zoul0813/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoul0813/subscriptions","organizations_url":"https://api.github.com/users/zoul0813/orgs","repos_url":"https://api.github.com/users/zoul0813/repos","events_url":"https://api.github.com/users/zoul0813/events{/privacy}","received_events_url":"https://api.github.com/users/zoul0813/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-22T15:06:44Z","updated_at":"2018-04-24T13:57:28Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/vue-generators/vue-form-generator/pulls/443","html_url":"https://github.com/vue-generators/vue-form-generator/pull/443","diff_url":"https://github.com/vue-generators/vue-form-generator/pull/443.diff","patch_url":"https://github.com/vue-generators/vue-form-generator/pull/443.patch"},"body":"added $event to onValidationError and call preventDefault when onValidateBeforeSubmit is true\r\n\r\nWe can't prevent the submit after waiting for async validation, so we just prevent it before calling any validation and let the user\r\nmanually submit the form in the `onSubmit` handler, if it validates.\r\n\r\n* **Please check if the PR fulfills these requirements**\r\n\r\n- [x] The commit message follows our guidelines\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n* **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...)\r\nBug Fix\r\n\r\n- **What is the current behavior?** (You can also link to an open issue here)\r\n`<form />` are submitted when using `submit` field with validateBeforeSubmit.\r\n\r\n* **What is the new behavior (if this is a feature change)?**\r\n`validateBeforeSubmit: true` calls `$event.preventDefault()` and prevents the form submission \r\n\r\n- **Does this PR introduce a breaking change?** (What changes might users need to make in their application due to this PR?)\r\nThis PR should introduce \"expected behavior\", so users should not need to do anything.\r\n\r\n* **Other information**:\r\n"},"comment":{"url":"https://api.github.com/repos/vue-generators/vue-form-generator/issues/comments/383940630","html_url":"https://github.com/vue-generators/vue-form-generator/pull/443#issuecomment-383940630","issue_url":"https://api.github.com/repos/vue-generators/vue-form-generator/issues/443","id":383940630,"user":{"login":"icebob","id":306521,"avatar_url":"https://avatars3.githubusercontent.com/u/306521?v=4","gravatar_id":"","url":"https://api.github.com/users/icebob","html_url":"https://github.com/icebob","followers_url":"https://api.github.com/users/icebob/followers","following_url":"https://api.github.com/users/icebob/following{/other_user}","gists_url":"https://api.github.com/users/icebob/gists{/gist_id}","starred_url":"https://api.github.com/users/icebob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icebob/subscriptions","organizations_url":"https://api.github.com/users/icebob/orgs","repos_url":"https://api.github.com/users/icebob/repos","events_url":"https://api.github.com/users/icebob/events{/privacy}","received_events_url":"https://api.github.com/users/icebob/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T13:57:28Z","updated_at":"2018-04-24T13:57:28Z","author_association":"OWNER","body":"OK.\r\n\r\nYes, but you have to use `npm run version ....` script. More info: https://github.com/vue-generators/vue-form-generator/issues/246#issuecomment-371791641"}}
{"actor":{"display_login":"icebob"}}