{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/force/pulls/comments/185561026","pull_request_review_id":116975495,"id":185561026,"diff_hunk":"@@ -24,20 +24,19 @@ describe 'Sitemaps', ->\n       @res = set: sinon.stub(), send: sinon.stub()\n \n     afterEach ->\n-      routes.__set__ 'NODE_ENV', 'test'\n+      routes.__set__ 'ENABLE_WEB_CRAWLING', false\n \n-    it 'renders a noindex in anything but production', ->\n-      routes.__set__ 'NODE_ENV', 'staging'\n+    it 'renders a noindex when ENABLE_WEB_CRAWLING is false', ->\n+      routes.__set__ 'ENABLE_WEB_CRAWLING', false\n       routes.robots null, @res\n       @res.send.args[0][0]\n         .should.equal  'User-agent: *\\nNoindex: /'\n \n-    describe 'production', ->\n+    describe 'when ENABLE_WEB_CRAWLING is true', ->\n       beforeEach ->\n-        routes.__set__ NODE_ENV: 'production', APP_URL: 'https://www.artsy.net'\n+        routes.__set__ ENABLE_WEB_CRAWLING: true, APP_URL: 'https://www.artsy.net'","path":"src/desktop/apps/sitemaps/test/routes.coffee","position":19,"original_position":19,"commit_id":"eacf429d018f831be5afad24047c67e20bfbc17a","original_commit_id":"eacf429d018f831be5afad24047c67e20bfbc17a","user":{"login":"mzikherman","id":1457859,"avatar_url":"https://avatars2.githubusercontent.com/u/1457859?v=4","gravatar_id":"","url":"https://api.github.com/users/mzikherman","html_url":"https://github.com/mzikherman","followers_url":"https://api.github.com/users/mzikherman/followers","following_url":"https://api.github.com/users/mzikherman/following{/other_user}","gists_url":"https://api.github.com/users/mzikherman/gists{/gist_id}","starred_url":"https://api.github.com/users/mzikherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzikherman/subscriptions","organizations_url":"https://api.github.com/users/mzikherman/orgs","repos_url":"https://api.github.com/users/mzikherman/repos","events_url":"https://api.github.com/users/mzikherman/events{/privacy}","received_events_url":"https://api.github.com/users/mzikherman/received_events","type":"User","site_admin":false},"body":"So stubbing at this point, you should be stubbing the actual values ^ (from `JSON.parse`)","created_at":"2018-05-02T16:38:24Z","updated_at":"2018-05-02T16:38:24Z","html_url":"https://github.com/artsy/force/pull/2449#discussion_r185561026","pull_request_url":"https://api.github.com/repos/artsy/force/pulls/2449","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/artsy/force/pulls/comments/185561026"},"html":{"href":"https://github.com/artsy/force/pull/2449#discussion_r185561026"},"pull_request":{"href":"https://api.github.com/repos/artsy/force/pulls/2449"}},"in_reply_to_id":185558125},"pull_request":{"url":"https://api.github.com/repos/artsy/force/pulls/2449","id":185465878,"html_url":"https://github.com/artsy/force/pull/2449","diff_url":"https://github.com/artsy/force/pull/2449.diff","patch_url":"https://github.com/artsy/force/pull/2449.patch","issue_url":"https://api.github.com/repos/artsy/force/issues/2449","number":2449,"state":"open","locked":false,"title":"@joeyAghion => Add a few granular flags to replace NODE_ENV","user":{"login":"mzikherman","id":1457859,"avatar_url":"https://avatars2.githubusercontent.com/u/1457859?v=4","gravatar_id":"","url":"https://api.github.com/users/mzikherman","html_url":"https://github.com/mzikherman","followers_url":"https://api.github.com/users/mzikherman/followers","following_url":"https://api.github.com/users/mzikherman/following{/other_user}","gists_url":"https://api.github.com/users/mzikherman/gists{/gist_id}","starred_url":"https://api.github.com/users/mzikherman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzikherman/subscriptions","organizations_url":"https://api.github.com/users/mzikherman/orgs","repos_url":"https://api.github.com/users/mzikherman/repos","events_url":"https://api.github.com/users/mzikherman/events{/privacy}","received_events_url":"https://api.github.com/users/mzikherman/received_events","type":"User","site_admin":false},"body":"While I'm in here, I'll do a sweep for some other places that may need updating to their own flags.\r\n\r\n## Migration (after-merge)\r\n\r\nOn `force-production`:\r\n  Set `ENABLE_WEB_CRAWLING=true`.\r\n  \r\nOn `force-staging`:\r\n  Set `SHOW_ANALYTICS_CALLS=true`.\r\n  Set `ENABLE_MEMORY_PROFILING=true`.","created_at":"2018-05-02T14:57:12Z","updated_at":"2018-05-02T16:38:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f01cc305ab19d1578c9cae95e95c965e971e0c73","assignee":{"login":"joeyAghion","id":28120,"avatar_url":"https://avatars2.githubusercontent.com/u/28120?v=4","gravatar_id":"","url":"https://api.github.com/users/joeyAghion","html_url":"https://github.com/joeyAghion","followers_url":"https://api.github.com/users/joeyAghion/followers","following_url":"https://api.github.com/users/joeyAghion/following{/other_user}","gists_url":"https://api.github.com/users/joeyAghion/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyAghion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyAghion/subscriptions","organizations_url":"https://api.github.com/users/joeyAghion/orgs","repos_url":"https://api.github.com/users/joeyAghion/repos","events_url":"https://api.github.com/users/joeyAghion/events{/privacy}","received_events_url":"https://api.github.com/users/joeyAghion/received_events","type":"User","site_admin":false},"assignees":[{"login":"joeyAghion","id":28120,"avatar_url":"https://avatars2.githubusercontent.com/u/28120?v=4","gravatar_id":"","url":"https://api.github.com/users/joeyAghion","html_url":"https://github.com/joeyAghion","followers_url":"https://api.github.com/users/joeyAghion/followers","following_url":"https://api.github.com/users/joeyAghion/following{/other_user}","gists_url":"https://api.github.com/users/joeyAghion/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyAghion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyAghion/subscriptions","organizations_url":"https://api.github.com/users/joeyAghion/orgs","repos_url":"https://api.github.com/users/joeyAghion/repos","events_url":"https://api.github.com/users/joeyAghion/events{/privacy}","received_events_url":"https://api.github.com/users/joeyAghion/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/force/pulls/2449/commits","review_comments_url":"https://api.github.com/repos/artsy/force/pulls/2449/comments","review_comment_url":"https://api.github.com/repos/artsy/force/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/force/issues/2449/comments","statuses_url":"https://api.github.com/repos/artsy/force/statuses/eacf429d018f831be5afad24047c67e20bfbc17a","head":{"label":"artsy:env_fix","ref":"env_fix","sha":"eacf429d018f831be5afad24047c67e20bfbc17a","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":22887404,"name":"force","full_name":"artsy/force","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/force","description":"The Artsy.net website:","fork":false,"url":"https://api.github.com/repos/artsy/force","forks_url":"https://api.github.com/repos/artsy/force/forks","keys_url":"https://api.github.com/repos/artsy/force/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/force/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/force/teams","hooks_url":"https://api.github.com/repos/artsy/force/hooks","issue_events_url":"https://api.github.com/repos/artsy/force/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/force/events","assignees_url":"https://api.github.com/repos/artsy/force/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/force/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/force/tags","blobs_url":"https://api.github.com/repos/artsy/force/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/force/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/force/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/force/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/force/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/force/languages","stargazers_url":"https://api.github.com/repos/artsy/force/stargazers","contributors_url":"https://api.github.com/repos/artsy/force/contributors","subscribers_url":"https://api.github.com/repos/artsy/force/subscribers","subscription_url":"https://api.github.com/repos/artsy/force/subscription","commits_url":"https://api.github.com/repos/artsy/force/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/force/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/force/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/force/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/force/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/force/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/force/merges","archive_url":"https://api.github.com/repos/artsy/force/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/force/downloads","issues_url":"https://api.github.com/repos/artsy/force/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/force/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/force/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/force/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/force/labels{/name}","releases_url":"https://api.github.com/repos/artsy/force/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/force/deployments","created_at":"2014-08-12T18:14:34Z","updated_at":"2018-05-02T16:23:35Z","pushed_at":"2018-05-02T16:23:32Z","git_url":"git://github.com/artsy/force.git","ssh_url":"git@github.com:artsy/force.git","clone_url":"https://github.com/artsy/force.git","svn_url":"https://github.com/artsy/force","homepage":"https://www.artsy.net","size":128015,"stargazers_count":222,"watchers_count":222,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":81,"open_issues":52,"watchers":222,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"a937a36999ea200cb1dcc7e6a705a7c5c05254e1","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":22887404,"name":"force","full_name":"artsy/force","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/force","description":"The Artsy.net website:","fork":false,"url":"https://api.github.com/repos/artsy/force","forks_url":"https://api.github.com/repos/artsy/force/forks","keys_url":"https://api.github.com/repos/artsy/force/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/force/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/force/teams","hooks_url":"https://api.github.com/repos/artsy/force/hooks","issue_events_url":"https://api.github.com/repos/artsy/force/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/force/events","assignees_url":"https://api.github.com/repos/artsy/force/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/force/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/force/tags","blobs_url":"https://api.github.com/repos/artsy/force/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/force/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/force/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/force/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/force/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/force/languages","stargazers_url":"https://api.github.com/repos/artsy/force/stargazers","contributors_url":"https://api.github.com/repos/artsy/force/contributors","subscribers_url":"https://api.github.com/repos/artsy/force/subscribers","subscription_url":"https://api.github.com/repos/artsy/force/subscription","commits_url":"https://api.github.com/repos/artsy/force/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/force/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/force/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/force/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/force/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/force/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/force/merges","archive_url":"https://api.github.com/repos/artsy/force/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/force/downloads","issues_url":"https://api.github.com/repos/artsy/force/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/force/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/force/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/force/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/force/labels{/name}","releases_url":"https://api.github.com/repos/artsy/force/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/force/deployments","created_at":"2014-08-12T18:14:34Z","updated_at":"2018-05-02T16:23:35Z","pushed_at":"2018-05-02T16:23:32Z","git_url":"git://github.com/artsy/force.git","ssh_url":"git@github.com:artsy/force.git","clone_url":"https://github.com/artsy/force.git","svn_url":"https://github.com/artsy/force","homepage":"https://www.artsy.net","size":128015,"stargazers_count":222,"watchers_count":222,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":81,"open_issues":52,"watchers":222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/force/pulls/2449"},"html":{"href":"https://github.com/artsy/force/pull/2449"},"issue":{"href":"https://api.github.com/repos/artsy/force/issues/2449"},"comments":{"href":"https://api.github.com/repos/artsy/force/issues/2449/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/force/pulls/2449/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/force/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/force/pulls/2449/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/force/statuses/eacf429d018f831be5afad24047c67e20bfbc17a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mzikherman"}}