{"action":"created","issue":{"url":"https://api.github.com/repos/JamieOnUbuntu/results-whitelist/issues/1","repository_url":"https://api.github.com/repos/JamieOnUbuntu/results-whitelist","labels_url":"https://api.github.com/repos/JamieOnUbuntu/results-whitelist/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/JamieOnUbuntu/results-whitelist/issues/1/comments","events_url":"https://api.github.com/repos/JamieOnUbuntu/results-whitelist/issues/1/events","html_url":"https://github.com/JamieOnUbuntu/results-whitelist/issues/1","id":298011473,"number":1,"title":"Error in results.js due to setting callback as an integer","user":{"login":"joker314","id":18113170,"avatar_url":"https://avatars0.githubusercontent.com/u/18113170?v=4","gravatar_id":"","url":"https://api.github.com/users/joker314","html_url":"https://github.com/joker314","followers_url":"https://api.github.com/users/joker314/followers","following_url":"https://api.github.com/users/joker314/following{/other_user}","gists_url":"https://api.github.com/users/joker314/gists{/gist_id}","starred_url":"https://api.github.com/users/joker314/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joker314/subscriptions","organizations_url":"https://api.github.com/users/joker314/orgs","repos_url":"https://api.github.com/users/joker314/repos","events_url":"https://api.github.com/users/joker314/events{/privacy}","received_events_url":"https://api.github.com/users/joker314/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"JamieOnUbuntu","id":10353998,"avatar_url":"https://avatars2.githubusercontent.com/u/10353998?v=4","gravatar_id":"","url":"https://api.github.com/users/JamieOnUbuntu","html_url":"https://github.com/JamieOnUbuntu","followers_url":"https://api.github.com/users/JamieOnUbuntu/followers","following_url":"https://api.github.com/users/JamieOnUbuntu/following{/other_user}","gists_url":"https://api.github.com/users/JamieOnUbuntu/gists{/gist_id}","starred_url":"https://api.github.com/users/JamieOnUbuntu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamieOnUbuntu/subscriptions","organizations_url":"https://api.github.com/users/JamieOnUbuntu/orgs","repos_url":"https://api.github.com/users/JamieOnUbuntu/repos","events_url":"https://api.github.com/users/JamieOnUbuntu/events{/privacy}","received_events_url":"https://api.github.com/users/JamieOnUbuntu/received_events","type":"User","site_admin":false},"assignees":[{"login":"JamieOnUbuntu","id":10353998,"avatar_url":"https://avatars2.githubusercontent.com/u/10353998?v=4","gravatar_id":"","url":"https://api.github.com/users/JamieOnUbuntu","html_url":"https://github.com/JamieOnUbuntu","followers_url":"https://api.github.com/users/JamieOnUbuntu/followers","following_url":"https://api.github.com/users/JamieOnUbuntu/following{/other_user}","gists_url":"https://api.github.com/users/JamieOnUbuntu/gists{/gist_id}","starred_url":"https://api.github.com/users/JamieOnUbuntu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamieOnUbuntu/subscriptions","organizations_url":"https://api.github.com/users/JamieOnUbuntu/orgs","repos_url":"https://api.github.com/users/JamieOnUbuntu/repos","events_url":"https://api.github.com/users/JamieOnUbuntu/events{/privacy}","received_events_url":"https://api.github.com/users/JamieOnUbuntu/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-02-17T15:12:46Z","updated_at":"2018-02-17T16:21:36Z","closed_at":"2018-02-17T15:36:14Z","author_association":"CONTRIBUTOR","body":"Hi! Wow, wonderful work here! In results.js, on line 13, you have some code which adds an event listener. However, the callback you specify is `setTimeout()`. This *calls* the function `setTimeout()` and therefore will set the callback as its return value.\r\n\r\nAs it happens, `setTimeout` returns an ID which can be used later to cancel the timeout. What you should do is pass the actual `setTimeout` function to the callback.\r\n\r\nOne way to do this is to wrap the `setTimeout` into another function (e.g. `function() { setTimeout(...) }`; or, you could do some clever binding of arguments which will accomplish a similar thing.\r\n\r\n(This issue causes errors in my console)\r\n\r\nAgain, awesome project!"},"comment":{"url":"https://api.github.com/repos/JamieOnUbuntu/results-whitelist/issues/comments/366452162","html_url":"https://github.com/JamieOnUbuntu/results-whitelist/issues/1#issuecomment-366452162","issue_url":"https://api.github.com/repos/JamieOnUbuntu/results-whitelist/issues/1","id":366452162,"user":{"login":"JamieOnUbuntu","id":10353998,"avatar_url":"https://avatars2.githubusercontent.com/u/10353998?v=4","gravatar_id":"","url":"https://api.github.com/users/JamieOnUbuntu","html_url":"https://github.com/JamieOnUbuntu","followers_url":"https://api.github.com/users/JamieOnUbuntu/followers","following_url":"https://api.github.com/users/JamieOnUbuntu/following{/other_user}","gists_url":"https://api.github.com/users/JamieOnUbuntu/gists{/gist_id}","starred_url":"https://api.github.com/users/JamieOnUbuntu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JamieOnUbuntu/subscriptions","organizations_url":"https://api.github.com/users/JamieOnUbuntu/orgs","repos_url":"https://api.github.com/users/JamieOnUbuntu/repos","events_url":"https://api.github.com/users/JamieOnUbuntu/events{/privacy}","received_events_url":"https://api.github.com/users/JamieOnUbuntu/received_events","type":"User","site_admin":false},"created_at":"2018-02-17T16:21:36Z","updated_at":"2018-02-17T16:21:36Z","author_association":"OWNER","body":"I removed the `DOMNodeInserted` event listener as that would make the script run every time a node was inserted, which for something like Google search is hundreds of times per page."}}
{"actor":{"display_login":"JamieOnUbuntu"}}