{"action":"created","issue":{"url":"https://api.github.com/repos/LMMS/lmms/issues/4397","repository_url":"https://api.github.com/repos/LMMS/lmms","labels_url":"https://api.github.com/repos/LMMS/lmms/issues/4397/labels{/name}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/4397/comments","events_url":"https://api.github.com/repos/LMMS/lmms/issues/4397/events","html_url":"https://github.com/LMMS/lmms/pull/4397","id":328839761,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjU0MjU4","number":4397,"title":"Improved Oscillators","user":{"login":"curlymorphic","id":7412852,"node_id":"MDQ6VXNlcjc0MTI4NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/7412852?v=4","gravatar_id":"","url":"https://api.github.com/users/curlymorphic","html_url":"https://github.com/curlymorphic","followers_url":"https://api.github.com/users/curlymorphic/followers","following_url":"https://api.github.com/users/curlymorphic/following{/other_user}","gists_url":"https://api.github.com/users/curlymorphic/gists{/gist_id}","starred_url":"https://api.github.com/users/curlymorphic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/curlymorphic/subscriptions","organizations_url":"https://api.github.com/users/curlymorphic/orgs","repos_url":"https://api.github.com/users/curlymorphic/repos","events_url":"https://api.github.com/users/curlymorphic/events{/privacy}","received_events_url":"https://api.github.com/users/curlymorphic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-03T15:57:15Z","updated_at":"2018-06-08T20:54:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/4397","html_url":"https://github.com/LMMS/lmms/pull/4397","diff_url":"https://github.com/LMMS/lmms/pull/4397.diff","patch_url":"https://github.com/LMMS/lmms/pull/4397.patch"},"body":"LMMS used the same oscillators in many places for audio generation. This pull request provides a band limited option, so no aliasing, and a cleaner signal. The Implementation has been via TripleOscillator, will the addition of a new button per oscillator allowing switching between the classic sounds, and the new. Currently the sin, triangle, saw, square, moog saw and the exponential waveforms have a band limited version. The user wave shape is still WIP\r\n\r\nThe clearness of the waveforms can be clearly heard, and becme more apparent when sing FM or phase mode, backward compatibility is retained.\r\n \r\n\r\n![image](https://user-images.githubusercontent.com/7412852/40888413-a25072d2-674e-11e8-977f-07ad0c6a9dff.png)\r\n\r\nI have a wiki page with explanations images and audio filles\r\nhttps://github.com/curlymorphic/lmms/wiki/LMMS-Oscillator-Class\r\n\r\nThis code is not being presented as finished, but I would like to present the concept for comments. \r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/LMMS/lmms/issues/comments/395887353","html_url":"https://github.com/LMMS/lmms/pull/4397#issuecomment-395887353","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/4397","id":395887353,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTg4NzM1Mw==","user":{"login":"karmux","id":2575235,"node_id":"MDQ6VXNlcjI1NzUyMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/2575235?v=4","gravatar_id":"","url":"https://api.github.com/users/karmux","html_url":"https://github.com/karmux","followers_url":"https://api.github.com/users/karmux/followers","following_url":"https://api.github.com/users/karmux/following{/other_user}","gists_url":"https://api.github.com/users/karmux/gists{/gist_id}","starred_url":"https://api.github.com/users/karmux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karmux/subscriptions","organizations_url":"https://api.github.com/users/karmux/orgs","repos_url":"https://api.github.com/users/karmux/repos","events_url":"https://api.github.com/users/karmux/events{/privacy}","received_events_url":"https://api.github.com/users/karmux/received_events","type":"User","site_admin":false},"created_at":"2018-06-08T20:54:20Z","updated_at":"2018-06-08T20:54:20Z","author_association":"CONTRIBUTOR","body":"One more issue.\r\n\r\nWhen default TripleOscillator/SEGuitar.xpf is played at the same time with simple beat made of kick01.ogg then LMMS always crashes very quickly. I can't crash LMMS when playing SEGuitar.xpf in solo."}}
{"actor":{"display_login":"karmux"}}