{"action":"closed","number":10404,"pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/10404","id":242368784,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMzY4Nzg0","html_url":"https://github.com/helm/charts/pull/10404","diff_url":"https://github.com/helm/charts/pull/10404.diff","patch_url":"https://github.com/helm/charts/pull/10404.patch","issue_url":"https://api.github.com/repos/helm/charts/issues/10404","number":10404,"state":"closed","locked":false,"title":"[node-problem-detector] parameterize location of logdir to make it run on RHEL and upgrade to latest release","user":{"login":"davidkarlsen","id":18299,"node_id":"MDQ6VXNlcjE4Mjk5","avatar_url":"https://avatars0.githubusercontent.com/u/18299?v=4","gravatar_id":"","url":"https://api.github.com/users/davidkarlsen","html_url":"https://github.com/davidkarlsen","followers_url":"https://api.github.com/users/davidkarlsen/followers","following_url":"https://api.github.com/users/davidkarlsen/following{/other_user}","gists_url":"https://api.github.com/users/davidkarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkarlsen/subscriptions","organizations_url":"https://api.github.com/users/davidkarlsen/orgs","repos_url":"https://api.github.com/users/davidkarlsen/repos","events_url":"https://api.github.com/users/davidkarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/davidkarlsen/received_events","type":"User","site_admin":false},"body":"Signed-off-by: David J. M. Karlsen <david@davidkarlsen.com>\r\n\r\n#### What this PR does / why we need it:\r\nThe logdir needs to be parameterized to suit several distros. RHEL has journal on /run/log\r\n\r\n#### Which issue this PR fixes\r\n*(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*\r\n  - fixes #\r\n\r\n#### Special notes for your reviewer:\r\nSee https://github.com/kubernetes/node-problem-detector\r\n\r\n#### Checklist\r\n[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]\r\n- [X] [DCO](https://www.helm.sh/blog/helm-dco/index.html) signed\r\n- [X] Chart Version bumped\r\n- [X] Variables are documented in the README.md\r\n","created_at":"2019-01-04T20:49:54Z","updated_at":"2019-01-05T00:15:42Z","closed_at":"2019-01-05T00:15:41Z","merged_at":"2019-01-05T00:15:41Z","merge_commit_sha":"921e968df19a06272f9571b9cc7aa4d96c91cfdc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lachie83","id":6912984,"node_id":"MDQ6VXNlcjY5MTI5ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6912984?v=4","gravatar_id":"","url":"https://api.github.com/users/lachie83","html_url":"https://github.com/lachie83","followers_url":"https://api.github.com/users/lachie83/followers","following_url":"https://api.github.com/users/lachie83/following{/other_user}","gists_url":"https://api.github.com/users/lachie83/gists{/gist_id}","starred_url":"https://api.github.com/users/lachie83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lachie83/subscriptions","organizations_url":"https://api.github.com/users/lachie83/orgs","repos_url":"https://api.github.com/users/lachie83/repos","events_url":"https://api.github.com/users/lachie83/events{/privacy}","received_events_url":"https://api.github.com/users/lachie83/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":764227863,"node_id":"MDU6TGFiZWw3NjQyMjc4NjM=","url":"https://api.github.com/repos/helm/charts/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":352669720,"node_id":"MDU6TGFiZWwzNTI2Njk3MjA=","url":"https://api.github.com/repos/helm/charts/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":676009699,"node_id":"MDU6TGFiZWw2NzYwMDk2OTk=","url":"https://api.github.com/repos/helm/charts/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/helm/charts/pulls/10404/commits","review_comments_url":"https://api.github.com/repos/helm/charts/pulls/10404/comments","review_comment_url":"https://api.github.com/repos/helm/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helm/charts/issues/10404/comments","statuses_url":"https://api.github.com/repos/helm/charts/statuses/542eb1cae6fb13e6dba390179ed919e7eafec21e","head":{"label":"davidkarlsen:paramNodeProblemDetectorLogPath","ref":"paramNodeProblemDetectorLogPath","sha":"542eb1cae6fb13e6dba390179ed919e7eafec21e","user":{"login":"davidkarlsen","id":18299,"node_id":"MDQ6VXNlcjE4Mjk5","avatar_url":"https://avatars0.githubusercontent.com/u/18299?v=4","gravatar_id":"","url":"https://api.github.com/users/davidkarlsen","html_url":"https://github.com/davidkarlsen","followers_url":"https://api.github.com/users/davidkarlsen/followers","following_url":"https://api.github.com/users/davidkarlsen/following{/other_user}","gists_url":"https://api.github.com/users/davidkarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkarlsen/subscriptions","organizations_url":"https://api.github.com/users/davidkarlsen/orgs","repos_url":"https://api.github.com/users/davidkarlsen/repos","events_url":"https://api.github.com/users/davidkarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/davidkarlsen/received_events","type":"User","site_admin":false},"repo":{"id":115001085,"node_id":"MDEwOlJlcG9zaXRvcnkxMTUwMDEwODU=","name":"charts","full_name":"davidkarlsen/charts","private":false,"owner":{"login":"davidkarlsen","id":18299,"node_id":"MDQ6VXNlcjE4Mjk5","avatar_url":"https://avatars0.githubusercontent.com/u/18299?v=4","gravatar_id":"","url":"https://api.github.com/users/davidkarlsen","html_url":"https://github.com/davidkarlsen","followers_url":"https://api.github.com/users/davidkarlsen/followers","following_url":"https://api.github.com/users/davidkarlsen/following{/other_user}","gists_url":"https://api.github.com/users/davidkarlsen/gists{/gist_id}","starred_url":"https://api.github.com/users/davidkarlsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidkarlsen/subscriptions","organizations_url":"https://api.github.com/users/davidkarlsen/orgs","repos_url":"https://api.github.com/users/davidkarlsen/repos","events_url":"https://api.github.com/users/davidkarlsen/events{/privacy}","received_events_url":"https://api.github.com/users/davidkarlsen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/davidkarlsen/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/davidkarlsen/charts","forks_url":"https://api.github.com/repos/davidkarlsen/charts/forks","keys_url":"https://api.github.com/repos/davidkarlsen/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidkarlsen/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidkarlsen/charts/teams","hooks_url":"https://api.github.com/repos/davidkarlsen/charts/hooks","issue_events_url":"https://api.github.com/repos/davidkarlsen/charts/issues/events{/number}","events_url":"https://api.github.com/repos/davidkarlsen/charts/events","assignees_url":"https://api.github.com/repos/davidkarlsen/charts/assignees{/user}","branches_url":"https://api.github.com/repos/davidkarlsen/charts/branches{/branch}","tags_url":"https://api.github.com/repos/davidkarlsen/charts/tags","blobs_url":"https://api.github.com/repos/davidkarlsen/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidkarlsen/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidkarlsen/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidkarlsen/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidkarlsen/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/davidkarlsen/charts/languages","stargazers_url":"https://api.github.com/repos/davidkarlsen/charts/stargazers","contributors_url":"https://api.github.com/repos/davidkarlsen/charts/contributors","subscribers_url":"https://api.github.com/repos/davidkarlsen/charts/subscribers","subscription_url":"https://api.github.com/repos/davidkarlsen/charts/subscription","commits_url":"https://api.github.com/repos/davidkarlsen/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidkarlsen/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidkarlsen/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidkarlsen/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidkarlsen/charts/contents/{+path}","compare_url":"https://api.github.com/repos/davidkarlsen/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidkarlsen/charts/merges","archive_url":"https://api.github.com/repos/davidkarlsen/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidkarlsen/charts/downloads","issues_url":"https://api.github.com/repos/davidkarlsen/charts/issues{/number}","pulls_url":"https://api.github.com/repos/davidkarlsen/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/davidkarlsen/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/davidkarlsen/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidkarlsen/charts/labels{/name}","releases_url":"https://api.github.com/repos/davidkarlsen/charts/releases{/id}","deployments_url":"https://api.github.com/repos/davidkarlsen/charts/deployments","created_at":"2017-12-21T11:59:09Z","updated_at":"2019-01-04T22:29:43Z","pushed_at":"2019-01-04T23:00:37Z","git_url":"git://github.com/davidkarlsen/charts.git","ssh_url":"git@github.com:davidkarlsen/charts.git","clone_url":"https://github.com/davidkarlsen/charts.git","svn_url":"https://github.com/davidkarlsen/charts","homepage":"","size":15332,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"helm:master","ref":"master","sha":"48503bacd1fb53edea643cc771b578c0c499ce9f","user":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwNjE4NA==","name":"charts","full_name":"helm/charts","private":false,"owner":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/helm/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/helm/charts","forks_url":"https://api.github.com/repos/helm/charts/forks","keys_url":"https://api.github.com/repos/helm/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helm/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helm/charts/teams","hooks_url":"https://api.github.com/repos/helm/charts/hooks","issue_events_url":"https://api.github.com/repos/helm/charts/issues/events{/number}","events_url":"https://api.github.com/repos/helm/charts/events","assignees_url":"https://api.github.com/repos/helm/charts/assignees{/user}","branches_url":"https://api.github.com/repos/helm/charts/branches{/branch}","tags_url":"https://api.github.com/repos/helm/charts/tags","blobs_url":"https://api.github.com/repos/helm/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helm/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helm/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/helm/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helm/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/helm/charts/languages","stargazers_url":"https://api.github.com/repos/helm/charts/stargazers","contributors_url":"https://api.github.com/repos/helm/charts/contributors","subscribers_url":"https://api.github.com/repos/helm/charts/subscribers","subscription_url":"https://api.github.com/repos/helm/charts/subscription","commits_url":"https://api.github.com/repos/helm/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/helm/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/helm/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/helm/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/helm/charts/contents/{+path}","compare_url":"https://api.github.com/repos/helm/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helm/charts/merges","archive_url":"https://api.github.com/repos/helm/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helm/charts/downloads","issues_url":"https://api.github.com/repos/helm/charts/issues{/number}","pulls_url":"https://api.github.com/repos/helm/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/helm/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/helm/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helm/charts/labels{/name}","releases_url":"https://api.github.com/repos/helm/charts/releases{/id}","deployments_url":"https://api.github.com/repos/helm/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2019-01-05T00:05:36Z","pushed_at":"2019-01-05T00:15:41Z","git_url":"git://github.com/helm/charts.git","ssh_url":"git@github.com:helm/charts.git","clone_url":"https://github.com/helm/charts.git","svn_url":"https://github.com/helm/charts","homepage":"","size":15355,"stargazers_count":6249,"watchers_count":6249,"language":"Smarty","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5752,"mirror_url":null,"archived":false,"open_issues_count":580,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5752,"open_issues":580,"watchers":6249,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/10404"},"html":{"href":"https://github.com/helm/charts/pull/10404"},"issue":{"href":"https://api.github.com/repos/helm/charts/issues/10404"},"comments":{"href":"https://api.github.com/repos/helm/charts/issues/10404/comments"},"review_comments":{"href":"https://api.github.com/repos/helm/charts/pulls/10404/comments"},"review_comment":{"href":"https://api.github.com/repos/helm/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helm/charts/pulls/10404/commits"},"statuses":{"href":"https://api.github.com/repos/helm/charts/statuses/542eb1cae6fb13e6dba390179ed919e7eafec21e"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":8,"deletions":5,"changed_files":4}}
{"actor":{"display_login":"k8s-ci-robot"}}