{"action":"created","comment":{"url":"https://api.github.com/repos/munin-monitoring/contrib/pulls/comments/217911266","pull_request_review_id":155741825,"id":217911266,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzkxMTI2Ng==","diff_hunk":"@@ -0,0 +1,202 @@\n+#!/bin/bash\n+# -*- sh -*-\n+\n+: << =cut\n+\n+=pod\n+\n+=encoding UTF-8\n+\n+=head1 NAME\n+\n+cake_ - Plugin to monitor cake's backlog, dropped, overlimits and requeues\n+\n+=head1 CONFIGURATION\n+\n+None needed.\n+\n+=head1 INTERPRETATION\n+\n+Cake, also known as sch_cake is a modern bandwidth limiter, which eliminates\n+buffer bloat over slow links. It's also capable to give flows, hosts and each \n+flow of each host a fair part of the avaible bandwidth.\n+\n+This plugin allows for a monitor of the pressure on the qdisc, by monitoring key\n+values.\n+\n+=head1 SEE ALSO\n+\n+Take a look at \"man cake\" to get more information about cake.\n+\n+=head1 MAGIC MARKERS\n+\n+ #%# family=auto\n+ #%# capabilities=autoconf suggest\n+\n+=head1 AUTHORS\n+\n+RubenKelevra <ruben@vfn-nrw.de>\n+\n+work based on the tc plugin, authors:\n+Steve Schnepp <steve.schnepp@gmail.com>,\n+Samuel Smith <esaym@cpan.org>,\n+Nye Liu <nyet@nyet.org>\n+\n+=head1 LICENSE\n+\n+GPLv2 or later\n+\n+=cut\n+\n+DEVICE=${0##*/cake_}\n+\n+tc_get_ifb_dev() {\n+\tdev=\"$(/sbin/tc filter show dev $DEVICE parent ffff: protocol all | grep \"mirred\" | grep \"Egress Redirect to device\")\"","path":"plugins/cake/cake_","position":null,"original_position":54,"commit_id":"7540eb3102231919aeadf2580565f5b07d8137a4","original_commit_id":"86df21bd13614b12a469749195cb77c55b3a08a6","user":{"login":"sumpfralle","id":1474141,"node_id":"MDQ6VXNlcjE0NzQxNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1474141?v=4","gravatar_id":"","url":"https://api.github.com/users/sumpfralle","html_url":"https://github.com/sumpfralle","followers_url":"https://api.github.com/users/sumpfralle/followers","following_url":"https://api.github.com/users/sumpfralle/following{/other_user}","gists_url":"https://api.github.com/users/sumpfralle/gists{/gist_id}","starred_url":"https://api.github.com/users/sumpfralle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumpfralle/subscriptions","organizations_url":"https://api.github.com/users/sumpfralle/orgs","repos_url":"https://api.github.com/users/sumpfralle/repos","events_url":"https://api.github.com/users/sumpfralle/events{/privacy}","received_events_url":"https://api.github.com/users/sumpfralle/received_events","type":"User","site_admin":false},"body":"I am not sure, if you meant this serious, but I will just follow your invitation for spoon feeding :)\r\n```shell\r\ngrep \"mirred.*Egress Redirect to device\"\r\n```\r\n\r\nAdditionally this would be a great place for adding a comment with this expected example output line. This will ease the life of future readers of the code.\r\n\r\nAnd I have to admit, that this line of output looks quite human-centric and thus will *really change* somewhen. `json` would be your friend :)","created_at":"2018-09-16T11:41:57Z","updated_at":"2018-09-16T11:41:57Z","html_url":"https://github.com/munin-monitoring/contrib/pull/941#discussion_r217911266","pull_request_url":"https://api.github.com/repos/munin-monitoring/contrib/pulls/941","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/munin-monitoring/contrib/pulls/comments/217911266"},"html":{"href":"https://github.com/munin-monitoring/contrib/pull/941#discussion_r217911266"},"pull_request":{"href":"https://api.github.com/repos/munin-monitoring/contrib/pulls/941"}},"in_reply_to_id":217464224},"pull_request":{"url":"https://api.github.com/repos/munin-monitoring/contrib/pulls/941","id":214492567,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDkyNTY3","html_url":"https://github.com/munin-monitoring/contrib/pull/941","diff_url":"https://github.com/munin-monitoring/contrib/pull/941.diff","patch_url":"https://github.com/munin-monitoring/contrib/pull/941.patch","issue_url":"https://api.github.com/repos/munin-monitoring/contrib/issues/941","number":941,"state":"open","locked":false,"title":"[WIP] cake plugins","user":{"login":"RubenKelevra","id":614929,"node_id":"MDQ6VXNlcjYxNDkyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/614929?v=4","gravatar_id":"","url":"https://api.github.com/users/RubenKelevra","html_url":"https://github.com/RubenKelevra","followers_url":"https://api.github.com/users/RubenKelevra/followers","following_url":"https://api.github.com/users/RubenKelevra/following{/other_user}","gists_url":"https://api.github.com/users/RubenKelevra/gists{/gist_id}","starred_url":"https://api.github.com/users/RubenKelevra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RubenKelevra/subscriptions","organizations_url":"https://api.github.com/users/RubenKelevra/orgs","repos_url":"https://api.github.com/users/RubenKelevra/repos","events_url":"https://api.github.com/users/RubenKelevra/events{/privacy}","received_events_url":"https://api.github.com/users/RubenKelevra/received_events","type":"User","site_admin":false},"body":"cake.cake_  renders the drops, overlimits and requeues as well as the backlog\r\n![cake_wlp3s0-day](https://user-images.githubusercontent.com/614929/45333880-8f51b600-b578-11e8-8d27-8bb3e63ea0ec.png)\r\n\r\ncake.cake_tin_ renders the packets sent in each tin\r\n![cake_tin_wlp3s0-day](https://user-images.githubusercontent.com/614929/45333871-8234c700-b578-11e8-92bf-7b99116bb5c5.png)\r\n_This plugin can handle diffserv3, diffserv4 and diffserv8... while diffserv8 is somewhat incompatible with the others, since the tins are named differently._\r\n\r\n@sumpfralle thanks for your initial feedback.\r\n\r\n- No, the arrays won't work on POSIX shells, so I changed the shell required to bash.\r\n- I thought again about the name. But it looks still fine to me.\r\n- I really dislike those multigraph plugins, since they, well multigraph, which would be a mess with all those values. So I think I'll stick with the stacked area graphs per interface - thanks for your idea on that, anyway. :)\r\n- The `exit 1` for autoconf is exactly like on network.tc_, so I like to stick with this for the moment. If you think, that's an issue, feel free to change my plugin as well, when you fix network.tc_\r\n\r\n\r\n\r\n","created_at":"2018-09-11T02:09:10Z","updated_at":"2018-09-16T11:41:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1dae40be22ac72eec7cd67ec8c03feb4031300b9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/munin-monitoring/contrib/pulls/941/commits","review_comments_url":"https://api.github.com/repos/munin-monitoring/contrib/pulls/941/comments","review_comment_url":"https://api.github.com/repos/munin-monitoring/contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/munin-monitoring/contrib/issues/941/comments","statuses_url":"https://api.github.com/repos/munin-monitoring/contrib/statuses/7540eb3102231919aeadf2580565f5b07d8137a4","head":{"label":"RubenKelevra:cake_plugins","ref":"cake_plugins","sha":"7540eb3102231919aeadf2580565f5b07d8137a4","user":{"login":"RubenKelevra","id":614929,"node_id":"MDQ6VXNlcjYxNDkyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/614929?v=4","gravatar_id":"","url":"https://api.github.com/users/RubenKelevra","html_url":"https://github.com/RubenKelevra","followers_url":"https://api.github.com/users/RubenKelevra/followers","following_url":"https://api.github.com/users/RubenKelevra/following{/other_user}","gists_url":"https://api.github.com/users/RubenKelevra/gists{/gist_id}","starred_url":"https://api.github.com/users/RubenKelevra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RubenKelevra/subscriptions","organizations_url":"https://api.github.com/users/RubenKelevra/orgs","repos_url":"https://api.github.com/users/RubenKelevra/repos","events_url":"https://api.github.com/users/RubenKelevra/events{/privacy}","received_events_url":"https://api.github.com/users/RubenKelevra/received_events","type":"User","site_admin":false},"repo":{"id":148195485,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgxOTU0ODU=","name":"contrib","full_name":"RubenKelevra/contrib","private":false,"owner":{"login":"RubenKelevra","id":614929,"node_id":"MDQ6VXNlcjYxNDkyOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/614929?v=4","gravatar_id":"","url":"https://api.github.com/users/RubenKelevra","html_url":"https://github.com/RubenKelevra","followers_url":"https://api.github.com/users/RubenKelevra/followers","following_url":"https://api.github.com/users/RubenKelevra/following{/other_user}","gists_url":"https://api.github.com/users/RubenKelevra/gists{/gist_id}","starred_url":"https://api.github.com/users/RubenKelevra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RubenKelevra/subscriptions","organizations_url":"https://api.github.com/users/RubenKelevra/orgs","repos_url":"https://api.github.com/users/RubenKelevra/repos","events_url":"https://api.github.com/users/RubenKelevra/events{/privacy}","received_events_url":"https://api.github.com/users/RubenKelevra/received_events","type":"User","site_admin":false},"html_url":"https://github.com/RubenKelevra/contrib","description":"Contributed stuff for munin (plugins, tools, etc...)","fork":true,"url":"https://api.github.com/repos/RubenKelevra/contrib","forks_url":"https://api.github.com/repos/RubenKelevra/contrib/forks","keys_url":"https://api.github.com/repos/RubenKelevra/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RubenKelevra/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RubenKelevra/contrib/teams","hooks_url":"https://api.github.com/repos/RubenKelevra/contrib/hooks","issue_events_url":"https://api.github.com/repos/RubenKelevra/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/RubenKelevra/contrib/events","assignees_url":"https://api.github.com/repos/RubenKelevra/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/RubenKelevra/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/RubenKelevra/contrib/tags","blobs_url":"https://api.github.com/repos/RubenKelevra/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RubenKelevra/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RubenKelevra/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/RubenKelevra/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RubenKelevra/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/RubenKelevra/contrib/languages","stargazers_url":"https://api.github.com/repos/RubenKelevra/contrib/stargazers","contributors_url":"https://api.github.com/repos/RubenKelevra/contrib/contributors","subscribers_url":"https://api.github.com/repos/RubenKelevra/contrib/subscribers","subscription_url":"https://api.github.com/repos/RubenKelevra/contrib/subscription","commits_url":"https://api.github.com/repos/RubenKelevra/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/RubenKelevra/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/RubenKelevra/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/RubenKelevra/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/RubenKelevra/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/RubenKelevra/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RubenKelevra/contrib/merges","archive_url":"https://api.github.com/repos/RubenKelevra/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RubenKelevra/contrib/downloads","issues_url":"https://api.github.com/repos/RubenKelevra/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/RubenKelevra/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/RubenKelevra/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/RubenKelevra/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RubenKelevra/contrib/labels{/name}","releases_url":"https://api.github.com/repos/RubenKelevra/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/RubenKelevra/contrib/deployments","created_at":"2018-09-10T17:48:16Z","updated_at":"2018-09-10T19:11:00Z","pushed_at":"2018-09-16T08:17:57Z","git_url":"git://github.com/RubenKelevra/contrib.git","ssh_url":"git@github.com:RubenKelevra/contrib.git","clone_url":"https://github.com/RubenKelevra/contrib.git","svn_url":"https://github.com/RubenKelevra/contrib","homepage":"http://munin-monitoring.org","size":9995,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"munin-monitoring:master","ref":"master","sha":"f96bcb415a79a6df419a9af2aa1a1271cd8a9762","user":{"login":"munin-monitoring","id":909917,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwOTkxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/909917?v=4","gravatar_id":"","url":"https://api.github.com/users/munin-monitoring","html_url":"https://github.com/munin-monitoring","followers_url":"https://api.github.com/users/munin-monitoring/followers","following_url":"https://api.github.com/users/munin-monitoring/following{/other_user}","gists_url":"https://api.github.com/users/munin-monitoring/gists{/gist_id}","starred_url":"https://api.github.com/users/munin-monitoring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munin-monitoring/subscriptions","organizations_url":"https://api.github.com/users/munin-monitoring/orgs","repos_url":"https://api.github.com/users/munin-monitoring/repos","events_url":"https://api.github.com/users/munin-monitoring/events{/privacy}","received_events_url":"https://api.github.com/users/munin-monitoring/received_events","type":"Organization","site_admin":false},"repo":{"id":2035393,"node_id":"MDEwOlJlcG9zaXRvcnkyMDM1Mzkz","name":"contrib","full_name":"munin-monitoring/contrib","private":false,"owner":{"login":"munin-monitoring","id":909917,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwOTkxNw==","avatar_url":"https://avatars0.githubusercontent.com/u/909917?v=4","gravatar_id":"","url":"https://api.github.com/users/munin-monitoring","html_url":"https://github.com/munin-monitoring","followers_url":"https://api.github.com/users/munin-monitoring/followers","following_url":"https://api.github.com/users/munin-monitoring/following{/other_user}","gists_url":"https://api.github.com/users/munin-monitoring/gists{/gist_id}","starred_url":"https://api.github.com/users/munin-monitoring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/munin-monitoring/subscriptions","organizations_url":"https://api.github.com/users/munin-monitoring/orgs","repos_url":"https://api.github.com/users/munin-monitoring/repos","events_url":"https://api.github.com/users/munin-monitoring/events{/privacy}","received_events_url":"https://api.github.com/users/munin-monitoring/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/munin-monitoring/contrib","description":"Contributed stuff for munin (plugins, tools, etc...)","fork":false,"url":"https://api.github.com/repos/munin-monitoring/contrib","forks_url":"https://api.github.com/repos/munin-monitoring/contrib/forks","keys_url":"https://api.github.com/repos/munin-monitoring/contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/munin-monitoring/contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/munin-monitoring/contrib/teams","hooks_url":"https://api.github.com/repos/munin-monitoring/contrib/hooks","issue_events_url":"https://api.github.com/repos/munin-monitoring/contrib/issues/events{/number}","events_url":"https://api.github.com/repos/munin-monitoring/contrib/events","assignees_url":"https://api.github.com/repos/munin-monitoring/contrib/assignees{/user}","branches_url":"https://api.github.com/repos/munin-monitoring/contrib/branches{/branch}","tags_url":"https://api.github.com/repos/munin-monitoring/contrib/tags","blobs_url":"https://api.github.com/repos/munin-monitoring/contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/munin-monitoring/contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/munin-monitoring/contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/munin-monitoring/contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/munin-monitoring/contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/munin-monitoring/contrib/languages","stargazers_url":"https://api.github.com/repos/munin-monitoring/contrib/stargazers","contributors_url":"https://api.github.com/repos/munin-monitoring/contrib/contributors","subscribers_url":"https://api.github.com/repos/munin-monitoring/contrib/subscribers","subscription_url":"https://api.github.com/repos/munin-monitoring/contrib/subscription","commits_url":"https://api.github.com/repos/munin-monitoring/contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/munin-monitoring/contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/munin-monitoring/contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/munin-monitoring/contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/munin-monitoring/contrib/contents/{+path}","compare_url":"https://api.github.com/repos/munin-monitoring/contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/munin-monitoring/contrib/merges","archive_url":"https://api.github.com/repos/munin-monitoring/contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/munin-monitoring/contrib/downloads","issues_url":"https://api.github.com/repos/munin-monitoring/contrib/issues{/number}","pulls_url":"https://api.github.com/repos/munin-monitoring/contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/munin-monitoring/contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/munin-monitoring/contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/munin-monitoring/contrib/labels{/name}","releases_url":"https://api.github.com/repos/munin-monitoring/contrib/releases{/id}","deployments_url":"https://api.github.com/repos/munin-monitoring/contrib/deployments","created_at":"2011-07-12T10:12:34Z","updated_at":"2018-09-14T20:11:03Z","pushed_at":"2018-09-16T08:17:59Z","git_url":"git://github.com/munin-monitoring/contrib.git","ssh_url":"git@github.com:munin-monitoring/contrib.git","clone_url":"https://github.com/munin-monitoring/contrib.git","svn_url":"https://github.com/munin-monitoring/contrib","homepage":"http://munin-monitoring.org","size":10000,"stargazers_count":988,"watchers_count":988,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":613,"mirror_url":null,"archived":false,"open_issues_count":37,"license":null,"forks":613,"open_issues":37,"watchers":988,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/munin-monitoring/contrib/pulls/941"},"html":{"href":"https://github.com/munin-monitoring/contrib/pull/941"},"issue":{"href":"https://api.github.com/repos/munin-monitoring/contrib/issues/941"},"comments":{"href":"https://api.github.com/repos/munin-monitoring/contrib/issues/941/comments"},"review_comments":{"href":"https://api.github.com/repos/munin-monitoring/contrib/pulls/941/comments"},"review_comment":{"href":"https://api.github.com/repos/munin-monitoring/contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/munin-monitoring/contrib/pulls/941/commits"},"statuses":{"href":"https://api.github.com/repos/munin-monitoring/contrib/statuses/7540eb3102231919aeadf2580565f5b07d8137a4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sumpfralle"}}