{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/212013913","pull_request_review_id":148555562,"id":212013913,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjAxMzkxMw==","diff_hunk":"@@ -0,0 +1,21 @@\n+{\n+    \"extends\": \"dtslint/dt.json\",\n+    \"rules\": {\n+        \"comment-format\": false,","path":"types/strophe.js/tslint.json","position":4,"original_position":4,"commit_id":"75457ed6d50288ddc9c08ebb637379b9aa34fa37","original_commit_id":"75457ed6d50288ddc9c08ebb637379b9aa34fa37","user":{"login":"uniqueiniquity","id":9092011,"node_id":"MDQ6VXNlcjkwOTIwMTE=","avatar_url":"https://avatars1.githubusercontent.com/u/9092011?v=4","gravatar_id":"","url":"https://api.github.com/users/uniqueiniquity","html_url":"https://github.com/uniqueiniquity","followers_url":"https://api.github.com/users/uniqueiniquity/followers","following_url":"https://api.github.com/users/uniqueiniquity/following{/other_user}","gists_url":"https://api.github.com/users/uniqueiniquity/gists{/gist_id}","starred_url":"https://api.github.com/users/uniqueiniquity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uniqueiniquity/subscriptions","organizations_url":"https://api.github.com/users/uniqueiniquity/orgs","repos_url":"https://api.github.com/users/uniqueiniquity/repos","events_url":"https://api.github.com/users/uniqueiniquity/events{/privacy}","received_events_url":"https://api.github.com/users/uniqueiniquity/received_events","type":"User","site_admin":false},"body":"Sorry to keep making you go through this, but we'd really like to get all of these rules enabled, since most indicate some issue you'll hit in the future. Can you document where each of these is causing issues? I'll be able to help resolve them then.","created_at":"2018-08-22T16:04:45Z","updated_at":"2018-08-22T16:06:11Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28257#discussion_r212013913","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28257","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/212013913"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28257#discussion_r212013913"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28257"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28257","id":209729752,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NzI5NzUy","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28257","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28257.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28257.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28257","number":28257,"state":"open","locked":false,"title":"Definitions for strophe.js, as suggested in PR #27682.","user":{"login":"tijszwinkels","id":140654,"node_id":"MDQ6VXNlcjE0MDY1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/140654?v=4","gravatar_id":"","url":"https://api.github.com/users/tijszwinkels","html_url":"https://github.com/tijszwinkels","followers_url":"https://api.github.com/users/tijszwinkels/followers","following_url":"https://api.github.com/users/tijszwinkels/following{/other_user}","gists_url":"https://api.github.com/users/tijszwinkels/gists{/gist_id}","starred_url":"https://api.github.com/users/tijszwinkels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tijszwinkels/subscriptions","organizations_url":"https://api.github.com/users/tijszwinkels/orgs","repos_url":"https://api.github.com/users/tijszwinkels/repos","events_url":"https://api.github.com/users/tijszwinkels/events{/privacy}","received_events_url":"https://api.github.com/users/tijszwinkels/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf adding a new definition: \r\n_Please note: This is not really a new definition, it's just a renamed 'strophe' package._\r\n- [x] The package does not already provide its own types, or cannot have its `.d.ts` files generated via `--declaration`\r\n- [x] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.\r\n- [] Create it with `dts-gen --dt`, not by basing it on an existing project.\r\n- [] `tslint.json` should be present, and `tsconfig.json` should have `noImplicitAny`, `noImplicitThis`, `strictNullChecks`, and `strictFunctionTypes` set to `true`.\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/27682\r\n- [] Increase the version number in the header if appropriate.\r\n- [] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n","created_at":"2018-08-21T07:17:39Z","updated_at":"2018-08-22T16:06:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ea929d617b42d382cb210b13dda0095caaf0fdc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":646788888,"node_id":"MDU6TGFiZWw2NDY3ODg4ODg=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/New%20Definition","name":"New Definition","color":"4eca56","default":false},{"id":395679059,"node_id":"MDU6TGFiZWwzOTU2NzkwNTk=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Revision%20needed","name":"Revision needed","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28257/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28257/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28257/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/75457ed6d50288ddc9c08ebb637379b9aa34fa37","head":{"label":"tijszwinkels:strophe.js","ref":"strophe.js","sha":"75457ed6d50288ddc9c08ebb637379b9aa34fa37","user":{"login":"tijszwinkels","id":140654,"node_id":"MDQ6VXNlcjE0MDY1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/140654?v=4","gravatar_id":"","url":"https://api.github.com/users/tijszwinkels","html_url":"https://github.com/tijszwinkels","followers_url":"https://api.github.com/users/tijszwinkels/followers","following_url":"https://api.github.com/users/tijszwinkels/following{/other_user}","gists_url":"https://api.github.com/users/tijszwinkels/gists{/gist_id}","starred_url":"https://api.github.com/users/tijszwinkels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tijszwinkels/subscriptions","organizations_url":"https://api.github.com/users/tijszwinkels/orgs","repos_url":"https://api.github.com/users/tijszwinkels/repos","events_url":"https://api.github.com/users/tijszwinkels/events{/privacy}","received_events_url":"https://api.github.com/users/tijszwinkels/received_events","type":"User","site_admin":false},"repo":{"id":142855357,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI4NTUzNTc=","name":"DefinitelyTyped","full_name":"tijszwinkels/DefinitelyTyped","owner":{"login":"tijszwinkels","id":140654,"node_id":"MDQ6VXNlcjE0MDY1NA==","avatar_url":"https://avatars0.githubusercontent.com/u/140654?v=4","gravatar_id":"","url":"https://api.github.com/users/tijszwinkels","html_url":"https://github.com/tijszwinkels","followers_url":"https://api.github.com/users/tijszwinkels/followers","following_url":"https://api.github.com/users/tijszwinkels/following{/other_user}","gists_url":"https://api.github.com/users/tijszwinkels/gists{/gist_id}","starred_url":"https://api.github.com/users/tijszwinkels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tijszwinkels/subscriptions","organizations_url":"https://api.github.com/users/tijszwinkels/orgs","repos_url":"https://api.github.com/users/tijszwinkels/repos","events_url":"https://api.github.com/users/tijszwinkels/events{/privacy}","received_events_url":"https://api.github.com/users/tijszwinkels/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tijszwinkels/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped","forks_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/tijszwinkels/DefinitelyTyped/deployments","created_at":"2018-07-30T09:36:45Z","updated_at":"2018-08-20T18:25:55Z","pushed_at":"2018-08-22T07:40:12Z","git_url":"git://github.com/tijszwinkels/DefinitelyTyped.git","ssh_url":"git@github.com:tijszwinkels/DefinitelyTyped.git","clone_url":"https://github.com/tijszwinkels/DefinitelyTyped.git","svn_url":"https://github.com/tijszwinkels/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":348424,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"b3c691dcd2f1379e324a89ae6782b503edabd39b","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-08-22T16:00:58Z","pushed_at":"2018-08-22T15:59:45Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":348868,"stargazers_count":17033,"watchers_count":17033,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14231,"mirror_url":null,"archived":false,"open_issues_count":2366,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14231,"open_issues":2366,"watchers":17033,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28257"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28257"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28257"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28257/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28257/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28257/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/75457ed6d50288ddc9c08ebb637379b9aa34fa37"}},"author_association":"NONE"}}
{"actor":{"display_login":"uniqueiniquity"}}