{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/blikenoother/aiourlshortener/pulls/7","id":166926985,"html_url":"https://github.com/blikenoother/aiourlshortener/pull/7","diff_url":"https://github.com/blikenoother/aiourlshortener/pull/7.diff","patch_url":"https://github.com/blikenoother/aiourlshortener/pull/7.patch","issue_url":"https://api.github.com/repos/blikenoother/aiourlshortener/issues/7","number":7,"state":"closed","locked":false,"title":"Refactor shortener keyword arguments","user":{"login":"das7pad","id":17931887,"avatar_url":"https://avatars3.githubusercontent.com/u/17931887?v=4","gravatar_id":"","url":"https://api.github.com/users/das7pad","html_url":"https://github.com/das7pad","followers_url":"https://api.github.com/users/das7pad/followers","following_url":"https://api.github.com/users/das7pad/following{/other_user}","gists_url":"https://api.github.com/users/das7pad/gists{/gist_id}","starred_url":"https://api.github.com/users/das7pad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/das7pad/subscriptions","organizations_url":"https://api.github.com/users/das7pad/orgs","repos_url":"https://api.github.com/users/das7pad/repos","events_url":"https://api.github.com/users/das7pad/events{/privacy}","received_events_url":"https://api.github.com/users/das7pad/received_events","type":"User","site_admin":false},"body":"- use the builtin mechanics to\r\n  -  set a keyword argument default https://github.com/blikenoother/aiourlshortener/commit/d016a961d2dbe6fd052e411f6c355504f706e4c2\r\n  - require a keyword argument https://github.com/blikenoother/aiourlshortener/commit/234a473356a952ad36cc57bd0c1c0d5e0271e9e2\r\n- `aiohttp` can handle the connection timeout for us https://github.com/blikenoother/aiourlshortener/commit/d016a961d2dbe6fd052e411f6c355504f706e4c2\r\n\r\nWith https://github.com/blikenoother/aiourlshortener/commit/d016a961d2dbe6fd052e411f6c355504f706e4c2 we can increase or decrease the timeout [in one place](https://github.com/das7pad/aiourlshortener/blob/234a473356a952ad36cc57bd0c1c0d5e0271e9e2/aiourlshortener/shorteners/base.py#L9).","created_at":"2018-02-02T23:30:14Z","updated_at":"2018-02-04T07:00:03Z","closed_at":"2018-02-04T07:00:03Z","merged_at":"2018-02-04T07:00:03Z","merge_commit_sha":"be9f41dcf93f131094616c06a61416035703546a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/blikenoother/aiourlshortener/pulls/7/commits","review_comments_url":"https://api.github.com/repos/blikenoother/aiourlshortener/pulls/7/comments","review_comment_url":"https://api.github.com/repos/blikenoother/aiourlshortener/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blikenoother/aiourlshortener/issues/7/comments","statuses_url":"https://api.github.com/repos/blikenoother/aiourlshortener/statuses/234a473356a952ad36cc57bd0c1c0d5e0271e9e2","head":{"label":"das7pad:refactor-shortener-kwargs","ref":"refactor-shortener-kwargs","sha":"234a473356a952ad36cc57bd0c1c0d5e0271e9e2","user":{"login":"das7pad","id":17931887,"avatar_url":"https://avatars3.githubusercontent.com/u/17931887?v=4","gravatar_id":"","url":"https://api.github.com/users/das7pad","html_url":"https://github.com/das7pad","followers_url":"https://api.github.com/users/das7pad/followers","following_url":"https://api.github.com/users/das7pad/following{/other_user}","gists_url":"https://api.github.com/users/das7pad/gists{/gist_id}","starred_url":"https://api.github.com/users/das7pad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/das7pad/subscriptions","organizations_url":"https://api.github.com/users/das7pad/orgs","repos_url":"https://api.github.com/users/das7pad/repos","events_url":"https://api.github.com/users/das7pad/events{/privacy}","received_events_url":"https://api.github.com/users/das7pad/received_events","type":"User","site_admin":false},"repo":{"id":119166172,"name":"aiourlshortener","full_name":"das7pad/aiourlshortener","owner":{"login":"das7pad","id":17931887,"avatar_url":"https://avatars3.githubusercontent.com/u/17931887?v=4","gravatar_id":"","url":"https://api.github.com/users/das7pad","html_url":"https://github.com/das7pad","followers_url":"https://api.github.com/users/das7pad/followers","following_url":"https://api.github.com/users/das7pad/following{/other_user}","gists_url":"https://api.github.com/users/das7pad/gists{/gist_id}","starred_url":"https://api.github.com/users/das7pad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/das7pad/subscriptions","organizations_url":"https://api.github.com/users/das7pad/orgs","repos_url":"https://api.github.com/users/das7pad/repos","events_url":"https://api.github.com/users/das7pad/events{/privacy}","received_events_url":"https://api.github.com/users/das7pad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/das7pad/aiourlshortener","description":"aiourlshortener is a asyncio python3 compatible library for URL shorting using Googl, Bitly API","fork":true,"url":"https://api.github.com/repos/das7pad/aiourlshortener","forks_url":"https://api.github.com/repos/das7pad/aiourlshortener/forks","keys_url":"https://api.github.com/repos/das7pad/aiourlshortener/keys{/key_id}","collaborators_url":"https://api.github.com/repos/das7pad/aiourlshortener/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/das7pad/aiourlshortener/teams","hooks_url":"https://api.github.com/repos/das7pad/aiourlshortener/hooks","issue_events_url":"https://api.github.com/repos/das7pad/aiourlshortener/issues/events{/number}","events_url":"https://api.github.com/repos/das7pad/aiourlshortener/events","assignees_url":"https://api.github.com/repos/das7pad/aiourlshortener/assignees{/user}","branches_url":"https://api.github.com/repos/das7pad/aiourlshortener/branches{/branch}","tags_url":"https://api.github.com/repos/das7pad/aiourlshortener/tags","blobs_url":"https://api.github.com/repos/das7pad/aiourlshortener/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/das7pad/aiourlshortener/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/das7pad/aiourlshortener/git/refs{/sha}","trees_url":"https://api.github.com/repos/das7pad/aiourlshortener/git/trees{/sha}","statuses_url":"https://api.github.com/repos/das7pad/aiourlshortener/statuses/{sha}","languages_url":"https://api.github.com/repos/das7pad/aiourlshortener/languages","stargazers_url":"https://api.github.com/repos/das7pad/aiourlshortener/stargazers","contributors_url":"https://api.github.com/repos/das7pad/aiourlshortener/contributors","subscribers_url":"https://api.github.com/repos/das7pad/aiourlshortener/subscribers","subscription_url":"https://api.github.com/repos/das7pad/aiourlshortener/subscription","commits_url":"https://api.github.com/repos/das7pad/aiourlshortener/commits{/sha}","git_commits_url":"https://api.github.com/repos/das7pad/aiourlshortener/git/commits{/sha}","comments_url":"https://api.github.com/repos/das7pad/aiourlshortener/comments{/number}","issue_comment_url":"https://api.github.com/repos/das7pad/aiourlshortener/issues/comments{/number}","contents_url":"https://api.github.com/repos/das7pad/aiourlshortener/contents/{+path}","compare_url":"https://api.github.com/repos/das7pad/aiourlshortener/compare/{base}...{head}","merges_url":"https://api.github.com/repos/das7pad/aiourlshortener/merges","archive_url":"https://api.github.com/repos/das7pad/aiourlshortener/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/das7pad/aiourlshortener/downloads","issues_url":"https://api.github.com/repos/das7pad/aiourlshortener/issues{/number}","pulls_url":"https://api.github.com/repos/das7pad/aiourlshortener/pulls{/number}","milestones_url":"https://api.github.com/repos/das7pad/aiourlshortener/milestones{/number}","notifications_url":"https://api.github.com/repos/das7pad/aiourlshortener/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/das7pad/aiourlshortener/labels{/name}","releases_url":"https://api.github.com/repos/das7pad/aiourlshortener/releases{/id}","deployments_url":"https://api.github.com/repos/das7pad/aiourlshortener/deployments","created_at":"2018-01-27T13:21:12Z","updated_at":"2018-01-27T13:21:14Z","pushed_at":"2018-02-02T12:47:27Z","git_url":"git://github.com/das7pad/aiourlshortener.git","ssh_url":"git@github.com:das7pad/aiourlshortener.git","clone_url":"https://github.com/das7pad/aiourlshortener.git","svn_url":"https://github.com/das7pad/aiourlshortener","homepage":"","size":28,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"blikenoother:master","ref":"master","sha":"1ea040e7abc583e6d52341490dd7b0e064b7c1da","user":{"login":"blikenoother","id":1961813,"avatar_url":"https://avatars3.githubusercontent.com/u/1961813?v=4","gravatar_id":"","url":"https://api.github.com/users/blikenoother","html_url":"https://github.com/blikenoother","followers_url":"https://api.github.com/users/blikenoother/followers","following_url":"https://api.github.com/users/blikenoother/following{/other_user}","gists_url":"https://api.github.com/users/blikenoother/gists{/gist_id}","starred_url":"https://api.github.com/users/blikenoother/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blikenoother/subscriptions","organizations_url":"https://api.github.com/users/blikenoother/orgs","repos_url":"https://api.github.com/users/blikenoother/repos","events_url":"https://api.github.com/users/blikenoother/events{/privacy}","received_events_url":"https://api.github.com/users/blikenoother/received_events","type":"User","site_admin":false},"repo":{"id":86250079,"name":"aiourlshortener","full_name":"blikenoother/aiourlshortener","owner":{"login":"blikenoother","id":1961813,"avatar_url":"https://avatars3.githubusercontent.com/u/1961813?v=4","gravatar_id":"","url":"https://api.github.com/users/blikenoother","html_url":"https://github.com/blikenoother","followers_url":"https://api.github.com/users/blikenoother/followers","following_url":"https://api.github.com/users/blikenoother/following{/other_user}","gists_url":"https://api.github.com/users/blikenoother/gists{/gist_id}","starred_url":"https://api.github.com/users/blikenoother/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blikenoother/subscriptions","organizations_url":"https://api.github.com/users/blikenoother/orgs","repos_url":"https://api.github.com/users/blikenoother/repos","events_url":"https://api.github.com/users/blikenoother/events{/privacy}","received_events_url":"https://api.github.com/users/blikenoother/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blikenoother/aiourlshortener","description":"aiourlshortener is a asyncio python3 compatible library for URL shorting using Googl, Bitly API","fork":false,"url":"https://api.github.com/repos/blikenoother/aiourlshortener","forks_url":"https://api.github.com/repos/blikenoother/aiourlshortener/forks","keys_url":"https://api.github.com/repos/blikenoother/aiourlshortener/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blikenoother/aiourlshortener/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blikenoother/aiourlshortener/teams","hooks_url":"https://api.github.com/repos/blikenoother/aiourlshortener/hooks","issue_events_url":"https://api.github.com/repos/blikenoother/aiourlshortener/issues/events{/number}","events_url":"https://api.github.com/repos/blikenoother/aiourlshortener/events","assignees_url":"https://api.github.com/repos/blikenoother/aiourlshortener/assignees{/user}","branches_url":"https://api.github.com/repos/blikenoother/aiourlshortener/branches{/branch}","tags_url":"https://api.github.com/repos/blikenoother/aiourlshortener/tags","blobs_url":"https://api.github.com/repos/blikenoother/aiourlshortener/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blikenoother/aiourlshortener/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blikenoother/aiourlshortener/git/refs{/sha}","trees_url":"https://api.github.com/repos/blikenoother/aiourlshortener/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blikenoother/aiourlshortener/statuses/{sha}","languages_url":"https://api.github.com/repos/blikenoother/aiourlshortener/languages","stargazers_url":"https://api.github.com/repos/blikenoother/aiourlshortener/stargazers","contributors_url":"https://api.github.com/repos/blikenoother/aiourlshortener/contributors","subscribers_url":"https://api.github.com/repos/blikenoother/aiourlshortener/subscribers","subscription_url":"https://api.github.com/repos/blikenoother/aiourlshortener/subscription","commits_url":"https://api.github.com/repos/blikenoother/aiourlshortener/commits{/sha}","git_commits_url":"https://api.github.com/repos/blikenoother/aiourlshortener/git/commits{/sha}","comments_url":"https://api.github.com/repos/blikenoother/aiourlshortener/comments{/number}","issue_comment_url":"https://api.github.com/repos/blikenoother/aiourlshortener/issues/comments{/number}","contents_url":"https://api.github.com/repos/blikenoother/aiourlshortener/contents/{+path}","compare_url":"https://api.github.com/repos/blikenoother/aiourlshortener/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blikenoother/aiourlshortener/merges","archive_url":"https://api.github.com/repos/blikenoother/aiourlshortener/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blikenoother/aiourlshortener/downloads","issues_url":"https://api.github.com/repos/blikenoother/aiourlshortener/issues{/number}","pulls_url":"https://api.github.com/repos/blikenoother/aiourlshortener/pulls{/number}","milestones_url":"https://api.github.com/repos/blikenoother/aiourlshortener/milestones{/number}","notifications_url":"https://api.github.com/repos/blikenoother/aiourlshortener/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blikenoother/aiourlshortener/labels{/name}","releases_url":"https://api.github.com/repos/blikenoother/aiourlshortener/releases{/id}","deployments_url":"https://api.github.com/repos/blikenoother/aiourlshortener/deployments","created_at":"2017-03-26T17:11:32Z","updated_at":"2018-02-02T07:08:59Z","pushed_at":"2018-02-04T07:00:03Z","git_url":"git://github.com/blikenoother/aiourlshortener.git","ssh_url":"git@github.com:blikenoother/aiourlshortener.git","clone_url":"https://github.com/blikenoother/aiourlshortener.git","svn_url":"https://github.com/blikenoother/aiourlshortener","homepage":"","size":24,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/blikenoother/aiourlshortener/pulls/7"},"html":{"href":"https://github.com/blikenoother/aiourlshortener/pull/7"},"issue":{"href":"https://api.github.com/repos/blikenoother/aiourlshortener/issues/7"},"comments":{"href":"https://api.github.com/repos/blikenoother/aiourlshortener/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/blikenoother/aiourlshortener/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/blikenoother/aiourlshortener/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blikenoother/aiourlshortener/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/blikenoother/aiourlshortener/statuses/234a473356a952ad36cc57bd0c1c0d5e0271e9e2"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"blikenoother","id":1961813,"avatar_url":"https://avatars3.githubusercontent.com/u/1961813?v=4","gravatar_id":"","url":"https://api.github.com/users/blikenoother","html_url":"https://github.com/blikenoother","followers_url":"https://api.github.com/users/blikenoother/followers","following_url":"https://api.github.com/users/blikenoother/following{/other_user}","gists_url":"https://api.github.com/users/blikenoother/gists{/gist_id}","starred_url":"https://api.github.com/users/blikenoother/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blikenoother/subscriptions","organizations_url":"https://api.github.com/users/blikenoother/orgs","repos_url":"https://api.github.com/users/blikenoother/repos","events_url":"https://api.github.com/users/blikenoother/events{/privacy}","received_events_url":"https://api.github.com/users/blikenoother/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":14,"deletions":20,"changed_files":4}}
{"actor":{"display_login":"blikenoother"}}