{"action":"created","comment":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/165971277","pull_request_review_id":93988227,"id":165971277,"diff_hunk":"@@ -314,7 +314,11 @@ public PathAddress append(String key) {\n      * @param create {@code true} to create the last part of the node if it does not exist\n      * @return the submodel\n      * @throws NoSuchElementException if the model contains no such element\n+     *\n+     * @deprecated manipulating a deep DMR node tree via PathAddress is no longer how the management layer works","path":"controller/src/main/java/org/jboss/as/controller/PathAddress.java","position":5,"original_position":5,"commit_id":"1171cd3b2f876bd03e865647abff3e0f2b1432cd","original_commit_id":"1171cd3b2f876bd03e865647abff3e0f2b1432cd","user":{"login":"jmesnil","id":6193,"avatar_url":"https://avatars2.githubusercontent.com/u/6193?v=4","gravatar_id":"","url":"https://api.github.com/users/jmesnil","html_url":"https://github.com/jmesnil","followers_url":"https://api.github.com/users/jmesnil/followers","following_url":"https://api.github.com/users/jmesnil/following{/other_user}","gists_url":"https://api.github.com/users/jmesnil/gists{/gist_id}","starred_url":"https://api.github.com/users/jmesnil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmesnil/subscriptions","organizations_url":"https://api.github.com/users/jmesnil/orgs","repos_url":"https://api.github.com/users/jmesnil/repos","events_url":"https://api.github.com/users/jmesnil/events{/privacy}","received_events_url":"https://api.github.com/users/jmesnil/received_events","type":"User","site_admin":false},"body":"Should the deprecated message mention the correct alternative?","created_at":"2018-02-05T13:29:38Z","updated_at":"2018-02-05T13:29:42Z","html_url":"https://github.com/wildfly/wildfly-core/pull/3013#discussion_r165971277","pull_request_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3013","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments/165971277"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/3013#discussion_r165971277"},"pull_request":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3013"}}},"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3013","id":160652759,"html_url":"https://github.com/wildfly/wildfly-core/pull/3013","diff_url":"https://github.com/wildfly/wildfly-core/pull/3013.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/3013.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/3013","number":3013,"state":"open","locked":false,"title":"[WFCORE-3483] Deprecate PathAddress.navigate and remove, replace controller catches of NoSuchElementException with Resource.NoSuchResourceException","user":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars1.githubusercontent.com/u/299242?v=4","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/WFCORE-3483\r\n\r\nMinor thing to help make it easier to move to a cleaner exception model in future management code.","created_at":"2018-01-01T16:13:03Z","updated_at":"2018-02-05T13:29:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b72c02ee29b967aa45acc9f166eec2e91a3206c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3013/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3013/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/3013/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/1171cd3b2f876bd03e865647abff3e0f2b1432cd","head":{"label":"bstansberry:WFCORE-3483","ref":"WFCORE-3483","sha":"1171cd3b2f876bd03e865647abff3e0f2b1432cd","user":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars1.githubusercontent.com/u/299242?v=4","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"repo":{"id":21433119,"name":"wildfly-core","full_name":"bstansberry/wildfly-core","owner":{"login":"bstansberry","id":299242,"avatar_url":"https://avatars1.githubusercontent.com/u/299242?v=4","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bstansberry/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":true,"url":"https://api.github.com/repos/bstansberry/wildfly-core","forks_url":"https://api.github.com/repos/bstansberry/wildfly-core/forks","keys_url":"https://api.github.com/repos/bstansberry/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bstansberry/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bstansberry/wildfly-core/teams","hooks_url":"https://api.github.com/repos/bstansberry/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/bstansberry/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/bstansberry/wildfly-core/events","assignees_url":"https://api.github.com/repos/bstansberry/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/bstansberry/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/bstansberry/wildfly-core/tags","blobs_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bstansberry/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/bstansberry/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/bstansberry/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/bstansberry/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/bstansberry/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/bstansberry/wildfly-core/subscription","commits_url":"https://api.github.com/repos/bstansberry/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/bstansberry/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/bstansberry/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/bstansberry/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/bstansberry/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bstansberry/wildfly-core/merges","archive_url":"https://api.github.com/repos/bstansberry/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bstansberry/wildfly-core/downloads","issues_url":"https://api.github.com/repos/bstansberry/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/bstansberry/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/bstansberry/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/bstansberry/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bstansberry/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/bstansberry/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/bstansberry/wildfly-core/deployments","created_at":"2014-07-02T17:20:55Z","updated_at":"2016-01-19T14:32:28Z","pushed_at":"2018-02-02T17:35:32Z","git_url":"git://github.com/bstansberry/wildfly-core.git","ssh_url":"git@github.com:bstansberry/wildfly-core.git","clone_url":"https://github.com/bstansberry/wildfly-core.git","svn_url":"https://github.com/bstansberry/wildfly-core","homepage":null,"size":65965,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"717ed06c5a5460a03739ae2af1381ae7cdf79bbd","user":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":21394954,"name":"wildfly-core","full_name":"wildfly/wildfly-core","owner":{"login":"wildfly","id":3066274,"avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-core","forks_url":"https://api.github.com/repos/wildfly/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly/wildfly-core/deployments","created_at":"2014-07-01T16:33:34Z","updated_at":"2018-02-01T17:00:26Z","pushed_at":"2018-02-05T10:41:11Z","git_url":"git://github.com/wildfly/wildfly-core.git","ssh_url":"git@github.com:wildfly/wildfly-core.git","clone_url":"https://github.com/wildfly/wildfly-core.git","svn_url":"https://github.com/wildfly/wildfly-core","homepage":null,"size":66925,"stargazers_count":86,"watchers_count":86,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":299,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":299,"open_issues":54,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3013"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/3013"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/3013"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/3013/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3013/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3013/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-core/statuses/1171cd3b2f876bd03e865647abff3e0f2b1432cd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jmesnil"}}