{"action":"created","comment":{"url":"https://api.github.com/repos/SonarSource/SonarJS/pulls/comments/166632221","pull_request_review_id":94725573,"id":166632221,"diff_hunk":"@@ -113,10 +113,15 @@ private void checkParameterClause(ArrowFunctionTree tree) {\n     }\n \n     if (!parameterParens && hasParameterParens) {\n-      SeparatedList<BindingElementTree> parameters = ((ParameterListTree) tree.parameterClause()).parameters();\n-      if (parameters.size() == 1 && parameters.get(0).is(Kind.BINDING_IDENTIFIER)) {\n+      ParameterListTree parameterListTree = (ParameterListTree) tree.parameterClause();\n+      SeparatedList<BindingElementTree> parameters = parameterListTree.parameters();\n+      if (parameters.size() == 1 && parameters.get(0).is(Kind.BINDING_IDENTIFIER) && !hasCommentInside(parameterListTree)) {\n         addIssue(tree.parameterClause(), MESSAGE_REMOVE_PARAMETER);\n       }\n     }\n   }\n+\n+  private boolean hasCommentInside(ParameterListTree parameterListTree) {","path":"javascript-checks/src/main/java/org/sonar/javascript/checks/ArrowFunctionConventionCheck.java","position":14,"original_position":14,"commit_id":"af62adb7d41e144621b7da64ce9a956cf40d452d","original_commit_id":"af62adb7d41e144621b7da64ce9a956cf40d452d","user":{"login":"SonarTech","id":1842438,"avatar_url":"https://avatars2.githubusercontent.com/u/1842438?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarTech","html_url":"https://github.com/SonarTech","followers_url":"https://api.github.com/users/SonarTech/followers","following_url":"https://api.github.com/users/SonarTech/following{/other_user}","gists_url":"https://api.github.com/users/SonarTech/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarTech/subscriptions","organizations_url":"https://api.github.com/users/SonarTech/orgs","repos_url":"https://api.github.com/users/SonarTech/repos","events_url":"https://api.github.com/users/SonarTech/events{/privacy}","received_events_url":"https://api.github.com/users/SonarTech/received_events","type":"User","site_admin":false},"body":"![Code Smell](https://sonarsource.github.io/sonar-github/code_smell.png 'Code Smell') Code Smell: Make \"hasCommentInside\" a \"static\" method. ([squid:S2325](https://next.sonarqube.com/sonarqube/coding_rules#rule_key=squid%3AS2325))\n\n[See it in SonarQube](https://next.sonarqube.com/sonarqube/project/issues?id=org.sonarsource.javascript%3Ajavascript&branch=issue-906&issues=AWFwqa7Kh1v1MSKKr6_K&open=AWFwqa7Kh1v1MSKKr6_K)\n\n[ISSUE_KEY]: AWFwqa7Kh1v1MSKKr6_K","created_at":"2018-02-07T14:27:07Z","updated_at":"2018-02-07T14:27:07Z","html_url":"https://github.com/SonarSource/SonarJS/pull/926#discussion_r166632221","pull_request_url":"https://api.github.com/repos/SonarSource/SonarJS/pulls/926","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/SonarSource/SonarJS/pulls/comments/166632221"},"html":{"href":"https://github.com/SonarSource/SonarJS/pull/926#discussion_r166632221"},"pull_request":{"href":"https://api.github.com/repos/SonarSource/SonarJS/pulls/926"}}},"pull_request":{"url":"https://api.github.com/repos/SonarSource/SonarJS/pulls/926","id":167705328,"html_url":"https://github.com/SonarSource/SonarJS/pull/926","diff_url":"https://github.com/SonarSource/SonarJS/pull/926.diff","patch_url":"https://github.com/SonarSource/SonarJS/pull/926.patch","issue_url":"https://api.github.com/repos/SonarSource/SonarJS/issues/926","number":926,"state":"open","locked":false,"title":"Improve S3524: ignore when parameter has comment","user":{"login":"vilchik-elena","id":10108186,"avatar_url":"https://avatars1.githubusercontent.com/u/10108186?v=4","gravatar_id":"","url":"https://api.github.com/users/vilchik-elena","html_url":"https://github.com/vilchik-elena","followers_url":"https://api.github.com/users/vilchik-elena/followers","following_url":"https://api.github.com/users/vilchik-elena/following{/other_user}","gists_url":"https://api.github.com/users/vilchik-elena/gists{/gist_id}","starred_url":"https://api.github.com/users/vilchik-elena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilchik-elena/subscriptions","organizations_url":"https://api.github.com/users/vilchik-elena/orgs","repos_url":"https://api.github.com/users/vilchik-elena/repos","events_url":"https://api.github.com/users/vilchik-elena/events{/privacy}","received_events_url":"https://api.github.com/users/vilchik-elena/received_events","type":"User","site_admin":false},"body":"Fixes #906 ","created_at":"2018-02-07T14:20:49Z","updated_at":"2018-02-07T14:27:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b23d23da3bb9178ac1cc1e5f3d3550d07be446c","assignee":{"login":"vilchik-elena","id":10108186,"avatar_url":"https://avatars1.githubusercontent.com/u/10108186?v=4","gravatar_id":"","url":"https://api.github.com/users/vilchik-elena","html_url":"https://github.com/vilchik-elena","followers_url":"https://api.github.com/users/vilchik-elena/followers","following_url":"https://api.github.com/users/vilchik-elena/following{/other_user}","gists_url":"https://api.github.com/users/vilchik-elena/gists{/gist_id}","starred_url":"https://api.github.com/users/vilchik-elena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilchik-elena/subscriptions","organizations_url":"https://api.github.com/users/vilchik-elena/orgs","repos_url":"https://api.github.com/users/vilchik-elena/repos","events_url":"https://api.github.com/users/vilchik-elena/events{/privacy}","received_events_url":"https://api.github.com/users/vilchik-elena/received_events","type":"User","site_admin":false},"assignees":[{"login":"vilchik-elena","id":10108186,"avatar_url":"https://avatars1.githubusercontent.com/u/10108186?v=4","gravatar_id":"","url":"https://api.github.com/users/vilchik-elena","html_url":"https://github.com/vilchik-elena","followers_url":"https://api.github.com/users/vilchik-elena/followers","following_url":"https://api.github.com/users/vilchik-elena/following{/other_user}","gists_url":"https://api.github.com/users/vilchik-elena/gists{/gist_id}","starred_url":"https://api.github.com/users/vilchik-elena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vilchik-elena/subscriptions","organizations_url":"https://api.github.com/users/vilchik-elena/orgs","repos_url":"https://api.github.com/users/vilchik-elena/repos","events_url":"https://api.github.com/users/vilchik-elena/events{/privacy}","received_events_url":"https://api.github.com/users/vilchik-elena/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"saberduck","id":680437,"avatar_url":"https://avatars1.githubusercontent.com/u/680437?v=4","gravatar_id":"","url":"https://api.github.com/users/saberduck","html_url":"https://github.com/saberduck","followers_url":"https://api.github.com/users/saberduck/followers","following_url":"https://api.github.com/users/saberduck/following{/other_user}","gists_url":"https://api.github.com/users/saberduck/gists{/gist_id}","starred_url":"https://api.github.com/users/saberduck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saberduck/subscriptions","organizations_url":"https://api.github.com/users/saberduck/orgs","repos_url":"https://api.github.com/users/saberduck/repos","events_url":"https://api.github.com/users/saberduck/events{/privacy}","received_events_url":"https://api.github.com/users/saberduck/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/SonarSource/SonarJS/pulls/926/commits","review_comments_url":"https://api.github.com/repos/SonarSource/SonarJS/pulls/926/comments","review_comment_url":"https://api.github.com/repos/SonarSource/SonarJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarSource/SonarJS/issues/926/comments","statuses_url":"https://api.github.com/repos/SonarSource/SonarJS/statuses/af62adb7d41e144621b7da64ce9a956cf40d452d","head":{"label":"SonarSource:issue-906","ref":"issue-906","sha":"af62adb7d41e144621b7da64ce9a956cf40d452d","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":4335519,"name":"SonarJS","full_name":"SonarSource/SonarJS","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/SonarJS","description":"SonarJS: JavaScript Analyzer for SonarQube","fork":false,"url":"https://api.github.com/repos/SonarSource/SonarJS","forks_url":"https://api.github.com/repos/SonarSource/SonarJS/forks","keys_url":"https://api.github.com/repos/SonarSource/SonarJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/SonarJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/SonarJS/teams","hooks_url":"https://api.github.com/repos/SonarSource/SonarJS/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/SonarJS/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/SonarJS/events","assignees_url":"https://api.github.com/repos/SonarSource/SonarJS/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/SonarJS/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/SonarJS/tags","blobs_url":"https://api.github.com/repos/SonarSource/SonarJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/SonarJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/SonarJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/SonarJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/SonarJS/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/SonarJS/languages","stargazers_url":"https://api.github.com/repos/SonarSource/SonarJS/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/SonarJS/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/SonarJS/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/SonarJS/subscription","commits_url":"https://api.github.com/repos/SonarSource/SonarJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/SonarJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/SonarJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/SonarJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/SonarJS/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/SonarJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/SonarJS/merges","archive_url":"https://api.github.com/repos/SonarSource/SonarJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/SonarJS/downloads","issues_url":"https://api.github.com/repos/SonarSource/SonarJS/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/SonarJS/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/SonarJS/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/SonarJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/SonarJS/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/SonarJS/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/SonarJS/deployments","created_at":"2012-05-15T12:35:38Z","updated_at":"2018-02-06T14:05:00Z","pushed_at":"2018-02-07T14:22:16Z","git_url":"git://github.com/SonarSource/SonarJS.git","ssh_url":"git@github.com:SonarSource/SonarJS.git","clone_url":"https://github.com/SonarSource/SonarJS.git","svn_url":"https://github.com/SonarSource/SonarJS","homepage":"https://redirect.sonarsource.com/plugins/javascript.html","size":15939,"stargazers_count":189,"watchers_count":189,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":94,"open_issues":104,"watchers":189,"default_branch":"master"}},"base":{"label":"SonarSource:master","ref":"master","sha":"9997ce3ae0264d21e3a816bb6b4a6912ab5e8b1c","user":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"repo":{"id":4335519,"name":"SonarJS","full_name":"SonarSource/SonarJS","owner":{"login":"SonarSource","id":545988,"avatar_url":"https://avatars0.githubusercontent.com/u/545988?v=4","gravatar_id":"","url":"https://api.github.com/users/SonarSource","html_url":"https://github.com/SonarSource","followers_url":"https://api.github.com/users/SonarSource/followers","following_url":"https://api.github.com/users/SonarSource/following{/other_user}","gists_url":"https://api.github.com/users/SonarSource/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarSource/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarSource/subscriptions","organizations_url":"https://api.github.com/users/SonarSource/orgs","repos_url":"https://api.github.com/users/SonarSource/repos","events_url":"https://api.github.com/users/SonarSource/events{/privacy}","received_events_url":"https://api.github.com/users/SonarSource/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarSource/SonarJS","description":"SonarJS: JavaScript Analyzer for SonarQube","fork":false,"url":"https://api.github.com/repos/SonarSource/SonarJS","forks_url":"https://api.github.com/repos/SonarSource/SonarJS/forks","keys_url":"https://api.github.com/repos/SonarSource/SonarJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarSource/SonarJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarSource/SonarJS/teams","hooks_url":"https://api.github.com/repos/SonarSource/SonarJS/hooks","issue_events_url":"https://api.github.com/repos/SonarSource/SonarJS/issues/events{/number}","events_url":"https://api.github.com/repos/SonarSource/SonarJS/events","assignees_url":"https://api.github.com/repos/SonarSource/SonarJS/assignees{/user}","branches_url":"https://api.github.com/repos/SonarSource/SonarJS/branches{/branch}","tags_url":"https://api.github.com/repos/SonarSource/SonarJS/tags","blobs_url":"https://api.github.com/repos/SonarSource/SonarJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarSource/SonarJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarSource/SonarJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarSource/SonarJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarSource/SonarJS/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarSource/SonarJS/languages","stargazers_url":"https://api.github.com/repos/SonarSource/SonarJS/stargazers","contributors_url":"https://api.github.com/repos/SonarSource/SonarJS/contributors","subscribers_url":"https://api.github.com/repos/SonarSource/SonarJS/subscribers","subscription_url":"https://api.github.com/repos/SonarSource/SonarJS/subscription","commits_url":"https://api.github.com/repos/SonarSource/SonarJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarSource/SonarJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarSource/SonarJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarSource/SonarJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarSource/SonarJS/contents/{+path}","compare_url":"https://api.github.com/repos/SonarSource/SonarJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarSource/SonarJS/merges","archive_url":"https://api.github.com/repos/SonarSource/SonarJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarSource/SonarJS/downloads","issues_url":"https://api.github.com/repos/SonarSource/SonarJS/issues{/number}","pulls_url":"https://api.github.com/repos/SonarSource/SonarJS/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarSource/SonarJS/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarSource/SonarJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarSource/SonarJS/labels{/name}","releases_url":"https://api.github.com/repos/SonarSource/SonarJS/releases{/id}","deployments_url":"https://api.github.com/repos/SonarSource/SonarJS/deployments","created_at":"2012-05-15T12:35:38Z","updated_at":"2018-02-06T14:05:00Z","pushed_at":"2018-02-07T14:22:16Z","git_url":"git://github.com/SonarSource/SonarJS.git","ssh_url":"git@github.com:SonarSource/SonarJS.git","clone_url":"https://github.com/SonarSource/SonarJS.git","svn_url":"https://github.com/SonarSource/SonarJS","homepage":"https://redirect.sonarsource.com/plugins/javascript.html","size":15939,"stargazers_count":189,"watchers_count":189,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":94,"open_issues":104,"watchers":189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarSource/SonarJS/pulls/926"},"html":{"href":"https://github.com/SonarSource/SonarJS/pull/926"},"issue":{"href":"https://api.github.com/repos/SonarSource/SonarJS/issues/926"},"comments":{"href":"https://api.github.com/repos/SonarSource/SonarJS/issues/926/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarSource/SonarJS/pulls/926/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarSource/SonarJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarSource/SonarJS/pulls/926/commits"},"statuses":{"href":"https://api.github.com/repos/SonarSource/SonarJS/statuses/af62adb7d41e144621b7da64ce9a956cf40d452d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SonarTech"}}