{"action":"created","comment":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/211124434","pull_request_review_id":147481329,"id":211124434,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTEyNDQzNA==","diff_hunk":"@@ -0,0 +1,86 @@\n+// Distributed under the MIT License.\n+// See LICENSE.txt for details.\n+\n+#pragma once\n+\n+#include <cstddef>\n+\n+#include \"DataStructures/DataBox/Prefixes.hpp\"  // IWYU pragma: keep\n+#include \"DataStructures/Tensor/Tensor.hpp\"     // IWYU pragma: keep\n+#include \"Elliptic/Systems/Poisson/Tags.hpp\"    // IWYU pragma: keep\n+#include \"Options/Options.hpp\"\n+#include \"Utilities/TMPL.hpp\"\n+#include \"Utilities/TaggedTuple.hpp\"\n+\n+/// \\cond\n+class DataVector;\n+namespace PUP {\n+class er;\n+}  // namespace PUP\n+/// \\endcond\n+\n+namespace Poisson {\n+namespace Solutions {","path":"src/PointwiseFunctions/AnalyticSolutions/Poisson/Moustache.hpp","position":23,"original_position":23,"commit_id":"b35eb063d84d53b3cfaba3ba1846055524394b3a","original_commit_id":"b35eb063d84d53b3cfaba3ba1846055524394b3a","user":{"login":"nilsdeppe","id":13531030,"node_id":"MDQ6VXNlcjEzNTMxMDMw","avatar_url":"https://avatars3.githubusercontent.com/u/13531030?v=4","gravatar_id":"","url":"https://api.github.com/users/nilsdeppe","html_url":"https://github.com/nilsdeppe","followers_url":"https://api.github.com/users/nilsdeppe/followers","following_url":"https://api.github.com/users/nilsdeppe/following{/other_user}","gists_url":"https://api.github.com/users/nilsdeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/nilsdeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilsdeppe/subscriptions","organizations_url":"https://api.github.com/users/nilsdeppe/orgs","repos_url":"https://api.github.com/users/nilsdeppe/repos","events_url":"https://api.github.com/users/nilsdeppe/events{/privacy}","received_events_url":"https://api.github.com/users/nilsdeppe/received_events","type":"User","site_admin":false},"body":"I can't find this namespace in Doxygen. Do you need to document it?","created_at":"2018-08-20T01:35:10Z","updated_at":"2018-08-20T01:50:04Z","html_url":"https://github.com/sxs-collaboration/spectre/pull/843#discussion_r211124434","pull_request_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/843","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/211124434"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/843#discussion_r211124434"},"pull_request":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/843"}}},"pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/843","id":204553797,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NTUzNzk3","html_url":"https://github.com/sxs-collaboration/spectre/pull/843","diff_url":"https://github.com/sxs-collaboration/spectre/pull/843.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/843.patch","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/843","number":843,"state":"open","locked":false,"title":"Add Poisson solution with discontinuous first derivative","user":{"login":"nilsleiffischer","id":746230,"node_id":"MDQ6VXNlcjc0NjIzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/746230?v=4","gravatar_id":"","url":"https://api.github.com/users/nilsleiffischer","html_url":"https://github.com/nilsleiffischer","followers_url":"https://api.github.com/users/nilsleiffischer/followers","following_url":"https://api.github.com/users/nilsleiffischer/following{/other_user}","gists_url":"https://api.github.com/users/nilsleiffischer/gists{/gist_id}","starred_url":"https://api.github.com/users/nilsleiffischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilsleiffischer/subscriptions","organizations_url":"https://api.github.com/users/nilsleiffischer/orgs","repos_url":"https://api.github.com/users/nilsleiffischer/repos","events_url":"https://api.github.com/users/nilsleiffischer/events{/privacy}","received_events_url":"https://api.github.com/users/nilsleiffischer/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n\r\nThis solution to the Poisson equation has a discontinuous first derivative at x=1/2=y which makes it useful to test convergence and (eventually) AMR for the elliptic solver:\r\n\r\nThe two-dimensional solution is:\r\n\r\n```math\r\nu(x) = x (1 - x) y (1 - y) ((x - 1/2)^2 + (y - 1/2)^2)^3/2\r\n```\r\n\r\nFor reasons that should be clear from looking at the shape of the source (see 1D plot below) I named it `Poisson::Solutions::Moustache`. Renaming suggestions welcome :)\r\n\r\n![bildschirmfoto 2018-07-28 um 00 26 01](https://user-images.githubusercontent.com/746230/43348906-dec708ce-91fc-11e8-963c-1ddb1a908aa4.png)\r\n\r\n### Types of changes:\r\n\r\n- [x] New feature\r\n\r\n### Component:\r\n\r\n- [x] Code\r\n\r\n### Code review checklist\r\n\r\n- [x] The PR passes all checks, including unit tests, `clang-tidy` and `IWYU`. For\r\n  instructions on how to perform the CI checks locally refer to the [Dev guide\r\n  on the Travis CI](https://spectre-code.org/travis_guide.html).\r\n- [x] The code is documented and the documentation renders correctly. Run `make doc`\r\n  to generate the documentation locally into `BUILD_DIR/docs/html`. Then open\r\n  `index.html`.\r\n- [x] The code follows the stylistic and code quality guidelines listed in the\r\n  [code review guide](https://spectre-code.org/code_review_guide.html).","created_at":"2018-07-27T22:30:45Z","updated_at":"2018-08-20T01:50:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"330f20832a8428a6e7a04570d066b2d332941349","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/843/commits","review_comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/843/comments","review_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/843/comments","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/b35eb063d84d53b3cfaba3ba1846055524394b3a","head":{"label":"nilsleiffischer:poisson_moustache","ref":"poisson_moustache","sha":"b35eb063d84d53b3cfaba3ba1846055524394b3a","user":{"login":"nilsleiffischer","id":746230,"node_id":"MDQ6VXNlcjc0NjIzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/746230?v=4","gravatar_id":"","url":"https://api.github.com/users/nilsleiffischer","html_url":"https://github.com/nilsleiffischer","followers_url":"https://api.github.com/users/nilsleiffischer/followers","following_url":"https://api.github.com/users/nilsleiffischer/following{/other_user}","gists_url":"https://api.github.com/users/nilsleiffischer/gists{/gist_id}","starred_url":"https://api.github.com/users/nilsleiffischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilsleiffischer/subscriptions","organizations_url":"https://api.github.com/users/nilsleiffischer/orgs","repos_url":"https://api.github.com/users/nilsleiffischer/repos","events_url":"https://api.github.com/users/nilsleiffischer/events{/privacy}","received_events_url":"https://api.github.com/users/nilsleiffischer/received_events","type":"User","site_admin":false},"repo":{"id":119436274,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk0MzYyNzQ=","name":"spectre","full_name":"nilsleiffischer/spectre","owner":{"login":"nilsleiffischer","id":746230,"node_id":"MDQ6VXNlcjc0NjIzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/746230?v=4","gravatar_id":"","url":"https://api.github.com/users/nilsleiffischer","html_url":"https://github.com/nilsleiffischer","followers_url":"https://api.github.com/users/nilsleiffischer/followers","following_url":"https://api.github.com/users/nilsleiffischer/following{/other_user}","gists_url":"https://api.github.com/users/nilsleiffischer/gists{/gist_id}","starred_url":"https://api.github.com/users/nilsleiffischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilsleiffischer/subscriptions","organizations_url":"https://api.github.com/users/nilsleiffischer/orgs","repos_url":"https://api.github.com/users/nilsleiffischer/repos","events_url":"https://api.github.com/users/nilsleiffischer/events{/privacy}","received_events_url":"https://api.github.com/users/nilsleiffischer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nilsleiffischer/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":true,"url":"https://api.github.com/repos/nilsleiffischer/spectre","forks_url":"https://api.github.com/repos/nilsleiffischer/spectre/forks","keys_url":"https://api.github.com/repos/nilsleiffischer/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nilsleiffischer/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nilsleiffischer/spectre/teams","hooks_url":"https://api.github.com/repos/nilsleiffischer/spectre/hooks","issue_events_url":"https://api.github.com/repos/nilsleiffischer/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/nilsleiffischer/spectre/events","assignees_url":"https://api.github.com/repos/nilsleiffischer/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/nilsleiffischer/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/nilsleiffischer/spectre/tags","blobs_url":"https://api.github.com/repos/nilsleiffischer/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nilsleiffischer/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nilsleiffischer/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/nilsleiffischer/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nilsleiffischer/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/nilsleiffischer/spectre/languages","stargazers_url":"https://api.github.com/repos/nilsleiffischer/spectre/stargazers","contributors_url":"https://api.github.com/repos/nilsleiffischer/spectre/contributors","subscribers_url":"https://api.github.com/repos/nilsleiffischer/spectre/subscribers","subscription_url":"https://api.github.com/repos/nilsleiffischer/spectre/subscription","commits_url":"https://api.github.com/repos/nilsleiffischer/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/nilsleiffischer/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/nilsleiffischer/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/nilsleiffischer/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/nilsleiffischer/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/nilsleiffischer/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nilsleiffischer/spectre/merges","archive_url":"https://api.github.com/repos/nilsleiffischer/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nilsleiffischer/spectre/downloads","issues_url":"https://api.github.com/repos/nilsleiffischer/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/nilsleiffischer/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/nilsleiffischer/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/nilsleiffischer/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nilsleiffischer/spectre/labels{/name}","releases_url":"https://api.github.com/repos/nilsleiffischer/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/nilsleiffischer/spectre/deployments","created_at":"2018-01-29T20:19:38Z","updated_at":"2018-08-17T08:21:41Z","pushed_at":"2018-08-17T11:57:09Z","git_url":"git://github.com/nilsleiffischer/spectre.git","ssh_url":"git@github.com:nilsleiffischer/spectre.git","clone_url":"https://github.com/nilsleiffischer/spectre.git","svn_url":"https://github.com/nilsleiffischer/spectre","homepage":"","size":10229,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sxs-collaboration:develop","ref":"develop","sha":"bb9a3472a52763c9381dec83524c0e3bb576e6e0","user":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":87570510,"node_id":"MDEwOlJlcG9zaXRvcnk4NzU3MDUxMA==","name":"spectre","full_name":"sxs-collaboration/spectre","owner":{"login":"sxs-collaboration","id":26882595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2ODgyNTk1","avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sxs-collaboration/spectre","description":"SpECTRE is a code for multi-scale, multi-physics problems in astrophysics and gravitational physics.","fork":false,"url":"https://api.github.com/repos/sxs-collaboration/spectre","forks_url":"https://api.github.com/repos/sxs-collaboration/spectre/forks","keys_url":"https://api.github.com/repos/sxs-collaboration/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sxs-collaboration/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sxs-collaboration/spectre/teams","hooks_url":"https://api.github.com/repos/sxs-collaboration/spectre/hooks","issue_events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/events","assignees_url":"https://api.github.com/repos/sxs-collaboration/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/sxs-collaboration/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/tags","blobs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/sxs-collaboration/spectre/languages","stargazers_url":"https://api.github.com/repos/sxs-collaboration/spectre/stargazers","contributors_url":"https://api.github.com/repos/sxs-collaboration/spectre/contributors","subscribers_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscribers","subscription_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscription","commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/sxs-collaboration/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/sxs-collaboration/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sxs-collaboration/spectre/merges","archive_url":"https://api.github.com/repos/sxs-collaboration/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sxs-collaboration/spectre/downloads","issues_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/sxs-collaboration/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/sxs-collaboration/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/labels{/name}","releases_url":"https://api.github.com/repos/sxs-collaboration/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/sxs-collaboration/spectre/deployments","created_at":"2017-04-07T17:28:20Z","updated_at":"2018-08-17T05:10:53Z","pushed_at":"2018-08-19T23:50:29Z","git_url":"git://github.com/sxs-collaboration/spectre.git","ssh_url":"git@github.com:sxs-collaboration/spectre.git","clone_url":"https://github.com/sxs-collaboration/spectre.git","svn_url":"https://github.com/sxs-collaboration/spectre","homepage":"","size":12792,"stargazers_count":27,"watchers_count":27,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":110,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":26,"open_issues":110,"watchers":27,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/843"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/843"},"issue":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/843"},"comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/843/comments"},"review_comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/843/comments"},"review_comment":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/843/commits"},"statuses":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/b35eb063d84d53b3cfaba3ba1846055524394b3a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nilsdeppe"}}