{"action":"created","issue":{"url":"https://api.github.com/repos/ratt-ru/CubiCal/issues/240","repository_url":"https://api.github.com/repos/ratt-ru/CubiCal","labels_url":"https://api.github.com/repos/ratt-ru/CubiCal/issues/240/labels{/name}","comments_url":"https://api.github.com/repos/ratt-ru/CubiCal/issues/240/comments","events_url":"https://api.github.com/repos/ratt-ru/CubiCal/issues/240/events","html_url":"https://github.com/ratt-ru/CubiCal/pull/240","id":382258396,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMDA3MjAz","number":240,"title":"Update SourceProvider for montblanc ddfacet branch","user":{"login":"sjperkins","id":3530212,"node_id":"MDQ6VXNlcjM1MzAyMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/3530212?v=4","gravatar_id":"","url":"https://api.github.com/users/sjperkins","html_url":"https://github.com/sjperkins","followers_url":"https://api.github.com/users/sjperkins/followers","following_url":"https://api.github.com/users/sjperkins/following{/other_user}","gists_url":"https://api.github.com/users/sjperkins/gists{/gist_id}","starred_url":"https://api.github.com/users/sjperkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjperkins/subscriptions","organizations_url":"https://api.github.com/users/sjperkins/orgs","repos_url":"https://api.github.com/users/sjperkins/repos","events_url":"https://api.github.com/users/sjperkins/events{/privacy}","received_events_url":"https://api.github.com/users/sjperkins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-11-19T15:11:15Z","updated_at":"2018-11-21T21:37:28Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ratt-ru/CubiCal/pulls/240","html_url":"https://github.com/ratt-ru/CubiCal/pull/240","diff_url":"https://github.com/ratt-ru/CubiCal/pull/240.diff","patch_url":"https://github.com/ratt-ru/CubiCal/pull/240.patch"},"body":"@o-smirnov @JSKenyon This updates the TiggerSourceProvider to work with Montblanc's ddfacet branch, where\r\n\r\n1. the spectral index parameters are removed.\r\n2. per-channel stokes values are supported, allowing the user to specify custom spectral models.\r\n\r\nI haven't been able to test this, but it expresses the general usage style that works in the [MeqTrees test case](https://github.com/ska-sa/montblanc/blob/bfa80dd678abdad908a944dc9c4910442486b029/montblanc/tests/test_meq_tf.py#L279-L287). \r\n\r\nAs discussed earlier I'm willing to merge the ddfacet branch into master (since almost everyone is using it), but its probably a good idea for someone to give it a run here.\r\n\r\nNote that you can try out (and possibly extend) this PR by following https://help.github.com/articles/checking-out-pull-requests-locally/"},"comment":{"url":"https://api.github.com/repos/ratt-ru/CubiCal/issues/comments/440817897","html_url":"https://github.com/ratt-ru/CubiCal/pull/240#issuecomment-440817897","issue_url":"https://api.github.com/repos/ratt-ru/CubiCal/issues/240","id":440817897,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDgxNzg5Nw==","user":{"login":"JSKenyon","id":6582745,"node_id":"MDQ6VXNlcjY1ODI3NDU=","avatar_url":"https://avatars1.githubusercontent.com/u/6582745?v=4","gravatar_id":"","url":"https://api.github.com/users/JSKenyon","html_url":"https://github.com/JSKenyon","followers_url":"https://api.github.com/users/JSKenyon/followers","following_url":"https://api.github.com/users/JSKenyon/following{/other_user}","gists_url":"https://api.github.com/users/JSKenyon/gists{/gist_id}","starred_url":"https://api.github.com/users/JSKenyon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JSKenyon/subscriptions","organizations_url":"https://api.github.com/users/JSKenyon/orgs","repos_url":"https://api.github.com/users/JSKenyon/repos","events_url":"https://api.github.com/users/JSKenyon/events{/privacy}","received_events_url":"https://api.github.com/users/JSKenyon/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T21:37:28Z","updated_at":"2018-11-21T21:37:28Z","author_association":"COLLABORATOR","body":"That degree of error is roughly what I observed when tracking down the original discrepancy which was caused by the sign. Other causes can be using Monthlanc in single precision or (less likely) weirdness with UVW coordinates.\n\nSent from my iPhone\n\n> On 21 Nov 2018, at 22:37, Oleg Smirnov <notifications@github.com> wrote:\n> \n> MeqTrees can do either per antenna, or a single global one. But for this simulation I used per antenna -- I double-checked this -- so if Montblanc uses per antenna too, there's still an unexplained discrepancy.\n> \n> The PR to MeqTrees had to do with the sign of the rotation. It would produce a far larger discrepancy. So it can't be that.\n> \n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n"}}
{"actor":{"display_login":"JSKenyon"}}