{"action":"created","comment":{"url":"https://api.github.com/repos/Sylius/Sylius-Standard/pulls/comments/221731330","pull_request_review_id":160453065,"id":221731330,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTczMTMzMA==","diff_hunk":"@@ -2,43 +2,23 @@ server {\n     root /srv/sylius/public;\n \n     location / {\n-        # try to serve file directly, fallback to app.php\n-        try_files $uri /app.php$is_args$args;\n+        # try to serve file directly, fallback to index.php\n+        try_files $uri /index.php$is_args$args;\n     }\n \n     # DEV\n     # This rule should only be placed on your development environment\n     # In production, don't include this and don't deploy app_dev.php or config.php\n-    location ~ ^/(app_dev|config)\\.php(/|$) {\n-        # Comment the next line and uncomment the lines after to enable dynamic resolution (incompatible with Kubernetes)\n+    location ~ ^/index\\.php(/|$) {\n         fastcgi_pass php:9000;\n-        #resolver 127.0.0.11;\n-        #set $upstream_host php;\n-        #fastcgi_pass $upstream_host:9000;\n-\n         fastcgi_split_path_info ^(.+\\.php)(/.*)$;\n         include fastcgi_params;\n-        # When you are using symlinks to link the document root to the","path":"docker/nginx/conf.d/default.dev.conf","position":23,"original_position":23,"commit_id":"04caed19c34f55c2e3331905677fc54b5c7bc8e3","original_commit_id":"04caed19c34f55c2e3331905677fc54b5c7bc8e3","user":{"login":"jacquesbh","id":858611,"node_id":"MDQ6VXNlcjg1ODYxMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/858611?v=4","gravatar_id":"","url":"https://api.github.com/users/jacquesbh","html_url":"https://github.com/jacquesbh","followers_url":"https://api.github.com/users/jacquesbh/followers","following_url":"https://api.github.com/users/jacquesbh/following{/other_user}","gists_url":"https://api.github.com/users/jacquesbh/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquesbh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquesbh/subscriptions","organizations_url":"https://api.github.com/users/jacquesbh/orgs","repos_url":"https://api.github.com/users/jacquesbh/repos","events_url":"https://api.github.com/users/jacquesbh/events{/privacy}","received_events_url":"https://api.github.com/users/jacquesbh/received_events","type":"User","site_admin":false},"body":"Same comment here. When you are dealing with some deployment methods, the application root is often a symlink to the latest version. So I would keep this lines commented and/or put a link to a documentation which explains everything about.","created_at":"2018-10-01T19:40:16Z","updated_at":"2018-10-01T19:40:26Z","html_url":"https://github.com/Sylius/Sylius-Standard/pull/268#discussion_r221731330","pull_request_url":"https://api.github.com/repos/Sylius/Sylius-Standard/pulls/268","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius-Standard/pulls/comments/221731330"},"html":{"href":"https://github.com/Sylius/Sylius-Standard/pull/268#discussion_r221731330"},"pull_request":{"href":"https://api.github.com/repos/Sylius/Sylius-Standard/pulls/268"}}},"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius-Standard/pulls/268","id":218756270,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NzU2Mjcw","html_url":"https://github.com/Sylius/Sylius-Standard/pull/268","diff_url":"https://github.com/Sylius/Sylius-Standard/pull/268.diff","patch_url":"https://github.com/Sylius/Sylius-Standard/pull/268.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius-Standard/issues/268","number":268,"state":"open","locked":false,"title":"Docker nginx config fix for symfony4","user":{"login":"doctorx32","id":20308356,"node_id":"MDQ6VXNlcjIwMzA4MzU2","avatar_url":"https://avatars3.githubusercontent.com/u/20308356?v=4","gravatar_id":"","url":"https://api.github.com/users/doctorx32","html_url":"https://github.com/doctorx32","followers_url":"https://api.github.com/users/doctorx32/followers","following_url":"https://api.github.com/users/doctorx32/following{/other_user}","gists_url":"https://api.github.com/users/doctorx32/gists{/gist_id}","starred_url":"https://api.github.com/users/doctorx32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctorx32/subscriptions","organizations_url":"https://api.github.com/users/doctorx32/orgs","repos_url":"https://api.github.com/users/doctorx32/repos","events_url":"https://api.github.com/users/doctorx32/events{/privacy}","received_events_url":"https://api.github.com/users/doctorx32/received_events","type":"User","site_admin":false},"body":"| Q               | A\r\n| --------------- | -----\r\n| Branch?         | 1.3\r\n| Bug fix?        | yes\r\n| New feature?    | no\r\n| BC breaks?      | no\r\n| Deprecations?   | no\r\n| Related tickets | fixes #267 \r\n| License         | MIT","created_at":"2018-09-27T19:01:18Z","updated_at":"2018-10-01T19:40:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a221dc0f4dc0ffd6acf10e2aa41733a3bedcb63","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":746509177,"node_id":"MDU6TGFiZWw3NDY1MDkxNzc=","url":"https://api.github.com/repos/Sylius/Sylius-Standard/labels/Bug","name":"Bug","color":"e10c02","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/Sylius-Standard/pulls/268/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius-Standard/pulls/268/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius-Standard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/Sylius-Standard/issues/268/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius-Standard/statuses/04caed19c34f55c2e3331905677fc54b5c7bc8e3","head":{"label":"doctorx32:docker-nginx-sf4","ref":"docker-nginx-sf4","sha":"04caed19c34f55c2e3331905677fc54b5c7bc8e3","user":{"login":"doctorx32","id":20308356,"node_id":"MDQ6VXNlcjIwMzA4MzU2","avatar_url":"https://avatars3.githubusercontent.com/u/20308356?v=4","gravatar_id":"","url":"https://api.github.com/users/doctorx32","html_url":"https://github.com/doctorx32","followers_url":"https://api.github.com/users/doctorx32/followers","following_url":"https://api.github.com/users/doctorx32/following{/other_user}","gists_url":"https://api.github.com/users/doctorx32/gists{/gist_id}","starred_url":"https://api.github.com/users/doctorx32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctorx32/subscriptions","organizations_url":"https://api.github.com/users/doctorx32/orgs","repos_url":"https://api.github.com/users/doctorx32/repos","events_url":"https://api.github.com/users/doctorx32/events{/privacy}","received_events_url":"https://api.github.com/users/doctorx32/received_events","type":"User","site_admin":false},"repo":{"id":107401083,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc0MDEwODM=","name":"Sylius-Standard","full_name":"doctorx32/Sylius-Standard","private":false,"owner":{"login":"doctorx32","id":20308356,"node_id":"MDQ6VXNlcjIwMzA4MzU2","avatar_url":"https://avatars3.githubusercontent.com/u/20308356?v=4","gravatar_id":"","url":"https://api.github.com/users/doctorx32","html_url":"https://github.com/doctorx32","followers_url":"https://api.github.com/users/doctorx32/followers","following_url":"https://api.github.com/users/doctorx32/following{/other_user}","gists_url":"https://api.github.com/users/doctorx32/gists{/gist_id}","starred_url":"https://api.github.com/users/doctorx32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctorx32/subscriptions","organizations_url":"https://api.github.com/users/doctorx32/orgs","repos_url":"https://api.github.com/users/doctorx32/repos","events_url":"https://api.github.com/users/doctorx32/events{/privacy}","received_events_url":"https://api.github.com/users/doctorx32/received_events","type":"User","site_admin":false},"html_url":"https://github.com/doctorx32/Sylius-Standard","description":"Sylius Standard Edition for starting new eCommerce projects.","fork":true,"url":"https://api.github.com/repos/doctorx32/Sylius-Standard","forks_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/forks","keys_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/teams","hooks_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/hooks","issue_events_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/issues/events{/number}","events_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/events","assignees_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/assignees{/user}","branches_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/branches{/branch}","tags_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/tags","blobs_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/statuses/{sha}","languages_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/languages","stargazers_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/stargazers","contributors_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/contributors","subscribers_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/subscribers","subscription_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/subscription","commits_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/contents/{+path}","compare_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/merges","archive_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/downloads","issues_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/issues{/number}","pulls_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/pulls{/number}","milestones_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/milestones{/number}","notifications_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/labels{/name}","releases_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/releases{/id}","deployments_url":"https://api.github.com/repos/doctorx32/Sylius-Standard/deployments","created_at":"2017-10-18T11:50:41Z","updated_at":"2018-09-27T18:44:14Z","pushed_at":"2018-09-27T18:47:54Z","git_url":"git://github.com/doctorx32/Sylius-Standard.git","ssh_url":"git@github.com:doctorx32/Sylius-Standard.git","clone_url":"https://github.com/doctorx32/Sylius-Standard.git","svn_url":"https://github.com/doctorx32/Sylius-Standard","homepage":"http://Sylius.org","size":1568,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:1.3","ref":"1.3","sha":"787a74fd0cf991ba21827416597848958d9c56d6","user":{"login":"Sylius","id":719423,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxOTQyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/719423?v=4","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":12681284,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4MTI4NA==","name":"Sylius-Standard","full_name":"Sylius/Sylius-Standard","private":false,"owner":{"login":"Sylius","id":719423,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxOTQyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/719423?v=4","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Sylius/Sylius-Standard","description":"Open Source eCommerce Application on top of Symfony","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius-Standard","forks_url":"https://api.github.com/repos/Sylius/Sylius-Standard/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius-Standard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius-Standard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius-Standard/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius-Standard/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius-Standard/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius-Standard/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius-Standard/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius-Standard/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius-Standard/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius-Standard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius-Standard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius-Standard/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius-Standard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius-Standard/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius-Standard/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius-Standard/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius-Standard/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius-Standard/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius-Standard/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius-Standard/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius-Standard/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius-Standard/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius-Standard/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/Sylius-Standard/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius-Standard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius-Standard/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius-Standard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius-Standard/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius-Standard/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius-Standard/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius-Standard/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius-Standard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius-Standard/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius-Standard/releases{/id}","deployments_url":"https://api.github.com/repos/Sylius/Sylius-Standard/deployments","created_at":"2013-09-08T13:43:34Z","updated_at":"2018-09-27T15:04:35Z","pushed_at":"2018-10-01T13:40:31Z","git_url":"git://github.com/Sylius/Sylius-Standard.git","ssh_url":"git@github.com:Sylius/Sylius-Standard.git","clone_url":"https://github.com/Sylius/Sylius-Standard.git","svn_url":"https://github.com/Sylius/Sylius-Standard","homepage":"https://sylius.com","size":1615,"stargazers_count":100,"watchers_count":100,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":88,"open_issues":16,"watchers":100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius-Standard/pulls/268"},"html":{"href":"https://github.com/Sylius/Sylius-Standard/pull/268"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius-Standard/issues/268"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius-Standard/issues/268/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius-Standard/pulls/268/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius-Standard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius-Standard/pulls/268/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius-Standard/statuses/04caed19c34f55c2e3331905677fc54b5c7bc8e3"}},"author_association":"NONE"}}
{"actor":{"display_login":"jacquesbh"}}