{"action":"created","comment":{"url":"https://api.github.com/repos/arschmitz/broccoli-standard/pulls/comments/244760863","pull_request_review_id":188709930,"id":244760863,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDc2MDg2Mw==","diff_hunk":"@@ -51,7 +51,8 @@ var StandardValidationFilter = function (inputNode, options = {}) {\n     format: options.format ? options.format : undefined,\n     throwOnError: options.throwOnError ? options.throwOnError : false,\n     logOutput: options.logOutput ? options.logOutput : false,\n-    fix: options.fix ? options.fix : false\n+    fix: options.fix ? options.fix : false,\n+    globals: options.globals || options.global","path":"lib/index.js","position":6,"original_position":6,"commit_id":"bcc6d022a5a9f092231e940e3fd0862c4fcd11f2","original_commit_id":"bcc6d022a5a9f092231e940e3fd0862c4fcd11f2","user":{"login":"jhitchins88","id":24356857,"node_id":"MDQ6VXNlcjI0MzU2ODU3","avatar_url":"https://avatars2.githubusercontent.com/u/24356857?v=4","gravatar_id":"","url":"https://api.github.com/users/jhitchins88","html_url":"https://github.com/jhitchins88","followers_url":"https://api.github.com/users/jhitchins88/followers","following_url":"https://api.github.com/users/jhitchins88/following{/other_user}","gists_url":"https://api.github.com/users/jhitchins88/gists{/gist_id}","starred_url":"https://api.github.com/users/jhitchins88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhitchins88/subscriptions","organizations_url":"https://api.github.com/users/jhitchins88/orgs","repos_url":"https://api.github.com/users/jhitchins88/repos","events_url":"https://api.github.com/users/jhitchins88/events{/privacy}","received_events_url":"https://api.github.com/users/jhitchins88/received_events","type":"User","site_admin":false},"body":"To mimic standard accepting of both: https://github.com/standard/standard#i-use-a-library-that-pollutes-the-global-namespace-how-do-i-prevent-variable-is-not-defined-errors","created_at":"2019-01-02T15:13:40Z","updated_at":"2019-01-02T15:13:41Z","html_url":"https://github.com/arschmitz/broccoli-standard/pull/2#discussion_r244760863","pull_request_url":"https://api.github.com/repos/arschmitz/broccoli-standard/pulls/2","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/arschmitz/broccoli-standard/pulls/comments/244760863"},"html":{"href":"https://github.com/arschmitz/broccoli-standard/pull/2#discussion_r244760863"},"pull_request":{"href":"https://api.github.com/repos/arschmitz/broccoli-standard/pulls/2"}},"in_reply_to_id":244663888},"pull_request":{"url":"https://api.github.com/repos/arschmitz/broccoli-standard/pulls/2","id":241646595,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNjQ2NTk1","html_url":"https://github.com/arschmitz/broccoli-standard/pull/2","diff_url":"https://github.com/arschmitz/broccoli-standard/pull/2.diff","patch_url":"https://github.com/arschmitz/broccoli-standard/pull/2.patch","issue_url":"https://api.github.com/repos/arschmitz/broccoli-standard/issues/2","number":2,"state":"open","locked":false,"title":"Pass global options to standard","user":{"login":"jhitchins88","id":24356857,"node_id":"MDQ6VXNlcjI0MzU2ODU3","avatar_url":"https://avatars2.githubusercontent.com/u/24356857?v=4","gravatar_id":"","url":"https://api.github.com/users/jhitchins88","html_url":"https://github.com/jhitchins88","followers_url":"https://api.github.com/users/jhitchins88/followers","following_url":"https://api.github.com/users/jhitchins88/following{/other_user}","gists_url":"https://api.github.com/users/jhitchins88/gists{/gist_id}","starred_url":"https://api.github.com/users/jhitchins88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhitchins88/subscriptions","organizations_url":"https://api.github.com/users/jhitchins88/orgs","repos_url":"https://api.github.com/users/jhitchins88/repos","events_url":"https://api.github.com/users/jhitchins88/events{/privacy}","received_events_url":"https://api.github.com/users/jhitchins88/received_events","type":"User","site_admin":false},"body":"Fixes #1\r\n\r\nAdds the `global` or `globals` option to the `internalOptions` object, allowing someone to pass a globals array to the standard linter.  This will not prevent the `package.json` of the main file from adding its own `globals` options on top of this option.","created_at":"2019-01-01T18:57:24Z","updated_at":"2019-01-02T15:13:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e29b2b2ead0e5afd60fb6f05407d0eef896a4315","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/arschmitz/broccoli-standard/pulls/2/commits","review_comments_url":"https://api.github.com/repos/arschmitz/broccoli-standard/pulls/2/comments","review_comment_url":"https://api.github.com/repos/arschmitz/broccoli-standard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arschmitz/broccoli-standard/issues/2/comments","statuses_url":"https://api.github.com/repos/arschmitz/broccoli-standard/statuses/bcc6d022a5a9f092231e940e3fd0862c4fcd11f2","head":{"label":"jhitchins88:add-global-options","ref":"add-global-options","sha":"bcc6d022a5a9f092231e940e3fd0862c4fcd11f2","user":{"login":"jhitchins88","id":24356857,"node_id":"MDQ6VXNlcjI0MzU2ODU3","avatar_url":"https://avatars2.githubusercontent.com/u/24356857?v=4","gravatar_id":"","url":"https://api.github.com/users/jhitchins88","html_url":"https://github.com/jhitchins88","followers_url":"https://api.github.com/users/jhitchins88/followers","following_url":"https://api.github.com/users/jhitchins88/following{/other_user}","gists_url":"https://api.github.com/users/jhitchins88/gists{/gist_id}","starred_url":"https://api.github.com/users/jhitchins88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhitchins88/subscriptions","organizations_url":"https://api.github.com/users/jhitchins88/orgs","repos_url":"https://api.github.com/users/jhitchins88/repos","events_url":"https://api.github.com/users/jhitchins88/events{/privacy}","received_events_url":"https://api.github.com/users/jhitchins88/received_events","type":"User","site_admin":false},"repo":{"id":163756961,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM3NTY5NjE=","name":"broccoli-standard","full_name":"jhitchins88/broccoli-standard","private":false,"owner":{"login":"jhitchins88","id":24356857,"node_id":"MDQ6VXNlcjI0MzU2ODU3","avatar_url":"https://avatars2.githubusercontent.com/u/24356857?v=4","gravatar_id":"","url":"https://api.github.com/users/jhitchins88","html_url":"https://github.com/jhitchins88","followers_url":"https://api.github.com/users/jhitchins88/followers","following_url":"https://api.github.com/users/jhitchins88/following{/other_user}","gists_url":"https://api.github.com/users/jhitchins88/gists{/gist_id}","starred_url":"https://api.github.com/users/jhitchins88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhitchins88/subscriptions","organizations_url":"https://api.github.com/users/jhitchins88/orgs","repos_url":"https://api.github.com/users/jhitchins88/repos","events_url":"https://api.github.com/users/jhitchins88/events{/privacy}","received_events_url":"https://api.github.com/users/jhitchins88/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jhitchins88/broccoli-standard","description":"Standard formatting for green vegetable based build systems","fork":true,"url":"https://api.github.com/repos/jhitchins88/broccoli-standard","forks_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/forks","keys_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/teams","hooks_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/hooks","issue_events_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/issues/events{/number}","events_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/events","assignees_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/assignees{/user}","branches_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/branches{/branch}","tags_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/tags","blobs_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/statuses/{sha}","languages_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/languages","stargazers_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/stargazers","contributors_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/contributors","subscribers_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/subscribers","subscription_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/subscription","commits_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/contents/{+path}","compare_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/merges","archive_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/downloads","issues_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/issues{/number}","pulls_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/pulls{/number}","milestones_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/milestones{/number}","notifications_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/labels{/name}","releases_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/releases{/id}","deployments_url":"https://api.github.com/repos/jhitchins88/broccoli-standard/deployments","created_at":"2019-01-01T18:18:19Z","updated_at":"2019-01-01T18:18:22Z","pushed_at":"2019-01-01T18:23:47Z","git_url":"git://github.com/jhitchins88/broccoli-standard.git","ssh_url":"git@github.com:jhitchins88/broccoli-standard.git","clone_url":"https://github.com/jhitchins88/broccoli-standard.git","svn_url":"https://github.com/jhitchins88/broccoli-standard","homepage":null,"size":15,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arschmitz:master","ref":"master","sha":"f88e268bd15df408b05c54f57471c9f5525df83b","user":{"login":"arschmitz","id":462993,"node_id":"MDQ6VXNlcjQ2Mjk5Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/462993?v=4","gravatar_id":"","url":"https://api.github.com/users/arschmitz","html_url":"https://github.com/arschmitz","followers_url":"https://api.github.com/users/arschmitz/followers","following_url":"https://api.github.com/users/arschmitz/following{/other_user}","gists_url":"https://api.github.com/users/arschmitz/gists{/gist_id}","starred_url":"https://api.github.com/users/arschmitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschmitz/subscriptions","organizations_url":"https://api.github.com/users/arschmitz/orgs","repos_url":"https://api.github.com/users/arschmitz/repos","events_url":"https://api.github.com/users/arschmitz/events{/privacy}","received_events_url":"https://api.github.com/users/arschmitz/received_events","type":"User","site_admin":false},"repo":{"id":71094679,"node_id":"MDEwOlJlcG9zaXRvcnk3MTA5NDY3OQ==","name":"broccoli-standard","full_name":"arschmitz/broccoli-standard","private":false,"owner":{"login":"arschmitz","id":462993,"node_id":"MDQ6VXNlcjQ2Mjk5Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/462993?v=4","gravatar_id":"","url":"https://api.github.com/users/arschmitz","html_url":"https://github.com/arschmitz","followers_url":"https://api.github.com/users/arschmitz/followers","following_url":"https://api.github.com/users/arschmitz/following{/other_user}","gists_url":"https://api.github.com/users/arschmitz/gists{/gist_id}","starred_url":"https://api.github.com/users/arschmitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschmitz/subscriptions","organizations_url":"https://api.github.com/users/arschmitz/orgs","repos_url":"https://api.github.com/users/arschmitz/repos","events_url":"https://api.github.com/users/arschmitz/events{/privacy}","received_events_url":"https://api.github.com/users/arschmitz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/arschmitz/broccoli-standard","description":"Standard formatting for green vegetable based build systems","fork":false,"url":"https://api.github.com/repos/arschmitz/broccoli-standard","forks_url":"https://api.github.com/repos/arschmitz/broccoli-standard/forks","keys_url":"https://api.github.com/repos/arschmitz/broccoli-standard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arschmitz/broccoli-standard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arschmitz/broccoli-standard/teams","hooks_url":"https://api.github.com/repos/arschmitz/broccoli-standard/hooks","issue_events_url":"https://api.github.com/repos/arschmitz/broccoli-standard/issues/events{/number}","events_url":"https://api.github.com/repos/arschmitz/broccoli-standard/events","assignees_url":"https://api.github.com/repos/arschmitz/broccoli-standard/assignees{/user}","branches_url":"https://api.github.com/repos/arschmitz/broccoli-standard/branches{/branch}","tags_url":"https://api.github.com/repos/arschmitz/broccoli-standard/tags","blobs_url":"https://api.github.com/repos/arschmitz/broccoli-standard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arschmitz/broccoli-standard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arschmitz/broccoli-standard/git/refs{/sha}","trees_url":"https://api.github.com/repos/arschmitz/broccoli-standard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arschmitz/broccoli-standard/statuses/{sha}","languages_url":"https://api.github.com/repos/arschmitz/broccoli-standard/languages","stargazers_url":"https://api.github.com/repos/arschmitz/broccoli-standard/stargazers","contributors_url":"https://api.github.com/repos/arschmitz/broccoli-standard/contributors","subscribers_url":"https://api.github.com/repos/arschmitz/broccoli-standard/subscribers","subscription_url":"https://api.github.com/repos/arschmitz/broccoli-standard/subscription","commits_url":"https://api.github.com/repos/arschmitz/broccoli-standard/commits{/sha}","git_commits_url":"https://api.github.com/repos/arschmitz/broccoli-standard/git/commits{/sha}","comments_url":"https://api.github.com/repos/arschmitz/broccoli-standard/comments{/number}","issue_comment_url":"https://api.github.com/repos/arschmitz/broccoli-standard/issues/comments{/number}","contents_url":"https://api.github.com/repos/arschmitz/broccoli-standard/contents/{+path}","compare_url":"https://api.github.com/repos/arschmitz/broccoli-standard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arschmitz/broccoli-standard/merges","archive_url":"https://api.github.com/repos/arschmitz/broccoli-standard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arschmitz/broccoli-standard/downloads","issues_url":"https://api.github.com/repos/arschmitz/broccoli-standard/issues{/number}","pulls_url":"https://api.github.com/repos/arschmitz/broccoli-standard/pulls{/number}","milestones_url":"https://api.github.com/repos/arschmitz/broccoli-standard/milestones{/number}","notifications_url":"https://api.github.com/repos/arschmitz/broccoli-standard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arschmitz/broccoli-standard/labels{/name}","releases_url":"https://api.github.com/repos/arschmitz/broccoli-standard/releases{/id}","deployments_url":"https://api.github.com/repos/arschmitz/broccoli-standard/deployments","created_at":"2016-10-17T02:55:53Z","updated_at":"2016-10-17T03:01:29Z","pushed_at":"2019-01-01T18:57:24Z","git_url":"git://github.com/arschmitz/broccoli-standard.git","ssh_url":"git@github.com:arschmitz/broccoli-standard.git","clone_url":"https://github.com/arschmitz/broccoli-standard.git","svn_url":"https://github.com/arschmitz/broccoli-standard","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arschmitz/broccoli-standard/pulls/2"},"html":{"href":"https://github.com/arschmitz/broccoli-standard/pull/2"},"issue":{"href":"https://api.github.com/repos/arschmitz/broccoli-standard/issues/2"},"comments":{"href":"https://api.github.com/repos/arschmitz/broccoli-standard/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/arschmitz/broccoli-standard/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/arschmitz/broccoli-standard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arschmitz/broccoli-standard/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/arschmitz/broccoli-standard/statuses/bcc6d022a5a9f092231e940e3fd0862c4fcd11f2"}},"author_association":"NONE"}}
{"actor":{"display_login":"jhitchins88"}}