{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/SignalR/pulls/comments/209825830","pull_request_review_id":145913178,"id":209825830,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTgyNTgzMA==","diff_hunk":"@@ -2,38 +2,22 @@\n // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.\n \n import com.microsoft.aspnet.signalr.NullLogger;\n+import com.microsoft.aspnet.signalr.Transport;\n import com.microsoft.aspnet.signalr.WebSocketTransport;\n-import java.net.URISyntaxException;\n-import java.util.Arrays;\n-import java.util.Collection;\n+import org.junit.Rule;\n import org.junit.Test;\n-import org.junit.runner.RunWith;\n-import org.junit.runners.Parameterized;\n+import org.junit.rules.ExpectedException;\n \n-import static org.junit.Assert.*;\n-\n-@RunWith(Parameterized.class)\n public class WebSocketTransportTest {\n-    private String url;\n-    private String expectedUrl;\n-\n-    public WebSocketTransportTest(String url, String expectedProtocol){\n-        this.url = url;\n-        this.expectedUrl = expectedProtocol;\n-    }\n \n-    @Parameterized.Parameters\n-    public static Collection protocols(){\n-        return Arrays.asList(new String[][] {\n-                {\"http://example.com\", \"ws://example.com\"},\n-                {\"https://example.com\", \"wss://example.com\"},\n-                {\"ws://example.com\", \"ws://example.com\"},\n-                {\"wss://example.com\", \"wss://example.com\"}});\n-    }\n+    @Rule\n+    public ExpectedException expectedEx = ExpectedException.none();\n \n     @Test\n-    public void checkWebsocketUrlProtocol() throws URISyntaxException {\n-        WebSocketTransport webSocketTransport = new WebSocketTransport(this.url, new NullLogger());\n-        assertEquals(this.expectedUrl, webSocketTransport.getUrl().toString());\n+    public void WebsocketThrowsIIfItCantConnect() throws Exception {\n+        expectedEx.expect(Exception.class);","path":"clients/java/signalr/src/test/java/WebSocketTransportTest.java","position":43,"original_position":43,"commit_id":"b0d3fa8dd5ad2790268ff140ae7e53fea15ece82","original_commit_id":"b0d3fa8dd5ad2790268ff140ae7e53fea15ece82","user":{"login":"mikaelm12","id":4809660,"node_id":"MDQ6VXNlcjQ4MDk2NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/4809660?v=4","gravatar_id":"","url":"https://api.github.com/users/mikaelm12","html_url":"https://github.com/mikaelm12","followers_url":"https://api.github.com/users/mikaelm12/followers","following_url":"https://api.github.com/users/mikaelm12/following{/other_user}","gists_url":"https://api.github.com/users/mikaelm12/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaelm12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaelm12/subscriptions","organizations_url":"https://api.github.com/users/mikaelm12/orgs","repos_url":"https://api.github.com/users/mikaelm12/repos","events_url":"https://api.github.com/users/mikaelm12/events{/privacy}","received_events_url":"https://api.github.com/users/mikaelm12/received_events","type":"User","site_admin":false},"body":"Yeah, I like the JUnit 5 assertThrows syntax more and it also provides a better way to do parametrized tests but I started making the changes and it was just a little to involved to be a side effect of this change imo. I'll file an issue and plan to do this in the preview2 wave. ","created_at":"2018-08-14T04:32:16Z","updated_at":"2018-08-14T04:32:16Z","html_url":"https://github.com/aspnet/SignalR/pull/2801#discussion_r209825830","pull_request_url":"https://api.github.com/repos/aspnet/SignalR/pulls/2801","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aspnet/SignalR/pulls/comments/209825830"},"html":{"href":"https://github.com/aspnet/SignalR/pull/2801#discussion_r209825830"},"pull_request":{"href":"https://api.github.com/repos/aspnet/SignalR/pulls/2801"}},"in_reply_to_id":209785688},"pull_request":{"url":"https://api.github.com/repos/aspnet/SignalR/pulls/2801","id":208126676,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTI2Njc2","html_url":"https://github.com/aspnet/SignalR/pull/2801","diff_url":"https://github.com/aspnet/SignalR/pull/2801.diff","patch_url":"https://github.com/aspnet/SignalR/pull/2801.patch","issue_url":"https://api.github.com/repos/aspnet/SignalR/issues/2801","number":2801,"state":"open","locked":false,"title":"Throw if the Websocket cant connect","user":{"login":"mikaelm12","id":4809660,"node_id":"MDQ6VXNlcjQ4MDk2NjA=","avatar_url":"https://avatars1.githubusercontent.com/u/4809660?v=4","gravatar_id":"","url":"https://api.github.com/users/mikaelm12","html_url":"https://github.com/mikaelm12","followers_url":"https://api.github.com/users/mikaelm12/followers","following_url":"https://api.github.com/users/mikaelm12/following{/other_user}","gists_url":"https://api.github.com/users/mikaelm12/gists{/gist_id}","starred_url":"https://api.github.com/users/mikaelm12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikaelm12/subscriptions","organizations_url":"https://api.github.com/users/mikaelm12/orgs","repos_url":"https://api.github.com/users/mikaelm12/repos","events_url":"https://api.github.com/users/mikaelm12/events{/privacy}","received_events_url":"https://api.github.com/users/mikaelm12/received_events","type":"User","site_admin":false},"body":"Issue: https://github.com/aspnet/SignalR/issues/2781\r\nCurrently the Websockets transport doesn't fail immediately if it can't connect. It fails right after when it tries to send the handshake response. This ensures that the websocket was able to connect before continuing. ","created_at":"2018-08-13T22:58:26Z","updated_at":"2018-08-14T04:32:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"391dd3ae93f43da30695852e571b8adb18c8ef67","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/SignalR/pulls/2801/commits","review_comments_url":"https://api.github.com/repos/aspnet/SignalR/pulls/2801/comments","review_comment_url":"https://api.github.com/repos/aspnet/SignalR/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/SignalR/issues/2801/comments","statuses_url":"https://api.github.com/repos/aspnet/SignalR/statuses/b0d3fa8dd5ad2790268ff140ae7e53fea15ece82","head":{"label":"aspnet:mikaelm12/CheckConnectResult","ref":"mikaelm12/CheckConnectResult","sha":"b0d3fa8dd5ad2790268ff140ae7e53fea15ece82","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":71159589,"node_id":"MDEwOlJlcG9zaXRvcnk3MTE1OTU4OQ==","name":"SignalR","full_name":"aspnet/SignalR","owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/SignalR","description":"Incredibly simple real-time web for ASP.NET Core","fork":false,"url":"https://api.github.com/repos/aspnet/SignalR","forks_url":"https://api.github.com/repos/aspnet/SignalR/forks","keys_url":"https://api.github.com/repos/aspnet/SignalR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/SignalR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/SignalR/teams","hooks_url":"https://api.github.com/repos/aspnet/SignalR/hooks","issue_events_url":"https://api.github.com/repos/aspnet/SignalR/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/SignalR/events","assignees_url":"https://api.github.com/repos/aspnet/SignalR/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/SignalR/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/SignalR/tags","blobs_url":"https://api.github.com/repos/aspnet/SignalR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/SignalR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/SignalR/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/SignalR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/SignalR/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/SignalR/languages","stargazers_url":"https://api.github.com/repos/aspnet/SignalR/stargazers","contributors_url":"https://api.github.com/repos/aspnet/SignalR/contributors","subscribers_url":"https://api.github.com/repos/aspnet/SignalR/subscribers","subscription_url":"https://api.github.com/repos/aspnet/SignalR/subscription","commits_url":"https://api.github.com/repos/aspnet/SignalR/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/SignalR/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/SignalR/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/SignalR/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/SignalR/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/SignalR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/SignalR/merges","archive_url":"https://api.github.com/repos/aspnet/SignalR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/SignalR/downloads","issues_url":"https://api.github.com/repos/aspnet/SignalR/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/SignalR/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/SignalR/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/SignalR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/SignalR/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/SignalR/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/SignalR/deployments","created_at":"2016-10-17T16:39:15Z","updated_at":"2018-08-14T02:02:08Z","pushed_at":"2018-08-13T23:33:16Z","git_url":"git://github.com/aspnet/SignalR.git","ssh_url":"git@github.com:aspnet/SignalR.git","clone_url":"https://github.com/aspnet/SignalR.git","svn_url":"https://github.com/aspnet/SignalR","homepage":null,"size":10014,"stargazers_count":2071,"watchers_count":2071,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":363,"mirror_url":null,"archived":false,"open_issues_count":163,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":363,"open_issues":163,"watchers":2071,"default_branch":"release/2.2"}},"base":{"label":"aspnet:release/2.2","ref":"release/2.2","sha":"045d5f1c7fd10d767be0190dc8190104c28c5281","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":71159589,"node_id":"MDEwOlJlcG9zaXRvcnk3MTE1OTU4OQ==","name":"SignalR","full_name":"aspnet/SignalR","owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/SignalR","description":"Incredibly simple real-time web for ASP.NET Core","fork":false,"url":"https://api.github.com/repos/aspnet/SignalR","forks_url":"https://api.github.com/repos/aspnet/SignalR/forks","keys_url":"https://api.github.com/repos/aspnet/SignalR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/SignalR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/SignalR/teams","hooks_url":"https://api.github.com/repos/aspnet/SignalR/hooks","issue_events_url":"https://api.github.com/repos/aspnet/SignalR/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/SignalR/events","assignees_url":"https://api.github.com/repos/aspnet/SignalR/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/SignalR/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/SignalR/tags","blobs_url":"https://api.github.com/repos/aspnet/SignalR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/SignalR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/SignalR/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/SignalR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/SignalR/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/SignalR/languages","stargazers_url":"https://api.github.com/repos/aspnet/SignalR/stargazers","contributors_url":"https://api.github.com/repos/aspnet/SignalR/contributors","subscribers_url":"https://api.github.com/repos/aspnet/SignalR/subscribers","subscription_url":"https://api.github.com/repos/aspnet/SignalR/subscription","commits_url":"https://api.github.com/repos/aspnet/SignalR/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/SignalR/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/SignalR/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/SignalR/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/SignalR/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/SignalR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/SignalR/merges","archive_url":"https://api.github.com/repos/aspnet/SignalR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/SignalR/downloads","issues_url":"https://api.github.com/repos/aspnet/SignalR/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/SignalR/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/SignalR/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/SignalR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/SignalR/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/SignalR/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/SignalR/deployments","created_at":"2016-10-17T16:39:15Z","updated_at":"2018-08-14T02:02:08Z","pushed_at":"2018-08-13T23:33:16Z","git_url":"git://github.com/aspnet/SignalR.git","ssh_url":"git@github.com:aspnet/SignalR.git","clone_url":"https://github.com/aspnet/SignalR.git","svn_url":"https://github.com/aspnet/SignalR","homepage":null,"size":10014,"stargazers_count":2071,"watchers_count":2071,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":363,"mirror_url":null,"archived":false,"open_issues_count":163,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":363,"open_issues":163,"watchers":2071,"default_branch":"release/2.2"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/SignalR/pulls/2801"},"html":{"href":"https://github.com/aspnet/SignalR/pull/2801"},"issue":{"href":"https://api.github.com/repos/aspnet/SignalR/issues/2801"},"comments":{"href":"https://api.github.com/repos/aspnet/SignalR/issues/2801/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/SignalR/pulls/2801/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/SignalR/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/SignalR/pulls/2801/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/SignalR/statuses/b0d3fa8dd5ad2790268ff140ae7e53fea15ece82"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mikaelm12"}}