{"action":"created","issue":{"url":"https://api.github.com/repos/salesforce/design-system-react/issues/1590","repository_url":"https://api.github.com/repos/salesforce/design-system-react","labels_url":"https://api.github.com/repos/salesforce/design-system-react/issues/1590/labels{/name}","comments_url":"https://api.github.com/repos/salesforce/design-system-react/issues/1590/comments","events_url":"https://api.github.com/repos/salesforce/design-system-react/issues/1590/events","html_url":"https://github.com/salesforce/design-system-react/pull/1590","id":366919187,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNDc3NjY2","number":1590,"title":"Datepicker: Move custom input props to input render prop instead of children prop","user":{"login":"interactivellama","id":1290832,"node_id":"MDQ6VXNlcjEyOTA4MzI=","avatar_url":"https://avatars0.githubusercontent.com/u/1290832?v=4","gravatar_id":"","url":"https://api.github.com/users/interactivellama","html_url":"https://github.com/interactivellama","followers_url":"https://api.github.com/users/interactivellama/followers","following_url":"https://api.github.com/users/interactivellama/following{/other_user}","gists_url":"https://api.github.com/users/interactivellama/gists{/gist_id}","starred_url":"https://api.github.com/users/interactivellama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interactivellama/subscriptions","organizations_url":"https://api.github.com/users/interactivellama/orgs","repos_url":"https://api.github.com/users/interactivellama/repos","events_url":"https://api.github.com/users/interactivellama/events{/privacy}","received_events_url":"https://api.github.com/users/interactivellama/received_events","type":"User","site_admin":false},"labels":[{"id":330299410,"node_id":"MDU6TGFiZWwzMzAyOTk0MTA=","url":"https://api.github.com/repos/salesforce/design-system-react/labels/date-picker","name":"date-picker","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":{"login":"futuremint","id":5891,"node_id":"MDQ6VXNlcjU4OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/5891?v=4","gravatar_id":"","url":"https://api.github.com/users/futuremint","html_url":"https://github.com/futuremint","followers_url":"https://api.github.com/users/futuremint/followers","following_url":"https://api.github.com/users/futuremint/following{/other_user}","gists_url":"https://api.github.com/users/futuremint/gists{/gist_id}","starred_url":"https://api.github.com/users/futuremint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/futuremint/subscriptions","organizations_url":"https://api.github.com/users/futuremint/orgs","repos_url":"https://api.github.com/users/futuremint/repos","events_url":"https://api.github.com/users/futuremint/events{/privacy}","received_events_url":"https://api.github.com/users/futuremint/received_events","type":"User","site_admin":false},"assignees":[{"login":"futuremint","id":5891,"node_id":"MDQ6VXNlcjU4OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/5891?v=4","gravatar_id":"","url":"https://api.github.com/users/futuremint","html_url":"https://github.com/futuremint","followers_url":"https://api.github.com/users/futuremint/followers","following_url":"https://api.github.com/users/futuremint/following{/other_user}","gists_url":"https://api.github.com/users/futuremint/gists{/gist_id}","starred_url":"https://api.github.com/users/futuremint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/futuremint/subscriptions","organizations_url":"https://api.github.com/users/futuremint/orgs","repos_url":"https://api.github.com/users/futuremint/repos","events_url":"https://api.github.com/users/futuremint/events{/privacy}","received_events_url":"https://api.github.com/users/futuremint/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-10-04T18:40:21Z","updated_at":"2018-10-17T13:39:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/salesforce/design-system-react/pulls/1590","html_url":"https://github.com/salesforce/design-system-react/pull/1590","diff_url":"https://github.com/salesforce/design-system-react/pull/1590.diff","patch_url":"https://github.com/salesforce/design-system-react/pull/1590.patch"},"body":"Fixes #1524 and partial fix for #1588 in that it makes custom input props more obvious.\r\n\r\n### Additional description\r\n\r\nConsole warning:\r\n![screen shot 2018-10-04 at 12 36 10 pm](https://user-images.githubusercontent.com/1290832/46496927-74b8d880-c7d6-11e8-8aab-a379e31db4a6.png)\r\n\r\n\r\n---\r\n\r\n### CONTRIBUTOR checklist (do not remove)\r\nPlease complete for every pull request\r\n\r\n* [ ] First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.\r\n* [ ] `npm run lint:fix` has been run and linting passes.\r\n* [ ] Mocha, Jest (Storyshots), and `components/component-docs.json` CI tests pass (`npm test`).\r\n* [ ] Tests have been added for new props to prevent regressions in the future. See [readme](https://github.com/salesforce/design-system-react/blob/master/tests/README.md).\r\n* [ ] Review the appropriate Storybook stories. Open [http://localhost:9001/](http://localhost:9001/).\r\n* [ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open [http://localhost:9001/](http://localhost:9001/).\r\n* [ ] Review tests are passing in the browser. Open [http://localhost:8001/](http://localhost:8001/).\r\n* [ ] Review markup conforms to [SLDS](https://www.lightningdesignsystem.com/) by looking at [DOM snapshot strings](https://facebook.github.io/jest/docs/en/snapshot-testing.html).\r\n\r\n### REVIEWER checklist (do not remove)\r\n\r\n* [ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and `components/component-docs.json` tests.\r\n* [ ] Tests have been added for new props to prevent regressions in the future. See [readme](https://github.com/salesforce/design-system-react/blob/master/tests/README.md).\r\n* [ ] Review the appropriate Storybook stories. Open [http://localhost:9001/](http://localhost:9001/).\r\n* [ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open [http://localhost:9001/](http://localhost:9001/).\r\n* [ ] Review tests are passing in the browser. Open [http://localhost:8001/](http://localhost:8001/).\r\n* [ ] Review markup conforms to [SLDS](https://www.lightningdesignsystem.com/) by looking at [DOM snapshot strings](https://facebook.github.io/jest/docs/en/snapshot-testing.html).\r\n###### Required only if there are markup / UX changes\r\n* [ ] Add year-first date and commit SHA to `last-slds-markup-review` in `package.json` and push.\r\n* [ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.\r\n* [ ] Add year-first review date, and commit SHA, `last-accessibility-review`, to `package.json` and push.\r\n* [ ] While the contributor's branch is checked out, run `npm run local-update` within locally cloned [site repo](https://github.com/salesforce-ux/design-system-react-site) to confirm the site will function correctly at the next release.\r\n"},"comment":{"url":"https://api.github.com/repos/salesforce/design-system-react/issues/comments/430632236","html_url":"https://github.com/salesforce/design-system-react/pull/1590#issuecomment-430632236","issue_url":"https://api.github.com/repos/salesforce/design-system-react/issues/1590","id":430632236,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDYzMjIzNg==","user":{"login":"futuremint","id":5891,"node_id":"MDQ6VXNlcjU4OTE=","avatar_url":"https://avatars2.githubusercontent.com/u/5891?v=4","gravatar_id":"","url":"https://api.github.com/users/futuremint","html_url":"https://github.com/futuremint","followers_url":"https://api.github.com/users/futuremint/followers","following_url":"https://api.github.com/users/futuremint/following{/other_user}","gists_url":"https://api.github.com/users/futuremint/gists{/gist_id}","starred_url":"https://api.github.com/users/futuremint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/futuremint/subscriptions","organizations_url":"https://api.github.com/users/futuremint/orgs","repos_url":"https://api.github.com/users/futuremint/repos","events_url":"https://api.github.com/users/futuremint/events{/privacy}","received_events_url":"https://api.github.com/users/futuremint/received_events","type":"User","site_admin":false},"created_at":"2018-10-17T13:39:26Z","updated_at":"2018-10-17T13:39:26Z","author_association":"CONTRIBUTOR","body":"I think there should just be _one_ class method that gets all the props needed for the input.  And inside that one method is all of the implementation details to do that (all of the defaults, overrides, combinations, etc.).  As it stands currently that implementation is partially inside the render function and partially outside (spread across the various \"get\" methods for the different props that are assembled inside the render function).  The render function should just be about rendering, so it should have one call to `getInputProps` (because the fact that they are assembled from different props is an implementation detail that will go away eventually and should be abstracted away).  Then the one `getInputProps` method has all the steps _currently_ required to assemble those props from the various sources, deprecated and otherwise.  As time progresses that will also contain the changes to how those props are derived to that one method potentially making future PR reviews a bit easier too."}}
{"actor":{"display_login":"futuremint"}}