{"action":"created","issue":{"url":"https://api.github.com/repos/DefectDojo/django-DefectDojo/issues/511","repository_url":"https://api.github.com/repos/DefectDojo/django-DefectDojo","labels_url":"https://api.github.com/repos/DefectDojo/django-DefectDojo/issues/511/labels{/name}","comments_url":"https://api.github.com/repos/DefectDojo/django-DefectDojo/issues/511/comments","events_url":"https://api.github.com/repos/DefectDojo/django-DefectDojo/issues/511/events","html_url":"https://github.com/DefectDojo/django-DefectDojo/pull/511","id":305952983,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc1NTUxODkx","number":511,"title":"Add migrations to version control","user":{"login":"maennel","id":1587013,"node_id":"MDQ6VXNlcjE1ODcwMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1587013?v=4","gravatar_id":"","url":"https://api.github.com/users/maennel","html_url":"https://github.com/maennel","followers_url":"https://api.github.com/users/maennel/followers","following_url":"https://api.github.com/users/maennel/following{/other_user}","gists_url":"https://api.github.com/users/maennel/gists{/gist_id}","starred_url":"https://api.github.com/users/maennel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maennel/subscriptions","organizations_url":"https://api.github.com/users/maennel/orgs","repos_url":"https://api.github.com/users/maennel/repos","events_url":"https://api.github.com/users/maennel/events{/privacy}","received_events_url":"https://api.github.com/users/maennel/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-03-16T14:39:04Z","updated_at":"2018-06-11T19:45:38Z","closed_at":"2018-06-11T19:45:38Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/DefectDojo/django-DefectDojo/pulls/511","html_url":"https://github.com/DefectDojo/django-DefectDojo/pull/511","diff_url":"https://github.com/DefectDojo/django-DefectDojo/pull/511.diff","patch_url":"https://github.com/DefectDojo/django-DefectDojo/pull/511.patch"},"body":"As described in issue #495, Django migrations are now tracked under version control. \r\nAn official documentation of migrations can be found at https://docs.djangoproject.com/en/dev/topics/migrations/#version-control\r\n\r\nIn my opinion, tracking migrations can prevent issues to happen in future releases and ensure data consistency across new releases. \r\n\r\nThis PR includes:\r\n- an initial migration\r\n- a technical way to ensure contributors have added migrations (tests will fail otherwise)\r\n- an upgrading \"How-To\" guide\r\n- several small bugfixes (mainly wrong settings imports discovered during testing of migrations)\r\n- renamed settings.dist.py to settings_dist.py to make it importable in unittest-settings (adapted all retrieveable occurrences of it, as well)\r\n\r\n---\r\nWhen submitting a pull request, please make sure you have completed the following checklist:\r\n\r\n- [ ] Your code is pep8 compliant (Dojo's code isn't currently pep8 compliant, but we're trying to correct that)\r\n- [x] If this is a new feature and not a bug fix, you've included the proper documentation under the /docs folder\r\n"},"comment":{"url":"https://api.github.com/repos/DefectDojo/django-DefectDojo/issues/comments/396363420","html_url":"https://github.com/DefectDojo/django-DefectDojo/pull/511#issuecomment-396363420","issue_url":"https://api.github.com/repos/DefectDojo/django-DefectDojo/issues/511","id":396363420,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjM2MzQyMA==","user":{"login":"devGregA","id":4741312,"node_id":"MDQ6VXNlcjQ3NDEzMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/4741312?v=4","gravatar_id":"","url":"https://api.github.com/users/devGregA","html_url":"https://github.com/devGregA","followers_url":"https://api.github.com/users/devGregA/followers","following_url":"https://api.github.com/users/devGregA/following{/other_user}","gists_url":"https://api.github.com/users/devGregA/gists{/gist_id}","starred_url":"https://api.github.com/users/devGregA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devGregA/subscriptions","organizations_url":"https://api.github.com/users/devGregA/orgs","repos_url":"https://api.github.com/users/devGregA/repos","events_url":"https://api.github.com/users/devGregA/events{/privacy}","received_events_url":"https://api.github.com/users/devGregA/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T19:45:38Z","updated_at":"2018-06-11T19:45:38Z","author_association":"COLLABORATOR","body":"All, closing for now. Regarding API V2, I believe the issue was due to poor travis tests. Having Migrations would not have affected the testing outcome as migrations only manage schema, not the actual data. A pre-populated previous version of Dojo in CI would have caught the issue."}}
{"actor":{"display_login":"devGregA"}}