{"action":"closed","number":2687,"pull_request":{"url":"https://api.github.com/repos/scalableminds/webknossos/pulls/2687","id":192845979,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyODQ1OTc5","html_url":"https://github.com/scalableminds/webknossos/pull/2687","diff_url":"https://github.com/scalableminds/webknossos/pull/2687.diff","patch_url":"https://github.com/scalableminds/webknossos/pull/2687.patch","issue_url":"https://api.github.com/repos/scalableminds/webknossos/issues/2687","number":2687,"state":"closed","locked":false,"title":"Refactor ping (prefetch) functionality","user":{"login":"daniel-wer","id":1702075,"node_id":"MDQ6VXNlcjE3MDIwNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1702075?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-wer","html_url":"https://github.com/daniel-wer","followers_url":"https://api.github.com/users/daniel-wer/followers","following_url":"https://api.github.com/users/daniel-wer/following{/other_user}","gists_url":"https://api.github.com/users/daniel-wer/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-wer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-wer/subscriptions","organizations_url":"https://api.github.com/users/daniel-wer/orgs","repos_url":"https://api.github.com/users/daniel-wer/repos","events_url":"https://api.github.com/users/daniel-wer/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-wer/received_events","type":"User","site_admin":false},"body":"This PR refactors the ping (renamed to prefetch) functionality into a saga. Before, the prefetching was triggered after each rendering, whereas now, a standalone saga triggers the prefetching whenever the flycam was changed (position/rotation/zoom). The saga is throttled using the same throttle interval that was used to throttle the pinging before.\r\nI've cleaned up other stuff while I was on it. One does get kind of \"blind\" during such a refactoring, because there's so much to fix, so if you have any other recommendations, please tell me and I'll incorporate them :)\r\n\r\nFun Performance/Memory Findings: During refactoring I noticed that there was a bug in the arbitary ping implementation, which caused prefetched buckets to always be in zoomstep 0. I fixed this and a simple test (20s of tracing in zoomstep > 0 in flight mode) showed that webknossos now downloads 20% less buckets :)\r\nAlso, the arbitraryPing used to be executed every single time the arbitrary view was rendered, even when no flycam property changed, which incurred quite a bit of processing overhead -> now a thing of the past :)\r\n\r\n### ToDo:\r\n  - [x] Add unit tests for prefetch_saga\r\n  - Data is only prefetched after the first flycam action, should be triggered once initially - _Actually I don't think this is needed, once the user starts to move the prefetching starts (makes more sense anyways as we then know the movement direction)_\r\n\r\n### URL of deployed dev instance (used for testing):\r\n- `http://___.webknossos.xyz`\r\n\r\n### Steps to test:\r\n- Fly through the dataset, data should be prefetched and you should not need to wait for data to load during tracing\r\n\r\n### Issues:\r\n- part of #2601\r\n\r\n------\r\n- [x] Ready for review\r\n","created_at":"2018-06-05T21:48:16Z","updated_at":"2018-06-07T15:31:50Z","closed_at":"2018-06-07T15:31:49Z","merged_at":"2018-06-07T15:31:49Z","merge_commit_sha":"d80f1356d1492cfbc99ce644334f20dc4a28dad6","assignee":{"login":"daniel-wer","id":1702075,"node_id":"MDQ6VXNlcjE3MDIwNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1702075?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-wer","html_url":"https://github.com/daniel-wer","followers_url":"https://api.github.com/users/daniel-wer/followers","following_url":"https://api.github.com/users/daniel-wer/following{/other_user}","gists_url":"https://api.github.com/users/daniel-wer/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-wer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-wer/subscriptions","organizations_url":"https://api.github.com/users/daniel-wer/orgs","repos_url":"https://api.github.com/users/daniel-wer/repos","events_url":"https://api.github.com/users/daniel-wer/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-wer/received_events","type":"User","site_admin":false},"assignees":[{"login":"daniel-wer","id":1702075,"node_id":"MDQ6VXNlcjE3MDIwNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1702075?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-wer","html_url":"https://github.com/daniel-wer","followers_url":"https://api.github.com/users/daniel-wer/followers","following_url":"https://api.github.com/users/daniel-wer/following{/other_user}","gists_url":"https://api.github.com/users/daniel-wer/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-wer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-wer/subscriptions","organizations_url":"https://api.github.com/users/daniel-wer/orgs","repos_url":"https://api.github.com/users/daniel-wer/repos","events_url":"https://api.github.com/users/daniel-wer/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-wer/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":60646770,"node_id":"MDU6TGFiZWw2MDY0Njc3MA==","url":"https://api.github.com/repos/scalableminds/webknossos/labels/frontend","name":"frontend","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/scalableminds/webknossos/pulls/2687/commits","review_comments_url":"https://api.github.com/repos/scalableminds/webknossos/pulls/2687/comments","review_comment_url":"https://api.github.com/repos/scalableminds/webknossos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalableminds/webknossos/issues/2687/comments","statuses_url":"https://api.github.com/repos/scalableminds/webknossos/statuses/42bc893c46935e94223db51fa5f86218a925a6cf","head":{"label":"scalableminds:refactor-ping","ref":"refactor-ping","sha":"42bc893c46935e94223db51fa5f86218a925a6cf","user":{"login":"scalableminds","id":1648557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg1NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1648557?v=4","gravatar_id":"","url":"https://api.github.com/users/scalableminds","html_url":"https://github.com/scalableminds","followers_url":"https://api.github.com/users/scalableminds/followers","following_url":"https://api.github.com/users/scalableminds/following{/other_user}","gists_url":"https://api.github.com/users/scalableminds/gists{/gist_id}","starred_url":"https://api.github.com/users/scalableminds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalableminds/subscriptions","organizations_url":"https://api.github.com/users/scalableminds/orgs","repos_url":"https://api.github.com/users/scalableminds/repos","events_url":"https://api.github.com/users/scalableminds/events{/privacy}","received_events_url":"https://api.github.com/users/scalableminds/received_events","type":"Organization","site_admin":false},"repo":{"id":4326197,"node_id":"MDEwOlJlcG9zaXRvcnk0MzI2MTk3","name":"webknossos","full_name":"scalableminds/webknossos","owner":{"login":"scalableminds","id":1648557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg1NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1648557?v=4","gravatar_id":"","url":"https://api.github.com/users/scalableminds","html_url":"https://github.com/scalableminds","followers_url":"https://api.github.com/users/scalableminds/followers","following_url":"https://api.github.com/users/scalableminds/following{/other_user}","gists_url":"https://api.github.com/users/scalableminds/gists{/gist_id}","starred_url":"https://api.github.com/users/scalableminds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalableminds/subscriptions","organizations_url":"https://api.github.com/users/scalableminds/orgs","repos_url":"https://api.github.com/users/scalableminds/repos","events_url":"https://api.github.com/users/scalableminds/events{/privacy}","received_events_url":"https://api.github.com/users/scalableminds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalableminds/webknossos","description":"A fully cloud- and browser-based 3D annotation tool for distributed large-scale data analysis in light- and electron-microscopy based Connectomics","fork":false,"url":"https://api.github.com/repos/scalableminds/webknossos","forks_url":"https://api.github.com/repos/scalableminds/webknossos/forks","keys_url":"https://api.github.com/repos/scalableminds/webknossos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalableminds/webknossos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalableminds/webknossos/teams","hooks_url":"https://api.github.com/repos/scalableminds/webknossos/hooks","issue_events_url":"https://api.github.com/repos/scalableminds/webknossos/issues/events{/number}","events_url":"https://api.github.com/repos/scalableminds/webknossos/events","assignees_url":"https://api.github.com/repos/scalableminds/webknossos/assignees{/user}","branches_url":"https://api.github.com/repos/scalableminds/webknossos/branches{/branch}","tags_url":"https://api.github.com/repos/scalableminds/webknossos/tags","blobs_url":"https://api.github.com/repos/scalableminds/webknossos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalableminds/webknossos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalableminds/webknossos/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalableminds/webknossos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalableminds/webknossos/statuses/{sha}","languages_url":"https://api.github.com/repos/scalableminds/webknossos/languages","stargazers_url":"https://api.github.com/repos/scalableminds/webknossos/stargazers","contributors_url":"https://api.github.com/repos/scalableminds/webknossos/contributors","subscribers_url":"https://api.github.com/repos/scalableminds/webknossos/subscribers","subscription_url":"https://api.github.com/repos/scalableminds/webknossos/subscription","commits_url":"https://api.github.com/repos/scalableminds/webknossos/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalableminds/webknossos/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalableminds/webknossos/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalableminds/webknossos/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalableminds/webknossos/contents/{+path}","compare_url":"https://api.github.com/repos/scalableminds/webknossos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalableminds/webknossos/merges","archive_url":"https://api.github.com/repos/scalableminds/webknossos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalableminds/webknossos/downloads","issues_url":"https://api.github.com/repos/scalableminds/webknossos/issues{/number}","pulls_url":"https://api.github.com/repos/scalableminds/webknossos/pulls{/number}","milestones_url":"https://api.github.com/repos/scalableminds/webknossos/milestones{/number}","notifications_url":"https://api.github.com/repos/scalableminds/webknossos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalableminds/webknossos/labels{/name}","releases_url":"https://api.github.com/repos/scalableminds/webknossos/releases{/id}","deployments_url":"https://api.github.com/repos/scalableminds/webknossos/deployments","created_at":"2012-05-14T16:26:17Z","updated_at":"2018-06-07T15:13:54Z","pushed_at":"2018-06-07T15:31:49Z","git_url":"git://github.com/scalableminds/webknossos.git","ssh_url":"git@github.com:scalableminds/webknossos.git","clone_url":"https://github.com/scalableminds/webknossos.git","svn_url":"https://github.com/scalableminds/webknossos","homepage":"https://webknossos.org/","size":94361,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":3,"open_issues":91,"watchers":20,"default_branch":"master"}},"base":{"label":"scalableminds:refactor-model-base-2","ref":"refactor-model-base-2","sha":"d73d35e3bae22970bf2b0484e5f3191e1c8b323f","user":{"login":"scalableminds","id":1648557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg1NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1648557?v=4","gravatar_id":"","url":"https://api.github.com/users/scalableminds","html_url":"https://github.com/scalableminds","followers_url":"https://api.github.com/users/scalableminds/followers","following_url":"https://api.github.com/users/scalableminds/following{/other_user}","gists_url":"https://api.github.com/users/scalableminds/gists{/gist_id}","starred_url":"https://api.github.com/users/scalableminds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalableminds/subscriptions","organizations_url":"https://api.github.com/users/scalableminds/orgs","repos_url":"https://api.github.com/users/scalableminds/repos","events_url":"https://api.github.com/users/scalableminds/events{/privacy}","received_events_url":"https://api.github.com/users/scalableminds/received_events","type":"Organization","site_admin":false},"repo":{"id":4326197,"node_id":"MDEwOlJlcG9zaXRvcnk0MzI2MTk3","name":"webknossos","full_name":"scalableminds/webknossos","owner":{"login":"scalableminds","id":1648557,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDg1NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1648557?v=4","gravatar_id":"","url":"https://api.github.com/users/scalableminds","html_url":"https://github.com/scalableminds","followers_url":"https://api.github.com/users/scalableminds/followers","following_url":"https://api.github.com/users/scalableminds/following{/other_user}","gists_url":"https://api.github.com/users/scalableminds/gists{/gist_id}","starred_url":"https://api.github.com/users/scalableminds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalableminds/subscriptions","organizations_url":"https://api.github.com/users/scalableminds/orgs","repos_url":"https://api.github.com/users/scalableminds/repos","events_url":"https://api.github.com/users/scalableminds/events{/privacy}","received_events_url":"https://api.github.com/users/scalableminds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalableminds/webknossos","description":"A fully cloud- and browser-based 3D annotation tool for distributed large-scale data analysis in light- and electron-microscopy based Connectomics","fork":false,"url":"https://api.github.com/repos/scalableminds/webknossos","forks_url":"https://api.github.com/repos/scalableminds/webknossos/forks","keys_url":"https://api.github.com/repos/scalableminds/webknossos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalableminds/webknossos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalableminds/webknossos/teams","hooks_url":"https://api.github.com/repos/scalableminds/webknossos/hooks","issue_events_url":"https://api.github.com/repos/scalableminds/webknossos/issues/events{/number}","events_url":"https://api.github.com/repos/scalableminds/webknossos/events","assignees_url":"https://api.github.com/repos/scalableminds/webknossos/assignees{/user}","branches_url":"https://api.github.com/repos/scalableminds/webknossos/branches{/branch}","tags_url":"https://api.github.com/repos/scalableminds/webknossos/tags","blobs_url":"https://api.github.com/repos/scalableminds/webknossos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalableminds/webknossos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalableminds/webknossos/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalableminds/webknossos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalableminds/webknossos/statuses/{sha}","languages_url":"https://api.github.com/repos/scalableminds/webknossos/languages","stargazers_url":"https://api.github.com/repos/scalableminds/webknossos/stargazers","contributors_url":"https://api.github.com/repos/scalableminds/webknossos/contributors","subscribers_url":"https://api.github.com/repos/scalableminds/webknossos/subscribers","subscription_url":"https://api.github.com/repos/scalableminds/webknossos/subscription","commits_url":"https://api.github.com/repos/scalableminds/webknossos/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalableminds/webknossos/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalableminds/webknossos/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalableminds/webknossos/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalableminds/webknossos/contents/{+path}","compare_url":"https://api.github.com/repos/scalableminds/webknossos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalableminds/webknossos/merges","archive_url":"https://api.github.com/repos/scalableminds/webknossos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalableminds/webknossos/downloads","issues_url":"https://api.github.com/repos/scalableminds/webknossos/issues{/number}","pulls_url":"https://api.github.com/repos/scalableminds/webknossos/pulls{/number}","milestones_url":"https://api.github.com/repos/scalableminds/webknossos/milestones{/number}","notifications_url":"https://api.github.com/repos/scalableminds/webknossos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalableminds/webknossos/labels{/name}","releases_url":"https://api.github.com/repos/scalableminds/webknossos/releases{/id}","deployments_url":"https://api.github.com/repos/scalableminds/webknossos/deployments","created_at":"2012-05-14T16:26:17Z","updated_at":"2018-06-07T15:13:54Z","pushed_at":"2018-06-07T15:31:49Z","git_url":"git://github.com/scalableminds/webknossos.git","ssh_url":"git@github.com:scalableminds/webknossos.git","clone_url":"https://github.com/scalableminds/webknossos.git","svn_url":"https://github.com/scalableminds/webknossos","homepage":"https://webknossos.org/","size":94361,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":3,"open_issues":91,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalableminds/webknossos/pulls/2687"},"html":{"href":"https://github.com/scalableminds/webknossos/pull/2687"},"issue":{"href":"https://api.github.com/repos/scalableminds/webknossos/issues/2687"},"comments":{"href":"https://api.github.com/repos/scalableminds/webknossos/issues/2687/comments"},"review_comments":{"href":"https://api.github.com/repos/scalableminds/webknossos/pulls/2687/comments"},"review_comment":{"href":"https://api.github.com/repos/scalableminds/webknossos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalableminds/webknossos/pulls/2687/commits"},"statuses":{"href":"https://api.github.com/repos/scalableminds/webknossos/statuses/42bc893c46935e94223db51fa5f86218a925a6cf"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"daniel-wer","id":1702075,"node_id":"MDQ6VXNlcjE3MDIwNzU=","avatar_url":"https://avatars3.githubusercontent.com/u/1702075?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-wer","html_url":"https://github.com/daniel-wer","followers_url":"https://api.github.com/users/daniel-wer/followers","following_url":"https://api.github.com/users/daniel-wer/following{/other_user}","gists_url":"https://api.github.com/users/daniel-wer/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-wer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-wer/subscriptions","organizations_url":"https://api.github.com/users/daniel-wer/orgs","repos_url":"https://api.github.com/users/daniel-wer/repos","events_url":"https://api.github.com/users/daniel-wer/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-wer/received_events","type":"User","site_admin":false},"comments":3,"review_comments":4,"maintainer_can_modify":false,"commits":6,"additions":281,"deletions":203,"changed_files":14}}
{"actor":{"display_login":"daniel-wer"}}