{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corefxlab/issues/2458","repository_url":"https://api.github.com/repos/dotnet/corefxlab","labels_url":"https://api.github.com/repos/dotnet/corefxlab/issues/2458/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corefxlab/issues/2458/comments","events_url":"https://api.github.com/repos/dotnet/corefxlab/issues/2458/events","html_url":"https://github.com/dotnet/corefxlab/pull/2458","id":354928627,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTc3NzQ1","number":2458,"title":"DictionarySlim","user":{"login":"AnthonyLloyd","id":9265702,"node_id":"MDQ6VXNlcjkyNjU3MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/9265702?v=4","gravatar_id":"","url":"https://api.github.com/users/AnthonyLloyd","html_url":"https://github.com/AnthonyLloyd","followers_url":"https://api.github.com/users/AnthonyLloyd/followers","following_url":"https://api.github.com/users/AnthonyLloyd/following{/other_user}","gists_url":"https://api.github.com/users/AnthonyLloyd/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonyLloyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonyLloyd/subscriptions","organizations_url":"https://api.github.com/users/AnthonyLloyd/orgs","repos_url":"https://api.github.com/users/AnthonyLloyd/repos","events_url":"https://api.github.com/users/AnthonyLloyd/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonyLloyd/received_events","type":"User","site_admin":false},"labels":[{"id":279193354,"node_id":"MDU6TGFiZWwyNzkxOTMzNTQ=","url":"https://api.github.com/repos/dotnet/corefxlab/labels/area-System.Collections","name":"area-System.Collections","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"safern","id":22899328,"node_id":"MDQ6VXNlcjIyODk5MzI4","avatar_url":"https://avatars1.githubusercontent.com/u/22899328?v=4","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false},"assignees":[{"login":"safern","id":22899328,"node_id":"MDQ6VXNlcjIyODk5MzI4","avatar_url":"https://avatars1.githubusercontent.com/u/22899328?v=4","gravatar_id":"","url":"https://api.github.com/users/safern","html_url":"https://github.com/safern","followers_url":"https://api.github.com/users/safern/followers","following_url":"https://api.github.com/users/safern/following{/other_user}","gists_url":"https://api.github.com/users/safern/gists{/gist_id}","starred_url":"https://api.github.com/users/safern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safern/subscriptions","organizations_url":"https://api.github.com/users/safern/orgs","repos_url":"https://api.github.com/users/safern/repos","events_url":"https://api.github.com/users/safern/events{/privacy}","received_events_url":"https://api.github.com/users/safern/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corefxlab/milestones/3","html_url":"https://github.com/dotnet/corefxlab/milestone/3","labels_url":"https://api.github.com/repos/dotnet/corefxlab/milestones/3/labels","id":2328180,"node_id":"MDk6TWlsZXN0b25lMjMyODE4MA==","number":3,"title":"Future","description":"Milestone tracking the issues triaged for an unspecified future release","creator":{"login":"joshfree","id":1302850,"node_id":"MDQ6VXNlcjEzMDI4NTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1302850?v=4","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":138,"closed_issues":42,"state":"open","created_at":"2017-02-16T18:27:23Z","updated_at":"2018-10-10T23:06:52Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2018-08-28T22:32:37Z","updated_at":"2018-11-04T00:53:30Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/dotnet/corefxlab/pulls/2458","html_url":"https://github.com/dotnet/corefxlab/pull/2458","diff_url":"https://github.com/dotnet/corefxlab/pull/2458.diff","patch_url":"https://github.com/dotnet/corefxlab/pull/2458.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/dotnet/corefxlab/issues/comments/435632879","html_url":"https://github.com/dotnet/corefxlab/pull/2458#issuecomment-435632879","issue_url":"https://api.github.com/repos/dotnet/corefxlab/issues/2458","id":435632879,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTYzMjg3OQ==","user":{"login":"danmosemsft","id":6385855,"node_id":"MDQ6VXNlcjYzODU4NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/6385855?v=4","gravatar_id":"","url":"https://api.github.com/users/danmosemsft","html_url":"https://github.com/danmosemsft","followers_url":"https://api.github.com/users/danmosemsft/followers","following_url":"https://api.github.com/users/danmosemsft/following{/other_user}","gists_url":"https://api.github.com/users/danmosemsft/gists{/gist_id}","starred_url":"https://api.github.com/users/danmosemsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmosemsft/subscriptions","organizations_url":"https://api.github.com/users/danmosemsft/orgs","repos_url":"https://api.github.com/users/danmosemsft/repos","events_url":"https://api.github.com/users/danmosemsft/events{/privacy}","received_events_url":"https://api.github.com/users/danmosemsft/received_events","type":"User","site_admin":false},"created_at":"2018-11-04T00:53:30Z","updated_at":"2018-11-04T00:53:30Z","author_association":"MEMBER","body":"I ran your perf tests on the Q6600 (same hardware as benchmark machine). I included 25_000_000 like the benchmark. I didn't attempt to reproduce their actual number, I'm assuming the ratios are reliable though.\r\n\r\nBenchmarkDotNet=v0.11.1, OS=ubuntu 18.04\r\nIntel Core2 Quad CPU Q6600 2.40GHz, 1 CPU, 4 logical and 4 physical cores\r\n.NET Core SDK=2.1.401\r\n  [Host]     : .NET Core 2.1.3 (CoreCLR 4.6.26725.06, CoreFX 4.6.26725.05), 64bit RyuJIT\r\n  DefaultJob : .NET Core 2.1.3 (CoreCLR 4.6.26725.06, CoreFX 4.6.26725.05), 64bit RyuJIT\r\n\r\n\r\n|        Method |     Size |        Mean |      Error |     StdDev |      Median | Scaled | ScaledSD |\r\n|-------------- |--------- |------------:|-----------:|-----------:|------------:|-------:|---------:|\r\n|          Hack |   250000 |    156.5 ms |   3.005 ms |   4.309 ms |    155.9 ms |   0.70 |     0.04 |\r\n|    Dictionary |   250000 |    223.5 ms |   4.441 ms |  11.931 ms |    220.2 ms |   1.00 |     0.00 |\r\n| RefDictionary |   250000 |    137.4 ms |   3.025 ms |   6.041 ms |    137.2 ms |   0.62 |     0.04 |\r\n|               |          |             |            |            |             |        |          |\r\n|          Hack |  2500000 |    983.5 ms |  19.690 ms |  58.056 ms |    973.5 ms |   0.71 |     0.07 |\r\n|    Dictionary |  2500000 |  1,399.2 ms |  33.559 ms |  98.948 ms |  1,421.8 ms |   1.00 |     0.00 |\r\n| RefDictionary |  2500000 |    711.6 ms |  18.466 ms |  54.448 ms |    688.8 ms |   0.51 |     0.05 |\r\n|               |          |             |            |            |             |        |          |\r\n|          Hack | 25000000 |  9,360.5 ms | 185.271 ms | 461.390 ms |  9,319.8 ms |   0.65 |     0.04 |\r\n|    Dictionary | 25000000 | 14,424.8 ms | 272.597 ms | 382.143 ms | 14,481.2 ms |   1.00 |     0.00 |\r\n| RefDictionary | 25000000 |  6,774.3 ms | 170.427 ms | 502.509 ms |  6,619.8 ms |   0.47 |     0.04 |\r\n\r\n[Here is all the data](https://gist.github.com/danmosemsft/73d62cbf5f94eb0e1c0f89a9ba34a208)\r\n\r\nNote this was before your commit that changed the table to prime size and initial 11 size.\r\n\r\nIt looks like `Hack` is `C# .NET Core #8` which is currently 9.23 - not far off the 9.36 above. By ratio, `RefDictionary` would be 6.68. Which is better, but I see you have a `C# .NET Core #9` which is `#8` changed to use raw pointers and it's 5.58. Am I following correctly, that `#8` would still be faster than this `DictionarySlim` ? \r\n--\r\n\r\n\r\n"}}
{"actor":{"display_login":"danmosemsft"}}