{"action":"opened","number":5872,"pull_request":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/5872","id":237903379,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3OTAzMzc5","html_url":"https://github.com/vuetifyjs/vuetify/pull/5872","diff_url":"https://github.com/vuetifyjs/vuetify/pull/5872.diff","patch_url":"https://github.com/vuetifyjs/vuetify/pull/5872.patch","issue_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/5872","number":5872,"state":"open","locked":false,"title":"fix(VMenu): prevent scroll on keydown","user":{"login":"johnleider","id":9064066,"node_id":"MDQ6VXNlcjkwNjQwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/9064066?v=4","gravatar_id":"","url":"https://api.github.com/users/johnleider","html_url":"https://github.com/johnleider","followers_url":"https://api.github.com/users/johnleider/followers","following_url":"https://api.github.com/users/johnleider/following{/other_user}","gists_url":"https://api.github.com/users/johnleider/gists{/gist_id}","starred_url":"https://api.github.com/users/johnleider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnleider/subscriptions","organizations_url":"https://api.github.com/users/johnleider/orgs","repos_url":"https://api.github.com/users/johnleider/repos","events_url":"https://api.github.com/users/johnleider/events{/privacy}","received_events_url":"https://api.github.com/users/johnleider/received_events","type":"User","site_admin":false},"body":"fixes #5714\r\n<!--\r\nMAKE SURE TO READ THE CONTRIBUTING GUIDE BEFORE CREATING A PR\r\nhttps://github.com/vuetifyjs/vuetify/blob/master/.github/CONTRIBUTING.md\r\n\r\nTesting and markup sections can be removed for documentation changes\r\n-->\r\n\r\n<!-- Provide a general summary of your changes in the Title above -->\r\n<!-- Keep the title short and descriptive, as it will be used as a commit message -->\r\n\r\n## Description\r\nmove preventDefault invocation to more appropriate location\r\n<!--- Describe your changes in detail -->\r\n\r\n## Motivation and Context\r\nSince v1.2 selects have maintained control over keydown. Move default prevent to **changeListIndex** as it is always called when pertaining to keyboard navigation in menus.\r\n\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n## How Has This Been Tested?\r\njest\r\n<!--- Please describe how you tested your changes. -->\r\n<!--- Have you created new tests or updated existing ones? -->\r\n<!--- e.g. unit | visually | e2e | none -->\r\n\r\n## Markup:\r\n<!--- Paste markup for testing your change --->\r\n<details>\r\n\r\n```vue\r\n// Paste your FULL Playground.vue here\r\n<template>\r\n  <div id=\"app\" style=\"min-height: 400vh;\">\r\n  <v-app id=\"inspire\">\r\n    <v-card>\r\n      <v-container\r\n        fluid\r\n        grid-list-xl\r\n      >\r\n        <v-layout\r\n          align-center\r\n          wrap\r\n        >\r\n          <v-flex xs12 sm6>\r\n            <v-select\r\n              v-model=\"value\"\r\n              :items=\"items\"\r\n              attach\r\n              chips\r\n              label=\"Chips\"\r\n              multiple\r\n            ></v-select>\r\n          </v-flex>\r\n          <v-flex xs12 sm6>\r\n            <v-select\r\n              v-model=\"value\"\r\n              :items=\"items\"\r\n              box\r\n              chips\r\n              label=\"Chips\"\r\n              multiple\r\n            ></v-select>\r\n          </v-flex>\r\n          <v-flex xs12 sm6>\r\n            <v-select\r\n              v-model=\"value\"\r\n              :items=\"items\"\r\n              chips\r\n              label=\"Chips\"\r\n              multiple\r\n              outline\r\n            ></v-select>\r\n          </v-flex>\r\n          <v-flex xs12 sm6>\r\n            <v-select\r\n              v-model=\"value\"\r\n              :items=\"items\"\r\n              chips\r\n              label=\"Chips\"\r\n              multiple\r\n              solo\r\n            ></v-select>\r\n          </v-flex>\r\n        </v-layout>\r\n      </v-container>\r\n    </v-card>\r\n  </v-app>\r\n</div>\r\n</template>\r\n\r\n<script>\r\nexport default {\r\n  data: () => ({\r\n    items: ['foo', 'bar', 'fizz', 'buzz'],\r\n    value: ['foo', 'bar', 'fizz', 'buzz']\r\n  })\r\n}\r\n</script>\r\n```\r\n</details>\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] The PR title is no longer than 64 characters.\r\n- [x] The PR is submitted to the correct branch (`master` for bug fixes and documentation updates, `dev` for new features and breaking changes).\r\n- [x] My code follows the code style of this project.\r\n- [ ] I've added relevant changes to the documentation (applies to new features and breaking changes in core library) \r\n","created_at":"2018-12-12T03:44:08Z","updated_at":"2018-12-12T03:44:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"johnleider","id":9064066,"node_id":"MDQ6VXNlcjkwNjQwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/9064066?v=4","gravatar_id":"","url":"https://api.github.com/users/johnleider","html_url":"https://github.com/johnleider","followers_url":"https://api.github.com/users/johnleider/followers","following_url":"https://api.github.com/users/johnleider/following{/other_user}","gists_url":"https://api.github.com/users/johnleider/gists{/gist_id}","starred_url":"https://api.github.com/users/johnleider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnleider/subscriptions","organizations_url":"https://api.github.com/users/johnleider/orgs","repos_url":"https://api.github.com/users/johnleider/repos","events_url":"https://api.github.com/users/johnleider/events{/privacy}","received_events_url":"https://api.github.com/users/johnleider/received_events","type":"User","site_admin":false},"assignees":[{"login":"johnleider","id":9064066,"node_id":"MDQ6VXNlcjkwNjQwNjY=","avatar_url":"https://avatars3.githubusercontent.com/u/9064066?v=4","gravatar_id":"","url":"https://api.github.com/users/johnleider","html_url":"https://github.com/johnleider","followers_url":"https://api.github.com/users/johnleider/followers","following_url":"https://api.github.com/users/johnleider/following{/other_user}","gists_url":"https://api.github.com/users/johnleider/gists{/gist_id}","starred_url":"https://api.github.com/users/johnleider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnleider/subscriptions","organizations_url":"https://api.github.com/users/johnleider/orgs","repos_url":"https://api.github.com/users/johnleider/repos","events_url":"https://api.github.com/users/johnleider/events{/privacy}","received_events_url":"https://api.github.com/users/johnleider/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":440781591,"node_id":"MDU6TGFiZWw0NDA3ODE1OTE=","url":"https://api.github.com/repos/vuetifyjs/vuetify/labels/T:%20bug","name":"T: bug","color":"ee0701","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/5872/commits","review_comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/5872/comments","review_comment_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/5872/comments","statuses_url":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/4f2d2499f54ab611c418b2a48f1fd1c87aeeee50","head":{"label":"vuetifyjs:fix/5714-menu-arrow-keys-page-scroll","ref":"fix/5714-menu-arrow-keys-page-scroll","sha":"4f2d2499f54ab611c418b2a48f1fd1c87aeeee50","user":{"login":"vuetifyjs","id":22138497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTM4NDk3","avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67962648,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzk2MjY0OA==","name":"vuetify","full_name":"vuetifyjs/vuetify","private":false,"owner":{"login":"vuetifyjs","id":22138497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTM4NDk3","avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vuetifyjs/vuetify","description":"🐲 Material Component Framework for Vue.js 2","fork":false,"url":"https://api.github.com/repos/vuetifyjs/vuetify","forks_url":"https://api.github.com/repos/vuetifyjs/vuetify/forks","keys_url":"https://api.github.com/repos/vuetifyjs/vuetify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuetifyjs/vuetify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuetifyjs/vuetify/teams","hooks_url":"https://api.github.com/repos/vuetifyjs/vuetify/hooks","issue_events_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/events{/number}","events_url":"https://api.github.com/repos/vuetifyjs/vuetify/events","assignees_url":"https://api.github.com/repos/vuetifyjs/vuetify/assignees{/user}","branches_url":"https://api.github.com/repos/vuetifyjs/vuetify/branches{/branch}","tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/tags","blobs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/{sha}","languages_url":"https://api.github.com/repos/vuetifyjs/vuetify/languages","stargazers_url":"https://api.github.com/repos/vuetifyjs/vuetify/stargazers","contributors_url":"https://api.github.com/repos/vuetifyjs/vuetify/contributors","subscribers_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscribers","subscription_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscription","commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuetifyjs/vuetify/contents/{+path}","compare_url":"https://api.github.com/repos/vuetifyjs/vuetify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuetifyjs/vuetify/merges","archive_url":"https://api.github.com/repos/vuetifyjs/vuetify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuetifyjs/vuetify/downloads","issues_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues{/number}","pulls_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls{/number}","milestones_url":"https://api.github.com/repos/vuetifyjs/vuetify/milestones{/number}","notifications_url":"https://api.github.com/repos/vuetifyjs/vuetify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuetifyjs/vuetify/labels{/name}","releases_url":"https://api.github.com/repos/vuetifyjs/vuetify/releases{/id}","deployments_url":"https://api.github.com/repos/vuetifyjs/vuetify/deployments","created_at":"2016-09-12T00:39:35Z","updated_at":"2018-12-12T03:35:44Z","pushed_at":"2018-12-12T03:44:03Z","git_url":"git://github.com/vuetifyjs/vuetify.git","ssh_url":"git@github.com:vuetifyjs/vuetify.git","clone_url":"https://github.com/vuetifyjs/vuetify.git","svn_url":"https://github.com/vuetifyjs/vuetify","homepage":"https://vuetifyjs.com","size":42199,"stargazers_count":15221,"watchers_count":15221,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1410,"mirror_url":null,"archived":false,"open_issues_count":584,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1410,"open_issues":584,"watchers":15221,"default_branch":"master"}},"base":{"label":"vuetifyjs:master","ref":"master","sha":"8a2a1a1b6974ec264e974866b0775f2820dc3503","user":{"login":"vuetifyjs","id":22138497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTM4NDk3","avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67962648,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzk2MjY0OA==","name":"vuetify","full_name":"vuetifyjs/vuetify","private":false,"owner":{"login":"vuetifyjs","id":22138497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTM4NDk3","avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vuetifyjs/vuetify","description":"🐲 Material Component Framework for Vue.js 2","fork":false,"url":"https://api.github.com/repos/vuetifyjs/vuetify","forks_url":"https://api.github.com/repos/vuetifyjs/vuetify/forks","keys_url":"https://api.github.com/repos/vuetifyjs/vuetify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuetifyjs/vuetify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuetifyjs/vuetify/teams","hooks_url":"https://api.github.com/repos/vuetifyjs/vuetify/hooks","issue_events_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/events{/number}","events_url":"https://api.github.com/repos/vuetifyjs/vuetify/events","assignees_url":"https://api.github.com/repos/vuetifyjs/vuetify/assignees{/user}","branches_url":"https://api.github.com/repos/vuetifyjs/vuetify/branches{/branch}","tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/tags","blobs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/{sha}","languages_url":"https://api.github.com/repos/vuetifyjs/vuetify/languages","stargazers_url":"https://api.github.com/repos/vuetifyjs/vuetify/stargazers","contributors_url":"https://api.github.com/repos/vuetifyjs/vuetify/contributors","subscribers_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscribers","subscription_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscription","commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuetifyjs/vuetify/contents/{+path}","compare_url":"https://api.github.com/repos/vuetifyjs/vuetify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuetifyjs/vuetify/merges","archive_url":"https://api.github.com/repos/vuetifyjs/vuetify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuetifyjs/vuetify/downloads","issues_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues{/number}","pulls_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls{/number}","milestones_url":"https://api.github.com/repos/vuetifyjs/vuetify/milestones{/number}","notifications_url":"https://api.github.com/repos/vuetifyjs/vuetify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuetifyjs/vuetify/labels{/name}","releases_url":"https://api.github.com/repos/vuetifyjs/vuetify/releases{/id}","deployments_url":"https://api.github.com/repos/vuetifyjs/vuetify/deployments","created_at":"2016-09-12T00:39:35Z","updated_at":"2018-12-12T03:35:44Z","pushed_at":"2018-12-12T03:44:03Z","git_url":"git://github.com/vuetifyjs/vuetify.git","ssh_url":"git@github.com:vuetifyjs/vuetify.git","clone_url":"https://github.com/vuetifyjs/vuetify.git","svn_url":"https://github.com/vuetifyjs/vuetify","homepage":"https://vuetifyjs.com","size":42199,"stargazers_count":15221,"watchers_count":15221,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1410,"mirror_url":null,"archived":false,"open_issues_count":584,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1410,"open_issues":584,"watchers":15221,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/5872"},"html":{"href":"https://github.com/vuetifyjs/vuetify/pull/5872"},"issue":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/issues/5872"},"comments":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/issues/5872/comments"},"review_comments":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/5872/comments"},"review_comment":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/5872/commits"},"statuses":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/4f2d2499f54ab611c418b2a48f1fd1c87aeeee50"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":13,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"johnleider"}}