{"action":"created","issue":{"url":"https://api.github.com/repos/geobretagne/mviewer/issues/72","repository_url":"https://api.github.com/repos/geobretagne/mviewer","labels_url":"https://api.github.com/repos/geobretagne/mviewer/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/geobretagne/mviewer/issues/72/comments","events_url":"https://api.github.com/repos/geobretagne/mviewer/issues/72/events","html_url":"https://github.com/geobretagne/mviewer/pull/72","id":296735383,"number":72,"title":"Geoloc, rotation and responsive","user":{"login":"SylvainMassol","id":19145908,"avatar_url":"https://avatars2.githubusercontent.com/u/19145908?v=4","gravatar_id":"","url":"https://api.github.com/users/SylvainMassol","html_url":"https://github.com/SylvainMassol","followers_url":"https://api.github.com/users/SylvainMassol/followers","following_url":"https://api.github.com/users/SylvainMassol/following{/other_user}","gists_url":"https://api.github.com/users/SylvainMassol/gists{/gist_id}","starred_url":"https://api.github.com/users/SylvainMassol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SylvainMassol/subscriptions","organizations_url":"https://api.github.com/users/SylvainMassol/orgs","repos_url":"https://api.github.com/users/SylvainMassol/repos","events_url":"https://api.github.com/users/SylvainMassol/events{/privacy}","received_events_url":"https://api.github.com/users/SylvainMassol/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-13T13:24:29Z","updated_at":"2018-02-13T13:45:02Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/geobretagne/mviewer/pulls/72","html_url":"https://github.com/geobretagne/mviewer/pull/72","diff_url":"https://github.com/geobretagne/mviewer/pull/72.diff","patch_url":"https://github.com/geobretagne/mviewer/pull/72.patch"},"body":"I retry to give a clean PR.\r\n=>Add option for rotate map\r\n=>Add option for geolocation (need https)\r\n=>Responsive top navbar search\r\n=>ToggleLegend hide if themes mini"},"comment":{"url":"https://api.github.com/repos/geobretagne/mviewer/issues/comments/365270531","html_url":"https://github.com/geobretagne/mviewer/pull/72#issuecomment-365270531","issue_url":"https://api.github.com/repos/geobretagne/mviewer/issues/72","id":365270531,"user":{"login":"bchartier","id":2361255,"avatar_url":"https://avatars3.githubusercontent.com/u/2361255?v=4","gravatar_id":"","url":"https://api.github.com/users/bchartier","html_url":"https://github.com/bchartier","followers_url":"https://api.github.com/users/bchartier/followers","following_url":"https://api.github.com/users/bchartier/following{/other_user}","gists_url":"https://api.github.com/users/bchartier/gists{/gist_id}","starred_url":"https://api.github.com/users/bchartier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bchartier/subscriptions","organizations_url":"https://api.github.com/users/bchartier/orgs","repos_url":"https://api.github.com/users/bchartier/repos","events_url":"https://api.github.com/users/bchartier/events{/privacy}","received_events_url":"https://api.github.com/users/bchartier/received_events","type":"User","site_admin":false},"created_at":"2018-02-13T13:45:02Z","updated_at":"2018-02-13T13:45:02Z","author_association":"CONTRIBUTOR","body":"Je ne suis pas le destinataire de cette question mais je donne mon avis car je suis également concerné...\r\n\r\nEn l'état actuel du projet, il vaut mieux désactiver les mises en forme automatique du code. Pour ma part, j'utilise Pycharm (je suis plutôt développeur Python). Il ne réalise aucune mise en forme du code particulière si on ne lui demande pas de le faire.\r\n\r\nCe serait pas mal qu'on nettoye le code effectivement car c'est vraiment pénible d'avoir des dizaines d'espace en fin de ligne par exemple, ou des mélanges d'espace et de tabulations pour l'indentation. Si on le fait il faudrait que les développeurs du projet utilise les mêmes règles : ne pas utiliser de tabulation mais uniquement des espaces et utiliser un nombre fixe d'espaces. Pour information il existe des règles adoptées par des communautés de développeurs. Au hasard : https://google.github.io/styleguide/jsguide.html\r\nPour l'indentation chez Google : https://google.github.io/styleguide/jsguide.html#formatting-block-indentation\r\n\r\nSi un nettoyage est fait il faudrait que ce soit un PR ou un commit spécifique."}}
{"actor":{"display_login":"bchartier"}}