{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/activity-stream/issues/4288","repository_url":"https://api.github.com/repos/mozilla/activity-stream","labels_url":"https://api.github.com/repos/mozilla/activity-stream/issues/4288/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/activity-stream/issues/4288/comments","events_url":"https://api.github.com/repos/mozilla/activity-stream/issues/4288/events","html_url":"https://github.com/mozilla/activity-stream/pull/4288","id":347958418,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDI1MzAz","number":4288,"title":"Fix Bug 1480518 - Replace default and frecent sites with @search when they match given URL pattern","user":{"login":"piatra","id":810040,"node_id":"MDQ6VXNlcjgxMDA0MA==","avatar_url":"https://avatars2.githubusercontent.com/u/810040?v=4","gravatar_id":"","url":"https://api.github.com/users/piatra","html_url":"https://github.com/piatra","followers_url":"https://api.github.com/users/piatra/followers","following_url":"https://api.github.com/users/piatra/following{/other_user}","gists_url":"https://api.github.com/users/piatra/gists{/gist_id}","starred_url":"https://api.github.com/users/piatra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piatra/subscriptions","organizations_url":"https://api.github.com/users/piatra/orgs","repos_url":"https://api.github.com/users/piatra/repos","events_url":"https://api.github.com/users/piatra/events{/privacy}","received_events_url":"https://api.github.com/users/piatra/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-06T14:54:55Z","updated_at":"2018-08-06T17:45:34Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/mozilla/activity-stream/pulls/4288","html_url":"https://github.com/mozilla/activity-stream/pull/4288","diff_url":"https://github.com/mozilla/activity-stream/pull/4288.diff","patch_url":"https://github.com/mozilla/activity-stream/pull/4288.patch"},"body":"\r\n<img width=\"121\" alt=\"grafik\" src=\"https://user-images.githubusercontent.com/810040/43724213-f585b220-9988-11e8-9e54-606f25d67c11.png\">\r\n<img width=\"122\" alt=\"grafik\" src=\"https://user-images.githubusercontent.com/810040/43724325-31a8cf30-9989-11e8-81cf-93d0894320ed.png\">\r\n<img width=\"132\" alt=\"grafik\" src=\"https://user-images.githubusercontent.com/810040/43724223-fa8da2c8-9988-11e8-97eb-cd5dd5069cbf.png\">\r\n\r\n\r\n\r\nThis will replace any default site that would show up in the topsites (and pin it to the first position) and any frecent website (no pinning or position change).\r\nIt adds a new action `FILL_SEARCH_TERM` that populates the location bar with the `@{search-provider}` key term.\r\n\r\nNot sure (not implemented) any context menu options: if you unpin a default topsite turned into search topsite it will revert your action and pin it back again.\r\n\r\nIf a frecent site is turned into a search site you can still see the origin url when you hover the tile \r\n<img width=\"498\" alt=\"screen shot 2018-08-06 at 16 48 36\" src=\"https://user-images.githubusercontent.com/810040/43723993-8416365a-9988-11e8-8b0c-c13338a852af.png\">\r\n\r\nNo icon (just the fallback text) and using the regular tippytop or high res icon as a small favicon."},"comment":{"url":"https://api.github.com/repos/mozilla/activity-stream/issues/comments/410791915","html_url":"https://github.com/mozilla/activity-stream/pull/4288#issuecomment-410791915","issue_url":"https://api.github.com/repos/mozilla/activity-stream/issues/4288","id":410791915,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDc5MTkxNQ==","user":{"login":"piatra","id":810040,"node_id":"MDQ6VXNlcjgxMDA0MA==","avatar_url":"https://avatars2.githubusercontent.com/u/810040?v=4","gravatar_id":"","url":"https://api.github.com/users/piatra","html_url":"https://github.com/piatra","followers_url":"https://api.github.com/users/piatra/followers","following_url":"https://api.github.com/users/piatra/following{/other_user}","gists_url":"https://api.github.com/users/piatra/gists{/gist_id}","starred_url":"https://api.github.com/users/piatra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piatra/subscriptions","organizations_url":"https://api.github.com/users/piatra/orgs","repos_url":"https://api.github.com/users/piatra/repos","events_url":"https://api.github.com/users/piatra/events{/privacy}","received_events_url":"https://api.github.com/users/piatra/received_events","type":"User","site_admin":false},"created_at":"2018-08-06T17:45:34Z","updated_at":"2018-08-06T17:45:34Z","author_association":"COLLABORATOR","body":"Just noticed this: the website url is google.com/photos so it fetches the photos icon. Right now it just uses whatever icon it would normally display for the Topsite but it should probably fetch the icon associated to the URL origin.\r\n<img width=\"130\" alt=\"grafik\" src=\"https://user-images.githubusercontent.com/810040/43732142-4c09f1ee-99a0-11e8-9a60-ef68f0d10863.png\">\r\n"}}
{"actor":{"display_login":"piatra"}}