{"action":"closed","number":1343,"pull_request":{"url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/pulls/1343","id":224336017,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MzM2MDE3","html_url":"https://github.com/whosonfirst-data/whosonfirst-data/pull/1343","diff_url":"https://github.com/whosonfirst-data/whosonfirst-data/pull/1343.diff","patch_url":"https://github.com/whosonfirst-data/whosonfirst-data/pull/1343.patch","issue_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/issues/1343","number":1343,"state":"closed","locked":false,"title":"France: Updated localadmin and locality records","user":{"login":"stepps00","id":18567700,"node_id":"MDQ6VXNlcjE4NTY3NzAw","avatar_url":"https://avatars3.githubusercontent.com/u/18567700?v=4","gravatar_id":"","url":"https://api.github.com/users/stepps00","html_url":"https://github.com/stepps00","followers_url":"https://api.github.com/users/stepps00/followers","following_url":"https://api.github.com/users/stepps00/following{/other_user}","gists_url":"https://api.github.com/users/stepps00/gists{/gist_id}","starred_url":"https://api.github.com/users/stepps00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stepps00/subscriptions","organizations_url":"https://api.github.com/users/stepps00/orgs","repos_url":"https://api.github.com/users/stepps00/repos","events_url":"https://api.github.com/users/stepps00/events{/privacy}","received_events_url":"https://api.github.com/users/stepps00/received_events","type":"User","site_admin":false},"body":"Fixes #1277.\r\nFixes #1351.\r\n\r\nUpdates to the locality and neighbourhood placetype in France.\r\n\r\n**Included changes:**\r\n\r\n- [x] Mark each `locality` and `localadmin` as **coterminous** with each other\r\n- [x] Change existing `locality` to use the same larger geom used for `localadmin` now\r\n- [x] Save existing `locality` polygons as alt geoms\r\n- [x] Retain locality **label centroids**\r\n- [x] Set **nav centroid** for `localadmin` to the **locality's** label centroid\r\n- [x] Mark `localadmin` as **hierarchy_label** = 0\r\n- [x] In places where there is `localadmin` coverage, but no `locality` coverage, create a **new** `locality` with the `localadmin` shape\r\n- [x] If there are extra existing `locality`s within the `localadmin` that don't share the name, then demote them to placetype `neighbourhood`.\r\n    - [x] Point geometries\r\n        - [x] Tag as `min_zoom` of 14.\r\n    - [x] Polygon geometries\r\n        - [x] Tag as `min_zoom` of 14.\r\n        - [x] Their geometry should still be cleaned up to not spill across the locality / localadmin boundaries as proposed in https://github.com/whosonfirst-data/whosonfirst-data/issues/1277#issuecomment-430400745, but limited in scope and we delete the orphaned no-name pieces.\r\n- [x] Validate all geometries (both new and old)\r\n- [x] Verify records in Paris, Lyon, and Marseille are correct (these three communes have \"special\" status)\r\n- [x] Update `lbl:` properties for Paris, Lyon, and Marseille\r\n- [x] Update `localadmin` \"Arrondissemont\" records in Paris, Lyon, and Marseille, supersede into `borough` records\r\n\r\n**To do:**\r\n\r\n- [x] QA changes to all records (ensure no gaps in coverage, all props are set correctly etc)\r\n- [x] PIP records","created_at":"2018-10-19T16:00:34Z","updated_at":"2018-11-01T05:44:21Z","closed_at":"2018-11-01T05:44:20Z","merged_at":"2018-11-01T05:44:20Z","merge_commit_sha":"f98e2c90121dcb6765a8343b056ea046420842c7","assignee":{"login":"stepps00","id":18567700,"node_id":"MDQ6VXNlcjE4NTY3NzAw","avatar_url":"https://avatars3.githubusercontent.com/u/18567700?v=4","gravatar_id":"","url":"https://api.github.com/users/stepps00","html_url":"https://github.com/stepps00","followers_url":"https://api.github.com/users/stepps00/followers","following_url":"https://api.github.com/users/stepps00/following{/other_user}","gists_url":"https://api.github.com/users/stepps00/gists{/gist_id}","starred_url":"https://api.github.com/users/stepps00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stepps00/subscriptions","organizations_url":"https://api.github.com/users/stepps00/orgs","repos_url":"https://api.github.com/users/stepps00/repos","events_url":"https://api.github.com/users/stepps00/events{/privacy}","received_events_url":"https://api.github.com/users/stepps00/received_events","type":"User","site_admin":false},"assignees":[{"login":"stepps00","id":18567700,"node_id":"MDQ6VXNlcjE4NTY3NzAw","avatar_url":"https://avatars3.githubusercontent.com/u/18567700?v=4","gravatar_id":"","url":"https://api.github.com/users/stepps00","html_url":"https://github.com/stepps00","followers_url":"https://api.github.com/users/stepps00/followers","following_url":"https://api.github.com/users/stepps00/following{/other_user}","gists_url":"https://api.github.com/users/stepps00/gists{/gist_id}","starred_url":"https://api.github.com/users/stepps00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stepps00/subscriptions","organizations_url":"https://api.github.com/users/stepps00/orgs","repos_url":"https://api.github.com/users/stepps00/repos","events_url":"https://api.github.com/users/stepps00/events{/privacy}","received_events_url":"https://api.github.com/users/stepps00/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/pulls/1343/commits","review_comments_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/pulls/1343/comments","review_comment_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/issues/1343/comments","statuses_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/statuses/13e95b0e7cb4d8806de8559afc9f9cf7a1bba674","head":{"label":"whosonfirst-data:stepps00/france-vis-a-vis","ref":"stepps00/france-vis-a-vis","sha":"13e95b0e7cb4d8806de8559afc9f9cf7a1bba674","user":{"login":"whosonfirst-data","id":16909145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTA5MTQ1","avatar_url":"https://avatars3.githubusercontent.com/u/16909145?v=4","gravatar_id":"","url":"https://api.github.com/users/whosonfirst-data","html_url":"https://github.com/whosonfirst-data","followers_url":"https://api.github.com/users/whosonfirst-data/followers","following_url":"https://api.github.com/users/whosonfirst-data/following{/other_user}","gists_url":"https://api.github.com/users/whosonfirst-data/gists{/gist_id}","starred_url":"https://api.github.com/users/whosonfirst-data/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whosonfirst-data/subscriptions","organizations_url":"https://api.github.com/users/whosonfirst-data/orgs","repos_url":"https://api.github.com/users/whosonfirst-data/repos","events_url":"https://api.github.com/users/whosonfirst-data/events{/privacy}","received_events_url":"https://api.github.com/users/whosonfirst-data/received_events","type":"Organization","site_admin":false},"repo":{"id":39277038,"node_id":"MDEwOlJlcG9zaXRvcnkzOTI3NzAzOA==","name":"whosonfirst-data","full_name":"whosonfirst-data/whosonfirst-data","private":false,"owner":{"login":"whosonfirst-data","id":16909145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTA5MTQ1","avatar_url":"https://avatars3.githubusercontent.com/u/16909145?v=4","gravatar_id":"","url":"https://api.github.com/users/whosonfirst-data","html_url":"https://github.com/whosonfirst-data","followers_url":"https://api.github.com/users/whosonfirst-data/followers","following_url":"https://api.github.com/users/whosonfirst-data/following{/other_user}","gists_url":"https://api.github.com/users/whosonfirst-data/gists{/gist_id}","starred_url":"https://api.github.com/users/whosonfirst-data/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whosonfirst-data/subscriptions","organizations_url":"https://api.github.com/users/whosonfirst-data/orgs","repos_url":"https://api.github.com/users/whosonfirst-data/repos","events_url":"https://api.github.com/users/whosonfirst-data/events{/privacy}","received_events_url":"https://api.github.com/users/whosonfirst-data/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/whosonfirst-data/whosonfirst-data","description":"Who's On First is a gazetteer of places.","fork":false,"url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data","forks_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/forks","keys_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/teams","hooks_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/hooks","issue_events_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/issues/events{/number}","events_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/events","assignees_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/assignees{/user}","branches_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/branches{/branch}","tags_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/tags","blobs_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/statuses/{sha}","languages_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/languages","stargazers_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/stargazers","contributors_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/contributors","subscribers_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/subscribers","subscription_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/subscription","commits_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/contents/{+path}","compare_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/merges","archive_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/downloads","issues_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/issues{/number}","pulls_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/pulls{/number}","milestones_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/milestones{/number}","notifications_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/labels{/name}","releases_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/releases{/id}","deployments_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/deployments","created_at":"2015-07-17T21:57:52Z","updated_at":"2018-10-30T16:05:57Z","pushed_at":"2018-11-01T05:44:20Z","git_url":"git://github.com/whosonfirst-data/whosonfirst-data.git","ssh_url":"git@github.com:whosonfirst-data/whosonfirst-data.git","clone_url":"https://github.com/whosonfirst-data/whosonfirst-data.git","svn_url":"https://github.com/whosonfirst-data/whosonfirst-data","homepage":"http://www.whosonfirst.org/","size":27761782,"stargazers_count":213,"watchers_count":213,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":368,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":58,"open_issues":368,"watchers":213,"default_branch":"master"}},"base":{"label":"whosonfirst-data:master","ref":"master","sha":"00af34cf81ce6784c2dd69acf683ce9814759556","user":{"login":"whosonfirst-data","id":16909145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTA5MTQ1","avatar_url":"https://avatars3.githubusercontent.com/u/16909145?v=4","gravatar_id":"","url":"https://api.github.com/users/whosonfirst-data","html_url":"https://github.com/whosonfirst-data","followers_url":"https://api.github.com/users/whosonfirst-data/followers","following_url":"https://api.github.com/users/whosonfirst-data/following{/other_user}","gists_url":"https://api.github.com/users/whosonfirst-data/gists{/gist_id}","starred_url":"https://api.github.com/users/whosonfirst-data/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whosonfirst-data/subscriptions","organizations_url":"https://api.github.com/users/whosonfirst-data/orgs","repos_url":"https://api.github.com/users/whosonfirst-data/repos","events_url":"https://api.github.com/users/whosonfirst-data/events{/privacy}","received_events_url":"https://api.github.com/users/whosonfirst-data/received_events","type":"Organization","site_admin":false},"repo":{"id":39277038,"node_id":"MDEwOlJlcG9zaXRvcnkzOTI3NzAzOA==","name":"whosonfirst-data","full_name":"whosonfirst-data/whosonfirst-data","private":false,"owner":{"login":"whosonfirst-data","id":16909145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTA5MTQ1","avatar_url":"https://avatars3.githubusercontent.com/u/16909145?v=4","gravatar_id":"","url":"https://api.github.com/users/whosonfirst-data","html_url":"https://github.com/whosonfirst-data","followers_url":"https://api.github.com/users/whosonfirst-data/followers","following_url":"https://api.github.com/users/whosonfirst-data/following{/other_user}","gists_url":"https://api.github.com/users/whosonfirst-data/gists{/gist_id}","starred_url":"https://api.github.com/users/whosonfirst-data/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whosonfirst-data/subscriptions","organizations_url":"https://api.github.com/users/whosonfirst-data/orgs","repos_url":"https://api.github.com/users/whosonfirst-data/repos","events_url":"https://api.github.com/users/whosonfirst-data/events{/privacy}","received_events_url":"https://api.github.com/users/whosonfirst-data/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/whosonfirst-data/whosonfirst-data","description":"Who's On First is a gazetteer of places.","fork":false,"url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data","forks_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/forks","keys_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/teams","hooks_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/hooks","issue_events_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/issues/events{/number}","events_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/events","assignees_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/assignees{/user}","branches_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/branches{/branch}","tags_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/tags","blobs_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/git/refs{/sha}","trees_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/statuses/{sha}","languages_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/languages","stargazers_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/stargazers","contributors_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/contributors","subscribers_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/subscribers","subscription_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/subscription","commits_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/commits{/sha}","git_commits_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/git/commits{/sha}","comments_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/comments{/number}","issue_comment_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/issues/comments{/number}","contents_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/contents/{+path}","compare_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/merges","archive_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/downloads","issues_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/issues{/number}","pulls_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/pulls{/number}","milestones_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/milestones{/number}","notifications_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/labels{/name}","releases_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/releases{/id}","deployments_url":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/deployments","created_at":"2015-07-17T21:57:52Z","updated_at":"2018-10-30T16:05:57Z","pushed_at":"2018-11-01T05:44:20Z","git_url":"git://github.com/whosonfirst-data/whosonfirst-data.git","ssh_url":"git@github.com:whosonfirst-data/whosonfirst-data.git","clone_url":"https://github.com/whosonfirst-data/whosonfirst-data.git","svn_url":"https://github.com/whosonfirst-data/whosonfirst-data","homepage":"http://www.whosonfirst.org/","size":27761782,"stargazers_count":213,"watchers_count":213,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":368,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":58,"open_issues":368,"watchers":213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/pulls/1343"},"html":{"href":"https://github.com/whosonfirst-data/whosonfirst-data/pull/1343"},"issue":{"href":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/issues/1343"},"comments":{"href":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/issues/1343/comments"},"review_comments":{"href":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/pulls/1343/comments"},"review_comment":{"href":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/pulls/1343/commits"},"statuses":{"href":"https://api.github.com/repos/whosonfirst-data/whosonfirst-data/statuses/13e95b0e7cb4d8806de8559afc9f9cf7a1bba674"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"stepps00","id":18567700,"node_id":"MDQ6VXNlcjE4NTY3NzAw","avatar_url":"https://avatars3.githubusercontent.com/u/18567700?v=4","gravatar_id":"","url":"https://api.github.com/users/stepps00","html_url":"https://github.com/stepps00","followers_url":"https://api.github.com/users/stepps00/followers","following_url":"https://api.github.com/users/stepps00/following{/other_user}","gists_url":"https://api.github.com/users/stepps00/gists{/gist_id}","starred_url":"https://api.github.com/users/stepps00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stepps00/subscriptions","organizations_url":"https://api.github.com/users/stepps00/orgs","repos_url":"https://api.github.com/users/stepps00/repos","events_url":"https://api.github.com/users/stepps00/events{/privacy}","received_events_url":"https://api.github.com/users/stepps00/received_events","type":"User","site_admin":false},"comments":11,"review_comments":0,"maintainer_can_modify":false,"commits":19,"additions":0,"deletions":0,"changed_files":0}}
{"actor":{"display_login":"stepps00"}}