{"action":"created","issue":{"url":"https://api.github.com/repos/digidem/react-mapfilter/issues/73","repository_url":"https://api.github.com/repos/digidem/react-mapfilter","labels_url":"https://api.github.com/repos/digidem/react-mapfilter/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/digidem/react-mapfilter/issues/73/comments","events_url":"https://api.github.com/repos/digidem/react-mapfilter/issues/73/events","html_url":"https://github.com/digidem/react-mapfilter/issues/73","id":282946934,"number":73,"title":"Multiple Tile Sets, Layers on one MapView","user":{"login":"GoGoCarl","id":1719249,"avatar_url":"https://avatars0.githubusercontent.com/u/1719249?v=4","gravatar_id":"","url":"https://api.github.com/users/GoGoCarl","html_url":"https://github.com/GoGoCarl","followers_url":"https://api.github.com/users/GoGoCarl/followers","following_url":"https://api.github.com/users/GoGoCarl/following{/other_user}","gists_url":"https://api.github.com/users/GoGoCarl/gists{/gist_id}","starred_url":"https://api.github.com/users/GoGoCarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoGoCarl/subscriptions","organizations_url":"https://api.github.com/users/GoGoCarl/orgs","repos_url":"https://api.github.com/users/GoGoCarl/repos","events_url":"https://api.github.com/users/GoGoCarl/events{/privacy}","received_events_url":"https://api.github.com/users/GoGoCarl/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-12-18T16:49:26Z","updated_at":"2018-05-08T16:09:00Z","closed_at":"2018-05-01T00:55:51Z","author_association":"CONTRIBUTOR","body":"Feature Request:\r\n\r\nAllow users to toggle between multiple tile sets when viewing a Map. This could be achieved by adding a button to the map like:\r\n\r\n<img width=\"61\" alt=\"screen shot 2017-12-18 at 11 32 22 am\" src=\"https://user-images.githubusercontent.com/1719249/34116652-3d3fbcf8-e3e7-11e7-990a-04842327b56f.png\">\r\n\r\nThat, when clicked, displays a set of options for different tile sets, with the current tile set in use marked as selected:\r\n\r\n<img width=\"157\" alt=\"screen shot 2017-12-18 at 11 31 25 am\" src=\"https://user-images.githubusercontent.com/1719249/34116587-11175cd0-e3e7-11e7-9cec-897daa90c54a.png\">\r\n\r\nThe current tile set should specified be an optional controllable props, defaulting to the first tile set.\r\n\r\nOn change, update the map to use the selected tile set, and fire a change event.\r\n\r\nA tile set could be a prop like:\r\n\r\n    tileSets = PropTypes.arrayOf(PropTypes.shape({\r\n      /** A unique identifier for this tile set */\r\n      id: PropTypes.string,\r\n      /** A localized display name for the tile set */\r\n      name: PropTypes.string,\r\n      /** The URL to use to retrieve tiles for this tile set */\r\n      url: PropTypes.string\r\n    }))\r\n\r\nA question here would be with custom tiles -- generally the URL isn't an actual URL, but a URL template, which is filled dynamically based on the map position. This may need to be accounted for as well. \r\n\r\nNote: while building this functionality, it would be useful to consider the possibility down the line of adding support for custom layers as well -- layers that would appear on the map independent of any tile set chosen. "},"comment":{"url":"https://api.github.com/repos/digidem/react-mapfilter/issues/comments/387455939","html_url":"https://github.com/digidem/react-mapfilter/issues/73#issuecomment-387455939","issue_url":"https://api.github.com/repos/digidem/react-mapfilter/issues/73","id":387455939,"user":{"login":"karissa","id":633012,"avatar_url":"https://avatars3.githubusercontent.com/u/633012?v=4","gravatar_id":"","url":"https://api.github.com/users/karissa","html_url":"https://github.com/karissa","followers_url":"https://api.github.com/users/karissa/followers","following_url":"https://api.github.com/users/karissa/following{/other_user}","gists_url":"https://api.github.com/users/karissa/gists{/gist_id}","starred_url":"https://api.github.com/users/karissa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karissa/subscriptions","organizations_url":"https://api.github.com/users/karissa/orgs","repos_url":"https://api.github.com/users/karissa/repos","events_url":"https://api.github.com/users/karissa/events{/privacy}","received_events_url":"https://api.github.com/users/karissa/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T16:09:00Z","updated_at":"2018-05-08T16:09:00Z","author_association":"CONTRIBUTOR","body":"Hey @GoGoCarl \r\n\r\nHere is a minimal example:\r\nhttps://github.com/digidem/mapfilter-desktop/commit/12c551a42fac9a8ac3c55b825022b0d70aee2abc\r\n\r\nYou are right, it is `mapControls`. I also realized we didn't add controls after map.on('load') which was causing issues accessing the style property within the map. That bug is fixed now."}}
{"actor":{"display_login":"karissa"}}