{"action":"created","comment":{"url":"https://api.github.com/repos/agile42/marqueebookings/pulls/comments/194494928","pull_request_review_id":127674014,"id":194494928,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDQ5NDkyOA==","diff_hunk":"@@ -23,7 +23,7 @@\n     %hr\n     .row\n       .col-md-3\n-        = render \"searches/form_section_items\", f: f, heading: 'Tables', collection: TableType.all + TrestleTableType.all, line_item_method_name: 'number_of_tables_method_name'\n+        = render \"searches/form_section_items\", f: f, heading: 'Tables', collection: Search::TABLE_NUMBER_METHODS.map { |t| OpenStruct.new(name: t, display_name: Table::DISPLAY_NAMES[t]) }, line_item_method_name: 'name'","path":"app/views/searches/_form.haml","position":5,"original_position":5,"commit_id":"2363db745f56185f63af8eb5a516b9cbd499a91c","original_commit_id":"2363db745f56185f63af8eb5a516b9cbd499a91c","user":{"login":"johngallagher","id":22185,"node_id":"MDQ6VXNlcjIyMTg1","avatar_url":"https://avatars0.githubusercontent.com/u/22185?v=4","gravatar_id":"","url":"https://api.github.com/users/johngallagher","html_url":"https://github.com/johngallagher","followers_url":"https://api.github.com/users/johngallagher/followers","following_url":"https://api.github.com/users/johngallagher/following{/other_user}","gists_url":"https://api.github.com/users/johngallagher/gists{/gist_id}","starred_url":"https://api.github.com/users/johngallagher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johngallagher/subscriptions","organizations_url":"https://api.github.com/users/johngallagher/orgs","repos_url":"https://api.github.com/users/johngallagher/repos","events_url":"https://api.github.com/users/johngallagher/events{/privacy}","received_events_url":"https://api.github.com/users/johngallagher/received_events","type":"User","site_admin":false},"body":"I realise this is kinda cheating - making a dummy object - but apart from introducing a ton of duplication by having a different `searches/table_form_section_items` or similar I couldn't figure out a better way.","created_at":"2018-06-11T18:05:20Z","updated_at":"2018-06-11T18:06:27Z","html_url":"https://github.com/agile42/marqueebookings/pull/6#discussion_r194494928","pull_request_url":"https://api.github.com/repos/agile42/marqueebookings/pulls/6","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/agile42/marqueebookings/pulls/comments/194494928"},"html":{"href":"https://github.com/agile42/marqueebookings/pull/6#discussion_r194494928"},"pull_request":{"href":"https://api.github.com/repos/agile42/marqueebookings/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/agile42/marqueebookings/pulls/6","id":193408988,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDA4OTg4","html_url":"https://github.com/agile42/marqueebookings/pull/6","diff_url":"https://github.com/agile42/marqueebookings/pull/6.diff","patch_url":"https://github.com/agile42/marqueebookings/pull/6.patch","issue_url":"https://api.github.com/repos/agile42/marqueebookings/issues/6","number":6,"state":"open","locked":false,"title":"Stop with the table type object craziness ","user":{"login":"johngallagher","id":22185,"node_id":"MDQ6VXNlcjIyMTg1","avatar_url":"https://avatars0.githubusercontent.com/u/22185?v=4","gravatar_id":"","url":"https://api.github.com/users/johngallagher","html_url":"https://github.com/johngallagher","followers_url":"https://api.github.com/users/johngallagher/followers","following_url":"https://api.github.com/users/johngallagher/following{/other_user}","gists_url":"https://api.github.com/users/johngallagher/gists{/gist_id}","starred_url":"https://api.github.com/users/johngallagher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johngallagher/subscriptions","organizations_url":"https://api.github.com/users/johngallagher/orgs","repos_url":"https://api.github.com/users/johngallagher/repos","events_url":"https://api.github.com/users/johngallagher/events{/privacy}","received_events_url":"https://api.github.com/users/johngallagher/received_events","type":"User","site_admin":false},"body":"- [x] Only have ONE trestle table price for a supplier - put it in the table object\r\n- [x] Nuke all number_of_X_table method names/keys","created_at":"2018-06-07T18:27:20Z","updated_at":"2018-06-11T18:06:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a0dba7090f4236efeca017bbadcf8a441c22c6c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/agile42/marqueebookings/pulls/6/commits","review_comments_url":"https://api.github.com/repos/agile42/marqueebookings/pulls/6/comments","review_comment_url":"https://api.github.com/repos/agile42/marqueebookings/pulls/comments{/number}","comments_url":"https://api.github.com/repos/agile42/marqueebookings/issues/6/comments","statuses_url":"https://api.github.com/repos/agile42/marqueebookings/statuses/2363db745f56185f63af8eb5a516b9cbd499a91c","head":{"label":"agile42:add-table-type","ref":"add-table-type","sha":"2363db745f56185f63af8eb5a516b9cbd499a91c","user":{"login":"agile42","id":1370568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzA1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1370568?v=4","gravatar_id":"","url":"https://api.github.com/users/agile42","html_url":"https://github.com/agile42","followers_url":"https://api.github.com/users/agile42/followers","following_url":"https://api.github.com/users/agile42/following{/other_user}","gists_url":"https://api.github.com/users/agile42/gists{/gist_id}","starred_url":"https://api.github.com/users/agile42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agile42/subscriptions","organizations_url":"https://api.github.com/users/agile42/orgs","repos_url":"https://api.github.com/users/agile42/repos","events_url":"https://api.github.com/users/agile42/events{/privacy}","received_events_url":"https://api.github.com/users/agile42/received_events","type":"Organization","site_admin":false},"repo":{"id":123427049,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM0MjcwNDk=","name":"marqueebookings","full_name":"agile42/marqueebookings","owner":{"login":"agile42","id":1370568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzA1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1370568?v=4","gravatar_id":"","url":"https://api.github.com/users/agile42","html_url":"https://github.com/agile42","followers_url":"https://api.github.com/users/agile42/followers","following_url":"https://api.github.com/users/agile42/following{/other_user}","gists_url":"https://api.github.com/users/agile42/gists{/gist_id}","starred_url":"https://api.github.com/users/agile42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agile42/subscriptions","organizations_url":"https://api.github.com/users/agile42/orgs","repos_url":"https://api.github.com/users/agile42/repos","events_url":"https://api.github.com/users/agile42/events{/privacy}","received_events_url":"https://api.github.com/users/agile42/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/agile42/marqueebookings","description":"Marquee bookings","fork":false,"url":"https://api.github.com/repos/agile42/marqueebookings","forks_url":"https://api.github.com/repos/agile42/marqueebookings/forks","keys_url":"https://api.github.com/repos/agile42/marqueebookings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agile42/marqueebookings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agile42/marqueebookings/teams","hooks_url":"https://api.github.com/repos/agile42/marqueebookings/hooks","issue_events_url":"https://api.github.com/repos/agile42/marqueebookings/issues/events{/number}","events_url":"https://api.github.com/repos/agile42/marqueebookings/events","assignees_url":"https://api.github.com/repos/agile42/marqueebookings/assignees{/user}","branches_url":"https://api.github.com/repos/agile42/marqueebookings/branches{/branch}","tags_url":"https://api.github.com/repos/agile42/marqueebookings/tags","blobs_url":"https://api.github.com/repos/agile42/marqueebookings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agile42/marqueebookings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agile42/marqueebookings/git/refs{/sha}","trees_url":"https://api.github.com/repos/agile42/marqueebookings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agile42/marqueebookings/statuses/{sha}","languages_url":"https://api.github.com/repos/agile42/marqueebookings/languages","stargazers_url":"https://api.github.com/repos/agile42/marqueebookings/stargazers","contributors_url":"https://api.github.com/repos/agile42/marqueebookings/contributors","subscribers_url":"https://api.github.com/repos/agile42/marqueebookings/subscribers","subscription_url":"https://api.github.com/repos/agile42/marqueebookings/subscription","commits_url":"https://api.github.com/repos/agile42/marqueebookings/commits{/sha}","git_commits_url":"https://api.github.com/repos/agile42/marqueebookings/git/commits{/sha}","comments_url":"https://api.github.com/repos/agile42/marqueebookings/comments{/number}","issue_comment_url":"https://api.github.com/repos/agile42/marqueebookings/issues/comments{/number}","contents_url":"https://api.github.com/repos/agile42/marqueebookings/contents/{+path}","compare_url":"https://api.github.com/repos/agile42/marqueebookings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agile42/marqueebookings/merges","archive_url":"https://api.github.com/repos/agile42/marqueebookings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agile42/marqueebookings/downloads","issues_url":"https://api.github.com/repos/agile42/marqueebookings/issues{/number}","pulls_url":"https://api.github.com/repos/agile42/marqueebookings/pulls{/number}","milestones_url":"https://api.github.com/repos/agile42/marqueebookings/milestones{/number}","notifications_url":"https://api.github.com/repos/agile42/marqueebookings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agile42/marqueebookings/labels{/name}","releases_url":"https://api.github.com/repos/agile42/marqueebookings/releases{/id}","deployments_url":"https://api.github.com/repos/agile42/marqueebookings/deployments","created_at":"2018-03-01T11:38:05Z","updated_at":"2018-05-24T12:42:01Z","pushed_at":"2018-06-11T17:52:55Z","git_url":"git://github.com/agile42/marqueebookings.git","ssh_url":"git@github.com:agile42/marqueebookings.git","clone_url":"https://github.com/agile42/marqueebookings.git","svn_url":"https://github.com/agile42/marqueebookings","homepage":"https://marqueebookings.fac3.io/","size":18295,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"agile42:rebased-refactor","ref":"rebased-refactor","sha":"b96e933cae03e9eccc17c4cd9c7ae1effc3b85c2","user":{"login":"agile42","id":1370568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzA1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1370568?v=4","gravatar_id":"","url":"https://api.github.com/users/agile42","html_url":"https://github.com/agile42","followers_url":"https://api.github.com/users/agile42/followers","following_url":"https://api.github.com/users/agile42/following{/other_user}","gists_url":"https://api.github.com/users/agile42/gists{/gist_id}","starred_url":"https://api.github.com/users/agile42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agile42/subscriptions","organizations_url":"https://api.github.com/users/agile42/orgs","repos_url":"https://api.github.com/users/agile42/repos","events_url":"https://api.github.com/users/agile42/events{/privacy}","received_events_url":"https://api.github.com/users/agile42/received_events","type":"Organization","site_admin":false},"repo":{"id":123427049,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM0MjcwNDk=","name":"marqueebookings","full_name":"agile42/marqueebookings","owner":{"login":"agile42","id":1370568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNzA1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1370568?v=4","gravatar_id":"","url":"https://api.github.com/users/agile42","html_url":"https://github.com/agile42","followers_url":"https://api.github.com/users/agile42/followers","following_url":"https://api.github.com/users/agile42/following{/other_user}","gists_url":"https://api.github.com/users/agile42/gists{/gist_id}","starred_url":"https://api.github.com/users/agile42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agile42/subscriptions","organizations_url":"https://api.github.com/users/agile42/orgs","repos_url":"https://api.github.com/users/agile42/repos","events_url":"https://api.github.com/users/agile42/events{/privacy}","received_events_url":"https://api.github.com/users/agile42/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/agile42/marqueebookings","description":"Marquee bookings","fork":false,"url":"https://api.github.com/repos/agile42/marqueebookings","forks_url":"https://api.github.com/repos/agile42/marqueebookings/forks","keys_url":"https://api.github.com/repos/agile42/marqueebookings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agile42/marqueebookings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agile42/marqueebookings/teams","hooks_url":"https://api.github.com/repos/agile42/marqueebookings/hooks","issue_events_url":"https://api.github.com/repos/agile42/marqueebookings/issues/events{/number}","events_url":"https://api.github.com/repos/agile42/marqueebookings/events","assignees_url":"https://api.github.com/repos/agile42/marqueebookings/assignees{/user}","branches_url":"https://api.github.com/repos/agile42/marqueebookings/branches{/branch}","tags_url":"https://api.github.com/repos/agile42/marqueebookings/tags","blobs_url":"https://api.github.com/repos/agile42/marqueebookings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agile42/marqueebookings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agile42/marqueebookings/git/refs{/sha}","trees_url":"https://api.github.com/repos/agile42/marqueebookings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agile42/marqueebookings/statuses/{sha}","languages_url":"https://api.github.com/repos/agile42/marqueebookings/languages","stargazers_url":"https://api.github.com/repos/agile42/marqueebookings/stargazers","contributors_url":"https://api.github.com/repos/agile42/marqueebookings/contributors","subscribers_url":"https://api.github.com/repos/agile42/marqueebookings/subscribers","subscription_url":"https://api.github.com/repos/agile42/marqueebookings/subscription","commits_url":"https://api.github.com/repos/agile42/marqueebookings/commits{/sha}","git_commits_url":"https://api.github.com/repos/agile42/marqueebookings/git/commits{/sha}","comments_url":"https://api.github.com/repos/agile42/marqueebookings/comments{/number}","issue_comment_url":"https://api.github.com/repos/agile42/marqueebookings/issues/comments{/number}","contents_url":"https://api.github.com/repos/agile42/marqueebookings/contents/{+path}","compare_url":"https://api.github.com/repos/agile42/marqueebookings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agile42/marqueebookings/merges","archive_url":"https://api.github.com/repos/agile42/marqueebookings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agile42/marqueebookings/downloads","issues_url":"https://api.github.com/repos/agile42/marqueebookings/issues{/number}","pulls_url":"https://api.github.com/repos/agile42/marqueebookings/pulls{/number}","milestones_url":"https://api.github.com/repos/agile42/marqueebookings/milestones{/number}","notifications_url":"https://api.github.com/repos/agile42/marqueebookings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agile42/marqueebookings/labels{/name}","releases_url":"https://api.github.com/repos/agile42/marqueebookings/releases{/id}","deployments_url":"https://api.github.com/repos/agile42/marqueebookings/deployments","created_at":"2018-03-01T11:38:05Z","updated_at":"2018-05-24T12:42:01Z","pushed_at":"2018-06-11T17:52:55Z","git_url":"git://github.com/agile42/marqueebookings.git","ssh_url":"git@github.com:agile42/marqueebookings.git","clone_url":"https://github.com/agile42/marqueebookings.git","svn_url":"https://github.com/agile42/marqueebookings","homepage":"https://marqueebookings.fac3.io/","size":18295,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/agile42/marqueebookings/pulls/6"},"html":{"href":"https://github.com/agile42/marqueebookings/pull/6"},"issue":{"href":"https://api.github.com/repos/agile42/marqueebookings/issues/6"},"comments":{"href":"https://api.github.com/repos/agile42/marqueebookings/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/agile42/marqueebookings/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/agile42/marqueebookings/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/agile42/marqueebookings/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/agile42/marqueebookings/statuses/2363db745f56185f63af8eb5a516b9cbd499a91c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"johngallagher"}}