{"action":"created","issue":{"url":"https://api.github.com/repos/textmate/html.tmbundle/issues/85","repository_url":"https://api.github.com/repos/textmate/html.tmbundle","labels_url":"https://api.github.com/repos/textmate/html.tmbundle/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/textmate/html.tmbundle/issues/85/comments","events_url":"https://api.github.com/repos/textmate/html.tmbundle/issues/85/events","html_url":"https://github.com/textmate/html.tmbundle/issues/85","id":328416748,"node_id":"MDU6SXNzdWUzMjg0MTY3NDg=","number":85,"title":"Embedded JavaScript grammar can break the colorization","user":{"login":"aeschli","id":6461412,"node_id":"MDQ6VXNlcjY0NjE0MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/6461412?v=4","gravatar_id":"","url":"https://api.github.com/users/aeschli","html_url":"https://github.com/aeschli","followers_url":"https://api.github.com/users/aeschli/followers","following_url":"https://api.github.com/users/aeschli/following{/other_user}","gists_url":"https://api.github.com/users/aeschli/gists{/gist_id}","starred_url":"https://api.github.com/users/aeschli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeschli/subscriptions","organizations_url":"https://api.github.com/users/aeschli/orgs","repos_url":"https://api.github.com/users/aeschli/repos","events_url":"https://api.github.com/users/aeschli/events{/privacy}","received_events_url":"https://api.github.com/users/aeschli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-01T07:52:45Z","updated_at":"2018-06-01T15:54:39Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The following code doesn't highlight correctly in VSCode after ` //</script>`. The problem is that the embedded JavaScript grammar consumes the full `//</script>` and the sourrounding html rule doesn't end. The grammar is stuck in `js`.\r\n\r\n```\r\n<!DOCTYPE html>\r\n<html>\r\n<head>\r\n    <script>\r\n        //</script>\r\n</head>\r\n<body>\r\n\r\n</body>\r\n</html>\r\n```\r\n\r\nThere are many similar issues when the JS code is not complete and the JavaScript grammar is in the middle of some rule.\r\n\r\nIMO the best thing would be to not include the full blown JavaScript grammar but embed a (simplified) variant that is aware of the `</script>` tag"},"comment":{"url":"https://api.github.com/repos/textmate/html.tmbundle/issues/comments/393924308","html_url":"https://github.com/textmate/html.tmbundle/issues/85#issuecomment-393924308","issue_url":"https://api.github.com/repos/textmate/html.tmbundle/issues/85","id":393924308,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzkyNDMwOA==","user":{"login":"SDP190","id":16751213,"node_id":"MDQ6VXNlcjE2NzUxMjEz","avatar_url":"https://avatars0.githubusercontent.com/u/16751213?v=4","gravatar_id":"","url":"https://api.github.com/users/SDP190","html_url":"https://github.com/SDP190","followers_url":"https://api.github.com/users/SDP190/followers","following_url":"https://api.github.com/users/SDP190/following{/other_user}","gists_url":"https://api.github.com/users/SDP190/gists{/gist_id}","starred_url":"https://api.github.com/users/SDP190/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SDP190/subscriptions","organizations_url":"https://api.github.com/users/SDP190/orgs","repos_url":"https://api.github.com/users/SDP190/repos","events_url":"https://api.github.com/users/SDP190/events{/privacy}","received_events_url":"https://api.github.com/users/SDP190/received_events","type":"User","site_admin":false},"created_at":"2018-06-01T15:54:39Z","updated_at":"2018-06-01T15:54:39Z","author_association":"NONE","body":"Hi @aeschli, do you know by any chance if this issue occurs with other applications beside VSCode which uses this html.tmbundle TextMate grammar?"}}
{"actor":{"display_login":"SDP190"}}