{"action":"created","issue":{"url":"https://api.github.com/repos/xapi-project/xenopsd/issues/525","repository_url":"https://api.github.com/repos/xapi-project/xenopsd","labels_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/525/labels{/name}","comments_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/525/comments","events_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/525/events","html_url":"https://github.com/xapi-project/xenopsd/pull/525","id":336941389,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MjcyODk3","number":525,"title":"CP-24770: create QEMU disk command line in xenopsd instead of qemu-wrapper","user":{"login":"mg12","id":590521,"node_id":"MDQ6VXNlcjU5MDUyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/590521?v=4","gravatar_id":"","url":"https://api.github.com/users/mg12","html_url":"https://github.com/mg12","followers_url":"https://api.github.com/users/mg12/followers","following_url":"https://api.github.com/users/mg12/following{/other_user}","gists_url":"https://api.github.com/users/mg12/gists{/gist_id}","starred_url":"https://api.github.com/users/mg12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mg12/subscriptions","organizations_url":"https://api.github.com/users/mg12/orgs","repos_url":"https://api.github.com/users/mg12/repos","events_url":"https://api.github.com/users/mg12/events{/privacy}","received_events_url":"https://api.github.com/users/mg12/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-29T10:08:17Z","updated_at":"2018-07-02T09:21:54Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/525","html_url":"https://github.com/xapi-project/xenopsd/pull/525","diff_url":"https://github.com/xapi-project/xenopsd/pull/525.diff","patch_url":"https://github.com/xapi-project/xenopsd/pull/525.patch"},"body":"    This patch rebases commit ffddbbfb414d7a83ecde14f07fa0809941af5c9c                                                                                           \r\n    > CP-24770: Xenopsd calls now the qemu-wrapper script passing in the right                                                                                           \r\n    > parameters for disks and CD drives.                                                                                           \r\n    > Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>  \r\n\r\n    In particular, it simplifies the change to the VmExtra.qemu_vbds field after                                                                                           \r\n    the VmExtra.non_persistent_t field was removed and qemu_vbds is available                                                                                           \r\n    now only as part of the VmExtra.persistent_t field, which needs to be                                                                                           \r\n    backwards-compatible with previous versions of xenopsd due to RPU and                                                                                           \r\n    cross-pool migration: instead of making qemu_frontend optional, which would                                                                                           \r\n    cause incompatibility with previous versions of the VmExtra.persistent_t                                                                                           \r\n    field, it adds an extra option 'Empty' to the qemu_frontend type. The                                                                                           \r\n    unmarshalling of this new option should be backwards-compatible for VMs                                                                                           \r\n    started in previous versions of xenopsd.                                                                                           \r\n                                                                                                                                                                                                                          \r\n  \r\nTested with win7 guests and qemu-trad and qemu-upstream-compat profiles.\r\n* verified that the -drive parameters are being passed as expected for disks and cdrom to qemu-wrapper in qemu-upstream after the patch (whereas before they were generated inside qemu-wrapper).\r\n* verified that the -drive parameters are not being passed for qemu-trad\r\n* verified that we can start vms whose cdrom is using index 2 instead of 3\r\n* verified that a newly created RW disk is passed to the qemu-upstream disk parameters, but when this disk is made RO the corresponding disk parameters are not passed as expected.\r\n"},"comment":{"url":"https://api.github.com/repos/xapi-project/xenopsd/issues/comments/401729716","html_url":"https://github.com/xapi-project/xenopsd/pull/525#issuecomment-401729716","issue_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/525","id":401729716,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTcyOTcxNg==","user":{"login":"gaborigloi","id":10549240,"node_id":"MDQ6VXNlcjEwNTQ5MjQw","avatar_url":"https://avatars3.githubusercontent.com/u/10549240?v=4","gravatar_id":"","url":"https://api.github.com/users/gaborigloi","html_url":"https://github.com/gaborigloi","followers_url":"https://api.github.com/users/gaborigloi/followers","following_url":"https://api.github.com/users/gaborigloi/following{/other_user}","gists_url":"https://api.github.com/users/gaborigloi/gists{/gist_id}","starred_url":"https://api.github.com/users/gaborigloi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaborigloi/subscriptions","organizations_url":"https://api.github.com/users/gaborigloi/orgs","repos_url":"https://api.github.com/users/gaborigloi/repos","events_url":"https://api.github.com/users/gaborigloi/events{/privacy}","received_events_url":"https://api.github.com/users/gaborigloi/received_events","type":"User","site_admin":false},"created_at":"2018-07-02T09:21:54Z","updated_at":"2018-07-02T09:21:54Z","author_association":"CONTRIBUTOR","body":"Indeed, it needs to be rebased on master first, because there will be merge conflicts, the qemu-wrapper script has changed in the meantime."}}
{"actor":{"display_login":"gaborigloi"}}