{"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/help-to-save-stub/pulls/comments/209297697","pull_request_review_id":145289590,"id":209297697,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTI5NzY5Nw==","diff_hunk":"@@ -153,7 +153,7 @@ class NSIControllerSpec extends UnitSpec with WithFakeApplication with AkkaMater\n     \"return a 400 with errorMessageId HTS-API015-006 when given a nino not found\" in {\n       val request = FakeRequest()\n         .withHeaders(authHeader)\n-      val result = await(NSIController.getAccount(Some(\"correlationId\"), Some(\"EZ000001A\"), Some(\"V1.0\"), Some(\"systemId\"))(request))\n+      val result = await(NSIController.getAccount(Some(\"correlationId\"), Some(generator.nextNino.nino), Some(\"V1.0\"), Some(\"systemId\"))(request))","path":"test/uk/gov/hmrc/helptosavestub/controllers/NSIControllerSpec.scala","position":42,"original_position":42,"commit_id":"8b2808bec46c0993d437dcc535e5579eb3ea3b05","original_commit_id":"8b2808bec46c0993d437dcc535e5579eb3ea3b05","user":{"login":"AndyHWChung","id":26929776,"node_id":"MDQ6VXNlcjI2OTI5Nzc2","avatar_url":"https://avatars1.githubusercontent.com/u/26929776?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyHWChung","html_url":"https://github.com/AndyHWChung","followers_url":"https://api.github.com/users/AndyHWChung/followers","following_url":"https://api.github.com/users/AndyHWChung/following{/other_user}","gists_url":"https://api.github.com/users/AndyHWChung/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyHWChung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyHWChung/subscriptions","organizations_url":"https://api.github.com/users/AndyHWChung/orgs","repos_url":"https://api.github.com/users/AndyHWChung/repos","events_url":"https://api.github.com/users/AndyHWChung/events{/privacy}","received_events_url":"https://api.github.com/users/AndyHWChung/received_events","type":"User","site_admin":false},"body":"potentially, but the chances of that happening are very low. I thought the chances were low enough to basically ignore","created_at":"2018-08-10T15:27:19Z","updated_at":"2018-08-10T15:27:19Z","html_url":"https://github.com/hmrc/help-to-save-stub/pull/141#discussion_r209297697","pull_request_url":"https://api.github.com/repos/hmrc/help-to-save-stub/pulls/141","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmrc/help-to-save-stub/pulls/comments/209297697"},"html":{"href":"https://github.com/hmrc/help-to-save-stub/pull/141#discussion_r209297697"},"pull_request":{"href":"https://api.github.com/repos/hmrc/help-to-save-stub/pulls/141"}},"in_reply_to_id":209296816},"pull_request":{"url":"https://api.github.com/repos/hmrc/help-to-save-stub/pulls/141","id":207641051,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NjQxMDUx","html_url":"https://github.com/hmrc/help-to-save-stub/pull/141","diff_url":"https://github.com/hmrc/help-to-save-stub/pull/141.diff","patch_url":"https://github.com/hmrc/help-to-save-stub/pull/141.patch","issue_url":"https://api.github.com/repos/hmrc/help-to-save-stub/issues/141","number":141,"state":"open","locked":false,"title":"Got rid of hard coded NINOs","user":{"login":"AndyHWChung","id":26929776,"node_id":"MDQ6VXNlcjI2OTI5Nzc2","avatar_url":"https://avatars1.githubusercontent.com/u/26929776?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyHWChung","html_url":"https://github.com/AndyHWChung","followers_url":"https://api.github.com/users/AndyHWChung/followers","following_url":"https://api.github.com/users/AndyHWChung/following{/other_user}","gists_url":"https://api.github.com/users/AndyHWChung/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyHWChung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyHWChung/subscriptions","organizations_url":"https://api.github.com/users/AndyHWChung/orgs","repos_url":"https://api.github.com/users/AndyHWChung/repos","events_url":"https://api.github.com/users/AndyHWChung/events{/privacy}","received_events_url":"https://api.github.com/users/AndyHWChung/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-10T15:07:48Z","updated_at":"2018-08-10T15:27:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77da95e234d8628da7eaba93a2675f4c24689b6f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/help-to-save-stub/pulls/141/commits","review_comments_url":"https://api.github.com/repos/hmrc/help-to-save-stub/pulls/141/comments","review_comment_url":"https://api.github.com/repos/hmrc/help-to-save-stub/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/help-to-save-stub/issues/141/comments","statuses_url":"https://api.github.com/repos/hmrc/help-to-save-stub/statuses/8b2808bec46c0993d437dcc535e5579eb3ea3b05","head":{"label":"hmrc:ninos","ref":"ninos","sha":"8b2808bec46c0993d437dcc535e5579eb3ea3b05","user":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":87530931,"node_id":"MDEwOlJlcG9zaXRvcnk4NzUzMDkzMQ==","name":"help-to-save-stub","full_name":"hmrc/help-to-save-stub","owner":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/help-to-save-stub","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/help-to-save-stub","forks_url":"https://api.github.com/repos/hmrc/help-to-save-stub/forks","keys_url":"https://api.github.com/repos/hmrc/help-to-save-stub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/help-to-save-stub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/help-to-save-stub/teams","hooks_url":"https://api.github.com/repos/hmrc/help-to-save-stub/hooks","issue_events_url":"https://api.github.com/repos/hmrc/help-to-save-stub/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/help-to-save-stub/events","assignees_url":"https://api.github.com/repos/hmrc/help-to-save-stub/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/help-to-save-stub/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/help-to-save-stub/tags","blobs_url":"https://api.github.com/repos/hmrc/help-to-save-stub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/help-to-save-stub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/help-to-save-stub/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/help-to-save-stub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/help-to-save-stub/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/help-to-save-stub/languages","stargazers_url":"https://api.github.com/repos/hmrc/help-to-save-stub/stargazers","contributors_url":"https://api.github.com/repos/hmrc/help-to-save-stub/contributors","subscribers_url":"https://api.github.com/repos/hmrc/help-to-save-stub/subscribers","subscription_url":"https://api.github.com/repos/hmrc/help-to-save-stub/subscription","commits_url":"https://api.github.com/repos/hmrc/help-to-save-stub/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/help-to-save-stub/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/help-to-save-stub/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/help-to-save-stub/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/help-to-save-stub/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/help-to-save-stub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/help-to-save-stub/merges","archive_url":"https://api.github.com/repos/hmrc/help-to-save-stub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/help-to-save-stub/downloads","issues_url":"https://api.github.com/repos/hmrc/help-to-save-stub/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/help-to-save-stub/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/help-to-save-stub/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/help-to-save-stub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/help-to-save-stub/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/help-to-save-stub/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/help-to-save-stub/deployments","created_at":"2017-04-07T09:45:48Z","updated_at":"2018-08-10T09:59:24Z","pushed_at":"2018-08-10T15:07:48Z","git_url":"git://github.com/hmrc/help-to-save-stub.git","ssh_url":"git@github.com:hmrc/help-to-save-stub.git","clone_url":"https://github.com/hmrc/help-to-save-stub.git","svn_url":"https://github.com/hmrc/help-to-save-stub","homepage":"","size":1683,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"efcfc827b4e8be5f37d66196a8e3472a47cd9a04","user":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":87530931,"node_id":"MDEwOlJlcG9zaXRvcnk4NzUzMDkzMQ==","name":"help-to-save-stub","full_name":"hmrc/help-to-save-stub","owner":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/help-to-save-stub","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/help-to-save-stub","forks_url":"https://api.github.com/repos/hmrc/help-to-save-stub/forks","keys_url":"https://api.github.com/repos/hmrc/help-to-save-stub/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/help-to-save-stub/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/help-to-save-stub/teams","hooks_url":"https://api.github.com/repos/hmrc/help-to-save-stub/hooks","issue_events_url":"https://api.github.com/repos/hmrc/help-to-save-stub/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/help-to-save-stub/events","assignees_url":"https://api.github.com/repos/hmrc/help-to-save-stub/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/help-to-save-stub/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/help-to-save-stub/tags","blobs_url":"https://api.github.com/repos/hmrc/help-to-save-stub/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/help-to-save-stub/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/help-to-save-stub/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/help-to-save-stub/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/help-to-save-stub/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/help-to-save-stub/languages","stargazers_url":"https://api.github.com/repos/hmrc/help-to-save-stub/stargazers","contributors_url":"https://api.github.com/repos/hmrc/help-to-save-stub/contributors","subscribers_url":"https://api.github.com/repos/hmrc/help-to-save-stub/subscribers","subscription_url":"https://api.github.com/repos/hmrc/help-to-save-stub/subscription","commits_url":"https://api.github.com/repos/hmrc/help-to-save-stub/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/help-to-save-stub/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/help-to-save-stub/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/help-to-save-stub/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/help-to-save-stub/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/help-to-save-stub/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/help-to-save-stub/merges","archive_url":"https://api.github.com/repos/hmrc/help-to-save-stub/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/help-to-save-stub/downloads","issues_url":"https://api.github.com/repos/hmrc/help-to-save-stub/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/help-to-save-stub/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/help-to-save-stub/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/help-to-save-stub/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/help-to-save-stub/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/help-to-save-stub/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/help-to-save-stub/deployments","created_at":"2017-04-07T09:45:48Z","updated_at":"2018-08-10T09:59:24Z","pushed_at":"2018-08-10T15:07:48Z","git_url":"git://github.com/hmrc/help-to-save-stub.git","ssh_url":"git@github.com:hmrc/help-to-save-stub.git","clone_url":"https://github.com/hmrc/help-to-save-stub.git","svn_url":"https://github.com/hmrc/help-to-save-stub","homepage":"","size":1683,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/help-to-save-stub/pulls/141"},"html":{"href":"https://github.com/hmrc/help-to-save-stub/pull/141"},"issue":{"href":"https://api.github.com/repos/hmrc/help-to-save-stub/issues/141"},"comments":{"href":"https://api.github.com/repos/hmrc/help-to-save-stub/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/help-to-save-stub/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/help-to-save-stub/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/help-to-save-stub/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/help-to-save-stub/statuses/8b2808bec46c0993d437dcc535e5579eb3ea3b05"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AndyHWChung"}}