{"action":"created","issue":{"url":"https://api.github.com/repos/scala/scala/issues/7074","repository_url":"https://api.github.com/repos/scala/scala","labels_url":"https://api.github.com/repos/scala/scala/issues/7074/labels{/name}","comments_url":"https://api.github.com/repos/scala/scala/issues/7074/comments","events_url":"https://api.github.com/repos/scala/scala/issues/7074/events","html_url":"https://github.com/scala/scala/pull/7074","id":350535191,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MzYzMzU2","number":7074,"title":"Make CHAMP HashMap and HashSet the default","user":{"login":"szeiger","id":54262,"node_id":"MDQ6VXNlcjU0MjYy","avatar_url":"https://avatars3.githubusercontent.com/u/54262?v=4","gravatar_id":"","url":"https://api.github.com/users/szeiger","html_url":"https://github.com/szeiger","followers_url":"https://api.github.com/users/szeiger/followers","following_url":"https://api.github.com/users/szeiger/following{/other_user}","gists_url":"https://api.github.com/users/szeiger/gists{/gist_id}","starred_url":"https://api.github.com/users/szeiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szeiger/subscriptions","organizations_url":"https://api.github.com/users/szeiger/orgs","repos_url":"https://api.github.com/users/szeiger/repos","events_url":"https://api.github.com/users/szeiger/events{/privacy}","received_events_url":"https://api.github.com/users/szeiger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/scala/scala/milestones/74","html_url":"https://github.com/scala/scala/milestone/74","labels_url":"https://api.github.com/repos/scala/scala/milestones/74/labels","id":3295287,"node_id":"MDk6TWlsZXN0b25lMzI5NTI4Nw==","number":74,"title":"2.13.0-M5","description":"Last milestone (feature-frozen; aka RC0).\r\nRelease lead: @SethTisue","creator":{"login":"lrytz","id":119636,"node_id":"MDQ6VXNlcjExOTYzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/119636?v=4","gravatar_id":"","url":"https://api.github.com/users/lrytz","html_url":"https://github.com/lrytz","followers_url":"https://api.github.com/users/lrytz/followers","following_url":"https://api.github.com/users/lrytz/following{/other_user}","gists_url":"https://api.github.com/users/lrytz/gists{/gist_id}","starred_url":"https://api.github.com/users/lrytz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrytz/subscriptions","organizations_url":"https://api.github.com/users/lrytz/orgs","repos_url":"https://api.github.com/users/lrytz/repos","events_url":"https://api.github.com/users/lrytz/events{/privacy}","received_events_url":"https://api.github.com/users/lrytz/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":394,"state":"open","created_at":"2018-04-25T07:15:17Z","updated_at":"2018-08-14T18:01:24Z","due_on":"2018-08-14T07:00:00Z","closed_at":null},"comments":4,"created_at":"2018-08-14T18:01:05Z","updated_at":"2018-08-15T10:53:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/scala/scala/pulls/7074","html_url":"https://github.com/scala/scala/pull/7074","diff_url":"https://github.com/scala/scala/pull/7074.diff","patch_url":"https://github.com/scala/scala/pull/7074.patch"},"body":"The `Map` and `Set` delegate factories already used them but now they\r\nare named `s.c.i.HashMap` and `s.c.i.HashSet`.\r\n\r\nThe old implementations are still available under `OldHashMap` and\r\n`OldHashSet` and they can still be selected by setting the environment\r\nvariable `SCALA_COLLECTION_IMMUTABLE_USE_BASELINE` to `true`.\r\n\r\n\r\nNow that @retronym's CHAMP changes have been merged we can rename the classes to make CHAMP the default. I deliberately renamed the old files (`HashSet.scala` -> `OldHashSet.scala`, same for Map) but not the new ones (`HashSet` is defined in `ChampHashSet.scala`) to make outstanding merges easier. We should clean that up when we remove the old implementations altogether (presumably for RC1)."},"comment":{"url":"https://api.github.com/repos/scala/scala/issues/comments/413162966","html_url":"https://github.com/scala/scala/pull/7074#issuecomment-413162966","issue_url":"https://api.github.com/repos/scala/scala/issues/7074","id":413162966,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzE2Mjk2Ng==","user":{"login":"szeiger","id":54262,"node_id":"MDQ6VXNlcjU0MjYy","avatar_url":"https://avatars3.githubusercontent.com/u/54262?v=4","gravatar_id":"","url":"https://api.github.com/users/szeiger","html_url":"https://github.com/szeiger","followers_url":"https://api.github.com/users/szeiger/followers","following_url":"https://api.github.com/users/szeiger/following{/other_user}","gists_url":"https://api.github.com/users/szeiger/gists{/gist_id}","starred_url":"https://api.github.com/users/szeiger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szeiger/subscriptions","organizations_url":"https://api.github.com/users/szeiger/orgs","repos_url":"https://api.github.com/users/szeiger/repos","events_url":"https://api.github.com/users/szeiger/events{/privacy}","received_events_url":"https://api.github.com/users/szeiger/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T10:53:18Z","updated_at":"2018-08-15T10:53:18Z","author_association":"CONTRIBUTOR","body":"I've added the public constructor and made the scalacheck tests compile but I'm getting one seemingly unrelated error in them:\r\n\r\n```\r\n[info] ! unliftable.unlift scala.symbol: Exception raised on property evaluation.\r\n[info] > Exception: java.lang.Error: bad constant value: 'foo of class class scala.Symbol\r\n[info] scala.reflect.internal.Constants$Constant.<init>(Constants.scala:51)\r\n[info] scala.reflect.internal.Constants$Constant$.apply(Constants.scala:33)\r\n[info] scala.reflect.internal.Constants$Constant$.apply(Constants.scala:272)\r\n[info] scala.reflect.quasiquotes.UnliftableProps$.$anonfun$new$26(UnliftableProps.scala:76)\r\n[info] scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:12)\r\n[info] scala.reflect.quasiquotes.Helpers.$anonfun$test$1(QuasiquoteProperties.scala:17)\r\n[info] org.scalacheck.Prop$.$anonfun$apply$1(Prop.scala:307)\r\n[info] org.scalacheck.PropFromFun.apply(Prop.scala:22)\r\n[info] org.scalacheck.Prop$.$anonfun$delay$1(Prop.scala:476)\r\n[info] org.scalacheck.Prop$.$anonfun$apply$1(Prop.scala:307)\r\n[info] org.scalacheck.PropFromFun.apply(Prop.scala:22)\r\n[info] org.scalacheck.Test$.workerFun$1(Test.scala:326)\r\n[info] org.scalacheck.Test$.$anonfun$check$1(Test.scala:355)\r\n[info] org.scalacheck.Test$.$anonfun$check$1$adapted(Test.scala:355)\r\n[info] org.scalacheck.Platform$.runWorkers(Platform.scala:40)\r\n[info] org.scalacheck.Test$.check(Test.scala:355)\r\n[info] org.scalacheck.CustomScalaCheckRunner$$anon$2.executeInternal(CustomScalaCheckRunner.scala:113)\r\n[info] org.scalacheck.CustomScalaCheckRunner$$anon$2.$anonfun$execute$10(CustomScalaCheckRunner.scala:105)\r\n[info] org.scalacheck.CustomScalaCheckRunner$$anon$2.$anonfun$execute$10$adapted(CustomScalaCheckRunner.scala:104)\r\n[info] scala.collection.IterableOnceOps.foreach(IterableOnce.scala:451)\r\n[info] scala.collection.IterableOnceOps.foreach$(IterableOnce.scala:449)\r\n[info] scala.collection.AbstractIterable.foreach(Iterable.scala:881)\r\n[info] scala.collection.IterableOps$WithFilter.foreach(Iterable.scala:867)\r\n[info] org.scalacheck.CustomScalaCheckRunner$$anon$2.execute(CustomScalaCheckRunner.scala:104)\r\n[info] sbt.ForkMain$Run$2.call(ForkMain.java:296)\r\n[info] sbt.ForkMain$Run$2.call(ForkMain.java:286)\r\n[info] java.util.concurrent.FutureTask.run(FutureTask.java:266)\r\n[info] java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)\r\n[info] java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)\r\n[info] java.lang.Thread.run(Thread.java:748)\r\n[info] Elapsed time: 0.005 sec\r\n```\r\n\r\n@retronym any ideas?"}}
{"actor":{"display_login":"szeiger"}}