{"action":"created","comment":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/201305759","pull_request_review_id":135778666,"id":201305759,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTMwNTc1OQ==","diff_hunk":"@@ -163,4 +165,57 @@ void FilteredTile::atomic_add(\n     }\n }\n \n+float FilteredTile::compute_weighted_pixel_variance(\n+    const float*        main,\n+    const float*        second)\n+{\n+    // Get weights.\n+    float main_weight = *main++;\n+    main_weight = main_weight == 0.0f ? 0.0f : 1.0f / main_weight;\n+    float second_weight = *second++;\n+    second_weight = second_weight == 0.0f ? 0.0f : 1.0f / second_weight;\n+\n+    // Get colors and assign weights.\n+    Color4f main_color(abs(main[0]), abs(main[1]), abs(main[2]), abs(main[3]));","path":"src/appleseed/foundation/image/filteredtile.cpp","position":24,"original_position":24,"commit_id":"4666162f6b31e24e25e339831916930609039e96","original_commit_id":"7a2946439eae4f6ec6d27c5e6b2dddc796929fa9","user":{"login":"oktomus","id":4656466,"node_id":"MDQ6VXNlcjQ2NTY0NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/4656466?v=4","gravatar_id":"","url":"https://api.github.com/users/oktomus","html_url":"https://github.com/oktomus","followers_url":"https://api.github.com/users/oktomus/followers","following_url":"https://api.github.com/users/oktomus/following{/other_user}","gists_url":"https://api.github.com/users/oktomus/gists{/gist_id}","starred_url":"https://api.github.com/users/oktomus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oktomus/subscriptions","organizations_url":"https://api.github.com/users/oktomus/orgs","repos_url":"https://api.github.com/users/oktomus/repos","events_url":"https://api.github.com/users/oktomus/events{/privacy}","received_events_url":"https://api.github.com/users/oktomus/received_events","type":"User","site_admin":false},"body":"Most of the times it was because of the filter that has negative weights ","created_at":"2018-07-10T11:20:58Z","updated_at":"2018-07-10T11:38:23Z","html_url":"https://github.com/appleseedhq/appleseed/pull/2062#discussion_r201305759","pull_request_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2062","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments/201305759"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/2062#discussion_r201305759"},"pull_request":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2062"}},"in_reply_to_id":201268608},"pull_request":{"url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2062","id":190910316,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwOTEwMzE2","html_url":"https://github.com/appleseedhq/appleseed/pull/2062","diff_url":"https://github.com/appleseedhq/appleseed/pull/2062.diff","patch_url":"https://github.com/appleseedhq/appleseed/pull/2062.patch","issue_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/2062","number":2062,"state":"open","locked":false,"title":"Adaptive sampling","user":{"login":"oktomus","id":4656466,"node_id":"MDQ6VXNlcjQ2NTY0NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/4656466?v=4","gravatar_id":"","url":"https://api.github.com/users/oktomus","html_url":"https://github.com/oktomus","followers_url":"https://api.github.com/users/oktomus/followers","following_url":"https://api.github.com/users/oktomus/following{/other_user}","gists_url":"https://api.github.com/users/oktomus/gists{/gist_id}","starred_url":"https://api.github.com/users/oktomus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oktomus/subscriptions","organizations_url":"https://api.github.com/users/oktomus/orgs","repos_url":"https://api.github.com/users/oktomus/repos","events_url":"https://api.github.com/users/oktomus/events{/privacy}","received_events_url":"https://api.github.com/users/oktomus/received_events","type":"User","site_admin":false},"body":"- Remove `PixelRenderer::enable_diagnostics` and rename `Frame::save_extra_aovs` to `Frame::enable_diagnostic_aovs`\r\n- Introduce Adatpive tile renderer\r\n\r\n**TODO**\r\n- Implement *invalid samples AOV* in the adaptive tile renderer\r\n","created_at":"2018-05-28T11:49:06Z","updated_at":"2018-07-10T11:38:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1cd419a7527a8bef5c4ee95122d9ce8dea7a7d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2062/commits","review_comments_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2062/comments","review_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/2062/comments","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/4666162f6b31e24e25e339831916930609039e96","head":{"label":"oktomus:adaptive-sampling","ref":"adaptive-sampling","sha":"4666162f6b31e24e25e339831916930609039e96","user":{"login":"oktomus","id":4656466,"node_id":"MDQ6VXNlcjQ2NTY0NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/4656466?v=4","gravatar_id":"","url":"https://api.github.com/users/oktomus","html_url":"https://github.com/oktomus","followers_url":"https://api.github.com/users/oktomus/followers","following_url":"https://api.github.com/users/oktomus/following{/other_user}","gists_url":"https://api.github.com/users/oktomus/gists{/gist_id}","starred_url":"https://api.github.com/users/oktomus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oktomus/subscriptions","organizations_url":"https://api.github.com/users/oktomus/orgs","repos_url":"https://api.github.com/users/oktomus/repos","events_url":"https://api.github.com/users/oktomus/events{/privacy}","received_events_url":"https://api.github.com/users/oktomus/received_events","type":"User","site_admin":false},"repo":{"id":122386792,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIzODY3OTI=","name":"appleseed","full_name":"oktomus/appleseed","owner":{"login":"oktomus","id":4656466,"node_id":"MDQ6VXNlcjQ2NTY0NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/4656466?v=4","gravatar_id":"","url":"https://api.github.com/users/oktomus","html_url":"https://github.com/oktomus","followers_url":"https://api.github.com/users/oktomus/followers","following_url":"https://api.github.com/users/oktomus/following{/other_user}","gists_url":"https://api.github.com/users/oktomus/gists{/gist_id}","starred_url":"https://api.github.com/users/oktomus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oktomus/subscriptions","organizations_url":"https://api.github.com/users/oktomus/orgs","repos_url":"https://api.github.com/users/oktomus/repos","events_url":"https://api.github.com/users/oktomus/events{/privacy}","received_events_url":"https://api.github.com/users/oktomus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oktomus/appleseed","description":"A modern open source rendering engine for animation and visual effects","fork":true,"url":"https://api.github.com/repos/oktomus/appleseed","forks_url":"https://api.github.com/repos/oktomus/appleseed/forks","keys_url":"https://api.github.com/repos/oktomus/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oktomus/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oktomus/appleseed/teams","hooks_url":"https://api.github.com/repos/oktomus/appleseed/hooks","issue_events_url":"https://api.github.com/repos/oktomus/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/oktomus/appleseed/events","assignees_url":"https://api.github.com/repos/oktomus/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/oktomus/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/oktomus/appleseed/tags","blobs_url":"https://api.github.com/repos/oktomus/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oktomus/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oktomus/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/oktomus/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oktomus/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/oktomus/appleseed/languages","stargazers_url":"https://api.github.com/repos/oktomus/appleseed/stargazers","contributors_url":"https://api.github.com/repos/oktomus/appleseed/contributors","subscribers_url":"https://api.github.com/repos/oktomus/appleseed/subscribers","subscription_url":"https://api.github.com/repos/oktomus/appleseed/subscription","commits_url":"https://api.github.com/repos/oktomus/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/oktomus/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/oktomus/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/oktomus/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/oktomus/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/oktomus/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oktomus/appleseed/merges","archive_url":"https://api.github.com/repos/oktomus/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oktomus/appleseed/downloads","issues_url":"https://api.github.com/repos/oktomus/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/oktomus/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/oktomus/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/oktomus/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oktomus/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/oktomus/appleseed/releases{/id}","deployments_url":"https://api.github.com/repos/oktomus/appleseed/deployments","created_at":"2018-02-21T20:02:17Z","updated_at":"2018-02-21T20:02:29Z","pushed_at":"2018-07-10T11:16:19Z","git_url":"git://github.com/oktomus/appleseed.git","ssh_url":"git@github.com:oktomus/appleseed.git","clone_url":"https://github.com/oktomus/appleseed.git","svn_url":"https://github.com/oktomus/appleseed","homepage":"http://appleseedhq.net/","size":1259774,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appleseedhq:master","ref":"master","sha":"6d7c2dff73a2bbe451ca3af3a3a31720306487c9","user":{"login":"appleseedhq","id":6373510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNzM1MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"repo":{"id":753784,"node_id":"MDEwOlJlcG9zaXRvcnk3NTM3ODQ=","name":"appleseed","full_name":"appleseedhq/appleseed","owner":{"login":"appleseedhq","id":6373510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNzM1MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6373510?v=4","gravatar_id":"","url":"https://api.github.com/users/appleseedhq","html_url":"https://github.com/appleseedhq","followers_url":"https://api.github.com/users/appleseedhq/followers","following_url":"https://api.github.com/users/appleseedhq/following{/other_user}","gists_url":"https://api.github.com/users/appleseedhq/gists{/gist_id}","starred_url":"https://api.github.com/users/appleseedhq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appleseedhq/subscriptions","organizations_url":"https://api.github.com/users/appleseedhq/orgs","repos_url":"https://api.github.com/users/appleseedhq/repos","events_url":"https://api.github.com/users/appleseedhq/events{/privacy}","received_events_url":"https://api.github.com/users/appleseedhq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appleseedhq/appleseed","description":"A modern open source rendering engine for animation and visual effects","fork":false,"url":"https://api.github.com/repos/appleseedhq/appleseed","forks_url":"https://api.github.com/repos/appleseedhq/appleseed/forks","keys_url":"https://api.github.com/repos/appleseedhq/appleseed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appleseedhq/appleseed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appleseedhq/appleseed/teams","hooks_url":"https://api.github.com/repos/appleseedhq/appleseed/hooks","issue_events_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/events{/number}","events_url":"https://api.github.com/repos/appleseedhq/appleseed/events","assignees_url":"https://api.github.com/repos/appleseedhq/appleseed/assignees{/user}","branches_url":"https://api.github.com/repos/appleseedhq/appleseed/branches{/branch}","tags_url":"https://api.github.com/repos/appleseedhq/appleseed/tags","blobs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appleseedhq/appleseed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appleseedhq/appleseed/git/refs{/sha}","trees_url":"https://api.github.com/repos/appleseedhq/appleseed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appleseedhq/appleseed/statuses/{sha}","languages_url":"https://api.github.com/repos/appleseedhq/appleseed/languages","stargazers_url":"https://api.github.com/repos/appleseedhq/appleseed/stargazers","contributors_url":"https://api.github.com/repos/appleseedhq/appleseed/contributors","subscribers_url":"https://api.github.com/repos/appleseedhq/appleseed/subscribers","subscription_url":"https://api.github.com/repos/appleseedhq/appleseed/subscription","commits_url":"https://api.github.com/repos/appleseedhq/appleseed/commits{/sha}","git_commits_url":"https://api.github.com/repos/appleseedhq/appleseed/git/commits{/sha}","comments_url":"https://api.github.com/repos/appleseedhq/appleseed/comments{/number}","issue_comment_url":"https://api.github.com/repos/appleseedhq/appleseed/issues/comments{/number}","contents_url":"https://api.github.com/repos/appleseedhq/appleseed/contents/{+path}","compare_url":"https://api.github.com/repos/appleseedhq/appleseed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appleseedhq/appleseed/merges","archive_url":"https://api.github.com/repos/appleseedhq/appleseed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appleseedhq/appleseed/downloads","issues_url":"https://api.github.com/repos/appleseedhq/appleseed/issues{/number}","pulls_url":"https://api.github.com/repos/appleseedhq/appleseed/pulls{/number}","milestones_url":"https://api.github.com/repos/appleseedhq/appleseed/milestones{/number}","notifications_url":"https://api.github.com/repos/appleseedhq/appleseed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appleseedhq/appleseed/labels{/name}","releases_url":"https://api.github.com/repos/appleseedhq/appleseed/releases{/id}","deployments_url":"https://api.github.com/repos/appleseedhq/appleseed/deployments","created_at":"2010-07-02T16:33:51Z","updated_at":"2018-07-09T07:34:10Z","pushed_at":"2018-07-10T11:16:20Z","git_url":"git://github.com/appleseedhq/appleseed.git","ssh_url":"git@github.com:appleseedhq/appleseed.git","clone_url":"https://github.com/appleseedhq/appleseed.git","svn_url":"https://github.com/appleseedhq/appleseed","homepage":"https://appleseedhq.net/","size":1259649,"stargazers_count":1010,"watchers_count":1010,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":184,"mirror_url":null,"archived":false,"open_issues_count":349,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":184,"open_issues":349,"watchers":1010,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2062"},"html":{"href":"https://github.com/appleseedhq/appleseed/pull/2062"},"issue":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/2062"},"comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/issues/2062/comments"},"review_comments":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2062/comments"},"review_comment":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appleseedhq/appleseed/pulls/2062/commits"},"statuses":{"href":"https://api.github.com/repos/appleseedhq/appleseed/statuses/4666162f6b31e24e25e339831916930609039e96"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"oktomus"}}