{"action":"created","comment":{"url":"https://api.github.com/repos/ngxs/store/pulls/comments/178672213","pull_request_review_id":108768338,"id":178672213,"diff_hunk":"@@ -1,6 +1,16 @@\n-import { ensureStoreMetadata, getTypeFromKlass } from './internals';\n+import { ensureStoreMetadata, uuid } from './internals';\n import { ActionOptions } from './symbols';\n \n+export class ActionToken {\n+  private readonly stamp = uuid();\n+\n+  constructor(public readonly desc: string) {}\n+\n+  toString(): string {\n+    return `ActionToken ${this.desc} ${this.stamp}`;","path":"packages/store/src/action.ts","position":11,"original_position":11,"commit_id":"a94dd467ae15cb33182cc4ba2ac0be23b4ce4098","original_commit_id":"a94dd467ae15cb33182cc4ba2ac0be23b4ce4098","user":{"login":"deebloo","id":6563621,"avatar_url":"https://avatars0.githubusercontent.com/u/6563621?v=4","gravatar_id":"","url":"https://api.github.com/users/deebloo","html_url":"https://github.com/deebloo","followers_url":"https://api.github.com/users/deebloo/followers","following_url":"https://api.github.com/users/deebloo/following{/other_user}","gists_url":"https://api.github.com/users/deebloo/gists{/gist_id}","starred_url":"https://api.github.com/users/deebloo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deebloo/subscriptions","organizations_url":"https://api.github.com/users/deebloo/orgs","repos_url":"https://api.github.com/users/deebloo/repos","events_url":"https://api.github.com/users/deebloo/events{/privacy}","received_events_url":"https://api.github.com/users/deebloo/received_events","type":"User","site_admin":false},"body":"we sure could","created_at":"2018-04-02T22:52:53Z","updated_at":"2018-04-02T22:52:54Z","html_url":"https://github.com/ngxs/store/pull/212#discussion_r178672213","pull_request_url":"https://api.github.com/repos/ngxs/store/pulls/212","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ngxs/store/pulls/comments/178672213"},"html":{"href":"https://github.com/ngxs/store/pull/212#discussion_r178672213"},"pull_request":{"href":"https://api.github.com/repos/ngxs/store/pulls/212"}},"in_reply_to_id":178669487},"pull_request":{"url":"https://api.github.com/repos/ngxs/store/pulls/212","id":178904048,"html_url":"https://github.com/ngxs/store/pull/212","diff_url":"https://github.com/ngxs/store/pull/212.diff","patch_url":"https://github.com/ngxs/store/pull/212.patch","issue_url":"https://api.github.com/repos/ngxs/store/issues/212","number":212,"state":"open","locked":false,"title":"WIP: fix(store): always set action type","user":{"login":"deebloo","id":6563621,"avatar_url":"https://avatars0.githubusercontent.com/u/6563621?v=4","gravatar_id":"","url":"https://api.github.com/users/deebloo","html_url":"https://github.com/deebloo","followers_url":"https://api.github.com/users/deebloo/followers","following_url":"https://api.github.com/users/deebloo/following{/other_user}","gists_url":"https://api.github.com/users/deebloo/gists{/gist_id}","starred_url":"https://api.github.com/users/deebloo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deebloo/subscriptions","organizations_url":"https://api.github.com/users/deebloo/orgs","repos_url":"https://api.github.com/users/deebloo/repos","events_url":"https://api.github.com/users/deebloo/events{/privacy}","received_events_url":"https://api.github.com/users/deebloo/received_events","type":"User","site_admin":false},"body":"The goal of this PR is to mitigate any minification or name collision issues.\r\n\r\nMy First thought was to use Symbol but since that isn't supported by any IE browsers id rather not force folks to depend on a polyfill so I am thinking use a small Token class and use that as the token if none is provided. The hope here is to create completely unique actions without depending on the user to add a static property themselves.\r\n\r\nQuestions:\r\nHow would this impact plugins? - solved\r\nAre there performance implications?\r\n\r\nFixes #200\r\n\r\n@amcdnl @leon","created_at":"2018-04-02T18:56:18Z","updated_at":"2018-04-02T22:52:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60fccaafc76768da8db0ff2b1bc132ccf1e3366d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"leon","id":13211,"avatar_url":"https://avatars2.githubusercontent.com/u/13211?v=4","gravatar_id":"","url":"https://api.github.com/users/leon","html_url":"https://github.com/leon","followers_url":"https://api.github.com/users/leon/followers","following_url":"https://api.github.com/users/leon/following{/other_user}","gists_url":"https://api.github.com/users/leon/gists{/gist_id}","starred_url":"https://api.github.com/users/leon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leon/subscriptions","organizations_url":"https://api.github.com/users/leon/orgs","repos_url":"https://api.github.com/users/leon/repos","events_url":"https://api.github.com/users/leon/events{/privacy}","received_events_url":"https://api.github.com/users/leon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ngxs/store/pulls/212/commits","review_comments_url":"https://api.github.com/repos/ngxs/store/pulls/212/comments","review_comment_url":"https://api.github.com/repos/ngxs/store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ngxs/store/issues/212/comments","statuses_url":"https://api.github.com/repos/ngxs/store/statuses/a94dd467ae15cb33182cc4ba2ac0be23b4ce4098","head":{"label":"ngxs:action-types","ref":"action-types","sha":"a94dd467ae15cb33182cc4ba2ac0be23b4ce4098","user":{"login":"ngxs","id":37132593,"avatar_url":"https://avatars2.githubusercontent.com/u/37132593?v=4","gravatar_id":"","url":"https://api.github.com/users/ngxs","html_url":"https://github.com/ngxs","followers_url":"https://api.github.com/users/ngxs/followers","following_url":"https://api.github.com/users/ngxs/following{/other_user}","gists_url":"https://api.github.com/users/ngxs/gists{/gist_id}","starred_url":"https://api.github.com/users/ngxs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngxs/subscriptions","organizations_url":"https://api.github.com/users/ngxs/orgs","repos_url":"https://api.github.com/users/ngxs/repos","events_url":"https://api.github.com/users/ngxs/events{/privacy}","received_events_url":"https://api.github.com/users/ngxs/received_events","type":"Organization","site_admin":false},"repo":{"id":121422793,"name":"store","full_name":"ngxs/store","owner":{"login":"ngxs","id":37132593,"avatar_url":"https://avatars2.githubusercontent.com/u/37132593?v=4","gravatar_id":"","url":"https://api.github.com/users/ngxs","html_url":"https://github.com/ngxs","followers_url":"https://api.github.com/users/ngxs/followers","following_url":"https://api.github.com/users/ngxs/following{/other_user}","gists_url":"https://api.github.com/users/ngxs/gists{/gist_id}","starred_url":"https://api.github.com/users/ngxs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngxs/subscriptions","organizations_url":"https://api.github.com/users/ngxs/orgs","repos_url":"https://api.github.com/users/ngxs/repos","events_url":"https://api.github.com/users/ngxs/events{/privacy}","received_events_url":"https://api.github.com/users/ngxs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ngxs/store","description":"🚀 NGXS - State Management for Angular ","fork":false,"url":"https://api.github.com/repos/ngxs/store","forks_url":"https://api.github.com/repos/ngxs/store/forks","keys_url":"https://api.github.com/repos/ngxs/store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngxs/store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngxs/store/teams","hooks_url":"https://api.github.com/repos/ngxs/store/hooks","issue_events_url":"https://api.github.com/repos/ngxs/store/issues/events{/number}","events_url":"https://api.github.com/repos/ngxs/store/events","assignees_url":"https://api.github.com/repos/ngxs/store/assignees{/user}","branches_url":"https://api.github.com/repos/ngxs/store/branches{/branch}","tags_url":"https://api.github.com/repos/ngxs/store/tags","blobs_url":"https://api.github.com/repos/ngxs/store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngxs/store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngxs/store/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngxs/store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngxs/store/statuses/{sha}","languages_url":"https://api.github.com/repos/ngxs/store/languages","stargazers_url":"https://api.github.com/repos/ngxs/store/stargazers","contributors_url":"https://api.github.com/repos/ngxs/store/contributors","subscribers_url":"https://api.github.com/repos/ngxs/store/subscribers","subscription_url":"https://api.github.com/repos/ngxs/store/subscription","commits_url":"https://api.github.com/repos/ngxs/store/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngxs/store/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngxs/store/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngxs/store/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngxs/store/contents/{+path}","compare_url":"https://api.github.com/repos/ngxs/store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngxs/store/merges","archive_url":"https://api.github.com/repos/ngxs/store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngxs/store/downloads","issues_url":"https://api.github.com/repos/ngxs/store/issues{/number}","pulls_url":"https://api.github.com/repos/ngxs/store/pulls{/number}","milestones_url":"https://api.github.com/repos/ngxs/store/milestones{/number}","notifications_url":"https://api.github.com/repos/ngxs/store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngxs/store/labels{/name}","releases_url":"https://api.github.com/repos/ngxs/store/releases{/id}","deployments_url":"https://api.github.com/repos/ngxs/store/deployments","created_at":"2018-02-13T18:55:44Z","updated_at":"2018-04-02T22:36:38Z","pushed_at":"2018-04-02T19:21:56Z","git_url":"git://github.com/ngxs/store.git","ssh_url":"git@github.com:ngxs/store.git","clone_url":"https://github.com/ngxs/store.git","svn_url":"https://github.com/ngxs/store","homepage":"https://ngxs.gitbooks.io/ngxs/","size":1034,"stargazers_count":451,"watchers_count":451,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":34,"license":null,"forks":40,"open_issues":34,"watchers":451,"default_branch":"master"}},"base":{"label":"ngxs:master","ref":"master","sha":"50f0444f91a545035b186308d0db5f791c08bfbb","user":{"login":"ngxs","id":37132593,"avatar_url":"https://avatars2.githubusercontent.com/u/37132593?v=4","gravatar_id":"","url":"https://api.github.com/users/ngxs","html_url":"https://github.com/ngxs","followers_url":"https://api.github.com/users/ngxs/followers","following_url":"https://api.github.com/users/ngxs/following{/other_user}","gists_url":"https://api.github.com/users/ngxs/gists{/gist_id}","starred_url":"https://api.github.com/users/ngxs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngxs/subscriptions","organizations_url":"https://api.github.com/users/ngxs/orgs","repos_url":"https://api.github.com/users/ngxs/repos","events_url":"https://api.github.com/users/ngxs/events{/privacy}","received_events_url":"https://api.github.com/users/ngxs/received_events","type":"Organization","site_admin":false},"repo":{"id":121422793,"name":"store","full_name":"ngxs/store","owner":{"login":"ngxs","id":37132593,"avatar_url":"https://avatars2.githubusercontent.com/u/37132593?v=4","gravatar_id":"","url":"https://api.github.com/users/ngxs","html_url":"https://github.com/ngxs","followers_url":"https://api.github.com/users/ngxs/followers","following_url":"https://api.github.com/users/ngxs/following{/other_user}","gists_url":"https://api.github.com/users/ngxs/gists{/gist_id}","starred_url":"https://api.github.com/users/ngxs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngxs/subscriptions","organizations_url":"https://api.github.com/users/ngxs/orgs","repos_url":"https://api.github.com/users/ngxs/repos","events_url":"https://api.github.com/users/ngxs/events{/privacy}","received_events_url":"https://api.github.com/users/ngxs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ngxs/store","description":"🚀 NGXS - State Management for Angular ","fork":false,"url":"https://api.github.com/repos/ngxs/store","forks_url":"https://api.github.com/repos/ngxs/store/forks","keys_url":"https://api.github.com/repos/ngxs/store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngxs/store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngxs/store/teams","hooks_url":"https://api.github.com/repos/ngxs/store/hooks","issue_events_url":"https://api.github.com/repos/ngxs/store/issues/events{/number}","events_url":"https://api.github.com/repos/ngxs/store/events","assignees_url":"https://api.github.com/repos/ngxs/store/assignees{/user}","branches_url":"https://api.github.com/repos/ngxs/store/branches{/branch}","tags_url":"https://api.github.com/repos/ngxs/store/tags","blobs_url":"https://api.github.com/repos/ngxs/store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngxs/store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngxs/store/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngxs/store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngxs/store/statuses/{sha}","languages_url":"https://api.github.com/repos/ngxs/store/languages","stargazers_url":"https://api.github.com/repos/ngxs/store/stargazers","contributors_url":"https://api.github.com/repos/ngxs/store/contributors","subscribers_url":"https://api.github.com/repos/ngxs/store/subscribers","subscription_url":"https://api.github.com/repos/ngxs/store/subscription","commits_url":"https://api.github.com/repos/ngxs/store/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngxs/store/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngxs/store/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngxs/store/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngxs/store/contents/{+path}","compare_url":"https://api.github.com/repos/ngxs/store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngxs/store/merges","archive_url":"https://api.github.com/repos/ngxs/store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngxs/store/downloads","issues_url":"https://api.github.com/repos/ngxs/store/issues{/number}","pulls_url":"https://api.github.com/repos/ngxs/store/pulls{/number}","milestones_url":"https://api.github.com/repos/ngxs/store/milestones{/number}","notifications_url":"https://api.github.com/repos/ngxs/store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngxs/store/labels{/name}","releases_url":"https://api.github.com/repos/ngxs/store/releases{/id}","deployments_url":"https://api.github.com/repos/ngxs/store/deployments","created_at":"2018-02-13T18:55:44Z","updated_at":"2018-04-02T22:36:38Z","pushed_at":"2018-04-02T19:21:56Z","git_url":"git://github.com/ngxs/store.git","ssh_url":"git@github.com:ngxs/store.git","clone_url":"https://github.com/ngxs/store.git","svn_url":"https://github.com/ngxs/store","homepage":"https://ngxs.gitbooks.io/ngxs/","size":1034,"stargazers_count":451,"watchers_count":451,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":34,"license":null,"forks":40,"open_issues":34,"watchers":451,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ngxs/store/pulls/212"},"html":{"href":"https://github.com/ngxs/store/pull/212"},"issue":{"href":"https://api.github.com/repos/ngxs/store/issues/212"},"comments":{"href":"https://api.github.com/repos/ngxs/store/issues/212/comments"},"review_comments":{"href":"https://api.github.com/repos/ngxs/store/pulls/212/comments"},"review_comment":{"href":"https://api.github.com/repos/ngxs/store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ngxs/store/pulls/212/commits"},"statuses":{"href":"https://api.github.com/repos/ngxs/store/statuses/a94dd467ae15cb33182cc4ba2ac0be23b4ce4098"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"deebloo"}}