{"action":"created","comment":{"url":"https://api.github.com/repos/devtools-html/perf.html/pulls/comments/175502111","pull_request_review_id":105037657,"id":175502111,"diff_hunk":"@@ -978,20 +979,45 @@ export function getTracingMarkers(thread: Thread): TracingMarker[] {\n       };\n       tracingMarkers.push(marker);\n     } else if (data.type === 'tracing') {\n+      // Tracing markers come in the form of 2 distinct markers: the first is\n+      // emitted at the start of some process, the second at the end. We convert\n+      // these 2 one-time markers into one marker with a non-null duration.\n+      // We also handle nested markers by assuming markers of the same type are\n+      // never interwoven: given input markers startA, startB, endC, endD, we'll\n+      // get 2 markers A-D and B-C.\n+      // This is implemented by AutoProfilerTracing in Gecko.","path":"src/profile-logic/profile-data.js","position":20,"original_position":20,"commit_id":"3f82611b5730f5cae7cba19181c52bed4e7ad00a","original_commit_id":"4d1db01aad931497149637a151047b5565aa920a","user":{"login":"gregtatum","id":1588648,"avatar_url":"https://avatars3.githubusercontent.com/u/1588648?v=4","gravatar_id":"","url":"https://api.github.com/users/gregtatum","html_url":"https://github.com/gregtatum","followers_url":"https://api.github.com/users/gregtatum/followers","following_url":"https://api.github.com/users/gregtatum/following{/other_user}","gists_url":"https://api.github.com/users/gregtatum/gists{/gist_id}","starred_url":"https://api.github.com/users/gregtatum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregtatum/subscriptions","organizations_url":"https://api.github.com/users/gregtatum/orgs","repos_url":"https://api.github.com/users/gregtatum/repos","events_url":"https://api.github.com/users/gregtatum/events{/privacy}","received_events_url":"https://api.github.com/users/gregtatum/received_events","type":"User","site_admin":false},"body":"I got confused by the use of numbers (like `2 one-time`), and the word `process`. How about this phrasing?\r\n\r\n```\r\n// Tracing markers are created from two distinct markers that are created at\r\n// the start and end of whatever code that is running that we care about. We\r\n// convert both of these raw markers into a single tracing marker with a\r\n// non-null duration. This is implemented by AutoProfilerTracing in Gecko.\r\n//\r\n// We also handle nested markers by assuming markers of the same type are\r\n// never interwoven: given input markers startA, startB, endC, endD, we'll\r\n// get 2 markers A-D and B-C.\r\n```\r\n\r\n","created_at":"2018-03-19T16:38:51Z","updated_at":"2018-03-19T16:56:57Z","html_url":"https://github.com/devtools-html/perf.html/pull/864#discussion_r175502111","pull_request_url":"https://api.github.com/repos/devtools-html/perf.html/pulls/864","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/devtools-html/perf.html/pulls/comments/175502111"},"html":{"href":"https://github.com/devtools-html/perf.html/pull/864#discussion_r175502111"},"pull_request":{"href":"https://api.github.com/repos/devtools-html/perf.html/pulls/864"}}},"pull_request":{"url":"https://api.github.com/repos/devtools-html/perf.html/pulls/864","id":175614487,"html_url":"https://github.com/devtools-html/perf.html/pull/864","diff_url":"https://github.com/devtools-html/perf.html/pull/864.diff","patch_url":"https://github.com/devtools-html/perf.html/pull/864.patch","issue_url":"https://api.github.com/repos/devtools-html/perf.html/issues/864","number":864,"state":"open","locked":false,"title":"Properly handles nested tracing markers as well as tracing markers without a start or an end.","user":{"login":"julienw","id":454175,"avatar_url":"https://avatars0.githubusercontent.com/u/454175?v=4","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"body":"Fixes #644, as well as the perf.html part of #606","created_at":"2018-03-16T18:36:31Z","updated_at":"2018-03-19T16:56:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dedfd11b63e9b593d843bedcc58bbe9b1980b61f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/devtools-html/perf.html/pulls/864/commits","review_comments_url":"https://api.github.com/repos/devtools-html/perf.html/pulls/864/comments","review_comment_url":"https://api.github.com/repos/devtools-html/perf.html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/devtools-html/perf.html/issues/864/comments","statuses_url":"https://api.github.com/repos/devtools-html/perf.html/statuses/3f82611b5730f5cae7cba19181c52bed4e7ad00a","head":{"label":"julienw:644-fix-nested-markers","ref":"644-fix-nested-markers","sha":"3f82611b5730f5cae7cba19181c52bed4e7ad00a","user":{"login":"julienw","id":454175,"avatar_url":"https://avatars0.githubusercontent.com/u/454175?v=4","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"repo":{"id":85606366,"name":"perf.html","full_name":"julienw/perf.html","owner":{"login":"julienw","id":454175,"avatar_url":"https://avatars0.githubusercontent.com/u/454175?v=4","gravatar_id":"","url":"https://api.github.com/users/julienw","html_url":"https://github.com/julienw","followers_url":"https://api.github.com/users/julienw/followers","following_url":"https://api.github.com/users/julienw/following{/other_user}","gists_url":"https://api.github.com/users/julienw/gists{/gist_id}","starred_url":"https://api.github.com/users/julienw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julienw/subscriptions","organizations_url":"https://api.github.com/users/julienw/orgs","repos_url":"https://api.github.com/users/julienw/repos","events_url":"https://api.github.com/users/julienw/events{/privacy}","received_events_url":"https://api.github.com/users/julienw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/julienw/perf.html","description":"Firefox Performance tools for the web, by the web 🛥","fork":true,"url":"https://api.github.com/repos/julienw/perf.html","forks_url":"https://api.github.com/repos/julienw/perf.html/forks","keys_url":"https://api.github.com/repos/julienw/perf.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/julienw/perf.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/julienw/perf.html/teams","hooks_url":"https://api.github.com/repos/julienw/perf.html/hooks","issue_events_url":"https://api.github.com/repos/julienw/perf.html/issues/events{/number}","events_url":"https://api.github.com/repos/julienw/perf.html/events","assignees_url":"https://api.github.com/repos/julienw/perf.html/assignees{/user}","branches_url":"https://api.github.com/repos/julienw/perf.html/branches{/branch}","tags_url":"https://api.github.com/repos/julienw/perf.html/tags","blobs_url":"https://api.github.com/repos/julienw/perf.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/julienw/perf.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/julienw/perf.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/julienw/perf.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/julienw/perf.html/statuses/{sha}","languages_url":"https://api.github.com/repos/julienw/perf.html/languages","stargazers_url":"https://api.github.com/repos/julienw/perf.html/stargazers","contributors_url":"https://api.github.com/repos/julienw/perf.html/contributors","subscribers_url":"https://api.github.com/repos/julienw/perf.html/subscribers","subscription_url":"https://api.github.com/repos/julienw/perf.html/subscription","commits_url":"https://api.github.com/repos/julienw/perf.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/julienw/perf.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/julienw/perf.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/julienw/perf.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/julienw/perf.html/contents/{+path}","compare_url":"https://api.github.com/repos/julienw/perf.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/julienw/perf.html/merges","archive_url":"https://api.github.com/repos/julienw/perf.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/julienw/perf.html/downloads","issues_url":"https://api.github.com/repos/julienw/perf.html/issues{/number}","pulls_url":"https://api.github.com/repos/julienw/perf.html/pulls{/number}","milestones_url":"https://api.github.com/repos/julienw/perf.html/milestones{/number}","notifications_url":"https://api.github.com/repos/julienw/perf.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/julienw/perf.html/labels{/name}","releases_url":"https://api.github.com/repos/julienw/perf.html/releases{/id}","deployments_url":"https://api.github.com/repos/julienw/perf.html/deployments","created_at":"2017-03-20T17:30:11Z","updated_at":"2017-03-20T17:30:13Z","pushed_at":"2018-03-19T13:27:15Z","git_url":"git://github.com/julienw/perf.html.git","ssh_url":"git@github.com:julienw/perf.html.git","clone_url":"https://github.com/julienw/perf.html.git","svn_url":"https://github.com/julienw/perf.html","homepage":"https://perf-html.io/","size":6197,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"devtools-html:master","ref":"master","sha":"65bb73ae5a971cd21c88aeaccb9a5a09f4edb029","user":{"login":"devtools-html","id":19979421,"avatar_url":"https://avatars2.githubusercontent.com/u/19979421?v=4","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"repo":{"id":3607308,"name":"perf.html","full_name":"devtools-html/perf.html","owner":{"login":"devtools-html","id":19979421,"avatar_url":"https://avatars2.githubusercontent.com/u/19979421?v=4","gravatar_id":"","url":"https://api.github.com/users/devtools-html","html_url":"https://github.com/devtools-html","followers_url":"https://api.github.com/users/devtools-html/followers","following_url":"https://api.github.com/users/devtools-html/following{/other_user}","gists_url":"https://api.github.com/users/devtools-html/gists{/gist_id}","starred_url":"https://api.github.com/users/devtools-html/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devtools-html/subscriptions","organizations_url":"https://api.github.com/users/devtools-html/orgs","repos_url":"https://api.github.com/users/devtools-html/repos","events_url":"https://api.github.com/users/devtools-html/events{/privacy}","received_events_url":"https://api.github.com/users/devtools-html/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/devtools-html/perf.html","description":"Firefox Performance tools for the web, by the web 🛥","fork":false,"url":"https://api.github.com/repos/devtools-html/perf.html","forks_url":"https://api.github.com/repos/devtools-html/perf.html/forks","keys_url":"https://api.github.com/repos/devtools-html/perf.html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/devtools-html/perf.html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/devtools-html/perf.html/teams","hooks_url":"https://api.github.com/repos/devtools-html/perf.html/hooks","issue_events_url":"https://api.github.com/repos/devtools-html/perf.html/issues/events{/number}","events_url":"https://api.github.com/repos/devtools-html/perf.html/events","assignees_url":"https://api.github.com/repos/devtools-html/perf.html/assignees{/user}","branches_url":"https://api.github.com/repos/devtools-html/perf.html/branches{/branch}","tags_url":"https://api.github.com/repos/devtools-html/perf.html/tags","blobs_url":"https://api.github.com/repos/devtools-html/perf.html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/devtools-html/perf.html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/devtools-html/perf.html/git/refs{/sha}","trees_url":"https://api.github.com/repos/devtools-html/perf.html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/devtools-html/perf.html/statuses/{sha}","languages_url":"https://api.github.com/repos/devtools-html/perf.html/languages","stargazers_url":"https://api.github.com/repos/devtools-html/perf.html/stargazers","contributors_url":"https://api.github.com/repos/devtools-html/perf.html/contributors","subscribers_url":"https://api.github.com/repos/devtools-html/perf.html/subscribers","subscription_url":"https://api.github.com/repos/devtools-html/perf.html/subscription","commits_url":"https://api.github.com/repos/devtools-html/perf.html/commits{/sha}","git_commits_url":"https://api.github.com/repos/devtools-html/perf.html/git/commits{/sha}","comments_url":"https://api.github.com/repos/devtools-html/perf.html/comments{/number}","issue_comment_url":"https://api.github.com/repos/devtools-html/perf.html/issues/comments{/number}","contents_url":"https://api.github.com/repos/devtools-html/perf.html/contents/{+path}","compare_url":"https://api.github.com/repos/devtools-html/perf.html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/devtools-html/perf.html/merges","archive_url":"https://api.github.com/repos/devtools-html/perf.html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/devtools-html/perf.html/downloads","issues_url":"https://api.github.com/repos/devtools-html/perf.html/issues{/number}","pulls_url":"https://api.github.com/repos/devtools-html/perf.html/pulls{/number}","milestones_url":"https://api.github.com/repos/devtools-html/perf.html/milestones{/number}","notifications_url":"https://api.github.com/repos/devtools-html/perf.html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/devtools-html/perf.html/labels{/name}","releases_url":"https://api.github.com/repos/devtools-html/perf.html/releases{/id}","deployments_url":"https://api.github.com/repos/devtools-html/perf.html/deployments","created_at":"2012-03-02T23:55:22Z","updated_at":"2018-03-19T16:21:58Z","pushed_at":"2018-03-19T16:21:55Z","git_url":"git://github.com/devtools-html/perf.html.git","ssh_url":"git@github.com:devtools-html/perf.html.git","clone_url":"https://github.com/devtools-html/perf.html.git","svn_url":"https://github.com/devtools-html/perf.html","homepage":"https://perf-html.io/","size":5860,"stargazers_count":149,"watchers_count":149,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":210,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":52,"open_issues":210,"watchers":149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/devtools-html/perf.html/pulls/864"},"html":{"href":"https://github.com/devtools-html/perf.html/pull/864"},"issue":{"href":"https://api.github.com/repos/devtools-html/perf.html/issues/864"},"comments":{"href":"https://api.github.com/repos/devtools-html/perf.html/issues/864/comments"},"review_comments":{"href":"https://api.github.com/repos/devtools-html/perf.html/pulls/864/comments"},"review_comment":{"href":"https://api.github.com/repos/devtools-html/perf.html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/devtools-html/perf.html/pulls/864/commits"},"statuses":{"href":"https://api.github.com/repos/devtools-html/perf.html/statuses/3f82611b5730f5cae7cba19181c52bed4e7ad00a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gregtatum"}}