{"action":"created","issue":{"url":"https://api.github.com/repos/fsprojects/Paket/issues/3012","repository_url":"https://api.github.com/repos/fsprojects/Paket","labels_url":"https://api.github.com/repos/fsprojects/Paket/issues/3012/labels{/name}","comments_url":"https://api.github.com/repos/fsprojects/Paket/issues/3012/comments","events_url":"https://api.github.com/repos/fsprojects/Paket/issues/3012/events","html_url":"https://github.com/fsprojects/Paket/issues/3012","id":291524202,"number":3012,"title":"Paket restore silently fails when TargetFramework(s) are specified in Directory.Build.props and not csproj","user":{"login":"msatina","id":20299309,"avatar_url":"https://avatars2.githubusercontent.com/u/20299309?v=4","gravatar_id":"","url":"https://api.github.com/users/msatina","html_url":"https://github.com/msatina","followers_url":"https://api.github.com/users/msatina/followers","following_url":"https://api.github.com/users/msatina/following{/other_user}","gists_url":"https://api.github.com/users/msatina/gists{/gist_id}","starred_url":"https://api.github.com/users/msatina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msatina/subscriptions","organizations_url":"https://api.github.com/users/msatina/orgs","repos_url":"https://api.github.com/users/msatina/repos","events_url":"https://api.github.com/users/msatina/events{/privacy}","received_events_url":"https://api.github.com/users/msatina/received_events","type":"User","site_admin":false},"labels":[{"id":120459169,"url":"https://api.github.com/repos/fsprojects/Paket/labels/bug","name":"bug","color":"fc2929","default":true},{"id":814981286,"url":"https://api.github.com/repos/fsprojects/Paket/labels/msbuild%20proj","name":"msbuild proj","color":"ce6654","default":false},{"id":813789166,"url":"https://api.github.com/repos/fsprojects/Paket/labels/sdk:%20dotnet/sdk","name":"sdk: dotnet/sdk","color":"d178db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-01-25T10:41:11Z","updated_at":"2018-02-11T21:17:41Z","closed_at":null,"author_association":"NONE","body":"### Description\r\n\r\nWhen TargetFramework(s) are defined in Directory.Build.props Paket restore silently fails, it should be able to get it from msbuild at runtime.\r\n\r\n### Repro steps\r\n\r\nHave Directory.Build.props in solution root folder e.g.:\r\n\r\n```xml\r\n<Project>\r\n <Import Project=\".\\Versions.props\"/>\r\n  <PropertyGroup>\r\n      <FullFrameworkVersion>net462</FullFrameworkVersion>\r\n   </PropertyGroup>\r\n</Project>\r\n```\r\n\r\nand then use the property to define TargetFramework in underlying project files, e.g.:\r\n\r\n```xml\r\n<Project Sdk=\"Microsoft.NET.Sdk\">\r\n  <PropertyGroup>\r\n   <TargetFramework>$(FullFrameworkVersion)</TargetFramework>\r\n    <AssemblyName>SomeAssembly</AssemblyName>\r\n...\r\n  </PropertyGroup>\r\n  <Import Project=\"..\\..\\.paket\\Paket.Restore.targets\" />\r\n</Project>\r\n```\r\n\r\n### Expected behavior\r\n**Paket restore** shouldn't silently fail. Ideally it should be able to get Framework information from msbuild from runtime.\r\n\r\n### Actual behavior\r\n**Paket restore** is not able to get TargetFramework(s) information from project file and silently fails.\r\n\r\n### Known workarounds\r\nDon't define TargetFramework in Directory.Build.props .\r\n#3013 "},"comment":{"url":"https://api.github.com/repos/fsprojects/Paket/issues/comments/364789667","html_url":"https://github.com/fsprojects/Paket/issues/3012#issuecomment-364789667","issue_url":"https://api.github.com/repos/fsprojects/Paket/issues/3012","id":364789667,"user":{"login":"vbfox","id":131878,"avatar_url":"https://avatars0.githubusercontent.com/u/131878?v=4","gravatar_id":"","url":"https://api.github.com/users/vbfox","html_url":"https://github.com/vbfox","followers_url":"https://api.github.com/users/vbfox/followers","following_url":"https://api.github.com/users/vbfox/following{/other_user}","gists_url":"https://api.github.com/users/vbfox/gists{/gist_id}","starred_url":"https://api.github.com/users/vbfox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbfox/subscriptions","organizations_url":"https://api.github.com/users/vbfox/orgs","repos_url":"https://api.github.com/users/vbfox/repos","events_url":"https://api.github.com/users/vbfox/events{/privacy}","received_events_url":"https://api.github.com/users/vbfox/received_events","type":"User","site_admin":false},"created_at":"2018-02-11T21:17:41Z","updated_at":"2018-02-11T21:17:41Z","author_association":"CONTRIBUTOR","body":";) I experimented with trying to reduce the size of the generated XML :)"}}
{"actor":{"display_login":"vbfox"}}