{"action":"created","issue":{"url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2088","repository_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer","labels_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2088/labels{/name}","comments_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2088/comments","events_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2088/events","html_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/issues/2088","id":349743929,"node_id":"MDU6SXNzdWUzNDk3NDM5Mjk=","number":2088,"title":"Azerite Traits with fixed damage/healing values","user":{"login":"joshinat0r","id":29842841,"node_id":"MDQ6VXNlcjI5ODQyODQx","avatar_url":"https://avatars2.githubusercontent.com/u/29842841?v=4","gravatar_id":"","url":"https://api.github.com/users/joshinat0r","html_url":"https://github.com/joshinat0r","followers_url":"https://api.github.com/users/joshinat0r/followers","following_url":"https://api.github.com/users/joshinat0r/following{/other_user}","gists_url":"https://api.github.com/users/joshinat0r/gists{/gist_id}","starred_url":"https://api.github.com/users/joshinat0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshinat0r/subscriptions","organizations_url":"https://api.github.com/users/joshinat0r/orgs","repos_url":"https://api.github.com/users/joshinat0r/repos","events_url":"https://api.github.com/users/joshinat0r/events{/privacy}","received_events_url":"https://api.github.com/users/joshinat0r/received_events","type":"User","site_admin":false},"labels":[{"id":732044734,"node_id":"MDU6TGFiZWw3MzIwNDQ3MzQ=","url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/labels/core","name":"core","color":"000000","default":false},{"id":681980253,"node_id":"MDU6TGFiZWw2ODE5ODAyNTM=","url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/labels/help%20wanted","name":"help wanted","color":"0e8a16","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-08-11T15:55:33Z","updated_at":"2018-11-23T12:56:03Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Some azerite traits deal a fixed amount of damage (like [Zealotry](https://www.wowhead.com/spell=278615/zealotry) for ret pallys), but only using the value from our azerite-calculation might lead to wrong numbers. \r\nAll % damage modifiers on targets and player would cause numbers that are off, ~~which means we need a module that will keep track of those buffs and debuffs.~~\r\n\r\nThings that the module should account for:\r\n- multipliers on player\r\n- multipliers on bosses\r\n- armor if the damage type of the trait is physical (would also need to account for shifting K-values of bosses)\r\n- versatility\r\n\r\nTracking other buffs might be more difficult, such as the raid wide target debuffs applied by monks and demon hunters as we dont have them in the events. The same thing applies to healers and target specific % healing modifiers (like Vampiric Blood).\r\n\r\n**EDIT**\r\nAs Gebuz mentioned, a proper solution to account for untrackable buffs (untrackable as in we don't want to make new API calls) is to calculate the expected damage of the spell. Check [this](https://github.com/WoWAnalyzer/WoWAnalyzer/issues/2088#issuecomment-414596614) comment on how we would calculate the expected hit size."},"comment":{"url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/comments/441234627","html_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/issues/2088#issuecomment-441234627","issue_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2088","id":441234627,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTIzNDYyNw==","user":{"login":"sMteX","id":5068584,"node_id":"MDQ6VXNlcjUwNjg1ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/5068584?v=4","gravatar_id":"","url":"https://api.github.com/users/sMteX","html_url":"https://github.com/sMteX","followers_url":"https://api.github.com/users/sMteX/followers","following_url":"https://api.github.com/users/sMteX/following{/other_user}","gists_url":"https://api.github.com/users/sMteX/gists{/gist_id}","starred_url":"https://api.github.com/users/sMteX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sMteX/subscriptions","organizations_url":"https://api.github.com/users/sMteX/orgs","repos_url":"https://api.github.com/users/sMteX/repos","events_url":"https://api.github.com/users/sMteX/events{/privacy}","received_events_url":"https://api.github.com/users/sMteX/received_events","type":"User","site_admin":false},"created_at":"2018-11-23T12:56:03Z","updated_at":"2018-11-23T12:56:03Z","author_association":"COLLABORATOR","body":"In #2744, the method used by Anatta and Putro in Feeding Frenzy module is refactored into an importable helper method in `parser/core/calculateBonusAzeriteDamage.js`."}}
{"actor":{"display_login":"sMteX"}}