{"action":"created","issue":{"url":"https://api.github.com/repos/Fody/Fody/issues/631","repository_url":"https://api.github.com/repos/Fody/Fody","labels_url":"https://api.github.com/repos/Fody/Fody/issues/631/labels{/name}","comments_url":"https://api.github.com/repos/Fody/Fody/issues/631/comments","events_url":"https://api.github.com/repos/Fody/Fody/issues/631/events","html_url":"https://github.com/Fody/Fody/pull/631","id":391480612,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4OTc0NTY4","number":631,"title":"Refactoring for #625","user":{"login":"tom-englert","id":10229954,"node_id":"MDQ6VXNlcjEwMjI5OTU0","avatar_url":"https://avatars3.githubusercontent.com/u/10229954?v=4","gravatar_id":"","url":"https://api.github.com/users/tom-englert","html_url":"https://github.com/tom-englert","followers_url":"https://api.github.com/users/tom-englert/followers","following_url":"https://api.github.com/users/tom-englert/following{/other_user}","gists_url":"https://api.github.com/users/tom-englert/gists{/gist_id}","starred_url":"https://api.github.com/users/tom-englert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tom-englert/subscriptions","organizations_url":"https://api.github.com/users/tom-englert/orgs","repos_url":"https://api.github.com/users/tom-englert/repos","events_url":"https://api.github.com/users/tom-englert/events{/privacy}","received_events_url":"https://api.github.com/users/tom-englert/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-16T16:01:19Z","updated_at":"2018-12-17T12:43:09Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Fody/Fody/pulls/631","html_url":"https://github.com/Fody/Fody/pull/631","diff_url":"https://github.com/Fody/Fody/pull/631.diff","patch_url":"https://github.com/Fody/Fody/pull/631.patch"},"body":"This PR addresses #625 \r\n\r\nAfter looking at the code I decided to not add a configurable option, but to refactor it an completely remove the legacy lookup.\r\nThe code flow was too much focused on the old strategy, where the `FodyWeavers.xml` was the \"main entry point\". Now that the `<WeaverFiles>` items are our starting point, many things could be simplified, so there is much less code left to maintain.\r\n\r\nCurrently there are some minor changes to the constraints, that make using weavers even easier and more flexible:\r\n\r\n1. All weavers configured for a project (i.e. NuGet package installed) will run by default, even if there is no entry in the `FodyWeavers.xml`. It is no longer required (however still recommended), to list the weavers in the configuration.\r\n2. A `FodyWeavers.xml` in the solution directory will control ordering and default configuration of the weavers. However now it's possible to configure the super set of all weavers used in all projects. Any additional configuration in the global configuration where no weaver is available in a specific project will be just ignored.\r\n3. InSolutionWeaving with multiple weavers per project is still supported, however no longer by naming convention. The Wiki update that describes the steps needed for migration is prepared here: https://github.com/tom-englert/Fody/wiki/InSolutionWeaving"},"comment":{"url":"https://api.github.com/repos/Fody/Fody/issues/comments/447832873","html_url":"https://github.com/Fody/Fody/pull/631#issuecomment-447832873","issue_url":"https://api.github.com/repos/Fody/Fody/issues/631","id":447832873,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzgzMjg3Mw==","user":{"login":"tom-englert","id":10229954,"node_id":"MDQ6VXNlcjEwMjI5OTU0","avatar_url":"https://avatars3.githubusercontent.com/u/10229954?v=4","gravatar_id":"","url":"https://api.github.com/users/tom-englert","html_url":"https://github.com/tom-englert","followers_url":"https://api.github.com/users/tom-englert/followers","following_url":"https://api.github.com/users/tom-englert/following{/other_user}","gists_url":"https://api.github.com/users/tom-englert/gists{/gist_id}","starred_url":"https://api.github.com/users/tom-englert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tom-englert/subscriptions","organizations_url":"https://api.github.com/users/tom-englert/orgs","repos_url":"https://api.github.com/users/tom-englert/repos","events_url":"https://api.github.com/users/tom-englert/events{/privacy}","received_events_url":"https://api.github.com/users/tom-englert/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T12:43:09Z","updated_at":"2018-12-17T12:43:09Z","author_association":"MEMBER","body":"@SimonCropp I've cleaned up the unnecessary whitespace changes introduced by R#, and extended the R# settings to avoid this in the future.\r\nAlso removed the readme changes, will post that later.\r\n\r\nThe breaking changes are the three listed in the top comment.\r\n1. and 2. are up to discussion if we want to allow this extensions, or rather keep it like it was before.\r\n3. Is mandatory, if we don't want to keep 90% of the old code.\r\n"}}
{"actor":{"display_login":"tom-englert"}}