{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/172048465","pull_request_review_id":101005475,"id":172048465,"diff_hunk":"@@ -1,5 +1,6 @@\n-{ stdenv, fetchurl, fetchpatch }:\n+{ lib, stdenv, fetchurl, fetchpatch, writeText, config ? null }:","path":"pkgs/applications/networking/instant-messengers/riot/riot-web.nix","position":2,"original_position":2,"commit_id":"2767db584eab540659377ec8be40711b084c0055","original_commit_id":"2767db584eab540659377ec8be40711b084c0055","user":{"login":"Mic92","id":96200,"avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"body":"Mhm, `conf` is a pretty generic term that might be set accidentially in `all-packages.nix`\r\n\r\nAdding\r\n```\r\nriot-web = callPackage ../applications/networking/instant-messengers/riot/riot-web.nix {\r\n  conf = config.riot-web.conf or null;\r\n};\r\n```\r\n\r\nto `all-packages.nix` helps to avoid namespace pollution.\r\nIt can be still overridden with the `override` function, but it can be also set in:\r\n`~/.config/nixpkgs/config.nix` via `riot-web.conf`\r\nI think renaming it from `conf` to `config` also don't hurt.","created_at":"2018-03-04T13:17:20Z","updated_at":"2018-03-04T13:17:20Z","html_url":"https://github.com/NixOS/nixpkgs/pull/36265#discussion_r172048465","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36265","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/172048465"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/36265#discussion_r172048465"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36265"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36265","id":172688437,"html_url":"https://github.com/NixOS/nixpkgs/pull/36265","diff_url":"https://github.com/NixOS/nixpkgs/pull/36265.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/36265.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/36265","number":36265,"state":"open","locked":false,"title":"riot-web: make package configurable","user":{"login":"Ekleog","id":411447,"avatar_url":"https://avatars1.githubusercontent.com/u/411447?v=4","gravatar_id":"","url":"https://api.github.com/users/Ekleog","html_url":"https://github.com/Ekleog","followers_url":"https://api.github.com/users/Ekleog/followers","following_url":"https://api.github.com/users/Ekleog/following{/other_user}","gists_url":"https://api.github.com/users/Ekleog/gists{/gist_id}","starred_url":"https://api.github.com/users/Ekleog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ekleog/subscriptions","organizations_url":"https://api.github.com/users/Ekleog/orgs","repos_url":"https://api.github.com/users/Ekleog/repos","events_url":"https://api.github.com/users/Ekleog/events{/privacy}","received_events_url":"https://api.github.com/users/Ekleog/received_events","type":"User","site_admin":false},"body":"Make `riot-web` more easy to configure for eg. a NixOS install: having a configured `riot-web` vhost becomes a matter of:\r\n```nix\r\n{\r\n  services.nginx.virtualHosts.\"riot.example.org\" = {\r\n    enableACME = true; forceSSL = true;\r\n    root = pkgs.riot-web.override {\r\n      config = ''\r\n        { the config.json contents }\r\n      '';\r\n    };\r\n  };\r\n}\r\n```\r\n\r\ncc @bachp ","created_at":"2018-03-03T21:28:38Z","updated_at":"2018-03-04T13:17:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9d344af77ef33eae415dabd8099e0a5d6c2149f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36265/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36265/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/36265/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/2767db584eab540659377ec8be40711b084c0055","head":{"label":"Ekleog:configurable-riot","ref":"configurable-riot","sha":"2767db584eab540659377ec8be40711b084c0055","user":{"login":"Ekleog","id":411447,"avatar_url":"https://avatars1.githubusercontent.com/u/411447?v=4","gravatar_id":"","url":"https://api.github.com/users/Ekleog","html_url":"https://github.com/Ekleog","followers_url":"https://api.github.com/users/Ekleog/followers","following_url":"https://api.github.com/users/Ekleog/following{/other_user}","gists_url":"https://api.github.com/users/Ekleog/gists{/gist_id}","starred_url":"https://api.github.com/users/Ekleog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ekleog/subscriptions","organizations_url":"https://api.github.com/users/Ekleog/orgs","repos_url":"https://api.github.com/users/Ekleog/repos","events_url":"https://api.github.com/users/Ekleog/events{/privacy}","received_events_url":"https://api.github.com/users/Ekleog/received_events","type":"User","site_admin":false},"repo":{"id":65348822,"name":"nixpkgs","full_name":"Ekleog/nixpkgs","owner":{"login":"Ekleog","id":411447,"avatar_url":"https://avatars1.githubusercontent.com/u/411447?v=4","gravatar_id":"","url":"https://api.github.com/users/Ekleog","html_url":"https://github.com/Ekleog","followers_url":"https://api.github.com/users/Ekleog/followers","following_url":"https://api.github.com/users/Ekleog/following{/other_user}","gists_url":"https://api.github.com/users/Ekleog/gists{/gist_id}","starred_url":"https://api.github.com/users/Ekleog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ekleog/subscriptions","organizations_url":"https://api.github.com/users/Ekleog/orgs","repos_url":"https://api.github.com/users/Ekleog/repos","events_url":"https://api.github.com/users/Ekleog/events{/privacy}","received_events_url":"https://api.github.com/users/Ekleog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ekleog/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/Ekleog/nixpkgs","forks_url":"https://api.github.com/repos/Ekleog/nixpkgs/forks","keys_url":"https://api.github.com/repos/Ekleog/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ekleog/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ekleog/nixpkgs/teams","hooks_url":"https://api.github.com/repos/Ekleog/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/Ekleog/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/Ekleog/nixpkgs/events","assignees_url":"https://api.github.com/repos/Ekleog/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/Ekleog/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/Ekleog/nixpkgs/tags","blobs_url":"https://api.github.com/repos/Ekleog/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ekleog/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ekleog/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ekleog/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ekleog/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/Ekleog/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/Ekleog/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/Ekleog/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/Ekleog/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/Ekleog/nixpkgs/subscription","commits_url":"https://api.github.com/repos/Ekleog/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ekleog/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ekleog/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ekleog/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ekleog/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/Ekleog/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ekleog/nixpkgs/merges","archive_url":"https://api.github.com/repos/Ekleog/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ekleog/nixpkgs/downloads","issues_url":"https://api.github.com/repos/Ekleog/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/Ekleog/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/Ekleog/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/Ekleog/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ekleog/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/Ekleog/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/Ekleog/nixpkgs/deployments","created_at":"2016-08-10T03:51:17Z","updated_at":"2016-08-10T03:51:42Z","pushed_at":"2018-03-04T10:54:56Z","git_url":"git://github.com/Ekleog/nixpkgs.git","ssh_url":"git@github.com:Ekleog/nixpkgs.git","clone_url":"https://github.com/Ekleog/nixpkgs.git","svn_url":"https://github.com/Ekleog/nixpkgs","homepage":null,"size":621587,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"2069a2a002d9b90c6444a827abbb3dd9016ebac6","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-03-03T07:33:22Z","pushed_at":"2018-03-04T13:14:13Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":729511,"stargazers_count":2260,"watchers_count":2260,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2593,"mirror_url":null,"archived":false,"open_issues_count":2959,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2593,"open_issues":2959,"watchers":2260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36265"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/36265"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/36265"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/36265/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36265/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/36265/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/2767db584eab540659377ec8be40711b084c0055"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Mic92"}}