{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/create-react-app/issues/5673","repository_url":"https://api.github.com/repos/facebook/create-react-app","labels_url":"https://api.github.com/repos/facebook/create-react-app/issues/5673/labels{/name}","comments_url":"https://api.github.com/repos/facebook/create-react-app/issues/5673/comments","events_url":"https://api.github.com/repos/facebook/create-react-app/issues/5673/events","html_url":"https://github.com/facebook/create-react-app/issues/5673","id":376509010,"node_id":"MDU6SXNzdWUzNzY1MDkwMTA=","number":5673,"title":"Guidlines for Using Workbox","user":{"login":"Nick-t-go","id":9603047,"node_id":"MDQ6VXNlcjk2MDMwNDc=","avatar_url":"https://avatars0.githubusercontent.com/u/9603047?v=4","gravatar_id":"","url":"https://api.github.com/users/Nick-t-go","html_url":"https://github.com/Nick-t-go","followers_url":"https://api.github.com/users/Nick-t-go/followers","following_url":"https://api.github.com/users/Nick-t-go/following{/other_user}","gists_url":"https://api.github.com/users/Nick-t-go/gists{/gist_id}","starred_url":"https://api.github.com/users/Nick-t-go/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nick-t-go/subscriptions","organizations_url":"https://api.github.com/users/Nick-t-go/orgs","repos_url":"https://api.github.com/users/Nick-t-go/repos","events_url":"https://api.github.com/users/Nick-t-go/events{/privacy}","received_events_url":"https://api.github.com/users/Nick-t-go/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-11-01T18:15:57Z","updated_at":"2018-11-16T05:08:13Z","closed_at":null,"author_association":"NONE","body":"\r\nI am on React-Scripts 2.0.5. I am eager to use the new Workbox functionality that is mentioned in the release notes for 2.0. I can't find any directions on how to do it though. \r\n\r\nThere are posts on Medium, Freecodecamp and such that are really just hacks to the 1.x versions of React-scripts. \r\n\r\nI had thought since it has just been added as a dependency we could get some assistance on how and where to add configurations. When I include Workbox in my `registerServiceWorker.js` and attempt to set some strategies on assets it crashes the entire app once built. \r\n\r\n`Unable to import module 'workbox-routing' from 'WORKBOX_CDN_ROOT_URL/workbox-routing.prod.js'.`\r\n\r\nI understand serviceworkers are now opt-in.\r\nI understand that in the latest version of create react app the service worker register file is now just called `serviceworker.js`.\r\n\r\n I compared the old `registerServiceWorker.js` to the new  `serviceworker.js` and they are the same. I also am able to build with the default service worker file and I do see Workbox in the application tab in Chrome dev tools. I know its working out of the box. I just want to be able to edit it. Guidance would be greatly appreciated."},"comment":{"url":"https://api.github.com/repos/facebook/create-react-app/issues/comments/439283651","html_url":"https://github.com/facebook/create-react-app/issues/5673#issuecomment-439283651","issue_url":"https://api.github.com/repos/facebook/create-react-app/issues/5673","id":439283651,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTI4MzY1MQ==","user":{"login":"karannagupta","id":36845810,"node_id":"MDQ6VXNlcjM2ODQ1ODEw","avatar_url":"https://avatars1.githubusercontent.com/u/36845810?v=4","gravatar_id":"","url":"https://api.github.com/users/karannagupta","html_url":"https://github.com/karannagupta","followers_url":"https://api.github.com/users/karannagupta/followers","following_url":"https://api.github.com/users/karannagupta/following{/other_user}","gists_url":"https://api.github.com/users/karannagupta/gists{/gist_id}","starred_url":"https://api.github.com/users/karannagupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karannagupta/subscriptions","organizations_url":"https://api.github.com/users/karannagupta/orgs","repos_url":"https://api.github.com/users/karannagupta/repos","events_url":"https://api.github.com/users/karannagupta/events{/privacy}","received_events_url":"https://api.github.com/users/karannagupta/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T05:08:13Z","updated_at":"2018-11-16T05:08:13Z","author_association":"NONE","body":"Not sure if it will work because, in an un-ejecting CRA, we don't have control over the webpack.cofig. #5369 will address the same problem. I think they will provide a workbox.config that will be read by the CRA's webpack.config to allow customizations ..."}}
{"actor":{"display_login":"karannagupta"}}