{"action":"created","comment":{"url":"https://api.github.com/repos/tue-robotics/tue-env/pulls/comments/176934003","pull_request_review_id":106723543,"id":176934003,"diff_hunk":"@@ -31,7 +33,7 @@ TUE_DEV_DIR=$TUE_ENV_DIR/dev\n if [ ! -f $TUE_SYSTEM_DIR/devel/setup.bash ]\n then\n     mkdir -p $TUE_SYSTEM_DIR/src\n-    hash g++ 2> /dev/null || sudo apt-get install --assume-yes g++\n+    hash g++ 2> /dev/null || tue-install-system-now g++","path":"installer/targets/ros/install.bash","position":33,"original_position":31,"commit_id":"7a1b31572115f2ad98e513b6634fda91bbea8bce","original_commit_id":"d19d0c92996ba07896a3330f38510be72a8e9783","user":{"login":"MatthijsBurgh","id":18014833,"avatar_url":"https://avatars2.githubusercontent.com/u/18014833?v=4","gravatar_id":"","url":"https://api.github.com/users/MatthijsBurgh","html_url":"https://github.com/MatthijsBurgh","followers_url":"https://api.github.com/users/MatthijsBurgh/followers","following_url":"https://api.github.com/users/MatthijsBurgh/following{/other_user}","gists_url":"https://api.github.com/users/MatthijsBurgh/gists{/gist_id}","starred_url":"https://api.github.com/users/MatthijsBurgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatthijsBurgh/subscriptions","organizations_url":"https://api.github.com/users/MatthijsBurgh/orgs","repos_url":"https://api.github.com/users/MatthijsBurgh/repos","events_url":"https://api.github.com/users/MatthijsBurgh/events{/privacy}","received_events_url":"https://api.github.com/users/MatthijsBurgh/received_events","type":"User","site_admin":false},"body":"@Timple We don't need the hash check here anymore, right? But it is faster than the dpkg check right? Than it is usefull to keep these.","created_at":"2018-03-25T09:15:47Z","updated_at":"2018-03-25T09:15:47Z","html_url":"https://github.com/tue-robotics/tue-env/pull/229#discussion_r176934003","pull_request_url":"https://api.github.com/repos/tue-robotics/tue-env/pulls/229","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/tue-robotics/tue-env/pulls/comments/176934003"},"html":{"href":"https://github.com/tue-robotics/tue-env/pull/229#discussion_r176934003"},"pull_request":{"href":"https://api.github.com/repos/tue-robotics/tue-env/pulls/229"}}},"pull_request":{"url":"https://api.github.com/repos/tue-robotics/tue-env/pulls/229","id":164259061,"html_url":"https://github.com/tue-robotics/tue-env/pull/229","diff_url":"https://github.com/tue-robotics/tue-env/pull/229.diff","patch_url":"https://github.com/tue-robotics/tue-env/pull/229.patch","issue_url":"https://api.github.com/repos/tue-robotics/tue-env/issues/229","number":229,"state":"open","locked":false,"title":"Nobleo-backport","user":{"login":"Timple","id":5036851,"avatar_url":"https://avatars3.githubusercontent.com/u/5036851?v=4","gravatar_id":"","url":"https://api.github.com/users/Timple","html_url":"https://github.com/Timple","followers_url":"https://api.github.com/users/Timple/followers","following_url":"https://api.github.com/users/Timple/following{/other_user}","gists_url":"https://api.github.com/users/Timple/gists{/gist_id}","starred_url":"https://api.github.com/users/Timple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Timple/subscriptions","organizations_url":"https://api.github.com/users/Timple/orgs","repos_url":"https://api.github.com/users/Timple/repos","events_url":"https://api.github.com/users/Timple/events{/privacy}","received_events_url":"https://api.github.com/users/Timple/received_events","type":"User","site_admin":false},"body":"With:\r\nSupport for branches: Usefull for CI\r\nMore robust package installing options\r\nInstall snapd if using snaps\r\nActivate docker permissions on install\r\nInstall less packages initially when installing ROS","created_at":"2018-01-22T09:36:44Z","updated_at":"2018-03-25T09:15:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d598e79f51ed757ec0c191532e2c93aa9fc16c2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":750129943,"url":"https://api.github.com/repos/tue-robotics/tue-env/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tue-robotics/tue-env/pulls/229/commits","review_comments_url":"https://api.github.com/repos/tue-robotics/tue-env/pulls/229/comments","review_comment_url":"https://api.github.com/repos/tue-robotics/tue-env/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tue-robotics/tue-env/issues/229/comments","statuses_url":"https://api.github.com/repos/tue-robotics/tue-env/statuses/7a1b31572115f2ad98e513b6634fda91bbea8bce","head":{"label":"tue-robotics:nobleo-backport","ref":"nobleo-backport","sha":"7a1b31572115f2ad98e513b6634fda91bbea8bce","user":{"login":"tue-robotics","id":2786024,"avatar_url":"https://avatars3.githubusercontent.com/u/2786024?v=4","gravatar_id":"","url":"https://api.github.com/users/tue-robotics","html_url":"https://github.com/tue-robotics","followers_url":"https://api.github.com/users/tue-robotics/followers","following_url":"https://api.github.com/users/tue-robotics/following{/other_user}","gists_url":"https://api.github.com/users/tue-robotics/gists{/gist_id}","starred_url":"https://api.github.com/users/tue-robotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tue-robotics/subscriptions","organizations_url":"https://api.github.com/users/tue-robotics/orgs","repos_url":"https://api.github.com/users/tue-robotics/repos","events_url":"https://api.github.com/users/tue-robotics/events{/privacy}","received_events_url":"https://api.github.com/users/tue-robotics/received_events","type":"Organization","site_admin":false},"repo":{"id":27542300,"name":"tue-env","full_name":"tue-robotics/tue-env","owner":{"login":"tue-robotics","id":2786024,"avatar_url":"https://avatars3.githubusercontent.com/u/2786024?v=4","gravatar_id":"","url":"https://api.github.com/users/tue-robotics","html_url":"https://github.com/tue-robotics","followers_url":"https://api.github.com/users/tue-robotics/followers","following_url":"https://api.github.com/users/tue-robotics/following{/other_user}","gists_url":"https://api.github.com/users/tue-robotics/gists{/gist_id}","starred_url":"https://api.github.com/users/tue-robotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tue-robotics/subscriptions","organizations_url":"https://api.github.com/users/tue-robotics/orgs","repos_url":"https://api.github.com/users/tue-robotics/repos","events_url":"https://api.github.com/users/tue-robotics/events{/privacy}","received_events_url":"https://api.github.com/users/tue-robotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tue-robotics/tue-env","description":"Package manager that can be used to install (ROS) dependencies","fork":false,"url":"https://api.github.com/repos/tue-robotics/tue-env","forks_url":"https://api.github.com/repos/tue-robotics/tue-env/forks","keys_url":"https://api.github.com/repos/tue-robotics/tue-env/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tue-robotics/tue-env/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tue-robotics/tue-env/teams","hooks_url":"https://api.github.com/repos/tue-robotics/tue-env/hooks","issue_events_url":"https://api.github.com/repos/tue-robotics/tue-env/issues/events{/number}","events_url":"https://api.github.com/repos/tue-robotics/tue-env/events","assignees_url":"https://api.github.com/repos/tue-robotics/tue-env/assignees{/user}","branches_url":"https://api.github.com/repos/tue-robotics/tue-env/branches{/branch}","tags_url":"https://api.github.com/repos/tue-robotics/tue-env/tags","blobs_url":"https://api.github.com/repos/tue-robotics/tue-env/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tue-robotics/tue-env/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tue-robotics/tue-env/git/refs{/sha}","trees_url":"https://api.github.com/repos/tue-robotics/tue-env/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tue-robotics/tue-env/statuses/{sha}","languages_url":"https://api.github.com/repos/tue-robotics/tue-env/languages","stargazers_url":"https://api.github.com/repos/tue-robotics/tue-env/stargazers","contributors_url":"https://api.github.com/repos/tue-robotics/tue-env/contributors","subscribers_url":"https://api.github.com/repos/tue-robotics/tue-env/subscribers","subscription_url":"https://api.github.com/repos/tue-robotics/tue-env/subscription","commits_url":"https://api.github.com/repos/tue-robotics/tue-env/commits{/sha}","git_commits_url":"https://api.github.com/repos/tue-robotics/tue-env/git/commits{/sha}","comments_url":"https://api.github.com/repos/tue-robotics/tue-env/comments{/number}","issue_comment_url":"https://api.github.com/repos/tue-robotics/tue-env/issues/comments{/number}","contents_url":"https://api.github.com/repos/tue-robotics/tue-env/contents/{+path}","compare_url":"https://api.github.com/repos/tue-robotics/tue-env/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tue-robotics/tue-env/merges","archive_url":"https://api.github.com/repos/tue-robotics/tue-env/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tue-robotics/tue-env/downloads","issues_url":"https://api.github.com/repos/tue-robotics/tue-env/issues{/number}","pulls_url":"https://api.github.com/repos/tue-robotics/tue-env/pulls{/number}","milestones_url":"https://api.github.com/repos/tue-robotics/tue-env/milestones{/number}","notifications_url":"https://api.github.com/repos/tue-robotics/tue-env/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tue-robotics/tue-env/labels{/name}","releases_url":"https://api.github.com/repos/tue-robotics/tue-env/releases{/id}","deployments_url":"https://api.github.com/repos/tue-robotics/tue-env/deployments","created_at":"2014-12-04T13:44:07Z","updated_at":"2018-03-24T16:06:28Z","pushed_at":"2018-03-23T13:33:15Z","git_url":"git://github.com/tue-robotics/tue-env.git","ssh_url":"git@github.com:tue-robotics/tue-env.git","clone_url":"https://github.com/tue-robotics/tue-env.git","svn_url":"https://github.com/tue-robotics/tue-env","homepage":"","size":5534,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":1,"open_issues":12,"watchers":3,"default_branch":"master"}},"base":{"label":"tue-robotics:master","ref":"master","sha":"47f11f3159198e63c825bcdbe57e703ca605f938","user":{"login":"tue-robotics","id":2786024,"avatar_url":"https://avatars3.githubusercontent.com/u/2786024?v=4","gravatar_id":"","url":"https://api.github.com/users/tue-robotics","html_url":"https://github.com/tue-robotics","followers_url":"https://api.github.com/users/tue-robotics/followers","following_url":"https://api.github.com/users/tue-robotics/following{/other_user}","gists_url":"https://api.github.com/users/tue-robotics/gists{/gist_id}","starred_url":"https://api.github.com/users/tue-robotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tue-robotics/subscriptions","organizations_url":"https://api.github.com/users/tue-robotics/orgs","repos_url":"https://api.github.com/users/tue-robotics/repos","events_url":"https://api.github.com/users/tue-robotics/events{/privacy}","received_events_url":"https://api.github.com/users/tue-robotics/received_events","type":"Organization","site_admin":false},"repo":{"id":27542300,"name":"tue-env","full_name":"tue-robotics/tue-env","owner":{"login":"tue-robotics","id":2786024,"avatar_url":"https://avatars3.githubusercontent.com/u/2786024?v=4","gravatar_id":"","url":"https://api.github.com/users/tue-robotics","html_url":"https://github.com/tue-robotics","followers_url":"https://api.github.com/users/tue-robotics/followers","following_url":"https://api.github.com/users/tue-robotics/following{/other_user}","gists_url":"https://api.github.com/users/tue-robotics/gists{/gist_id}","starred_url":"https://api.github.com/users/tue-robotics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tue-robotics/subscriptions","organizations_url":"https://api.github.com/users/tue-robotics/orgs","repos_url":"https://api.github.com/users/tue-robotics/repos","events_url":"https://api.github.com/users/tue-robotics/events{/privacy}","received_events_url":"https://api.github.com/users/tue-robotics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tue-robotics/tue-env","description":"Package manager that can be used to install (ROS) dependencies","fork":false,"url":"https://api.github.com/repos/tue-robotics/tue-env","forks_url":"https://api.github.com/repos/tue-robotics/tue-env/forks","keys_url":"https://api.github.com/repos/tue-robotics/tue-env/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tue-robotics/tue-env/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tue-robotics/tue-env/teams","hooks_url":"https://api.github.com/repos/tue-robotics/tue-env/hooks","issue_events_url":"https://api.github.com/repos/tue-robotics/tue-env/issues/events{/number}","events_url":"https://api.github.com/repos/tue-robotics/tue-env/events","assignees_url":"https://api.github.com/repos/tue-robotics/tue-env/assignees{/user}","branches_url":"https://api.github.com/repos/tue-robotics/tue-env/branches{/branch}","tags_url":"https://api.github.com/repos/tue-robotics/tue-env/tags","blobs_url":"https://api.github.com/repos/tue-robotics/tue-env/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tue-robotics/tue-env/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tue-robotics/tue-env/git/refs{/sha}","trees_url":"https://api.github.com/repos/tue-robotics/tue-env/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tue-robotics/tue-env/statuses/{sha}","languages_url":"https://api.github.com/repos/tue-robotics/tue-env/languages","stargazers_url":"https://api.github.com/repos/tue-robotics/tue-env/stargazers","contributors_url":"https://api.github.com/repos/tue-robotics/tue-env/contributors","subscribers_url":"https://api.github.com/repos/tue-robotics/tue-env/subscribers","subscription_url":"https://api.github.com/repos/tue-robotics/tue-env/subscription","commits_url":"https://api.github.com/repos/tue-robotics/tue-env/commits{/sha}","git_commits_url":"https://api.github.com/repos/tue-robotics/tue-env/git/commits{/sha}","comments_url":"https://api.github.com/repos/tue-robotics/tue-env/comments{/number}","issue_comment_url":"https://api.github.com/repos/tue-robotics/tue-env/issues/comments{/number}","contents_url":"https://api.github.com/repos/tue-robotics/tue-env/contents/{+path}","compare_url":"https://api.github.com/repos/tue-robotics/tue-env/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tue-robotics/tue-env/merges","archive_url":"https://api.github.com/repos/tue-robotics/tue-env/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tue-robotics/tue-env/downloads","issues_url":"https://api.github.com/repos/tue-robotics/tue-env/issues{/number}","pulls_url":"https://api.github.com/repos/tue-robotics/tue-env/pulls{/number}","milestones_url":"https://api.github.com/repos/tue-robotics/tue-env/milestones{/number}","notifications_url":"https://api.github.com/repos/tue-robotics/tue-env/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tue-robotics/tue-env/labels{/name}","releases_url":"https://api.github.com/repos/tue-robotics/tue-env/releases{/id}","deployments_url":"https://api.github.com/repos/tue-robotics/tue-env/deployments","created_at":"2014-12-04T13:44:07Z","updated_at":"2018-03-24T16:06:28Z","pushed_at":"2018-03-23T13:33:15Z","git_url":"git://github.com/tue-robotics/tue-env.git","ssh_url":"git@github.com:tue-robotics/tue-env.git","clone_url":"https://github.com/tue-robotics/tue-env.git","svn_url":"https://github.com/tue-robotics/tue-env","homepage":"","size":5534,"stargazers_count":3,"watchers_count":3,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":1,"open_issues":12,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tue-robotics/tue-env/pulls/229"},"html":{"href":"https://github.com/tue-robotics/tue-env/pull/229"},"issue":{"href":"https://api.github.com/repos/tue-robotics/tue-env/issues/229"},"comments":{"href":"https://api.github.com/repos/tue-robotics/tue-env/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/tue-robotics/tue-env/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/tue-robotics/tue-env/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tue-robotics/tue-env/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/tue-robotics/tue-env/statuses/7a1b31572115f2ad98e513b6634fda91bbea8bce"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"MatthijsBurgh"}}