{"action":"created","comment":{"url":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/comments/166558443","pull_request_review_id":94632991,"id":166558443,"diff_hunk":"@@ -180,8 +180,7 @@ REGISTER_SELECT_GPU(complex128);\n       Name(\"Select\").Device(DEVICE_SYCL).TypeConstraint<type>(\"T\"), \\\n       SelectOp<SYCLDevice, type>);\n \n-REGISTER_SELECT_SYCL(float);\n-REGISTER_SELECT_SYCL(double);\n+TF_CALL_SYCL_NUMBER_TYPES(REGISTER_SELECT_SYCL);\n REGISTER_SELECT_SYCL(int32);\n REGISTER_SELECT_SYCL(int64);","path":"tensorflow/core/kernels/cwise_op_select.cc","position":8,"original_position":8,"commit_id":"f6ad5eacacb3a311e21f7182a5e85684bb7ba223","original_commit_id":"f6ad5eacacb3a311e21f7182a5e85684bb7ba223","user":{"login":"jwlawson","id":1849778,"avatar_url":"https://avatars3.githubusercontent.com/u/1849778?v=4","gravatar_id":"","url":"https://api.github.com/users/jwlawson","html_url":"https://github.com/jwlawson","followers_url":"https://api.github.com/users/jwlawson/followers","following_url":"https://api.github.com/users/jwlawson/following{/other_user}","gists_url":"https://api.github.com/users/jwlawson/gists{/gist_id}","starred_url":"https://api.github.com/users/jwlawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwlawson/subscriptions","organizations_url":"https://api.github.com/users/jwlawson/orgs","repos_url":"https://api.github.com/users/jwlawson/repos","events_url":"https://api.github.com/users/jwlawson/events{/privacy}","received_events_url":"https://api.github.com/users/jwlawson/received_events","type":"User","site_admin":false},"body":"Same. Can this use the `TF_CALL...` macro?","created_at":"2018-02-07T09:21:43Z","updated_at":"2018-02-07T09:37:08Z","html_url":"https://github.com/lukeiwanski/tensorflow/pull/207#discussion_r166558443","pull_request_url":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/207","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/comments/166558443"},"html":{"href":"https://github.com/lukeiwanski/tensorflow/pull/207#discussion_r166558443"},"pull_request":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/207"}}},"pull_request":{"url":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/207","id":167573355,"html_url":"https://github.com/lukeiwanski/tensorflow/pull/207","diff_url":"https://github.com/lukeiwanski/tensorflow/pull/207.diff","patch_url":"https://github.com/lukeiwanski/tensorflow/pull/207.patch","issue_url":"https://api.github.com/repos/lukeiwanski/tensorflow/issues/207","number":207,"state":"open","locked":false,"title":"[SYCL] Registered Ops to use TF_CALL_SYCL_NUMBER_TYPES","user":{"login":"lukeiwanski","id":8373795,"avatar_url":"https://avatars1.githubusercontent.com/u/8373795?v=4","gravatar_id":"","url":"https://api.github.com/users/lukeiwanski","html_url":"https://github.com/lukeiwanski","followers_url":"https://api.github.com/users/lukeiwanski/followers","following_url":"https://api.github.com/users/lukeiwanski/following{/other_user}","gists_url":"https://api.github.com/users/lukeiwanski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeiwanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeiwanski/subscriptions","organizations_url":"https://api.github.com/users/lukeiwanski/orgs","repos_url":"https://api.github.com/users/lukeiwanski/repos","events_url":"https://api.github.com/users/lukeiwanski/events{/privacy}","received_events_url":"https://api.github.com/users/lukeiwanski/received_events","type":"User","site_admin":false},"body":"This PR introduces `TF_CALL_SYCL_NUMBER_TYPES`.\r\n\r\nDuring configuration process user is able to specify which datatypes to support (eg. double, half) as they are extensions in OpenCL and support on various platforms may not be guaranteed.","created_at":"2018-02-07T01:11:34Z","updated_at":"2018-02-07T09:37:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e408219389b061fed08b86dcca3ff7e04b3e097d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/207/commits","review_comments_url":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/207/comments","review_comment_url":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lukeiwanski/tensorflow/issues/207/comments","statuses_url":"https://api.github.com/repos/lukeiwanski/tensorflow/statuses/f6ad5eacacb3a311e21f7182a5e85684bb7ba223","head":{"label":"lukeiwanski:feature/tf_call_sycl_number_types","ref":"feature/tf_call_sycl_number_types","sha":"f6ad5eacacb3a311e21f7182a5e85684bb7ba223","user":{"login":"lukeiwanski","id":8373795,"avatar_url":"https://avatars1.githubusercontent.com/u/8373795?v=4","gravatar_id":"","url":"https://api.github.com/users/lukeiwanski","html_url":"https://github.com/lukeiwanski","followers_url":"https://api.github.com/users/lukeiwanski/followers","following_url":"https://api.github.com/users/lukeiwanski/following{/other_user}","gists_url":"https://api.github.com/users/lukeiwanski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeiwanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeiwanski/subscriptions","organizations_url":"https://api.github.com/users/lukeiwanski/orgs","repos_url":"https://api.github.com/users/lukeiwanski/repos","events_url":"https://api.github.com/users/lukeiwanski/events{/privacy}","received_events_url":"https://api.github.com/users/lukeiwanski/received_events","type":"User","site_admin":false},"repo":{"id":87582233,"name":"tensorflow","full_name":"lukeiwanski/tensorflow","owner":{"login":"lukeiwanski","id":8373795,"avatar_url":"https://avatars1.githubusercontent.com/u/8373795?v=4","gravatar_id":"","url":"https://api.github.com/users/lukeiwanski","html_url":"https://github.com/lukeiwanski","followers_url":"https://api.github.com/users/lukeiwanski/followers","following_url":"https://api.github.com/users/lukeiwanski/following{/other_user}","gists_url":"https://api.github.com/users/lukeiwanski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeiwanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeiwanski/subscriptions","organizations_url":"https://api.github.com/users/lukeiwanski/orgs","repos_url":"https://api.github.com/users/lukeiwanski/repos","events_url":"https://api.github.com/users/lukeiwanski/events{/privacy}","received_events_url":"https://api.github.com/users/lukeiwanski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukeiwanski/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/lukeiwanski/tensorflow","forks_url":"https://api.github.com/repos/lukeiwanski/tensorflow/forks","keys_url":"https://api.github.com/repos/lukeiwanski/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukeiwanski/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukeiwanski/tensorflow/teams","hooks_url":"https://api.github.com/repos/lukeiwanski/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/lukeiwanski/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/lukeiwanski/tensorflow/events","assignees_url":"https://api.github.com/repos/lukeiwanski/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/lukeiwanski/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/lukeiwanski/tensorflow/tags","blobs_url":"https://api.github.com/repos/lukeiwanski/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukeiwanski/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukeiwanski/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukeiwanski/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukeiwanski/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/lukeiwanski/tensorflow/languages","stargazers_url":"https://api.github.com/repos/lukeiwanski/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/lukeiwanski/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/lukeiwanski/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/lukeiwanski/tensorflow/subscription","commits_url":"https://api.github.com/repos/lukeiwanski/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukeiwanski/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukeiwanski/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukeiwanski/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukeiwanski/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/lukeiwanski/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukeiwanski/tensorflow/merges","archive_url":"https://api.github.com/repos/lukeiwanski/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukeiwanski/tensorflow/downloads","issues_url":"https://api.github.com/repos/lukeiwanski/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/lukeiwanski/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/lukeiwanski/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukeiwanski/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/lukeiwanski/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/lukeiwanski/tensorflow/deployments","created_at":"2017-04-07T19:56:43Z","updated_at":"2018-01-29T10:03:51Z","pushed_at":"2018-02-07T01:11:35Z","git_url":"git://github.com/lukeiwanski/tensorflow.git","ssh_url":"git@github.com:lukeiwanski/tensorflow.git","clone_url":"https://github.com/lukeiwanski/tensorflow.git","svn_url":"https://github.com/lukeiwanski/tensorflow","homepage":"http://tensorflow.org","size":151083,"stargazers_count":23,"watchers_count":23,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":13,"open_issues":39,"watchers":23,"default_branch":"master"}},"base":{"label":"lukeiwanski:dev/amd_gpu","ref":"dev/amd_gpu","sha":"814e88df5608476191500599bfc165c9b28d34f1","user":{"login":"lukeiwanski","id":8373795,"avatar_url":"https://avatars1.githubusercontent.com/u/8373795?v=4","gravatar_id":"","url":"https://api.github.com/users/lukeiwanski","html_url":"https://github.com/lukeiwanski","followers_url":"https://api.github.com/users/lukeiwanski/followers","following_url":"https://api.github.com/users/lukeiwanski/following{/other_user}","gists_url":"https://api.github.com/users/lukeiwanski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeiwanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeiwanski/subscriptions","organizations_url":"https://api.github.com/users/lukeiwanski/orgs","repos_url":"https://api.github.com/users/lukeiwanski/repos","events_url":"https://api.github.com/users/lukeiwanski/events{/privacy}","received_events_url":"https://api.github.com/users/lukeiwanski/received_events","type":"User","site_admin":false},"repo":{"id":87582233,"name":"tensorflow","full_name":"lukeiwanski/tensorflow","owner":{"login":"lukeiwanski","id":8373795,"avatar_url":"https://avatars1.githubusercontent.com/u/8373795?v=4","gravatar_id":"","url":"https://api.github.com/users/lukeiwanski","html_url":"https://github.com/lukeiwanski","followers_url":"https://api.github.com/users/lukeiwanski/followers","following_url":"https://api.github.com/users/lukeiwanski/following{/other_user}","gists_url":"https://api.github.com/users/lukeiwanski/gists{/gist_id}","starred_url":"https://api.github.com/users/lukeiwanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukeiwanski/subscriptions","organizations_url":"https://api.github.com/users/lukeiwanski/orgs","repos_url":"https://api.github.com/users/lukeiwanski/repos","events_url":"https://api.github.com/users/lukeiwanski/events{/privacy}","received_events_url":"https://api.github.com/users/lukeiwanski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lukeiwanski/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/lukeiwanski/tensorflow","forks_url":"https://api.github.com/repos/lukeiwanski/tensorflow/forks","keys_url":"https://api.github.com/repos/lukeiwanski/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukeiwanski/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukeiwanski/tensorflow/teams","hooks_url":"https://api.github.com/repos/lukeiwanski/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/lukeiwanski/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/lukeiwanski/tensorflow/events","assignees_url":"https://api.github.com/repos/lukeiwanski/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/lukeiwanski/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/lukeiwanski/tensorflow/tags","blobs_url":"https://api.github.com/repos/lukeiwanski/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukeiwanski/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukeiwanski/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukeiwanski/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukeiwanski/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/lukeiwanski/tensorflow/languages","stargazers_url":"https://api.github.com/repos/lukeiwanski/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/lukeiwanski/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/lukeiwanski/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/lukeiwanski/tensorflow/subscription","commits_url":"https://api.github.com/repos/lukeiwanski/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukeiwanski/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukeiwanski/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukeiwanski/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukeiwanski/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/lukeiwanski/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukeiwanski/tensorflow/merges","archive_url":"https://api.github.com/repos/lukeiwanski/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukeiwanski/tensorflow/downloads","issues_url":"https://api.github.com/repos/lukeiwanski/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/lukeiwanski/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/lukeiwanski/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukeiwanski/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/lukeiwanski/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/lukeiwanski/tensorflow/deployments","created_at":"2017-04-07T19:56:43Z","updated_at":"2018-01-29T10:03:51Z","pushed_at":"2018-02-07T01:11:35Z","git_url":"git://github.com/lukeiwanski/tensorflow.git","ssh_url":"git@github.com:lukeiwanski/tensorflow.git","clone_url":"https://github.com/lukeiwanski/tensorflow.git","svn_url":"https://github.com/lukeiwanski/tensorflow","homepage":"http://tensorflow.org","size":151083,"stargazers_count":23,"watchers_count":23,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":13,"open_issues":39,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/207"},"html":{"href":"https://github.com/lukeiwanski/tensorflow/pull/207"},"issue":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/issues/207"},"comments":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/issues/207/comments"},"review_comments":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/207/comments"},"review_comment":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/pulls/207/commits"},"statuses":{"href":"https://api.github.com/repos/lukeiwanski/tensorflow/statuses/f6ad5eacacb3a311e21f7182a5e85684bb7ba223"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jwlawson"}}