{"action":"created","comment":{"url":"https://api.github.com/repos/UNC-Libraries/hy-c/pulls/comments/212622691","pull_request_review_id":149296589,"id":212622691,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjYyMjY5MQ==","diff_hunk":"@@ -24,6 +28,10 @@ def self.multiple?(field)\n \n   # cast single value fields back to multivalued so they will actually deposit\n   def self.model_attributes(form_params)\n+    admin_multi_value_fields.each do |field|","path":"app/forms/single_value_form.rb","position":17,"original_position":17,"commit_id":"76c66a1817fffcc62ccc7b9b7cb4a887fb95d0db","original_commit_id":"76c66a1817fffcc62ccc7b9b7cb4a887fb95d0db","user":{"login":"smithjp","id":7035044,"node_id":"MDQ6VXNlcjcwMzUwNDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7035044?v=4","gravatar_id":"","url":"https://api.github.com/users/smithjp","html_url":"https://github.com/smithjp","followers_url":"https://api.github.com/users/smithjp/followers","following_url":"https://api.github.com/users/smithjp/following{/other_user}","gists_url":"https://api.github.com/users/smithjp/gists{/gist_id}","starred_url":"https://api.github.com/users/smithjp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smithjp/subscriptions","organizations_url":"https://api.github.com/users/smithjp/orgs","repos_url":"https://api.github.com/users/smithjp/repos","events_url":"https://api.github.com/users/smithjp/events{/privacy}","received_events_url":"https://api.github.com/users/smithjp/received_events","type":"User","site_admin":false},"body":"The fields need to be converted to arrays if they were not multi-valued in the forms before the params are sanitized or they will not be permitted.  I will add comments about this in the code.  \r\nThese fields should show up as single-valued for non-admins when works are created.  I may need to adjust the form partials to allow the fields to be multi-valued for everyone on edit or not editable for non-admins on edit in order to retain all of the data.","created_at":"2018-08-24T13:10:38Z","updated_at":"2018-08-24T13:10:38Z","html_url":"https://github.com/UNC-Libraries/hy-c/pull/97#discussion_r212622691","pull_request_url":"https://api.github.com/repos/UNC-Libraries/hy-c/pulls/97","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/UNC-Libraries/hy-c/pulls/comments/212622691"},"html":{"href":"https://github.com/UNC-Libraries/hy-c/pull/97#discussion_r212622691"},"pull_request":{"href":"https://api.github.com/repos/UNC-Libraries/hy-c/pulls/97"}},"in_reply_to_id":212024211},"pull_request":{"url":"https://api.github.com/repos/UNC-Libraries/hy-c/pulls/97","id":208617879,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NjE3ODc5","html_url":"https://github.com/UNC-Libraries/hy-c/pull/97","diff_url":"https://github.com/UNC-Libraries/hy-c/pull/97.diff","patch_url":"https://github.com/UNC-Libraries/hy-c/pull/97.patch","issue_url":"https://api.github.com/repos/UNC-Libraries/hy-c/issues/97","number":97,"state":"open","locked":false,"title":"Honors workflow","user":{"login":"smithjp","id":7035044,"node_id":"MDQ6VXNlcjcwMzUwNDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7035044?v=4","gravatar_id":"","url":"https://api.github.com/users/smithjp","html_url":"https://github.com/smithjp","followers_url":"https://api.github.com/users/smithjp/followers","following_url":"https://api.github.com/users/smithjp/following{/other_user}","gists_url":"https://api.github.com/users/smithjp/gists{/gist_id}","starred_url":"https://api.github.com/users/smithjp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smithjp/subscriptions","organizations_url":"https://api.github.com/users/smithjp/orgs","repos_url":"https://api.github.com/users/smithjp/repos","events_url":"https://api.github.com/users/smithjp/events{/privacy}","received_events_url":"https://api.github.com/users/smithjp/received_events","type":"User","site_admin":false},"body":"* Make affiliation required and single-valued in honors thesis form\r\n* Remove requirement for academic concentration from honors thesis form\r\n* Add feature test for reviewer group creation for honors thesis workflow","created_at":"2018-08-15T16:48:38Z","updated_at":"2018-08-24T13:10:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"592f97a7c339899b80d9379307725a089ba9955b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UNC-Libraries/hy-c/pulls/97/commits","review_comments_url":"https://api.github.com/repos/UNC-Libraries/hy-c/pulls/97/comments","review_comment_url":"https://api.github.com/repos/UNC-Libraries/hy-c/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UNC-Libraries/hy-c/issues/97/comments","statuses_url":"https://api.github.com/repos/UNC-Libraries/hy-c/statuses/76c66a1817fffcc62ccc7b9b7cb4a887fb95d0db","head":{"label":"UNC-Libraries:honors-workflow","ref":"honors-workflow","sha":"76c66a1817fffcc62ccc7b9b7cb4a887fb95d0db","user":{"login":"UNC-Libraries","id":552066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MjA2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/552066?v=4","gravatar_id":"","url":"https://api.github.com/users/UNC-Libraries","html_url":"https://github.com/UNC-Libraries","followers_url":"https://api.github.com/users/UNC-Libraries/followers","following_url":"https://api.github.com/users/UNC-Libraries/following{/other_user}","gists_url":"https://api.github.com/users/UNC-Libraries/gists{/gist_id}","starred_url":"https://api.github.com/users/UNC-Libraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNC-Libraries/subscriptions","organizations_url":"https://api.github.com/users/UNC-Libraries/orgs","repos_url":"https://api.github.com/users/UNC-Libraries/repos","events_url":"https://api.github.com/users/UNC-Libraries/events{/privacy}","received_events_url":"https://api.github.com/users/UNC-Libraries/received_events","type":"Organization","site_admin":false},"repo":{"id":108883690,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg4ODM2OTA=","name":"hy-c","full_name":"UNC-Libraries/hy-c","owner":{"login":"UNC-Libraries","id":552066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MjA2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/552066?v=4","gravatar_id":"","url":"https://api.github.com/users/UNC-Libraries","html_url":"https://github.com/UNC-Libraries","followers_url":"https://api.github.com/users/UNC-Libraries/followers","following_url":"https://api.github.com/users/UNC-Libraries/following{/other_user}","gists_url":"https://api.github.com/users/UNC-Libraries/gists{/gist_id}","starred_url":"https://api.github.com/users/UNC-Libraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNC-Libraries/subscriptions","organizations_url":"https://api.github.com/users/UNC-Libraries/orgs","repos_url":"https://api.github.com/users/UNC-Libraries/repos","events_url":"https://api.github.com/users/UNC-Libraries/events{/privacy}","received_events_url":"https://api.github.com/users/UNC-Libraries/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UNC-Libraries/hy-c","description":null,"fork":false,"url":"https://api.github.com/repos/UNC-Libraries/hy-c","forks_url":"https://api.github.com/repos/UNC-Libraries/hy-c/forks","keys_url":"https://api.github.com/repos/UNC-Libraries/hy-c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UNC-Libraries/hy-c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UNC-Libraries/hy-c/teams","hooks_url":"https://api.github.com/repos/UNC-Libraries/hy-c/hooks","issue_events_url":"https://api.github.com/repos/UNC-Libraries/hy-c/issues/events{/number}","events_url":"https://api.github.com/repos/UNC-Libraries/hy-c/events","assignees_url":"https://api.github.com/repos/UNC-Libraries/hy-c/assignees{/user}","branches_url":"https://api.github.com/repos/UNC-Libraries/hy-c/branches{/branch}","tags_url":"https://api.github.com/repos/UNC-Libraries/hy-c/tags","blobs_url":"https://api.github.com/repos/UNC-Libraries/hy-c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UNC-Libraries/hy-c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UNC-Libraries/hy-c/git/refs{/sha}","trees_url":"https://api.github.com/repos/UNC-Libraries/hy-c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UNC-Libraries/hy-c/statuses/{sha}","languages_url":"https://api.github.com/repos/UNC-Libraries/hy-c/languages","stargazers_url":"https://api.github.com/repos/UNC-Libraries/hy-c/stargazers","contributors_url":"https://api.github.com/repos/UNC-Libraries/hy-c/contributors","subscribers_url":"https://api.github.com/repos/UNC-Libraries/hy-c/subscribers","subscription_url":"https://api.github.com/repos/UNC-Libraries/hy-c/subscription","commits_url":"https://api.github.com/repos/UNC-Libraries/hy-c/commits{/sha}","git_commits_url":"https://api.github.com/repos/UNC-Libraries/hy-c/git/commits{/sha}","comments_url":"https://api.github.com/repos/UNC-Libraries/hy-c/comments{/number}","issue_comment_url":"https://api.github.com/repos/UNC-Libraries/hy-c/issues/comments{/number}","contents_url":"https://api.github.com/repos/UNC-Libraries/hy-c/contents/{+path}","compare_url":"https://api.github.com/repos/UNC-Libraries/hy-c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UNC-Libraries/hy-c/merges","archive_url":"https://api.github.com/repos/UNC-Libraries/hy-c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UNC-Libraries/hy-c/downloads","issues_url":"https://api.github.com/repos/UNC-Libraries/hy-c/issues{/number}","pulls_url":"https://api.github.com/repos/UNC-Libraries/hy-c/pulls{/number}","milestones_url":"https://api.github.com/repos/UNC-Libraries/hy-c/milestones{/number}","notifications_url":"https://api.github.com/repos/UNC-Libraries/hy-c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UNC-Libraries/hy-c/labels{/name}","releases_url":"https://api.github.com/repos/UNC-Libraries/hy-c/releases{/id}","deployments_url":"https://api.github.com/repos/UNC-Libraries/hy-c/deployments","created_at":"2017-10-30T17:17:23Z","updated_at":"2018-08-14T13:25:48Z","pushed_at":"2018-08-23T21:17:40Z","git_url":"git://github.com/UNC-Libraries/hy-c.git","ssh_url":"git@github.com:UNC-Libraries/hy-c.git","clone_url":"https://github.com/UNC-Libraries/hy-c.git","svn_url":"https://github.com/UNC-Libraries/hy-c","homepage":null,"size":127771,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":6,"watchers":3,"default_branch":"master"}},"base":{"label":"UNC-Libraries:master","ref":"master","sha":"f043a6cbc21f168ccc7759b7d145ad47ba0002b8","user":{"login":"UNC-Libraries","id":552066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MjA2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/552066?v=4","gravatar_id":"","url":"https://api.github.com/users/UNC-Libraries","html_url":"https://github.com/UNC-Libraries","followers_url":"https://api.github.com/users/UNC-Libraries/followers","following_url":"https://api.github.com/users/UNC-Libraries/following{/other_user}","gists_url":"https://api.github.com/users/UNC-Libraries/gists{/gist_id}","starred_url":"https://api.github.com/users/UNC-Libraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNC-Libraries/subscriptions","organizations_url":"https://api.github.com/users/UNC-Libraries/orgs","repos_url":"https://api.github.com/users/UNC-Libraries/repos","events_url":"https://api.github.com/users/UNC-Libraries/events{/privacy}","received_events_url":"https://api.github.com/users/UNC-Libraries/received_events","type":"Organization","site_admin":false},"repo":{"id":108883690,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg4ODM2OTA=","name":"hy-c","full_name":"UNC-Libraries/hy-c","owner":{"login":"UNC-Libraries","id":552066,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU1MjA2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/552066?v=4","gravatar_id":"","url":"https://api.github.com/users/UNC-Libraries","html_url":"https://github.com/UNC-Libraries","followers_url":"https://api.github.com/users/UNC-Libraries/followers","following_url":"https://api.github.com/users/UNC-Libraries/following{/other_user}","gists_url":"https://api.github.com/users/UNC-Libraries/gists{/gist_id}","starred_url":"https://api.github.com/users/UNC-Libraries/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UNC-Libraries/subscriptions","organizations_url":"https://api.github.com/users/UNC-Libraries/orgs","repos_url":"https://api.github.com/users/UNC-Libraries/repos","events_url":"https://api.github.com/users/UNC-Libraries/events{/privacy}","received_events_url":"https://api.github.com/users/UNC-Libraries/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UNC-Libraries/hy-c","description":null,"fork":false,"url":"https://api.github.com/repos/UNC-Libraries/hy-c","forks_url":"https://api.github.com/repos/UNC-Libraries/hy-c/forks","keys_url":"https://api.github.com/repos/UNC-Libraries/hy-c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UNC-Libraries/hy-c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UNC-Libraries/hy-c/teams","hooks_url":"https://api.github.com/repos/UNC-Libraries/hy-c/hooks","issue_events_url":"https://api.github.com/repos/UNC-Libraries/hy-c/issues/events{/number}","events_url":"https://api.github.com/repos/UNC-Libraries/hy-c/events","assignees_url":"https://api.github.com/repos/UNC-Libraries/hy-c/assignees{/user}","branches_url":"https://api.github.com/repos/UNC-Libraries/hy-c/branches{/branch}","tags_url":"https://api.github.com/repos/UNC-Libraries/hy-c/tags","blobs_url":"https://api.github.com/repos/UNC-Libraries/hy-c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UNC-Libraries/hy-c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UNC-Libraries/hy-c/git/refs{/sha}","trees_url":"https://api.github.com/repos/UNC-Libraries/hy-c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UNC-Libraries/hy-c/statuses/{sha}","languages_url":"https://api.github.com/repos/UNC-Libraries/hy-c/languages","stargazers_url":"https://api.github.com/repos/UNC-Libraries/hy-c/stargazers","contributors_url":"https://api.github.com/repos/UNC-Libraries/hy-c/contributors","subscribers_url":"https://api.github.com/repos/UNC-Libraries/hy-c/subscribers","subscription_url":"https://api.github.com/repos/UNC-Libraries/hy-c/subscription","commits_url":"https://api.github.com/repos/UNC-Libraries/hy-c/commits{/sha}","git_commits_url":"https://api.github.com/repos/UNC-Libraries/hy-c/git/commits{/sha}","comments_url":"https://api.github.com/repos/UNC-Libraries/hy-c/comments{/number}","issue_comment_url":"https://api.github.com/repos/UNC-Libraries/hy-c/issues/comments{/number}","contents_url":"https://api.github.com/repos/UNC-Libraries/hy-c/contents/{+path}","compare_url":"https://api.github.com/repos/UNC-Libraries/hy-c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UNC-Libraries/hy-c/merges","archive_url":"https://api.github.com/repos/UNC-Libraries/hy-c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UNC-Libraries/hy-c/downloads","issues_url":"https://api.github.com/repos/UNC-Libraries/hy-c/issues{/number}","pulls_url":"https://api.github.com/repos/UNC-Libraries/hy-c/pulls{/number}","milestones_url":"https://api.github.com/repos/UNC-Libraries/hy-c/milestones{/number}","notifications_url":"https://api.github.com/repos/UNC-Libraries/hy-c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UNC-Libraries/hy-c/labels{/name}","releases_url":"https://api.github.com/repos/UNC-Libraries/hy-c/releases{/id}","deployments_url":"https://api.github.com/repos/UNC-Libraries/hy-c/deployments","created_at":"2017-10-30T17:17:23Z","updated_at":"2018-08-14T13:25:48Z","pushed_at":"2018-08-23T21:17:40Z","git_url":"git://github.com/UNC-Libraries/hy-c.git","ssh_url":"git@github.com:UNC-Libraries/hy-c.git","clone_url":"https://github.com/UNC-Libraries/hy-c.git","svn_url":"https://github.com/UNC-Libraries/hy-c","homepage":null,"size":127771,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UNC-Libraries/hy-c/pulls/97"},"html":{"href":"https://github.com/UNC-Libraries/hy-c/pull/97"},"issue":{"href":"https://api.github.com/repos/UNC-Libraries/hy-c/issues/97"},"comments":{"href":"https://api.github.com/repos/UNC-Libraries/hy-c/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/UNC-Libraries/hy-c/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/UNC-Libraries/hy-c/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UNC-Libraries/hy-c/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/UNC-Libraries/hy-c/statuses/76c66a1817fffcc62ccc7b9b7cb4a887fb95d0db"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"smithjp"}}