{"action":"created","issue":{"url":"https://api.github.com/repos/kubeflow/tf-operator/issues/539","repository_url":"https://api.github.com/repos/kubeflow/tf-operator","labels_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/539/labels{/name}","comments_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/539/comments","events_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/539/events","html_url":"https://github.com/kubeflow/tf-operator/pull/539","id":314630091,"number":539,"title":"fix the bug of keeping creating new pdb","user":{"login":"ChanYiLin","id":7100904,"avatar_url":"https://avatars1.githubusercontent.com/u/7100904?v=4","gravatar_id":"","url":"https://api.github.com/users/ChanYiLin","html_url":"https://github.com/ChanYiLin","followers_url":"https://api.github.com/users/ChanYiLin/followers","following_url":"https://api.github.com/users/ChanYiLin/following{/other_user}","gists_url":"https://api.github.com/users/ChanYiLin/gists{/gist_id}","starred_url":"https://api.github.com/users/ChanYiLin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChanYiLin/subscriptions","organizations_url":"https://api.github.com/users/ChanYiLin/orgs","repos_url":"https://api.github.com/users/ChanYiLin/repos","events_url":"https://api.github.com/users/ChanYiLin/events{/privacy}","received_events_url":"https://api.github.com/users/ChanYiLin/received_events","type":"User","site_admin":false},"labels":[{"id":835413768,"url":"https://api.github.com/repos/kubeflow/tf-operator/labels/size/XS","name":"size/XS","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"gaocegege","id":5100735,"avatar_url":"https://avatars3.githubusercontent.com/u/5100735?v=4","gravatar_id":"","url":"https://api.github.com/users/gaocegege","html_url":"https://github.com/gaocegege","followers_url":"https://api.github.com/users/gaocegege/followers","following_url":"https://api.github.com/users/gaocegege/following{/other_user}","gists_url":"https://api.github.com/users/gaocegege/gists{/gist_id}","starred_url":"https://api.github.com/users/gaocegege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaocegege/subscriptions","organizations_url":"https://api.github.com/users/gaocegege/orgs","repos_url":"https://api.github.com/users/gaocegege/repos","events_url":"https://api.github.com/users/gaocegege/events{/privacy}","received_events_url":"https://api.github.com/users/gaocegege/received_events","type":"User","site_admin":false},"assignees":[{"login":"gaocegege","id":5100735,"avatar_url":"https://avatars3.githubusercontent.com/u/5100735?v=4","gravatar_id":"","url":"https://api.github.com/users/gaocegege","html_url":"https://github.com/gaocegege","followers_url":"https://api.github.com/users/gaocegege/followers","following_url":"https://api.github.com/users/gaocegege/following{/other_user}","gists_url":"https://api.github.com/users/gaocegege/gists{/gist_id}","starred_url":"https://api.github.com/users/gaocegege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaocegege/subscriptions","organizations_url":"https://api.github.com/users/gaocegege/orgs","repos_url":"https://api.github.com/users/gaocegege/repos","events_url":"https://api.github.com/users/gaocegege/events{/privacy}","received_events_url":"https://api.github.com/users/gaocegege/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-04-16T12:32:44Z","updated_at":"2018-04-16T13:25:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubeflow/tf-operator/pulls/539","html_url":"https://github.com/kubeflow/tf-operator/pull/539","diff_url":"https://github.com/kubeflow/tf-operator/pull/539.diff","patch_url":"https://github.com/kubeflow/tf-operator/pull/539.patch"},"body":"The original code will let the controller keep creating new pdb for the job since the names are not the same. \r\nThey only have the same prefix which is GenerateName: \"tf-job-pdb-\".\r\n\r\nI try to fix it by assigning the name, \"tf-job-pdb-\" + j.job.ObjectMeta.Name, to the pdb in order to make controller only create pdb once.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/tf-operator/539)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/kubeflow/tf-operator/issues/comments/381598202","html_url":"https://github.com/kubeflow/tf-operator/pull/539#issuecomment-381598202","issue_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/539","id":381598202,"user":{"login":"gaocegege","id":5100735,"avatar_url":"https://avatars3.githubusercontent.com/u/5100735?v=4","gravatar_id":"","url":"https://api.github.com/users/gaocegege","html_url":"https://github.com/gaocegege","followers_url":"https://api.github.com/users/gaocegege/followers","following_url":"https://api.github.com/users/gaocegege/following{/other_user}","gists_url":"https://api.github.com/users/gaocegege/gists{/gist_id}","starred_url":"https://api.github.com/users/gaocegege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaocegege/subscriptions","organizations_url":"https://api.github.com/users/gaocegege/orgs","repos_url":"https://api.github.com/users/gaocegege/repos","events_url":"https://api.github.com/users/gaocegege/events{/privacy}","received_events_url":"https://api.github.com/users/gaocegege/received_events","type":"User","site_admin":false},"created_at":"2018-04-16T13:25:18Z","updated_at":"2018-04-16T13:25:18Z","author_association":"MEMBER","body":"I do not think so. It seems that the Travis reported that the import order is not followed. Our checker is weird and it returns some errors which is not caused by your code. Let us see if it works well :smile: "}}
{"actor":{"display_login":"gaocegege"}}