{"action":"created","comment":{"url":"https://api.github.com/repos/arbor/antiope/pulls/comments/204285697","pull_request_review_id":139336282,"id":204285697,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDI4NTY5Nw==","diff_hunk":"@@ -44,6 +44,15 @@ dependencies:\n - transformers\n - unordered-containers\n \n+ghc-options:\n+- -Wall\n+- -Wcompat\n+- -Wincomplete-record-updates\n+- -Wincomplete-uni-patterns\n+- -Wredundant-constraints\n+- -O2\n+- -msse4.2","path":"antiope-dynamodb/package.yaml","position":11,"original_position":11,"commit_id":"f151057f281b936a14882b70e0d8420622855845","original_commit_id":"f151057f281b936a14882b70e0d8420622855845","user":{"login":"newhoggy","id":63014,"node_id":"MDQ6VXNlcjYzMDE0","avatar_url":"https://avatars2.githubusercontent.com/u/63014?v=4","gravatar_id":"","url":"https://api.github.com/users/newhoggy","html_url":"https://github.com/newhoggy","followers_url":"https://api.github.com/users/newhoggy/followers","following_url":"https://api.github.com/users/newhoggy/following{/other_user}","gists_url":"https://api.github.com/users/newhoggy/gists{/gist_id}","starred_url":"https://api.github.com/users/newhoggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newhoggy/subscriptions","organizations_url":"https://api.github.com/users/newhoggy/orgs","repos_url":"https://api.github.com/users/newhoggy/repos","events_url":"https://api.github.com/users/newhoggy/events{/privacy}","received_events_url":"https://api.github.com/users/newhoggy/received_events","type":"User","site_admin":false},"body":"I like the stricter options.","created_at":"2018-07-23T05:33:27Z","updated_at":"2018-07-23T05:33:27Z","html_url":"https://github.com/arbor/antiope/pull/15#discussion_r204285697","pull_request_url":"https://api.github.com/repos/arbor/antiope/pulls/15","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/arbor/antiope/pulls/comments/204285697"},"html":{"href":"https://github.com/arbor/antiope/pull/15#discussion_r204285697"},"pull_request":{"href":"https://api.github.com/repos/arbor/antiope/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/arbor/antiope/pulls/15","id":203106080,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMTA2MDgw","html_url":"https://github.com/arbor/antiope/pull/15","diff_url":"https://github.com/arbor/antiope/pull/15.diff","patch_url":"https://github.com/arbor/antiope/pull/15.patch","issue_url":"https://api.github.com/repos/arbor/antiope/issues/15","number":15,"state":"open","locked":false,"title":"MAYH-9336 antiope-sns","user":{"login":"jianwan2016","id":24264417,"node_id":"MDQ6VXNlcjI0MjY0NDE3","avatar_url":"https://avatars2.githubusercontent.com/u/24264417?v=4","gravatar_id":"","url":"https://api.github.com/users/jianwan2016","html_url":"https://github.com/jianwan2016","followers_url":"https://api.github.com/users/jianwan2016/followers","following_url":"https://api.github.com/users/jianwan2016/following{/other_user}","gists_url":"https://api.github.com/users/jianwan2016/gists{/gist_id}","starred_url":"https://api.github.com/users/jianwan2016/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jianwan2016/subscriptions","organizations_url":"https://api.github.com/users/jianwan2016/orgs","repos_url":"https://api.github.com/users/jianwan2016/repos","events_url":"https://api.github.com/users/jianwan2016/events{/privacy}","received_events_url":"https://api.github.com/users/jianwan2016/received_events","type":"User","site_admin":false},"body":"* Added `antiope-sns`\r\n* Added warnings and cleaned.\r\n\r\nTest:\r\n```\r\nλ> env <- mkEnv Oregon (\\l bs -> return ()) \r\nλ> runResourceT $ runAWS env $ publishMsg \"arn:aws:sns:us-west-2:143032791481:wan-MaxMindRawTopic\" \"test\"\r\nit :: ()\r\n```\r\n\r\nAnd run 10s of `publishMsg`, check `lsof` to see whether there are leaked connection: looks like no.\r\n```\r\nλ> sequence_ $ [runResourceT $ runAWS env $ publishMsg \"arn:aws:sns:us-west-2:143032791481:wan-MaxMindRawTopic\" \"test\" | _ <- take 1000 [1..]]\r\njwan@~/Start/atlas/python $ lsof -p 38158  | wc -l\r\n     153\r\njwan@~/Start/atlas/python $ lsof -p 38158  | wc -l\r\n     153\r\n```\r\n\r\n```\r\nrunResourceT $ runAWS env $ sequence_ $ [publishMsg \"arn:aws:sns:us-west-2:143032791481:wan-MaxMindRawTopic\" \"test\" | _ <- take 1000 [1..]]\r\n\r\njwan@~/Start/atlas/python $ lsof -p 38158  | wc -l\r\n     153\r\n```\r\n\r\n","created_at":"2018-07-23T04:26:52Z","updated_at":"2018-07-23T05:33:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"add33dfa895117094f5baf5a783bbf615cbf5fcf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/arbor/antiope/pulls/15/commits","review_comments_url":"https://api.github.com/repos/arbor/antiope/pulls/15/comments","review_comment_url":"https://api.github.com/repos/arbor/antiope/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arbor/antiope/issues/15/comments","statuses_url":"https://api.github.com/repos/arbor/antiope/statuses/f151057f281b936a14882b70e0d8420622855845","head":{"label":"arbor:MAYH-9336-antiope-sns","ref":"MAYH-9336-antiope-sns","sha":"f151057f281b936a14882b70e0d8420622855845","user":{"login":"arbor","id":2744495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDQ0OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2744495?v=4","gravatar_id":"","url":"https://api.github.com/users/arbor","html_url":"https://github.com/arbor","followers_url":"https://api.github.com/users/arbor/followers","following_url":"https://api.github.com/users/arbor/following{/other_user}","gists_url":"https://api.github.com/users/arbor/gists{/gist_id}","starred_url":"https://api.github.com/users/arbor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arbor/subscriptions","organizations_url":"https://api.github.com/users/arbor/orgs","repos_url":"https://api.github.com/users/arbor/repos","events_url":"https://api.github.com/users/arbor/events{/privacy}","received_events_url":"https://api.github.com/users/arbor/received_events","type":"Organization","site_admin":false},"repo":{"id":127414411,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc0MTQ0MTE=","name":"antiope","full_name":"arbor/antiope","owner":{"login":"arbor","id":2744495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDQ0OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2744495?v=4","gravatar_id":"","url":"https://api.github.com/users/arbor","html_url":"https://github.com/arbor","followers_url":"https://api.github.com/users/arbor/followers","following_url":"https://api.github.com/users/arbor/following{/other_user}","gists_url":"https://api.github.com/users/arbor/gists{/gist_id}","starred_url":"https://api.github.com/users/arbor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arbor/subscriptions","organizations_url":"https://api.github.com/users/arbor/orgs","repos_url":"https://api.github.com/users/arbor/repos","events_url":"https://api.github.com/users/arbor/events{/privacy}","received_events_url":"https://api.github.com/users/arbor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arbor/antiope","description":"A tiny wrapper around Amazonka","fork":false,"url":"https://api.github.com/repos/arbor/antiope","forks_url":"https://api.github.com/repos/arbor/antiope/forks","keys_url":"https://api.github.com/repos/arbor/antiope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arbor/antiope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arbor/antiope/teams","hooks_url":"https://api.github.com/repos/arbor/antiope/hooks","issue_events_url":"https://api.github.com/repos/arbor/antiope/issues/events{/number}","events_url":"https://api.github.com/repos/arbor/antiope/events","assignees_url":"https://api.github.com/repos/arbor/antiope/assignees{/user}","branches_url":"https://api.github.com/repos/arbor/antiope/branches{/branch}","tags_url":"https://api.github.com/repos/arbor/antiope/tags","blobs_url":"https://api.github.com/repos/arbor/antiope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arbor/antiope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arbor/antiope/git/refs{/sha}","trees_url":"https://api.github.com/repos/arbor/antiope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arbor/antiope/statuses/{sha}","languages_url":"https://api.github.com/repos/arbor/antiope/languages","stargazers_url":"https://api.github.com/repos/arbor/antiope/stargazers","contributors_url":"https://api.github.com/repos/arbor/antiope/contributors","subscribers_url":"https://api.github.com/repos/arbor/antiope/subscribers","subscription_url":"https://api.github.com/repos/arbor/antiope/subscription","commits_url":"https://api.github.com/repos/arbor/antiope/commits{/sha}","git_commits_url":"https://api.github.com/repos/arbor/antiope/git/commits{/sha}","comments_url":"https://api.github.com/repos/arbor/antiope/comments{/number}","issue_comment_url":"https://api.github.com/repos/arbor/antiope/issues/comments{/number}","contents_url":"https://api.github.com/repos/arbor/antiope/contents/{+path}","compare_url":"https://api.github.com/repos/arbor/antiope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arbor/antiope/merges","archive_url":"https://api.github.com/repos/arbor/antiope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arbor/antiope/downloads","issues_url":"https://api.github.com/repos/arbor/antiope/issues{/number}","pulls_url":"https://api.github.com/repos/arbor/antiope/pulls{/number}","milestones_url":"https://api.github.com/repos/arbor/antiope/milestones{/number}","notifications_url":"https://api.github.com/repos/arbor/antiope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arbor/antiope/labels{/name}","releases_url":"https://api.github.com/repos/arbor/antiope/releases{/id}","deployments_url":"https://api.github.com/repos/arbor/antiope/deployments","created_at":"2018-03-30T10:16:44Z","updated_at":"2018-07-17T05:25:46Z","pushed_at":"2018-07-23T04:29:37Z","git_url":"git://github.com/arbor/antiope.git","ssh_url":"git@github.com:arbor/antiope.git","clone_url":"https://github.com/arbor/antiope.git","svn_url":"https://github.com/arbor/antiope","homepage":null,"size":46,"stargazers_count":1,"watchers_count":1,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"arbor:master","ref":"master","sha":"4c661ba1fe59cafc3d5f49da3ee356ede7449124","user":{"login":"arbor","id":2744495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDQ0OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2744495?v=4","gravatar_id":"","url":"https://api.github.com/users/arbor","html_url":"https://github.com/arbor","followers_url":"https://api.github.com/users/arbor/followers","following_url":"https://api.github.com/users/arbor/following{/other_user}","gists_url":"https://api.github.com/users/arbor/gists{/gist_id}","starred_url":"https://api.github.com/users/arbor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arbor/subscriptions","organizations_url":"https://api.github.com/users/arbor/orgs","repos_url":"https://api.github.com/users/arbor/repos","events_url":"https://api.github.com/users/arbor/events{/privacy}","received_events_url":"https://api.github.com/users/arbor/received_events","type":"Organization","site_admin":false},"repo":{"id":127414411,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc0MTQ0MTE=","name":"antiope","full_name":"arbor/antiope","owner":{"login":"arbor","id":2744495,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NDQ0OTU=","avatar_url":"https://avatars2.githubusercontent.com/u/2744495?v=4","gravatar_id":"","url":"https://api.github.com/users/arbor","html_url":"https://github.com/arbor","followers_url":"https://api.github.com/users/arbor/followers","following_url":"https://api.github.com/users/arbor/following{/other_user}","gists_url":"https://api.github.com/users/arbor/gists{/gist_id}","starred_url":"https://api.github.com/users/arbor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arbor/subscriptions","organizations_url":"https://api.github.com/users/arbor/orgs","repos_url":"https://api.github.com/users/arbor/repos","events_url":"https://api.github.com/users/arbor/events{/privacy}","received_events_url":"https://api.github.com/users/arbor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arbor/antiope","description":"A tiny wrapper around Amazonka","fork":false,"url":"https://api.github.com/repos/arbor/antiope","forks_url":"https://api.github.com/repos/arbor/antiope/forks","keys_url":"https://api.github.com/repos/arbor/antiope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arbor/antiope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arbor/antiope/teams","hooks_url":"https://api.github.com/repos/arbor/antiope/hooks","issue_events_url":"https://api.github.com/repos/arbor/antiope/issues/events{/number}","events_url":"https://api.github.com/repos/arbor/antiope/events","assignees_url":"https://api.github.com/repos/arbor/antiope/assignees{/user}","branches_url":"https://api.github.com/repos/arbor/antiope/branches{/branch}","tags_url":"https://api.github.com/repos/arbor/antiope/tags","blobs_url":"https://api.github.com/repos/arbor/antiope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arbor/antiope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arbor/antiope/git/refs{/sha}","trees_url":"https://api.github.com/repos/arbor/antiope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arbor/antiope/statuses/{sha}","languages_url":"https://api.github.com/repos/arbor/antiope/languages","stargazers_url":"https://api.github.com/repos/arbor/antiope/stargazers","contributors_url":"https://api.github.com/repos/arbor/antiope/contributors","subscribers_url":"https://api.github.com/repos/arbor/antiope/subscribers","subscription_url":"https://api.github.com/repos/arbor/antiope/subscription","commits_url":"https://api.github.com/repos/arbor/antiope/commits{/sha}","git_commits_url":"https://api.github.com/repos/arbor/antiope/git/commits{/sha}","comments_url":"https://api.github.com/repos/arbor/antiope/comments{/number}","issue_comment_url":"https://api.github.com/repos/arbor/antiope/issues/comments{/number}","contents_url":"https://api.github.com/repos/arbor/antiope/contents/{+path}","compare_url":"https://api.github.com/repos/arbor/antiope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arbor/antiope/merges","archive_url":"https://api.github.com/repos/arbor/antiope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arbor/antiope/downloads","issues_url":"https://api.github.com/repos/arbor/antiope/issues{/number}","pulls_url":"https://api.github.com/repos/arbor/antiope/pulls{/number}","milestones_url":"https://api.github.com/repos/arbor/antiope/milestones{/number}","notifications_url":"https://api.github.com/repos/arbor/antiope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arbor/antiope/labels{/name}","releases_url":"https://api.github.com/repos/arbor/antiope/releases{/id}","deployments_url":"https://api.github.com/repos/arbor/antiope/deployments","created_at":"2018-03-30T10:16:44Z","updated_at":"2018-07-17T05:25:46Z","pushed_at":"2018-07-23T04:29:37Z","git_url":"git://github.com/arbor/antiope.git","ssh_url":"git@github.com:arbor/antiope.git","clone_url":"https://github.com/arbor/antiope.git","svn_url":"https://github.com/arbor/antiope","homepage":null,"size":46,"stargazers_count":1,"watchers_count":1,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arbor/antiope/pulls/15"},"html":{"href":"https://github.com/arbor/antiope/pull/15"},"issue":{"href":"https://api.github.com/repos/arbor/antiope/issues/15"},"comments":{"href":"https://api.github.com/repos/arbor/antiope/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/arbor/antiope/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/arbor/antiope/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arbor/antiope/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/arbor/antiope/statuses/f151057f281b936a14882b70e0d8420622855845"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"newhoggy"}}