{"action":"created","comment":{"url":"https://api.github.com/repos/KLFitter/KLFitter/pulls/comments/209202131","pull_request_review_id":145170175,"id":209202131,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTIwMjEzMQ==","diff_hunk":"@@ -0,0 +1,251 @@\n+/*\n+ * Copyright (c) 2009--2018, the KLFitter developer team\n+ *\n+ * This file is part of KLFitter.\n+ *\n+ * KLFitter is free software: you can redistribute it and/or modify it\n+ * under the terms of the GNU Lesser General Public License as published by\n+ * the Free Software Foundation, either version 3 of the License, or (at\n+ * your option) any later version.\n+ *\n+ * KLFitter is distributed in the hope that it will be useful, but WITHOUT\n+ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or\n+ * FITNESS FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public\n+ * License for more details.\n+ *\n+ * You should have received a copy of the GNU Lesser General Public License\n+ * along with KLFitter. If not, see <http://www.gnu.org/licenses/>.\n+ */\n+\n+\n+// --------------------------------------------------------- \n+\n+#ifndef LIKELIHOODTWOTRACKS\n+#define LIKELIHOODTWOTRACKS\n+\n+// --------------------------------------------------------- \n+\n+#include \"LikelihoodBase.h\" \n+#include \"TLorentzVector.h\"\n+#include \"ResolutionBase.h\"\n+\n+#include <iostream>\n+\n+// --------------------------------------------------------- \n+\n+/*!\n+ * \\namespace KLFitter\n+ * \\brief The KLFitter namespace\n+ */\n+namespace KLFitter\n+{\n+\n+  class LikelihoodTwoTracks : public KLFitter::LikelihoodBase\n+  {\n+                \n+  public: \n+                \n+    /** \\name Constructors and destructors */ \n+    /* @{ */ \n+                \n+    /** \n+     * The default constructor. \n+     */ \n+    LikelihoodTwoTracks(); \n+                \n+    /**\n+     * The default destructor.\n+     */\n+    ~LikelihoodTwoTracks(); \n+\n+    /**\n+     * Calculate 3D Gaussian.\n+     */\n+    double Log3DGaus(double x0, double x1, double x2, double mean0, double mean1, double mean2, double sigma00, double sigma10, double sigma11, double sigma20, double sigma21, double sigma22);","path":"include/KLFitter/LikelihoodTwoTracks.h","position":64,"original_position":64,"commit_id":"ccf234f89455f6eda2ecccb4317fc2ca3939fe0b","original_commit_id":"ccf234f89455f6eda2ecccb4317fc2ca3939fe0b","user":{"login":"Soonja","id":6968352,"node_id":"MDQ6VXNlcjY5NjgzNTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6968352?v=4","gravatar_id":"","url":"https://api.github.com/users/Soonja","html_url":"https://github.com/Soonja","followers_url":"https://api.github.com/users/Soonja/followers","following_url":"https://api.github.com/users/Soonja/following{/other_user}","gists_url":"https://api.github.com/users/Soonja/gists{/gist_id}","starred_url":"https://api.github.com/users/Soonja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soonja/subscriptions","organizations_url":"https://api.github.com/users/Soonja/orgs","repos_url":"https://api.github.com/users/Soonja/repos","events_url":"https://api.github.com/users/Soonja/events{/privacy}","received_events_url":"https://api.github.com/users/Soonja/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-08-10T09:34:04Z","updated_at":"2018-08-10T09:34:04Z","html_url":"https://github.com/KLFitter/KLFitter/pull/60#discussion_r209202131","pull_request_url":"https://api.github.com/repos/KLFitter/KLFitter/pulls/60","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/KLFitter/KLFitter/pulls/comments/209202131"},"html":{"href":"https://github.com/KLFitter/KLFitter/pull/60#discussion_r209202131"},"pull_request":{"href":"https://api.github.com/repos/KLFitter/KLFitter/pulls/60"}},"in_reply_to_id":209010302},"pull_request":{"url":"https://api.github.com/repos/KLFitter/KLFitter/pulls/60","id":207090812,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MDkwODEy","html_url":"https://github.com/KLFitter/KLFitter/pull/60","diff_url":"https://github.com/KLFitter/KLFitter/pull/60.diff","patch_url":"https://github.com/KLFitter/KLFitter/pull/60.patch","issue_url":"https://api.github.com/repos/KLFitter/KLFitter/issues/60","number":60,"state":"open","locked":false,"title":"Implementation of a new likelihood to fit two tracks from a decaying …","user":{"login":"Soonja","id":6968352,"node_id":"MDQ6VXNlcjY5NjgzNTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6968352?v=4","gravatar_id":"","url":"https://api.github.com/users/Soonja","html_url":"https://github.com/Soonja","followers_url":"https://api.github.com/users/Soonja/followers","following_url":"https://api.github.com/users/Soonja/following{/other_user}","gists_url":"https://api.github.com/users/Soonja/gists{/gist_id}","starred_url":"https://api.github.com/users/Soonja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soonja/subscriptions","organizations_url":"https://api.github.com/users/Soonja/orgs","repos_url":"https://api.github.com/users/Soonja/repos","events_url":"https://api.github.com/users/Soonja/events{/privacy}","received_events_url":"https://api.github.com/users/Soonja/received_events","type":"User","site_admin":false},"body":"…particle\r\n\r\nImplementation of a new likelihood with the purpose of fitting two tracks to one decaying particle. First use case: K_S->pi^+pi^-\r\n\r\n## Description\r\nNew likelihood: LikelihoodTwoTracks\r\nNew type of particle: Track\r\nNew attribute: Uncertainties, used for the uncertainties associated to measured tracks\r\n\r\n## Motivation and Context\r\n\r\nAllows for the kinematic fit of two tracks to one particle they originate from under consideration of uncertainties associated to the tracks.\r\n\r\n## How Has This Been Tested?\r\nChanges have been tested in an nTuple production using ATLAS's AnalysisTop 21.2.37\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n","created_at":"2018-08-08T18:04:03Z","updated_at":"2018-08-10T09:34:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1581f8732e1a0af68f226d01c443743ec9fee58b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KLFitter/KLFitter/pulls/60/commits","review_comments_url":"https://api.github.com/repos/KLFitter/KLFitter/pulls/60/comments","review_comment_url":"https://api.github.com/repos/KLFitter/KLFitter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KLFitter/KLFitter/issues/60/comments","statuses_url":"https://api.github.com/repos/KLFitter/KLFitter/statuses/ccf234f89455f6eda2ecccb4317fc2ca3939fe0b","head":{"label":"Soonja:LikelihoodTwoTracks_v1","ref":"LikelihoodTwoTracks_v1","sha":"ccf234f89455f6eda2ecccb4317fc2ca3939fe0b","user":{"login":"Soonja","id":6968352,"node_id":"MDQ6VXNlcjY5NjgzNTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6968352?v=4","gravatar_id":"","url":"https://api.github.com/users/Soonja","html_url":"https://github.com/Soonja","followers_url":"https://api.github.com/users/Soonja/followers","following_url":"https://api.github.com/users/Soonja/following{/other_user}","gists_url":"https://api.github.com/users/Soonja/gists{/gist_id}","starred_url":"https://api.github.com/users/Soonja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soonja/subscriptions","organizations_url":"https://api.github.com/users/Soonja/orgs","repos_url":"https://api.github.com/users/Soonja/repos","events_url":"https://api.github.com/users/Soonja/events{/privacy}","received_events_url":"https://api.github.com/users/Soonja/received_events","type":"User","site_admin":false},"repo":{"id":144009639,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQwMDk2Mzk=","name":"KLFitter","full_name":"Soonja/KLFitter","owner":{"login":"Soonja","id":6968352,"node_id":"MDQ6VXNlcjY5NjgzNTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6968352?v=4","gravatar_id":"","url":"https://api.github.com/users/Soonja","html_url":"https://github.com/Soonja","followers_url":"https://api.github.com/users/Soonja/followers","following_url":"https://api.github.com/users/Soonja/following{/other_user}","gists_url":"https://api.github.com/users/Soonja/gists{/gist_id}","starred_url":"https://api.github.com/users/Soonja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soonja/subscriptions","organizations_url":"https://api.github.com/users/Soonja/orgs","repos_url":"https://api.github.com/users/Soonja/repos","events_url":"https://api.github.com/users/Soonja/events{/privacy}","received_events_url":"https://api.github.com/users/Soonja/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Soonja/KLFitter","description":"Repository hosting the KLFitter library – the Kinematic Likelihood Fitter.","fork":true,"url":"https://api.github.com/repos/Soonja/KLFitter","forks_url":"https://api.github.com/repos/Soonja/KLFitter/forks","keys_url":"https://api.github.com/repos/Soonja/KLFitter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Soonja/KLFitter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Soonja/KLFitter/teams","hooks_url":"https://api.github.com/repos/Soonja/KLFitter/hooks","issue_events_url":"https://api.github.com/repos/Soonja/KLFitter/issues/events{/number}","events_url":"https://api.github.com/repos/Soonja/KLFitter/events","assignees_url":"https://api.github.com/repos/Soonja/KLFitter/assignees{/user}","branches_url":"https://api.github.com/repos/Soonja/KLFitter/branches{/branch}","tags_url":"https://api.github.com/repos/Soonja/KLFitter/tags","blobs_url":"https://api.github.com/repos/Soonja/KLFitter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Soonja/KLFitter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Soonja/KLFitter/git/refs{/sha}","trees_url":"https://api.github.com/repos/Soonja/KLFitter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Soonja/KLFitter/statuses/{sha}","languages_url":"https://api.github.com/repos/Soonja/KLFitter/languages","stargazers_url":"https://api.github.com/repos/Soonja/KLFitter/stargazers","contributors_url":"https://api.github.com/repos/Soonja/KLFitter/contributors","subscribers_url":"https://api.github.com/repos/Soonja/KLFitter/subscribers","subscription_url":"https://api.github.com/repos/Soonja/KLFitter/subscription","commits_url":"https://api.github.com/repos/Soonja/KLFitter/commits{/sha}","git_commits_url":"https://api.github.com/repos/Soonja/KLFitter/git/commits{/sha}","comments_url":"https://api.github.com/repos/Soonja/KLFitter/comments{/number}","issue_comment_url":"https://api.github.com/repos/Soonja/KLFitter/issues/comments{/number}","contents_url":"https://api.github.com/repos/Soonja/KLFitter/contents/{+path}","compare_url":"https://api.github.com/repos/Soonja/KLFitter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Soonja/KLFitter/merges","archive_url":"https://api.github.com/repos/Soonja/KLFitter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Soonja/KLFitter/downloads","issues_url":"https://api.github.com/repos/Soonja/KLFitter/issues{/number}","pulls_url":"https://api.github.com/repos/Soonja/KLFitter/pulls{/number}","milestones_url":"https://api.github.com/repos/Soonja/KLFitter/milestones{/number}","notifications_url":"https://api.github.com/repos/Soonja/KLFitter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Soonja/KLFitter/labels{/name}","releases_url":"https://api.github.com/repos/Soonja/KLFitter/releases{/id}","deployments_url":"https://api.github.com/repos/Soonja/KLFitter/deployments","created_at":"2018-08-08T12:20:21Z","updated_at":"2018-08-08T12:20:23Z","pushed_at":"2018-08-09T14:55:36Z","git_url":"git://github.com/Soonja/KLFitter.git","ssh_url":"git@github.com:Soonja/KLFitter.git","clone_url":"https://github.com/Soonja/KLFitter.git","svn_url":"https://github.com/Soonja/KLFitter","homepage":"","size":2354,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KLFitter:master","ref":"master","sha":"8c299330de8a56e3244d672874ea41ba906ec52f","user":{"login":"KLFitter","id":36031760,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDMxNzYw","avatar_url":"https://avatars3.githubusercontent.com/u/36031760?v=4","gravatar_id":"","url":"https://api.github.com/users/KLFitter","html_url":"https://github.com/KLFitter","followers_url":"https://api.github.com/users/KLFitter/followers","following_url":"https://api.github.com/users/KLFitter/following{/other_user}","gists_url":"https://api.github.com/users/KLFitter/gists{/gist_id}","starred_url":"https://api.github.com/users/KLFitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KLFitter/subscriptions","organizations_url":"https://api.github.com/users/KLFitter/orgs","repos_url":"https://api.github.com/users/KLFitter/repos","events_url":"https://api.github.com/users/KLFitter/events{/privacy}","received_events_url":"https://api.github.com/users/KLFitter/received_events","type":"Organization","site_admin":false},"repo":{"id":129797212,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk3OTcyMTI=","name":"KLFitter","full_name":"KLFitter/KLFitter","owner":{"login":"KLFitter","id":36031760,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDMxNzYw","avatar_url":"https://avatars3.githubusercontent.com/u/36031760?v=4","gravatar_id":"","url":"https://api.github.com/users/KLFitter","html_url":"https://github.com/KLFitter","followers_url":"https://api.github.com/users/KLFitter/followers","following_url":"https://api.github.com/users/KLFitter/following{/other_user}","gists_url":"https://api.github.com/users/KLFitter/gists{/gist_id}","starred_url":"https://api.github.com/users/KLFitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KLFitter/subscriptions","organizations_url":"https://api.github.com/users/KLFitter/orgs","repos_url":"https://api.github.com/users/KLFitter/repos","events_url":"https://api.github.com/users/KLFitter/events{/privacy}","received_events_url":"https://api.github.com/users/KLFitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KLFitter/KLFitter","description":"Repository hosting the KLFitter library – the Kinematic Likelihood Fitter.","fork":false,"url":"https://api.github.com/repos/KLFitter/KLFitter","forks_url":"https://api.github.com/repos/KLFitter/KLFitter/forks","keys_url":"https://api.github.com/repos/KLFitter/KLFitter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KLFitter/KLFitter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KLFitter/KLFitter/teams","hooks_url":"https://api.github.com/repos/KLFitter/KLFitter/hooks","issue_events_url":"https://api.github.com/repos/KLFitter/KLFitter/issues/events{/number}","events_url":"https://api.github.com/repos/KLFitter/KLFitter/events","assignees_url":"https://api.github.com/repos/KLFitter/KLFitter/assignees{/user}","branches_url":"https://api.github.com/repos/KLFitter/KLFitter/branches{/branch}","tags_url":"https://api.github.com/repos/KLFitter/KLFitter/tags","blobs_url":"https://api.github.com/repos/KLFitter/KLFitter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KLFitter/KLFitter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KLFitter/KLFitter/git/refs{/sha}","trees_url":"https://api.github.com/repos/KLFitter/KLFitter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KLFitter/KLFitter/statuses/{sha}","languages_url":"https://api.github.com/repos/KLFitter/KLFitter/languages","stargazers_url":"https://api.github.com/repos/KLFitter/KLFitter/stargazers","contributors_url":"https://api.github.com/repos/KLFitter/KLFitter/contributors","subscribers_url":"https://api.github.com/repos/KLFitter/KLFitter/subscribers","subscription_url":"https://api.github.com/repos/KLFitter/KLFitter/subscription","commits_url":"https://api.github.com/repos/KLFitter/KLFitter/commits{/sha}","git_commits_url":"https://api.github.com/repos/KLFitter/KLFitter/git/commits{/sha}","comments_url":"https://api.github.com/repos/KLFitter/KLFitter/comments{/number}","issue_comment_url":"https://api.github.com/repos/KLFitter/KLFitter/issues/comments{/number}","contents_url":"https://api.github.com/repos/KLFitter/KLFitter/contents/{+path}","compare_url":"https://api.github.com/repos/KLFitter/KLFitter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KLFitter/KLFitter/merges","archive_url":"https://api.github.com/repos/KLFitter/KLFitter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KLFitter/KLFitter/downloads","issues_url":"https://api.github.com/repos/KLFitter/KLFitter/issues{/number}","pulls_url":"https://api.github.com/repos/KLFitter/KLFitter/pulls{/number}","milestones_url":"https://api.github.com/repos/KLFitter/KLFitter/milestones{/number}","notifications_url":"https://api.github.com/repos/KLFitter/KLFitter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KLFitter/KLFitter/labels{/name}","releases_url":"https://api.github.com/repos/KLFitter/KLFitter/releases{/id}","deployments_url":"https://api.github.com/repos/KLFitter/KLFitter/deployments","created_at":"2018-04-16T19:49:13Z","updated_at":"2018-08-08T16:15:49Z","pushed_at":"2018-08-09T14:55:38Z","git_url":"git://github.com/KLFitter/KLFitter.git","ssh_url":"git@github.com:KLFitter/KLFitter.git","clone_url":"https://github.com/KLFitter/KLFitter.git","svn_url":"https://github.com/KLFitter/KLFitter","homepage":"","size":2339,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":5,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KLFitter/KLFitter/pulls/60"},"html":{"href":"https://github.com/KLFitter/KLFitter/pull/60"},"issue":{"href":"https://api.github.com/repos/KLFitter/KLFitter/issues/60"},"comments":{"href":"https://api.github.com/repos/KLFitter/KLFitter/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/KLFitter/KLFitter/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/KLFitter/KLFitter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KLFitter/KLFitter/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/KLFitter/KLFitter/statuses/ccf234f89455f6eda2ecccb4317fc2ca3939fe0b"}},"author_association":"NONE"}}
{"actor":{"display_login":"Soonja"}}