{"action":"created","comment":{"url":"https://api.github.com/repos/Babylonpartners/ios-playbook/pulls/comments/231998224","pull_request_review_id":173092244,"id":231998224,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTk5ODIyNA==","diff_hunk":"@@ -81,39 +78,24 @@ Descriptive and consistent naming makes software easier to read and understand.\n - naming methods for their side effects\n   - verb methods follow the -ed, -ing rule for the non-mutating version\n   - noun methods follow the formX rule for the mutating version\n-  - boolean types should read like assertions\n+  - boolean types should read like assertions (`isLoading`, `isHidden`, etc)\n   - protocols that describe _what something is_ should read as nouns\n   - protocols that describe _a capability_ should end in _-able_ or _-ible_\n - using terms that don't surprise experts or confuse beginners\n-- generally avoiding abbreviations\n-- using precedent for names\n+- generally avoiding abbreviations // a few well-known ones are allowed, such as, `Html` and `Id`. Any others?","path":"Style-guide/README.md","position":39,"original_position":39,"commit_id":"4f13330adc9765bfe11c73d8d926b586b5eb7fa5","original_commit_id":"4f13330adc9765bfe11c73d8d926b586b5eb7fa5","user":{"login":"wltrup","id":1015142,"node_id":"MDQ6VXNlcjEwMTUxNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1015142?v=4","gravatar_id":"","url":"https://api.github.com/users/wltrup","html_url":"https://github.com/wltrup","followers_url":"https://api.github.com/users/wltrup/followers","following_url":"https://api.github.com/users/wltrup/following{/other_user}","gists_url":"https://api.github.com/users/wltrup/gists{/gist_id}","starred_url":"https://api.github.com/users/wltrup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wltrup/subscriptions","organizations_url":"https://api.github.com/users/wltrup/orgs","repos_url":"https://api.github.com/users/wltrup/repos","events_url":"https://api.github.com/users/wltrup/events{/privacy}","received_events_url":"https://api.github.com/users/wltrup/received_events","type":"User","site_admin":false},"body":"(I've had to change the line above to trigger a diff, else we couldn't comment on the line. The inline comment will be removed.)\r\n\r\nA few well-known ones are allowed, such as, `Html` and `Id`. Any others?","created_at":"2018-11-08T17:51:22Z","updated_at":"2018-11-08T17:51:22Z","html_url":"https://github.com/Babylonpartners/ios-playbook/pull/9#discussion_r231998224","pull_request_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/pulls/9","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Babylonpartners/ios-playbook/pulls/comments/231998224"},"html":{"href":"https://github.com/Babylonpartners/ios-playbook/pull/9#discussion_r231998224"},"pull_request":{"href":"https://api.github.com/repos/Babylonpartners/ios-playbook/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/Babylonpartners/ios-playbook/pulls/9","id":229450844,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDUwODQ0","html_url":"https://github.com/Babylonpartners/ios-playbook/pull/9","diff_url":"https://github.com/Babylonpartners/ios-playbook/pull/9.diff","patch_url":"https://github.com/Babylonpartners/ios-playbook/pull/9.patch","issue_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/issues/9","number":9,"state":"open","locked":false,"title":"[Style guide] Adds several more sections","user":{"login":"wltrup","id":1015142,"node_id":"MDQ6VXNlcjEwMTUxNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1015142?v=4","gravatar_id":"","url":"https://api.github.com/users/wltrup","html_url":"https://github.com/wltrup","followers_url":"https://api.github.com/users/wltrup/followers","following_url":"https://api.github.com/users/wltrup/following{/other_user}","gists_url":"https://api.github.com/users/wltrup/gists{/gist_id}","starred_url":"https://api.github.com/users/wltrup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wltrup/subscriptions","organizations_url":"https://api.github.com/users/wltrup/orgs","repos_url":"https://api.github.com/users/wltrup/repos","events_url":"https://api.github.com/users/wltrup/events{/privacy}","received_events_url":"https://api.github.com/users/wltrup/received_events","type":"User","site_admin":false},"body":"Full document [here](https://github.com/Babylonpartners/ios-playbook/blob/wagner/style-guide/naming/Style-guide/README.md)","created_at":"2018-11-08T17:35:07Z","updated_at":"2018-11-08T17:51:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27d1a9d65628171a820d064e3e519b305a785d91","assignee":{"login":"wltrup","id":1015142,"node_id":"MDQ6VXNlcjEwMTUxNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1015142?v=4","gravatar_id":"","url":"https://api.github.com/users/wltrup","html_url":"https://github.com/wltrup","followers_url":"https://api.github.com/users/wltrup/followers","following_url":"https://api.github.com/users/wltrup/following{/other_user}","gists_url":"https://api.github.com/users/wltrup/gists{/gist_id}","starred_url":"https://api.github.com/users/wltrup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wltrup/subscriptions","organizations_url":"https://api.github.com/users/wltrup/orgs","repos_url":"https://api.github.com/users/wltrup/repos","events_url":"https://api.github.com/users/wltrup/events{/privacy}","received_events_url":"https://api.github.com/users/wltrup/received_events","type":"User","site_admin":false},"assignees":[{"login":"wltrup","id":1015142,"node_id":"MDQ6VXNlcjEwMTUxNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/1015142?v=4","gravatar_id":"","url":"https://api.github.com/users/wltrup","html_url":"https://github.com/wltrup","followers_url":"https://api.github.com/users/wltrup/followers","following_url":"https://api.github.com/users/wltrup/following{/other_user}","gists_url":"https://api.github.com/users/wltrup/gists{/gist_id}","starred_url":"https://api.github.com/users/wltrup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wltrup/subscriptions","organizations_url":"https://api.github.com/users/wltrup/orgs","repos_url":"https://api.github.com/users/wltrup/repos","events_url":"https://api.github.com/users/wltrup/events{/privacy}","received_events_url":"https://api.github.com/users/wltrup/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1095052893,"node_id":"MDU6TGFiZWwxMDk1MDUyODkz","url":"https://api.github.com/repos/Babylonpartners/ios-playbook/labels/Ready%20for%20Review%20%F0%9F%9A%80","name":"Ready for Review 🚀","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/pulls/9/commits","review_comments_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/pulls/9/comments","review_comment_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/issues/9/comments","statuses_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/statuses/4f13330adc9765bfe11c73d8d926b586b5eb7fa5","head":{"label":"Babylonpartners:wagner/style-guide/naming","ref":"wagner/style-guide/naming","sha":"4f13330adc9765bfe11c73d8d926b586b5eb7fa5","user":{"login":"Babylonpartners","id":6124714,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMjQ3MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6124714?v=4","gravatar_id":"","url":"https://api.github.com/users/Babylonpartners","html_url":"https://github.com/Babylonpartners","followers_url":"https://api.github.com/users/Babylonpartners/followers","following_url":"https://api.github.com/users/Babylonpartners/following{/other_user}","gists_url":"https://api.github.com/users/Babylonpartners/gists{/gist_id}","starred_url":"https://api.github.com/users/Babylonpartners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Babylonpartners/subscriptions","organizations_url":"https://api.github.com/users/Babylonpartners/orgs","repos_url":"https://api.github.com/users/Babylonpartners/repos","events_url":"https://api.github.com/users/Babylonpartners/events{/privacy}","received_events_url":"https://api.github.com/users/Babylonpartners/received_events","type":"Organization","site_admin":false},"repo":{"id":153272170,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMyNzIxNzA=","name":"ios-playbook","full_name":"Babylonpartners/ios-playbook","private":false,"owner":{"login":"Babylonpartners","id":6124714,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMjQ3MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6124714?v=4","gravatar_id":"","url":"https://api.github.com/users/Babylonpartners","html_url":"https://github.com/Babylonpartners","followers_url":"https://api.github.com/users/Babylonpartners/followers","following_url":"https://api.github.com/users/Babylonpartners/following{/other_user}","gists_url":"https://api.github.com/users/Babylonpartners/gists{/gist_id}","starred_url":"https://api.github.com/users/Babylonpartners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Babylonpartners/subscriptions","organizations_url":"https://api.github.com/users/Babylonpartners/orgs","repos_url":"https://api.github.com/users/Babylonpartners/repos","events_url":"https://api.github.com/users/Babylonpartners/events{/privacy}","received_events_url":"https://api.github.com/users/Babylonpartners/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Babylonpartners/ios-playbook","description":null,"fork":false,"url":"https://api.github.com/repos/Babylonpartners/ios-playbook","forks_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/forks","keys_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/teams","hooks_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/hooks","issue_events_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/issues/events{/number}","events_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/events","assignees_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/assignees{/user}","branches_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/branches{/branch}","tags_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/tags","blobs_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/statuses/{sha}","languages_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/languages","stargazers_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/stargazers","contributors_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/contributors","subscribers_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/subscribers","subscription_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/subscription","commits_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/contents/{+path}","compare_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/merges","archive_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/downloads","issues_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/issues{/number}","pulls_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/pulls{/number}","milestones_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/milestones{/number}","notifications_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/labels{/name}","releases_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/releases{/id}","deployments_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/deployments","created_at":"2018-10-16T11:10:34Z","updated_at":"2018-11-07T15:51:57Z","pushed_at":"2018-11-08T17:49:35Z","git_url":"git://github.com/Babylonpartners/ios-playbook.git","ssh_url":"git@github.com:Babylonpartners/ios-playbook.git","clone_url":"https://github.com/Babylonpartners/ios-playbook.git","svn_url":"https://github.com/Babylonpartners/ios-playbook","homepage":null,"size":451,"stargazers_count":36,"watchers_count":36,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":36,"default_branch":"master"}},"base":{"label":"Babylonpartners:wagner/style-guide/pre-master","ref":"wagner/style-guide/pre-master","sha":"fd341e356db8294eded22b934b302a6afca97e72","user":{"login":"Babylonpartners","id":6124714,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMjQ3MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6124714?v=4","gravatar_id":"","url":"https://api.github.com/users/Babylonpartners","html_url":"https://github.com/Babylonpartners","followers_url":"https://api.github.com/users/Babylonpartners/followers","following_url":"https://api.github.com/users/Babylonpartners/following{/other_user}","gists_url":"https://api.github.com/users/Babylonpartners/gists{/gist_id}","starred_url":"https://api.github.com/users/Babylonpartners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Babylonpartners/subscriptions","organizations_url":"https://api.github.com/users/Babylonpartners/orgs","repos_url":"https://api.github.com/users/Babylonpartners/repos","events_url":"https://api.github.com/users/Babylonpartners/events{/privacy}","received_events_url":"https://api.github.com/users/Babylonpartners/received_events","type":"Organization","site_admin":false},"repo":{"id":153272170,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMyNzIxNzA=","name":"ios-playbook","full_name":"Babylonpartners/ios-playbook","private":false,"owner":{"login":"Babylonpartners","id":6124714,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMjQ3MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6124714?v=4","gravatar_id":"","url":"https://api.github.com/users/Babylonpartners","html_url":"https://github.com/Babylonpartners","followers_url":"https://api.github.com/users/Babylonpartners/followers","following_url":"https://api.github.com/users/Babylonpartners/following{/other_user}","gists_url":"https://api.github.com/users/Babylonpartners/gists{/gist_id}","starred_url":"https://api.github.com/users/Babylonpartners/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Babylonpartners/subscriptions","organizations_url":"https://api.github.com/users/Babylonpartners/orgs","repos_url":"https://api.github.com/users/Babylonpartners/repos","events_url":"https://api.github.com/users/Babylonpartners/events{/privacy}","received_events_url":"https://api.github.com/users/Babylonpartners/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Babylonpartners/ios-playbook","description":null,"fork":false,"url":"https://api.github.com/repos/Babylonpartners/ios-playbook","forks_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/forks","keys_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/teams","hooks_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/hooks","issue_events_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/issues/events{/number}","events_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/events","assignees_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/assignees{/user}","branches_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/branches{/branch}","tags_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/tags","blobs_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/git/refs{/sha}","trees_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/statuses/{sha}","languages_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/languages","stargazers_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/stargazers","contributors_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/contributors","subscribers_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/subscribers","subscription_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/subscription","commits_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/commits{/sha}","git_commits_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/git/commits{/sha}","comments_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/comments{/number}","issue_comment_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/issues/comments{/number}","contents_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/contents/{+path}","compare_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/merges","archive_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/downloads","issues_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/issues{/number}","pulls_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/pulls{/number}","milestones_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/milestones{/number}","notifications_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/labels{/name}","releases_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/releases{/id}","deployments_url":"https://api.github.com/repos/Babylonpartners/ios-playbook/deployments","created_at":"2018-10-16T11:10:34Z","updated_at":"2018-11-07T15:51:57Z","pushed_at":"2018-11-08T17:49:35Z","git_url":"git://github.com/Babylonpartners/ios-playbook.git","ssh_url":"git@github.com:Babylonpartners/ios-playbook.git","clone_url":"https://github.com/Babylonpartners/ios-playbook.git","svn_url":"https://github.com/Babylonpartners/ios-playbook","homepage":null,"size":451,"stargazers_count":36,"watchers_count":36,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Babylonpartners/ios-playbook/pulls/9"},"html":{"href":"https://github.com/Babylonpartners/ios-playbook/pull/9"},"issue":{"href":"https://api.github.com/repos/Babylonpartners/ios-playbook/issues/9"},"comments":{"href":"https://api.github.com/repos/Babylonpartners/ios-playbook/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/Babylonpartners/ios-playbook/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/Babylonpartners/ios-playbook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Babylonpartners/ios-playbook/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/Babylonpartners/ios-playbook/statuses/4f13330adc9765bfe11c73d8d926b586b5eb7fa5"}},"author_association":"NONE"}}
{"actor":{"display_login":"wltrup"}}