{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kops/issues/3625","repository_url":"https://api.github.com/repos/kubernetes/kops","labels_url":"https://api.github.com/repos/kubernetes/kops/issues/3625/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/3625/comments","events_url":"https://api.github.com/repos/kubernetes/kops/issues/3625/events","html_url":"https://github.com/kubernetes/kops/pull/3625","id":265349225,"number":3625,"title":"Shared security group implementation for masters and nodes","user":{"login":"chrislovecnm","id":335402,"avatar_url":"https://avatars2.githubusercontent.com/u/335402?v=4","gravatar_id":"","url":"https://api.github.com/users/chrislovecnm","html_url":"https://github.com/chrislovecnm","followers_url":"https://api.github.com/users/chrislovecnm/followers","following_url":"https://api.github.com/users/chrislovecnm/following{/other_user}","gists_url":"https://api.github.com/users/chrislovecnm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislovecnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislovecnm/subscriptions","organizations_url":"https://api.github.com/users/chrislovecnm/orgs","repos_url":"https://api.github.com/users/chrislovecnm/repos","events_url":"https://api.github.com/users/chrislovecnm/events{/privacy}","received_events_url":"https://api.github.com/users/chrislovecnm/received_events","type":"User","site_admin":false},"labels":[{"id":655705079,"url":"https://api.github.com/repos/kubernetes/kops/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":485059302,"url":"https://api.github.com/repos/kubernetes/kops/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":732202571,"url":"https://api.github.com/repos/kubernetes/kops/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":676563299,"url":"https://api.github.com/repos/kubernetes/kops/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"rdrgmnzs","id":410764,"avatar_url":"https://avatars1.githubusercontent.com/u/410764?v=4","gravatar_id":"","url":"https://api.github.com/users/rdrgmnzs","html_url":"https://github.com/rdrgmnzs","followers_url":"https://api.github.com/users/rdrgmnzs/followers","following_url":"https://api.github.com/users/rdrgmnzs/following{/other_user}","gists_url":"https://api.github.com/users/rdrgmnzs/gists{/gist_id}","starred_url":"https://api.github.com/users/rdrgmnzs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdrgmnzs/subscriptions","organizations_url":"https://api.github.com/users/rdrgmnzs/orgs","repos_url":"https://api.github.com/users/rdrgmnzs/repos","events_url":"https://api.github.com/users/rdrgmnzs/events{/privacy}","received_events_url":"https://api.github.com/users/rdrgmnzs/received_events","type":"User","site_admin":false},"assignees":[{"login":"rdrgmnzs","id":410764,"avatar_url":"https://avatars1.githubusercontent.com/u/410764?v=4","gravatar_id":"","url":"https://api.github.com/users/rdrgmnzs","html_url":"https://github.com/rdrgmnzs","followers_url":"https://api.github.com/users/rdrgmnzs/followers","following_url":"https://api.github.com/users/rdrgmnzs/following{/other_user}","gists_url":"https://api.github.com/users/rdrgmnzs/gists{/gist_id}","starred_url":"https://api.github.com/users/rdrgmnzs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdrgmnzs/subscriptions","organizations_url":"https://api.github.com/users/rdrgmnzs/orgs","repos_url":"https://api.github.com/users/rdrgmnzs/repos","events_url":"https://api.github.com/users/rdrgmnzs/events{/privacy}","received_events_url":"https://api.github.com/users/rdrgmnzs/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kops/milestones/15","html_url":"https://github.com/kubernetes/kops/milestone/15","labels_url":"https://api.github.com/repos/kubernetes/kops/milestones/15/labels","id":2784439,"number":15,"title":"1.8.1","description":null,"creator":{"login":"justinsb","id":100893,"avatar_url":"https://avatars2.githubusercontent.com/u/100893?v=4","gravatar_id":"","url":"https://api.github.com/users/justinsb","html_url":"https://github.com/justinsb","followers_url":"https://api.github.com/users/justinsb/followers","following_url":"https://api.github.com/users/justinsb/following{/other_user}","gists_url":"https://api.github.com/users/justinsb/gists{/gist_id}","starred_url":"https://api.github.com/users/justinsb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinsb/subscriptions","organizations_url":"https://api.github.com/users/justinsb/orgs","repos_url":"https://api.github.com/users/justinsb/repos","events_url":"https://api.github.com/users/justinsb/events{/privacy}","received_events_url":"https://api.github.com/users/justinsb/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":6,"state":"open","created_at":"2017-09-22T04:04:31Z","updated_at":"2017-12-30T20:43:24Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2017-10-13T16:37:10Z","updated_at":"2018-02-20T03:31:26Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/3625","html_url":"https://github.com/kubernetes/kops/pull/3625","diff_url":"https://github.com/kubernetes/kops/pull/3625.diff","patch_url":"https://github.com/kubernetes/kops/pull/3625.patch"},"body":"This PR starts the implementation of using a security group tied to an instance group. It gives us the capability to set an existing security group as the primary group for an ig, and then we also have the additional security groups.  A security team would be able to use the TF from kops to create the groups, or run kops to create the groups.\r\n\r\nThe PR does depend on the other phase work that I am doing to allow for full functionality.\r\n\r\n@justinsb PTLA - the suffixes for naming the individual sg rule tasks started getting really messy.  If you can recommend a cleaner pattern, I am all ears."},"comment":{"url":"https://api.github.com/repos/kubernetes/kops/issues/comments/366857617","html_url":"https://github.com/kubernetes/kops/pull/3625#issuecomment-366857617","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/3625","id":366857617,"user":{"login":"chrislovecnm","id":335402,"avatar_url":"https://avatars2.githubusercontent.com/u/335402?v=4","gravatar_id":"","url":"https://api.github.com/users/chrislovecnm","html_url":"https://github.com/chrislovecnm","followers_url":"https://api.github.com/users/chrislovecnm/followers","following_url":"https://api.github.com/users/chrislovecnm/following{/other_user}","gists_url":"https://api.github.com/users/chrislovecnm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislovecnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislovecnm/subscriptions","organizations_url":"https://api.github.com/users/chrislovecnm/orgs","repos_url":"https://api.github.com/users/chrislovecnm/repos","events_url":"https://api.github.com/users/chrislovecnm/events{/privacy}","received_events_url":"https://api.github.com/users/chrislovecnm/received_events","type":"User","site_admin":false},"created_at":"2018-02-20T03:31:26Z","updated_at":"2018-02-20T03:31:26Z","author_association":"MEMBER","body":"@rdrgmnzs rebased I have a hold on the PR, so feel free to add a `/lgtm` after we get any kinks out.\r\n\r\nWill let you review and then will assign to @justinsb "}}
{"actor":{"display_login":"chrislovecnm"}}