{"action":"created","issue":{"url":"https://api.github.com/repos/symfony/symfony/issues/29258","repository_url":"https://api.github.com/repos/symfony/symfony","labels_url":"https://api.github.com/repos/symfony/symfony/issues/29258/labels{/name}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/29258/comments","events_url":"https://api.github.com/repos/symfony/symfony/issues/29258/events","html_url":"https://github.com/symfony/symfony/pull/29258","id":382016613,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODI0OTY3","number":29258,"title":"[DoctrineBridge] Custom entity repositories in EntityUserProvider","user":{"login":"lrlopez","id":547387,"node_id":"MDQ6VXNlcjU0NzM4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/547387?v=4","gravatar_id":"","url":"https://api.github.com/users/lrlopez","html_url":"https://github.com/lrlopez","followers_url":"https://api.github.com/users/lrlopez/followers","following_url":"https://api.github.com/users/lrlopez/following{/other_user}","gists_url":"https://api.github.com/users/lrlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/lrlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrlopez/subscriptions","organizations_url":"https://api.github.com/users/lrlopez/orgs","repos_url":"https://api.github.com/users/lrlopez/repos","events_url":"https://api.github.com/users/lrlopez/events{/privacy}","received_events_url":"https://api.github.com/users/lrlopez/received_events","type":"User","site_admin":false},"labels":[{"id":100079,"node_id":"MDU6TGFiZWwxMDAwNzk=","url":"https://api.github.com/repos/symfony/symfony/labels/Bug","name":"Bug","color":"e10c02","default":false},{"id":337187703,"node_id":"MDU6TGFiZWwzMzcxODc3MDM=","url":"https://api.github.com/repos/symfony/symfony/labels/DoctrineBridge","name":"DoctrineBridge","color":"dddddd","default":false},{"id":100378,"node_id":"MDU6TGFiZWwxMDAzNzg=","url":"https://api.github.com/repos/symfony/symfony/labels/Feature","name":"Feature","color":"02e10c","default":false},{"id":237003792,"node_id":"MDU6TGFiZWwyMzcwMDM3OTI=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-19T00:06:23Z","updated_at":"2018-11-19T15:11:14Z","closed_at":"2018-11-19T15:11:14Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/29258","html_url":"https://github.com/symfony/symfony/pull/29258","diff_url":"https://github.com/symfony/symfony/pull/29258.diff","patch_url":"https://github.com/symfony/symfony/pull/29258.patch"},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | 3.4\r\n| Bug fix?      | yes\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Tests pass?   | yes\r\n| Fixed tickets | #29257\r\n| License       | MIT\r\n| Doc PR        | pending \r\n\r\nThis PR adds a new config option to the entity user provider in `security.yml` called `repository` that can be used to point to a custom entity repository class. This avoids calling Doctrine repository locator, which will return the wrong instance if the entity repository gets converted to a service.\r\n\r\nIf none is specified, Doctrine locator will be called, so BC is guaranteed.\r\n\r\nWithout this change, using entity repositories as services won't work with `EntityUserProvider`, which may be considered a bug.\r\n\r\nExample:\r\n```yaml\r\n    # config/packages/security.yml\r\n    # ...\r\n\r\n    providers:\r\n        our_db_provider:\r\n            entity:\r\n                class: App\\Entity\\User\r\n                repository: App\\Repository\\UserRepository\r\n    # ...\r\n```"},"comment":{"url":"https://api.github.com/repos/symfony/symfony/issues/comments/439925686","html_url":"https://github.com/symfony/symfony/pull/29258#issuecomment-439925686","issue_url":"https://api.github.com/repos/symfony/symfony/issues/29258","id":439925686,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTkyNTY4Ng==","user":{"login":"lrlopez","id":547387,"node_id":"MDQ6VXNlcjU0NzM4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/547387?v=4","gravatar_id":"","url":"https://api.github.com/users/lrlopez","html_url":"https://github.com/lrlopez","followers_url":"https://api.github.com/users/lrlopez/followers","following_url":"https://api.github.com/users/lrlopez/following{/other_user}","gists_url":"https://api.github.com/users/lrlopez/gists{/gist_id}","starred_url":"https://api.github.com/users/lrlopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrlopez/subscriptions","organizations_url":"https://api.github.com/users/lrlopez/orgs","repos_url":"https://api.github.com/users/lrlopez/repos","events_url":"https://api.github.com/users/lrlopez/events{/privacy}","received_events_url":"https://api.github.com/users/lrlopez/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T15:11:14Z","updated_at":"2018-11-19T15:11:14Z","author_association":"CONTRIBUTOR","body":"As discussed in the related issue, there is no need for this PR if you use `ServiceEntityRepository` so I'm closing the PR. Thanks for the review, I really appreciate it. "}}
{"actor":{"display_login":"lrlopez"}}