{"action":"created","issue":{"url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2718","repository_url":"https://api.github.com/repos/openmrs/openmrs-core","labels_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2718/labels{/name}","comments_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2718/comments","events_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2718/events","html_url":"https://github.com/openmrs/openmrs-core/pull/2718","id":373135744,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MTM4ODQw","number":2718,"title":"GCI-246: Replaced the Long constructor with valueOf","user":{"login":"shakeelsamsu","id":16440459,"node_id":"MDQ6VXNlcjE2NDQwNDU5","avatar_url":"https://avatars3.githubusercontent.com/u/16440459?v=4","gravatar_id":"","url":"https://api.github.com/users/shakeelsamsu","html_url":"https://github.com/shakeelsamsu","followers_url":"https://api.github.com/users/shakeelsamsu/followers","following_url":"https://api.github.com/users/shakeelsamsu/following{/other_user}","gists_url":"https://api.github.com/users/shakeelsamsu/gists{/gist_id}","starred_url":"https://api.github.com/users/shakeelsamsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shakeelsamsu/subscriptions","organizations_url":"https://api.github.com/users/shakeelsamsu/orgs","repos_url":"https://api.github.com/users/shakeelsamsu/repos","events_url":"https://api.github.com/users/shakeelsamsu/events{/privacy}","received_events_url":"https://api.github.com/users/shakeelsamsu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-23T18:20:07Z","updated_at":"2018-10-23T23:15:51Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-core/pulls/2718","html_url":"https://github.com/openmrs/openmrs-core/pull/2718","diff_url":"https://github.com/openmrs/openmrs-core/pull/2718.diff","patch_url":"https://github.com/openmrs/openmrs-core/pull/2718.patch"},"body":"<!--- Add a pull request title above in this format -->\r\n<!--- real example: 'TRUNK-5111 Replace use of deprecated isVoided' -->\r\n<!--- 'TRUNK-JiraIssueNumber JiraIssueTitle' -->\r\n## Description of what I changed\r\n<!--- Describe your changes in detail -->\r\n<!--- It can simply be your commit message, which you must have -->\r\nUse Long.valueOf(long) instead of the inefficient new Long(long) constructor\r\n\r\n## Issue I worked on\r\n<!--- This project only accepts pull requests related to open issues -->\r\n<!--- Want a new feature or change? Discuss it in an issue first -->\r\n<!--- Found a bug? Point us to the issue/or create one so we can reproduce it -->\r\n<!--- Just add the issue number at the end: -->\r\nsee https://issues.openmrs.org/browse/GCI-246\r\n\r\n## Checklist: I completed these to help reviewers :)\r\n<!--- Put an `x` in the box if you did the task -->\r\n<!--- If you forgot a task please follow the instructions below -->\r\n- [x] My pull request only contains **ONE single commit**\r\n(the number above, next to the 'Commits' tab is 1).\r\n\r\n  No? -> [read here](https://wiki.openmrs.org/display/docs/Pull+Request+Tips) on how to squash multiple commits into one\r\n\r\n- [x] My IDE is configured to follow the [**code style**](https://wiki.openmrs.org/display/docs/Java+Conventions) of this project.\r\n\r\n  No? Unsure? -> [configure your IDE](https://wiki.openmrs.org/display/docs/How-To+Setup+And+Use+Your+IDE), format the code and add the changes with `git add . && git commit --amend`\r\n\r\n- [x] I have **added tests** to cover my changes. (If you refactored\r\n  existing code that was well tested you do not have to add tests)\r\n\r\n  No? -> write tests and add them to this commit `git add . && git commit --amend`\r\n\r\n- [x] I ran `mvn clean package` right before creating this pull request and\r\n  added all formatting changes to my commit.\r\n\r\n  No? -> execute above command\r\n\r\n- [x] All new and existing **tests passed**.\r\n\r\n  No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.\r\n\r\n- [x] My pull request is **based on the latest changes** of the master branch.\r\n\r\n  No? Unsure? -> execute command `git pull --rebase upstream master`\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/openmrs/openmrs-core/issues/comments/432454994","html_url":"https://github.com/openmrs/openmrs-core/pull/2718#issuecomment-432454994","issue_url":"https://api.github.com/repos/openmrs/openmrs-core/issues/2718","id":432454994,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjQ1NDk5NA==","user":{"login":"ykarim","id":6414721,"node_id":"MDQ6VXNlcjY0MTQ3MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/6414721?v=4","gravatar_id":"","url":"https://api.github.com/users/ykarim","html_url":"https://github.com/ykarim","followers_url":"https://api.github.com/users/ykarim/followers","following_url":"https://api.github.com/users/ykarim/following{/other_user}","gists_url":"https://api.github.com/users/ykarim/gists{/gist_id}","starred_url":"https://api.github.com/users/ykarim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ykarim/subscriptions","organizations_url":"https://api.github.com/users/ykarim/orgs","repos_url":"https://api.github.com/users/ykarim/repos","events_url":"https://api.github.com/users/ykarim/events{/privacy}","received_events_url":"https://api.github.com/users/ykarim/received_events","type":"User","site_admin":false},"created_at":"2018-10-23T23:15:51Z","updated_at":"2018-10-23T23:15:51Z","author_association":"CONTRIBUTOR","body":"Code looks all good but please follow the [OpenMRS Pull Request Tips](https://wiki.openmrs.org/display/docs/Pull+Request+Tips) (take a look at the branch name == ticket name part). The pull request branch should be GCI-246 against the master branch."}}
{"actor":{"display_login":"ykarim"}}