{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaDocs/Documenter.jl/issues/885","repository_url":"https://api.github.com/repos/JuliaDocs/Documenter.jl","labels_url":"https://api.github.com/repos/JuliaDocs/Documenter.jl/issues/885/labels{/name}","comments_url":"https://api.github.com/repos/JuliaDocs/Documenter.jl/issues/885/comments","events_url":"https://api.github.com/repos/JuliaDocs/Documenter.jl/issues/885/events","html_url":"https://github.com/JuliaDocs/Documenter.jl/pull/885","id":378674252,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MzIwNjUz","number":885,"title":"added filter function to @autodocs","user":{"login":"timkittel","id":19408882,"node_id":"MDQ6VXNlcjE5NDA4ODgy","avatar_url":"https://avatars3.githubusercontent.com/u/19408882?v=4","gravatar_id":"","url":"https://api.github.com/users/timkittel","html_url":"https://github.com/timkittel","followers_url":"https://api.github.com/users/timkittel/followers","following_url":"https://api.github.com/users/timkittel/following{/other_user}","gists_url":"https://api.github.com/users/timkittel/gists{/gist_id}","starred_url":"https://api.github.com/users/timkittel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timkittel/subscriptions","organizations_url":"https://api.github.com/users/timkittel/orgs","repos_url":"https://api.github.com/users/timkittel/repos","events_url":"https://api.github.com/users/timkittel/events{/privacy}","received_events_url":"https://api.github.com/users/timkittel/received_events","type":"User","site_admin":false},"labels":[{"id":382774606,"node_id":"MDU6TGFiZWwzODI3NzQ2MDY=","url":"https://api.github.com/repos/JuliaDocs/Documenter.jl/labels/Type:%20Feature","name":"Type: Feature","color":"810f7c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/JuliaDocs/Documenter.jl/milestones/54","html_url":"https://github.com/JuliaDocs/Documenter.jl/milestone/54","labels_url":"https://api.github.com/repos/JuliaDocs/Documenter.jl/milestones/54/labels","id":3789090,"node_id":"MDk6TWlsZXN0b25lMzc4OTA5MA==","number":54,"title":"0.21.0","description":null,"creator":{"login":"mortenpi","id":147757,"node_id":"MDQ6VXNlcjE0Nzc1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/147757?v=4","gravatar_id":"","url":"https://api.github.com/users/mortenpi","html_url":"https://github.com/mortenpi","followers_url":"https://api.github.com/users/mortenpi/followers","following_url":"https://api.github.com/users/mortenpi/following{/other_user}","gists_url":"https://api.github.com/users/mortenpi/gists{/gist_id}","starred_url":"https://api.github.com/users/mortenpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortenpi/subscriptions","organizations_url":"https://api.github.com/users/mortenpi/orgs","repos_url":"https://api.github.com/users/mortenpi/repos","events_url":"https://api.github.com/users/mortenpi/events{/privacy}","received_events_url":"https://api.github.com/users/mortenpi/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":4,"state":"open","created_at":"2018-11-01T20:38:07Z","updated_at":"2018-11-10T06:42:41Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-11-08T10:43:21Z","updated_at":"2018-11-10T06:49:00Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/JuliaDocs/Documenter.jl/pulls/885","html_url":"https://github.com/JuliaDocs/Documenter.jl/pull/885","diff_url":"https://github.com/JuliaDocs/Documenter.jl/pull/885.diff","patch_url":"https://github.com/JuliaDocs/Documenter.jl/pull/885.patch"},"body":"Hi, I have a simple implementation of adding a filter function to `@autodocs` via a `Filter` keyword (as shortly discussed in [slack here and the corresponding thread](https://julialang.slack.com/archives/C66L48G1X/p1541515077072700)). See [here](https://github.com/timkittel/Documenter-test/blob/master/docs/src/index.md) for an example `index.md` where the filtering function is created [here](https://github.com/timkittel/Documenter-test/blob/master/docs/make.jl#L20-L22). Do you generally agree with that idea?\r\n\r\nIt seems to work if I try it with this example setup https://github.com/timkittel/Documenter-test but I don't really know how I would add the tests here. Could you give me some pointers?\r\n\r\nOf course, I would add a sction to the documentation if there is positive feedback here (:\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/JuliaDocs/Documenter.jl/issues/comments/437563141","html_url":"https://github.com/JuliaDocs/Documenter.jl/pull/885#issuecomment-437563141","issue_url":"https://api.github.com/repos/JuliaDocs/Documenter.jl/issues/885","id":437563141,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzU2MzE0MQ==","user":{"login":"mortenpi","id":147757,"node_id":"MDQ6VXNlcjE0Nzc1Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/147757?v=4","gravatar_id":"","url":"https://api.github.com/users/mortenpi","html_url":"https://github.com/mortenpi","followers_url":"https://api.github.com/users/mortenpi/followers","following_url":"https://api.github.com/users/mortenpi/following{/other_user}","gists_url":"https://api.github.com/users/mortenpi/gists{/gist_id}","starred_url":"https://api.github.com/users/mortenpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mortenpi/subscriptions","organizations_url":"https://api.github.com/users/mortenpi/orgs","repos_url":"https://api.github.com/users/mortenpi/repos","events_url":"https://api.github.com/users/mortenpi/events{/privacy}","received_events_url":"https://api.github.com/users/mortenpi/received_events","type":"User","site_admin":false},"created_at":"2018-11-10T06:49:00Z","updated_at":"2018-11-10T06:49:00Z","author_association":"MEMBER","body":"Awesome, thanks! I don't think this really needs to be more complicated than this, so the implementation looks good.\r\n\r\nJust needs docs as you mentioned. I am not entirely sure what are the types of the objects that will get passed to the filter function though -- it would be good to document that. For functions you probably get these `Binding` objects I assume.\r\n\r\nDoes it also work if you create a lambda function directly in the at-autodocs block?\r\n\r\nFor tests, I think we should add something to `test/examples/`."}}
{"actor":{"display_login":"mortenpi"}}