{"action":"created","issue":{"url":"https://api.github.com/repos/mobiusklein/pynumpress/issues/2","repository_url":"https://api.github.com/repos/mobiusklein/pynumpress","labels_url":"https://api.github.com/repos/mobiusklein/pynumpress/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/mobiusklein/pynumpress/issues/2/comments","events_url":"https://api.github.com/repos/mobiusklein/pynumpress/issues/2/events","html_url":"https://github.com/mobiusklein/pynumpress/pull/2","id":360264064,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NTYyNDM5","number":2,"title":"Install numpy in setup.py, so the package can be installed without the need to have numpy installed before installation","user":{"login":"MKoesters","id":17874544,"node_id":"MDQ6VXNlcjE3ODc0NTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/17874544?v=4","gravatar_id":"","url":"https://api.github.com/users/MKoesters","html_url":"https://github.com/MKoesters","followers_url":"https://api.github.com/users/MKoesters/followers","following_url":"https://api.github.com/users/MKoesters/following{/other_user}","gists_url":"https://api.github.com/users/MKoesters/gists{/gist_id}","starred_url":"https://api.github.com/users/MKoesters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MKoesters/subscriptions","organizations_url":"https://api.github.com/users/MKoesters/orgs","repos_url":"https://api.github.com/users/MKoesters/repos","events_url":"https://api.github.com/users/MKoesters/events{/privacy}","received_events_url":"https://api.github.com/users/MKoesters/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-14T11:19:12Z","updated_at":"2018-09-14T13:06:58Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/mobiusklein/pynumpress/pulls/2","html_url":"https://github.com/mobiusklein/pynumpress/pull/2","diff_url":"https://github.com/mobiusklein/pynumpress/pull/2.diff","patch_url":"https://github.com/mobiusklein/pynumpress/pull/2.patch"},"body":"Installing pynumpress fail, when numpy is not installed on the system, even though its in requirements.\r\nThis is due to the fact that the requirements are built before setup.py, but not installed.\r\nSince cython requires numpy, we need to make sure numpy is installed when setup.py is executed.\r\nThis pull requests introduces a setup.py version, where numpy is installed before building the package"},"comment":{"url":"https://api.github.com/repos/mobiusklein/pynumpress/issues/comments/421352507","html_url":"https://github.com/mobiusklein/pynumpress/pull/2#issuecomment-421352507","issue_url":"https://api.github.com/repos/mobiusklein/pynumpress/issues/2","id":421352507,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTM1MjUwNw==","user":{"login":"mobiusklein","id":1426041,"node_id":"MDQ6VXNlcjE0MjYwNDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1426041?v=4","gravatar_id":"","url":"https://api.github.com/users/mobiusklein","html_url":"https://github.com/mobiusklein","followers_url":"https://api.github.com/users/mobiusklein/followers","following_url":"https://api.github.com/users/mobiusklein/following{/other_user}","gists_url":"https://api.github.com/users/mobiusklein/gists{/gist_id}","starred_url":"https://api.github.com/users/mobiusklein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobiusklein/subscriptions","organizations_url":"https://api.github.com/users/mobiusklein/orgs","repos_url":"https://api.github.com/users/mobiusklein/repos","events_url":"https://api.github.com/users/mobiusklein/events{/privacy}","received_events_url":"https://api.github.com/users/mobiusklein/received_events","type":"User","site_admin":false},"created_at":"2018-09-14T13:06:58Z","updated_at":"2018-09-14T13:06:58Z","author_association":"OWNER","body":"You should only need Cython if you're installing from source. When the package is built and uploaded to PyPI, it ships the `.cpp` and `.h` files needed to compile using just the platform's C++ compiler. Is that not the case?\r\n\r\nDoes the pip install command you're running in the setup script to install numpy install from the source distribution (tar.gz) or the platform-specific wheel? This isn't ideal either way but `setuptools` doesn't provide a way to express \"I need the installed headers for this package to already in place before this package installs\". "}}
{"actor":{"display_login":"mobiusklein"}}