{"action":"opened","number":763,"pull_request":{"url":"https://api.github.com/repos/plexinc/plex-media-player/pulls/763","id":199117603,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MTE3NjAz","html_url":"https://github.com/plexinc/plex-media-player/pull/763","diff_url":"https://github.com/plexinc/plex-media-player/pull/763.diff","patch_url":"https://github.com/plexinc/plex-media-player/pull/763.patch","issue_url":"https://api.github.com/repos/plexinc/plex-media-player/issues/763","number":763,"state":"open","locked":false,"title":"Improve systemname handling","user":{"login":"mseeley","id":30019,"node_id":"MDQ6VXNlcjMwMDE5","avatar_url":"https://avatars3.githubusercontent.com/u/30019?v=4","gravatar_id":"","url":"https://api.github.com/users/mseeley","html_url":"https://github.com/mseeley","followers_url":"https://api.github.com/users/mseeley/followers","following_url":"https://api.github.com/users/mseeley/following{/other_user}","gists_url":"https://api.github.com/users/mseeley/gists{/gist_id}","starred_url":"https://api.github.com/users/mseeley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseeley/subscriptions","organizations_url":"https://api.github.com/users/mseeley/orgs","repos_url":"https://api.github.com/users/mseeley/repos","events_url":"https://api.github.com/users/mseeley/events{/privacy}","received_events_url":"https://api.github.com/users/mseeley/received_events","type":"User","site_admin":false},"body":"### Context\r\n\r\nOur `systemname` setting was ignored on desktop systems. Reported [in the forums](https://forums.plex.tv/t/for-the-love-of-god-can-you-please-let-me-change-name-of-pmp/278708/).\r\n\r\n@sixones tagging you on this to make sure the C++ is sane.\r\n\r\n- Fixes #762 \r\n\r\n### Discussion\r\n\r\nPlease see the comments included in the code for context and solution.\r\n\r\nAlthough even after this change there's another bug, this time in PMS, which results in the Plex player drop down in Web displaying stale player names. Several PMS restarts seems to cause the correct name to be displayed.\r\n\r\n### Steps to test\r\n\r\nI've included debug logs to keep this testable. I haven't been able to test on embedded although realistically testing on desktop will cover both desktop and embedded environments.\r\n\r\nI've tested:\r\n\r\n* Shutdown PMP\r\n* Edit `plexmediaplayer.conf` to include `systemname: \"PlexMediaPlayer\"` -- the default value\r\n* Startup PMP and tail logs\r\n* You should see the host select the system's hostname as the resource title:\r\n```\r\n2018-07-03 15:02:42 [ DEBUG ] RemoteComponent.cpp @ 106 - Resolving system name: Host name: \"Matt_s MacBook Pro\" \r\n2018-07-03 15:02:42 [ DEBUG ] RemoteComponent.cpp @ 107 - Resolving system name: System name setting: \"PlexMediaPlayer\" \r\n2018-07-03 15:02:42 [ DEBUG ] RemoteComponent.cpp @ 108 - Resolving system name: Is system name setting empty value: 0 \r\n2018-07-03 15:02:42 [ DEBUG ] RemoteComponent.cpp @ 109 - Resolving system name: Is system name setting default value: 1 \r\n2018-07-03 15:02:42 [ DEBUG ] RemoteComponent.cpp @ 110 - Resolving system name: Final value: \"Matt_s MacBook Pro\" \r\n```\r\n\r\n* Shutdown PMP\r\n* Edit `plexmediaplayer.conf` to include `systemname: \"Something custom\"` -- anything but the default value\r\n* Startup PMP and tail logs\r\n* You should see the host select the `systemname` setting as the resource title:\r\n```\r\n2018-07-03 15:05:00 [ DEBUG ] RemoteComponent.cpp @ 108 - Resolving system name: Host name: \"Matt_s MacBook Pro\" \r\n2018-07-03 15:05:00 [ DEBUG ] RemoteComponent.cpp @ 109 - Resolving system name: System name setting: \"Office Display\" \r\n2018-07-03 15:05:00 [ DEBUG ] RemoteComponent.cpp @ 110 - Resolving system name: Is system name setting empty value: 0 \r\n2018-07-03 15:05:00 [ DEBUG ] RemoteComponent.cpp @ 111 - Resolving system name: Is system name setting default value: 0 \r\n2018-07-03 15:05:00 [ DEBUG ] RemoteComponent.cpp @ 112 - Resolving system name: Final value: \"Office Display\" \r\n```\r\n\r\n### Expected behavior\r\n<!-- What should happen?  -->\r\n1.\r\n\r\n","created_at":"2018-07-04T01:16:09Z","updated_at":"2018-07-04T01:16:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"mseeley","id":30019,"node_id":"MDQ6VXNlcjMwMDE5","avatar_url":"https://avatars3.githubusercontent.com/u/30019?v=4","gravatar_id":"","url":"https://api.github.com/users/mseeley","html_url":"https://github.com/mseeley","followers_url":"https://api.github.com/users/mseeley/followers","following_url":"https://api.github.com/users/mseeley/following{/other_user}","gists_url":"https://api.github.com/users/mseeley/gists{/gist_id}","starred_url":"https://api.github.com/users/mseeley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseeley/subscriptions","organizations_url":"https://api.github.com/users/mseeley/orgs","repos_url":"https://api.github.com/users/mseeley/repos","events_url":"https://api.github.com/users/mseeley/events{/privacy}","received_events_url":"https://api.github.com/users/mseeley/received_events","type":"User","site_admin":false},"assignees":[{"login":"mseeley","id":30019,"node_id":"MDQ6VXNlcjMwMDE5","avatar_url":"https://avatars3.githubusercontent.com/u/30019?v=4","gravatar_id":"","url":"https://api.github.com/users/mseeley","html_url":"https://github.com/mseeley","followers_url":"https://api.github.com/users/mseeley/followers","following_url":"https://api.github.com/users/mseeley/following{/other_user}","gists_url":"https://api.github.com/users/mseeley/gists{/gist_id}","starred_url":"https://api.github.com/users/mseeley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseeley/subscriptions","organizations_url":"https://api.github.com/users/mseeley/orgs","repos_url":"https://api.github.com/users/mseeley/repos","events_url":"https://api.github.com/users/mseeley/events{/privacy}","received_events_url":"https://api.github.com/users/mseeley/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/plexinc/plex-media-player/pulls/763/commits","review_comments_url":"https://api.github.com/repos/plexinc/plex-media-player/pulls/763/comments","review_comment_url":"https://api.github.com/repos/plexinc/plex-media-player/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plexinc/plex-media-player/issues/763/comments","statuses_url":"https://api.github.com/repos/plexinc/plex-media-player/statuses/142a89699b8e7d41359ebf6b926aee120dd0790c","head":{"label":"plexinc:mseeley/systemname","ref":"mseeley/systemname","sha":"142a89699b8e7d41359ebf6b926aee120dd0790c","user":{"login":"plexinc","id":324832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/324832?v=4","gravatar_id":"","url":"https://api.github.com/users/plexinc","html_url":"https://github.com/plexinc","followers_url":"https://api.github.com/users/plexinc/followers","following_url":"https://api.github.com/users/plexinc/following{/other_user}","gists_url":"https://api.github.com/users/plexinc/gists{/gist_id}","starred_url":"https://api.github.com/users/plexinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plexinc/subscriptions","organizations_url":"https://api.github.com/users/plexinc/orgs","repos_url":"https://api.github.com/users/plexinc/repos","events_url":"https://api.github.com/users/plexinc/events{/privacy}","received_events_url":"https://api.github.com/users/plexinc/received_events","type":"Organization","site_admin":false},"repo":{"id":44163097,"node_id":"MDEwOlJlcG9zaXRvcnk0NDE2MzA5Nw==","name":"plex-media-player","full_name":"plexinc/plex-media-player","owner":{"login":"plexinc","id":324832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/324832?v=4","gravatar_id":"","url":"https://api.github.com/users/plexinc","html_url":"https://github.com/plexinc","followers_url":"https://api.github.com/users/plexinc/followers","following_url":"https://api.github.com/users/plexinc/following{/other_user}","gists_url":"https://api.github.com/users/plexinc/gists{/gist_id}","starred_url":"https://api.github.com/users/plexinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plexinc/subscriptions","organizations_url":"https://api.github.com/users/plexinc/orgs","repos_url":"https://api.github.com/users/plexinc/repos","events_url":"https://api.github.com/users/plexinc/events{/privacy}","received_events_url":"https://api.github.com/users/plexinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plexinc/plex-media-player","description":"Next generation Plex Desktop/Embedded Client","fork":false,"url":"https://api.github.com/repos/plexinc/plex-media-player","forks_url":"https://api.github.com/repos/plexinc/plex-media-player/forks","keys_url":"https://api.github.com/repos/plexinc/plex-media-player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plexinc/plex-media-player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plexinc/plex-media-player/teams","hooks_url":"https://api.github.com/repos/plexinc/plex-media-player/hooks","issue_events_url":"https://api.github.com/repos/plexinc/plex-media-player/issues/events{/number}","events_url":"https://api.github.com/repos/plexinc/plex-media-player/events","assignees_url":"https://api.github.com/repos/plexinc/plex-media-player/assignees{/user}","branches_url":"https://api.github.com/repos/plexinc/plex-media-player/branches{/branch}","tags_url":"https://api.github.com/repos/plexinc/plex-media-player/tags","blobs_url":"https://api.github.com/repos/plexinc/plex-media-player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plexinc/plex-media-player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plexinc/plex-media-player/git/refs{/sha}","trees_url":"https://api.github.com/repos/plexinc/plex-media-player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plexinc/plex-media-player/statuses/{sha}","languages_url":"https://api.github.com/repos/plexinc/plex-media-player/languages","stargazers_url":"https://api.github.com/repos/plexinc/plex-media-player/stargazers","contributors_url":"https://api.github.com/repos/plexinc/plex-media-player/contributors","subscribers_url":"https://api.github.com/repos/plexinc/plex-media-player/subscribers","subscription_url":"https://api.github.com/repos/plexinc/plex-media-player/subscription","commits_url":"https://api.github.com/repos/plexinc/plex-media-player/commits{/sha}","git_commits_url":"https://api.github.com/repos/plexinc/plex-media-player/git/commits{/sha}","comments_url":"https://api.github.com/repos/plexinc/plex-media-player/comments{/number}","issue_comment_url":"https://api.github.com/repos/plexinc/plex-media-player/issues/comments{/number}","contents_url":"https://api.github.com/repos/plexinc/plex-media-player/contents/{+path}","compare_url":"https://api.github.com/repos/plexinc/plex-media-player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plexinc/plex-media-player/merges","archive_url":"https://api.github.com/repos/plexinc/plex-media-player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plexinc/plex-media-player/downloads","issues_url":"https://api.github.com/repos/plexinc/plex-media-player/issues{/number}","pulls_url":"https://api.github.com/repos/plexinc/plex-media-player/pulls{/number}","milestones_url":"https://api.github.com/repos/plexinc/plex-media-player/milestones{/number}","notifications_url":"https://api.github.com/repos/plexinc/plex-media-player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plexinc/plex-media-player/labels{/name}","releases_url":"https://api.github.com/repos/plexinc/plex-media-player/releases{/id}","deployments_url":"https://api.github.com/repos/plexinc/plex-media-player/deployments","created_at":"2015-10-13T08:36:34Z","updated_at":"2018-07-03T21:01:58Z","pushed_at":"2018-07-04T01:06:59Z","git_url":"git://github.com/plexinc/plex-media-player.git","ssh_url":"git@github.com:plexinc/plex-media-player.git","clone_url":"https://github.com/plexinc/plex-media-player.git","svn_url":"https://github.com/plexinc/plex-media-player","homepage":null,"size":3394,"stargazers_count":577,"watchers_count":577,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":86,"open_issues":92,"watchers":577,"default_branch":"master"}},"base":{"label":"plexinc:master","ref":"master","sha":"45ccf442bbb008035ad6069832d8f3174d25afcd","user":{"login":"plexinc","id":324832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/324832?v=4","gravatar_id":"","url":"https://api.github.com/users/plexinc","html_url":"https://github.com/plexinc","followers_url":"https://api.github.com/users/plexinc/followers","following_url":"https://api.github.com/users/plexinc/following{/other_user}","gists_url":"https://api.github.com/users/plexinc/gists{/gist_id}","starred_url":"https://api.github.com/users/plexinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plexinc/subscriptions","organizations_url":"https://api.github.com/users/plexinc/orgs","repos_url":"https://api.github.com/users/plexinc/repos","events_url":"https://api.github.com/users/plexinc/events{/privacy}","received_events_url":"https://api.github.com/users/plexinc/received_events","type":"Organization","site_admin":false},"repo":{"id":44163097,"node_id":"MDEwOlJlcG9zaXRvcnk0NDE2MzA5Nw==","name":"plex-media-player","full_name":"plexinc/plex-media-player","owner":{"login":"plexinc","id":324832,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNDgzMg==","avatar_url":"https://avatars1.githubusercontent.com/u/324832?v=4","gravatar_id":"","url":"https://api.github.com/users/plexinc","html_url":"https://github.com/plexinc","followers_url":"https://api.github.com/users/plexinc/followers","following_url":"https://api.github.com/users/plexinc/following{/other_user}","gists_url":"https://api.github.com/users/plexinc/gists{/gist_id}","starred_url":"https://api.github.com/users/plexinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plexinc/subscriptions","organizations_url":"https://api.github.com/users/plexinc/orgs","repos_url":"https://api.github.com/users/plexinc/repos","events_url":"https://api.github.com/users/plexinc/events{/privacy}","received_events_url":"https://api.github.com/users/plexinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plexinc/plex-media-player","description":"Next generation Plex Desktop/Embedded Client","fork":false,"url":"https://api.github.com/repos/plexinc/plex-media-player","forks_url":"https://api.github.com/repos/plexinc/plex-media-player/forks","keys_url":"https://api.github.com/repos/plexinc/plex-media-player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plexinc/plex-media-player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plexinc/plex-media-player/teams","hooks_url":"https://api.github.com/repos/plexinc/plex-media-player/hooks","issue_events_url":"https://api.github.com/repos/plexinc/plex-media-player/issues/events{/number}","events_url":"https://api.github.com/repos/plexinc/plex-media-player/events","assignees_url":"https://api.github.com/repos/plexinc/plex-media-player/assignees{/user}","branches_url":"https://api.github.com/repos/plexinc/plex-media-player/branches{/branch}","tags_url":"https://api.github.com/repos/plexinc/plex-media-player/tags","blobs_url":"https://api.github.com/repos/plexinc/plex-media-player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plexinc/plex-media-player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plexinc/plex-media-player/git/refs{/sha}","trees_url":"https://api.github.com/repos/plexinc/plex-media-player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plexinc/plex-media-player/statuses/{sha}","languages_url":"https://api.github.com/repos/plexinc/plex-media-player/languages","stargazers_url":"https://api.github.com/repos/plexinc/plex-media-player/stargazers","contributors_url":"https://api.github.com/repos/plexinc/plex-media-player/contributors","subscribers_url":"https://api.github.com/repos/plexinc/plex-media-player/subscribers","subscription_url":"https://api.github.com/repos/plexinc/plex-media-player/subscription","commits_url":"https://api.github.com/repos/plexinc/plex-media-player/commits{/sha}","git_commits_url":"https://api.github.com/repos/plexinc/plex-media-player/git/commits{/sha}","comments_url":"https://api.github.com/repos/plexinc/plex-media-player/comments{/number}","issue_comment_url":"https://api.github.com/repos/plexinc/plex-media-player/issues/comments{/number}","contents_url":"https://api.github.com/repos/plexinc/plex-media-player/contents/{+path}","compare_url":"https://api.github.com/repos/plexinc/plex-media-player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plexinc/plex-media-player/merges","archive_url":"https://api.github.com/repos/plexinc/plex-media-player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plexinc/plex-media-player/downloads","issues_url":"https://api.github.com/repos/plexinc/plex-media-player/issues{/number}","pulls_url":"https://api.github.com/repos/plexinc/plex-media-player/pulls{/number}","milestones_url":"https://api.github.com/repos/plexinc/plex-media-player/milestones{/number}","notifications_url":"https://api.github.com/repos/plexinc/plex-media-player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plexinc/plex-media-player/labels{/name}","releases_url":"https://api.github.com/repos/plexinc/plex-media-player/releases{/id}","deployments_url":"https://api.github.com/repos/plexinc/plex-media-player/deployments","created_at":"2015-10-13T08:36:34Z","updated_at":"2018-07-03T21:01:58Z","pushed_at":"2018-07-04T01:06:59Z","git_url":"git://github.com/plexinc/plex-media-player.git","ssh_url":"git@github.com:plexinc/plex-media-player.git","clone_url":"https://github.com/plexinc/plex-media-player.git","svn_url":"https://github.com/plexinc/plex-media-player","homepage":null,"size":3394,"stargazers_count":577,"watchers_count":577,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"archived":false,"open_issues_count":92,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":86,"open_issues":92,"watchers":577,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plexinc/plex-media-player/pulls/763"},"html":{"href":"https://github.com/plexinc/plex-media-player/pull/763"},"issue":{"href":"https://api.github.com/repos/plexinc/plex-media-player/issues/763"},"comments":{"href":"https://api.github.com/repos/plexinc/plex-media-player/issues/763/comments"},"review_comments":{"href":"https://api.github.com/repos/plexinc/plex-media-player/pulls/763/comments"},"review_comment":{"href":"https://api.github.com/repos/plexinc/plex-media-player/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plexinc/plex-media-player/pulls/763/commits"},"statuses":{"href":"https://api.github.com/repos/plexinc/plex-media-player/statuses/142a89699b8e7d41359ebf6b926aee120dd0790c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":32,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"mseeley"}}