{"action":"created","comment":{"url":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/comments/189314021","pull_request_review_id":121475391,"id":189314021,"diff_hunk":"@@ -38,3 +38,34 @@ func (xmlTr xmlFormater) Format(event *models.Event) []byte {\n \t}\n \treturn b\n }\n+\n+type thingsboardJSONFormater struct {","path":"export/distro/format.go","position":5,"original_position":5,"commit_id":"d11cbb1f668135fade3620e80e4c76e77e944afa","original_commit_id":"d11cbb1f668135fade3620e80e4c76e77e944afa","user":{"login":"jduranf","id":11269311,"avatar_url":"https://avatars3.githubusercontent.com/u/11269311?v=4","gravatar_id":"","url":"https://api.github.com/users/jduranf","html_url":"https://github.com/jduranf","followers_url":"https://api.github.com/users/jduranf/followers","following_url":"https://api.github.com/users/jduranf/following{/other_user}","gists_url":"https://api.github.com/users/jduranf/gists{/gist_id}","starred_url":"https://api.github.com/users/jduranf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jduranf/subscriptions","organizations_url":"https://api.github.com/users/jduranf/orgs","repos_url":"https://api.github.com/users/jduranf/repos","events_url":"https://api.github.com/users/jduranf/events{/privacy}","received_events_url":"https://api.github.com/users/jduranf/received_events","type":"User","site_admin":false},"body":"Completely agree. But, should I fix all other \"formater\"?","created_at":"2018-05-18T15:50:55Z","updated_at":"2018-05-18T15:50:56Z","html_url":"https://github.com/edgexfoundry/edgex-go/pull/238#discussion_r189314021","pull_request_url":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/238","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/comments/189314021"},"html":{"href":"https://github.com/edgexfoundry/edgex-go/pull/238#discussion_r189314021"},"pull_request":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/238"}},"in_reply_to_id":189308858},"pull_request":{"url":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/238","id":189058619,"html_url":"https://github.com/edgexfoundry/edgex-go/pull/238","diff_url":"https://github.com/edgexfoundry/edgex-go/pull/238.diff","patch_url":"https://github.com/edgexfoundry/edgex-go/pull/238.patch","issue_url":"https://api.github.com/repos/edgexfoundry/edgex-go/issues/238","number":238,"state":"open","locked":false,"title":"Added export ThingsBoard JSON format","user":{"login":"jduranf","id":11269311,"avatar_url":"https://avatars3.githubusercontent.com/u/11269311?v=4","gravatar_id":"","url":"https://api.github.com/users/jduranf","html_url":"https://github.com/jduranf","followers_url":"https://api.github.com/users/jduranf/followers","following_url":"https://api.github.com/users/jduranf/following{/other_user}","gists_url":"https://api.github.com/users/jduranf/gists{/gist_id}","starred_url":"https://api.github.com/users/jduranf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jduranf/subscriptions","organizations_url":"https://api.github.com/users/jduranf/orgs","repos_url":"https://api.github.com/users/jduranf/repos","events_url":"https://api.github.com/users/jduranf/events{/privacy}","received_events_url":"https://api.github.com/users/jduranf/received_events","type":"User","site_admin":false},"body":"Related with issue #225 \r\n\r\nMore information about this JSON format:\r\nhttps://thingsboard.io/docs/reference/gateway-mqtt-api/#telemetry-upload-api\r\n\r\nSigned-off-by: Joan Duran <jduran@circutor.com>","created_at":"2018-05-18T15:20:56Z","updated_at":"2018-05-18T15:50:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"652c5e50fff44bd7d2fb345daf0cd17569d65d4e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/238/commits","review_comments_url":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/238/comments","review_comment_url":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edgexfoundry/edgex-go/issues/238/comments","statuses_url":"https://api.github.com/repos/edgexfoundry/edgex-go/statuses/d11cbb1f668135fade3620e80e4c76e77e944afa","head":{"label":"jduranf:exportThingsBoard","ref":"exportThingsBoard","sha":"d11cbb1f668135fade3620e80e4c76e77e944afa","user":{"login":"jduranf","id":11269311,"avatar_url":"https://avatars3.githubusercontent.com/u/11269311?v=4","gravatar_id":"","url":"https://api.github.com/users/jduranf","html_url":"https://github.com/jduranf","followers_url":"https://api.github.com/users/jduranf/followers","following_url":"https://api.github.com/users/jduranf/following{/other_user}","gists_url":"https://api.github.com/users/jduranf/gists{/gist_id}","starred_url":"https://api.github.com/users/jduranf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jduranf/subscriptions","organizations_url":"https://api.github.com/users/jduranf/orgs","repos_url":"https://api.github.com/users/jduranf/repos","events_url":"https://api.github.com/users/jduranf/events{/privacy}","received_events_url":"https://api.github.com/users/jduranf/received_events","type":"User","site_admin":false},"repo":{"id":128470810,"name":"edgex-go","full_name":"jduranf/edgex-go","owner":{"login":"jduranf","id":11269311,"avatar_url":"https://avatars3.githubusercontent.com/u/11269311?v=4","gravatar_id":"","url":"https://api.github.com/users/jduranf","html_url":"https://github.com/jduranf","followers_url":"https://api.github.com/users/jduranf/followers","following_url":"https://api.github.com/users/jduranf/following{/other_user}","gists_url":"https://api.github.com/users/jduranf/gists{/gist_id}","starred_url":"https://api.github.com/users/jduranf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jduranf/subscriptions","organizations_url":"https://api.github.com/users/jduranf/orgs","repos_url":"https://api.github.com/users/jduranf/repos","events_url":"https://api.github.com/users/jduranf/events{/privacy}","received_events_url":"https://api.github.com/users/jduranf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jduranf/edgex-go","description":"EdgeX Golang Services Monorepo","fork":true,"url":"https://api.github.com/repos/jduranf/edgex-go","forks_url":"https://api.github.com/repos/jduranf/edgex-go/forks","keys_url":"https://api.github.com/repos/jduranf/edgex-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jduranf/edgex-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jduranf/edgex-go/teams","hooks_url":"https://api.github.com/repos/jduranf/edgex-go/hooks","issue_events_url":"https://api.github.com/repos/jduranf/edgex-go/issues/events{/number}","events_url":"https://api.github.com/repos/jduranf/edgex-go/events","assignees_url":"https://api.github.com/repos/jduranf/edgex-go/assignees{/user}","branches_url":"https://api.github.com/repos/jduranf/edgex-go/branches{/branch}","tags_url":"https://api.github.com/repos/jduranf/edgex-go/tags","blobs_url":"https://api.github.com/repos/jduranf/edgex-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jduranf/edgex-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jduranf/edgex-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/jduranf/edgex-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jduranf/edgex-go/statuses/{sha}","languages_url":"https://api.github.com/repos/jduranf/edgex-go/languages","stargazers_url":"https://api.github.com/repos/jduranf/edgex-go/stargazers","contributors_url":"https://api.github.com/repos/jduranf/edgex-go/contributors","subscribers_url":"https://api.github.com/repos/jduranf/edgex-go/subscribers","subscription_url":"https://api.github.com/repos/jduranf/edgex-go/subscription","commits_url":"https://api.github.com/repos/jduranf/edgex-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/jduranf/edgex-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/jduranf/edgex-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/jduranf/edgex-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/jduranf/edgex-go/contents/{+path}","compare_url":"https://api.github.com/repos/jduranf/edgex-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jduranf/edgex-go/merges","archive_url":"https://api.github.com/repos/jduranf/edgex-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jduranf/edgex-go/downloads","issues_url":"https://api.github.com/repos/jduranf/edgex-go/issues{/number}","pulls_url":"https://api.github.com/repos/jduranf/edgex-go/pulls{/number}","milestones_url":"https://api.github.com/repos/jduranf/edgex-go/milestones{/number}","notifications_url":"https://api.github.com/repos/jduranf/edgex-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jduranf/edgex-go/labels{/name}","releases_url":"https://api.github.com/repos/jduranf/edgex-go/releases{/id}","deployments_url":"https://api.github.com/repos/jduranf/edgex-go/deployments","created_at":"2018-04-06T21:10:52Z","updated_at":"2018-05-15T20:22:43Z","pushed_at":"2018-05-18T15:18:08Z","git_url":"git://github.com/jduranf/edgex-go.git","ssh_url":"git@github.com:jduranf/edgex-go.git","clone_url":"https://github.com/jduranf/edgex-go.git","svn_url":"https://github.com/jduranf/edgex-go","homepage":null,"size":121659,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"edgexfoundry:master","ref":"master","sha":"9ad1697539a8e37eb4c7af21a7fa5228f0e26444","user":{"login":"edgexfoundry","id":27781926,"avatar_url":"https://avatars3.githubusercontent.com/u/27781926?v=4","gravatar_id":"","url":"https://api.github.com/users/edgexfoundry","html_url":"https://github.com/edgexfoundry","followers_url":"https://api.github.com/users/edgexfoundry/followers","following_url":"https://api.github.com/users/edgexfoundry/following{/other_user}","gists_url":"https://api.github.com/users/edgexfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/edgexfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgexfoundry/subscriptions","organizations_url":"https://api.github.com/users/edgexfoundry/orgs","repos_url":"https://api.github.com/users/edgexfoundry/repos","events_url":"https://api.github.com/users/edgexfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/edgexfoundry/received_events","type":"Organization","site_admin":false},"repo":{"id":119106012,"name":"edgex-go","full_name":"edgexfoundry/edgex-go","owner":{"login":"edgexfoundry","id":27781926,"avatar_url":"https://avatars3.githubusercontent.com/u/27781926?v=4","gravatar_id":"","url":"https://api.github.com/users/edgexfoundry","html_url":"https://github.com/edgexfoundry","followers_url":"https://api.github.com/users/edgexfoundry/followers","following_url":"https://api.github.com/users/edgexfoundry/following{/other_user}","gists_url":"https://api.github.com/users/edgexfoundry/gists{/gist_id}","starred_url":"https://api.github.com/users/edgexfoundry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgexfoundry/subscriptions","organizations_url":"https://api.github.com/users/edgexfoundry/orgs","repos_url":"https://api.github.com/users/edgexfoundry/repos","events_url":"https://api.github.com/users/edgexfoundry/events{/privacy}","received_events_url":"https://api.github.com/users/edgexfoundry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edgexfoundry/edgex-go","description":"EdgeX Golang Services Monorepo","fork":false,"url":"https://api.github.com/repos/edgexfoundry/edgex-go","forks_url":"https://api.github.com/repos/edgexfoundry/edgex-go/forks","keys_url":"https://api.github.com/repos/edgexfoundry/edgex-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edgexfoundry/edgex-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edgexfoundry/edgex-go/teams","hooks_url":"https://api.github.com/repos/edgexfoundry/edgex-go/hooks","issue_events_url":"https://api.github.com/repos/edgexfoundry/edgex-go/issues/events{/number}","events_url":"https://api.github.com/repos/edgexfoundry/edgex-go/events","assignees_url":"https://api.github.com/repos/edgexfoundry/edgex-go/assignees{/user}","branches_url":"https://api.github.com/repos/edgexfoundry/edgex-go/branches{/branch}","tags_url":"https://api.github.com/repos/edgexfoundry/edgex-go/tags","blobs_url":"https://api.github.com/repos/edgexfoundry/edgex-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edgexfoundry/edgex-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edgexfoundry/edgex-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/edgexfoundry/edgex-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edgexfoundry/edgex-go/statuses/{sha}","languages_url":"https://api.github.com/repos/edgexfoundry/edgex-go/languages","stargazers_url":"https://api.github.com/repos/edgexfoundry/edgex-go/stargazers","contributors_url":"https://api.github.com/repos/edgexfoundry/edgex-go/contributors","subscribers_url":"https://api.github.com/repos/edgexfoundry/edgex-go/subscribers","subscription_url":"https://api.github.com/repos/edgexfoundry/edgex-go/subscription","commits_url":"https://api.github.com/repos/edgexfoundry/edgex-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/edgexfoundry/edgex-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/edgexfoundry/edgex-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/edgexfoundry/edgex-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/edgexfoundry/edgex-go/contents/{+path}","compare_url":"https://api.github.com/repos/edgexfoundry/edgex-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edgexfoundry/edgex-go/merges","archive_url":"https://api.github.com/repos/edgexfoundry/edgex-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edgexfoundry/edgex-go/downloads","issues_url":"https://api.github.com/repos/edgexfoundry/edgex-go/issues{/number}","pulls_url":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls{/number}","milestones_url":"https://api.github.com/repos/edgexfoundry/edgex-go/milestones{/number}","notifications_url":"https://api.github.com/repos/edgexfoundry/edgex-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edgexfoundry/edgex-go/labels{/name}","releases_url":"https://api.github.com/repos/edgexfoundry/edgex-go/releases{/id}","deployments_url":"https://api.github.com/repos/edgexfoundry/edgex-go/deployments","created_at":"2018-01-26T21:37:55Z","updated_at":"2018-05-18T10:46:35Z","pushed_at":"2018-05-18T15:20:56Z","git_url":"git://github.com/edgexfoundry/edgex-go.git","ssh_url":"git@github.com:edgexfoundry/edgex-go.git","clone_url":"https://github.com/edgexfoundry/edgex-go.git","svn_url":"https://github.com/edgexfoundry/edgex-go","homepage":null,"size":121644,"stargazers_count":53,"watchers_count":53,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":32,"open_issues":48,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/238"},"html":{"href":"https://github.com/edgexfoundry/edgex-go/pull/238"},"issue":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/issues/238"},"comments":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/edgexfoundry/edgex-go/statuses/d11cbb1f668135fade3620e80e4c76e77e944afa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jduranf"}}