{"action":"closed","number":59,"pull_request":{"url":"https://api.github.com/repos/Esri/hub.js/pulls/59","id":213811681,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzODExNjgx","html_url":"https://github.com/Esri/hub.js/pull/59","diff_url":"https://github.com/Esri/hub.js/pull/59.diff","patch_url":"https://github.com/Esri/hub.js/pull/59.patch","issue_url":"https://api.github.com/repos/Esri/hub.js/issues/59","number":59,"state":"closed","locked":false,"title":"Added examples for simple Annotation CRUD","user":{"login":"ajturner","id":1218,"node_id":"MDQ6VXNlcjEyMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1218?v=4","gravatar_id":"","url":"https://api.github.com/users/ajturner","html_url":"https://github.com/ajturner","followers_url":"https://api.github.com/users/ajturner/followers","following_url":"https://api.github.com/users/ajturner/following{/other_user}","gists_url":"https://api.github.com/users/ajturner/gists{/gist_id}","starred_url":"https://api.github.com/users/ajturner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajturner/subscriptions","organizations_url":"https://api.github.com/users/ajturner/orgs","repos_url":"https://api.github.com/users/ajturner/repos","events_url":"https://api.github.com/users/ajturner/events{/privacy}","received_events_url":"https://api.github.com/users/ajturner/received_events","type":"User","site_admin":false},"body":"Added examples - but before merging I would like to discuss simple improvements to the method signatures that exposes less of the implementation.\r\n\r\n- Directly use the `annotationsUrl` without requiring adding a layer index `+ '/0'`\r\n- Remove redundant parameter names `addAnnotations({adds: [...]})`\r\n- Make Delete consistent with updates and add \r\n  - `addAnnotations({annotations: [{attributes: {description: \"Kinda Awesome!\"}]})`\r\n  - `updateAnnotations({annotations: [{attributes: {OBJECTID: 1, description: \"More Awesomer!\"}]})`\r\n  - `deleteAnnotations({annotations: [{attributes: {OBJECTID: 1}]})`","created_at":"2018-09-07T04:13:20Z","updated_at":"2018-09-19T22:38:38Z","closed_at":"2018-09-19T22:38:38Z","merged_at":"2018-09-19T22:38:38Z","merge_commit_sha":"1d5821f3c0ebdbdb2fea3c79b2f8561ee3c982a1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Esri/hub.js/pulls/59/commits","review_comments_url":"https://api.github.com/repos/Esri/hub.js/pulls/59/comments","review_comment_url":"https://api.github.com/repos/Esri/hub.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Esri/hub.js/issues/59/comments","statuses_url":"https://api.github.com/repos/Esri/hub.js/statuses/a51d0fe0b472b5947ec473e6df50960e7bd09e82","head":{"label":"Esri:d/annotation-docs","ref":"d/annotation-docs","sha":"a51d0fe0b472b5947ec473e6df50960e7bd09e82","user":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"repo":{"id":126880567,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4ODA1Njc=","name":"hub.js","full_name":"Esri/hub.js","private":false,"owner":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Esri/hub.js","description":"JavaScript wrappers for talking to ArcGIS Hub","fork":false,"url":"https://api.github.com/repos/Esri/hub.js","forks_url":"https://api.github.com/repos/Esri/hub.js/forks","keys_url":"https://api.github.com/repos/Esri/hub.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Esri/hub.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Esri/hub.js/teams","hooks_url":"https://api.github.com/repos/Esri/hub.js/hooks","issue_events_url":"https://api.github.com/repos/Esri/hub.js/issues/events{/number}","events_url":"https://api.github.com/repos/Esri/hub.js/events","assignees_url":"https://api.github.com/repos/Esri/hub.js/assignees{/user}","branches_url":"https://api.github.com/repos/Esri/hub.js/branches{/branch}","tags_url":"https://api.github.com/repos/Esri/hub.js/tags","blobs_url":"https://api.github.com/repos/Esri/hub.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Esri/hub.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Esri/hub.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Esri/hub.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Esri/hub.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Esri/hub.js/languages","stargazers_url":"https://api.github.com/repos/Esri/hub.js/stargazers","contributors_url":"https://api.github.com/repos/Esri/hub.js/contributors","subscribers_url":"https://api.github.com/repos/Esri/hub.js/subscribers","subscription_url":"https://api.github.com/repos/Esri/hub.js/subscription","commits_url":"https://api.github.com/repos/Esri/hub.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Esri/hub.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Esri/hub.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Esri/hub.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Esri/hub.js/contents/{+path}","compare_url":"https://api.github.com/repos/Esri/hub.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Esri/hub.js/merges","archive_url":"https://api.github.com/repos/Esri/hub.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Esri/hub.js/downloads","issues_url":"https://api.github.com/repos/Esri/hub.js/issues{/number}","pulls_url":"https://api.github.com/repos/Esri/hub.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Esri/hub.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Esri/hub.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Esri/hub.js/labels{/name}","releases_url":"https://api.github.com/repos/Esri/hub.js/releases{/id}","deployments_url":"https://api.github.com/repos/Esri/hub.js/deployments","created_at":"2018-03-26T19:38:34Z","updated_at":"2018-09-19T21:15:00Z","pushed_at":"2018-09-19T22:38:38Z","git_url":"git://github.com/Esri/hub.js.git","ssh_url":"git@github.com:Esri/hub.js.git","clone_url":"https://github.com/Esri/hub.js.git","svn_url":"https://github.com/Esri/hub.js","homepage":"https://esri.github.io/hub.js/","size":736,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":18,"watchers":5,"default_branch":"master"}},"base":{"label":"Esri:master","ref":"master","sha":"5bd59a9d24a613489c5dea7647635709befff851","user":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"repo":{"id":126880567,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY4ODA1Njc=","name":"hub.js","full_name":"Esri/hub.js","private":false,"owner":{"login":"Esri","id":628795,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyODc5NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/628795?v=4","gravatar_id":"","url":"https://api.github.com/users/Esri","html_url":"https://github.com/Esri","followers_url":"https://api.github.com/users/Esri/followers","following_url":"https://api.github.com/users/Esri/following{/other_user}","gists_url":"https://api.github.com/users/Esri/gists{/gist_id}","starred_url":"https://api.github.com/users/Esri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Esri/subscriptions","organizations_url":"https://api.github.com/users/Esri/orgs","repos_url":"https://api.github.com/users/Esri/repos","events_url":"https://api.github.com/users/Esri/events{/privacy}","received_events_url":"https://api.github.com/users/Esri/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Esri/hub.js","description":"JavaScript wrappers for talking to ArcGIS Hub","fork":false,"url":"https://api.github.com/repos/Esri/hub.js","forks_url":"https://api.github.com/repos/Esri/hub.js/forks","keys_url":"https://api.github.com/repos/Esri/hub.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Esri/hub.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Esri/hub.js/teams","hooks_url":"https://api.github.com/repos/Esri/hub.js/hooks","issue_events_url":"https://api.github.com/repos/Esri/hub.js/issues/events{/number}","events_url":"https://api.github.com/repos/Esri/hub.js/events","assignees_url":"https://api.github.com/repos/Esri/hub.js/assignees{/user}","branches_url":"https://api.github.com/repos/Esri/hub.js/branches{/branch}","tags_url":"https://api.github.com/repos/Esri/hub.js/tags","blobs_url":"https://api.github.com/repos/Esri/hub.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Esri/hub.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Esri/hub.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Esri/hub.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Esri/hub.js/statuses/{sha}","languages_url":"https://api.github.com/repos/Esri/hub.js/languages","stargazers_url":"https://api.github.com/repos/Esri/hub.js/stargazers","contributors_url":"https://api.github.com/repos/Esri/hub.js/contributors","subscribers_url":"https://api.github.com/repos/Esri/hub.js/subscribers","subscription_url":"https://api.github.com/repos/Esri/hub.js/subscription","commits_url":"https://api.github.com/repos/Esri/hub.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Esri/hub.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Esri/hub.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Esri/hub.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Esri/hub.js/contents/{+path}","compare_url":"https://api.github.com/repos/Esri/hub.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Esri/hub.js/merges","archive_url":"https://api.github.com/repos/Esri/hub.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Esri/hub.js/downloads","issues_url":"https://api.github.com/repos/Esri/hub.js/issues{/number}","pulls_url":"https://api.github.com/repos/Esri/hub.js/pulls{/number}","milestones_url":"https://api.github.com/repos/Esri/hub.js/milestones{/number}","notifications_url":"https://api.github.com/repos/Esri/hub.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Esri/hub.js/labels{/name}","releases_url":"https://api.github.com/repos/Esri/hub.js/releases{/id}","deployments_url":"https://api.github.com/repos/Esri/hub.js/deployments","created_at":"2018-03-26T19:38:34Z","updated_at":"2018-09-19T21:15:00Z","pushed_at":"2018-09-19T22:38:38Z","git_url":"git://github.com/Esri/hub.js.git","ssh_url":"git@github.com:Esri/hub.js.git","clone_url":"https://github.com/Esri/hub.js.git","svn_url":"https://github.com/Esri/hub.js","homepage":"https://esri.github.io/hub.js/","size":736,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":18,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Esri/hub.js/pulls/59"},"html":{"href":"https://github.com/Esri/hub.js/pull/59"},"issue":{"href":"https://api.github.com/repos/Esri/hub.js/issues/59"},"comments":{"href":"https://api.github.com/repos/Esri/hub.js/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/Esri/hub.js/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/Esri/hub.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Esri/hub.js/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/Esri/hub.js/statuses/a51d0fe0b472b5947ec473e6df50960e7bd09e82"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dbouwman","id":119129,"node_id":"MDQ6VXNlcjExOTEyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/119129?v=4","gravatar_id":"","url":"https://api.github.com/users/dbouwman","html_url":"https://github.com/dbouwman","followers_url":"https://api.github.com/users/dbouwman/followers","following_url":"https://api.github.com/users/dbouwman/following{/other_user}","gists_url":"https://api.github.com/users/dbouwman/gists{/gist_id}","starred_url":"https://api.github.com/users/dbouwman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbouwman/subscriptions","organizations_url":"https://api.github.com/users/dbouwman/orgs","repos_url":"https://api.github.com/users/dbouwman/repos","events_url":"https://api.github.com/users/dbouwman/events{/privacy}","received_events_url":"https://api.github.com/users/dbouwman/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":140,"deletions":71,"changed_files":11}}
{"actor":{"display_login":"dbouwman"}}