{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/205158255","pull_request_review_id":140372669,"id":205158255,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTE1ODI1NQ==","diff_hunk":"@@ -229,33 +561,33 @@ void FeatureType::SetNames(StringUtf8Multilang const & newNames)\n   });\n \n   if (m_params.name.IsEmpty())\n-    SetHeader(~feature::HEADER_HAS_NAME & Header());\n+    m_header = ~feature::HEADER_HAS_NAME & m_header;","path":"indexer/feature.cpp","position":null,"original_position":641,"commit_id":"f82495b55af531e7217a3daae064f253d5ea0f26","original_commit_id":"3bc6798ee1db810d78898d5750fcbde20459cd57","user":{"login":"tatiana-yan","id":9213190,"node_id":"MDQ6VXNlcjkyMTMxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-yan","html_url":"https://github.com/tatiana-yan","followers_url":"https://api.github.com/users/tatiana-yan/followers","following_url":"https://api.github.com/users/tatiana-yan/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-yan/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-yan/subscriptions","organizations_url":"https://api.github.com/users/tatiana-yan/orgs","repos_url":"https://api.github.com/users/tatiana-yan/repos","events_url":"https://api.github.com/users/tatiana-yan/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-yan/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-07-25T15:35:26Z","updated_at":"2018-07-25T15:35:26Z","html_url":"https://github.com/mapsme/omim/pull/9176#discussion_r205158255","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/9176","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/205158255"},"html":{"href":"https://github.com/mapsme/omim/pull/9176#discussion_r205158255"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/9176"}},"in_reply_to_id":205117994},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/9176","id":203485405,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNDg1NDA1","html_url":"https://github.com/mapsme/omim/pull/9176","diff_url":"https://github.com/mapsme/omim/pull/9176.diff","patch_url":"https://github.com/mapsme/omim/pull/9176.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/9176","number":9176,"state":"open","locked":false,"title":"[indexer] Convert LoaderBase methods to const, do not store FeatureType * in shared feature loader…","user":{"login":"tatiana-yan","id":9213190,"node_id":"MDQ6VXNlcjkyMTMxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-yan","html_url":"https://github.com/tatiana-yan","followers_url":"https://api.github.com/users/tatiana-yan/followers","following_url":"https://api.github.com/users/tatiana-yan/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-yan/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-yan/subscriptions","organizations_url":"https://api.github.com/users/tatiana-yan/orgs","repos_url":"https://api.github.com/users/tatiana-yan/repos","events_url":"https://api.github.com/users/tatiana-yan/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-yan/received_events","type":"User","site_admin":false},"body":"Convert LoaderBase methods to const, do not store FeatureType * in shared feature loader. Remove mutable from FeatureType. Remove methods which use uninitialized FeatureType * LoaderBase::m_pFt from FeatureBase. Remove FeatureBase because noone else uses it.\r\n\r\n\r\nОсновные содержательные изменения в feature, feature_loader, feature_loader_base.\r\nТакже убрала из generator/feature_builder использование FeatureBase методом \"будучи friend классом заполним все его поля данными которые мы и так знаем, проставим флажок что всё распашено (т.к. иначе при попытке парсинга всё крешится -- там внутри был лоадер у которого внутри нулевой указатель на FeatureType который он заполняет при парсинге) и будем его передавать во всякие методы\", пришлось немного поменять сигнатуры в indexer/feature_visibility\r\n\r\nостальные места затронуты по причине убирания mutable.\r\n\r\nВторым коммитом удалила FeatureLoader и перенесла всё в FeatureType, т.к. всё что делал FeatureLoader -- заполнял приватные поля FeatureType пользуясь тем, что он friend, лучше уж всё в одном классе чем так.","created_at":"2018-07-24T10:49:13Z","updated_at":"2018-07-25T15:35:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"19c635b40ea90d6b7490d29e8c3bf7f903ed7d21","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/9176/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/9176/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/9176/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/f82495b55af531e7217a3daae064f253d5ea0f26","head":{"label":"tatiana-yan:temp","ref":"temp","sha":"f82495b55af531e7217a3daae064f253d5ea0f26","user":{"login":"tatiana-yan","id":9213190,"node_id":"MDQ6VXNlcjkyMTMxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-yan","html_url":"https://github.com/tatiana-yan","followers_url":"https://api.github.com/users/tatiana-yan/followers","following_url":"https://api.github.com/users/tatiana-yan/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-yan/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-yan/subscriptions","organizations_url":"https://api.github.com/users/tatiana-yan/orgs","repos_url":"https://api.github.com/users/tatiana-yan/repos","events_url":"https://api.github.com/users/tatiana-yan/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-yan/received_events","type":"User","site_admin":false},"repo":{"id":98180090,"node_id":"MDEwOlJlcG9zaXRvcnk5ODE4MDA5MA==","name":"omim","full_name":"tatiana-yan/omim","owner":{"login":"tatiana-yan","id":9213190,"node_id":"MDQ6VXNlcjkyMTMxOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-yan","html_url":"https://github.com/tatiana-yan","followers_url":"https://api.github.com/users/tatiana-yan/followers","following_url":"https://api.github.com/users/tatiana-yan/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-yan/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-yan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-yan/subscriptions","organizations_url":"https://api.github.com/users/tatiana-yan/orgs","repos_url":"https://api.github.com/users/tatiana-yan/repos","events_url":"https://api.github.com/users/tatiana-yan/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-yan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tatiana-yan/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":true,"url":"https://api.github.com/repos/tatiana-yan/omim","forks_url":"https://api.github.com/repos/tatiana-yan/omim/forks","keys_url":"https://api.github.com/repos/tatiana-yan/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tatiana-yan/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tatiana-yan/omim/teams","hooks_url":"https://api.github.com/repos/tatiana-yan/omim/hooks","issue_events_url":"https://api.github.com/repos/tatiana-yan/omim/issues/events{/number}","events_url":"https://api.github.com/repos/tatiana-yan/omim/events","assignees_url":"https://api.github.com/repos/tatiana-yan/omim/assignees{/user}","branches_url":"https://api.github.com/repos/tatiana-yan/omim/branches{/branch}","tags_url":"https://api.github.com/repos/tatiana-yan/omim/tags","blobs_url":"https://api.github.com/repos/tatiana-yan/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tatiana-yan/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tatiana-yan/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/tatiana-yan/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tatiana-yan/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/tatiana-yan/omim/languages","stargazers_url":"https://api.github.com/repos/tatiana-yan/omim/stargazers","contributors_url":"https://api.github.com/repos/tatiana-yan/omim/contributors","subscribers_url":"https://api.github.com/repos/tatiana-yan/omim/subscribers","subscription_url":"https://api.github.com/repos/tatiana-yan/omim/subscription","commits_url":"https://api.github.com/repos/tatiana-yan/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/tatiana-yan/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/tatiana-yan/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/tatiana-yan/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/tatiana-yan/omim/contents/{+path}","compare_url":"https://api.github.com/repos/tatiana-yan/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tatiana-yan/omim/merges","archive_url":"https://api.github.com/repos/tatiana-yan/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tatiana-yan/omim/downloads","issues_url":"https://api.github.com/repos/tatiana-yan/omim/issues{/number}","pulls_url":"https://api.github.com/repos/tatiana-yan/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/tatiana-yan/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/tatiana-yan/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tatiana-yan/omim/labels{/name}","releases_url":"https://api.github.com/repos/tatiana-yan/omim/releases{/id}","deployments_url":"https://api.github.com/repos/tatiana-yan/omim/deployments","created_at":"2017-07-24T10:44:21Z","updated_at":"2018-04-27T18:53:14Z","pushed_at":"2018-07-25T15:33:37Z","git_url":"git://github.com/tatiana-yan/omim.git","ssh_url":"git@github.com:tatiana-yan/omim.git","clone_url":"https://github.com/tatiana-yan/omim.git","svn_url":"https://github.com/tatiana-yan/omim","homepage":"","size":3971174,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"279dda49d08a301e0cf5da9e5789e95cd0f9addd","user":{"login":"mapsme","id":14185141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTg1MTQx","avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjc5ODAzMw==","name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTg1MTQx","avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2018-07-25T15:00:32Z","pushed_at":"2018-07-25T15:33:39Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":3999583,"stargazers_count":2725,"watchers_count":2725,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":591,"mirror_url":null,"archived":false,"open_issues_count":724,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":591,"open_issues":724,"watchers":2725,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/9176"},"html":{"href":"https://github.com/mapsme/omim/pull/9176"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/9176"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/9176/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/9176/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/9176/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/f82495b55af531e7217a3daae064f253d5ea0f26"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tatiana-yan"}}