{"action":"created","issue":{"url":"https://api.github.com/repos/mikeboers/PyAV/issues/413","repository_url":"https://api.github.com/repos/mikeboers/PyAV","labels_url":"https://api.github.com/repos/mikeboers/PyAV/issues/413/labels{/name}","comments_url":"https://api.github.com/repos/mikeboers/PyAV/issues/413/comments","events_url":"https://api.github.com/repos/mikeboers/PyAV/issues/413/events","html_url":"https://github.com/mikeboers/PyAV/pull/413","id":366716833,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMzIwNjM2","number":413,"title":"Always use send / recv mechanism","user":{"login":"jlaine","id":1567624,"node_id":"MDQ6VXNlcjE1Njc2MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1567624?v=4","gravatar_id":"","url":"https://api.github.com/users/jlaine","html_url":"https://github.com/jlaine","followers_url":"https://api.github.com/users/jlaine/followers","following_url":"https://api.github.com/users/jlaine/following{/other_user}","gists_url":"https://api.github.com/users/jlaine/gists{/gist_id}","starred_url":"https://api.github.com/users/jlaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlaine/subscriptions","organizations_url":"https://api.github.com/users/jlaine/orgs","repos_url":"https://api.github.com/users/jlaine/repos","events_url":"https://api.github.com/users/jlaine/events{/privacy}","received_events_url":"https://api.github.com/users/jlaine/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-04T10:11:51Z","updated_at":"2018-10-05T13:18:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mikeboers/PyAV/pulls/413","html_url":"https://github.com/mikeboers/PyAV/pull/413","diff_url":"https://github.com/mikeboers/PyAV/pull/413.diff","patch_url":"https://github.com/mikeboers/PyAV/pull/413.patch"},"body":"Since FFmpeg 3.1, the preferred mechanism for encoding / decoding audio and video is using a send / receive mechanisms instead of calling avcodec_xxx_encode and avcodec_xxx_decode methods.\r\n\r\nNow that our baseline is FFmpeg 3.2 we can remove the legacy code, which fixes a number of deprecation warnings."},"comment":{"url":"https://api.github.com/repos/mikeboers/PyAV/issues/comments/427362992","html_url":"https://github.com/mikeboers/PyAV/pull/413#issuecomment-427362992","issue_url":"https://api.github.com/repos/mikeboers/PyAV/issues/413","id":427362992,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzM2Mjk5Mg==","user":{"login":"jlaine","id":1567624,"node_id":"MDQ6VXNlcjE1Njc2MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1567624?v=4","gravatar_id":"","url":"https://api.github.com/users/jlaine","html_url":"https://github.com/jlaine","followers_url":"https://api.github.com/users/jlaine/followers","following_url":"https://api.github.com/users/jlaine/following{/other_user}","gists_url":"https://api.github.com/users/jlaine/gists{/gist_id}","starred_url":"https://api.github.com/users/jlaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlaine/subscriptions","organizations_url":"https://api.github.com/users/jlaine/orgs","repos_url":"https://api.github.com/users/jlaine/repos","events_url":"https://api.github.com/users/jlaine/events{/privacy}","received_events_url":"https://api.github.com/users/jlaine/received_events","type":"User","site_admin":false},"created_at":"2018-10-05T13:18:07Z","updated_at":"2018-10-05T13:18:07Z","author_association":"CONTRIBUTOR","body":"I just want to point out that this commit doesn't change the behaviour compared to 0.5.3 : we were already using send / recv, so the \"count\" parameter did nothing.\r\n\r\nSo the immediate question is : do we keep the \"count\" parameter as a no-op or be honest and drop it?\r\n\r\nConcerning the \"blocking\" behaviour, I don't think it's justified, if you need your main loop to be responsive you should be running your `demux()` or `decode()` call in a thread. The blocking code occurs within a C function call and the GIL is released. I for instance use this in aiortc's \"webcam\" demo."}}
{"actor":{"display_login":"jlaine"}}