{"action":"created","comment":{"url":"https://api.github.com/repos/certbot/certbot/pulls/comments/199872416","pull_request_review_id":134068360,"id":199872416,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTg3MjQxNg==","diff_hunk":"@@ -39,6 +39,35 @@ def pick_authenticator(\n     return pick_plugin(\n         config, default, plugins, question, (interfaces.IAuthenticator,))\n \n+def get_unprepared_installer(config, plugins):\n+    \"\"\"\n+    Get an unprepared interfaces.IInstaller object.\n+\n+    :param certbot.interfaces.IConfig config: Configuration\n+    :param certbot.plugins.disco.PluginsRegistry plugins:\n+        All plugins registered as entry points.\n+\n+    :returns: Unprepared installer plugin.\n+    :rtype: IPlugin\n+    \"\"\"\n+\n+    _, req_inst = cli_plugin_requests(config)\n+    if not req_inst:","path":"certbot/plugins/selection.py","position":17,"original_position":17,"commit_id":"e5bb8c950b4b203e7d23971a306de1b6764c8e79","original_commit_id":"e5bb8c950b4b203e7d23971a306de1b6764c8e79","user":{"login":"bmw","id":6504915,"node_id":"MDQ6VXNlcjY1MDQ5MTU=","avatar_url":"https://avatars0.githubusercontent.com/u/6504915?v=4","gravatar_id":"","url":"https://api.github.com/users/bmw","html_url":"https://github.com/bmw","followers_url":"https://api.github.com/users/bmw/followers","following_url":"https://api.github.com/users/bmw/following{/other_user}","gists_url":"https://api.github.com/users/bmw/gists{/gist_id}","starred_url":"https://api.github.com/users/bmw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmw/subscriptions","organizations_url":"https://api.github.com/users/bmw/orgs","repos_url":"https://api.github.com/users/bmw/repos","events_url":"https://api.github.com/users/bmw/events{/privacy}","received_events_url":"https://api.github.com/users/bmw/received_events","type":"User","site_admin":false},"body":"If you obtain a cert without an installer (e.g. `certonly`) and then run `certbot renew`, the following is output:\r\n```\r\nCould not choose appropriate plugin for updaters: Missing command line flags. For non-interactive execution, you will need to specify an installer plugin on the command line. You can do this by running Certbot with '--installer PLUGIN_NAME\r\n```\r\nWe shouldn't do this. How about we just return `None` here?","created_at":"2018-07-03T16:29:52Z","updated_at":"2018-07-03T16:53:20Z","html_url":"https://github.com/certbot/certbot/pull/6167#discussion_r199872416","pull_request_url":"https://api.github.com/repos/certbot/certbot/pulls/6167","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/certbot/certbot/pulls/comments/199872416"},"html":{"href":"https://github.com/certbot/certbot/pull/6167#discussion_r199872416"},"pull_request":{"href":"https://api.github.com/repos/certbot/certbot/pulls/6167"}}},"pull_request":{"url":"https://api.github.com/repos/certbot/certbot/pulls/6167","id":198677797,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Njc3Nzk3","html_url":"https://github.com/certbot/certbot/pull/6167","diff_url":"https://github.com/certbot/certbot/pull/6167.diff","patch_url":"https://github.com/certbot/certbot/pull/6167.patch","issue_url":"https://api.github.com/repos/certbot/certbot/issues/6167","number":6167,"state":"open","locked":false,"title":"Do not call IPlugin.prepare() for updaters when running renew","user":{"login":"joohoi","id":5235109,"node_id":"MDQ6VXNlcjUyMzUxMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5235109?v=4","gravatar_id":"","url":"https://api.github.com/users/joohoi","html_url":"https://github.com/joohoi","followers_url":"https://api.github.com/users/joohoi/followers","following_url":"https://api.github.com/users/joohoi/following{/other_user}","gists_url":"https://api.github.com/users/joohoi/gists{/gist_id}","starred_url":"https://api.github.com/users/joohoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joohoi/subscriptions","organizations_url":"https://api.github.com/users/joohoi/orgs","repos_url":"https://api.github.com/users/joohoi/repos","events_url":"https://api.github.com/users/joohoi/events{/privacy}","received_events_url":"https://api.github.com/users/joohoi/received_events","type":"User","site_admin":false},"body":"`interfaces.GenericUpdater` and new enhancement interface updater functions get run on every invocation of Certbot with \"renew\" verb for every lineage. This causes performance problems for users with large configurations, because of plugin plumbing and preparsing happening in `prepare()` method of installer plugins. This PR moves the responsibility to call `prepare()` to the plugin (possibly) implementing a new style enhancement interface.\r\n\r\nFixes: #6153\r\n","created_at":"2018-07-02T13:20:56Z","updated_at":"2018-07-03T16:53:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62ff63d399c4cae16e3fdf66e9be31ca9cee6a7e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/certbot/certbot/pulls/6167/commits","review_comments_url":"https://api.github.com/repos/certbot/certbot/pulls/6167/comments","review_comment_url":"https://api.github.com/repos/certbot/certbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/certbot/certbot/issues/6167/comments","statuses_url":"https://api.github.com/repos/certbot/certbot/statuses/e5bb8c950b4b203e7d23971a306de1b6764c8e79","head":{"label":"certbot:unprepared_pick","ref":"unprepared_pick","sha":"e5bb8c950b4b203e7d23971a306de1b6764c8e79","user":{"login":"certbot","id":17889013,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODg5MDEz","avatar_url":"https://avatars2.githubusercontent.com/u/17889013?v=4","gravatar_id":"","url":"https://api.github.com/users/certbot","html_url":"https://github.com/certbot","followers_url":"https://api.github.com/users/certbot/followers","following_url":"https://api.github.com/users/certbot/following{/other_user}","gists_url":"https://api.github.com/users/certbot/gists{/gist_id}","starred_url":"https://api.github.com/users/certbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certbot/subscriptions","organizations_url":"https://api.github.com/users/certbot/orgs","repos_url":"https://api.github.com/users/certbot/repos","events_url":"https://api.github.com/users/certbot/events{/privacy}","received_events_url":"https://api.github.com/users/certbot/received_events","type":"Organization","site_admin":false},"repo":{"id":26516210,"node_id":"MDEwOlJlcG9zaXRvcnkyNjUxNjIxMA==","name":"certbot","full_name":"certbot/certbot","owner":{"login":"certbot","id":17889013,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODg5MDEz","avatar_url":"https://avatars2.githubusercontent.com/u/17889013?v=4","gravatar_id":"","url":"https://api.github.com/users/certbot","html_url":"https://github.com/certbot","followers_url":"https://api.github.com/users/certbot/followers","following_url":"https://api.github.com/users/certbot/following{/other_user}","gists_url":"https://api.github.com/users/certbot/gists{/gist_id}","starred_url":"https://api.github.com/users/certbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certbot/subscriptions","organizations_url":"https://api.github.com/users/certbot/orgs","repos_url":"https://api.github.com/users/certbot/repos","events_url":"https://api.github.com/users/certbot/events{/privacy}","received_events_url":"https://api.github.com/users/certbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/certbot/certbot","description":"Certbot is EFF's tool to obtain certs from Let's Encrypt and (optionally) auto-enable HTTPS on your server.  It can also act as a client for any other CA that uses the ACME protocol.","fork":false,"url":"https://api.github.com/repos/certbot/certbot","forks_url":"https://api.github.com/repos/certbot/certbot/forks","keys_url":"https://api.github.com/repos/certbot/certbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/certbot/certbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/certbot/certbot/teams","hooks_url":"https://api.github.com/repos/certbot/certbot/hooks","issue_events_url":"https://api.github.com/repos/certbot/certbot/issues/events{/number}","events_url":"https://api.github.com/repos/certbot/certbot/events","assignees_url":"https://api.github.com/repos/certbot/certbot/assignees{/user}","branches_url":"https://api.github.com/repos/certbot/certbot/branches{/branch}","tags_url":"https://api.github.com/repos/certbot/certbot/tags","blobs_url":"https://api.github.com/repos/certbot/certbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/certbot/certbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/certbot/certbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/certbot/certbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/certbot/certbot/statuses/{sha}","languages_url":"https://api.github.com/repos/certbot/certbot/languages","stargazers_url":"https://api.github.com/repos/certbot/certbot/stargazers","contributors_url":"https://api.github.com/repos/certbot/certbot/contributors","subscribers_url":"https://api.github.com/repos/certbot/certbot/subscribers","subscription_url":"https://api.github.com/repos/certbot/certbot/subscription","commits_url":"https://api.github.com/repos/certbot/certbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/certbot/certbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/certbot/certbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/certbot/certbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/certbot/certbot/contents/{+path}","compare_url":"https://api.github.com/repos/certbot/certbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/certbot/certbot/merges","archive_url":"https://api.github.com/repos/certbot/certbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/certbot/certbot/downloads","issues_url":"https://api.github.com/repos/certbot/certbot/issues{/number}","pulls_url":"https://api.github.com/repos/certbot/certbot/pulls{/number}","milestones_url":"https://api.github.com/repos/certbot/certbot/milestones{/number}","notifications_url":"https://api.github.com/repos/certbot/certbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/certbot/certbot/labels{/name}","releases_url":"https://api.github.com/repos/certbot/certbot/releases{/id}","deployments_url":"https://api.github.com/repos/certbot/certbot/deployments","created_at":"2014-11-12T02:52:20Z","updated_at":"2018-07-03T16:26:19Z","pushed_at":"2018-07-03T13:58:04Z","git_url":"git://github.com/certbot/certbot.git","ssh_url":"git@github.com:certbot/certbot.git","clone_url":"https://github.com/certbot/certbot.git","svn_url":"https://github.com/certbot/certbot","homepage":"","size":19174,"stargazers_count":22549,"watchers_count":22549,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2188,"mirror_url":null,"archived":false,"open_issues_count":1021,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2188,"open_issues":1021,"watchers":22549,"default_branch":"master"}},"base":{"label":"certbot:master","ref":"master","sha":"552e60a12691d434ea86a7c6bf5bc4a270651ba8","user":{"login":"certbot","id":17889013,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODg5MDEz","avatar_url":"https://avatars2.githubusercontent.com/u/17889013?v=4","gravatar_id":"","url":"https://api.github.com/users/certbot","html_url":"https://github.com/certbot","followers_url":"https://api.github.com/users/certbot/followers","following_url":"https://api.github.com/users/certbot/following{/other_user}","gists_url":"https://api.github.com/users/certbot/gists{/gist_id}","starred_url":"https://api.github.com/users/certbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certbot/subscriptions","organizations_url":"https://api.github.com/users/certbot/orgs","repos_url":"https://api.github.com/users/certbot/repos","events_url":"https://api.github.com/users/certbot/events{/privacy}","received_events_url":"https://api.github.com/users/certbot/received_events","type":"Organization","site_admin":false},"repo":{"id":26516210,"node_id":"MDEwOlJlcG9zaXRvcnkyNjUxNjIxMA==","name":"certbot","full_name":"certbot/certbot","owner":{"login":"certbot","id":17889013,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3ODg5MDEz","avatar_url":"https://avatars2.githubusercontent.com/u/17889013?v=4","gravatar_id":"","url":"https://api.github.com/users/certbot","html_url":"https://github.com/certbot","followers_url":"https://api.github.com/users/certbot/followers","following_url":"https://api.github.com/users/certbot/following{/other_user}","gists_url":"https://api.github.com/users/certbot/gists{/gist_id}","starred_url":"https://api.github.com/users/certbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certbot/subscriptions","organizations_url":"https://api.github.com/users/certbot/orgs","repos_url":"https://api.github.com/users/certbot/repos","events_url":"https://api.github.com/users/certbot/events{/privacy}","received_events_url":"https://api.github.com/users/certbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/certbot/certbot","description":"Certbot is EFF's tool to obtain certs from Let's Encrypt and (optionally) auto-enable HTTPS on your server.  It can also act as a client for any other CA that uses the ACME protocol.","fork":false,"url":"https://api.github.com/repos/certbot/certbot","forks_url":"https://api.github.com/repos/certbot/certbot/forks","keys_url":"https://api.github.com/repos/certbot/certbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/certbot/certbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/certbot/certbot/teams","hooks_url":"https://api.github.com/repos/certbot/certbot/hooks","issue_events_url":"https://api.github.com/repos/certbot/certbot/issues/events{/number}","events_url":"https://api.github.com/repos/certbot/certbot/events","assignees_url":"https://api.github.com/repos/certbot/certbot/assignees{/user}","branches_url":"https://api.github.com/repos/certbot/certbot/branches{/branch}","tags_url":"https://api.github.com/repos/certbot/certbot/tags","blobs_url":"https://api.github.com/repos/certbot/certbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/certbot/certbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/certbot/certbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/certbot/certbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/certbot/certbot/statuses/{sha}","languages_url":"https://api.github.com/repos/certbot/certbot/languages","stargazers_url":"https://api.github.com/repos/certbot/certbot/stargazers","contributors_url":"https://api.github.com/repos/certbot/certbot/contributors","subscribers_url":"https://api.github.com/repos/certbot/certbot/subscribers","subscription_url":"https://api.github.com/repos/certbot/certbot/subscription","commits_url":"https://api.github.com/repos/certbot/certbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/certbot/certbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/certbot/certbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/certbot/certbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/certbot/certbot/contents/{+path}","compare_url":"https://api.github.com/repos/certbot/certbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/certbot/certbot/merges","archive_url":"https://api.github.com/repos/certbot/certbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/certbot/certbot/downloads","issues_url":"https://api.github.com/repos/certbot/certbot/issues{/number}","pulls_url":"https://api.github.com/repos/certbot/certbot/pulls{/number}","milestones_url":"https://api.github.com/repos/certbot/certbot/milestones{/number}","notifications_url":"https://api.github.com/repos/certbot/certbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/certbot/certbot/labels{/name}","releases_url":"https://api.github.com/repos/certbot/certbot/releases{/id}","deployments_url":"https://api.github.com/repos/certbot/certbot/deployments","created_at":"2014-11-12T02:52:20Z","updated_at":"2018-07-03T16:26:19Z","pushed_at":"2018-07-03T13:58:04Z","git_url":"git://github.com/certbot/certbot.git","ssh_url":"git@github.com:certbot/certbot.git","clone_url":"https://github.com/certbot/certbot.git","svn_url":"https://github.com/certbot/certbot","homepage":"","size":19174,"stargazers_count":22549,"watchers_count":22549,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2188,"mirror_url":null,"archived":false,"open_issues_count":1021,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2188,"open_issues":1021,"watchers":22549,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/certbot/certbot/pulls/6167"},"html":{"href":"https://github.com/certbot/certbot/pull/6167"},"issue":{"href":"https://api.github.com/repos/certbot/certbot/issues/6167"},"comments":{"href":"https://api.github.com/repos/certbot/certbot/issues/6167/comments"},"review_comments":{"href":"https://api.github.com/repos/certbot/certbot/pulls/6167/comments"},"review_comment":{"href":"https://api.github.com/repos/certbot/certbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/certbot/certbot/pulls/6167/commits"},"statuses":{"href":"https://api.github.com/repos/certbot/certbot/statuses/e5bb8c950b4b203e7d23971a306de1b6764c8e79"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bmw"}}