{"action":"created","comment":{"url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/pulls/comments/207437695","pull_request_review_id":143049787,"id":207437695,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzQzNzY5NQ==","diff_hunk":"@@ -1670,6 +1679,10 @@ double VideoState::get_master_clock() const {\n \treturn val;\n }\n \n+double VideoState::get_fps() const {\n+\treturn video_st ? this->fps : 0;","path":"src/main/cpp/VideoState.cpp","position":21,"original_position":21,"commit_id":"b3b1972e3689112e8194c07d3e2bb88463b61e8e","original_commit_id":"b3b1972e3689112e8194c07d3e2bb88463b61e8e","user":{"login":"fraudies","id":1770877,"node_id":"MDQ6VXNlcjE3NzA4Nzc=","avatar_url":"https://avatars0.githubusercontent.com/u/1770877?v=4","gravatar_id":"","url":"https://api.github.com/users/fraudies","html_url":"https://github.com/fraudies","followers_url":"https://api.github.com/users/fraudies/followers","following_url":"https://api.github.com/users/fraudies/following{/other_user}","gists_url":"https://api.github.com/users/fraudies/gists{/gist_id}","starred_url":"https://api.github.com/users/fraudies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraudies/subscriptions","organizations_url":"https://api.github.com/users/fraudies/orgs","repos_url":"https://api.github.com/users/fraudies/repos","events_url":"https://api.github.com/users/fraudies/events{/privacy}","received_events_url":"https://api.github.com/users/fraudies/received_events","type":"User","site_admin":false},"body":"Maybe return -1 to make it consistent with what happens in java if we have an exception?","created_at":"2018-08-03T04:25:47Z","updated_at":"2018-08-03T04:29:46Z","html_url":"https://github.com/databrary/datavyu-ffmpegplugin/pull/22#discussion_r207437695","pull_request_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/pulls/22","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/pulls/comments/207437695"},"html":{"href":"https://github.com/databrary/datavyu-ffmpegplugin/pull/22#discussion_r207437695"},"pull_request":{"href":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/pulls/22","id":205876622,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1ODc2NjIy","html_url":"https://github.com/databrary/datavyu-ffmpegplugin/pull/22","diff_url":"https://github.com/databrary/datavyu-ffmpegplugin/pull/22.diff","patch_url":"https://github.com/databrary/datavyu-ffmpegplugin/pull/22.patch","issue_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/issues/22","number":22,"state":"open","locked":false,"title":"DVD-440 add and wire getFps and step to the next frame","user":{"login":"TheoWolf","id":7011786,"node_id":"MDQ6VXNlcjcwMTE3ODY=","avatar_url":"https://avatars2.githubusercontent.com/u/7011786?v=4","gravatar_id":"","url":"https://api.github.com/users/TheoWolf","html_url":"https://github.com/TheoWolf","followers_url":"https://api.github.com/users/TheoWolf/followers","following_url":"https://api.github.com/users/TheoWolf/following{/other_user}","gists_url":"https://api.github.com/users/TheoWolf/gists{/gist_id}","starred_url":"https://api.github.com/users/TheoWolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheoWolf/subscriptions","organizations_url":"https://api.github.com/users/TheoWolf/orgs","repos_url":"https://api.github.com/users/TheoWolf/repos","events_url":"https://api.github.com/users/TheoWolf/events{/privacy}","received_events_url":"https://api.github.com/users/TheoWolf/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-02T22:16:31Z","updated_at":"2018-08-03T04:29:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bd16f8e6fc0d4340e576e50e43440f9919cb110","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/pulls/22/commits","review_comments_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/pulls/22/comments","review_comment_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/issues/22/comments","statuses_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/statuses/b3b1972e3689112e8194c07d3e2bb88463b61e8e","head":{"label":"databrary:task_DVD-440","ref":"task_DVD-440","sha":"b3b1972e3689112e8194c07d3e2bb88463b61e8e","user":{"login":"databrary","id":3430703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzA3MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/3430703?v=4","gravatar_id":"","url":"https://api.github.com/users/databrary","html_url":"https://github.com/databrary","followers_url":"https://api.github.com/users/databrary/followers","following_url":"https://api.github.com/users/databrary/following{/other_user}","gists_url":"https://api.github.com/users/databrary/gists{/gist_id}","starred_url":"https://api.github.com/users/databrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databrary/subscriptions","organizations_url":"https://api.github.com/users/databrary/orgs","repos_url":"https://api.github.com/users/databrary/repos","events_url":"https://api.github.com/users/databrary/events{/privacy}","received_events_url":"https://api.github.com/users/databrary/received_events","type":"Organization","site_admin":false},"repo":{"id":102606140,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI2MDYxNDA=","name":"datavyu-ffmpegplugin","full_name":"databrary/datavyu-ffmpegplugin","owner":{"login":"databrary","id":3430703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzA3MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/3430703?v=4","gravatar_id":"","url":"https://api.github.com/users/databrary","html_url":"https://github.com/databrary","followers_url":"https://api.github.com/users/databrary/followers","following_url":"https://api.github.com/users/databrary/following{/other_user}","gists_url":"https://api.github.com/users/databrary/gists{/gist_id}","starred_url":"https://api.github.com/users/databrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databrary/subscriptions","organizations_url":"https://api.github.com/users/databrary/orgs","repos_url":"https://api.github.com/users/databrary/repos","events_url":"https://api.github.com/users/databrary/events{/privacy}","received_events_url":"https://api.github.com/users/databrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/databrary/datavyu-ffmpegplugin","description":"Code for ffmpeg-plugin","fork":false,"url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin","forks_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/forks","keys_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/teams","hooks_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/hooks","issue_events_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/issues/events{/number}","events_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/events","assignees_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/assignees{/user}","branches_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/branches{/branch}","tags_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/tags","blobs_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/statuses/{sha}","languages_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/languages","stargazers_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/stargazers","contributors_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/contributors","subscribers_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/subscribers","subscription_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/subscription","commits_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/contents/{+path}","compare_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/merges","archive_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/downloads","issues_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/issues{/number}","pulls_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/pulls{/number}","milestones_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/milestones{/number}","notifications_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/labels{/name}","releases_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/releases{/id}","deployments_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/deployments","created_at":"2017-09-06T12:33:38Z","updated_at":"2018-07-20T17:07:10Z","pushed_at":"2018-08-02T22:16:32Z","git_url":"git://github.com/databrary/datavyu-ffmpegplugin.git","ssh_url":"git@github.com:databrary/datavyu-ffmpegplugin.git","clone_url":"https://github.com/databrary/datavyu-ffmpegplugin.git","svn_url":"https://github.com/databrary/datavyu-ffmpegplugin","homepage":"","size":31103,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"databrary:byte-array","ref":"byte-array","sha":"b7c985a641ce37bab82e983bde4f2421685002cf","user":{"login":"databrary","id":3430703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzA3MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/3430703?v=4","gravatar_id":"","url":"https://api.github.com/users/databrary","html_url":"https://github.com/databrary","followers_url":"https://api.github.com/users/databrary/followers","following_url":"https://api.github.com/users/databrary/following{/other_user}","gists_url":"https://api.github.com/users/databrary/gists{/gist_id}","starred_url":"https://api.github.com/users/databrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databrary/subscriptions","organizations_url":"https://api.github.com/users/databrary/orgs","repos_url":"https://api.github.com/users/databrary/repos","events_url":"https://api.github.com/users/databrary/events{/privacy}","received_events_url":"https://api.github.com/users/databrary/received_events","type":"Organization","site_admin":false},"repo":{"id":102606140,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI2MDYxNDA=","name":"datavyu-ffmpegplugin","full_name":"databrary/datavyu-ffmpegplugin","owner":{"login":"databrary","id":3430703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzA3MDM=","avatar_url":"https://avatars3.githubusercontent.com/u/3430703?v=4","gravatar_id":"","url":"https://api.github.com/users/databrary","html_url":"https://github.com/databrary","followers_url":"https://api.github.com/users/databrary/followers","following_url":"https://api.github.com/users/databrary/following{/other_user}","gists_url":"https://api.github.com/users/databrary/gists{/gist_id}","starred_url":"https://api.github.com/users/databrary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/databrary/subscriptions","organizations_url":"https://api.github.com/users/databrary/orgs","repos_url":"https://api.github.com/users/databrary/repos","events_url":"https://api.github.com/users/databrary/events{/privacy}","received_events_url":"https://api.github.com/users/databrary/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/databrary/datavyu-ffmpegplugin","description":"Code for ffmpeg-plugin","fork":false,"url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin","forks_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/forks","keys_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/teams","hooks_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/hooks","issue_events_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/issues/events{/number}","events_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/events","assignees_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/assignees{/user}","branches_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/branches{/branch}","tags_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/tags","blobs_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/statuses/{sha}","languages_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/languages","stargazers_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/stargazers","contributors_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/contributors","subscribers_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/subscribers","subscription_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/subscription","commits_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/contents/{+path}","compare_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/merges","archive_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/downloads","issues_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/issues{/number}","pulls_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/pulls{/number}","milestones_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/milestones{/number}","notifications_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/labels{/name}","releases_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/releases{/id}","deployments_url":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/deployments","created_at":"2017-09-06T12:33:38Z","updated_at":"2018-07-20T17:07:10Z","pushed_at":"2018-08-02T22:16:32Z","git_url":"git://github.com/databrary/datavyu-ffmpegplugin.git","ssh_url":"git@github.com:databrary/datavyu-ffmpegplugin.git","clone_url":"https://github.com/databrary/datavyu-ffmpegplugin.git","svn_url":"https://github.com/databrary/datavyu-ffmpegplugin","homepage":"","size":31103,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/pulls/22"},"html":{"href":"https://github.com/databrary/datavyu-ffmpegplugin/pull/22"},"issue":{"href":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/issues/22"},"comments":{"href":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/databrary/datavyu-ffmpegplugin/statuses/b3b1972e3689112e8194c07d3e2bb88463b61e8e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fraudies"}}