{"action":"created","comment":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/168646636","pull_request_review_id":97051151,"id":168646636,"diff_hunk":"@@ -197,6 +207,7 @@ public long getBookiePendingRequests(BookieSocketAddress bookieSocketAddress) {\n         ensembleChangeCounter = bk.getStatsLogger().getCounter(BookKeeperClientStats.ENSEMBLE_CHANGES);\n         lacUpdateHitsCounter = bk.getStatsLogger().getCounter(BookKeeperClientStats.LAC_UPDATE_HITS);\n         lacUpdateMissesCounter = bk.getStatsLogger().getCounter(BookKeeperClientStats.LAC_UPDATE_MISSES);\n+        sendWaitTimer = bk.getStatsLogger().getOpStatsLogger(BookKeeperClientStats.CLIENT_SEND_WAIT_TIMER);","path":"bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java","position":49,"original_position":49,"commit_id":"0db554d1bf782cdb0d0eefe93580db2eb441a64e","original_commit_id":"0db554d1bf782cdb0d0eefe93580db2eb441a64e","user":{"login":"dlg99","id":8622884,"avatar_url":"https://avatars0.githubusercontent.com/u/8622884?v=4","gravatar_id":"","url":"https://api.github.com/users/dlg99","html_url":"https://github.com/dlg99","followers_url":"https://api.github.com/users/dlg99/followers","following_url":"https://api.github.com/users/dlg99/following{/other_user}","gists_url":"https://api.github.com/users/dlg99/gists{/gist_id}","starred_url":"https://api.github.com/users/dlg99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlg99/subscriptions","organizations_url":"https://api.github.com/users/dlg99/orgs","repos_url":"https://api.github.com/users/dlg99/repos","events_url":"https://api.github.com/users/dlg99/events{/privacy}","received_events_url":"https://api.github.com/users/dlg99/received_events","type":"User","site_admin":false},"body":"same as BookieWatcher's newEnsembleTimer and replaceBookieTimer.\r\nI'll see what is  the better name might be for it ","created_at":"2018-02-16T00:09:00Z","updated_at":"2018-02-16T00:09:00Z","html_url":"https://github.com/apache/bookkeeper/pull/1088#discussion_r168646636","pull_request_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1088","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments/168646636"},"html":{"href":"https://github.com/apache/bookkeeper/pull/1088#discussion_r168646636"},"pull_request":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1088"}},"in_reply_to_id":168380400},"pull_request":{"url":"https://api.github.com/repos/apache/bookkeeper/pulls/1088","id":166056344,"html_url":"https://github.com/apache/bookkeeper/pull/1088","diff_url":"https://github.com/apache/bookkeeper/pull/1088.diff","patch_url":"https://github.com/apache/bookkeeper/pull/1088.patch","issue_url":"https://api.github.com/repos/apache/bookkeeper/issues/1088","number":1088,"state":"open","locked":false,"title":"ISSUE #1086 (@bug W-4146427@) Client-side backpressure in netty (Fixes: io.netty.util.internal.OutOfDirectMemoryError under continuous heavy load)","user":{"login":"dlg99","id":8622884,"avatar_url":"https://avatars0.githubusercontent.com/u/8622884?v=4","gravatar_id":"","url":"https://api.github.com/users/dlg99","html_url":"https://github.com/dlg99","followers_url":"https://api.github.com/users/dlg99/followers","following_url":"https://api.github.com/users/dlg99/following{/other_user}","gists_url":"https://api.github.com/users/dlg99/gists{/gist_id}","starred_url":"https://api.github.com/users/dlg99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlg99/subscriptions","organizations_url":"https://api.github.com/users/dlg99/orgs","repos_url":"https://api.github.com/users/dlg99/repos","events_url":"https://api.github.com/users/dlg99/events{/privacy}","received_events_url":"https://api.github.com/users/dlg99/received_events","type":"User","site_admin":false},"body":"Descriptions of the changes in this PR:\r\n\r\nAdded client-side support for netty backpressure.\r\nNow PCBC will actually respect netty's behavior configured with\r\nclientWriteBufferLowWaterMark and clientWriteBufferHighWaterMark config parameters.\r\nIt is highly recommended setting them reasonably high for expected size of requests and load\r\nOtherwise client may end up doing frequent waits / throughput may drop.\r\n     \r\nMaster Issue: #1086 \r\n\r\n","created_at":"2018-01-30T18:07:28Z","updated_at":"2018-02-16T00:09:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"856266ecbfa7cab45a4f01d817e4fcd91e75b2e9","assignee":{"login":"dlg99","id":8622884,"avatar_url":"https://avatars0.githubusercontent.com/u/8622884?v=4","gravatar_id":"","url":"https://api.github.com/users/dlg99","html_url":"https://github.com/dlg99","followers_url":"https://api.github.com/users/dlg99/followers","following_url":"https://api.github.com/users/dlg99/following{/other_user}","gists_url":"https://api.github.com/users/dlg99/gists{/gist_id}","starred_url":"https://api.github.com/users/dlg99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlg99/subscriptions","organizations_url":"https://api.github.com/users/dlg99/orgs","repos_url":"https://api.github.com/users/dlg99/repos","events_url":"https://api.github.com/users/dlg99/events{/privacy}","received_events_url":"https://api.github.com/users/dlg99/received_events","type":"User","site_admin":false},"assignees":[{"login":"dlg99","id":8622884,"avatar_url":"https://avatars0.githubusercontent.com/u/8622884?v=4","gravatar_id":"","url":"https://api.github.com/users/dlg99","html_url":"https://github.com/dlg99","followers_url":"https://api.github.com/users/dlg99/followers","following_url":"https://api.github.com/users/dlg99/following{/other_user}","gists_url":"https://api.github.com/users/dlg99/gists{/gist_id}","starred_url":"https://api.github.com/users/dlg99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlg99/subscriptions","organizations_url":"https://api.github.com/users/dlg99/orgs","repos_url":"https://api.github.com/users/dlg99/repos","events_url":"https://api.github.com/users/dlg99/events{/privacy}","received_events_url":"https://api.github.com/users/dlg99/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"merlimat","id":62500,"avatar_url":"https://avatars2.githubusercontent.com/u/62500?v=4","gravatar_id":"","url":"https://api.github.com/users/merlimat","html_url":"https://github.com/merlimat","followers_url":"https://api.github.com/users/merlimat/followers","following_url":"https://api.github.com/users/merlimat/following{/other_user}","gists_url":"https://api.github.com/users/merlimat/gists{/gist_id}","starred_url":"https://api.github.com/users/merlimat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merlimat/subscriptions","organizations_url":"https://api.github.com/users/merlimat/orgs","repos_url":"https://api.github.com/users/merlimat/repos","events_url":"https://api.github.com/users/merlimat/events{/privacy}","received_events_url":"https://api.github.com/users/merlimat/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":769552700,"url":"https://api.github.com/repos/apache/bookkeeper/labels/type/improvement","name":"type/improvement","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1088/commits","review_comments_url":"https://api.github.com/repos/apache/bookkeeper/pulls/1088/comments","review_comment_url":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/bookkeeper/issues/1088/comments","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/0db554d1bf782cdb0d0eefe93580db2eb441a64e","head":{"label":"dlg99:fix/netty-client-backpressure","ref":"fix/netty-client-backpressure","sha":"0db554d1bf782cdb0d0eefe93580db2eb441a64e","user":{"login":"dlg99","id":8622884,"avatar_url":"https://avatars0.githubusercontent.com/u/8622884?v=4","gravatar_id":"","url":"https://api.github.com/users/dlg99","html_url":"https://github.com/dlg99","followers_url":"https://api.github.com/users/dlg99/followers","following_url":"https://api.github.com/users/dlg99/following{/other_user}","gists_url":"https://api.github.com/users/dlg99/gists{/gist_id}","starred_url":"https://api.github.com/users/dlg99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlg99/subscriptions","organizations_url":"https://api.github.com/users/dlg99/orgs","repos_url":"https://api.github.com/users/dlg99/repos","events_url":"https://api.github.com/users/dlg99/events{/privacy}","received_events_url":"https://api.github.com/users/dlg99/received_events","type":"User","site_admin":false},"repo":{"id":55713096,"name":"bookkeeper","full_name":"dlg99/bookkeeper","owner":{"login":"dlg99","id":8622884,"avatar_url":"https://avatars0.githubusercontent.com/u/8622884?v=4","gravatar_id":"","url":"https://api.github.com/users/dlg99","html_url":"https://github.com/dlg99","followers_url":"https://api.github.com/users/dlg99/followers","following_url":"https://api.github.com/users/dlg99/following{/other_user}","gists_url":"https://api.github.com/users/dlg99/gists{/gist_id}","starred_url":"https://api.github.com/users/dlg99/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlg99/subscriptions","organizations_url":"https://api.github.com/users/dlg99/orgs","repos_url":"https://api.github.com/users/dlg99/repos","events_url":"https://api.github.com/users/dlg99/events{/privacy}","received_events_url":"https://api.github.com/users/dlg99/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dlg99/bookkeeper","description":"Mirror of Apache Bookkeeper","fork":true,"url":"https://api.github.com/repos/dlg99/bookkeeper","forks_url":"https://api.github.com/repos/dlg99/bookkeeper/forks","keys_url":"https://api.github.com/repos/dlg99/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlg99/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlg99/bookkeeper/teams","hooks_url":"https://api.github.com/repos/dlg99/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/dlg99/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/dlg99/bookkeeper/events","assignees_url":"https://api.github.com/repos/dlg99/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/dlg99/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/dlg99/bookkeeper/tags","blobs_url":"https://api.github.com/repos/dlg99/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlg99/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlg99/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlg99/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlg99/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/dlg99/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/dlg99/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/dlg99/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/dlg99/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/dlg99/bookkeeper/subscription","commits_url":"https://api.github.com/repos/dlg99/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlg99/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlg99/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlg99/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlg99/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/dlg99/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlg99/bookkeeper/merges","archive_url":"https://api.github.com/repos/dlg99/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlg99/bookkeeper/downloads","issues_url":"https://api.github.com/repos/dlg99/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/dlg99/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/dlg99/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/dlg99/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlg99/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/dlg99/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/dlg99/bookkeeper/deployments","created_at":"2016-04-07T17:10:00Z","updated_at":"2016-04-07T17:10:02Z","pushed_at":"2018-02-14T20:37:54Z","git_url":"git://github.com/dlg99/bookkeeper.git","ssh_url":"git@github.com:dlg99/bookkeeper.git","clone_url":"https://github.com/dlg99/bookkeeper.git","svn_url":"https://github.com/dlg99/bookkeeper","homepage":null,"size":16347,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8bd6f0270fdb36de3c7b7e0bf92eb48d39bdf52e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":1575956,"name":"bookkeeper","full_name":"apache/bookkeeper","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/bookkeeper","description":"Apache Bookkeeper","fork":false,"url":"https://api.github.com/repos/apache/bookkeeper","forks_url":"https://api.github.com/repos/apache/bookkeeper/forks","keys_url":"https://api.github.com/repos/apache/bookkeeper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/bookkeeper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/bookkeeper/teams","hooks_url":"https://api.github.com/repos/apache/bookkeeper/hooks","issue_events_url":"https://api.github.com/repos/apache/bookkeeper/issues/events{/number}","events_url":"https://api.github.com/repos/apache/bookkeeper/events","assignees_url":"https://api.github.com/repos/apache/bookkeeper/assignees{/user}","branches_url":"https://api.github.com/repos/apache/bookkeeper/branches{/branch}","tags_url":"https://api.github.com/repos/apache/bookkeeper/tags","blobs_url":"https://api.github.com/repos/apache/bookkeeper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/bookkeeper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/bookkeeper/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/bookkeeper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/bookkeeper/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/bookkeeper/languages","stargazers_url":"https://api.github.com/repos/apache/bookkeeper/stargazers","contributors_url":"https://api.github.com/repos/apache/bookkeeper/contributors","subscribers_url":"https://api.github.com/repos/apache/bookkeeper/subscribers","subscription_url":"https://api.github.com/repos/apache/bookkeeper/subscription","commits_url":"https://api.github.com/repos/apache/bookkeeper/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/bookkeeper/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/bookkeeper/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/bookkeeper/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/bookkeeper/contents/{+path}","compare_url":"https://api.github.com/repos/apache/bookkeeper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/bookkeeper/merges","archive_url":"https://api.github.com/repos/apache/bookkeeper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/bookkeeper/downloads","issues_url":"https://api.github.com/repos/apache/bookkeeper/issues{/number}","pulls_url":"https://api.github.com/repos/apache/bookkeeper/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/bookkeeper/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/bookkeeper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/bookkeeper/labels{/name}","releases_url":"https://api.github.com/repos/apache/bookkeeper/releases{/id}","deployments_url":"https://api.github.com/repos/apache/bookkeeper/deployments","created_at":"2011-04-06T07:00:07Z","updated_at":"2018-02-11T18:36:56Z","pushed_at":"2018-02-15T23:29:50Z","git_url":"git://github.com/apache/bookkeeper.git","ssh_url":"git@github.com:apache/bookkeeper.git","clone_url":"https://github.com/apache/bookkeeper.git","svn_url":"https://github.com/apache/bookkeeper","homepage":"https://bookkeeper.apache.org","size":24157,"stargazers_count":267,"watchers_count":267,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":148,"mirror_url":null,"archived":false,"open_issues_count":183,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":148,"open_issues":183,"watchers":267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1088"},"html":{"href":"https://github.com/apache/bookkeeper/pull/1088"},"issue":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/1088"},"comments":{"href":"https://api.github.com/repos/apache/bookkeeper/issues/1088/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1088/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/bookkeeper/pulls/1088/commits"},"statuses":{"href":"https://api.github.com/repos/apache/bookkeeper/statuses/0db554d1bf782cdb0d0eefe93580db2eb441a64e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dlg99"}}