{"action":"created","comment":{"url":"https://api.github.com/repos/IATI/deployment/pulls/comments/175731617","pull_request_review_id":105298995,"id":175731617,"diff_hunk":"@@ -0,0 +1,45 @@\n+# Include module configuration:\n+Include /etc/apache2/mods-enabled/*.load\n+Include /etc/apache2/mods-enabled/*.conf\n+\n+# Include ports listing\n+Include /etc/apache2/ports.conf\n+\n+{% if apache2_servername is defined %}\n+ServerName {{apache2_servername}}\n+{% endif %}\n+\n+<VirtualHost {{apache2_ip}}:{{apache2_port}}>\n+  ServerAdmin webmaster@localhost\n+  \n+  {% if apache2_documentroot is defined %}\n+  DocumentRoot {{apache2_documentroot}}\n+  {% endif %}\n+\n+  ErrorLog ${APACHE_LOG_DIR}/error.log\n+  CustomLog ${APACHE_LOG_DIR}/access.log combined\n+\n+  {% for directory in apache2_directories %}\n+    {% if directory.alias_source is defined %}\n+  Alias {{directory.alias_source}} {{directory.alias_destination}}\n+    {% endif %}\n+  <Directory {{directory.root}}>\n+    {% if directory.file_location is defined %}\n+    <Files {{directory.file_location}}>\n+      Require all granted\n+    </Files>\n+    {% else %}\n+    {% if directory.options is defined%}\n+      {% for option in directory.options %}\n+    {{option.line}}\n+      {% endfor %}\n+    {% endif %}\n+    Require all granted\n+    {% endif %}\n+  </Directory>\n+  {% endfor %}\n+\n+  {% for apache2_extra in apache2_extras %}","path":"roles/common/apache2/apache2_install/templates/apache2.conf.j2","position":42,"original_position":42,"commit_id":"577b8dc7b1c88a702daa7d4282ba3311742c68f9","original_commit_id":"577b8dc7b1c88a702daa7d4282ba3311742c68f9","user":{"login":"allthatilk","id":23729009,"avatar_url":"https://avatars3.githubusercontent.com/u/23729009?v=4","gravatar_id":"","url":"https://api.github.com/users/allthatilk","html_url":"https://github.com/allthatilk","followers_url":"https://api.github.com/users/allthatilk/followers","following_url":"https://api.github.com/users/allthatilk/following{/other_user}","gists_url":"https://api.github.com/users/allthatilk/gists{/gist_id}","starred_url":"https://api.github.com/users/allthatilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allthatilk/subscriptions","organizations_url":"https://api.github.com/users/allthatilk/orgs","repos_url":"https://api.github.com/users/allthatilk/repos","events_url":"https://api.github.com/users/allthatilk/events{/privacy}","received_events_url":"https://api.github.com/users/allthatilk/received_events","type":"User","site_admin":false},"body":"what does apache2 extras refer to?","created_at":"2018-03-20T11:26:09Z","updated_at":"2018-03-20T11:29:11Z","html_url":"https://github.com/IATI/deployment/pull/18#discussion_r175731617","pull_request_url":"https://api.github.com/repos/IATI/deployment/pulls/18","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/IATI/deployment/pulls/comments/175731617"},"html":{"href":"https://github.com/IATI/deployment/pull/18#discussion_r175731617"},"pull_request":{"href":"https://api.github.com/repos/IATI/deployment/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/IATI/deployment/pulls/18","id":176039441,"html_url":"https://github.com/IATI/deployment/pull/18","diff_url":"https://github.com/IATI/deployment/pull/18.diff","patch_url":"https://github.com/IATI/deployment/pull/18.patch","issue_url":"https://api.github.com/repos/IATI/deployment/issues/18","number":18,"state":"open","locked":false,"title":"Completed Apache config template with validation","user":{"login":"akmiller01","id":2836840,"avatar_url":"https://avatars1.githubusercontent.com/u/2836840?v=4","gravatar_id":"","url":"https://api.github.com/users/akmiller01","html_url":"https://github.com/akmiller01","followers_url":"https://api.github.com/users/akmiller01/followers","following_url":"https://api.github.com/users/akmiller01/following{/other_user}","gists_url":"https://api.github.com/users/akmiller01/gists{/gist_id}","starred_url":"https://api.github.com/users/akmiller01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akmiller01/subscriptions","organizations_url":"https://api.github.com/users/akmiller01/orgs","repos_url":"https://api.github.com/users/akmiller01/repos","events_url":"https://api.github.com/users/akmiller01/events{/privacy}","received_events_url":"https://api.github.com/users/akmiller01/received_events","type":"User","site_admin":false},"body":"The validator was a pain, requiring some additional pieces beyond the original configs.","created_at":"2018-03-19T22:10:23Z","updated_at":"2018-03-20T11:29:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3753bfaed44f3f99e1a5fb9420e3ce34ae1c17be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":832394736,"url":"https://api.github.com/repos/IATI/deployment/labels/complete","name":"complete","color":"0052cc","default":false},{"id":624914526,"url":"https://api.github.com/repos/IATI/deployment/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/IATI/deployment/pulls/18/commits","review_comments_url":"https://api.github.com/repos/IATI/deployment/pulls/18/comments","review_comment_url":"https://api.github.com/repos/IATI/deployment/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IATI/deployment/issues/18/comments","statuses_url":"https://api.github.com/repos/IATI/deployment/statuses/577b8dc7b1c88a702daa7d4282ba3311742c68f9","head":{"label":"akmiller01:dev","ref":"dev","sha":"577b8dc7b1c88a702daa7d4282ba3311742c68f9","user":{"login":"akmiller01","id":2836840,"avatar_url":"https://avatars1.githubusercontent.com/u/2836840?v=4","gravatar_id":"","url":"https://api.github.com/users/akmiller01","html_url":"https://github.com/akmiller01","followers_url":"https://api.github.com/users/akmiller01/followers","following_url":"https://api.github.com/users/akmiller01/following{/other_user}","gists_url":"https://api.github.com/users/akmiller01/gists{/gist_id}","starred_url":"https://api.github.com/users/akmiller01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akmiller01/subscriptions","organizations_url":"https://api.github.com/users/akmiller01/orgs","repos_url":"https://api.github.com/users/akmiller01/repos","events_url":"https://api.github.com/users/akmiller01/events{/privacy}","received_events_url":"https://api.github.com/users/akmiller01/received_events","type":"User","site_admin":false},"repo":{"id":125902066,"name":"deployment","full_name":"akmiller01/deployment","owner":{"login":"akmiller01","id":2836840,"avatar_url":"https://avatars1.githubusercontent.com/u/2836840?v=4","gravatar_id":"","url":"https://api.github.com/users/akmiller01","html_url":"https://github.com/akmiller01","followers_url":"https://api.github.com/users/akmiller01/followers","following_url":"https://api.github.com/users/akmiller01/following{/other_user}","gists_url":"https://api.github.com/users/akmiller01/gists{/gist_id}","starred_url":"https://api.github.com/users/akmiller01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akmiller01/subscriptions","organizations_url":"https://api.github.com/users/akmiller01/orgs","repos_url":"https://api.github.com/users/akmiller01/repos","events_url":"https://api.github.com/users/akmiller01/events{/privacy}","received_events_url":"https://api.github.com/users/akmiller01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akmiller01/deployment","description":"A repository for managing deployment processes. Single-purpose successor to https://github.com/IATI/IATI-Websites","fork":true,"url":"https://api.github.com/repos/akmiller01/deployment","forks_url":"https://api.github.com/repos/akmiller01/deployment/forks","keys_url":"https://api.github.com/repos/akmiller01/deployment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akmiller01/deployment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akmiller01/deployment/teams","hooks_url":"https://api.github.com/repos/akmiller01/deployment/hooks","issue_events_url":"https://api.github.com/repos/akmiller01/deployment/issues/events{/number}","events_url":"https://api.github.com/repos/akmiller01/deployment/events","assignees_url":"https://api.github.com/repos/akmiller01/deployment/assignees{/user}","branches_url":"https://api.github.com/repos/akmiller01/deployment/branches{/branch}","tags_url":"https://api.github.com/repos/akmiller01/deployment/tags","blobs_url":"https://api.github.com/repos/akmiller01/deployment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akmiller01/deployment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akmiller01/deployment/git/refs{/sha}","trees_url":"https://api.github.com/repos/akmiller01/deployment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akmiller01/deployment/statuses/{sha}","languages_url":"https://api.github.com/repos/akmiller01/deployment/languages","stargazers_url":"https://api.github.com/repos/akmiller01/deployment/stargazers","contributors_url":"https://api.github.com/repos/akmiller01/deployment/contributors","subscribers_url":"https://api.github.com/repos/akmiller01/deployment/subscribers","subscription_url":"https://api.github.com/repos/akmiller01/deployment/subscription","commits_url":"https://api.github.com/repos/akmiller01/deployment/commits{/sha}","git_commits_url":"https://api.github.com/repos/akmiller01/deployment/git/commits{/sha}","comments_url":"https://api.github.com/repos/akmiller01/deployment/comments{/number}","issue_comment_url":"https://api.github.com/repos/akmiller01/deployment/issues/comments{/number}","contents_url":"https://api.github.com/repos/akmiller01/deployment/contents/{+path}","compare_url":"https://api.github.com/repos/akmiller01/deployment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akmiller01/deployment/merges","archive_url":"https://api.github.com/repos/akmiller01/deployment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akmiller01/deployment/downloads","issues_url":"https://api.github.com/repos/akmiller01/deployment/issues{/number}","pulls_url":"https://api.github.com/repos/akmiller01/deployment/pulls{/number}","milestones_url":"https://api.github.com/repos/akmiller01/deployment/milestones{/number}","notifications_url":"https://api.github.com/repos/akmiller01/deployment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akmiller01/deployment/labels{/name}","releases_url":"https://api.github.com/repos/akmiller01/deployment/releases{/id}","deployments_url":"https://api.github.com/repos/akmiller01/deployment/deployments","created_at":"2018-03-19T18:21:27Z","updated_at":"2018-03-19T18:21:28Z","pushed_at":"2018-03-19T18:28:19Z","git_url":"git://github.com/akmiller01/deployment.git","ssh_url":"git@github.com:akmiller01/deployment.git","clone_url":"https://github.com/akmiller01/deployment.git","svn_url":"https://github.com/akmiller01/deployment","homepage":null,"size":122,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IATI:dev","ref":"dev","sha":"4d8cc11ace5b3032a6f0bba4a78483574e5ff67d","user":{"login":"IATI","id":5502974,"avatar_url":"https://avatars3.githubusercontent.com/u/5502974?v=4","gravatar_id":"","url":"https://api.github.com/users/IATI","html_url":"https://github.com/IATI","followers_url":"https://api.github.com/users/IATI/followers","following_url":"https://api.github.com/users/IATI/following{/other_user}","gists_url":"https://api.github.com/users/IATI/gists{/gist_id}","starred_url":"https://api.github.com/users/IATI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IATI/subscriptions","organizations_url":"https://api.github.com/users/IATI/orgs","repos_url":"https://api.github.com/users/IATI/repos","events_url":"https://api.github.com/users/IATI/events{/privacy}","received_events_url":"https://api.github.com/users/IATI/received_events","type":"Organization","site_admin":false},"repo":{"id":94097665,"name":"deployment","full_name":"IATI/deployment","owner":{"login":"IATI","id":5502974,"avatar_url":"https://avatars3.githubusercontent.com/u/5502974?v=4","gravatar_id":"","url":"https://api.github.com/users/IATI","html_url":"https://github.com/IATI","followers_url":"https://api.github.com/users/IATI/followers","following_url":"https://api.github.com/users/IATI/following{/other_user}","gists_url":"https://api.github.com/users/IATI/gists{/gist_id}","starred_url":"https://api.github.com/users/IATI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IATI/subscriptions","organizations_url":"https://api.github.com/users/IATI/orgs","repos_url":"https://api.github.com/users/IATI/repos","events_url":"https://api.github.com/users/IATI/events{/privacy}","received_events_url":"https://api.github.com/users/IATI/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IATI/deployment","description":"A repository for managing deployment processes. Single-purpose successor to https://github.com/IATI/IATI-Websites","fork":false,"url":"https://api.github.com/repos/IATI/deployment","forks_url":"https://api.github.com/repos/IATI/deployment/forks","keys_url":"https://api.github.com/repos/IATI/deployment/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IATI/deployment/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IATI/deployment/teams","hooks_url":"https://api.github.com/repos/IATI/deployment/hooks","issue_events_url":"https://api.github.com/repos/IATI/deployment/issues/events{/number}","events_url":"https://api.github.com/repos/IATI/deployment/events","assignees_url":"https://api.github.com/repos/IATI/deployment/assignees{/user}","branches_url":"https://api.github.com/repos/IATI/deployment/branches{/branch}","tags_url":"https://api.github.com/repos/IATI/deployment/tags","blobs_url":"https://api.github.com/repos/IATI/deployment/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IATI/deployment/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IATI/deployment/git/refs{/sha}","trees_url":"https://api.github.com/repos/IATI/deployment/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IATI/deployment/statuses/{sha}","languages_url":"https://api.github.com/repos/IATI/deployment/languages","stargazers_url":"https://api.github.com/repos/IATI/deployment/stargazers","contributors_url":"https://api.github.com/repos/IATI/deployment/contributors","subscribers_url":"https://api.github.com/repos/IATI/deployment/subscribers","subscription_url":"https://api.github.com/repos/IATI/deployment/subscription","commits_url":"https://api.github.com/repos/IATI/deployment/commits{/sha}","git_commits_url":"https://api.github.com/repos/IATI/deployment/git/commits{/sha}","comments_url":"https://api.github.com/repos/IATI/deployment/comments{/number}","issue_comment_url":"https://api.github.com/repos/IATI/deployment/issues/comments{/number}","contents_url":"https://api.github.com/repos/IATI/deployment/contents/{+path}","compare_url":"https://api.github.com/repos/IATI/deployment/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IATI/deployment/merges","archive_url":"https://api.github.com/repos/IATI/deployment/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IATI/deployment/downloads","issues_url":"https://api.github.com/repos/IATI/deployment/issues{/number}","pulls_url":"https://api.github.com/repos/IATI/deployment/pulls{/number}","milestones_url":"https://api.github.com/repos/IATI/deployment/milestones{/number}","notifications_url":"https://api.github.com/repos/IATI/deployment/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IATI/deployment/labels{/name}","releases_url":"https://api.github.com/repos/IATI/deployment/releases{/id}","deployments_url":"https://api.github.com/repos/IATI/deployment/deployments","created_at":"2017-06-12T13:12:01Z","updated_at":"2017-06-12T13:12:01Z","pushed_at":"2018-03-19T22:10:23Z","git_url":"git://github.com/IATI/deployment.git","ssh_url":"git@github.com:IATI/deployment.git","clone_url":"https://github.com/IATI/deployment.git","svn_url":"https://github.com/IATI/deployment","homepage":null,"size":116,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IATI/deployment/pulls/18"},"html":{"href":"https://github.com/IATI/deployment/pull/18"},"issue":{"href":"https://api.github.com/repos/IATI/deployment/issues/18"},"comments":{"href":"https://api.github.com/repos/IATI/deployment/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/IATI/deployment/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/IATI/deployment/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IATI/deployment/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/IATI/deployment/statuses/577b8dc7b1c88a702daa7d4282ba3311742c68f9"}},"author_association":"NONE"}}
{"actor":{"display_login":"allthatilk"}}