{"action":"created","issue":{"url":"https://api.github.com/repos/RobinSchmidt/RS-MET/issues/263","repository_url":"https://api.github.com/repos/RobinSchmidt/RS-MET","labels_url":"https://api.github.com/repos/RobinSchmidt/RS-MET/issues/263/labels{/name}","comments_url":"https://api.github.com/repos/RobinSchmidt/RS-MET/issues/263/comments","events_url":"https://api.github.com/repos/RobinSchmidt/RS-MET/issues/263/events","html_url":"https://github.com/RobinSchmidt/RS-MET/issues/263","id":386314247,"node_id":"MDU6SXNzdWUzODYzMTQyNDc=","number":263,"title":"Please solve your signed unsigned mismatche warnings","user":{"login":"elanhickler","id":9116575,"node_id":"MDQ6VXNlcjkxMTY1NzU=","avatar_url":"https://avatars3.githubusercontent.com/u/9116575?v=4","gravatar_id":"","url":"https://api.github.com/users/elanhickler","html_url":"https://github.com/elanhickler","followers_url":"https://api.github.com/users/elanhickler/followers","following_url":"https://api.github.com/users/elanhickler/following{/other_user}","gists_url":"https://api.github.com/users/elanhickler/gists{/gist_id}","starred_url":"https://api.github.com/users/elanhickler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elanhickler/subscriptions","organizations_url":"https://api.github.com/users/elanhickler/orgs","repos_url":"https://api.github.com/users/elanhickler/repos","events_url":"https://api.github.com/users/elanhickler/events{/privacy}","received_events_url":"https://api.github.com/users/elanhickler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-30T19:13:03Z","updated_at":"2018-12-01T19:52:21Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"you have a lot of signed unsigned mismatch warnings\r\n\r\n```cpp\r\n// wrong\r\nfor (int i = 0; i < vector.size(); ++i)\r\n```\r\n\r\n```cpp\r\n// ok\r\nfor (int i = 0; i < (int)vector.size(); ++i)\r\n```\r\n\r\n```cpp\r\n// good\r\nfor (unsigned i = 0; i < vector.size(); ++i)\r\n```\r\n\r\n```cpp\r\n// best\r\nfor (const auto & obj : vector)\r\n```"},"comment":{"url":"https://api.github.com/repos/RobinSchmidt/RS-MET/issues/comments/443453589","html_url":"https://github.com/RobinSchmidt/RS-MET/issues/263#issuecomment-443453589","issue_url":"https://api.github.com/repos/RobinSchmidt/RS-MET/issues/263","id":443453589,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzQ1MzU4OQ==","user":{"login":"RobinSchmidt","id":1833099,"node_id":"MDQ6VXNlcjE4MzMwOTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1833099?v=4","gravatar_id":"","url":"https://api.github.com/users/RobinSchmidt","html_url":"https://github.com/RobinSchmidt","followers_url":"https://api.github.com/users/RobinSchmidt/followers","following_url":"https://api.github.com/users/RobinSchmidt/following{/other_user}","gists_url":"https://api.github.com/users/RobinSchmidt/gists{/gist_id}","starred_url":"https://api.github.com/users/RobinSchmidt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobinSchmidt/subscriptions","organizations_url":"https://api.github.com/users/RobinSchmidt/orgs","repos_url":"https://api.github.com/users/RobinSchmidt/repos","events_url":"https://api.github.com/users/RobinSchmidt/events{/privacy}","received_events_url":"https://api.github.com/users/RobinSchmidt/received_events","type":"User","site_admin":false},"created_at":"2018-12-01T19:52:21Z","updated_at":"2018-12-01T19:52:21Z","author_association":"OWNER","body":"actually, i did a clean rebuild. do you really get them with toolchain or in another project? and/or maybe you are using VS 2017 (while i still use 2015)"}}
{"actor":{"display_login":"RobinSchmidt"}}