{"push_id":2575526633,"size":146,"distinct_size":1,"ref":"refs/heads/ByInfixo","head":"9eef9f5847d67d65450e199bb7d1727f810bd500","before":"d0308b4869a8860f0229179aa2c8d3732d604b9c","commits":[{"sha":"7f03dc70854f7fe92bd1d237a44521d84c9fcc73","author":{"name":"davenye","email":"c24cc3cd1a553e349b4b8fa26f021650311fb3b8@users.noreply.github.com"},"message":"Fixed blank names in AD deal withdrawn notes\n\nNow using getName() since nicknames are not populated for AI players, it\nseems. getName() is used with much success all over the codebase.","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/7f03dc70854f7fe92bd1d237a44521d84c9fcc73"},{"sha":"244d9ef5ffad79397bbd90138aaf375a1872ef13","author":{"name":"ilteroi","email":"5f69beaa4c83cbbda3c5aab10fdcdf1bb13dbead@web.de"},"message":"much improved fake rng (should have been obvious)\nother small tweaks","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/244d9ef5ffad79397bbd90138aaf375a1872ef13"},{"sha":"293f481bac247c83825bee8b0866f63f7af41353","author":{"name":"davenye","email":"c24cc3cd1a553e349b4b8fa26f021650311fb3b8@users.noreply.github.com"},"message":"Fix erroneous counter-offer notifications with AD\n\nPrevents getting a counter offer notification instead of a deal proposed\nnotification to self when making a human-human deal with Active\nDiplomacy active.","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/293f481bac247c83825bee8b0866f63f7af41353"},{"sha":"5e015beb7604b9d06c4824e141c31176a5a836e7","author":{"name":"davenye","email":"c24cc3cd1a553e349b4b8fa26f021650311fb3b8@users.noreply.github.com"},"message":"Fixed iteration over AD deal request notifications\n\nA couple of errors in CvDiplomacyRequests::CheckRemainingNotifications()\nwhich could result CTDs, the wrong details used in deal withdrawl\nnotifications, or deals could be skipped over. This is due to the\nerasing during processing which also assigns back to the iterator before\nit has finished using it. The iterator would then be pointing to the\nnext element, which could even be end(). Also the iterator essentially\nbeing incremented twice but would be processed on the next call to the\nfunction and not be a real problem in reality.","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/5e015beb7604b9d06c4824e141c31176a5a836e7"},{"sha":"809c4c6d0908f2dd210f090c4fb8dc449fe81dd7","author":{"name":"davenye","email":"c24cc3cd1a553e349b4b8fa26f021650311fb3b8@users.noreply.github.com"},"message":"Fixed issue with AD deal request withdrawl logic\n\nLooks like a bool was named incorrectly, leading to some inverted logic.\nThe bug would cause valid deals being withdrawl by the AI and invalid\ndeals no withdrawn.\n\nThe bug had been addressed by the time I got around to submitting the fix but I am not sure if the fix that was checked in is the best solution since I thought it would result in bad deals being presented to the player.\n\nI have an upcoming pull request that does actually remove this condition but also implements logic to try to adjust the deal so that it is acceptable before presenting.","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/809c4c6d0908f2dd210f090c4fb8dc449fe81dd7"},{"sha":"9e73f8eb2c50e4952630d8ee294f4839bafe475f","author":{"name":"davenye","email":"c24cc3cd1a553e349b4b8fa26f021650311fb3b8@users.noreply.github.com"},"message":"Fixed blank names in AD deal withdrawn notes\n\nNow using getName() since nicknames are not populated for AI players, it\nseems. getName() is used with much success all over the codebase.","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/9e73f8eb2c50e4952630d8ee294f4839bafe475f"},{"sha":"3e0a2d23f7be3d94b907ba1bec49905d365e19d9","author":{"name":"davenye","email":"c24cc3cd1a553e349b4b8fa26f021650311fb3b8@users.noreply.github.com"},"message":"bypass Acitve Diplomacy FinalizeDeal code for human-human deals\n\nAt least after my other changes (possibly before also) there were errors in the failed AI diplomacy logs about human to human deals. Just skipping the Active Diplomacy code again for human-human deals seems to fix the issue and not cause any more either.\n\nDidn't investigate much do due the history of similar problems.","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/3e0a2d23f7be3d94b907ba1bec49905d365e19d9"},{"sha":"857a2cf1e28fbb6f01e2c7b31ac5b549ecb0ee7c","author":{"name":"davenye","email":"c24cc3cd1a553e349b4b8fa26f021650311fb3b8@users.noreply.github.com"},"message":"Fix lack of human-human deal notifications with AD\n\nDeal proposed notifications for human to human deals were getting\nswallowed up by Active Diplomacy code when active, meaning the recipient\ndid not know they had deals waiting.\n\nNot sure why the original code was the way it was and\nmaybe I don't understand the problem properly.","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/857a2cf1e28fbb6f01e2c7b31ac5b549ecb0ee7c"},{"sha":"ac1a9e1ab83346f4d461e8e947c6af9793a0e519","author":{"name":"davenye","email":"c24cc3cd1a553e349b4b8fa26f021650311fb3b8@users.noreply.github.com"},"message":"Merge branch 'pull/fix/ad_deal_req_withdrawl_logic' into pull/fix/ad_jit_deal_modification","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/ac1a9e1ab83346f4d461e8e947c6af9793a0e519"},{"sha":"3b90fd7f6ee5476b48700f4f26fad511a9bfa0c9","author":{"name":"davenye","email":"c24cc3cd1a553e349b4b8fa26f021650311fb3b8@users.noreply.github.com"},"message":"Merge branch 'pull/fix/ad_deal_withdrawl_blank_name' into pull/fix/ad_jit_deal_modification","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/3b90fd7f6ee5476b48700f4f26fad511a9bfa0c9"},{"sha":"bb1ad3f61aceec0e2c0a3113684648b1e35a527f","author":{"name":"davenye","email":"c24cc3cd1a553e349b4b8fa26f021650311fb3b8@users.noreply.github.com"},"message":"Add in chance to equalize AD deal before opening\n\nCached peace value wrecking havoc with AD deals (well vice versa, I\nguess). Now AI will check the deal just before notification is activated\nby human and attempt to equalize it. Unacceptable deals will no longer\nbe removed just after other deals have finished activation, as a\nsupporting change.","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/bb1ad3f61aceec0e2c0a3113684648b1e35a527f"},{"sha":"38ff19f0513b5b3f262c6a12a7f23b18d55d32c1","author":{"name":"davenye","email":"c24cc3cd1a553e349b4b8fa26f021650311fb3b8@users.noreply.github.com"},"message":"Merge pull request #4187 from davenye/pull/fix/ad_deal_req_withdrawl_logic\n\nMerged to mp_bugfixes branch.","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/38ff19f0513b5b3f262c6a12a7f23b18d55d32c1"},{"sha":"d8e63a9b32e1ca6e7d84a20bc783935c69663218","author":{"name":"davenye","email":"c24cc3cd1a553e349b4b8fa26f021650311fb3b8@users.noreply.github.com"},"message":"Merge pull request #4188 from davenye/pull/fix/ad_deal_req_iteration\n\nMerged to mp_bugfixes branch.","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/d8e63a9b32e1ca6e7d84a20bc783935c69663218"},{"sha":"4f77d9c3bdadbc42651cc7d48b5ee285d37bf6b1","author":{"name":"davenye","email":"c24cc3cd1a553e349b4b8fa26f021650311fb3b8@users.noreply.github.com"},"message":"Merge pull request #4189 from davenye/fix/ad_deal_withdrawl_blank_name\n\nFixed blank names in AD deal withdrawn notes","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/4f77d9c3bdadbc42651cc7d48b5ee285d37bf6b1"},{"sha":"92576a7a02f86d0f9fa61a5366a858d02aef6c36","author":{"name":"davenye","email":"c24cc3cd1a553e349b4b8fa26f021650311fb3b8@users.noreply.github.com"},"message":"Merge pull request #4190 from davenye/pull/fix/ad_counter_offer_notifications\n\nFix erroneous counter-offer notifications with Active Diplomacy","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/92576a7a02f86d0f9fa61a5366a858d02aef6c36"},{"sha":"e62dfae5c4c2259bf0593dbb18da4a23d28aeabf","author":{"name":"davenye","email":"c24cc3cd1a553e349b4b8fa26f021650311fb3b8@users.noreply.github.com"},"message":"Merge pull request #4191 from davenye/pull/fix/ad_human_human_deal_proposed_notifications\n\nFix lack of human-human deal notifications with Active Diplomacy","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/e62dfae5c4c2259bf0593dbb18da4a23d28aeabf"},{"sha":"a5091c2e1cd832a89b169c0e186afb301ec6086a","author":{"name":"davenye","email":"c24cc3cd1a553e349b4b8fa26f021650311fb3b8@users.noreply.github.com"},"message":"Merge pull request #4192 from davenye/pull/fix/ad_erroneous_failed_deal_logs\n\nbypass Acitve Diplomacy FinalizeDeal code for human-human deals\r\n\r\nAt least after my other changes (possibly before also) there were errors in the failed AI diplomacy logs about human to human deals. Just skipping the Active Diplomacy code again for human-human deals seems to fix the issue and not cause any more either.\r\n\r\nDidn't investigate much do due the history of similar problems.","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/a5091c2e1cd832a89b169c0e186afb301ec6086a"},{"sha":"de2dc8be3f022f890b7fb6a08dfe33fa2626747f","author":{"name":"davenye","email":"c24cc3cd1a553e349b4b8fa26f021650311fb3b8@users.noreply.github.com"},"message":"Merge pull request #4193 from davenye/pull/fix/ad_jit_deal_modification\n\nActive Diplomacy JIT deal modification\r\n\r\nAdd in chance to equalize Active Diplomacy deal before opening\r\n\r\nCached peace value wrecking havoc with AD deals (well vice versa, I\r\nguess). Now AI will check the deal just before notification is activated\r\nby human and attempt to equalize it. Unacceptable deals will no longer\r\nbe removed just after other deals have finished activation, as a\r\nsupporting change.","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/de2dc8be3f022f890b7fb6a08dfe33fa2626747f"},{"sha":"33e93991347879477b2af1da8b779b21892b787a","author":{"name":"ilteroi","email":"5f69beaa4c83cbbda3c5aab10fdcdf1bb13dbead@web.de"},"message":"Merge remote-tracking branch 'remotes/origin/master' into shiny","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/33e93991347879477b2af1da8b779b21892b787a"},{"sha":"cc98a9431844968dea866f9aa4f9c47a8b0ccbbe","author":{"name":"Infixo","email":"93c0d9b859f003ec24034b71bbf8e2260485855d@gmail.com"},"message":"Fixes for #4220 and #4222\n\nFixes for #4220 and #4222","distinct":false,"url":"https://api.github.com/repos/Infixo/Community-Patch-DLL/commits/cc98a9431844968dea866f9aa4f9c47a8b0ccbbe"}]}
{"actor":{"display_login":"Infixo"}}