{"push_id":3135317985,"size":11,"distinct_size":0,"ref":"refs/heads/lkgr-android-internal","head":"57e7834a27d40cf0ee6df24c7751451a2d0fc1df","before":"419c4bfbfb94849ed30dcab7c3aaf67afe238b27","commits":[{"sha":"269ecd52bd4e0ec15a70924b089589f9bfe26ee0","author":{"name":"Fredrik Söderquist","email":"3f4bb586f04a0c1d93eadab9363a8a3183b4860c@opera.com"},"message":"Return used width/height for SVG <image>, <rect> and <foreignObject>\n\nPer https://drafts.csswg.org/cssom/#resolved-values we should return the\n\"used value\" for 'width' and 'height' on these elements [1].\nThis behavior was clarified in SVGWG GitHub issue #349 [2].\n\n[1] And also on <svg>, but we don't support those properties there yet.\n    Tests added for that case too though.\n[2] https://github.com/w3c/svgwg/issues/349\n\nBug: 772707\nChange-Id: Ic7b6b148883d4380daadb41b62bddd02da55e1af\nReviewed-on: https://chromium-review.googlesource.com/c/1374291\nReviewed-by: Philip Rogers <pdr@chromium.org>\nCommit-Queue: Fredrik Söderquist <fs@opera.com>\nCr-Commit-Position: refs/heads/master@{#616343}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/269ecd52bd4e0ec15a70924b089589f9bfe26ee0"},{"sha":"98f527a731ae837efe3012f14574a696dee54827","author":{"name":"edchin","email":"356d0f6616a794c32c1c41860a7add0083666ffc@chromium.org"},"message":"[ios] Remove WKWebViewSnapshots experiment\n\nWKWebViewSnapshots experiment is enabled so it can be removed.\n\nBug: 885003\nChange-Id: Ieb3089daee53b336871558e3f71abb0a9b4fed05\nReviewed-on: https://chromium-review.googlesource.com/c/1375615\nReviewed-by: edchin <edchin@chromium.org>\nReviewed-by: Mark Cogan <marq@chromium.org>\nCommit-Queue: edchin <edchin@chromium.org>\nCr-Commit-Position: refs/heads/master@{#616344}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/98f527a731ae837efe3012f14574a696dee54827"},{"sha":"aad9192cd1ede7508716e4c9f9d5df0699d93a0e","author":{"name":"erikchen","email":"b51d12b71fa2f8cb17021720ad5ee62fe09eb9e9@chromium.org"},"message":"macOS: Make cmd+<numkey> always trigger as a numerical key.\n\nOn all keyboards, treat cmd + <number key> as the equivalent numerical key. This\nis technically incorrect, since the actual character produced may not be a\nnumerical key, but this causes Chrome to match the expectations of users.\n\nThis mostly reverts Chrome to its historical behavior [and to match Safari],\nexcept for the Dvorak-Left and Dvorak-Right layouts, which used to have the\nopposite behavior.\n\nBug: 898638\nChange-Id: Ia011def220a0e6b90f080aa3259751949f3dfc5f\nReviewed-on: https://chromium-review.googlesource.com/c/1372349\nCommit-Queue: Erik Chen <erikchen@chromium.org>\nReviewed-by: Nico Weber <thakis@chromium.org>\nCr-Commit-Position: refs/heads/master@{#616345}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/aad9192cd1ede7508716e4c9f9d5df0699d93a0e"},{"sha":"ecde845099001740fee119a82d45664e622d0ade","author":{"name":"Xiyuan Xia","email":"db97f61d07c31fd69698b8602ab9b0e934f96b23@chromium.org"},"message":"wm: Update nested activation handling\n\n- NOTREACHED() and no-ope if the nested activation wants to change\n  to a different active window other than the one being activated;\n- Allow focus shift in nested activations as long as they don't\n  change the window to be activated\n\nBug: 908524\nTest: FocusControllerApiTest.ActivateWhileActivating\nChange-Id: I105c85bf2671c7e396fdcbedff7b8082f007f642\nReviewed-on: https://chromium-review.googlesource.com/c/1357017\nReviewed-by: Scott Violet <sky@chromium.org>\nReviewed-by: Mitsuru Oshima (gardener - slow) <oshima@chromium.org>\nCommit-Queue: Xiyuan Xia <xiyuan@chromium.org>\nCr-Commit-Position: refs/heads/master@{#616346}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/ecde845099001740fee119a82d45664e622d0ade"},{"sha":"971548cdca2d4c0a6fedd3db0c94372c2a27eac3","author":{"name":"Guido Urdaneta","email":"b320b46c13883733ef16ffb1e2d57504fa255ae4@chromium.org"},"message":"Make MediaStreamDispatcherHost per-request instead of per-frame.\n\nInstead of having RenderFrameHost own a single MSDH to handle all\nrequests from a frame, MSDH objects will be owned by a strong binding.\n\nA consequence of this is that an additional requester ID is added to\nrequests to MediaStreamManager, so that an MSDH is able to cancel only\nrequests generated by it.\n\nIn practice, MSDH will continue to be per frame in most cases since\neach frame normally makes a single request for an MSDH object.\n\nThis fixes a lifetime issue caused by the IO thread executing tasks\nafter the RenderFrameHost dies.\n\nDrive-by: Fix some minor lint issues.\n\nBug: 912520\nChange-Id: I52742ffc98b9fc57ce8e6f5093a61aed86d3e516\nReviewed-on: https://chromium-review.googlesource.com/c/1369799\nReviewed-by: Emircan Uysaler <emircan@chromium.org>\nReviewed-by: Ken Buchanan <kenrb@chromium.org>\nReviewed-by: Olga Sharonova <olka@chromium.org>\nCommit-Queue: Guido Urdaneta <guidou@chromium.org>\nCr-Commit-Position: refs/heads/master@{#616347}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/971548cdca2d4c0a6fedd3db0c94372c2a27eac3"},{"sha":"be41fab665818d4184f70143c39f6caed80364fc","author":{"name":"Javier Ernesto Flores Robles","email":"1bdfa27212cc321f950fafb6ef91d6e87f0bdd56@chromium.org"},"message":"Revert \"[ios] Store TaskRunners instead of threads in WebThreadImpl.\"\n\nThis reverts commit 3d3f6bf113b71a9d0d2a259152581a5d65f76a22.\n\nReason for revert: This broke ios_chrome_unittest, more info in \ncrbug.com/914869\n\nOriginal change's description:\n> [ios] Store TaskRunners instead of threads in WebThreadImpl.\n> \n> Track thread states explicitly instead of simply checking\n> whether a TaskRunner pointer exists or not.\n> \n> BUG=826465\n> \n> Change-Id: Id0f84e7eedc6b9f6568aec629abbb86f46979efa\n> Reviewed-on: https://chromium-review.googlesource.com/c/1340827\n> Reviewed-by: Rohit Rao <rohitrao@chromium.org>\n> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>\n> Reviewed-by: Gabriel Charette <gab@chromium.org>\n> Commit-Queue: Rohit Rao <rohitrao@chromium.org>\n> Cr-Commit-Position: refs/heads/master@{#616319}\n\nTBR=rohitrao@chromium.org,gab@chromium.org,sdefresne@chromium.org\n\nChange-Id: I1297465d60f4b3b5a76882b5e723080c9376a7dc\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 826465\nReviewed-on: https://chromium-review.googlesource.com/c/1375890\nReviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>\nCommit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>\nCr-Commit-Position: refs/heads/master@{#616348}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/be41fab665818d4184f70143c39f6caed80364fc"},{"sha":"ebc1d4a86e895b51e87f163b2b34a98a7325e866","author":{"name":"Clark DuVall","email":"1a9f0934a1345b5a164cf75f747ffe62a48d3776@chromium.org"},"message":"Revert \"Stop creating net::URLRequestContext in the browser process when network service is enabled.\"\n\nThis reverts commit 2864f69f22b4c9398a49f059b72b28f9bece8fc3.\n\nReason for revert: http://crbug.com/914724\n\nOriginal change's description:\n> Stop creating net::URLRequestContext in the browser process when network service is enabled.\n> \n> Bug: 837753\n> Change-Id: I479666949f8c552e964ab86420ef080db9010d06\n> Reviewed-on: https://chromium-review.googlesource.com/c/1367088\n> Commit-Queue: John Abd-El-Malek <jam@chromium.org>\n> Reviewed-by: Matt Menke <mmenke@chromium.org>\n> Cr-Commit-Position: refs/heads/master@{#615995}\n\nTBR=jam@chromium.org,mmenke@chromium.org\n\nChange-Id: I6506e560dea13058d0336e22c3fc4844ac57fa04\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 837753, 914724\nReviewed-on: https://chromium-review.googlesource.com/c/1376101\nReviewed-by: Clark DuVall <cduvall@chromium.org>\nCommit-Queue: Clark DuVall <cduvall@chromium.org>\nCr-Commit-Position: refs/heads/master@{#616349}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/ebc1d4a86e895b51e87f163b2b34a98a7325e866"},{"sha":"6a988bfbbdae7880bd3fba26f96c120600a76db5","author":{"name":"Elly Fong-Jones","email":"1693f95ea06ee6d7b2276cb599c3f4f33a951d9c@chromium.org"},"message":"Reland \"base: Don't keep running tasks after nested run loop quits on iOS\"\n\nThis reverts commit d0de086966fe7e05b6aa69d3ec69eedad2aa9e64.\n\nReason for revert: broke ios-simulator bots\n\nOriginal change's description:\n> Revert \"base: Don't keep running tasks after nested run loop quits on iOS\"\n> \n> This reverts commit 3ce69a991fd9ca03030738e324a1833c02462da0.\n> \n> Reason for revert:\n> Sheriff suspects this broke a handful of menu tests on macOS 10.12:\n> \n> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17564\n> \n> e.g.:\n> WebViewTest.TestContextMenu\n> \n> Original change's description:\n> > base: Don't keep running tasks after nested run loop quits on iOS\n> > \n> > The CoreFoundation message pump (MessagePumpCFRunLoop) scheduled an extra call\n> > to Delegate::DoWork in the following scenario:\n> > \n> >   1. Start a run loop and schedule DoWork.\n> >   2. In DoWork, start a second run nested run loop which quits immediately.\n> >   3. After the nested run loop quits, schedule another DoWork which quits the\n> >      original run loop.\n> > \n> > After step #3, the message pump would call DoWork again because the nested\n> > run loop triggered the execution of the nesting deferred work source.\n> > \n> > This patch fixes the issue by checking whether the further work is allowed\n> > before calling DoWork. Note that this check can't be done just for the nested\n> > deferred work source, because in the flow above that source is what triggers\n> > the call to DoWork in step #3, i.e., the run loop hasn't quit yet at that point.\n> > \n> > The patch also includes a fix to\n> > WebContentsViewMacInteractiveTest.SelectMenuLifetime; the test had the\n> > following sequence in it (while a select menu is open):\n> > \n> >   1. Quit an outer run loop.\n> >   2. Post a task onto an inner run loop to continue the test.\n> > \n> > The assumption here was that a select menu causes an inner run loop to\n> > be active while the menu is open. This wasn't strictly correct: the\n> > inner run loop is a native (CoreFoundation) run loop as opposed to a\n> > base::RunLoop, which can't be explicitly exited with RunLoop::Quit().\n> > This means that the Quit() in step #1 affects the same run loop as the\n> > PostTask in step #2, i.e., the task is prevented from running.\n> > \n> > This patch changes the test to only quit the test run loop after the\n> > posted task (which closes the select menu) has run.\n> > \n> > Bug: 891670\n> > Change-Id: I6fe21289205664c4e1b1469547495667c753f56d\n> > Reviewed-on: https://chromium-review.googlesource.com/c/1373754\n> > Reviewed-by: Mark Mentovai <mark@chromium.org>\n> > Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>\n> > Cr-Commit-Position: refs/heads/master@{#615967}\n> \n> TBR=skyostil@chromium.org,mark@chromium.org\n> \n> Change-Id: If6e3b032ae40a391df56b62ae78f0bc1ed8d93f6\n> No-Presubmit: true\n> No-Tree-Checks: true\n> No-Try: true\n> Bug: 891670\n> Reviewed-on: https://chromium-review.googlesource.com/c/1375382\n> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>\n> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>\n> Cr-Commit-Position: refs/heads/master@{#616297}\n\nTBR=ellyjones@chromium.org,skyostil@chromium.org,mark@chromium.org\n\nChange-Id: I68d7b4687fd1f2a4906961f55b31038199089ff3\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 891670\nReviewed-on: https://chromium-review.googlesource.com/c/1376249\nReviewed-by: Elly Fong-Jones <ellyjones@chromium.org>\nCommit-Queue: Elly Fong-Jones <ellyjones@chromium.org>\nCr-Commit-Position: refs/heads/master@{#616350}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/6a988bfbbdae7880bd3fba26f96c120600a76db5"},{"sha":"c2844308876309ec17a9a607ac0e4e41538c1396","author":{"name":"Jan Krcal","email":"93237df08813c25e1a581e7e2c8cf6e31c2a1037@chromium.org"},"message":"[AF] Adapt sync wallet bridge to the new wallet_metadata bridge\n\nThis CL makes the wallet_data bridge NOT write wallet metadata into the\nDB if metadata is handled by the new USS bridge. This CL is part of a\nnew design for splitting responsibilities between the two bridges.\n\nBug: 853688\nChange-Id: Ib9299af8c1440fbf911d2a9ebe3cfa069bc29853\nReviewed-on: https://chromium-review.googlesource.com/c/1375728\nReviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>\nCommit-Queue: Jan Krcal <jkrcal@chromium.org>\nCr-Commit-Position: refs/heads/master@{#616351}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/c2844308876309ec17a9a607ac0e4e41538c1396"},{"sha":"5f534197944cdb2e4947e9aca7ceaee68ee3608d","author":{"name":"Elly Fong-Jones","email":"1693f95ea06ee6d7b2276cb599c3f4f33a951d9c@chromium.org"},"message":"Revert \"Reland \"base: Don't keep running tasks after nested run loop quits on iOS\"\"\n\nThis reverts commit 6a988bfbbdae7880bd3fba26f96c120600a76db5.\n\nReason for revert: should not have relanded\n\nOriginal change's description:\n> Reland \"base: Don't keep running tasks after nested run loop quits on iOS\"\n> \n> This reverts commit d0de086966fe7e05b6aa69d3ec69eedad2aa9e64.\n> \n> Reason for revert: broke ios-simulator bots\n> \n> Original change's description:\n> > Revert \"base: Don't keep running tasks after nested run loop quits on iOS\"\n> > \n> > This reverts commit 3ce69a991fd9ca03030738e324a1833c02462da0.\n> > \n> > Reason for revert:\n> > Sheriff suspects this broke a handful of menu tests on macOS 10.12:\n> > \n> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/17564\n> > \n> > e.g.:\n> > WebViewTest.TestContextMenu\n> > \n> > Original change's description:\n> > > base: Don't keep running tasks after nested run loop quits on iOS\n> > > \n> > > The CoreFoundation message pump (MessagePumpCFRunLoop) scheduled an extra call\n> > > to Delegate::DoWork in the following scenario:\n> > > \n> > >   1. Start a run loop and schedule DoWork.\n> > >   2. In DoWork, start a second run nested run loop which quits immediately.\n> > >   3. After the nested run loop quits, schedule another DoWork which quits the\n> > >      original run loop.\n> > > \n> > > After step #3, the message pump would call DoWork again because the nested\n> > > run loop triggered the execution of the nesting deferred work source.\n> > > \n> > > This patch fixes the issue by checking whether the further work is allowed\n> > > before calling DoWork. Note that this check can't be done just for the nested\n> > > deferred work source, because in the flow above that source is what triggers\n> > > the call to DoWork in step #3, i.e., the run loop hasn't quit yet at that point.\n> > > \n> > > The patch also includes a fix to\n> > > WebContentsViewMacInteractiveTest.SelectMenuLifetime; the test had the\n> > > following sequence in it (while a select menu is open):\n> > > \n> > >   1. Quit an outer run loop.\n> > >   2. Post a task onto an inner run loop to continue the test.\n> > > \n> > > The assumption here was that a select menu causes an inner run loop to\n> > > be active while the menu is open. This wasn't strictly correct: the\n> > > inner run loop is a native (CoreFoundation) run loop as opposed to a\n> > > base::RunLoop, which can't be explicitly exited with RunLoop::Quit().\n> > > This means that the Quit() in step #1 affects the same run loop as the\n> > > PostTask in step #2, i.e., the task is prevented from running.\n> > > \n> > > This patch changes the test to only quit the test run loop after the\n> > > posted task (which closes the select menu) has run.\n> > > \n> > > Bug: 891670\n> > > Change-Id: I6fe21289205664c4e1b1469547495667c753f56d\n> > > Reviewed-on: https://chromium-review.googlesource.com/c/1373754\n> > > Reviewed-by: Mark Mentovai <mark@chromium.org>\n> > > Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>\n> > > Cr-Commit-Position: refs/heads/master@{#615967}\n> > \n> > TBR=skyostil@chromium.org,mark@chromium.org\n> > \n> > Change-Id: If6e3b032ae40a391df56b62ae78f0bc1ed8d93f6\n> > No-Presubmit: true\n> > No-Tree-Checks: true\n> > No-Try: true\n> > Bug: 891670\n> > Reviewed-on: https://chromium-review.googlesource.com/c/1375382\n> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>\n> > Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>\n> > Cr-Commit-Position: refs/heads/master@{#616297}\n> \n> TBR=ellyjones@chromium.org,skyostil@chromium.org,mark@chromium.org\n> \n> Change-Id: I68d7b4687fd1f2a4906961f55b31038199089ff3\n> No-Presubmit: true\n> No-Tree-Checks: true\n> No-Try: true\n> Bug: 891670\n> Reviewed-on: https://chromium-review.googlesource.com/c/1376249\n> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>\n> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>\n> Cr-Commit-Position: refs/heads/master@{#616350}\n\nTBR=ellyjones@chromium.org,skyostil@chromium.org,mark@chromium.org\n\nChange-Id: Ia05259cd2f2d60b41efdc7b73702da865680c1a3\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nBug: 891670\nReviewed-on: https://chromium-review.googlesource.com/c/1376250\nReviewed-by: Elly Fong-Jones <ellyjones@chromium.org>\nCommit-Queue: Elly Fong-Jones <ellyjones@chromium.org>\nCr-Commit-Position: refs/heads/master@{#616352}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/5f534197944cdb2e4947e9aca7ceaee68ee3608d"},{"sha":"57e7834a27d40cf0ee6df24c7751451a2d0fc1df","author":{"name":"Matt Reynolds","email":"b76023695866bfcce438e08be42afef2cff9c809@google.com"},"message":"Fix threading and ordering issues for vibration effects\n\nThis CL addresses a threading issue where the vibration effect completion\ncallback was called on the polling thread instead of the thread that\nrequested the effect. Now a SequencedTaskRunner is passed along with the\ncallback to ensure the callback is run on the correct thread.\n\nIt also addresses an ordering issue when effects are queued using\nPromises. Previously, if an effect completed successfully and triggered\nanother effect from its completion callback, the gamepad service would\nstill send a StopVibration command before starting the second effect. On\nmost gamepads, this is not noticeable due to the inertia of the vibration\nactuator. However, on devices with more responsive actuators it may cause\nshort hiccups in vibration playback.\n\nThis CL fixes the ordering issue by scheduling a StopVibration task to\noccur after all microtasks associated with the Promise callback are\ncompleted. The scheduled task will only stop vibration if no other\nvibration commands were sent to the actuator since the task was queued.\n\nBUG=801717\n\nChange-Id: I6507a409e6004bbe411210217b9873f29788ef7c\nReviewed-on: https://chromium-review.googlesource.com/c/1354483\nReviewed-by: Ovidio Henriquez <odejesush@chromium.org>\nCommit-Queue: Matt Reynolds <mattreynolds@chromium.org>\nCr-Commit-Position: refs/heads/master@{#616353}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/57e7834a27d40cf0ee6df24c7751451a2d0fc1df"}]}
{"actor":{"display_login":"aarongable"}}