{"action":"closed","number":21228,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/21228","id":193761692,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzYxNjky","html_url":"https://github.com/nodejs/node/pull/21228","diff_url":"https://github.com/nodejs/node/pull/21228.diff","patch_url":"https://github.com/nodejs/node/pull/21228.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/21228","number":21228,"state":"closed","locked":false,"title":"build: fix cctest build failure in Windows","user":{"login":"yhwang","id":1147320,"node_id":"MDQ6VXNlcjExNDczMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1147320?v=4","gravatar_id":"","url":"https://api.github.com/users/yhwang","html_url":"https://github.com/yhwang","followers_url":"https://api.github.com/users/yhwang/followers","following_url":"https://api.github.com/users/yhwang/following{/other_user}","gists_url":"https://api.github.com/users/yhwang/gists{/gist_id}","starred_url":"https://api.github.com/users/yhwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhwang/subscriptions","organizations_url":"https://api.github.com/users/yhwang/orgs","repos_url":"https://api.github.com/users/yhwang/repos","events_url":"https://api.github.com/users/yhwang/events{/privacy}","received_events_url":"https://api.github.com/users/yhwang/received_events","type":"User","site_admin":false},"body":"cctest needs to access some internal APIs in node core. Putting\r\nnode_lib_target_name as dependency would causes linking error when\r\nnode_lib is built as shared lib in Windows. The reason being is\r\nthose internal APIs don't have `__declspec(dllexport)`. For cctest\r\nwe still need to specify individual obj files and link them instead\r\nof node_lib. In Windows, changes of the dependencies in `libraries`\r\ntrigger the cctest to rebuild. However, in Linux platforms, it\r\ndoesn't work. Instead, need to put obj dependencies into `sources`.\r\n\r\nSigned-off-by: Yihong Wang <yh.wang@ibm.com>\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-06-09T06:32:23Z","updated_at":"2018-09-17T15:32:54Z","closed_at":"2018-09-17T15:32:54Z","merged_at":null,"merge_commit_sha":"91ae06736d99ae38b2f4df80416a52e90fd7e29a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"danbev","id":432351,"node_id":"MDQ6VXNlcjQzMjM1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/432351?v=4","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":754449534,"node_id":"MDU6TGFiZWw3NTQ0NDk1MzQ=","url":"https://api.github.com/repos/nodejs/node/labels/author%20ready","name":"author ready","color":"1eca26","default":false},{"id":171787391,"node_id":"MDU6TGFiZWwxNzE3ODczOTE=","url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420","default":false},{"id":287185809,"node_id":"MDU6TGFiZWwyODcxODU4MDk=","url":"https://api.github.com/repos/nodejs/node/labels/stalled","name":"stalled","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/21228/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/21228/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/21228/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/0ec2e1ddb5c607082412492b82dc1b8a7dbb27bc","head":{"label":"yhwang:fix-windows-undefined-symbols","ref":"fix-windows-undefined-symbols","sha":"0ec2e1ddb5c607082412492b82dc1b8a7dbb27bc","user":{"login":"yhwang","id":1147320,"node_id":"MDQ6VXNlcjExNDczMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1147320?v=4","gravatar_id":"","url":"https://api.github.com/users/yhwang","html_url":"https://github.com/yhwang","followers_url":"https://api.github.com/users/yhwang/followers","following_url":"https://api.github.com/users/yhwang/following{/other_user}","gists_url":"https://api.github.com/users/yhwang/gists{/gist_id}","starred_url":"https://api.github.com/users/yhwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhwang/subscriptions","organizations_url":"https://api.github.com/users/yhwang/orgs","repos_url":"https://api.github.com/users/yhwang/repos","events_url":"https://api.github.com/users/yhwang/events{/privacy}","received_events_url":"https://api.github.com/users/yhwang/received_events","type":"User","site_admin":false},"repo":{"id":91820174,"node_id":"MDEwOlJlcG9zaXRvcnk5MTgyMDE3NA==","name":"node","full_name":"yhwang/node","private":false,"owner":{"login":"yhwang","id":1147320,"node_id":"MDQ6VXNlcjExNDczMjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1147320?v=4","gravatar_id":"","url":"https://api.github.com/users/yhwang","html_url":"https://github.com/yhwang","followers_url":"https://api.github.com/users/yhwang/followers","following_url":"https://api.github.com/users/yhwang/following{/other_user}","gists_url":"https://api.github.com/users/yhwang/gists{/gist_id}","starred_url":"https://api.github.com/users/yhwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yhwang/subscriptions","organizations_url":"https://api.github.com/users/yhwang/orgs","repos_url":"https://api.github.com/users/yhwang/repos","events_url":"https://api.github.com/users/yhwang/events{/privacy}","received_events_url":"https://api.github.com/users/yhwang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yhwang/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/yhwang/node","forks_url":"https://api.github.com/repos/yhwang/node/forks","keys_url":"https://api.github.com/repos/yhwang/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yhwang/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yhwang/node/teams","hooks_url":"https://api.github.com/repos/yhwang/node/hooks","issue_events_url":"https://api.github.com/repos/yhwang/node/issues/events{/number}","events_url":"https://api.github.com/repos/yhwang/node/events","assignees_url":"https://api.github.com/repos/yhwang/node/assignees{/user}","branches_url":"https://api.github.com/repos/yhwang/node/branches{/branch}","tags_url":"https://api.github.com/repos/yhwang/node/tags","blobs_url":"https://api.github.com/repos/yhwang/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yhwang/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yhwang/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/yhwang/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yhwang/node/statuses/{sha}","languages_url":"https://api.github.com/repos/yhwang/node/languages","stargazers_url":"https://api.github.com/repos/yhwang/node/stargazers","contributors_url":"https://api.github.com/repos/yhwang/node/contributors","subscribers_url":"https://api.github.com/repos/yhwang/node/subscribers","subscription_url":"https://api.github.com/repos/yhwang/node/subscription","commits_url":"https://api.github.com/repos/yhwang/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/yhwang/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/yhwang/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/yhwang/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/yhwang/node/contents/{+path}","compare_url":"https://api.github.com/repos/yhwang/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yhwang/node/merges","archive_url":"https://api.github.com/repos/yhwang/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yhwang/node/downloads","issues_url":"https://api.github.com/repos/yhwang/node/issues{/number}","pulls_url":"https://api.github.com/repos/yhwang/node/pulls{/number}","milestones_url":"https://api.github.com/repos/yhwang/node/milestones{/number}","notifications_url":"https://api.github.com/repos/yhwang/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yhwang/node/labels{/name}","releases_url":"https://api.github.com/repos/yhwang/node/releases{/id}","deployments_url":"https://api.github.com/repos/yhwang/node/deployments","created_at":"2017-05-19T15:32:15Z","updated_at":"2018-08-14T00:19:18Z","pushed_at":"2018-08-14T00:19:10Z","git_url":"git://github.com/yhwang/node.git","ssh_url":"git@github.com:yhwang/node.git","clone_url":"https://github.com/yhwang/node.git","svn_url":"https://github.com/yhwang/node","homepage":"https://nodejs.org","size":376498,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"121439a8ff0cd5e41517b3032890d5dab90ea44b","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-09-17T15:26:00Z","pushed_at":"2018-09-17T15:32:52Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":413464,"stargazers_count":53409,"watchers_count":53409,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11380,"mirror_url":null,"archived":false,"open_issues_count":884,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11380,"open_issues":884,"watchers":53409,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/21228"},"html":{"href":"https://github.com/nodejs/node/pull/21228"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/21228"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/21228/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/21228/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/21228/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/0ec2e1ddb5c607082412492b82dc1b8a7dbb27bc"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":18,"review_comments":18,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"addaleax"}}