{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/205585582","pull_request_review_id":140888306,"id":205585582,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTU4NTU4Mg==","diff_hunk":"@@ -321,7 +328,11 @@ def test_apply_dics_timeseries():\n     filters = make_dics(evoked.info, fwd_surf, csd20, label=label, reg=reg)\n \n     # Sanity checks on the resulting STC after applying DICS on epochs.\n-    stcs = apply_dics_epochs(epochs, filters)\n+    # Also test whether stcs contain src\n+    with warnings.catch_warnings(record=True) as wrn:","path":"mne/beamformer/tests/test_dics.py","position":29,"original_position":29,"commit_id":"4a8721c42653fa2c3cabed2d5d3488e5bd8f5048","original_commit_id":"4a8721c42653fa2c3cabed2d5d3488e5bd8f5048","user":{"login":"britta-wstnr","id":20129119,"node_id":"MDQ6VXNlcjIwMTI5MTE5","avatar_url":"https://avatars0.githubusercontent.com/u/20129119?v=4","gravatar_id":"","url":"https://api.github.com/users/britta-wstnr","html_url":"https://github.com/britta-wstnr","followers_url":"https://api.github.com/users/britta-wstnr/followers","following_url":"https://api.github.com/users/britta-wstnr/following{/other_user}","gists_url":"https://api.github.com/users/britta-wstnr/gists{/gist_id}","starred_url":"https://api.github.com/users/britta-wstnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britta-wstnr/subscriptions","organizations_url":"https://api.github.com/users/britta-wstnr/orgs","repos_url":"https://api.github.com/users/britta-wstnr/repos","events_url":"https://api.github.com/users/britta-wstnr/events{/privacy}","received_events_url":"https://api.github.com/users/britta-wstnr/received_events","type":"User","site_admin":false},"body":"Yes - but: in this iteration now, the ``_make_stc`` call in the beamformer code requires ``src_type``. So if ``filters`` does not have it, it crashes. So I think we need to allow the function call without ``src_type`` still in ``apply_lcmv`` etc. - and then ``_make_stc`` subfunctions throw the warning about supplying ``stc``.","created_at":"2018-07-26T20:05:30Z","updated_at":"2018-07-26T20:05:30Z","html_url":"https://github.com/mne-tools/mne-python/pull/5317#discussion_r205585582","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5317","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/205585582"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/5317#discussion_r205585582"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/5317"}},"in_reply_to_id":204741884},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5317","id":199466538,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NDY2NTM4","html_url":"https://github.com/mne-tools/mne-python/pull/5317","diff_url":"https://github.com/mne-tools/mne-python/pull/5317.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/5317.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/5317","number":5317,"state":"open","locked":false,"title":"Use src to create stc in beamformer code","user":{"login":"britta-wstnr","id":20129119,"node_id":"MDQ6VXNlcjIwMTI5MTE5","avatar_url":"https://avatars0.githubusercontent.com/u/20129119?v=4","gravatar_id":"","url":"https://api.github.com/users/britta-wstnr","html_url":"https://github.com/britta-wstnr","followers_url":"https://api.github.com/users/britta-wstnr/followers","following_url":"https://api.github.com/users/britta-wstnr/following{/other_user}","gists_url":"https://api.github.com/users/britta-wstnr/gists{/gist_id}","starred_url":"https://api.github.com/users/britta-wstnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britta-wstnr/subscriptions","organizations_url":"https://api.github.com/users/britta-wstnr/orgs","repos_url":"https://api.github.com/users/britta-wstnr/repos","events_url":"https://api.github.com/users/britta-wstnr/events{/privacy}","received_events_url":"https://api.github.com/users/britta-wstnr/received_events","type":"User","site_admin":false},"body":"Refers to https://github.com/mne-tools/mne-python/issues/5224 and https://github.com/mne-tools/mne-python/pull/5231 .\r\nUse ``src`` as input to  ``_make_stc`` in ``_lcmv`` and ``_dics``.\r\n\r\n@agramfort are these all that all the changes required here?","created_at":"2018-07-05T13:15:16Z","updated_at":"2018-07-26T20:05:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa4ec25d4f7df786031292aed4d978d09d7be872","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5317/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/5317/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/5317/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/4a8721c42653fa2c3cabed2d5d3488e5bd8f5048","head":{"label":"britta-wstnr:fix_stc","ref":"fix_stc","sha":"4a8721c42653fa2c3cabed2d5d3488e5bd8f5048","user":{"login":"britta-wstnr","id":20129119,"node_id":"MDQ6VXNlcjIwMTI5MTE5","avatar_url":"https://avatars0.githubusercontent.com/u/20129119?v=4","gravatar_id":"","url":"https://api.github.com/users/britta-wstnr","html_url":"https://github.com/britta-wstnr","followers_url":"https://api.github.com/users/britta-wstnr/followers","following_url":"https://api.github.com/users/britta-wstnr/following{/other_user}","gists_url":"https://api.github.com/users/britta-wstnr/gists{/gist_id}","starred_url":"https://api.github.com/users/britta-wstnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britta-wstnr/subscriptions","organizations_url":"https://api.github.com/users/britta-wstnr/orgs","repos_url":"https://api.github.com/users/britta-wstnr/repos","events_url":"https://api.github.com/users/britta-wstnr/events{/privacy}","received_events_url":"https://api.github.com/users/britta-wstnr/received_events","type":"User","site_admin":false},"repo":{"id":86345521,"node_id":"MDEwOlJlcG9zaXRvcnk4NjM0NTUyMQ==","name":"mne-python","full_name":"britta-wstnr/mne-python","owner":{"login":"britta-wstnr","id":20129119,"node_id":"MDQ6VXNlcjIwMTI5MTE5","avatar_url":"https://avatars0.githubusercontent.com/u/20129119?v=4","gravatar_id":"","url":"https://api.github.com/users/britta-wstnr","html_url":"https://github.com/britta-wstnr","followers_url":"https://api.github.com/users/britta-wstnr/followers","following_url":"https://api.github.com/users/britta-wstnr/following{/other_user}","gists_url":"https://api.github.com/users/britta-wstnr/gists{/gist_id}","starred_url":"https://api.github.com/users/britta-wstnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/britta-wstnr/subscriptions","organizations_url":"https://api.github.com/users/britta-wstnr/orgs","repos_url":"https://api.github.com/users/britta-wstnr/repos","events_url":"https://api.github.com/users/britta-wstnr/events{/privacy}","received_events_url":"https://api.github.com/users/britta-wstnr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/britta-wstnr/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/britta-wstnr/mne-python","forks_url":"https://api.github.com/repos/britta-wstnr/mne-python/forks","keys_url":"https://api.github.com/repos/britta-wstnr/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/britta-wstnr/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/britta-wstnr/mne-python/teams","hooks_url":"https://api.github.com/repos/britta-wstnr/mne-python/hooks","issue_events_url":"https://api.github.com/repos/britta-wstnr/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/britta-wstnr/mne-python/events","assignees_url":"https://api.github.com/repos/britta-wstnr/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/britta-wstnr/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/britta-wstnr/mne-python/tags","blobs_url":"https://api.github.com/repos/britta-wstnr/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/britta-wstnr/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/britta-wstnr/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/britta-wstnr/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/britta-wstnr/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/britta-wstnr/mne-python/languages","stargazers_url":"https://api.github.com/repos/britta-wstnr/mne-python/stargazers","contributors_url":"https://api.github.com/repos/britta-wstnr/mne-python/contributors","subscribers_url":"https://api.github.com/repos/britta-wstnr/mne-python/subscribers","subscription_url":"https://api.github.com/repos/britta-wstnr/mne-python/subscription","commits_url":"https://api.github.com/repos/britta-wstnr/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/britta-wstnr/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/britta-wstnr/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/britta-wstnr/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/britta-wstnr/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/britta-wstnr/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/britta-wstnr/mne-python/merges","archive_url":"https://api.github.com/repos/britta-wstnr/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/britta-wstnr/mne-python/downloads","issues_url":"https://api.github.com/repos/britta-wstnr/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/britta-wstnr/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/britta-wstnr/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/britta-wstnr/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/britta-wstnr/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/britta-wstnr/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/britta-wstnr/mne-python/deployments","created_at":"2017-03-27T14:29:06Z","updated_at":"2017-03-27T14:29:11Z","pushed_at":"2018-07-24T10:05:51Z","git_url":"git://github.com/britta-wstnr/mne-python.git","ssh_url":"git@github.com:britta-wstnr/mne-python.git","clone_url":"https://github.com/britta-wstnr/mne-python.git","svn_url":"https://github.com/britta-wstnr/mne-python","homepage":"http://martinos.org/mne/","size":100325,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"f2fcc5aec08893f2b29502992d8a283b83027b15","user":{"login":"mne-tools","id":583875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4Mzg3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/583875?v=4","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAxNTg0","name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU4Mzg3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/583875?v=4","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/mne-tools/mne-python/deployments","created_at":"2011-01-28T03:31:13Z","updated_at":"2018-07-26T18:13:34Z","pushed_at":"2018-07-26T18:46:02Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":100318,"stargazers_count":556,"watchers_count":556,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":424,"mirror_url":null,"archived":false,"open_issues_count":262,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":424,"open_issues":262,"watchers":556,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/5317"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/5317"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/5317"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/5317/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/5317/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/5317/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/4a8721c42653fa2c3cabed2d5d3488e5bd8f5048"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"britta-wstnr"}}