{"action":"created","issue":{"url":"https://api.github.com/repos/dashpay/dash/issues/2149","repository_url":"https://api.github.com/repos/dashpay/dash","labels_url":"https://api.github.com/repos/dashpay/dash/issues/2149/labels{/name}","comments_url":"https://api.github.com/repos/dashpay/dash/issues/2149/comments","events_url":"https://api.github.com/repos/dashpay/dash/issues/2149/events","html_url":"https://github.com/dashpay/dash/pull/2149","id":335850501,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDQ1NDg4","number":2149,"title":"GetOutPointPrivateSendRounds readability","user":{"login":"PaulieD","id":6443210,"node_id":"MDQ6VXNlcjY0NDMyMTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6443210?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulieD","html_url":"https://github.com/PaulieD","followers_url":"https://api.github.com/users/PaulieD/followers","following_url":"https://api.github.com/users/PaulieD/following{/other_user}","gists_url":"https://api.github.com/users/PaulieD/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulieD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulieD/subscriptions","organizations_url":"https://api.github.com/users/PaulieD/orgs","repos_url":"https://api.github.com/users/PaulieD/repos","events_url":"https://api.github.com/users/PaulieD/events{/privacy}","received_events_url":"https://api.github.com/users/PaulieD/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-26T14:35:51Z","updated_at":"2018-06-26T15:27:13Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/dashpay/dash/pulls/2149","html_url":"https://github.com/dashpay/dash/pull/2149","diff_url":"https://github.com/dashpay/dash/pull/2149.diff","patch_url":"https://github.com/dashpay/dash/pull/2149.patch"},"body":"Makes it easier to read `GetOutPointPrivateSendRounds` as it will now not have a magic 0 as the second arg when being called externally. Since the second arg is only used for the recursive logic, this should work well.\r\n\r\nAlso includes an addition to the .gitnore for us weirdos who use visual studio... Don't judge me.\r\n\r\nSince none of this should affect functionality, this should be able to be merged whenever."},"comment":{"url":"https://api.github.com/repos/dashpay/dash/issues/comments/400351531","html_url":"https://github.com/dashpay/dash/pull/2149#issuecomment-400351531","issue_url":"https://api.github.com/repos/dashpay/dash/issues/2149","id":400351531,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDM1MTUzMQ==","user":{"login":"PaulieD","id":6443210,"node_id":"MDQ6VXNlcjY0NDMyMTA=","avatar_url":"https://avatars1.githubusercontent.com/u/6443210?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulieD","html_url":"https://github.com/PaulieD","followers_url":"https://api.github.com/users/PaulieD/followers","following_url":"https://api.github.com/users/PaulieD/following{/other_user}","gists_url":"https://api.github.com/users/PaulieD/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulieD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulieD/subscriptions","organizations_url":"https://api.github.com/users/PaulieD/orgs","repos_url":"https://api.github.com/users/PaulieD/repos","events_url":"https://api.github.com/users/PaulieD/events{/privacy}","received_events_url":"https://api.github.com/users/PaulieD/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T15:27:13Z","updated_at":"2018-06-26T15:27:13Z","author_association":"NONE","body":"Changed back comment, after rereading the old one is fine. fixed alignment, darn tabbing. \r\n\r\nI personally disagree with it not providing any value. When reading the code, it makes no sense for that zero to be there, and requires the reader to look into the function and figure out what that zero actually means, whereas it is clear why the output is there and what it does. Also, in regards to writing, it becomes quite possible to forget that the zero needs to be there, again wasting time. I personally messed that up in a prior PR because it doesn't intuitively make sense for the zero to be present."}}
{"actor":{"display_login":"PaulieD"}}