{"action":"created","comment":{"url":"https://api.github.com/repos/boto/botocore/pulls/comments/201059630","pull_request_review_id":135487390,"id":201059630,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTA1OTYzMA==","diff_hunk":"@@ -450,6 +471,92 @@ def prepare_body(self, data, files, json=None):\n                 if 'Transfer-Encoding' in self.headers:\n                     self.headers.pop('Transfer-Encoding')\n \n+        if self.body and 'Content-Length' not in self.headers:\n+            self.headers['Transfer-Encoding'] = 'chunked'\n+\n+\n+class AWSResponse(object):\n+\n+    def __init__(self, url=None, status_code=None, headers=None, raw=None):\n+        self.url = url\n+        self.status_code = status_code\n+        self.headers = HeadersDict(headers or {})\n+        self.raw = raw\n+\n+        self._content = None\n+\n+    @property\n+    def content(self):\n+        \"\"\"Content of the response, in bytes.\"\"\"\n+\n+        if self._content is None:\n+            # Read the contents.\n+            try:\n+                data_generator = self.raw.stream()\n+            except AttributeError:","path":"botocore/awsrequest.py","position":325,"original_position":325,"commit_id":"54bc45cafe9c4689d38b9431c96eefee097307c1","original_commit_id":"54bc45cafe9c4689d38b9431c96eefee097307c1","user":{"login":"jamesls","id":368057,"node_id":"MDQ6VXNlcjM2ODA1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/368057?v=4","gravatar_id":"","url":"https://api.github.com/users/jamesls","html_url":"https://github.com/jamesls","followers_url":"https://api.github.com/users/jamesls/followers","following_url":"https://api.github.com/users/jamesls/following{/other_user}","gists_url":"https://api.github.com/users/jamesls/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesls/subscriptions","organizations_url":"https://api.github.com/users/jamesls/orgs","repos_url":"https://api.github.com/users/jamesls/repos","events_url":"https://api.github.com/users/jamesls/events{/privacy}","received_events_url":"https://api.github.com/users/jamesls/received_events","type":"User","site_admin":false},"body":"Yeah I'd prefer to simplify and remove this fallback if our tests are the only thing relying on it.","created_at":"2018-07-09T16:08:24Z","updated_at":"2018-07-09T16:08:25Z","html_url":"https://github.com/boto/botocore/pull/1495#discussion_r201059630","pull_request_url":"https://api.github.com/repos/boto/botocore/pulls/1495","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/boto/botocore/pulls/comments/201059630"},"html":{"href":"https://github.com/boto/botocore/pull/1495#discussion_r201059630"},"pull_request":{"href":"https://api.github.com/repos/boto/botocore/pulls/1495"}},"in_reply_to_id":200775767},"pull_request":{"url":"https://api.github.com/repos/boto/botocore/pulls/1495","id":199111395,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MTExMzk1","html_url":"https://github.com/boto/botocore/pull/1495","diff_url":"https://github.com/boto/botocore/pull/1495.diff","patch_url":"https://github.com/boto/botocore/pull/1495.patch","issue_url":"https://api.github.com/repos/boto/botocore/issues/1495","number":1495,"state":"open","locked":false,"title":"Unvendor requests and use urllib3 directly","user":{"login":"joguSD","id":1935727,"node_id":"MDQ6VXNlcjE5MzU3Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1935727?v=4","gravatar_id":"","url":"https://api.github.com/users/joguSD","html_url":"https://github.com/joguSD","followers_url":"https://api.github.com/users/joguSD/followers","following_url":"https://api.github.com/users/joguSD/following{/other_user}","gists_url":"https://api.github.com/users/joguSD/gists{/gist_id}","starred_url":"https://api.github.com/users/joguSD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joguSD/subscriptions","organizations_url":"https://api.github.com/users/joguSD/orgs","repos_url":"https://api.github.com/users/joguSD/repos","events_url":"https://api.github.com/users/joguSD/events{/privacy}","received_events_url":"https://api.github.com/users/joguSD/received_events","type":"User","site_admin":false},"body":"This pull request begins to implement the changes discussed in https://github.com/boto/botocore/issues/1486\r\n\r\nThis builds on some of the work started in this PR: https://github.com/boto/botocore/pull/1466\r\n\r\nThe work is not yet done but this branch should largely be functional for the majority of use cases. In particular exception cases have been hard to verify, and there will be cases where different exceptions are now raised. This is an unavoidable consequence of moving away from our vendored dependencies. To continue building on this I would like to minimize dependency exception uses to single modules, and ensure that we don't leak exceptions from our dependencies to simplify both the exceptions generated from `botocore` and make it easier to verify `botocore`'s exception behavior.\r\n\r\nAdditionally, these changes impact our dependent packages `s3-transfer`, `boto3`, and `aws-cli` as all have references to our vendored dependencies (mostly exception classes). ","created_at":"2018-07-04T00:13:37Z","updated_at":"2018-07-09T16:08:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8df8af4df44721403491b7a388ebfc82f30261aa","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dstufft","id":145979,"node_id":"MDQ6VXNlcjE0NTk3OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/145979?v=4","gravatar_id":"","url":"https://api.github.com/users/dstufft","html_url":"https://github.com/dstufft","followers_url":"https://api.github.com/users/dstufft/followers","following_url":"https://api.github.com/users/dstufft/following{/other_user}","gists_url":"https://api.github.com/users/dstufft/gists{/gist_id}","starred_url":"https://api.github.com/users/dstufft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dstufft/subscriptions","organizations_url":"https://api.github.com/users/dstufft/orgs","repos_url":"https://api.github.com/users/dstufft/repos","events_url":"https://api.github.com/users/dstufft/events{/privacy}","received_events_url":"https://api.github.com/users/dstufft/received_events","type":"User","site_admin":false},{"login":"stealthycoin","id":1010634,"node_id":"MDQ6VXNlcjEwMTA2MzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1010634?v=4","gravatar_id":"","url":"https://api.github.com/users/stealthycoin","html_url":"https://github.com/stealthycoin","followers_url":"https://api.github.com/users/stealthycoin/followers","following_url":"https://api.github.com/users/stealthycoin/following{/other_user}","gists_url":"https://api.github.com/users/stealthycoin/gists{/gist_id}","starred_url":"https://api.github.com/users/stealthycoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stealthycoin/subscriptions","organizations_url":"https://api.github.com/users/stealthycoin/orgs","repos_url":"https://api.github.com/users/stealthycoin/repos","events_url":"https://api.github.com/users/stealthycoin/events{/privacy}","received_events_url":"https://api.github.com/users/stealthycoin/received_events","type":"User","site_admin":false},{"login":"JordonPhillips","id":2643092,"node_id":"MDQ6VXNlcjI2NDMwOTI=","avatar_url":"https://avatars2.githubusercontent.com/u/2643092?v=4","gravatar_id":"","url":"https://api.github.com/users/JordonPhillips","html_url":"https://github.com/JordonPhillips","followers_url":"https://api.github.com/users/JordonPhillips/followers","following_url":"https://api.github.com/users/JordonPhillips/following{/other_user}","gists_url":"https://api.github.com/users/JordonPhillips/gists{/gist_id}","starred_url":"https://api.github.com/users/JordonPhillips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JordonPhillips/subscriptions","organizations_url":"https://api.github.com/users/JordonPhillips/orgs","repos_url":"https://api.github.com/users/JordonPhillips/repos","events_url":"https://api.github.com/users/JordonPhillips/events{/privacy}","received_events_url":"https://api.github.com/users/JordonPhillips/received_events","type":"User","site_admin":false},{"login":"kyleknap","id":4605355,"node_id":"MDQ6VXNlcjQ2MDUzNTU=","avatar_url":"https://avatars0.githubusercontent.com/u/4605355?v=4","gravatar_id":"","url":"https://api.github.com/users/kyleknap","html_url":"https://github.com/kyleknap","followers_url":"https://api.github.com/users/kyleknap/followers","following_url":"https://api.github.com/users/kyleknap/following{/other_user}","gists_url":"https://api.github.com/users/kyleknap/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleknap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleknap/subscriptions","organizations_url":"https://api.github.com/users/kyleknap/orgs","repos_url":"https://api.github.com/users/kyleknap/repos","events_url":"https://api.github.com/users/kyleknap/events{/privacy}","received_events_url":"https://api.github.com/users/kyleknap/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":19177680,"node_id":"MDU6TGFiZWwxOTE3NzY4MA==","url":"https://api.github.com/repos/boto/botocore/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":691874220,"node_id":"MDU6TGFiZWw2OTE4NzQyMjA=","url":"https://api.github.com/repos/boto/botocore/labels/large","name":"large","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/boto/botocore/pulls/1495/commits","review_comments_url":"https://api.github.com/repos/boto/botocore/pulls/1495/comments","review_comment_url":"https://api.github.com/repos/boto/botocore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/boto/botocore/issues/1495/comments","statuses_url":"https://api.github.com/repos/boto/botocore/statuses/54bc45cafe9c4689d38b9431c96eefee097307c1","head":{"label":"joguSD:pluggable-endpoints","ref":"pluggable-endpoints","sha":"54bc45cafe9c4689d38b9431c96eefee097307c1","user":{"login":"joguSD","id":1935727,"node_id":"MDQ6VXNlcjE5MzU3Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1935727?v=4","gravatar_id":"","url":"https://api.github.com/users/joguSD","html_url":"https://github.com/joguSD","followers_url":"https://api.github.com/users/joguSD/followers","following_url":"https://api.github.com/users/joguSD/following{/other_user}","gists_url":"https://api.github.com/users/joguSD/gists{/gist_id}","starred_url":"https://api.github.com/users/joguSD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joguSD/subscriptions","organizations_url":"https://api.github.com/users/joguSD/orgs","repos_url":"https://api.github.com/users/joguSD/repos","events_url":"https://api.github.com/users/joguSD/events{/privacy}","received_events_url":"https://api.github.com/users/joguSD/received_events","type":"User","site_admin":false},"repo":{"id":97641116,"node_id":"MDEwOlJlcG9zaXRvcnk5NzY0MTExNg==","name":"botocore","full_name":"joguSD/botocore","owner":{"login":"joguSD","id":1935727,"node_id":"MDQ6VXNlcjE5MzU3Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/1935727?v=4","gravatar_id":"","url":"https://api.github.com/users/joguSD","html_url":"https://github.com/joguSD","followers_url":"https://api.github.com/users/joguSD/followers","following_url":"https://api.github.com/users/joguSD/following{/other_user}","gists_url":"https://api.github.com/users/joguSD/gists{/gist_id}","starred_url":"https://api.github.com/users/joguSD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joguSD/subscriptions","organizations_url":"https://api.github.com/users/joguSD/orgs","repos_url":"https://api.github.com/users/joguSD/repos","events_url":"https://api.github.com/users/joguSD/events{/privacy}","received_events_url":"https://api.github.com/users/joguSD/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joguSD/botocore","description":"The low-level, core functionality of boto 3.","fork":true,"url":"https://api.github.com/repos/joguSD/botocore","forks_url":"https://api.github.com/repos/joguSD/botocore/forks","keys_url":"https://api.github.com/repos/joguSD/botocore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joguSD/botocore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joguSD/botocore/teams","hooks_url":"https://api.github.com/repos/joguSD/botocore/hooks","issue_events_url":"https://api.github.com/repos/joguSD/botocore/issues/events{/number}","events_url":"https://api.github.com/repos/joguSD/botocore/events","assignees_url":"https://api.github.com/repos/joguSD/botocore/assignees{/user}","branches_url":"https://api.github.com/repos/joguSD/botocore/branches{/branch}","tags_url":"https://api.github.com/repos/joguSD/botocore/tags","blobs_url":"https://api.github.com/repos/joguSD/botocore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joguSD/botocore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joguSD/botocore/git/refs{/sha}","trees_url":"https://api.github.com/repos/joguSD/botocore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joguSD/botocore/statuses/{sha}","languages_url":"https://api.github.com/repos/joguSD/botocore/languages","stargazers_url":"https://api.github.com/repos/joguSD/botocore/stargazers","contributors_url":"https://api.github.com/repos/joguSD/botocore/contributors","subscribers_url":"https://api.github.com/repos/joguSD/botocore/subscribers","subscription_url":"https://api.github.com/repos/joguSD/botocore/subscription","commits_url":"https://api.github.com/repos/joguSD/botocore/commits{/sha}","git_commits_url":"https://api.github.com/repos/joguSD/botocore/git/commits{/sha}","comments_url":"https://api.github.com/repos/joguSD/botocore/comments{/number}","issue_comment_url":"https://api.github.com/repos/joguSD/botocore/issues/comments{/number}","contents_url":"https://api.github.com/repos/joguSD/botocore/contents/{+path}","compare_url":"https://api.github.com/repos/joguSD/botocore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joguSD/botocore/merges","archive_url":"https://api.github.com/repos/joguSD/botocore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joguSD/botocore/downloads","issues_url":"https://api.github.com/repos/joguSD/botocore/issues{/number}","pulls_url":"https://api.github.com/repos/joguSD/botocore/pulls{/number}","milestones_url":"https://api.github.com/repos/joguSD/botocore/milestones{/number}","notifications_url":"https://api.github.com/repos/joguSD/botocore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joguSD/botocore/labels{/name}","releases_url":"https://api.github.com/repos/joguSD/botocore/releases{/id}","deployments_url":"https://api.github.com/repos/joguSD/botocore/deployments","created_at":"2017-07-18T20:29:49Z","updated_at":"2018-07-03T17:31:54Z","pushed_at":"2018-07-06T19:10:07Z","git_url":"git://github.com/joguSD/botocore.git","ssh_url":"git@github.com:joguSD/botocore.git","clone_url":"https://github.com/joguSD/botocore.git","svn_url":"https://github.com/joguSD/botocore","homepage":null,"size":37980,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"boto:develop","ref":"develop","sha":"81a17343fd25e4711373afe31e9e599b924c9e53","user":{"login":"boto","id":327752,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzc1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/327752?v=4","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"repo":{"id":6670942,"node_id":"MDEwOlJlcG9zaXRvcnk2NjcwOTQy","name":"botocore","full_name":"boto/botocore","owner":{"login":"boto","id":327752,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzc1Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/327752?v=4","gravatar_id":"","url":"https://api.github.com/users/boto","html_url":"https://github.com/boto","followers_url":"https://api.github.com/users/boto/followers","following_url":"https://api.github.com/users/boto/following{/other_user}","gists_url":"https://api.github.com/users/boto/gists{/gist_id}","starred_url":"https://api.github.com/users/boto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boto/subscriptions","organizations_url":"https://api.github.com/users/boto/orgs","repos_url":"https://api.github.com/users/boto/repos","events_url":"https://api.github.com/users/boto/events{/privacy}","received_events_url":"https://api.github.com/users/boto/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boto/botocore","description":"The low-level, core functionality of boto 3.","fork":false,"url":"https://api.github.com/repos/boto/botocore","forks_url":"https://api.github.com/repos/boto/botocore/forks","keys_url":"https://api.github.com/repos/boto/botocore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boto/botocore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boto/botocore/teams","hooks_url":"https://api.github.com/repos/boto/botocore/hooks","issue_events_url":"https://api.github.com/repos/boto/botocore/issues/events{/number}","events_url":"https://api.github.com/repos/boto/botocore/events","assignees_url":"https://api.github.com/repos/boto/botocore/assignees{/user}","branches_url":"https://api.github.com/repos/boto/botocore/branches{/branch}","tags_url":"https://api.github.com/repos/boto/botocore/tags","blobs_url":"https://api.github.com/repos/boto/botocore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boto/botocore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boto/botocore/git/refs{/sha}","trees_url":"https://api.github.com/repos/boto/botocore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boto/botocore/statuses/{sha}","languages_url":"https://api.github.com/repos/boto/botocore/languages","stargazers_url":"https://api.github.com/repos/boto/botocore/stargazers","contributors_url":"https://api.github.com/repos/boto/botocore/contributors","subscribers_url":"https://api.github.com/repos/boto/botocore/subscribers","subscription_url":"https://api.github.com/repos/boto/botocore/subscription","commits_url":"https://api.github.com/repos/boto/botocore/commits{/sha}","git_commits_url":"https://api.github.com/repos/boto/botocore/git/commits{/sha}","comments_url":"https://api.github.com/repos/boto/botocore/comments{/number}","issue_comment_url":"https://api.github.com/repos/boto/botocore/issues/comments{/number}","contents_url":"https://api.github.com/repos/boto/botocore/contents/{+path}","compare_url":"https://api.github.com/repos/boto/botocore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boto/botocore/merges","archive_url":"https://api.github.com/repos/boto/botocore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boto/botocore/downloads","issues_url":"https://api.github.com/repos/boto/botocore/issues{/number}","pulls_url":"https://api.github.com/repos/boto/botocore/pulls{/number}","milestones_url":"https://api.github.com/repos/boto/botocore/milestones{/number}","notifications_url":"https://api.github.com/repos/boto/botocore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boto/botocore/labels{/name}","releases_url":"https://api.github.com/repos/boto/botocore/releases{/id}","deployments_url":"https://api.github.com/repos/boto/botocore/deployments","created_at":"2012-11-13T13:25:36Z","updated_at":"2018-07-09T14:34:44Z","pushed_at":"2018-07-06T19:10:08Z","git_url":"git://github.com/boto/botocore.git","ssh_url":"git@github.com:boto/botocore.git","clone_url":"https://github.com/boto/botocore.git","svn_url":"https://github.com/boto/botocore","homepage":null,"size":42019,"stargazers_count":485,"watchers_count":485,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":425,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":425,"open_issues":140,"watchers":485,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/boto/botocore/pulls/1495"},"html":{"href":"https://github.com/boto/botocore/pull/1495"},"issue":{"href":"https://api.github.com/repos/boto/botocore/issues/1495"},"comments":{"href":"https://api.github.com/repos/boto/botocore/issues/1495/comments"},"review_comments":{"href":"https://api.github.com/repos/boto/botocore/pulls/1495/comments"},"review_comment":{"href":"https://api.github.com/repos/boto/botocore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/boto/botocore/pulls/1495/commits"},"statuses":{"href":"https://api.github.com/repos/boto/botocore/statuses/54bc45cafe9c4689d38b9431c96eefee097307c1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jamesls"}}