{"action":"created","comment":{"url":"https://api.github.com/repos/Workiva/dependency_validator/pulls/comments/190762361","pull_request_review_id":123211049,"id":190762361,"diff_hunk":"@@ -22,6 +22,7 @@ final ArgParser argParser = new ArgParser()\n   ..addFlag('verbose', defaultsTo: false)\n   ..addOption('ignore', abbr: 'i', allowMultiple: true, splitCommas: true)\n   ..addOption('exclude-dir', abbr: 'x', allowMultiple: true, splitCommas: true)\n+  ..addFlag('fatal-pins', defaultsTo: true)","path":"bin/dependency_validator.dart","position":4,"original_position":4,"commit_id":"0104d04419c977173adf1ab396f30e82e3641b15","original_commit_id":"e9b06a3fc148f97f1d063486175a912bf8218d1e","user":{"login":"greglittlefield-wf","id":1713967,"avatar_url":"https://avatars0.githubusercontent.com/u/1713967?v=4","gravatar_id":"","url":"https://api.github.com/users/greglittlefield-wf","html_url":"https://github.com/greglittlefield-wf","followers_url":"https://api.github.com/users/greglittlefield-wf/followers","following_url":"https://api.github.com/users/greglittlefield-wf/following{/other_user}","gists_url":"https://api.github.com/users/greglittlefield-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/greglittlefield-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglittlefield-wf/subscriptions","organizations_url":"https://api.github.com/users/greglittlefield-wf/orgs","repos_url":"https://api.github.com/users/greglittlefield-wf/repos","events_url":"https://api.github.com/users/greglittlefield-wf/events{/privacy}","received_events_url":"https://api.github.com/users/greglittlefield-wf/received_events","type":"User","site_admin":false},"body":"I'm fine with that, so long as we do it soon, before consumers need to figure out how to use the flag. If it's going to take a while to get to, we should just stick a line in the README.","created_at":"2018-05-25T00:03:59Z","updated_at":"2018-05-25T00:04:00Z","html_url":"https://github.com/Workiva/dependency_validator/pull/27#discussion_r190762361","pull_request_url":"https://api.github.com/repos/Workiva/dependency_validator/pulls/27","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Workiva/dependency_validator/pulls/comments/190762361"},"html":{"href":"https://github.com/Workiva/dependency_validator/pull/27#discussion_r190762361"},"pull_request":{"href":"https://api.github.com/repos/Workiva/dependency_validator/pulls/27"}},"in_reply_to_id":190760503},"pull_request":{"url":"https://api.github.com/repos/Workiva/dependency_validator/pulls/27","id":189087612,"html_url":"https://github.com/Workiva/dependency_validator/pull/27","diff_url":"https://github.com/Workiva/dependency_validator/pull/27.diff","patch_url":"https://github.com/Workiva/dependency_validator/pull/27.patch","issue_url":"https://api.github.com/repos/Workiva/dependency_validator/issues/27","number":27,"state":"open","locked":false,"title":"AF-178 check for dep pins","user":{"login":"toddbeckman-wf","id":16763404,"avatar_url":"https://avatars3.githubusercontent.com/u/16763404?v=4","gravatar_id":"","url":"https://api.github.com/users/toddbeckman-wf","html_url":"https://github.com/toddbeckman-wf","followers_url":"https://api.github.com/users/toddbeckman-wf/followers","following_url":"https://api.github.com/users/toddbeckman-wf/following{/other_user}","gists_url":"https://api.github.com/users/toddbeckman-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/toddbeckman-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toddbeckman-wf/subscriptions","organizations_url":"https://api.github.com/users/toddbeckman-wf/orgs","repos_url":"https://api.github.com/users/toddbeckman-wf/repos","events_url":"https://api.github.com/users/toddbeckman-wf/events{/privacy}","received_events_url":"https://api.github.com/users/toddbeckman-wf/received_events","type":"User","site_admin":false},"body":"## Problem\r\n\r\nDependency pins are bad\r\n\r\n## Solution\r\n\r\nCheck for pins.\r\n\r\n## Testing\r\n\r\n- [ ] Change a dependency to a pin and run `pub run dependency_validator -i coverage,dartdoc,dart_style,_foo,foo,_bar,bar,foo1,foo_foo` (which is run by task-runner) and verify that `echo $?` returns 1.\r\n- [ ] Repeat with the `--no-fatal-pins` flag. You should still get a warning, but the return code is 0.\r\n\r\nExample pins:\r\n\r\n* `path: 1.4.2`\r\n* `args: '>=0.13.7 <=2.0.0'`\r\n* `args: '>=0.13.7 <2.0.1'`\r\n","created_at":"2018-05-18T17:22:53Z","updated_at":"2018-05-25T00:04:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16b97424c2b07b6382ab593cde5a6f95507f8a35","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":721851050,"url":"https://api.github.com/repos/Workiva/dependency_validator/labels/Merge%20Requirements%20Unmet","name":"Merge Requirements Unmet","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Workiva/dependency_validator/pulls/27/commits","review_comments_url":"https://api.github.com/repos/Workiva/dependency_validator/pulls/27/comments","review_comment_url":"https://api.github.com/repos/Workiva/dependency_validator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Workiva/dependency_validator/issues/27/comments","statuses_url":"https://api.github.com/repos/Workiva/dependency_validator/statuses/0104d04419c977173adf1ab396f30e82e3641b15","head":{"label":"Workiva:AF-178_check-for-dep-pins","ref":"AF-178_check-for-dep-pins","sha":"0104d04419c977173adf1ab396f30e82e3641b15","user":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":106869294,"name":"dependency_validator","full_name":"Workiva/dependency_validator","owner":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Workiva/dependency_validator","description":"A tool to help you find missing, under-promoted, over-promoted, and unused dependencies.","fork":false,"url":"https://api.github.com/repos/Workiva/dependency_validator","forks_url":"https://api.github.com/repos/Workiva/dependency_validator/forks","keys_url":"https://api.github.com/repos/Workiva/dependency_validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/dependency_validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/dependency_validator/teams","hooks_url":"https://api.github.com/repos/Workiva/dependency_validator/hooks","issue_events_url":"https://api.github.com/repos/Workiva/dependency_validator/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/dependency_validator/events","assignees_url":"https://api.github.com/repos/Workiva/dependency_validator/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/dependency_validator/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/dependency_validator/tags","blobs_url":"https://api.github.com/repos/Workiva/dependency_validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/dependency_validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/dependency_validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/dependency_validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/dependency_validator/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/dependency_validator/languages","stargazers_url":"https://api.github.com/repos/Workiva/dependency_validator/stargazers","contributors_url":"https://api.github.com/repos/Workiva/dependency_validator/contributors","subscribers_url":"https://api.github.com/repos/Workiva/dependency_validator/subscribers","subscription_url":"https://api.github.com/repos/Workiva/dependency_validator/subscription","commits_url":"https://api.github.com/repos/Workiva/dependency_validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/dependency_validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/dependency_validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/dependency_validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Workiva/dependency_validator/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/dependency_validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/dependency_validator/merges","archive_url":"https://api.github.com/repos/Workiva/dependency_validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/dependency_validator/downloads","issues_url":"https://api.github.com/repos/Workiva/dependency_validator/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/dependency_validator/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/dependency_validator/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/dependency_validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/dependency_validator/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/dependency_validator/releases{/id}","deployments_url":"https://api.github.com/repos/Workiva/dependency_validator/deployments","created_at":"2017-10-13T20:16:01Z","updated_at":"2018-05-22T16:22:08Z","pushed_at":"2018-05-24T23:57:33Z","git_url":"git://github.com/Workiva/dependency_validator.git","ssh_url":"git@github.com:Workiva/dependency_validator.git","clone_url":"https://github.com/Workiva/dependency_validator.git","svn_url":"https://github.com/Workiva/dependency_validator","homepage":"","size":95,"stargazers_count":11,"watchers_count":11,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5,"open_issues":6,"watchers":11,"default_branch":"master"}},"base":{"label":"Workiva:master","ref":"master","sha":"2eab834793266fcd311f9028e0f93b8f3f8d286c","user":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":106869294,"name":"dependency_validator","full_name":"Workiva/dependency_validator","owner":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Workiva/dependency_validator","description":"A tool to help you find missing, under-promoted, over-promoted, and unused dependencies.","fork":false,"url":"https://api.github.com/repos/Workiva/dependency_validator","forks_url":"https://api.github.com/repos/Workiva/dependency_validator/forks","keys_url":"https://api.github.com/repos/Workiva/dependency_validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/dependency_validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/dependency_validator/teams","hooks_url":"https://api.github.com/repos/Workiva/dependency_validator/hooks","issue_events_url":"https://api.github.com/repos/Workiva/dependency_validator/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/dependency_validator/events","assignees_url":"https://api.github.com/repos/Workiva/dependency_validator/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/dependency_validator/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/dependency_validator/tags","blobs_url":"https://api.github.com/repos/Workiva/dependency_validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/dependency_validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/dependency_validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/dependency_validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/dependency_validator/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/dependency_validator/languages","stargazers_url":"https://api.github.com/repos/Workiva/dependency_validator/stargazers","contributors_url":"https://api.github.com/repos/Workiva/dependency_validator/contributors","subscribers_url":"https://api.github.com/repos/Workiva/dependency_validator/subscribers","subscription_url":"https://api.github.com/repos/Workiva/dependency_validator/subscription","commits_url":"https://api.github.com/repos/Workiva/dependency_validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/dependency_validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/dependency_validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/dependency_validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Workiva/dependency_validator/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/dependency_validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/dependency_validator/merges","archive_url":"https://api.github.com/repos/Workiva/dependency_validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/dependency_validator/downloads","issues_url":"https://api.github.com/repos/Workiva/dependency_validator/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/dependency_validator/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/dependency_validator/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/dependency_validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/dependency_validator/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/dependency_validator/releases{/id}","deployments_url":"https://api.github.com/repos/Workiva/dependency_validator/deployments","created_at":"2017-10-13T20:16:01Z","updated_at":"2018-05-22T16:22:08Z","pushed_at":"2018-05-24T23:57:33Z","git_url":"git://github.com/Workiva/dependency_validator.git","ssh_url":"git@github.com:Workiva/dependency_validator.git","clone_url":"https://github.com/Workiva/dependency_validator.git","svn_url":"https://github.com/Workiva/dependency_validator","homepage":"","size":95,"stargazers_count":11,"watchers_count":11,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":5,"open_issues":6,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Workiva/dependency_validator/pulls/27"},"html":{"href":"https://github.com/Workiva/dependency_validator/pull/27"},"issue":{"href":"https://api.github.com/repos/Workiva/dependency_validator/issues/27"},"comments":{"href":"https://api.github.com/repos/Workiva/dependency_validator/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/Workiva/dependency_validator/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/Workiva/dependency_validator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Workiva/dependency_validator/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/Workiva/dependency_validator/statuses/0104d04419c977173adf1ab396f30e82e3641b15"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"greglittlefield-wf"}}