{"action":"closed","number":5798,"pull_request":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5798","id":184588313,"html_url":"https://github.com/salesagility/SuiteCRM/pull/5798","diff_url":"https://github.com/salesagility/SuiteCRM/pull/5798.diff","patch_url":"https://github.com/salesagility/SuiteCRM/pull/5798.patch","issue_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5798","number":5798,"state":"closed","locked":false,"title":"WIP: Feature/travis ci tests","user":{"login":"daniel-samson","id":12231216,"avatar_url":"https://avatars0.githubusercontent.com/u/12231216?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-samson","html_url":"https://github.com/daniel-samson","followers_url":"https://api.github.com/users/daniel-samson/followers","following_url":"https://api.github.com/users/daniel-samson/following{/other_user}","gists_url":"https://api.github.com/users/daniel-samson/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-samson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-samson/subscriptions","organizations_url":"https://api.github.com/users/daniel-samson/orgs","repos_url":"https://api.github.com/users/daniel-samson/repos","events_url":"https://api.github.com/users/daniel-samson/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-samson/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here unless your commit contains the issue number -->\r\nThis feature runs the install, api and acceptance tests inside travis.\r\n\r\nI have moved the redirection in the last step of the installer to use javascript instead of php. I have also fixed some of the php notices.\r\n\r\nThe deprecated notice in php 7.2 is something we need to spend more time on, as it in the core and our third party libraries. So we need to tackle this in separate pull request. I have removed create_function. each and list from the project\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n- Increases the chance of finding bugs\r\n\r\n## How To Test This\r\n<!--- Please describe in detail how to test your changes. -->\r\n- See travis log\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n### Final checklist\r\n<!--- Go over all the following points and check all the boxes that apply. --->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --->\r\n- [x] My code follows the code style of this project found [here](https://docs.suitecrm.com/community/contributing-code/coding-standards/).\r\n- [x] My change requires a change to the documentation.\r\n- [x] I have read the [**How to Contribute**](https://docs.suitecrm.com/community/contributing-code/) guidelines.\r\n\r\n<!--- Your pull request will be tested via Travis CI to automatically indicate that your changes do not prevent compilation. --->\r\n\r\n<!--- If it reports back that there are problems, you can log into the Travis system and check the log report for your pull request to see what the problem was. --->","created_at":"2018-04-27T10:51:04Z","updated_at":"2018-05-07T12:04:15Z","closed_at":"2018-05-07T12:04:15Z","merged_at":null,"merge_commit_sha":"14e5d7ae7c1516a894aaa8329c4cb85714f0451d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5798/commits","review_comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5798/comments","review_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5798/comments","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/04d2e4952f7bba0956c32861795c385643bc8332","head":{"label":"daniel-samson:feature/travis_ci_tests","ref":"feature/travis_ci_tests","sha":"04d2e4952f7bba0956c32861795c385643bc8332","user":{"login":"daniel-samson","id":12231216,"avatar_url":"https://avatars0.githubusercontent.com/u/12231216?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-samson","html_url":"https://github.com/daniel-samson","followers_url":"https://api.github.com/users/daniel-samson/followers","following_url":"https://api.github.com/users/daniel-samson/following{/other_user}","gists_url":"https://api.github.com/users/daniel-samson/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-samson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-samson/subscriptions","organizations_url":"https://api.github.com/users/daniel-samson/orgs","repos_url":"https://api.github.com/users/daniel-samson/repos","events_url":"https://api.github.com/users/daniel-samson/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-samson/received_events","type":"User","site_admin":false},"repo":{"id":46138130,"name":"SuiteCRM","full_name":"daniel-samson/SuiteCRM","owner":{"login":"daniel-samson","id":12231216,"avatar_url":"https://avatars0.githubusercontent.com/u/12231216?v=4","gravatar_id":"","url":"https://api.github.com/users/daniel-samson","html_url":"https://github.com/daniel-samson","followers_url":"https://api.github.com/users/daniel-samson/followers","following_url":"https://api.github.com/users/daniel-samson/following{/other_user}","gists_url":"https://api.github.com/users/daniel-samson/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-samson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-samson/subscriptions","organizations_url":"https://api.github.com/users/daniel-samson/orgs","repos_url":"https://api.github.com/users/daniel-samson/repos","events_url":"https://api.github.com/users/daniel-samson/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-samson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daniel-samson/SuiteCRM","description":"SuiteCRM - Open source CRM for the world","fork":true,"url":"https://api.github.com/repos/daniel-samson/SuiteCRM","forks_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/forks","keys_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/events","assignees_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/merges","archive_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/daniel-samson/SuiteCRM/deployments","created_at":"2015-11-13T17:53:25Z","updated_at":"2018-05-01T11:27:17Z","pushed_at":"2018-05-07T11:36:25Z","git_url":"git://github.com/daniel-samson/SuiteCRM.git","ssh_url":"git@github.com:daniel-samson/SuiteCRM.git","clone_url":"https://github.com/daniel-samson/SuiteCRM.git","svn_url":"https://github.com/daniel-samson/SuiteCRM","homepage":"http://www.suitecrm.com","size":90864,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"salesagility:hotfix","ref":"hotfix","sha":"0496d88e9a5696f2ab06e3395dcdd115d3c420c9","user":{"login":"salesagility","id":1450870,"avatar_url":"https://avatars1.githubusercontent.com/u/1450870?v=4","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"repo":{"id":13044600,"name":"SuiteCRM","full_name":"salesagility/SuiteCRM","owner":{"login":"salesagility","id":1450870,"avatar_url":"https://avatars1.githubusercontent.com/u/1450870?v=4","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salesagility/SuiteCRM","description":"SuiteCRM - Open source CRM for the world","fork":false,"url":"https://api.github.com/repos/salesagility/SuiteCRM","forks_url":"https://api.github.com/repos/salesagility/SuiteCRM/forks","keys_url":"https://api.github.com/repos/salesagility/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salesagility/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salesagility/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/salesagility/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/salesagility/SuiteCRM/events","assignees_url":"https://api.github.com/repos/salesagility/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/salesagility/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/salesagility/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/salesagility/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/salesagility/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/salesagility/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/salesagility/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salesagility/SuiteCRM/merges","archive_url":"https://api.github.com/repos/salesagility/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salesagility/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/salesagility/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/salesagility/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salesagility/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/salesagility/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/salesagility/SuiteCRM/deployments","created_at":"2013-09-23T19:10:08Z","updated_at":"2018-05-07T09:14:15Z","pushed_at":"2018-05-07T11:22:40Z","git_url":"git://github.com/salesagility/SuiteCRM.git","ssh_url":"git@github.com:salesagility/SuiteCRM.git","clone_url":"https://github.com/salesagility/SuiteCRM.git","svn_url":"https://github.com/salesagility/SuiteCRM","homepage":"http://www.suitecrm.com","size":91626,"stargazers_count":991,"watchers_count":991,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":787,"mirror_url":null,"archived":false,"open_issues_count":922,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":787,"open_issues":922,"watchers":991,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5798"},"html":{"href":"https://github.com/salesagility/SuiteCRM/pull/5798"},"issue":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5798"},"comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/5798/comments"},"review_comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5798/comments"},"review_comment":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/5798/commits"},"statuses":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/04d2e4952f7bba0956c32861795c385643bc8332"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"unstable","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":104,"additions":549,"deletions":242,"changed_files":52}}
{"actor":{"display_login":"daniel-samson"}}