{"action":"created","issue":{"url":"https://api.github.com/repos/handshake-org/hsd/issues/44","repository_url":"https://api.github.com/repos/handshake-org/hsd","labels_url":"https://api.github.com/repos/handshake-org/hsd/issues/44/labels{/name}","comments_url":"https://api.github.com/repos/handshake-org/hsd/issues/44/comments","events_url":"https://api.github.com/repos/handshake-org/hsd/issues/44/events","html_url":"https://github.com/handshake-org/hsd/pull/44","id":348644711,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2OTQ0MzYz","number":44,"title":"lib/node: use an address object in the coin address endpoint [bugfix]","user":{"login":"turbomaze","id":4857130,"node_id":"MDQ6VXNlcjQ4NTcxMzA=","avatar_url":"https://avatars1.githubusercontent.com/u/4857130?v=4","gravatar_id":"","url":"https://api.github.com/users/turbomaze","html_url":"https://github.com/turbomaze","followers_url":"https://api.github.com/users/turbomaze/followers","following_url":"https://api.github.com/users/turbomaze/following{/other_user}","gists_url":"https://api.github.com/users/turbomaze/gists{/gist_id}","starred_url":"https://api.github.com/users/turbomaze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turbomaze/subscriptions","organizations_url":"https://api.github.com/users/turbomaze/orgs","repos_url":"https://api.github.com/users/turbomaze/repos","events_url":"https://api.github.com/users/turbomaze/events{/privacy}","received_events_url":"https://api.github.com/users/turbomaze/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-08T09:25:09Z","updated_at":"2018-09-07T20:31:01Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/handshake-org/hsd/pulls/44","html_url":"https://github.com/handshake-org/hsd/pull/44","diff_url":"https://github.com/handshake-org/hsd/pull/44.diff","patch_url":"https://github.com/handshake-org/hsd/pull/44.patch"},"body":"The coin address endpoint at `./lib/node/http.js` passes an address string to `this.node.getCoinsByAddress(*)`, which eventually passes that same address to the mempool's `getCoinsByAddress(*)`. Attempting to query an address from the CLI or from CURL via `hsd-cli coin $ADDRESS` results in the error message `object is not an address`.\r\n\r\nThis PR creates an `Address` object after receiving the address string to fix this issue."},"comment":{"url":"https://api.github.com/repos/handshake-org/hsd/issues/comments/419557383","html_url":"https://github.com/handshake-org/hsd/pull/44#issuecomment-419557383","issue_url":"https://api.github.com/repos/handshake-org/hsd/issues/44","id":419557383,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTU1NzM4Mw==","user":{"login":"boymanjor","id":1259462,"node_id":"MDQ6VXNlcjEyNTk0NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1259462?v=4","gravatar_id":"","url":"https://api.github.com/users/boymanjor","html_url":"https://github.com/boymanjor","followers_url":"https://api.github.com/users/boymanjor/followers","following_url":"https://api.github.com/users/boymanjor/following{/other_user}","gists_url":"https://api.github.com/users/boymanjor/gists{/gist_id}","starred_url":"https://api.github.com/users/boymanjor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boymanjor/subscriptions","organizations_url":"https://api.github.com/users/boymanjor/orgs","repos_url":"https://api.github.com/users/boymanjor/repos","events_url":"https://api.github.com/users/boymanjor/events{/privacy}","received_events_url":"https://api.github.com/users/boymanjor/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T20:31:01Z","updated_at":"2018-09-07T20:31:01Z","author_association":"CONTRIBUTOR","body":"Sorry it took a while to get to this. LGTM."}}
{"actor":{"display_login":"boymanjor"}}