{"action":"closed","number":6752,"pull_request":{"url":"https://api.github.com/repos/concrete5/concrete5/pulls/6752","id":193787810,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzg3ODEw","html_url":"https://github.com/concrete5/concrete5/pull/6752","diff_url":"https://github.com/concrete5/concrete5/pull/6752.diff","patch_url":"https://github.com/concrete5/concrete5/pull/6752.patch","issue_url":"https://api.github.com/repos/concrete5/concrete5/issues/6752","number":6752,"state":"closed","locked":false,"title":"Add FileFolder::getChildFolderByName and FileFolder::getChildFolderByPath","user":{"login":"mlocati","id":928116,"node_id":"MDQ6VXNlcjkyODExNg==","avatar_url":"https://avatars3.githubusercontent.com/u/928116?v=4","gravatar_id":"","url":"https://api.github.com/users/mlocati","html_url":"https://github.com/mlocati","followers_url":"https://api.github.com/users/mlocati/followers","following_url":"https://api.github.com/users/mlocati/following{/other_user}","gists_url":"https://api.github.com/users/mlocati/gists{/gist_id}","starred_url":"https://api.github.com/users/mlocati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlocati/subscriptions","organizations_url":"https://api.github.com/users/mlocati/orgs","repos_url":"https://api.github.com/users/mlocati/repos","events_url":"https://api.github.com/users/mlocati/events{/privacy}","received_events_url":"https://api.github.com/users/mlocati/received_events","type":"User","site_admin":false},"body":"Here's what we discussed in #6672, with a handy addition: the ability to create folders if they don't exist (plus some phpdocs and [this](https://github.com/concrete5/concrete5/commit/1dcee2fe1cc162acfe13e3697bd020947d8fe285#diff-479422cef7f180fc48e597c997a644ecR564) and [this](https://github.com/concrete5/concrete5/commit/50e92a45043e3668f7eccab5c39cbc831e517764) bug fixes).\r\n\r\nOne question about [this line](https://github.com/concrete5/concrete5/commit/8c63a1d317d1703ffd63f4a4d1d14aad1f5f501a#diff-65eeada9ffd75ac1f9142813fa390018R112): it works, but is it ok or should we use the `addFolder` method of `Filesystem`?\r\n\r\nPS: fix #6672","created_at":"2018-06-09T17:19:57Z","updated_at":"2018-06-11T16:18:45Z","closed_at":"2018-06-11T16:18:45Z","merged_at":"2018-06-11T16:18:45Z","merge_commit_sha":"2618c8cb83ed77951ae1821fa846e71ba86e3b20","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/concrete5/concrete5/pulls/6752/commits","review_comments_url":"https://api.github.com/repos/concrete5/concrete5/pulls/6752/comments","review_comment_url":"https://api.github.com/repos/concrete5/concrete5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/concrete5/concrete5/issues/6752/comments","statuses_url":"https://api.github.com/repos/concrete5/concrete5/statuses/1c4f62b2522a37eb1a3840fbd35209fe0975beab","head":{"label":"mlocati:improve-node-selection-v2","ref":"improve-node-selection-v2","sha":"1c4f62b2522a37eb1a3840fbd35209fe0975beab","user":{"login":"mlocati","id":928116,"node_id":"MDQ6VXNlcjkyODExNg==","avatar_url":"https://avatars3.githubusercontent.com/u/928116?v=4","gravatar_id":"","url":"https://api.github.com/users/mlocati","html_url":"https://github.com/mlocati","followers_url":"https://api.github.com/users/mlocati/followers","following_url":"https://api.github.com/users/mlocati/following{/other_user}","gists_url":"https://api.github.com/users/mlocati/gists{/gist_id}","starred_url":"https://api.github.com/users/mlocati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlocati/subscriptions","organizations_url":"https://api.github.com/users/mlocati/orgs","repos_url":"https://api.github.com/users/mlocati/repos","events_url":"https://api.github.com/users/mlocati/events{/privacy}","received_events_url":"https://api.github.com/users/mlocati/received_events","type":"User","site_admin":false},"repo":{"id":19068220,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA2ODIyMA==","name":"concrete5","full_name":"mlocati/concrete5","owner":{"login":"mlocati","id":928116,"node_id":"MDQ6VXNlcjkyODExNg==","avatar_url":"https://avatars3.githubusercontent.com/u/928116?v=4","gravatar_id":"","url":"https://api.github.com/users/mlocati","html_url":"https://github.com/mlocati","followers_url":"https://api.github.com/users/mlocati/followers","following_url":"https://api.github.com/users/mlocati/following{/other_user}","gists_url":"https://api.github.com/users/mlocati/gists{/gist_id}","starred_url":"https://api.github.com/users/mlocati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlocati/subscriptions","organizations_url":"https://api.github.com/users/mlocati/orgs","repos_url":"https://api.github.com/users/mlocati/repos","events_url":"https://api.github.com/users/mlocati/events{/privacy}","received_events_url":"https://api.github.com/users/mlocati/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlocati/concrete5","description":"My development fork of concrete5","fork":true,"url":"https://api.github.com/repos/mlocati/concrete5","forks_url":"https://api.github.com/repos/mlocati/concrete5/forks","keys_url":"https://api.github.com/repos/mlocati/concrete5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlocati/concrete5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlocati/concrete5/teams","hooks_url":"https://api.github.com/repos/mlocati/concrete5/hooks","issue_events_url":"https://api.github.com/repos/mlocati/concrete5/issues/events{/number}","events_url":"https://api.github.com/repos/mlocati/concrete5/events","assignees_url":"https://api.github.com/repos/mlocati/concrete5/assignees{/user}","branches_url":"https://api.github.com/repos/mlocati/concrete5/branches{/branch}","tags_url":"https://api.github.com/repos/mlocati/concrete5/tags","blobs_url":"https://api.github.com/repos/mlocati/concrete5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlocati/concrete5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlocati/concrete5/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlocati/concrete5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlocati/concrete5/statuses/{sha}","languages_url":"https://api.github.com/repos/mlocati/concrete5/languages","stargazers_url":"https://api.github.com/repos/mlocati/concrete5/stargazers","contributors_url":"https://api.github.com/repos/mlocati/concrete5/contributors","subscribers_url":"https://api.github.com/repos/mlocati/concrete5/subscribers","subscription_url":"https://api.github.com/repos/mlocati/concrete5/subscription","commits_url":"https://api.github.com/repos/mlocati/concrete5/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlocati/concrete5/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlocati/concrete5/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlocati/concrete5/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlocati/concrete5/contents/{+path}","compare_url":"https://api.github.com/repos/mlocati/concrete5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlocati/concrete5/merges","archive_url":"https://api.github.com/repos/mlocati/concrete5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlocati/concrete5/downloads","issues_url":"https://api.github.com/repos/mlocati/concrete5/issues{/number}","pulls_url":"https://api.github.com/repos/mlocati/concrete5/pulls{/number}","milestones_url":"https://api.github.com/repos/mlocati/concrete5/milestones{/number}","notifications_url":"https://api.github.com/repos/mlocati/concrete5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlocati/concrete5/labels{/name}","releases_url":"https://api.github.com/repos/mlocati/concrete5/releases{/id}","deployments_url":"https://api.github.com/repos/mlocati/concrete5/deployments","created_at":"2014-04-23T12:09:20Z","updated_at":"2018-06-11T09:48:01Z","pushed_at":"2018-06-11T16:16:52Z","git_url":"git://github.com/mlocati/concrete5.git","ssh_url":"git@github.com:mlocati/concrete5.git","clone_url":"https://github.com/mlocati/concrete5.git","svn_url":"https://github.com/mlocati/concrete5","homepage":"https://github.com/concrete5/concrete5","size":107322,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"concrete5:develop","ref":"develop","sha":"6cae1890a4574171ea04ec68a856d46b377c5ebb","user":{"login":"concrete5","id":657929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzkyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/657929?v=4","gravatar_id":"","url":"https://api.github.com/users/concrete5","html_url":"https://github.com/concrete5","followers_url":"https://api.github.com/users/concrete5/followers","following_url":"https://api.github.com/users/concrete5/following{/other_user}","gists_url":"https://api.github.com/users/concrete5/gists{/gist_id}","starred_url":"https://api.github.com/users/concrete5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concrete5/subscriptions","organizations_url":"https://api.github.com/users/concrete5/orgs","repos_url":"https://api.github.com/users/concrete5/repos","events_url":"https://api.github.com/users/concrete5/events{/privacy}","received_events_url":"https://api.github.com/users/concrete5/received_events","type":"Organization","site_admin":false},"repo":{"id":19040482,"node_id":"MDEwOlJlcG9zaXRvcnkxOTA0MDQ4Mg==","name":"concrete5","full_name":"concrete5/concrete5","owner":{"login":"concrete5","id":657929,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY1NzkyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/657929?v=4","gravatar_id":"","url":"https://api.github.com/users/concrete5","html_url":"https://github.com/concrete5","followers_url":"https://api.github.com/users/concrete5/followers","following_url":"https://api.github.com/users/concrete5/following{/other_user}","gists_url":"https://api.github.com/users/concrete5/gists{/gist_id}","starred_url":"https://api.github.com/users/concrete5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concrete5/subscriptions","organizations_url":"https://api.github.com/users/concrete5/orgs","repos_url":"https://api.github.com/users/concrete5/repos","events_url":"https://api.github.com/users/concrete5/events{/privacy}","received_events_url":"https://api.github.com/users/concrete5/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/concrete5/concrete5","description":"Official repository for concrete5 development","fork":false,"url":"https://api.github.com/repos/concrete5/concrete5","forks_url":"https://api.github.com/repos/concrete5/concrete5/forks","keys_url":"https://api.github.com/repos/concrete5/concrete5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concrete5/concrete5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concrete5/concrete5/teams","hooks_url":"https://api.github.com/repos/concrete5/concrete5/hooks","issue_events_url":"https://api.github.com/repos/concrete5/concrete5/issues/events{/number}","events_url":"https://api.github.com/repos/concrete5/concrete5/events","assignees_url":"https://api.github.com/repos/concrete5/concrete5/assignees{/user}","branches_url":"https://api.github.com/repos/concrete5/concrete5/branches{/branch}","tags_url":"https://api.github.com/repos/concrete5/concrete5/tags","blobs_url":"https://api.github.com/repos/concrete5/concrete5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concrete5/concrete5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concrete5/concrete5/git/refs{/sha}","trees_url":"https://api.github.com/repos/concrete5/concrete5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concrete5/concrete5/statuses/{sha}","languages_url":"https://api.github.com/repos/concrete5/concrete5/languages","stargazers_url":"https://api.github.com/repos/concrete5/concrete5/stargazers","contributors_url":"https://api.github.com/repos/concrete5/concrete5/contributors","subscribers_url":"https://api.github.com/repos/concrete5/concrete5/subscribers","subscription_url":"https://api.github.com/repos/concrete5/concrete5/subscription","commits_url":"https://api.github.com/repos/concrete5/concrete5/commits{/sha}","git_commits_url":"https://api.github.com/repos/concrete5/concrete5/git/commits{/sha}","comments_url":"https://api.github.com/repos/concrete5/concrete5/comments{/number}","issue_comment_url":"https://api.github.com/repos/concrete5/concrete5/issues/comments{/number}","contents_url":"https://api.github.com/repos/concrete5/concrete5/contents/{+path}","compare_url":"https://api.github.com/repos/concrete5/concrete5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concrete5/concrete5/merges","archive_url":"https://api.github.com/repos/concrete5/concrete5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concrete5/concrete5/downloads","issues_url":"https://api.github.com/repos/concrete5/concrete5/issues{/number}","pulls_url":"https://api.github.com/repos/concrete5/concrete5/pulls{/number}","milestones_url":"https://api.github.com/repos/concrete5/concrete5/milestones{/number}","notifications_url":"https://api.github.com/repos/concrete5/concrete5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concrete5/concrete5/labels{/name}","releases_url":"https://api.github.com/repos/concrete5/concrete5/releases{/id}","deployments_url":"https://api.github.com/repos/concrete5/concrete5/deployments","created_at":"2014-04-22T18:12:28Z","updated_at":"2018-06-11T16:15:00Z","pushed_at":"2018-06-11T16:18:44Z","git_url":"git://github.com/concrete5/concrete5.git","ssh_url":"git@github.com:concrete5/concrete5.git","clone_url":"https://github.com/concrete5/concrete5.git","svn_url":"https://github.com/concrete5/concrete5","homepage":"https://www.concrete5.org","size":99429,"stargazers_count":459,"watchers_count":459,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":347,"mirror_url":null,"archived":false,"open_issues_count":644,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":347,"open_issues":644,"watchers":459,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/6752"},"html":{"href":"https://github.com/concrete5/concrete5/pull/6752"},"issue":{"href":"https://api.github.com/repos/concrete5/concrete5/issues/6752"},"comments":{"href":"https://api.github.com/repos/concrete5/concrete5/issues/6752/comments"},"review_comments":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/6752/comments"},"review_comment":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/concrete5/concrete5/pulls/6752/commits"},"statuses":{"href":"https://api.github.com/repos/concrete5/concrete5/statuses/1c4f62b2522a37eb1a3840fbd35209fe0975beab"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"aembler","id":527809,"node_id":"MDQ6VXNlcjUyNzgwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/527809?v=4","gravatar_id":"","url":"https://api.github.com/users/aembler","html_url":"https://github.com/aembler","followers_url":"https://api.github.com/users/aembler/followers","following_url":"https://api.github.com/users/aembler/following{/other_user}","gists_url":"https://api.github.com/users/aembler/gists{/gist_id}","starred_url":"https://api.github.com/users/aembler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aembler/subscriptions","organizations_url":"https://api.github.com/users/aembler/orgs","repos_url":"https://api.github.com/users/aembler/repos","events_url":"https://api.github.com/users/aembler/events{/privacy}","received_events_url":"https://api.github.com/users/aembler/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":15,"additions":280,"deletions":128,"changed_files":6}}
{"actor":{"display_login":"aembler"}}