{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/14620","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/14620/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/14620/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/14620/events","html_url":"https://github.com/highfidelity/hifi/pull/14620","id":392805111,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5OTk2NTg5","number":14620,"title":"VIVE can now auto-detect hmd and desktop modes","user":{"login":"amantley","id":22531620,"node_id":"MDQ6VXNlcjIyNTMxNjIw","avatar_url":"https://avatars0.githubusercontent.com/u/22531620?v=4","gravatar_id":"","url":"https://api.github.com/users/amantley","html_url":"https://github.com/amantley","followers_url":"https://api.github.com/users/amantley/followers","following_url":"https://api.github.com/users/amantley/following{/other_user}","gists_url":"https://api.github.com/users/amantley/gists{/gist_id}","starred_url":"https://api.github.com/users/amantley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amantley/subscriptions","organizations_url":"https://api.github.com/users/amantley/orgs","repos_url":"https://api.github.com/users/amantley/repos","events_url":"https://api.github.com/users/amantley/events{/privacy}","received_events_url":"https://api.github.com/users/amantley/received_events","type":"User","site_admin":false},"labels":[{"id":837498945,"node_id":"MDU6TGFiZWw4Mzc0OTg5NDU=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Avatar","name":"Avatar","color":"fcc4dc","default":false},{"id":314155368,"node_id":"MDU6TGFiZWwzMTQxNTUzNjg=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Development%20Approved","name":"Development Approved","color":"009800","default":false},{"id":461634431,"node_id":"MDU6TGFiZWw0NjE2MzQ0MzE=","url":"https://api.github.com/repos/highfidelity/hifi/labels/HMD%20required","name":"HMD required","color":"d4c5f9","default":false},{"id":313595519,"node_id":"MDU6TGFiZWwzMTM1OTU1MTk=","url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Ready","name":"QA Ready","color":"bfd4f2","default":false},{"id":461634652,"node_id":"MDU6TGFiZWw0NjE2MzQ2NTI=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Vive%20Required","name":"Vive Required","color":"d4c5f9","default":false},{"id":11332862,"node_id":"MDU6TGFiZWwxMTMzMjg2Mg==","url":"https://api.github.com/repos/highfidelity/hifi/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":{"login":"amantley","id":22531620,"node_id":"MDQ6VXNlcjIyNTMxNjIw","avatar_url":"https://avatars0.githubusercontent.com/u/22531620?v=4","gravatar_id":"","url":"https://api.github.com/users/amantley","html_url":"https://github.com/amantley","followers_url":"https://api.github.com/users/amantley/followers","following_url":"https://api.github.com/users/amantley/following{/other_user}","gists_url":"https://api.github.com/users/amantley/gists{/gist_id}","starred_url":"https://api.github.com/users/amantley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amantley/subscriptions","organizations_url":"https://api.github.com/users/amantley/orgs","repos_url":"https://api.github.com/users/amantley/repos","events_url":"https://api.github.com/users/amantley/events{/privacy}","received_events_url":"https://api.github.com/users/amantley/received_events","type":"User","site_admin":false},"assignees":[{"login":"amantley","id":22531620,"node_id":"MDQ6VXNlcjIyNTMxNjIw","avatar_url":"https://avatars0.githubusercontent.com/u/22531620?v=4","gravatar_id":"","url":"https://api.github.com/users/amantley","html_url":"https://github.com/amantley","followers_url":"https://api.github.com/users/amantley/followers","following_url":"https://api.github.com/users/amantley/following{/other_user}","gists_url":"https://api.github.com/users/amantley/gists{/gist_id}","starred_url":"https://api.github.com/users/amantley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amantley/subscriptions","organizations_url":"https://api.github.com/users/amantley/orgs","repos_url":"https://api.github.com/users/amantley/repos","events_url":"https://api.github.com/users/amantley/events{/privacy}","received_events_url":"https://api.github.com/users/amantley/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/38","html_url":"https://github.com/highfidelity/hifi/milestone/38","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/38/labels","id":3290838,"node_id":"MDk6TWlsZXN0b25lMzI5MDgzOA==","number":38,"title":"v0.78.0","description":"","creator":{"login":"conklin94122","id":12115653,"node_id":"MDQ6VXNlcjEyMTE1NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/12115653?v=4","gravatar_id":"","url":"https://api.github.com/users/conklin94122","html_url":"https://github.com/conklin94122","followers_url":"https://api.github.com/users/conklin94122/followers","following_url":"https://api.github.com/users/conklin94122/following{/other_user}","gists_url":"https://api.github.com/users/conklin94122/gists{/gist_id}","starred_url":"https://api.github.com/users/conklin94122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklin94122/subscriptions","organizations_url":"https://api.github.com/users/conklin94122/orgs","repos_url":"https://api.github.com/users/conklin94122/repos","events_url":"https://api.github.com/users/conklin94122/events{/privacy}","received_events_url":"https://api.github.com/users/conklin94122/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":22,"state":"open","created_at":"2018-04-23T19:27:30Z","updated_at":"2018-12-20T00:40:36Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2018-12-19T22:38:09Z","updated_at":"2018-12-20T01:33:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/14620","html_url":"https://github.com/highfidelity/hifi/pull/14620","diff_url":"https://github.com/highfidelity/hifi/pull/14620.diff","patch_url":"https://github.com/highfidelity/hifi/pull/14620.patch"},"body":"This pr addresses case https://highfidelity.manuscript.com/f/cases/20245 where users head is disturbing when taking off the headset in hmd mode.\r\n\r\n### Test Plan.\r\n1) Start Interface and put on the VIVE headset.  You should automatically go to VR mode.  Go to 3rd person view and verify that IK works as normal in head and hands.\r\n2) Take off the headset and you should switch to desktop mode automatically.  Verify that animations play as normal on the avatar.\r\n3) Calibrate pucks for head, feet with controllers for hands. The VIVE HMD is attached but not used for tracking. When the calibration succeeds you should see that the avatar head moves as you would expect.\r\n4) Disconnect the VIVE and connect the Oculus Rift and verify that auto switching between HMD mode and desktop takes places as normal.  \r\n"},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/448825815","html_url":"https://github.com/highfidelity/hifi/pull/14620#issuecomment-448825815","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/14620","id":448825815,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODgyNTgxNQ==","user":{"login":"qlimguicheteau","id":39308773,"node_id":"MDQ6VXNlcjM5MzA4Nzcz","avatar_url":"https://avatars1.githubusercontent.com/u/39308773?v=4","gravatar_id":"","url":"https://api.github.com/users/qlimguicheteau","html_url":"https://github.com/qlimguicheteau","followers_url":"https://api.github.com/users/qlimguicheteau/followers","following_url":"https://api.github.com/users/qlimguicheteau/following{/other_user}","gists_url":"https://api.github.com/users/qlimguicheteau/gists{/gist_id}","starred_url":"https://api.github.com/users/qlimguicheteau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qlimguicheteau/subscriptions","organizations_url":"https://api.github.com/users/qlimguicheteau/orgs","repos_url":"https://api.github.com/users/qlimguicheteau/repos","events_url":"https://api.github.com/users/qlimguicheteau/events{/privacy}","received_events_url":"https://api.github.com/users/qlimguicheteau/received_events","type":"User","site_admin":false},"created_at":"2018-12-20T01:33:15Z","updated_at":"2018-12-20T01:33:15Z","author_association":"NONE","body":"Testing Paused\r\n\r\n\r\n???\r\n--\r\nOn startup if the pucks are enabled, they can be injected in place of the controllers. There seems to be nothing to validate whether the tracker is actually a puck or a controller.\r\n\r\nThis strange attachment is also found in Master, so it does not come from this PR, however it blocks the calibration of devices outside of \"Desktop Mode\". \r\n![pucks instead of controllers](https://user-images.githubusercontent.com/39308773/50257319-0e485d00-03b8-11e9-8920-bf86fac10f59.png)\r\n\r\nHead Puck will not work unless \"use in Desktop Mode\" is active, this disables the tracking of the \r\nheadset making observation not possible without assistance.\r\n\r\n1- Pass- Head and hand IK work as expected when they do not have a puck injected into their feed.\r\n2- Pass- Switching effect happens properly.\r\n3- Pass- Pucks track in \"Use in Desktop mode\" with the headset plugged in.\r\n4- Not tested yet.\r\n\r\nNote:  This will probably be hated by livestreamers who do stunts with their headset. Or they will tape over the sensor so it cannot activate."}}
{"actor":{"display_login":"qlimguicheteau"}}